{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/1","id":66801527,"html_url":"https://github.com/serilog/serilog-sinks-periodicbatching/pull/1","diff_url":"https://github.com/serilog/serilog-sinks-periodicbatching/pull/1.diff","patch_url":"https://github.com/serilog/serilog-sinks-periodicbatching/pull/1.patch","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/1","number":1,"state":"closed","locked":false,"title":"Fixes 718 in the 2.0 code by removing appdomain hooks","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"body":"Proposed fix for #718 in the 2.0 codebase: removes broken `AppDomain` shutdown hooks from `PeriodicBatchingSink`.\r\n\r\nBecause these are not available under .NET Core, they can't be relied on in Serilog 2 anyway, so all code should shut down the logger by calling either `Log.CloseAndFlush()` or disposing the logging pipeline manually.\r\n\r\nAnother 2.0 PR coming which will (finally) make the return type of `LoggerConfiguration.CreateLogger()` disposable so that the contract is more clearly visible.\r\n\r\nPing @merbla @khellang thoughts?","created_at":"2016-04-18T05:46:12Z","updated_at":"2016-04-20T03:59:58Z","closed_at":"2016-04-20T03:59:58Z","merged_at":"2016-04-20T03:59:58Z","merge_commit_sha":"dd7cb28e997c59d99dbb9161f133ed80119bef85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/1/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/1/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/1/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/statuses/667573e83c38a1a84f742afe8011c262f4171555","head":{"label":"nblumhardt:master","ref":"master","sha":"667573e83c38a1a84f742afe8011c262f4171555","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"repo":{"id":56480020,"name":"serilog-sinks-periodicbatching","full_name":"nblumhardt/serilog-sinks-periodicbatching","owner":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nblumhardt/serilog-sinks-periodicbatching","description":"The periodic batching sink for Serilog","fork":true,"url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching","forks_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/forks","keys_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/teams","hooks_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/hooks","issue_events_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/issues/events{/number}","events_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/events","assignees_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/assignees{/user}","branches_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/branches{/branch}","tags_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/tags","blobs_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/git/refs{/sha}","trees_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/statuses/{sha}","languages_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/languages","stargazers_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/stargazers","contributors_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/contributors","subscribers_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/subscribers","subscription_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/subscription","commits_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/commits{/sha}","git_commits_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/git/commits{/sha}","comments_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/comments{/number}","issue_comment_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/issues/comments{/number}","contents_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/contents/{+path}","compare_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/merges","archive_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/downloads","issues_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/issues{/number}","pulls_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/pulls{/number}","milestones_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/milestones{/number}","notifications_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/labels{/name}","releases_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/releases{/id}","deployments_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-periodicbatching/deployments","created_at":"2016-04-18T05:39:04Z","updated_at":"2016-04-18T05:39:06Z","pushed_at":"2016-04-18T05:43:30Z","git_url":"git://github.com/nblumhardt/serilog-sinks-periodicbatching.git","ssh_url":"git@github.com:nblumhardt/serilog-sinks-periodicbatching.git","clone_url":"https://github.com/nblumhardt/serilog-sinks-periodicbatching.git","svn_url":"https://github.com/nblumhardt/serilog-sinks-periodicbatching","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serilog:master","ref":"master","sha":"4a6f9c84b6c930ba24355d42cc9540da67ad1e84","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":53472596,"name":"serilog-sinks-periodicbatching","full_name":"serilog/serilog-sinks-periodicbatching","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-sinks-periodicbatching","description":"The periodic batching sink for Serilog","fork":false,"url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching","forks_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/forks","keys_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/events","assignees_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/merges","archive_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/deployments","created_at":"2016-03-09T06:02:17Z","updated_at":"2016-04-18T05:39:02Z","pushed_at":"2016-04-20T03:59:59Z","git_url":"git://github.com/serilog/serilog-sinks-periodicbatching.git","ssh_url":"git@github.com:serilog/serilog-sinks-periodicbatching.git","clone_url":"https://github.com/serilog/serilog-sinks-periodicbatching.git","svn_url":"https://github.com/serilog/serilog-sinks-periodicbatching","homepage":null,"size":27,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/1"},"html":{"href":"https://github.com/serilog/serilog-sinks-periodicbatching/pull/1"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/1"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-sinks-periodicbatching/statuses/667573e83c38a1a84f742afe8011c262f4171555"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":4,"deletions":27,"changed_files":3}}