{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8861","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8861/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8861/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8861/events","html_url":"https://github.com/nodejs/node/pull/8861","id":180315731,"number":8861,"title":"build: make addons build  dep. on node_version.h","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/addons","name":"addons","color":"ededed"},{"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v4.x","name":"lts-watch-v4.x","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099"}],"state":"open","locked":false,"assignee":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"assignees":[{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-30T14:19:55Z","updated_at":"2016-10-05T22:00:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8861","html_url":"https://github.com/nodejs/node/pull/8861","diff_url":"https://github.com/nodejs/node/pull/8861.diff","patch_url":"https://github.com/nodejs/node/pull/8861.patch"},"body":"##### Checklist\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\naddon tests\r\n\r\n##### Description of change\r\n\r\nMake the `test/addons/.buildstamp` file dependent on `src/node_version.h` since addons need to be re-compiled after `NODE_MODULE_VERSION` bumps, e.g. as it happened recently in b5bdff876ba62ed58664eb011a863d0960f4089b."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/251812320","html_url":"https://github.com/nodejs/node/pull/8861#issuecomment-251812320","issue_url":"https://api.github.com/repos/nodejs/node/issues/8861","id":251812320,"user":{"login":"imyller","id":1898870,"avatar_url":"https://avatars.githubusercontent.com/u/1898870?v=3","gravatar_id":"","url":"https://api.github.com/users/imyller","html_url":"https://github.com/imyller","followers_url":"https://api.github.com/users/imyller/followers","following_url":"https://api.github.com/users/imyller/following{/other_user}","gists_url":"https://api.github.com/users/imyller/gists{/gist_id}","starred_url":"https://api.github.com/users/imyller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imyller/subscriptions","organizations_url":"https://api.github.com/users/imyller/orgs","repos_url":"https://api.github.com/users/imyller/repos","events_url":"https://api.github.com/users/imyller/events{/privacy}","received_events_url":"https://api.github.com/users/imyller/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T22:00:25Z","updated_at":"2016-10-05T22:00:25Z","body":"Landing:\r\n - [x] Approvals (LGTM): 3\r\n - [x] No objections\r\n - [x] PR has been open for the minimum time of 48 or 72 hours \r\n - [x] CI tests passed (only known/unrelated failures)"}}
{"actor":{"display_login":"imyller"}}