{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/66813531","id":66813531,"diff_hunk":"@@ -2519,15 +2519,24 @@ void RGWPutObj::execute()\n   }\n \n   do {\n-    bufferlist data;\n-    len = get_data(data);\n+    bufferlist data_in;\n+    len = get_data(data_in);\n     if (len < 0) {\n       op_ret = len;\n       goto done;\n     }\n     if (!len)\n       break;\n \n+    bufferlist data;","path":"src/rgw/rgw_op.cc","position":15,"original_position":15,"commit_id":"5de5876a535537f7878615898bb9cf7887204cb1","original_commit_id":"5de5876a535537f7878615898bb9cf7887204cb1","user":{"login":"mattbenjamin","id":301287,"avatar_url":"https://avatars.githubusercontent.com/u/301287?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},"body":"This induces buffer sharing.  Would we get the same result if data were a pointer to data_in or s->aws_auth->bl (saving the atomic ops to attach each buffer::ptr)?","created_at":"2016-06-13T15:32:06Z","updated_at":"2016-06-13T15:32:06Z","html_url":"https://github.com/ceph/ceph/pull/9484#discussion_r66813531","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9484","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/66813531"},"html":{"href":"https://github.com/ceph/ceph/pull/9484#discussion_r66813531"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9484"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9484","id":72527643,"html_url":"https://github.com/ceph/ceph/pull/9484","diff_url":"https://github.com/ceph/ceph/pull/9484.diff","patch_url":"https://github.com/ceph/ceph/pull/9484.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9484","number":9484,"state":"open","locked":false,"title":"rgw: aws4: add STREAMING-AWS4-HMAC-SHA256-PAYLOAD support","user":{"login":"jmunhoz","id":6533548,"avatar_url":"https://avatars.githubusercontent.com/u/6533548?v=3","gravatar_id":"","url":"https://api.github.com/users/jmunhoz","html_url":"https://github.com/jmunhoz","followers_url":"https://api.github.com/users/jmunhoz/followers","following_url":"https://api.github.com/users/jmunhoz/following{/other_user}","gists_url":"https://api.github.com/users/jmunhoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmunhoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmunhoz/subscriptions","organizations_url":"https://api.github.com/users/jmunhoz/orgs","repos_url":"https://api.github.com/users/jmunhoz/repos","events_url":"https://api.github.com/users/jmunhoz/events{/privacy}","received_events_url":"https://api.github.com/users/jmunhoz/received_events","type":"User","site_admin":false},"body":"When authenticating requests using the Authorization header in AWS4, you have\r\nthe option of uploading the payload in chunks. You can send data in fixed size\r\nor variable size chunks.\r\n\r\nThis patch enables streaming mode and signed headers support with chunked\r\nuploads.\r\n\r\nFixes: http://tracker.ceph.com/issues/16146\r\n\r\nSigned-off-by: Javier M. Mellid <jmunhoz@igalia.com>","created_at":"2016-06-03T15:42:08Z","updated_at":"2016-06-13T15:32:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12b9818518f2de3a0dc850c1d5fed2a3682dce96","assignee":{"login":"mattbenjamin","id":301287,"avatar_url":"https://avatars.githubusercontent.com/u/301287?v=3","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9484/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9484/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9484/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/5de5876a535537f7878615898bb9cf7887204cb1","head":{"label":"jmunhoz:aws4-streaming","ref":"aws4-streaming","sha":"5de5876a535537f7878615898bb9cf7887204cb1","user":{"login":"jmunhoz","id":6533548,"avatar_url":"https://avatars.githubusercontent.com/u/6533548?v=3","gravatar_id":"","url":"https://api.github.com/users/jmunhoz","html_url":"https://github.com/jmunhoz","followers_url":"https://api.github.com/users/jmunhoz/followers","following_url":"https://api.github.com/users/jmunhoz/following{/other_user}","gists_url":"https://api.github.com/users/jmunhoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmunhoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmunhoz/subscriptions","organizations_url":"https://api.github.com/users/jmunhoz/orgs","repos_url":"https://api.github.com/users/jmunhoz/repos","events_url":"https://api.github.com/users/jmunhoz/events{/privacy}","received_events_url":"https://api.github.com/users/jmunhoz/received_events","type":"User","site_admin":false},"repo":{"id":35660953,"name":"ceph","full_name":"jmunhoz/ceph","owner":{"login":"jmunhoz","id":6533548,"avatar_url":"https://avatars.githubusercontent.com/u/6533548?v=3","gravatar_id":"","url":"https://api.github.com/users/jmunhoz","html_url":"https://github.com/jmunhoz","followers_url":"https://api.github.com/users/jmunhoz/followers","following_url":"https://api.github.com/users/jmunhoz/following{/other_user}","gists_url":"https://api.github.com/users/jmunhoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmunhoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmunhoz/subscriptions","organizations_url":"https://api.github.com/users/jmunhoz/orgs","repos_url":"https://api.github.com/users/jmunhoz/repos","events_url":"https://api.github.com/users/jmunhoz/events{/privacy}","received_events_url":"https://api.github.com/users/jmunhoz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmunhoz/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/jmunhoz/ceph","forks_url":"https://api.github.com/repos/jmunhoz/ceph/forks","keys_url":"https://api.github.com/repos/jmunhoz/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmunhoz/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmunhoz/ceph/teams","hooks_url":"https://api.github.com/repos/jmunhoz/ceph/hooks","issue_events_url":"https://api.github.com/repos/jmunhoz/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/jmunhoz/ceph/events","assignees_url":"https://api.github.com/repos/jmunhoz/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/jmunhoz/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/jmunhoz/ceph/tags","blobs_url":"https://api.github.com/repos/jmunhoz/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmunhoz/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmunhoz/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmunhoz/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmunhoz/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/jmunhoz/ceph/languages","stargazers_url":"https://api.github.com/repos/jmunhoz/ceph/stargazers","contributors_url":"https://api.github.com/repos/jmunhoz/ceph/contributors","subscribers_url":"https://api.github.com/repos/jmunhoz/ceph/subscribers","subscription_url":"https://api.github.com/repos/jmunhoz/ceph/subscription","commits_url":"https://api.github.com/repos/jmunhoz/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmunhoz/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmunhoz/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmunhoz/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmunhoz/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/jmunhoz/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmunhoz/ceph/merges","archive_url":"https://api.github.com/repos/jmunhoz/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmunhoz/ceph/downloads","issues_url":"https://api.github.com/repos/jmunhoz/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/jmunhoz/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/jmunhoz/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/jmunhoz/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmunhoz/ceph/labels{/name}","releases_url":"https://api.github.com/repos/jmunhoz/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/jmunhoz/ceph/deployments","created_at":"2015-05-15T07:47:41Z","updated_at":"2016-02-20T17:54:10Z","pushed_at":"2016-06-03T15:38:46Z","git_url":"git://github.com/jmunhoz/ceph.git","ssh_url":"git@github.com:jmunhoz/ceph.git","clone_url":"https://github.com/jmunhoz/ceph.git","svn_url":"https://github.com/jmunhoz/ceph","homepage":"http://ceph.com","size":157621,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"7abda15aa5723e0cd251a477a183a6295926f082","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-06-13T03:59:48Z","pushed_at":"2016-06-13T15:21:05Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":218488,"stargazers_count":2230,"watchers_count":2230,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1319,"mirror_url":null,"open_issues_count":378,"forks":1319,"open_issues":378,"watchers":2230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9484"},"html":{"href":"https://github.com/ceph/ceph/pull/9484"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9484"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9484/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9484/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9484/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/5de5876a535537f7878615898bb9cf7887204cb1"}}}}
{"actor":{"display_login":"mattbenjamin"}}