{"action":"created","issue":{"url":"https://api.github.com/repos/koreader/koreader/issues/630","repository_url":"https://api.github.com/repos/koreader/koreader","labels_url":"https://api.github.com/repos/koreader/koreader/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/koreader/koreader/issues/630/comments","events_url":"https://api.github.com/repos/koreader/koreader/issues/630/events","html_url":"https://github.com/koreader/koreader/issues/630","id":35033110,"number":630,"title":"Kobo Touch Mark3 has trouble turning a page with tapping.","user":{"login":"Markismus","id":5269101,"avatar_url":"https://avatars.githubusercontent.com/u/5269101?v=3","gravatar_id":"","url":"https://api.github.com/users/Markismus","html_url":"https://github.com/Markismus","followers_url":"https://api.github.com/users/Markismus/followers","following_url":"https://api.github.com/users/Markismus/following{/other_user}","gists_url":"https://api.github.com/users/Markismus/gists{/gist_id}","starred_url":"https://api.github.com/users/Markismus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Markismus/subscriptions","organizations_url":"https://api.github.com/users/Markismus/orgs","repos_url":"https://api.github.com/users/Markismus/repos","events_url":"https://api.github.com/users/Markismus/events{/privacy}","received_events_url":"https://api.github.com/users/Markismus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/koreader/koreader/labels/Kobo","name":"Kobo","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":42,"created_at":"2014-06-05T07:25:41Z","updated_at":"2016-06-05T21:18:15Z","closed_at":"2014-10-08T09:15:10Z","body":"[On mobileread simonchik](http://www.mobileread.com/forums/showthread.php?p=2842283#post2842283) has posted his problem with installing koreader on the older Mark 3 Kobo Touch. \r\nHe has done extensive testing and apparently he has a different hardware from other Mark 3 owners [such as tshering](http://www.mobileread.com/forums/showthread.php?p=2843886#post2843886) or a different way of touching the screen.\r\n\r\nBecause it is a nice case study and the Kobo Aura is also not behaving quite as you would like, we have delved into `gesturedetector.lua` and try to find a way to make it work for his hardware. First we'll try to change the parameters in `GestureDetector`.\r\n\r\nLatest post by simonchik:\r\n@markismus: about versions that 'work' on my kobo, I now have a clearer idea about what's happening: if I put my finger on the screen, I get \r\n```\r\n# tev fed| 558 | 291854 | 342 | 307 | 1 | Evt 0\r\n# in tap state...\r\n# set up hold timer\r\n# hold gesture detected in slot 0\r\n# in hold state...\r\n# tev fed| 558 | 405127 | 341 | 307 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 558 | 504107 | 341 | 308 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 558 | 688109 | 340 | 309 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 558 | 872074 | 339 | 309 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 559 | 27735 | 339 | 310 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 559 | 225903 | 338 | 311 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 559 | 749673 | 337 | 311 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 560 | 4570 | 337 | 309 | 1 | Evt 0\r\n# in hold state...\r\n# tev fed| 560 | 13418 | 337 | 309 | -1 | Evt 0\r\n# in hold state...\r\n# hold_release detected in slot 0\r\n```\r\nwhich means that tev is populated with touch events from very close coordinates, as if I were moving my finger, except I'm not. There is no multitouch, no \"two finger-tap\" and so on, so I think the best think would be to put a threshold, like 5 points or so on this device, below which a touch event on hold state would be discarded?"},"comment":{"url":"https://api.github.com/repos/koreader/koreader/issues/comments/223838275","html_url":"https://github.com/koreader/koreader/issues/630#issuecomment-223838275","issue_url":"https://api.github.com/repos/koreader/koreader/issues/630","id":223838275,"user":{"login":"houqp","id":670302,"avatar_url":"https://avatars.githubusercontent.com/u/670302?v=3","gravatar_id":"","url":"https://api.github.com/users/houqp","html_url":"https://github.com/houqp","followers_url":"https://api.github.com/users/houqp/followers","following_url":"https://api.github.com/users/houqp/following{/other_user}","gists_url":"https://api.github.com/users/houqp/gists{/gist_id}","starred_url":"https://api.github.com/users/houqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houqp/subscriptions","organizations_url":"https://api.github.com/users/houqp/orgs","repos_url":"https://api.github.com/users/houqp/repos","events_url":"https://api.github.com/users/houqp/events{/privacy}","received_events_url":"https://api.github.com/users/houqp/received_events","type":"User","site_admin":false},"created_at":"2016-06-05T21:18:15Z","updated_at":"2016-06-05T21:18:15Z","body":"> Sorry for taking so long to reply. I tested the last master (861e50c) since it looks like the patch was merged in the meantime. And I can confirm that it works for me, except that I had lots of trouble going past the initial orientation detection screen on a new installation. At first it didn't seem to work at all, even with very quick taps (while koreader correctly displayed its suspend/poweroff screen when I used to on/off button). I tried again after a hard reset, and this time a quick tap did the job.\r\n\r\nBy reset you mean removing the reader setting? You should not need to do quick tap to make it work. If you are still able to reproduce it, feel free to upload the settings here, I will take a look :)\r\n\r\n> Also: perhaps it would be (marginally) more robust to compare the timestamp with now() minus a few seconds than with a fixed date?\r\n\r\nGood point. Except couple seconds might not be enough given the main UI loop might be blocked loading document before handling the event. I set it to 10 minute in: https://github.com/koreader/koreader/pull/2064"}}
{"actor":{"display_login":"houqp"}}