{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/1639","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/1639/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/1639/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/1639/events","html_url":"https://github.com/zulip/zulip/pull/1639","id":171646910,"number":1639,"title":"Cache Node modules in update-prod-static.","user":{"login":"umairwaheed","id":641763,"avatar_url":"https://avatars.githubusercontent.com/u/641763?v=3","gravatar_id":"","url":"https://api.github.com/users/umairwaheed","html_url":"https://github.com/umairwaheed","followers_url":"https://api.github.com/users/umairwaheed/followers","following_url":"https://api.github.com/users/umairwaheed/following{/other_user}","gists_url":"https://api.github.com/users/umairwaheed/gists{/gist_id}","starred_url":"https://api.github.com/users/umairwaheed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umairwaheed/subscriptions","organizations_url":"https://api.github.com/users/umairwaheed/orgs","repos_url":"https://api.github.com/users/umairwaheed/repos","events_url":"https://api.github.com/users/umairwaheed/events{/privacy}","received_events_url":"https://api.github.com/users/umairwaheed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-17T12:37:49Z","updated_at":"2016-08-26T12:42:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/1639","html_url":"https://github.com/zulip/zulip/pull/1639","diff_url":"https://github.com/zulip/zulip/pull/1639.diff","patch_url":"https://github.com/zulip/zulip/pull/1639.patch"},"body":"@timabbott please review"},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/242724911","html_url":"https://github.com/zulip/zulip/pull/1639#issuecomment-242724911","issue_url":"https://api.github.com/repos/zulip/zulip/issues/1639","id":242724911,"user":{"login":"umairwaheed","id":641763,"avatar_url":"https://avatars.githubusercontent.com/u/641763?v=3","gravatar_id":"","url":"https://api.github.com/users/umairwaheed","html_url":"https://github.com/umairwaheed","followers_url":"https://api.github.com/users/umairwaheed/followers","following_url":"https://api.github.com/users/umairwaheed/following{/other_user}","gists_url":"https://api.github.com/users/umairwaheed/gists{/gist_id}","starred_url":"https://api.github.com/users/umairwaheed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umairwaheed/subscriptions","organizations_url":"https://api.github.com/users/umairwaheed/orgs","repos_url":"https://api.github.com/users/umairwaheed/repos","events_url":"https://api.github.com/users/umairwaheed/events{/privacy}","received_events_url":"https://api.github.com/users/umairwaheed/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T12:42:15Z","updated_at":"2016-08-26T12:42:15Z","body":"> The hash key should be based not just on package.json but also on npm --version, node-version, and npm_args, so that we don't mix the two types of NPM installs and handle version upgrades correctly. I think we can just concenate those with package.json.\r\n\r\nThis is done.\r\n\r\n> I think this breaks the build-release-tarball script, since now node_modules isn't part of the tree that we tar up (just the symlink is). This is a bit tricky to solve; we might need to add code to move the relevant npm cache data into the tarball and then code to upgrade-zulip-stage-2 (the part that runs using code from the to-be-installed release) to move the npm cache data out of the tarball and into /srv/npm-cache on the server we're deploying to.\r\n\r\nI think we can use `--dereference` option of `tar` command to dereference the symlinks."}}
{"actor":{"display_login":"umairwaheed"}}