{"action":"created","comment":{"url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/comments/77353713","id":77353713,"diff_hunk":"@@ -23,6 +23,19 @@\n #define HEX_CHAR_TO_NIBBLE(c) ((c >= 'A') ? (c - 'A' + 0x0A) : (c - '0'))\n #define HEX_PAIR_TO_BYTE(h, l) ((HEX_CHAR_TO_NIBBLE(h) << 4) + HEX_CHAR_TO_NIBBLE(l))\n \n+/* BEGIN TEST */\n+\n+#ifdef DEBUG","path":"src/TheThingsNetwork.h","position":6,"original_position":6,"commit_id":"8ec238dae563e88bac3f40f9b65259481cb911f3","original_commit_id":"8ec238dae563e88bac3f40f9b65259481cb911f3","user":{"login":"Nicolasdejean","id":20477842,"avatar_url":"https://avatars.githubusercontent.com/u/20477842?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicolasdejean","html_url":"https://github.com/Nicolasdejean","followers_url":"https://api.github.com/users/Nicolasdejean/followers","following_url":"https://api.github.com/users/Nicolasdejean/following{/other_user}","gists_url":"https://api.github.com/users/Nicolasdejean/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicolasdejean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicolasdejean/subscriptions","organizations_url":"https://api.github.com/users/Nicolasdejean/orgs","repos_url":"https://api.github.com/users/Nicolasdejean/repos","events_url":"https://api.github.com/users/Nicolasdejean/events{/privacy}","received_events_url":"https://api.github.com/users/Nicolasdejean/received_events","type":"User","site_admin":false},"body":"I'm going to see if I can put debugPrintLn and debugPrint in the public library.\n\n\n\nOn Fri, Sep 2, 2016 at 2:32 PM +0200, \"Johan Stokking\" <notifications@github.com<mailto:notifications@github.com>> wrote:\n\n\nIn src/TheThingsNetwork.h<https://github.com/TheThingsNetwork/arduino-library/pull/12#discussion_r77338168>:\n\n> @@ -23,6 +23,19 @@\n>  #define HEX_CHAR_TO_NIBBLE(c) ((c >= 'A') ? (c - 'A' + 0x0A) : (c - '0'))\n>  #define HEX_PAIR_TO_BYTE(h, l) ((HEX_CHAR_TO_NIBBLE(h) << 4) + HEX_CHAR_TO_NIBBLE(l))\n>\n> +/* BEGIN TEST */\n> +\n> +#ifdef DEBUG\n\n\nYes!\n\n-\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub<https://github.com/TheThingsNetwork/arduino-library/pull/12/files/8ec238dae563e88bac3f40f9b65259481cb911f3#r77338168>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATh3kohDtKVO4DuOaoRLK78Y39WBN-8bks5qmBddgaJpZM4Jzms4>.\n","created_at":"2016-09-02T14:20:31Z","updated_at":"2016-09-02T14:20:31Z","html_url":"https://github.com/TheThingsNetwork/arduino-library/pull/12#discussion_r77353713","pull_request_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/comments/77353713"},"html":{"href":"https://github.com/TheThingsNetwork/arduino-library/pull/12#discussion_r77353713"},"pull_request":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12","id":83784489,"html_url":"https://github.com/TheThingsNetwork/arduino-library/pull/12","diff_url":"https://github.com/TheThingsNetwork/arduino-library/pull/12.diff","patch_url":"https://github.com/TheThingsNetwork/arduino-library/pull/12.patch","issue_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/12","number":12,"state":"open","locked":false,"title":"Compiler directive for debug output","user":{"login":"Nicolasdejean","id":20477842,"avatar_url":"https://avatars.githubusercontent.com/u/20477842?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicolasdejean","html_url":"https://github.com/Nicolasdejean","followers_url":"https://api.github.com/users/Nicolasdejean/followers","following_url":"https://api.github.com/users/Nicolasdejean/following{/other_user}","gists_url":"https://api.github.com/users/Nicolasdejean/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicolasdejean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicolasdejean/subscriptions","organizations_url":"https://api.github.com/users/Nicolasdejean/orgs","repos_url":"https://api.github.com/users/Nicolasdejean/repos","events_url":"https://api.github.com/users/Nicolasdejean/events{/privacy}","received_events_url":"https://api.github.com/users/Nicolasdejean/received_events","type":"User","site_admin":false},"body":"Adding debugPrintln and debugPrint to TheThingsNetwork.h to simplify example codes. #4","created_at":"2016-09-02T11:13:33Z","updated_at":"2016-09-02T14:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9178e793b15b15fb3861640930263d43d24cc0b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12/commits","review_comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12/comments","review_comment_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/12/comments","statuses_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/statuses/8ec238dae563e88bac3f40f9b65259481cb911f3","head":{"label":"TheThingsNetwork:Nicolasdejean-patch-2-1","ref":"Nicolasdejean-patch-2-1","sha":"8ec238dae563e88bac3f40f9b65259481cb911f3","user":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":65997719,"name":"arduino-library","full_name":"TheThingsNetwork/arduino-library","owner":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheThingsNetwork/arduino-library","description":"The Things Network Arduino Library","fork":false,"url":"https://api.github.com/repos/TheThingsNetwork/arduino-library","forks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/forks","keys_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/teams","hooks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/hooks","issue_events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/events{/number}","events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/events","assignees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/assignees{/user}","branches_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/branches{/branch}","tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/tags","blobs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/statuses/{sha}","languages_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/languages","stargazers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/stargazers","contributors_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/contributors","subscribers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/subscribers","subscription_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/subscription","commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/contents/{+path}","compare_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/merges","archive_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/downloads","issues_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues{/number}","pulls_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls{/number}","milestones_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/milestones{/number}","notifications_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/labels{/name}","releases_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/releases{/id}","deployments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/deployments","created_at":"2016-08-18T13:04:36Z","updated_at":"2016-08-29T11:47:51Z","pushed_at":"2016-09-02T11:13:34Z","git_url":"git://github.com/TheThingsNetwork/arduino-library.git","ssh_url":"git@github.com:TheThingsNetwork/arduino-library.git","clone_url":"https://github.com/TheThingsNetwork/arduino-library.git","svn_url":"https://github.com/TheThingsNetwork/arduino-library","homepage":null,"size":26,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"TheThingsNetwork:master","ref":"master","sha":"c70d4f8af01893c8565836528a1eb32fed7edcd3","user":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":65997719,"name":"arduino-library","full_name":"TheThingsNetwork/arduino-library","owner":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheThingsNetwork/arduino-library","description":"The Things Network Arduino Library","fork":false,"url":"https://api.github.com/repos/TheThingsNetwork/arduino-library","forks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/forks","keys_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/teams","hooks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/hooks","issue_events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/events{/number}","events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/events","assignees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/assignees{/user}","branches_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/branches{/branch}","tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/tags","blobs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/statuses/{sha}","languages_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/languages","stargazers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/stargazers","contributors_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/contributors","subscribers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/subscribers","subscription_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/subscription","commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/contents/{+path}","compare_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/merges","archive_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/downloads","issues_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues{/number}","pulls_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls{/number}","milestones_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/milestones{/number}","notifications_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/labels{/name}","releases_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/releases{/id}","deployments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-library/deployments","created_at":"2016-08-18T13:04:36Z","updated_at":"2016-08-29T11:47:51Z","pushed_at":"2016-09-02T11:13:34Z","git_url":"git://github.com/TheThingsNetwork/arduino-library.git","ssh_url":"git@github.com:TheThingsNetwork/arduino-library.git","clone_url":"https://github.com/TheThingsNetwork/arduino-library.git","svn_url":"https://github.com/TheThingsNetwork/arduino-library","homepage":null,"size":26,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12"},"html":{"href":"https://github.com/TheThingsNetwork/arduino-library/pull/12"},"issue":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/12"},"comments":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-library/statuses/8ec238dae563e88bac3f40f9b65259481cb911f3"}}}}
{"actor":{"display_login":"Nicolasdejean"}}