{"action":"created","comment":{"url":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments/67786448","id":67786448,"diff_hunk":"@@ -83,8 +105,8 @@ private class SubscriberInfomation\n             {\n                 _log.Error(\n                     exception,\n-                    \"Failed to dispatch to event handler {0}\",\n-                    handler.GetType().PrettyPrint());\n+                    $\"Failed to dispatch to event handler '{handler.GetType().PrettyPrint()}' for event '{domainEvent.EventType.PrettyPrint()}' due to unexpected exception!\");\n+                throw;","path":"Source/EventFlow/Subscribers/DispatchToEventSubscribers.cs","position":62,"original_position":62,"commit_id":"2b0775af31ff09fdb2488c1411745dd695d15209","original_commit_id":"2b0775af31ff09fdb2488c1411745dd695d15209","user":{"login":"ylbillyli","id":13381578,"avatar_url":"https://avatars.githubusercontent.com/u/13381578?v=3","gravatar_id":"","url":"https://api.github.com/users/ylbillyli","html_url":"https://github.com/ylbillyli","followers_url":"https://api.github.com/users/ylbillyli/followers","following_url":"https://api.github.com/users/ylbillyli/following{/other_user}","gists_url":"https://api.github.com/users/ylbillyli/gists{/gist_id}","starred_url":"https://api.github.com/users/ylbillyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylbillyli/subscriptions","organizations_url":"https://api.github.com/users/ylbillyli/orgs","repos_url":"https://api.github.com/users/ylbillyli/repos","events_url":"https://api.github.com/users/ylbillyli/events{/privacy}","received_events_url":"https://api.github.com/users/ylbillyli/received_events","type":"User","site_admin":false},"body":"How about save one try-catch overhead by doing it here:\r\n```\r\nif(_eventFlowConfiguration.ThrowSubscriberExceptions) throw else _log.debug(e, \"swallowed\");\r\n```\r\nJust a small suggestion, not sure if I am up-to-date with the code base, if you are doing an extra `try-catch` in `DomainEventPublisher` on purpose to make it neater, then I think that is also fair enough.","created_at":"2016-06-20T23:40:06Z","updated_at":"2016-06-20T23:40:06Z","html_url":"https://github.com/rasmus/EventFlow/pull/230#discussion_r67786448","pull_request_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/230","_links":{"self":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments/67786448"},"html":{"href":"https://github.com/rasmus/EventFlow/pull/230#discussion_r67786448"},"pull_request":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/rasmus/EventFlow/pulls/230","id":74509449,"html_url":"https://github.com/rasmus/EventFlow/pull/230","diff_url":"https://github.com/rasmus/EventFlow/pull/230.diff","patch_url":"https://github.com/rasmus/EventFlow/pull/230.patch","issue_url":"https://api.github.com/repos/rasmus/EventFlow/issues/230","number":230,"state":"open","locked":false,"title":"Allow unhandled subscriber exceptions to be thrown","user":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"body":"Sometimes unhandled subscribers exceptions should be allowed to propagate to the originating publisher of a command.","created_at":"2016-06-20T20:41:07Z","updated_at":"2016-06-20T23:40:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3d905b72740658e01f0cd1b610fe7942e88719c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/230/commits","review_comments_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/230/comments","review_comment_url":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rasmus/EventFlow/issues/230/comments","statuses_url":"https://api.github.com/repos/rasmus/EventFlow/statuses/2b0775af31ff09fdb2488c1411745dd695d15209","head":{"label":"rasmus:dont-swallow-subscriber-exceptions","ref":"dont-swallow-subscriber-exceptions","sha":"2b0775af31ff09fdb2488c1411745dd695d15209","user":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"repo":{"id":32411368,"name":"EventFlow","full_name":"rasmus/EventFlow","owner":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rasmus/EventFlow","description":"Async/await first CQRS+ES and DDD framework for .NET","fork":false,"url":"https://api.github.com/repos/rasmus/EventFlow","forks_url":"https://api.github.com/repos/rasmus/EventFlow/forks","keys_url":"https://api.github.com/repos/rasmus/EventFlow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rasmus/EventFlow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rasmus/EventFlow/teams","hooks_url":"https://api.github.com/repos/rasmus/EventFlow/hooks","issue_events_url":"https://api.github.com/repos/rasmus/EventFlow/issues/events{/number}","events_url":"https://api.github.com/repos/rasmus/EventFlow/events","assignees_url":"https://api.github.com/repos/rasmus/EventFlow/assignees{/user}","branches_url":"https://api.github.com/repos/rasmus/EventFlow/branches{/branch}","tags_url":"https://api.github.com/repos/rasmus/EventFlow/tags","blobs_url":"https://api.github.com/repos/rasmus/EventFlow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rasmus/EventFlow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rasmus/EventFlow/git/refs{/sha}","trees_url":"https://api.github.com/repos/rasmus/EventFlow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rasmus/EventFlow/statuses/{sha}","languages_url":"https://api.github.com/repos/rasmus/EventFlow/languages","stargazers_url":"https://api.github.com/repos/rasmus/EventFlow/stargazers","contributors_url":"https://api.github.com/repos/rasmus/EventFlow/contributors","subscribers_url":"https://api.github.com/repos/rasmus/EventFlow/subscribers","subscription_url":"https://api.github.com/repos/rasmus/EventFlow/subscription","commits_url":"https://api.github.com/repos/rasmus/EventFlow/commits{/sha}","git_commits_url":"https://api.github.com/repos/rasmus/EventFlow/git/commits{/sha}","comments_url":"https://api.github.com/repos/rasmus/EventFlow/comments{/number}","issue_comment_url":"https://api.github.com/repos/rasmus/EventFlow/issues/comments{/number}","contents_url":"https://api.github.com/repos/rasmus/EventFlow/contents/{+path}","compare_url":"https://api.github.com/repos/rasmus/EventFlow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rasmus/EventFlow/merges","archive_url":"https://api.github.com/repos/rasmus/EventFlow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rasmus/EventFlow/downloads","issues_url":"https://api.github.com/repos/rasmus/EventFlow/issues{/number}","pulls_url":"https://api.github.com/repos/rasmus/EventFlow/pulls{/number}","milestones_url":"https://api.github.com/repos/rasmus/EventFlow/milestones{/number}","notifications_url":"https://api.github.com/repos/rasmus/EventFlow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rasmus/EventFlow/labels{/name}","releases_url":"https://api.github.com/repos/rasmus/EventFlow/releases{/id}","deployments_url":"https://api.github.com/repos/rasmus/EventFlow/deployments","created_at":"2015-03-17T18:11:23Z","updated_at":"2016-06-18T19:12:51Z","pushed_at":"2016-06-20T21:31:12Z","git_url":"git://github.com/rasmus/EventFlow.git","ssh_url":"git@github.com:rasmus/EventFlow.git","clone_url":"https://github.com/rasmus/EventFlow.git","svn_url":"https://github.com/rasmus/EventFlow","homepage":"http://geteventflow.net/","size":3323,"stargazers_count":123,"watchers_count":123,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":35,"forks":23,"open_issues":35,"watchers":123,"default_branch":"develop"}},"base":{"label":"rasmus:develop","ref":"develop","sha":"52dca064b7a9b3292d93662592c8057fd2389bf5","user":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"repo":{"id":32411368,"name":"EventFlow","full_name":"rasmus/EventFlow","owner":{"login":"rasmus","id":18956,"avatar_url":"https://avatars.githubusercontent.com/u/18956?v=3","gravatar_id":"","url":"https://api.github.com/users/rasmus","html_url":"https://github.com/rasmus","followers_url":"https://api.github.com/users/rasmus/followers","following_url":"https://api.github.com/users/rasmus/following{/other_user}","gists_url":"https://api.github.com/users/rasmus/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmus/subscriptions","organizations_url":"https://api.github.com/users/rasmus/orgs","repos_url":"https://api.github.com/users/rasmus/repos","events_url":"https://api.github.com/users/rasmus/events{/privacy}","received_events_url":"https://api.github.com/users/rasmus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rasmus/EventFlow","description":"Async/await first CQRS+ES and DDD framework for .NET","fork":false,"url":"https://api.github.com/repos/rasmus/EventFlow","forks_url":"https://api.github.com/repos/rasmus/EventFlow/forks","keys_url":"https://api.github.com/repos/rasmus/EventFlow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rasmus/EventFlow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rasmus/EventFlow/teams","hooks_url":"https://api.github.com/repos/rasmus/EventFlow/hooks","issue_events_url":"https://api.github.com/repos/rasmus/EventFlow/issues/events{/number}","events_url":"https://api.github.com/repos/rasmus/EventFlow/events","assignees_url":"https://api.github.com/repos/rasmus/EventFlow/assignees{/user}","branches_url":"https://api.github.com/repos/rasmus/EventFlow/branches{/branch}","tags_url":"https://api.github.com/repos/rasmus/EventFlow/tags","blobs_url":"https://api.github.com/repos/rasmus/EventFlow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rasmus/EventFlow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rasmus/EventFlow/git/refs{/sha}","trees_url":"https://api.github.com/repos/rasmus/EventFlow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rasmus/EventFlow/statuses/{sha}","languages_url":"https://api.github.com/repos/rasmus/EventFlow/languages","stargazers_url":"https://api.github.com/repos/rasmus/EventFlow/stargazers","contributors_url":"https://api.github.com/repos/rasmus/EventFlow/contributors","subscribers_url":"https://api.github.com/repos/rasmus/EventFlow/subscribers","subscription_url":"https://api.github.com/repos/rasmus/EventFlow/subscription","commits_url":"https://api.github.com/repos/rasmus/EventFlow/commits{/sha}","git_commits_url":"https://api.github.com/repos/rasmus/EventFlow/git/commits{/sha}","comments_url":"https://api.github.com/repos/rasmus/EventFlow/comments{/number}","issue_comment_url":"https://api.github.com/repos/rasmus/EventFlow/issues/comments{/number}","contents_url":"https://api.github.com/repos/rasmus/EventFlow/contents/{+path}","compare_url":"https://api.github.com/repos/rasmus/EventFlow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rasmus/EventFlow/merges","archive_url":"https://api.github.com/repos/rasmus/EventFlow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rasmus/EventFlow/downloads","issues_url":"https://api.github.com/repos/rasmus/EventFlow/issues{/number}","pulls_url":"https://api.github.com/repos/rasmus/EventFlow/pulls{/number}","milestones_url":"https://api.github.com/repos/rasmus/EventFlow/milestones{/number}","notifications_url":"https://api.github.com/repos/rasmus/EventFlow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rasmus/EventFlow/labels{/name}","releases_url":"https://api.github.com/repos/rasmus/EventFlow/releases{/id}","deployments_url":"https://api.github.com/repos/rasmus/EventFlow/deployments","created_at":"2015-03-17T18:11:23Z","updated_at":"2016-06-18T19:12:51Z","pushed_at":"2016-06-20T21:31:12Z","git_url":"git://github.com/rasmus/EventFlow.git","ssh_url":"git@github.com:rasmus/EventFlow.git","clone_url":"https://github.com/rasmus/EventFlow.git","svn_url":"https://github.com/rasmus/EventFlow","homepage":"http://geteventflow.net/","size":3323,"stargazers_count":123,"watchers_count":123,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":35,"forks":23,"open_issues":35,"watchers":123,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/230"},"html":{"href":"https://github.com/rasmus/EventFlow/pull/230"},"issue":{"href":"https://api.github.com/repos/rasmus/EventFlow/issues/230"},"comments":{"href":"https://api.github.com/repos/rasmus/EventFlow/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rasmus/EventFlow/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/rasmus/EventFlow/statuses/2b0775af31ff09fdb2488c1411745dd695d15209"}}}}
{"actor":{"display_login":"ylbillyli"}}