{"action":"created","comment":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/86262116","pull_request_review_id":6928713,"id":86262116,"diff_hunk":"@@ -58,7 +58,12 @@ library ChannelManagerLibrary {\n \n         address[] storage existingChannels = self.nodeChannels[msg.sender];","path":"raiden/smart_contracts/ChannelManagerLibrary.sol","position":2,"original_position":2,"commit_id":"261415036c4f771382e549db592ea6804092d2aa","original_commit_id":"7fa4a7936a0e6cb00343bc07b2154ae9ef3921c5","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"@czepluch , @schmir is right. You are iterating an array and attempting to modify it during the iteration. That will not end up nicely.","created_at":"2016-11-02T23:06:15Z","updated_at":"2016-11-02T23:06:15Z","html_url":"https://github.com/raiden-network/raiden/pull/191#discussion_r86262116","pull_request_url":"https://api.github.com/repos/raiden-network/raiden/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/86262116"},"html":{"href":"https://github.com/raiden-network/raiden/pull/191#discussion_r86262116"},"pull_request":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/191","id":90818159,"html_url":"https://github.com/raiden-network/raiden/pull/191","diff_url":"https://github.com/raiden-network/raiden/pull/191.diff","patch_url":"https://github.com/raiden-network/raiden/pull/191.patch","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/191","number":191,"state":"open","locked":false,"title":"Allow a new channel to be opened with same partner after settling","user":{"login":"czepluch","id":1026799,"avatar_url":"https://avatars.githubusercontent.com/u/1026799?v=3","gravatar_id":"","url":"https://api.github.com/users/czepluch","html_url":"https://github.com/czepluch","followers_url":"https://api.github.com/users/czepluch/followers","following_url":"https://api.github.com/users/czepluch/following{/other_user}","gists_url":"https://api.github.com/users/czepluch/gists{/gist_id}","starred_url":"https://api.github.com/users/czepluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czepluch/subscriptions","organizations_url":"https://api.github.com/users/czepluch/orgs","repos_url":"https://api.github.com/users/czepluch/repos","events_url":"https://api.github.com/users/czepluch/events{/privacy}","received_events_url":"https://api.github.com/users/czepluch/received_events","type":"User","site_admin":false},"body":"This PR implements:\n- Nonce ranges to make sure transfers from a previous channel cannot be used in a new channel\n- Deletes a channel from the blockchain after it's been settled\n- Allows for a new channel to be opened between two parties who previously had a channel\n","created_at":"2016-10-25T14:23:14Z","updated_at":"2016-11-02T23:11:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82503d6c0d3b78388051be31635b174b8579a74e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/raiden-network/raiden/milestones/9","html_url":"https://github.com/raiden-network/raiden/milestones/MVP","labels_url":"https://api.github.com/repos/raiden-network/raiden/milestones/9/labels","id":2080256,"number":9,"title":"MVP","description":"","creator":{"login":"heikoheiko","id":2804689,"avatar_url":"https://avatars.githubusercontent.com/u/2804689?v=3","gravatar_id":"","url":"https://api.github.com/users/heikoheiko","html_url":"https://github.com/heikoheiko","followers_url":"https://api.github.com/users/heikoheiko/followers","following_url":"https://api.github.com/users/heikoheiko/following{/other_user}","gists_url":"https://api.github.com/users/heikoheiko/gists{/gist_id}","starred_url":"https://api.github.com/users/heikoheiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heikoheiko/subscriptions","organizations_url":"https://api.github.com/users/heikoheiko/orgs","repos_url":"https://api.github.com/users/heikoheiko/repos","events_url":"https://api.github.com/users/heikoheiko/events{/privacy}","received_events_url":"https://api.github.com/users/heikoheiko/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":1,"state":"open","created_at":"2016-10-19T15:23:12Z","updated_at":"2016-11-01T14:35:24Z","due_on":"2016-12-24T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/raiden-network/raiden/pulls/191/commits","review_comments_url":"https://api.github.com/repos/raiden-network/raiden/pulls/191/comments","review_comment_url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/191/comments","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/261415036c4f771382e549db592ea6804092d2aa","head":{"label":"czepluch:issue_93","ref":"issue_93","sha":"261415036c4f771382e549db592ea6804092d2aa","user":{"login":"czepluch","id":1026799,"avatar_url":"https://avatars.githubusercontent.com/u/1026799?v=3","gravatar_id":"","url":"https://api.github.com/users/czepluch","html_url":"https://github.com/czepluch","followers_url":"https://api.github.com/users/czepluch/followers","following_url":"https://api.github.com/users/czepluch/following{/other_user}","gists_url":"https://api.github.com/users/czepluch/gists{/gist_id}","starred_url":"https://api.github.com/users/czepluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czepluch/subscriptions","organizations_url":"https://api.github.com/users/czepluch/orgs","repos_url":"https://api.github.com/users/czepluch/repos","events_url":"https://api.github.com/users/czepluch/events{/privacy}","received_events_url":"https://api.github.com/users/czepluch/received_events","type":"User","site_admin":false},"repo":{"id":70597153,"name":"raiden","full_name":"czepluch/raiden","owner":{"login":"czepluch","id":1026799,"avatar_url":"https://avatars.githubusercontent.com/u/1026799?v=3","gravatar_id":"","url":"https://api.github.com/users/czepluch","html_url":"https://github.com/czepluch","followers_url":"https://api.github.com/users/czepluch/followers","following_url":"https://api.github.com/users/czepluch/following{/other_user}","gists_url":"https://api.github.com/users/czepluch/gists{/gist_id}","starred_url":"https://api.github.com/users/czepluch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czepluch/subscriptions","organizations_url":"https://api.github.com/users/czepluch/orgs","repos_url":"https://api.github.com/users/czepluch/repos","events_url":"https://api.github.com/users/czepluch/events{/privacy}","received_events_url":"https://api.github.com/users/czepluch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/czepluch/raiden","description":"Raiden Network","fork":true,"url":"https://api.github.com/repos/czepluch/raiden","forks_url":"https://api.github.com/repos/czepluch/raiden/forks","keys_url":"https://api.github.com/repos/czepluch/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/czepluch/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/czepluch/raiden/teams","hooks_url":"https://api.github.com/repos/czepluch/raiden/hooks","issue_events_url":"https://api.github.com/repos/czepluch/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/czepluch/raiden/events","assignees_url":"https://api.github.com/repos/czepluch/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/czepluch/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/czepluch/raiden/tags","blobs_url":"https://api.github.com/repos/czepluch/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/czepluch/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/czepluch/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/czepluch/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/czepluch/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/czepluch/raiden/languages","stargazers_url":"https://api.github.com/repos/czepluch/raiden/stargazers","contributors_url":"https://api.github.com/repos/czepluch/raiden/contributors","subscribers_url":"https://api.github.com/repos/czepluch/raiden/subscribers","subscription_url":"https://api.github.com/repos/czepluch/raiden/subscription","commits_url":"https://api.github.com/repos/czepluch/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/czepluch/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/czepluch/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/czepluch/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/czepluch/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/czepluch/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/czepluch/raiden/merges","archive_url":"https://api.github.com/repos/czepluch/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/czepluch/raiden/downloads","issues_url":"https://api.github.com/repos/czepluch/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/czepluch/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/czepluch/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/czepluch/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/czepluch/raiden/labels{/name}","releases_url":"https://api.github.com/repos/czepluch/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/czepluch/raiden/deployments","created_at":"2016-10-11T13:38:35Z","updated_at":"2016-10-11T13:38:37Z","pushed_at":"2016-11-02T21:43:20Z","git_url":"git://github.com/czepluch/raiden.git","ssh_url":"git@github.com:czepluch/raiden.git","clone_url":"https://github.com/czepluch/raiden.git","svn_url":"https://github.com/czepluch/raiden","homepage":null,"size":1887,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:master","ref":"master","sha":"7788e87f69c522d07b7fe39447942ba726593b71","user":{"login":"raiden-network","id":19666847,"avatar_url":"https://avatars.githubusercontent.com/u/19666847?v=3","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":50646767,"name":"raiden","full_name":"raiden-network/raiden","owner":{"login":"raiden-network","id":19666847,"avatar_url":"https://avatars.githubusercontent.com/u/19666847?v=3","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raiden-network/raiden","description":"Raiden Network","fork":false,"url":"https://api.github.com/repos/raiden-network/raiden","forks_url":"https://api.github.com/repos/raiden-network/raiden/forks","keys_url":"https://api.github.com/repos/raiden-network/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/raiden/teams","hooks_url":"https://api.github.com/repos/raiden-network/raiden/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/raiden/events","assignees_url":"https://api.github.com/repos/raiden-network/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/raiden/tags","blobs_url":"https://api.github.com/repos/raiden-network/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/raiden/languages","stargazers_url":"https://api.github.com/repos/raiden-network/raiden/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/raiden/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/raiden/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/raiden/subscription","commits_url":"https://api.github.com/repos/raiden-network/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/raiden/merges","archive_url":"https://api.github.com/repos/raiden-network/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/raiden/downloads","issues_url":"https://api.github.com/repos/raiden-network/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/raiden/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/raiden/deployments","created_at":"2016-01-29T07:40:47Z","updated_at":"2016-11-02T07:03:47Z","pushed_at":"2016-11-02T22:49:28Z","git_url":"git://github.com/raiden-network/raiden.git","ssh_url":"git@github.com:raiden-network/raiden.git","clone_url":"https://github.com/raiden-network/raiden.git","svn_url":"https://github.com/raiden-network/raiden","homepage":null,"size":1969,"stargazers_count":144,"watchers_count":144,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":85,"forks":31,"open_issues":85,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/191"},"html":{"href":"https://github.com/raiden-network/raiden/pull/191"},"issue":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/191"},"comments":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/raiden/statuses/261415036c4f771382e549db592ea6804092d2aa"}}}}
{"actor":{"display_login":"LefterisJP"}}