{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/3312","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/3312/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/3312/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/3312/events","html_url":"https://github.com/qgis/QGIS/pull/3312","id":165898258,"number":3312,"title":"Make QgsCoordinateTransform implicitly shared, no longer a QObject","user":{"login":"nyalldawson","id":1829991,"avatar_url":"https://avatars.githubusercontent.com/u/1829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/qgis/QGIS/labels/API%20break","name":"API break","color":"fbca04"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-16T00:12:21Z","updated_at":"2016-07-17T08:53:39Z","closed_at":"2016-07-17T08:53:35Z","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/3312","html_url":"https://github.com/qgis/QGIS/pull/3312","diff_url":"https://github.com/qgis/QGIS/pull/3312.diff","patch_url":"https://github.com/qgis/QGIS/pull/3312.patch"},"body":"Phew... this was a bit painful. Anyway, this PR makes QgsCoordinateTransform objects implicitly shared (woooo!) and no longer QObjects (bigger woooo!). See https://github.com/qgis/qgis3.0_api/issues/46\r\n\r\nThere was no code in core using the signals/slots associated with QgsCoordinateTransform, and little reason to keep the class a QObject. Making it not a QObject simplifies code and allows QgsCoordinateTransform objects to be easily copied and passed around without complication. And now that they're implicitly shared, it's inexpensive to do so.\r\n\r\nThis breaks any code which relies on the signal from QgsCoordinateTransform (I suspect no one is using this), and using the slots in connections (again, I suspect no-one would be doing this). \r\n\r\nI'm going to follow this up with a cleanup of the  QgsCoordinateTransform api, and removal of all QgsCoordinateTransform* and QgsCoordinateTransform::clone use."},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/233172090","html_url":"https://github.com/qgis/QGIS/pull/3312#issuecomment-233172090","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/3312","id":233172090,"user":{"login":"nyalldawson","id":1829991,"avatar_url":"https://avatars.githubusercontent.com/u/1829991?v=3","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"created_at":"2016-07-17T08:53:39Z","updated_at":"2016-07-17T08:53:39Z","body":"Thanks!"}}
{"actor":{"display_login":"nyalldawson"}}