{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/79296634","id":79296634,"diff_hunk":"@@ -87,19 +87,23 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {\n   }\n \n   /**\n-   * Create an [[AnalyzeTableCommand]] command. This currently only implements the NOSCAN\n-   * option (other options are passed on to Hive) e.g.:\n-   * {{{\n-   *   ANALYZE TABLE table COMPUTE STATISTICS NOSCAN;\n-   * }}}\n+   * Create an [[AnalyzeTableCommand]] command or an [[AnalyzeColumnCommand]] command.\n    */\n   override def visitAnalyze(ctx: AnalyzeContext): LogicalPlan = withOrigin(ctx) {\n     if (ctx.partitionSpec == null &&\n       ctx.identifier != null &&\n       ctx.identifier.getText.toLowerCase == \"noscan\") {\n-      AnalyzeTableCommand(visitTableIdentifier(ctx.tableIdentifier).toString)\n+      AnalyzeTableCommand(visitTableIdentifier(ctx.tableIdentifier))\n+    } else if (ctx.identifierSeq() == null) {","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala","position":17,"original_position":17,"commit_id":"9cdc722780445c62ed2c306ede0ebc4829dbdbe8","original_commit_id":"9cdc722780445c62ed2c306ede0ebc4829dbdbe8","user":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"body":"Yeah, good idea","created_at":"2016-09-18T03:26:52Z","updated_at":"2016-09-18T03:26:52Z","html_url":"https://github.com/apache/spark/pull/15090#discussion_r79296634","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15090","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/79296634"},"html":{"href":"https://github.com/apache/spark/pull/15090#discussion_r79296634"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15090"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15090","id":85163180,"html_url":"https://github.com/apache/spark/pull/15090","diff_url":"https://github.com/apache/spark/pull/15090.diff","patch_url":"https://github.com/apache/spark/pull/15090.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15090","number":15090,"state":"open","locked":false,"title":"[SPARK-17073] [SQL] generate column-level statistics","user":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nGenerate basic column statistics for all the atomic types:\r\n- numeric types: max, min, num of nulls, ndv (number of distinct values)\r\n- date/timestamp types: they are also represented as numbers internally, so they have the same stats as above.\r\n- string: avg length, max length, num of nulls, ndv\r\n- binary: avg length, max length, num of nulls\r\n- boolean: num of nulls, num of trues, num of falsies, ndv (must be 2)\r\n\r\nAlso support storing and loading these statistics.\r\n\r\nThis pr also fixes a small bug:\r\nwhen converting `SimpleCatalogRelation` to `LogicalRelation`, we should set its `expectedOutputAttributes`.\r\n\r\n## How was this patch tested?\r\n\r\nadd unit tests","created_at":"2016-09-14T03:56:14Z","updated_at":"2016-09-18T03:26:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87a23dbf36d1131e43d899b24f03e5ddfd849c9d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15090/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15090/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15090/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/9cdc722780445c62ed2c306ede0ebc4829dbdbe8","head":{"label":"wzhfy:colStats","ref":"colStats","sha":"9cdc722780445c62ed2c306ede0ebc4829dbdbe8","user":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"repo":{"id":66051854,"name":"spark","full_name":"wzhfy/spark","owner":{"login":"wzhfy","id":10878553,"avatar_url":"https://avatars.githubusercontent.com/u/10878553?v=3","gravatar_id":"","url":"https://api.github.com/users/wzhfy","html_url":"https://github.com/wzhfy","followers_url":"https://api.github.com/users/wzhfy/followers","following_url":"https://api.github.com/users/wzhfy/following{/other_user}","gists_url":"https://api.github.com/users/wzhfy/gists{/gist_id}","starred_url":"https://api.github.com/users/wzhfy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wzhfy/subscriptions","organizations_url":"https://api.github.com/users/wzhfy/orgs","repos_url":"https://api.github.com/users/wzhfy/repos","events_url":"https://api.github.com/users/wzhfy/events{/privacy}","received_events_url":"https://api.github.com/users/wzhfy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wzhfy/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/wzhfy/spark","forks_url":"https://api.github.com/repos/wzhfy/spark/forks","keys_url":"https://api.github.com/repos/wzhfy/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wzhfy/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wzhfy/spark/teams","hooks_url":"https://api.github.com/repos/wzhfy/spark/hooks","issue_events_url":"https://api.github.com/repos/wzhfy/spark/issues/events{/number}","events_url":"https://api.github.com/repos/wzhfy/spark/events","assignees_url":"https://api.github.com/repos/wzhfy/spark/assignees{/user}","branches_url":"https://api.github.com/repos/wzhfy/spark/branches{/branch}","tags_url":"https://api.github.com/repos/wzhfy/spark/tags","blobs_url":"https://api.github.com/repos/wzhfy/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wzhfy/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wzhfy/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/wzhfy/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wzhfy/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/wzhfy/spark/languages","stargazers_url":"https://api.github.com/repos/wzhfy/spark/stargazers","contributors_url":"https://api.github.com/repos/wzhfy/spark/contributors","subscribers_url":"https://api.github.com/repos/wzhfy/spark/subscribers","subscription_url":"https://api.github.com/repos/wzhfy/spark/subscription","commits_url":"https://api.github.com/repos/wzhfy/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/wzhfy/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/wzhfy/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/wzhfy/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/wzhfy/spark/contents/{+path}","compare_url":"https://api.github.com/repos/wzhfy/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wzhfy/spark/merges","archive_url":"https://api.github.com/repos/wzhfy/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wzhfy/spark/downloads","issues_url":"https://api.github.com/repos/wzhfy/spark/issues{/number}","pulls_url":"https://api.github.com/repos/wzhfy/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/wzhfy/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/wzhfy/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wzhfy/spark/labels{/name}","releases_url":"https://api.github.com/repos/wzhfy/spark/releases{/id}","deployments_url":"https://api.github.com/repos/wzhfy/spark/deployments","created_at":"2016-08-19T04:11:04Z","updated_at":"2016-08-19T04:11:28Z","pushed_at":"2016-09-16T06:37:03Z","git_url":"git://github.com/wzhfy/spark.git","ssh_url":"git@github.com:wzhfy/spark.git","clone_url":"https://github.com/wzhfy/spark.git","svn_url":"https://github.com/wzhfy/spark","homepage":null,"size":186781,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"37b93f54e89332b6b77bb02c1c2299614338fd7c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-09-18T03:13:11Z","pushed_at":"2016-09-18T02:18:46Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":526848,"stargazers_count":10042,"watchers_count":10042,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9359,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":478,"forks":9359,"open_issues":478,"watchers":10042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15090"},"html":{"href":"https://github.com/apache/spark/pull/15090"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15090"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15090/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15090/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15090/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/9cdc722780445c62ed2c306ede0ebc4829dbdbe8"}}}}
{"actor":{"display_login":"wzhfy"}}