{"action":"closed","number":172,"pull_request":{"url":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/172","id":83161982,"html_url":"https://github.com/mvantellingen/python-zeep/pull/172","diff_url":"https://github.com/mvantellingen/python-zeep/pull/172.diff","patch_url":"https://github.com/mvantellingen/python-zeep/pull/172.patch","issue_url":"https://api.github.com/repos/mvantellingen/python-zeep/issues/172","number":172,"state":"closed","locked":false,"title":"Add support for Transport-specified timeout in XML GET/POST requests","user":{"login":"beager","id":1027710,"avatar_url":"https://avatars.githubusercontent.com/u/1027710?v=3","gravatar_id":"","url":"https://api.github.com/users/beager","html_url":"https://github.com/beager","followers_url":"https://api.github.com/users/beager/followers","following_url":"https://api.github.com/users/beager/following{/other_user}","gists_url":"https://api.github.com/users/beager/gists{/gist_id}","starred_url":"https://api.github.com/users/beager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beager/subscriptions","organizations_url":"https://api.github.com/users/beager/orgs","repos_url":"https://api.github.com/users/beager/repos","events_url":"https://api.github.com/users/beager/events{/privacy}","received_events_url":"https://api.github.com/users/beager/received_events","type":"User","site_admin":false},"body":"This fixes issue #140 which disregards the timeout passed to `Transport` for any request except the one that fetches the wsdl/xsd.\r\n\r\nThis has some weird considerations in that by default the wsdl/xsd fetch is 300s, but there is no timeout set for get/post requests. Any \"reasonable\" request would be much less than that, but you can't go about assuming that people won't be making a 2000s request. As such, I set the timeout by default to `NotSet` and assigned it to `300` for `load()` and `None` for get/post if it was not set on instantiation of the Transport.\r\n\r\nThis could potentially break implementations where a load timeout is explicitly set, but the get/post request should not have a timeout. Not sure what your thoughts on that are.\r\n\r\nAnyway, this would be hugely useful for me to get this merged. Not familiar with your testing/coverage concerns but tox seems to pass for this. Thanks.\r\n\r\n@mvantellingen ","created_at":"2016-08-29T20:28:32Z","updated_at":"2016-10-30T10:27:55Z","closed_at":"2016-10-30T10:27:55Z","merged_at":null,"merge_commit_sha":"fae57db583b17caf451e4af83a0c2e5b4e58791f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/172/commits","review_comments_url":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/172/comments","review_comment_url":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mvantellingen/python-zeep/issues/172/comments","statuses_url":"https://api.github.com/repos/mvantellingen/python-zeep/statuses/40f253813704829c88f6533c307bf149e05a7caf","head":{"label":"NomadHealth:bill/transports-timeout-support","ref":"bill/transports-timeout-support","sha":"40f253813704829c88f6533c307bf149e05a7caf","user":{"login":"NomadHealth","id":17914613,"avatar_url":"https://avatars.githubusercontent.com/u/17914613?v=3","gravatar_id":"","url":"https://api.github.com/users/NomadHealth","html_url":"https://github.com/NomadHealth","followers_url":"https://api.github.com/users/NomadHealth/followers","following_url":"https://api.github.com/users/NomadHealth/following{/other_user}","gists_url":"https://api.github.com/users/NomadHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/NomadHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NomadHealth/subscriptions","organizations_url":"https://api.github.com/users/NomadHealth/orgs","repos_url":"https://api.github.com/users/NomadHealth/repos","events_url":"https://api.github.com/users/NomadHealth/events{/privacy}","received_events_url":"https://api.github.com/users/NomadHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":66876514,"name":"python-zeep","full_name":"NomadHealth/python-zeep","owner":{"login":"NomadHealth","id":17914613,"avatar_url":"https://avatars.githubusercontent.com/u/17914613?v=3","gravatar_id":"","url":"https://api.github.com/users/NomadHealth","html_url":"https://github.com/NomadHealth","followers_url":"https://api.github.com/users/NomadHealth/followers","following_url":"https://api.github.com/users/NomadHealth/following{/other_user}","gists_url":"https://api.github.com/users/NomadHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/NomadHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NomadHealth/subscriptions","organizations_url":"https://api.github.com/users/NomadHealth/orgs","repos_url":"https://api.github.com/users/NomadHealth/repos","events_url":"https://api.github.com/users/NomadHealth/events{/privacy}","received_events_url":"https://api.github.com/users/NomadHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NomadHealth/python-zeep","description":"A modern/fast python SOAP client based on lxml / requests","fork":true,"url":"https://api.github.com/repos/NomadHealth/python-zeep","forks_url":"https://api.github.com/repos/NomadHealth/python-zeep/forks","keys_url":"https://api.github.com/repos/NomadHealth/python-zeep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NomadHealth/python-zeep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NomadHealth/python-zeep/teams","hooks_url":"https://api.github.com/repos/NomadHealth/python-zeep/hooks","issue_events_url":"https://api.github.com/repos/NomadHealth/python-zeep/issues/events{/number}","events_url":"https://api.github.com/repos/NomadHealth/python-zeep/events","assignees_url":"https://api.github.com/repos/NomadHealth/python-zeep/assignees{/user}","branches_url":"https://api.github.com/repos/NomadHealth/python-zeep/branches{/branch}","tags_url":"https://api.github.com/repos/NomadHealth/python-zeep/tags","blobs_url":"https://api.github.com/repos/NomadHealth/python-zeep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NomadHealth/python-zeep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NomadHealth/python-zeep/git/refs{/sha}","trees_url":"https://api.github.com/repos/NomadHealth/python-zeep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NomadHealth/python-zeep/statuses/{sha}","languages_url":"https://api.github.com/repos/NomadHealth/python-zeep/languages","stargazers_url":"https://api.github.com/repos/NomadHealth/python-zeep/stargazers","contributors_url":"https://api.github.com/repos/NomadHealth/python-zeep/contributors","subscribers_url":"https://api.github.com/repos/NomadHealth/python-zeep/subscribers","subscription_url":"https://api.github.com/repos/NomadHealth/python-zeep/subscription","commits_url":"https://api.github.com/repos/NomadHealth/python-zeep/commits{/sha}","git_commits_url":"https://api.github.com/repos/NomadHealth/python-zeep/git/commits{/sha}","comments_url":"https://api.github.com/repos/NomadHealth/python-zeep/comments{/number}","issue_comment_url":"https://api.github.com/repos/NomadHealth/python-zeep/issues/comments{/number}","contents_url":"https://api.github.com/repos/NomadHealth/python-zeep/contents/{+path}","compare_url":"https://api.github.com/repos/NomadHealth/python-zeep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NomadHealth/python-zeep/merges","archive_url":"https://api.github.com/repos/NomadHealth/python-zeep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NomadHealth/python-zeep/downloads","issues_url":"https://api.github.com/repos/NomadHealth/python-zeep/issues{/number}","pulls_url":"https://api.github.com/repos/NomadHealth/python-zeep/pulls{/number}","milestones_url":"https://api.github.com/repos/NomadHealth/python-zeep/milestones{/number}","notifications_url":"https://api.github.com/repos/NomadHealth/python-zeep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NomadHealth/python-zeep/labels{/name}","releases_url":"https://api.github.com/repos/NomadHealth/python-zeep/releases{/id}","deployments_url":"https://api.github.com/repos/NomadHealth/python-zeep/deployments","created_at":"2016-08-29T20:04:34Z","updated_at":"2016-08-29T20:04:35Z","pushed_at":"2016-08-29T20:21:44Z","git_url":"git://github.com/NomadHealth/python-zeep.git","ssh_url":"git@github.com:NomadHealth/python-zeep.git","clone_url":"https://github.com/NomadHealth/python-zeep.git","svn_url":"https://github.com/NomadHealth/python-zeep","homepage":"http://docs.python-zeep.org","size":1047,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mvantellingen:master","ref":"master","sha":"858986212a064205dcbcaabfd098bd429785e45b","user":{"login":"mvantellingen","id":245297,"avatar_url":"https://avatars.githubusercontent.com/u/245297?v=3","gravatar_id":"","url":"https://api.github.com/users/mvantellingen","html_url":"https://github.com/mvantellingen","followers_url":"https://api.github.com/users/mvantellingen/followers","following_url":"https://api.github.com/users/mvantellingen/following{/other_user}","gists_url":"https://api.github.com/users/mvantellingen/gists{/gist_id}","starred_url":"https://api.github.com/users/mvantellingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvantellingen/subscriptions","organizations_url":"https://api.github.com/users/mvantellingen/orgs","repos_url":"https://api.github.com/users/mvantellingen/repos","events_url":"https://api.github.com/users/mvantellingen/events{/privacy}","received_events_url":"https://api.github.com/users/mvantellingen/received_events","type":"User","site_admin":false},"repo":{"id":51690353,"name":"python-zeep","full_name":"mvantellingen/python-zeep","owner":{"login":"mvantellingen","id":245297,"avatar_url":"https://avatars.githubusercontent.com/u/245297?v=3","gravatar_id":"","url":"https://api.github.com/users/mvantellingen","html_url":"https://github.com/mvantellingen","followers_url":"https://api.github.com/users/mvantellingen/followers","following_url":"https://api.github.com/users/mvantellingen/following{/other_user}","gists_url":"https://api.github.com/users/mvantellingen/gists{/gist_id}","starred_url":"https://api.github.com/users/mvantellingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvantellingen/subscriptions","organizations_url":"https://api.github.com/users/mvantellingen/orgs","repos_url":"https://api.github.com/users/mvantellingen/repos","events_url":"https://api.github.com/users/mvantellingen/events{/privacy}","received_events_url":"https://api.github.com/users/mvantellingen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mvantellingen/python-zeep","description":"A modern/fast python SOAP client based on lxml / requests","fork":false,"url":"https://api.github.com/repos/mvantellingen/python-zeep","forks_url":"https://api.github.com/repos/mvantellingen/python-zeep/forks","keys_url":"https://api.github.com/repos/mvantellingen/python-zeep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvantellingen/python-zeep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvantellingen/python-zeep/teams","hooks_url":"https://api.github.com/repos/mvantellingen/python-zeep/hooks","issue_events_url":"https://api.github.com/repos/mvantellingen/python-zeep/issues/events{/number}","events_url":"https://api.github.com/repos/mvantellingen/python-zeep/events","assignees_url":"https://api.github.com/repos/mvantellingen/python-zeep/assignees{/user}","branches_url":"https://api.github.com/repos/mvantellingen/python-zeep/branches{/branch}","tags_url":"https://api.github.com/repos/mvantellingen/python-zeep/tags","blobs_url":"https://api.github.com/repos/mvantellingen/python-zeep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvantellingen/python-zeep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvantellingen/python-zeep/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvantellingen/python-zeep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvantellingen/python-zeep/statuses/{sha}","languages_url":"https://api.github.com/repos/mvantellingen/python-zeep/languages","stargazers_url":"https://api.github.com/repos/mvantellingen/python-zeep/stargazers","contributors_url":"https://api.github.com/repos/mvantellingen/python-zeep/contributors","subscribers_url":"https://api.github.com/repos/mvantellingen/python-zeep/subscribers","subscription_url":"https://api.github.com/repos/mvantellingen/python-zeep/subscription","commits_url":"https://api.github.com/repos/mvantellingen/python-zeep/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvantellingen/python-zeep/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvantellingen/python-zeep/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvantellingen/python-zeep/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvantellingen/python-zeep/contents/{+path}","compare_url":"https://api.github.com/repos/mvantellingen/python-zeep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvantellingen/python-zeep/merges","archive_url":"https://api.github.com/repos/mvantellingen/python-zeep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvantellingen/python-zeep/downloads","issues_url":"https://api.github.com/repos/mvantellingen/python-zeep/issues{/number}","pulls_url":"https://api.github.com/repos/mvantellingen/python-zeep/pulls{/number}","milestones_url":"https://api.github.com/repos/mvantellingen/python-zeep/milestones{/number}","notifications_url":"https://api.github.com/repos/mvantellingen/python-zeep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvantellingen/python-zeep/labels{/name}","releases_url":"https://api.github.com/repos/mvantellingen/python-zeep/releases{/id}","deployments_url":"https://api.github.com/repos/mvantellingen/python-zeep/deployments","created_at":"2016-02-14T10:31:07Z","updated_at":"2016-10-28T16:48:50Z","pushed_at":"2016-10-30T10:27:12Z","git_url":"git://github.com/mvantellingen/python-zeep.git","ssh_url":"git@github.com:mvantellingen/python-zeep.git","clone_url":"https://github.com/mvantellingen/python-zeep.git","svn_url":"https://github.com/mvantellingen/python-zeep","homepage":"http://docs.python-zeep.org","size":1541,"stargazers_count":251,"watchers_count":251,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":34,"forks":71,"open_issues":34,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/172"},"html":{"href":"https://github.com/mvantellingen/python-zeep/pull/172"},"issue":{"href":"https://api.github.com/repos/mvantellingen/python-zeep/issues/172"},"comments":{"href":"https://api.github.com/repos/mvantellingen/python-zeep/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mvantellingen/python-zeep/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/mvantellingen/python-zeep/statuses/40f253813704829c88f6533c307bf149e05a7caf"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":3,"additions":9,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"mvantellingen"}}