{"action":"created","comment":{"url":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments/81634101","pull_request_review_id":2600144,"id":81634101,"diff_hunk":"@@ -1734,27 +1728,181 @@ def plot_multistrike_cones(is_returns, oos_returns, num_samples=1000,\n             if crossing.sum() <= 0:\n                 break\n             cone_start = crossing.loc[crossing].index[0]\n-            returns_tmp = oos_returns.loc[cone_start:]\n+            returns_tmp = returns.loc[cone_start:]\n             bounds_tmp = (bounds - (1 - returns.loc[cone_start]))\n         for std in cone_std:\n             x = returns_tmp.index\n             y1 = bounds_tmp[float(std)].iloc[:len(returns_tmp)]\n             y2 = bounds_tmp[float(-std)].iloc[:len(returns_tmp)]\n             axes.fill_between(x, y1, y2, color=colors[c], alpha=0.5)\n+\n     # Plot returns line graph\n-    returns.plot(\n-        ax=axes,\n-        lw=3.,\n-        color='black',\n-        label='Cumulative returns = {:.2f}%'.format(\n-            (returns.iloc[-1] - 1) * 100)\n-    )\n+    label = 'Cumulative returns = {:.2f}%'.format((returns.iloc[-1] - 1) * 100)\n+    axes.plot(returns.index, returns.values, color='k', lw=3.,\n+              label=label)\n+\n     if name is not None:\n         axes.set_title(name)\n-    axes.axhline(1, color='black', alpha=0.2)\n+    axes.axhline(1, color='k', alpha=0.2)","path":"pyfolio/plotting.py","position":89,"original_position":89,"commit_id":"0ce062c4da51a5dd9654322e9428bf9ad7c9b47e","original_commit_id":"0ce062c4da51a5dd9654322e9428bf9ad7c9b47e","user":{"login":"ahgnaw","id":921335,"avatar_url":"https://avatars.githubusercontent.com/u/921335?v=3","gravatar_id":"","url":"https://api.github.com/users/ahgnaw","html_url":"https://github.com/ahgnaw","followers_url":"https://api.github.com/users/ahgnaw/followers","following_url":"https://api.github.com/users/ahgnaw/following{/other_user}","gists_url":"https://api.github.com/users/ahgnaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgnaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgnaw/subscriptions","organizations_url":"https://api.github.com/users/ahgnaw/orgs","repos_url":"https://api.github.com/users/ahgnaw/repos","events_url":"https://api.github.com/users/ahgnaw/events{/privacy}","received_events_url":"https://api.github.com/users/ahgnaw/received_events","type":"User","site_admin":false},"body":"I prefer `black` too, I just wanted to be consistent and changed this to match an earlier line. I'll change it to back to `black`.","created_at":"2016-10-03T20:35:10Z","updated_at":"2016-10-03T20:35:10Z","html_url":"https://github.com/quantopian/pyfolio/pull/332#discussion_r81634101","pull_request_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/332","_links":{"self":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments/81634101"},"html":{"href":"https://github.com/quantopian/pyfolio/pull/332#discussion_r81634101"},"pull_request":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/quantopian/pyfolio/pulls/332","id":87380275,"html_url":"https://github.com/quantopian/pyfolio/pull/332","diff_url":"https://github.com/quantopian/pyfolio/pull/332.diff","patch_url":"https://github.com/quantopian/pyfolio/pull/332.patch","issue_url":"https://api.github.com/repos/quantopian/pyfolio/issues/332","number":332,"state":"open","locked":false,"title":"Portfolio multistrike cones","user":{"login":"ahgnaw","id":921335,"avatar_url":"https://avatars.githubusercontent.com/u/921335?v=3","gravatar_id":"","url":"https://api.github.com/users/ahgnaw","html_url":"https://github.com/ahgnaw","followers_url":"https://api.github.com/users/ahgnaw/followers","following_url":"https://api.github.com/users/ahgnaw/following{/other_user}","gists_url":"https://api.github.com/users/ahgnaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgnaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgnaw/subscriptions","organizations_url":"https://api.github.com/users/ahgnaw/orgs","repos_url":"https://api.github.com/users/ahgnaw/repos","events_url":"https://api.github.com/users/ahgnaw/events{/privacy}","received_events_url":"https://api.github.com/users/ahgnaw/received_events","type":"User","site_admin":false},"body":"A portfolio cone prediction changes as new funds are added. Previous method treated portfolio returns without regard to when new funds were turned on.","created_at":"2016-09-29T19:44:15Z","updated_at":"2016-10-03T20:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c23f2d74af96f6817e22a8bed9f768021f8cf42","assignee":{"login":"twiecki","id":674200,"avatar_url":"https://avatars.githubusercontent.com/u/674200?v=3","gravatar_id":"","url":"https://api.github.com/users/twiecki","html_url":"https://github.com/twiecki","followers_url":"https://api.github.com/users/twiecki/followers","following_url":"https://api.github.com/users/twiecki/following{/other_user}","gists_url":"https://api.github.com/users/twiecki/gists{/gist_id}","starred_url":"https://api.github.com/users/twiecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiecki/subscriptions","organizations_url":"https://api.github.com/users/twiecki/orgs","repos_url":"https://api.github.com/users/twiecki/repos","events_url":"https://api.github.com/users/twiecki/events{/privacy}","received_events_url":"https://api.github.com/users/twiecki/received_events","type":"User","site_admin":false},"assignees":[{"login":"twiecki","id":674200,"avatar_url":"https://avatars.githubusercontent.com/u/674200?v=3","gravatar_id":"","url":"https://api.github.com/users/twiecki","html_url":"https://github.com/twiecki","followers_url":"https://api.github.com/users/twiecki/followers","following_url":"https://api.github.com/users/twiecki/following{/other_user}","gists_url":"https://api.github.com/users/twiecki/gists{/gist_id}","starred_url":"https://api.github.com/users/twiecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twiecki/subscriptions","organizations_url":"https://api.github.com/users/twiecki/orgs","repos_url":"https://api.github.com/users/twiecki/repos","events_url":"https://api.github.com/users/twiecki/events{/privacy}","received_events_url":"https://api.github.com/users/twiecki/received_events","type":"User","site_admin":false},{"login":"abhijeetkalyan","id":3505048,"avatar_url":"https://avatars.githubusercontent.com/u/3505048?v=3","gravatar_id":"","url":"https://api.github.com/users/abhijeetkalyan","html_url":"https://github.com/abhijeetkalyan","followers_url":"https://api.github.com/users/abhijeetkalyan/followers","following_url":"https://api.github.com/users/abhijeetkalyan/following{/other_user}","gists_url":"https://api.github.com/users/abhijeetkalyan/gists{/gist_id}","starred_url":"https://api.github.com/users/abhijeetkalyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhijeetkalyan/subscriptions","organizations_url":"https://api.github.com/users/abhijeetkalyan/orgs","repos_url":"https://api.github.com/users/abhijeetkalyan/repos","events_url":"https://api.github.com/users/abhijeetkalyan/events{/privacy}","received_events_url":"https://api.github.com/users/abhijeetkalyan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/332/commits","review_comments_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/332/comments","review_comment_url":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quantopian/pyfolio/issues/332/comments","statuses_url":"https://api.github.com/repos/quantopian/pyfolio/statuses/0ce062c4da51a5dd9654322e9428bf9ad7c9b47e","head":{"label":"quantopian:portfolio-multistrike-cones","ref":"portfolio-multistrike-cones","sha":"0ce062c4da51a5dd9654322e9428bf9ad7c9b47e","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":36670205,"name":"pyfolio","full_name":"quantopian/pyfolio","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/pyfolio","description":"Portfolio and risk analytics in Python","fork":false,"url":"https://api.github.com/repos/quantopian/pyfolio","forks_url":"https://api.github.com/repos/quantopian/pyfolio/forks","keys_url":"https://api.github.com/repos/quantopian/pyfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/pyfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/pyfolio/teams","hooks_url":"https://api.github.com/repos/quantopian/pyfolio/hooks","issue_events_url":"https://api.github.com/repos/quantopian/pyfolio/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/pyfolio/events","assignees_url":"https://api.github.com/repos/quantopian/pyfolio/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/pyfolio/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/pyfolio/tags","blobs_url":"https://api.github.com/repos/quantopian/pyfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/pyfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/pyfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/pyfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/pyfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/pyfolio/languages","stargazers_url":"https://api.github.com/repos/quantopian/pyfolio/stargazers","contributors_url":"https://api.github.com/repos/quantopian/pyfolio/contributors","subscribers_url":"https://api.github.com/repos/quantopian/pyfolio/subscribers","subscription_url":"https://api.github.com/repos/quantopian/pyfolio/subscription","commits_url":"https://api.github.com/repos/quantopian/pyfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/pyfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/pyfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/pyfolio/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/pyfolio/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/pyfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/pyfolio/merges","archive_url":"https://api.github.com/repos/quantopian/pyfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/pyfolio/downloads","issues_url":"https://api.github.com/repos/quantopian/pyfolio/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/pyfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/pyfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/pyfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/pyfolio/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/pyfolio/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/pyfolio/deployments","created_at":"2015-06-01T15:31:39Z","updated_at":"2016-10-03T18:36:13Z","pushed_at":"2016-10-03T19:39:04Z","git_url":"git://github.com/quantopian/pyfolio.git","ssh_url":"git@github.com:quantopian/pyfolio.git","clone_url":"https://github.com/quantopian/pyfolio.git","svn_url":"https://github.com/quantopian/pyfolio","homepage":"http://quantopian.github.io/pyfolio","size":71327,"stargazers_count":762,"watchers_count":762,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":200,"mirror_url":null,"open_issues_count":57,"forks":200,"open_issues":57,"watchers":762,"default_branch":"master"}},"base":{"label":"quantopian:master","ref":"master","sha":"bb31dcea78ee80b4b8462e272116ca62c17dd073","user":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"repo":{"id":36670205,"name":"pyfolio","full_name":"quantopian/pyfolio","owner":{"login":"quantopian","id":1393215,"avatar_url":"https://avatars.githubusercontent.com/u/1393215?v=3","gravatar_id":"","url":"https://api.github.com/users/quantopian","html_url":"https://github.com/quantopian","followers_url":"https://api.github.com/users/quantopian/followers","following_url":"https://api.github.com/users/quantopian/following{/other_user}","gists_url":"https://api.github.com/users/quantopian/gists{/gist_id}","starred_url":"https://api.github.com/users/quantopian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantopian/subscriptions","organizations_url":"https://api.github.com/users/quantopian/orgs","repos_url":"https://api.github.com/users/quantopian/repos","events_url":"https://api.github.com/users/quantopian/events{/privacy}","received_events_url":"https://api.github.com/users/quantopian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quantopian/pyfolio","description":"Portfolio and risk analytics in Python","fork":false,"url":"https://api.github.com/repos/quantopian/pyfolio","forks_url":"https://api.github.com/repos/quantopian/pyfolio/forks","keys_url":"https://api.github.com/repos/quantopian/pyfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantopian/pyfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantopian/pyfolio/teams","hooks_url":"https://api.github.com/repos/quantopian/pyfolio/hooks","issue_events_url":"https://api.github.com/repos/quantopian/pyfolio/issues/events{/number}","events_url":"https://api.github.com/repos/quantopian/pyfolio/events","assignees_url":"https://api.github.com/repos/quantopian/pyfolio/assignees{/user}","branches_url":"https://api.github.com/repos/quantopian/pyfolio/branches{/branch}","tags_url":"https://api.github.com/repos/quantopian/pyfolio/tags","blobs_url":"https://api.github.com/repos/quantopian/pyfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantopian/pyfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantopian/pyfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantopian/pyfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantopian/pyfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/quantopian/pyfolio/languages","stargazers_url":"https://api.github.com/repos/quantopian/pyfolio/stargazers","contributors_url":"https://api.github.com/repos/quantopian/pyfolio/contributors","subscribers_url":"https://api.github.com/repos/quantopian/pyfolio/subscribers","subscription_url":"https://api.github.com/repos/quantopian/pyfolio/subscription","commits_url":"https://api.github.com/repos/quantopian/pyfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantopian/pyfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantopian/pyfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantopian/pyfolio/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantopian/pyfolio/contents/{+path}","compare_url":"https://api.github.com/repos/quantopian/pyfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantopian/pyfolio/merges","archive_url":"https://api.github.com/repos/quantopian/pyfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantopian/pyfolio/downloads","issues_url":"https://api.github.com/repos/quantopian/pyfolio/issues{/number}","pulls_url":"https://api.github.com/repos/quantopian/pyfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/quantopian/pyfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/quantopian/pyfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantopian/pyfolio/labels{/name}","releases_url":"https://api.github.com/repos/quantopian/pyfolio/releases{/id}","deployments_url":"https://api.github.com/repos/quantopian/pyfolio/deployments","created_at":"2015-06-01T15:31:39Z","updated_at":"2016-10-03T18:36:13Z","pushed_at":"2016-10-03T19:39:04Z","git_url":"git://github.com/quantopian/pyfolio.git","ssh_url":"git@github.com:quantopian/pyfolio.git","clone_url":"https://github.com/quantopian/pyfolio.git","svn_url":"https://github.com/quantopian/pyfolio","homepage":"http://quantopian.github.io/pyfolio","size":71327,"stargazers_count":762,"watchers_count":762,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":200,"mirror_url":null,"open_issues_count":57,"forks":200,"open_issues":57,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/332"},"html":{"href":"https://github.com/quantopian/pyfolio/pull/332"},"issue":{"href":"https://api.github.com/repos/quantopian/pyfolio/issues/332"},"comments":{"href":"https://api.github.com/repos/quantopian/pyfolio/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quantopian/pyfolio/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/quantopian/pyfolio/statuses/0ce062c4da51a5dd9654322e9428bf9ad7c9b47e"}}}}
{"actor":{"display_login":"ahgnaw"}}