{"action":"created","comment":{"url":"https://api.github.com/repos/reem/rust-typemap/pulls/comments/52696025","id":52696025,"diff_hunk":"@@ -16,17 +15,19 @@ of `TypeMap`.\n extern crate typemap;\n use typemap::{TypeMap, Key};\n \n-struct KeyType;\n+// Some arbitrary type that we will use as a Key in Typemap\n+struct MyKeyType;\n \n #[derive(Debug, PartialEq)]\n-struct Value(i32);\n+struct MyValueType(i32);\n \n-impl Key for KeyType { type Value = Value; }\n+// The value for the type Key MyKeyType must be an instance of MyValueType","path":"README.md","position":25,"original_position":25,"commit_id":"b100e3c391bc48e8952211c1ae3fe6fddcbded6e","original_commit_id":"b100e3c391bc48e8952211c1ae3fe6fddcbded6e","user":{"login":"reem","id":4745181,"avatar_url":"https://avatars.githubusercontent.com/u/4745181?v=3","gravatar_id":"","url":"https://api.github.com/users/reem","html_url":"https://github.com/reem","followers_url":"https://api.github.com/users/reem/followers","following_url":"https://api.github.com/users/reem/following{/other_user}","gists_url":"https://api.github.com/users/reem/gists{/gist_id}","starred_url":"https://api.github.com/users/reem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reem/subscriptions","organizations_url":"https://api.github.com/users/reem/orgs","repos_url":"https://api.github.com/users/reem/repos","events_url":"https://api.github.com/users/reem/events{/privacy}","received_events_url":"https://api.github.com/users/reem/received_events","type":"User","site_admin":false},"body":"Hmm, this doesn't sound very clear to me; how about \"Define the key-value relationship between MyKeyType and MyValueType.\"?","created_at":"2016-02-12T01:31:39Z","updated_at":"2016-02-12T01:31:39Z","html_url":"https://github.com/reem/rust-typemap/pull/34#discussion_r52696025","pull_request_url":"https://api.github.com/repos/reem/rust-typemap/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/reem/rust-typemap/pulls/comments/52696025"},"html":{"href":"https://github.com/reem/rust-typemap/pull/34#discussion_r52696025"},"pull_request":{"href":"https://api.github.com/repos/reem/rust-typemap/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/reem/rust-typemap/pulls/34","id":59118860,"html_url":"https://github.com/reem/rust-typemap/pull/34","diff_url":"https://github.com/reem/rust-typemap/pull/34.diff","patch_url":"https://github.com/reem/rust-typemap/pull/34.patch","issue_url":"https://api.github.com/repos/reem/rust-typemap/issues/34","number":34,"state":"open","locked":false,"title":"Update README description and example","user":{"login":"echochamber","id":4073509,"avatar_url":"https://avatars.githubusercontent.com/u/4073509?v=3","gravatar_id":"","url":"https://api.github.com/users/echochamber","html_url":"https://github.com/echochamber","followers_url":"https://api.github.com/users/echochamber/followers","following_url":"https://api.github.com/users/echochamber/following{/other_user}","gists_url":"https://api.github.com/users/echochamber/gists{/gist_id}","starred_url":"https://api.github.com/users/echochamber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echochamber/subscriptions","organizations_url":"https://api.github.com/users/echochamber/orgs","repos_url":"https://api.github.com/users/echochamber/repos","events_url":"https://api.github.com/users/echochamber/events{/privacy}","received_events_url":"https://api.github.com/users/echochamber/received_events","type":"User","site_admin":false},"body":"Changed the description to clarify differences between this and AnyType. Also changed the name of a few things in the example to more clearly differentiate between the Structs/Traits defined in the library and the ones that exists only in this example. Makes it easier to understand when looking at it for the first time without prior knowledge of what a TypeMap is.","created_at":"2016-02-12T00:49:58Z","updated_at":"2016-02-12T01:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86087a2da9ed397d5d1db4f9e28675f8275d3302","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/reem/rust-typemap/pulls/34/commits","review_comments_url":"https://api.github.com/repos/reem/rust-typemap/pulls/34/comments","review_comment_url":"https://api.github.com/repos/reem/rust-typemap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reem/rust-typemap/issues/34/comments","statuses_url":"https://api.github.com/repos/reem/rust-typemap/statuses/b100e3c391bc48e8952211c1ae3fe6fddcbded6e","head":{"label":"echochamber:patch-1","ref":"patch-1","sha":"b100e3c391bc48e8952211c1ae3fe6fddcbded6e","user":{"login":"echochamber","id":4073509,"avatar_url":"https://avatars.githubusercontent.com/u/4073509?v=3","gravatar_id":"","url":"https://api.github.com/users/echochamber","html_url":"https://github.com/echochamber","followers_url":"https://api.github.com/users/echochamber/followers","following_url":"https://api.github.com/users/echochamber/following{/other_user}","gists_url":"https://api.github.com/users/echochamber/gists{/gist_id}","starred_url":"https://api.github.com/users/echochamber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echochamber/subscriptions","organizations_url":"https://api.github.com/users/echochamber/orgs","repos_url":"https://api.github.com/users/echochamber/repos","events_url":"https://api.github.com/users/echochamber/events{/privacy}","received_events_url":"https://api.github.com/users/echochamber/received_events","type":"User","site_admin":false},"repo":{"id":51557296,"name":"rust-typemap","full_name":"echochamber/rust-typemap","owner":{"login":"echochamber","id":4073509,"avatar_url":"https://avatars.githubusercontent.com/u/4073509?v=3","gravatar_id":"","url":"https://api.github.com/users/echochamber","html_url":"https://github.com/echochamber","followers_url":"https://api.github.com/users/echochamber/followers","following_url":"https://api.github.com/users/echochamber/following{/other_user}","gists_url":"https://api.github.com/users/echochamber/gists{/gist_id}","starred_url":"https://api.github.com/users/echochamber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echochamber/subscriptions","organizations_url":"https://api.github.com/users/echochamber/orgs","repos_url":"https://api.github.com/users/echochamber/repos","events_url":"https://api.github.com/users/echochamber/events{/privacy}","received_events_url":"https://api.github.com/users/echochamber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/echochamber/rust-typemap","description":"A typesafe store keyed by types and containing different types of values.","fork":true,"url":"https://api.github.com/repos/echochamber/rust-typemap","forks_url":"https://api.github.com/repos/echochamber/rust-typemap/forks","keys_url":"https://api.github.com/repos/echochamber/rust-typemap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/echochamber/rust-typemap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/echochamber/rust-typemap/teams","hooks_url":"https://api.github.com/repos/echochamber/rust-typemap/hooks","issue_events_url":"https://api.github.com/repos/echochamber/rust-typemap/issues/events{/number}","events_url":"https://api.github.com/repos/echochamber/rust-typemap/events","assignees_url":"https://api.github.com/repos/echochamber/rust-typemap/assignees{/user}","branches_url":"https://api.github.com/repos/echochamber/rust-typemap/branches{/branch}","tags_url":"https://api.github.com/repos/echochamber/rust-typemap/tags","blobs_url":"https://api.github.com/repos/echochamber/rust-typemap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/echochamber/rust-typemap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/echochamber/rust-typemap/git/refs{/sha}","trees_url":"https://api.github.com/repos/echochamber/rust-typemap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/echochamber/rust-typemap/statuses/{sha}","languages_url":"https://api.github.com/repos/echochamber/rust-typemap/languages","stargazers_url":"https://api.github.com/repos/echochamber/rust-typemap/stargazers","contributors_url":"https://api.github.com/repos/echochamber/rust-typemap/contributors","subscribers_url":"https://api.github.com/repos/echochamber/rust-typemap/subscribers","subscription_url":"https://api.github.com/repos/echochamber/rust-typemap/subscription","commits_url":"https://api.github.com/repos/echochamber/rust-typemap/commits{/sha}","git_commits_url":"https://api.github.com/repos/echochamber/rust-typemap/git/commits{/sha}","comments_url":"https://api.github.com/repos/echochamber/rust-typemap/comments{/number}","issue_comment_url":"https://api.github.com/repos/echochamber/rust-typemap/issues/comments{/number}","contents_url":"https://api.github.com/repos/echochamber/rust-typemap/contents/{+path}","compare_url":"https://api.github.com/repos/echochamber/rust-typemap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/echochamber/rust-typemap/merges","archive_url":"https://api.github.com/repos/echochamber/rust-typemap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/echochamber/rust-typemap/downloads","issues_url":"https://api.github.com/repos/echochamber/rust-typemap/issues{/number}","pulls_url":"https://api.github.com/repos/echochamber/rust-typemap/pulls{/number}","milestones_url":"https://api.github.com/repos/echochamber/rust-typemap/milestones{/number}","notifications_url":"https://api.github.com/repos/echochamber/rust-typemap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/echochamber/rust-typemap/labels{/name}","releases_url":"https://api.github.com/repos/echochamber/rust-typemap/releases{/id}","deployments_url":"https://api.github.com/repos/echochamber/rust-typemap/deployments","created_at":"2016-02-12T00:13:04Z","updated_at":"2016-02-12T00:13:05Z","pushed_at":"2016-02-12T00:46:40Z","git_url":"git://github.com/echochamber/rust-typemap.git","ssh_url":"git@github.com:echochamber/rust-typemap.git","clone_url":"https://github.com/echochamber/rust-typemap.git","svn_url":"https://github.com/echochamber/rust-typemap","homepage":"","size":52,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reem:master","ref":"master","sha":"35c09780b008b1be9542d2bdb6a97721fa7b4a9f","user":{"login":"reem","id":4745181,"avatar_url":"https://avatars.githubusercontent.com/u/4745181?v=3","gravatar_id":"","url":"https://api.github.com/users/reem","html_url":"https://github.com/reem","followers_url":"https://api.github.com/users/reem/followers","following_url":"https://api.github.com/users/reem/following{/other_user}","gists_url":"https://api.github.com/users/reem/gists{/gist_id}","starred_url":"https://api.github.com/users/reem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reem/subscriptions","organizations_url":"https://api.github.com/users/reem/orgs","repos_url":"https://api.github.com/users/reem/repos","events_url":"https://api.github.com/users/reem/events{/privacy}","received_events_url":"https://api.github.com/users/reem/received_events","type":"User","site_admin":false},"repo":{"id":23103633,"name":"rust-typemap","full_name":"reem/rust-typemap","owner":{"login":"reem","id":4745181,"avatar_url":"https://avatars.githubusercontent.com/u/4745181?v=3","gravatar_id":"","url":"https://api.github.com/users/reem","html_url":"https://github.com/reem","followers_url":"https://api.github.com/users/reem/followers","following_url":"https://api.github.com/users/reem/following{/other_user}","gists_url":"https://api.github.com/users/reem/gists{/gist_id}","starred_url":"https://api.github.com/users/reem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reem/subscriptions","organizations_url":"https://api.github.com/users/reem/orgs","repos_url":"https://api.github.com/users/reem/repos","events_url":"https://api.github.com/users/reem/events{/privacy}","received_events_url":"https://api.github.com/users/reem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reem/rust-typemap","description":"A typesafe store keyed by types and containing different types of values.","fork":false,"url":"https://api.github.com/repos/reem/rust-typemap","forks_url":"https://api.github.com/repos/reem/rust-typemap/forks","keys_url":"https://api.github.com/repos/reem/rust-typemap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reem/rust-typemap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reem/rust-typemap/teams","hooks_url":"https://api.github.com/repos/reem/rust-typemap/hooks","issue_events_url":"https://api.github.com/repos/reem/rust-typemap/issues/events{/number}","events_url":"https://api.github.com/repos/reem/rust-typemap/events","assignees_url":"https://api.github.com/repos/reem/rust-typemap/assignees{/user}","branches_url":"https://api.github.com/repos/reem/rust-typemap/branches{/branch}","tags_url":"https://api.github.com/repos/reem/rust-typemap/tags","blobs_url":"https://api.github.com/repos/reem/rust-typemap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reem/rust-typemap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reem/rust-typemap/git/refs{/sha}","trees_url":"https://api.github.com/repos/reem/rust-typemap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reem/rust-typemap/statuses/{sha}","languages_url":"https://api.github.com/repos/reem/rust-typemap/languages","stargazers_url":"https://api.github.com/repos/reem/rust-typemap/stargazers","contributors_url":"https://api.github.com/repos/reem/rust-typemap/contributors","subscribers_url":"https://api.github.com/repos/reem/rust-typemap/subscribers","subscription_url":"https://api.github.com/repos/reem/rust-typemap/subscription","commits_url":"https://api.github.com/repos/reem/rust-typemap/commits{/sha}","git_commits_url":"https://api.github.com/repos/reem/rust-typemap/git/commits{/sha}","comments_url":"https://api.github.com/repos/reem/rust-typemap/comments{/number}","issue_comment_url":"https://api.github.com/repos/reem/rust-typemap/issues/comments{/number}","contents_url":"https://api.github.com/repos/reem/rust-typemap/contents/{+path}","compare_url":"https://api.github.com/repos/reem/rust-typemap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reem/rust-typemap/merges","archive_url":"https://api.github.com/repos/reem/rust-typemap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reem/rust-typemap/downloads","issues_url":"https://api.github.com/repos/reem/rust-typemap/issues{/number}","pulls_url":"https://api.github.com/repos/reem/rust-typemap/pulls{/number}","milestones_url":"https://api.github.com/repos/reem/rust-typemap/milestones{/number}","notifications_url":"https://api.github.com/repos/reem/rust-typemap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reem/rust-typemap/labels{/name}","releases_url":"https://api.github.com/repos/reem/rust-typemap/releases{/id}","deployments_url":"https://api.github.com/repos/reem/rust-typemap/deployments","created_at":"2014-08-19T09:01:18Z","updated_at":"2016-01-30T19:26:44Z","pushed_at":"2016-02-12T00:49:58Z","git_url":"git://github.com/reem/rust-typemap.git","ssh_url":"git@github.com:reem/rust-typemap.git","clone_url":"https://github.com/reem/rust-typemap.git","svn_url":"https://github.com/reem/rust-typemap","homepage":"","size":57,"stargazers_count":43,"watchers_count":43,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":2,"forks":20,"open_issues":2,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reem/rust-typemap/pulls/34"},"html":{"href":"https://github.com/reem/rust-typemap/pull/34"},"issue":{"href":"https://api.github.com/repos/reem/rust-typemap/issues/34"},"comments":{"href":"https://api.github.com/repos/reem/rust-typemap/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/reem/rust-typemap/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/reem/rust-typemap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reem/rust-typemap/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/reem/rust-typemap/statuses/b100e3c391bc48e8952211c1ae3fe6fddcbded6e"}}}}