{"action":"created","issue":{"url":"https://api.github.com/repos/koalyptus/TableFilter/issues/309","repository_url":"https://api.github.com/repos/koalyptus/TableFilter","labels_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/309/comments","events_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/309/events","html_url":"https://github.com/koalyptus/TableFilter/issues/309","id":181913461,"number":309,"title":"highlightKeywords does not clean properly after unhighlighting","user":{"login":"jerefrer","id":140954,"avatar_url":"https://avatars.githubusercontent.com/u/140954?v=3","gravatar_id":"","url":"https://api.github.com/users/jerefrer","html_url":"https://github.com/jerefrer","followers_url":"https://api.github.com/users/jerefrer/followers","following_url":"https://api.github.com/users/jerefrer/following{/other_user}","gists_url":"https://api.github.com/users/jerefrer/gists{/gist_id}","starred_url":"https://api.github.com/users/jerefrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerefrer/subscriptions","organizations_url":"https://api.github.com/users/jerefrer/orgs","repos_url":"https://api.github.com/users/jerefrer/repos","events_url":"https://api.github.com/users/jerefrer/events{/privacy}","received_events_url":"https://api.github.com/users/jerefrer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-09T21:36:11Z","updated_at":"2016-10-09T22:43:59Z","closed_at":null,"body":"Hi there and many thanks for this quite easy-to-use and powerful piece of work :)\r\n\r\nI realized that after I filter a column with a search term of say 3 chars, then when removing the filter it leaves the original text split in 3 parts : `before the search term` + `the 3 chars of the search term` + `after the search term`.\r\n\r\nThen when trying to search for a term of 4 chars or more, the results are actually filtered but the search terms are no longer highlighted. I guess this happens because the text is actually split from before.\r\n\r\nI would try fixing it myself but I'm afraid I'm not fluent enough in JS to make it as performant as possible.\r\n\r\nAll my love to anyone willing to pick up this fight :bowing_man: "},"comment":{"url":"https://api.github.com/repos/koalyptus/TableFilter/issues/comments/252518313","html_url":"https://github.com/koalyptus/TableFilter/issues/309#issuecomment-252518313","issue_url":"https://api.github.com/repos/koalyptus/TableFilter/issues/309","id":252518313,"user":{"login":"koalyptus","id":8214629,"avatar_url":"https://avatars.githubusercontent.com/u/8214629?v=3","gravatar_id":"","url":"https://api.github.com/users/koalyptus","html_url":"https://github.com/koalyptus","followers_url":"https://api.github.com/users/koalyptus/followers","following_url":"https://api.github.com/users/koalyptus/following{/other_user}","gists_url":"https://api.github.com/users/koalyptus/gists{/gist_id}","starred_url":"https://api.github.com/users/koalyptus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koalyptus/subscriptions","organizations_url":"https://api.github.com/users/koalyptus/orgs","repos_url":"https://api.github.com/users/koalyptus/repos","events_url":"https://api.github.com/users/koalyptus/events{/privacy}","received_events_url":"https://api.github.com/users/koalyptus/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T22:43:59Z","updated_at":"2016-10-09T22:43:59Z","body":"I am able to reproduce this issue on latest version (v0.3.1) on http://koalyptus.github.io/TableFilter/highlight-keywords.html demo page.\r\nThanks for pointing this out, I will try to sneak a fix in in one of next release(s).\r\nCheers "}}
{"actor":{"display_login":"koalyptus"}}