{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/92554828","pull_request_review_id":13071904,"id":92554828,"diff_hunk":"@@ -294,11 +296,18 @@ public void close() throws Exception {\n \t\t\t\tlastStateSnapshot.toString(), checkpointId, checkpointTimestamp);\n \t\t}\n \n-\t\treturn lastStateSnapshot;\n+\t\tList<Tuple2<KinesisStreamShard, SequenceNumber>> listState = new ArrayList<>(lastStateSnapshot.size());\n+\t\tfor (Map.Entry<KinesisStreamShard, SequenceNumber> entry: lastStateSnapshot.entrySet()) {","path":"flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java","position":60,"original_position":60,"commit_id":"955212609161031e69573d339ca6eb41e0801f2c","original_commit_id":"955212609161031e69573d339ca6eb41e0801f2c","user":{"login":"tzulitai","id":5284370,"avatar_url":"https://avatars.githubusercontent.com/u/5284370?v=3","gravatar_id":"","url":"https://api.github.com/users/tzulitai","html_url":"https://github.com/tzulitai","followers_url":"https://api.github.com/users/tzulitai/followers","following_url":"https://api.github.com/users/tzulitai/following{/other_user}","gists_url":"https://api.github.com/users/tzulitai/gists{/gist_id}","starred_url":"https://api.github.com/users/tzulitai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzulitai/subscriptions","organizations_url":"https://api.github.com/users/tzulitai/orgs","repos_url":"https://api.github.com/users/tzulitai/repos","events_url":"https://api.github.com/users/tzulitai/events{/privacy}","received_events_url":"https://api.github.com/users/tzulitai/received_events","type":"User","site_admin":false},"body":"formatting nit: need empty space before colon `:`","created_at":"2016-12-15T07:12:17Z","updated_at":"2016-12-15T07:21:19Z","html_url":"https://github.com/apache/flink/pull/3001#discussion_r92554828","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/3001","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/92554828"},"html":{"href":"https://github.com/apache/flink/pull/3001#discussion_r92554828"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/3001"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/3001","id":97876358,"html_url":"https://github.com/apache/flink/pull/3001","diff_url":"https://github.com/apache/flink/pull/3001.diff","patch_url":"https://github.com/apache/flink/pull/3001.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/3001","number":3001,"state":"open","locked":false,"title":"[FLINK-4821] [kinesis] Implement rescalable non-partitioned state for Kinesis Connector","user":{"login":"tony810430","id":14329393,"avatar_url":"https://avatars.githubusercontent.com/u/14329393?v=3","gravatar_id":"","url":"https://api.github.com/users/tony810430","html_url":"https://github.com/tony810430","followers_url":"https://api.github.com/users/tony810430/followers","following_url":"https://api.github.com/users/tony810430/following{/other_user}","gists_url":"https://api.github.com/users/tony810430/gists{/gist_id}","starred_url":"https://api.github.com/users/tony810430/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony810430/subscriptions","organizations_url":"https://api.github.com/users/tony810430/orgs","repos_url":"https://api.github.com/users/tony810430/repos","events_url":"https://api.github.com/users/tony810430/events{/privacy}","received_events_url":"https://api.github.com/users/tony810430/received_events","type":"User","site_admin":false},"body":"Implement ListCheckpointed interface on Kinesis Consumer\r\n\r\nAs a reminder, I returned empty list instead of null in some cases in the snapshotState, because snapshotState method in AbstractUdfStreamOperator didn't handle the situation when list is null and would get NullPointeException in the foreach statement. (see line 106 to line 119 in AbstractUdfStreamOperator)","created_at":"2016-12-14T02:30:26Z","updated_at":"2016-12-15T07:21:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbf9c112e4c64d40df60c648e697c5e867182d1a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/3001/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/3001/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/3001/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/955212609161031e69573d339ca6eb41e0801f2c","head":{"label":"tony810430:FLINK-4821","ref":"FLINK-4821","sha":"955212609161031e69573d339ca6eb41e0801f2c","user":{"login":"tony810430","id":14329393,"avatar_url":"https://avatars.githubusercontent.com/u/14329393?v=3","gravatar_id":"","url":"https://api.github.com/users/tony810430","html_url":"https://github.com/tony810430","followers_url":"https://api.github.com/users/tony810430/followers","following_url":"https://api.github.com/users/tony810430/following{/other_user}","gists_url":"https://api.github.com/users/tony810430/gists{/gist_id}","starred_url":"https://api.github.com/users/tony810430/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony810430/subscriptions","organizations_url":"https://api.github.com/users/tony810430/orgs","repos_url":"https://api.github.com/users/tony810430/repos","events_url":"https://api.github.com/users/tony810430/events{/privacy}","received_events_url":"https://api.github.com/users/tony810430/received_events","type":"User","site_admin":false},"repo":{"id":73358257,"name":"flink","full_name":"tony810430/flink","owner":{"login":"tony810430","id":14329393,"avatar_url":"https://avatars.githubusercontent.com/u/14329393?v=3","gravatar_id":"","url":"https://api.github.com/users/tony810430","html_url":"https://github.com/tony810430","followers_url":"https://api.github.com/users/tony810430/followers","following_url":"https://api.github.com/users/tony810430/following{/other_user}","gists_url":"https://api.github.com/users/tony810430/gists{/gist_id}","starred_url":"https://api.github.com/users/tony810430/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony810430/subscriptions","organizations_url":"https://api.github.com/users/tony810430/orgs","repos_url":"https://api.github.com/users/tony810430/repos","events_url":"https://api.github.com/users/tony810430/events{/privacy}","received_events_url":"https://api.github.com/users/tony810430/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tony810430/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/tony810430/flink","forks_url":"https://api.github.com/repos/tony810430/flink/forks","keys_url":"https://api.github.com/repos/tony810430/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tony810430/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tony810430/flink/teams","hooks_url":"https://api.github.com/repos/tony810430/flink/hooks","issue_events_url":"https://api.github.com/repos/tony810430/flink/issues/events{/number}","events_url":"https://api.github.com/repos/tony810430/flink/events","assignees_url":"https://api.github.com/repos/tony810430/flink/assignees{/user}","branches_url":"https://api.github.com/repos/tony810430/flink/branches{/branch}","tags_url":"https://api.github.com/repos/tony810430/flink/tags","blobs_url":"https://api.github.com/repos/tony810430/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tony810430/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tony810430/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/tony810430/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tony810430/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/tony810430/flink/languages","stargazers_url":"https://api.github.com/repos/tony810430/flink/stargazers","contributors_url":"https://api.github.com/repos/tony810430/flink/contributors","subscribers_url":"https://api.github.com/repos/tony810430/flink/subscribers","subscription_url":"https://api.github.com/repos/tony810430/flink/subscription","commits_url":"https://api.github.com/repos/tony810430/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/tony810430/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/tony810430/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/tony810430/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/tony810430/flink/contents/{+path}","compare_url":"https://api.github.com/repos/tony810430/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tony810430/flink/merges","archive_url":"https://api.github.com/repos/tony810430/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tony810430/flink/downloads","issues_url":"https://api.github.com/repos/tony810430/flink/issues{/number}","pulls_url":"https://api.github.com/repos/tony810430/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/tony810430/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/tony810430/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tony810430/flink/labels{/name}","releases_url":"https://api.github.com/repos/tony810430/flink/releases{/id}","deployments_url":"https://api.github.com/repos/tony810430/flink/deployments","created_at":"2016-11-10T07:42:21Z","updated_at":"2016-11-10T07:42:51Z","pushed_at":"2016-12-14T13:53:25Z","git_url":"git://github.com/tony810430/flink.git","ssh_url":"git@github.com:tony810430/flink.git","clone_url":"https://github.com/tony810430/flink.git","svn_url":"https://github.com/tony810430/flink","homepage":null,"size":107355,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e4c767a372fb0db840b8288a54d8712c660779f5","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-12-15T03:39:30Z","pushed_at":"2016-12-15T06:52:19Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":109657,"stargazers_count":1822,"watchers_count":1822,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1249,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":191,"forks":1249,"open_issues":191,"watchers":1822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/3001"},"html":{"href":"https://github.com/apache/flink/pull/3001"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/3001"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/3001/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/3001/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/3001/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/955212609161031e69573d339ca6eb41e0801f2c"}}}}
{"actor":{"display_login":"tzulitai"}}