{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/78460377","id":78460377,"diff_hunk":"@@ -234,6 +234,13 @@ static function &fields() {\n           'dataPattern' => '',\n           'export' => true,\n         ) ,\n+        'activity_free_text_search' => array(","path":"CRM/Activity/DAO/Activity.php","position":null,"original_position":4,"commit_id":"02c87f33205a50a7761accd7929ce22bae98c278","original_commit_id":"0276f82215e6de20f373f7bd183a381af72d9992","user":{"login":"seamuslee001","id":6799125,"avatar_url":"https://avatars.githubusercontent.com/u/6799125?v=3","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false},"body":"Hi @ravi-sharma what i was meaning is i think this added code and the getFreeTextFields() need to move into https://github.com/civicrm/civicrm-core/blob/master/CRM/Activity/BAO/Activity.php and then called from there, Unless you are actually planning on adding a column to the civicrm_activity table this is the wrong place. \r\n\r\nThe DAO class is designed to be just about mimicking the database, these get regenerated whenever the schema changes. Most code should either go in the form layer or in the BAO class which is for the Business logic","created_at":"2016-09-12T21:41:31Z","updated_at":"2016-09-12T21:41:31Z","html_url":"https://github.com/civicrm/civicrm-core/pull/8992#discussion_r78460377","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/78460377"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/8992#discussion_r78460377"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992","id":84110289,"html_url":"https://github.com/civicrm/civicrm-core/pull/8992","diff_url":"https://github.com/civicrm/civicrm-core/pull/8992.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/8992.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/8992","number":8992,"state":"open","locked":false,"title":"(WIP) Free text advance search.","user":{"login":"ravi-sharma","id":3090090,"avatar_url":"https://avatars.githubusercontent.com/u/3090090?v=3","gravatar_id":"","url":"https://api.github.com/users/ravi-sharma","html_url":"https://github.com/ravi-sharma","followers_url":"https://api.github.com/users/ravi-sharma/followers","following_url":"https://api.github.com/users/ravi-sharma/following{/other_user}","gists_url":"https://api.github.com/users/ravi-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/ravi-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravi-sharma/subscriptions","organizations_url":"https://api.github.com/users/ravi-sharma/orgs","repos_url":"https://api.github.com/users/ravi-sharma/repos","events_url":"https://api.github.com/users/ravi-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/ravi-sharma/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-06T12:08:03Z","updated_at":"2016-09-12T21:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2c3eeb6e2bf0e157aff2f46f91f8dc72613229","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/8992/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/02c87f33205a50a7761accd7929ce22bae98c278","head":{"label":"ravi-sharma:free-text-search","ref":"free-text-search","sha":"02c87f33205a50a7761accd7929ce22bae98c278","user":{"login":"ravi-sharma","id":3090090,"avatar_url":"https://avatars.githubusercontent.com/u/3090090?v=3","gravatar_id":"","url":"https://api.github.com/users/ravi-sharma","html_url":"https://github.com/ravi-sharma","followers_url":"https://api.github.com/users/ravi-sharma/followers","following_url":"https://api.github.com/users/ravi-sharma/following{/other_user}","gists_url":"https://api.github.com/users/ravi-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/ravi-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravi-sharma/subscriptions","organizations_url":"https://api.github.com/users/ravi-sharma/orgs","repos_url":"https://api.github.com/users/ravi-sharma/repos","events_url":"https://api.github.com/users/ravi-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/ravi-sharma/received_events","type":"User","site_admin":false},"repo":{"id":66239767,"name":"civicrm-core","full_name":"ravi-sharma/civicrm-core","owner":{"login":"ravi-sharma","id":3090090,"avatar_url":"https://avatars.githubusercontent.com/u/3090090?v=3","gravatar_id":"","url":"https://api.github.com/users/ravi-sharma","html_url":"https://github.com/ravi-sharma","followers_url":"https://api.github.com/users/ravi-sharma/followers","following_url":"https://api.github.com/users/ravi-sharma/following{/other_user}","gists_url":"https://api.github.com/users/ravi-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/ravi-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravi-sharma/subscriptions","organizations_url":"https://api.github.com/users/ravi-sharma/orgs","repos_url":"https://api.github.com/users/ravi-sharma/repos","events_url":"https://api.github.com/users/ravi-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/ravi-sharma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravi-sharma/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/ravi-sharma/civicrm-core","forks_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/forks","keys_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/teams","hooks_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/events","assignees_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/tags","blobs_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/subscription","commits_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/merges","archive_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/downloads","issues_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/ravi-sharma/civicrm-core/deployments","created_at":"2016-08-22T04:33:10Z","updated_at":"2016-08-22T04:33:26Z","pushed_at":"2016-09-12T17:49:54Z","git_url":"git://github.com/ravi-sharma/civicrm-core.git","ssh_url":"git@github.com:ravi-sharma/civicrm-core.git","clone_url":"https://github.com/ravi-sharma/civicrm-core.git","svn_url":"https://github.com/ravi-sharma/civicrm-core","homepage":null,"size":129779,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"a40f03c89e0d094f3db18ef6f0a411b8a68afddd","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2016-09-09T06:49:05Z","pushed_at":"2016-09-12T20:47:29Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":167456,"stargazers_count":165,"watchers_count":165,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":468,"mirror_url":null,"open_issues_count":149,"forks":468,"open_issues":149,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/8992"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/8992"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/8992/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/8992/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/02c87f33205a50a7761accd7929ce22bae98c278"}}}}
{"actor":{"display_login":"seamuslee001"}}