{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-expressive/pulls/comments/88850305","pull_request_review_id":9405695,"id":88850305,"diff_hunk":"@@ -0,0 +1,25 @@\n+<?php\n+/**\n+ * @see       https://github.com/zendframework/zend-expressive for the canonical source repository\n+ * @copyright Copyright (c) 2016 Zend Technologies USA Inc. (http://www.zend.com)\n+ * @license   https://github.com/zendframework/zend-expressive/blob/master/LICENSE.md New BSD License\n+ */\n+\n+namespace Zend\\Expressive\\Container;\n+\n+use Interop\\Container\\ContainerInterface;\n+use Zend\\Expressive\\Middleware\\WhoopsErrorResponseGenerator;\n+\n+class WhoopsErrorResponseGeneratorFactory\n+{\n+    /**\n+     * @param ContainerInterface $container\n+     * @return WhoopsErrorResponseGenerator\n+     */\n+    public function __invoke(ContainerInterface $container)\n+    {\n+        return new WhoopsErrorResponseGenerator(\n+            $container->get('Zend\\Expressive\\Whoops')","path":"src/Container/WhoopsErrorResponseGeneratorFactory.php","position":22,"original_position":22,"commit_id":"485cbedb5a3c522e08cb7ba2b835c355d91d4f78","original_commit_id":"485cbedb5a3c522e08cb7ba2b835c355d91d4f78","user":{"login":"webimpress","id":7423207,"avatar_url":"https://avatars.githubusercontent.com/u/7423207?v=3","gravatar_id":"","url":"https://api.github.com/users/webimpress","html_url":"https://github.com/webimpress","followers_url":"https://api.github.com/users/webimpress/followers","following_url":"https://api.github.com/users/webimpress/following{/other_user}","gists_url":"https://api.github.com/users/webimpress/gists{/gist_id}","starred_url":"https://api.github.com/users/webimpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webimpress/subscriptions","organizations_url":"https://api.github.com/users/webimpress/orgs","repos_url":"https://api.github.com/users/webimpress/repos","events_url":"https://api.github.com/users/webimpress/events{/privacy}","received_events_url":"https://api.github.com/users/webimpress/received_events","type":"User","site_admin":false},"body":"Should we use `::class` here?","created_at":"2016-11-21T08:55:46Z","updated_at":"2016-11-21T08:57:27Z","html_url":"https://github.com/zendframework/zend-expressive/pull/396#discussion_r88850305","pull_request_url":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-expressive/pulls/comments/88850305"},"html":{"href":"https://github.com/zendframework/zend-expressive/pull/396#discussion_r88850305"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396","id":93409995,"html_url":"https://github.com/zendframework/zend-expressive/pull/396","diff_url":"https://github.com/zendframework/zend-expressive/pull/396.diff","patch_url":"https://github.com/zendframework/zend-expressive/pull/396.patch","issue_url":"https://api.github.com/repos/zendframework/zend-expressive/issues/396","number":396,"state":"open","locked":false,"title":"Implement programmatic pipeline features","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"This patch implements the [Programmatic Pipelines RFC requirements](https://gist.github.com/weierophinney/a983f733c2ff3c9b3a687625e012e6e1#requirements-for-expressive-11).\r\n\r\nTODO\r\n----\r\n\r\n- [x] Create `Zend\\Expressive\\Middleware\\ErrorResponseGenerator`\r\n- [x] Create `Zend\\Expressive\\Middleware\\WhoopsErrorResponseGenerator`\r\n- [x] Create `Zend\\Expressive\\Middleware\\NotFoundHandler`\r\n- [x] Create `Zend\\Expressive\\Container\\ErrorResponseGeneratorFactory`\r\n- [x] Create `Zend\\Expressive\\Container\\WhoopsErrorResponseGeneratorFactory`\r\n- [x] Create `Zend\\Expressive\\Container\\NotFoundHandlerFactory`\r\n- [x] Create `Zend\\Expressive\\Container\\ErrorHandlerFactory`\r\n- [x] Create `Zend\\Expressive\\ApplicationConfigInjectionTrait`, and compose it into `Application`.\r\n- [x] Update `Zend\\Expressive\\Container\\ApplicationFactory` to vary creation and return of the `Application` instance based on the `zend-expressive.programmatic_pipeline` configuration flag.\r\n- [x] Update `Zend\\Expressive\\Container\\ApplicationFactory` to use the methods defined in `ApplicationConfigInjectionTrait` to inject pipeline and routed middleware from configuration into the `Application` instance.\r\n- [x] Update `Zend\\Expressive\\Application` to emit a deprecation notice from `pipeErrorMiddleware()`.\r\n- [x] Update `Zend\\Expressive\\MarshalMiddlewareTrait` to allow marshalling http-interop middleware.\r\n- [x] Add support for \"raise throwables\" flag to `ApplicationFactory`.\r\n- [x] Tool for generating programmatic pipelines and routing from existing configuration.\r\n    - [x] working proof of concept\r\n    - [x] unit tests\r\n    - [x] tool should push the `OriginalMessages` middleware as the outermost layer of the pipe.\r\n- [x] Tool for migrating `getOriginal*()` calls to `getAttribute(*)` calls on the request object.\r\n- [ ] Tool for identifying error middleware in an existing application.\r\n- [x] Documentation\r\n\r\nReferences\r\n----------\r\n\r\n- [Programmatic Pipelines RFC](https://gist.github.com/weierophinney/a983f733c2ff3c9b3a687625e012e6e1)\r\n- #392 (original draft of error handler classes)\r\n- [Stratigility 1.3/2.0 migration docs](https://docs.zendframework.com/zend-stratigility/migration/to-v2/)","created_at":"2016-11-11T22:40:16Z","updated_at":"2016-11-21T08:57:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5285fb8715a6ce678ad62d6ed4a9e1cf5ca2b47f","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zendframework/zend-expressive/milestones/15","html_url":"https://github.com/zendframework/zend-expressive/milestones/1.1.0","labels_url":"https://api.github.com/repos/zendframework/zend-expressive/milestones/15/labels","id":1497861,"number":15,"title":"1.1.0","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":3,"state":"open","created_at":"2016-01-11T17:34:09Z","updated_at":"2016-11-11T22:41:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-expressive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive/issues/396/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive/statuses/485cbedb5a3c522e08cb7ba2b835c355d91d4f78","head":{"label":"weierophinney:feature/programmatic","ref":"feature/programmatic","sha":"485cbedb5a3c522e08cb7ba2b835c355d91d4f78","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"repo":{"id":40145470,"name":"zend-expressive","full_name":"weierophinney/zend-expressive","owner":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weierophinney/zend-expressive","description":"Start to develop PSR-7 middleware applications in PHP in a minute!","fork":true,"url":"https://api.github.com/repos/weierophinney/zend-expressive","forks_url":"https://api.github.com/repos/weierophinney/zend-expressive/forks","keys_url":"https://api.github.com/repos/weierophinney/zend-expressive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weierophinney/zend-expressive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weierophinney/zend-expressive/teams","hooks_url":"https://api.github.com/repos/weierophinney/zend-expressive/hooks","issue_events_url":"https://api.github.com/repos/weierophinney/zend-expressive/issues/events{/number}","events_url":"https://api.github.com/repos/weierophinney/zend-expressive/events","assignees_url":"https://api.github.com/repos/weierophinney/zend-expressive/assignees{/user}","branches_url":"https://api.github.com/repos/weierophinney/zend-expressive/branches{/branch}","tags_url":"https://api.github.com/repos/weierophinney/zend-expressive/tags","blobs_url":"https://api.github.com/repos/weierophinney/zend-expressive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weierophinney/zend-expressive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weierophinney/zend-expressive/git/refs{/sha}","trees_url":"https://api.github.com/repos/weierophinney/zend-expressive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weierophinney/zend-expressive/statuses/{sha}","languages_url":"https://api.github.com/repos/weierophinney/zend-expressive/languages","stargazers_url":"https://api.github.com/repos/weierophinney/zend-expressive/stargazers","contributors_url":"https://api.github.com/repos/weierophinney/zend-expressive/contributors","subscribers_url":"https://api.github.com/repos/weierophinney/zend-expressive/subscribers","subscription_url":"https://api.github.com/repos/weierophinney/zend-expressive/subscription","commits_url":"https://api.github.com/repos/weierophinney/zend-expressive/commits{/sha}","git_commits_url":"https://api.github.com/repos/weierophinney/zend-expressive/git/commits{/sha}","comments_url":"https://api.github.com/repos/weierophinney/zend-expressive/comments{/number}","issue_comment_url":"https://api.github.com/repos/weierophinney/zend-expressive/issues/comments{/number}","contents_url":"https://api.github.com/repos/weierophinney/zend-expressive/contents/{+path}","compare_url":"https://api.github.com/repos/weierophinney/zend-expressive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weierophinney/zend-expressive/merges","archive_url":"https://api.github.com/repos/weierophinney/zend-expressive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weierophinney/zend-expressive/downloads","issues_url":"https://api.github.com/repos/weierophinney/zend-expressive/issues{/number}","pulls_url":"https://api.github.com/repos/weierophinney/zend-expressive/pulls{/number}","milestones_url":"https://api.github.com/repos/weierophinney/zend-expressive/milestones{/number}","notifications_url":"https://api.github.com/repos/weierophinney/zend-expressive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weierophinney/zend-expressive/labels{/name}","releases_url":"https://api.github.com/repos/weierophinney/zend-expressive/releases{/id}","deployments_url":"https://api.github.com/repos/weierophinney/zend-expressive/deployments","created_at":"2015-08-03T20:06:05Z","updated_at":"2015-08-03T20:06:06Z","pushed_at":"2016-11-20T18:15:08Z","git_url":"git://github.com/weierophinney/zend-expressive.git","ssh_url":"git@github.com:weierophinney/zend-expressive.git","clone_url":"https://github.com/weierophinney/zend-expressive.git","svn_url":"https://github.com/weierophinney/zend-expressive","homepage":null,"size":2084,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:develop","ref":"develop","sha":"8c751a13154c1e0ab81a8365858600cf2f33bf83","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":40017341,"name":"zend-expressive","full_name":"zendframework/zend-expressive","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-expressive","description":"Start to develop PSR-7 middleware applications in PHP in a minute!","fork":false,"url":"https://api.github.com/repos/zendframework/zend-expressive","forks_url":"https://api.github.com/repos/zendframework/zend-expressive/forks","keys_url":"https://api.github.com/repos/zendframework/zend-expressive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-expressive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-expressive/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-expressive/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-expressive/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-expressive/events","assignees_url":"https://api.github.com/repos/zendframework/zend-expressive/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-expressive/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-expressive/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-expressive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-expressive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-expressive/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-expressive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-expressive/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-expressive/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-expressive/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-expressive/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-expressive/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-expressive/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-expressive/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-expressive/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-expressive/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-expressive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-expressive/merges","archive_url":"https://api.github.com/repos/zendframework/zend-expressive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-expressive/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-expressive/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-expressive/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-expressive/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-expressive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-expressive/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-expressive/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-expressive/deployments","created_at":"2015-07-31T17:45:22Z","updated_at":"2016-11-19T22:14:24Z","pushed_at":"2016-11-20T18:15:09Z","git_url":"git://github.com/zendframework/zend-expressive.git","ssh_url":"git@github.com:zendframework/zend-expressive.git","clone_url":"https://github.com/zendframework/zend-expressive.git","svn_url":"https://github.com/zendframework/zend-expressive","homepage":null,"size":3840,"stargazers_count":459,"watchers_count":459,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":113,"mirror_url":null,"open_issues_count":31,"forks":113,"open_issues":31,"watchers":459,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396"},"html":{"href":"https://github.com/zendframework/zend-expressive/pull/396"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-expressive/issues/396"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-expressive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-expressive/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-expressive/statuses/485cbedb5a3c522e08cb7ba2b835c355d91d4f78"}}}}
{"actor":{"display_login":"webimpress"}}