{"action":"created","comment":{"url":"https://api.github.com/repos/erikrose/peep/pulls/comments/50294123","id":50294123,"diff_hunk":"@@ -362,9 +362,11 @@ def package_finder(argv):\n     # Carry over PackageFinder kwargs that have [about] the same names as\n     # options attr names:\n     possible_options = [\n-        'find_links', FORMAT_CONTROL_ARG, 'allow_external', 'allow_unverified',","path":"peep.py","position":13,"original_position":13,"commit_id":"bd02af7f2f8eb470c07b1fa2770646f3ce96454e","original_commit_id":"bd02af7f2f8eb470c07b1fa2770646f3ce96454e","user":{"login":"erikrose","id":295816,"avatar_url":"https://avatars.githubusercontent.com/u/295816?v=3","gravatar_id":"","url":"https://api.github.com/users/erikrose","html_url":"https://github.com/erikrose","followers_url":"https://api.github.com/users/erikrose/followers","following_url":"https://api.github.com/users/erikrose/following{/other_user}","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","organizations_url":"https://api.github.com/users/erikrose/orgs","repos_url":"https://api.github.com/users/erikrose/repos","events_url":"https://api.github.com/users/erikrose/events{/privacy}","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","site_admin":false},"body":"I don't think we ought to remove allow_external and allow_all_external; there's nothing wrong (from a security standpoint—especially when checking hashes) with downloading from sites other than PyPI. Can we stick these in a branch? We might as well bring back allow_unverified while we're at it.","created_at":"2016-01-20T18:12:05Z","updated_at":"2016-01-20T18:12:05Z","html_url":"https://github.com/erikrose/peep/pull/113#discussion_r50294123","pull_request_url":"https://api.github.com/repos/erikrose/peep/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/erikrose/peep/pulls/comments/50294123"},"html":{"href":"https://github.com/erikrose/peep/pull/113#discussion_r50294123"},"pull_request":{"href":"https://api.github.com/repos/erikrose/peep/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/erikrose/peep/pulls/113","id":56643814,"html_url":"https://github.com/erikrose/peep/pull/113","diff_url":"https://github.com/erikrose/peep/pull/113.diff","patch_url":"https://github.com/erikrose/peep/pull/113.patch","issue_url":"https://api.github.com/repos/erikrose/peep/issues/113","number":113,"state":"open","locked":false,"title":"Add support for pip 8.x","user":{"login":"edmorley","id":501702,"avatar_url":"https://avatars.githubusercontent.com/u/501702?v=3","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"body":"Pip 8 has deprecated the `--allow-external`, `--allow-unverified` and `--allow-all-external` options, since they they now a no-op after changes to PyPI, even with older versions of pip:\r\nhttps://github.com/pypa/pip/pull/3070#issuecomment-137464224\r\n\r\nRemoving handling for these in peep does not affect older versions of pip, but avoids an exception for each removed option with pip v8:\r\n`TypeError: __init__() got an unexpected keyword argument 'allow_unverified'`\r\n\r\nWhilst pip v8 adds native hashing support, it's helpful for peep to support v8 so that users can separate the \"update pip\" and \"switch from peep to pip hashes\" steps.\r\n\r\nFixes #112.\r\n\r\nCC @erikrose ","created_at":"2016-01-20T17:56:49Z","updated_at":"2016-01-20T18:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43a62e0312dac4eb18bdadf0e4661b5b18bd8433","assignee":{"login":"edmorley","id":501702,"avatar_url":"https://avatars.githubusercontent.com/u/501702?v=3","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/erikrose/peep/pulls/113/commits","review_comments_url":"https://api.github.com/repos/erikrose/peep/pulls/113/comments","review_comment_url":"https://api.github.com/repos/erikrose/peep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/erikrose/peep/issues/113/comments","statuses_url":"https://api.github.com/repos/erikrose/peep/statuses/bd02af7f2f8eb470c07b1fa2770646f3ce96454e","head":{"label":"edmorley:support-pip-v8","ref":"support-pip-v8","sha":"bd02af7f2f8eb470c07b1fa2770646f3ce96454e","user":{"login":"edmorley","id":501702,"avatar_url":"https://avatars.githubusercontent.com/u/501702?v=3","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"repo":{"id":32046421,"name":"peep","full_name":"edmorley/peep","owner":{"login":"edmorley","id":501702,"avatar_url":"https://avatars.githubusercontent.com/u/501702?v=3","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edmorley/peep","description":"A \"pip install\" that is cryptographically guaranteed repeatable","fork":true,"url":"https://api.github.com/repos/edmorley/peep","forks_url":"https://api.github.com/repos/edmorley/peep/forks","keys_url":"https://api.github.com/repos/edmorley/peep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edmorley/peep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edmorley/peep/teams","hooks_url":"https://api.github.com/repos/edmorley/peep/hooks","issue_events_url":"https://api.github.com/repos/edmorley/peep/issues/events{/number}","events_url":"https://api.github.com/repos/edmorley/peep/events","assignees_url":"https://api.github.com/repos/edmorley/peep/assignees{/user}","branches_url":"https://api.github.com/repos/edmorley/peep/branches{/branch}","tags_url":"https://api.github.com/repos/edmorley/peep/tags","blobs_url":"https://api.github.com/repos/edmorley/peep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edmorley/peep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edmorley/peep/git/refs{/sha}","trees_url":"https://api.github.com/repos/edmorley/peep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edmorley/peep/statuses/{sha}","languages_url":"https://api.github.com/repos/edmorley/peep/languages","stargazers_url":"https://api.github.com/repos/edmorley/peep/stargazers","contributors_url":"https://api.github.com/repos/edmorley/peep/contributors","subscribers_url":"https://api.github.com/repos/edmorley/peep/subscribers","subscription_url":"https://api.github.com/repos/edmorley/peep/subscription","commits_url":"https://api.github.com/repos/edmorley/peep/commits{/sha}","git_commits_url":"https://api.github.com/repos/edmorley/peep/git/commits{/sha}","comments_url":"https://api.github.com/repos/edmorley/peep/comments{/number}","issue_comment_url":"https://api.github.com/repos/edmorley/peep/issues/comments{/number}","contents_url":"https://api.github.com/repos/edmorley/peep/contents/{+path}","compare_url":"https://api.github.com/repos/edmorley/peep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edmorley/peep/merges","archive_url":"https://api.github.com/repos/edmorley/peep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edmorley/peep/downloads","issues_url":"https://api.github.com/repos/edmorley/peep/issues{/number}","pulls_url":"https://api.github.com/repos/edmorley/peep/pulls{/number}","milestones_url":"https://api.github.com/repos/edmorley/peep/milestones{/number}","notifications_url":"https://api.github.com/repos/edmorley/peep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edmorley/peep/labels{/name}","releases_url":"https://api.github.com/repos/edmorley/peep/releases{/id}","created_at":"2015-03-11T23:21:33Z","updated_at":"2016-01-20T16:44:15Z","pushed_at":"2016-01-20T17:54:56Z","git_url":"git://github.com/edmorley/peep.git","ssh_url":"git@github.com:edmorley/peep.git","clone_url":"https://github.com/edmorley/peep.git","svn_url":"https://github.com/edmorley/peep","homepage":null,"size":306,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"erikrose:master","ref":"master","sha":"4215691b9fdcdad7297141976c5dccca26427aa8","user":{"login":"erikrose","id":295816,"avatar_url":"https://avatars.githubusercontent.com/u/295816?v=3","gravatar_id":"","url":"https://api.github.com/users/erikrose","html_url":"https://github.com/erikrose","followers_url":"https://api.github.com/users/erikrose/followers","following_url":"https://api.github.com/users/erikrose/following{/other_user}","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","organizations_url":"https://api.github.com/users/erikrose/orgs","repos_url":"https://api.github.com/users/erikrose/repos","events_url":"https://api.github.com/users/erikrose/events{/privacy}","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","site_admin":false},"repo":{"id":10850960,"name":"peep","full_name":"erikrose/peep","owner":{"login":"erikrose","id":295816,"avatar_url":"https://avatars.githubusercontent.com/u/295816?v=3","gravatar_id":"","url":"https://api.github.com/users/erikrose","html_url":"https://github.com/erikrose","followers_url":"https://api.github.com/users/erikrose/followers","following_url":"https://api.github.com/users/erikrose/following{/other_user}","gists_url":"https://api.github.com/users/erikrose/gists{/gist_id}","starred_url":"https://api.github.com/users/erikrose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikrose/subscriptions","organizations_url":"https://api.github.com/users/erikrose/orgs","repos_url":"https://api.github.com/users/erikrose/repos","events_url":"https://api.github.com/users/erikrose/events{/privacy}","received_events_url":"https://api.github.com/users/erikrose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erikrose/peep","description":"A \"pip install\" that is cryptographically guaranteed repeatable","fork":false,"url":"https://api.github.com/repos/erikrose/peep","forks_url":"https://api.github.com/repos/erikrose/peep/forks","keys_url":"https://api.github.com/repos/erikrose/peep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erikrose/peep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erikrose/peep/teams","hooks_url":"https://api.github.com/repos/erikrose/peep/hooks","issue_events_url":"https://api.github.com/repos/erikrose/peep/issues/events{/number}","events_url":"https://api.github.com/repos/erikrose/peep/events","assignees_url":"https://api.github.com/repos/erikrose/peep/assignees{/user}","branches_url":"https://api.github.com/repos/erikrose/peep/branches{/branch}","tags_url":"https://api.github.com/repos/erikrose/peep/tags","blobs_url":"https://api.github.com/repos/erikrose/peep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erikrose/peep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erikrose/peep/git/refs{/sha}","trees_url":"https://api.github.com/repos/erikrose/peep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erikrose/peep/statuses/{sha}","languages_url":"https://api.github.com/repos/erikrose/peep/languages","stargazers_url":"https://api.github.com/repos/erikrose/peep/stargazers","contributors_url":"https://api.github.com/repos/erikrose/peep/contributors","subscribers_url":"https://api.github.com/repos/erikrose/peep/subscribers","subscription_url":"https://api.github.com/repos/erikrose/peep/subscription","commits_url":"https://api.github.com/repos/erikrose/peep/commits{/sha}","git_commits_url":"https://api.github.com/repos/erikrose/peep/git/commits{/sha}","comments_url":"https://api.github.com/repos/erikrose/peep/comments{/number}","issue_comment_url":"https://api.github.com/repos/erikrose/peep/issues/comments{/number}","contents_url":"https://api.github.com/repos/erikrose/peep/contents/{+path}","compare_url":"https://api.github.com/repos/erikrose/peep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erikrose/peep/merges","archive_url":"https://api.github.com/repos/erikrose/peep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erikrose/peep/downloads","issues_url":"https://api.github.com/repos/erikrose/peep/issues{/number}","pulls_url":"https://api.github.com/repos/erikrose/peep/pulls{/number}","milestones_url":"https://api.github.com/repos/erikrose/peep/milestones{/number}","notifications_url":"https://api.github.com/repos/erikrose/peep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erikrose/peep/labels{/name}","releases_url":"https://api.github.com/repos/erikrose/peep/releases{/id}","created_at":"2013-06-21T19:44:59Z","updated_at":"2016-01-05T17:17:15Z","pushed_at":"2016-01-20T17:56:51Z","git_url":"git://github.com/erikrose/peep.git","ssh_url":"git@github.com:erikrose/peep.git","clone_url":"https://github.com/erikrose/peep.git","svn_url":"https://github.com/erikrose/peep","homepage":null,"size":379,"stargazers_count":231,"watchers_count":231,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":22,"forks":30,"open_issues":22,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/erikrose/peep/pulls/113"},"html":{"href":"https://github.com/erikrose/peep/pull/113"},"issue":{"href":"https://api.github.com/repos/erikrose/peep/issues/113"},"comments":{"href":"https://api.github.com/repos/erikrose/peep/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/erikrose/peep/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/erikrose/peep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/erikrose/peep/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/erikrose/peep/statuses/bd02af7f2f8eb470c07b1fa2770646f3ce96454e"}}}}