{"action":"closed","issue":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/444","repository_url":"https://api.github.com/repos/iea-annex60/modelica-annex60","labels_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/444/labels{/name}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/444/comments","events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/444/events","html_url":"https://github.com/iea-annex60/modelica-annex60/issues/444","id":142726432,"number":444,"title":"redesign flow functions","user":{"login":"Mathadon","id":5970879,"avatar_url":"https://avatars.githubusercontent.com/u/5970879?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathadon","html_url":"https://github.com/Mathadon","followers_url":"https://api.github.com/users/Mathadon/followers","following_url":"https://api.github.com/users/Mathadon/following{/other_user}","gists_url":"https://api.github.com/users/Mathadon/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathadon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathadon/subscriptions","organizations_url":"https://api.github.com/users/Mathadon/orgs","repos_url":"https://api.github.com/users/Mathadon/repos","events_url":"https://api.github.com/users/Mathadon/events{/privacy}","received_events_url":"https://api.github.com/users/Mathadon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-03-22T17:47:26Z","updated_at":"2016-10-23T13:01:29Z","closed_at":"2016-10-23T13:01:29Z","body":"I have a proposal to redesign the flow function implementation. The idea is to use a block (or even a twoport?) instead of a function. This would have three advantages.\r\n\r\n1)\r\nFixed coefficients can be precomputed inside the block. Right now this is not possible in functions since this removes the ability to inline the code inside the function. This leads to more operations and worse performance.\r\n\r\n2)\r\nCurrently the options from_dp=true and from_dp=false lead to more complex code (if/else clauses). The same is true for homotopy initalisation and the option to linearise the pressure drop equations. This code is also duplicated in multiple components. Concentrating this code in one block would avoid this.\r\n\r\n3)\r\nMaking a block would allow the addition of many more flow functions (such as 1) linear flow, 2) quadratic flow and 3) the new one including both quadratic and laminar flow), which can then be selected using an enumeration record.\r\n\r\nCould be interesting?\r\n"}}
{"actor":{"display_login":"mwetter"}}