{"action":"created","issue":{"url":"https://api.github.com/repos/dfahlander/Dexie.js/issues/290","repository_url":"https://api.github.com/repos/dfahlander/Dexie.js","labels_url":"https://api.github.com/repos/dfahlander/Dexie.js/issues/290/labels{/name}","comments_url":"https://api.github.com/repos/dfahlander/Dexie.js/issues/290/comments","events_url":"https://api.github.com/repos/dfahlander/Dexie.js/issues/290/events","html_url":"https://github.com/dfahlander/Dexie.js/pull/290","id":164936241,"number":290,"title":"Delete table only if new schema explicitly sets it to null","user":{"login":"prannayb","id":908535,"avatar_url":"https://avatars.githubusercontent.com/u/908535?v=3","gravatar_id":"","url":"https://api.github.com/users/prannayb","html_url":"https://github.com/prannayb","followers_url":"https://api.github.com/users/prannayb/followers","following_url":"https://api.github.com/users/prannayb/following{/other_user}","gists_url":"https://api.github.com/users/prannayb/gists{/gist_id}","starred_url":"https://api.github.com/users/prannayb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prannayb/subscriptions","organizations_url":"https://api.github.com/users/prannayb/orgs","repos_url":"https://api.github.com/users/prannayb/repos","events_url":"https://api.github.com/users/prannayb/events{/privacy}","received_events_url":"https://api.github.com/users/prannayb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-11T21:15:41Z","updated_at":"2016-07-14T20:10:11Z","closed_at":"2016-07-14T02:09:04Z","pull_request":{"url":"https://api.github.com/repos/dfahlander/Dexie.js/pulls/290","html_url":"https://github.com/dfahlander/Dexie.js/pull/290","diff_url":"https://github.com/dfahlander/Dexie.js/pull/290.diff","patch_url":"https://github.com/dfahlander/Dexie.js/pull/290.patch"},"body":"The double equal also returns true if a value is undefined. Meaning, if the new schema does not have a table name, we'll delete it. This breaks the \"updates-only schema for new versions\" pattern recommended by dexie best practices. To fix this, explicitly check for null."},"comment":{"url":"https://api.github.com/repos/dfahlander/Dexie.js/issues/comments/232777743","html_url":"https://github.com/dfahlander/Dexie.js/pull/290#issuecomment-232777743","issue_url":"https://api.github.com/repos/dfahlander/Dexie.js/issues/290","id":232777743,"user":{"login":"prannayb","id":908535,"avatar_url":"https://avatars.githubusercontent.com/u/908535?v=3","gravatar_id":"","url":"https://api.github.com/users/prannayb","html_url":"https://github.com/prannayb","followers_url":"https://api.github.com/users/prannayb/followers","following_url":"https://api.github.com/users/prannayb/following{/other_user}","gists_url":"https://api.github.com/users/prannayb/gists{/gist_id}","starred_url":"https://api.github.com/users/prannayb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prannayb/subscriptions","organizations_url":"https://api.github.com/users/prannayb/orgs","repos_url":"https://api.github.com/users/prannayb/repos","events_url":"https://api.github.com/users/prannayb/events{/privacy}","received_events_url":"https://api.github.com/users/prannayb/received_events","type":"User","site_admin":false},"created_at":"2016-07-14T20:10:11Z","updated_at":"2016-07-14T20:10:11Z","body":"Hey Chris, I was only trying to upgade two versions changes at once. I had a need to change the primary key of a table. So I created two versions upgrades, v2 had table marked as null and v3 had table with new primary key. I didn't want to preserve table data, but I couldn't get dexie to allow me to do this. My PR was only something I thought was a bug that it would delete tables not in the currently-being-processed version upgrade. I'll wait on the primary key upgrade that you're working on instead. Thanks for the review!"}}
{"actor":{"display_login":"prannayb"}}