{"action":"created","issue":{"url":"https://api.github.com/repos/kokkos/kokkos/issues/431","repository_url":"https://api.github.com/repos/kokkos/kokkos","labels_url":"https://api.github.com/repos/kokkos/kokkos/issues/431/labels{/name}","comments_url":"https://api.github.com/repos/kokkos/kokkos/issues/431/comments","events_url":"https://api.github.com/repos/kokkos/kokkos/issues/431/events","html_url":"https://github.com/kokkos/kokkos/pull/431","id":177070575,"number":431,"title":"Disable GTest pthread use if Pthread not enabled","user":{"login":"gsjaardema","id":897294,"avatar_url":"https://avatars.githubusercontent.com/u/897294?v=3","gravatar_id":"","url":"https://api.github.com/users/gsjaardema","html_url":"https://github.com/gsjaardema","followers_url":"https://api.github.com/users/gsjaardema/followers","following_url":"https://api.github.com/users/gsjaardema/following{/other_user}","gists_url":"https://api.github.com/users/gsjaardema/gists{/gist_id}","starred_url":"https://api.github.com/users/gsjaardema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsjaardema/subscriptions","organizations_url":"https://api.github.com/users/gsjaardema/orgs","repos_url":"https://api.github.com/users/gsjaardema/repos","events_url":"https://api.github.com/users/gsjaardema/events{/privacy}","received_events_url":"https://api.github.com/users/gsjaardema/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-15T02:11:08Z","updated_at":"2016-10-27T13:11:27Z","closed_at":"2016-10-26T15:56:16Z","pull_request":{"url":"https://api.github.com/repos/kokkos/kokkos/pulls/431","html_url":"https://github.com/kokkos/kokkos/pull/431","diff_url":"https://github.com/kokkos/kokkos/pull/431.diff","patch_url":"https://github.com/kokkos/kokkos/pull/431.patch"},"body":"Not sure where the best location for this test is, but if TPL_ENABLE_Pthread is not enabled, then Gtest has to be told to not enable Pthread use also.  Currently, the following code in gtest.h will enable pthreads if GTEST_HAS_PTHREAD is not defined externally:\r\n\r\n```\r\n// Determines whether Google Test can use the pthreads library.\r\n#ifndef GTEST_HAS_PTHREAD\r\n// The user didn't tell us explicitly, so we assume pthreads support is\r\n// available on Linux and Mac.\r\n//\r\n// To disable threading support in Google Test, add -DGTEST_HAS_PTHREAD=0\r\n// to your compiler flags.\r\n# define GTEST_HAS_PTHREAD (GTEST_OS_LINUX || GTEST_OS_MAC || GTEST_OS_HPUX \\\r\n    || GTEST_OS_QNX)\r\n#endif  // GTEST_HAS_PTHREAD\r\n```\r\n\r\nThis will enable gtest pthread use even if TPL_ENABLE_Pthread is disabled which can result in undefined symbols when linking.\r\n\r\nI may be missing some other configuration setting that handles this."},"comment":{"url":"https://api.github.com/repos/kokkos/kokkos/issues/comments/256636270","html_url":"https://github.com/kokkos/kokkos/pull/431#issuecomment-256636270","issue_url":"https://api.github.com/repos/kokkos/kokkos/issues/431","id":256636270,"user":{"login":"gsjaardema","id":897294,"avatar_url":"https://avatars.githubusercontent.com/u/897294?v=3","gravatar_id":"","url":"https://api.github.com/users/gsjaardema","html_url":"https://github.com/gsjaardema","followers_url":"https://api.github.com/users/gsjaardema/followers","following_url":"https://api.github.com/users/gsjaardema/following{/other_user}","gists_url":"https://api.github.com/users/gsjaardema/gists{/gist_id}","starred_url":"https://api.github.com/users/gsjaardema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsjaardema/subscriptions","organizations_url":"https://api.github.com/users/gsjaardema/orgs","repos_url":"https://api.github.com/users/gsjaardema/repos","events_url":"https://api.github.com/users/gsjaardema/events{/privacy}","received_events_url":"https://api.github.com/users/gsjaardema/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T13:11:26Z","updated_at":"2016-10-27T13:11:26Z","body":"Thanks."}}
{"actor":{"display_login":"gsjaardema"}}