{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/86585524","pull_request_review_id":7239175,"id":86585524,"diff_hunk":"@@ -0,0 +1,133 @@\n+define([\n+    'bean',\n+    'qwery',\n+    'common/utils/$',\n+    'common/utils/template',\n+    'common/views/svg',\n+    'common/utils/fastdom-promise',\n+    'common/utils/mediator',\n+    'text!common/views/contributions-membership-epic.html',\n+    'common/utils/robust',\n+    'inlineSvg!svgs/icon/arrow-right',\n+    'common/utils/config',\n+    'common/utils/cookies',\n+    'common/modules/experiments/embed',\n+    'common/utils/ajax',\n+    'common/modules/commercial/commercial-features'\n+\n+], function (bean,\n+             qwery,\n+             $,\n+             template,\n+             svg,\n+             fastdom,\n+             mediator,\n+             contributionsEpic,\n+             robust,\n+             arrowRight,\n+             config,\n+             cookies,\n+             embed,\n+             ajax,\n+             commercialFeatures\n+) {\n+\n+\n+    return function () {\n+\n+        this.id = 'ContributionsMembershipEpicSideBySide';\n+        this.start = '2016-11-04';\n+        this.expiry = '2016-11-07';\n+        this.author = 'Jonathan Rankin';\n+        this.description = 'Find out if offering membership and contributions side by side with equal weighting is as effective as just offering membership by itself';\n+        this.showForSensitive = true;\n+        this.audience = 0;\n+        this.audienceOffset = 0.1;\n+        this.successMeasure = 'Impressions to number of contributions/supporter signups';\n+        this.audienceCriteria = 'All users in US and UK who are not reading articles about Brexit';\n+        this.dataLinkNames = '';\n+        this.idealOutcome = 'One of the 2 variants proves to be a clear winner';\n+        this.canRun = function () {\n+            var userHasNeverContributed = !cookies.get('gu.contributions.contrib-timestamp');\n+            var worksWellWithPageTemplate = (config.page.contentType === 'Article'); // may render badly on other types\n+            var keywords = config.page.keywordIds.split(',');\n+            var nonKeywordTagIds = config.page.nonKeywordTagIds.split(',');\n+            var isNotAboutBrexit = (keywords.indexOf('politics/eu-referendum') == -1) && (nonKeywordTagIds.indexOf('tone/news') == -1);","path":"static/src/javascripts/projects/common/modules/experiments/tests/contributions-membership-epic-side-by-side.js","position":55,"original_position":55,"commit_id":"66acf911ee5fa9476131c92f38e9dac2026e3ee8","original_commit_id":"66acf911ee5fa9476131c92f38e9dac2026e3ee8","user":{"login":"jfsoul","id":8754692,"avatar_url":"https://avatars.githubusercontent.com/u/8754692?v=3","gravatar_id":"","url":"https://api.github.com/users/jfsoul","html_url":"https://github.com/jfsoul","followers_url":"https://api.github.com/users/jfsoul/followers","following_url":"https://api.github.com/users/jfsoul/following{/other_user}","gists_url":"https://api.github.com/users/jfsoul/gists{/gist_id}","starred_url":"https://api.github.com/users/jfsoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfsoul/subscriptions","organizations_url":"https://api.github.com/users/jfsoul/orgs","repos_url":"https://api.github.com/users/jfsoul/repos","events_url":"https://api.github.com/users/jfsoul/events{/privacy}","received_events_url":"https://api.github.com/users/jfsoul/received_events","type":"User","site_admin":false},"body":"Also you'll want `===` instead of `==`.","created_at":"2016-11-04T16:44:15Z","updated_at":"2016-11-04T16:44:16Z","html_url":"https://github.com/guardian/frontend/pull/14895#discussion_r86585524","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/14895","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/86585524"},"html":{"href":"https://github.com/guardian/frontend/pull/14895#discussion_r86585524"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14895"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/14895","id":92373636,"html_url":"https://github.com/guardian/frontend/pull/14895","diff_url":"https://github.com/guardian/frontend/pull/14895.diff","patch_url":"https://github.com/guardian/frontend/pull/14895.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/14895","number":14895,"state":"open","locked":false,"title":"Contributions Membership side by side test.","user":{"login":"jranks123","id":2844554,"avatar_url":"https://avatars.githubusercontent.com/u/2844554?v=3","gravatar_id":"","url":"https://api.github.com/users/jranks123","html_url":"https://github.com/jranks123","followers_url":"https://api.github.com/users/jranks123/followers","following_url":"https://api.github.com/users/jranks123/following{/other_user}","gists_url":"https://api.github.com/users/jranks123/gists{/gist_id}","starred_url":"https://api.github.com/users/jranks123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jranks123/subscriptions","organizations_url":"https://api.github.com/users/jranks123/orgs","repos_url":"https://api.github.com/users/jranks123/repos","events_url":"https://api.github.com/users/jranks123/events{/privacy}","received_events_url":"https://api.github.com/users/jranks123/received_events","type":"User","site_admin":false},"body":"<!--\r\n[We'd love some feedback on any struggles you had with this PR](https://goo.gl/forms/QRQaco334CdpfmNF2).\r\nAll the questions are optional. Any amount of feedback is great!\r\n-->\r\n\r\n## What does this change?\r\n\r\nPreviously, we tested Contributions by itself vs Contributions with a small Membership ask and Membership with a small Contributions ask. \r\n\r\nWe now want to test just Membership vs Membership and Contributions side by side. We also don't want to run it on articles about Brexit.\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nWe will learn what the effect of having equally weighted Contributions and Membership asks is, against just Membership. \r\n\r\n\r\n\r\n<!--\r\nIf setting up an AB test, make sure you have read our [AB testing doc](https://github.com/guardian/frontend/blob/master/docs/03-dev-howtos/01-ab-testing.md).\r\n-->\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\n<!--\r\nRun the AMP test suite with `make validate-amp`\r\n\r\nYou should also validate a specific page that your change affects by adding the amp query string along with the development hash: http://localhost:3000/sport/2016/aug/25/katie-ledecky-first-pitch-washington-nationals-bryce-harper?amp=1#development=1\r\n\r\nThe AMP validation results will appear in your console.\r\n-->\r\n\r\n## Screenshots\r\n![screenshot at nov 04 16-26-08](https://cloud.githubusercontent.com/assets/2844554/20013821/7f28920c-a2ac-11e6-8a4d-8d78b9082701.png)\r\n![screenshot at nov 04 16-26-24](https://cloud.githubusercontent.com/assets/2844554/20013823/7f2e1ce0-a2ac-11e6-8fa7-bbca70d3ac90.png)\r\n![screenshot at nov 04 16-27-02](https://cloud.githubusercontent.com/assets/2844554/20013822/7f29255a-a2ac-11e6-920a-160dee6de730.png)\r\n\r\n## Request for comment\r\n\r\n\r\n<!--\r\n*Does this PR meet the [contributing guidelines](https://github.com/guardian/frontend/blob/issue_pr_templates/.github/CONTRIBUTING.md#submission)?*\r\n-->\r\n","created_at":"2016-11-04T16:34:22Z","updated_at":"2016-11-04T16:44:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d45d430f47efbd18234e9b5274b4d6793f505b14","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/14895/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/14895/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/14895/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/66acf911ee5fa9476131c92f38e9dac2026e3ee8","head":{"label":"guardian:contributionsMembershipNewTest","ref":"contributionsMembershipNewTest","sha":"66acf911ee5fa9476131c92f38e9dac2026e3ee8","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-11-02T19:05:51Z","pushed_at":"2016-11-04T16:34:22Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":552194,"stargazers_count":3384,"watchers_count":3384,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":55,"forks":359,"open_issues":55,"watchers":3384,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"1c4b26eebf3a2413a4b167d663c455aadd26aef0","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-11-02T19:05:51Z","pushed_at":"2016-11-04T16:34:22Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":552194,"stargazers_count":3384,"watchers_count":3384,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"open_issues_count":55,"forks":359,"open_issues":55,"watchers":3384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14895"},"html":{"href":"https://github.com/guardian/frontend/pull/14895"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/14895"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/14895/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14895/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14895/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/66acf911ee5fa9476131c92f38e9dac2026e3ee8"}}}}
{"actor":{"display_login":"jfsoul"}}