{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/quasar/pulls/comments/89871102","pull_request_review_id":10402207,"id":89871102,"diff_hunk":"@@ -0,0 +1,49 @@\n+import sys\n+import config\n+import MySQLdb\n+import MySQLdb.converters\n+\n+### Create DB Connection with Appropriate Conversions\n+#   Conversions inherited from Josh's other ETL scripts.\n+conv_dict = MySQLdb.converters.conversions.copy()","path":"etl-scripts/create_mobile_master_lookup_lite.py","position":8,"original_position":8,"commit_id":"8482b8834c58b5646323abf9e08327d2ed303364","original_commit_id":"8482b8834c58b5646323abf9e08327d2ed303364","user":{"login":"mshmsh5000","id":149811,"avatar_url":"https://avatars.githubusercontent.com/u/149811?v=3","gravatar_id":"","url":"https://api.github.com/users/mshmsh5000","html_url":"https://github.com/mshmsh5000","followers_url":"https://api.github.com/users/mshmsh5000/followers","following_url":"https://api.github.com/users/mshmsh5000/following{/other_user}","gists_url":"https://api.github.com/users/mshmsh5000/gists{/gist_id}","starred_url":"https://api.github.com/users/mshmsh5000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshmsh5000/subscriptions","organizations_url":"https://api.github.com/users/mshmsh5000/orgs","repos_url":"https://api.github.com/users/mshmsh5000/repos","events_url":"https://api.github.com/users/mshmsh5000/events{/privacy}","received_events_url":"https://api.github.com/users/mshmsh5000/received_events","type":"User","site_admin":false},"body":"Asking out of ignorance: Do we still need all of this `converters` business?","created_at":"2016-11-28T20:00:39Z","updated_at":"2016-11-28T20:58:02Z","html_url":"https://github.com/DoSomething/quasar/pull/266#discussion_r89871102","pull_request_url":"https://api.github.com/repos/DoSomething/quasar/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/quasar/pulls/comments/89871102"},"html":{"href":"https://github.com/DoSomething/quasar/pull/266#discussion_r89871102"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/quasar/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/quasar/pulls/266","id":93858763,"html_url":"https://github.com/DoSomething/quasar/pull/266","diff_url":"https://github.com/DoSomething/quasar/pull/266.diff","patch_url":"https://github.com/DoSomething/quasar/pull/266.patch","issue_url":"https://api.github.com/repos/DoSomething/quasar/issues/266","number":266,"state":"open","locked":false,"title":"Adding refactored MailChimp Subscribers Script for RedShift.","user":{"login":"sheyd","id":4562565,"avatar_url":"https://avatars.githubusercontent.com/u/4562565?v=3","gravatar_id":"","url":"https://api.github.com/users/sheyd","html_url":"https://github.com/sheyd","followers_url":"https://api.github.com/users/sheyd/followers","following_url":"https://api.github.com/users/sheyd/following{/other_user}","gists_url":"https://api.github.com/users/sheyd/gists{/gist_id}","starred_url":"https://api.github.com/users/sheyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheyd/subscriptions","organizations_url":"https://api.github.com/users/sheyd/orgs","repos_url":"https://api.github.com/users/sheyd/repos","events_url":"https://api.github.com/users/sheyd/events{/privacy}","received_events_url":"https://api.github.com/users/sheyd/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\n\r\n* Moves all ETL Scripts currently run in Hubble to Quasar Public repo.\r\n* All scripts updated to use Python 3.\r\n* Keeping the config in the same path as repo, but private, so added to .gitignore.\r\n* All scripts that were written by @joshcusano have been pre-pended with `jc_`.\r\n* Re-factored `run_update.sh` script to use Python MySQL wrappers.\r\n\r\n#### Where should the reviewer start?\r\n\r\nAll the files below. @mshmsh5000 I've sent you original ETL repo link via Slack so you can compare between the two.\r\n\r\n#### How should this be manually tested?\r\n\r\n* Tested in Quasar.\r\n\r\n#### What are the relevant tickets?\r\nhttps://github.com/DoSomething/quasar/issues/259\r\n\r\n","created_at":"2016-11-15T22:09:48Z","updated_at":"2016-11-28T20:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bd1282c250b36e1d56af3be0e062a7ad090d24d","assignee":{"login":"mshmsh5000","id":149811,"avatar_url":"https://avatars.githubusercontent.com/u/149811?v=3","gravatar_id":"","url":"https://api.github.com/users/mshmsh5000","html_url":"https://github.com/mshmsh5000","followers_url":"https://api.github.com/users/mshmsh5000/followers","following_url":"https://api.github.com/users/mshmsh5000/following{/other_user}","gists_url":"https://api.github.com/users/mshmsh5000/gists{/gist_id}","starred_url":"https://api.github.com/users/mshmsh5000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshmsh5000/subscriptions","organizations_url":"https://api.github.com/users/mshmsh5000/orgs","repos_url":"https://api.github.com/users/mshmsh5000/repos","events_url":"https://api.github.com/users/mshmsh5000/events{/privacy}","received_events_url":"https://api.github.com/users/mshmsh5000/received_events","type":"User","site_admin":false},"assignees":[{"login":"mshmsh5000","id":149811,"avatar_url":"https://avatars.githubusercontent.com/u/149811?v=3","gravatar_id":"","url":"https://api.github.com/users/mshmsh5000","html_url":"https://github.com/mshmsh5000","followers_url":"https://api.github.com/users/mshmsh5000/followers","following_url":"https://api.github.com/users/mshmsh5000/following{/other_user}","gists_url":"https://api.github.com/users/mshmsh5000/gists{/gist_id}","starred_url":"https://api.github.com/users/mshmsh5000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshmsh5000/subscriptions","organizations_url":"https://api.github.com/users/mshmsh5000/orgs","repos_url":"https://api.github.com/users/mshmsh5000/repos","events_url":"https://api.github.com/users/mshmsh5000/events{/privacy}","received_events_url":"https://api.github.com/users/mshmsh5000/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/quasar/pulls/266/commits","review_comments_url":"https://api.github.com/repos/DoSomething/quasar/pulls/266/comments","review_comment_url":"https://api.github.com/repos/DoSomething/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/quasar/issues/266/comments","statuses_url":"https://api.github.com/repos/DoSomething/quasar/statuses/8482b8834c58b5646323abf9e08327d2ed303364","head":{"label":"DoSomething:etl-hubble-v1","ref":"etl-hubble-v1","sha":"8482b8834c58b5646323abf9e08327d2ed303364","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":42329799,"name":"quasar","full_name":"DoSomething/quasar","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/quasar","description":":cyclone: The DoSomething data platform (ETL, Data Pipeline, Data Warehousing, etc.)","fork":false,"url":"https://api.github.com/repos/DoSomething/quasar","forks_url":"https://api.github.com/repos/DoSomething/quasar/forks","keys_url":"https://api.github.com/repos/DoSomething/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/quasar/teams","hooks_url":"https://api.github.com/repos/DoSomething/quasar/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/quasar/events","assignees_url":"https://api.github.com/repos/DoSomething/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/quasar/tags","blobs_url":"https://api.github.com/repos/DoSomething/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/quasar/languages","stargazers_url":"https://api.github.com/repos/DoSomething/quasar/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/quasar/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/quasar/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/quasar/subscription","commits_url":"https://api.github.com/repos/DoSomething/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/quasar/merges","archive_url":"https://api.github.com/repos/DoSomething/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/quasar/downloads","issues_url":"https://api.github.com/repos/DoSomething/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/quasar/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/quasar/deployments","created_at":"2015-09-11T20:07:42Z","updated_at":"2016-07-06T20:23:08Z","pushed_at":"2016-11-28T18:24:49Z","git_url":"git://github.com/DoSomething/quasar.git","ssh_url":"git@github.com:DoSomething/quasar.git","clone_url":"https://github.com/DoSomething/quasar.git","svn_url":"https://github.com/DoSomething/quasar","homepage":"","size":151,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":37,"forks":0,"open_issues":37,"watchers":0,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"a91827c8d694f3ac5e84e8e3d51bfb807c34e280","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":42329799,"name":"quasar","full_name":"DoSomething/quasar","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/quasar","description":":cyclone: The DoSomething data platform (ETL, Data Pipeline, Data Warehousing, etc.)","fork":false,"url":"https://api.github.com/repos/DoSomething/quasar","forks_url":"https://api.github.com/repos/DoSomething/quasar/forks","keys_url":"https://api.github.com/repos/DoSomething/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/quasar/teams","hooks_url":"https://api.github.com/repos/DoSomething/quasar/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/quasar/events","assignees_url":"https://api.github.com/repos/DoSomething/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/quasar/tags","blobs_url":"https://api.github.com/repos/DoSomething/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/quasar/languages","stargazers_url":"https://api.github.com/repos/DoSomething/quasar/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/quasar/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/quasar/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/quasar/subscription","commits_url":"https://api.github.com/repos/DoSomething/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/quasar/merges","archive_url":"https://api.github.com/repos/DoSomething/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/quasar/downloads","issues_url":"https://api.github.com/repos/DoSomething/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/quasar/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/quasar/deployments","created_at":"2015-09-11T20:07:42Z","updated_at":"2016-07-06T20:23:08Z","pushed_at":"2016-11-28T18:24:49Z","git_url":"git://github.com/DoSomething/quasar.git","ssh_url":"git@github.com:DoSomething/quasar.git","clone_url":"https://github.com/DoSomething/quasar.git","svn_url":"https://github.com/DoSomething/quasar","homepage":"","size":151,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":37,"forks":0,"open_issues":37,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/quasar/pulls/266"},"html":{"href":"https://github.com/DoSomething/quasar/pull/266"},"issue":{"href":"https://api.github.com/repos/DoSomething/quasar/issues/266"},"comments":{"href":"https://api.github.com/repos/DoSomething/quasar/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/quasar/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/quasar/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/quasar/statuses/8482b8834c58b5646323abf9e08327d2ed303364"}}}}
{"actor":{"display_login":"mshmsh5000"}}