{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/57519724","id":57519724,"diff_hunk":"@@ -43,6 +43,8 @@ New Features\n \n - ``astropy.modeling``\n \n+  - Added the fittable=True attribute to the Scale and Shift models with tests.\n+","path":"CHANGES.rst","position":5,"original_position":5,"commit_id":"66309f33456e5ca26607cc988cffa04497a8fa9b","original_commit_id":"66309f33456e5ca26607cc988cffa04497a8fa9b","user":{"login":"nden","id":1110361,"avatar_url":"https://avatars.githubusercontent.com/u/1110361?v=3","gravatar_id":"","url":"https://api.github.com/users/nden","html_url":"https://github.com/nden","followers_url":"https://api.github.com/users/nden/followers","following_url":"https://api.github.com/users/nden/following{/other_user}","gists_url":"https://api.github.com/users/nden/gists{/gist_id}","starred_url":"https://api.github.com/users/nden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nden/subscriptions","organizations_url":"https://api.github.com/users/nden/orgs","repos_url":"https://api.github.com/users/nden/repos","events_url":"https://api.github.com/users/nden/events{/privacy}","received_events_url":"https://api.github.com/users/nden/received_events","type":"User","site_admin":false},"body":"Could you add the issue/PR number at the end, e.g. [4721].","created_at":"2016-03-26T21:19:21Z","updated_at":"2016-03-26T21:19:21Z","html_url":"https://github.com/astropy/astropy/pull/4721#discussion_r57519724","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/4721","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/57519724"},"html":{"href":"https://github.com/astropy/astropy/pull/4721#discussion_r57519724"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4721"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4721","id":63845861,"html_url":"https://github.com/astropy/astropy/pull/4721","diff_url":"https://github.com/astropy/astropy/pull/4721.diff","patch_url":"https://github.com/astropy/astropy/pull/4721.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4721","number":4721,"state":"open","locked":false,"title":"Fix #4718 - Make Scale and Shift models fittable","user":{"login":"pkrskr","id":10918388,"avatar_url":"https://avatars.githubusercontent.com/u/10918388?v=3","gravatar_id":"","url":"https://api.github.com/users/pkrskr","html_url":"https://github.com/pkrskr","followers_url":"https://api.github.com/users/pkrskr/followers","following_url":"https://api.github.com/users/pkrskr/following{/other_user}","gists_url":"https://api.github.com/users/pkrskr/gists{/gist_id}","starred_url":"https://api.github.com/users/pkrskr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkrskr/subscriptions","organizations_url":"https://api.github.com/users/pkrskr/orgs","repos_url":"https://api.github.com/users/pkrskr/repos","events_url":"https://api.github.com/users/pkrskr/events{/privacy}","received_events_url":"https://api.github.com/users/pkrskr/received_events","type":"User","site_admin":false},"body":"Hope this fixes the issue. I have added the `fittable=True` attribute to the Scale and Shift models, made tests for them in test_functional_models.py and added a changelog entry in CHANGES.rst","created_at":"2016-03-23T08:23:14Z","updated_at":"2016-03-26T21:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"312a9cb3f0e4c21b57a9c14a537914edfd2a32d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/4721/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/4721/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4721/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/66309f33456e5ca26607cc988cffa04497a8fa9b","head":{"label":"pkrskr:fix-4718","ref":"fix-4718","sha":"66309f33456e5ca26607cc988cffa04497a8fa9b","user":{"login":"pkrskr","id":10918388,"avatar_url":"https://avatars.githubusercontent.com/u/10918388?v=3","gravatar_id":"","url":"https://api.github.com/users/pkrskr","html_url":"https://github.com/pkrskr","followers_url":"https://api.github.com/users/pkrskr/followers","following_url":"https://api.github.com/users/pkrskr/following{/other_user}","gists_url":"https://api.github.com/users/pkrskr/gists{/gist_id}","starred_url":"https://api.github.com/users/pkrskr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkrskr/subscriptions","organizations_url":"https://api.github.com/users/pkrskr/orgs","repos_url":"https://api.github.com/users/pkrskr/repos","events_url":"https://api.github.com/users/pkrskr/events{/privacy}","received_events_url":"https://api.github.com/users/pkrskr/received_events","type":"User","site_admin":false},"repo":{"id":54173531,"name":"astropy","full_name":"pkrskr/astropy","owner":{"login":"pkrskr","id":10918388,"avatar_url":"https://avatars.githubusercontent.com/u/10918388?v=3","gravatar_id":"","url":"https://api.github.com/users/pkrskr","html_url":"https://github.com/pkrskr","followers_url":"https://api.github.com/users/pkrskr/followers","following_url":"https://api.github.com/users/pkrskr/following{/other_user}","gists_url":"https://api.github.com/users/pkrskr/gists{/gist_id}","starred_url":"https://api.github.com/users/pkrskr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkrskr/subscriptions","organizations_url":"https://api.github.com/users/pkrskr/orgs","repos_url":"https://api.github.com/users/pkrskr/repos","events_url":"https://api.github.com/users/pkrskr/events{/privacy}","received_events_url":"https://api.github.com/users/pkrskr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkrskr/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/pkrskr/astropy","forks_url":"https://api.github.com/repos/pkrskr/astropy/forks","keys_url":"https://api.github.com/repos/pkrskr/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkrskr/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkrskr/astropy/teams","hooks_url":"https://api.github.com/repos/pkrskr/astropy/hooks","issue_events_url":"https://api.github.com/repos/pkrskr/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/pkrskr/astropy/events","assignees_url":"https://api.github.com/repos/pkrskr/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/pkrskr/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/pkrskr/astropy/tags","blobs_url":"https://api.github.com/repos/pkrskr/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkrskr/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkrskr/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkrskr/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkrskr/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/pkrskr/astropy/languages","stargazers_url":"https://api.github.com/repos/pkrskr/astropy/stargazers","contributors_url":"https://api.github.com/repos/pkrskr/astropy/contributors","subscribers_url":"https://api.github.com/repos/pkrskr/astropy/subscribers","subscription_url":"https://api.github.com/repos/pkrskr/astropy/subscription","commits_url":"https://api.github.com/repos/pkrskr/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkrskr/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkrskr/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkrskr/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkrskr/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/pkrskr/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkrskr/astropy/merges","archive_url":"https://api.github.com/repos/pkrskr/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkrskr/astropy/downloads","issues_url":"https://api.github.com/repos/pkrskr/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/pkrskr/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/pkrskr/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/pkrskr/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkrskr/astropy/labels{/name}","releases_url":"https://api.github.com/repos/pkrskr/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/pkrskr/astropy/deployments","created_at":"2016-03-18T04:22:04Z","updated_at":"2016-03-18T04:22:08Z","pushed_at":"2016-03-23T07:57:06Z","git_url":"git://github.com/pkrskr/astropy.git","ssh_url":"git@github.com:pkrskr/astropy.git","clone_url":"https://github.com/pkrskr/astropy.git","svn_url":"https://github.com/pkrskr/astropy","homepage":"www.astropy.org","size":43304,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"71eb02e6262fb80efc6ac49c603193ecf865cae7","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2016-03-22T23:05:48Z","pushed_at":"2016-03-25T13:57:34Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":61557,"stargazers_count":821,"watchers_count":821,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":535,"mirror_url":null,"open_issues_count":713,"forks":535,"open_issues":713,"watchers":821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4721"},"html":{"href":"https://github.com/astropy/astropy/pull/4721"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/4721"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/4721/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4721/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/4721/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/66309f33456e5ca26607cc988cffa04497a8fa9b"}}}}