{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/loci/issues/30","repository_url":"https://api.github.com/repos/mozilla/loci","labels_url":"https://api.github.com/repos/mozilla/loci/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/loci/issues/30/comments","events_url":"https://api.github.com/repos/mozilla/loci/issues/30/events","html_url":"https://github.com/mozilla/loci/pull/30","id":170550884,"number":30,"title":"feat(workers): #20 Canonicalize and normalize URLs","user":{"login":"rittme","id":201125,"avatar_url":"https://avatars.githubusercontent.com/u/201125?v=3","gravatar_id":"","url":"https://api.github.com/users/rittme","html_url":"https://github.com/rittme","followers_url":"https://api.github.com/users/rittme/followers","following_url":"https://api.github.com/users/rittme/following{/other_user}","gists_url":"https://api.github.com/users/rittme/gists{/gist_id}","starred_url":"https://api.github.com/users/rittme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rittme/subscriptions","organizations_url":"https://api.github.com/users/rittme/orgs","repos_url":"https://api.github.com/users/rittme/repos","events_url":"https://api.github.com/users/rittme/events{/privacy}","received_events_url":"https://api.github.com/users/rittme/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/loci/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/mozilla/loci/labels/R?","name":"R?","color":"1d76db"}],"state":"open","locked":false,"assignee":{"login":"oyiptong","id":9365,"avatar_url":"https://avatars.githubusercontent.com/u/9365?v=3","gravatar_id":"","url":"https://api.github.com/users/oyiptong","html_url":"https://github.com/oyiptong","followers_url":"https://api.github.com/users/oyiptong/followers","following_url":"https://api.github.com/users/oyiptong/following{/other_user}","gists_url":"https://api.github.com/users/oyiptong/gists{/gist_id}","starred_url":"https://api.github.com/users/oyiptong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyiptong/subscriptions","organizations_url":"https://api.github.com/users/oyiptong/orgs","repos_url":"https://api.github.com/users/oyiptong/repos","events_url":"https://api.github.com/users/oyiptong/events{/privacy}","received_events_url":"https://api.github.com/users/oyiptong/received_events","type":"User","site_admin":false},"assignees":[{"login":"oyiptong","id":9365,"avatar_url":"https://avatars.githubusercontent.com/u/9365?v=3","gravatar_id":"","url":"https://api.github.com/users/oyiptong","html_url":"https://github.com/oyiptong","followers_url":"https://api.github.com/users/oyiptong/followers","following_url":"https://api.github.com/users/oyiptong/following{/other_user}","gists_url":"https://api.github.com/users/oyiptong/gists{/gist_id}","starred_url":"https://api.github.com/users/oyiptong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyiptong/subscriptions","organizations_url":"https://api.github.com/users/oyiptong/orgs","repos_url":"https://api.github.com/users/oyiptong/repos","events_url":"https://api.github.com/users/oyiptong/events{/privacy}","received_events_url":"https://api.github.com/users/oyiptong/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-11T00:48:46Z","updated_at":"2016-08-11T15:55:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/loci/pulls/30","html_url":"https://github.com/mozilla/loci/pull/30","diff_url":"https://github.com/mozilla/loci/pull/30.diff","patch_url":"https://github.com/mozilla/loci/pull/30.patch"},"body":"Fixes #20.\r\n\r\nURL normalization is being done at the Page/Task creation as I think it's better than proxying the message through some other method."},"comment":{"url":"https://api.github.com/repos/mozilla/loci/issues/comments/239204978","html_url":"https://github.com/mozilla/loci/pull/30#issuecomment-239204978","issue_url":"https://api.github.com/repos/mozilla/loci/issues/30","id":239204978,"user":{"login":"oyiptong","id":9365,"avatar_url":"https://avatars.githubusercontent.com/u/9365?v=3","gravatar_id":"","url":"https://api.github.com/users/oyiptong","html_url":"https://github.com/oyiptong","followers_url":"https://api.github.com/users/oyiptong/followers","following_url":"https://api.github.com/users/oyiptong/following{/other_user}","gists_url":"https://api.github.com/users/oyiptong/gists{/gist_id}","starred_url":"https://api.github.com/users/oyiptong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oyiptong/subscriptions","organizations_url":"https://api.github.com/users/oyiptong/orgs","repos_url":"https://api.github.com/users/oyiptong/repos","events_url":"https://api.github.com/users/oyiptong/events{/privacy}","received_events_url":"https://api.github.com/users/oyiptong/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T15:55:29Z","updated_at":"2016-08-11T15:55:29Z","body":"looks good to go, with a couple of small changes:\r\n\r\n1. normalize canonical urls as well (with the arg to keep the reference/fragment, since the page intended to have the fragment in there)\r\n2. keep normalizing normal urls (without fragment)\r\n3. do not encode spaces or `+`, since URL encoding is taken care of by `nsIURI`\r\n\r\nI'll make it an r+. You can merge after the above changes"}}
{"actor":{"display_login":"oyiptong"}}