{"action":"created","issue":{"url":"https://api.github.com/repos/yegor256/rultor/issues/1039","repository_url":"https://api.github.com/repos/yegor256/rultor","labels_url":"https://api.github.com/repos/yegor256/rultor/issues/1039/labels{/name}","comments_url":"https://api.github.com/repos/yegor256/rultor/issues/1039/comments","events_url":"https://api.github.com/repos/yegor256/rultor/issues/1039/events","html_url":"https://github.com/yegor256/rultor/issues/1039","id":138115482,"number":1039,"title":"Rultor Uses the Target Branch's .rultor.yml on Merges","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars.githubusercontent.com/u/6490959?v=3","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/yegor256/rultor/labels/30%20mins","name":"30 mins","color":"eb6421"},{"url":"https://api.github.com/repos/yegor256/rultor/labels/@vkuchyn","name":"@vkuchyn","color":"009801"},{"url":"https://api.github.com/repos/yegor256/rultor/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/yegor256/rultor/labels/DEV","name":"DEV","color":"bfd4f3"},{"url":"https://api.github.com/repos/yegor256/rultor/labels/urgent","name":"urgent","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/yegor256/rultor/milestones/1","html_url":"https://github.com/yegor256/rultor/milestones/2.0","labels_url":"https://api.github.com/repos/yegor256/rultor/milestones/1/labels","id":427872,"number":1,"title":"2.0","description":"fully stable version","creator":{"login":"yegor256","id":526301,"avatar_url":"https://avatars.githubusercontent.com/u/526301?v=3","gravatar_id":"","url":"https://api.github.com/users/yegor256","html_url":"https://github.com/yegor256","followers_url":"https://api.github.com/users/yegor256/followers","following_url":"https://api.github.com/users/yegor256/following{/other_user}","gists_url":"https://api.github.com/users/yegor256/gists{/gist_id}","starred_url":"https://api.github.com/users/yegor256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yegor256/subscriptions","organizations_url":"https://api.github.com/users/yegor256/orgs","repos_url":"https://api.github.com/users/yegor256/repos","events_url":"https://api.github.com/users/yegor256/events{/privacy}","received_events_url":"https://api.github.com/users/yegor256/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":63,"state":"open","created_at":"2013-09-15T09:00:55Z","updated_at":"2016-03-07T15:23:52Z","due_on":"2015-06-01T07:00:00Z","closed_at":null},"comments":13,"created_at":"2016-03-03T08:50:57Z","updated_at":"2016-03-08T20:09:40Z","closed_at":null,"body":"Currently we have a situation where pull requests like e.g. #1038 can get stuck in a manner Rultor users cannot resolve without manually intervening in their master branch.\r\n\r\n# The problem is this:\r\nWe are currently reading the `.rultor.yml` from the master branch, not the fork branch.\r\nThis means that whatever changes a user makes to the `.rultor.yml` will not affect the run to merge those changes, but only the next run.\r\nReading the `.rultor.yml` from `master` is obviously correct for authentication purposes, but it is also obviously wrong for the dependency parts ( `merge`, `install`, `docker` etc.) parts of the `.rultor.yml`.\r\nSame as with a `.travis.yml` these parts need to come from the same branch as the source code, otherwise any change in dependencies becomes impossible when strictly allowing only Rultor on the `master` branch.\r\nThis is especially bad since the opposite is also possible, the merge with changes in the `.rultor.yml` could work, even when those changes break the build. Hence merging a broken `.rultor.yml` would cause development to become stuck in any case.\r\n\r\n## Example\r\n\r\nYou want to upgrade your project from Java 7 to Java 8 and change the `image:` section in the `.rultor.yml` from JDK7 to JDK8, as well as some code in a way that is not Java 7 compatible anymore.\r\nMerging this is impossible, because the run will still use the JDK7 from `master`. Only after the merge would JDK8 be used for subsequent merges.\r\n\r\n# Fix must include:\r\n\r\n* Reading `.rultor.yml` from the merge result when building, not from master\r\n* Reading `.rultor.yml` for **authentication purposes** from master still\r\n * Authentication purposes being defined as the lists for commanders and architects\r\n"},"comment":{"url":"https://api.github.com/repos/yegor256/rultor/issues/comments/193947437","html_url":"https://github.com/yegor256/rultor/issues/1039#issuecomment-193947437","issue_url":"https://api.github.com/repos/yegor256/rultor/issues/1039","id":193947437,"user":{"login":"vkuchyn","id":3267621,"avatar_url":"https://avatars.githubusercontent.com/u/3267621?v=3","gravatar_id":"","url":"https://api.github.com/users/vkuchyn","html_url":"https://github.com/vkuchyn","followers_url":"https://api.github.com/users/vkuchyn/followers","following_url":"https://api.github.com/users/vkuchyn/following{/other_user}","gists_url":"https://api.github.com/users/vkuchyn/gists{/gist_id}","starred_url":"https://api.github.com/users/vkuchyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkuchyn/subscriptions","organizations_url":"https://api.github.com/users/vkuchyn/orgs","repos_url":"https://api.github.com/users/vkuchyn/repos","events_url":"https://api.github.com/users/vkuchyn/events{/privacy}","received_events_url":"https://api.github.com/users/vkuchyn/received_events","type":"User","site_admin":false},"created_at":"2016-03-08T20:09:40Z","updated_at":"2016-03-08T20:09:40Z","body":"@original-brownbear thanks for quick reaction. I didn't expect such speed ) Please, see my comment above - I updated it"}}