{"action":"created","comment":{"url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/comments/84958066","pull_request_review_id":5702623,"id":84958066,"diff_hunk":"@@ -0,0 +1,7 @@\n+package org.kitteh.irc.client.library.feature.sts;\n+\n+public interface StsStorageManager {","path":"src/main/java/org/kitteh/irc/client/library/feature/sts/StsStorageManager.java","position":3,"original_position":3,"commit_id":"611188c6541f4099bd0d32dcd0c9ef9ca9ee9eab","original_commit_id":"611188c6541f4099bd0d32dcd0c9ef9ca9ee9eab","user":{"login":"lol768","id":2552726,"avatar_url":"https://avatars.githubusercontent.com/u/2552726?v=3","gravatar_id":"","url":"https://api.github.com/users/lol768","html_url":"https://github.com/lol768","followers_url":"https://api.github.com/users/lol768/followers","following_url":"https://api.github.com/users/lol768/following{/other_user}","gists_url":"https://api.github.com/users/lol768/gists{/gist_id}","starred_url":"https://api.github.com/users/lol768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lol768/subscriptions","organizations_url":"https://api.github.com/users/lol768/orgs","repos_url":"https://api.github.com/users/lol768/repos","events_url":"https://api.github.com/users/lol768/events{/privacy}","received_events_url":"https://api.github.com/users/lol768/received_events","type":"User","site_admin":false},"body":"needs to store arbitrary key/value pairs too","created_at":"2016-10-25T17:37:11Z","updated_at":"2016-10-25T17:39:55Z","html_url":"https://github.com/KittehOrg/KittehIRCClientLib/pull/155#discussion_r84958066","pull_request_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155","_links":{"self":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/comments/84958066"},"html":{"href":"https://github.com/KittehOrg/KittehIRCClientLib/pull/155#discussion_r84958066"},"pull_request":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155","id":90855340,"html_url":"https://github.com/KittehOrg/KittehIRCClientLib/pull/155","diff_url":"https://github.com/KittehOrg/KittehIRCClientLib/pull/155.diff","patch_url":"https://github.com/KittehOrg/KittehIRCClientLib/pull/155.patch","issue_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/issues/155","number":155,"state":"open","locked":false,"title":"[WIP] STS Support","user":{"login":"lol768","id":2552726,"avatar_url":"https://avatars.githubusercontent.com/u/2552726?v=3","gravatar_id":"","url":"https://api.github.com/users/lol768","html_url":"https://github.com/lol768","followers_url":"https://api.github.com/users/lol768/followers","following_url":"https://api.github.com/users/lol768/following{/other_user}","gists_url":"https://api.github.com/users/lol768/gists{/gist_id}","starred_url":"https://api.github.com/users/lol768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lol768/subscriptions","organizations_url":"https://api.github.com/users/lol768/orgs","repos_url":"https://api.github.com/users/lol768/repos","events_url":"https://api.github.com/users/lol768/events{/privacy}","received_events_url":"https://api.github.com/users/lol768/received_events","type":"User","site_admin":false},"body":"This is some early work on adding STS support to KICL. Comments are welcome! Pedantic formatting comments are also welcome (`this.kashike`)!\r\n\r\nCurrently it doesn't much, TODO:\r\n\r\n* [ ] CAP key=value parsing. Should (why else would we be sending `LS 302`s?) be in KICL but isn't yet?\r\n* [ ] Handler machine manipulation code.\r\n* [ ] Simple persistence implementation using files or something.\r\n\r\n`StsMachine` is a [finite state machine](https://en.wikipedia.org/wiki/Finite-state_machine) that can be in one state at a time depending on what's going on w.r.t STS and the remote server. We have one machine per client instance.\r\n\r\nSTS support is currently off by default because there is no persistence implementation to use by default. Suggestions on how (or even if to bother trying) to approach this are welcome (writing to appdata? ~/.config? doing it all in memory?), especially because KICL hasn't really needed this sort of persistence before.","created_at":"2016-10-25T17:36:11Z","updated_at":"2016-10-25T17:39:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08f79c6e30901ba2fb4f35a7459d5ef6332b881c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155/commits","review_comments_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155/comments","review_comment_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/issues/155/comments","statuses_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/statuses/611188c6541f4099bd0d32dcd0c9ef9ca9ee9eab","head":{"label":"lol768:sts","ref":"sts","sha":"611188c6541f4099bd0d32dcd0c9ef9ca9ee9eab","user":{"login":"lol768","id":2552726,"avatar_url":"https://avatars.githubusercontent.com/u/2552726?v=3","gravatar_id":"","url":"https://api.github.com/users/lol768","html_url":"https://github.com/lol768","followers_url":"https://api.github.com/users/lol768/followers","following_url":"https://api.github.com/users/lol768/following{/other_user}","gists_url":"https://api.github.com/users/lol768/gists{/gist_id}","starred_url":"https://api.github.com/users/lol768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lol768/subscriptions","organizations_url":"https://api.github.com/users/lol768/orgs","repos_url":"https://api.github.com/users/lol768/repos","events_url":"https://api.github.com/users/lol768/events{/privacy}","received_events_url":"https://api.github.com/users/lol768/received_events","type":"User","site_admin":false},"repo":{"id":32289429,"name":"KittehIRCClientLib","full_name":"lol768/KittehIRCClientLib","owner":{"login":"lol768","id":2552726,"avatar_url":"https://avatars.githubusercontent.com/u/2552726?v=3","gravatar_id":"","url":"https://api.github.com/users/lol768","html_url":"https://github.com/lol768","followers_url":"https://api.github.com/users/lol768/followers","following_url":"https://api.github.com/users/lol768/following{/other_user}","gists_url":"https://api.github.com/users/lol768/gists{/gist_id}","starred_url":"https://api.github.com/users/lol768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lol768/subscriptions","organizations_url":"https://api.github.com/users/lol768/orgs","repos_url":"https://api.github.com/users/lol768/repos","events_url":"https://api.github.com/users/lol768/events{/privacy}","received_events_url":"https://api.github.com/users/lol768/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lol768/KittehIRCClientLib","description":null,"fork":true,"url":"https://api.github.com/repos/lol768/KittehIRCClientLib","forks_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/forks","keys_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/teams","hooks_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/hooks","issue_events_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/issues/events{/number}","events_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/events","assignees_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/assignees{/user}","branches_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/branches{/branch}","tags_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/tags","blobs_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/statuses/{sha}","languages_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/languages","stargazers_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/stargazers","contributors_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/contributors","subscribers_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/subscribers","subscription_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/subscription","commits_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/contents/{+path}","compare_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/merges","archive_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/downloads","issues_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/issues{/number}","pulls_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/pulls{/number}","milestones_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/milestones{/number}","notifications_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/labels{/name}","releases_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/releases{/id}","deployments_url":"https://api.github.com/repos/lol768/KittehIRCClientLib/deployments","created_at":"2015-03-15T23:12:28Z","updated_at":"2016-02-07T01:43:40Z","pushed_at":"2016-10-25T17:30:54Z","git_url":"git://github.com/lol768/KittehIRCClientLib.git","ssh_url":"git@github.com:lol768/KittehIRCClientLib.git","clone_url":"https://github.com/lol768/KittehIRCClientLib.git","svn_url":"https://github.com/lol768/KittehIRCClientLib","homepage":null,"size":2293,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KittehOrg:next","ref":"next","sha":"f39ac8ac05aaca70a7e2002249a12dc742136723","user":{"login":"KittehOrg","id":1663469,"avatar_url":"https://avatars.githubusercontent.com/u/1663469?v=3","gravatar_id":"","url":"https://api.github.com/users/KittehOrg","html_url":"https://github.com/KittehOrg","followers_url":"https://api.github.com/users/KittehOrg/followers","following_url":"https://api.github.com/users/KittehOrg/following{/other_user}","gists_url":"https://api.github.com/users/KittehOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/KittehOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KittehOrg/subscriptions","organizations_url":"https://api.github.com/users/KittehOrg/orgs","repos_url":"https://api.github.com/users/KittehOrg/repos","events_url":"https://api.github.com/users/KittehOrg/events{/privacy}","received_events_url":"https://api.github.com/users/KittehOrg/received_events","type":"Organization","site_admin":false},"repo":{"id":27287741,"name":"KittehIRCClientLib","full_name":"KittehOrg/KittehIRCClientLib","owner":{"login":"KittehOrg","id":1663469,"avatar_url":"https://avatars.githubusercontent.com/u/1663469?v=3","gravatar_id":"","url":"https://api.github.com/users/KittehOrg","html_url":"https://github.com/KittehOrg","followers_url":"https://api.github.com/users/KittehOrg/followers","following_url":"https://api.github.com/users/KittehOrg/following{/other_user}","gists_url":"https://api.github.com/users/KittehOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/KittehOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KittehOrg/subscriptions","organizations_url":"https://api.github.com/users/KittehOrg/orgs","repos_url":"https://api.github.com/users/KittehOrg/repos","events_url":"https://api.github.com/users/KittehOrg/events{/privacy}","received_events_url":"https://api.github.com/users/KittehOrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KittehOrg/KittehIRCClientLib","description":"An IRC client library in Java","fork":false,"url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib","forks_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/forks","keys_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/teams","hooks_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/hooks","issue_events_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/issues/events{/number}","events_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/events","assignees_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/assignees{/user}","branches_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/branches{/branch}","tags_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/tags","blobs_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/git/refs{/sha}","trees_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/statuses/{sha}","languages_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/languages","stargazers_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/stargazers","contributors_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/contributors","subscribers_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/subscribers","subscription_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/subscription","commits_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/commits{/sha}","git_commits_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/git/commits{/sha}","comments_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/comments{/number}","issue_comment_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/issues/comments{/number}","contents_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/contents/{+path}","compare_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/merges","archive_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/downloads","issues_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/issues{/number}","pulls_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls{/number}","milestones_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/milestones{/number}","notifications_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/labels{/name}","releases_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/releases{/id}","deployments_url":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/deployments","created_at":"2014-11-29T01:27:02Z","updated_at":"2016-09-30T16:14:47Z","pushed_at":"2016-10-25T17:36:11Z","git_url":"git://github.com/KittehOrg/KittehIRCClientLib.git","ssh_url":"git@github.com:KittehOrg/KittehIRCClientLib.git","clone_url":"https://github.com/KittehOrg/KittehIRCClientLib.git","svn_url":"https://github.com/KittehOrg/KittehIRCClientLib","homepage":"http://kitteh.org","size":9557,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":30,"forks":16,"open_issues":30,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155"},"html":{"href":"https://github.com/KittehOrg/KittehIRCClientLib/pull/155"},"issue":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/issues/155"},"comments":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/KittehOrg/KittehIRCClientLib/statuses/611188c6541f4099bd0d32dcd0c9ef9ca9ee9eab"}}}}
{"actor":{"display_login":"lol768"}}