{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/60112485","id":60112485,"diff_hunk":"@@ -1,617 +0,0 @@\n-import { context } from 'ember-environment';\n-import EmberObject from 'ember-runtime/system/object';\n-import run from 'ember-metal/run_loop';\n-import EmberView from 'ember-views/views/view';\n-import { A as emberA } from 'ember-runtime/system/native_array';\n-import EmberController from 'ember-runtime/controllers/controller';\n-\n-import { set } from 'ember-metal/property_set';\n-import { runAppend, runDestroy } from 'ember-runtime/tests/utils';\n-\n-import compile from 'ember-template-compiler/system/compile';\n-\n-import { registerKeyword, resetKeyword } from 'ember-htmlbars/tests/utils';\n-import viewKeyword from 'ember-htmlbars/keywords/view';\n-\n-import buildOwner from 'container/tests/test-helpers/build-owner';\n-import { OWNER } from 'container/owner';\n-\n-var people, view, owner;\n-var template, templateMyView, MyView, MyEmptyView, templateMyEmptyView;\n-var originalViewKeyword;\n-\n-var originalLookup = context.lookup;\n-var lookup;\n-\n-import isEnabled from 'ember-metal/features';\n-if (!isEnabled('ember-glimmer')) {\n-  // jscs:disable\n-\n-QUnit.module('the #each helper', {\n-  setup() {\n-    context.lookup = lookup = {};\n-\n-    originalViewKeyword = registerKeyword('view',  viewKeyword);\n-\n-    template = compile('{{#each view.people as |person|}}{{person.name}}{{/each}}');\n-    people = emberA([{ name: 'Steve Holt' }, { name: 'Annabelle' }]);\n-\n-    owner = buildOwner();\n-\n-    owner.register('view:toplevel', EmberView.extend());\n-\n-    view = EmberView.create({\n-      [OWNER]: owner,\n-      template: template,\n-      people: people\n-    });\n-\n-    templateMyView = compile('{{name}}');\n-    lookup.MyView  = MyView = EmberView.extend({ template: templateMyView });\n-    owner.register('view:my-view', MyView);\n-\n-    templateMyEmptyView = compile('I\\'m empty');\n-    lookup.MyEmptyView = MyEmptyView = EmberView.extend({\n-      template: templateMyEmptyView\n-    });\n-    owner.register('view:my-empty-view', MyEmptyView);\n-\n-    runAppend(view);\n-  },\n-\n-  teardown() {\n-    runDestroy(owner);\n-    runDestroy(view);\n-    owner = view = null;\n-\n-    context.lookup = originalLookup;\n-\n-    resetKeyword('view', originalViewKeyword);\n-  }\n-});\n-\n-var assertHTML = function(view, expectedHTML) {\n-  var html = view.$().html();\n-\n-  // IE 8 (and prior?) adds the \\r\\n\n-  html = html.replace(/<script[^>]*><\\/script>/ig, '').replace(/[\\r\\n]/g, '');\n-\n-  equal(html, expectedHTML);\n-};\n-\n-QUnit.test('it renders the template for each item in an array', function() {\n-  assertHTML(view, 'Steve HoltAnnabelle');\n-});\n-\n-QUnit.test('it updates the view if an item is added', function() {\n-  run(function() {\n-    people.pushObject({ name: 'Tom Dale' });\n-  });\n-\n-  assertHTML(view, 'Steve HoltAnnabelleTom Dale');\n-});\n-\n-QUnit.test('it updates the view if an item is removed', function() {\n-  run(function() {\n-    people.removeAt(0);\n-  });\n-\n-  assertHTML(view, 'Annabelle');\n-});\n-\n-QUnit.test('it updates the view if an item is replaced', function() {\n-  run(function() {\n-    people.removeAt(0);\n-    people.insertAt(0, { name: 'Kazuki' });\n-  });\n-\n-  assertHTML(view, 'KazukiAnnabelle');\n-});\n-\n-QUnit.test('can add and replace in the same runloop', function() {\n-  run(function() {\n-    people.pushObject({ name: 'Tom Dale' });\n-    people.removeAt(0);\n-    people.insertAt(0, { name: 'Kazuki' });\n-  });\n-\n-  assertHTML(view, 'KazukiAnnabelleTom Dale');\n-});\n-\n-QUnit.test('can add and replace the object before the add in the same runloop', function() {\n-  run(function() {\n-    people.pushObject({ name: 'Tom Dale' });\n-    people.removeAt(1);\n-    people.insertAt(1, { name: 'Kazuki' });\n-  });\n-\n-  assertHTML(view, 'Steve HoltKazukiTom Dale');\n-});\n-\n-QUnit.test('can add and replace complicatedly', function() {\n-  run(function() {\n-    people.pushObject({ name: 'Tom Dale' });\n-    people.removeAt(1);\n-    people.insertAt(1, { name: 'Kazuki' });\n-    people.pushObject({ name: 'Firestone' });\n-    people.pushObject({ name: 'McMunch' });\n-    people.removeAt(3);\n-  });\n-\n-  assertHTML(view, 'Steve HoltKazukiTom DaleMcMunch');\n-});\n-\n-QUnit.test('can add and replace complicatedly harder', function() {\n-  run(function() {\n-    people.pushObject({ name: 'Tom Dale' });\n-    people.removeAt(1);\n-    people.insertAt(1, { name: 'Kazuki' });\n-    people.pushObject({ name: 'Firestone' });\n-    people.pushObject({ name: 'McMunch' });\n-    people.removeAt(2);\n-  });\n-\n-  assertHTML(view, 'Steve HoltKazukiFirestoneMcMunch');\n-});\n-\n-QUnit.test('it does not mark each option tag as selected', function() {","path":"packages/ember-htmlbars/tests/helpers/each_test.js","position":100,"original_position":157,"commit_id":"9b47bde9d209baec65f6bcb5b8a2dde515ebd9da","original_commit_id":"c08e75f3474e8bb995f5f24b837479bf3fca64f8","user":{"login":"Joelkang","id":2020382,"avatar_url":"https://avatars.githubusercontent.com/u/2020382?v=3","gravatar_id":"","url":"https://api.github.com/users/Joelkang","html_url":"https://github.com/Joelkang","followers_url":"https://api.github.com/users/Joelkang/followers","following_url":"https://api.github.com/users/Joelkang/following{/other_user}","gists_url":"https://api.github.com/users/Joelkang/gists{/gist_id}","starred_url":"https://api.github.com/users/Joelkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joelkang/subscriptions","organizations_url":"https://api.github.com/users/Joelkang/orgs","repos_url":"https://api.github.com/users/Joelkang/repos","events_url":"https://api.github.com/users/Joelkang/events{/privacy}","received_events_url":"https://api.github.com/users/Joelkang/received_events","type":"User","site_admin":false},"body":"Ok, I migrated the complicatedly and complicatedly harder tests with the exact list operations so that we get the same coverage. It's all in a single INUR test, which seems fine to me if all we're testing is the diff-ing within a single run loop","created_at":"2016-04-18T18:45:22Z","updated_at":"2016-04-18T18:45:22Z","html_url":"https://github.com/emberjs/ember.js/pull/13349#discussion_r60112485","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13349","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/60112485"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13349#discussion_r60112485"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13349"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13349","id":66750177,"html_url":"https://github.com/emberjs/ember.js/pull/13349","diff_url":"https://github.com/emberjs/ember.js/pull/13349.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13349.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13349","number":13349,"state":"open","locked":false,"title":"[Glimmer2] Migrate remainder of {{#each}} tests","user":{"login":"Joelkang","id":2020382,"avatar_url":"https://avatars.githubusercontent.com/u/2020382?v=3","gravatar_id":"","url":"https://api.github.com/users/Joelkang","html_url":"https://github.com/Joelkang","followers_url":"https://api.github.com/users/Joelkang/followers","following_url":"https://api.github.com/users/Joelkang/following{/other_user}","gists_url":"https://api.github.com/users/Joelkang/gists{/gist_id}","starred_url":"https://api.github.com/users/Joelkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joelkang/subscriptions","organizations_url":"https://api.github.com/users/Joelkang/orgs","repos_url":"https://api.github.com/users/Joelkang/repos","events_url":"https://api.github.com/users/Joelkang/events{/privacy}","received_events_url":"https://api.github.com/users/Joelkang/received_events","type":"User","site_admin":false},"body":"Part of #13127","created_at":"2016-04-16T21:18:02Z","updated_at":"2016-04-18T18:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b45bd763cbb8417f0e87d4723d83b80a78f6ab0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13349/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13349/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13349/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/9b47bde9d209baec65f6bcb5b8a2dde515ebd9da","head":{"label":"Joelkang:each-tests","ref":"each-tests","sha":"9b47bde9d209baec65f6bcb5b8a2dde515ebd9da","user":{"login":"Joelkang","id":2020382,"avatar_url":"https://avatars.githubusercontent.com/u/2020382?v=3","gravatar_id":"","url":"https://api.github.com/users/Joelkang","html_url":"https://github.com/Joelkang","followers_url":"https://api.github.com/users/Joelkang/followers","following_url":"https://api.github.com/users/Joelkang/following{/other_user}","gists_url":"https://api.github.com/users/Joelkang/gists{/gist_id}","starred_url":"https://api.github.com/users/Joelkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joelkang/subscriptions","organizations_url":"https://api.github.com/users/Joelkang/orgs","repos_url":"https://api.github.com/users/Joelkang/repos","events_url":"https://api.github.com/users/Joelkang/events{/privacy}","received_events_url":"https://api.github.com/users/Joelkang/received_events","type":"User","site_admin":false},"repo":{"id":54746899,"name":"ember.js","full_name":"Joelkang/ember.js","owner":{"login":"Joelkang","id":2020382,"avatar_url":"https://avatars.githubusercontent.com/u/2020382?v=3","gravatar_id":"","url":"https://api.github.com/users/Joelkang","html_url":"https://github.com/Joelkang","followers_url":"https://api.github.com/users/Joelkang/followers","following_url":"https://api.github.com/users/Joelkang/following{/other_user}","gists_url":"https://api.github.com/users/Joelkang/gists{/gist_id}","starred_url":"https://api.github.com/users/Joelkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joelkang/subscriptions","organizations_url":"https://api.github.com/users/Joelkang/orgs","repos_url":"https://api.github.com/users/Joelkang/repos","events_url":"https://api.github.com/users/Joelkang/events{/privacy}","received_events_url":"https://api.github.com/users/Joelkang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Joelkang/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/Joelkang/ember.js","forks_url":"https://api.github.com/repos/Joelkang/ember.js/forks","keys_url":"https://api.github.com/repos/Joelkang/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Joelkang/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Joelkang/ember.js/teams","hooks_url":"https://api.github.com/repos/Joelkang/ember.js/hooks","issue_events_url":"https://api.github.com/repos/Joelkang/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/Joelkang/ember.js/events","assignees_url":"https://api.github.com/repos/Joelkang/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/Joelkang/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/Joelkang/ember.js/tags","blobs_url":"https://api.github.com/repos/Joelkang/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Joelkang/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Joelkang/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Joelkang/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Joelkang/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Joelkang/ember.js/languages","stargazers_url":"https://api.github.com/repos/Joelkang/ember.js/stargazers","contributors_url":"https://api.github.com/repos/Joelkang/ember.js/contributors","subscribers_url":"https://api.github.com/repos/Joelkang/ember.js/subscribers","subscription_url":"https://api.github.com/repos/Joelkang/ember.js/subscription","commits_url":"https://api.github.com/repos/Joelkang/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Joelkang/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Joelkang/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Joelkang/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Joelkang/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/Joelkang/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Joelkang/ember.js/merges","archive_url":"https://api.github.com/repos/Joelkang/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Joelkang/ember.js/downloads","issues_url":"https://api.github.com/repos/Joelkang/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/Joelkang/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Joelkang/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Joelkang/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Joelkang/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/Joelkang/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/Joelkang/ember.js/deployments","created_at":"2016-03-25T20:53:53Z","updated_at":"2016-03-25T20:53:58Z","pushed_at":"2016-04-18T18:43:07Z","git_url":"git://github.com/Joelkang/ember.js.git","ssh_url":"git@github.com:Joelkang/ember.js.git","clone_url":"https://github.com/Joelkang/ember.js.git","svn_url":"https://github.com/Joelkang/ember.js","homepage":"http://www.emberjs.com","size":32575,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"fe04b2f3e1353cfc5819555d453a256729fc6feb","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-04-18T16:49:04Z","pushed_at":"2016-04-18T18:43:08Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":67113,"stargazers_count":16081,"watchers_count":16081,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3457,"mirror_url":null,"open_issues_count":308,"forks":3457,"open_issues":308,"watchers":16081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13349"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13349"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13349"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13349/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13349/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13349/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/9b47bde9d209baec65f6bcb5b8a2dde515ebd9da"}}}}