{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/4","id":77695944,"html_url":"https://github.com/arachne-framework/arachne-core/pull/4","diff_url":"https://github.com/arachne-framework/arachne-core/pull/4.diff","patch_url":"https://github.com/arachne-framework/arachne-core/pull/4.patch","issue_url":"https://api.github.com/repos/arachne-framework/arachne-core/issues/4","number":4,"state":"closed","locked":false,"title":"Fix broken multiplex config","user":{"login":"levand","id":70788,"avatar_url":"https://avatars.githubusercontent.com/u/70788?v=3","gravatar_id":"","url":"https://api.github.com/users/levand","html_url":"https://github.com/levand","followers_url":"https://api.github.com/users/levand/followers","following_url":"https://api.github.com/users/levand/following{/other_user}","gists_url":"https://api.github.com/users/levand/gists{/gist_id}","starred_url":"https://api.github.com/users/levand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levand/subscriptions","organizations_url":"https://api.github.com/users/levand/orgs","repos_url":"https://api.github.com/users/levand/repos","events_url":"https://api.github.com/users/levand/events{/privacy}","received_events_url":"https://api.github.com/users/levand/received_events","type":"User","site_admin":false},"body":"There were two problems. The first was that the multiplex config was not\r\nactually being exercised. Now it is.\r\n\r\nThat revealed that the multiplexer wasn't actually working; indeed, it\r\ncould not, because it did not account for the case where a user would\r\nquery, obtain an entity ID, and then subsequently use that ID in another\r\nquery.\r\n\r\nThe approach used to fix this is for the multiplexer to retrieve the\r\nactual entity IDs by resolving all the tempids after each transaction,\r\nand then store a mapping of Datomic EID to DataScript EID. Then, before\r\npassing any data to DataScript, the multiplexer will walk it and replace\r\nall Datomic eids it finds with DataScript EIDs.\r\n\r\nThere is a known extreme edge case here: If the user tries to transact\r\nan actual integer value that happens to collide with a Datomic entity\r\nID, it will be replaced incorrectly. Given that the multiplexer is only\r\nused for testing and development, not for actual users, I do not expect\r\nthat this is likely to result in any problems (and even if it does, the\r\nworst that would happen is a spurious multiplexer failure for a module\r\ndeveloper)","created_at":"2016-07-16T00:59:07Z","updated_at":"2016-07-16T01:05:48Z","closed_at":"2016-07-16T01:05:48Z","merged_at":"2016-07-16T01:05:48Z","merge_commit_sha":"9510d0e7662a871ad732b6687042d2143c2bd3dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/4/commits","review_comments_url":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/4/comments","review_comment_url":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arachne-framework/arachne-core/issues/4/comments","statuses_url":"https://api.github.com/repos/arachne-framework/arachne-core/statuses/ab86c258bc37daac8ee02aa84dc4fb1f1a5a09a4","head":{"label":"levand:fix-multiplex-config","ref":"fix-multiplex-config","sha":"ab86c258bc37daac8ee02aa84dc4fb1f1a5a09a4","user":{"login":"levand","id":70788,"avatar_url":"https://avatars.githubusercontent.com/u/70788?v=3","gravatar_id":"","url":"https://api.github.com/users/levand","html_url":"https://github.com/levand","followers_url":"https://api.github.com/users/levand/followers","following_url":"https://api.github.com/users/levand/following{/other_user}","gists_url":"https://api.github.com/users/levand/gists{/gist_id}","starred_url":"https://api.github.com/users/levand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levand/subscriptions","organizations_url":"https://api.github.com/users/levand/orgs","repos_url":"https://api.github.com/users/levand/repos","events_url":"https://api.github.com/users/levand/events{/privacy}","received_events_url":"https://api.github.com/users/levand/received_events","type":"User","site_admin":false},"repo":{"id":62830165,"name":"arachne-core","full_name":"levand/arachne-core","owner":{"login":"levand","id":70788,"avatar_url":"https://avatars.githubusercontent.com/u/70788?v=3","gravatar_id":"","url":"https://api.github.com/users/levand","html_url":"https://github.com/levand","followers_url":"https://api.github.com/users/levand/followers","following_url":"https://api.github.com/users/levand/following{/other_user}","gists_url":"https://api.github.com/users/levand/gists{/gist_id}","starred_url":"https://api.github.com/users/levand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levand/subscriptions","organizations_url":"https://api.github.com/users/levand/orgs","repos_url":"https://api.github.com/users/levand/repos","events_url":"https://api.github.com/users/levand/events{/privacy}","received_events_url":"https://api.github.com/users/levand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/levand/arachne-core","description":"The core module for the Arachne web framework","fork":true,"url":"https://api.github.com/repos/levand/arachne-core","forks_url":"https://api.github.com/repos/levand/arachne-core/forks","keys_url":"https://api.github.com/repos/levand/arachne-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/levand/arachne-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/levand/arachne-core/teams","hooks_url":"https://api.github.com/repos/levand/arachne-core/hooks","issue_events_url":"https://api.github.com/repos/levand/arachne-core/issues/events{/number}","events_url":"https://api.github.com/repos/levand/arachne-core/events","assignees_url":"https://api.github.com/repos/levand/arachne-core/assignees{/user}","branches_url":"https://api.github.com/repos/levand/arachne-core/branches{/branch}","tags_url":"https://api.github.com/repos/levand/arachne-core/tags","blobs_url":"https://api.github.com/repos/levand/arachne-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/levand/arachne-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/levand/arachne-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/levand/arachne-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/levand/arachne-core/statuses/{sha}","languages_url":"https://api.github.com/repos/levand/arachne-core/languages","stargazers_url":"https://api.github.com/repos/levand/arachne-core/stargazers","contributors_url":"https://api.github.com/repos/levand/arachne-core/contributors","subscribers_url":"https://api.github.com/repos/levand/arachne-core/subscribers","subscription_url":"https://api.github.com/repos/levand/arachne-core/subscription","commits_url":"https://api.github.com/repos/levand/arachne-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/levand/arachne-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/levand/arachne-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/levand/arachne-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/levand/arachne-core/contents/{+path}","compare_url":"https://api.github.com/repos/levand/arachne-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/levand/arachne-core/merges","archive_url":"https://api.github.com/repos/levand/arachne-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/levand/arachne-core/downloads","issues_url":"https://api.github.com/repos/levand/arachne-core/issues{/number}","pulls_url":"https://api.github.com/repos/levand/arachne-core/pulls{/number}","milestones_url":"https://api.github.com/repos/levand/arachne-core/milestones{/number}","notifications_url":"https://api.github.com/repos/levand/arachne-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/levand/arachne-core/labels{/name}","releases_url":"https://api.github.com/repos/levand/arachne-core/releases{/id}","deployments_url":"https://api.github.com/repos/levand/arachne-core/deployments","created_at":"2016-07-07T18:40:20Z","updated_at":"2016-07-07T18:40:21Z","pushed_at":"2016-07-16T00:58:34Z","git_url":"git://github.com/levand/arachne-core.git","ssh_url":"git@github.com:levand/arachne-core.git","clone_url":"https://github.com/levand/arachne-core.git","svn_url":"https://github.com/levand/arachne-core","homepage":null,"size":46,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arachne-framework:master","ref":"master","sha":"c47dbe6c46a1261120e5ac2009d4856b9891cd0f","user":{"login":"arachne-framework","id":15279127,"avatar_url":"https://avatars.githubusercontent.com/u/15279127?v=3","gravatar_id":"","url":"https://api.github.com/users/arachne-framework","html_url":"https://github.com/arachne-framework","followers_url":"https://api.github.com/users/arachne-framework/followers","following_url":"https://api.github.com/users/arachne-framework/following{/other_user}","gists_url":"https://api.github.com/users/arachne-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/arachne-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arachne-framework/subscriptions","organizations_url":"https://api.github.com/users/arachne-framework/orgs","repos_url":"https://api.github.com/users/arachne-framework/repos","events_url":"https://api.github.com/users/arachne-framework/events{/privacy}","received_events_url":"https://api.github.com/users/arachne-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":62824861,"name":"arachne-core","full_name":"arachne-framework/arachne-core","owner":{"login":"arachne-framework","id":15279127,"avatar_url":"https://avatars.githubusercontent.com/u/15279127?v=3","gravatar_id":"","url":"https://api.github.com/users/arachne-framework","html_url":"https://github.com/arachne-framework","followers_url":"https://api.github.com/users/arachne-framework/followers","following_url":"https://api.github.com/users/arachne-framework/following{/other_user}","gists_url":"https://api.github.com/users/arachne-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/arachne-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arachne-framework/subscriptions","organizations_url":"https://api.github.com/users/arachne-framework/orgs","repos_url":"https://api.github.com/users/arachne-framework/repos","events_url":"https://api.github.com/users/arachne-framework/events{/privacy}","received_events_url":"https://api.github.com/users/arachne-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arachne-framework/arachne-core","description":"The core module for the Arachne web framework","fork":false,"url":"https://api.github.com/repos/arachne-framework/arachne-core","forks_url":"https://api.github.com/repos/arachne-framework/arachne-core/forks","keys_url":"https://api.github.com/repos/arachne-framework/arachne-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arachne-framework/arachne-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arachne-framework/arachne-core/teams","hooks_url":"https://api.github.com/repos/arachne-framework/arachne-core/hooks","issue_events_url":"https://api.github.com/repos/arachne-framework/arachne-core/issues/events{/number}","events_url":"https://api.github.com/repos/arachne-framework/arachne-core/events","assignees_url":"https://api.github.com/repos/arachne-framework/arachne-core/assignees{/user}","branches_url":"https://api.github.com/repos/arachne-framework/arachne-core/branches{/branch}","tags_url":"https://api.github.com/repos/arachne-framework/arachne-core/tags","blobs_url":"https://api.github.com/repos/arachne-framework/arachne-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arachne-framework/arachne-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arachne-framework/arachne-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/arachne-framework/arachne-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arachne-framework/arachne-core/statuses/{sha}","languages_url":"https://api.github.com/repos/arachne-framework/arachne-core/languages","stargazers_url":"https://api.github.com/repos/arachne-framework/arachne-core/stargazers","contributors_url":"https://api.github.com/repos/arachne-framework/arachne-core/contributors","subscribers_url":"https://api.github.com/repos/arachne-framework/arachne-core/subscribers","subscription_url":"https://api.github.com/repos/arachne-framework/arachne-core/subscription","commits_url":"https://api.github.com/repos/arachne-framework/arachne-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/arachne-framework/arachne-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/arachne-framework/arachne-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/arachne-framework/arachne-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/arachne-framework/arachne-core/contents/{+path}","compare_url":"https://api.github.com/repos/arachne-framework/arachne-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arachne-framework/arachne-core/merges","archive_url":"https://api.github.com/repos/arachne-framework/arachne-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arachne-framework/arachne-core/downloads","issues_url":"https://api.github.com/repos/arachne-framework/arachne-core/issues{/number}","pulls_url":"https://api.github.com/repos/arachne-framework/arachne-core/pulls{/number}","milestones_url":"https://api.github.com/repos/arachne-framework/arachne-core/milestones{/number}","notifications_url":"https://api.github.com/repos/arachne-framework/arachne-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arachne-framework/arachne-core/labels{/name}","releases_url":"https://api.github.com/repos/arachne-framework/arachne-core/releases{/id}","deployments_url":"https://api.github.com/repos/arachne-framework/arachne-core/deployments","created_at":"2016-07-07T17:15:23Z","updated_at":"2016-07-15T23:23:50Z","pushed_at":"2016-07-16T01:05:48Z","git_url":"git://github.com/arachne-framework/arachne-core.git","ssh_url":"git@github.com:arachne-framework/arachne-core.git","clone_url":"https://github.com/arachne-framework/arachne-core.git","svn_url":"https://github.com/arachne-framework/arachne-core","homepage":null,"size":46,"stargazers_count":33,"watchers_count":33,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/4"},"html":{"href":"https://github.com/arachne-framework/arachne-core/pull/4"},"issue":{"href":"https://api.github.com/repos/arachne-framework/arachne-core/issues/4"},"comments":{"href":"https://api.github.com/repos/arachne-framework/arachne-core/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arachne-framework/arachne-core/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/arachne-framework/arachne-core/statuses/ab86c258bc37daac8ee02aa84dc4fb1f1a5a09a4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"levand","id":70788,"avatar_url":"https://avatars.githubusercontent.com/u/70788?v=3","gravatar_id":"","url":"https://api.github.com/users/levand","html_url":"https://github.com/levand","followers_url":"https://api.github.com/users/levand/followers","following_url":"https://api.github.com/users/levand/following{/other_user}","gists_url":"https://api.github.com/users/levand/gists{/gist_id}","starred_url":"https://api.github.com/users/levand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levand/subscriptions","organizations_url":"https://api.github.com/users/levand/orgs","repos_url":"https://api.github.com/users/levand/repos","events_url":"https://api.github.com/users/levand/events{/privacy}","received_events_url":"https://api.github.com/users/levand/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":141,"deletions":65,"changed_files":8}}
{"actor":{"display_login":"levand"}}