{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4748","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4748/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4748/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4748/events","html_url":"https://github.com/cockroachdb/cockroach/pull/4748","id":137651905,"number":4748,"title":"tracing: defer Finish for all started spans","user":{"login":"dt","id":15615,"avatar_url":"https://avatars.githubusercontent.com/u/15615?v=3","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2016-03-01T18:35:40Z","updated_at":"2016-03-01T20:12:20Z","closed_at":"2016-03-01T20:03:25Z","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/4748","html_url":"https://github.com/cockroachdb/cockroach/pull/4748","diff_url":"https://github.com/cockroachdb/cockroach/pull/4748.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/4748.patch"},"body":"Also refactor SpanFromContext to return a cleanup func that finishes the span iff it creates a new one.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/4748)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/190882866","html_url":"https://github.com/cockroachdb/cockroach/pull/4748#issuecomment-190882866","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/4748","id":190882866,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T20:12:20Z","updated_at":"2016-03-01T20:12:20Z","body":"\n\n\n\nReviewed 8 of 10 files at r1, 2 of 2 files at r2.\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[util/tracing/tracer.go, line 84 \\[r2\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/4748#-KBnnTlbFIKGC-0dOiXJ:-KBnnTlca9HGOTbLFMOf:-240866087) ([raw file](https://github.com/cockroachdb/cockroach/blob/ad86bab223035aa0a431d9af87d5d60638ad754c/util/tracing/tracer.go#L84)):*\nWhat do you think about wrapping opentracing.Span in a type that doesn't export Finish? Add a TODO if you think that's a good idea.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/4748)*\n<!-- Sent from Reviewable.io -->\n"}}