{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/nvml/issues/1509","repository_url":"https://api.github.com/repos/pmem/nvml","labels_url":"https://api.github.com/repos/pmem/nvml/issues/1509/labels{/name}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/1509/comments","events_url":"https://api.github.com/repos/pmem/nvml/issues/1509/events","html_url":"https://github.com/pmem/nvml/pull/1509","id":194085173,"number":1509,"title":"obj: fix pmemcheck for large free undo logs","user":{"login":"pbalcer","id":8775610,"avatar_url":"https://avatars.githubusercontent.com/u/8775610?v=3","gravatar_id":"","url":"https://api.github.com/users/pbalcer","html_url":"https://github.com/pbalcer","followers_url":"https://api.github.com/users/pbalcer/followers","following_url":"https://api.github.com/users/pbalcer/following{/other_user}","gists_url":"https://api.github.com/users/pbalcer/gists{/gist_id}","starred_url":"https://api.github.com/users/pbalcer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbalcer/subscriptions","organizations_url":"https://api.github.com/users/pbalcer/orgs","repos_url":"https://api.github.com/users/pbalcer/repos","events_url":"https://api.github.com/users/pbalcer/events{/privacy}","received_events_url":"https://api.github.com/users/pbalcer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-07T15:47:01Z","updated_at":"2016-12-07T15:49:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/1509","html_url":"https://github.com/pmem/nvml/pull/1509","diff_url":"https://github.com/pmem/nvml/pull/1509.diff","patch_url":"https://github.com/pmem/nvml/pull/1509.patch"},"body":"For small tx undo logs, the vector structure usesan embedded array that is\r\nlocated in lane, if the undo log needs to grow beyond the initial size it\r\nallocates an array from a heap. The issue was that the lanes are added\r\nto the pmemcheck tx ignore list whereas the heap allocations must be\r\nmanually added to the transaction to suppress the pmemcheck warning.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/1509)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/nvml/issues/comments/265483565","html_url":"https://github.com/pmem/nvml/pull/1509#issuecomment-265483565","issue_url":"https://api.github.com/repos/pmem/nvml/issues/1509","id":265483565,"user":{"login":"marcinslusarz","id":12811376,"avatar_url":"https://avatars.githubusercontent.com/u/12811376?v=3","gravatar_id":"","url":"https://api.github.com/users/marcinslusarz","html_url":"https://github.com/marcinslusarz","followers_url":"https://api.github.com/users/marcinslusarz/followers","following_url":"https://api.github.com/users/marcinslusarz/following{/other_user}","gists_url":"https://api.github.com/users/marcinslusarz/gists{/gist_id}","starred_url":"https://api.github.com/users/marcinslusarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcinslusarz/subscriptions","organizations_url":"https://api.github.com/users/marcinslusarz/orgs","repos_url":"https://api.github.com/users/marcinslusarz/repos","events_url":"https://api.github.com/users/marcinslusarz/events{/privacy}","received_events_url":"https://api.github.com/users/marcinslusarz/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T15:49:20Z","updated_at":"2016-12-07T15:49:20Z","body":"\n\n\n\n\n\n\n\n*[src/libpmemobj/pvector.c, line 273 at r1](https://reviewable.io:443/reviews/pmem/nvml/1509#-KYOyMQ5A3lupnG1MJQ5:-KYOyMQ6-pLlAB-KO3Y3:b-7ozztp) ([raw file](https://github.com/pmem/nvml/blob/19ace27cfe7af619eed454848882c304340a4128/src/libpmemobj/pvector.c#L273)):*\n> ```C\n> \n> \tif (s.pos == 0 && s.idx != 0 /* the array 0 is embedded */) {\n> #ifndef USE_VG_PMEMCHECK\n> ```\n\nifdef\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/nvml/1509)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"marcinslusarz"}}