{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/53542781","id":53542781,"diff_hunk":"@@ -313,7 +313,7 @@ private bool IsTextualTriggerCharacter(ICompletionService completionService, cha\n             return completionService.IsTriggerCharacter(previousPosition.Snapshot.AsText(), previousPosition, GetCompletionProviders(), options);\n         }\n \n-        private bool IsCommitCharacter(char ch)\n+        private bool IsCommitCharacter(char typedChar)","path":"src/EditorFeatures/Core/Implementation/IntelliSense/Completion/Controller_TypeChar.cs","position":5,"original_position":5,"commit_id":"fca0de28d798b99fc8220d88d9cd3fbe096731b7","original_commit_id":"fca0de28d798b99fc8220d88d9cd3fbe096731b7","user":{"login":"diryboy","id":159110,"avatar_url":"https://avatars.githubusercontent.com/u/159110?v=3","gravatar_id":"","url":"https://api.github.com/users/diryboy","html_url":"https://github.com/diryboy","followers_url":"https://api.github.com/users/diryboy/followers","following_url":"https://api.github.com/users/diryboy/following{/other_user}","gists_url":"https://api.github.com/users/diryboy/gists{/gist_id}","starred_url":"https://api.github.com/users/diryboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diryboy/subscriptions","organizations_url":"https://api.github.com/users/diryboy/orgs","repos_url":"https://api.github.com/users/diryboy/repos","events_url":"https://api.github.com/users/diryboy/events{/privacy}","received_events_url":"https://api.github.com/users/diryboy/received_events","type":"User","site_admin":false},"body":"Currently Controller_CaretPositionChanged.cs does not wait for model, do you mind me placing\r\n```\r\n// TODO(cyrusn): Find a way to allow the user to cancel out of this.\r\n```\r\nas you did in Controller_TypedChar.cs?","created_at":"2016-02-20T02:39:27Z","updated_at":"2016-02-20T02:39:27Z","html_url":"https://github.com/dotnet/roslyn/pull/8668#discussion_r53542781","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/8668","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/53542781"},"html":{"href":"https://github.com/dotnet/roslyn/pull/8668#discussion_r53542781"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/8668"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/8668","id":59263623,"html_url":"https://github.com/dotnet/roslyn/pull/8668","diff_url":"https://github.com/dotnet/roslyn/pull/8668.diff","patch_url":"https://github.com/dotnet/roslyn/pull/8668.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/8668","number":8668,"state":"open","locked":false,"title":"Avoid commiting the selected item when a commit character was typed at the start of a non-empty filter span.","user":{"login":"diryboy","id":159110,"avatar_url":"https://avatars.githubusercontent.com/u/159110?v=3","gravatar_id":"","url":"https://api.github.com/users/diryboy","html_url":"https://github.com/diryboy","followers_url":"https://api.github.com/users/diryboy/followers","following_url":"https://api.github.com/users/diryboy/following{/other_user}","gists_url":"https://api.github.com/users/diryboy/gists{/gist_id}","starred_url":"https://api.github.com/users/diryboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diryboy/subscriptions","organizations_url":"https://api.github.com/users/diryboy/orgs","repos_url":"https://api.github.com/users/diryboy/repos","events_url":"https://api.github.com/users/diryboy/events{/privacy}","received_events_url":"https://api.github.com/users/diryboy/received_events","type":"User","site_admin":false},"body":"Fixes #5487","created_at":"2016-02-13T09:46:30Z","updated_at":"2016-02-20T02:39:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"599ffbe028082264f283b413e6270200c54076f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/8668/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/8668/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/8668/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/fca0de28d798b99fc8220d88d9cd3fbe096731b7","head":{"label":"diryboy:fix5487","ref":"fix5487","sha":"fca0de28d798b99fc8220d88d9cd3fbe096731b7","user":{"login":"diryboy","id":159110,"avatar_url":"https://avatars.githubusercontent.com/u/159110?v=3","gravatar_id":"","url":"https://api.github.com/users/diryboy","html_url":"https://github.com/diryboy","followers_url":"https://api.github.com/users/diryboy/followers","following_url":"https://api.github.com/users/diryboy/following{/other_user}","gists_url":"https://api.github.com/users/diryboy/gists{/gist_id}","starred_url":"https://api.github.com/users/diryboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diryboy/subscriptions","organizations_url":"https://api.github.com/users/diryboy/orgs","repos_url":"https://api.github.com/users/diryboy/repos","events_url":"https://api.github.com/users/diryboy/events{/privacy}","received_events_url":"https://api.github.com/users/diryboy/received_events","type":"User","site_admin":false},"repo":{"id":39498532,"name":"roslyn","full_name":"diryboy/roslyn","owner":{"login":"diryboy","id":159110,"avatar_url":"https://avatars.githubusercontent.com/u/159110?v=3","gravatar_id":"","url":"https://api.github.com/users/diryboy","html_url":"https://github.com/diryboy","followers_url":"https://api.github.com/users/diryboy/followers","following_url":"https://api.github.com/users/diryboy/following{/other_user}","gists_url":"https://api.github.com/users/diryboy/gists{/gist_id}","starred_url":"https://api.github.com/users/diryboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diryboy/subscriptions","organizations_url":"https://api.github.com/users/diryboy/orgs","repos_url":"https://api.github.com/users/diryboy/repos","events_url":"https://api.github.com/users/diryboy/events{/privacy}","received_events_url":"https://api.github.com/users/diryboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diryboy/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/diryboy/roslyn","forks_url":"https://api.github.com/repos/diryboy/roslyn/forks","keys_url":"https://api.github.com/repos/diryboy/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diryboy/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diryboy/roslyn/teams","hooks_url":"https://api.github.com/repos/diryboy/roslyn/hooks","issue_events_url":"https://api.github.com/repos/diryboy/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/diryboy/roslyn/events","assignees_url":"https://api.github.com/repos/diryboy/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/diryboy/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/diryboy/roslyn/tags","blobs_url":"https://api.github.com/repos/diryboy/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diryboy/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diryboy/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/diryboy/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diryboy/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/diryboy/roslyn/languages","stargazers_url":"https://api.github.com/repos/diryboy/roslyn/stargazers","contributors_url":"https://api.github.com/repos/diryboy/roslyn/contributors","subscribers_url":"https://api.github.com/repos/diryboy/roslyn/subscribers","subscription_url":"https://api.github.com/repos/diryboy/roslyn/subscription","commits_url":"https://api.github.com/repos/diryboy/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/diryboy/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/diryboy/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/diryboy/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/diryboy/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/diryboy/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diryboy/roslyn/merges","archive_url":"https://api.github.com/repos/diryboy/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diryboy/roslyn/downloads","issues_url":"https://api.github.com/repos/diryboy/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/diryboy/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/diryboy/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/diryboy/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diryboy/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/diryboy/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/diryboy/roslyn/deployments","created_at":"2015-07-22T09:50:45Z","updated_at":"2016-01-18T03:28:45Z","pushed_at":"2016-02-19T04:25:34Z","git_url":"git://github.com/diryboy/roslyn.git","ssh_url":"git@github.com:diryboy/roslyn.git","clone_url":"https://github.com/diryboy/roslyn.git","svn_url":"https://github.com/diryboy/roslyn","homepage":"","size":130175,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0b6917c0e94a73f0cc9a837f7e614b18eeedd889","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-02-19T12:40:04Z","pushed_at":"2016-02-20T02:22:28Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":159554,"stargazers_count":4450,"watchers_count":4450,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1105,"mirror_url":null,"open_issues_count":2263,"forks":1105,"open_issues":2263,"watchers":4450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/8668"},"html":{"href":"https://github.com/dotnet/roslyn/pull/8668"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/8668"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/8668/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/8668/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/8668/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/fca0de28d798b99fc8220d88d9cd3fbe096731b7"}}}}