{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/66825230","id":66825230,"diff_hunk":"@@ -72,6 +72,7 @@ This rule has an object option:\n \n * `\"SwitchCase\"` (default: 0) enforces indentation level for `case` clauses in `switch` statements\n * `\"VariableDeclarator\"` (default: 1) enforces indentation level for `var` declarators; can also take an object to define separate rules for `var`, `let` and `const` declarations.\n+* `\"IndentOuterIIFE\"` (default: true) when false enforces no indentation level increase for file-level IIFEs.","path":"docs/rules/indent.md","position":4,"original_position":4,"commit_id":"a9f26b35bbca3556f934e588b9cc0eacd1faaa87","original_commit_id":"a9f26b35bbca3556f934e588b9cc0eacd1faaa87","user":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"body":"We probably need something different here. The other options are all node types, and this is not. Also, we are really talking about indenting the IIFE body, not the IIFE itself, so we need to work on this naming a bit. ","created_at":"2016-06-13T16:39:33Z","updated_at":"2016-06-13T16:39:33Z","html_url":"https://github.com/eslint/eslint/pull/6382#discussion_r66825230","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/6382","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/66825230"},"html":{"href":"https://github.com/eslint/eslint/pull/6382#discussion_r66825230"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/6382"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/6382","id":73471615,"html_url":"https://github.com/eslint/eslint/pull/6382","diff_url":"https://github.com/eslint/eslint/pull/6382.diff","patch_url":"https://github.com/eslint/eslint/pull/6382.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/6382","number":6382,"state":"open","locked":false,"title":"Update: Implement IndentOuterIIFE option for indent rule (fixes #6259)","user":{"login":"davidshepherd7","id":795860,"avatar_url":"https://avatars.githubusercontent.com/u/795860?v=3","gravatar_id":"","url":"https://api.github.com/users/davidshepherd7","html_url":"https://github.com/davidshepherd7","followers_url":"https://api.github.com/users/davidshepherd7/followers","following_url":"https://api.github.com/users/davidshepherd7/following{/other_user}","gists_url":"https://api.github.com/users/davidshepherd7/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshepherd7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshepherd7/subscriptions","organizations_url":"https://api.github.com/users/davidshepherd7/orgs","repos_url":"https://api.github.com/users/davidshepherd7/repos","events_url":"https://api.github.com/users/davidshepherd7/events{/privacy}","received_events_url":"https://api.github.com/users/davidshepherd7/received_events","type":"User","site_admin":false},"body":"Partly fixes #6259. I've only added support for IIFEs and not for the other forms of full-file closures described [here](https://contribute.jquery.org/style-guide/js/#full-file-closures) because I don't know much about the other forms.\r\n\r\nSome questions for people who know a bit more about eslint:\r\n\r\n* Do I need to add anything to the `indent-valid-fixture-1.js` or `indent-invalid-fixture-1.js` test files?\r\n* Any thoughts on the option name?\r\n* There are some [crazy ways](http://stackoverflow.com/a/23925102/874671) of writing IIFEs, should we support them all?","created_at":"2016-06-11T16:08:01Z","updated_at":"2016-06-13T16:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b1f765a007acebd8f788224c2f0f61b13331775","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/6382/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/6382/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/6382/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/a9f26b35bbca3556f934e588b9cc0eacd1faaa87","head":{"label":"davidshepherd7:master","ref":"master","sha":"a9f26b35bbca3556f934e588b9cc0eacd1faaa87","user":{"login":"davidshepherd7","id":795860,"avatar_url":"https://avatars.githubusercontent.com/u/795860?v=3","gravatar_id":"","url":"https://api.github.com/users/davidshepherd7","html_url":"https://github.com/davidshepherd7","followers_url":"https://api.github.com/users/davidshepherd7/followers","following_url":"https://api.github.com/users/davidshepherd7/following{/other_user}","gists_url":"https://api.github.com/users/davidshepherd7/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshepherd7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshepherd7/subscriptions","organizations_url":"https://api.github.com/users/davidshepherd7/orgs","repos_url":"https://api.github.com/users/davidshepherd7/repos","events_url":"https://api.github.com/users/davidshepherd7/events{/privacy}","received_events_url":"https://api.github.com/users/davidshepherd7/received_events","type":"User","site_admin":false},"repo":{"id":60912359,"name":"eslint","full_name":"davidshepherd7/eslint","owner":{"login":"davidshepherd7","id":795860,"avatar_url":"https://avatars.githubusercontent.com/u/795860?v=3","gravatar_id":"","url":"https://api.github.com/users/davidshepherd7","html_url":"https://github.com/davidshepherd7","followers_url":"https://api.github.com/users/davidshepherd7/followers","following_url":"https://api.github.com/users/davidshepherd7/following{/other_user}","gists_url":"https://api.github.com/users/davidshepherd7/gists{/gist_id}","starred_url":"https://api.github.com/users/davidshepherd7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidshepherd7/subscriptions","organizations_url":"https://api.github.com/users/davidshepherd7/orgs","repos_url":"https://api.github.com/users/davidshepherd7/repos","events_url":"https://api.github.com/users/davidshepherd7/events{/privacy}","received_events_url":"https://api.github.com/users/davidshepherd7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidshepherd7/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/davidshepherd7/eslint","forks_url":"https://api.github.com/repos/davidshepherd7/eslint/forks","keys_url":"https://api.github.com/repos/davidshepherd7/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidshepherd7/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidshepherd7/eslint/teams","hooks_url":"https://api.github.com/repos/davidshepherd7/eslint/hooks","issue_events_url":"https://api.github.com/repos/davidshepherd7/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/davidshepherd7/eslint/events","assignees_url":"https://api.github.com/repos/davidshepherd7/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/davidshepherd7/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/davidshepherd7/eslint/tags","blobs_url":"https://api.github.com/repos/davidshepherd7/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidshepherd7/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidshepherd7/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidshepherd7/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidshepherd7/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/davidshepherd7/eslint/languages","stargazers_url":"https://api.github.com/repos/davidshepherd7/eslint/stargazers","contributors_url":"https://api.github.com/repos/davidshepherd7/eslint/contributors","subscribers_url":"https://api.github.com/repos/davidshepherd7/eslint/subscribers","subscription_url":"https://api.github.com/repos/davidshepherd7/eslint/subscription","commits_url":"https://api.github.com/repos/davidshepherd7/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidshepherd7/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidshepherd7/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidshepherd7/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidshepherd7/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/davidshepherd7/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidshepherd7/eslint/merges","archive_url":"https://api.github.com/repos/davidshepherd7/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidshepherd7/eslint/downloads","issues_url":"https://api.github.com/repos/davidshepherd7/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/davidshepherd7/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/davidshepherd7/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/davidshepherd7/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidshepherd7/eslint/labels{/name}","releases_url":"https://api.github.com/repos/davidshepherd7/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/davidshepherd7/eslint/deployments","created_at":"2016-06-11T14:59:55Z","updated_at":"2016-06-11T15:00:00Z","pushed_at":"2016-06-11T17:16:30Z","git_url":"git://github.com/davidshepherd7/eslint.git","ssh_url":"git@github.com:davidshepherd7/eslint.git","clone_url":"https://github.com/davidshepherd7/eslint.git","svn_url":"https://github.com/davidshepherd7/eslint","homepage":"http://eslint.org","size":10824,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"6b08cfc75c49c9873cdf3e1676e1092bfd2a8d65","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2016-06-13T08:29:51Z","pushed_at":"2016-06-13T15:05:02Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":15180,"stargazers_count":5144,"watchers_count":5144,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":999,"mirror_url":null,"open_issues_count":267,"forks":999,"open_issues":267,"watchers":5144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/6382"},"html":{"href":"https://github.com/eslint/eslint/pull/6382"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/6382"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/6382/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/6382/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/6382/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/a9f26b35bbca3556f934e588b9cc0eacd1faaa87"}}}}
{"actor":{"display_login":"nzakas"}}