{"action":"created","issue":{"url":"https://api.github.com/repos/OptimalBits/bull/issues/271","repository_url":"https://api.github.com/repos/OptimalBits/bull","labels_url":"https://api.github.com/repos/OptimalBits/bull/issues/271/labels{/name}","comments_url":"https://api.github.com/repos/OptimalBits/bull/issues/271/comments","events_url":"https://api.github.com/repos/OptimalBits/bull/issues/271/events","html_url":"https://github.com/OptimalBits/bull/issues/271","id":141288307,"number":271,"title":"node_redis complaining about .end() call","user":{"login":"nibblesnbits","id":6042917,"avatar_url":"https://avatars.githubusercontent.com/u/6042917?v=3","gravatar_id":"","url":"https://api.github.com/users/nibblesnbits","html_url":"https://github.com/nibblesnbits","followers_url":"https://api.github.com/users/nibblesnbits/followers","following_url":"https://api.github.com/users/nibblesnbits/following{/other_user}","gists_url":"https://api.github.com/users/nibblesnbits/gists{/gist_id}","starred_url":"https://api.github.com/users/nibblesnbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibblesnbits/subscriptions","organizations_url":"https://api.github.com/users/nibblesnbits/orgs","repos_url":"https://api.github.com/users/nibblesnbits/repos","events_url":"https://api.github.com/users/nibblesnbits/events{/privacy}","received_events_url":"https://api.github.com/users/nibblesnbits/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-16T14:16:10Z","updated_at":"2016-03-17T10:53:20Z","closed_at":null,"body":"When I call `close()` on my bull queues, I'm getting complaints from `node_redis` that the `end()` function without the `flush` parameter will throw soon.  After reading the docs, it seems passing `false` would be sufficient, but I'm curious what you think about the cleanest way to do this.  [This](https://github.com/NodeRedis/node_redis#clientendflush) bit from the docs suggests using `quit()` instead, but that waits for all requests to process.  I'll make the change if someone has a suggestion on which is best."},"comment":{"url":"https://api.github.com/repos/OptimalBits/bull/issues/comments/197817638","html_url":"https://github.com/OptimalBits/bull/issues/271#issuecomment-197817638","issue_url":"https://api.github.com/repos/OptimalBits/bull/issues/271","id":197817638,"user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars.githubusercontent.com/u/8822573?v=3","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T10:53:20Z","updated_at":"2016-03-17T10:53:20Z","body":"`end` should practically not be used at all in production, if you are not certain, that you do not care about any still running command. This function was meant for testing purposes and not for being used as the normal method to end the connection. If you use `end(false)` all still running commands are just ignored and the callback won't be called anymore. Only new commands after the function call are rejected.\r\nUsing `end(true)` is going to call the callback of all still running commands and rejecting them with a error that you did not wait for the reponse to return.\r\n\r\nYou might want to just add a stacktrace to the printed warnings on your local machine to find the origins of the calls faster (you can do so by inserting: `msg = msg + '\\n' + new Error().stack.split('\\n').splice(x).join('\\n')` in the warn function, where x is the number of lines that you want to ski)p. Running mocha should print valuable stack traces in that case. "}}