{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/7244","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/7244/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/7244/comments","events_url":"https://api.github.com/repos/electron/electron/issues/7244/events","html_url":"https://github.com/electron/electron/issues/7244","id":177643126,"number":7244,"title":"Spellchecker provider character sets & multiple spell check languages","user":{"login":"Thomas101","id":103586,"avatar_url":"https://avatars.githubusercontent.com/u/103586?v=3","gravatar_id":"","url":"https://api.github.com/users/Thomas101","html_url":"https://github.com/Thomas101","followers_url":"https://api.github.com/users/Thomas101/followers","following_url":"https://api.github.com/users/Thomas101/following{/other_user}","gists_url":"https://api.github.com/users/Thomas101/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas101/subscriptions","organizations_url":"https://api.github.com/users/Thomas101/orgs","repos_url":"https://api.github.com/users/Thomas101/repos","events_url":"https://api.github.com/users/Thomas101/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas101/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-18T10:05:46Z","updated_at":"2016-09-21T05:48:50Z","closed_at":"2016-09-21T05:48:50Z","body":"* Electron version: 1.4.0\r\n* Operating system: osx\r\n\r\nI've noticed that when setting the spellcheck provider for a certain language it doesn't run spell checking over character sets not used in that language (e.g. american characters vs cyrillics). For example if you set..\r\n\r\n```js\r\nwebFrame.setSpellCheckProvider('en-US', true, {\r\n  spellCheck (text) {\r\n    console.log(text)\r\n    return false\r\n  }\r\n})\r\n```\r\n\r\nThen if you start typing in a text field you'll find the following...\r\n* Type `english` you see `english`\r\n* Type `français` you see `français`\r\n* Type `русский` nothing gets logged out.\r\n\r\nSwap the provider language to `ru` you'll see the results in reverse.\r\n\r\nTaking this into account is it possible to...\r\n\r\n1.) Run the spellchecker over different character sets? (I'm guessing the answer to this is going to be no as I can't imagine chrome supports it...)\r\n2.) Provide spellchecking for multiple languages at once? I noticed that if you run the `setSpellCheckProvider` multiple times the last one wins\r\n3.) Give any information on the character sets used for the different languages so I can build a matrix of compatible languages?\r\n\r\nThanks for your help :-)"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/248517736","html_url":"https://github.com/electron/electron/issues/7244#issuecomment-248517736","issue_url":"https://api.github.com/repos/electron/electron/issues/7244","id":248517736,"user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars.githubusercontent.com/u/639601?v=3","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"created_at":"2016-09-21T05:48:50Z","updated_at":"2016-09-21T05:48:50Z","body":"The design of spellchecker API is from Chromium and currently it can only check spell for exactly only one language. Making it support multiple languages is nice but we don't have someone familiar with spellchecking to do it, and we don't have resources for that neither, so I'm closing this as won't fix.\r\n\r\n> After digging through the source it looks like it falls through to spellcheck_worditerator.cc which calls uscript_getCode with the language code.\r\n\r\nYeah it is the code for iterating words, and you can start hacking from it."}}
{"actor":{"display_login":"zcbenz"}}