{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/71910226","id":71910226,"diff_hunk":"@@ -0,0 +1,71 @@\n+/*\n+ * Copyright (C) 2008-2016 TrinityCore <http://www.trinitycore.org/>\n+ *\n+ * This program is free software; you can redistribute it and/or modify it\n+ * under the terms of the GNU General Public License as published by the\n+ * Free Software Foundation; either version 2 of the License, or (at your\n+ * option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for\n+ * more details.\n+ *\n+ * You should have received a copy of the GNU General Public License along\n+ * with this program. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+/*\n+ * Scripts for spells with SPELLFAMILY_DEATHKNIGHT and SPELLFAMILY_GENERIC spells used by deathknight players.\n+ * Ordered alphabetically using scriptname.\n+ * Scriptnames of files in this file should be prefixed with \"spell_dk_\".\n+ */\n+\n+#include \"Player.h\"\n+#include \"ScriptMgr.h\"\n+#include \"SpellScript.h\"\n+#include \"SpellAuraEffects.h\"\n+#include \"SpellHistory.h\"\n+#include \"Containers.h\"\n+\n+enum DemonHunterSpells\n+{\n+    SPELL_CHAOS_STRIKE_MAINHAND = 199547,\n+    SPELL_CHAOS_STRIKE_OFFHAND  = 222031,\n+};\n+\n+// 197125 - Chaos Strike\n+class spell_dh_chaos_strike : public SpellScriptLoader\n+{\n+public:\n+    spell_dh_chaos_strike() : SpellScriptLoader(\"spell_dh_chaos_strike\") { }\n+\n+    class spell_dh_chaos_strike_AuraScript : public AuraScript\n+    {\n+        PrepareAuraScript(spell_dh_chaos_strike_AuraScript);\n+\n+        void HandleEffectProc(AuraEffect const* aurEff, ProcEventInfo& eventInfo)\n+        {\n+            PreventDefaultAction();\n+\n+            if (Unit* caster = GetCaster())\n+                if (eventInfo.GetSpellInfo() && eventInfo.GetHitMask() & PROC_HIT_CRITICAL && (eventInfo.GetSpellInfo()->Id == SPELL_CHAOS_STRIKE_MAINHAND ||","path":"src/server/scripts/Spells/spell_dh.cpp","position":null,"original_position":52,"commit_id":"bed04bede88ada82c9bd9688af3b4a6bab9bba42","original_commit_id":"8e473ee10104de439b12fd4af1133eb078bd13a7","user":{"login":"Shauren","id":297439,"avatar_url":"https://avatars.githubusercontent.com/u/297439?v=3","gravatar_id":"","url":"https://api.github.com/users/Shauren","html_url":"https://github.com/Shauren","followers_url":"https://api.github.com/users/Shauren/followers","following_url":"https://api.github.com/users/Shauren/following{/other_user}","gists_url":"https://api.github.com/users/Shauren/gists{/gist_id}","starred_url":"https://api.github.com/users/Shauren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shauren/subscriptions","organizations_url":"https://api.github.com/users/Shauren/orgs","repos_url":"https://api.github.com/users/Shauren/repos","events_url":"https://api.github.com/users/Shauren/events{/privacy}","received_events_url":"https://api.github.com/users/Shauren/received_events","type":"User","site_admin":false},"body":"you control these condtions - spell, hit type with fields in database","created_at":"2016-07-22T16:54:36Z","updated_at":"2016-07-22T16:54:36Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/17651#discussion_r71910226","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/71910226"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17651#discussion_r71910226"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651","id":78467185,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/17651","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/17651.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/17651.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17651","number":17651,"state":"open","locked":false,"title":"Demon Hunter creation implementation","user":{"login":"Ovahlord","id":18347559,"avatar_url":"https://avatars.githubusercontent.com/u/18347559?v=3","gravatar_id":"","url":"https://api.github.com/users/Ovahlord","html_url":"https://github.com/Ovahlord","followers_url":"https://api.github.com/users/Ovahlord/followers","following_url":"https://api.github.com/users/Ovahlord/following{/other_user}","gists_url":"https://api.github.com/users/Ovahlord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovahlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovahlord/subscriptions","organizations_url":"https://api.github.com/users/Ovahlord/orgs","repos_url":"https://api.github.com/users/Ovahlord/repos","events_url":"https://api.github.com/users/Ovahlord/events{/privacy}","received_events_url":"https://api.github.com/users/Ovahlord/received_events","type":"User","site_admin":false},"body":"**Changes proposed**:\r\n\r\n- added configurable requirements to create a demon hunter\r\n- added database informations for required expansions\r\n- added position datas for demon hunter starting zone (thx to fabi for sniffed datas)\r\n- added rbac permission type to allow gamemasters to create demon hunters at any time\r\n\r\n**Target branch(es)**: 6x\r\n\r\n**Issues addressed**: Closes #17642\r\n\r\n**Tests performed**: tested ingame, works as intended.\r\n\r\n**Known issues and TODO list**:\r\n\r\n- [ ] need the sniffed value for orientation\r\n- [ ] need updated player levelstats for demon hunter BEFORE merging this pull request else the worldserver startup is gonna break due to missing database content (summoning @funjoker )\r\n\r\nImages:\r\n![wowscrnshot_072216_143447](https://cloud.githubusercontent.com/assets/18347559/17057366/cbde25ca-5019-11e6-9b8e-11341fa134dd.jpg)\r\n![wowscrnshot_072216_143502](https://cloud.githubusercontent.com/assets/18347559/17057371/cf7101da-5019-11e6-9f24-7f9161a5acca.jpg)\r\n![wowscrnshot_072216_143656](https://cloud.githubusercontent.com/assets/18347559/17057380/d36545d0-5019-11e6-971a-4b04ac1574b3.jpg)\r\n","created_at":"2016-07-22T12:09:34Z","updated_at":"2016-07-22T16:54:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0fc0e5b0dbb89da215cdb5bd118791b3ca23ec9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17651/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/bed04bede88ada82c9bd9688af3b4a6bab9bba42","head":{"label":"Ovahlord:DemonHunter","ref":"DemonHunter","sha":"bed04bede88ada82c9bd9688af3b4a6bab9bba42","user":{"login":"Ovahlord","id":18347559,"avatar_url":"https://avatars.githubusercontent.com/u/18347559?v=3","gravatar_id":"","url":"https://api.github.com/users/Ovahlord","html_url":"https://github.com/Ovahlord","followers_url":"https://api.github.com/users/Ovahlord/followers","following_url":"https://api.github.com/users/Ovahlord/following{/other_user}","gists_url":"https://api.github.com/users/Ovahlord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovahlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovahlord/subscriptions","organizations_url":"https://api.github.com/users/Ovahlord/orgs","repos_url":"https://api.github.com/users/Ovahlord/repos","events_url":"https://api.github.com/users/Ovahlord/events{/privacy}","received_events_url":"https://api.github.com/users/Ovahlord/received_events","type":"User","site_admin":false},"repo":{"id":55772502,"name":"TrinityCore","full_name":"Ovahlord/TrinityCore","owner":{"login":"Ovahlord","id":18347559,"avatar_url":"https://avatars.githubusercontent.com/u/18347559?v=3","gravatar_id":"","url":"https://api.github.com/users/Ovahlord","html_url":"https://github.com/Ovahlord","followers_url":"https://api.github.com/users/Ovahlord/followers","following_url":"https://api.github.com/users/Ovahlord/following{/other_user}","gists_url":"https://api.github.com/users/Ovahlord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovahlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovahlord/subscriptions","organizations_url":"https://api.github.com/users/Ovahlord/orgs","repos_url":"https://api.github.com/users/Ovahlord/repos","events_url":"https://api.github.com/users/Ovahlord/events{/privacy}","received_events_url":"https://api.github.com/users/Ovahlord/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ovahlord/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Ovahlord/TrinityCore","forks_url":"https://api.github.com/repos/Ovahlord/TrinityCore/forks","keys_url":"https://api.github.com/repos/Ovahlord/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ovahlord/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ovahlord/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Ovahlord/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Ovahlord/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Ovahlord/TrinityCore/events","assignees_url":"https://api.github.com/repos/Ovahlord/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Ovahlord/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Ovahlord/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Ovahlord/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ovahlord/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ovahlord/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ovahlord/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ovahlord/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Ovahlord/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Ovahlord/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Ovahlord/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Ovahlord/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Ovahlord/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Ovahlord/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ovahlord/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ovahlord/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ovahlord/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ovahlord/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Ovahlord/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ovahlord/TrinityCore/merges","archive_url":"https://api.github.com/repos/Ovahlord/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ovahlord/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Ovahlord/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Ovahlord/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Ovahlord/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Ovahlord/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ovahlord/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Ovahlord/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/Ovahlord/TrinityCore/deployments","created_at":"2016-04-08T10:58:46Z","updated_at":"2016-04-20T14:16:46Z","pushed_at":"2016-07-22T16:54:11Z","git_url":"git://github.com/Ovahlord/TrinityCore.git","ssh_url":"git@github.com:Ovahlord/TrinityCore.git","clone_url":"https://github.com/Ovahlord/TrinityCore.git","svn_url":"https://github.com/Ovahlord/TrinityCore","homepage":"http://www.trinitycore.org","size":349015,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"6.x"}},"base":{"label":"TrinityCore:6.x","ref":"6.x","sha":"4587b5d88082d2c6416fafaa2f5b9f5f15038520","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-07-22T07:00:41Z","pushed_at":"2016-07-22T16:54:11Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":783642,"stargazers_count":3418,"watchers_count":3418,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3489,"mirror_url":null,"open_issues_count":1294,"forks":3489,"open_issues":1294,"watchers":3418,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/17651"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17651"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/17651/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/17651/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/bed04bede88ada82c9bd9688af3b4a6bab9bba42"}}}}
{"actor":{"display_login":"Shauren"}}