{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56655039","id":56655039,"diff_hunk":"@@ -33,6 +33,11 @@ public static void Aggregate_AggregateException_Wraps_OperationCanceledException\n             Functions.AssertAggregateAlternateCanceled((token, canceler) => Cancel(token, canceler, source, operation).Aggregate(0, (i, j) => j, i => i));\n             Functions.AssertAggregateAlternateCanceled((token, canceler) => Cancel(token, canceler, source, operation).Aggregate(0, (i, j) => j, (i, j) => i, i => i));\n             Functions.AssertAggregateAlternateCanceled((token, canceler) => Cancel(token, canceler, source, operation).Aggregate(() => 0, (i, j) => j, (i, j) => i, i => i));\n+            Functions.AssertAggregateNotCanceled((token, canceler) => Cancel(token, canceler, source, operation).Aggregate((i, j) => j));","path":"src/System.Linq.Parallel/tests/Combinatorial/CancellationParallelQueryCombinationTests.cs","position":null,"original_position":4,"commit_id":"618192470a049e879620de351008978a32323efe","original_commit_id":"14059740731b744e8b8866c87e51099e26f87f2f","user":{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"Do we really need these NotCanceled tests for all of these different operators?  Is it exercising code paths that the AlternateCanceled didn't cover?  I'm not convinced that all of these extra tests add much more value than the original test that was there.","created_at":"2016-03-18T13:28:56Z","updated_at":"2016-03-18T13:28:56Z","html_url":"https://github.com/dotnet/corefx/pull/7016#discussion_r56655039","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7016","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/56655039"},"html":{"href":"https://github.com/dotnet/corefx/pull/7016#discussion_r56655039"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7016"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7016","id":63332411,"html_url":"https://github.com/dotnet/corefx/pull/7016","diff_url":"https://github.com/dotnet/corefx/pull/7016.diff","patch_url":"https://github.com/dotnet/corefx/pull/7016.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7016","number":7016,"state":"open","locked":false,"title":"Clean up and expand PLINQ cancellation tests","user":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"body":"This cleans up and expands tests relating to cancellation in PLINQ.\r\n\r\nMany of these are new tests relating to in-flight cancellation.  Several are tweaks to the existing pre-canceled tests.\r\n\r\nLine coverage is up ~.5% to 93.3%, and branch coverage is up ~1%, to 92%","created_at":"2016-03-18T06:17:49Z","updated_at":"2016-03-18T13:28:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"508472ee37532847557c5afab5f1708e6ec08b57","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7016/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7016/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7016/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/618192470a049e879620de351008978a32323efe","head":{"label":"Clockwork-Muse:516_System.Linq.Parallel_Cancellation","ref":"516_System.Linq.Parallel_Cancellation","sha":"618192470a049e879620de351008978a32323efe","user":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"repo":{"id":29805465,"name":"corefx","full_name":"Clockwork-Muse/corefx","owner":{"login":"Clockwork-Muse","id":5569508,"avatar_url":"https://avatars.githubusercontent.com/u/5569508?v=3","gravatar_id":"","url":"https://api.github.com/users/Clockwork-Muse","html_url":"https://github.com/Clockwork-Muse","followers_url":"https://api.github.com/users/Clockwork-Muse/followers","following_url":"https://api.github.com/users/Clockwork-Muse/following{/other_user}","gists_url":"https://api.github.com/users/Clockwork-Muse/gists{/gist_id}","starred_url":"https://api.github.com/users/Clockwork-Muse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clockwork-Muse/subscriptions","organizations_url":"https://api.github.com/users/Clockwork-Muse/orgs","repos_url":"https://api.github.com/users/Clockwork-Muse/repos","events_url":"https://api.github.com/users/Clockwork-Muse/events{/privacy}","received_events_url":"https://api.github.com/users/Clockwork-Muse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Clockwork-Muse/corefx","description":"","fork":true,"url":"https://api.github.com/repos/Clockwork-Muse/corefx","forks_url":"https://api.github.com/repos/Clockwork-Muse/corefx/forks","keys_url":"https://api.github.com/repos/Clockwork-Muse/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clockwork-Muse/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clockwork-Muse/corefx/teams","hooks_url":"https://api.github.com/repos/Clockwork-Muse/corefx/hooks","issue_events_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/Clockwork-Muse/corefx/events","assignees_url":"https://api.github.com/repos/Clockwork-Muse/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/Clockwork-Muse/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/Clockwork-Muse/corefx/tags","blobs_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clockwork-Muse/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/Clockwork-Muse/corefx/languages","stargazers_url":"https://api.github.com/repos/Clockwork-Muse/corefx/stargazers","contributors_url":"https://api.github.com/repos/Clockwork-Muse/corefx/contributors","subscribers_url":"https://api.github.com/repos/Clockwork-Muse/corefx/subscribers","subscription_url":"https://api.github.com/repos/Clockwork-Muse/corefx/subscription","commits_url":"https://api.github.com/repos/Clockwork-Muse/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clockwork-Muse/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clockwork-Muse/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clockwork-Muse/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/Clockwork-Muse/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clockwork-Muse/corefx/merges","archive_url":"https://api.github.com/repos/Clockwork-Muse/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clockwork-Muse/corefx/downloads","issues_url":"https://api.github.com/repos/Clockwork-Muse/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/Clockwork-Muse/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/Clockwork-Muse/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/Clockwork-Muse/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clockwork-Muse/corefx/labels{/name}","releases_url":"https://api.github.com/repos/Clockwork-Muse/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/Clockwork-Muse/corefx/deployments","created_at":"2015-01-25T06:35:53Z","updated_at":"2016-01-13T09:07:23Z","pushed_at":"2016-03-18T06:38:16Z","git_url":"git://github.com/Clockwork-Muse/corefx.git","ssh_url":"git@github.com:Clockwork-Muse/corefx.git","clone_url":"https://github.com/Clockwork-Muse/corefx.git","svn_url":"https://github.com/Clockwork-Muse/corefx","homepage":"","size":59585,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"cf4c169f9771f81009b99e29336f5d8f42c53ae0","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-03-18T11:44:45Z","pushed_at":"2016-03-18T12:17:15Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":80409,"stargazers_count":9338,"watchers_count":9338,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2196,"mirror_url":null,"open_issues_count":924,"forks":2196,"open_issues":924,"watchers":9338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7016"},"html":{"href":"https://github.com/dotnet/corefx/pull/7016"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7016"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7016/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7016/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7016/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/618192470a049e879620de351008978a32323efe"}}}}