{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9391","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9391/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9391/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9391/events","html_url":"https://github.com/nodejs/node/issues/9391","id":186456962,"number":9391,"title":"Push rebased PRs before merging","user":{"login":"strugee","id":911174,"avatar_url":"https://avatars.githubusercontent.com/u/911174?v=3","gravatar_id":"","url":"https://api.github.com/users/strugee","html_url":"https://github.com/strugee","followers_url":"https://api.github.com/users/strugee/followers","following_url":"https://api.github.com/users/strugee/following{/other_user}","gists_url":"https://api.github.com/users/strugee/gists{/gist_id}","starred_url":"https://api.github.com/users/strugee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strugee/subscriptions","organizations_url":"https://api.github.com/users/strugee/orgs","repos_url":"https://api.github.com/users/strugee/repos","events_url":"https://api.github.com/users/strugee/events{/privacy}","received_events_url":"https://api.github.com/users/strugee/received_events","type":"User","site_admin":false},"labels":[{"id":191447057,"url":"https://api.github.com/repos/nodejs/node/labels/meta","name":"meta","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-01T04:30:10Z","updated_at":"2016-11-01T15:40:40Z","closed_at":null,"body":"I've noticed that PRs sent by people outside of Node.js core (i.e. people who can't merge their own PRs) show as closed on GitHub even though technically speaking they were rebased and merged.\r\n\r\nI'm not 100% sure as I haven't tested it but I _believe_ that if whoever merges the PR pushes the rebased commits first - which can be done if the \"allow edits from maintainers\" box is checked - and then does a fast-forward merge, GitHub should mark the PR as merged.\r\n\r\nSomeone should test it on an open PR. If it doesn't work, oh well, but if it does it would be kinda nice if the merge policy was changed to use this so people could see which PRs were merged and which were closed for some other reason, which is currently impossible to determine when looking at the list of PRs."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/257600866","html_url":"https://github.com/nodejs/node/issues/9391#issuecomment-257600866","issue_url":"https://api.github.com/repos/nodejs/node/issues/9391","id":257600866,"user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"created_at":"2016-11-01T15:40:40Z","updated_at":"2016-11-01T15:40:40Z","body":"@sam-github there are currently two options:\r\n\r\n- squash all with a custom message\r\n- rebase all and apply\r\n\r\nUnfortunately that doesn't fully cover our needs but can cover simple cases."}}
{"actor":{"display_login":"Fishrock123"}}