{"action":"created","issue":{"url":"https://api.github.com/repos/MrSwitch/hello.js/issues/449","repository_url":"https://api.github.com/repos/MrSwitch/hello.js","labels_url":"https://api.github.com/repos/MrSwitch/hello.js/issues/449/labels{/name}","comments_url":"https://api.github.com/repos/MrSwitch/hello.js/issues/449/comments","events_url":"https://api.github.com/repos/MrSwitch/hello.js/issues/449/events","html_url":"https://github.com/MrSwitch/hello.js/pull/449","id":175843313,"number":449,"title":"Added setting to avoid autoemit events","user":{"login":"philsturgeon","id":67381,"avatar_url":"https://avatars.githubusercontent.com/u/67381?v=3","gravatar_id":"","url":"https://api.github.com/users/philsturgeon","html_url":"https://github.com/philsturgeon","followers_url":"https://api.github.com/users/philsturgeon/followers","following_url":"https://api.github.com/users/philsturgeon/following{/other_user}","gists_url":"https://api.github.com/users/philsturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/philsturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsturgeon/subscriptions","organizations_url":"https://api.github.com/users/philsturgeon/orgs","repos_url":"https://api.github.com/users/philsturgeon/repos","events_url":"https://api.github.com/users/philsturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/philsturgeon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-08T19:34:33Z","updated_at":"2016-09-29T21:07:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MrSwitch/hello.js/pulls/449","html_url":"https://github.com/MrSwitch/hello.js/pull/449","diff_url":"https://github.com/MrSwitch/hello.js/pull/449.diff","patch_url":"https://github.com/MrSwitch/hello.js/pull/449.patch"},"body":"I ran into a bit of trouble using Hello on a project, with it retrying logins in situations when it maybe shouldn't. This PR is a hack-job, but the following functionality really did solve my issue:\r\n\r\n``` js\r\n    hello.init({ google: 'xxxx' }, {\r\n      autoemit: false,\r\n      ...\r\n    });\r\n```\r\n\r\nLet me know how to tidy this up, and I'll see about getting some tests in when the direction seems stable."},"comment":{"url":"https://api.github.com/repos/MrSwitch/hello.js/issues/comments/250591656","html_url":"https://github.com/MrSwitch/hello.js/pull/449#issuecomment-250591656","issue_url":"https://api.github.com/repos/MrSwitch/hello.js/issues/449","id":250591656,"user":{"login":"philsturgeon","id":67381,"avatar_url":"https://avatars.githubusercontent.com/u/67381?v=3","gravatar_id":"","url":"https://api.github.com/users/philsturgeon","html_url":"https://github.com/philsturgeon","followers_url":"https://api.github.com/users/philsturgeon/followers","following_url":"https://api.github.com/users/philsturgeon/following{/other_user}","gists_url":"https://api.github.com/users/philsturgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/philsturgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsturgeon/subscriptions","organizations_url":"https://api.github.com/users/philsturgeon/orgs","repos_url":"https://api.github.com/users/philsturgeon/repos","events_url":"https://api.github.com/users/philsturgeon/events{/privacy}","received_events_url":"https://api.github.com/users/philsturgeon/received_events","type":"User","site_admin":false},"created_at":"2016-09-29T21:07:20Z","updated_at":"2016-09-29T21:07:20Z","body":"Quick bump. You said this over on the older issue #124:\r\n\r\n> @philsturgeon Could you not bind to the login handler hello(path).login().then(handleLogin) ?\r\n> Or put your autoemit flag in global events hello.on('login', () => if (config.autoemit) {...}); ?\r\n\r\nI'm not sure what this means. I do not want my login callback to act differently, I want your internal logic to not happen.\r\n\r\nThe fact that this code is happening internally and automatically is the problem, and I'm not sure that your suggestion would resolve that. "}}
{"actor":{"display_login":"philsturgeon"}}