{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/20995","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/20995/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20995/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/20995/events","html_url":"https://github.com/symfony/symfony/pull/20995","id":196628039,"number":20995,"title":"[DependencyInjection] Fix the priority order of compiler pass trait","user":{"login":"francoispluchino","id":567393,"avatar_url":"https://avatars.githubusercontent.com/u/567393?v=3","gravatar_id":"","url":"https://api.github.com/users/francoispluchino","html_url":"https://github.com/francoispluchino","followers_url":"https://api.github.com/users/francoispluchino/followers","following_url":"https://api.github.com/users/francoispluchino/following{/other_user}","gists_url":"https://api.github.com/users/francoispluchino/gists{/gist_id}","starred_url":"https://api.github.com/users/francoispluchino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francoispluchino/subscriptions","organizations_url":"https://api.github.com/users/francoispluchino/orgs","repos_url":"https://api.github.com/users/francoispluchino/repos","events_url":"https://api.github.com/users/francoispluchino/events{/privacy}","received_events_url":"https://api.github.com/users/francoispluchino/received_events","type":"User","site_admin":false},"labels":[{"id":148416,"url":"https://api.github.com/repos/symfony/symfony/labels/FrameworkBundle","name":"FrameworkBundle","color":"DDDDDD","default":false},{"id":237550465,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Reviewed","name":"Status: Reviewed","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-12-20T09:46:59Z","updated_at":"2016-12-20T14:07:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20995","html_url":"https://github.com/symfony/symfony/pull/20995","diff_url":"https://github.com/symfony/symfony/pull/20995.diff","patch_url":"https://github.com/symfony/symfony/pull/20995.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.2\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #20332, #20993\r\n| License       | MIT\r\n| Doc PR        | ~\r\n\r\nA regression has appeared between the version `3.1` and `3.2` on the compilation passes using a priority option (see #20332).\r\n\r\nIndeed, the order is no longer preserved for service definitions with the same priority. This is caused by the `SplPriorityQueue` class that does not have a FIFO implementation (see this [comment](https://github.com/symfony/symfony/issues/20332#issuecomment-268096527)).\r\n\r\nThe PR #20993 fixes the problem but only for Forms, not for all compiler passes using the `PriorityTaggedServiceTrait` trait since `3.2`."},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/268251412","html_url":"https://github.com/symfony/symfony/pull/20995#issuecomment-268251412","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20995","id":268251412,"user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T14:07:30Z","updated_at":"2016-12-20T14:07:30Z","body":"@javiereguiluz there was no priority for form extensions in Symfony 3.1, and so bundles were not defining a priority, but the order of registration was preserved. This PR is about reverting a BC break where a project would stop working when updating to 3.2 because the order of extensions defined without priority would be different (and unknown btw, making things hard to debug as it could change over time)"}}
{"actor":{"display_login":"stof"}}