{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/14","labels_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/14/comments","events_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/14/events","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/14","id":127716638,"number":14,"title":"Rename some of the functions in the basemodel","user":{"login":"jpevarnek","id":902894,"avatar_url":"https://avatars.githubusercontent.com/u/902894?v=3","gravatar_id":"","url":"https://api.github.com/users/jpevarnek","html_url":"https://github.com/jpevarnek","followers_url":"https://api.github.com/users/jpevarnek/followers","following_url":"https://api.github.com/users/jpevarnek/following{/other_user}","gists_url":"https://api.github.com/users/jpevarnek/gists{/gist_id}","starred_url":"https://api.github.com/users/jpevarnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpevarnek/subscriptions","organizations_url":"https://api.github.com/users/jpevarnek/orgs","repos_url":"https://api.github.com/users/jpevarnek/repos","events_url":"https://api.github.com/users/jpevarnek/events{/privacy}","received_events_url":"https://api.github.com/users/jpevarnek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-01-20T16:09:09Z","updated_at":"2016-01-21T15:37:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/pulls/14","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/14","diff_url":"https://github.com/uProxy/ufo-management-server-flask/pull/14.diff","patch_url":"https://github.com/uProxy/ufo-management-server-flask/pull/14.patch"},"body":"This renames two of the functions in the Model class and updates them to\r\ntake as parameters a commit argument that determines whether the\r\nsession will actually be committed immediately following that function.\r\n\r\nWe now directoly call methods on the query attribute for the models,\r\nallowing us to use get_or_404 and remove a few TODOs from the code\r\n\r\nA few fixes were mode to the add_user functionality so that should\r\nactually work (was not intending to do this, noticed some things while\r\nworking on it).\r\n\r\n@xwsxethan this is going to have conflicts with your pending PR I think, I'll deal with those once it's merged in if that's fine.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/ufo-management-server-flask/14)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/comments/173609141","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/14#issuecomment-173609141","issue_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/14","id":173609141,"user":{"login":"xwsxethan","id":6269245,"avatar_url":"https://avatars.githubusercontent.com/u/6269245?v=3","gravatar_id":"","url":"https://api.github.com/users/xwsxethan","html_url":"https://github.com/xwsxethan","followers_url":"https://api.github.com/users/xwsxethan/followers","following_url":"https://api.github.com/users/xwsxethan/following{/other_user}","gists_url":"https://api.github.com/users/xwsxethan/gists{/gist_id}","starred_url":"https://api.github.com/users/xwsxethan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwsxethan/subscriptions","organizations_url":"https://api.github.com/users/xwsxethan/orgs","repos_url":"https://api.github.com/users/xwsxethan/repos","events_url":"https://api.github.com/users/xwsxethan/events{/privacy}","received_events_url":"https://api.github.com/users/xwsxethan/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T15:37:50Z","updated_at":"2016-01-21T15:37:50Z","body":"Looks good to me. :+1: \n\n---\n\nReviewed 2 of 2 files at r2.\nReview status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[ufo/user.py, line 131 \\[r2\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/14#-K8ZohARA6teuzVNdX5X:-K8ZohARA6teuzVNdX5Y:-490100129) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/a3e1f66b93ee3302f60c73c85d3357032ed1bc28/ufo/user.py#L131)):*\nNice!\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/14#-:-K8ZpLEABc6d-I00FxfG:1426114601)*\n<!-- Sent from Reviewable.io -->\n"}}