{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/kronenthaler/libai/pulls/13","id":95357367,"html_url":"https://github.com/kronenthaler/libai/pull/13","diff_url":"https://github.com/kronenthaler/libai/pull/13.diff","patch_url":"https://github.com/kronenthaler/libai/pull/13.patch","issue_url":"https://api.github.com/repos/kronenthaler/libai/issues/13","number":13,"state":"closed","locked":false,"title":"Change currentTimeMillis() for nanoTime()","user":{"login":"dktcoding","id":709639,"avatar_url":"https://avatars.githubusercontent.com/u/709639?v=3","gravatar_id":"","url":"https://api.github.com/users/dktcoding","html_url":"https://github.com/dktcoding","followers_url":"https://api.github.com/users/dktcoding/followers","following_url":"https://api.github.com/users/dktcoding/following{/other_user}","gists_url":"https://api.github.com/users/dktcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/dktcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dktcoding/subscriptions","organizations_url":"https://api.github.com/users/dktcoding/orgs","repos_url":"https://api.github.com/users/dktcoding/repos","events_url":"https://api.github.com/users/dktcoding/events{/privacy}","received_events_url":"https://api.github.com/users/dktcoding/received_events","type":"User","site_admin":false},"body":"I've been writing and running some tests and found a somewhat troubling behavior, multiple invocations to `Matrix.random()` will return the exact same matrix...\r\n\r\n```java\r\n    @Test\r\n    public void testRandomIntInt() {\r\n        Matrix a = Matrix.random(15, 10);\r\n        Matrix b = Matrix.random(15, 10);\r\n        assertNotEquals(a, b);\r\n    }\r\n```\r\n\r\nThis is actually fascinating, I wrote the tests on my laptop and the work perfectly and when I got home they didn't work (I don't own a very good laptop...),\r\n\r\nThe proposed change is simply to make the tests work, but in the future I much rather pass a `Random` object to random initializers, and use `ThreadLocalRandom.current()` for uninitialized random objects.","created_at":"2016-11-26T01:34:26Z","updated_at":"2016-11-27T11:45:02Z","closed_at":"2016-11-27T11:45:02Z","merged_at":"2016-11-27T11:45:02Z","merge_commit_sha":"6fa2f7afbfd7112d1d713f25fe4be230d794daf4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kronenthaler/libai/pulls/13/commits","review_comments_url":"https://api.github.com/repos/kronenthaler/libai/pulls/13/comments","review_comment_url":"https://api.github.com/repos/kronenthaler/libai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kronenthaler/libai/issues/13/comments","statuses_url":"https://api.github.com/repos/kronenthaler/libai/statuses/318804197ec886f7adc7077172186066f8eea81f","head":{"label":"dktcoding:patch-1","ref":"patch-1","sha":"318804197ec886f7adc7077172186066f8eea81f","user":{"login":"dktcoding","id":709639,"avatar_url":"https://avatars.githubusercontent.com/u/709639?v=3","gravatar_id":"","url":"https://api.github.com/users/dktcoding","html_url":"https://github.com/dktcoding","followers_url":"https://api.github.com/users/dktcoding/followers","following_url":"https://api.github.com/users/dktcoding/following{/other_user}","gists_url":"https://api.github.com/users/dktcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/dktcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dktcoding/subscriptions","organizations_url":"https://api.github.com/users/dktcoding/orgs","repos_url":"https://api.github.com/users/dktcoding/repos","events_url":"https://api.github.com/users/dktcoding/events{/privacy}","received_events_url":"https://api.github.com/users/dktcoding/received_events","type":"User","site_admin":false},"repo":{"id":74713137,"name":"libai","full_name":"dktcoding/libai","owner":{"login":"dktcoding","id":709639,"avatar_url":"https://avatars.githubusercontent.com/u/709639?v=3","gravatar_id":"","url":"https://api.github.com/users/dktcoding","html_url":"https://github.com/dktcoding","followers_url":"https://api.github.com/users/dktcoding/followers","following_url":"https://api.github.com/users/dktcoding/following{/other_user}","gists_url":"https://api.github.com/users/dktcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/dktcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dktcoding/subscriptions","organizations_url":"https://api.github.com/users/dktcoding/orgs","repos_url":"https://api.github.com/users/dktcoding/repos","events_url":"https://api.github.com/users/dktcoding/events{/privacy}","received_events_url":"https://api.github.com/users/dktcoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dktcoding/libai","description":null,"fork":true,"url":"https://api.github.com/repos/dktcoding/libai","forks_url":"https://api.github.com/repos/dktcoding/libai/forks","keys_url":"https://api.github.com/repos/dktcoding/libai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dktcoding/libai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dktcoding/libai/teams","hooks_url":"https://api.github.com/repos/dktcoding/libai/hooks","issue_events_url":"https://api.github.com/repos/dktcoding/libai/issues/events{/number}","events_url":"https://api.github.com/repos/dktcoding/libai/events","assignees_url":"https://api.github.com/repos/dktcoding/libai/assignees{/user}","branches_url":"https://api.github.com/repos/dktcoding/libai/branches{/branch}","tags_url":"https://api.github.com/repos/dktcoding/libai/tags","blobs_url":"https://api.github.com/repos/dktcoding/libai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dktcoding/libai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dktcoding/libai/git/refs{/sha}","trees_url":"https://api.github.com/repos/dktcoding/libai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dktcoding/libai/statuses/{sha}","languages_url":"https://api.github.com/repos/dktcoding/libai/languages","stargazers_url":"https://api.github.com/repos/dktcoding/libai/stargazers","contributors_url":"https://api.github.com/repos/dktcoding/libai/contributors","subscribers_url":"https://api.github.com/repos/dktcoding/libai/subscribers","subscription_url":"https://api.github.com/repos/dktcoding/libai/subscription","commits_url":"https://api.github.com/repos/dktcoding/libai/commits{/sha}","git_commits_url":"https://api.github.com/repos/dktcoding/libai/git/commits{/sha}","comments_url":"https://api.github.com/repos/dktcoding/libai/comments{/number}","issue_comment_url":"https://api.github.com/repos/dktcoding/libai/issues/comments{/number}","contents_url":"https://api.github.com/repos/dktcoding/libai/contents/{+path}","compare_url":"https://api.github.com/repos/dktcoding/libai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dktcoding/libai/merges","archive_url":"https://api.github.com/repos/dktcoding/libai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dktcoding/libai/downloads","issues_url":"https://api.github.com/repos/dktcoding/libai/issues{/number}","pulls_url":"https://api.github.com/repos/dktcoding/libai/pulls{/number}","milestones_url":"https://api.github.com/repos/dktcoding/libai/milestones{/number}","notifications_url":"https://api.github.com/repos/dktcoding/libai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dktcoding/libai/labels{/name}","releases_url":"https://api.github.com/repos/dktcoding/libai/releases{/id}","deployments_url":"https://api.github.com/repos/dktcoding/libai/deployments","created_at":"2016-11-25T00:29:36Z","updated_at":"2016-11-25T00:29:38Z","pushed_at":"2016-11-26T19:48:39Z","git_url":"git://github.com/dktcoding/libai.git","ssh_url":"git@github.com:dktcoding/libai.git","clone_url":"https://github.com/dktcoding/libai.git","svn_url":"https://github.com/dktcoding/libai","homepage":null,"size":1404,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kronenthaler:master","ref":"master","sha":"04bf5742514bee8e9fee669edfe620ddc4b955e9","user":{"login":"kronenthaler","id":513315,"avatar_url":"https://avatars.githubusercontent.com/u/513315?v=3","gravatar_id":"","url":"https://api.github.com/users/kronenthaler","html_url":"https://github.com/kronenthaler","followers_url":"https://api.github.com/users/kronenthaler/followers","following_url":"https://api.github.com/users/kronenthaler/following{/other_user}","gists_url":"https://api.github.com/users/kronenthaler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronenthaler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronenthaler/subscriptions","organizations_url":"https://api.github.com/users/kronenthaler/orgs","repos_url":"https://api.github.com/users/kronenthaler/repos","events_url":"https://api.github.com/users/kronenthaler/events{/privacy}","received_events_url":"https://api.github.com/users/kronenthaler/received_events","type":"User","site_admin":false},"repo":{"id":7753784,"name":"libai","full_name":"kronenthaler/libai","owner":{"login":"kronenthaler","id":513315,"avatar_url":"https://avatars.githubusercontent.com/u/513315?v=3","gravatar_id":"","url":"https://api.github.com/users/kronenthaler","html_url":"https://github.com/kronenthaler","followers_url":"https://api.github.com/users/kronenthaler/followers","following_url":"https://api.github.com/users/kronenthaler/following{/other_user}","gists_url":"https://api.github.com/users/kronenthaler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronenthaler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronenthaler/subscriptions","organizations_url":"https://api.github.com/users/kronenthaler/orgs","repos_url":"https://api.github.com/users/kronenthaler/repos","events_url":"https://api.github.com/users/kronenthaler/events{/privacy}","received_events_url":"https://api.github.com/users/kronenthaler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kronenthaler/libai","description":null,"fork":false,"url":"https://api.github.com/repos/kronenthaler/libai","forks_url":"https://api.github.com/repos/kronenthaler/libai/forks","keys_url":"https://api.github.com/repos/kronenthaler/libai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kronenthaler/libai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kronenthaler/libai/teams","hooks_url":"https://api.github.com/repos/kronenthaler/libai/hooks","issue_events_url":"https://api.github.com/repos/kronenthaler/libai/issues/events{/number}","events_url":"https://api.github.com/repos/kronenthaler/libai/events","assignees_url":"https://api.github.com/repos/kronenthaler/libai/assignees{/user}","branches_url":"https://api.github.com/repos/kronenthaler/libai/branches{/branch}","tags_url":"https://api.github.com/repos/kronenthaler/libai/tags","blobs_url":"https://api.github.com/repos/kronenthaler/libai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kronenthaler/libai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kronenthaler/libai/git/refs{/sha}","trees_url":"https://api.github.com/repos/kronenthaler/libai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kronenthaler/libai/statuses/{sha}","languages_url":"https://api.github.com/repos/kronenthaler/libai/languages","stargazers_url":"https://api.github.com/repos/kronenthaler/libai/stargazers","contributors_url":"https://api.github.com/repos/kronenthaler/libai/contributors","subscribers_url":"https://api.github.com/repos/kronenthaler/libai/subscribers","subscription_url":"https://api.github.com/repos/kronenthaler/libai/subscription","commits_url":"https://api.github.com/repos/kronenthaler/libai/commits{/sha}","git_commits_url":"https://api.github.com/repos/kronenthaler/libai/git/commits{/sha}","comments_url":"https://api.github.com/repos/kronenthaler/libai/comments{/number}","issue_comment_url":"https://api.github.com/repos/kronenthaler/libai/issues/comments{/number}","contents_url":"https://api.github.com/repos/kronenthaler/libai/contents/{+path}","compare_url":"https://api.github.com/repos/kronenthaler/libai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kronenthaler/libai/merges","archive_url":"https://api.github.com/repos/kronenthaler/libai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kronenthaler/libai/downloads","issues_url":"https://api.github.com/repos/kronenthaler/libai/issues{/number}","pulls_url":"https://api.github.com/repos/kronenthaler/libai/pulls{/number}","milestones_url":"https://api.github.com/repos/kronenthaler/libai/milestones{/number}","notifications_url":"https://api.github.com/repos/kronenthaler/libai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kronenthaler/libai/labels{/name}","releases_url":"https://api.github.com/repos/kronenthaler/libai/releases{/id}","deployments_url":"https://api.github.com/repos/kronenthaler/libai/deployments","created_at":"2013-01-22T14:30:50Z","updated_at":"2016-11-12T00:38:16Z","pushed_at":"2016-11-27T11:45:02Z","git_url":"git://github.com/kronenthaler/libai.git","ssh_url":"git@github.com:kronenthaler/libai.git","clone_url":"https://github.com/kronenthaler/libai.git","svn_url":"https://github.com/kronenthaler/libai","homepage":null,"size":1912,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kronenthaler/libai/pulls/13"},"html":{"href":"https://github.com/kronenthaler/libai/pull/13"},"issue":{"href":"https://api.github.com/repos/kronenthaler/libai/issues/13"},"comments":{"href":"https://api.github.com/repos/kronenthaler/libai/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/kronenthaler/libai/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/kronenthaler/libai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kronenthaler/libai/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/kronenthaler/libai/statuses/318804197ec886f7adc7077172186066f8eea81f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kronenthaler","id":513315,"avatar_url":"https://avatars.githubusercontent.com/u/513315?v=3","gravatar_id":"","url":"https://api.github.com/users/kronenthaler","html_url":"https://github.com/kronenthaler","followers_url":"https://api.github.com/users/kronenthaler/followers","following_url":"https://api.github.com/users/kronenthaler/following{/other_user}","gists_url":"https://api.github.com/users/kronenthaler/gists{/gist_id}","starred_url":"https://api.github.com/users/kronenthaler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronenthaler/subscriptions","organizations_url":"https://api.github.com/users/kronenthaler/orgs","repos_url":"https://api.github.com/users/kronenthaler/repos","events_url":"https://api.github.com/users/kronenthaler/events{/privacy}","received_events_url":"https://api.github.com/users/kronenthaler/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"kronenthaler"}}