{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/comments/93446183","pull_request_review_id":13973731,"id":93446183,"diff_hunk":"@@ -45,3 +46,18 @@ node {\n     throw e\n   }\n }\n+\n+// Run schema tests outside of 'node' definition, so that they do not block the\n+// original executor while the downstream tests are being run\n+if (env.BRANCH_NAME != 'master') {","path":"Jenkinsfile","position":26,"original_position":26,"commit_id":"5fba6d588b6398279bc8c1b1104a889c86b47891","original_commit_id":"5fba6d588b6398279bc8c1b1104a889c86b47891","user":{"login":"cbaines","id":1130010,"avatar_url":"https://avatars.githubusercontent.com/u/1130010?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaines","html_url":"https://github.com/cbaines","followers_url":"https://api.github.com/users/cbaines/followers","following_url":"https://api.github.com/users/cbaines/following{/other_user}","gists_url":"https://api.github.com/users/cbaines/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaines/subscriptions","organizations_url":"https://api.github.com/users/cbaines/orgs","repos_url":"https://api.github.com/users/cbaines/repos","events_url":"https://api.github.com/users/cbaines/events{/privacy}","received_events_url":"https://api.github.com/users/cbaines/received_events","type":"User","site_admin":false},"body":"If I remember correctly, the current CI setup has tests in apps are run regardless of the branch, however, I think the overall job status is only dependent on all of the other builds succeeding when building the master branch.\r\n\r\nThis looks like the app tests are only run when not building master, which I think is different from how the CI works currently. Is this an intentional change?","created_at":"2016-12-21T14:25:40Z","updated_at":"2016-12-21T14:25:40Z","html_url":"https://github.com/alphagov/govuk-content-schemas/pull/460#discussion_r93446183","pull_request_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/comments/93446183"},"html":{"href":"https://github.com/alphagov/govuk-content-schemas/pull/460#discussion_r93446183"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460","id":97774815,"html_url":"https://github.com/alphagov/govuk-content-schemas/pull/460","diff_url":"https://github.com/alphagov/govuk-content-schemas/pull/460.diff","patch_url":"https://github.com/alphagov/govuk-content-schemas/pull/460.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/460","number":460,"state":"open","locked":false,"title":"Configure downstream builds in Jenkins 2","user":{"login":"suzannehamilton","id":754712,"avatar_url":"https://avatars.githubusercontent.com/u/754712?v=3","gravatar_id":"","url":"https://api.github.com/users/suzannehamilton","html_url":"https://github.com/suzannehamilton","followers_url":"https://api.github.com/users/suzannehamilton/followers","following_url":"https://api.github.com/users/suzannehamilton/following{/other_user}","gists_url":"https://api.github.com/users/suzannehamilton/gists{/gist_id}","starred_url":"https://api.github.com/users/suzannehamilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suzannehamilton/subscriptions","organizations_url":"https://api.github.com/users/suzannehamilton/orgs","repos_url":"https://api.github.com/users/suzannehamilton/repos","events_url":"https://api.github.com/users/suzannehamilton/events{/privacy}","received_events_url":"https://api.github.com/users/suzannehamilton/received_events","type":"User","site_admin":false},"body":"This is a spike to work out how best to trigger builds of projects which depend on the schemas.\r\n\r\nIn this approach, we call the downstream builds directly from the govuk-content-schemas Jenkinsfile. We'll have to test whether this approach updates pull request checks correctly.\r\n\r\nIt's separate from PR #458, because we might be able to merge that one as soon as this project is being built by Jenkins 2.\r\n\r\nhttps://trello.com/c/S4DZbsPa/285-jenkins-2-migration","created_at":"2016-12-13T15:39:09Z","updated_at":"2016-12-21T14:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bff0bcec1c5abffe6410ffc5ff05c3e7b2fe7c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/460/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/5fba6d588b6398279bc8c1b1104a889c86b47891","head":{"label":"alphagov:jenkinsfile-schema-dependencies","ref":"jenkinsfile-schema-dependencies","sha":"5fba6d588b6398279bc8c1b1104a889c86b47891","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":27441121,"name":"govuk-content-schemas","full_name":"alphagov/govuk-content-schemas","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-content-schemas","description":"Definitions of the data formats used to represent content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-content-schemas","forks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/deployments","created_at":"2014-12-02T16:20:33Z","updated_at":"2016-10-24T10:18:31Z","pushed_at":"2016-12-21T14:08:36Z","git_url":"git://github.com/alphagov/govuk-content-schemas.git","ssh_url":"git@github.com:alphagov/govuk-content-schemas.git","clone_url":"https://github.com/alphagov/govuk-content-schemas.git","svn_url":"https://github.com/alphagov/govuk-content-schemas","homepage":null,"size":4149,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"655ec790dc70ce6ffaf01cf59ef8f53490949284","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":27441121,"name":"govuk-content-schemas","full_name":"alphagov/govuk-content-schemas","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-content-schemas","description":"Definitions of the data formats used to represent content on GOV.UK","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-content-schemas","forks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-content-schemas/deployments","created_at":"2014-12-02T16:20:33Z","updated_at":"2016-10-24T10:18:31Z","pushed_at":"2016-12-21T14:08:36Z","git_url":"git://github.com/alphagov/govuk-content-schemas.git","ssh_url":"git@github.com:alphagov/govuk-content-schemas.git","clone_url":"https://github.com/alphagov/govuk-content-schemas.git","svn_url":"https://github.com/alphagov/govuk-content-schemas","homepage":null,"size":4149,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460"},"html":{"href":"https://github.com/alphagov/govuk-content-schemas/pull/460"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/460"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-content-schemas/statuses/5fba6d588b6398279bc8c1b1104a889c86b47891"}}}}
{"actor":{"display_login":"cbaines"}}