{"action":"created","issue":{"url":"https://api.github.com/repos/SSSD/sssd/issues/74","repository_url":"https://api.github.com/repos/SSSD/sssd","labels_url":"https://api.github.com/repos/SSSD/sssd/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/SSSD/sssd/issues/74/comments","events_url":"https://api.github.com/repos/SSSD/sssd/issues/74/events","html_url":"https://github.com/SSSD/sssd/pull/74","id":187962388,"number":74,"title":"IPA/AD: check auth ctx before using it","user":{"login":"sumit-bose","id":15247317,"avatar_url":"https://avatars.githubusercontent.com/u/15247317?v=3","gravatar_id":"","url":"https://api.github.com/users/sumit-bose","html_url":"https://github.com/sumit-bose","followers_url":"https://api.github.com/users/sumit-bose/followers","following_url":"https://api.github.com/users/sumit-bose/following{/other_user}","gists_url":"https://api.github.com/users/sumit-bose/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit-bose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit-bose/subscriptions","organizations_url":"https://api.github.com/users/sumit-bose/orgs","repos_url":"https://api.github.com/users/sumit-bose/repos","events_url":"https://api.github.com/users/sumit-bose/events{/privacy}","received_events_url":"https://api.github.com/users/sumit-bose/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"celestian","id":1382015,"avatar_url":"https://avatars.githubusercontent.com/u/1382015?v=3","gravatar_id":"","url":"https://api.github.com/users/celestian","html_url":"https://github.com/celestian","followers_url":"https://api.github.com/users/celestian/followers","following_url":"https://api.github.com/users/celestian/following{/other_user}","gists_url":"https://api.github.com/users/celestian/gists{/gist_id}","starred_url":"https://api.github.com/users/celestian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celestian/subscriptions","organizations_url":"https://api.github.com/users/celestian/orgs","repos_url":"https://api.github.com/users/celestian/repos","events_url":"https://api.github.com/users/celestian/events{/privacy}","received_events_url":"https://api.github.com/users/celestian/received_events","type":"User","site_admin":false},"assignees":[{"login":"celestian","id":1382015,"avatar_url":"https://avatars.githubusercontent.com/u/1382015?v=3","gravatar_id":"","url":"https://api.github.com/users/celestian","html_url":"https://github.com/celestian","followers_url":"https://api.github.com/users/celestian/followers","following_url":"https://api.github.com/users/celestian/following{/other_user}","gists_url":"https://api.github.com/users/celestian/gists{/gist_id}","starred_url":"https://api.github.com/users/celestian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celestian/subscriptions","organizations_url":"https://api.github.com/users/celestian/orgs","repos_url":"https://api.github.com/users/celestian/repos","events_url":"https://api.github.com/users/celestian/events{/privacy}","received_events_url":"https://api.github.com/users/celestian/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-11-08T11:01:29Z","updated_at":"2016-11-10T11:12:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SSSD/sssd/pulls/74","html_url":"https://github.com/SSSD/sssd/pull/74","diff_url":"https://github.com/SSSD/sssd/pull/74.diff","patch_url":"https://github.com/SSSD/sssd/pull/74.patch"},"body":"In e6b6b9fa79c67d7d2698bc7e33d2e2f6bb53d483 a feature was introduced to\nset the 'canonicalize' option in the system-wide Kerberos configuration\naccording to the settings in SSSD if the AD or IPA provider were used.\nUnfortunately the patch implied that the auth provider is the same as\nthe id provider which might not always be the case. A different auth\nprovider caused a crash in the backend which is fixed by this patch.\n\nResolves https://fedorahosted.org/sssd/ticket/3234\n\nI tried to add an integration test to see if SSSD can start with a mixed\nconfiguration but the AD provider tries to set some SASL parameters which\nrequires e.g. an existing keytab which is afaik currently not available in the\nintegration test. Since this issue it easy to reproduce manually (start SSSD\nwith id_provder=ad and auth_provider=krb5) I hope it is acceptable that an\nintegration test can be added later when the infrastructure for AD provider\ntests is available?"},"comment":{"url":"https://api.github.com/repos/SSSD/sssd/issues/comments/259664277","html_url":"https://github.com/SSSD/sssd/pull/74#issuecomment-259664277","issue_url":"https://api.github.com/repos/SSSD/sssd/issues/74","id":259664277,"user":{"login":"celestian","id":1382015,"avatar_url":"https://avatars.githubusercontent.com/u/1382015?v=3","gravatar_id":"","url":"https://api.github.com/users/celestian","html_url":"https://github.com/celestian","followers_url":"https://api.github.com/users/celestian/followers","following_url":"https://api.github.com/users/celestian/following{/other_user}","gists_url":"https://api.github.com/users/celestian/gists{/gist_id}","starred_url":"https://api.github.com/users/celestian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/celestian/subscriptions","organizations_url":"https://api.github.com/users/celestian/orgs","repos_url":"https://api.github.com/users/celestian/repos","events_url":"https://api.github.com/users/celestian/events{/privacy}","received_events_url":"https://api.github.com/users/celestian/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T11:12:45Z","updated_at":"2016-11-10T11:12:45Z","body":"Code looks good to me. CI tests passed: http://sssd-ci.duckdns.org/logs/job/56/88/summary.html\r\nAnd I manually test it.\r\n\r\n@sumit-bose, could you please file ticket for witting test on it? I understand it is not possible to write it now.\r\n\r\nACK"}}
{"actor":{"display_login":"celestian"}}