{"action":"created","issue":{"url":"https://api.github.com/repos/deis/router/issues/164","repository_url":"https://api.github.com/repos/deis/router","labels_url":"https://api.github.com/repos/deis/router/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/deis/router/issues/164/comments","events_url":"https://api.github.com/repos/deis/router/issues/164/events","html_url":"https://github.com/deis/router/issues/164","id":149471702,"number":164,"title":"router/certificates only work with full domains","user":{"login":"jcmoraisjr","id":1457820,"avatar_url":"https://avatars.githubusercontent.com/u/1457820?v=3","gravatar_id":"","url":"https://api.github.com/users/jcmoraisjr","html_url":"https://github.com/jcmoraisjr","followers_url":"https://api.github.com/users/jcmoraisjr/followers","following_url":"https://api.github.com/users/jcmoraisjr/following{/other_user}","gists_url":"https://api.github.com/users/jcmoraisjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jcmoraisjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcmoraisjr/subscriptions","organizations_url":"https://api.github.com/users/jcmoraisjr/orgs","repos_url":"https://api.github.com/users/jcmoraisjr/repos","events_url":"https://api.github.com/users/jcmoraisjr/events{/privacy}","received_events_url":"https://api.github.com/users/jcmoraisjr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-19T14:08:26Z","updated_at":"2016-05-31T21:42:11Z","closed_at":"2016-05-31T21:42:11Z","body":"The annotation `router.deis.io/domains` does work as expected if the domain doesn't have any dot `.`: such domain will be a subdomain of `router.deis.io/nginx.platformDomain` defined in the router annotation.\r\n\r\nI tried to configure https using this same approach but the configuration didn't work. Eg:\r\n\r\n**This works:**\r\n\r\n* Router RC:\r\n    * `router.deis.io/nginx.platformDomain: \"example.com\"`\r\n* Routable app:\r\n    * `router.deis.io/domains: \"bar\"`\r\n\r\nHttp is configured as `bar.example.com`\r\n\r\n**This also works:**\r\n\r\n* Router RC:\r\n    * `router.deis.io/nginx.platformDomain: \"example.com\"`\r\n* Routable app:\r\n    * `router.deis.io/domains: \"bar.example.com\"`\r\n    * `router.deis.io/certificates: \"bar.example.com:bar\"`\r\n\r\nBoth http and https are configured as `bar.example.com`. The cert and key declared in `secret/bar-cert` are used as expected.\r\n\r\n**This does not work:**\r\n\r\n* Router RC:\r\n    * `router.deis.io/nginx.platformDomain: \"example.com\"`\r\n* Routable app:\r\n    * `router.deis.io/domains: \"bar\"`\r\n    * `router.deis.io/certificates: \"bar:bar\"`\r\n\r\nHttp is configured and https is ignored.\r\n"},"comment":{"url":"https://api.github.com/repos/deis/router/issues/comments/222830280","html_url":"https://github.com/deis/router/issues/164#issuecomment-222830280","issue_url":"https://api.github.com/repos/deis/router/issues/164","id":222830280,"user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T21:42:11Z","updated_at":"2016-05-31T21:42:11Z","body":"Closing this. I've let this marinate for a while and still feel strongly that the current behavior is correct and that modifying that would create opportunities for cluster ops to break apps without even knowing they'd done so."}}
{"actor":{"display_login":"krancour"}}