{"action":"closed","number":1748,"pull_request":{"url":"https://api.github.com/repos/Vazkii/Botania/pulls/1748","id":55993463,"html_url":"https://github.com/Vazkii/Botania/pull/1748","diff_url":"https://github.com/Vazkii/Botania/pull/1748.diff","patch_url":"https://github.com/Vazkii/Botania/pull/1748.patch","issue_url":"https://api.github.com/repos/Vazkii/Botania/issues/1748","number":1748,"state":"closed","locked":false,"title":"Hotfix #1722 - Allow client to control sash speedup and slowdown","user":{"login":"blacksmithgu","id":616490,"avatar_url":"https://avatars.githubusercontent.com/u/616490?v=3","gravatar_id":"","url":"https://api.github.com/users/blacksmithgu","html_url":"https://github.com/blacksmithgu","followers_url":"https://api.github.com/users/blacksmithgu/followers","following_url":"https://api.github.com/users/blacksmithgu/following{/other_user}","gists_url":"https://api.github.com/users/blacksmithgu/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksmithgu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksmithgu/subscriptions","organizations_url":"https://api.github.com/users/blacksmithgu/orgs","repos_url":"https://api.github.com/users/blacksmithgu/repos","events_url":"https://api.github.com/users/blacksmithgu/events{/privacy}","received_events_url":"https://api.github.com/users/blacksmithgu/received_events","type":"User","site_admin":false},"body":"This provides the straightforward solution as outlined in #1722, by allowing the client to also handle slowdowns. The existing code allowed the client to handle the actual speedup, but prevented it from reseting the speed as well due to a remote server check. The actual origin of the bug is related to `Entity.moveForward` always being `0.0F` on the server, but the fix for it is nontrivial and this will work as a working solution in the meanwhile.\r\n\r\nWith this patch, the sash properly resets it's speed both on the client and the server if the user stops for a few moments. The sash speeds up properly as it already has been.\r\n\r\nComments welcome.","created_at":"2016-01-14T05:11:09Z","updated_at":"2016-01-14T16:55:01Z","closed_at":"2016-01-14T16:55:01Z","merged_at":"2016-01-14T16:55:01Z","merge_commit_sha":"3402a6fb698fb3d86ebf3e17f3c60ce0915650bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Vazkii/Botania/pulls/1748/commits","review_comments_url":"https://api.github.com/repos/Vazkii/Botania/pulls/1748/comments","review_comment_url":"https://api.github.com/repos/Vazkii/Botania/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vazkii/Botania/issues/1748/comments","statuses_url":"https://api.github.com/repos/Vazkii/Botania/statuses/0595397943108aba4b387799d650c6a90aea8631","head":{"label":"blacksmithgu:patch-1722","ref":"patch-1722","sha":"0595397943108aba4b387799d650c6a90aea8631","user":{"login":"blacksmithgu","id":616490,"avatar_url":"https://avatars.githubusercontent.com/u/616490?v=3","gravatar_id":"","url":"https://api.github.com/users/blacksmithgu","html_url":"https://github.com/blacksmithgu","followers_url":"https://api.github.com/users/blacksmithgu/followers","following_url":"https://api.github.com/users/blacksmithgu/following{/other_user}","gists_url":"https://api.github.com/users/blacksmithgu/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksmithgu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksmithgu/subscriptions","organizations_url":"https://api.github.com/users/blacksmithgu/orgs","repos_url":"https://api.github.com/users/blacksmithgu/repos","events_url":"https://api.github.com/users/blacksmithgu/events{/privacy}","received_events_url":"https://api.github.com/users/blacksmithgu/received_events","type":"User","site_admin":false},"repo":{"id":49457397,"name":"Botania","full_name":"blacksmithgu/Botania","owner":{"login":"blacksmithgu","id":616490,"avatar_url":"https://avatars.githubusercontent.com/u/616490?v=3","gravatar_id":"","url":"https://api.github.com/users/blacksmithgu","html_url":"https://github.com/blacksmithgu","followers_url":"https://api.github.com/users/blacksmithgu/followers","following_url":"https://api.github.com/users/blacksmithgu/following{/other_user}","gists_url":"https://api.github.com/users/blacksmithgu/gists{/gist_id}","starred_url":"https://api.github.com/users/blacksmithgu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blacksmithgu/subscriptions","organizations_url":"https://api.github.com/users/blacksmithgu/orgs","repos_url":"https://api.github.com/users/blacksmithgu/repos","events_url":"https://api.github.com/users/blacksmithgu/events{/privacy}","received_events_url":"https://api.github.com/users/blacksmithgu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blacksmithgu/Botania","description":"A magic mod for Minecraft based on nature and plant life. Also literally the seed of all evil on the modding community.","fork":true,"url":"https://api.github.com/repos/blacksmithgu/Botania","forks_url":"https://api.github.com/repos/blacksmithgu/Botania/forks","keys_url":"https://api.github.com/repos/blacksmithgu/Botania/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blacksmithgu/Botania/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blacksmithgu/Botania/teams","hooks_url":"https://api.github.com/repos/blacksmithgu/Botania/hooks","issue_events_url":"https://api.github.com/repos/blacksmithgu/Botania/issues/events{/number}","events_url":"https://api.github.com/repos/blacksmithgu/Botania/events","assignees_url":"https://api.github.com/repos/blacksmithgu/Botania/assignees{/user}","branches_url":"https://api.github.com/repos/blacksmithgu/Botania/branches{/branch}","tags_url":"https://api.github.com/repos/blacksmithgu/Botania/tags","blobs_url":"https://api.github.com/repos/blacksmithgu/Botania/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blacksmithgu/Botania/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blacksmithgu/Botania/git/refs{/sha}","trees_url":"https://api.github.com/repos/blacksmithgu/Botania/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blacksmithgu/Botania/statuses/{sha}","languages_url":"https://api.github.com/repos/blacksmithgu/Botania/languages","stargazers_url":"https://api.github.com/repos/blacksmithgu/Botania/stargazers","contributors_url":"https://api.github.com/repos/blacksmithgu/Botania/contributors","subscribers_url":"https://api.github.com/repos/blacksmithgu/Botania/subscribers","subscription_url":"https://api.github.com/repos/blacksmithgu/Botania/subscription","commits_url":"https://api.github.com/repos/blacksmithgu/Botania/commits{/sha}","git_commits_url":"https://api.github.com/repos/blacksmithgu/Botania/git/commits{/sha}","comments_url":"https://api.github.com/repos/blacksmithgu/Botania/comments{/number}","issue_comment_url":"https://api.github.com/repos/blacksmithgu/Botania/issues/comments{/number}","contents_url":"https://api.github.com/repos/blacksmithgu/Botania/contents/{+path}","compare_url":"https://api.github.com/repos/blacksmithgu/Botania/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blacksmithgu/Botania/merges","archive_url":"https://api.github.com/repos/blacksmithgu/Botania/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blacksmithgu/Botania/downloads","issues_url":"https://api.github.com/repos/blacksmithgu/Botania/issues{/number}","pulls_url":"https://api.github.com/repos/blacksmithgu/Botania/pulls{/number}","milestones_url":"https://api.github.com/repos/blacksmithgu/Botania/milestones{/number}","notifications_url":"https://api.github.com/repos/blacksmithgu/Botania/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blacksmithgu/Botania/labels{/name}","releases_url":"https://api.github.com/repos/blacksmithgu/Botania/releases{/id}","created_at":"2016-01-11T22:03:51Z","updated_at":"2016-01-11T22:03:55Z","pushed_at":"2016-01-14T05:08:28Z","git_url":"git://github.com/blacksmithgu/Botania.git","ssh_url":"git@github.com:blacksmithgu/Botania.git","clone_url":"https://github.com/blacksmithgu/Botania.git","svn_url":"https://github.com/blacksmithgu/Botania","homepage":"http://botaniamod.net/","size":31590,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Vazkii:master","ref":"master","sha":"d3055c4c4d4381e199c77bbe6a208c2cb5d0097e","user":{"login":"Vazkii","id":1794735,"avatar_url":"https://avatars.githubusercontent.com/u/1794735?v=3","gravatar_id":"","url":"https://api.github.com/users/Vazkii","html_url":"https://github.com/Vazkii","followers_url":"https://api.github.com/users/Vazkii/followers","following_url":"https://api.github.com/users/Vazkii/following{/other_user}","gists_url":"https://api.github.com/users/Vazkii/gists{/gist_id}","starred_url":"https://api.github.com/users/Vazkii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vazkii/subscriptions","organizations_url":"https://api.github.com/users/Vazkii/orgs","repos_url":"https://api.github.com/users/Vazkii/repos","events_url":"https://api.github.com/users/Vazkii/events{/privacy}","received_events_url":"https://api.github.com/users/Vazkii/received_events","type":"User","site_admin":false},"repo":{"id":15870488,"name":"Botania","full_name":"Vazkii/Botania","owner":{"login":"Vazkii","id":1794735,"avatar_url":"https://avatars.githubusercontent.com/u/1794735?v=3","gravatar_id":"","url":"https://api.github.com/users/Vazkii","html_url":"https://github.com/Vazkii","followers_url":"https://api.github.com/users/Vazkii/followers","following_url":"https://api.github.com/users/Vazkii/following{/other_user}","gists_url":"https://api.github.com/users/Vazkii/gists{/gist_id}","starred_url":"https://api.github.com/users/Vazkii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vazkii/subscriptions","organizations_url":"https://api.github.com/users/Vazkii/orgs","repos_url":"https://api.github.com/users/Vazkii/repos","events_url":"https://api.github.com/users/Vazkii/events{/privacy}","received_events_url":"https://api.github.com/users/Vazkii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vazkii/Botania","description":"A magic mod for Minecraft based on nature and plant life. Also literally the seed of all evil on the modding community.","fork":false,"url":"https://api.github.com/repos/Vazkii/Botania","forks_url":"https://api.github.com/repos/Vazkii/Botania/forks","keys_url":"https://api.github.com/repos/Vazkii/Botania/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vazkii/Botania/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vazkii/Botania/teams","hooks_url":"https://api.github.com/repos/Vazkii/Botania/hooks","issue_events_url":"https://api.github.com/repos/Vazkii/Botania/issues/events{/number}","events_url":"https://api.github.com/repos/Vazkii/Botania/events","assignees_url":"https://api.github.com/repos/Vazkii/Botania/assignees{/user}","branches_url":"https://api.github.com/repos/Vazkii/Botania/branches{/branch}","tags_url":"https://api.github.com/repos/Vazkii/Botania/tags","blobs_url":"https://api.github.com/repos/Vazkii/Botania/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vazkii/Botania/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vazkii/Botania/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vazkii/Botania/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vazkii/Botania/statuses/{sha}","languages_url":"https://api.github.com/repos/Vazkii/Botania/languages","stargazers_url":"https://api.github.com/repos/Vazkii/Botania/stargazers","contributors_url":"https://api.github.com/repos/Vazkii/Botania/contributors","subscribers_url":"https://api.github.com/repos/Vazkii/Botania/subscribers","subscription_url":"https://api.github.com/repos/Vazkii/Botania/subscription","commits_url":"https://api.github.com/repos/Vazkii/Botania/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vazkii/Botania/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vazkii/Botania/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vazkii/Botania/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vazkii/Botania/contents/{+path}","compare_url":"https://api.github.com/repos/Vazkii/Botania/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vazkii/Botania/merges","archive_url":"https://api.github.com/repos/Vazkii/Botania/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vazkii/Botania/downloads","issues_url":"https://api.github.com/repos/Vazkii/Botania/issues{/number}","pulls_url":"https://api.github.com/repos/Vazkii/Botania/pulls{/number}","milestones_url":"https://api.github.com/repos/Vazkii/Botania/milestones{/number}","notifications_url":"https://api.github.com/repos/Vazkii/Botania/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vazkii/Botania/labels{/name}","releases_url":"https://api.github.com/repos/Vazkii/Botania/releases{/id}","created_at":"2014-01-13T14:30:52Z","updated_at":"2016-01-14T12:42:28Z","pushed_at":"2016-01-14T16:55:01Z","git_url":"git://github.com/Vazkii/Botania.git","ssh_url":"git@github.com:Vazkii/Botania.git","clone_url":"https://github.com/Vazkii/Botania.git","svn_url":"https://github.com/Vazkii/Botania","homepage":"http://botaniamod.net/","size":33584,"stargazers_count":335,"watchers_count":335,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":36,"forks":198,"open_issues":36,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vazkii/Botania/pulls/1748"},"html":{"href":"https://github.com/Vazkii/Botania/pull/1748"},"issue":{"href":"https://api.github.com/repos/Vazkii/Botania/issues/1748"},"comments":{"href":"https://api.github.com/repos/Vazkii/Botania/issues/1748/comments"},"review_comments":{"href":"https://api.github.com/repos/Vazkii/Botania/pulls/1748/comments"},"review_comment":{"href":"https://api.github.com/repos/Vazkii/Botania/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vazkii/Botania/pulls/1748/commits"},"statuses":{"href":"https://api.github.com/repos/Vazkii/Botania/statuses/0595397943108aba4b387799d650c6a90aea8631"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"TheWhiteWolves","id":1471503,"avatar_url":"https://avatars.githubusercontent.com/u/1471503?v=3","gravatar_id":"","url":"https://api.github.com/users/TheWhiteWolves","html_url":"https://github.com/TheWhiteWolves","followers_url":"https://api.github.com/users/TheWhiteWolves/followers","following_url":"https://api.github.com/users/TheWhiteWolves/following{/other_user}","gists_url":"https://api.github.com/users/TheWhiteWolves/gists{/gist_id}","starred_url":"https://api.github.com/users/TheWhiteWolves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheWhiteWolves/subscriptions","organizations_url":"https://api.github.com/users/TheWhiteWolves/orgs","repos_url":"https://api.github.com/users/TheWhiteWolves/repos","events_url":"https://api.github.com/users/TheWhiteWolves/events{/privacy}","received_events_url":"https://api.github.com/users/TheWhiteWolves/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":3,"changed_files":1}}