{"action":"created","issue":{"url":"https://api.github.com/repos/hyperhq/hyperstart/issues/226","repository_url":"https://api.github.com/repos/hyperhq/hyperstart","labels_url":"https://api.github.com/repos/hyperhq/hyperstart/issues/226/labels{/name}","comments_url":"https://api.github.com/repos/hyperhq/hyperstart/issues/226/comments","events_url":"https://api.github.com/repos/hyperhq/hyperstart/issues/226/events","html_url":"https://github.com/hyperhq/hyperstart/pull/226","id":186616582,"number":226,"title":"Ack DESTROYPOD command","user":{"login":"sboeuf","id":22890413,"avatar_url":"https://avatars.githubusercontent.com/u/22890413?v=3","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-01T18:55:35Z","updated_at":"2016-11-04T02:23:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hyperhq/hyperstart/pulls/226","html_url":"https://github.com/hyperhq/hyperstart/pull/226","diff_url":"https://github.com/hyperhq/hyperstart/pull/226.diff","patch_url":"https://github.com/hyperhq/hyperstart/pull/226.patch"},"body":"In case hyperstart receives a DESTROYPOD command on the CTL\r\nchannel, it does not send anything back to the channel and\r\nreturn 0.\r\nBecause DESTROYPOD is a standard command, there is no reason\r\nnot to send an ACK after the DESTROYPOD is done."},"comment":{"url":"https://api.github.com/repos/hyperhq/hyperstart/issues/comments/258329127","html_url":"https://github.com/hyperhq/hyperstart/pull/226#issuecomment-258329127","issue_url":"https://api.github.com/repos/hyperhq/hyperstart/issues/226","id":258329127,"user":{"login":"gao-feng","id":1870497,"avatar_url":"https://avatars.githubusercontent.com/u/1870497?v=3","gravatar_id":"","url":"https://api.github.com/users/gao-feng","html_url":"https://github.com/gao-feng","followers_url":"https://api.github.com/users/gao-feng/followers","following_url":"https://api.github.com/users/gao-feng/following{/other_user}","gists_url":"https://api.github.com/users/gao-feng/gists{/gist_id}","starred_url":"https://api.github.com/users/gao-feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gao-feng/subscriptions","organizations_url":"https://api.github.com/users/gao-feng/orgs","repos_url":"https://api.github.com/users/gao-feng/repos","events_url":"https://api.github.com/users/gao-feng/events{/privacy}","received_events_url":"https://api.github.com/users/gao-feng/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T02:23:24Z","updated_at":"2016-11-04T02:23:24Z","body":"You should check out hyper_init_sigchld->hyper_handle_exit->hyper_handle_exec_exit->hyper_release_exec->hyper_pod_destroyed.\r\n\r\nterm_all only send out TERM/KILL signal, the ack is sent out in signal handler.\r\nIf you kill hyperstart/init, it has no chance to trigger signal handler and send out ack."}}
{"actor":{"display_login":"gao-feng"}}