{"push_id":1236516479,"size":44,"distinct_size":40,"ref":"refs/heads/master","head":"5a42f00e408075c4f9d01898e4ef437ee35be0ff","before":"b1467352c30b3b8b48d99e2b726acb6f428085c8","commits":[{"sha":"b9a5d00e15b76739978b7e321f12ab15a3b55d9e","author":{"name":"Khai Do","email":"0e3ddef4d3468acdba86db35821bb91d33893f2d@gmail.com"},"message":"Add an optional flag to force an online reindex\n\nAs discussed on Gerrit ML[1] and in referenced issue, there are\nsituations where you may want to run an online reindex besides\nthe upgrade gerrit use case.  This change allows users to force an\nonline reindex.\n\n[1] https://groups.google.com/d/msg/repo-discuss/pUn8fHVh58w/icsSFef2CAAJ\n\nfeature: issue 3987\nChange-Id: Ie88b7effda08996f7c0f325543be703bcf09c794","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/b9a5d00e15b76739978b7e321f12ab15a3b55d9e"},{"sha":"7f1a1b66fc422d6a07767d7bad9064aa3d476474","author":{"name":"David Pursehouse","email":"db50ae67856e12e3bc09af3c7dda2a3c617c138b@collab.net"},"message":"Attach sources for sshd-core and mina-core\n\nHaving sources helps with debugging.\n\nChange-Id: If57ded4f72cd4864b8834ed04e6758f603fd05d9","distinct":false,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/7f1a1b66fc422d6a07767d7bad9064aa3d476474"},{"sha":"b150ce534a7a9fda382fbea177e90b13b45b7ed7","author":{"name":"David Pursehouse","email":"db50ae67856e12e3bc09af3c7dda2a3c617c138b@collab.net"},"message":"SshDaemon: Set up the session timeout to make sshd.idleTimeout work\n\nSshServer#start() sets up the session timeout by calling:\n\n  setupSessionTimeout(sessionFactory);\n\nbut SshDaemon overrides the start() method, does not call super(), and\ndoes not call setupSessionTimeout.\n\nTherefore, no session timeout is set up on ssh sessions, and sessions\ncontinue to be kept open beyond the timeout specified in the configured\nsshd.idleTimeout.\n\nChange-Id: Ia72980d3f0f700386f62d301164f61f32405528e","distinct":false,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/b150ce534a7a9fda382fbea177e90b13b45b7ed7"},{"sha":"8219b1fac3aedb6a44ab07e131f9d432f9db4db0","author":{"name":"David Pursehouse","email":"db50ae67856e12e3bc09af3c7dda2a3c617c138b@collab.net"},"message":"Update 2.12.4 release notes\n\nChange-Id: Iaa184e05a44ffc661811572f15f3cc164f658fe6","distinct":false,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/8219b1fac3aedb6a44ab07e131f9d432f9db4db0"},{"sha":"22ade6cd6e615c2feea7bb0cf7e0832bcedc4976","author":{"name":"Edwin Kempin","email":"09dea6af173b9d87c3598437a9d65c7b6656a11e@google.com"},"message":"PutName: Remove special case for LDAP\n\nIf the realm doesn't allow editing the username, editing the username\nshould be forbidden.\n\nThe special case for LDAP didn't make sense as it was checking for an\nexternal ID in the gerrit scheme that had the username of the user as\nvalue, but usernames are stored in the username scheme.\n\nChange-Id: Id69a6cbfc9c6a6b0f1617ebc13bdff02b608c527\nSigned-off-by: Edwin Kempin <ekempin@google.com>","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/22ade6cd6e615c2feea7bb0cf7e0832bcedc4976"},{"sha":"c66120af5aa776bf1cb4168dc0675e7351bbd90b","author":{"name":"Hugo Arès","email":"421a26fbda5e04247c439e686e65c27ad9c00449@ericsson.com"},"message":"Merge \"Add an optional flag to force an online reindex\"","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/c66120af5aa776bf1cb4168dc0675e7351bbd90b"},{"sha":"271ee3fab2f6c20726b3feb1382d8c07b3fb19e0","author":{"name":"Björn Pedersen","email":"37fda7cecc224f34a5d382e2ada132108e561ff3@googlemail.com"},"message":"Set uploader for inline edit\n\nBug: Issue 4324\nChange-Id: I95c305046aca0e6635cd9f7348fd07ebcfc958a8","distinct":false,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/271ee3fab2f6c20726b3feb1382d8c07b3fb19e0"},{"sha":"ba22868bcf9c5802381d77f4f8a8e8f57049156f","author":{"name":"Dave Borowitz","email":"500d0e81487f8d69b15282cb27a6e4212bea252e@google.com"},"message":"Fix racy rebuilding when the winning writer fails\n\nConsider the following scenario:\n\n1. Thread 1 rebuilds in-memory to state A, and successfully updates\n   the state in ReviewDb to A.\n2. Thread 1 attempts the ref update but fails.\n3. Thread 2 rebuilds in-memory and gets A again, which throws\n   AbortUpdateException because the state in ReviewDb is already A.\n\nNow we are in a state where step (3) repeats indefinitely until there\nis a write to the change that triggers a NoteDbChangeState update in\nReviewDb. At that point it will skip the update of the NoteDb ref,\nsince it's out of date, but the *next* read will go back to step (1)\nand have another shot at rebuilding it.\n\nFix this by checking the actual state of the refs after an\nAbortUpdateException, and retrying the ref update if it doesn't match.\nThis has the slight downside that if N threads are trying to rebuild\nthe change at once, likely N-1 or N of them will still fail. However,\nthere's not much we can do in this case: there is no way to tell it to\nrebuild only if we think there isn't going to be contention on the\nref. Because we return the staged results and ignore errors coming from\nChangeRebuilder#execute, this shouldn't affect correctness, just\nperformance for the requests doing the rebuild.\n\nChange-Id: I6243f94d3e99535d1c1abbea0a1b3f075557d93a","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/ba22868bcf9c5802381d77f4f8a8e8f57049156f"},{"sha":"7d64e7841ed17423a8670c81c749eb46773e2508","author":{"name":"Ravi Mistry","email":"a9def7c7d0e905c58ea97dd479b910fb841a0498@google.com"},"message":"Add API event callback for 'revert'.\n\nThe API allows callbacks to modify the revertMessage displayed in the\nconfirmRevertDialog.\n\nBUG= https://bugs.chromium.org/p/chromium/issues/detail?id=624383\n\nChange-Id: I6d5aa061b20a26c09b79eef896bd27328b05d003","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/7d64e7841ed17423a8670c81c749eb46773e2508"},{"sha":"76b0e76d2fde52413cba43326ca8a5071d40c2c2","author":{"name":"Andrew Bonventre","email":"ca7f4cf29dd242d9eab97815aa578e9d00141a9b@chromium.org"},"message":"Merge \"Add API event callback for 'revert'.\"","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/76b0e76d2fde52413cba43326ca8a5071d40c2c2"},{"sha":"e5fcdf79109e05fd1d9c8d704b22eaa4ead4c632","author":{"name":"Stephen Li","email":"717529dfc1af3931ec8dc730e708beb640d6c41b@google.com"},"message":"Allow setting notification handling on abandon via API\n\nChange-Id: I099c9b094ac6b75248f44f665347506db15b2749","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/e5fcdf79109e05fd1d9c8d704b22eaa4ead4c632"},{"sha":"84ab583b8bb4904ea602ada89a0b6d48a50dec76","author":{"name":"Andrew Bonventre","email":"ca7f4cf29dd242d9eab97815aa578e9d00141a9b@chromium.org"},"message":"Don’t use relative path for loading hljs\n\nThis causes issues when the app is vulcanized and the paths are\ndifferent as a result. The async/defer attributes will ensure\nthe script does not block parsing of the page.\n\nAdds a flag to the Vulcanize rule that excludes HLJS. Confirmed that the\ntag is ignored by Vulcanize phase in the compiled WAR file. Confirmed\nthat the `onload` case functions as expected via browser throttling.\n\nChange-Id: Ie9603a5a07d4bae198ccc1ee56f408bfa0d37d49","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/84ab583b8bb4904ea602ada89a0b6d48a50dec76"},{"sha":"b34d1f87c7d7d98e7d46d41e635b33258b037b97","author":{"name":"Viktar Donich","email":"1fb01216c0d6d1210f2c418ef8a5aba3b91ffafe@google.com"},"message":"Show file weblinks (e.g. gitles) in diff view\n\nBug: Issue 4205\nChange-Id: Ib5c832bb29453aa51ebe73732c7b8e6885e7e12f","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/b34d1f87c7d7d98e7d46d41e635b33258b037b97"},{"sha":"a75fb05650c312f219908bc4aa3221dfea372be3","author":{"name":"Logan Hanks","email":"a9b5416e5fa932332dd598a83b9e837c630e371c@google.com"},"message":"Separate CCs from reviewers when NoteDb is enabled\n\nWhen the server config reports `note_db_enabled` is true, we have the\nopportunity to display reviewers by state. There are just two states\nwe care about: `REVIEWER` and `CC`. Reviewers in the `REVIEWER` state\nwill continue to be managed in the existing \"Reviewers\" fields in\n<gr-change-metadata> and <gr-reply-dialog>. We need similar but separate\n\"CC\" fields in the same elements for managing reviewers in the `CC`\nstate.\n\nBecause the reply dialog may now have two editable account lists, the\nlogic for tracking reviewer state and filtering autocomplete suggestions\nneeds to move to <gr-reply-dialog>. In particular, we don't want pending\nadditions in one field to show up as suggestions in the other field. We\nalso need to make sure that the large group confirmation overlay can\nhandle confirmations for either field, and return focus to the right\nelement when closed.\n\nFeature: Issue 3810\nChange-Id: Id5111220906ad728707087f6fb2ddb085c34a9b8","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/a75fb05650c312f219908bc4aa3221dfea372be3"},{"sha":"9cb649a265b36971cfc5acef6f60c215453859fc","author":{"name":"Andrew Bonventre","email":"ca7f4cf29dd242d9eab97815aa578e9d00141a9b@chromium.org"},"message":"Merge \"Separate CCs from reviewers when NoteDb is enabled\"","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/9cb649a265b36971cfc5acef6f60c215453859fc"},{"sha":"2b2c3dd55a748921c2ff074567797cc31be57eaa","author":{"name":"David Pursehouse","email":"db50ae67856e12e3bc09af3c7dda2a3c617c138b@collab.net"},"message":"Merge branch 'stable-2.12'\n\n* stable-2.12:\n  Set uploader for inline edit\n  Update 2.12.4 release notes\n  SshDaemon: Set up the session timeout to make sshd.idleTimeout work\n  Attach sources for sshd-core and mina-core\n\nChange-Id: I651e8901f96646660790a7ef6a14275f6d94343c","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/2b2c3dd55a748921c2ff074567797cc31be57eaa"},{"sha":"cfb51c2caca69b2d8d34364a93ce3e7d68969185","author":{"name":"David Pursehouse","email":"db50ae67856e12e3bc09af3c7dda2a3c617c138b@collab.net"},"message":"Upgrade JGit to 4.4.1.201607150455-r.74-gd6fe52e\n\nThis snapshot includes the following improvements related to LFS:\n\n- Include error message in response body\n- Pass request and path to getLargeFileRepository\n- Return HTTP 422 instead of 400\n\nand the following other changes that are needed in Gerrit:\n\n- RefSpec: allow construction of weird wildcarded RefSpecs\n- RefSpec: reject refs ending in '/'\n- BatchRefUpdate: Include command message in toString()\n- DiffFormatter: Support setting a reader without a repo\n\nChange-Id: I42eb72603c47e05cf39079164653defa96cf37c4","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/cfb51c2caca69b2d8d34364a93ce3e7d68969185"},{"sha":"3d6717840b663272429875d50550238302a7b85a","author":{"name":"Edwin Kempin","email":"09dea6af173b9d87c3598437a9d65c7b6656a11e@google.com"},"message":"Merge \"Allow setting notification handling on abandon via API\"","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/3d6717840b663272429875d50550238302a7b85a"},{"sha":"a407a3fb5b47c59d84391ac097172284aa271a06","author":{"name":"David Pursehouse","email":"db50ae67856e12e3bc09af3c7dda2a3c617c138b@collab.net"},"message":"ShowConnections: Only show start and idle columns for mina backend\n\nThe nio2 backend does not provide these data, so displaying dummy\nvalues can confuse users.\n\nModify the command to only show those columns when the backend is\nmina, which does support them.\n\nChange-Id: I889339a4811e38c1b02211983bde6b6e017cd600","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/a407a3fb5b47c59d84391ac097172284aa271a06"},{"sha":"4eca3ee3f1911656ca54dfe2c54490d8fa222857","author":{"name":"Edwin Kempin","email":"09dea6af173b9d87c3598437a9d65c7b6656a11e@google.com"},"message":"Merge \"Merge branch 'stable-2.12'\"","distinct":true,"url":"https://api.github.com/repos/gerrit-review/gerrit/commits/4eca3ee3f1911656ca54dfe2c54490d8fa222857"}]}
{"actor":{"display_login":"uwolfer"}}