{"action":"created","issue":{"url":"https://api.github.com/repos/google/oauth2client/issues/429","repository_url":"https://api.github.com/repos/google/oauth2client","labels_url":"https://api.github.com/repos/google/oauth2client/issues/429/labels{/name}","comments_url":"https://api.github.com/repos/google/oauth2client/issues/429/comments","events_url":"https://api.github.com/repos/google/oauth2client/issues/429/events","html_url":"https://github.com/google/oauth2client/pull/429","id":135107580,"number":429,"title":"Moving util.dict_to_tuple_key() into only module that uses it.","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/oauth2client/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars.githubusercontent.com/u/10131044?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-02-20T18:18:51Z","updated_at":"2016-02-20T18:37:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/oauth2client/pulls/429","html_url":"https://github.com/google/oauth2client/pull/429","diff_url":"https://github.com/google/oauth2client/pull/429.diff","patch_url":"https://github.com/google/oauth2client/pull/429.patch"},"body":"When I filed #428 I compared the modules to see what was superfluous and noticed that this method only had one user. This change may not be \"allowed\" since it removes a public interface."},"comment":{"url":"https://api.github.com/repos/google/oauth2client/issues/comments/186664454","html_url":"https://github.com/google/oauth2client/pull/429#issuecomment-186664454","issue_url":"https://api.github.com/repos/google/oauth2client/issues/429","id":186664454,"user":{"login":"nathanielmanistaatgoogle","id":10131044,"avatar_url":"https://avatars.githubusercontent.com/u/10131044?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanielmanistaatgoogle","html_url":"https://github.com/nathanielmanistaatgoogle","followers_url":"https://api.github.com/users/nathanielmanistaatgoogle/followers","following_url":"https://api.github.com/users/nathanielmanistaatgoogle/following{/other_user}","gists_url":"https://api.github.com/users/nathanielmanistaatgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanielmanistaatgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanielmanistaatgoogle/subscriptions","organizations_url":"https://api.github.com/users/nathanielmanistaatgoogle/orgs","repos_url":"https://api.github.com/users/nathanielmanistaatgoogle/repos","events_url":"https://api.github.com/users/nathanielmanistaatgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/nathanielmanistaatgoogle/received_events","type":"User","site_admin":false},"created_at":"2016-02-20T18:37:27Z","updated_at":"2016-02-20T18:37:27Z","body":"I endorse this change, despite it technically regressing the public interface of the library. The code element being withdrawn has nothing to do with authentication or cryptography or security or anything else that is part of the intended surface area of the library.\r\n\r\nI was actually just the other day defending another library's many many underscores and highly restricted public interface and I think this a good example of what I was describing in that conversation about how too often things are accidentally public because underscores are cosmetically unattractive and library authors are slow to adopt a habit of \"everything hidden by default when first written and then public only after thoughtful consideration that it needs to be public to serve the library's users\". :-)"}}