{"action":"created","issue":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/1629","labels_url":"https://api.github.com/repos/sakaiproject/sakai/issues/1629/labels{/name}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/1629/comments","events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/1629/events","html_url":"https://github.com/sakaiproject/sakai/pull/1629","id":129151110,"number":1629,"title":"Bug/1420 keep highest etc settings not applied in category score","user":{"login":"steveswinsburg","id":129129,"avatar_url":"https://avatars.githubusercontent.com/u/129129?v=3","gravatar_id":"","url":"https://api.github.com/users/steveswinsburg","html_url":"https://github.com/steveswinsburg","followers_url":"https://api.github.com/users/steveswinsburg/followers","following_url":"https://api.github.com/users/steveswinsburg/following{/other_user}","gists_url":"https://api.github.com/users/steveswinsburg/gists{/gist_id}","starred_url":"https://api.github.com/users/steveswinsburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveswinsburg/subscriptions","organizations_url":"https://api.github.com/users/steveswinsburg/orgs","repos_url":"https://api.github.com/users/steveswinsburg/repos","events_url":"https://api.github.com/users/steveswinsburg/events{/privacy}","received_events_url":"https://api.github.com/users/steveswinsburg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sakaiproject/sakai/labels/GradebookNG","name":"GradebookNG","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"payten","id":608337,"avatar_url":"https://avatars.githubusercontent.com/u/608337?v=3","gravatar_id":"","url":"https://api.github.com/users/payten","html_url":"https://github.com/payten","followers_url":"https://api.github.com/users/payten/followers","following_url":"https://api.github.com/users/payten/following{/other_user}","gists_url":"https://api.github.com/users/payten/gists{/gist_id}","starred_url":"https://api.github.com/users/payten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payten/subscriptions","organizations_url":"https://api.github.com/users/payten/orgs","repos_url":"https://api.github.com/users/payten/repos","events_url":"https://api.github.com/users/payten/events{/privacy}","received_events_url":"https://api.github.com/users/payten/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-01-27T13:57:55Z","updated_at":"2016-01-27T23:57:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/1629","html_url":"https://github.com/sakaiproject/sakai/pull/1629","diff_url":"https://github.com/sakaiproject/sakai/pull/1629.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/1629.patch"},"body":"Refactor the calculateCategoryScore methods and pass the data through `applyDropScores` to ensure the category subtotal respects the settings, for both batch and incremental category score lookups.\r\n\r\nDid some performance testing and noticed that a getGradebook lookup takes about 10ms which adds up when you have a large number of students, so ensured that we pass in the Gradebook object where possible, to avoid redundant lookups.\r\n\r\nDelivers #1420"},"comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments/175916525","html_url":"https://github.com/sakaiproject/sakai/pull/1629#issuecomment-175916525","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/1629","id":175916525,"user":{"login":"payten","id":608337,"avatar_url":"https://avatars.githubusercontent.com/u/608337?v=3","gravatar_id":"","url":"https://api.github.com/users/payten","html_url":"https://github.com/payten","followers_url":"https://api.github.com/users/payten/followers","following_url":"https://api.github.com/users/payten/following{/other_user}","gists_url":"https://api.github.com/users/payten/gists{/gist_id}","starred_url":"https://api.github.com/users/payten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payten/subscriptions","organizations_url":"https://api.github.com/users/payten/orgs","repos_url":"https://api.github.com/users/payten/repos","events_url":"https://api.github.com/users/payten/events{/privacy}","received_events_url":"https://api.github.com/users/payten/received_events","type":"User","site_admin":false},"created_at":"2016-01-27T23:57:55Z","updated_at":"2016-01-27T23:57:55Z","body":"I'm seeing some indentation anomalies.  Happy to ignore, just thought I'd mention it!  Also, are we squashing commits now?  I got a poke to do that to one of my PRs.  Otherwise looks good."}}