{"action":"created","comment":{"url":"https://api.github.com/repos/apache/reef/pulls/comments/50115445","id":50115445,"diff_hunk":"@@ -0,0 +1,51 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.apache.reef.vortex.driver;\n+\n+import org.apache.reef.annotations.Unstable;\n+import org.apache.reef.annotations.audience.Private;\n+import org.apache.reef.vortex.api.VortexAggregateFunction;\n+\n+import javax.annotation.concurrent.ThreadSafe;\n+import javax.inject.Inject;\n+import java.util.Map;\n+import java.util.concurrent.ConcurrentHashMap;\n+\n+/**\n+ * A repository for {@link VortexAggregateFunction}, used to pass functions between {@link VortexMaster} and\n+ * {@link RunningWorkers}.\n+ */\n+@ThreadSafe\n+@Unstable\n+@Private\n+public final class AggregateFunctionRepository {\n+  private final Map<Integer, VortexAggregateFunction> aggregateFunctionIdMap = new ConcurrentHashMap<>();","path":"lang/java/reef-applications/reef-vortex/src/main/java/org/apache/reef/vortex/driver/AggregateFunctionRepository.java","position":38,"original_position":38,"commit_id":"1058ece08904a83e09a6999b61ca47d599d8ca5c","original_commit_id":"1058ece08904a83e09a6999b61ca47d599d8ca5c","user":{"login":"yunseong","id":1748276,"avatar_url":"https://avatars.githubusercontent.com/u/1748276?v=3","gravatar_id":"","url":"https://api.github.com/users/yunseong","html_url":"https://github.com/yunseong","followers_url":"https://api.github.com/users/yunseong/followers","following_url":"https://api.github.com/users/yunseong/following{/other_user}","gists_url":"https://api.github.com/users/yunseong/gists{/gist_id}","starred_url":"https://api.github.com/users/yunseong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunseong/subscriptions","organizations_url":"https://api.github.com/users/yunseong/orgs","repos_url":"https://api.github.com/users/yunseong/repos","events_url":"https://api.github.com/users/yunseong/events{/privacy}","received_events_url":"https://api.github.com/users/yunseong/received_events","type":"User","site_admin":false},"body":"`Map` -> `ConcurrentMap`","created_at":"2016-01-19T14:11:20Z","updated_at":"2016-01-19T14:11:20Z","html_url":"https://github.com/apache/reef/pull/777#discussion_r50115445","pull_request_url":"https://api.github.com/repos/apache/reef/pulls/777","_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/comments/50115445"},"html":{"href":"https://github.com/apache/reef/pull/777#discussion_r50115445"},"pull_request":{"href":"https://api.github.com/repos/apache/reef/pulls/777"}}},"pull_request":{"url":"https://api.github.com/repos/apache/reef/pulls/777","id":56431255,"html_url":"https://github.com/apache/reef/pull/777","diff_url":"https://github.com/apache/reef/pull/777.diff","patch_url":"https://github.com/apache/reef/pull/777.patch","issue_url":"https://api.github.com/repos/apache/reef/issues/777","number":777,"state":"open","locked":false,"title":"[REEF-1129] Driver side VortexAggregate submission","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"body":"This addressed the issue by\r\n  * Modified ThreadPool, VortexMaster, and RunningWorkers to support submission of aggregate-able VortexFunctions.\r\n  * Added AggregateFunctionRepository to share aggregate functions between VortexMaster and RunningWorkers.\r\n  * Modified tests.\r\n  * Add TODO for REEF-1130 in passing VortexAggregateFunctions to Worker processes.\r\n\r\nJIRA:\r\n  [REEF-1129](https://issues.apache.org/jira/browse/REEF-1129)","created_at":"2016-01-19T07:40:16Z","updated_at":"2016-01-19T14:11:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ae107221f3ec67ccc7642f0cb460f337e3cb4b1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/reef/pulls/777/commits","review_comments_url":"https://api.github.com/repos/apache/reef/pulls/777/comments","review_comment_url":"https://api.github.com/repos/apache/reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/reef/issues/777/comments","statuses_url":"https://api.github.com/repos/apache/reef/statuses/1058ece08904a83e09a6999b61ca47d599d8ca5c","head":{"label":"afchung:REEF-1129","ref":"REEF-1129","sha":"1058ece08904a83e09a6999b61ca47d599d8ca5c","user":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"repo":{"id":31485914,"name":"reef","full_name":"afchung/reef","owner":{"login":"afchung","id":2817619,"avatar_url":"https://avatars.githubusercontent.com/u/2817619?v=3","gravatar_id":"","url":"https://api.github.com/users/afchung","html_url":"https://github.com/afchung","followers_url":"https://api.github.com/users/afchung/followers","following_url":"https://api.github.com/users/afchung/following{/other_user}","gists_url":"https://api.github.com/users/afchung/gists{/gist_id}","starred_url":"https://api.github.com/users/afchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afchung/subscriptions","organizations_url":"https://api.github.com/users/afchung/orgs","repos_url":"https://api.github.com/users/afchung/repos","events_url":"https://api.github.com/users/afchung/events{/privacy}","received_events_url":"https://api.github.com/users/afchung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/afchung/reef","description":"Mirror of Apache REEF","fork":true,"url":"https://api.github.com/repos/afchung/reef","forks_url":"https://api.github.com/repos/afchung/reef/forks","keys_url":"https://api.github.com/repos/afchung/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afchung/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afchung/reef/teams","hooks_url":"https://api.github.com/repos/afchung/reef/hooks","issue_events_url":"https://api.github.com/repos/afchung/reef/issues/events{/number}","events_url":"https://api.github.com/repos/afchung/reef/events","assignees_url":"https://api.github.com/repos/afchung/reef/assignees{/user}","branches_url":"https://api.github.com/repos/afchung/reef/branches{/branch}","tags_url":"https://api.github.com/repos/afchung/reef/tags","blobs_url":"https://api.github.com/repos/afchung/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afchung/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afchung/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/afchung/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afchung/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/afchung/reef/languages","stargazers_url":"https://api.github.com/repos/afchung/reef/stargazers","contributors_url":"https://api.github.com/repos/afchung/reef/contributors","subscribers_url":"https://api.github.com/repos/afchung/reef/subscribers","subscription_url":"https://api.github.com/repos/afchung/reef/subscription","commits_url":"https://api.github.com/repos/afchung/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/afchung/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/afchung/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/afchung/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/afchung/reef/contents/{+path}","compare_url":"https://api.github.com/repos/afchung/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afchung/reef/merges","archive_url":"https://api.github.com/repos/afchung/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afchung/reef/downloads","issues_url":"https://api.github.com/repos/afchung/reef/issues{/number}","pulls_url":"https://api.github.com/repos/afchung/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/afchung/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/afchung/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afchung/reef/labels{/name}","releases_url":"https://api.github.com/repos/afchung/reef/releases{/id}","created_at":"2015-03-01T03:44:31Z","updated_at":"2016-01-13T15:51:07Z","pushed_at":"2016-01-19T07:39:35Z","git_url":"git://github.com/afchung/reef.git","ssh_url":"git@github.com:afchung/reef.git","clone_url":"https://github.com/afchung/reef.git","svn_url":"https://github.com/afchung/reef","homepage":"","size":33567,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7ec6de9c229042e70a3908954db01b93b1c82c99","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"reef","full_name":"apache/reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/reef","description":"Mirror of Apache REEF","fork":false,"url":"https://api.github.com/repos/apache/reef","forks_url":"https://api.github.com/repos/apache/reef/forks","keys_url":"https://api.github.com/repos/apache/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/reef/teams","hooks_url":"https://api.github.com/repos/apache/reef/hooks","issue_events_url":"https://api.github.com/repos/apache/reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/reef/events","assignees_url":"https://api.github.com/repos/apache/reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/reef/tags","blobs_url":"https://api.github.com/repos/apache/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/reef/languages","stargazers_url":"https://api.github.com/repos/apache/reef/stargazers","contributors_url":"https://api.github.com/repos/apache/reef/contributors","subscribers_url":"https://api.github.com/repos/apache/reef/subscribers","subscription_url":"https://api.github.com/repos/apache/reef/subscription","commits_url":"https://api.github.com/repos/apache/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/reef/merges","archive_url":"https://api.github.com/repos/apache/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/reef/downloads","issues_url":"https://api.github.com/repos/apache/reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2016-01-12T01:08:39Z","pushed_at":"2016-01-19T07:40:16Z","git_url":"git://github.com/apache/reef.git","ssh_url":"git@github.com:apache/reef.git","clone_url":"https://github.com/apache/reef.git","svn_url":"https://github.com/apache/reef","homepage":"","size":46123,"stargazers_count":39,"watchers_count":39,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":"git://git.apache.org/reef.git","open_issues_count":10,"forks":46,"open_issues":10,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/777"},"html":{"href":"https://github.com/apache/reef/pull/777"},"issue":{"href":"https://api.github.com/repos/apache/reef/issues/777"},"comments":{"href":"https://api.github.com/repos/apache/reef/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/reef/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/reef/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/apache/reef/statuses/1058ece08904a83e09a6999b61ca47d599d8ca5c"}}}}