{"action":"created","issue":{"url":"https://api.github.com/repos/dataprotocols/dataprotocols/issues/246","repository_url":"https://api.github.com/repos/dataprotocols/dataprotocols","labels_url":"https://api.github.com/repos/dataprotocols/dataprotocols/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/dataprotocols/dataprotocols/issues/246/comments","events_url":"https://api.github.com/repos/dataprotocols/dataprotocols/issues/246/events","html_url":"https://github.com/dataprotocols/dataprotocols/issues/246","id":138570760,"number":246,"title":"Add option to specify the decimal separator character for `number` types in JTS","user":{"login":"akariv","id":265333,"avatar_url":"https://avatars.githubusercontent.com/u/265333?v=3","gravatar_id":"","url":"https://api.github.com/users/akariv","html_url":"https://github.com/akariv","followers_url":"https://api.github.com/users/akariv/followers","following_url":"https://api.github.com/users/akariv/following{/other_user}","gists_url":"https://api.github.com/users/akariv/gists{/gist_id}","starred_url":"https://api.github.com/users/akariv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akariv/subscriptions","organizations_url":"https://api.github.com/users/akariv/orgs","repos_url":"https://api.github.com/users/akariv/repos","events_url":"https://api.github.com/users/akariv/events{/privacy}","received_events_url":"https://api.github.com/users/akariv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dataprotocols/dataprotocols/labels/Ready%20for%20PR","name":"Ready for PR","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-04T19:56:35Z","updated_at":"2016-04-24T15:17:30Z","closed_at":"2016-04-18T21:03:07Z","body":"Both `,` and `.` are commonly used throughout the world (reference: https://en.wikipedia.org/wiki/Decimal_mark#/media/File:DecimalSeparator.svg), and not specifying which decimal separator is used creates ambiguity (e.g. '1,500' can mean \"one and a half\" or \"fifteen hundred\").\r\n\r\nWe should be able to add to the format definition an indication for which decimal separator is used. I can see two options for that:\r\n- Create a new attribute (`decimalSeparator`) which will only be used in case `type` is `number`. Its value would be the decimal separator character. In case it's missing, number interpretation will be defined to be implementation dependent.\r\n- Create new formats in addition to `default` and `currency`: `default-comma-decimal-separator` and `currency-comma-decimal-separator` (we might consider shorter names). This removes the need for introducing a new attribute, and also doesn't face the backward compatibility issues of the first option.\r\n\r\n@rgrp "},"comment":{"url":"https://api.github.com/repos/dataprotocols/dataprotocols/issues/comments/213982261","html_url":"https://github.com/dataprotocols/dataprotocols/issues/246#issuecomment-213982261","issue_url":"https://api.github.com/repos/dataprotocols/dataprotocols/issues/246","id":213982261,"user":{"login":"akariv","id":265333,"avatar_url":"https://avatars.githubusercontent.com/u/265333?v=3","gravatar_id":"","url":"https://api.github.com/users/akariv","html_url":"https://github.com/akariv","followers_url":"https://api.github.com/users/akariv/followers","following_url":"https://api.github.com/users/akariv/following{/other_user}","gists_url":"https://api.github.com/users/akariv/gists{/gist_id}","starred_url":"https://api.github.com/users/akariv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akariv/subscriptions","organizations_url":"https://api.github.com/users/akariv/orgs","repos_url":"https://api.github.com/users/akariv/repos","events_url":"https://api.github.com/users/akariv/events{/privacy}","received_events_url":"https://api.github.com/users/akariv/received_events","type":"User","site_admin":false},"created_at":"2016-04-24T15:17:30Z","updated_at":"2016-04-24T15:17:30Z","body":"@rgrp one comment - it's not clear right now from the wording what exactly should `currency` be - a boolean? a string?\r\nIn case we opt to leave this property and not remove it as #258 suggests, we should have a better definition for its value."}}