{"action":"created","comment":{"url":"https://api.github.com/repos/docker/notary/pulls/comments/60806518","id":60806518,"diff_hunk":"@@ -666,11 +551,10 @@ func TestValidateSuccessfulRootRotation(t *testing.T) {\n \t}\n }\n \n-// Generates a X509Store in a temporary directory and returns the\n-// store and certificates for two keys which have been added to the keystore.\n+// Generates certificates for two keys which have been added to the keystore.\n // Also returns the temporary directory so it can be cleaned up.\n-func filestoreWithTwoCerts(t *testing.T, gun, keyAlg string) (\n-\tstring, trustmanager.X509Store, *cryptoservice.CryptoService, []*x509.Certificate) {\n+func generateTwoCerts(t *testing.T, gun, keyAlg string) (","path":"trustpinning/certs_test.go","position":426,"original_position":426,"commit_id":"c98f791058f36a299479489850b26b96dc8b249b","original_commit_id":"c98f791058f36a299479489850b26b96dc8b249b","user":{"login":"riyazdf","id":1865981,"avatar_url":"https://avatars.githubusercontent.com/u/1865981?v=3","gravatar_id":"","url":"https://api.github.com/users/riyazdf","html_url":"https://github.com/riyazdf","followers_url":"https://api.github.com/users/riyazdf/followers","following_url":"https://api.github.com/users/riyazdf/following{/other_user}","gists_url":"https://api.github.com/users/riyazdf/gists{/gist_id}","starred_url":"https://api.github.com/users/riyazdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyazdf/subscriptions","organizations_url":"https://api.github.com/users/riyazdf/orgs","repos_url":"https://api.github.com/users/riyazdf/repos","events_url":"https://api.github.com/users/riyazdf/events{/privacy}","received_events_url":"https://api.github.com/users/riyazdf/received_events","type":"User","site_admin":false},"body":"you're right, more red! \\o/","created_at":"2016-04-22T21:37:05Z","updated_at":"2016-04-22T21:37:05Z","html_url":"https://github.com/docker/notary/pull/693#discussion_r60806518","pull_request_url":"https://api.github.com/repos/docker/notary/pulls/693","_links":{"self":{"href":"https://api.github.com/repos/docker/notary/pulls/comments/60806518"},"html":{"href":"https://github.com/docker/notary/pull/693#discussion_r60806518"},"pull_request":{"href":"https://api.github.com/repos/docker/notary/pulls/693"}}},"pull_request":{"url":"https://api.github.com/repos/docker/notary/pulls/693","id":67552898,"html_url":"https://github.com/docker/notary/pull/693","diff_url":"https://github.com/docker/notary/pull/693.diff","patch_url":"https://github.com/docker/notary/pull/693.patch","issue_url":"https://api.github.com/repos/docker/notary/issues/693","number":693,"state":"open","locked":false,"title":"Remove certstore","user":{"login":"riyazdf","id":1865981,"avatar_url":"https://avatars.githubusercontent.com/u/1865981?v=3","gravatar_id":"","url":"https://api.github.com/users/riyazdf","html_url":"https://github.com/riyazdf","followers_url":"https://api.github.com/users/riyazdf/followers","following_url":"https://api.github.com/users/riyazdf/following{/other_user}","gists_url":"https://api.github.com/users/riyazdf/gists{/gist_id}","starred_url":"https://api.github.com/users/riyazdf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyazdf/subscriptions","organizations_url":"https://api.github.com/users/riyazdf/orgs","repos_url":"https://api.github.com/users/riyazdf/repos","events_url":"https://api.github.com/users/riyazdf/events{/privacy}","received_events_url":"https://api.github.com/users/riyazdf/received_events","type":"User","site_admin":false},"body":"Use the previous root on disk to directly validate new roots on update, parsing out its own certificates in from the root metadata's `Keys` section instead of consulting a certificate store.\r\n\r\nAs a consequence, the certificate store in the notary repository (also in `trustmanager` x509 utils) and `notary cert` are no more :wave:","created_at":"2016-04-22T18:25:12Z","updated_at":"2016-04-22T21:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50a50f48ba04b12dc7e49cc179d2fb8e047ce05d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/notary/pulls/693/commits","review_comments_url":"https://api.github.com/repos/docker/notary/pulls/693/comments","review_comment_url":"https://api.github.com/repos/docker/notary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/notary/issues/693/comments","statuses_url":"https://api.github.com/repos/docker/notary/statuses/c98f791058f36a299479489850b26b96dc8b249b","head":{"label":"docker:remove-certstore","ref":"remove-certstore","sha":"c98f791058f36a299479489850b26b96dc8b249b","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":37743436,"name":"notary","full_name":"docker/notary","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/notary","description":"Notary is a Docker project that allows anyone to have trust over arbitrary collections of data","fork":false,"url":"https://api.github.com/repos/docker/notary","forks_url":"https://api.github.com/repos/docker/notary/forks","keys_url":"https://api.github.com/repos/docker/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/notary/teams","hooks_url":"https://api.github.com/repos/docker/notary/hooks","issue_events_url":"https://api.github.com/repos/docker/notary/issues/events{/number}","events_url":"https://api.github.com/repos/docker/notary/events","assignees_url":"https://api.github.com/repos/docker/notary/assignees{/user}","branches_url":"https://api.github.com/repos/docker/notary/branches{/branch}","tags_url":"https://api.github.com/repos/docker/notary/tags","blobs_url":"https://api.github.com/repos/docker/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/notary/languages","stargazers_url":"https://api.github.com/repos/docker/notary/stargazers","contributors_url":"https://api.github.com/repos/docker/notary/contributors","subscribers_url":"https://api.github.com/repos/docker/notary/subscribers","subscription_url":"https://api.github.com/repos/docker/notary/subscription","commits_url":"https://api.github.com/repos/docker/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/notary/contents/{+path}","compare_url":"https://api.github.com/repos/docker/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/notary/merges","archive_url":"https://api.github.com/repos/docker/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/notary/downloads","issues_url":"https://api.github.com/repos/docker/notary/issues{/number}","pulls_url":"https://api.github.com/repos/docker/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/notary/labels{/name}","releases_url":"https://api.github.com/repos/docker/notary/releases{/id}","deployments_url":"https://api.github.com/repos/docker/notary/deployments","created_at":"2015-06-19T20:07:53Z","updated_at":"2016-04-21T20:17:32Z","pushed_at":"2016-04-22T21:25:21Z","git_url":"git://github.com/docker/notary.git","ssh_url":"git@github.com:docker/notary.git","clone_url":"https://github.com/docker/notary.git","svn_url":"https://github.com/docker/notary","homepage":"https://docker.com","size":29761,"stargazers_count":613,"watchers_count":613,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":83,"forks":82,"open_issues":83,"watchers":613,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"b5a7b2adaa2e988a91d43c9ccdb2472f1017400f","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":37743436,"name":"notary","full_name":"docker/notary","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/notary","description":"Notary is a Docker project that allows anyone to have trust over arbitrary collections of data","fork":false,"url":"https://api.github.com/repos/docker/notary","forks_url":"https://api.github.com/repos/docker/notary/forks","keys_url":"https://api.github.com/repos/docker/notary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/notary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/notary/teams","hooks_url":"https://api.github.com/repos/docker/notary/hooks","issue_events_url":"https://api.github.com/repos/docker/notary/issues/events{/number}","events_url":"https://api.github.com/repos/docker/notary/events","assignees_url":"https://api.github.com/repos/docker/notary/assignees{/user}","branches_url":"https://api.github.com/repos/docker/notary/branches{/branch}","tags_url":"https://api.github.com/repos/docker/notary/tags","blobs_url":"https://api.github.com/repos/docker/notary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/notary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/notary/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/notary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/notary/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/notary/languages","stargazers_url":"https://api.github.com/repos/docker/notary/stargazers","contributors_url":"https://api.github.com/repos/docker/notary/contributors","subscribers_url":"https://api.github.com/repos/docker/notary/subscribers","subscription_url":"https://api.github.com/repos/docker/notary/subscription","commits_url":"https://api.github.com/repos/docker/notary/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/notary/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/notary/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/notary/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/notary/contents/{+path}","compare_url":"https://api.github.com/repos/docker/notary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/notary/merges","archive_url":"https://api.github.com/repos/docker/notary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/notary/downloads","issues_url":"https://api.github.com/repos/docker/notary/issues{/number}","pulls_url":"https://api.github.com/repos/docker/notary/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/notary/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/notary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/notary/labels{/name}","releases_url":"https://api.github.com/repos/docker/notary/releases{/id}","deployments_url":"https://api.github.com/repos/docker/notary/deployments","created_at":"2015-06-19T20:07:53Z","updated_at":"2016-04-21T20:17:32Z","pushed_at":"2016-04-22T21:25:21Z","git_url":"git://github.com/docker/notary.git","ssh_url":"git@github.com:docker/notary.git","clone_url":"https://github.com/docker/notary.git","svn_url":"https://github.com/docker/notary","homepage":"https://docker.com","size":29761,"stargazers_count":613,"watchers_count":613,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":83,"forks":82,"open_issues":83,"watchers":613,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/notary/pulls/693"},"html":{"href":"https://github.com/docker/notary/pull/693"},"issue":{"href":"https://api.github.com/repos/docker/notary/issues/693"},"comments":{"href":"https://api.github.com/repos/docker/notary/issues/693/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/notary/pulls/693/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/notary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/notary/pulls/693/commits"},"statuses":{"href":"https://api.github.com/repos/docker/notary/statuses/c98f791058f36a299479489850b26b96dc8b249b"}}}}