{"action":"opened","number":1592,"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/1592","id":63972572,"html_url":"https://github.com/youtube/vitess/pull/1592","diff_url":"https://github.com/youtube/vitess/pull/1592.diff","patch_url":"https://github.com/youtube/vitess/pull/1592.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/1592","number":1592,"state":"open","locked":false,"title":"Doing most of my todos in splitquery","user":{"login":"erzel","id":14099708,"avatar_url":"https://avatars.githubusercontent.com/u/14099708?v=3","gravatar_id":"","url":"https://api.github.com/users/erzel","html_url":"https://github.com/erzel","followers_url":"https://api.github.com/users/erzel/followers","following_url":"https://api.github.com/users/erzel/following{/other_user}","gists_url":"https://api.github.com/users/erzel/gists{/gist_id}","starred_url":"https://api.github.com/users/erzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erzel/subscriptions","organizations_url":"https://api.github.com/users/erzel/orgs","repos_url":"https://api.github.com/users/erzel/repos","events_url":"https://api.github.com/users/erzel/events{/privacy}","received_events_url":"https://api.github.com/users/erzel/received_events","type":"User","site_admin":false},"body":"1. Added checks that for FULL_SCAN algorithm the split_columns are the primary key and must be the prefix of an index in general.\r\n2. Added creation of SplitParams with either SplitCount or NumRowsPerQueryPart and allowed computing one from the other.\r\n3. SplitColumns now default to primary key\r\n4. Replaced assertion-functions with \"if (!cond) { panic ... }\"\r\n@michael-berlin @dumbunny please take a look.","created_at":"2016-03-24T00:08:54Z","updated_at":"2016-03-24T00:08:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/1592/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/1592/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/1592/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/27e1e7e77679c1ab59dfd494b0db59a942b7c7ad","head":{"label":"erzel:finalizing_todos_in_splitquery","ref":"finalizing_todos_in_splitquery","sha":"27e1e7e77679c1ab59dfd494b0db59a942b7c7ad","user":{"login":"erzel","id":14099708,"avatar_url":"https://avatars.githubusercontent.com/u/14099708?v=3","gravatar_id":"","url":"https://api.github.com/users/erzel","html_url":"https://github.com/erzel","followers_url":"https://api.github.com/users/erzel/followers","following_url":"https://api.github.com/users/erzel/following{/other_user}","gists_url":"https://api.github.com/users/erzel/gists{/gist_id}","starred_url":"https://api.github.com/users/erzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erzel/subscriptions","organizations_url":"https://api.github.com/users/erzel/orgs","repos_url":"https://api.github.com/users/erzel/repos","events_url":"https://api.github.com/users/erzel/events{/privacy}","received_events_url":"https://api.github.com/users/erzel/received_events","type":"User","site_admin":false},"repo":{"id":41829214,"name":"vitess","full_name":"erzel/vitess","owner":{"login":"erzel","id":14099708,"avatar_url":"https://avatars.githubusercontent.com/u/14099708?v=3","gravatar_id":"","url":"https://api.github.com/users/erzel","html_url":"https://github.com/erzel","followers_url":"https://api.github.com/users/erzel/followers","following_url":"https://api.github.com/users/erzel/following{/other_user}","gists_url":"https://api.github.com/users/erzel/gists{/gist_id}","starred_url":"https://api.github.com/users/erzel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erzel/subscriptions","organizations_url":"https://api.github.com/users/erzel/orgs","repos_url":"https://api.github.com/users/erzel/repos","events_url":"https://api.github.com/users/erzel/events{/privacy}","received_events_url":"https://api.github.com/users/erzel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erzel/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":true,"url":"https://api.github.com/repos/erzel/vitess","forks_url":"https://api.github.com/repos/erzel/vitess/forks","keys_url":"https://api.github.com/repos/erzel/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erzel/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erzel/vitess/teams","hooks_url":"https://api.github.com/repos/erzel/vitess/hooks","issue_events_url":"https://api.github.com/repos/erzel/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/erzel/vitess/events","assignees_url":"https://api.github.com/repos/erzel/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/erzel/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/erzel/vitess/tags","blobs_url":"https://api.github.com/repos/erzel/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erzel/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erzel/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/erzel/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erzel/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/erzel/vitess/languages","stargazers_url":"https://api.github.com/repos/erzel/vitess/stargazers","contributors_url":"https://api.github.com/repos/erzel/vitess/contributors","subscribers_url":"https://api.github.com/repos/erzel/vitess/subscribers","subscription_url":"https://api.github.com/repos/erzel/vitess/subscription","commits_url":"https://api.github.com/repos/erzel/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/erzel/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/erzel/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/erzel/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/erzel/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/erzel/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erzel/vitess/merges","archive_url":"https://api.github.com/repos/erzel/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erzel/vitess/downloads","issues_url":"https://api.github.com/repos/erzel/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/erzel/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/erzel/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/erzel/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erzel/vitess/labels{/name}","releases_url":"https://api.github.com/repos/erzel/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/erzel/vitess/deployments","created_at":"2015-09-02T21:42:27Z","updated_at":"2016-02-09T23:24:02Z","pushed_at":"2016-03-24T00:03:23Z","git_url":"git://github.com/erzel/vitess.git","ssh_url":"git@github.com:erzel/vitess.git","clone_url":"https://github.com/erzel/vitess.git","svn_url":"https://github.com/erzel/vitess","homepage":null,"size":57365,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"268fcf98ff29ccf54cb6dbbfa4924be1b32a7525","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/youtube/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2016-03-23T17:19:33Z","pushed_at":"2016-03-23T21:06:16Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":62237,"stargazers_count":3334,"watchers_count":3334,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":419,"mirror_url":null,"open_issues_count":19,"forks":419,"open_issues":19,"watchers":3334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1592"},"html":{"href":"https://github.com/youtube/vitess/pull/1592"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/1592"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/1592/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1592/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1592/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/27e1e7e77679c1ab59dfd494b0db59a942b7c7ad"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":243,"deletions":92,"changed_files":11}}