{"action":"created","comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/75020765","id":75020765,"diff_hunk":"@@ -78,7 +73,7 @@ public void process() {\n      * be reversed, not eliminated, by re-enabling writing to the Depth Buffer.\n      */\n     private void preRenderSetupSimpleBlendMaterials() {\n-        frameBuffersManager.getFBO(SCENE_OPAQUE_FBO).setRenderBufferMask(true, true, true);\n+        dynamicFBM.getFBO(DefaultDynamicFBOs.ReadOnlyGBuffer.getResourceUrn()).setRenderBufferMask(true, true, true);","path":"engine/src/main/java/org/terasology/rendering/dag/nodes/SimpleBlendMaterialsNode.java","position":38,"original_position":42,"commit_id":"de5e7be8aba7269227d78b95ed7aacd20c0a5abd","original_commit_id":"614374d2ef5db5fa337ec60b556b45bc678a25a5","user":{"login":"tdgunes","id":136392,"avatar_url":"https://avatars.githubusercontent.com/u/136392?v=3","gravatar_id":"","url":"https://api.github.com/users/tdgunes","html_url":"https://github.com/tdgunes","followers_url":"https://api.github.com/users/tdgunes/followers","following_url":"https://api.github.com/users/tdgunes/following{/other_user}","gists_url":"https://api.github.com/users/tdgunes/gists{/gist_id}","starred_url":"https://api.github.com/users/tdgunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdgunes/subscriptions","organizations_url":"https://api.github.com/users/tdgunes/orgs","repos_url":"https://api.github.com/users/tdgunes/repos","events_url":"https://api.github.com/users/tdgunes/events{/privacy}","received_events_url":"https://api.github.com/users/tdgunes/received_events","type":"User","site_admin":false},"body":"or `ReadOnlyGBuffer.setRenderBufferMask(true, true, true);`?\r\n","created_at":"2016-08-16T21:10:00Z","updated_at":"2016-08-16T21:10:00Z","html_url":"https://github.com/MovingBlocks/Terasology/pull/2431#discussion_r75020765","pull_request_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431","_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/75020765"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2431#discussion_r75020765"},"pull_request":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431"}}},"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431","id":80144433,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2431","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2431.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2431.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2431","number":2431,"state":"open","locked":false,"title":"[RFR] Nodes use FBOConfig to add their desired FBOs to FBM","user":{"login":"tdgunes","id":136392,"avatar_url":"https://avatars.githubusercontent.com/u/136392?v=3","gravatar_id":"","url":"https://api.github.com/users/tdgunes","html_url":"https://github.com/tdgunes","followers_url":"https://api.github.com/users/tdgunes/followers","following_url":"https://api.github.com/users/tdgunes/following{/other_user}","gists_url":"https://api.github.com/users/tdgunes/gists{/gist_id}","starred_url":"https://api.github.com/users/tdgunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdgunes/subscriptions","organizations_url":"https://api.github.com/users/tdgunes/orgs","repos_url":"https://api.github.com/users/tdgunes/repos","events_url":"https://api.github.com/users/tdgunes/events{/privacy}","received_events_url":"https://api.github.com/users/tdgunes/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request for Terasology! :-)\r\nPlease fill in some brief details below about the PR.\r\nIf it contains source code please make sure to run Checkstyle on it first\r\nIf you add unit tests we'll love you forever! -->\r\n\r\n### Contains\r\n\r\nInitial but working PR for the issue: [Nodes generate and publish the FBOs they need, unless available already](https://github.com/tdgunes/Terasology/issues/7). All current-default nodes in this PR have `requireFBO` statements.  \r\n\r\n### How to test\r\n\r\nPlease check any weirdness on rendering in the PR. Sorry for not specifying any particular rendering operation since all nodes were modified. \r\n","created_at":"2016-08-04T20:30:11Z","updated_at":"2016-08-16T21:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"998aa0f7ea6ca72e5a17cd8763206d6c51ff783d","assignee":{"login":"msteiger","id":1820007,"avatar_url":"https://avatars.githubusercontent.com/u/1820007?v=3","gravatar_id":"","url":"https://api.github.com/users/msteiger","html_url":"https://github.com/msteiger","followers_url":"https://api.github.com/users/msteiger/followers","following_url":"https://api.github.com/users/msteiger/following{/other_user}","gists_url":"https://api.github.com/users/msteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/msteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msteiger/subscriptions","organizations_url":"https://api.github.com/users/msteiger/orgs","repos_url":"https://api.github.com/users/msteiger/repos","events_url":"https://api.github.com/users/msteiger/events{/privacy}","received_events_url":"https://api.github.com/users/msteiger/received_events","type":"User","site_admin":false},"assignees":[{"login":"msteiger","id":1820007,"avatar_url":"https://avatars.githubusercontent.com/u/1820007?v=3","gravatar_id":"","url":"https://api.github.com/users/msteiger","html_url":"https://github.com/msteiger","followers_url":"https://api.github.com/users/msteiger/followers","following_url":"https://api.github.com/users/msteiger/following{/other_user}","gists_url":"https://api.github.com/users/msteiger/gists{/gist_id}","starred_url":"https://api.github.com/users/msteiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msteiger/subscriptions","organizations_url":"https://api.github.com/users/msteiger/orgs","repos_url":"https://api.github.com/users/msteiger/repos","events_url":"https://api.github.com/users/msteiger/events{/privacy}","received_events_url":"https://api.github.com/users/msteiger/received_events","type":"User","site_admin":false},{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2431/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/de5e7be8aba7269227d78b95ed7aacd20c0a5abd","head":{"label":"tdgunes:dag-fbos","ref":"dag-fbos","sha":"de5e7be8aba7269227d78b95ed7aacd20c0a5abd","user":{"login":"tdgunes","id":136392,"avatar_url":"https://avatars.githubusercontent.com/u/136392?v=3","gravatar_id":"","url":"https://api.github.com/users/tdgunes","html_url":"https://github.com/tdgunes","followers_url":"https://api.github.com/users/tdgunes/followers","following_url":"https://api.github.com/users/tdgunes/following{/other_user}","gists_url":"https://api.github.com/users/tdgunes/gists{/gist_id}","starred_url":"https://api.github.com/users/tdgunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdgunes/subscriptions","organizations_url":"https://api.github.com/users/tdgunes/orgs","repos_url":"https://api.github.com/users/tdgunes/repos","events_url":"https://api.github.com/users/tdgunes/events{/privacy}","received_events_url":"https://api.github.com/users/tdgunes/received_events","type":"User","site_admin":false},"repo":{"id":55730673,"name":"Terasology","full_name":"tdgunes/Terasology","owner":{"login":"tdgunes","id":136392,"avatar_url":"https://avatars.githubusercontent.com/u/136392?v=3","gravatar_id":"","url":"https://api.github.com/users/tdgunes","html_url":"https://github.com/tdgunes","followers_url":"https://api.github.com/users/tdgunes/followers","following_url":"https://api.github.com/users/tdgunes/following{/other_user}","gists_url":"https://api.github.com/users/tdgunes/gists{/gist_id}","starred_url":"https://api.github.com/users/tdgunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdgunes/subscriptions","organizations_url":"https://api.github.com/users/tdgunes/orgs","repos_url":"https://api.github.com/users/tdgunes/repos","events_url":"https://api.github.com/users/tdgunes/events{/privacy}","received_events_url":"https://api.github.com/users/tdgunes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdgunes/Terasology","description":"Terasology - open source voxel world","fork":true,"url":"https://api.github.com/repos/tdgunes/Terasology","forks_url":"https://api.github.com/repos/tdgunes/Terasology/forks","keys_url":"https://api.github.com/repos/tdgunes/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdgunes/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdgunes/Terasology/teams","hooks_url":"https://api.github.com/repos/tdgunes/Terasology/hooks","issue_events_url":"https://api.github.com/repos/tdgunes/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/tdgunes/Terasology/events","assignees_url":"https://api.github.com/repos/tdgunes/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/tdgunes/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/tdgunes/Terasology/tags","blobs_url":"https://api.github.com/repos/tdgunes/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdgunes/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdgunes/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdgunes/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdgunes/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/tdgunes/Terasology/languages","stargazers_url":"https://api.github.com/repos/tdgunes/Terasology/stargazers","contributors_url":"https://api.github.com/repos/tdgunes/Terasology/contributors","subscribers_url":"https://api.github.com/repos/tdgunes/Terasology/subscribers","subscription_url":"https://api.github.com/repos/tdgunes/Terasology/subscription","commits_url":"https://api.github.com/repos/tdgunes/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdgunes/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdgunes/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdgunes/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdgunes/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/tdgunes/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdgunes/Terasology/merges","archive_url":"https://api.github.com/repos/tdgunes/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdgunes/Terasology/downloads","issues_url":"https://api.github.com/repos/tdgunes/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/tdgunes/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/tdgunes/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/tdgunes/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdgunes/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/tdgunes/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/tdgunes/Terasology/deployments","created_at":"2016-04-07T21:52:38Z","updated_at":"2016-06-30T22:35:05Z","pushed_at":"2016-08-16T04:11:36Z","git_url":"git://github.com/tdgunes/Terasology.git","ssh_url":"git@github.com:tdgunes/Terasology.git","clone_url":"https://github.com/tdgunes/Terasology.git","svn_url":"https://github.com/tdgunes/Terasology","homepage":"http://terasology.org","size":267940,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"7df19a958ea5f853733895785c10855fee2052d3","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2016-08-16T14:01:12Z","pushed_at":"2016-08-16T18:58:36Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":335664,"stargazers_count":1589,"watchers_count":1589,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":642,"mirror_url":null,"open_issues_count":324,"forks":642,"open_issues":324,"watchers":1589,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2431"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2431"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2431/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2431/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/de5e7be8aba7269227d78b95ed7aacd20c0a5abd"}}}}
{"actor":{"display_login":"tdgunes"}}