{"action":"created","issue":{"url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/47","repository_url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids","labels_url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/47/comments","events_url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/47/events","html_url":"https://github.com/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/47","id":124248401,"number":47,"title":"Cover problem dynamics and problem definition classes with tests ","user":{"login":"pgagarinov","id":4868370,"avatar_url":"https://avatars.githubusercontent.com/u/4868370?v=3","gravatar_id":"","url":"https://api.github.com/users/pgagarinov","html_url":"https://github.com/pgagarinov","followers_url":"https://api.github.com/users/pgagarinov/followers","following_url":"https://api.github.com/users/pgagarinov/following{/other_user}","gists_url":"https://api.github.com/users/pgagarinov/gists{/gist_id}","starred_url":"https://api.github.com/users/pgagarinov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgagarinov/subscriptions","organizations_url":"https://api.github.com/users/pgagarinov/orgs","repos_url":"https://api.github.com/users/pgagarinov/repos","events_url":"https://api.github.com/users/pgagarinov/events{/privacy}","received_events_url":"https://api.github.com/users/pgagarinov/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"arturlu","id":15003018,"avatar_url":"https://avatars.githubusercontent.com/u/15003018?v=3","gravatar_id":"","url":"https://api.github.com/users/arturlu","html_url":"https://github.com/arturlu","followers_url":"https://api.github.com/users/arturlu/followers","following_url":"https://api.github.com/users/arturlu/following{/other_user}","gists_url":"https://api.github.com/users/arturlu/gists{/gist_id}","starred_url":"https://api.github.com/users/arturlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturlu/subscriptions","organizations_url":"https://api.github.com/users/arturlu/orgs","repos_url":"https://api.github.com/users/arturlu/repos","events_url":"https://api.github.com/users/arturlu/events{/privacy}","received_events_url":"https://api.github.com/users/arturlu/received_events","type":"User","site_admin":false},"milestone":null,"comments":12,"created_at":"2015-12-29T18:11:09Z","updated_at":"2016-02-23T20:58:25Z","closed_at":null,"body":" Cover problem dynamics and problem definition classes from the following packages with tests \r\n\\products+gras+ellapx+lreachplain+probdef\r\n\\products+gras+ellapx+lreachplain+probdyn\r\n\\products+gras+ellapx+lreachuncert+probdef\r\n\\products+gras+ellapx+lreachuncert+probdyn\r\n\r\nthe test cases should be located in the following packages\r\n\r\n\\products+gras+ellapx+lreachplain+probdef+test+mlunit\r\n\\products+gras+ellapx+lreachplain+probdyn+test+mlunit\r\n\\products+gras+ellapx+lreachuncert+probdef+test+mlunit\r\n\\products+gras+ellapx+lreachuncert+probdyn+test+mlunit\r\n\r\nfunctions run_tests should be located in each +test subpackage.\r\nand their calls should be added to \\products+gras+ellapx+test\\run_tests function.\r\n\r\nFor the problem definition classes (in probdef packages) the tests should construct the problem definition objects on a few simple systems \r\nand verify that all methods return a correct result. Please note that there should be no copy-pasting in the tests - you should parameterize them \r\nwith tested calsses so that the same test case can be applied to different problem definition classes. This approach is very well demonstrated\r\nin elltool.reach.test.run_cont_tests - please use this function as a reference.\r\n\r\nFor problem dynamics classes the approach should be similar - create problem dynamics for a few simple systems and make sure that the values returned by \r\nits methods (by `getAtDynamics` method responsible for returning a matrix function for `A(t)`) match the expected result on a certain time grid. For `A(t)` it means that \r\nyou need to check that `A(t_i)` matches the expected result for all `t_i` from the time grid."},"comment":{"url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/comments/187901982","html_url":"https://github.com/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/47#issuecomment-187901982","issue_url":"https://api.github.com/repos/SystemAnalysisDpt-CMC-MSU/ellipsoids/issues/47","id":187901982,"user":{"login":"arturlu","id":15003018,"avatar_url":"https://avatars.githubusercontent.com/u/15003018?v=3","gravatar_id":"","url":"https://api.github.com/users/arturlu","html_url":"https://github.com/arturlu","followers_url":"https://api.github.com/users/arturlu/followers","following_url":"https://api.github.com/users/arturlu/following{/other_user}","gists_url":"https://api.github.com/users/arturlu/gists{/gist_id}","starred_url":"https://api.github.com/users/arturlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturlu/subscriptions","organizations_url":"https://api.github.com/users/arturlu/orgs","repos_url":"https://api.github.com/users/arturlu/repos","events_url":"https://api.github.com/users/arturlu/events{/privacy}","received_events_url":"https://api.github.com/users/arturlu/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T20:58:25Z","updated_at":"2016-02-23T20:58:25Z","body":"Ok. I rebased to master (by using ebb71ad028840d8c1d813818f353c577049711c4 commit) and merge.\r\n\r\nBut only the two errors into:\r\nelltool.reach.test.mlunit.ContinuousReachTestNTimeGridPoints[demo3thirdTest_IsBackTrueIsEvolveFalse]/testSetMatchesGetNTimeGridPoints\r\nelltool.reach.test.mlunit.ContinuousReachTestNTimeGridPoints[demo3thirdTest_IsBackTrueIsEvolveTrue]/testSetMatchesGetNTimeGridPoints \r\nremain."}}