{"action":"created","issue":{"url":"https://api.github.com/repos/iRail/hyperRail/issues/57","repository_url":"https://api.github.com/repos/iRail/hyperRail","labels_url":"https://api.github.com/repos/iRail/hyperRail/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/iRail/hyperRail/issues/57/comments","events_url":"https://api.github.com/repos/iRail/hyperRail/issues/57/events","html_url":"https://github.com/iRail/hyperRail/issues/57","id":39431348,"number":57,"title":"Rework departure URI","user":{"login":"pietercolpaert","id":347073,"avatar_url":"https://avatars.githubusercontent.com/u/347073?v=3","gravatar_id":"","url":"https://api.github.com/users/pietercolpaert","html_url":"https://github.com/pietercolpaert","followers_url":"https://api.github.com/users/pietercolpaert/followers","following_url":"https://api.github.com/users/pietercolpaert/following{/other_user}","gists_url":"https://api.github.com/users/pietercolpaert/gists{/gist_id}","starred_url":"https://api.github.com/users/pietercolpaert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietercolpaert/subscriptions","organizations_url":"https://api.github.com/users/pietercolpaert/orgs","repos_url":"https://api.github.com/users/pietercolpaert/repos","events_url":"https://api.github.com/users/pietercolpaert/events{/privacy}","received_events_url":"https://api.github.com/users/pietercolpaert/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2014-08-04T15:28:09Z","updated_at":"2016-07-21T20:39:24Z","closed_at":"2016-07-21T20:39:24Z","body":"The departure URI at this moment consists of:\r\n\r\n```php\r\n$departureURI = \"http://irail.be/stations/NMBS/008892007/departures/\" . date(\"YmdHi\") . md5sum(routeLabel . headsign ) . \"/\";\r\n```\r\n\r\nThe md5sum is particularly a problem as the headsign changes on the course of the train. For instance, on one interface the headsign can be \"Gent Oostende\" while in another interface, the headsign can become \"Gent\". Therefore we suggest changing the URI towards:\r\n\r\n```php\r\n$departureURI = \"http://irail.be/stations/NMBS/008892007/departures/\" . date(\"YmdHi\") . routeLabel . \"/\";\r\n```\r\nWhich will result in a clearer URI.\r\n\r\nSteps to be taken:\r\n * [x] inform everyone using the departure URI that this changed (thesis student)\r\n * [ ] Change it in hyperRail\r\n * [ ] Change it in the old API http://api.irail.be"},"comment":{"url":"https://api.github.com/repos/iRail/hyperRail/issues/comments/234376908","html_url":"https://github.com/iRail/hyperRail/issues/57#issuecomment-234376908","issue_url":"https://api.github.com/repos/iRail/hyperRail/issues/57","id":234376908,"user":{"login":"pietercolpaert","id":347073,"avatar_url":"https://avatars.githubusercontent.com/u/347073?v=3","gravatar_id":"","url":"https://api.github.com/users/pietercolpaert","html_url":"https://github.com/pietercolpaert","followers_url":"https://api.github.com/users/pietercolpaert/followers","following_url":"https://api.github.com/users/pietercolpaert/following{/other_user}","gists_url":"https://api.github.com/users/pietercolpaert/gists{/gist_id}","starred_url":"https://api.github.com/users/pietercolpaert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pietercolpaert/subscriptions","organizations_url":"https://api.github.com/users/pietercolpaert/orgs","repos_url":"https://api.github.com/users/pietercolpaert/repos","events_url":"https://api.github.com/users/pietercolpaert/events{/privacy}","received_events_url":"https://api.github.com/users/pietercolpaert/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T20:39:24Z","updated_at":"2016-07-21T20:39:24Z","body":"Won't fix: the departure URI will disappear in favor of a connection URI which is being rolled out."}}
{"actor":{"display_login":"pietercolpaert"}}