{"action":"opened","number":140,"pull_request":{"url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/140","id":72741851,"html_url":"https://github.com/F5Networks/f5-openstack-agent/pull/140","diff_url":"https://github.com/F5Networks/f5-openstack-agent/pull/140.diff","patch_url":"https://github.com/F5Networks/f5-openstack-agent/pull/140.patch","issue_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/140","number":140,"state":"open","locked":false,"title":"Refactor/cleanup selfips","user":{"login":"richbrowne","id":8740561,"avatar_url":"https://avatars.githubusercontent.com/u/8740561?v=3","gravatar_id":"","url":"https://api.github.com/users/richbrowne","html_url":"https://github.com/richbrowne","followers_url":"https://api.github.com/users/richbrowne/followers","following_url":"https://api.github.com/users/richbrowne/following{/other_user}","gists_url":"https://api.github.com/users/richbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/richbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richbrowne/subscriptions","organizations_url":"https://api.github.com/users/richbrowne/orgs","repos_url":"https://api.github.com/users/richbrowne/repos","events_url":"https://api.github.com/users/richbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/richbrowne/received_events","type":"User","site_admin":false},"body":"@jlongstaf \r\n#### What issues does this address?\r\nFixes #126\r\n\r\n#### What's this change do?\r\nReorganizes some error handling in the selfip code to allow errors to be logged and handled at top layers of the code.  There are some bug fixes to selfip.\r\n\r\n#### Where should the reviewer start?\r\nselfip.py\r\n\r\n#### Any background context?\r\nN/A\r\n\r\nIssues:\r\nFixes #126\r\n\r\nProblem:\r\nSome error handling and defensive programming changes were made\r\nto public functions.\r\n\r\nAssure gateway was not functional.  This adds support for deployments\r\nwhere snat-enabled is False.\r\n\r\nMoved over some selfip functionality from network_helper.\r\n\r\nAnalysis:\r\nRefactored exceptions, moved all selfip code from network helper to\r\nselfip, and fixed gateway creationg.\r\n\r\nTests:\r\nPass traffic.","created_at":"2016-06-06T16:51:32Z","updated_at":"2016-06-06T16:51:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/140/commits","review_comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/140/comments","review_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/140/comments","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/statuses/9c2ec4ec195e578e42d1459d70ac309fe255f6ac","head":{"label":"richbrowne:feature.refactor-selfip","ref":"feature.refactor-selfip","sha":"9c2ec4ec195e578e42d1459d70ac309fe255f6ac","user":{"login":"richbrowne","id":8740561,"avatar_url":"https://avatars.githubusercontent.com/u/8740561?v=3","gravatar_id":"","url":"https://api.github.com/users/richbrowne","html_url":"https://github.com/richbrowne","followers_url":"https://api.github.com/users/richbrowne/followers","following_url":"https://api.github.com/users/richbrowne/following{/other_user}","gists_url":"https://api.github.com/users/richbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/richbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richbrowne/subscriptions","organizations_url":"https://api.github.com/users/richbrowne/orgs","repos_url":"https://api.github.com/users/richbrowne/repos","events_url":"https://api.github.com/users/richbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/richbrowne/received_events","type":"User","site_admin":false},"repo":{"id":51530396,"name":"f5-openstack-agent","full_name":"richbrowne/f5-openstack-agent","owner":{"login":"richbrowne","id":8740561,"avatar_url":"https://avatars.githubusercontent.com/u/8740561?v=3","gravatar_id":"","url":"https://api.github.com/users/richbrowne","html_url":"https://github.com/richbrowne","followers_url":"https://api.github.com/users/richbrowne/followers","following_url":"https://api.github.com/users/richbrowne/following{/other_user}","gists_url":"https://api.github.com/users/richbrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/richbrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richbrowne/subscriptions","organizations_url":"https://api.github.com/users/richbrowne/orgs","repos_url":"https://api.github.com/users/richbrowne/repos","events_url":"https://api.github.com/users/richbrowne/events{/privacy}","received_events_url":"https://api.github.com/users/richbrowne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richbrowne/f5-openstack-agent","description":"The F5 OpenStack Agent allows you to deploy BIG-IP services in an OpenStack environment.","fork":true,"url":"https://api.github.com/repos/richbrowne/f5-openstack-agent","forks_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/forks","keys_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/teams","hooks_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/hooks","issue_events_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/issues/events{/number}","events_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/events","assignees_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/assignees{/user}","branches_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/branches{/branch}","tags_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/tags","blobs_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/languages","stargazers_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/stargazers","contributors_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/contributors","subscribers_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/subscribers","subscription_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/subscription","commits_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/contents/{+path}","compare_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/merges","archive_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/downloads","issues_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/issues{/number}","pulls_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/labels{/name}","releases_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/releases{/id}","deployments_url":"https://api.github.com/repos/richbrowne/f5-openstack-agent/deployments","created_at":"2016-02-11T17:02:49Z","updated_at":"2016-03-18T20:05:36Z","pushed_at":"2016-06-06T16:49:12Z","git_url":"git://github.com/richbrowne/f5-openstack-agent.git","ssh_url":"git@github.com:richbrowne/f5-openstack-agent.git","clone_url":"https://github.com/richbrowne/f5-openstack-agent.git","svn_url":"https://github.com/richbrowne/f5-openstack-agent","homepage":"","size":560,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"liberty"}},"base":{"label":"F5Networks:liberty","ref":"liberty","sha":"e321cfe23ecf3522856b4317b73bfc9932528f69","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":44189799,"name":"f5-openstack-agent","full_name":"F5Networks/f5-openstack-agent","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars.githubusercontent.com/u/8935905?v=3","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/f5-openstack-agent","description":"The F5® OpenStack Agent allows you to deploy BIG-IP® services in an OpenStack environment.","fork":false,"url":"https://api.github.com/repos/F5Networks/f5-openstack-agent","forks_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/forks","keys_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/teams","hooks_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/events","assignees_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/tags","blobs_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/languages","stargazers_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/subscription","commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/merges","archive_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/downloads","issues_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/f5-openstack-agent/deployments","created_at":"2015-10-13T16:28:50Z","updated_at":"2016-04-01T22:11:45Z","pushed_at":"2016-06-06T16:51:32Z","git_url":"git://github.com/F5Networks/f5-openstack-agent.git","ssh_url":"git@github.com:F5Networks/f5-openstack-agent.git","clone_url":"https://github.com/F5Networks/f5-openstack-agent.git","svn_url":"https://github.com/F5Networks/f5-openstack-agent","homepage":"http://f5-openstack-lbaasv2.rtfd.org/en/","size":568,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":12,"forks":8,"open_issues":12,"watchers":1,"default_branch":"liberty"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/140"},"html":{"href":"https://github.com/F5Networks/f5-openstack-agent/pull/140"},"issue":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/140"},"comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/f5-openstack-agent/statuses/9c2ec4ec195e578e42d1459d70ac309fe255f6ac"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":334,"deletions":232,"changed_files":5}}
{"actor":{"display_login":"richbrowne"}}