{"action":"created","issue":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1504","repository_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1504/labels{/name}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1504/comments","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1504/events","html_url":"https://github.com/gravitystorm/openstreetmap-carto/issues/1504","id":71609976,"number":1504,"title":"Plan database re-import","user":{"login":"math1985","id":5251909,"avatar_url":"https://avatars.githubusercontent.com/u/5251909?v=3","gravatar_id":"","url":"https://api.github.com/users/math1985","html_url":"https://github.com/math1985","followers_url":"https://api.github.com/users/math1985/followers","following_url":"https://api.github.com/users/math1985/following{/other_user}","gists_url":"https://api.github.com/users/math1985/gists{/gist_id}","starred_url":"https://api.github.com/users/math1985/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/math1985/subscriptions","organizations_url":"https://api.github.com/users/math1985/orgs","repos_url":"https://api.github.com/users/math1985/repos","events_url":"https://api.github.com/users/math1985/events{/privacy}","received_events_url":"https://api.github.com/users/math1985/received_events","type":"User","site_admin":false},"labels":[{"id":92409422,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels/general","name":"general","color":"cccccc","default":false},{"id":407378446,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels/lua","name":"lua","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"assignees":[{"login":"pnorman","id":1190866,"avatar_url":"https://avatars.githubusercontent.com/u/1190866?v=3","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones/1","html_url":"https://github.com/gravitystorm/openstreetmap-carto/milestones/Database%20layout%20change","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones/1/labels","id":623947,"number":1,"title":"Database layout change","description":"Certain features can't be implemented without changing the database layout\r\n\r\nChanging this warrants a move to a 3.x series, and ideally, any changes to either the database or the Mapnik version will happen at the same time.","creator":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars.githubusercontent.com/u/360803?v=3","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":35,"state":"open","created_at":"2014-04-08T14:24:05Z","updated_at":"2016-11-14T08:46:43Z","due_on":null,"closed_at":null},"comments":74,"created_at":"2015-04-28T14:46:43Z","updated_at":"2016-11-16T08:00:36Z","closed_at":null,"body":"This is a management issue for the upcoming re-import of the database. A re-import of the database gives us the opportunity to change the keys that are available to the stylesheet.\n\nWe will use the lua tag transformation option from osm2pgsql, and enable the hstore option.\n# Questions to be answered\n- Decide for which keys we want to change the polygon vs linestring behaviour for closed ways.\n- Decide for which key/value combinations we want to change the polygon vs linestring behaviour for closed ways.\n- Is there anything in particular that needs to be done to prepare for hstore?\n- Do we want to move the z_order code for roads to lua?\n- Are there any other changes we want to make?\n# Action plan\n- [ ] Decide on the questions above.\n- [ ] Prepare SQL for hstore\n- [ ] Implement changes in lua file.\n- [ ] Contact server admins to discuss date of database reload.\n- [ ] Database reload.\n- [ ] Start resolving issues that need the new database scheme.\n# Requested changes\n\nThe following changes have been requested:\n## Keys to be added\n\nAdding hstore will avoid the need to manually add these keys.\n- emergency #318, #1160\n- entrance #740, #517\n- golf #661\n- addr:flats #264, #605\n- allotments #432\n- area:highway #180\n- mountain_pass #244\n- ford #267\n## Keys to be added\n\nAdding hstore will avoid the need to manually add these keys.\n- backcountry #1485\n- memorial:type #1066\n- lock_name #828\n- bridge_name #828\n- leaf_type #822\n- int_name #803\n- basin #709\n- location #552, #640\n- protect_class #603\n- proposed #592\n- information #304, #324\n- network #508\n- height #1017\n- generator:output:electricity #1017\n- lock_name #157\n- bus #311, #435\n- vehicle #214\n- motor_vehicle #214\n- motorcar #214 \n## Keys to be treated as linestring\n- sport https://github.com/gravitystorm/openstreetmap-carto/issues/1362#issuecomment-78860353\n## Keys to be treated as polygon\n- junction #1253\n- boundary #468\n## Key/value combinations to be treated as linestring\n\nPull request written, see https://github.com/openstreetmap/osm2pgsql/pull/346.\n- man_made=embankment #892\n- natural=cliff #268\n- historic=citywalls #1362\n- man_made=breakwater #1362\n- man_made=groyne #1362\n- natural=tree_row #1362\n- waterway=derelict_canal #1362\n- waterway=ditch #1362\n- waterway=drain #1362\n- waterway=river #1362\n- waterway=stream #1362\n- waterway=wadi #1362\n- waterway=weir #1362\n- power=line #1362\n- power=minor_line #1362\n## Key/value combinations to be treated as polygon\n\nPull request written, see https://github.com/openstreetmap/osm2pgsql/pull/346.\n- highway=services #137\n## Also include as way\n\nThis has already been fixed in the current default lua style file.\n- ele #101\n"},"comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/260879180","html_url":"https://github.com/gravitystorm/openstreetmap-carto/issues/1504#issuecomment-260879180","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/1504","id":260879180,"user":{"login":"Ircama","id":8292987,"avatar_url":"https://avatars.githubusercontent.com/u/8292987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ircama","html_url":"https://github.com/Ircama","followers_url":"https://api.github.com/users/Ircama/followers","following_url":"https://api.github.com/users/Ircama/following{/other_user}","gists_url":"https://api.github.com/users/Ircama/gists{/gist_id}","starred_url":"https://api.github.com/users/Ircama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ircama/subscriptions","organizations_url":"https://api.github.com/users/Ircama/orgs","repos_url":"https://api.github.com/users/Ircama/repos","events_url":"https://api.github.com/users/Ircama/events{/privacy}","received_events_url":"https://api.github.com/users/Ircama/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T08:00:36Z","updated_at":"2016-11-16T08:00:36Z","body":"> Do we feel that the instructions and documentation is good enough that using transforms won't pose a barrier to those wanting to contribute?\r\n\r\nI think it might be worthwhile to add some note.\r\n\r\nJust some rough points by now (I’ll better check this in the next days):\r\n\r\n* scripts in [scripts/lua](https://github.com/gravitystorm/openstreetmap-carto/tree/lua/scripts/lua) might require some explanation; will they be kept for the final drop?\r\n* [README.md](https://github.com/gravitystorm/openstreetmap-carto/blob/lua/README.md) mentions [Current work (v2.x)](https://github.com/gravitystorm/openstreetmap-carto/tree/lua#current-work-v2x) and [Database schema change (v3.x)](https://github.com/gravitystorm/openstreetmap-carto/tree/lua#database-schema-change-v3x); do we need some additional clarification?\r\n* maybe some recommendations/best practices in using hstore could be added as well as its limitations (e.g., like [this](https://github.com/gravitystorm/openstreetmap-carto/issues/1504#issuecomment-97110342) and [this](https://github.com/gravitystorm/openstreetmap-carto/issues/1504#issuecomment-97125020))\r\n* I would suggest some note on the need to add a transform or an exclusion for a new feature and some warning on thinks not to be done in [openstreetmap-carto.lua](https://github.com/gravitystorm/openstreetmap-carto/blob/lua/openstreetmap-carto.lua)\r\n* I would suggest some note on the management of [openstreetmap-carto.style](https://github.com/gravitystorm/openstreetmap-carto/blob/lua/openstreetmap-carto.style) with hstore\r\n"}}
{"actor":{"display_login":"Ircama"}}