{"action":"closed","number":4709,"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/4709","id":62830929,"html_url":"https://github.com/chef/chef/pull/4709","diff_url":"https://github.com/chef/chef/pull/4709.diff","patch_url":"https://github.com/chef/chef/pull/4709.patch","issue_url":"https://api.github.com/repos/chef/chef/issues/4709","number":4709,"state":"closed","locked":false,"title":"Setting init_command should be accepted instead of specific command overrides","user":{"login":"coderanger","id":128243,"avatar_url":"https://avatars.githubusercontent.com/u/128243?v=3","gravatar_id":"","url":"https://api.github.com/users/coderanger","html_url":"https://github.com/coderanger","followers_url":"https://api.github.com/users/coderanger/followers","following_url":"https://api.github.com/users/coderanger/following{/other_user}","gists_url":"https://api.github.com/users/coderanger/gists{/gist_id}","starred_url":"https://api.github.com/users/coderanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderanger/subscriptions","organizations_url":"https://api.github.com/users/coderanger/orgs","repos_url":"https://api.github.com/users/coderanger/repos","events_url":"https://api.github.com/users/coderanger/events{/privacy}","received_events_url":"https://api.github.com/users/coderanger/received_events","type":"User","site_admin":false},"body":"Also remove `:enable` from that list because `enable_command` isn't a thing on the service resource. Not clear to me why `:enable` ever worked there.\r\n\r\nAlternatively we could modify `custom_command_for_action?` to always return true if `init_command` is set, but that feels weirder to me.\r\n\r\nPing @chef/client-core @chef/client-enterprise-linux for review.","created_at":"2016-03-14T22:58:46Z","updated_at":"2016-04-05T19:42:06Z","closed_at":"2016-04-05T19:42:06Z","merged_at":"2016-04-05T19:42:06Z","merge_commit_sha":"37a750c4857c2ff873a0c575dd3c140b2d2b742b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef/pulls/4709/commits","review_comments_url":"https://api.github.com/repos/chef/chef/pulls/4709/comments","review_comment_url":"https://api.github.com/repos/chef/chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef/issues/4709/comments","statuses_url":"https://api.github.com/repos/chef/chef/statuses/ea341043d8ad3f0852e0dfc8d8383704a4bc7623","head":{"label":"coderanger:init_command","ref":"init_command","sha":"ea341043d8ad3f0852e0dfc8d8383704a4bc7623","user":{"login":"coderanger","id":128243,"avatar_url":"https://avatars.githubusercontent.com/u/128243?v=3","gravatar_id":"","url":"https://api.github.com/users/coderanger","html_url":"https://github.com/coderanger","followers_url":"https://api.github.com/users/coderanger/followers","following_url":"https://api.github.com/users/coderanger/following{/other_user}","gists_url":"https://api.github.com/users/coderanger/gists{/gist_id}","starred_url":"https://api.github.com/users/coderanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderanger/subscriptions","organizations_url":"https://api.github.com/users/coderanger/orgs","repos_url":"https://api.github.com/users/coderanger/repos","events_url":"https://api.github.com/users/coderanger/events{/privacy}","received_events_url":"https://api.github.com/users/coderanger/received_events","type":"User","site_admin":false},"repo":{"id":12743312,"name":"chef","full_name":"coderanger/chef","owner":{"login":"coderanger","id":128243,"avatar_url":"https://avatars.githubusercontent.com/u/128243?v=3","gravatar_id":"","url":"https://api.github.com/users/coderanger","html_url":"https://github.com/coderanger","followers_url":"https://api.github.com/users/coderanger/followers","following_url":"https://api.github.com/users/coderanger/following{/other_user}","gists_url":"https://api.github.com/users/coderanger/gists{/gist_id}","starred_url":"https://api.github.com/users/coderanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderanger/subscriptions","organizations_url":"https://api.github.com/users/coderanger/orgs","repos_url":"https://api.github.com/users/coderanger/repos","events_url":"https://api.github.com/users/coderanger/events{/privacy}","received_events_url":"https://api.github.com/users/coderanger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coderanger/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":true,"url":"https://api.github.com/repos/coderanger/chef","forks_url":"https://api.github.com/repos/coderanger/chef/forks","keys_url":"https://api.github.com/repos/coderanger/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coderanger/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coderanger/chef/teams","hooks_url":"https://api.github.com/repos/coderanger/chef/hooks","issue_events_url":"https://api.github.com/repos/coderanger/chef/issues/events{/number}","events_url":"https://api.github.com/repos/coderanger/chef/events","assignees_url":"https://api.github.com/repos/coderanger/chef/assignees{/user}","branches_url":"https://api.github.com/repos/coderanger/chef/branches{/branch}","tags_url":"https://api.github.com/repos/coderanger/chef/tags","blobs_url":"https://api.github.com/repos/coderanger/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coderanger/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coderanger/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/coderanger/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coderanger/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/coderanger/chef/languages","stargazers_url":"https://api.github.com/repos/coderanger/chef/stargazers","contributors_url":"https://api.github.com/repos/coderanger/chef/contributors","subscribers_url":"https://api.github.com/repos/coderanger/chef/subscribers","subscription_url":"https://api.github.com/repos/coderanger/chef/subscription","commits_url":"https://api.github.com/repos/coderanger/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/coderanger/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/coderanger/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/coderanger/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/coderanger/chef/contents/{+path}","compare_url":"https://api.github.com/repos/coderanger/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coderanger/chef/merges","archive_url":"https://api.github.com/repos/coderanger/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coderanger/chef/downloads","issues_url":"https://api.github.com/repos/coderanger/chef/issues{/number}","pulls_url":"https://api.github.com/repos/coderanger/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/coderanger/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/coderanger/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coderanger/chef/labels{/name}","releases_url":"https://api.github.com/repos/coderanger/chef/releases{/id}","deployments_url":"https://api.github.com/repos/coderanger/chef/deployments","created_at":"2013-09-10T23:48:03Z","updated_at":"2014-08-19T21:47:07Z","pushed_at":"2016-04-05T19:41:52Z","git_url":"git://github.com/coderanger/chef.git","ssh_url":"git@github.com:coderanger/chef.git","clone_url":"https://github.com/coderanger/chef.git","svn_url":"https://github.com/coderanger/chef","homepage":"http://www.opscode.com/chef/","size":89973,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"3f07943715c31dd328dd104bba90d103b744323b","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"name":"chef","full_name":"chef/chef","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef/deployments","created_at":"2009-01-15T20:40:48Z","updated_at":"2016-04-05T17:57:41Z","pushed_at":"2016-04-05T19:42:06Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":102303,"stargazers_count":4176,"watchers_count":4176,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1727,"mirror_url":null,"open_issues_count":451,"forks":1727,"open_issues":451,"watchers":4176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/4709"},"html":{"href":"https://github.com/chef/chef/pull/4709"},"issue":{"href":"https://api.github.com/repos/chef/chef/issues/4709"},"comments":{"href":"https://api.github.com/repos/chef/chef/issues/4709/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef/pulls/4709/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef/pulls/4709/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef/statuses/ea341043d8ad3f0852e0dfc8d8383704a4bc7623"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"coderanger","id":128243,"avatar_url":"https://avatars.githubusercontent.com/u/128243?v=3","gravatar_id":"","url":"https://api.github.com/users/coderanger","html_url":"https://github.com/coderanger","followers_url":"https://api.github.com/users/coderanger/followers","following_url":"https://api.github.com/users/coderanger/following{/other_user}","gists_url":"https://api.github.com/users/coderanger/gists{/gist_id}","starred_url":"https://api.github.com/users/coderanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderanger/subscriptions","organizations_url":"https://api.github.com/users/coderanger/orgs","repos_url":"https://api.github.com/users/coderanger/repos","events_url":"https://api.github.com/users/coderanger/events{/privacy}","received_events_url":"https://api.github.com/users/coderanger/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":4,"additions":24,"deletions":4,"changed_files":2}}