{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/90400703","pull_request_review_id":10918163,"id":90400703,"diff_hunk":"@@ -1,46 +1,46 @@\n-<?php\r\n-\r\n-class WikiGetDataForPromoteHelper implements WikiGetDataHelper {\r\n-\tprotected $visualization;\r\n-\r\n-\t/**\r\n-\t * @return CityVisualization\r\n-\t */\r\n-\tprotected function getVisualization() {\r\n-\t\tif(empty($this->visualization)) {\r\n-\t\t\t$this->visualization = new CityVisualization();\r\n-\t\t}\r\n-\t\treturn $this->visualization;\r\n-\t}\r\n-\r\n-\tpublic function getMemcKey($wikiId, $langCode) {\r\n-\t\t$visualization = $this->getVisualization();\r\n-\t\treturn $visualization->getWikiPromoteDataCacheKey($wikiId, $langCode);\r\n-\t}\r\n-\r\n-\tpublic function getImagesMemcKey($wikiId, $langCode) {\r\n-\t\t$visualization = $this->getVisualization();\r\n-\t\treturn $visualization->getWikiImageNamesCacheKey($wikiId, $langCode, ImageReviewStatuses::STATE_ANY);\r\n-\t}\r\n-\r\n-\tpublic function getImages($wikiId, $langCode, $wikiRow) {\r\n-\t\t$visualization = $this->getVisualization();\r\n-\r\n-\t\treturn $visualization->getWikiImageNames($wikiId, $langCode, ImageReviewStatuses::STATE_ANY);\r\n-\t}\r\n-\r\n-\t/**\r\n-\t * @param $wikiId int\r\n-\t * @param $langCode String\r\n-\t * @param $imageSource object (city_visualization row)\r\n-\t * @param $currentData array\r\n-\t * @return bool\r\n-\t */\r\n-\tpublic function getMainImage($wikiId, $langCode, $imageSource, &$currentData) {\r\n- \t\tif(!empty($currentData['images']) && !empty($currentData['images'][0])) {\r\n-\t\t\t$mainImage = array_shift($currentData['images']);\r\n- \t\t\treturn $mainImage;\r\n- \t\t}\r\n- \t\treturn false;\r\n- \t}\r\n-}\r\n+<?php\n+\n+class WikiGetDataForPromoteHelper implements WikiGetDataHelper {\n+\tprotected $visualization;\n+\n+\t/**\n+\t * @return CityVisualization\n+\t */\n+\tprotected function getVisualization() {\n+\t\tif(empty($this->visualization)) {\n+\t\t\t$this->visualization = new CityVisualization();\n+\t\t}\n+\t\treturn $this->visualization;\n+\t}\n+\n+\tpublic function getMemcKey($wikiId, $langCode) {\n+\t\t$visualization = $this->getVisualization();\n+\t\treturn $visualization->getWikiPromoteDataCacheKey($wikiId, $langCode);\n+\t}\n+\n+\tpublic function getImagesMemcKey($wikiId, $langCode) {\n+\t\t$visualization = $this->getVisualization();\n+\t\treturn $visualization->getWikiImageNamesCacheKey($wikiId, $langCode, ImageStates::ANY);\n+\t}\n+\n+\tpublic function getImages($wikiId, $langCode, $wikiRow) {\n+\t\t$visualization = $this->getVisualization();\n+\n+\t\treturn $visualization->getWikiImageNames($wikiId, $langCode, ImageStates::ANY);\n+\t}\n+\n+\t/**\n+\t * @param $wikiId int\n+\t * @param $langCode String\n+\t * @param $imageSource object (city_visualization row)\n+\t * @param $currentData array\n+\t * @return bool\n+\t */\n+\tpublic function getMainImage($wikiId, $langCode, $imageSource, &$currentData) {\n+ \t\tif(!empty($currentData['images']) && !empty($currentData['images'][0])) {","path":"extensions/wikia/CityVisualization/classes/WikiGetDataForPromoteHelper.class.php","position":86,"original_position":86,"commit_id":"c789c3bf771970f77364bcdc960cdce3cb4f700c","original_commit_id":"c789c3bf771970f77364bcdc960cdce3cb4f700c","user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) Define a constant instead of duplicating this literal \"images\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n","created_at":"2016-12-01T08:23:35Z","updated_at":"2016-12-01T08:23:35Z","html_url":"https://github.com/Wikia/app/pull/11929#discussion_r90400703","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/11929","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/90400703"},"html":{"href":"https://github.com/Wikia/app/pull/11929#discussion_r90400703"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/11929"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/11929","id":94463100,"html_url":"https://github.com/Wikia/app/pull/11929","diff_url":"https://github.com/Wikia/app/pull/11929.diff","patch_url":"https://github.com/Wikia/app/pull/11929.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/11929","number":11929,"state":"open","locked":false,"title":"SUS-541 Refactoring of the ImageReview tool to make it more consistent","user":{"login":"garthwebb","id":72574,"avatar_url":"https://avatars.githubusercontent.com/u/72574?v=3","gravatar_id":"","url":"https://api.github.com/users/garthwebb","html_url":"https://github.com/garthwebb","followers_url":"https://api.github.com/users/garthwebb/followers","following_url":"https://api.github.com/users/garthwebb/following{/other_user}","gists_url":"https://api.github.com/users/garthwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/garthwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garthwebb/subscriptions","organizations_url":"https://api.github.com/users/garthwebb/orgs","repos_url":"https://api.github.com/users/garthwebb/repos","events_url":"https://api.github.com/users/garthwebb/events{/privacy}","received_events_url":"https://api.github.com/users/garthwebb/received_events","type":"User","site_admin":false},"body":"Jira Ticket: https://wikia-inc.atlassian.net/browse/SUS-541\r\n\r\nThis work does not directly address the tasks as listed in SUS-541 but should help fix some root problems.  This refactor aims to simplify some of the handling code, and make it more consistent.  \r\n\r\nFor example, previously if you visited Special:ImageReview repeatedly by direct URL (e.g. leaving off the ts=XXX it adds) you get different images each time, and the old set of images would still be assigned to you with virtually no way to get at them.  Now, if there is no ts=XXX argument, the extension looks in the DB for any records still assigned to you and updates your ts=XXX to match them.\r\n\r\nAlso fixed a race condition when getting images to review.  A lot of processing happens between pulling a list of possible images and claiming them as your own, and no checks are done to make sure you aren't claiming images that were just claimed by someone else a few microseconds earlier.\r\n\r\nFixed broken cvsStats.  They were giving an error screen because of a bad method call.  Also the output wasn't being set properly so it would have returned an HTML page anyway.\r\n\r\nLots of small updates to bring inline with PHP coding conventions.  Didn't update everywhere since that would make this already large PR even larger so updated at the function level for functions I touched.m\r\n\r\n@mixth-sense ","created_at":"2016-11-19T01:06:02Z","updated_at":"2016-12-01T08:23:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff113ff20788a0b32fad0781bf5c14d13a86a8a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/11929/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/11929/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/11929/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/c789c3bf771970f77364bcdc960cdce3cb4f700c","head":{"label":"Wikia:SUS-541","ref":"SUS-541","sha":"c789c3bf771970f77364bcdc960cdce3cb4f700c","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-11-23T04:09:52Z","pushed_at":"2016-12-01T07:29:55Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1494357,"stargazers_count":106,"watchers_count":106,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":111,"forks":85,"open_issues":111,"watchers":106,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"0454cbc7d28729b2c9bebc8c684400cd2aac7643","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-11-23T04:09:52Z","pushed_at":"2016-12-01T07:29:55Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1494357,"stargazers_count":106,"watchers_count":106,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":111,"forks":85,"open_issues":111,"watchers":106,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/11929"},"html":{"href":"https://github.com/Wikia/app/pull/11929"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/11929"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/11929/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/11929/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/11929/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/c789c3bf771970f77364bcdc960cdce3cb4f700c"}}}}
{"actor":{"display_login":"WikiaTech"}}