{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/68326885","id":68326885,"diff_hunk":"@@ -114,6 +114,9 @@ int Poller::poll(int timeout_ms) const {\n }","path":"libraries/AP_HAL_Linux/Poller.cpp","position":45,"original_position":1,"commit_id":"88483dbbb18ec987482a28ca01cd7c58ad4e2081","original_commit_id":"88483dbbb18ec987482a28ca01cd7c58ad4e2081","user":{"login":"mbelluzzo","id":1584229,"avatar_url":"https://avatars.githubusercontent.com/u/1584229?v=3","gravatar_id":"","url":"https://api.github.com/users/mbelluzzo","html_url":"https://github.com/mbelluzzo","followers_url":"https://api.github.com/users/mbelluzzo/followers","following_url":"https://api.github.com/users/mbelluzzo/following{/other_user}","gists_url":"https://api.github.com/users/mbelluzzo/gists{/gist_id}","starred_url":"https://api.github.com/users/mbelluzzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbelluzzo/subscriptions","organizations_url":"https://api.github.com/users/mbelluzzo/orgs","repos_url":"https://api.github.com/users/mbelluzzo/repos","events_url":"https://api.github.com/users/mbelluzzo/events{/privacy}","received_events_url":"https://api.github.com/users/mbelluzzo/received_events","type":"User","site_admin":false},"body":"+2","created_at":"2016-06-23T22:27:58Z","updated_at":"2016-06-23T22:27:58Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/4024#discussion_r68326885","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/68326885"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/4024#discussion_r68326885"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024"}}},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024","id":68620965,"html_url":"https://github.com/ArduPilot/ardupilot/pull/4024","diff_url":"https://github.com/ArduPilot/ardupilot/pull/4024.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/4024.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4024","number":4024,"state":"open","locked":false,"title":"AP_HAL_Linux: Refactor UARTDriver to use epoll","user":{"login":"lpereira","id":15001,"avatar_url":"https://avatars.githubusercontent.com/u/15001?v=3","gravatar_id":"","url":"https://api.github.com/users/lpereira","html_url":"https://github.com/lpereira","followers_url":"https://api.github.com/users/lpereira/followers","following_url":"https://api.github.com/users/lpereira/following{/other_user}","gists_url":"https://api.github.com/users/lpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/lpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpereira/subscriptions","organizations_url":"https://api.github.com/users/lpereira/orgs","repos_url":"https://api.github.com/users/lpereira/repos","events_url":"https://api.github.com/users/lpereira/events{/privacy}","received_events_url":"https://api.github.com/users/lpereira/received_events","type":"User","site_admin":false},"body":"This is a step in the direction of moving off of I/O with timer ticks to use the system's polling infrastructure to be notified whenever a device is ready to be read from or written to.\r\n\r\nThis removes a lot of code from UARTDriver, and introduces a few helper classes:\r\n        * Poller, as an interface to epoll()\r\n        * Pollable, as an interface to a file descriptor\r\n        * BufferedPollable, that has read and write ring buffers\r\n        * PacketedBufferedPollable, that's used for MAVLink packets\r\n\r\nThis creates a new thread that does the call to epoll_wait(); the timeout is fixed, but the remaining time is evenly split between each Pollable so that the maximum time they should wait to lock their semaphores is fairer.\r\n\r\nThe `packetise` flag from UARTDriver has been removed, and the write()-call-per-MAVLink-message has been slightly improved from a performance perspective (fast byte scans, etc), and improved from a readability perspective (ByteBuffer from AP_HAL is used instead of an open coded version).\r\n\r\nInterfaces still need some improvement from a readability perspective.\r\n\r\nThis has not been flight-tested yet but strace seems sane enough.\r\n","created_at":"2016-05-02T21:02:45Z","updated_at":"2016-06-23T22:27:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11c788a700cf80b8d48a7d1f7d0c5a83775784b3","assignee":{"login":"lucasdemarchi","id":31864,"avatar_url":"https://avatars.githubusercontent.com/u/31864?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4024/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/88483dbbb18ec987482a28ca01cd7c58ad4e2081","head":{"label":"lpereira:epoll","ref":"epoll","sha":"88483dbbb18ec987482a28ca01cd7c58ad4e2081","user":{"login":"lpereira","id":15001,"avatar_url":"https://avatars.githubusercontent.com/u/15001?v=3","gravatar_id":"","url":"https://api.github.com/users/lpereira","html_url":"https://github.com/lpereira","followers_url":"https://api.github.com/users/lpereira/followers","following_url":"https://api.github.com/users/lpereira/following{/other_user}","gists_url":"https://api.github.com/users/lpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/lpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpereira/subscriptions","organizations_url":"https://api.github.com/users/lpereira/orgs","repos_url":"https://api.github.com/users/lpereira/repos","events_url":"https://api.github.com/users/lpereira/events{/privacy}","received_events_url":"https://api.github.com/users/lpereira/received_events","type":"User","site_admin":false},"repo":{"id":57894089,"name":"ardupilot","full_name":"lpereira/ardupilot","owner":{"login":"lpereira","id":15001,"avatar_url":"https://avatars.githubusercontent.com/u/15001?v=3","gravatar_id":"","url":"https://api.github.com/users/lpereira","html_url":"https://github.com/lpereira","followers_url":"https://api.github.com/users/lpereira/followers","following_url":"https://api.github.com/users/lpereira/following{/other_user}","gists_url":"https://api.github.com/users/lpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/lpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpereira/subscriptions","organizations_url":"https://api.github.com/users/lpereira/orgs","repos_url":"https://api.github.com/users/lpereira/repos","events_url":"https://api.github.com/users/lpereira/events{/privacy}","received_events_url":"https://api.github.com/users/lpereira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpereira/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":true,"url":"https://api.github.com/repos/lpereira/ardupilot","forks_url":"https://api.github.com/repos/lpereira/ardupilot/forks","keys_url":"https://api.github.com/repos/lpereira/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpereira/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpereira/ardupilot/teams","hooks_url":"https://api.github.com/repos/lpereira/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/lpereira/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/lpereira/ardupilot/events","assignees_url":"https://api.github.com/repos/lpereira/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/lpereira/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/lpereira/ardupilot/tags","blobs_url":"https://api.github.com/repos/lpereira/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpereira/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpereira/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpereira/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpereira/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/lpereira/ardupilot/languages","stargazers_url":"https://api.github.com/repos/lpereira/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/lpereira/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/lpereira/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/lpereira/ardupilot/subscription","commits_url":"https://api.github.com/repos/lpereira/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpereira/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpereira/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpereira/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpereira/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/lpereira/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpereira/ardupilot/merges","archive_url":"https://api.github.com/repos/lpereira/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpereira/ardupilot/downloads","issues_url":"https://api.github.com/repos/lpereira/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/lpereira/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/lpereira/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/lpereira/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpereira/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/lpereira/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/lpereira/ardupilot/deployments","created_at":"2016-05-02T13:58:47Z","updated_at":"2016-05-02T13:58:58Z","pushed_at":"2016-06-06T13:21:18Z","git_url":"git://github.com/lpereira/ardupilot.git","ssh_url":"git@github.com:lpereira/ardupilot.git","clone_url":"https://github.com/lpereira/ardupilot.git","svn_url":"https://github.com/lpereira/ardupilot","homepage":"http://ardupilot.org/","size":74723,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"41bb2377993046057826bd2b3c9177495c256c70","user":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2016-06-23T16:15:18Z","pushed_at":"2016-06-23T22:09:03Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":137415,"stargazers_count":1918,"watchers_count":1918,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4062,"mirror_url":null,"open_issues_count":756,"forks":4062,"open_issues":756,"watchers":1918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/4024"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4024"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4024/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4024/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/88483dbbb18ec987482a28ca01cd7c58ad4e2081"}}}}
{"actor":{"display_login":"mbelluzzo"}}