{"action":"created","issue":{"url":"https://api.github.com/repos/python-control/python-control/issues/122","repository_url":"https://api.github.com/repos/python-control/python-control","labels_url":"https://api.github.com/repos/python-control/python-control/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/python-control/python-control/issues/122/comments","events_url":"https://api.github.com/repos/python-control/python-control/issues/122/events","html_url":"https://github.com/python-control/python-control/pull/122","id":197598595,"number":122,"title":"Allow unit tests to run without slycot","user":{"login":"murrayrm","id":293362,"avatar_url":"https://avatars.githubusercontent.com/u/293362?v=3","gravatar_id":"","url":"https://api.github.com/users/murrayrm","html_url":"https://github.com/murrayrm","followers_url":"https://api.github.com/users/murrayrm/followers","following_url":"https://api.github.com/users/murrayrm/following{/other_user}","gists_url":"https://api.github.com/users/murrayrm/gists{/gist_id}","starred_url":"https://api.github.com/users/murrayrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrayrm/subscriptions","organizations_url":"https://api.github.com/users/murrayrm/orgs","repos_url":"https://api.github.com/users/murrayrm/repos","events_url":"https://api.github.com/users/murrayrm/events{/privacy}","received_events_url":"https://api.github.com/users/murrayrm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"slivingston","id":355654,"avatar_url":"https://avatars.githubusercontent.com/u/355654?v=3","gravatar_id":"","url":"https://api.github.com/users/slivingston","html_url":"https://github.com/slivingston","followers_url":"https://api.github.com/users/slivingston/followers","following_url":"https://api.github.com/users/slivingston/following{/other_user}","gists_url":"https://api.github.com/users/slivingston/gists{/gist_id}","starred_url":"https://api.github.com/users/slivingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slivingston/subscriptions","organizations_url":"https://api.github.com/users/slivingston/orgs","repos_url":"https://api.github.com/users/slivingston/repos","events_url":"https://api.github.com/users/slivingston/events{/privacy}","received_events_url":"https://api.github.com/users/slivingston/received_events","type":"User","site_admin":false},"assignees":[{"login":"slivingston","id":355654,"avatar_url":"https://avatars.githubusercontent.com/u/355654?v=3","gravatar_id":"","url":"https://api.github.com/users/slivingston","html_url":"https://github.com/slivingston","followers_url":"https://api.github.com/users/slivingston/followers","following_url":"https://api.github.com/users/slivingston/following{/other_user}","gists_url":"https://api.github.com/users/slivingston/gists{/gist_id}","starred_url":"https://api.github.com/users/slivingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slivingston/subscriptions","organizations_url":"https://api.github.com/users/slivingston/orgs","repos_url":"https://api.github.com/users/slivingston/repos","events_url":"https://api.github.com/users/slivingston/events{/privacy}","received_events_url":"https://api.github.com/users/slivingston/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-12-26T15:34:20Z","updated_at":"2016-12-31T21:57:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/python-control/python-control/pulls/122","html_url":"https://github.com/python-control/python-control/pull/122","diff_url":"https://github.com/python-control/python-control/pull/122.diff","patch_url":"https://github.com/python-control/python-control/pull/122.patch"},"body":"This PR provides updates to allow unit tests to run correctly when `slycot` is not installed.  There is also a change in `xferfcn.py` to allow proper creation of transfer functions when num or den is a 0d ndarray.  This can occur when `slycot` is not installed due to a difference in the way that transfer functions are created from state space matrices in `xferfcn._convertToTransferFunction()` when `slycot` is not available.\r\n"},"comment":{"url":"https://api.github.com/repos/python-control/python-control/issues/comments/269883256","html_url":"https://github.com/python-control/python-control/pull/122#issuecomment-269883256","issue_url":"https://api.github.com/repos/python-control/python-control/issues/122","id":269883256,"user":{"login":"slivingston","id":355654,"avatar_url":"https://avatars.githubusercontent.com/u/355654?v=3","gravatar_id":"","url":"https://api.github.com/users/slivingston","html_url":"https://github.com/slivingston","followers_url":"https://api.github.com/users/slivingston/followers","following_url":"https://api.github.com/users/slivingston/following{/other_user}","gists_url":"https://api.github.com/users/slivingston/gists{/gist_id}","starred_url":"https://api.github.com/users/slivingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slivingston/subscriptions","organizations_url":"https://api.github.com/users/slivingston/orgs","repos_url":"https://api.github.com/users/slivingston/repos","events_url":"https://api.github.com/users/slivingston/events{/privacy}","received_events_url":"https://api.github.com/users/slivingston/received_events","type":"User","site_admin":false},"created_at":"2016-12-31T21:57:02Z","updated_at":"2016-12-31T21:57:02Z","body":"For future work, I think that it would be useful to either:\r\n\r\n* notify the user when a test case is modified according to whether `slycot` is found; or\r\n* separate instances of the above into uniquely named tests, so that a test case is never hot-swapped but rather skipped or not."}}
{"actor":{"display_login":"slivingston"}}