{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/10682","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10682/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10682/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10682/events","html_url":"https://github.com/joomla/joomla-cms/pull/10682","id":157544314,"number":10682,"title":"[JDocument] Allow other attributes in meta tags","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.0","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/12/labels","id":1360635,"number":12,"title":"Joomla 3.6.0","description":"","creator":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":675,"state":"open","created_at":"2015-10-17T07:57:38Z","updated_at":"2016-06-04T10:09:18Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2016-05-30T18:48:37Z","updated_at":"2016-06-04T10:09:23Z","closed_at":"2016-06-04T10:09:18Z","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10682","html_url":"https://github.com/joomla/joomla-cms/pull/10682","diff_url":"https://github.com/joomla/joomla-cms/pull/10682.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10682.patch"},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/10671.\r\n\r\n#### Summary of Changes\r\n\r\nAllow to add other attributes in JDocument::setMetadata and retrieve them with JDocument::getMetadata.\r\n\r\n#### Testing Instructions\r\n\r\n- Code review\r\n\r\n- Add this code in protostar template index.php\r\n\r\n```php\r\n$doc->setMetaData('generator', 'test generator');\r\n$doc->setMetaData('description', 'test description');\r\n$doc->setMetaData('test 1', 'test 1 value');\r\n$doc->setMetaData('test 2', 'test 2 value', true);\r\n$doc->setMetaData('test 3', 'test 3 value', 'property');\r\n$doc->setMetaData('og:image', 'https://cdn.joomla.org/images/Joomla_logo.png', 'property');\r\n```\r\n- Now test before and after patch\r\n\r\nBefore patch\r\n\r\n```html\r\n  <meta http-equiv=\"test 2\" content=\"test 2 value\" />\r\n  <meta http-equiv=\"test 3\" content=\"test 3 value\" />\r\n  <meta http-equiv=\"og:image\" content=\"https://cdn.joomla.org/images/Joomla_logo.png\" />\r\n  <meta name=\"test 1\" content=\"test 1 value\" />\r\n  <meta name=\"description\" content=\"test description\" />\r\n  <meta name=\"generator\" content=\"test generator\" />\r\n```\r\n\r\nAfter patch\r\n\r\n```html\r\n  <meta http-equiv=\"test 2\" content=\"test 2 value\" />\r\n  <meta name=\"test 1\" content=\"test 1 value\" />\r\n  <meta property=\"test 3\" content=\"test 3 value\" />\r\n  <meta property=\"og:image\" content=\"https://cdn.joomla.org/images/Joomla_logo.png\" />\r\n  <meta name=\"description\" content=\"test description\" />\r\n  <meta name=\"generator\" content=\"test generator\" />\r\n```\r\n\r\n#### B/C\r\n\r\nSince `_metaTags` is public and don't exactly know the history on this, i'm not sure if this is B/C.\r\nSo please confirm."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/223747787","html_url":"https://github.com/joomla/joomla-cms/pull/10682#issuecomment-223747787","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10682","id":223747787,"user":{"login":"roland-d","id":359377,"avatar_url":"https://avatars.githubusercontent.com/u/359377?v=3","gravatar_id":"","url":"https://api.github.com/users/roland-d","html_url":"https://github.com/roland-d","followers_url":"https://api.github.com/users/roland-d/followers","following_url":"https://api.github.com/users/roland-d/following{/other_user}","gists_url":"https://api.github.com/users/roland-d/gists{/gist_id}","starred_url":"https://api.github.com/users/roland-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roland-d/subscriptions","organizations_url":"https://api.github.com/users/roland-d/orgs","repos_url":"https://api.github.com/users/roland-d/repos","events_url":"https://api.github.com/users/roland-d/events{/privacy}","received_events_url":"https://api.github.com/users/roland-d/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T10:09:23Z","updated_at":"2016-06-04T10:09:23Z","body":"Thanks everybody"}}
{"actor":{"display_login":"roland-d"}}