{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/85439299","pull_request_review_id":6156981,"id":85439299,"diff_hunk":"@@ -687,18 +687,23 @@ impl LineBreaker {\n         let mut need_ellipsis = false;\n         let available_inline_size = self.pending_line.green_zone.inline -\n             self.pending_line.bounds.size.inline - indentation;\n-        match (fragment.style().get_text().text_overflow,\n-               fragment.style().get_box().overflow_x) {\n-            (text_overflow::T::clip, _) | (_, overflow_x::T::visible) => {}\n-            (text_overflow::T::ellipsis, _) => {\n+\n+        let text_overflow_string: Option<String> = match fragment.style().get_text().text_overflow.first {\n+            longhands::text_overflow::Side::Clip => None,\n+            longhands::text_overflow::Side::Ellipsis => {","path":"components/layout/inline.rs","position":26,"original_position":26,"commit_id":"ccea58ea05fd2aa20446f517899cdf517e98e1b6","original_commit_id":"ccea58ea05fd2aa20446f517899cdf517e98e1b6","user":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"body":"@emilio I don't understand how looking into `self.style()` would help. Could you explain more?","created_at":"2016-10-27T22:18:20Z","updated_at":"2016-10-27T22:18:20Z","html_url":"https://github.com/servo/servo/pull/13924#discussion_r85439299","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13924","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/85439299"},"html":{"href":"https://github.com/servo/servo/pull/13924#discussion_r85439299"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13924"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13924","id":90908264,"html_url":"https://github.com/servo/servo/pull/13924","diff_url":"https://github.com/servo/servo/pull/13924.diff","patch_url":"https://github.com/servo/servo/pull/13924.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13924","number":13924,"state":"open","locked":false,"title":"implemented string-valued text-overflow","user":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #13709 \r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [X] These changes do not require tests\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\ncc @Manishearth \r\nThe lorem-ipsum example from MDN works as expected.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13924)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-10-25T23:01:49Z","updated_at":"2016-10-27T22:18:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bf2afd21a341f1e47044d855c8b0f483bcbc252","assignee":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"assignees":[{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13924/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13924/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13924/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/ccea58ea05fd2aa20446f517899cdf517e98e1b6","head":{"label":"cynicaldevil:text-overflow","ref":"text-overflow","sha":"ccea58ea05fd2aa20446f517899cdf517e98e1b6","user":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"repo":{"id":62301714,"name":"servo","full_name":"cynicaldevil/servo","owner":{"login":"cynicaldevil","id":11256206,"avatar_url":"https://avatars.githubusercontent.com/u/11256206?v=3","gravatar_id":"","url":"https://api.github.com/users/cynicaldevil","html_url":"https://github.com/cynicaldevil","followers_url":"https://api.github.com/users/cynicaldevil/followers","following_url":"https://api.github.com/users/cynicaldevil/following{/other_user}","gists_url":"https://api.github.com/users/cynicaldevil/gists{/gist_id}","starred_url":"https://api.github.com/users/cynicaldevil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynicaldevil/subscriptions","organizations_url":"https://api.github.com/users/cynicaldevil/orgs","repos_url":"https://api.github.com/users/cynicaldevil/repos","events_url":"https://api.github.com/users/cynicaldevil/events{/privacy}","received_events_url":"https://api.github.com/users/cynicaldevil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cynicaldevil/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/cynicaldevil/servo","forks_url":"https://api.github.com/repos/cynicaldevil/servo/forks","keys_url":"https://api.github.com/repos/cynicaldevil/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cynicaldevil/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cynicaldevil/servo/teams","hooks_url":"https://api.github.com/repos/cynicaldevil/servo/hooks","issue_events_url":"https://api.github.com/repos/cynicaldevil/servo/issues/events{/number}","events_url":"https://api.github.com/repos/cynicaldevil/servo/events","assignees_url":"https://api.github.com/repos/cynicaldevil/servo/assignees{/user}","branches_url":"https://api.github.com/repos/cynicaldevil/servo/branches{/branch}","tags_url":"https://api.github.com/repos/cynicaldevil/servo/tags","blobs_url":"https://api.github.com/repos/cynicaldevil/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cynicaldevil/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cynicaldevil/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/cynicaldevil/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cynicaldevil/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/cynicaldevil/servo/languages","stargazers_url":"https://api.github.com/repos/cynicaldevil/servo/stargazers","contributors_url":"https://api.github.com/repos/cynicaldevil/servo/contributors","subscribers_url":"https://api.github.com/repos/cynicaldevil/servo/subscribers","subscription_url":"https://api.github.com/repos/cynicaldevil/servo/subscription","commits_url":"https://api.github.com/repos/cynicaldevil/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/cynicaldevil/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/cynicaldevil/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/cynicaldevil/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/cynicaldevil/servo/contents/{+path}","compare_url":"https://api.github.com/repos/cynicaldevil/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cynicaldevil/servo/merges","archive_url":"https://api.github.com/repos/cynicaldevil/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cynicaldevil/servo/downloads","issues_url":"https://api.github.com/repos/cynicaldevil/servo/issues{/number}","pulls_url":"https://api.github.com/repos/cynicaldevil/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/cynicaldevil/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/cynicaldevil/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cynicaldevil/servo/labels{/name}","releases_url":"https://api.github.com/repos/cynicaldevil/servo/releases{/id}","deployments_url":"https://api.github.com/repos/cynicaldevil/servo/deployments","created_at":"2016-06-30T10:19:15Z","updated_at":"2016-06-30T09:18:38Z","pushed_at":"2016-10-25T22:58:27Z","git_url":"git://github.com/cynicaldevil/servo.git","ssh_url":"git@github.com:cynicaldevil/servo.git","clone_url":"https://github.com/cynicaldevil/servo.git","svn_url":"https://github.com/cynicaldevil/servo","homepage":"https://servo.org/","size":213403,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"c8321edc27ed7125181262e0341e66825951f634","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-27T18:33:13Z","pushed_at":"2016-10-27T21:49:06Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":304149,"stargazers_count":8137,"watchers_count":8137,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1327,"mirror_url":null,"open_issues_count":1861,"forks":1327,"open_issues":1861,"watchers":8137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13924"},"html":{"href":"https://github.com/servo/servo/pull/13924"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13924"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13924/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13924/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13924/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/ccea58ea05fd2aa20446f517899cdf517e98e1b6"}}}}
{"actor":{"display_login":"cynicaldevil"}}