{"action":"created","issue":{"url":"https://api.github.com/repos/friendica/friendica/issues/2806","repository_url":"https://api.github.com/repos/friendica/friendica","labels_url":"https://api.github.com/repos/friendica/friendica/issues/2806/labels{/name}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/2806/comments","events_url":"https://api.github.com/repos/friendica/friendica/issues/2806/events","html_url":"https://github.com/friendica/friendica/pull/2806","id":179806637,"number":2806,"title":"[frio] Increasing view width for desktop view","user":{"login":"Hypolite","id":925415,"avatar_url":"https://avatars.githubusercontent.com/u/925415?v=3","gravatar_id":"","url":"https://api.github.com/users/Hypolite","html_url":"https://github.com/Hypolite","followers_url":"https://api.github.com/users/Hypolite/followers","following_url":"https://api.github.com/users/Hypolite/following{/other_user}","gists_url":"https://api.github.com/users/Hypolite/gists{/gist_id}","starred_url":"https://api.github.com/users/Hypolite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hypolite/subscriptions","organizations_url":"https://api.github.com/users/Hypolite/orgs","repos_url":"https://api.github.com/users/Hypolite/repos","events_url":"https://api.github.com/users/Hypolite/events{/privacy}","received_events_url":"https://api.github.com/users/Hypolite/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-28T15:29:22Z","updated_at":"2016-09-28T17:32:20Z","closed_at":"2016-09-28T15:57:26Z","pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/2806","html_url":"https://github.com/friendica/friendica/pull/2806","diff_url":"https://github.com/friendica/friendica/pull/2806.diff","patch_url":"https://github.com/friendica/friendica/pull/2806.patch"},"body":"Lately, I've been frustrated with a couple of width-related points on the frio theme:\r\n- There is a large blank space on the right of the screen\r\n- Shared items have large left and right margins which compresses the shared content\r\n\r\nThis PR aims at solving both those issues. The changes aren't groundbreaking, but they saves a few scrolls when going through the stream.\r\n\r\nBefore:\r\n![screen shot 2016-09-28 at 11 17 48 am](https://cloud.githubusercontent.com/assets/925415/18920010/1f70482e-856e-11e6-8fc4-e964317a7b9c.png)\r\n\r\nAfter:\r\n![screen shot 2016-09-28 at 11 18 56 am](https://cloud.githubusercontent.com/assets/925415/18920020/2653c27e-856e-11e6-81e2-c5505fbdcb58.png)\r\n\r\nA couple of notes regarding the increased width of the center column:\r\n- The bootstrap grid has 12 divisions, however so far on desktop frio only used 10 of them (3 left + 10 center), and the right space wasn't preserved for the right aside, which is displayed on the left column under the left aside. I just reclaimed the missing 2 divisions.\r\n- Even when resizing the browser to extreme width, the content doesn't become unreadable with the change because the parent container has a fixed width."},"comment":{"url":"https://api.github.com/repos/friendica/friendica/issues/comments/250238861","html_url":"https://github.com/friendica/friendica/pull/2806#issuecomment-250238861","issue_url":"https://api.github.com/repos/friendica/friendica/issues/2806","id":250238861,"user":{"login":"rabuzarus","id":3750381,"avatar_url":"https://avatars.githubusercontent.com/u/3750381?v=3","gravatar_id":"","url":"https://api.github.com/users/rabuzarus","html_url":"https://github.com/rabuzarus","followers_url":"https://api.github.com/users/rabuzarus/followers","following_url":"https://api.github.com/users/rabuzarus/following{/other_user}","gists_url":"https://api.github.com/users/rabuzarus/gists{/gist_id}","starred_url":"https://api.github.com/users/rabuzarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabuzarus/subscriptions","organizations_url":"https://api.github.com/users/rabuzarus/orgs","repos_url":"https://api.github.com/users/rabuzarus/repos","events_url":"https://api.github.com/users/rabuzarus/events{/privacy}","received_events_url":"https://api.github.com/users/rabuzarus/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T17:32:20Z","updated_at":"2016-09-28T17:32:20Z","body":"@Hypolite \r\n>  I actually don't mind leaving the center column as is\r\n\r\nIm glad for that. You are right. With saying that twitter only use 140 characters but the most friendica comments doesn't have more characters. So you have to deal with different requirements. The blessing and the curse of friendica are its universality. This makes it hard for GUI developers. After starting Frio development I spent 2 weeks with comparing the other social networks and I tried a lot of width/font size combinations to get something which fits in the most cases. Sure you are right for very long articles the width is to small but this are not the most common posts.\r\n\r\n> My real gripe was with the share margins.\r\nI can understand it. The share margins aren't a good solution. This was something as a result from inspiration through facebook and how they present their shared content. But I'm not very happy with it.\r\n\r\nSome thoughts according to shared content:\r\nAt the present state a shared post is visually presented as a post in a post. Other themes use a horizontal line to make clear where the where the shared posts starts and ends (with some margins). Frio uses facebooks concept of frame (with margins). Both concepts aren't ideal. We need some good (-looking) solution how to we present this. Of how we make it distinguishable that the one is the post and the other the the shared content. Something which is a pleasure for the eyes without being annoying. I'm very open for new ideas and new concepts.\r\nI'm no fundamentalist if you want lower the margins. But this shouldn't be the end of ideas which we have for presenting shared post in Frio.\r\n\r\nBTW: we also need a good concept how to present event posts. They are really ugly and not that good noticeably \r\n"}}
{"actor":{"display_login":"rabuzarus"}}