{"action":"created","issue":{"url":"https://api.github.com/repos/m-lab/ndt/issues/55","repository_url":"https://api.github.com/repos/m-lab/ndt","labels_url":"https://api.github.com/repos/m-lab/ndt/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/m-lab/ndt/issues/55/comments","events_url":"https://api.github.com/repos/m-lab/ndt/issues/55/events","html_url":"https://github.com/m-lab/ndt/pull/55","id":154868231,"number":55,"title":"Separating Frontend and Backend Functionality in NDT HTML5 Client - Part 2","user":{"login":"shredtechular","id":2396774,"avatar_url":"https://avatars.githubusercontent.com/u/2396774?v=3","gravatar_id":"","url":"https://api.github.com/users/shredtechular","html_url":"https://github.com/shredtechular","followers_url":"https://api.github.com/users/shredtechular/followers","following_url":"https://api.github.com/users/shredtechular/following{/other_user}","gists_url":"https://api.github.com/users/shredtechular/gists{/gist_id}","starred_url":"https://api.github.com/users/shredtechular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shredtechular/subscriptions","organizations_url":"https://api.github.com/users/shredtechular/orgs","repos_url":"https://api.github.com/users/shredtechular/repos","events_url":"https://api.github.com/users/shredtechular/events{/privacy}","received_events_url":"https://api.github.com/users/shredtechular/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-14T18:20:29Z","updated_at":"2016-06-02T21:06:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/m-lab/ndt/pulls/55","html_url":"https://github.com/m-lab/ndt/pull/55","diff_url":"https://github.com/m-lab/ndt/pull/55.diff","patch_url":"https://github.com/m-lab/ndt/pull/55.patch"},"body":"**NOTE** - this PR is dependent on #54 and will need to be rebased after #54 is reviewed/accepted.\r\n\r\nPer feedback contained in #49 this PR is part 2 of spliting the changes in that PR into a more manageable PR.  This first PR contains additional cleanup of the script.js file adding in comments that follow [Google JS Code Style](https://google.github.io/styleguide/javascriptguide.xml).\r\n\r\nOnce #54 and this PR is merged, #49 can be closed.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/m-lab/ndt/55)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/m-lab/ndt/issues/comments/223422419","html_url":"https://github.com/m-lab/ndt/pull/55#issuecomment-223422419","issue_url":"https://api.github.com/repos/m-lab/ndt/issues/55","id":223422419,"user":{"login":"collina","id":582005,"avatar_url":"https://avatars.githubusercontent.com/u/582005?v=3","gravatar_id":"","url":"https://api.github.com/users/collina","html_url":"https://github.com/collina","followers_url":"https://api.github.com/users/collina/followers","following_url":"https://api.github.com/users/collina/following{/other_user}","gists_url":"https://api.github.com/users/collina/gists{/gist_id}","starred_url":"https://api.github.com/users/collina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/collina/subscriptions","organizations_url":"https://api.github.com/users/collina/orgs","repos_url":"https://api.github.com/users/collina/repos","events_url":"https://api.github.com/users/collina/events{/privacy}","received_events_url":"https://api.github.com/users/collina/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T21:06:03Z","updated_at":"2016-06-02T21:06:03Z","body":"Are all of this methods actually private that are specified as such (e.g. testStatus)? \n\n<details><summary><i>Previously, collina (Collin Anderson) wrote…</i></summary>\n> Aren't private variables typically denoted with prefixed underscores rather than appended ones? http://stackoverflow.com/questions/4484424/underscore-prefix-for-property-and-method-names-in-javascriptfe\n</details>\n\n\n---\n\n\n\n\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/m-lab/ndt/55#-:-KJHvtXJjD389ExERl_C:1554374217)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"collina"}}