{"action":"created","issue":{"url":"https://api.github.com/repos/lmatteis/redux-cycle-middleware/issues/6","repository_url":"https://api.github.com/repos/lmatteis/redux-cycle-middleware","labels_url":"https://api.github.com/repos/lmatteis/redux-cycle-middleware/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/lmatteis/redux-cycle-middleware/issues/6/comments","events_url":"https://api.github.com/repos/lmatteis/redux-cycle-middleware/issues/6/events","html_url":"https://github.com/lmatteis/redux-cycle-middleware/issues/6","id":196655113,"number":6,"title":"Support multiple stream libraries","user":{"login":"lmatteis","id":535442,"avatar_url":"https://avatars.githubusercontent.com/u/535442?v=3","gravatar_id":"","url":"https://api.github.com/users/lmatteis","html_url":"https://github.com/lmatteis","followers_url":"https://api.github.com/users/lmatteis/followers","following_url":"https://api.github.com/users/lmatteis/following{/other_user}","gists_url":"https://api.github.com/users/lmatteis/gists{/gist_id}","starred_url":"https://api.github.com/users/lmatteis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmatteis/subscriptions","organizations_url":"https://api.github.com/users/lmatteis/orgs","repos_url":"https://api.github.com/users/lmatteis/repos","events_url":"https://api.github.com/users/lmatteis/events{/privacy}","received_events_url":"https://api.github.com/users/lmatteis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-20T11:57:56Z","updated_at":"2016-12-21T14:42:39Z","closed_at":null,"body":"Currently `createCycleMiddleware()` decides which stream library to use and it defaults `xstream-run`. It would be nice to allow users to select which `run` method to call, hence which stream library to use - and our driver internally should support most common stream libs using `runStreamAdapter`. \r\n"},"comment":{"url":"https://api.github.com/repos/lmatteis/redux-cycle-middleware/issues/comments/268538945","html_url":"https://github.com/lmatteis/redux-cycle-middleware/issues/6#issuecomment-268538945","issue_url":"https://api.github.com/repos/lmatteis/redux-cycle-middleware/issues/6","id":268538945,"user":{"login":"lmatteis","id":535442,"avatar_url":"https://avatars.githubusercontent.com/u/535442?v=3","gravatar_id":"","url":"https://api.github.com/users/lmatteis","html_url":"https://github.com/lmatteis","followers_url":"https://api.github.com/users/lmatteis/followers","following_url":"https://api.github.com/users/lmatteis/following{/other_user}","gists_url":"https://api.github.com/users/lmatteis/gists{/gist_id}","starred_url":"https://api.github.com/users/lmatteis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmatteis/subscriptions","organizations_url":"https://api.github.com/users/lmatteis/orgs","repos_url":"https://api.github.com/users/lmatteis/repos","events_url":"https://api.github.com/users/lmatteis/events{/privacy}","received_events_url":"https://api.github.com/users/lmatteis/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T14:42:39Z","updated_at":"2016-12-21T14:42:39Z","body":"@goshakkk @nickbalestra I'm thinking of this:\r\n\r\n```js\r\n// `Cycle` can be xstream or rxjs or anything else\r\nvar output = Cycle.run(main, { ACTION: makeActionDriver(), STATE: makeStateDriver() })\r\nconst cycleMiddleware = createCycleMiddleware(output);\r\n```\r\n\r\nProblem is that the ACTION driver needs access to `store` so we need to create the drivers in the middleware (as it is now).\r\n\r\nMaybe we can just keep the API as it is, but add an extra arg to `createCycleMiddleware` which is the actual `run` method to use internally:\r\n\r\n```js\r\nimport {run} from '@cycle/xstream-run';\r\nconst cycleMiddleware = createCycleMiddleware(main, { HTTP: makeHTTPDriver() }, run);\r\n```\r\n\r\nThoughts?\r\n"}}
{"actor":{"display_login":"lmatteis"}}