{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments/69916590","id":69916590,"diff_hunk":"@@ -67,6 +69,29 @@ define(function (require) {\n                 );\n             });\n \n+            it('renders a table', function () {\n+                var engagementTimelineModel,\n+                    detailView;\n+\n+                engagementTimelineModel = new EngagementTimelineModel({\n+                    days: [{\n+                        date: '2016-01-01',\n+                        discussion_contributions: 1,\n+                        problems_attempted: 1,\n+                        problems_completed: 1,\n+                        videos_viewed: 1\n+                    }]\n+                });\n+                detailView = new LearnerDetailView({\n+                    learnerModel: new LearnerModel(),\n+                    engagementTimelineModel: engagementTimelineModel,\n+                    el: fixtureClass\n+                });\n+                detailView.render().onBeforeShow();\n+                expect(detailView.$('.table-loading-container')).not.toExist();\n+                expect(detailView.$('.learner-engagement-table')).toExist();","path":"analytics_dashboard/static/apps/learners/detail/views/spec/learner-detail-spec.js","position":36,"original_position":36,"commit_id":"1c901c53fe82b8b972bcfbecc42785a3625059b0","original_commit_id":"1c901c53fe82b8b972bcfbecc42785a3625059b0","user":{"login":"dsjen","id":5265058,"avatar_url":"https://avatars.githubusercontent.com/u/5265058?v=3","gravatar_id":"","url":"https://api.github.com/users/dsjen","html_url":"https://github.com/dsjen","followers_url":"https://api.github.com/users/dsjen/followers","following_url":"https://api.github.com/users/dsjen/following{/other_user}","gists_url":"https://api.github.com/users/dsjen/gists{/gist_id}","starred_url":"https://api.github.com/users/dsjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsjen/subscriptions","organizations_url":"https://api.github.com/users/dsjen/orgs","repos_url":"https://api.github.com/users/dsjen/repos","events_url":"https://api.github.com/users/dsjen/events{/privacy}","received_events_url":"https://api.github.com/users/dsjen/received_events","type":"User","site_admin":false},"body":"Excellent test!","created_at":"2016-07-07T14:28:00Z","updated_at":"2016-07-07T14:28:00Z","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/502#discussion_r69916590","pull_request_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments/69916590"},"html":{"href":"https://github.com/edx/edx-analytics-dashboard/pull/502#discussion_r69916590"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502","id":76329749,"html_url":"https://github.com/edx/edx-analytics-dashboard/pull/502","diff_url":"https://github.com/edx/edx-analytics-dashboard/pull/502.diff","patch_url":"https://github.com/edx/edx-analytics-dashboard/pull/502.patch","issue_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/502","number":502,"state":"open","locked":false,"title":"Ajpal/a11y","user":{"login":"ajpal","id":8787187,"avatar_url":"https://avatars.githubusercontent.com/u/8787187?v=3","gravatar_id":"","url":"https://api.github.com/users/ajpal","html_url":"https://github.com/ajpal","followers_url":"https://api.github.com/users/ajpal/followers","following_url":"https://api.github.com/users/ajpal/following{/other_user}","gists_url":"https://api.github.com/users/ajpal/gists{/gist_id}","starred_url":"https://api.github.com/users/ajpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajpal/subscriptions","organizations_url":"https://api.github.com/users/ajpal/orgs","repos_url":"https://api.github.com/users/ajpal/repos","events_url":"https://api.github.com/users/ajpal/events{/privacy}","received_events_url":"https://api.github.com/users/ajpal/received_events","type":"User","site_admin":false},"body":"@dsjen @thallada @lamagnifica \r\n\r\nThis adds a data table beneath the chart on the learner detail page, similar to the table below the chart on the enrollment page, which increases accessibility for users who cannot use the chart.\r\n\r\n![screen shot 2016-07-06 at 10 47 35 am](https://cloud.githubusercontent.com/assets/8787187/16622167/1d2eba3a-4367-11e6-901a-c9b49510759e.png)\r\n","created_at":"2016-07-05T19:34:26Z","updated_at":"2016-07-07T14:28:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11609672e86773958673feff478370e124a3dbc5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502/commits","review_comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502/comments","review_comment_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/502/comments","statuses_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/1c901c53fe82b8b972bcfbecc42785a3625059b0","head":{"label":"edx:ajpal/a11y","ref":"ajpal/a11y","sha":"1c901c53fe82b8b972bcfbecc42785a3625059b0","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":20941273,"name":"edx-analytics-dashboard","full_name":"edx/edx-analytics-dashboard","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-analytics-dashboard","description":"Dashboard to display course analytics to course teams","fork":false,"url":"https://api.github.com/repos/edx/edx-analytics-dashboard","forks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/forks","keys_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/teams","hooks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/events","assignees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/tags","blobs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/languages","stargazers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscription","commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/merges","archive_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/downloads","issues_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/deployments","created_at":"2014-06-17T22:14:33Z","updated_at":"2016-06-19T11:19:25Z","pushed_at":"2016-07-07T14:14:42Z","git_url":"git://github.com/edx/edx-analytics-dashboard.git","ssh_url":"git@github.com:edx/edx-analytics-dashboard.git","clone_url":"https://github.com/edx/edx-analytics-dashboard.git","svn_url":"https://github.com/edx/edx-analytics-dashboard","homepage":null,"size":17568,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":6,"forks":44,"open_issues":6,"watchers":26,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"019e209bf847168357d447089df3be4e02a9dba1","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":20941273,"name":"edx-analytics-dashboard","full_name":"edx/edx-analytics-dashboard","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-analytics-dashboard","description":"Dashboard to display course analytics to course teams","fork":false,"url":"https://api.github.com/repos/edx/edx-analytics-dashboard","forks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/forks","keys_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/teams","hooks_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/events","assignees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/tags","blobs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/languages","stargazers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/subscription","commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/merges","archive_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/downloads","issues_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/deployments","created_at":"2014-06-17T22:14:33Z","updated_at":"2016-06-19T11:19:25Z","pushed_at":"2016-07-07T14:14:42Z","git_url":"git://github.com/edx/edx-analytics-dashboard.git","ssh_url":"git@github.com:edx/edx-analytics-dashboard.git","clone_url":"https://github.com/edx/edx-analytics-dashboard.git","svn_url":"https://github.com/edx/edx-analytics-dashboard","homepage":null,"size":17568,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":6,"forks":44,"open_issues":6,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502"},"html":{"href":"https://github.com/edx/edx-analytics-dashboard/pull/502"},"issue":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/502"},"comments":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/502/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/502/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-analytics-dashboard/statuses/1c901c53fe82b8b972bcfbecc42785a3625059b0"}}}}
{"actor":{"display_login":"dsjen"}}