{"action":"created","comment":{"url":"https://api.github.com/repos/TuneLab/go-truss/pulls/comments/90739582","pull_request_review_id":11260626,"id":90739582,"diff_hunk":"@@ -23,7 +23,9 @@ import (\n // NewService is an exported func that creates a new service\n // it will not be defined in the service definition but is required\n const ignoredFunc = \"NewService\"\n-const serverTemplPath = \"NAME-service/handlers/server/server_handler.gotemplate\"\n+\n+// ServerFile is the path to the service handelr file that handler will render","path":"gengokit/handler/handler.go","position":null,"original_position":6,"commit_id":"58db2c16912d1259ec9adf84515f3a09af5ed240","original_commit_id":"926895c623fa7b1c53c1ae562fcc255233013729","user":{"login":"hasAdamr","id":19537819,"avatar_url":"https://avatars.githubusercontent.com/u/19537819?v=3","gravatar_id":"","url":"https://api.github.com/users/hasAdamr","html_url":"https://github.com/hasAdamr","followers_url":"https://api.github.com/users/hasAdamr/followers","following_url":"https://api.github.com/users/hasAdamr/following{/other_user}","gists_url":"https://api.github.com/users/hasAdamr/gists{/gist_id}","starred_url":"https://api.github.com/users/hasAdamr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasAdamr/subscriptions","organizations_url":"https://api.github.com/users/hasAdamr/orgs","repos_url":"https://api.github.com/users/hasAdamr/repos","events_url":"https://api.github.com/users/hasAdamr/events{/privacy}","received_events_url":"https://api.github.com/users/hasAdamr/received_events","type":"User","site_admin":false},"body":"I went with `ServerHandlerPath`.","created_at":"2016-12-02T23:44:56Z","updated_at":"2016-12-02T23:44:56Z","html_url":"https://github.com/TuneLab/go-truss/pull/101#discussion_r90739582","pull_request_url":"https://api.github.com/repos/TuneLab/go-truss/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/TuneLab/go-truss/pulls/comments/90739582"},"html":{"href":"https://github.com/TuneLab/go-truss/pull/101#discussion_r90739582"},"pull_request":{"href":"https://api.github.com/repos/TuneLab/go-truss/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/TuneLab/go-truss/pulls/101","id":95485374,"html_url":"https://github.com/TuneLab/go-truss/pull/101","diff_url":"https://github.com/TuneLab/go-truss/pull/101.diff","patch_url":"https://github.com/TuneLab/go-truss/pull/101.patch","issue_url":"https://api.github.com/repos/TuneLab/go-truss/issues/101","number":101,"state":"open","locked":false,"title":"Refactor names and tests in preperation for middleware addition","user":{"login":"hasAdamr","id":19537819,"avatar_url":"https://avatars.githubusercontent.com/u/19537819?v=3","gravatar_id":"","url":"https://api.github.com/users/hasAdamr","html_url":"https://github.com/hasAdamr","followers_url":"https://api.github.com/users/hasAdamr/followers","following_url":"https://api.github.com/users/hasAdamr/following{/other_user}","gists_url":"https://api.github.com/users/hasAdamr/gists{/gist_id}","starred_url":"https://api.github.com/users/hasAdamr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasAdamr/subscriptions","organizations_url":"https://api.github.com/users/hasAdamr/orgs","repos_url":"https://api.github.com/users/hasAdamr/repos","events_url":"https://api.github.com/users/hasAdamr/events{/privacy}","received_events_url":"https://api.github.com/users/hasAdamr/received_events","type":"User","site_admin":false},"body":"This refactor pull request is intended to separate out some reorganizing done to add middlewares. **No functional change.**\r\n\r\n### Main points\r\n- `gengokit.TemplateExecutor` renamed to `gengokit.Executor` as well as a rename to `gengokit.NewTemplateExecutor` to what you would expect. This creates a big part of the diff.\r\n- `generateResponseFile` now takes the previous version of the file rather than a map of strings to all files, separating out the concern of finding getting the old file. \r\n- `ApplyTemplate` helper methods have been added to `gengokit` and package `handler` now uses these to apply its templates rather than every package reimplementing it. Package `middlewares` will also use this.\r\n- Package `handler` now exports the file it renders as a constant and the `generator` package switches on that constant rather than it being defined in two places.","created_at":"2016-11-28T11:56:41Z","updated_at":"2016-12-02T23:44:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12a1e035f3356acb0cf96b37891c44577b4923bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TuneLab/go-truss/pulls/101/commits","review_comments_url":"https://api.github.com/repos/TuneLab/go-truss/pulls/101/comments","review_comment_url":"https://api.github.com/repos/TuneLab/go-truss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TuneLab/go-truss/issues/101/comments","statuses_url":"https://api.github.com/repos/TuneLab/go-truss/statuses/58db2c16912d1259ec9adf84515f3a09af5ed240","head":{"label":"hasAdamr:executor-rename","ref":"executor-rename","sha":"58db2c16912d1259ec9adf84515f3a09af5ed240","user":{"login":"hasAdamr","id":19537819,"avatar_url":"https://avatars.githubusercontent.com/u/19537819?v=3","gravatar_id":"","url":"https://api.github.com/users/hasAdamr","html_url":"https://github.com/hasAdamr","followers_url":"https://api.github.com/users/hasAdamr/followers","following_url":"https://api.github.com/users/hasAdamr/following{/other_user}","gists_url":"https://api.github.com/users/hasAdamr/gists{/gist_id}","starred_url":"https://api.github.com/users/hasAdamr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasAdamr/subscriptions","organizations_url":"https://api.github.com/users/hasAdamr/orgs","repos_url":"https://api.github.com/users/hasAdamr/repos","events_url":"https://api.github.com/users/hasAdamr/events{/privacy}","received_events_url":"https://api.github.com/users/hasAdamr/received_events","type":"User","site_admin":false},"repo":{"id":66120508,"name":"go-truss","full_name":"hasAdamr/go-truss","owner":{"login":"hasAdamr","id":19537819,"avatar_url":"https://avatars.githubusercontent.com/u/19537819?v=3","gravatar_id":"","url":"https://api.github.com/users/hasAdamr","html_url":"https://github.com/hasAdamr","followers_url":"https://api.github.com/users/hasAdamr/followers","following_url":"https://api.github.com/users/hasAdamr/following{/other_user}","gists_url":"https://api.github.com/users/hasAdamr/gists{/gist_id}","starred_url":"https://api.github.com/users/hasAdamr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hasAdamr/subscriptions","organizations_url":"https://api.github.com/users/hasAdamr/orgs","repos_url":"https://api.github.com/users/hasAdamr/repos","events_url":"https://api.github.com/users/hasAdamr/events{/privacy}","received_events_url":"https://api.github.com/users/hasAdamr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hasAdamr/go-truss","description":"Truss helps you build go-kit microservices without having to worry about writing or maintaining boilerplate code.","fork":true,"url":"https://api.github.com/repos/hasAdamr/go-truss","forks_url":"https://api.github.com/repos/hasAdamr/go-truss/forks","keys_url":"https://api.github.com/repos/hasAdamr/go-truss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hasAdamr/go-truss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hasAdamr/go-truss/teams","hooks_url":"https://api.github.com/repos/hasAdamr/go-truss/hooks","issue_events_url":"https://api.github.com/repos/hasAdamr/go-truss/issues/events{/number}","events_url":"https://api.github.com/repos/hasAdamr/go-truss/events","assignees_url":"https://api.github.com/repos/hasAdamr/go-truss/assignees{/user}","branches_url":"https://api.github.com/repos/hasAdamr/go-truss/branches{/branch}","tags_url":"https://api.github.com/repos/hasAdamr/go-truss/tags","blobs_url":"https://api.github.com/repos/hasAdamr/go-truss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hasAdamr/go-truss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hasAdamr/go-truss/git/refs{/sha}","trees_url":"https://api.github.com/repos/hasAdamr/go-truss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hasAdamr/go-truss/statuses/{sha}","languages_url":"https://api.github.com/repos/hasAdamr/go-truss/languages","stargazers_url":"https://api.github.com/repos/hasAdamr/go-truss/stargazers","contributors_url":"https://api.github.com/repos/hasAdamr/go-truss/contributors","subscribers_url":"https://api.github.com/repos/hasAdamr/go-truss/subscribers","subscription_url":"https://api.github.com/repos/hasAdamr/go-truss/subscription","commits_url":"https://api.github.com/repos/hasAdamr/go-truss/commits{/sha}","git_commits_url":"https://api.github.com/repos/hasAdamr/go-truss/git/commits{/sha}","comments_url":"https://api.github.com/repos/hasAdamr/go-truss/comments{/number}","issue_comment_url":"https://api.github.com/repos/hasAdamr/go-truss/issues/comments{/number}","contents_url":"https://api.github.com/repos/hasAdamr/go-truss/contents/{+path}","compare_url":"https://api.github.com/repos/hasAdamr/go-truss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hasAdamr/go-truss/merges","archive_url":"https://api.github.com/repos/hasAdamr/go-truss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hasAdamr/go-truss/downloads","issues_url":"https://api.github.com/repos/hasAdamr/go-truss/issues{/number}","pulls_url":"https://api.github.com/repos/hasAdamr/go-truss/pulls{/number}","milestones_url":"https://api.github.com/repos/hasAdamr/go-truss/milestones{/number}","notifications_url":"https://api.github.com/repos/hasAdamr/go-truss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hasAdamr/go-truss/labels{/name}","releases_url":"https://api.github.com/repos/hasAdamr/go-truss/releases{/id}","deployments_url":"https://api.github.com/repos/hasAdamr/go-truss/deployments","created_at":"2016-08-20T00:38:18Z","updated_at":"2016-08-20T00:38:20Z","pushed_at":"2016-12-02T23:44:44Z","git_url":"git://github.com/hasAdamr/go-truss.git","ssh_url":"git@github.com:hasAdamr/go-truss.git","clone_url":"https://github.com/hasAdamr/go-truss.git","svn_url":"https://github.com/hasAdamr/go-truss","homepage":"","size":10438,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TuneLab:master","ref":"master","sha":"5924b77e114a436a5bd3d621ace0df4ac9399e12","user":{"login":"TuneLab","id":12895637,"avatar_url":"https://avatars.githubusercontent.com/u/12895637?v=3","gravatar_id":"","url":"https://api.github.com/users/TuneLab","html_url":"https://github.com/TuneLab","followers_url":"https://api.github.com/users/TuneLab/followers","following_url":"https://api.github.com/users/TuneLab/following{/other_user}","gists_url":"https://api.github.com/users/TuneLab/gists{/gist_id}","starred_url":"https://api.github.com/users/TuneLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuneLab/subscriptions","organizations_url":"https://api.github.com/users/TuneLab/orgs","repos_url":"https://api.github.com/users/TuneLab/repos","events_url":"https://api.github.com/users/TuneLab/events{/privacy}","received_events_url":"https://api.github.com/users/TuneLab/received_events","type":"Organization","site_admin":false},"repo":{"id":61059364,"name":"go-truss","full_name":"TuneLab/go-truss","owner":{"login":"TuneLab","id":12895637,"avatar_url":"https://avatars.githubusercontent.com/u/12895637?v=3","gravatar_id":"","url":"https://api.github.com/users/TuneLab","html_url":"https://github.com/TuneLab","followers_url":"https://api.github.com/users/TuneLab/followers","following_url":"https://api.github.com/users/TuneLab/following{/other_user}","gists_url":"https://api.github.com/users/TuneLab/gists{/gist_id}","starred_url":"https://api.github.com/users/TuneLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TuneLab/subscriptions","organizations_url":"https://api.github.com/users/TuneLab/orgs","repos_url":"https://api.github.com/users/TuneLab/repos","events_url":"https://api.github.com/users/TuneLab/events{/privacy}","received_events_url":"https://api.github.com/users/TuneLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TuneLab/go-truss","description":"Truss helps you build go-kit microservices without having to worry about writing or maintaining boilerplate code.","fork":false,"url":"https://api.github.com/repos/TuneLab/go-truss","forks_url":"https://api.github.com/repos/TuneLab/go-truss/forks","keys_url":"https://api.github.com/repos/TuneLab/go-truss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TuneLab/go-truss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TuneLab/go-truss/teams","hooks_url":"https://api.github.com/repos/TuneLab/go-truss/hooks","issue_events_url":"https://api.github.com/repos/TuneLab/go-truss/issues/events{/number}","events_url":"https://api.github.com/repos/TuneLab/go-truss/events","assignees_url":"https://api.github.com/repos/TuneLab/go-truss/assignees{/user}","branches_url":"https://api.github.com/repos/TuneLab/go-truss/branches{/branch}","tags_url":"https://api.github.com/repos/TuneLab/go-truss/tags","blobs_url":"https://api.github.com/repos/TuneLab/go-truss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TuneLab/go-truss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TuneLab/go-truss/git/refs{/sha}","trees_url":"https://api.github.com/repos/TuneLab/go-truss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TuneLab/go-truss/statuses/{sha}","languages_url":"https://api.github.com/repos/TuneLab/go-truss/languages","stargazers_url":"https://api.github.com/repos/TuneLab/go-truss/stargazers","contributors_url":"https://api.github.com/repos/TuneLab/go-truss/contributors","subscribers_url":"https://api.github.com/repos/TuneLab/go-truss/subscribers","subscription_url":"https://api.github.com/repos/TuneLab/go-truss/subscription","commits_url":"https://api.github.com/repos/TuneLab/go-truss/commits{/sha}","git_commits_url":"https://api.github.com/repos/TuneLab/go-truss/git/commits{/sha}","comments_url":"https://api.github.com/repos/TuneLab/go-truss/comments{/number}","issue_comment_url":"https://api.github.com/repos/TuneLab/go-truss/issues/comments{/number}","contents_url":"https://api.github.com/repos/TuneLab/go-truss/contents/{+path}","compare_url":"https://api.github.com/repos/TuneLab/go-truss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TuneLab/go-truss/merges","archive_url":"https://api.github.com/repos/TuneLab/go-truss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TuneLab/go-truss/downloads","issues_url":"https://api.github.com/repos/TuneLab/go-truss/issues{/number}","pulls_url":"https://api.github.com/repos/TuneLab/go-truss/pulls{/number}","milestones_url":"https://api.github.com/repos/TuneLab/go-truss/milestones{/number}","notifications_url":"https://api.github.com/repos/TuneLab/go-truss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TuneLab/go-truss/labels{/name}","releases_url":"https://api.github.com/repos/TuneLab/go-truss/releases{/id}","deployments_url":"https://api.github.com/repos/TuneLab/go-truss/deployments","created_at":"2016-06-13T18:18:25Z","updated_at":"2016-11-27T16:39:46Z","pushed_at":"2016-12-02T23:44:44Z","git_url":"git://github.com/TuneLab/go-truss.git","ssh_url":"git@github.com:TuneLab/go-truss.git","clone_url":"https://github.com/TuneLab/go-truss.git","svn_url":"https://github.com/TuneLab/go-truss","homepage":"","size":10531,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TuneLab/go-truss/pulls/101"},"html":{"href":"https://github.com/TuneLab/go-truss/pull/101"},"issue":{"href":"https://api.github.com/repos/TuneLab/go-truss/issues/101"},"comments":{"href":"https://api.github.com/repos/TuneLab/go-truss/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/TuneLab/go-truss/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/TuneLab/go-truss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TuneLab/go-truss/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/TuneLab/go-truss/statuses/58db2c16912d1259ec9adf84515f3a09af5ed240"}}}}
{"actor":{"display_login":"hasAdamr"}}