{"action":"created","issue":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/2154","repository_url":"https://api.github.com/repos/sakaiproject/sakai","labels_url":"https://api.github.com/repos/sakaiproject/sakai/issues/2154/labels{/name}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/2154/comments","events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/2154/events","html_url":"https://github.com/sakaiproject/sakai/pull/2154","id":146648377,"number":2154,"title":"SAM-2801 samigo email notification needs a default value","user":{"login":"bjones86","id":10403943,"avatar_url":"https://avatars.githubusercontent.com/u/10403943?v=3","gravatar_id":"","url":"https://api.github.com/users/bjones86","html_url":"https://github.com/bjones86","followers_url":"https://api.github.com/users/bjones86/followers","following_url":"https://api.github.com/users/bjones86/following{/other_user}","gists_url":"https://api.github.com/users/bjones86/gists{/gist_id}","starred_url":"https://api.github.com/users/bjones86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjones86/subscriptions","organizations_url":"https://api.github.com/users/bjones86/orgs","repos_url":"https://api.github.com/users/bjones86/repos","events_url":"https://api.github.com/users/bjones86/events{/privacy}","received_events_url":"https://api.github.com/users/bjones86/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sakaiproject/sakai/labels/sakai-11","name":"sakai-11","color":"f7c6c7"},{"url":"https://api.github.com/repos/sakaiproject/sakai/labels/sakai-12","name":"sakai-12","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-07T14:48:51Z","updated_at":"2016-04-07T14:52:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/2154","html_url":"https://github.com/sakaiproject/sakai/pull/2154","diff_url":"https://github.com/sakaiproject/sakai/pull/2154.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/2154.patch"},"body":"https://jira.sakaiproject.org/browse/SAM-2801\r\n\r\nThe new email notification feature for Tests & Quizzes adds radio buttons to the settings but does not provide a default. This presents an error to the user if they do not select one before saving their settings.\r\n\r\nPre-select the \"No\" option to default to the current state (Samigo sends no emails to the instructor). If instructors want to be inundated with submission emails they should opt-in to this behaviour.\r\n\r\nCleaned up the files while I was in there, mostly removing un-necessary boxing/unboxing, redundant if/else statements. The actual change of note here to implement the default selection is the following:\r\n\r\n`private String instructorNotification = \"1\";  // Default is 'No - I do not want to receive any emails';`"},"comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments/206940046","html_url":"https://github.com/sakaiproject/sakai/pull/2154#issuecomment-206940046","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/2154","id":206940046,"user":{"login":"ottenhoff","id":810505,"avatar_url":"https://avatars.githubusercontent.com/u/810505?v=3","gravatar_id":"","url":"https://api.github.com/users/ottenhoff","html_url":"https://github.com/ottenhoff","followers_url":"https://api.github.com/users/ottenhoff/followers","following_url":"https://api.github.com/users/ottenhoff/following{/other_user}","gists_url":"https://api.github.com/users/ottenhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ottenhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottenhoff/subscriptions","organizations_url":"https://api.github.com/users/ottenhoff/orgs","repos_url":"https://api.github.com/users/ottenhoff/repos","events_url":"https://api.github.com/users/ottenhoff/events{/privacy}","received_events_url":"https://api.github.com/users/ottenhoff/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T14:52:52Z","updated_at":"2016-04-07T14:52:52Z","body":"LGTM"}}