{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments/68334379","id":68334379,"diff_hunk":"@@ -1,9 +1,43 @@\n ---\n-- name: Update authorized_keys for each user.\n+- name: Merge managed_users and managed_admin users\n+  set_fact:\n+    pubkey_users: \"{{ managed_users|list + managed_admin_users|list }}\"\n+\n+# The following set_fact calls are apparently necessary to avoid using sudo on\n+# localhost to clone the keys repo.\n+- set_fact:\n+    ansible_become_orig: \"{{ ansible_become }}\"\n+\n+- set_fact:\n+    ansible_become: false\n+\n+- name: Clone the keys repo","path":"roles/users/tasks/update_keys.yml","position":14,"original_position":15,"commit_id":"4e8169b326567289a0ea8a5dce3ae2e283897241","original_commit_id":"04bd03038c5569b34761e71225475738fe770dc2","user":{"login":"dmick","id":1350673,"avatar_url":"https://avatars.githubusercontent.com/u/1350673?v=3","gravatar_id":"","url":"https://api.github.com/users/dmick","html_url":"https://github.com/dmick","followers_url":"https://api.github.com/users/dmick/followers","following_url":"https://api.github.com/users/dmick/following{/other_user}","gists_url":"https://api.github.com/users/dmick/gists{/gist_id}","starred_url":"https://api.github.com/users/dmick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmick/subscriptions","organizations_url":"https://api.github.com/users/dmick/orgs","repos_url":"https://api.github.com/users/dmick/repos","events_url":"https://api.github.com/users/dmick/events{/privacy}","received_events_url":"https://api.github.com/users/dmick/received_events","type":"User","site_admin":false},"body":"agreed.","created_at":"2016-06-23T23:42:33Z","updated_at":"2016-06-23T23:42:33Z","html_url":"https://github.com/ceph/ceph-cm-ansible/pull/253#discussion_r68334379","pull_request_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments/68334379"},"html":{"href":"https://github.com/ceph/ceph-cm-ansible/pull/253#discussion_r68334379"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253","id":75041300,"html_url":"https://github.com/ceph/ceph-cm-ansible/pull/253","diff_url":"https://github.com/ceph/ceph-cm-ansible/pull/253.diff","patch_url":"https://github.com/ceph/ceph-cm-ansible/pull/253.patch","issue_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/253","number":253,"state":"open","locked":false,"title":"users: Greatly speed up ssh pubkey deployment","user":{"login":"zmc","id":58307,"avatar_url":"https://avatars.githubusercontent.com/u/58307?v=3","gravatar_id":"","url":"https://api.github.com/users/zmc","html_url":"https://github.com/zmc","followers_url":"https://api.github.com/users/zmc/followers","following_url":"https://api.github.com/users/zmc/following{/other_user}","gists_url":"https://api.github.com/users/zmc/gists{/gist_id}","starred_url":"https://api.github.com/users/zmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmc/subscriptions","organizations_url":"https://api.github.com/users/zmc/orgs","repos_url":"https://api.github.com/users/zmc/repos","events_url":"https://api.github.com/users/zmc/events{/privacy}","received_events_url":"https://api.github.com/users/zmc/received_events","type":"User","site_admin":false},"body":"The speedup depends on changes like https://github.com/ceph/ceph-sepia-secrets/pull/135 - but this PR won't break the current behavior","created_at":"2016-06-23T23:00:13Z","updated_at":"2016-06-23T23:42:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51948b8834a0336262e45fec3e4fa47791c38bda","assignee":{"login":"dmick","id":1350673,"avatar_url":"https://avatars.githubusercontent.com/u/1350673?v=3","gravatar_id":"","url":"https://api.github.com/users/dmick","html_url":"https://github.com/dmick","followers_url":"https://api.github.com/users/dmick/followers","following_url":"https://api.github.com/users/dmick/following{/other_user}","gists_url":"https://api.github.com/users/dmick/gists{/gist_id}","starred_url":"https://api.github.com/users/dmick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmick/subscriptions","organizations_url":"https://api.github.com/users/dmick/orgs","repos_url":"https://api.github.com/users/dmick/repos","events_url":"https://api.github.com/users/dmick/events{/privacy}","received_events_url":"https://api.github.com/users/dmick/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmick","id":1350673,"avatar_url":"https://avatars.githubusercontent.com/u/1350673?v=3","gravatar_id":"","url":"https://api.github.com/users/dmick","html_url":"https://github.com/dmick","followers_url":"https://api.github.com/users/dmick/followers","following_url":"https://api.github.com/users/dmick/following{/other_user}","gists_url":"https://api.github.com/users/dmick/gists{/gist_id}","starred_url":"https://api.github.com/users/dmick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmick/subscriptions","organizations_url":"https://api.github.com/users/dmick/orgs","repos_url":"https://api.github.com/users/dmick/repos","events_url":"https://api.github.com/users/dmick/events{/privacy}","received_events_url":"https://api.github.com/users/dmick/received_events","type":"User","site_admin":false},{"login":"djgalloway","id":11281208,"avatar_url":"https://avatars.githubusercontent.com/u/11281208?v=3","gravatar_id":"","url":"https://api.github.com/users/djgalloway","html_url":"https://github.com/djgalloway","followers_url":"https://api.github.com/users/djgalloway/followers","following_url":"https://api.github.com/users/djgalloway/following{/other_user}","gists_url":"https://api.github.com/users/djgalloway/gists{/gist_id}","starred_url":"https://api.github.com/users/djgalloway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djgalloway/subscriptions","organizations_url":"https://api.github.com/users/djgalloway/orgs","repos_url":"https://api.github.com/users/djgalloway/repos","events_url":"https://api.github.com/users/djgalloway/events{/privacy}","received_events_url":"https://api.github.com/users/djgalloway/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/253/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/4e8169b326567289a0ea8a5dce3ae2e283897241","head":{"label":"ceph:wip-fast-keys","ref":"wip-fast-keys","sha":"4e8169b326567289a0ea8a5dce3ae2e283897241","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":34542634,"name":"ceph-cm-ansible","full_name":"ceph/ceph-cm-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-cm-ansible","description":"Ansible configurations for Ceph.com infrastructure","fork":false,"url":"https://api.github.com/repos/ceph/ceph-cm-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/deployments","created_at":"2015-04-24T21:24:55Z","updated_at":"2016-06-03T22:34:24Z","pushed_at":"2016-06-23T23:26:35Z","git_url":"git://github.com/ceph/ceph-cm-ansible.git","ssh_url":"git@github.com:ceph/ceph-cm-ansible.git","clone_url":"https://github.com/ceph/ceph-cm-ansible.git","svn_url":"https://github.com/ceph/ceph-cm-ansible","homepage":"","size":2050,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":6,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"69d71b7eb295911cea1014ac091a3a1976f1a5b2","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":34542634,"name":"ceph-cm-ansible","full_name":"ceph/ceph-cm-ansible","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-cm-ansible","description":"Ansible configurations for Ceph.com infrastructure","fork":false,"url":"https://api.github.com/repos/ceph/ceph-cm-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-cm-ansible/deployments","created_at":"2015-04-24T21:24:55Z","updated_at":"2016-06-03T22:34:24Z","pushed_at":"2016-06-23T23:26:35Z","git_url":"git://github.com/ceph/ceph-cm-ansible.git","ssh_url":"git@github.com:ceph/ceph-cm-ansible.git","clone_url":"https://github.com/ceph/ceph-cm-ansible.git","svn_url":"https://github.com/ceph/ceph-cm-ansible","homepage":"","size":2050,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":8,"forks":15,"open_issues":8,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253"},"html":{"href":"https://github.com/ceph/ceph-cm-ansible/pull/253"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/253"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-cm-ansible/statuses/4e8169b326567289a0ea8a5dce3ae2e283897241"}}}}
{"actor":{"display_login":"dmick"}}