{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8491","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8491/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8491/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8491/events","html_url":"https://github.com/nodejs/node/pull/8491","id":176241182,"number":8491,"title":"Make it build using openssl 1.1.0","user":{"login":"kroeckx","id":1616242,"avatar_url":"https://avatars.githubusercontent.com/u/1616242?v=3","gravatar_id":"","url":"https://api.github.com/users/kroeckx","html_url":"https://github.com/kroeckx","followers_url":"https://api.github.com/users/kroeckx/followers","following_url":"https://api.github.com/users/kroeckx/following{/other_user}","gists_url":"https://api.github.com/users/kroeckx/gists{/gist_id}","starred_url":"https://api.github.com/users/kroeckx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroeckx/subscriptions","organizations_url":"https://api.github.com/users/kroeckx/orgs","repos_url":"https://api.github.com/users/kroeckx/repos","events_url":"https://api.github.com/users/kroeckx/events{/privacy}","received_events_url":"https://api.github.com/users/kroeckx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21"},{"url":"https://api.github.com/repos/nodejs/node/labels/openssl","name":"openssl","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-11T12:21:11Z","updated_at":"2016-09-11T18:13:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8491","html_url":"https://github.com/nodejs/node/pull/8491","diff_url":"https://github.com/nodejs/node/pull/8491.diff","patch_url":"https://github.com/nodejs/node/pull/8491.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [ ] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ncrypto\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\nThis is to make it possible to build against OpenSSL 1.1.0 (#4270)\r\n\r\nIt currently has 2 new test failures when build against 1.0.2, because OpenSSL generates a different error message in 1.0.2 and 1.1.0.  I'm not sure how to deal with that.\r\n\r\nIn test/parallel/test-crypto.js the message is changed from \"asn1 encoding routines:ASN1_CHECK_TLEN:wrong tag\" to \"asn1 encoding routines:asn1_check_tlen:wrong tag\".  (The function name in openssl got renamed from all capital letters to small letters.)\r\n\r\nIn test/parallel/test-tls-junk-server.js, the error message changed from \"/unknown protocol/\" to \"/wrong version number/\".\r\n\r\nIt also fixes 3 current issues with the test suite against the 1.0.2 version.\r\n\r\nWhen building against the 1.1.0 version there are various tests that fail.  There are a total of 11 test failures.\r\n\r\nSome tests assumes the TLS ticket is 48 bytes.  This was always just an implementation details and you could already ask OpenSSL what the size was.  The encryption got changed from AES128 to AES256 in 1.1.0 and so the size changed. I have no idea how to get that size to the right places in the test suite.\r\n\r\nSome of the other failures are related to ciphers that are disabled by default.  For instance anonymous ciphers like AECDH are disabled and you need to enable them by selecting a different security level, which can for instance be done by adding `@SECLEVEL=0` to the cipher list, but that's not compatible with the 1.0.x version.  Ciphers like 3DES and RC4 are disabled by default.\r\n\r\nOther tests fails because the key size that's used is too small.\r\n\r\nI'm not sure yet why some of the other tests fail.\r\n\r\nThere are also a bunch of warnings about deprecated functions.  I left them like they are.  The proper way to deal with it will probably break compatibility.\r\n\r\nPS: During make test I'm getting invalid opcode traps, this seems unrelated to my changes and doesn't seem to cause test suite failures."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/246194795","html_url":"https://github.com/nodejs/node/pull/8491#issuecomment-246194795","issue_url":"https://api.github.com/repos/nodejs/node/issues/8491","id":246194795,"user":{"login":"kroeckx","id":1616242,"avatar_url":"https://avatars.githubusercontent.com/u/1616242?v=3","gravatar_id":"","url":"https://api.github.com/users/kroeckx","html_url":"https://github.com/kroeckx","followers_url":"https://api.github.com/users/kroeckx/followers","following_url":"https://api.github.com/users/kroeckx/following{/other_user}","gists_url":"https://api.github.com/users/kroeckx/gists{/gist_id}","starred_url":"https://api.github.com/users/kroeckx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroeckx/subscriptions","organizations_url":"https://api.github.com/users/kroeckx/orgs","repos_url":"https://api.github.com/users/kroeckx/repos","events_url":"https://api.github.com/users/kroeckx/events{/privacy}","received_events_url":"https://api.github.com/users/kroeckx/received_events","type":"User","site_admin":false},"created_at":"2016-09-11T18:13:18Z","updated_at":"2016-09-11T18:13:18Z","body":"It contains 1 change in error message generated by itself as far as I know, from \"Ticket keys length must be 48 bytes\" to \"Ticket keys length incorrect\"."}}
{"actor":{"display_login":"kroeckx"}}