{"action":"created","issue":{"url":"https://api.github.com/repos/npct/pct-shiny/issues/276","repository_url":"https://api.github.com/repos/npct/pct-shiny","labels_url":"https://api.github.com/repos/npct/pct-shiny/issues/276/labels{/name}","comments_url":"https://api.github.com/repos/npct/pct-shiny/issues/276/comments","events_url":"https://api.github.com/repos/npct/pct-shiny/issues/276/events","html_url":"https://github.com/npct/pct-shiny/issues/276","id":158642104,"number":276,"title":"Improving the zone/lines data download interface and content","user":{"login":"AnnaGoodman1","id":11818225,"avatar_url":"https://avatars.githubusercontent.com/u/11818225?v=3","gravatar_id":"","url":"https://api.github.com/users/AnnaGoodman1","html_url":"https://github.com/AnnaGoodman1","followers_url":"https://api.github.com/users/AnnaGoodman1/followers","following_url":"https://api.github.com/users/AnnaGoodman1/following{/other_user}","gists_url":"https://api.github.com/users/AnnaGoodman1/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaGoodman1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaGoodman1/subscriptions","organizations_url":"https://api.github.com/users/AnnaGoodman1/orgs","repos_url":"https://api.github.com/users/AnnaGoodman1/repos","events_url":"https://api.github.com/users/AnnaGoodman1/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaGoodman1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nikolai-b","id":6289830,"avatar_url":"https://avatars.githubusercontent.com/u/6289830?v=3","gravatar_id":"","url":"https://api.github.com/users/nikolai-b","html_url":"https://github.com/nikolai-b","followers_url":"https://api.github.com/users/nikolai-b/followers","following_url":"https://api.github.com/users/nikolai-b/following{/other_user}","gists_url":"https://api.github.com/users/nikolai-b/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolai-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolai-b/subscriptions","organizations_url":"https://api.github.com/users/nikolai-b/orgs","repos_url":"https://api.github.com/users/nikolai-b/repos","events_url":"https://api.github.com/users/nikolai-b/events{/privacy}","received_events_url":"https://api.github.com/users/nikolai-b/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikolai-b","id":6289830,"avatar_url":"https://avatars.githubusercontent.com/u/6289830?v=3","gravatar_id":"","url":"https://api.github.com/users/nikolai-b","html_url":"https://github.com/nikolai-b","followers_url":"https://api.github.com/users/nikolai-b/followers","following_url":"https://api.github.com/users/nikolai-b/following{/other_user}","gists_url":"https://api.github.com/users/nikolai-b/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolai-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolai-b/subscriptions","organizations_url":"https://api.github.com/users/nikolai-b/orgs","repos_url":"https://api.github.com/users/nikolai-b/repos","events_url":"https://api.github.com/users/nikolai-b/events{/privacy}","received_events_url":"https://api.github.com/users/nikolai-b/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/npct/pct-shiny/milestones/1","html_url":"https://github.com/npct/pct-shiny/milestones/v1.0","labels_url":"https://api.github.com/repos/npct/pct-shiny/milestones/1/labels","id":1766244,"number":1,"title":"v1.0","description":"These are things that will be ready fro the national launch.","creator":{"login":"Robinlovelace","id":1825120,"avatar_url":"https://avatars.githubusercontent.com/u/1825120?v=3","gravatar_id":"","url":"https://api.github.com/users/Robinlovelace","html_url":"https://github.com/Robinlovelace","followers_url":"https://api.github.com/users/Robinlovelace/followers","following_url":"https://api.github.com/users/Robinlovelace/following{/other_user}","gists_url":"https://api.github.com/users/Robinlovelace/gists{/gist_id}","starred_url":"https://api.github.com/users/Robinlovelace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robinlovelace/subscriptions","organizations_url":"https://api.github.com/users/Robinlovelace/orgs","repos_url":"https://api.github.com/users/Robinlovelace/repos","events_url":"https://api.github.com/users/Robinlovelace/events{/privacy}","received_events_url":"https://api.github.com/users/Robinlovelace/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":8,"state":"open","created_at":"2016-05-14T16:41:10Z","updated_at":"2016-06-28T17:11:11Z","due_on":"2016-07-10T23:00:00Z","closed_at":null},"comments":1,"created_at":"2016-06-06T10:01:59Z","updated_at":"2016-07-05T06:57:30Z","closed_at":null,"body":"Here are the steps I think I needed for this issue:\r\n\r\n1) change the “here you can download” text on the screen to match that shown in the attached word document, and also increase the font size.  Note that we are now removing some of the CSV files that could previously be downloaded\r\n\r\n2) change the variables included in the CSV file and RDS/Geo files, and the ordering of these variables, to match those specified in the attached word document and in the attached Excel document.   \r\n\r\n3) change the variables displayed on the screen, and their order and the labels given to them, to match those specified in the attached Excel document\r\n\r\n4) in a few cases variables need to be altered or added or renamed (or if renaming is not possible, then they should be deleted). These cases are highlighted in the first columns of the attached Excel document.  (There are also other inconsistencies in the naming which I find unhelpful – e.g. the car driver variable is \"Car\" in the zones, and \"Car_driver\" in the lines dataset; there is inconsistency between the files as to whether variable names are capitalised, e.g. “foot” in the zone file and “Foot” in the line file.  I previously asked Robin if these can be harmonised, but his view was that it would be too much work to be worth it)\r\n\r\n5)  the attached Excel document will form the basis of a zones and a lines codebook that I will create once the above changes have been put in place – just in case anything needs to change.\r\n\r\nI hope this makes sense, but please ask me if not then I can try to explain further. I’m afraid you would need to ask me any questions by email, since I don’t want monitor github\r\n\r\nAnna\r\n\r\n[downloadzoneslines.zip](https://github.com/npct/pct-shiny/files/300134/downloadzoneslines.zip)\r\n"},"comment":{"url":"https://api.github.com/repos/npct/pct-shiny/issues/comments/230400933","html_url":"https://github.com/npct/pct-shiny/issues/276#issuecomment-230400933","issue_url":"https://api.github.com/repos/npct/pct-shiny/issues/276","id":230400933,"user":{"login":"AnnaGoodman1","id":11818225,"avatar_url":"https://avatars.githubusercontent.com/u/11818225?v=3","gravatar_id":"","url":"https://api.github.com/users/AnnaGoodman1","html_url":"https://github.com/AnnaGoodman1","followers_url":"https://api.github.com/users/AnnaGoodman1/followers","following_url":"https://api.github.com/users/AnnaGoodman1/following{/other_user}","gists_url":"https://api.github.com/users/AnnaGoodman1/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaGoodman1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaGoodman1/subscriptions","organizations_url":"https://api.github.com/users/AnnaGoodman1/orgs","repos_url":"https://api.github.com/users/AnnaGoodman1/repos","events_url":"https://api.github.com/users/AnnaGoodman1/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaGoodman1/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T06:57:30Z","updated_at":"2016-07-05T06:57:30Z","body":"Thanks for the work you have been doing on this, Nikolai - I have just been having a look and taking stock.  Here are the further steps I think I needed for this issue (Some of these are just repeating what I said in my first message, so that everything is in one place – others are in response to the work you have already done):\r\n\r\n1) change the “here you can download” text & download options on the screen to match that shown in the attached word document - Specifically, the parts highlighted yellow have not yet been implemented.  Note that we are now removing some of the CSV files that could previously be downloaded.  \r\n\r\n2) zones: 1) change the variables included in the CSV file and RDS/Geo files, and (Ideally) the ordering of these variables, to match those specified in the attached Excel document.  \r\n\r\n3) Lines: 1) change the variables included in the CSV file and the straight lines RDS/Geo file, and (Ideally) the ordering of these variables, to match those specified in the attached Excel document. 2) The RDS/Geo files of the fast and quiet routes should not show any attribute data (but should have ID in there, ie start and  end  zones). 3) The route network file should continue to contain scenario data, it does not need to be changed.\r\n\r\n4) in a few cases variables need to be altered or added or renamed (or if renaming is not possible, then they should be deleted). These cases are highlighted in the first columns of the attached Excel document.  \r\n\r\n5) Some small modifications to the variables displayed on the screen:\r\n•\tLines:  1) add in fast route distance (variable =”dist_fast” / label= \"Fast route distance (km)\"), between “start and end zones” and “total number of commuters”. 2)  Remove the column for “no. car drivers in Census 2011”. 3) Can we remove the internal ID column, i.e. the unlabelled number that appears first on the far left of the screen?\r\n•\tarea: 1) add in total number of commuters (Variable = \"all\", label=\"Total no. commuters\"), between “zone name” and “no. Cyclists in Census 2011”. 2) Can we remove the internal ID column, i.e. the unlabelled number that appears first on the far left of the screen?\r\n\r\nVery happy to discuss any of the above, e.g. if it is unclear, or would involve a lot of work (it isn't always obvious to me how time-consuming different tasks will be)\r\n\r\nAnna\r\n\r\n[160705_pctdownload text.docx](https://github.com/npct/pct-shiny/files/347192/160705_pctdownload.text.docx)\r\n"}}
{"actor":{"display_login":"AnnaGoodman1"}}