{"action":"created","comment":{"url":"https://api.github.com/repos/baidu/tera/pulls/comments/64506060","id":64506060,"diff_hunk":"@@ -518,8 +518,7 @@ void IncrementalGcStrategy::CollectSingleDeadTablet(const std::string& tablename\n             if (!ParseFileName(files[f], &number, &type) ||\n                 type != leveldb::kTableFile) {\n                 // only keep sst, delete rest files\n-                LOG(INFO) << \"[gc] delete obsolete file: \" << file_path;\n-                env->DeleteFile(file_path);\n+                io::DeleteEnvDir(file_path);","path":"src/master/gc_strategy.cc","position":24,"original_position":62,"commit_id":"acbde0ae4d648a5543334f8f1534c929f42a1b4f","original_commit_id":"acbde0ae4d648a5543334f8f1534c929f42a1b4f","user":{"login":"bluebore","id":6851389,"avatar_url":"https://avatars.githubusercontent.com/u/6851389?v=3","gravatar_id":"","url":"https://api.github.com/users/bluebore","html_url":"https://github.com/bluebore","followers_url":"https://api.github.com/users/bluebore/followers","following_url":"https://api.github.com/users/bluebore/following{/other_user}","gists_url":"https://api.github.com/users/bluebore/gists{/gist_id}","starred_url":"https://api.github.com/users/bluebore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluebore/subscriptions","organizations_url":"https://api.github.com/users/bluebore/orgs","repos_url":"https://api.github.com/users/bluebore/repos","events_url":"https://api.github.com/users/bluebore/events{/privacy}","received_events_url":"https://api.github.com/users/bluebore/received_events","type":"User","site_admin":false},"body":"这个io是啥，为什么其他地方还用env，这里用io？","created_at":"2016-05-25T02:19:11Z","updated_at":"2016-05-25T02:19:11Z","html_url":"https://github.com/baidu/tera/pull/891#discussion_r64506060","pull_request_url":"https://api.github.com/repos/baidu/tera/pulls/891","_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments/64506060"},"html":{"href":"https://github.com/baidu/tera/pull/891#discussion_r64506060"},"pull_request":{"href":"https://api.github.com/repos/baidu/tera/pulls/891"}}},"pull_request":{"url":"https://api.github.com/repos/baidu/tera/pulls/891","id":71192546,"html_url":"https://github.com/baidu/tera/pull/891","diff_url":"https://github.com/baidu/tera/pull/891.diff","patch_url":"https://github.com/baidu/tera/pull/891.patch","issue_url":"https://api.github.com/repos/baidu/tera/issues/891","number":891,"state":"open","locked":false,"title":"master gc opz #890","user":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"body":"#890","created_at":"2016-05-24T10:08:01Z","updated_at":"2016-05-25T02:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1e6c0b38afa484e14356a53fa5c2d5afc4d7053","assignee":{"login":"bluebore","id":6851389,"avatar_url":"https://avatars.githubusercontent.com/u/6851389?v=3","gravatar_id":"","url":"https://api.github.com/users/bluebore","html_url":"https://github.com/bluebore","followers_url":"https://api.github.com/users/bluebore/followers","following_url":"https://api.github.com/users/bluebore/following{/other_user}","gists_url":"https://api.github.com/users/bluebore/gists{/gist_id}","starred_url":"https://api.github.com/users/bluebore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluebore/subscriptions","organizations_url":"https://api.github.com/users/bluebore/orgs","repos_url":"https://api.github.com/users/bluebore/repos","events_url":"https://api.github.com/users/bluebore/events{/privacy}","received_events_url":"https://api.github.com/users/bluebore/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/baidu/tera/pulls/891/commits","review_comments_url":"https://api.github.com/repos/baidu/tera/pulls/891/comments","review_comment_url":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baidu/tera/issues/891/comments","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/acbde0ae4d648a5543334f8f1534c929f42a1b4f","head":{"label":"xupeilin:bug/master-gc","ref":"bug/master-gc","sha":"acbde0ae4d648a5543334f8f1534c929f42a1b4f","user":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"repo":{"id":32515161,"name":"tera","full_name":"xupeilin/tera","owner":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xupeilin/tera","description":"A distributed table storage system.","fork":true,"url":"https://api.github.com/repos/xupeilin/tera","forks_url":"https://api.github.com/repos/xupeilin/tera/forks","keys_url":"https://api.github.com/repos/xupeilin/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xupeilin/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xupeilin/tera/teams","hooks_url":"https://api.github.com/repos/xupeilin/tera/hooks","issue_events_url":"https://api.github.com/repos/xupeilin/tera/issues/events{/number}","events_url":"https://api.github.com/repos/xupeilin/tera/events","assignees_url":"https://api.github.com/repos/xupeilin/tera/assignees{/user}","branches_url":"https://api.github.com/repos/xupeilin/tera/branches{/branch}","tags_url":"https://api.github.com/repos/xupeilin/tera/tags","blobs_url":"https://api.github.com/repos/xupeilin/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xupeilin/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xupeilin/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/xupeilin/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xupeilin/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/xupeilin/tera/languages","stargazers_url":"https://api.github.com/repos/xupeilin/tera/stargazers","contributors_url":"https://api.github.com/repos/xupeilin/tera/contributors","subscribers_url":"https://api.github.com/repos/xupeilin/tera/subscribers","subscription_url":"https://api.github.com/repos/xupeilin/tera/subscription","commits_url":"https://api.github.com/repos/xupeilin/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/xupeilin/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/xupeilin/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/xupeilin/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/xupeilin/tera/contents/{+path}","compare_url":"https://api.github.com/repos/xupeilin/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xupeilin/tera/merges","archive_url":"https://api.github.com/repos/xupeilin/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xupeilin/tera/downloads","issues_url":"https://api.github.com/repos/xupeilin/tera/issues{/number}","pulls_url":"https://api.github.com/repos/xupeilin/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/xupeilin/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/xupeilin/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xupeilin/tera/labels{/name}","releases_url":"https://api.github.com/repos/xupeilin/tera/releases{/id}","deployments_url":"https://api.github.com/repos/xupeilin/tera/deployments","created_at":"2015-03-19T10:32:01Z","updated_at":"2016-03-17T06:48:11Z","pushed_at":"2016-05-24T12:42:32Z","git_url":"git://github.com/xupeilin/tera.git","ssh_url":"git@github.com:xupeilin/tera.git","clone_url":"https://github.com/xupeilin/tera.git","svn_url":"https://github.com/xupeilin/tera","homepage":"","size":15309,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"baidu:master","ref":"master","sha":"f2ab94ed7b8c1eb4247e72f3dd56c84d0a935c8f","user":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"repo":{"id":18129915,"name":"tera","full_name":"baidu/tera","owner":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baidu/tera","description":"A distributed, elastic, structured database.","fork":false,"url":"https://api.github.com/repos/baidu/tera","forks_url":"https://api.github.com/repos/baidu/tera/forks","keys_url":"https://api.github.com/repos/baidu/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baidu/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baidu/tera/teams","hooks_url":"https://api.github.com/repos/baidu/tera/hooks","issue_events_url":"https://api.github.com/repos/baidu/tera/issues/events{/number}","events_url":"https://api.github.com/repos/baidu/tera/events","assignees_url":"https://api.github.com/repos/baidu/tera/assignees{/user}","branches_url":"https://api.github.com/repos/baidu/tera/branches{/branch}","tags_url":"https://api.github.com/repos/baidu/tera/tags","blobs_url":"https://api.github.com/repos/baidu/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baidu/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baidu/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/baidu/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/baidu/tera/languages","stargazers_url":"https://api.github.com/repos/baidu/tera/stargazers","contributors_url":"https://api.github.com/repos/baidu/tera/contributors","subscribers_url":"https://api.github.com/repos/baidu/tera/subscribers","subscription_url":"https://api.github.com/repos/baidu/tera/subscription","commits_url":"https://api.github.com/repos/baidu/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/baidu/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/baidu/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/baidu/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/baidu/tera/contents/{+path}","compare_url":"https://api.github.com/repos/baidu/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baidu/tera/merges","archive_url":"https://api.github.com/repos/baidu/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baidu/tera/downloads","issues_url":"https://api.github.com/repos/baidu/tera/issues{/number}","pulls_url":"https://api.github.com/repos/baidu/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/baidu/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/baidu/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baidu/tera/labels{/name}","releases_url":"https://api.github.com/repos/baidu/tera/releases{/id}","deployments_url":"https://api.github.com/repos/baidu/tera/deployments","created_at":"2014-03-26T07:22:05Z","updated_at":"2016-05-24T03:27:44Z","pushed_at":"2016-05-24T10:39:15Z","git_url":"git://github.com/baidu/tera.git","ssh_url":"git@github.com:baidu/tera.git","clone_url":"https://github.com/baidu/tera.git","svn_url":"https://github.com/baidu/tera","homepage":"","size":16960,"stargazers_count":393,"watchers_count":393,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":140,"mirror_url":null,"open_issues_count":170,"forks":140,"open_issues":170,"watchers":393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/891"},"html":{"href":"https://github.com/baidu/tera/pull/891"},"issue":{"href":"https://api.github.com/repos/baidu/tera/issues/891"},"comments":{"href":"https://api.github.com/repos/baidu/tera/issues/891/comments"},"review_comments":{"href":"https://api.github.com/repos/baidu/tera/pulls/891/comments"},"review_comment":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baidu/tera/pulls/891/commits"},"statuses":{"href":"https://api.github.com/repos/baidu/tera/statuses/acbde0ae4d648a5543334f8f1534c929f42a1b4f"}}}}
{"actor":{"display_login":"bluebore"}}