{"action":"closed","issue":{"url":"https://api.github.com/repos/numberoverzero/bloop/issues/66","repository_url":"https://api.github.com/repos/numberoverzero/bloop","labels_url":"https://api.github.com/repos/numberoverzero/bloop/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/numberoverzero/bloop/issues/66/comments","events_url":"https://api.github.com/repos/numberoverzero/bloop/issues/66/events","html_url":"https://github.com/numberoverzero/bloop/issues/66","id":172851350,"number":66,"title":"Refactor conditions to one module","user":{"login":"numberoverzero","id":1223809,"avatar_url":"https://avatars.githubusercontent.com/u/1223809?v=3","gravatar_id":"","url":"https://api.github.com/users/numberoverzero","html_url":"https://github.com/numberoverzero","followers_url":"https://api.github.com/users/numberoverzero/followers","following_url":"https://api.github.com/users/numberoverzero/following{/other_user}","gists_url":"https://api.github.com/users/numberoverzero/gists{/gist_id}","starred_url":"https://api.github.com/users/numberoverzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numberoverzero/subscriptions","organizations_url":"https://api.github.com/users/numberoverzero/orgs","repos_url":"https://api.github.com/users/numberoverzero/repos","events_url":"https://api.github.com/users/numberoverzero/events{/privacy}","received_events_url":"https://api.github.com/users/numberoverzero/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/numberoverzero/bloop/labels/api","name":"api","color":"c5def5"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-24T02:34:52Z","updated_at":"2016-08-29T02:40:19Z","closed_at":"2016-08-29T02:40:19Z","body":"With the new `object_*` signals, there's not really a need to import the raw tracking functions (`sync`, `mark`) and the only consumer of the `expressions` module are also consumers of `conditions`.\r\n\r\n- [x] Move `tracking` into conditions, replace all direct calls with `object_*.send` signal emission\r\n- [x] Move expressions back into conditions\r\n- [x] Move `_ComparisonMixin` into conditions\r\n\r\nAfter all the moving, the following cleanup:\r\n\r\n- [x] Create new single class for all `Condition`\r\n- [x] Create new mixin for new condition\r\n- [x] Create new renderer for new condition\r\n- [x] 100% unit test on new condition, mixin, renderer\r\n- [x] Swap everything over to new condition, mixin, renderer\r\n"}}
{"actor":{"display_login":"numberoverzero"}}