{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/comments/74368098","id":74368098,"diff_hunk":"@@ -601,22 +616,108 @@ protected function getFolderEditForm(Folder $folder)\n     /**\n      * See {@link getFolderEditForm()} for details.\n      *\n-     * @param File $file\n+     * @param int $id\n      * @return Form\n      */\n-    protected function getFileEditForm(File $file)\n+    public function getFileEditForm($id)\n     {\n+        /** @var File $file */\n+        $file = $this->getList()->byID($id);\n+\n+        // Get thumbnail, CMSThumbnail() is smaller than what we'd like\n+        $thumbnailWidth = $this->config()->edit_thumbnail_width;\n+        $thumbnailHeight = $this->config()->edit_thumbnail_height;\n+\n+        // todo: use getCMSFields","path":"code/Controller/AssetAdmin.php","position":90,"original_position":90,"commit_id":"891728ef3f8f69bd16d63286e85e88c364f7742b","original_commit_id":"891728ef3f8f69bd16d63286e85e88c364f7742b","user":{"login":"flamerohr","id":1064889,"avatar_url":"https://avatars.githubusercontent.com/u/1064889?v=3","gravatar_id":"","url":"https://api.github.com/users/flamerohr","html_url":"https://github.com/flamerohr","followers_url":"https://api.github.com/users/flamerohr/followers","following_url":"https://api.github.com/users/flamerohr/following{/other_user}","gists_url":"https://api.github.com/users/flamerohr/gists{/gist_id}","starred_url":"https://api.github.com/users/flamerohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamerohr/subscriptions","organizations_url":"https://api.github.com/users/flamerohr/orgs","repos_url":"https://api.github.com/users/flamerohr/repos","events_url":"https://api.github.com/users/flamerohr/events{/privacy}","received_events_url":"https://api.github.com/users/flamerohr/received_events","type":"User","site_admin":false},"body":"done, I've changed casing to uppercase","created_at":"2016-08-11T04:43:19Z","updated_at":"2016-08-11T04:43:19Z","html_url":"https://github.com/silverstripe/silverstripe-asset-admin/pull/215#discussion_r74368098","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/comments/74368098"},"html":{"href":"https://github.com/silverstripe/silverstripe-asset-admin/pull/215#discussion_r74368098"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215","id":80702419,"html_url":"https://github.com/silverstripe/silverstripe-asset-admin/pull/215","diff_url":"https://github.com/silverstripe/silverstripe-asset-admin/pull/215.diff","patch_url":"https://github.com/silverstripe/silverstripe-asset-admin/pull/215.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/issues/215","number":215,"state":"open","locked":false,"title":"Switch Editor form to use FormBuilder","user":{"login":"flamerohr","id":1064889,"avatar_url":"https://avatars.githubusercontent.com/u/1064889?v=3","gravatar_id":"","url":"https://api.github.com/users/flamerohr","html_url":"https://github.com/flamerohr","followers_url":"https://api.github.com/users/flamerohr/followers","following_url":"https://api.github.com/users/flamerohr/following{/other_user}","gists_url":"https://api.github.com/users/flamerohr/gists{/gist_id}","starred_url":"https://api.github.com/users/flamerohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamerohr/subscriptions","organizations_url":"https://api.github.com/users/flamerohr/orgs","repos_url":"https://api.github.com/users/flamerohr/repos","events_url":"https://api.github.com/users/flamerohr/events{/privacy}","received_events_url":"https://api.github.com/users/flamerohr/received_events","type":"User","site_admin":false},"body":"Relies on https://github.com/silverstripe/silverstripe-framework/pull/5880\r\n\r\nSwitching from the previous practice of building the form manually to using the FormBuilderComponent in framework.","created_at":"2016-08-09T21:58:25Z","updated_at":"2016-08-11T04:43:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8186c48fcfe9ee81cd96849f7bf1c2a3ed0b3452","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/issues/215/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/statuses/891728ef3f8f69bd16d63286e85e88c364f7742b","head":{"label":"open-sausages:pulls/4.0/formbuilder-file-edit","ref":"pulls/4.0/formbuilder-file-edit","sha":"891728ef3f8f69bd16d63286e85e88c364f7742b","user":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars.githubusercontent.com/u/12824172?v=3","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"repo":{"id":55116207,"name":"silverstripe-asset-admin","full_name":"open-sausages/silverstripe-asset-admin","owner":{"login":"open-sausages","id":12824172,"avatar_url":"https://avatars.githubusercontent.com/u/12824172?v=3","gravatar_id":"","url":"https://api.github.com/users/open-sausages","html_url":"https://github.com/open-sausages","followers_url":"https://api.github.com/users/open-sausages/followers","following_url":"https://api.github.com/users/open-sausages/following{/other_user}","gists_url":"https://api.github.com/users/open-sausages/gists{/gist_id}","starred_url":"https://api.github.com/users/open-sausages/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-sausages/subscriptions","organizations_url":"https://api.github.com/users/open-sausages/orgs","repos_url":"https://api.github.com/users/open-sausages/repos","events_url":"https://api.github.com/users/open-sausages/events{/privacy}","received_events_url":"https://api.github.com/users/open-sausages/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-sausages/silverstripe-asset-admin","description":"PoC for SilverStripe assets gallery","fork":true,"url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin","forks_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/forks","keys_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/teams","hooks_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/hooks","issue_events_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/issues/events{/number}","events_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/events","assignees_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/assignees{/user}","branches_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/branches{/branch}","tags_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/tags","blobs_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/languages","stargazers_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/stargazers","contributors_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/contributors","subscribers_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/subscribers","subscription_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/subscription","commits_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/contents/{+path}","compare_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/merges","archive_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/downloads","issues_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/issues{/number}","pulls_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/labels{/name}","releases_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/releases{/id}","deployments_url":"https://api.github.com/repos/open-sausages/silverstripe-asset-admin/deployments","created_at":"2016-03-31T03:10:13Z","updated_at":"2016-03-31T03:10:13Z","pushed_at":"2016-08-11T04:33:59Z","git_url":"git://github.com/open-sausages/silverstripe-asset-admin.git","ssh_url":"git@github.com:open-sausages/silverstripe-asset-admin.git","clone_url":"https://github.com/open-sausages/silverstripe-asset-admin.git","svn_url":"https://github.com/open-sausages/silverstripe-asset-admin","homepage":null,"size":3490,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:master","ref":"master","sha":"b46031ca9ce42ef9d346786b7740b5ea42539511","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":42913926,"name":"silverstripe-asset-admin","full_name":"silverstripe/silverstripe-asset-admin","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-asset-admin","description":"PoC for SilverStripe assets gallery","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/deployments","created_at":"2015-09-22T05:44:24Z","updated_at":"2016-05-02T14:22:39Z","pushed_at":"2016-08-11T02:12:49Z","git_url":"git://github.com/silverstripe/silverstripe-asset-admin.git","ssh_url":"git@github.com:silverstripe/silverstripe-asset-admin.git","clone_url":"https://github.com/silverstripe/silverstripe-asset-admin.git","svn_url":"https://github.com/silverstripe/silverstripe-asset-admin","homepage":null,"size":4034,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":32,"forks":13,"open_issues":32,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215"},"html":{"href":"https://github.com/silverstripe/silverstripe-asset-admin/pull/215"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/issues/215"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-asset-admin/statuses/891728ef3f8f69bd16d63286e85e88c364f7742b"}}}}
{"actor":{"display_login":"flamerohr"}}