{"action":"created","comment":{"url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/comments/72609863","id":72609863,"diff_hunk":"@@ -187,6 +193,25 @@ static int check_extension(char *filename, apr_array_header_t *exts)\n   return 0;\n }\n \n+static int check_time(apr_pool_t *p, unsigned int time_from, unsigned int time_to)\n+{\n+  apr_time_exp_t reqtime_result;","path":"mod_vhost_maxclients.c","position":33,"original_position":33,"commit_id":"a3013bd594be6b219f5491eefab3d266a3c56215","original_commit_id":"a3013bd594be6b219f5491eefab3d266a3c56215","user":{"login":"matsumoto-r","id":648437,"avatar_url":"https://avatars.githubusercontent.com/u/648437?v=3","gravatar_id":"","url":"https://api.github.com/users/matsumoto-r","html_url":"https://github.com/matsumoto-r","followers_url":"https://api.github.com/users/matsumoto-r/followers","following_url":"https://api.github.com/users/matsumoto-r/following{/other_user}","gists_url":"https://api.github.com/users/matsumoto-r/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumoto-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumoto-r/subscriptions","organizations_url":"https://api.github.com/users/matsumoto-r/orgs","repos_url":"https://api.github.com/users/matsumoto-r/repos","events_url":"https://api.github.com/users/matsumoto-r/events{/privacy}","received_events_url":"https://api.github.com/users/matsumoto-r/received_events","type":"User","site_admin":false},"body":"せっかく関数切り出したので、関数内は変数名もっと短くてよいです。reqtime_resultをtmとか。","created_at":"2016-07-28T12:09:12Z","updated_at":"2016-07-28T12:09:12Z","html_url":"https://github.com/matsumoto-r/mod_vhost_maxclients/pull/8#discussion_r72609863","pull_request_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/comments/72609863"},"html":{"href":"https://github.com/matsumoto-r/mod_vhost_maxclients/pull/8#discussion_r72609863"},"pull_request":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8","id":79130383,"html_url":"https://github.com/matsumoto-r/mod_vhost_maxclients/pull/8","diff_url":"https://github.com/matsumoto-r/mod_vhost_maxclients/pull/8.diff","patch_url":"https://github.com/matsumoto-r/mod_vhost_maxclients/pull/8.patch","issue_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/issues/8","number":8,"state":"open","locked":false,"title":"(WIP)Support the time to enable the limit","user":{"login":"yasuaki-tahira","id":12387636,"avatar_url":"https://avatars.githubusercontent.com/u/12387636?v=3","gravatar_id":"","url":"https://api.github.com/users/yasuaki-tahira","html_url":"https://github.com/yasuaki-tahira","followers_url":"https://api.github.com/users/yasuaki-tahira/followers","following_url":"https://api.github.com/users/yasuaki-tahira/following{/other_user}","gists_url":"https://api.github.com/users/yasuaki-tahira/gists{/gist_id}","starred_url":"https://api.github.com/users/yasuaki-tahira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasuaki-tahira/subscriptions","organizations_url":"https://api.github.com/users/yasuaki-tahira/orgs","repos_url":"https://api.github.com/users/yasuaki-tahira/repos","events_url":"https://api.github.com/users/yasuaki-tahira/events{/privacy}","received_events_url":"https://api.github.com/users/yasuaki-tahira/received_events","type":"User","site_admin":false},"body":"Set `VhostMaxClientsTimeFrom` , `VhostMaxClientsTimeTo`.\r\nYou can limit within the specified time.\r\n\r\n*example*\r\n```\r\n<VirtualHost *>\r\n\tDocumentRoot /var/www/html\r\n\tServerName localhost\r\n\tVhostMaxClients 1\r\n\tVhostMaxClientsTimeFrom 2300\r\n\tVhostMaxClientsTimeTo\t0230\r\n</VirtualHost>\r\n```\r\n\r\n- request_time = 1700 > disable\r\n- request_time = 2330 > enable\r\n\r\n----\r\n\r\nand fixed typo.  `vhost_maxclinets_log_error` > `vhost_maxclients_log_error`","created_at":"2016-07-28T02:59:37Z","updated_at":"2016-07-28T12:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88ed3b217fdee3fc6eb7495312243145f93666af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8/commits","review_comments_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8/comments","review_comment_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/issues/8/comments","statuses_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/statuses/a3013bd594be6b219f5491eefab3d266a3c56215","head":{"label":"yasuaki-tahira:add-limittime","ref":"add-limittime","sha":"a3013bd594be6b219f5491eefab3d266a3c56215","user":{"login":"yasuaki-tahira","id":12387636,"avatar_url":"https://avatars.githubusercontent.com/u/12387636?v=3","gravatar_id":"","url":"https://api.github.com/users/yasuaki-tahira","html_url":"https://github.com/yasuaki-tahira","followers_url":"https://api.github.com/users/yasuaki-tahira/followers","following_url":"https://api.github.com/users/yasuaki-tahira/following{/other_user}","gists_url":"https://api.github.com/users/yasuaki-tahira/gists{/gist_id}","starred_url":"https://api.github.com/users/yasuaki-tahira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasuaki-tahira/subscriptions","organizations_url":"https://api.github.com/users/yasuaki-tahira/orgs","repos_url":"https://api.github.com/users/yasuaki-tahira/repos","events_url":"https://api.github.com/users/yasuaki-tahira/events{/privacy}","received_events_url":"https://api.github.com/users/yasuaki-tahira/received_events","type":"User","site_admin":false},"repo":{"id":64358526,"name":"mod_vhost_maxclients","full_name":"yasuaki-tahira/mod_vhost_maxclients","owner":{"login":"yasuaki-tahira","id":12387636,"avatar_url":"https://avatars.githubusercontent.com/u/12387636?v=3","gravatar_id":"","url":"https://api.github.com/users/yasuaki-tahira","html_url":"https://github.com/yasuaki-tahira","followers_url":"https://api.github.com/users/yasuaki-tahira/followers","following_url":"https://api.github.com/users/yasuaki-tahira/following{/other_user}","gists_url":"https://api.github.com/users/yasuaki-tahira/gists{/gist_id}","starred_url":"https://api.github.com/users/yasuaki-tahira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasuaki-tahira/subscriptions","organizations_url":"https://api.github.com/users/yasuaki-tahira/orgs","repos_url":"https://api.github.com/users/yasuaki-tahira/repos","events_url":"https://api.github.com/users/yasuaki-tahira/events{/privacy}","received_events_url":"https://api.github.com/users/yasuaki-tahira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yasuaki-tahira/mod_vhost_maxclients","description":"MaxClients per vhost, no using shared memory and global lock. mod_vhost_maxclients use only scoreboad for stability, high compatibility and simple implementation.","fork":true,"url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients","forks_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/forks","keys_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/teams","hooks_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/hooks","issue_events_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/issues/events{/number}","events_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/events","assignees_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/assignees{/user}","branches_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/branches{/branch}","tags_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/tags","blobs_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/git/refs{/sha}","trees_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/statuses/{sha}","languages_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/languages","stargazers_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/stargazers","contributors_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/contributors","subscribers_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/subscribers","subscription_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/subscription","commits_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/commits{/sha}","git_commits_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/git/commits{/sha}","comments_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/comments{/number}","issue_comment_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/issues/comments{/number}","contents_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/contents/{+path}","compare_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/merges","archive_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/downloads","issues_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/issues{/number}","pulls_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/pulls{/number}","milestones_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/milestones{/number}","notifications_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/labels{/name}","releases_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/releases{/id}","deployments_url":"https://api.github.com/repos/yasuaki-tahira/mod_vhost_maxclients/deployments","created_at":"2016-07-28T02:42:23Z","updated_at":"2016-07-28T02:42:24Z","pushed_at":"2016-07-28T12:02:09Z","git_url":"git://github.com/yasuaki-tahira/mod_vhost_maxclients.git","ssh_url":"git@github.com:yasuaki-tahira/mod_vhost_maxclients.git","clone_url":"https://github.com/yasuaki-tahira/mod_vhost_maxclients.git","svn_url":"https://github.com/yasuaki-tahira/mod_vhost_maxclients","homepage":"","size":46,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matsumoto-r:master","ref":"master","sha":"6b8ccd0e7d8464b00c98bcd7593ef917e6029834","user":{"login":"matsumoto-r","id":648437,"avatar_url":"https://avatars.githubusercontent.com/u/648437?v=3","gravatar_id":"","url":"https://api.github.com/users/matsumoto-r","html_url":"https://github.com/matsumoto-r","followers_url":"https://api.github.com/users/matsumoto-r/followers","following_url":"https://api.github.com/users/matsumoto-r/following{/other_user}","gists_url":"https://api.github.com/users/matsumoto-r/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumoto-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumoto-r/subscriptions","organizations_url":"https://api.github.com/users/matsumoto-r/orgs","repos_url":"https://api.github.com/users/matsumoto-r/repos","events_url":"https://api.github.com/users/matsumoto-r/events{/privacy}","received_events_url":"https://api.github.com/users/matsumoto-r/received_events","type":"User","site_admin":false},"repo":{"id":41530541,"name":"mod_vhost_maxclients","full_name":"matsumoto-r/mod_vhost_maxclients","owner":{"login":"matsumoto-r","id":648437,"avatar_url":"https://avatars.githubusercontent.com/u/648437?v=3","gravatar_id":"","url":"https://api.github.com/users/matsumoto-r","html_url":"https://github.com/matsumoto-r","followers_url":"https://api.github.com/users/matsumoto-r/followers","following_url":"https://api.github.com/users/matsumoto-r/following{/other_user}","gists_url":"https://api.github.com/users/matsumoto-r/gists{/gist_id}","starred_url":"https://api.github.com/users/matsumoto-r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsumoto-r/subscriptions","organizations_url":"https://api.github.com/users/matsumoto-r/orgs","repos_url":"https://api.github.com/users/matsumoto-r/repos","events_url":"https://api.github.com/users/matsumoto-r/events{/privacy}","received_events_url":"https://api.github.com/users/matsumoto-r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matsumoto-r/mod_vhost_maxclients","description":"MaxClients per vhost, no using shared memory and global lock. mod_vhost_maxclients use only scoreboad for stability, high compatibility and simple implementation.","fork":false,"url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients","forks_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/forks","keys_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/teams","hooks_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/hooks","issue_events_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/issues/events{/number}","events_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/events","assignees_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/assignees{/user}","branches_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/branches{/branch}","tags_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/tags","blobs_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/git/refs{/sha}","trees_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/statuses/{sha}","languages_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/languages","stargazers_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/stargazers","contributors_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/contributors","subscribers_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/subscribers","subscription_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/subscription","commits_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/commits{/sha}","git_commits_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/git/commits{/sha}","comments_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/comments{/number}","issue_comment_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/issues/comments{/number}","contents_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/contents/{+path}","compare_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/merges","archive_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/downloads","issues_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/issues{/number}","pulls_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls{/number}","milestones_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/milestones{/number}","notifications_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/labels{/name}","releases_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/releases{/id}","deployments_url":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/deployments","created_at":"2015-08-28T06:13:43Z","updated_at":"2016-07-21T06:31:03Z","pushed_at":"2016-07-28T12:02:10Z","git_url":"git://github.com/matsumoto-r/mod_vhost_maxclients.git","ssh_url":"git@github.com:matsumoto-r/mod_vhost_maxclients.git","clone_url":"https://github.com/matsumoto-r/mod_vhost_maxclients.git","svn_url":"https://github.com/matsumoto-r/mod_vhost_maxclients","homepage":"","size":60,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8"},"html":{"href":"https://github.com/matsumoto-r/mod_vhost_maxclients/pull/8"},"issue":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/issues/8"},"comments":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/matsumoto-r/mod_vhost_maxclients/statuses/a3013bd594be6b219f5491eefab3d266a3c56215"}}}}
{"actor":{"display_login":"matsumoto-r"}}