{"action":"created","comment":{"url":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/comments/91066927","pull_request_review_id":11574098,"id":91066927,"diff_hunk":"@@ -1,23 +1,36 @@\n package osv\n \n import (\n+\t\"io/ioutil\"\n+\t\"os\"\n+\n \t\"github.com/emc-advanced-dev/pkg/errors\"\n \t\"github.com/emc-advanced-dev/unik/pkg/types\"\n )\n \n-type OsvVmwareCompiler struct {\n-\tOSvCompilerBase\n-}\n-\n const OSV_VMWARE_MEMORY = 512\n \n-func (osvCompiler *OsvVmwareCompiler) CompileRawImage(params types.CompileImageParams) (_ *types.RawImage, err error) {\n-\tresultFile, err := osvCompiler.CreateImage(params, false)\n+type VmwareCompilerHelper struct {\n+\tCompilerHelperBase\n+}\n+\n+func (b *VmwareCompilerHelper) Convert(params ConvertParams) (*types.RawImage, error) {\n+\t// Convert to WMDK format.","path":"pkg/compilers/osv/osv_vmware.go","position":24,"original_position":24,"commit_id":"3e148bb3934f3c0ab67707fd704c3eaf5340a293","original_commit_id":"3e148bb3934f3c0ab67707fd704c3eaf5340a293","user":{"login":"gberginc","id":1437960,"avatar_url":"https://avatars.githubusercontent.com/u/1437960?v=3","gravatar_id":"","url":"https://api.github.com/users/gberginc","html_url":"https://github.com/gberginc","followers_url":"https://api.github.com/users/gberginc/followers","following_url":"https://api.github.com/users/gberginc/following{/other_user}","gists_url":"https://api.github.com/users/gberginc/gists{/gist_id}","starred_url":"https://api.github.com/users/gberginc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberginc/subscriptions","organizations_url":"https://api.github.com/users/gberginc/orgs","repos_url":"https://api.github.com/users/gberginc/repos","events_url":"https://api.github.com/users/gberginc/events{/privacy}","received_events_url":"https://api.github.com/users/gberginc/received_events","type":"User","site_admin":false},"body":"VMDK","created_at":"2016-12-06T12:21:34Z","updated_at":"2016-12-06T12:48:16Z","html_url":"https://github.com/emc-advanced-dev/unik/pull/111#discussion_r91066927","pull_request_url":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/comments/91066927"},"html":{"href":"https://github.com/emc-advanced-dev/unik/pull/111#discussion_r91066927"},"pull_request":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111","id":94322712,"html_url":"https://github.com/emc-advanced-dev/unik/pull/111","diff_url":"https://github.com/emc-advanced-dev/unik/pull/111.diff","patch_url":"https://github.com/emc-advanced-dev/unik/pull/111.patch","issue_url":"https://api.github.com/repos/emc-advanced-dev/unik/issues/111","number":111,"state":"open","locked":false,"title":"Refactor OSv compiler","user":{"login":"miha-plesko","id":8102426,"avatar_url":"https://avatars.githubusercontent.com/u/8102426?v=3","gravatar_id":"","url":"https://api.github.com/users/miha-plesko","html_url":"https://github.com/miha-plesko","followers_url":"https://api.github.com/users/miha-plesko/followers","following_url":"https://api.github.com/users/miha-plesko/following{/other_user}","gists_url":"https://api.github.com/users/miha-plesko/gists{/gist_id}","starred_url":"https://api.github.com/users/miha-plesko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miha-plesko/subscriptions","organizations_url":"https://api.github.com/users/miha-plesko/orgs","repos_url":"https://api.github.com/users/miha-plesko/repos","events_url":"https://api.github.com/users/miha-plesko/events{/privacy}","received_events_url":"https://api.github.com/users/miha-plesko/received_events","type":"User","site_admin":false},"body":"OSv compiler needed some changes to match Rumprun compiler structure better. Prior this change, OSv compiler had a reversed logic compared to Rumprun. Fixed.","created_at":"2016-11-18T08:45:12Z","updated_at":"2016-12-06T12:48:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c02d9fe5e79cfac3e04c2bfbc0bf22b58296825","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111/commits","review_comments_url":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111/comments","review_comment_url":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emc-advanced-dev/unik/issues/111/comments","statuses_url":"https://api.github.com/repos/emc-advanced-dev/unik/statuses/3e148bb3934f3c0ab67707fd704c3eaf5340a293","head":{"label":"mikelangelo-project:refactor_osv_compiler_introduce_bootstrapper","ref":"refactor_osv_compiler_introduce_bootstrapper","sha":"3e148bb3934f3c0ab67707fd704c3eaf5340a293","user":{"login":"mikelangelo-project","id":19607578,"avatar_url":"https://avatars.githubusercontent.com/u/19607578?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelangelo-project","html_url":"https://github.com/mikelangelo-project","followers_url":"https://api.github.com/users/mikelangelo-project/followers","following_url":"https://api.github.com/users/mikelangelo-project/following{/other_user}","gists_url":"https://api.github.com/users/mikelangelo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelangelo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelangelo-project/subscriptions","organizations_url":"https://api.github.com/users/mikelangelo-project/orgs","repos_url":"https://api.github.com/users/mikelangelo-project/repos","events_url":"https://api.github.com/users/mikelangelo-project/events{/privacy}","received_events_url":"https://api.github.com/users/mikelangelo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":65882279,"name":"unik","full_name":"mikelangelo-project/unik","owner":{"login":"mikelangelo-project","id":19607578,"avatar_url":"https://avatars.githubusercontent.com/u/19607578?v=3","gravatar_id":"","url":"https://api.github.com/users/mikelangelo-project","html_url":"https://github.com/mikelangelo-project","followers_url":"https://api.github.com/users/mikelangelo-project/followers","following_url":"https://api.github.com/users/mikelangelo-project/following{/other_user}","gists_url":"https://api.github.com/users/mikelangelo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/mikelangelo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikelangelo-project/subscriptions","organizations_url":"https://api.github.com/users/mikelangelo-project/orgs","repos_url":"https://api.github.com/users/mikelangelo-project/repos","events_url":"https://api.github.com/users/mikelangelo-project/events{/privacy}","received_events_url":"https://api.github.com/users/mikelangelo-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mikelangelo-project/unik","description":"The Unikernel Compilation and Deployment Platform","fork":true,"url":"https://api.github.com/repos/mikelangelo-project/unik","forks_url":"https://api.github.com/repos/mikelangelo-project/unik/forks","keys_url":"https://api.github.com/repos/mikelangelo-project/unik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikelangelo-project/unik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikelangelo-project/unik/teams","hooks_url":"https://api.github.com/repos/mikelangelo-project/unik/hooks","issue_events_url":"https://api.github.com/repos/mikelangelo-project/unik/issues/events{/number}","events_url":"https://api.github.com/repos/mikelangelo-project/unik/events","assignees_url":"https://api.github.com/repos/mikelangelo-project/unik/assignees{/user}","branches_url":"https://api.github.com/repos/mikelangelo-project/unik/branches{/branch}","tags_url":"https://api.github.com/repos/mikelangelo-project/unik/tags","blobs_url":"https://api.github.com/repos/mikelangelo-project/unik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikelangelo-project/unik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikelangelo-project/unik/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikelangelo-project/unik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikelangelo-project/unik/statuses/{sha}","languages_url":"https://api.github.com/repos/mikelangelo-project/unik/languages","stargazers_url":"https://api.github.com/repos/mikelangelo-project/unik/stargazers","contributors_url":"https://api.github.com/repos/mikelangelo-project/unik/contributors","subscribers_url":"https://api.github.com/repos/mikelangelo-project/unik/subscribers","subscription_url":"https://api.github.com/repos/mikelangelo-project/unik/subscription","commits_url":"https://api.github.com/repos/mikelangelo-project/unik/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikelangelo-project/unik/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikelangelo-project/unik/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikelangelo-project/unik/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikelangelo-project/unik/contents/{+path}","compare_url":"https://api.github.com/repos/mikelangelo-project/unik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikelangelo-project/unik/merges","archive_url":"https://api.github.com/repos/mikelangelo-project/unik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikelangelo-project/unik/downloads","issues_url":"https://api.github.com/repos/mikelangelo-project/unik/issues{/number}","pulls_url":"https://api.github.com/repos/mikelangelo-project/unik/pulls{/number}","milestones_url":"https://api.github.com/repos/mikelangelo-project/unik/milestones{/number}","notifications_url":"https://api.github.com/repos/mikelangelo-project/unik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikelangelo-project/unik/labels{/name}","releases_url":"https://api.github.com/repos/mikelangelo-project/unik/releases{/id}","deployments_url":"https://api.github.com/repos/mikelangelo-project/unik/deployments","created_at":"2016-08-17T06:35:58Z","updated_at":"2016-11-11T07:18:20Z","pushed_at":"2016-12-06T10:56:58Z","git_url":"git://github.com/mikelangelo-project/unik.git","ssh_url":"git@github.com:mikelangelo-project/unik.git","clone_url":"https://github.com/mikelangelo-project/unik.git","svn_url":"https://github.com/mikelangelo-project/unik","homepage":null,"size":56009,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"emc-advanced-dev:master","ref":"master","sha":"8d385b5299c69969d438d0cefd64bdcf74ae9195","user":{"login":"emc-advanced-dev","id":18314192,"avatar_url":"https://avatars.githubusercontent.com/u/18314192?v=3","gravatar_id":"","url":"https://api.github.com/users/emc-advanced-dev","html_url":"https://github.com/emc-advanced-dev","followers_url":"https://api.github.com/users/emc-advanced-dev/followers","following_url":"https://api.github.com/users/emc-advanced-dev/following{/other_user}","gists_url":"https://api.github.com/users/emc-advanced-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/emc-advanced-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emc-advanced-dev/subscriptions","organizations_url":"https://api.github.com/users/emc-advanced-dev/orgs","repos_url":"https://api.github.com/users/emc-advanced-dev/repos","events_url":"https://api.github.com/users/emc-advanced-dev/events{/privacy}","received_events_url":"https://api.github.com/users/emc-advanced-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":55632099,"name":"unik","full_name":"emc-advanced-dev/unik","owner":{"login":"emc-advanced-dev","id":18314192,"avatar_url":"https://avatars.githubusercontent.com/u/18314192?v=3","gravatar_id":"","url":"https://api.github.com/users/emc-advanced-dev","html_url":"https://github.com/emc-advanced-dev","followers_url":"https://api.github.com/users/emc-advanced-dev/followers","following_url":"https://api.github.com/users/emc-advanced-dev/following{/other_user}","gists_url":"https://api.github.com/users/emc-advanced-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/emc-advanced-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emc-advanced-dev/subscriptions","organizations_url":"https://api.github.com/users/emc-advanced-dev/orgs","repos_url":"https://api.github.com/users/emc-advanced-dev/repos","events_url":"https://api.github.com/users/emc-advanced-dev/events{/privacy}","received_events_url":"https://api.github.com/users/emc-advanced-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emc-advanced-dev/unik","description":"The Unikernel Compilation and Deployment Platform","fork":false,"url":"https://api.github.com/repos/emc-advanced-dev/unik","forks_url":"https://api.github.com/repos/emc-advanced-dev/unik/forks","keys_url":"https://api.github.com/repos/emc-advanced-dev/unik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emc-advanced-dev/unik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emc-advanced-dev/unik/teams","hooks_url":"https://api.github.com/repos/emc-advanced-dev/unik/hooks","issue_events_url":"https://api.github.com/repos/emc-advanced-dev/unik/issues/events{/number}","events_url":"https://api.github.com/repos/emc-advanced-dev/unik/events","assignees_url":"https://api.github.com/repos/emc-advanced-dev/unik/assignees{/user}","branches_url":"https://api.github.com/repos/emc-advanced-dev/unik/branches{/branch}","tags_url":"https://api.github.com/repos/emc-advanced-dev/unik/tags","blobs_url":"https://api.github.com/repos/emc-advanced-dev/unik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emc-advanced-dev/unik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emc-advanced-dev/unik/git/refs{/sha}","trees_url":"https://api.github.com/repos/emc-advanced-dev/unik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emc-advanced-dev/unik/statuses/{sha}","languages_url":"https://api.github.com/repos/emc-advanced-dev/unik/languages","stargazers_url":"https://api.github.com/repos/emc-advanced-dev/unik/stargazers","contributors_url":"https://api.github.com/repos/emc-advanced-dev/unik/contributors","subscribers_url":"https://api.github.com/repos/emc-advanced-dev/unik/subscribers","subscription_url":"https://api.github.com/repos/emc-advanced-dev/unik/subscription","commits_url":"https://api.github.com/repos/emc-advanced-dev/unik/commits{/sha}","git_commits_url":"https://api.github.com/repos/emc-advanced-dev/unik/git/commits{/sha}","comments_url":"https://api.github.com/repos/emc-advanced-dev/unik/comments{/number}","issue_comment_url":"https://api.github.com/repos/emc-advanced-dev/unik/issues/comments{/number}","contents_url":"https://api.github.com/repos/emc-advanced-dev/unik/contents/{+path}","compare_url":"https://api.github.com/repos/emc-advanced-dev/unik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emc-advanced-dev/unik/merges","archive_url":"https://api.github.com/repos/emc-advanced-dev/unik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emc-advanced-dev/unik/downloads","issues_url":"https://api.github.com/repos/emc-advanced-dev/unik/issues{/number}","pulls_url":"https://api.github.com/repos/emc-advanced-dev/unik/pulls{/number}","milestones_url":"https://api.github.com/repos/emc-advanced-dev/unik/milestones{/number}","notifications_url":"https://api.github.com/repos/emc-advanced-dev/unik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emc-advanced-dev/unik/labels{/name}","releases_url":"https://api.github.com/repos/emc-advanced-dev/unik/releases{/id}","deployments_url":"https://api.github.com/repos/emc-advanced-dev/unik/deployments","created_at":"2016-04-06T18:46:17Z","updated_at":"2016-12-05T20:08:55Z","pushed_at":"2016-12-06T10:56:58Z","git_url":"git://github.com/emc-advanced-dev/unik.git","ssh_url":"git@github.com:emc-advanced-dev/unik.git","clone_url":"https://github.com/emc-advanced-dev/unik.git","svn_url":"https://github.com/emc-advanced-dev/unik","homepage":null,"size":37841,"stargazers_count":1060,"watchers_count":1060,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":23,"forks":70,"open_issues":23,"watchers":1060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111"},"html":{"href":"https://github.com/emc-advanced-dev/unik/pull/111"},"issue":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/issues/111"},"comments":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/emc-advanced-dev/unik/statuses/3e148bb3934f3c0ab67707fd704c3eaf5340a293"}}}}
{"actor":{"display_login":"gberginc"}}