{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/51344454","id":51344454,"diff_hunk":"@@ -793,7 +828,14 @@ function kube::release::create_docker_images_for_server() {\n         ln ${binary_dir}/${binary_name} ${docker_build_path}/${binary_name}\n         printf \" FROM ${base_image} \\n ADD ${binary_name} /usr/local/bin/${binary_name}\\n\" > ${docker_file_path}\n \n-        local docker_image_tag=gcr.io/google_containers/$binary_name:$md5_sum\n+        if [[ ${arch} == \"amd64\" ]]; then","path":"build/common.sh","position":121,"original_position":121,"commit_id":"428584bad3767d8aa2324ba82a9480d9f2b534d3","original_commit_id":"428584bad3767d8aa2324ba82a9480d9f2b534d3","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"@ixdy The issue was probably here. Some setup scripts assumed that the name of `linux/amd64` images was `${binary_name}:${md5_sum}` while I had changed it to  `${binary_name}-${arch}:${md5_sum}` when I was thinking about other arches.\r\n\r\nThis is the way to go. When we're releasing, both kinds of `amd64` images will be pushed","created_at":"2016-01-30T12:30:20Z","updated_at":"2016-01-30T12:30:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/19769#discussion_r51344454","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/51344454"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19769#discussion_r51344454"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769","id":56276908,"html_url":"https://github.com/kubernetes/kubernetes/pull/19769","diff_url":"https://github.com/kubernetes/kubernetes/pull/19769.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/19769.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19769","number":19769,"state":"open","locked":false,"title":"WIP: Add support for building arm, arm64 and ppc64le server and client targets","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"This one features support for building `arm`, `arm64` and `ppc64le` binaries dynamically or statically on `amd64` hosts.\r\n\r\nEarlier: \r\n - `arm`\r\n   - Server support only when building **on** an ARM hosts\r\n   - Client support also on `amd64` hosts\r\n - No `arm64` or `ppc64le` support at all.\r\n\r\nNow:\r\n - `arm`, `ppc64le`, `arm64`\r\n   - Server support when building on `amd64` hosts\r\n     - `kubelet` and `hyperkube` especially are built dynamically to include `cAdvisor`\r\n   - One patch already merged: #19712 for `arm64` to build server targets\r\n   - Client support present\r\n   - No test target support yet for `arm64`. \r\n     - It's `onsi/ginkgo` that is broken on `arm64`. I have a PR here: onsi/ginkgo#209\r\n     - But test target support isn't important at all for `arm`, `arm64`, `ppc64le`\r\n\r\nTracking issue: #17981 \r\nDepends on: #14873 \r\nA bit related to: #19703 \r\n\r\nWhen this is merged, it has the advantage that builds will fail when trying to merge only-working-on-amd64 code for the server targets, so it's easily noticed.\r\n\r\nThis is WIP for now because #14873 hasn't merged yet (and I have to rebase after that)\r\n> ~~However, if it takes too long time for  `arm64` and `ginkgo` to work, I'm gonna comment out `arm64` for the moment and merge that later.~~\r\n\r\nThoughts? This will make Kubernetes more cross-platform, and that will be awesome :+1: \r\n\r\n@brendandburns @thockin @zmerlynn @fgrzadkowski @david-mcmahon @mikedanese @gmarek @wojtek-t @qq511700505","created_at":"2016-01-17T12:42:54Z","updated_at":"2016-01-30T12:30:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb5eedc505569ff4568696d266c08aff7b5e1246","assignee":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/19769/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/428584bad3767d8aa2324ba82a9480d9f2b534d3","head":{"label":"luxas:server_cross_compilation","ref":"server_cross_compilation","sha":"428584bad3767d8aa2324ba82a9480d9f2b534d3","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"repo":{"id":37801743,"name":"kubernetes","full_name":"luxas/kubernetes","owner":{"login":"luxas","id":5442475,"avatar_url":"https://avatars.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luxas/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/luxas/kubernetes","forks_url":"https://api.github.com/repos/luxas/kubernetes/forks","keys_url":"https://api.github.com/repos/luxas/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luxas/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luxas/kubernetes/teams","hooks_url":"https://api.github.com/repos/luxas/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/luxas/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/luxas/kubernetes/events","assignees_url":"https://api.github.com/repos/luxas/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/luxas/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/luxas/kubernetes/tags","blobs_url":"https://api.github.com/repos/luxas/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luxas/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luxas/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/luxas/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luxas/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/luxas/kubernetes/languages","stargazers_url":"https://api.github.com/repos/luxas/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/luxas/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/luxas/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/luxas/kubernetes/subscription","commits_url":"https://api.github.com/repos/luxas/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/luxas/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/luxas/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/luxas/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/luxas/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/luxas/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luxas/kubernetes/merges","archive_url":"https://api.github.com/repos/luxas/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luxas/kubernetes/downloads","issues_url":"https://api.github.com/repos/luxas/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/luxas/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/luxas/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/luxas/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luxas/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/luxas/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/luxas/kubernetes/deployments","created_at":"2015-06-21T08:14:15Z","updated_at":"2016-01-11T14:11:00Z","pushed_at":"2016-01-30T12:21:42Z","git_url":"git://github.com/luxas/kubernetes.git","ssh_url":"git@github.com:luxas/kubernetes.git","clone_url":"https://github.com/luxas/kubernetes.git","svn_url":"https://github.com/luxas/kubernetes","homepage":"http://kubernetes.io","size":151966,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"311d8f8ab97ea80ce7162654128a34b983bafe96","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-01-30T08:45:07Z","pushed_at":"2016-01-30T12:25:56Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":313914,"stargazers_count":12422,"watchers_count":12422,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3518,"mirror_url":null,"open_issues_count":2830,"forks":3518,"open_issues":2830,"watchers":12422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/19769"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19769"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/19769/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/19769/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/428584bad3767d8aa2324ba82a9480d9f2b534d3"}}}}