{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/jcw/embencode/pulls/3","id":74702583,"html_url":"https://github.com/jcw/embencode/pull/3","diff_url":"https://github.com/jcw/embencode/pull/3.diff","patch_url":"https://github.com/jcw/embencode/pull/3.patch","issue_url":"https://api.github.com/repos/jcw/embencode/issues/3","number":3,"state":"open","locked":false,"title":"Make the PushChar method virtual to allow inheriting from EmBencode","user":{"login":"amotl","id":453543,"avatar_url":"https://avatars.githubusercontent.com/u/453543?v=3","gravatar_id":"","url":"https://api.github.com/users/amotl","html_url":"https://github.com/amotl","followers_url":"https://api.github.com/users/amotl/followers","following_url":"https://api.github.com/users/amotl/following{/other_user}","gists_url":"https://api.github.com/users/amotl/gists{/gist_id}","starred_url":"https://api.github.com/users/amotl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amotl/subscriptions","organizations_url":"https://api.github.com/users/amotl/orgs","repos_url":"https://api.github.com/users/amotl/repos","events_url":"https://api.github.com/users/amotl/events{/privacy}","received_events_url":"https://api.github.com/users/amotl/received_events","type":"User","site_admin":false},"body":"Dear Jean-Claude,\r\n\r\nalong the lines of #2 from @einsiedlerkrebs we have another change to *EmBencode* to improve its flexibility. At [Hiveeyes], we are aiming at functionality for automatically fragmenting data payloads.\r\n\r\nFor doing that, we would like to inherit our custom *[BERadioEncoder]* from the *EmBencode* encoder. To support making the `PushChar` method virtual, we needed to make some other methods non-static.\r\n\r\nWith kind regards,\r\nAndreas (on behalf of the Hiveeyes team).\r\n\r\nP.S.: We are operating one of your JeeLink devices on the gateway side, thanks a bunch for that and also for the opportunity to build our radio link communication upon the EmBencode library, which perfectly fitted our needs. You might also be interested in having a quick look at [BERadio], which is the specification and implementation of a little layer on top of Bencode we follow for encoding our data messages.\r\n\r\n[Hiveeyes]: https://hiveeyes.org/docs/system/\r\n[BERadioEncoder]: https://github.com/hiveeyes/arduino/blob/develop/libraries/BERadio/BERadio.cpp#L64\r\n[BERadio]: https://hiveeyes.org/docs/beradio/\r\n","created_at":"2016-06-21T23:27:50Z","updated_at":"2016-06-21T23:27:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jcw/embencode/pulls/3/commits","review_comments_url":"https://api.github.com/repos/jcw/embencode/pulls/3/comments","review_comment_url":"https://api.github.com/repos/jcw/embencode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jcw/embencode/issues/3/comments","statuses_url":"https://api.github.com/repos/jcw/embencode/statuses/68e3132af4940fad380dd2164e1f1d4e312097df","head":{"label":"hiveeyes:oo-improvements","ref":"oo-improvements","sha":"68e3132af4940fad380dd2164e1f1d4e312097df","user":{"login":"hiveeyes","id":15195291,"avatar_url":"https://avatars.githubusercontent.com/u/15195291?v=3","gravatar_id":"","url":"https://api.github.com/users/hiveeyes","html_url":"https://github.com/hiveeyes","followers_url":"https://api.github.com/users/hiveeyes/followers","following_url":"https://api.github.com/users/hiveeyes/following{/other_user}","gists_url":"https://api.github.com/users/hiveeyes/gists{/gist_id}","starred_url":"https://api.github.com/users/hiveeyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiveeyes/subscriptions","organizations_url":"https://api.github.com/users/hiveeyes/orgs","repos_url":"https://api.github.com/users/hiveeyes/repos","events_url":"https://api.github.com/users/hiveeyes/events{/privacy}","received_events_url":"https://api.github.com/users/hiveeyes/received_events","type":"Organization","site_admin":false},"repo":{"id":51530617,"name":"embencode","full_name":"hiveeyes/embencode","owner":{"login":"hiveeyes","id":15195291,"avatar_url":"https://avatars.githubusercontent.com/u/15195291?v=3","gravatar_id":"","url":"https://api.github.com/users/hiveeyes","html_url":"https://github.com/hiveeyes","followers_url":"https://api.github.com/users/hiveeyes/followers","following_url":"https://api.github.com/users/hiveeyes/following{/other_user}","gists_url":"https://api.github.com/users/hiveeyes/gists{/gist_id}","starred_url":"https://api.github.com/users/hiveeyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiveeyes/subscriptions","organizations_url":"https://api.github.com/users/hiveeyes/orgs","repos_url":"https://api.github.com/users/hiveeyes/repos","events_url":"https://api.github.com/users/hiveeyes/events{/privacy}","received_events_url":"https://api.github.com/users/hiveeyes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hiveeyes/embencode","description":"Bencode protocol support for embedded processors","fork":true,"url":"https://api.github.com/repos/hiveeyes/embencode","forks_url":"https://api.github.com/repos/hiveeyes/embencode/forks","keys_url":"https://api.github.com/repos/hiveeyes/embencode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiveeyes/embencode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiveeyes/embencode/teams","hooks_url":"https://api.github.com/repos/hiveeyes/embencode/hooks","issue_events_url":"https://api.github.com/repos/hiveeyes/embencode/issues/events{/number}","events_url":"https://api.github.com/repos/hiveeyes/embencode/events","assignees_url":"https://api.github.com/repos/hiveeyes/embencode/assignees{/user}","branches_url":"https://api.github.com/repos/hiveeyes/embencode/branches{/branch}","tags_url":"https://api.github.com/repos/hiveeyes/embencode/tags","blobs_url":"https://api.github.com/repos/hiveeyes/embencode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiveeyes/embencode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiveeyes/embencode/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiveeyes/embencode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiveeyes/embencode/statuses/{sha}","languages_url":"https://api.github.com/repos/hiveeyes/embencode/languages","stargazers_url":"https://api.github.com/repos/hiveeyes/embencode/stargazers","contributors_url":"https://api.github.com/repos/hiveeyes/embencode/contributors","subscribers_url":"https://api.github.com/repos/hiveeyes/embencode/subscribers","subscription_url":"https://api.github.com/repos/hiveeyes/embencode/subscription","commits_url":"https://api.github.com/repos/hiveeyes/embencode/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiveeyes/embencode/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiveeyes/embencode/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiveeyes/embencode/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiveeyes/embencode/contents/{+path}","compare_url":"https://api.github.com/repos/hiveeyes/embencode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiveeyes/embencode/merges","archive_url":"https://api.github.com/repos/hiveeyes/embencode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiveeyes/embencode/downloads","issues_url":"https://api.github.com/repos/hiveeyes/embencode/issues{/number}","pulls_url":"https://api.github.com/repos/hiveeyes/embencode/pulls{/number}","milestones_url":"https://api.github.com/repos/hiveeyes/embencode/milestones{/number}","notifications_url":"https://api.github.com/repos/hiveeyes/embencode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiveeyes/embencode/labels{/name}","releases_url":"https://api.github.com/repos/hiveeyes/embencode/releases{/id}","deployments_url":"https://api.github.com/repos/hiveeyes/embencode/deployments","created_at":"2016-02-11T17:05:53Z","updated_at":"2016-02-11T17:05:53Z","pushed_at":"2016-06-21T23:01:55Z","git_url":"git://github.com/hiveeyes/embencode.git","ssh_url":"git@github.com:hiveeyes/embencode.git","clone_url":"https://github.com/hiveeyes/embencode.git","svn_url":"https://github.com/hiveeyes/embencode","homepage":"","size":46,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jcw:master","ref":"master","sha":"389c2622cdc306a17dad5596dff64fdefb9e95b0","user":{"login":"jcw","id":148955,"avatar_url":"https://avatars.githubusercontent.com/u/148955?v=3","gravatar_id":"","url":"https://api.github.com/users/jcw","html_url":"https://github.com/jcw","followers_url":"https://api.github.com/users/jcw/followers","following_url":"https://api.github.com/users/jcw/following{/other_user}","gists_url":"https://api.github.com/users/jcw/gists{/gist_id}","starred_url":"https://api.github.com/users/jcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcw/subscriptions","organizations_url":"https://api.github.com/users/jcw/orgs","repos_url":"https://api.github.com/users/jcw/repos","events_url":"https://api.github.com/users/jcw/events{/privacy}","received_events_url":"https://api.github.com/users/jcw/received_events","type":"User","site_admin":false},"repo":{"id":6011234,"name":"embencode","full_name":"jcw/embencode","owner":{"login":"jcw","id":148955,"avatar_url":"https://avatars.githubusercontent.com/u/148955?v=3","gravatar_id":"","url":"https://api.github.com/users/jcw","html_url":"https://github.com/jcw","followers_url":"https://api.github.com/users/jcw/followers","following_url":"https://api.github.com/users/jcw/following{/other_user}","gists_url":"https://api.github.com/users/jcw/gists{/gist_id}","starred_url":"https://api.github.com/users/jcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcw/subscriptions","organizations_url":"https://api.github.com/users/jcw/orgs","repos_url":"https://api.github.com/users/jcw/repos","events_url":"https://api.github.com/users/jcw/events{/privacy}","received_events_url":"https://api.github.com/users/jcw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcw/embencode","description":"Bencode protocol support for embedded processors","fork":false,"url":"https://api.github.com/repos/jcw/embencode","forks_url":"https://api.github.com/repos/jcw/embencode/forks","keys_url":"https://api.github.com/repos/jcw/embencode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcw/embencode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcw/embencode/teams","hooks_url":"https://api.github.com/repos/jcw/embencode/hooks","issue_events_url":"https://api.github.com/repos/jcw/embencode/issues/events{/number}","events_url":"https://api.github.com/repos/jcw/embencode/events","assignees_url":"https://api.github.com/repos/jcw/embencode/assignees{/user}","branches_url":"https://api.github.com/repos/jcw/embencode/branches{/branch}","tags_url":"https://api.github.com/repos/jcw/embencode/tags","blobs_url":"https://api.github.com/repos/jcw/embencode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcw/embencode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcw/embencode/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcw/embencode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcw/embencode/statuses/{sha}","languages_url":"https://api.github.com/repos/jcw/embencode/languages","stargazers_url":"https://api.github.com/repos/jcw/embencode/stargazers","contributors_url":"https://api.github.com/repos/jcw/embencode/contributors","subscribers_url":"https://api.github.com/repos/jcw/embencode/subscribers","subscription_url":"https://api.github.com/repos/jcw/embencode/subscription","commits_url":"https://api.github.com/repos/jcw/embencode/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcw/embencode/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcw/embencode/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcw/embencode/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcw/embencode/contents/{+path}","compare_url":"https://api.github.com/repos/jcw/embencode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcw/embencode/merges","archive_url":"https://api.github.com/repos/jcw/embencode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcw/embencode/downloads","issues_url":"https://api.github.com/repos/jcw/embencode/issues{/number}","pulls_url":"https://api.github.com/repos/jcw/embencode/pulls{/number}","milestones_url":"https://api.github.com/repos/jcw/embencode/milestones{/number}","notifications_url":"https://api.github.com/repos/jcw/embencode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcw/embencode/labels{/name}","releases_url":"https://api.github.com/repos/jcw/embencode/releases{/id}","deployments_url":"https://api.github.com/repos/jcw/embencode/deployments","created_at":"2012-09-29T17:25:35Z","updated_at":"2016-05-18T22:47:28Z","pushed_at":"2016-02-11T18:25:51Z","git_url":"git://github.com/jcw/embencode.git","ssh_url":"git@github.com:jcw/embencode.git","clone_url":"https://github.com/jcw/embencode.git","svn_url":"https://github.com/jcw/embencode","homepage":"","size":45,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jcw/embencode/pulls/3"},"html":{"href":"https://github.com/jcw/embencode/pull/3"},"issue":{"href":"https://api.github.com/repos/jcw/embencode/issues/3"},"comments":{"href":"https://api.github.com/repos/jcw/embencode/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/jcw/embencode/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/jcw/embencode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jcw/embencode/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/jcw/embencode/statuses/68e3132af4940fad380dd2164e1f1d4e312097df"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":14,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"amotl"}}