{"action":"created","comment":{"url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/comments/77814980","id":77814980,"diff_hunk":"@@ -42,11 +42,11 @@ object KinesisClient {\n       awsSecretKey <- awsConfig.readString(\"secretAccessKey\")\n     } yield new StaticCredentialsProvider(new BasicAWSCredentials(awsAccessKey, awsSecretKey))\n \n-  private[this] def getStreamNameSuffix(streamNameRoot: String, config: Config): ConfigException Xor String =\n+  private[this] def streamNameWithSuffix(config: Config): ConfigException Xor (String => String) =\n     for {\n-      awsConfig <- config.configAt(\"aws\")\n-      streamNameSuffix <- config.readString(\"streamNameSuffix\")\n-    } yield streamNameRoot + \"-\" + streamNameSuffix\n+      awsConfig <- config.configAt(\"messaging.kinesis\")","path":"common-messaging/src/main/scala/org/genivi/sota/messaging/kinesis/KinesisClient.scala","position":35,"original_position":35,"commit_id":"8f42700e2cc7101d2381134a16f938b0056f6a43","original_commit_id":"8f42700e2cc7101d2381134a16f938b0056f6a43","user":{"login":"simao","id":203575,"avatar_url":"https://avatars.githubusercontent.com/u/203575?v=3","gravatar_id":"","url":"https://api.github.com/users/simao","html_url":"https://github.com/simao","followers_url":"https://api.github.com/users/simao/followers","following_url":"https://api.github.com/users/simao/following{/other_user}","gists_url":"https://api.github.com/users/simao/gists{/gist_id}","starred_url":"https://api.github.com/users/simao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simao/subscriptions","organizations_url":"https://api.github.com/users/simao/orgs","repos_url":"https://api.github.com/users/simao/repos","events_url":"https://api.github.com/users/simao/events{/privacy}","received_events_url":"https://api.github.com/users/simao/received_events","type":"User","site_admin":false},"body":"yes, you also need the next like `config => awsConfig`","created_at":"2016-09-07T12:52:19Z","updated_at":"2016-09-07T12:52:20Z","html_url":"https://github.com/advancedtelematic/rvi_sota_server/pull/554#discussion_r77814980","pull_request_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554","_links":{"self":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/comments/77814980"},"html":{"href":"https://github.com/advancedtelematic/rvi_sota_server/pull/554#discussion_r77814980"},"pull_request":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554"}}},"pull_request":{"url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554","id":84292722,"html_url":"https://github.com/advancedtelematic/rvi_sota_server/pull/554","diff_url":"https://github.com/advancedtelematic/rvi_sota_server/pull/554.diff","patch_url":"https://github.com/advancedtelematic/rvi_sota_server/pull/554.patch","issue_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/554","number":554,"state":"open","locked":false,"title":"Fix suffix for bus messages","user":{"login":"simao","id":203575,"avatar_url":"https://avatars.githubusercontent.com/u/203575?v=3","gravatar_id":"","url":"https://api.github.com/users/simao","html_url":"https://github.com/simao","followers_url":"https://api.github.com/users/simao/followers","following_url":"https://api.github.com/users/simao/following{/other_user}","gists_url":"https://api.github.com/users/simao/gists{/gist_id}","starred_url":"https://api.github.com/users/simao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simao/subscriptions","organizations_url":"https://api.github.com/users/simao/orgs","repos_url":"https://api.github.com/users/simao/repos","events_url":"https://api.github.com/users/simao/events{/privacy}","received_events_url":"https://api.github.com/users/simao/received_events","type":"User","site_admin":false},"body":"Add more logging","created_at":"2016-09-07T12:42:01Z","updated_at":"2016-09-07T12:52:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cfef9052ee794d1623feaa23989bfab84df1bc9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554/commits","review_comments_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554/comments","review_comment_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/554/comments","statuses_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/statuses/8f42700e2cc7101d2381134a16f938b0056f6a43","head":{"label":"advancedtelematic:bugfix/PRO-1326/fix_suffix","ref":"bugfix/PRO-1326/fix_suffix","sha":"8f42700e2cc7101d2381134a16f938b0056f6a43","user":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars.githubusercontent.com/u/7944633?v=3","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"repo":{"id":41109281,"name":"rvi_sota_server","full_name":"advancedtelematic/rvi_sota_server","owner":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars.githubusercontent.com/u/7944633?v=3","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advancedtelematic/rvi_sota_server","description":"SOTA Reference Implementation project - Server","fork":true,"url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server","forks_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/forks","keys_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/teams","hooks_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/hooks","issue_events_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/events{/number}","events_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/events","assignees_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/assignees{/user}","branches_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/branches{/branch}","tags_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/tags","blobs_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/statuses/{sha}","languages_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/languages","stargazers_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/stargazers","contributors_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/contributors","subscribers_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/subscribers","subscription_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/subscription","commits_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/contents/{+path}","compare_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/merges","archive_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/downloads","issues_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues{/number}","pulls_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls{/number}","milestones_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/milestones{/number}","notifications_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/labels{/name}","releases_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/releases{/id}","deployments_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/deployments","created_at":"2015-08-20T17:22:41Z","updated_at":"2016-03-10T11:05:03Z","pushed_at":"2016-09-07T12:48:23Z","git_url":"git://github.com/advancedtelematic/rvi_sota_server.git","ssh_url":"git@github.com:advancedtelematic/rvi_sota_server.git","clone_url":"https://github.com/advancedtelematic/rvi_sota_server.git","svn_url":"https://github.com/advancedtelematic/rvi_sota_server","homepage":null,"size":18654,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"advancedtelematic:master","ref":"master","sha":"f5a700fcb26cf2e4f4298971eefae693276906fa","user":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars.githubusercontent.com/u/7944633?v=3","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"repo":{"id":41109281,"name":"rvi_sota_server","full_name":"advancedtelematic/rvi_sota_server","owner":{"login":"advancedtelematic","id":7944633,"avatar_url":"https://avatars.githubusercontent.com/u/7944633?v=3","gravatar_id":"","url":"https://api.github.com/users/advancedtelematic","html_url":"https://github.com/advancedtelematic","followers_url":"https://api.github.com/users/advancedtelematic/followers","following_url":"https://api.github.com/users/advancedtelematic/following{/other_user}","gists_url":"https://api.github.com/users/advancedtelematic/gists{/gist_id}","starred_url":"https://api.github.com/users/advancedtelematic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advancedtelematic/subscriptions","organizations_url":"https://api.github.com/users/advancedtelematic/orgs","repos_url":"https://api.github.com/users/advancedtelematic/repos","events_url":"https://api.github.com/users/advancedtelematic/events{/privacy}","received_events_url":"https://api.github.com/users/advancedtelematic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advancedtelematic/rvi_sota_server","description":"SOTA Reference Implementation project - Server","fork":true,"url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server","forks_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/forks","keys_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/teams","hooks_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/hooks","issue_events_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/events{/number}","events_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/events","assignees_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/assignees{/user}","branches_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/branches{/branch}","tags_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/tags","blobs_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/statuses/{sha}","languages_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/languages","stargazers_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/stargazers","contributors_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/contributors","subscribers_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/subscribers","subscription_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/subscription","commits_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/contents/{+path}","compare_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/merges","archive_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/downloads","issues_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues{/number}","pulls_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls{/number}","milestones_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/milestones{/number}","notifications_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/labels{/name}","releases_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/releases{/id}","deployments_url":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/deployments","created_at":"2015-08-20T17:22:41Z","updated_at":"2016-03-10T11:05:03Z","pushed_at":"2016-09-07T12:48:23Z","git_url":"git://github.com/advancedtelematic/rvi_sota_server.git","ssh_url":"git@github.com:advancedtelematic/rvi_sota_server.git","clone_url":"https://github.com/advancedtelematic/rvi_sota_server.git","svn_url":"https://github.com/advancedtelematic/rvi_sota_server","homepage":null,"size":18654,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554"},"html":{"href":"https://github.com/advancedtelematic/rvi_sota_server/pull/554"},"issue":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/554"},"comments":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/advancedtelematic/rvi_sota_server/statuses/8f42700e2cc7101d2381134a16f938b0056f6a43"}}}}
{"actor":{"display_login":"simao"}}