{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments/85826685","pull_request_review_id":6519547,"id":85826685,"diff_hunk":"@@ -349,4 +349,10 @@\n   <data name=\"FilterTypeSelectorDescription\" xml:space=\"preserve\">\n     <value>Filter Types for Revit Filters</value>\n   </data>\n+  <data name=\"ExportColumnHeadersDescription\" xml:space=\"preserve\">","path":"src/Libraries/RevitNodesUI/Properties/Resources.resx","position":4,"original_position":4,"commit_id":"4b6064c31927cdd6cb8ca0f2589f4e38d5b2d6b4","original_commit_id":"4b6064c31927cdd6cb8ca0f2589f4e38d5b2d6b4","user":{"login":"ksobon","id":529781,"avatar_url":"https://avatars.githubusercontent.com/u/529781?v=3","gravatar_id":"","url":"https://api.github.com/users/ksobon","html_url":"https://github.com/ksobon","followers_url":"https://api.github.com/users/ksobon/followers","following_url":"https://api.github.com/users/ksobon/following{/other_user}","gists_url":"https://api.github.com/users/ksobon/gists{/gist_id}","starred_url":"https://api.github.com/users/ksobon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksobon/subscriptions","organizations_url":"https://api.github.com/users/ksobon/orgs","repos_url":"https://api.github.com/users/ksobon/repos","events_url":"https://api.github.com/users/ksobon/events{/privacy}","received_events_url":"https://api.github.com/users/ksobon/received_events","type":"User","site_admin":false},"body":"ExportColumnHeadersDescription is only needed for UI dropdown nodes so it should not be in the Revit Nodes resex. Right? ","created_at":"2016-10-31T20:34:10Z","updated_at":"2016-10-31T20:34:10Z","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1378#discussion_r85826685","pull_request_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments/85826685"},"html":{"href":"https://github.com/DynamoDS/DynamoRevit/pull/1378#discussion_r85826685"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378","id":91672158,"html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1378","diff_url":"https://github.com/DynamoDS/DynamoRevit/pull/1378.diff","patch_url":"https://github.com/DynamoDS/DynamoRevit/pull/1378.patch","issue_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1378","number":1378,"state":"open","locked":false,"title":"fixes to view schedule + export functionality","user":{"login":"ksobon","id":529781,"avatar_url":"https://avatars.githubusercontent.com/u/529781?v=3","gravatar_id":"","url":"https://api.github.com/users/ksobon","html_url":"https://github.com/ksobon","followers_url":"https://api.github.com/users/ksobon/followers","following_url":"https://api.github.com/users/ksobon/following{/other_user}","gists_url":"https://api.github.com/users/ksobon/gists{/gist_id}","starred_url":"https://api.github.com/users/ksobon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksobon/subscriptions","organizations_url":"https://api.github.com/users/ksobon/orgs","repos_url":"https://api.github.com/users/ksobon/repos","events_url":"https://api.github.com/users/ksobon/events{/privacy}","received_events_url":"https://api.github.com/users/ksobon/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nThese are two fixes to View Schedule:\r\n\r\n1. ViewSchedule.AddField node returns ViewSchedule object for every field it added. Fix to that was to change input type on fields from single to a List input. \r\n2. ViewSchedule.Create node will not rebind to previously created View, but instead try and create a new one causing an error. I added a binding routine to it, that fixed that issue. \r\n\r\nNew Functionality includes classes and objects related to Exporting View Schedules to textual format. It also adds two new overloads for creating regular schedules as well as material takeoffs. \r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [x] The level of testing this PR includes is appropriate\r\n- [x] User facing strings, if any, are extracted into `*.resx` files\r\n- [x] Snapshot of UI changes, if any.\r\n\r\n### Reviewers\r\n\r\n@ikeough @mjkkirschner \r\n\r\n### FYI\r\n\r\n@mjkkirschner that's the new PR that we talked about last week. \r\n\r\n","created_at":"2016-10-31T19:17:32Z","updated_at":"2016-10-31T20:34:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf3ca568ac44bd640c2fd0ba146aca928ea70513","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1378/comments","statuses_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/statuses/4b6064c31927cdd6cb8ca0f2589f4e38d5b2d6b4","head":{"label":"ksobon:R2017_ViewSchedule","ref":"R2017_ViewSchedule","sha":"4b6064c31927cdd6cb8ca0f2589f4e38d5b2d6b4","user":{"login":"ksobon","id":529781,"avatar_url":"https://avatars.githubusercontent.com/u/529781?v=3","gravatar_id":"","url":"https://api.github.com/users/ksobon","html_url":"https://github.com/ksobon","followers_url":"https://api.github.com/users/ksobon/followers","following_url":"https://api.github.com/users/ksobon/following{/other_user}","gists_url":"https://api.github.com/users/ksobon/gists{/gist_id}","starred_url":"https://api.github.com/users/ksobon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksobon/subscriptions","organizations_url":"https://api.github.com/users/ksobon/orgs","repos_url":"https://api.github.com/users/ksobon/repos","events_url":"https://api.github.com/users/ksobon/events{/privacy}","received_events_url":"https://api.github.com/users/ksobon/received_events","type":"User","site_admin":false},"repo":{"id":69196433,"name":"DynamoRevit","full_name":"ksobon/DynamoRevit","owner":{"login":"ksobon","id":529781,"avatar_url":"https://avatars.githubusercontent.com/u/529781?v=3","gravatar_id":"","url":"https://api.github.com/users/ksobon","html_url":"https://github.com/ksobon","followers_url":"https://api.github.com/users/ksobon/followers","following_url":"https://api.github.com/users/ksobon/following{/other_user}","gists_url":"https://api.github.com/users/ksobon/gists{/gist_id}","starred_url":"https://api.github.com/users/ksobon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksobon/subscriptions","organizations_url":"https://api.github.com/users/ksobon/orgs","repos_url":"https://api.github.com/users/ksobon/repos","events_url":"https://api.github.com/users/ksobon/events{/privacy}","received_events_url":"https://api.github.com/users/ksobon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksobon/DynamoRevit","description":"Dynamo Libraries for Revit","fork":true,"url":"https://api.github.com/repos/ksobon/DynamoRevit","forks_url":"https://api.github.com/repos/ksobon/DynamoRevit/forks","keys_url":"https://api.github.com/repos/ksobon/DynamoRevit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksobon/DynamoRevit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksobon/DynamoRevit/teams","hooks_url":"https://api.github.com/repos/ksobon/DynamoRevit/hooks","issue_events_url":"https://api.github.com/repos/ksobon/DynamoRevit/issues/events{/number}","events_url":"https://api.github.com/repos/ksobon/DynamoRevit/events","assignees_url":"https://api.github.com/repos/ksobon/DynamoRevit/assignees{/user}","branches_url":"https://api.github.com/repos/ksobon/DynamoRevit/branches{/branch}","tags_url":"https://api.github.com/repos/ksobon/DynamoRevit/tags","blobs_url":"https://api.github.com/repos/ksobon/DynamoRevit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksobon/DynamoRevit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksobon/DynamoRevit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksobon/DynamoRevit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksobon/DynamoRevit/statuses/{sha}","languages_url":"https://api.github.com/repos/ksobon/DynamoRevit/languages","stargazers_url":"https://api.github.com/repos/ksobon/DynamoRevit/stargazers","contributors_url":"https://api.github.com/repos/ksobon/DynamoRevit/contributors","subscribers_url":"https://api.github.com/repos/ksobon/DynamoRevit/subscribers","subscription_url":"https://api.github.com/repos/ksobon/DynamoRevit/subscription","commits_url":"https://api.github.com/repos/ksobon/DynamoRevit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksobon/DynamoRevit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksobon/DynamoRevit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksobon/DynamoRevit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ksobon/DynamoRevit/contents/{+path}","compare_url":"https://api.github.com/repos/ksobon/DynamoRevit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksobon/DynamoRevit/merges","archive_url":"https://api.github.com/repos/ksobon/DynamoRevit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksobon/DynamoRevit/downloads","issues_url":"https://api.github.com/repos/ksobon/DynamoRevit/issues{/number}","pulls_url":"https://api.github.com/repos/ksobon/DynamoRevit/pulls{/number}","milestones_url":"https://api.github.com/repos/ksobon/DynamoRevit/milestones{/number}","notifications_url":"https://api.github.com/repos/ksobon/DynamoRevit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksobon/DynamoRevit/labels{/name}","releases_url":"https://api.github.com/repos/ksobon/DynamoRevit/releases{/id}","deployments_url":"https://api.github.com/repos/ksobon/DynamoRevit/deployments","created_at":"2016-09-25T23:22:29Z","updated_at":"2016-09-25T23:22:34Z","pushed_at":"2016-10-31T20:02:03Z","git_url":"git://github.com/ksobon/DynamoRevit.git","ssh_url":"git@github.com:ksobon/DynamoRevit.git","clone_url":"https://github.com/ksobon/DynamoRevit.git","svn_url":"https://github.com/ksobon/DynamoRevit","homepage":"http://www.dynamobim.org","size":716838,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Revit2015"}},"base":{"label":"DynamoDS:Revit2017","ref":"Revit2017","sha":"36eb02033f9e9e3eda7a26d6d5f89d68e2e07948","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":22768182,"name":"DynamoRevit","full_name":"DynamoDS/DynamoRevit","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/DynamoRevit","description":"Dynamo Libraries for Revit","fork":false,"url":"https://api.github.com/repos/DynamoDS/DynamoRevit","forks_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/forks","keys_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/teams","hooks_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/events","assignees_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/tags","blobs_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/subscription","commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/merges","archive_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/downloads","issues_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/deployments","created_at":"2014-08-08T18:52:34Z","updated_at":"2016-10-28T18:24:05Z","pushed_at":"2016-10-31T20:02:04Z","git_url":"git://github.com/DynamoDS/DynamoRevit.git","ssh_url":"git@github.com:DynamoDS/DynamoRevit.git","clone_url":"https://github.com/DynamoDS/DynamoRevit.git","svn_url":"https://github.com/DynamoDS/DynamoRevit","homepage":"http://www.dynamobim.org","size":746020,"stargazers_count":30,"watchers_count":30,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":88,"forks":70,"open_issues":88,"watchers":30,"default_branch":"Revit2017"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378"},"html":{"href":"https://github.com/DynamoDS/DynamoRevit/pull/1378"},"issue":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1378"},"comments":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1378/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1378/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/DynamoRevit/statuses/4b6064c31927cdd6cb8ca0f2589f4e38d5b2d6b4"}}}}
{"actor":{"display_login":"ksobon"}}