{"action":"created","issue":{"url":"https://api.github.com/repos/ExcelDataReader/ExcelDataReader/issues/53","repository_url":"https://api.github.com/repos/ExcelDataReader/ExcelDataReader","labels_url":"https://api.github.com/repos/ExcelDataReader/ExcelDataReader/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/ExcelDataReader/ExcelDataReader/issues/53/comments","events_url":"https://api.github.com/repos/ExcelDataReader/ExcelDataReader/issues/53/events","html_url":"https://github.com/ExcelDataReader/ExcelDataReader/issues/53","id":57257825,"number":53,"title":"Cached formula string type ignored","user":{"login":"Jaecen","id":109625,"avatar_url":"https://avatars.githubusercontent.com/u/109625?v=3","gravatar_id":"","url":"https://api.github.com/users/Jaecen","html_url":"https://github.com/Jaecen","followers_url":"https://api.github.com/users/Jaecen/followers","following_url":"https://api.github.com/users/Jaecen/following{/other_user}","gists_url":"https://api.github.com/users/Jaecen/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaecen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaecen/subscriptions","organizations_url":"https://api.github.com/users/Jaecen/orgs","repos_url":"https://api.github.com/users/Jaecen/repos","events_url":"https://api.github.com/users/Jaecen/events{/privacy}","received_events_url":"https://api.github.com/users/Jaecen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-02-11T00:01:48Z","updated_at":"2016-05-25T13:06:38Z","closed_at":null,"body":"SpreadsheetML provides a \"str\" cell type on formula cells that indicates that the cached formula result should be read as a string. ExcelDataReader does not have support for this cell type and instead handles it as an untyped cell, converting the value to a double if .NET will parse it. Instead, it should be handled similar to an inline string.\r\n\r\nAdditionally, when ExcelOpenXmlReader reads a cell value it first [converts it to to a double if possible](../tree/2db357e6db7280a122fa27730baa17151095b2d6/Excel/ExcelOpenXmlReader.cs#L258-259). Then, if it determines that the cell was an inline string, it [converts the double back to a string](../tree/2db357e6db7280a122fa27730baa17151095b2d6/Excel/ExcelOpenXmlReader.cs#L265-268). This can cause loss of information, such as leading zeros and trailing commas and periods. Instead, inline string types should never be converted to a double. I believe this is similar to issues #47 and #31."},"comment":{"url":"https://api.github.com/repos/ExcelDataReader/ExcelDataReader/issues/comments/221569853","html_url":"https://github.com/ExcelDataReader/ExcelDataReader/issues/53#issuecomment-221569853","issue_url":"https://api.github.com/repos/ExcelDataReader/ExcelDataReader/issues/53","id":221569853,"user":{"login":"killergege","id":2920871,"avatar_url":"https://avatars.githubusercontent.com/u/2920871?v=3","gravatar_id":"","url":"https://api.github.com/users/killergege","html_url":"https://github.com/killergege","followers_url":"https://api.github.com/users/killergege/followers","following_url":"https://api.github.com/users/killergege/following{/other_user}","gists_url":"https://api.github.com/users/killergege/gists{/gist_id}","starred_url":"https://api.github.com/users/killergege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killergege/subscriptions","organizations_url":"https://api.github.com/users/killergege/orgs","repos_url":"https://api.github.com/users/killergege/repos","events_url":"https://api.github.com/users/killergege/events{/privacy}","received_events_url":"https://api.github.com/users/killergege/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T13:06:38Z","updated_at":"2016-05-25T13:06:38Z","body":"Ok, I applied (manually - I don't have a Git client here) the changes from the commit above on the right files (but ignored the changes on test files) to the current most recent version on GitHub and tried it with the TestApp included.\r\n\r\nI confirm that these changes fixes the specific issue that removes the leading zeros when the cell content is obtained from a formula.\r\nI only tested this case, but it works as expected for me.\r\n\r\n"}}
{"actor":{"display_login":"killergege"}}