{"push_id":1316848424,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"a78dc07f6bbc10c0e73e13cd221c2b9eb11e6d3a","before":"9dc8c03b1fe63b9054aca017ca47fd4fe3c2dbee","commits":[{"sha":"a78dc07f6bbc10c0e73e13cd221c2b9eb11e6d3a","author":{"name":"Mark Wubben","email":"fd1ed290c28236090ee5c195ebfc58186b22ec62@novemberborn.net"},"message":"Restore 100% code coverage, minor tweaks to #55 (#59)\n\n* Restore most of the original getWidget implementation\r\n\r\nCoverage for the else-branch of\r\n<https://github.com/dojo/app/blob/9dc8c03b1fe63b9054aca017ca47fd4fe3c2dbee/src/createApp.ts#L753:L755>\r\nbroke (see\r\n<https://github.com/dojo/app/blob/9dc8c03b1fe63b9054aca017ca47fd4fe3c2dbee/tests/unit/createApp/widgets.ts#L425>)\r\nbecause the registry was no longer called synchronously (see #55). Of\r\ncourse the test could have been amended, though the promise interaction\r\nwould've been tricky.\r\n\r\nRestoring most of the original implementation surfaced another error\r\nthat was swallowed by the `.catch()` chaining introduced in #55.\r\ncreateCustomWidget() would crash if there was no default widget store.\r\nI've added a guard to ensure createCustomWidget() is only called if\r\nthere is a default store.\r\n\r\n* Minor createCustomWidget improvement\r\n\r\nSince customFactory is called in a promise callback we can simply return\r\nand chain the next callback, without having to use Promise.resolve().","distinct":true,"url":"https://api.github.com/repos/dojo/app/commits/a78dc07f6bbc10c0e73e13cd221c2b9eb11e6d3a"}]}
{"actor":{"display_login":"novemberborn"}}