{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/bootkube/pulls/comments/71192348","id":71192348,"diff_hunk":"@@ -24,20 +24,60 @@ spec:\n         - --\n         - ./hyperkube\n         - kubelet\n-        - --api-servers={{ index .APIServers 0 }}\n-        - --config=/etc/kubernetes/manifests\n-        - --allow-privileged\n+        - --api-servers=$(API_SERVERS)\n+        - --config=$(CONFIG)\n+        - --allow-privileged=$(ALLOW_PRIVILEGED)\n         - --hostname-override=$(MY_POD_IP)\n-        - --cluster-dns=10.3.0.10\n-        - --cluster-domain=cluster.local\n-        - --kubeconfig=/etc/kubernetes/kubeconfig\n-        - --lock-file=/var/run/lock/kubelet.lock\n-        - --minimum-container-ttl-duration=3m0s\n+        - --cluster-dns=$(CLUSTER_DNS)\n+        - --cluster-domain=$(CLUSTER_DOMAIN)\n+        - --kubeconfig=$(KUBECONFIG)\n+        - --lock-file=$(LOCK_FILE)\n+        - --minimum-container-ttl-duration=$(MINIMUM_CONTAINER_TTL_DURATION)\n         env:\n           - name: MY_POD_IP\n             valueFrom:\n               fieldRef:\n                 fieldPath: status.podIP\n+          - name: API_SERVERS","path":"pkg/asset/templates/kubelet.yaml","position":26,"original_position":26,"commit_id":"269a5ea60c637531fd83673535678c6417fd547d","original_commit_id":"269a5ea60c637531fd83673535678c6417fd547d","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"body":"What do you think about just a single entry in the config map that is just like `kubelet.config: [all flags]` instead of dropping a file on disk? That way they are not handled individually, and we can still add/remove flags without having to change the kubelet manifest.","created_at":"2016-07-18T17:36:27Z","updated_at":"2016-07-18T17:36:27Z","html_url":"https://github.com/coreos/bootkube/pull/82#discussion_r71192348","pull_request_url":"https://api.github.com/repos/coreos/bootkube/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/coreos/bootkube/pulls/comments/71192348"},"html":{"href":"https://github.com/coreos/bootkube/pull/82#discussion_r71192348"},"pull_request":{"href":"https://api.github.com/repos/coreos/bootkube/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/bootkube/pulls/82","id":77385651,"html_url":"https://github.com/coreos/bootkube/pull/82","diff_url":"https://github.com/coreos/bootkube/pull/82.diff","patch_url":"https://github.com/coreos/bootkube/pull/82.patch","issue_url":"https://api.github.com/repos/coreos/bootkube/issues/82","number":82,"state":"open","locked":false,"title":"Node agent","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"body":"This set of patches introduces the node agent. The job of this process is to monitor the API server and look for certain annotations on the node object. Those annotations describe the desired config and kubelet version. Whenever those change, the process will update the corresponding systemd unit files and restart the kubelet service.\r\n\r\nThis allows for updates of the host kubelet. As of right now, the annotation process must be done manually. In the future, the node will be annotated via the update controller. The node-agent also ensures that the kubelet version is less than or equal to the current API server version.","created_at":"2016-07-14T00:57:33Z","updated_at":"2016-07-18T17:36:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7262d8a93311b9e13225ad3f37a91a75195a2151","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/bootkube/pulls/82/commits","review_comments_url":"https://api.github.com/repos/coreos/bootkube/pulls/82/comments","review_comment_url":"https://api.github.com/repos/coreos/bootkube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/bootkube/issues/82/comments","statuses_url":"https://api.github.com/repos/coreos/bootkube/statuses/269a5ea60c637531fd83673535678c6417fd547d","head":{"label":"derekparker:node-agent","ref":"node-agent","sha":"269a5ea60c637531fd83673535678c6417fd547d","user":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"repo":{"id":55725388,"name":"bootkube","full_name":"derekparker/bootkube","owner":{"login":"derekparker","id":1314079,"avatar_url":"https://avatars.githubusercontent.com/u/1314079?v=3","gravatar_id":"","url":"https://api.github.com/users/derekparker","html_url":"https://github.com/derekparker","followers_url":"https://api.github.com/users/derekparker/followers","following_url":"https://api.github.com/users/derekparker/following{/other_user}","gists_url":"https://api.github.com/users/derekparker/gists{/gist_id}","starred_url":"https://api.github.com/users/derekparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekparker/subscriptions","organizations_url":"https://api.github.com/users/derekparker/orgs","repos_url":"https://api.github.com/users/derekparker/repos","events_url":"https://api.github.com/users/derekparker/events{/privacy}","received_events_url":"https://api.github.com/users/derekparker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/derekparker/bootkube","description":"Bootkube","fork":true,"url":"https://api.github.com/repos/derekparker/bootkube","forks_url":"https://api.github.com/repos/derekparker/bootkube/forks","keys_url":"https://api.github.com/repos/derekparker/bootkube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/derekparker/bootkube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/derekparker/bootkube/teams","hooks_url":"https://api.github.com/repos/derekparker/bootkube/hooks","issue_events_url":"https://api.github.com/repos/derekparker/bootkube/issues/events{/number}","events_url":"https://api.github.com/repos/derekparker/bootkube/events","assignees_url":"https://api.github.com/repos/derekparker/bootkube/assignees{/user}","branches_url":"https://api.github.com/repos/derekparker/bootkube/branches{/branch}","tags_url":"https://api.github.com/repos/derekparker/bootkube/tags","blobs_url":"https://api.github.com/repos/derekparker/bootkube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/derekparker/bootkube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/derekparker/bootkube/git/refs{/sha}","trees_url":"https://api.github.com/repos/derekparker/bootkube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/derekparker/bootkube/statuses/{sha}","languages_url":"https://api.github.com/repos/derekparker/bootkube/languages","stargazers_url":"https://api.github.com/repos/derekparker/bootkube/stargazers","contributors_url":"https://api.github.com/repos/derekparker/bootkube/contributors","subscribers_url":"https://api.github.com/repos/derekparker/bootkube/subscribers","subscription_url":"https://api.github.com/repos/derekparker/bootkube/subscription","commits_url":"https://api.github.com/repos/derekparker/bootkube/commits{/sha}","git_commits_url":"https://api.github.com/repos/derekparker/bootkube/git/commits{/sha}","comments_url":"https://api.github.com/repos/derekparker/bootkube/comments{/number}","issue_comment_url":"https://api.github.com/repos/derekparker/bootkube/issues/comments{/number}","contents_url":"https://api.github.com/repos/derekparker/bootkube/contents/{+path}","compare_url":"https://api.github.com/repos/derekparker/bootkube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/derekparker/bootkube/merges","archive_url":"https://api.github.com/repos/derekparker/bootkube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/derekparker/bootkube/downloads","issues_url":"https://api.github.com/repos/derekparker/bootkube/issues{/number}","pulls_url":"https://api.github.com/repos/derekparker/bootkube/pulls{/number}","milestones_url":"https://api.github.com/repos/derekparker/bootkube/milestones{/number}","notifications_url":"https://api.github.com/repos/derekparker/bootkube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/derekparker/bootkube/labels{/name}","releases_url":"https://api.github.com/repos/derekparker/bootkube/releases{/id}","deployments_url":"https://api.github.com/repos/derekparker/bootkube/deployments","created_at":"2016-04-07T20:20:29Z","updated_at":"2016-04-07T20:20:30Z","pushed_at":"2016-07-14T17:29:45Z","git_url":"git://github.com/derekparker/bootkube.git","ssh_url":"git@github.com:derekparker/bootkube.git","clone_url":"https://github.com/derekparker/bootkube.git","svn_url":"https://github.com/derekparker/bootkube","homepage":null,"size":48486,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"82e4707df0c87476be4a2a865bb975aa265a45a6","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":53981347,"name":"bootkube","full_name":"coreos/bootkube","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/bootkube","description":"bootkube - Launch a self-hosted Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/coreos/bootkube","forks_url":"https://api.github.com/repos/coreos/bootkube/forks","keys_url":"https://api.github.com/repos/coreos/bootkube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/bootkube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/bootkube/teams","hooks_url":"https://api.github.com/repos/coreos/bootkube/hooks","issue_events_url":"https://api.github.com/repos/coreos/bootkube/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/bootkube/events","assignees_url":"https://api.github.com/repos/coreos/bootkube/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/bootkube/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/bootkube/tags","blobs_url":"https://api.github.com/repos/coreos/bootkube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/bootkube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/bootkube/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/bootkube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/bootkube/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/bootkube/languages","stargazers_url":"https://api.github.com/repos/coreos/bootkube/stargazers","contributors_url":"https://api.github.com/repos/coreos/bootkube/contributors","subscribers_url":"https://api.github.com/repos/coreos/bootkube/subscribers","subscription_url":"https://api.github.com/repos/coreos/bootkube/subscription","commits_url":"https://api.github.com/repos/coreos/bootkube/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/bootkube/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/bootkube/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/bootkube/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/bootkube/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/bootkube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/bootkube/merges","archive_url":"https://api.github.com/repos/coreos/bootkube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/bootkube/downloads","issues_url":"https://api.github.com/repos/coreos/bootkube/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/bootkube/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/bootkube/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/bootkube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/bootkube/labels{/name}","releases_url":"https://api.github.com/repos/coreos/bootkube/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/bootkube/deployments","created_at":"2016-03-15T21:58:22Z","updated_at":"2016-07-15T20:38:23Z","pushed_at":"2016-07-14T17:29:45Z","git_url":"git://github.com/coreos/bootkube.git","ssh_url":"git@github.com:coreos/bootkube.git","clone_url":"https://github.com/coreos/bootkube.git","svn_url":"https://github.com/coreos/bootkube","homepage":"","size":48491,"stargazers_count":77,"watchers_count":77,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/bootkube/pulls/82"},"html":{"href":"https://github.com/coreos/bootkube/pull/82"},"issue":{"href":"https://api.github.com/repos/coreos/bootkube/issues/82"},"comments":{"href":"https://api.github.com/repos/coreos/bootkube/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/bootkube/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/bootkube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/bootkube/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/bootkube/statuses/269a5ea60c637531fd83673535678c6417fd547d"}}}}
{"actor":{"display_login":"derekparker"}}