{"action":"opened","number":1196,"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1196","id":90666699,"html_url":"https://github.com/hibernate/hibernate-search/pull/1196","diff_url":"https://github.com/hibernate/hibernate-search/pull/1196.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/1196.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1196","number":1196,"state":"open","locked":false,"title":"New \"async\" IndexReader strategy, with performance tests","user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"body":" - https://hibernate.atlassian.net/browse/HSEARCH-2427\r\n - https://hibernate.atlassian.net/browse/HSEARCH-402\r\n\r\nThese are my results:\r\n```\r\n\r\nBenchmark                                                  (directorytype)  (indexSize)  (maxResults)  (readerStrategy)   Mode  Cnt     Score     Error  Units\r\nJMHBenchmarks.concurrentReadWriteTest                                   fs      5000000            10             async  thrpt   10  2021.166 ± 203.769  ops/s\r\nJMHBenchmarks.concurrentReadWriteTest:readWriteTestReader               fs      5000000            10             async  thrpt   10   259.620 ±  16.380  ops/s\r\nJMHBenchmarks.concurrentReadWriteTest:readWriteTestWriter               fs      5000000            10             async  thrpt   10  1761.546 ± 206.186  ops/s\r\nJMHBenchmarks.concurrentReadWriteTest                                   fs      5000000            10            shared  thrpt   10  1804.948 ± 132.665  ops/s\r\nJMHBenchmarks.concurrentReadWriteTest:readWriteTestReader               fs      5000000            10            shared  thrpt   10   159.672 ±  13.547  ops/s\r\nJMHBenchmarks.concurrentReadWriteTest:readWriteTestWriter               fs      5000000            10            shared  thrpt   10  1645.276 ± 139.887  ops/s\r\n```\r\n\r\nThe benchmark runs queries and index writes concurrently; the query is very simple so that it doesn't dominate the CPU usage; the high amount of concurrent writes will stress the `ReaderProvider`: as you can see in this scenario the new \"async\" reader strategy gives a good 60% performance boost.\r\n\r\nI actually expected more, but at least it proofs the point; I guess that with higher latency hard drives or larger indexes the benefit might get stronger.","created_at":"2016-10-24T18:28:40Z","updated_at":"2016-10-24T18:28:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1196/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1196/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1196/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/225fe4e8a22d383d2082df9fdddcade7aadc0f3d","head":{"label":"Sanne:HSEARCH-402","ref":"HSEARCH-402","sha":"225fe4e8a22d383d2082df9fdddcade7aadc0f3d","user":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"repo":{"id":1026619,"name":"hibernate-search","full_name":"Sanne/hibernate-search","owner":{"login":"Sanne","id":42573,"avatar_url":"https://avatars.githubusercontent.com/u/42573?v=3","gravatar_id":"","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following{/other_user}","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sanne/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/Sanne/hibernate-search","forks_url":"https://api.github.com/repos/Sanne/hibernate-search/forks","keys_url":"https://api.github.com/repos/Sanne/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sanne/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sanne/hibernate-search/teams","hooks_url":"https://api.github.com/repos/Sanne/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/Sanne/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/Sanne/hibernate-search/events","assignees_url":"https://api.github.com/repos/Sanne/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/Sanne/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/Sanne/hibernate-search/tags","blobs_url":"https://api.github.com/repos/Sanne/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sanne/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sanne/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sanne/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sanne/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/Sanne/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/Sanne/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/Sanne/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/Sanne/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/Sanne/hibernate-search/subscription","commits_url":"https://api.github.com/repos/Sanne/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sanne/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sanne/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sanne/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sanne/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/Sanne/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sanne/hibernate-search/merges","archive_url":"https://api.github.com/repos/Sanne/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sanne/hibernate-search/downloads","issues_url":"https://api.github.com/repos/Sanne/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/Sanne/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/Sanne/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/Sanne/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sanne/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/Sanne/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/Sanne/hibernate-search/deployments","created_at":"2010-10-26T20:06:17Z","updated_at":"2016-08-24T10:02:52Z","pushed_at":"2016-10-24T18:22:13Z","git_url":"git://github.com/Sanne/hibernate-search.git","ssh_url":"git@github.com:Sanne/hibernate-search.git","clone_url":"https://github.com/Sanne/hibernate-search.git","svn_url":"https://github.com/Sanne/hibernate-search","homepage":"http://search.hibernate.org","size":46962,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"4953fa102f9487eeff018c76a54a47895815f3e3","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-search/deployments","created_at":"2010-10-15T15:55:09Z","updated_at":"2016-10-06T11:25:00Z","pushed_at":"2016-10-24T18:28:40Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://search.hibernate.org","size":55710,"stargazers_count":197,"watchers_count":197,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":11,"forks":145,"open_issues":11,"watchers":197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1196"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1196"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1196"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1196/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1196/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1196/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/225fe4e8a22d383d2082df9fdddcade7aadc0f3d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":720,"deletions":138,"changed_files":15}}
{"actor":{"display_login":"Sanne"}}