{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/mjkaufer/Messer/pulls/14","id":90155955,"html_url":"https://github.com/mjkaufer/Messer/pull/14","diff_url":"https://github.com/mjkaufer/Messer/pull/14.diff","patch_url":"https://github.com/mjkaufer/Messer/pull/14.patch","issue_url":"https://api.github.com/repos/mjkaufer/Messer/issues/14","number":14,"state":"closed","locked":false,"title":"Refactor + additional commands","user":{"login":"tomquirk","id":12551741,"avatar_url":"https://avatars.githubusercontent.com/u/12551741?v=3","gravatar_id":"","url":"https://api.github.com/users/tomquirk","html_url":"https://github.com/tomquirk","followers_url":"https://api.github.com/users/tomquirk/followers","following_url":"https://api.github.com/users/tomquirk/following{/other_user}","gists_url":"https://api.github.com/users/tomquirk/gists{/gist_id}","starred_url":"https://api.github.com/users/tomquirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomquirk/subscriptions","organizations_url":"https://api.github.com/users/tomquirk/orgs","repos_url":"https://api.github.com/users/tomquirk/repos","events_url":"https://api.github.com/users/tomquirk/events{/privacy}","received_events_url":"https://api.github.com/users/tomquirk/received_events","type":"User","site_admin":false},"body":"I have slightly refactored the code, introducing more modularity and have allowed for easier additions to be made. These changes retain the existing commands (message and reply), whilst adding a new one, `contacts`, which lists all friends. All original code remains more or less in tact with minor changes for consistency, and may simply exist in different functions.\n\nFixes/enhancements: \n- added `contacts` command to get users friends list (cache this also)\n- `New message from _undefined_` fixed; uses friendlist lookup\n- Faster message sends, only 1 request made now; uses friendlist lookup\n- as of commit [7f5516f](https://github.com/mjkaufer/Messer/pull/14/commits/7f5516f8dcdfe56e96eb52ff95a97d8f190efcf2), issues #13 and #12 should be resolved\n\nNote: I aim to add more features when I get a chance, so this PR is just a step in a more maintainable direction.\n","created_at":"2016-10-20T08:41:27Z","updated_at":"2016-11-08T20:24:33Z","closed_at":"2016-11-08T20:24:33Z","merged_at":"2016-11-08T20:24:33Z","merge_commit_sha":"bcdbf40fd567fbd1d3bd166688f9c9f340a900ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mjkaufer/Messer/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mjkaufer/Messer/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mjkaufer/Messer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjkaufer/Messer/issues/14/comments","statuses_url":"https://api.github.com/repos/mjkaufer/Messer/statuses/7f5516f8dcdfe56e96eb52ff95a97d8f190efcf2","head":{"label":"tomquirk:master","ref":"master","sha":"7f5516f8dcdfe56e96eb52ff95a97d8f190efcf2","user":{"login":"tomquirk","id":12551741,"avatar_url":"https://avatars.githubusercontent.com/u/12551741?v=3","gravatar_id":"","url":"https://api.github.com/users/tomquirk","html_url":"https://github.com/tomquirk","followers_url":"https://api.github.com/users/tomquirk/followers","following_url":"https://api.github.com/users/tomquirk/following{/other_user}","gists_url":"https://api.github.com/users/tomquirk/gists{/gist_id}","starred_url":"https://api.github.com/users/tomquirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomquirk/subscriptions","organizations_url":"https://api.github.com/users/tomquirk/orgs","repos_url":"https://api.github.com/users/tomquirk/repos","events_url":"https://api.github.com/users/tomquirk/events{/privacy}","received_events_url":"https://api.github.com/users/tomquirk/received_events","type":"User","site_admin":false},"repo":{"id":70129431,"name":"Messer","full_name":"tomquirk/Messer","owner":{"login":"tomquirk","id":12551741,"avatar_url":"https://avatars.githubusercontent.com/u/12551741?v=3","gravatar_id":"","url":"https://api.github.com/users/tomquirk","html_url":"https://github.com/tomquirk","followers_url":"https://api.github.com/users/tomquirk/followers","following_url":"https://api.github.com/users/tomquirk/following{/other_user}","gists_url":"https://api.github.com/users/tomquirk/gists{/gist_id}","starred_url":"https://api.github.com/users/tomquirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomquirk/subscriptions","organizations_url":"https://api.github.com/users/tomquirk/orgs","repos_url":"https://api.github.com/users/tomquirk/repos","events_url":"https://api.github.com/users/tomquirk/events{/privacy}","received_events_url":"https://api.github.com/users/tomquirk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomquirk/Messer","description":":speech_balloon: Command-line messaging for Facebook Messenger","fork":true,"url":"https://api.github.com/repos/tomquirk/Messer","forks_url":"https://api.github.com/repos/tomquirk/Messer/forks","keys_url":"https://api.github.com/repos/tomquirk/Messer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomquirk/Messer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomquirk/Messer/teams","hooks_url":"https://api.github.com/repos/tomquirk/Messer/hooks","issue_events_url":"https://api.github.com/repos/tomquirk/Messer/issues/events{/number}","events_url":"https://api.github.com/repos/tomquirk/Messer/events","assignees_url":"https://api.github.com/repos/tomquirk/Messer/assignees{/user}","branches_url":"https://api.github.com/repos/tomquirk/Messer/branches{/branch}","tags_url":"https://api.github.com/repos/tomquirk/Messer/tags","blobs_url":"https://api.github.com/repos/tomquirk/Messer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomquirk/Messer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomquirk/Messer/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomquirk/Messer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomquirk/Messer/statuses/{sha}","languages_url":"https://api.github.com/repos/tomquirk/Messer/languages","stargazers_url":"https://api.github.com/repos/tomquirk/Messer/stargazers","contributors_url":"https://api.github.com/repos/tomquirk/Messer/contributors","subscribers_url":"https://api.github.com/repos/tomquirk/Messer/subscribers","subscription_url":"https://api.github.com/repos/tomquirk/Messer/subscription","commits_url":"https://api.github.com/repos/tomquirk/Messer/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomquirk/Messer/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomquirk/Messer/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomquirk/Messer/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomquirk/Messer/contents/{+path}","compare_url":"https://api.github.com/repos/tomquirk/Messer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomquirk/Messer/merges","archive_url":"https://api.github.com/repos/tomquirk/Messer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomquirk/Messer/downloads","issues_url":"https://api.github.com/repos/tomquirk/Messer/issues{/number}","pulls_url":"https://api.github.com/repos/tomquirk/Messer/pulls{/number}","milestones_url":"https://api.github.com/repos/tomquirk/Messer/milestones{/number}","notifications_url":"https://api.github.com/repos/tomquirk/Messer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomquirk/Messer/labels{/name}","releases_url":"https://api.github.com/repos/tomquirk/Messer/releases{/id}","deployments_url":"https://api.github.com/repos/tomquirk/Messer/deployments","created_at":"2016-10-06T06:43:16Z","updated_at":"2016-10-20T08:07:09Z","pushed_at":"2016-10-20T21:47:31Z","git_url":"git://github.com/tomquirk/Messer.git","ssh_url":"git@github.com:tomquirk/Messer.git","clone_url":"https://github.com/tomquirk/Messer.git","svn_url":"https://github.com/tomquirk/Messer","homepage":"https://www.npmjs.com/package/messer","size":21,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mjkaufer:master","ref":"master","sha":"00543878fc61e8bafaac74d04c6c63a18c00002f","user":{"login":"mjkaufer","id":1483405,"avatar_url":"https://avatars.githubusercontent.com/u/1483405?v=3","gravatar_id":"","url":"https://api.github.com/users/mjkaufer","html_url":"https://github.com/mjkaufer","followers_url":"https://api.github.com/users/mjkaufer/followers","following_url":"https://api.github.com/users/mjkaufer/following{/other_user}","gists_url":"https://api.github.com/users/mjkaufer/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkaufer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkaufer/subscriptions","organizations_url":"https://api.github.com/users/mjkaufer/orgs","repos_url":"https://api.github.com/users/mjkaufer/repos","events_url":"https://api.github.com/users/mjkaufer/events{/privacy}","received_events_url":"https://api.github.com/users/mjkaufer/received_events","type":"User","site_admin":false},"repo":{"id":38325755,"name":"Messer","full_name":"mjkaufer/Messer","owner":{"login":"mjkaufer","id":1483405,"avatar_url":"https://avatars.githubusercontent.com/u/1483405?v=3","gravatar_id":"","url":"https://api.github.com/users/mjkaufer","html_url":"https://github.com/mjkaufer","followers_url":"https://api.github.com/users/mjkaufer/followers","following_url":"https://api.github.com/users/mjkaufer/following{/other_user}","gists_url":"https://api.github.com/users/mjkaufer/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkaufer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkaufer/subscriptions","organizations_url":"https://api.github.com/users/mjkaufer/orgs","repos_url":"https://api.github.com/users/mjkaufer/repos","events_url":"https://api.github.com/users/mjkaufer/events{/privacy}","received_events_url":"https://api.github.com/users/mjkaufer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjkaufer/Messer","description":":speech_balloon: Command-line messaging for Facebook Messenger","fork":false,"url":"https://api.github.com/repos/mjkaufer/Messer","forks_url":"https://api.github.com/repos/mjkaufer/Messer/forks","keys_url":"https://api.github.com/repos/mjkaufer/Messer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjkaufer/Messer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjkaufer/Messer/teams","hooks_url":"https://api.github.com/repos/mjkaufer/Messer/hooks","issue_events_url":"https://api.github.com/repos/mjkaufer/Messer/issues/events{/number}","events_url":"https://api.github.com/repos/mjkaufer/Messer/events","assignees_url":"https://api.github.com/repos/mjkaufer/Messer/assignees{/user}","branches_url":"https://api.github.com/repos/mjkaufer/Messer/branches{/branch}","tags_url":"https://api.github.com/repos/mjkaufer/Messer/tags","blobs_url":"https://api.github.com/repos/mjkaufer/Messer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjkaufer/Messer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjkaufer/Messer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjkaufer/Messer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjkaufer/Messer/statuses/{sha}","languages_url":"https://api.github.com/repos/mjkaufer/Messer/languages","stargazers_url":"https://api.github.com/repos/mjkaufer/Messer/stargazers","contributors_url":"https://api.github.com/repos/mjkaufer/Messer/contributors","subscribers_url":"https://api.github.com/repos/mjkaufer/Messer/subscribers","subscription_url":"https://api.github.com/repos/mjkaufer/Messer/subscription","commits_url":"https://api.github.com/repos/mjkaufer/Messer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjkaufer/Messer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjkaufer/Messer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjkaufer/Messer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjkaufer/Messer/contents/{+path}","compare_url":"https://api.github.com/repos/mjkaufer/Messer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjkaufer/Messer/merges","archive_url":"https://api.github.com/repos/mjkaufer/Messer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjkaufer/Messer/downloads","issues_url":"https://api.github.com/repos/mjkaufer/Messer/issues{/number}","pulls_url":"https://api.github.com/repos/mjkaufer/Messer/pulls{/number}","milestones_url":"https://api.github.com/repos/mjkaufer/Messer/milestones{/number}","notifications_url":"https://api.github.com/repos/mjkaufer/Messer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjkaufer/Messer/labels{/name}","releases_url":"https://api.github.com/repos/mjkaufer/Messer/releases{/id}","deployments_url":"https://api.github.com/repos/mjkaufer/Messer/deployments","created_at":"2015-06-30T18:22:55Z","updated_at":"2016-11-07T13:23:19Z","pushed_at":"2016-11-08T20:24:33Z","git_url":"git://github.com/mjkaufer/Messer.git","ssh_url":"git@github.com:mjkaufer/Messer.git","clone_url":"https://github.com/mjkaufer/Messer.git","svn_url":"https://github.com/mjkaufer/Messer","homepage":"https://www.npmjs.com/package/messer","size":18,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjkaufer/Messer/pulls/14"},"html":{"href":"https://github.com/mjkaufer/Messer/pull/14"},"issue":{"href":"https://api.github.com/repos/mjkaufer/Messer/issues/14"},"comments":{"href":"https://api.github.com/repos/mjkaufer/Messer/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mjkaufer/Messer/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mjkaufer/Messer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjkaufer/Messer/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mjkaufer/Messer/statuses/7f5516f8dcdfe56e96eb52ff95a97d8f190efcf2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mjkaufer","id":1483405,"avatar_url":"https://avatars.githubusercontent.com/u/1483405?v=3","gravatar_id":"","url":"https://api.github.com/users/mjkaufer","html_url":"https://github.com/mjkaufer","followers_url":"https://api.github.com/users/mjkaufer/followers","following_url":"https://api.github.com/users/mjkaufer/following{/other_user}","gists_url":"https://api.github.com/users/mjkaufer/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkaufer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkaufer/subscriptions","organizations_url":"https://api.github.com/users/mjkaufer/orgs","repos_url":"https://api.github.com/users/mjkaufer/repos","events_url":"https://api.github.com/users/mjkaufer/events{/privacy}","received_events_url":"https://api.github.com/users/mjkaufer/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":6,"additions":216,"deletions":152,"changed_files":4}}
{"actor":{"display_login":"mjkaufer"}}