{"action":"closed","issue":{"url":"https://api.github.com/repos/xinthink/react-native-material-kit/issues/114","repository_url":"https://api.github.com/repos/xinthink/react-native-material-kit","labels_url":"https://api.github.com/repos/xinthink/react-native-material-kit/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/xinthink/react-native-material-kit/issues/114/comments","events_url":"https://api.github.com/repos/xinthink/react-native-material-kit/issues/114/events","html_url":"https://github.com/xinthink/react-native-material-kit/issues/114","id":139411166,"number":114,"title":"Make MKSlider's onPanResponderTerminationRequest prop `()=>false` or configurable","user":{"login":"marcoreat","id":15048404,"avatar_url":"https://avatars.githubusercontent.com/u/15048404?v=3","gravatar_id":"","url":"https://api.github.com/users/marcoreat","html_url":"https://github.com/marcoreat","followers_url":"https://api.github.com/users/marcoreat/followers","following_url":"https://api.github.com/users/marcoreat/following{/other_user}","gists_url":"https://api.github.com/users/marcoreat/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoreat/subscriptions","organizations_url":"https://api.github.com/users/marcoreat/orgs","repos_url":"https://api.github.com/users/marcoreat/repos","events_url":"https://api.github.com/users/marcoreat/events{/privacy}","received_events_url":"https://api.github.com/users/marcoreat/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-08T22:20:54Z","updated_at":"2016-05-31T18:42:25Z","closed_at":"2016-05-31T18:42:25Z","body":"Right now MKSlider has `onPanResponderTerminationRequest` property hardcoded to `()=>true` ([link](https://github.com/xinthink/react-native-material-kit/blob/master/lib/mdl/Slider.js#L61)). I propose that it should be either `()=>false` or configurable.\r\n\r\nThe property `onPanResponderTerminationRequest` specifies how the component behaves if another component wants to become the responder for the current gesture. (It's not documented well on the RN's [PanResponder page](https://facebook.github.io/react-native/docs/panresponder.html) but a similar documented property `onResponderTerminationRequest` exists in [the gesture responder system docs](https://facebook.github.io/react-native/docs/gesture-responder-system.html)).\r\n\r\nIn my app I'm placing a MKSlider component in a View that already responds to gesture events (with a PanResponder). However I'd like the MKSlider to have higher priority than the parent view.\r\n\r\nI think that having a slider that doesn't release focus is the most common use case. Actually I can't think of a situation where a MKSlider component would want to stop being the gesture responder. Here is a bug that happens when a SliderIOS component allows other gesture events: https://github.com/facebook/react-native/issues/1046#issuecomment-170347423 .\r\n\r\nWhat do others think?"}}
{"actor":{"display_login":"Crash--"}}