{"action":"created","comment":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/89615692","pull_request_review_id":10160266,"id":89615692,"diff_hunk":"@@ -49,13 +49,23 @@ def write_if_changed(text, outfilename):\n         f.write(text)\n \n def linux_syms(libfilename, outfilename):\n-    pe = subprocess.Popen(['readelf', '-d', libfilename], stdout=subprocess.PIPE, stderr=subprocess.PIPE)\n+    evar = 'READELF'\n+    if evar in os.environ:\n+        readelfbin = os.environ[evar].strip()\n+    else:\n+        readelfbin = 'readelf'\n+    evar = 'NM'\n+    if evar in os.environ:\n+        nmbin = os.environ[evar].strip()\n+    else:\n+        nmbin = 'nm'\n+    pe = subprocess.Popen([readelfbin, '-d', libfilename], stdout=subprocess.PIPE, stderr=subprocess.PIPE)\n     output = pe.communicate()[0].decode()\n     if pe.returncode != 0:\n         raise RuntimeError('Readelf does not work')\n     result = [x for x in output.split('\\n') if 'SONAME' in x]\n     assert(len(result) <= 1)\n-    pnm = subprocess.Popen(['nm', '--dynamic', '--extern-only', '--defined-only', '--format=posix', libfilename],\n+    pnm = subprocess.Popen([nmbin, '--dynamic', '--extern-only', '--defined-only', '--format=posix', libfilename],","path":"mesonbuild/scripts/symbolextractor.py","position":31,"original_position":31,"commit_id":"a75eaa92357c00d29b89b7cb6d79f42f833f05c4","original_commit_id":"a75eaa92357c00d29b89b7cb6d79f42f833f05c4","user":{"login":"Keruspe","id":222942,"avatar_url":"https://avatars.githubusercontent.com/u/222942?v=3","gravatar_id":"","url":"https://api.github.com/users/Keruspe","html_url":"https://github.com/Keruspe","followers_url":"https://api.github.com/users/Keruspe/followers","following_url":"https://api.github.com/users/Keruspe/following{/other_user}","gists_url":"https://api.github.com/users/Keruspe/gists{/gist_id}","starred_url":"https://api.github.com/users/Keruspe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keruspe/subscriptions","organizations_url":"https://api.github.com/users/Keruspe/orgs","repos_url":"https://api.github.com/users/Keruspe/repos","events_url":"https://api.github.com/users/Keruspe/events{/privacy}","received_events_url":"https://api.github.com/users/Keruspe/received_events","type":"User","site_admin":false},"body":"So, should I change anything there?","created_at":"2016-11-25T13:12:08Z","updated_at":"2016-11-25T13:12:08Z","html_url":"https://github.com/mesonbuild/meson/pull/1086#discussion_r89615692","pull_request_url":"https://api.github.com/repos/mesonbuild/meson/pulls/1086","_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments/89615692"},"html":{"href":"https://github.com/mesonbuild/meson/pull/1086#discussion_r89615692"},"pull_request":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1086"}}},"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/1086","id":94846557,"html_url":"https://github.com/mesonbuild/meson/pull/1086","diff_url":"https://github.com/mesonbuild/meson/pull/1086.diff","patch_url":"https://github.com/mesonbuild/meson/pull/1086.patch","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/1086","number":1086,"state":"open","locked":false,"title":"Allow specifying some toolchain executables using env","user":{"login":"Keruspe","id":222942,"avatar_url":"https://avatars.githubusercontent.com/u/222942?v=3","gravatar_id":"","url":"https://api.github.com/users/Keruspe","html_url":"https://github.com/Keruspe","followers_url":"https://api.github.com/users/Keruspe/followers","following_url":"https://api.github.com/users/Keruspe/following{/other_user}","gists_url":"https://api.github.com/users/Keruspe/gists{/gist_id}","starred_url":"https://api.github.com/users/Keruspe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keruspe/subscriptions","organizations_url":"https://api.github.com/users/Keruspe/orgs","repos_url":"https://api.github.com/users/Keruspe/repos","events_url":"https://api.github.com/users/Keruspe/events{/privacy}","received_events_url":"https://api.github.com/users/Keruspe/received_events","type":"User","site_admin":false},"body":"On Exherbo, during the configuration and compilation of packages, we're in a sandboxed environment where \"unprefixed\" tools such as cc, readelf or pkg-config are not available. All tools are prefixed by the target triple, even for native compilation.\r\nWhile CC is handled correctly, others aren't (pkg-config, readelf and nm were my blockers).\r\n\r\nI tried to follow the coding-style and idioms from other parts of the code and I believe the changes are simple enough but If another approach is preferred I can update the patchset as needed.","created_at":"2016-11-22T16:19:01Z","updated_at":"2016-11-25T13:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ccaec6e4365a6db27df668c86f7956bf4746b80","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mesonbuild/meson/milestones/4","html_url":"https://github.com/mesonbuild/meson/milestones/0.37.0","labels_url":"https://api.github.com/repos/mesonbuild/meson/milestones/4/labels","id":2123263,"number":4,"title":"0.37.0","description":"","creator":{"login":"nirbheek","id":75801,"avatar_url":"https://avatars.githubusercontent.com/u/75801?v=3","gravatar_id":"","url":"https://api.github.com/users/nirbheek","html_url":"https://github.com/nirbheek","followers_url":"https://api.github.com/users/nirbheek/followers","following_url":"https://api.github.com/users/nirbheek/following{/other_user}","gists_url":"https://api.github.com/users/nirbheek/gists{/gist_id}","starred_url":"https://api.github.com/users/nirbheek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirbheek/subscriptions","organizations_url":"https://api.github.com/users/nirbheek/orgs","repos_url":"https://api.github.com/users/nirbheek/repos","events_url":"https://api.github.com/users/nirbheek/events{/privacy}","received_events_url":"https://api.github.com/users/nirbheek/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":3,"state":"open","created_at":"2016-11-08T21:41:51Z","updated_at":"2016-11-23T15:35:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mesonbuild/meson/pulls/1086/commits","review_comments_url":"https://api.github.com/repos/mesonbuild/meson/pulls/1086/comments","review_comment_url":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/1086/comments","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/a75eaa92357c00d29b89b7cb6d79f42f833f05c4","head":{"label":"Keruspe:master","ref":"master","sha":"a75eaa92357c00d29b89b7cb6d79f42f833f05c4","user":{"login":"Keruspe","id":222942,"avatar_url":"https://avatars.githubusercontent.com/u/222942?v=3","gravatar_id":"","url":"https://api.github.com/users/Keruspe","html_url":"https://github.com/Keruspe","followers_url":"https://api.github.com/users/Keruspe/followers","following_url":"https://api.github.com/users/Keruspe/following{/other_user}","gists_url":"https://api.github.com/users/Keruspe/gists{/gist_id}","starred_url":"https://api.github.com/users/Keruspe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keruspe/subscriptions","organizations_url":"https://api.github.com/users/Keruspe/orgs","repos_url":"https://api.github.com/users/Keruspe/repos","events_url":"https://api.github.com/users/Keruspe/events{/privacy}","received_events_url":"https://api.github.com/users/Keruspe/received_events","type":"User","site_admin":false},"repo":{"id":74488329,"name":"meson","full_name":"Keruspe/meson","owner":{"login":"Keruspe","id":222942,"avatar_url":"https://avatars.githubusercontent.com/u/222942?v=3","gravatar_id":"","url":"https://api.github.com/users/Keruspe","html_url":"https://github.com/Keruspe","followers_url":"https://api.github.com/users/Keruspe/followers","following_url":"https://api.github.com/users/Keruspe/following{/other_user}","gists_url":"https://api.github.com/users/Keruspe/gists{/gist_id}","starred_url":"https://api.github.com/users/Keruspe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keruspe/subscriptions","organizations_url":"https://api.github.com/users/Keruspe/orgs","repos_url":"https://api.github.com/users/Keruspe/repos","events_url":"https://api.github.com/users/Keruspe/events{/privacy}","received_events_url":"https://api.github.com/users/Keruspe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Keruspe/meson","description":"The Meson Build System","fork":true,"url":"https://api.github.com/repos/Keruspe/meson","forks_url":"https://api.github.com/repos/Keruspe/meson/forks","keys_url":"https://api.github.com/repos/Keruspe/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keruspe/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keruspe/meson/teams","hooks_url":"https://api.github.com/repos/Keruspe/meson/hooks","issue_events_url":"https://api.github.com/repos/Keruspe/meson/issues/events{/number}","events_url":"https://api.github.com/repos/Keruspe/meson/events","assignees_url":"https://api.github.com/repos/Keruspe/meson/assignees{/user}","branches_url":"https://api.github.com/repos/Keruspe/meson/branches{/branch}","tags_url":"https://api.github.com/repos/Keruspe/meson/tags","blobs_url":"https://api.github.com/repos/Keruspe/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keruspe/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keruspe/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keruspe/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keruspe/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/Keruspe/meson/languages","stargazers_url":"https://api.github.com/repos/Keruspe/meson/stargazers","contributors_url":"https://api.github.com/repos/Keruspe/meson/contributors","subscribers_url":"https://api.github.com/repos/Keruspe/meson/subscribers","subscription_url":"https://api.github.com/repos/Keruspe/meson/subscription","commits_url":"https://api.github.com/repos/Keruspe/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keruspe/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keruspe/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keruspe/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keruspe/meson/contents/{+path}","compare_url":"https://api.github.com/repos/Keruspe/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keruspe/meson/merges","archive_url":"https://api.github.com/repos/Keruspe/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keruspe/meson/downloads","issues_url":"https://api.github.com/repos/Keruspe/meson/issues{/number}","pulls_url":"https://api.github.com/repos/Keruspe/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/Keruspe/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/Keruspe/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keruspe/meson/labels{/name}","releases_url":"https://api.github.com/repos/Keruspe/meson/releases{/id}","deployments_url":"https://api.github.com/repos/Keruspe/meson/deployments","created_at":"2016-11-22T15:51:08Z","updated_at":"2016-11-22T15:51:10Z","pushed_at":"2016-11-22T16:13:59Z","git_url":"git://github.com/Keruspe/meson.git","ssh_url":"git@github.com:Keruspe/meson.git","clone_url":"https://github.com/Keruspe/meson.git","svn_url":"https://github.com/Keruspe/meson","homepage":null,"size":4971,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mesonbuild:master","ref":"master","sha":"587a0bb3d14addcacd62282a46957b86d582f1be","user":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":19784232,"name":"meson","full_name":"mesonbuild/meson","owner":{"login":"mesonbuild","id":12551236,"avatar_url":"https://avatars.githubusercontent.com/u/12551236?v=3","gravatar_id":"","url":"https://api.github.com/users/mesonbuild","html_url":"https://github.com/mesonbuild","followers_url":"https://api.github.com/users/mesonbuild/followers","following_url":"https://api.github.com/users/mesonbuild/following{/other_user}","gists_url":"https://api.github.com/users/mesonbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/mesonbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesonbuild/subscriptions","organizations_url":"https://api.github.com/users/mesonbuild/orgs","repos_url":"https://api.github.com/users/mesonbuild/repos","events_url":"https://api.github.com/users/mesonbuild/events{/privacy}","received_events_url":"https://api.github.com/users/mesonbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesonbuild/meson","description":"The Meson Build System","fork":false,"url":"https://api.github.com/repos/mesonbuild/meson","forks_url":"https://api.github.com/repos/mesonbuild/meson/forks","keys_url":"https://api.github.com/repos/mesonbuild/meson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesonbuild/meson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesonbuild/meson/teams","hooks_url":"https://api.github.com/repos/mesonbuild/meson/hooks","issue_events_url":"https://api.github.com/repos/mesonbuild/meson/issues/events{/number}","events_url":"https://api.github.com/repos/mesonbuild/meson/events","assignees_url":"https://api.github.com/repos/mesonbuild/meson/assignees{/user}","branches_url":"https://api.github.com/repos/mesonbuild/meson/branches{/branch}","tags_url":"https://api.github.com/repos/mesonbuild/meson/tags","blobs_url":"https://api.github.com/repos/mesonbuild/meson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesonbuild/meson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesonbuild/meson/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesonbuild/meson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesonbuild/meson/statuses/{sha}","languages_url":"https://api.github.com/repos/mesonbuild/meson/languages","stargazers_url":"https://api.github.com/repos/mesonbuild/meson/stargazers","contributors_url":"https://api.github.com/repos/mesonbuild/meson/contributors","subscribers_url":"https://api.github.com/repos/mesonbuild/meson/subscribers","subscription_url":"https://api.github.com/repos/mesonbuild/meson/subscription","commits_url":"https://api.github.com/repos/mesonbuild/meson/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesonbuild/meson/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesonbuild/meson/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesonbuild/meson/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesonbuild/meson/contents/{+path}","compare_url":"https://api.github.com/repos/mesonbuild/meson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesonbuild/meson/merges","archive_url":"https://api.github.com/repos/mesonbuild/meson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesonbuild/meson/downloads","issues_url":"https://api.github.com/repos/mesonbuild/meson/issues{/number}","pulls_url":"https://api.github.com/repos/mesonbuild/meson/pulls{/number}","milestones_url":"https://api.github.com/repos/mesonbuild/meson/milestones{/number}","notifications_url":"https://api.github.com/repos/mesonbuild/meson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesonbuild/meson/labels{/name}","releases_url":"https://api.github.com/repos/mesonbuild/meson/releases{/id}","deployments_url":"https://api.github.com/repos/mesonbuild/meson/deployments","created_at":"2014-05-14T15:08:16Z","updated_at":"2016-11-24T18:09:59Z","pushed_at":"2016-11-25T03:40:56Z","git_url":"git://github.com/mesonbuild/meson.git","ssh_url":"git@github.com:mesonbuild/meson.git","clone_url":"https://github.com/mesonbuild/meson.git","svn_url":"https://github.com/mesonbuild/meson","homepage":null,"size":4925,"stargazers_count":569,"watchers_count":569,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":170,"forks":90,"open_issues":170,"watchers":569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1086"},"html":{"href":"https://github.com/mesonbuild/meson/pull/1086"},"issue":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/1086"},"comments":{"href":"https://api.github.com/repos/mesonbuild/meson/issues/1086/comments"},"review_comments":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1086/comments"},"review_comment":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesonbuild/meson/pulls/1086/commits"},"statuses":{"href":"https://api.github.com/repos/mesonbuild/meson/statuses/a75eaa92357c00d29b89b7cb6d79f42f833f05c4"}}}}
{"actor":{"display_login":"Keruspe"}}