{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments/61041333","id":61041333,"diff_hunk":"@@ -171,6 +171,8 @@\n #\n # $dhcp_provider::              DHCP provider\n #\n+# $dhcp_subnets::               DHCP subnets","path":"manifests/init.pp","position":4,"original_position":4,"commit_id":"80aceefe111a7f3a90c1b833941940f5753b4ca6","original_commit_id":"80aceefe111a7f3a90c1b833941940f5753b4ca6","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"If you could also expand the description, that would be very useful - e.g. \"List of subnets to restrict DHCP management to\"","created_at":"2016-04-26T07:47:26Z","updated_at":"2016-04-26T07:47:26Z","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237#discussion_r61041333","pull_request_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments/61041333"},"html":{"href":"https://github.com/theforeman/puppet-foreman_proxy/pull/237#discussion_r61041333"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237","id":67326438,"html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237","diff_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237.diff","patch_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/237.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237","number":237,"state":"open","locked":false,"title":"Add check for params dhcp_subnets","user":{"login":"andrei693","id":18531667,"avatar_url":"https://avatars.githubusercontent.com/u/18531667?v=3","gravatar_id":"","url":"https://api.github.com/users/andrei693","html_url":"https://github.com/andrei693","followers_url":"https://api.github.com/users/andrei693/followers","following_url":"https://api.github.com/users/andrei693/following{/other_user}","gists_url":"https://api.github.com/users/andrei693/gists{/gist_id}","starred_url":"https://api.github.com/users/andrei693/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrei693/subscriptions","organizations_url":"https://api.github.com/users/andrei693/orgs","repos_url":"https://api.github.com/users/andrei693/repos","events_url":"https://api.github.com/users/andrei693/events{/privacy}","received_events_url":"https://api.github.com/users/andrei693/received_events","type":"User","site_admin":false},"body":"Add new variable in params dhcp_subnets\r\nUse validate_re to do a basic check if the IP addresses/masks are numbers\r\nSet dhcp_subnets accordingly via template dhcp.yml.erb\r\nFixes GH-109","created_at":"2016-04-21T09:55:01Z","updated_at":"2016-04-26T07:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8f8cbb1b4022cabd8b63e7c349680b8f4729a85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/statuses/80aceefe111a7f3a90c1b833941940f5753b4ca6","head":{"label":"andrei693:Expose_DHCP_subnets_option_in_params","ref":"Expose_DHCP_subnets_option_in_params","sha":"80aceefe111a7f3a90c1b833941940f5753b4ca6","user":{"login":"andrei693","id":18531667,"avatar_url":"https://avatars.githubusercontent.com/u/18531667?v=3","gravatar_id":"","url":"https://api.github.com/users/andrei693","html_url":"https://github.com/andrei693","followers_url":"https://api.github.com/users/andrei693/followers","following_url":"https://api.github.com/users/andrei693/following{/other_user}","gists_url":"https://api.github.com/users/andrei693/gists{/gist_id}","starred_url":"https://api.github.com/users/andrei693/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrei693/subscriptions","organizations_url":"https://api.github.com/users/andrei693/orgs","repos_url":"https://api.github.com/users/andrei693/repos","events_url":"https://api.github.com/users/andrei693/events{/privacy}","received_events_url":"https://api.github.com/users/andrei693/received_events","type":"User","site_admin":false},"repo":{"id":56509419,"name":"puppet-foreman_proxy","full_name":"andrei693/puppet-foreman_proxy","owner":{"login":"andrei693","id":18531667,"avatar_url":"https://avatars.githubusercontent.com/u/18531667?v=3","gravatar_id":"","url":"https://api.github.com/users/andrei693","html_url":"https://github.com/andrei693","followers_url":"https://api.github.com/users/andrei693/followers","following_url":"https://api.github.com/users/andrei693/following{/other_user}","gists_url":"https://api.github.com/users/andrei693/gists{/gist_id}","starred_url":"https://api.github.com/users/andrei693/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrei693/subscriptions","organizations_url":"https://api.github.com/users/andrei693/orgs","repos_url":"https://api.github.com/users/andrei693/repos","events_url":"https://api.github.com/users/andrei693/events{/privacy}","received_events_url":"https://api.github.com/users/andrei693/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrei693/puppet-foreman_proxy","description":"Puppet module for Foreman Smart Proxy","fork":true,"url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy","forks_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/forks","keys_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/teams","hooks_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/hooks","issue_events_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/issues/events{/number}","events_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/events","assignees_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/assignees{/user}","branches_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/branches{/branch}","tags_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/tags","blobs_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/languages","stargazers_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/stargazers","contributors_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/contributors","subscribers_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/subscribers","subscription_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/subscription","commits_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/contents/{+path}","compare_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/merges","archive_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/downloads","issues_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/issues{/number}","pulls_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/labels{/name}","releases_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/releases{/id}","deployments_url":"https://api.github.com/repos/andrei693/puppet-foreman_proxy/deployments","created_at":"2016-04-18T13:20:16Z","updated_at":"2016-04-18T13:20:17Z","pushed_at":"2016-04-25T09:41:43Z","git_url":"git://github.com/andrei693/puppet-foreman_proxy.git","ssh_url":"git@github.com:andrei693/puppet-foreman_proxy.git","clone_url":"https://github.com/andrei693/puppet-foreman_proxy.git","svn_url":"https://github.com/andrei693/puppet-foreman_proxy","homepage":"","size":462,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"f9b886b98cc59fb32e04b42f8049dec4778d6b3b","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449602,"name":"puppet-foreman_proxy","full_name":"theforeman/puppet-foreman_proxy","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-foreman_proxy","description":"Puppet module for Foreman Smart Proxy","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy","forks_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/deployments","created_at":"2012-02-15T13:21:09Z","updated_at":"2016-01-12T01:30:49Z","pushed_at":"2016-04-25T09:41:44Z","git_url":"git://github.com/theforeman/puppet-foreman_proxy.git","ssh_url":"git@github.com:theforeman/puppet-foreman_proxy.git","clone_url":"https://github.com/theforeman/puppet-foreman_proxy.git","svn_url":"https://github.com/theforeman/puppet-foreman_proxy","homepage":"","size":598,"stargazers_count":25,"watchers_count":25,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":8,"forks":70,"open_issues":8,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237"},"html":{"href":"https://github.com/theforeman/puppet-foreman_proxy/pull/237"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/statuses/80aceefe111a7f3a90c1b833941940f5753b4ca6"}}}}