{"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/82529883","pull_request_review_id":3431867,"id":82529883,"diff_hunk":"@@ -149,11 +149,8 @@ module Base64\n   # Alphabet\" in RFC 4648.\n   #\n   # The alphabet uses '-' instead of '+' and '_' instead of '/'.\n-  #\n-  # The `padding` parameter defaults to false. When true, enough `=` characters\n-  # are added to make the output divisible by 3.\n   def urlsafe_encode(data, io : IO)","path":"src/base64.cr","position":36,"original_position":36,"commit_id":"e9bf383c49b33f7389bbe4757f2d08f7684d615a","original_commit_id":"e9bf383c49b33f7389bbe4757f2d08f7684d615a","user":{"login":"asterite","id":209371,"avatar_url":"https://avatars.githubusercontent.com/u/209371?v=3","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"body":"Should we have `padding = true` here too?","created_at":"2016-10-09T19:42:58Z","updated_at":"2016-10-09T19:42:58Z","html_url":"https://github.com/crystal-lang/crystal/pull/3403#discussion_r82529883","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/82529883"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/3403#discussion_r82529883"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403"}}},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403","id":88585001,"html_url":"https://github.com/crystal-lang/crystal/pull/3403","diff_url":"https://github.com/crystal-lang/crystal/pull/3403.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/3403.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/3403","number":3403,"state":"open","locked":false,"title":"Base64#urlsafe_encode now works as in ruby, fixed #3394","user":{"login":"kostya","id":95060,"avatar_url":"https://avatars.githubusercontent.com/u/95060?v=3","gravatar_id":"","url":"https://api.github.com/users/kostya","html_url":"https://github.com/kostya","followers_url":"https://api.github.com/users/kostya/followers","following_url":"https://api.github.com/users/kostya/following{/other_user}","gists_url":"https://api.github.com/users/kostya/gists{/gist_id}","starred_url":"https://api.github.com/users/kostya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostya/subscriptions","organizations_url":"https://api.github.com/users/kostya/orgs","repos_url":"https://api.github.com/users/kostya/repos","events_url":"https://api.github.com/users/kostya/events{/privacy}","received_events_url":"https://api.github.com/users/kostya/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-09T16:02:49Z","updated_at":"2016-10-09T19:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35a675716f6810c508cea49d25379aaf809516a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/3403/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/e9bf383c49b33f7389bbe4757f2d08f7684d615a","head":{"label":"kostya:base64_fix","ref":"base64_fix","sha":"e9bf383c49b33f7389bbe4757f2d08f7684d615a","user":{"login":"kostya","id":95060,"avatar_url":"https://avatars.githubusercontent.com/u/95060?v=3","gravatar_id":"","url":"https://api.github.com/users/kostya","html_url":"https://github.com/kostya","followers_url":"https://api.github.com/users/kostya/followers","following_url":"https://api.github.com/users/kostya/following{/other_user}","gists_url":"https://api.github.com/users/kostya/gists{/gist_id}","starred_url":"https://api.github.com/users/kostya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostya/subscriptions","organizations_url":"https://api.github.com/users/kostya/orgs","repos_url":"https://api.github.com/users/kostya/repos","events_url":"https://api.github.com/users/kostya/events{/privacy}","received_events_url":"https://api.github.com/users/kostya/received_events","type":"User","site_admin":false},"repo":{"id":10627463,"name":"crystal","full_name":"kostya/crystal","owner":{"login":"kostya","id":95060,"avatar_url":"https://avatars.githubusercontent.com/u/95060?v=3","gravatar_id":"","url":"https://api.github.com/users/kostya","html_url":"https://github.com/kostya","followers_url":"https://api.github.com/users/kostya/followers","following_url":"https://api.github.com/users/kostya/following{/other_user}","gists_url":"https://api.github.com/users/kostya/gists{/gist_id}","starred_url":"https://api.github.com/users/kostya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostya/subscriptions","organizations_url":"https://api.github.com/users/kostya/orgs","repos_url":"https://api.github.com/users/kostya/repos","events_url":"https://api.github.com/users/kostya/events{/privacy}","received_events_url":"https://api.github.com/users/kostya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kostya/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/kostya/crystal","forks_url":"https://api.github.com/repos/kostya/crystal/forks","keys_url":"https://api.github.com/repos/kostya/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kostya/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kostya/crystal/teams","hooks_url":"https://api.github.com/repos/kostya/crystal/hooks","issue_events_url":"https://api.github.com/repos/kostya/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/kostya/crystal/events","assignees_url":"https://api.github.com/repos/kostya/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/kostya/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/kostya/crystal/tags","blobs_url":"https://api.github.com/repos/kostya/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kostya/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kostya/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/kostya/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kostya/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/kostya/crystal/languages","stargazers_url":"https://api.github.com/repos/kostya/crystal/stargazers","contributors_url":"https://api.github.com/repos/kostya/crystal/contributors","subscribers_url":"https://api.github.com/repos/kostya/crystal/subscribers","subscription_url":"https://api.github.com/repos/kostya/crystal/subscription","commits_url":"https://api.github.com/repos/kostya/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/kostya/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/kostya/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/kostya/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/kostya/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/kostya/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kostya/crystal/merges","archive_url":"https://api.github.com/repos/kostya/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kostya/crystal/downloads","issues_url":"https://api.github.com/repos/kostya/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/kostya/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/kostya/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/kostya/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kostya/crystal/labels{/name}","releases_url":"https://api.github.com/repos/kostya/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/kostya/crystal/deployments","created_at":"2013-06-11T18:05:18Z","updated_at":"2016-05-07T12:01:04Z","pushed_at":"2016-10-09T18:18:10Z","git_url":"git://github.com/kostya/crystal.git","ssh_url":"git@github.com:kostya/crystal.git","clone_url":"https://github.com/kostya/crystal.git","svn_url":"https://github.com/kostya/crystal","homepage":"","size":31843,"stargazers_count":1,"watchers_count":1,"language":"Crystal","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"6c5fb5a3557c61e770a5c03a7d6d55421eb4c40b","user":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars.githubusercontent.com/u/6539796?v=3","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"name":"crystal","full_name":"crystal-lang/crystal","owner":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars.githubusercontent.com/u/6539796?v=3","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2016-10-09T18:28:08Z","pushed_at":"2016-10-09T19:36:00Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"git@github.com:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"http://crystal-lang.org","size":67153,"stargazers_count":6251,"watchers_count":6251,"language":"Crystal","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":505,"mirror_url":null,"open_issues_count":333,"forks":505,"open_issues":333,"watchers":6251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/3403"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/3403"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/3403/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3403/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/e9bf383c49b33f7389bbe4757f2d08f7684d615a"}}}}
{"actor":{"display_login":"asterite"}}