{"action":"opened","number":705,"pull_request":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/705","id":97663393,"html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/705","diff_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/705.diff","patch_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/705.patch","issue_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/705","number":705,"state":"open","locked":false,"title":"Update MSBuild packaging","user":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars.githubusercontent.com/u/116161?v=3","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"body":"This is a fairly significant change to rationalize how MSBuild is packaged with OmniSharp.\r\n\r\n- [x] Remove Microsoft.Build.Runtime from OmniSharp's project.json (since it won't work for Mono).\r\n- [x] Update build.cake to install Microsoft.Build.Runtime into packages folder\r\n- [x] Update build.cake to copy msbuild to '.msbuild-net46' and '.msbuild-netcoreapp1.0' folders (these will be used for debug and test)\r\n- [x] Update build.cake to copy the appropriate msbuild to the artifacts folders during publish. These are copied to an 'msbuild' subdirectory rather than directly in the OmniSharp folder.\r\n- [x] Add various .NET SDK packages which are used by newer MSBuild builds, which allow the \"Sdk\" to be specified in the .csproj as an attribute on the Project node.\r\n- [x] Copy Microsoft.CSharp.Core.targets to the 'msbuild' folder from the Microsoft.Net.Compilers package rather than including the file directly in OmniSharp.\r\n- [x] Update MSBuildProjectSystem to properly set MSBUILD_EXE_PATH and MSBuildSDKsPath environment variables so that MSBuild can locate itself.\r\n- [x] Update ProjectFileInfo to set the MSBuildExtensionsPath to the 'msbuild' subdirectory.\r\n\r\nWork yet to do:\r\n\r\n- [ ] Add net46 MSBuild for Mono\r\n- [ ] Various changes to build.cake to package the MSBuild for Mono on net46 builds for OSX/Linux\r\n- [ ] Update MSBuild tests to not deploy Microsoft.Build.Runtime and use the '.msbuild-net46' and '.msbuild-netcoreapp1.0' folders instead.\r\n- [ ] Ensure that MSBuild environment variables are set properly at debug time.","created_at":"2016-12-13T00:22:22Z","updated_at":"2016-12-13T00:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18bc9faa3a1e3bea746684efdc77c086f2a89232","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/705/commits","review_comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/705/comments","review_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/705/comments","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/969003b83b5d0a2c6af0f4c0b4491ea0eeda124a","head":{"label":"DustinCampbell:msbuild-package-acquisition","ref":"msbuild-package-acquisition","sha":"969003b83b5d0a2c6af0f4c0b4491ea0eeda124a","user":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars.githubusercontent.com/u/116161?v=3","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"repo":{"id":28405827,"name":"omnisharp-roslyn","full_name":"DustinCampbell/omnisharp-roslyn","owner":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars.githubusercontent.com/u/116161?v=3","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DustinCampbell/omnisharp-roslyn","description":"OmniSharp based on roslyn workspaces","fork":true,"url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn","forks_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/forks","keys_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/teams","hooks_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/hooks","issue_events_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/events","assignees_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/tags","blobs_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/languages","stargazers_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/stargazers","contributors_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/contributors","subscribers_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/subscribers","subscription_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/subscription","commits_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/merges","archive_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/downloads","issues_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/labels{/name}","releases_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/DustinCampbell/omnisharp-roslyn/deployments","created_at":"2014-12-23T15:45:56Z","updated_at":"2016-01-21T16:49:16Z","pushed_at":"2016-12-13T00:00:56Z","git_url":"git://github.com/DustinCampbell/omnisharp-roslyn.git","ssh_url":"git@github.com:DustinCampbell/omnisharp-roslyn.git","clone_url":"https://github.com/DustinCampbell/omnisharp-roslyn.git","svn_url":"https://github.com/DustinCampbell/omnisharp-roslyn","homepage":"","size":2405,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OmniSharp:new-msbuild","ref":"new-msbuild","sha":"5bb08711c3b1ababa06381b8e9d6c9e5c10e4a4a","user":{"login":"OmniSharp","id":9420663,"avatar_url":"https://avatars.githubusercontent.com/u/9420663?v=3","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"repo":{"id":27927984,"name":"omnisharp-roslyn","full_name":"OmniSharp/omnisharp-roslyn","owner":{"login":"OmniSharp","id":9420663,"avatar_url":"https://avatars.githubusercontent.com/u/9420663?v=3","gravatar_id":"","url":"https://api.github.com/users/OmniSharp","html_url":"https://github.com/OmniSharp","followers_url":"https://api.github.com/users/OmniSharp/followers","following_url":"https://api.github.com/users/OmniSharp/following{/other_user}","gists_url":"https://api.github.com/users/OmniSharp/gists{/gist_id}","starred_url":"https://api.github.com/users/OmniSharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmniSharp/subscriptions","organizations_url":"https://api.github.com/users/OmniSharp/orgs","repos_url":"https://api.github.com/users/OmniSharp/repos","events_url":"https://api.github.com/users/OmniSharp/events{/privacy}","received_events_url":"https://api.github.com/users/OmniSharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OmniSharp/omnisharp-roslyn","description":"OmniSharp based on roslyn workspaces","fork":false,"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn","forks_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/forks","keys_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/teams","hooks_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/hooks","issue_events_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/events","assignees_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/tags","blobs_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/languages","stargazers_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/stargazers","contributors_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/contributors","subscribers_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/subscribers","subscription_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/subscription","commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/merges","archive_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/downloads","issues_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/labels{/name}","releases_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/deployments","created_at":"2014-12-12T16:21:03Z","updated_at":"2016-12-11T08:56:40Z","pushed_at":"2016-12-13T00:22:22Z","git_url":"git://github.com/OmniSharp/omnisharp-roslyn.git","ssh_url":"git@github.com:OmniSharp/omnisharp-roslyn.git","clone_url":"https://github.com/OmniSharp/omnisharp-roslyn.git","svn_url":"https://github.com/OmniSharp/omnisharp-roslyn","homepage":"","size":9002,"stargazers_count":342,"watchers_count":342,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":123,"mirror_url":null,"open_issues_count":123,"forks":123,"open_issues":123,"watchers":342,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/705"},"html":{"href":"https://github.com/OmniSharp/omnisharp-roslyn/pull/705"},"issue":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/705"},"comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/705/comments"},"review_comments":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/705/comments"},"review_comment":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/705/commits"},"statuses":{"href":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/statuses/969003b83b5d0a2c6af0f4c0b4491ea0eeda124a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":9,"additions":246,"deletions":181,"changed_files":10}}
{"actor":{"display_login":"DustinCampbell"}}