{"action":"closed","issue":{"url":"https://api.github.com/repos/barnybug/cli53/issues/189","repository_url":"https://api.github.com/repos/barnybug/cli53","labels_url":"https://api.github.com/repos/barnybug/cli53/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/barnybug/cli53/issues/189/comments","events_url":"https://api.github.com/repos/barnybug/cli53/issues/189/events","html_url":"https://github.com/barnybug/cli53/issues/189","id":168907162,"number":189,"title":"Some CNAME records are missing periods","user":{"login":"nativex-dlepinski","id":12277470,"avatar_url":"https://avatars.githubusercontent.com/u/12277470?v=3","gravatar_id":"","url":"https://api.github.com/users/nativex-dlepinski","html_url":"https://github.com/nativex-dlepinski","followers_url":"https://api.github.com/users/nativex-dlepinski/followers","following_url":"https://api.github.com/users/nativex-dlepinski/following{/other_user}","gists_url":"https://api.github.com/users/nativex-dlepinski/gists{/gist_id}","starred_url":"https://api.github.com/users/nativex-dlepinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nativex-dlepinski/subscriptions","organizations_url":"https://api.github.com/users/nativex-dlepinski/orgs","repos_url":"https://api.github.com/users/nativex-dlepinski/repos","events_url":"https://api.github.com/users/nativex-dlepinski/events{/privacy}","received_events_url":"https://api.github.com/users/nativex-dlepinski/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-02T14:56:53Z","updated_at":"2016-08-30T09:02:28Z","closed_at":"2016-08-30T09:02:28Z","body":"### cli53 version (cli53 --version)\r\n.0.7.4\r\n\r\n### OS / Platform\r\nLinux\r\n\r\n### Expected behaviour\r\nThe code to fix CNAMEs records should add a period at the end of each CNAME record.\r\n\r\n### Actual behaviour\r\nThe code is fixing some CNAME records, but doesn't seem to fix CNAME records with dashes (-) in the domain url.\r\n\r\n### Steps to reproduce\r\n\r\nWe have multiple zones with dashes in the CNAME records. This issue happens in each one of them.\r\n\r\nFor example, this is a line from one of the bind files.\r\naws\t60\tIN\tCNAME\turl-with-dashes.domain.co ; AWS routing=\"WEIGHTED\" weight=1 healthCheckId=\"healthcheckID\" identifier=\"A1\"\r\n\r\nNo period is being added at the end of the domain.co, but periods are being added at the end of CNAMES without dashes in the domain within the same bind file.\r\n\r\n### Was the documentation missing information you required?\r\n\r\nPlease ensure you've checked: https://github.com/barnybug/cli53/blob/master/README.md\r\n\r\n### Could you contribute a fix or help testing with this issue?\r\nI will gladly help test.\r\n"}}
{"actor":{"display_login":"barnybug"}}