{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/72048334","id":72048334,"diff_hunk":"@@ -14,14 +14,23 @@ class Qjackctl < Formula\n   depends_on \"autoconf\" => :build\n   depends_on \"qt5\"\n   depends_on \"jack\"\n+  depends_on \"portaudio\" => :linked\n+\n+  # Fixes varaible length array error with LLVM/Clang\n+  # Reported upstream: https://github.com/rncbc/qjackctl/issues/17\n+  patch do\n+    url \"https://github.com/rncbc/qjackctl/pulls/18.patch\"\n+    sha256 \"cbb7cc72e0086b8e6df24c8c3a462dc0e9297f095573adb7a3cf98502a1902d4\"\n+  end\n \n   def install\n     system \"./autogen.sh\"\n     system \"./configure\", \"--disable-debug\",\n                           \"--enable-qt5\",\n                           \"--disable-dbus\",\n                           \"--disable-xunique\",\n-                          \"--prefix=#{prefix}\"\n+                          \"--prefix=#{prefix}\",\n+                          \"--with-qt5=#{Formula[\"qt5\"].prefix}\"","path":"Formula/qjackctl.rb","position":21,"original_position":21,"commit_id":"768fc76bda2d7a9fd0e9703ea6053c9f74d26f6a","original_commit_id":"768fc76bda2d7a9fd0e9703ea6053c9f74d26f6a","user":{"login":"muellermartin","id":343302,"avatar_url":"https://avatars.githubusercontent.com/u/343302?v=3","gravatar_id":"","url":"https://api.github.com/users/muellermartin","html_url":"https://github.com/muellermartin","followers_url":"https://api.github.com/users/muellermartin/followers","following_url":"https://api.github.com/users/muellermartin/following{/other_user}","gists_url":"https://api.github.com/users/muellermartin/gists{/gist_id}","starred_url":"https://api.github.com/users/muellermartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muellermartin/subscriptions","organizations_url":"https://api.github.com/users/muellermartin/orgs","repos_url":"https://api.github.com/users/muellermartin/repos","events_url":"https://api.github.com/users/muellermartin/events{/privacy}","received_events_url":"https://api.github.com/users/muellermartin/received_events","type":"User","site_admin":false},"body":"For me it's necessary (see #3278). I guess this is because `qt5` is not liked due to conflicts with `qt`...\r\nI'll update the formula to use `opt_prefix` instead of `prefix`.","created_at":"2016-07-25T11:31:48Z","updated_at":"2016-07-25T11:31:48Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/3281#discussion_r72048334","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/72048334"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/3281#discussion_r72048334"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281","id":78617843,"html_url":"https://github.com/Homebrew/homebrew-core/pull/3281","diff_url":"https://github.com/Homebrew/homebrew-core/pull/3281.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/3281.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3281","number":3281,"state":"open","locked":false,"title":"qjackctl: fix build errors","user":{"login":"muellermartin","id":343302,"avatar_url":"https://avatars.githubusercontent.com/u/343302?v=3","gravatar_id":"","url":"https://api.github.com/users/muellermartin","html_url":"https://github.com/muellermartin","followers_url":"https://api.github.com/users/muellermartin/followers","following_url":"https://api.github.com/users/muellermartin/following{/other_user}","gists_url":"https://api.github.com/users/muellermartin/gists{/gist_id}","starred_url":"https://api.github.com/users/muellermartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muellermartin/subscriptions","organizations_url":"https://api.github.com/users/muellermartin/orgs","repos_url":"https://api.github.com/users/muellermartin/repos","events_url":"https://api.github.com/users/muellermartin/events{/privacy}","received_events_url":"https://api.github.com/users/muellermartin/received_events","type":"User","site_admin":false},"body":"- [X] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/.github/CONTRIBUTING.md) document?\r\n- [X] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [X] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [X] Does your submission pass `brew audit --strict --online <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nqmake-qt5 cannot be found by the configure script. This is fixed adding\r\nthe prefix of the Qt5 installation as a configure option.\r\nBuilding with LLVM/Clang raises an error related to a variable sized\r\narray. This is fixed by patching a source file to use a dynamically\r\nallocated array instead.\r\n\r\nFixes #3278.","created_at":"2016-07-25T02:00:00Z","updated_at":"2016-07-25T11:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39226d546c92c2d77fd0ba83def8d49f80fbb350","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3281/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/768fc76bda2d7a9fd0e9703ea6053c9f74d26f6a","head":{"label":"muellermartin:fix-qjackctl","ref":"fix-qjackctl","sha":"768fc76bda2d7a9fd0e9703ea6053c9f74d26f6a","user":{"login":"muellermartin","id":343302,"avatar_url":"https://avatars.githubusercontent.com/u/343302?v=3","gravatar_id":"","url":"https://api.github.com/users/muellermartin","html_url":"https://github.com/muellermartin","followers_url":"https://api.github.com/users/muellermartin/followers","following_url":"https://api.github.com/users/muellermartin/following{/other_user}","gists_url":"https://api.github.com/users/muellermartin/gists{/gist_id}","starred_url":"https://api.github.com/users/muellermartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muellermartin/subscriptions","organizations_url":"https://api.github.com/users/muellermartin/orgs","repos_url":"https://api.github.com/users/muellermartin/repos","events_url":"https://api.github.com/users/muellermartin/events{/privacy}","received_events_url":"https://api.github.com/users/muellermartin/received_events","type":"User","site_admin":false},"repo":{"id":56353543,"name":"homebrew-core","full_name":"muellermartin/homebrew-core","owner":{"login":"muellermartin","id":343302,"avatar_url":"https://avatars.githubusercontent.com/u/343302?v=3","gravatar_id":"","url":"https://api.github.com/users/muellermartin","html_url":"https://github.com/muellermartin","followers_url":"https://api.github.com/users/muellermartin/followers","following_url":"https://api.github.com/users/muellermartin/following{/other_user}","gists_url":"https://api.github.com/users/muellermartin/gists{/gist_id}","starred_url":"https://api.github.com/users/muellermartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muellermartin/subscriptions","organizations_url":"https://api.github.com/users/muellermartin/orgs","repos_url":"https://api.github.com/users/muellermartin/repos","events_url":"https://api.github.com/users/muellermartin/events{/privacy}","received_events_url":"https://api.github.com/users/muellermartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muellermartin/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/muellermartin/homebrew-core","forks_url":"https://api.github.com/repos/muellermartin/homebrew-core/forks","keys_url":"https://api.github.com/repos/muellermartin/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muellermartin/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muellermartin/homebrew-core/teams","hooks_url":"https://api.github.com/repos/muellermartin/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/muellermartin/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/muellermartin/homebrew-core/events","assignees_url":"https://api.github.com/repos/muellermartin/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/muellermartin/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/muellermartin/homebrew-core/tags","blobs_url":"https://api.github.com/repos/muellermartin/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muellermartin/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muellermartin/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/muellermartin/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muellermartin/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/muellermartin/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/muellermartin/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/muellermartin/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/muellermartin/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/muellermartin/homebrew-core/subscription","commits_url":"https://api.github.com/repos/muellermartin/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/muellermartin/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/muellermartin/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/muellermartin/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/muellermartin/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/muellermartin/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muellermartin/homebrew-core/merges","archive_url":"https://api.github.com/repos/muellermartin/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muellermartin/homebrew-core/downloads","issues_url":"https://api.github.com/repos/muellermartin/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/muellermartin/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/muellermartin/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/muellermartin/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muellermartin/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/muellermartin/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/muellermartin/homebrew-core/deployments","created_at":"2016-04-15T22:32:57Z","updated_at":"2016-04-15T22:33:10Z","pushed_at":"2016-07-25T01:59:50Z","git_url":"git://github.com/muellermartin/homebrew-core.git","ssh_url":"git@github.com:muellermartin/homebrew-core.git","clone_url":"https://github.com/muellermartin/homebrew-core.git","svn_url":"https://github.com/muellermartin/homebrew-core","homepage":"http://brew.sh","size":64361,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"73364818ad2eedba8f40e6dee26562d58ad2e50e","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-07-25T09:28:53Z","pushed_at":"2016-07-25T11:18:02Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":101171,"stargazers_count":585,"watchers_count":585,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1026,"mirror_url":null,"open_issues_count":173,"forks":1026,"open_issues":173,"watchers":585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/3281"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3281"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3281/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3281/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/768fc76bda2d7a9fd0e9703ea6053c9f74d26f6a"}}}}
{"actor":{"display_login":"muellermartin"}}