{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/57532475","id":57532475,"diff_hunk":"@@ -59,11 +59,16 @@ public DyeableDataProcessor() {\n     }\n \n     public static boolean isDyeable(Item item) {\n-        return item.equals(Items.dye)\n-                || Block.getBlockFromItem(item).equals(Blocks.wool)\n-                || Block.getBlockFromItem(item).equals(Blocks.stained_glass)\n-                || Block.getBlockFromItem(item).equals(Blocks.stained_glass_pane)\n-                || Block.getBlockFromItem(item).equals(Blocks.stained_hardened_clay);\n+        if (item.equals(Items.dye)) {\n+            return true;\n+        }\n+\n+        Block bl = Block.getBlockFromItem(item);","path":"src/main/java/org/spongepowered/common/data/processor/data/DyeableDataProcessor.java","position":13,"original_position":13,"commit_id":"2852853dd0c69c98d8b03f9dc05a73237a7d9ffc","original_commit_id":"2852853dd0c69c98d8b03f9dc05a73237a7d9ffc","user":{"login":"kashike","id":5474071,"avatar_url":"https://avatars.githubusercontent.com/u/5474071?v=3","gravatar_id":"","url":"https://api.github.com/users/kashike","html_url":"https://github.com/kashike","followers_url":"https://api.github.com/users/kashike/followers","following_url":"https://api.github.com/users/kashike/following{/other_user}","gists_url":"https://api.github.com/users/kashike/gists{/gist_id}","starred_url":"https://api.github.com/users/kashike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kashike/subscriptions","organizations_url":"https://api.github.com/users/kashike/orgs","repos_url":"https://api.github.com/users/kashike/repos","events_url":"https://api.github.com/users/kashike/events{/privacy}","received_events_url":"https://api.github.com/users/kashike/received_events","type":"User","site_admin":false},"body":"Name it `block`? Three more characters won't hurt. :older_woman: ","created_at":"2016-03-27T18:03:50Z","updated_at":"2016-03-27T18:03:50Z","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/613#discussion_r57532475","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/57532475"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/613#discussion_r57532475"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613","id":64271419,"html_url":"https://github.com/SpongePowered/SpongeCommon/pull/613","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/613.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/613.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/613","number":613,"state":"open","locked":false,"title":"Add null check to DyeableDataProcessor#isDyeable","user":{"login":"dualspiral","id":1904167,"avatar_url":"https://avatars.githubusercontent.com/u/1904167?v=3","gravatar_id":"","url":"https://api.github.com/users/dualspiral","html_url":"https://github.com/dualspiral","followers_url":"https://api.github.com/users/dualspiral/followers","following_url":"https://api.github.com/users/dualspiral/following{/other_user}","gists_url":"https://api.github.com/users/dualspiral/gists{/gist_id}","starred_url":"https://api.github.com/users/dualspiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dualspiral/subscriptions","organizations_url":"https://api.github.com/users/dualspiral/orgs","repos_url":"https://api.github.com/users/dualspiral/repos","events_url":"https://api.github.com/users/dualspiral/events{/privacy}","received_events_url":"https://api.github.com/users/dualspiral/received_events","type":"User","site_admin":false},"body":"When running `ItemStack.supports(Keys.DYE_COLOR)` on an item that is not destined to become a block (or is not a dye), an NPE is thrown because `Block.getBlockFromItem(item)` returns `null`. This PR adds a null check to the method so that if the item is not a block, the method correctly returns `false`.","created_at":"2016-03-27T18:01:09Z","updated_at":"2016-03-27T18:03:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14c455df305e8b71e1a6550fa12e2d377d727fcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/613/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/2852853dd0c69c98d8b03f9dc05a73237a7d9ffc","head":{"label":"dualspiral:bugfix/dyeabledata","ref":"bugfix/dyeabledata","sha":"2852853dd0c69c98d8b03f9dc05a73237a7d9ffc","user":{"login":"dualspiral","id":1904167,"avatar_url":"https://avatars.githubusercontent.com/u/1904167?v=3","gravatar_id":"","url":"https://api.github.com/users/dualspiral","html_url":"https://github.com/dualspiral","followers_url":"https://api.github.com/users/dualspiral/followers","following_url":"https://api.github.com/users/dualspiral/following{/other_user}","gists_url":"https://api.github.com/users/dualspiral/gists{/gist_id}","starred_url":"https://api.github.com/users/dualspiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dualspiral/subscriptions","organizations_url":"https://api.github.com/users/dualspiral/orgs","repos_url":"https://api.github.com/users/dualspiral/repos","events_url":"https://api.github.com/users/dualspiral/events{/privacy}","received_events_url":"https://api.github.com/users/dualspiral/received_events","type":"User","site_admin":false},"repo":{"id":43213773,"name":"SpongeCommon","full_name":"dualspiral/SpongeCommon","owner":{"login":"dualspiral","id":1904167,"avatar_url":"https://avatars.githubusercontent.com/u/1904167?v=3","gravatar_id":"","url":"https://api.github.com/users/dualspiral","html_url":"https://github.com/dualspiral","followers_url":"https://api.github.com/users/dualspiral/followers","following_url":"https://api.github.com/users/dualspiral/following{/other_user}","gists_url":"https://api.github.com/users/dualspiral/gists{/gist_id}","starred_url":"https://api.github.com/users/dualspiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dualspiral/subscriptions","organizations_url":"https://api.github.com/users/dualspiral/orgs","repos_url":"https://api.github.com/users/dualspiral/repos","events_url":"https://api.github.com/users/dualspiral/events{/privacy}","received_events_url":"https://api.github.com/users/dualspiral/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dualspiral/SpongeCommon","description":"Shared code between Sponge and SpongeVanilla","fork":true,"url":"https://api.github.com/repos/dualspiral/SpongeCommon","forks_url":"https://api.github.com/repos/dualspiral/SpongeCommon/forks","keys_url":"https://api.github.com/repos/dualspiral/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dualspiral/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dualspiral/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/dualspiral/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/dualspiral/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/dualspiral/SpongeCommon/events","assignees_url":"https://api.github.com/repos/dualspiral/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/dualspiral/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/dualspiral/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/dualspiral/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dualspiral/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dualspiral/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dualspiral/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dualspiral/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/dualspiral/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/dualspiral/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/dualspiral/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/dualspiral/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/dualspiral/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/dualspiral/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dualspiral/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dualspiral/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dualspiral/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/dualspiral/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/dualspiral/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dualspiral/SpongeCommon/merges","archive_url":"https://api.github.com/repos/dualspiral/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dualspiral/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/dualspiral/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/dualspiral/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/dualspiral/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/dualspiral/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dualspiral/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/dualspiral/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/dualspiral/SpongeCommon/deployments","created_at":"2015-09-26T16:46:06Z","updated_at":"2016-03-05T09:59:01Z","pushed_at":"2016-03-27T17:55:59Z","git_url":"git://github.com/dualspiral/SpongeCommon.git","ssh_url":"git@github.com:dualspiral/SpongeCommon.git","clone_url":"https://github.com/dualspiral/SpongeCommon.git","svn_url":"https://github.com/dualspiral/SpongeCommon","homepage":null,"size":9458,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"3a460678fda8972f560645f8647038237679ed0a","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":33791453,"name":"SpongeCommon","full_name":"SpongePowered/SpongeCommon","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon","forks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/deployments","created_at":"2015-04-11T20:38:48Z","updated_at":"2016-03-25T20:23:42Z","pushed_at":"2016-03-27T18:01:10Z","git_url":"git://github.com/SpongePowered/SpongeCommon.git","ssh_url":"git@github.com:SpongePowered/SpongeCommon.git","clone_url":"https://github.com/SpongePowered/SpongeCommon.git","svn_url":"https://github.com/SpongePowered/SpongeCommon","homepage":"","size":15929,"stargazers_count":78,"watchers_count":78,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":93,"forks":77,"open_issues":93,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/613"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/613"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/2852853dd0c69c98d8b03f9dc05a73237a7d9ffc"}}}}