{"action":"created","issue":{"url":"https://api.github.com/repos/uTox/uTox/issues/507","repository_url":"https://api.github.com/repos/uTox/uTox","labels_url":"https://api.github.com/repos/uTox/uTox/issues/507/labels{/name}","comments_url":"https://api.github.com/repos/uTox/uTox/issues/507/comments","events_url":"https://api.github.com/repos/uTox/uTox/issues/507/events","html_url":"https://github.com/uTox/uTox/pull/507","id":191447235,"number":507,"title":"Refactor File Trasnefers, part 1","user":{"login":"GrayHatter","id":243408,"avatar_url":"https://avatars.githubusercontent.com/u/243408?v=3","gravatar_id":"","url":"https://api.github.com/users/GrayHatter","html_url":"https://github.com/GrayHatter","followers_url":"https://api.github.com/users/GrayHatter/followers","following_url":"https://api.github.com/users/GrayHatter/following{/other_user}","gists_url":"https://api.github.com/users/GrayHatter/gists{/gist_id}","starred_url":"https://api.github.com/users/GrayHatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrayHatter/subscriptions","organizations_url":"https://api.github.com/users/GrayHatter/orgs","repos_url":"https://api.github.com/users/GrayHatter/repos","events_url":"https://api.github.com/users/GrayHatter/events{/privacy}","received_events_url":"https://api.github.com/users/GrayHatter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-24T07:05:40Z","updated_at":"2016-12-08T09:40:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uTox/uTox/pulls/507","html_url":"https://github.com/uTox/uTox/pull/507","diff_url":"https://github.com/uTox/uTox/pull/507.diff","patch_url":"https://github.com/uTox/uTox/pull/507.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/utox/utox/507)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uTox/uTox/issues/comments/265696607","html_url":"https://github.com/uTox/uTox/pull/507#issuecomment-265696607","issue_url":"https://api.github.com/repos/uTox/uTox/issues/507","id":265696607,"user":{"login":"robinlinden","id":8304462,"avatar_url":"https://avatars.githubusercontent.com/u/8304462?v=3","gravatar_id":"","url":"https://api.github.com/users/robinlinden","html_url":"https://github.com/robinlinden","followers_url":"https://api.github.com/users/robinlinden/followers","following_url":"https://api.github.com/users/robinlinden/following{/other_user}","gists_url":"https://api.github.com/users/robinlinden/gists{/gist_id}","starred_url":"https://api.github.com/users/robinlinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinlinden/subscriptions","organizations_url":"https://api.github.com/users/robinlinden/orgs","repos_url":"https://api.github.com/users/robinlinden/repos","events_url":"https://api.github.com/users/robinlinden/events{/privacy}","received_events_url":"https://api.github.com/users/robinlinden/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T09:40:48Z","updated_at":"2016-12-08T09:40:48Z","body":"\n\n\n\nReviewed 2 of 8 files at r3, 1 of 1 files at r4.\nReview status: all files reviewed at latest revision, 19 unresolved discussions, some commit checks failed.\n\n---\n\n*[src/file_transfers.c, line 128 at r3](https://reviewable.io:443/reviews/utox/utox/507#-KYSdQnF7ocM4_wZKm9s:-KYSdQnF7ocM4_wZKm9t:bphr054) ([raw file](https://github.com/utox/utox/blob/690657356aa2b1667a2649b85a643d1f44dda9dd/src/file_transfers.c#L128)):*\n> ```C\n> static bool ft_init_resumable(FILE_TRANSFER *ft) {\n>     char name[UTOX_FILE_NAME_LENGTH];\n>     if (!resumeable_name(ft, name)) {\n> ```\n\nThis is equivalent to `if (true)` since resumeable_name always returns false.\n\n---\n\n*[src/file_transfers.c, line 144 at r3](https://reviewable.io:443/reviews/utox/utox/507#-KYSdqn-etoJAvUWgyzL:-KYSdqn-etoJAvUWgyzM:bphr054) ([raw file](https://github.com/utox/utox/blob/690657356aa2b1667a2649b85a643d1f44dda9dd/src/file_transfers.c#L144)):*\n> ```C\n> static void ft_decon_resumable(FILE_TRANSFER *ft) {\n>     char name[UTOX_FILE_NAME_LENGTH];\n>     if (!resumeable_name(ft, name)) {\n> ```\n\nThis is equivalent to `if (true)` since resumeable_name always returns false.\n\n---\n\n*[src/file_transfers.c, line 164 at r3](https://reviewable.io:443/reviews/utox/utox/507#-KYSdwBEWF7ORNoNmHI8:-KYSdwBEWF7ORNoNmHI9:bphr054) ([raw file](https://github.com/utox/utox/blob/690657356aa2b1667a2649b85a643d1f44dda9dd/src/file_transfers.c#L164)):*\n> ```C\n> static bool ft_find_resumeable(FILE_TRANSFER *ft) {\n>     char resume_name[UTOX_FILE_NAME_LENGTH];\n>     if (!resumeable_name(ft, resume_name)) {\n> ```\n\nThis is equivalent to `if (true)` since resumeable_name always returns false.\n\n---\n\n*[src/friend.h, line 82 at r3](https://reviewable.io:443/reviews/utox/utox/507#-KYShqZvGR8CJae5Emc8:-KYShqZvGR8CJae5Emc9:b-n53jgx) ([raw file](https://github.com/utox/utox/blob/690657356aa2b1667a2649b85a643d1f44dda9dd/src/friend.h#L82)):*\n> ```objc\n> \n>     FILE_TRANSFER  *file_transfers_incoming;\n>     uint16_t        file_transfers_incoming_size;\n> ```\n\nLooks like this is the number of incoming file transfers. Maybe rename them to _count? Same with file_transfers_outgoing_size.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/utox/utox/507)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"robinlinden"}}