{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/10","id":69594767,"html_url":"https://github.com/solidusio-contrib/solidus_active_shipping/pull/10","diff_url":"https://github.com/solidusio-contrib/solidus_active_shipping/pull/10.diff","patch_url":"https://github.com/solidusio-contrib/solidus_active_shipping/pull/10.patch","issue_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/issues/10","number":10,"state":"open","locked":false,"title":"WIP Add complete unit tests to the weight_limit spec","user":{"login":"dangerdogz","id":4110905,"avatar_url":"https://avatars.githubusercontent.com/u/4110905?v=3","gravatar_id":"","url":"https://api.github.com/users/dangerdogz","html_url":"https://github.com/dangerdogz","followers_url":"https://api.github.com/users/dangerdogz/followers","following_url":"https://api.github.com/users/dangerdogz/following{/other_user}","gists_url":"https://api.github.com/users/dangerdogz/gists{/gist_id}","starred_url":"https://api.github.com/users/dangerdogz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangerdogz/subscriptions","organizations_url":"https://api.github.com/users/dangerdogz/orgs","repos_url":"https://api.github.com/users/dangerdogz/repos","events_url":"https://api.github.com/users/dangerdogz/events{/privacy}","received_events_url":"https://api.github.com/users/dangerdogz/received_events","type":"User","site_admin":false},"body":"The weight limit spec and the associated methods contains a lot of code who looks unreachable or that we're not sure why or how it works (or even if we need it)\r\n\r\nThe plan would be to remove, refactor or extract some of those parts but they are virtually untested so I've begun adding unit tests for each individual methods.\r\n\r\nThis is a work in progress, comments and suggestions are very welcome.\r\n\r\nI also used transpec to update the syntax.","created_at":"2016-05-10T23:35:00Z","updated_at":"2016-05-10T23:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/10/commits","review_comments_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/10/comments","review_comment_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/issues/10/comments","statuses_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/statuses/cb6c5cf193bf52af481b9a2a6f7c76ec0161766e","head":{"label":"dangerdogz:weight_tests","ref":"weight_tests","sha":"cb6c5cf193bf52af481b9a2a6f7c76ec0161766e","user":{"login":"dangerdogz","id":4110905,"avatar_url":"https://avatars.githubusercontent.com/u/4110905?v=3","gravatar_id":"","url":"https://api.github.com/users/dangerdogz","html_url":"https://github.com/dangerdogz","followers_url":"https://api.github.com/users/dangerdogz/followers","following_url":"https://api.github.com/users/dangerdogz/following{/other_user}","gists_url":"https://api.github.com/users/dangerdogz/gists{/gist_id}","starred_url":"https://api.github.com/users/dangerdogz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangerdogz/subscriptions","organizations_url":"https://api.github.com/users/dangerdogz/orgs","repos_url":"https://api.github.com/users/dangerdogz/repos","events_url":"https://api.github.com/users/dangerdogz/events{/privacy}","received_events_url":"https://api.github.com/users/dangerdogz/received_events","type":"User","site_admin":false},"repo":{"id":57913472,"name":"solidus_active_shipping-1","full_name":"dangerdogz/solidus_active_shipping-1","owner":{"login":"dangerdogz","id":4110905,"avatar_url":"https://avatars.githubusercontent.com/u/4110905?v=3","gravatar_id":"","url":"https://api.github.com/users/dangerdogz","html_url":"https://github.com/dangerdogz","followers_url":"https://api.github.com/users/dangerdogz/followers","following_url":"https://api.github.com/users/dangerdogz/following{/other_user}","gists_url":"https://api.github.com/users/dangerdogz/gists{/gist_id}","starred_url":"https://api.github.com/users/dangerdogz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangerdogz/subscriptions","organizations_url":"https://api.github.com/users/dangerdogz/orgs","repos_url":"https://api.github.com/users/dangerdogz/repos","events_url":"https://api.github.com/users/dangerdogz/events{/privacy}","received_events_url":"https://api.github.com/users/dangerdogz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dangerdogz/solidus_active_shipping-1","description":":package: Solidus integration for Shopify's active_shipping gem.","fork":true,"url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1","forks_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/forks","keys_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/teams","hooks_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/hooks","issue_events_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/issues/events{/number}","events_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/events","assignees_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/assignees{/user}","branches_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/branches{/branch}","tags_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/tags","blobs_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/languages","stargazers_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/stargazers","contributors_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/contributors","subscribers_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/subscribers","subscription_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/subscription","commits_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/contents/{+path}","compare_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/merges","archive_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/downloads","issues_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/issues{/number}","pulls_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/labels{/name}","releases_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/releases{/id}","deployments_url":"https://api.github.com/repos/dangerdogz/solidus_active_shipping-1/deployments","created_at":"2016-05-02T18:58:35Z","updated_at":"2016-05-02T18:58:36Z","pushed_at":"2016-05-10T23:28:53Z","git_url":"git://github.com/dangerdogz/solidus_active_shipping-1.git","ssh_url":"git@github.com:dangerdogz/solidus_active_shipping-1.git","clone_url":"https://github.com/dangerdogz/solidus_active_shipping-1.git","svn_url":"https://github.com/dangerdogz/solidus_active_shipping-1","homepage":"","size":682,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio-contrib:master","ref":"master","sha":"6866b753371b90554d21478699595589ac07144e","user":{"login":"solidusio-contrib","id":15385649,"avatar_url":"https://avatars.githubusercontent.com/u/15385649?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio-contrib","html_url":"https://github.com/solidusio-contrib","followers_url":"https://api.github.com/users/solidusio-contrib/followers","following_url":"https://api.github.com/users/solidusio-contrib/following{/other_user}","gists_url":"https://api.github.com/users/solidusio-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio-contrib/subscriptions","organizations_url":"https://api.github.com/users/solidusio-contrib/orgs","repos_url":"https://api.github.com/users/solidusio-contrib/repos","events_url":"https://api.github.com/users/solidusio-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":57410574,"name":"solidus_active_shipping","full_name":"solidusio-contrib/solidus_active_shipping","owner":{"login":"solidusio-contrib","id":15385649,"avatar_url":"https://avatars.githubusercontent.com/u/15385649?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio-contrib","html_url":"https://github.com/solidusio-contrib","followers_url":"https://api.github.com/users/solidusio-contrib/followers","following_url":"https://api.github.com/users/solidusio-contrib/following{/other_user}","gists_url":"https://api.github.com/users/solidusio-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio-contrib/subscriptions","organizations_url":"https://api.github.com/users/solidusio-contrib/orgs","repos_url":"https://api.github.com/users/solidusio-contrib/repos","events_url":"https://api.github.com/users/solidusio-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio-contrib/solidus_active_shipping","description":":package: Solidus integration for Shopify's active_shipping gem.","fork":false,"url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping","forks_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/forks","keys_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/teams","hooks_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/hooks","issue_events_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/events","assignees_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/tags","blobs_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/languages","stargazers_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/stargazers","contributors_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/contributors","subscribers_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/subscribers","subscription_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/subscription","commits_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/merges","archive_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/downloads","issues_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/labels{/name}","releases_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/deployments","created_at":"2016-04-29T20:17:56Z","updated_at":"2016-05-02T18:50:12Z","pushed_at":"2016-05-10T20:33:16Z","git_url":"git://github.com/solidusio-contrib/solidus_active_shipping.git","ssh_url":"git@github.com:solidusio-contrib/solidus_active_shipping.git","clone_url":"https://github.com/solidusio-contrib/solidus_active_shipping.git","svn_url":"https://github.com/solidusio-contrib/solidus_active_shipping","homepage":"","size":683,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/10"},"html":{"href":"https://github.com/solidusio-contrib/solidus_active_shipping/pull/10"},"issue":{"href":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/issues/10"},"comments":{"href":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio-contrib/solidus_active_shipping/statuses/cb6c5cf193bf52af481b9a2a6f7c76ec0161766e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":167,"deletions":26,"changed_files":1}}