{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62215197","id":62215197,"diff_hunk":"@@ -852,6 +856,15 @@ func (gce *GCECloud) createTargetPool(name, serviceName, region string, hosts []\n \tfor _, host := range hosts {\n \t\tinstances = append(instances, makeHostURL(gce.projectID, host.Zone, host.Name))\n \t}\n+\tif len(instances) > maxInstancesPerTargetPool {","path":"pkg/cloudprovider/providers/gce/gce.go","position":22,"original_position":22,"commit_id":"b99b8f2eee5dd21f2ba336eb236f0314b77c1158","original_commit_id":"b99b8f2eee5dd21f2ba336eb236f0314b77c1158","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"We don't have the list of Nodes here, which means pulling another O(thousands) list.  It's probably the right thing to do, but I feel like this is moot eventually and we don't filter for healthy nodes today...","created_at":"2016-05-05T16:43:40Z","updated_at":"2016-05-05T16:43:40Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25178#discussion_r62215197","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62215197"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25178#discussion_r62215197"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178","id":68950836,"html_url":"https://github.com/kubernetes/kubernetes/pull/25178","diff_url":"https://github.com/kubernetes/kubernetes/pull/25178.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25178.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25178","number":25178,"state":"open","locked":false,"title":"GCE: Allow node count to exceed GCE TargetPool maximums","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"body":"```release-note\r\nIf the cluster node count exceeds the GCE TargetPool maximum (currently 1000),\r\nrandomly select which nodes are members of Kubernetes External Load Balancers.\r\n```\r\n\r\n\r\n[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()\r\n\r\nIf we would exceeded the TargetPool API maximums, instead just\r\nrandomly select some subsection of the nodes to include in the TP\r\ninstead.","created_at":"2016-05-04T23:59:55Z","updated_at":"2016-05-05T16:43:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fdc82d45e37b5f8749a9bc6899b100805de9727","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25178/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b99b8f2eee5dd21f2ba336eb236f0314b77c1158","head":{"label":"zmerlynn:random_max_target_pools","ref":"random_max_target_pools","sha":"b99b8f2eee5dd21f2ba336eb236f0314b77c1158","user":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"repo":{"id":27641977,"name":"kubernetes","full_name":"zmerlynn/kubernetes","owner":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmerlynn/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/zmerlynn/kubernetes","forks_url":"https://api.github.com/repos/zmerlynn/kubernetes/forks","keys_url":"https://api.github.com/repos/zmerlynn/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmerlynn/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmerlynn/kubernetes/teams","hooks_url":"https://api.github.com/repos/zmerlynn/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/zmerlynn/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/zmerlynn/kubernetes/events","assignees_url":"https://api.github.com/repos/zmerlynn/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/zmerlynn/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/zmerlynn/kubernetes/tags","blobs_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmerlynn/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/zmerlynn/kubernetes/languages","stargazers_url":"https://api.github.com/repos/zmerlynn/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/zmerlynn/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/zmerlynn/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/zmerlynn/kubernetes/subscription","commits_url":"https://api.github.com/repos/zmerlynn/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmerlynn/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmerlynn/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmerlynn/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmerlynn/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/zmerlynn/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmerlynn/kubernetes/merges","archive_url":"https://api.github.com/repos/zmerlynn/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmerlynn/kubernetes/downloads","issues_url":"https://api.github.com/repos/zmerlynn/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/zmerlynn/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/zmerlynn/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/zmerlynn/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmerlynn/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/zmerlynn/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/zmerlynn/kubernetes/deployments","created_at":"2014-12-06T17:10:41Z","updated_at":"2014-12-06T19:12:25Z","pushed_at":"2016-05-04T23:54:38Z","git_url":"git://github.com/zmerlynn/kubernetes.git","ssh_url":"git@github.com:zmerlynn/kubernetes.git","clone_url":"https://github.com/zmerlynn/kubernetes.git","svn_url":"https://github.com/zmerlynn/kubernetes","homepage":null,"size":187712,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e09ce3668bed0ec590420552c17403c1570db8fb","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-05T15:07:35Z","pushed_at":"2016-05-05T16:38:32Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":390789,"stargazers_count":14225,"watchers_count":14225,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4254,"mirror_url":null,"open_issues_count":3592,"forks":4254,"open_issues":3592,"watchers":14225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25178"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25178"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25178/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25178/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b99b8f2eee5dd21f2ba336eb236f0314b77c1158"}}}}