{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium/pulls/comments/66237829","id":66237829,"diff_hunk":"@@ -38,3 +38,5 @@ Settings are implemented via the following API endpoints:\n ### Supported Settings\n \n **\"ignoreUnimportantViews\"** - Boolean which sets whether Android devices should use `setCompressedLayoutHeirarchy()` which ignores all views which are marked IMPORTANT_FOR_ACCESSIBILITY_NO or IMPORTANT_FOR_ACCESSIBILITY_AUTO (and have been deemed not important by the system), in an attempt to make things less confusing or faster.\n+\n+**\"configurator\"** - JSON string (example: `{\"method\":\"setWaitForIdleTimeout\",\"value\":5000}`) which sets [UiAutomator Configurator](https://developer.android.com/reference/android/support/test/uiautomator/Configurator.html) timeouts and delays in Android devices. ","path":"docs/en/advanced-concepts/settings.md","position":5,"original_position":5,"commit_id":"79cc7332be8190c0ab3846df55236663e205e2bc","original_commit_id":"79cc7332be8190c0ab3846df55236663e205e2bc","user":{"login":"truebit","id":754906,"avatar_url":"https://avatars.githubusercontent.com/u/754906?v=3","gravatar_id":"","url":"https://api.github.com/users/truebit","html_url":"https://github.com/truebit","followers_url":"https://api.github.com/users/truebit/followers","following_url":"https://api.github.com/users/truebit/following{/other_user}","gists_url":"https://api.github.com/users/truebit/gists{/gist_id}","starred_url":"https://api.github.com/users/truebit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truebit/subscriptions","organizations_url":"https://api.github.com/users/truebit/orgs","repos_url":"https://api.github.com/users/truebit/repos","events_url":"https://api.github.com/users/truebit/events{/privacy}","received_events_url":"https://api.github.com/users/truebit/received_events","type":"User","site_admin":false},"body":"I think in http request, all params are treated as String. In client implementation, we could parse to JSON Object","created_at":"2016-06-08T11:22:56Z","updated_at":"2016-06-08T11:22:56Z","html_url":"https://github.com/appium/appium/pull/6561#discussion_r66237829","pull_request_url":"https://api.github.com/repos/appium/appium/pulls/6561","_links":{"self":{"href":"https://api.github.com/repos/appium/appium/pulls/comments/66237829"},"html":{"href":"https://github.com/appium/appium/pull/6561#discussion_r66237829"},"pull_request":{"href":"https://api.github.com/repos/appium/appium/pulls/6561"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium/pulls/6561","id":72997188,"html_url":"https://github.com/appium/appium/pull/6561","diff_url":"https://github.com/appium/appium/pull/6561.diff","patch_url":"https://github.com/appium/appium/pull/6561.patch","issue_url":"https://api.github.com/repos/appium/appium/issues/6561","number":6561,"state":"open","locked":false,"title":"add support to set UiAutomator Congfigurator values","user":{"login":"truebit","id":754906,"avatar_url":"https://avatars.githubusercontent.com/u/754906?v=3","gravatar_id":"","url":"https://api.github.com/users/truebit","html_url":"https://github.com/truebit","followers_url":"https://api.github.com/users/truebit/followers","following_url":"https://api.github.com/users/truebit/following{/other_user}","gists_url":"https://api.github.com/users/truebit/gists{/gist_id}","starred_url":"https://api.github.com/users/truebit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truebit/subscriptions","organizations_url":"https://api.github.com/users/truebit/orgs","repos_url":"https://api.github.com/users/truebit/repos","events_url":"https://api.github.com/users/truebit/events{/privacy}","received_events_url":"https://api.github.com/users/truebit/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n[UiAutomator Configurator](https://developer.android.com/reference/android/support/test/uiautomator/Configurator.html) provides several methods to change its the configurations.\r\nI have implemented them in appium using [appium settings api](https://github.com/appium/appium/tree/master/docs/en/advanced-concepts/settings.md)\r\n\r\nThis is the overall PR for all other three PRs:\r\n[appium-android-driver](https://github.com/appium/appium-android-driver/pull/153)\r\n[appium-android-bootstrap](https://github.com/appium/appium-android-bootstrap/pull/25)\r\n[java-client](https://github.com/appium/java-client/pull/410)\r\n\r\nI know there would be `appium-uiautomator2-server` and `appium-uiautomator2-driver` in upcoming versions. Since I used existing API, It would be OK for me to merge this feature to the new android server and driver\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce to Appium?\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [ ] Bugfix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n\r\n- [x] I have read the [CONTRIBUTING](/CONTRIBUTING.md) doc\r\n- [x] I have signed the [CLA](https://docs.google.com/forms/d/1lOfXRw_0VCk7gYzjj4WLetGu7yelDVo5LWh0z7pGftE/viewform)\r\n- [x] Lint and unit tests pass locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation (if appropriate)\r\n- [x] Any dependent changes have been merged and published in downstream modules\r\n\r\n## Further comments\r\nBut according to [android uiautomator fixed timeout bug in UiAutomatorBridge](https://code.google.com/p/android/issues/detail?id=73297), the timeout in dynamic page still cannot be changed.\r\nMaybe we need to recompile `uiautomator.jar` to change the static final field [`TOTAL_TIME_TO_WAIT_FOR_IDLE_STATE`](https://android.googlesource.com/platform/frameworks/uiautomator/+/master/src/com/android/uiautomator/core/UiAutomatorBridge.java#39) from `10 * 1000` to `Configurator.getInstance().getWaitForIdleTimeout()`.\r\nThat's a little more complexed, I have not tried that.\r\n\r\n### Reviewers: \r\n\r\n","created_at":"2016-06-08T07:17:19Z","updated_at":"2016-06-08T11:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7e8c96c2a982ab9b47031ba5015587c56fd7a3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium/pulls/6561/commits","review_comments_url":"https://api.github.com/repos/appium/appium/pulls/6561/comments","review_comment_url":"https://api.github.com/repos/appium/appium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium/issues/6561/comments","statuses_url":"https://api.github.com/repos/appium/appium/statuses/79cc7332be8190c0ab3846df55236663e205e2bc","head":{"label":"truebit:master","ref":"master","sha":"79cc7332be8190c0ab3846df55236663e205e2bc","user":{"login":"truebit","id":754906,"avatar_url":"https://avatars.githubusercontent.com/u/754906?v=3","gravatar_id":"","url":"https://api.github.com/users/truebit","html_url":"https://github.com/truebit","followers_url":"https://api.github.com/users/truebit/followers","following_url":"https://api.github.com/users/truebit/following{/other_user}","gists_url":"https://api.github.com/users/truebit/gists{/gist_id}","starred_url":"https://api.github.com/users/truebit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truebit/subscriptions","organizations_url":"https://api.github.com/users/truebit/orgs","repos_url":"https://api.github.com/users/truebit/repos","events_url":"https://api.github.com/users/truebit/events{/privacy}","received_events_url":"https://api.github.com/users/truebit/received_events","type":"User","site_admin":false},"repo":{"id":60675545,"name":"appium","full_name":"truebit/appium","owner":{"login":"truebit","id":754906,"avatar_url":"https://avatars.githubusercontent.com/u/754906?v=3","gravatar_id":"","url":"https://api.github.com/users/truebit","html_url":"https://github.com/truebit","followers_url":"https://api.github.com/users/truebit/followers","following_url":"https://api.github.com/users/truebit/following{/other_user}","gists_url":"https://api.github.com/users/truebit/gists{/gist_id}","starred_url":"https://api.github.com/users/truebit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truebit/subscriptions","organizations_url":"https://api.github.com/users/truebit/orgs","repos_url":"https://api.github.com/users/truebit/repos","events_url":"https://api.github.com/users/truebit/events{/privacy}","received_events_url":"https://api.github.com/users/truebit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/truebit/appium","description":":iphone: Automation for iOS and Android Apps.","fork":true,"url":"https://api.github.com/repos/truebit/appium","forks_url":"https://api.github.com/repos/truebit/appium/forks","keys_url":"https://api.github.com/repos/truebit/appium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/truebit/appium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/truebit/appium/teams","hooks_url":"https://api.github.com/repos/truebit/appium/hooks","issue_events_url":"https://api.github.com/repos/truebit/appium/issues/events{/number}","events_url":"https://api.github.com/repos/truebit/appium/events","assignees_url":"https://api.github.com/repos/truebit/appium/assignees{/user}","branches_url":"https://api.github.com/repos/truebit/appium/branches{/branch}","tags_url":"https://api.github.com/repos/truebit/appium/tags","blobs_url":"https://api.github.com/repos/truebit/appium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/truebit/appium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/truebit/appium/git/refs{/sha}","trees_url":"https://api.github.com/repos/truebit/appium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/truebit/appium/statuses/{sha}","languages_url":"https://api.github.com/repos/truebit/appium/languages","stargazers_url":"https://api.github.com/repos/truebit/appium/stargazers","contributors_url":"https://api.github.com/repos/truebit/appium/contributors","subscribers_url":"https://api.github.com/repos/truebit/appium/subscribers","subscription_url":"https://api.github.com/repos/truebit/appium/subscription","commits_url":"https://api.github.com/repos/truebit/appium/commits{/sha}","git_commits_url":"https://api.github.com/repos/truebit/appium/git/commits{/sha}","comments_url":"https://api.github.com/repos/truebit/appium/comments{/number}","issue_comment_url":"https://api.github.com/repos/truebit/appium/issues/comments{/number}","contents_url":"https://api.github.com/repos/truebit/appium/contents/{+path}","compare_url":"https://api.github.com/repos/truebit/appium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/truebit/appium/merges","archive_url":"https://api.github.com/repos/truebit/appium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/truebit/appium/downloads","issues_url":"https://api.github.com/repos/truebit/appium/issues{/number}","pulls_url":"https://api.github.com/repos/truebit/appium/pulls{/number}","milestones_url":"https://api.github.com/repos/truebit/appium/milestones{/number}","notifications_url":"https://api.github.com/repos/truebit/appium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/truebit/appium/labels{/name}","releases_url":"https://api.github.com/repos/truebit/appium/releases{/id}","deployments_url":"https://api.github.com/repos/truebit/appium/deployments","created_at":"2016-06-08T06:51:35Z","updated_at":"2016-06-08T06:51:38Z","pushed_at":"2016-06-08T07:00:26Z","git_url":"git://github.com/truebit/appium.git","ssh_url":"git@github.com:truebit/appium.git","clone_url":"https://github.com/truebit/appium.git","svn_url":"https://github.com/truebit/appium","homepage":"http://appium.io/","size":35580,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"9c663cf18eb426f32a37779504fadd053204655b","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":7530570,"name":"appium","full_name":"appium/appium","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium","description":":iphone: Automation for iOS and Android Apps.","fork":false,"url":"https://api.github.com/repos/appium/appium","forks_url":"https://api.github.com/repos/appium/appium/forks","keys_url":"https://api.github.com/repos/appium/appium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium/teams","hooks_url":"https://api.github.com/repos/appium/appium/hooks","issue_events_url":"https://api.github.com/repos/appium/appium/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium/events","assignees_url":"https://api.github.com/repos/appium/appium/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium/tags","blobs_url":"https://api.github.com/repos/appium/appium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium/languages","stargazers_url":"https://api.github.com/repos/appium/appium/stargazers","contributors_url":"https://api.github.com/repos/appium/appium/contributors","subscribers_url":"https://api.github.com/repos/appium/appium/subscribers","subscription_url":"https://api.github.com/repos/appium/appium/subscription","commits_url":"https://api.github.com/repos/appium/appium/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium/merges","archive_url":"https://api.github.com/repos/appium/appium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium/downloads","issues_url":"https://api.github.com/repos/appium/appium/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium/deployments","created_at":"2013-01-09T22:49:50Z","updated_at":"2016-06-08T10:14:59Z","pushed_at":"2016-06-08T07:17:19Z","git_url":"git://github.com/appium/appium.git","ssh_url":"git@github.com:appium/appium.git","clone_url":"https://github.com/appium/appium.git","svn_url":"https://github.com/appium/appium","homepage":"http://appium.io/","size":72018,"stargazers_count":3640,"watchers_count":3640,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2143,"mirror_url":null,"open_issues_count":689,"forks":2143,"open_issues":689,"watchers":3640,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium/pulls/6561"},"html":{"href":"https://github.com/appium/appium/pull/6561"},"issue":{"href":"https://api.github.com/repos/appium/appium/issues/6561"},"comments":{"href":"https://api.github.com/repos/appium/appium/issues/6561/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium/pulls/6561/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium/pulls/6561/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium/statuses/79cc7332be8190c0ab3846df55236663e205e2bc"}}}}
{"actor":{"display_login":"truebit"}}