{"action":"created","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/1490","labels_url":"https://api.github.com/repos/ripple/rippled/issues/1490/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/1490/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/1490/events","html_url":"https://github.com/ripple/rippled/pull/1490","id":127541392,"number":1490,"title":"WebSocket improvement medley:","user":{"login":"vinniefalco","id":1503976,"avatar_url":"https://avatars.githubusercontent.com/u/1503976?v=3","gravatar_id":"","url":"https://api.github.com/users/vinniefalco","html_url":"https://github.com/vinniefalco","followers_url":"https://api.github.com/users/vinniefalco/followers","following_url":"https://api.github.com/users/vinniefalco/following{/other_user}","gists_url":"https://api.github.com/users/vinniefalco/gists{/gist_id}","starred_url":"https://api.github.com/users/vinniefalco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinniefalco/subscriptions","organizations_url":"https://api.github.com/users/vinniefalco/orgs","repos_url":"https://api.github.com/users/vinniefalco/repos","events_url":"https://api.github.com/users/vinniefalco/events{/privacy}","received_events_url":"https://api.github.com/users/vinniefalco/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ripple/rippled/labels/Ed","name":"Ed","color":"eeeeee"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Rebase","name":"Rebase","color":"eb6420"},{"url":"https://api.github.com/repos/ripple/rippled/labels/Scott.D","name":"Scott.D","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-01-19T21:21:20Z","updated_at":"2016-01-22T23:37:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/1490","html_url":"https://github.com/ripple/rippled/pull/1490","diff_url":"https://github.com/ripple/rippled/pull/1490.diff","patch_url":"https://github.com/ripple/rippled/pull/1490.patch"},"body":"These changes ensure the caller can block until the Application object can be fully prepared (especially listening sockets). Solves the problem where tests can attempt connections before the server sockets are ready. Fixes a deadlock on exit, and removes unused websocket04.\r\n\r\nReviewers: @ximinez @seelabs "},"comment":{"url":"https://api.github.com/repos/ripple/rippled/issues/comments/174088115","html_url":"https://github.com/ripple/rippled/pull/1490#issuecomment-174088115","issue_url":"https://api.github.com/repos/ripple/rippled/issues/1490","id":174088115,"user":{"login":"ximinez","id":6757714,"avatar_url":"https://avatars.githubusercontent.com/u/6757714?v=3","gravatar_id":"","url":"https://api.github.com/users/ximinez","html_url":"https://github.com/ximinez","followers_url":"https://api.github.com/users/ximinez/followers","following_url":"https://api.github.com/users/ximinez/following{/other_user}","gists_url":"https://api.github.com/users/ximinez/gists{/gist_id}","starred_url":"https://api.github.com/users/ximinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ximinez/subscriptions","organizations_url":"https://api.github.com/users/ximinez/orgs","repos_url":"https://api.github.com/users/ximinez/repos","events_url":"https://api.github.com/users/ximinez/events{/privacy}","received_events_url":"https://api.github.com/users/ximinez/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T23:37:41Z","updated_at":"2016-01-22T23:37:41Z","body":"@seelabs 1325ed5 looks good, especially after squashing it into the previous. :+1: "}}