{"action":"created","issue":{"url":"https://api.github.com/repos/Yakindu/statecharts/issues/912","repository_url":"https://api.github.com/repos/Yakindu/statecharts","labels_url":"https://api.github.com/repos/Yakindu/statecharts/issues/912/labels{/name}","comments_url":"https://api.github.com/repos/Yakindu/statecharts/issues/912/comments","events_url":"https://api.github.com/repos/Yakindu/statecharts/issues/912/events","html_url":"https://github.com/Yakindu/statecharts/issues/912","id":171915188,"number":912,"title":"Design smell in IGenArtifactConfigurations API","user":{"login":"wendehals","id":12050690,"avatar_url":"https://avatars.githubusercontent.com/u/12050690?v=3","gravatar_id":"","url":"https://api.github.com/users/wendehals","html_url":"https://github.com/wendehals","followers_url":"https://api.github.com/users/wendehals/followers","following_url":"https://api.github.com/users/wendehals/following{/other_user}","gists_url":"https://api.github.com/users/wendehals/gists{/gist_id}","starred_url":"https://api.github.com/users/wendehals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendehals/subscriptions","organizations_url":"https://api.github.com/users/wendehals/orgs","repos_url":"https://api.github.com/users/wendehals/repos","events_url":"https://api.github.com/users/wendehals/events{/privacy}","received_events_url":"https://api.github.com/users/wendehals/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"andreasmuelder","id":6338708,"avatar_url":"https://avatars.githubusercontent.com/u/6338708?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasmuelder","html_url":"https://github.com/andreasmuelder","followers_url":"https://api.github.com/users/andreasmuelder/followers","following_url":"https://api.github.com/users/andreasmuelder/following{/other_user}","gists_url":"https://api.github.com/users/andreasmuelder/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasmuelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasmuelder/subscriptions","organizations_url":"https://api.github.com/users/andreasmuelder/orgs","repos_url":"https://api.github.com/users/andreasmuelder/repos","events_url":"https://api.github.com/users/andreasmuelder/events{/privacy}","received_events_url":"https://api.github.com/users/andreasmuelder/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreasmuelder","id":6338708,"avatar_url":"https://avatars.githubusercontent.com/u/6338708?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasmuelder","html_url":"https://github.com/andreasmuelder","followers_url":"https://api.github.com/users/andreasmuelder/followers","following_url":"https://api.github.com/users/andreasmuelder/following{/other_user}","gists_url":"https://api.github.com/users/andreasmuelder/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasmuelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasmuelder/subscriptions","organizations_url":"https://api.github.com/users/andreasmuelder/orgs","repos_url":"https://api.github.com/users/andreasmuelder/repos","events_url":"https://api.github.com/users/andreasmuelder/events{/privacy}","received_events_url":"https://api.github.com/users/andreasmuelder/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Yakindu/statecharts/milestones/4","html_url":"https://github.com/Yakindu/statecharts/milestones/Inbox","labels_url":"https://api.github.com/repos/Yakindu/statecharts/milestones/4/labels","id":1359382,"number":4,"title":"Inbox","description":"To be qualified & scheduled","creator":{"login":"terfloth","id":1296498,"avatar_url":"https://avatars.githubusercontent.com/u/1296498?v=3","gravatar_id":"","url":"https://api.github.com/users/terfloth","html_url":"https://github.com/terfloth","followers_url":"https://api.github.com/users/terfloth/followers","following_url":"https://api.github.com/users/terfloth/following{/other_user}","gists_url":"https://api.github.com/users/terfloth/gists{/gist_id}","starred_url":"https://api.github.com/users/terfloth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terfloth/subscriptions","organizations_url":"https://api.github.com/users/terfloth/orgs","repos_url":"https://api.github.com/users/terfloth/repos","events_url":"https://api.github.com/users/terfloth/events{/privacy}","received_events_url":"https://api.github.com/users/terfloth/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2015-10-16T13:13:15Z","updated_at":"2016-08-24T11:51:12Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-08-18T14:29:57Z","updated_at":"2016-08-24T11:51:12Z","closed_at":"2016-08-24T11:51:12Z","body":"The interface org.yakindu.sct.generator.c.IGenArtifactConfigurations there is a method\r\n\r\nList<GenArtifactConfiguration> getConfigurations();\r\n\r\nthat has a design smell. The type parameter GenArtifactConfiguration of the returned list is actually an inner class of org.yakindu.sct.generator.c.GenArtifactConfigurations that implements IGenArtifactConfigurations. Thus, there is no real decoupling between the interface and its implementation.\r\n\r\nConsider to create an interface IGenArtifactConfiguration for the type parameter of the getConfigurations() method.\r\n"},"comment":{"url":"https://api.github.com/repos/Yakindu/statecharts/issues/comments/242036892","html_url":"https://github.com/Yakindu/statecharts/issues/912#issuecomment-242036892","issue_url":"https://api.github.com/repos/Yakindu/statecharts/issues/912","id":242036892,"user":{"login":"andreasmuelder","id":6338708,"avatar_url":"https://avatars.githubusercontent.com/u/6338708?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasmuelder","html_url":"https://github.com/andreasmuelder","followers_url":"https://api.github.com/users/andreasmuelder/followers","following_url":"https://api.github.com/users/andreasmuelder/following{/other_user}","gists_url":"https://api.github.com/users/andreasmuelder/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasmuelder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasmuelder/subscriptions","organizations_url":"https://api.github.com/users/andreasmuelder/orgs","repos_url":"https://api.github.com/users/andreasmuelder/repos","events_url":"https://api.github.com/users/andreasmuelder/events{/privacy}","received_events_url":"https://api.github.com/users/andreasmuelder/received_events","type":"User","site_admin":false},"created_at":"2016-08-24T11:51:11Z","updated_at":"2016-08-24T11:51:11Z","body":"done with PR #921"}}
{"actor":{"display_login":"andreasmuelder"}}