{"action":"closed","number":9,"pull_request":{"url":"https://api.github.com/repos/tomverran/robots/pulls/9","id":61841015,"html_url":"https://github.com/tomverran/robots/pull/9","diff_url":"https://github.com/tomverran/robots/pull/9.diff","patch_url":"https://github.com/tomverran/robots/pull/9.patch","issue_url":"https://api.github.com/repos/tomverran/robots/issues/9","number":9,"state":"closed","locked":false,"title":"Issue 8","user":{"login":"tomverran","id":1388226,"avatar_url":"https://avatars.githubusercontent.com/u/1388226?v=3","gravatar_id":"","url":"https://api.github.com/users/tomverran","html_url":"https://github.com/tomverran","followers_url":"https://api.github.com/users/tomverran/followers","following_url":"https://api.github.com/users/tomverran/following{/other_user}","gists_url":"https://api.github.com/users/tomverran/gists{/gist_id}","starred_url":"https://api.github.com/users/tomverran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomverran/subscriptions","organizations_url":"https://api.github.com/users/tomverran/orgs","repos_url":"https://api.github.com/users/tomverran/repos","events_url":"https://api.github.com/users/tomverran/events{/privacy}","received_events_url":"https://api.github.com/users/tomverran/received_events","type":"User","site_admin":false},"body":"PR to resolve issue #8 \r\n\r\nThis update brings the library into line with the following two specs for Robots files:\r\n\r\n - http://www.robotstxt.org/norobots-rfc.txt\r\n - https://developers.google.com/webmasters/control-crawl-index/docs/robots_txt?hl=en\r\n\r\nA summary of the changes\r\n\r\n - The _most specific_ matching User-agent is found in the file to determine the rules to apply\r\n - I took most specific to mean longest match, which is how allow / disallow rules are ordered.\r\n - Wildcards expand across directory boundaries and can be anchored to the end of the string with $\r\n - Encoded HTML characters are supported, with the exception of encoded slashes which are left as-is\r\n\r\nThe file is no longer modelled as a tree but as a series of Records, with User-Agent and AccessRules objects. The actual file parser uses arrays as an intermediate representation to cut down on the number of objects created.\r\n\r\nThanks for bringing these issues to my attention @ranvis!","created_at":"2016-03-06T12:01:06Z","updated_at":"2016-03-06T12:30:23Z","closed_at":"2016-03-06T12:30:22Z","merged_at":"2016-03-06T12:30:22Z","merge_commit_sha":"5db8489407d289e53df3e228688c1f4d7d55ecd1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomverran/robots/pulls/9/commits","review_comments_url":"https://api.github.com/repos/tomverran/robots/pulls/9/comments","review_comment_url":"https://api.github.com/repos/tomverran/robots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomverran/robots/issues/9/comments","statuses_url":"https://api.github.com/repos/tomverran/robots/statuses/3548473a6a74bd64f065bcb1f5c48ab526840b36","head":{"label":"tomverran:issue-8","ref":"issue-8","sha":"3548473a6a74bd64f065bcb1f5c48ab526840b36","user":{"login":"tomverran","id":1388226,"avatar_url":"https://avatars.githubusercontent.com/u/1388226?v=3","gravatar_id":"","url":"https://api.github.com/users/tomverran","html_url":"https://github.com/tomverran","followers_url":"https://api.github.com/users/tomverran/followers","following_url":"https://api.github.com/users/tomverran/following{/other_user}","gists_url":"https://api.github.com/users/tomverran/gists{/gist_id}","starred_url":"https://api.github.com/users/tomverran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomverran/subscriptions","organizations_url":"https://api.github.com/users/tomverran/orgs","repos_url":"https://api.github.com/users/tomverran/repos","events_url":"https://api.github.com/users/tomverran/events{/privacy}","received_events_url":"https://api.github.com/users/tomverran/received_events","type":"User","site_admin":false},"repo":{"id":18773359,"name":"robots","full_name":"tomverran/robots","owner":{"login":"tomverran","id":1388226,"avatar_url":"https://avatars.githubusercontent.com/u/1388226?v=3","gravatar_id":"","url":"https://api.github.com/users/tomverran","html_url":"https://github.com/tomverran","followers_url":"https://api.github.com/users/tomverran/followers","following_url":"https://api.github.com/users/tomverran/following{/other_user}","gists_url":"https://api.github.com/users/tomverran/gists{/gist_id}","starred_url":"https://api.github.com/users/tomverran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomverran/subscriptions","organizations_url":"https://api.github.com/users/tomverran/orgs","repos_url":"https://api.github.com/users/tomverran/repos","events_url":"https://api.github.com/users/tomverran/events{/privacy}","received_events_url":"https://api.github.com/users/tomverran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomverran/robots","description":"A robots.txt checker","fork":false,"url":"https://api.github.com/repos/tomverran/robots","forks_url":"https://api.github.com/repos/tomverran/robots/forks","keys_url":"https://api.github.com/repos/tomverran/robots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomverran/robots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomverran/robots/teams","hooks_url":"https://api.github.com/repos/tomverran/robots/hooks","issue_events_url":"https://api.github.com/repos/tomverran/robots/issues/events{/number}","events_url":"https://api.github.com/repos/tomverran/robots/events","assignees_url":"https://api.github.com/repos/tomverran/robots/assignees{/user}","branches_url":"https://api.github.com/repos/tomverran/robots/branches{/branch}","tags_url":"https://api.github.com/repos/tomverran/robots/tags","blobs_url":"https://api.github.com/repos/tomverran/robots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomverran/robots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomverran/robots/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomverran/robots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomverran/robots/statuses/{sha}","languages_url":"https://api.github.com/repos/tomverran/robots/languages","stargazers_url":"https://api.github.com/repos/tomverran/robots/stargazers","contributors_url":"https://api.github.com/repos/tomverran/robots/contributors","subscribers_url":"https://api.github.com/repos/tomverran/robots/subscribers","subscription_url":"https://api.github.com/repos/tomverran/robots/subscription","commits_url":"https://api.github.com/repos/tomverran/robots/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomverran/robots/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomverran/robots/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomverran/robots/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomverran/robots/contents/{+path}","compare_url":"https://api.github.com/repos/tomverran/robots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomverran/robots/merges","archive_url":"https://api.github.com/repos/tomverran/robots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomverran/robots/downloads","issues_url":"https://api.github.com/repos/tomverran/robots/issues{/number}","pulls_url":"https://api.github.com/repos/tomverran/robots/pulls{/number}","milestones_url":"https://api.github.com/repos/tomverran/robots/milestones{/number}","notifications_url":"https://api.github.com/repos/tomverran/robots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomverran/robots/labels{/name}","releases_url":"https://api.github.com/repos/tomverran/robots/releases{/id}","deployments_url":"https://api.github.com/repos/tomverran/robots/deployments","created_at":"2014-04-14T19:24:01Z","updated_at":"2016-03-06T12:30:23Z","pushed_at":"2016-03-06T12:30:22Z","git_url":"git://github.com/tomverran/robots.git","ssh_url":"git@github.com:tomverran/robots.git","clone_url":"https://github.com/tomverran/robots.git","svn_url":"https://github.com/tomverran/robots","homepage":"","size":32,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"tomverran:master","ref":"master","sha":"d6897d72e9e3547da04e635c82e39ced8593f700","user":{"login":"tomverran","id":1388226,"avatar_url":"https://avatars.githubusercontent.com/u/1388226?v=3","gravatar_id":"","url":"https://api.github.com/users/tomverran","html_url":"https://github.com/tomverran","followers_url":"https://api.github.com/users/tomverran/followers","following_url":"https://api.github.com/users/tomverran/following{/other_user}","gists_url":"https://api.github.com/users/tomverran/gists{/gist_id}","starred_url":"https://api.github.com/users/tomverran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomverran/subscriptions","organizations_url":"https://api.github.com/users/tomverran/orgs","repos_url":"https://api.github.com/users/tomverran/repos","events_url":"https://api.github.com/users/tomverran/events{/privacy}","received_events_url":"https://api.github.com/users/tomverran/received_events","type":"User","site_admin":false},"repo":{"id":18773359,"name":"robots","full_name":"tomverran/robots","owner":{"login":"tomverran","id":1388226,"avatar_url":"https://avatars.githubusercontent.com/u/1388226?v=3","gravatar_id":"","url":"https://api.github.com/users/tomverran","html_url":"https://github.com/tomverran","followers_url":"https://api.github.com/users/tomverran/followers","following_url":"https://api.github.com/users/tomverran/following{/other_user}","gists_url":"https://api.github.com/users/tomverran/gists{/gist_id}","starred_url":"https://api.github.com/users/tomverran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomverran/subscriptions","organizations_url":"https://api.github.com/users/tomverran/orgs","repos_url":"https://api.github.com/users/tomverran/repos","events_url":"https://api.github.com/users/tomverran/events{/privacy}","received_events_url":"https://api.github.com/users/tomverran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomverran/robots","description":"A robots.txt checker","fork":false,"url":"https://api.github.com/repos/tomverran/robots","forks_url":"https://api.github.com/repos/tomverran/robots/forks","keys_url":"https://api.github.com/repos/tomverran/robots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomverran/robots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomverran/robots/teams","hooks_url":"https://api.github.com/repos/tomverran/robots/hooks","issue_events_url":"https://api.github.com/repos/tomverran/robots/issues/events{/number}","events_url":"https://api.github.com/repos/tomverran/robots/events","assignees_url":"https://api.github.com/repos/tomverran/robots/assignees{/user}","branches_url":"https://api.github.com/repos/tomverran/robots/branches{/branch}","tags_url":"https://api.github.com/repos/tomverran/robots/tags","blobs_url":"https://api.github.com/repos/tomverran/robots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomverran/robots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomverran/robots/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomverran/robots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomverran/robots/statuses/{sha}","languages_url":"https://api.github.com/repos/tomverran/robots/languages","stargazers_url":"https://api.github.com/repos/tomverran/robots/stargazers","contributors_url":"https://api.github.com/repos/tomverran/robots/contributors","subscribers_url":"https://api.github.com/repos/tomverran/robots/subscribers","subscription_url":"https://api.github.com/repos/tomverran/robots/subscription","commits_url":"https://api.github.com/repos/tomverran/robots/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomverran/robots/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomverran/robots/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomverran/robots/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomverran/robots/contents/{+path}","compare_url":"https://api.github.com/repos/tomverran/robots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomverran/robots/merges","archive_url":"https://api.github.com/repos/tomverran/robots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomverran/robots/downloads","issues_url":"https://api.github.com/repos/tomverran/robots/issues{/number}","pulls_url":"https://api.github.com/repos/tomverran/robots/pulls{/number}","milestones_url":"https://api.github.com/repos/tomverran/robots/milestones{/number}","notifications_url":"https://api.github.com/repos/tomverran/robots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomverran/robots/labels{/name}","releases_url":"https://api.github.com/repos/tomverran/robots/releases{/id}","deployments_url":"https://api.github.com/repos/tomverran/robots/deployments","created_at":"2014-04-14T19:24:01Z","updated_at":"2016-03-06T12:30:23Z","pushed_at":"2016-03-06T12:30:22Z","git_url":"git://github.com/tomverran/robots.git","ssh_url":"git@github.com:tomverran/robots.git","clone_url":"https://github.com/tomverran/robots.git","svn_url":"https://github.com/tomverran/robots","homepage":"","size":32,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomverran/robots/pulls/9"},"html":{"href":"https://github.com/tomverran/robots/pull/9"},"issue":{"href":"https://api.github.com/repos/tomverran/robots/issues/9"},"comments":{"href":"https://api.github.com/repos/tomverran/robots/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/tomverran/robots/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/tomverran/robots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomverran/robots/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/tomverran/robots/statuses/3548473a6a74bd64f065bcb1f5c48ab526840b36"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tomverran","id":1388226,"avatar_url":"https://avatars.githubusercontent.com/u/1388226?v=3","gravatar_id":"","url":"https://api.github.com/users/tomverran","html_url":"https://github.com/tomverran","followers_url":"https://api.github.com/users/tomverran/followers","following_url":"https://api.github.com/users/tomverran/following{/other_user}","gists_url":"https://api.github.com/users/tomverran/gists{/gist_id}","starred_url":"https://api.github.com/users/tomverran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomverran/subscriptions","organizations_url":"https://api.github.com/users/tomverran/orgs","repos_url":"https://api.github.com/users/tomverran/repos","events_url":"https://api.github.com/users/tomverran/events{/privacy}","received_events_url":"https://api.github.com/users/tomverran/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":6,"additions":606,"deletions":135,"changed_files":16}}