{"action":"created","issue":{"url":"https://api.github.com/repos/performancecopilot/parfait/issues/39","repository_url":"https://api.github.com/repos/performancecopilot/parfait","labels_url":"https://api.github.com/repos/performancecopilot/parfait/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/performancecopilot/parfait/issues/39/comments","events_url":"https://api.github.com/repos/performancecopilot/parfait/issues/39/events","html_url":"https://github.com/performancecopilot/parfait/pull/39","id":189999714,"number":39,"title":"Implement MMV V2 support","user":{"login":"ryandoyle","id":887536,"avatar_url":"https://avatars.githubusercontent.com/u/887536?v=3","gravatar_id":"","url":"https://api.github.com/users/ryandoyle","html_url":"https://github.com/ryandoyle","followers_url":"https://api.github.com/users/ryandoyle/followers","following_url":"https://api.github.com/users/ryandoyle/following{/other_user}","gists_url":"https://api.github.com/users/ryandoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandoyle/subscriptions","organizations_url":"https://api.github.com/users/ryandoyle/orgs","repos_url":"https://api.github.com/users/ryandoyle/repos","events_url":"https://api.github.com/users/ryandoyle/events{/privacy}","received_events_url":"https://api.github.com/users/ryandoyle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-17T10:08:41Z","updated_at":"2016-11-21T00:22:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/performancecopilot/parfait/pulls/39","html_url":"https://github.com/performancecopilot/parfait/pull/39","diff_url":"https://github.com/performancecopilot/parfait/pull/39.diff","patch_url":"https://github.com/performancecopilot/parfait/pull/39.patch"},"body":"This branch implements support for Parfait to write the MMV V2 format.\r\n\r\nThe approach I settled on was to implement V1/2 of `Instance` and `PcpMetricInfo`s. The responsibility of writing to the MMV file was moved to these domain classes themselves.\r\n\r\nThere is a small bit of variance in the performance tests but I'd say its within an acceptable range.\r\n```\r\nMMV V2\r\npcpStarted: false\tperMetricLock: false\tincrementRate(/sec):   51,880,674.45\t blockedCount: 0\t blockedTime: 0\r\npcpStarted: true\tperMetricLock: false\tincrementRate(/sec):    3,620,564.81\t blockedCount: 4158\t blockedTime: 386\r\npcpStarted: true\tperMetricLock: true\tincrementRate(/sec):    3,749,882.82\t blockedCount: 180\t blockedTime: 21\r\npcpStarted: true\tperMetricLock: true\tincrementRate(/sec):    3,819,709.70\t blockedCount: 138\t blockedTime: 10\r\npcpStarted: true\tperMetricLock: false\tincrementRate(/sec):    3,891,050.58\t blockedCount: 1903\t blockedTime: 350\r\npcpStarted: false\tperMetricLock: false\tincrementRate(/sec):  111,111,111.11\t blockedCount: 0\t blockedTime: 0\r\n\r\nMMV V1 - refactored\r\npcpStarted: false\tperMetricLock: false\tincrementRate(/sec):   52,910,052.91\t blockedCount: 5\t blockedTime: 0\r\npcpStarted: true\tperMetricLock: false\tincrementRate(/sec):    3,616,309.56\t blockedCount: 3921\t blockedTime: 353\r\npcpStarted: true\tperMetricLock: true\tincrementRate(/sec):    3,808,073.12\t blockedCount: 149\t blockedTime: 9\r\npcpStarted: true\tperMetricLock: true\tincrementRate(/sec):    3,950,617.28\t blockedCount: 66\t blockedTime: 14\r\npcpStarted: true\tperMetricLock: false\tincrementRate(/sec):    3,977,329.22\t blockedCount: 1688\t blockedTime: 440\r\npcpStarted: false\tperMetricLock: false\tincrementRate(/sec):   94,562,647.75\t blockedCount: 0\t blockedTime: 0\r\n\r\n\r\nMMV V1 - original code\r\npcpStarted: false\tperMetricLock: false\tincrementRate(/sec):   53,981,106.61\t blockedCount: 4\t blockedTime: 0\r\npcpStarted: true\tperMetricLock: false\tincrementRate(/sec):    3,660,992.13\t blockedCount: 5240\t blockedTime: 462\r\npcpStarted: true\tperMetricLock: true\tincrementRate(/sec):    3,844,305.62\t blockedCount: 141\t blockedTime: 18\r\npcpStarted: true\tperMetricLock: true\tincrementRate(/sec):    3,916,960.44\t blockedCount: 92\t blockedTime: 28\r\npcpStarted: true\tperMetricLock: false\tincrementRate(/sec):    3,958,828.19\t blockedCount: 1865\t blockedTime: 397\r\npcpStarted: false\tperMetricLock: false\tincrementRate(/sec):  106,666,666.67\t blockedCount: 1\t blockedTime: 1\r\n```"},"comment":{"url":"https://api.github.com/repos/performancecopilot/parfait/issues/comments/261817908","html_url":"https://github.com/performancecopilot/parfait/pull/39#issuecomment-261817908","issue_url":"https://api.github.com/repos/performancecopilot/parfait/issues/39","id":261817908,"user":{"login":"tallpsmith","id":203682,"avatar_url":"https://avatars.githubusercontent.com/u/203682?v=3","gravatar_id":"","url":"https://api.github.com/users/tallpsmith","html_url":"https://github.com/tallpsmith","followers_url":"https://api.github.com/users/tallpsmith/followers","following_url":"https://api.github.com/users/tallpsmith/following{/other_user}","gists_url":"https://api.github.com/users/tallpsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tallpsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallpsmith/subscriptions","organizations_url":"https://api.github.com/users/tallpsmith/orgs","repos_url":"https://api.github.com/users/tallpsmith/repos","events_url":"https://api.github.com/users/tallpsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tallpsmith/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T00:22:41Z","updated_at":"2016-11-21T00:22:41Z","body":"I like this refactoring, lots of responsibility taken out into simpler classes, which will leave the Writer infrastructure much easier to understand.\r\n\r\nI'm presuming this is going to live just in master, and we will not attempt to merge this to the 0.3 branch - the namespace change would be a killer..  (I don't think we need to merge it)."}}
{"actor":{"display_login":"tallpsmith"}}