{"action":"created","issue":{"url":"https://api.github.com/repos/microapps/Shopify-api-node/issues/104","repository_url":"https://api.github.com/repos/microapps/Shopify-api-node","labels_url":"https://api.github.com/repos/microapps/Shopify-api-node/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/microapps/Shopify-api-node/issues/104/comments","events_url":"https://api.github.com/repos/microapps/Shopify-api-node/issues/104/events","html_url":"https://github.com/microapps/Shopify-api-node/issues/104","id":185265935,"number":104,"title":"Mocha/Nock: encodedParams Issue","user":{"login":"59023g","id":5235538,"avatar_url":"https://avatars.githubusercontent.com/u/5235538?v=3","gravatar_id":"","url":"https://api.github.com/users/59023g","html_url":"https://github.com/59023g","followers_url":"https://api.github.com/users/59023g/followers","following_url":"https://api.github.com/users/59023g/following{/other_user}","gists_url":"https://api.github.com/users/59023g/gists{/gist_id}","starred_url":"https://api.github.com/users/59023g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/59023g/subscriptions","organizations_url":"https://api.github.com/users/59023g/orgs","repos_url":"https://api.github.com/users/59023g/repos","events_url":"https://api.github.com/users/59023g/events{/privacy}","received_events_url":"https://api.github.com/users/59023g/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-26T00:13:04Z","updated_at":"2016-10-26T06:18:19Z","closed_at":null,"body":"Unable to mock API calls because nock can not pick up the encoded query params. I emulated your current test suite set-up, to no luck.\r\n\r\nOutput from `nock.recorder.rec()`:\r\n```\r\nnock('https://demo-shop.myshopify.com:443', {\"encodedQueryParams\":true})\r\n  .put('/admin/orders/4476182279.json', {\"order\":{\"tags\":\"one,two,three\"}})\r\n  .reply(200, [\"1f8b080aaa03000000ffff\",\"ec57db8edb3610fd15417d6981f5429464cbf2533749fb96a6a893a726106892b28995488517efbac1fe7b86a46ef63a97a2796c8005a2e1903373e6cc21fd29968a32156f3ec59cc69b3c2f56689da6c5fa26662de64dbc8935a6b8d5254a7edd3bcb2d916d7c1393466a462b6ce28db04d0306c5b0e92d719aa0d502250b54bc45d9262f3679b248f24d92c04edbd1e78ee9f26d9a6c50b2c9d2d151d876e752cb0af8bf340cdc89940dac1879cf047c62c44a426b8258b1ae770949basdf38295a97aa0428776f6c4548509619dd1558bd53d335cec874802b76efb4f28c972d8af58cd9482f54a73877d38a3c1825eda08d4c29ae69c0dde560127b41c1398215b594d27d4c981917b692ff2f519006e6320ab217f47d33e1749b0e152cc4c5a5a058773ca84e13577ec395bb0aa192c9d928469fd3d8ca5ecc8fda923924a3ef85cba6bb840d5f560f7d3550d4c066881cb43332b2229838efefd21f01b12318aefac198c1d3eb55048d573b8721d1a9642f62e64cbcc41d240f011c86790f4dd4dcb7c890a4741dbd4bc69fcf90309fb2ee1474fab3e92c17bc7ba1d86835d3137d1d6ee3451bc73d89f7f45bf73a5cd7bf1c66b8a67b3c1c4545f979280514862dea189db9049d0a7f5ba480a54944bd0a723561c8b506a9614cb72992e57192c186e1a57eb4bdc69dbb0b30c75f4de2649ba8afe62aefce84f284b47d19d353202aeb187e8e7ed81773a6247a64e511abd86asdf27dff5c13aa33729d6bfe24f9df39b32ee298e2600df39315195a0139d6e93426c03941a1efd17620c844ef75afcf20545ff00cf2328aea410a36e93740addd557f85cc3385a2ace18e26c03ec3f6c088e912810bc84bfea59c3fab7707c7bb7231a5c075edde33b5d3a241f72075dff37e1d81294f96d1ca1ca2bb23bb8dee3a731b2137a77d0971069a82966899640e00df9a788b41e294bbbaa13560fec75d00719923b40e843d727f5dc1cc34bc964a70ecd1832e2a7ffb034d187553ee34dedd1a53862f24d76cca301d41906d87c569ba68a06fd6b5232b6e8b75b22a90bb09c5beb72e509adee6ab3ccf8ae538c2befa6888d0e753f55d7db79de53e185fde01e12716fd0feb8f8475360efd250b2f062b68ff41ac36b29d3dcad710142154e4df7a947ff16df7df1ee7a8f48ed92641a3e3551a5c03de8ba9ae7a2983129c723907269cf2d1f129abbb7003f46f427f56781a5cfe32093f06861b543965a0c31b23d4dbdac6f00e6bfd05ed608faced663f05c21be78e1810a2e1a2dbf93b6096c6c50399b21a4398f96cb844e17955ae57abdcbd44be1ba40b367e7b9c9ed1f9fa24fdfbd9b998bd6b537b95fd57987e7d2asdf0000ffff\",\"0300d4ea6asdfa20e0000\"]\r\n```\r\n\r\nAny thoughts?"},"comment":{"url":"https://api.github.com/repos/microapps/Shopify-api-node/issues/comments/256259166","html_url":"https://github.com/microapps/Shopify-api-node/issues/104#issuecomment-256259166","issue_url":"https://api.github.com/repos/microapps/Shopify-api-node/issues/104","id":256259166,"user":{"login":"lpinca","id":1443911,"avatar_url":"https://avatars.githubusercontent.com/u/1443911?v=3","gravatar_id":"","url":"https://api.github.com/users/lpinca","html_url":"https://github.com/lpinca","followers_url":"https://api.github.com/users/lpinca/followers","following_url":"https://api.github.com/users/lpinca/following{/other_user}","gists_url":"https://api.github.com/users/lpinca/gists{/gist_id}","starred_url":"https://api.github.com/users/lpinca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpinca/subscriptions","organizations_url":"https://api.github.com/users/lpinca/orgs","repos_url":"https://api.github.com/users/lpinca/repos","events_url":"https://api.github.com/users/lpinca/events{/privacy}","received_events_url":"https://api.github.com/users/lpinca/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T06:18:19Z","updated_at":"2016-10-26T06:18:19Z","body":"I'm not sure if I understand the issue correctly but in our test suite we encode the query parameters before hand and append them to the path, see https://github.com/microapps/Shopify-api-node/blob/5e79840bb074b1c2d9ca908b9d92adadfee56201/test/asset.test.js#L45.\r\n\r\nIf this doesn't help can you clarify or provide more details?\r\nThanks."}}
{"actor":{"display_login":"lpinca"}}