{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments/61078461","id":61078461,"diff_hunk":"@@ -0,0 +1,27 @@\n+﻿//-----------------------------------------------------------------------\n+// <copyright file=\"BoundSonarQubeProjectExtensions.cs\" company=\"SonarSource SA and Microsoft Corporation\">\n+//   Copyright (c) SonarSource SA and Microsoft Corporation.  All rights reserved.\n+//   Licensed under the MIT License. See License.txt in the project root for license information.\n+// </copyright>\n+//-----------------------------------------------------------------------\n+\n+using SonarLint.VisualStudio.Integration.Service;\n+using System;\n+\n+namespace SonarLint.VisualStudio.Integration.Persistence\n+{\n+    internal static class BoundSonarQubeProjectExtensions\n+    {\n+        public static ConnectionInformation CreateConnectionInformation(this BoundSonarQubeProject binding)","path":"src/Integration/Persistence/BoundSonarQubeProjectExtensions.cs","position":15,"original_position":15,"commit_id":"a0fd39c8f652eebc11b7b5f2aae8349d1944eabc","original_commit_id":"9b0a4c864c8d97c4549a0a7faa76889095c92b79","user":{"login":"mjcheetham","id":5658207,"avatar_url":"https://avatars.githubusercontent.com/u/5658207?v=3","gravatar_id":"","url":"https://api.github.com/users/mjcheetham","html_url":"https://github.com/mjcheetham","followers_url":"https://api.github.com/users/mjcheetham/followers","following_url":"https://api.github.com/users/mjcheetham/following{/other_user}","gists_url":"https://api.github.com/users/mjcheetham/gists{/gist_id}","starred_url":"https://api.github.com/users/mjcheetham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjcheetham/subscriptions","organizations_url":"https://api.github.com/users/mjcheetham/orgs","repos_url":"https://api.github.com/users/mjcheetham/repos","events_url":"https://api.github.com/users/mjcheetham/events{/privacy}","received_events_url":"https://api.github.com/users/mjcheetham/received_events","type":"User","site_admin":false},"body":"Tests?","created_at":"2016-04-26T12:47:07Z","updated_at":"2016-04-26T12:47:08Z","html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/66#discussion_r61078461","pull_request_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments/61078461"},"html":{"href":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/66#discussion_r61078461"},"pull_request":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66","id":67607108,"html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/66","diff_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/66.diff","patch_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/66.patch","issue_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/66","number":66,"state":"open","locked":false,"title":"[SVS-9] Implemented ErrorListInfoBarController","user":{"login":"eyalantzMS","id":16574964,"avatar_url":"https://avatars.githubusercontent.com/u/16574964?v=3","gravatar_id":"","url":"https://api.github.com/users/eyalantzMS","html_url":"https://github.com/eyalantzMS","followers_url":"https://api.github.com/users/eyalantzMS/followers","following_url":"https://api.github.com/users/eyalantzMS/following{/other_user}","gists_url":"https://api.github.com/users/eyalantzMS/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalantzMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalantzMS/subscriptions","organizations_url":"https://api.github.com/users/eyalantzMS/orgs","repos_url":"https://api.github.com/users/eyalantzMS/repos","events_url":"https://api.github.com/users/eyalantzMS/events{/privacy}","received_events_url":"https://api.github.com/users/eyalantzMS/received_events","type":"User","site_admin":false},"body":"Implemented the controller that will show the info bar and will handle the Update command.\r\n\r\nI've considered just using the binding and connection workflows instead of driving the experience via the section, but decided not to do it since it could introduce various race conditions and avoiding them would require increasing the overall complexity which i preferred to avoid.\r\nThe approach used drives the flow using the WPF commands by passing the right arguments to those commands, so essentially exactly the same as the user would have done, so no added risk.\r\n\r\nMisc:\r\n1. BindingController - removed dead code that was checked in part of SLVS-87 + some other minor change to be consisted with the ConnectionController\r\n2. ConnectionController/Workflow - Simplified the code (was getting a delegate that could have been directly called from within the workflow)\r\n3. Added another telemetry to the fix-conflicts: one that records the number of times we showed the UX in addition to the existing fix-conflicts command telemetry. Now we should be able to see if the users trust that feature :) ","created_at":"2016-04-23T13:44:57Z","updated_at":"2016-04-26T12:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30e135ffeae2b8258d62c7a02942b709d752710f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66/commits","review_comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66/comments","review_comment_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/66/comments","statuses_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/a0fd39c8f652eebc11b7b5f2aae8349d1944eabc","head":{"label":"SonarSource-VisualStudio:SVS-9_ErrorListController","ref":"SVS-9_ErrorListController","sha":"a0fd39c8f652eebc11b7b5f2aae8349d1944eabc","user":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":50510037,"name":"sonarlint-visualstudio","full_name":"SonarSource-VisualStudio/sonarlint-visualstudio","owner":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio","forks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/forks","keys_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/teams","hooks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/hooks","issue_events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/events","assignees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/tags","blobs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/languages","stargazers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/stargazers","contributors_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contributors","subscribers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscribers","subscription_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscription","commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/merges","archive_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/downloads","issues_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/deployments","created_at":"2016-01-27T13:44:12Z","updated_at":"2016-04-05T16:51:17Z","pushed_at":"2016-04-26T11:23:08Z","git_url":"git://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","ssh_url":"git@github.com:SonarSource-VisualStudio/sonarlint-visualstudio.git","clone_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","svn_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","homepage":null,"size":1831,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"SonarSource-VisualStudio:master","ref":"master","sha":"12ea8c9c96cb034d389449629b52775c52e6b210","user":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":50510037,"name":"sonarlint-visualstudio","full_name":"SonarSource-VisualStudio/sonarlint-visualstudio","owner":{"login":"SonarSource-VisualStudio","id":16780579,"avatar_url":"https://avatars.githubusercontent.com/u/16780579?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarSource-VisualStudio","html_url":"https://github.com/SonarSource-VisualStudio","followers_url":"https://api.github.com/users/SonarSource-VisualStudio/followers","following_url":"https://api.github.com/users/SonarSource-VisualStudio/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource-VisualStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource-VisualStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource-VisualStudio/subscriptions","organizations_url":"https://api.github.com/users/SonarSource-VisualStudio/orgs","repos_url":"https://api.github.com/users/SonarSource-VisualStudio/repos","events_url":"https://api.github.com/users/SonarSource-VisualStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource-VisualStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","description":"","fork":false,"url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio","forks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/forks","keys_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/teams","hooks_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/hooks","issue_events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/events","assignees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/tags","blobs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/languages","stargazers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/stargazers","contributors_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contributors","subscribers_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscribers","subscription_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/subscription","commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/merges","archive_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/downloads","issues_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/deployments","created_at":"2016-01-27T13:44:12Z","updated_at":"2016-04-05T16:51:17Z","pushed_at":"2016-04-26T11:23:08Z","git_url":"git://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","ssh_url":"git@github.com:SonarSource-VisualStudio/sonarlint-visualstudio.git","clone_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio.git","svn_url":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio","homepage":null,"size":1831,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66"},"html":{"href":"https://github.com/SonarSource-VisualStudio/sonarlint-visualstudio/pull/66"},"issue":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/66"},"comments":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource-VisualStudio/sonarlint-visualstudio/statuses/a0fd39c8f652eebc11b7b5f2aae8349d1944eabc"}}}}