{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/52472874","id":52472874,"diff_hunk":"@@ -108,6 +106,18 @@ export default class ReplicationControllerDetailController {\n      * @export {boolean}\n      */\n     this.eventsOrder = DOWNWARDS;\n+\n+    /**\n+     * If true then sidebar will be displayed, otherwise it won't.\n+     * @export {boolean}\n+     */\n+    this.displaySidebar = this.mdMedia('gt-sm');\n+\n+    /**\n+     * Binding resize listener, which switches displaySidebar boolean variable.\n+     */\n+    angular.element(this.window)","path":"src/app/frontend/replicationcontrollerdetail/replicationcontrollerdetail_controller.js","position":null,"original_position":63,"commit_id":"5b5364d5408ab019d204efa0f200fa246f1e5ebc","original_commit_id":"a0bb3daa03ba798b912a9df4fd8c1f1869e88e74","user":{"login":"batikanu","id":11628279,"avatar_url":"https://avatars.githubusercontent.com/u/11628279?v=3","gravatar_id":"","url":"https://api.github.com/users/batikanu","html_url":"https://github.com/batikanu","followers_url":"https://api.github.com/users/batikanu/followers","following_url":"https://api.github.com/users/batikanu/following{/other_user}","gists_url":"https://api.github.com/users/batikanu/gists{/gist_id}","starred_url":"https://api.github.com/users/batikanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batikanu/subscriptions","organizations_url":"https://api.github.com/users/batikanu/orgs","repos_url":"https://api.github.com/users/batikanu/repos","events_url":"https://api.github.com/users/batikanu/events{/privacy}","received_events_url":"https://api.github.com/users/batikanu/received_events","type":"User","site_admin":false},"body":"Yes I see the duplication. It looks much better I think now.","created_at":"2016-02-10T15:33:27Z","updated_at":"2016-02-10T15:33:27Z","html_url":"https://github.com/kubernetes/dashboard/pull/343#discussion_r52472874","pull_request_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/52472874"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/343#discussion_r52472874"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/343","id":58747687,"html_url":"https://github.com/kubernetes/dashboard/pull/343","diff_url":"https://github.com/kubernetes/dashboard/pull/343.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/343.patch","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/343","number":343,"state":"open","locked":false,"title":"Hide details page sidebar on narrow screens into tab","user":{"login":"maciaszczykm","id":2823399,"avatar_url":"https://avatars.githubusercontent.com/u/2823399?v=3","gravatar_id":"","url":"https://api.github.com/users/maciaszczykm","html_url":"https://github.com/maciaszczykm","followers_url":"https://api.github.com/users/maciaszczykm/followers","following_url":"https://api.github.com/users/maciaszczykm/following{/other_user}","gists_url":"https://api.github.com/users/maciaszczykm/gists{/gist_id}","starred_url":"https://api.github.com/users/maciaszczykm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciaszczykm/subscriptions","organizations_url":"https://api.github.com/users/maciaszczykm/orgs","repos_url":"https://api.github.com/users/maciaszczykm/repos","events_url":"https://api.github.com/users/maciaszczykm/events{/privacy}","received_events_url":"https://api.github.com/users/maciaszczykm/received_events","type":"User","site_admin":false},"body":"Connected to #334 issue.\r\n\r\n~~With these changes sidebar will be hidden when page inner width is below `MIN_CONTENT_WIDTH = 800`.~~\r\n\r\n~~@bryk `MIN_CONTENT_WIDTH` value can be changed. I saw, that in `replicationcontrollerlistcontainer.js ` there is ineresting usage of `mdMedia` service. Perhaps it should be used also here?~~\r\n\r\nChecklist:\r\n- [x] updated UI and created new directive for sidebar content\r\n- [x] mdMedia usage\r\n- [x] updated tests\r\n- [ ] details tab placement and content?\r\n\r\nScreenshots:\r\n![image](https://cloud.githubusercontent.com/assets/2823399/12917522/311d1614-cf3a-11e5-83de-8c936973f328.png)\r\n![image](https://cloud.githubusercontent.com/assets/2823399/12917509/200a7cfe-cf3a-11e5-97d1-e9c46758abab.png)\r\n\r\nPlease do not merge before all above points will be checked. I've created this pull request now to start discussion about possible improvements. If you have any sugesstions please let me know.","created_at":"2016-02-09T13:36:22Z","updated_at":"2016-02-10T15:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68816ca0795ecc65fe8b223ef5c069e0dd961b17","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/343/commits","review_comments_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/343/comments","review_comment_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/343/comments","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/5b5364d5408ab019d204efa0f200fa246f1e5ebc","head":{"label":"maciaszczykm:details-styling","ref":"details-styling","sha":"5b5364d5408ab019d204efa0f200fa246f1e5ebc","user":{"login":"maciaszczykm","id":2823399,"avatar_url":"https://avatars.githubusercontent.com/u/2823399?v=3","gravatar_id":"","url":"https://api.github.com/users/maciaszczykm","html_url":"https://github.com/maciaszczykm","followers_url":"https://api.github.com/users/maciaszczykm/followers","following_url":"https://api.github.com/users/maciaszczykm/following{/other_user}","gists_url":"https://api.github.com/users/maciaszczykm/gists{/gist_id}","starred_url":"https://api.github.com/users/maciaszczykm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciaszczykm/subscriptions","organizations_url":"https://api.github.com/users/maciaszczykm/orgs","repos_url":"https://api.github.com/users/maciaszczykm/repos","events_url":"https://api.github.com/users/maciaszczykm/events{/privacy}","received_events_url":"https://api.github.com/users/maciaszczykm/received_events","type":"User","site_admin":false},"repo":{"id":45401188,"name":"dashboard","full_name":"maciaszczykm/dashboard","owner":{"login":"maciaszczykm","id":2823399,"avatar_url":"https://avatars.githubusercontent.com/u/2823399?v=3","gravatar_id":"","url":"https://api.github.com/users/maciaszczykm","html_url":"https://github.com/maciaszczykm","followers_url":"https://api.github.com/users/maciaszczykm/followers","following_url":"https://api.github.com/users/maciaszczykm/following{/other_user}","gists_url":"https://api.github.com/users/maciaszczykm/gists{/gist_id}","starred_url":"https://api.github.com/users/maciaszczykm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciaszczykm/subscriptions","organizations_url":"https://api.github.com/users/maciaszczykm/orgs","repos_url":"https://api.github.com/users/maciaszczykm/repos","events_url":"https://api.github.com/users/maciaszczykm/events{/privacy}","received_events_url":"https://api.github.com/users/maciaszczykm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maciaszczykm/dashboard","description":"Fork of Kubernetes Dashboard from Google","fork":true,"url":"https://api.github.com/repos/maciaszczykm/dashboard","forks_url":"https://api.github.com/repos/maciaszczykm/dashboard/forks","keys_url":"https://api.github.com/repos/maciaszczykm/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maciaszczykm/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maciaszczykm/dashboard/teams","hooks_url":"https://api.github.com/repos/maciaszczykm/dashboard/hooks","issue_events_url":"https://api.github.com/repos/maciaszczykm/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/maciaszczykm/dashboard/events","assignees_url":"https://api.github.com/repos/maciaszczykm/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/maciaszczykm/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/maciaszczykm/dashboard/tags","blobs_url":"https://api.github.com/repos/maciaszczykm/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maciaszczykm/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maciaszczykm/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/maciaszczykm/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maciaszczykm/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/maciaszczykm/dashboard/languages","stargazers_url":"https://api.github.com/repos/maciaszczykm/dashboard/stargazers","contributors_url":"https://api.github.com/repos/maciaszczykm/dashboard/contributors","subscribers_url":"https://api.github.com/repos/maciaszczykm/dashboard/subscribers","subscription_url":"https://api.github.com/repos/maciaszczykm/dashboard/subscription","commits_url":"https://api.github.com/repos/maciaszczykm/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/maciaszczykm/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/maciaszczykm/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/maciaszczykm/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/maciaszczykm/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/maciaszczykm/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maciaszczykm/dashboard/merges","archive_url":"https://api.github.com/repos/maciaszczykm/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maciaszczykm/dashboard/downloads","issues_url":"https://api.github.com/repos/maciaszczykm/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/maciaszczykm/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/maciaszczykm/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/maciaszczykm/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maciaszczykm/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/maciaszczykm/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/maciaszczykm/dashboard/deployments","created_at":"2015-11-02T14:57:50Z","updated_at":"2016-01-11T11:49:15Z","pushed_at":"2016-02-10T14:47:34Z","git_url":"git://github.com/maciaszczykm/dashboard.git","ssh_url":"git@github.com:maciaszczykm/dashboard.git","clone_url":"https://github.com/maciaszczykm/dashboard.git","svn_url":"https://github.com/maciaszczykm/dashboard","homepage":"http://kubernetes.io/","size":43544,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8af746521d020d42d84b1278df1180a7c50d08e6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":44350607,"name":"dashboard","full_name":"kubernetes/dashboard","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/dashboard","description":"General-purpose web UI for Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/dashboard","forks_url":"https://api.github.com/repos/kubernetes/dashboard/forks","keys_url":"https://api.github.com/repos/kubernetes/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/dashboard/teams","hooks_url":"https://api.github.com/repos/kubernetes/dashboard/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/dashboard/events","assignees_url":"https://api.github.com/repos/kubernetes/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/dashboard/tags","blobs_url":"https://api.github.com/repos/kubernetes/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/dashboard/languages","stargazers_url":"https://api.github.com/repos/kubernetes/dashboard/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/dashboard/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/dashboard/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/dashboard/subscription","commits_url":"https://api.github.com/repos/kubernetes/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/dashboard/merges","archive_url":"https://api.github.com/repos/kubernetes/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/dashboard/downloads","issues_url":"https://api.github.com/repos/kubernetes/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/dashboard/deployments","created_at":"2015-10-15T23:09:14Z","updated_at":"2016-02-10T13:13:34Z","pushed_at":"2016-02-10T14:47:35Z","git_url":"git://github.com/kubernetes/dashboard.git","ssh_url":"git@github.com:kubernetes/dashboard.git","clone_url":"https://github.com/kubernetes/dashboard.git","svn_url":"https://github.com/kubernetes/dashboard","homepage":"","size":43662,"stargazers_count":103,"watchers_count":103,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":43,"forks":32,"open_issues":43,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/343"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/343"},"issue":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/343"},"comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/dashboard/statuses/5b5364d5408ab019d204efa0f200fa246f1e5ebc"}}}}