{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments/83818373","pull_request_review_id":4634526,"id":83818373,"diff_hunk":"@@ -1,14 +1,98 @@\n-import React from 'react';\n+import React, { PropTypes } from 'react';\n+import classNames from 'classnames';\n+\n+import theme from './DisplayTile.scss';\n+\n+const columnPropType = PropTypes.shape({\n+\tkey: PropTypes.string.isRequired,\n+\tlabel: PropTypes.string.isRequired,\n+});\n+\n+/**\n+ * render a tile sub element\n+ */\n+function TileItem({ value, column }) {\n+\tlet renderValue = value;\n+\tif (column.formater) {\n+\t\trenderValue = column.formater(value);\n+\t}\n+\treturn (\n+\t\t<li><span className={theme.tileItemTitle}>{column.label} : </span>{renderValue}</li>","path":"src/List/DisplayTile/DisplayTile.component.js","position":21,"original_position":21,"commit_id":"17c7379f098ec3e56ed8f61dfc685df3ed4efa23","original_commit_id":"17c7379f098ec3e56ed8f61dfc685df3ed4efa23","user":{"login":"frassinier","id":18534166,"avatar_url":"https://avatars.githubusercontent.com/u/18534166?v=3","gravatar_id":"","url":"https://api.github.com/users/frassinier","html_url":"https://github.com/frassinier","followers_url":"https://api.github.com/users/frassinier/followers","following_url":"https://api.github.com/users/frassinier/following{/other_user}","gists_url":"https://api.github.com/users/frassinier/gists{/gist_id}","starred_url":"https://api.github.com/users/frassinier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frassinier/subscriptions","organizations_url":"https://api.github.com/users/frassinier/orgs","repos_url":"https://api.github.com/users/frassinier/repos","events_url":"https://api.github.com/users/frassinier/events{/privacy}","received_events_url":"https://api.github.com/users/frassinier/received_events","type":"User","site_admin":false},"body":"You should not embed `<li>` inside `<TileItem/>` component","created_at":"2016-10-18T09:48:20Z","updated_at":"2016-10-18T09:57:36Z","html_url":"https://github.com/Talend/react-talend-components/pull/29#discussion_r83818373","pull_request_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments/83818373"},"html":{"href":"https://github.com/Talend/react-talend-components/pull/29#discussion_r83818373"},"pull_request":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/react-talend-components/pulls/29","id":89624933,"html_url":"https://github.com/Talend/react-talend-components/pull/29","diff_url":"https://github.com/Talend/react-talend-components/pull/29.diff","patch_url":"https://github.com/Talend/react-talend-components/pull/29.patch","issue_url":"https://api.github.com/repos/Talend/react-talend-components/issues/29","number":29,"state":"open","locked":false,"title":"feat(list): list -> tiles render","user":{"login":"acateland","id":19344650,"avatar_url":"https://avatars.githubusercontent.com/u/19344650?v=3","gravatar_id":"","url":"https://api.github.com/users/acateland","html_url":"https://github.com/acateland","followers_url":"https://api.github.com/users/acateland/followers","following_url":"https://api.github.com/users/acateland/following{/other_user}","gists_url":"https://api.github.com/users/acateland/gists{/gist_id}","starred_url":"https://api.github.com/users/acateland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acateland/subscriptions","organizations_url":"https://api.github.com/users/acateland/orgs","repos_url":"https://api.github.com/users/acateland/repos","events_url":"https://api.github.com/users/acateland/events{/privacy}","received_events_url":"https://api.github.com/users/acateland/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [X] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format)\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [X] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\ntile rendering was not implemented\r\n\r\n\r\n**What is the new behavior?**\r\nTiles are beautifull and render\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [X] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\nwaiting for more input from graph team","created_at":"2016-10-17T13:38:00Z","updated_at":"2016-10-18T09:57:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b24992c96e2cbaf7f86b03a827f19aff87c6eee6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/react-talend-components/issues/29/comments","statuses_url":"https://api.github.com/repos/Talend/react-talend-components/statuses/17c7379f098ec3e56ed8f61dfc685df3ed4efa23","head":{"label":"Talend:feat/list-tiles","ref":"feat/list-tiles","sha":"17c7379f098ec3e56ed8f61dfc685df3ed4efa23","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":70495607,"name":"react-talend-components","full_name":"Talend/react-talend-components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/react-talend-components","description":"Set of stateless react components which implement Talend guidelines","fork":false,"url":"https://api.github.com/repos/Talend/react-talend-components","forks_url":"https://api.github.com/repos/Talend/react-talend-components/forks","keys_url":"https://api.github.com/repos/Talend/react-talend-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/react-talend-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/react-talend-components/teams","hooks_url":"https://api.github.com/repos/Talend/react-talend-components/hooks","issue_events_url":"https://api.github.com/repos/Talend/react-talend-components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/react-talend-components/events","assignees_url":"https://api.github.com/repos/Talend/react-talend-components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/react-talend-components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/react-talend-components/tags","blobs_url":"https://api.github.com/repos/Talend/react-talend-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/react-talend-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/react-talend-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/react-talend-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/react-talend-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/react-talend-components/languages","stargazers_url":"https://api.github.com/repos/Talend/react-talend-components/stargazers","contributors_url":"https://api.github.com/repos/Talend/react-talend-components/contributors","subscribers_url":"https://api.github.com/repos/Talend/react-talend-components/subscribers","subscription_url":"https://api.github.com/repos/Talend/react-talend-components/subscription","commits_url":"https://api.github.com/repos/Talend/react-talend-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/react-talend-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/react-talend-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/react-talend-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/react-talend-components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/react-talend-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/react-talend-components/merges","archive_url":"https://api.github.com/repos/Talend/react-talend-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/react-talend-components/downloads","issues_url":"https://api.github.com/repos/Talend/react-talend-components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/react-talend-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/react-talend-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/react-talend-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/react-talend-components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/react-talend-components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/react-talend-components/deployments","created_at":"2016-10-10T14:22:07Z","updated_at":"2016-10-17T17:41:07Z","pushed_at":"2016-10-18T08:58:31Z","git_url":"git://github.com/Talend/react-talend-components.git","ssh_url":"git@github.com:Talend/react-talend-components.git","clone_url":"https://github.com/Talend/react-talend-components.git","svn_url":"https://github.com/Talend/react-talend-components","homepage":"https://talend.github.io/react-talend-components","size":795,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"4863f9daba1789e3485c6a9dfc7ce081774f2af6","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":70495607,"name":"react-talend-components","full_name":"Talend/react-talend-components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/react-talend-components","description":"Set of stateless react components which implement Talend guidelines","fork":false,"url":"https://api.github.com/repos/Talend/react-talend-components","forks_url":"https://api.github.com/repos/Talend/react-talend-components/forks","keys_url":"https://api.github.com/repos/Talend/react-talend-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/react-talend-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/react-talend-components/teams","hooks_url":"https://api.github.com/repos/Talend/react-talend-components/hooks","issue_events_url":"https://api.github.com/repos/Talend/react-talend-components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/react-talend-components/events","assignees_url":"https://api.github.com/repos/Talend/react-talend-components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/react-talend-components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/react-talend-components/tags","blobs_url":"https://api.github.com/repos/Talend/react-talend-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/react-talend-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/react-talend-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/react-talend-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/react-talend-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/react-talend-components/languages","stargazers_url":"https://api.github.com/repos/Talend/react-talend-components/stargazers","contributors_url":"https://api.github.com/repos/Talend/react-talend-components/contributors","subscribers_url":"https://api.github.com/repos/Talend/react-talend-components/subscribers","subscription_url":"https://api.github.com/repos/Talend/react-talend-components/subscription","commits_url":"https://api.github.com/repos/Talend/react-talend-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/react-talend-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/react-talend-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/react-talend-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/react-talend-components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/react-talend-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/react-talend-components/merges","archive_url":"https://api.github.com/repos/Talend/react-talend-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/react-talend-components/downloads","issues_url":"https://api.github.com/repos/Talend/react-talend-components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/react-talend-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/react-talend-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/react-talend-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/react-talend-components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/react-talend-components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/react-talend-components/deployments","created_at":"2016-10-10T14:22:07Z","updated_at":"2016-10-17T17:41:07Z","pushed_at":"2016-10-18T08:58:31Z","git_url":"git://github.com/Talend/react-talend-components.git","ssh_url":"git@github.com:Talend/react-talend-components.git","clone_url":"https://github.com/Talend/react-talend-components.git","svn_url":"https://github.com/Talend/react-talend-components","homepage":"https://talend.github.io/react-talend-components","size":795,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/29"},"html":{"href":"https://github.com/Talend/react-talend-components/pull/29"},"issue":{"href":"https://api.github.com/repos/Talend/react-talend-components/issues/29"},"comments":{"href":"https://api.github.com/repos/Talend/react-talend-components/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/react-talend-components/statuses/17c7379f098ec3e56ed8f61dfc685df3ed4efa23"}}}}
{"actor":{"display_login":"frassinier"}}