{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/28","id":66021431,"html_url":"https://github.com/emacs-eclim/emacs-eclim/pull/28","diff_url":"https://github.com/emacs-eclim/emacs-eclim/pull/28.diff","patch_url":"https://github.com/emacs-eclim/emacs-eclim/pull/28.patch","issue_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/issues/28","number":28,"state":"closed","locked":false,"title":"Completion: allow the user to customize insertion.","user":{"login":"ovy","id":65599,"avatar_url":"https://avatars.githubusercontent.com/u/65599?v=3","gravatar_id":"","url":"https://api.github.com/users/ovy","html_url":"https://github.com/ovy","followers_url":"https://api.github.com/users/ovy/followers","following_url":"https://api.github.com/users/ovy/following{/other_user}","gists_url":"https://api.github.com/users/ovy/gists{/gist_id}","starred_url":"https://api.github.com/users/ovy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovy/subscriptions","organizations_url":"https://api.github.com/users/ovy/orgs","repos_url":"https://api.github.com/users/ovy/repos","events_url":"https://api.github.com/users/ovy/events{/privacy}","received_events_url":"https://api.github.com/users/ovy/received_events","type":"User","site_admin":false},"body":"I think yas is problematic for completion because:\r\n* Completion begins by spitting out a potentially long method signature\r\n* Aborting from yas can't resume, so you're left with above\r\n* The code can be in a non-sensical (for Eclipse) state for quite\r\na long time. This can prevent further coding aids.\r\n* Yas is intrusive and wants to be a minor mode everywhere.\r\n\r\nThe default insertion is hardly better. So one should at least have the\r\noption to do something different. I put in a simple (and sample)\r\nalternative that simply erases arguments, which is already an improvement,\r\nbut I have something better for the next commit.","created_at":"2016-04-11T16:17:34Z","updated_at":"2016-04-18T18:29:30Z","closed_at":"2016-04-18T18:29:30Z","merged_at":"2016-04-18T18:29:30Z","merge_commit_sha":"b6daef5acf3e8cece565f410853ec4eebb4f8925","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/28/commits","review_comments_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/28/comments","review_comment_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/issues/28/comments","statuses_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/statuses/b6daef5acf3e8cece565f410853ec4eebb4f8925","head":{"label":"ovy:completion","ref":"completion","sha":"b6daef5acf3e8cece565f410853ec4eebb4f8925","user":{"login":"ovy","id":65599,"avatar_url":"https://avatars.githubusercontent.com/u/65599?v=3","gravatar_id":"","url":"https://api.github.com/users/ovy","html_url":"https://github.com/ovy","followers_url":"https://api.github.com/users/ovy/followers","following_url":"https://api.github.com/users/ovy/following{/other_user}","gists_url":"https://api.github.com/users/ovy/gists{/gist_id}","starred_url":"https://api.github.com/users/ovy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovy/subscriptions","organizations_url":"https://api.github.com/users/ovy/orgs","repos_url":"https://api.github.com/users/ovy/repos","events_url":"https://api.github.com/users/ovy/events{/privacy}","received_events_url":"https://api.github.com/users/ovy/received_events","type":"User","site_admin":false},"repo":{"id":40951756,"name":"emacs-eclim","full_name":"ovy/emacs-eclim","owner":{"login":"ovy","id":65599,"avatar_url":"https://avatars.githubusercontent.com/u/65599?v=3","gravatar_id":"","url":"https://api.github.com/users/ovy","html_url":"https://github.com/ovy","followers_url":"https://api.github.com/users/ovy/followers","following_url":"https://api.github.com/users/ovy/following{/other_user}","gists_url":"https://api.github.com/users/ovy/gists{/gist_id}","starred_url":"https://api.github.com/users/ovy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovy/subscriptions","organizations_url":"https://api.github.com/users/ovy/orgs","repos_url":"https://api.github.com/users/ovy/repos","events_url":"https://api.github.com/users/ovy/events{/privacy}","received_events_url":"https://api.github.com/users/ovy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ovy/emacs-eclim","description":"This project brings some of the great eclipse features to emacs developers. It is based on the eclim project, which provides eclipse features for vim.","fork":true,"url":"https://api.github.com/repos/ovy/emacs-eclim","forks_url":"https://api.github.com/repos/ovy/emacs-eclim/forks","keys_url":"https://api.github.com/repos/ovy/emacs-eclim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovy/emacs-eclim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovy/emacs-eclim/teams","hooks_url":"https://api.github.com/repos/ovy/emacs-eclim/hooks","issue_events_url":"https://api.github.com/repos/ovy/emacs-eclim/issues/events{/number}","events_url":"https://api.github.com/repos/ovy/emacs-eclim/events","assignees_url":"https://api.github.com/repos/ovy/emacs-eclim/assignees{/user}","branches_url":"https://api.github.com/repos/ovy/emacs-eclim/branches{/branch}","tags_url":"https://api.github.com/repos/ovy/emacs-eclim/tags","blobs_url":"https://api.github.com/repos/ovy/emacs-eclim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovy/emacs-eclim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovy/emacs-eclim/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovy/emacs-eclim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovy/emacs-eclim/statuses/{sha}","languages_url":"https://api.github.com/repos/ovy/emacs-eclim/languages","stargazers_url":"https://api.github.com/repos/ovy/emacs-eclim/stargazers","contributors_url":"https://api.github.com/repos/ovy/emacs-eclim/contributors","subscribers_url":"https://api.github.com/repos/ovy/emacs-eclim/subscribers","subscription_url":"https://api.github.com/repos/ovy/emacs-eclim/subscription","commits_url":"https://api.github.com/repos/ovy/emacs-eclim/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovy/emacs-eclim/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovy/emacs-eclim/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovy/emacs-eclim/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovy/emacs-eclim/contents/{+path}","compare_url":"https://api.github.com/repos/ovy/emacs-eclim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovy/emacs-eclim/merges","archive_url":"https://api.github.com/repos/ovy/emacs-eclim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovy/emacs-eclim/downloads","issues_url":"https://api.github.com/repos/ovy/emacs-eclim/issues{/number}","pulls_url":"https://api.github.com/repos/ovy/emacs-eclim/pulls{/number}","milestones_url":"https://api.github.com/repos/ovy/emacs-eclim/milestones{/number}","notifications_url":"https://api.github.com/repos/ovy/emacs-eclim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovy/emacs-eclim/labels{/name}","releases_url":"https://api.github.com/repos/ovy/emacs-eclim/releases{/id}","deployments_url":"https://api.github.com/repos/ovy/emacs-eclim/deployments","created_at":"2015-08-18T05:02:27Z","updated_at":"2015-08-18T05:02:28Z","pushed_at":"2016-04-11T16:15:10Z","git_url":"git://github.com/ovy/emacs-eclim.git","ssh_url":"git@github.com:ovy/emacs-eclim.git","clone_url":"https://github.com/ovy/emacs-eclim.git","svn_url":"https://github.com/ovy/emacs-eclim","homepage":"http://www.emacswiki.org/emacs/EmacsEclim","size":876,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emacs-eclim:master","ref":"master","sha":"de4be90e9b8ee6349e594c42b8889059482b4420","user":{"login":"emacs-eclim","id":16318861,"avatar_url":"https://avatars.githubusercontent.com/u/16318861?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-eclim","html_url":"https://github.com/emacs-eclim","followers_url":"https://api.github.com/users/emacs-eclim/followers","following_url":"https://api.github.com/users/emacs-eclim/following{/other_user}","gists_url":"https://api.github.com/users/emacs-eclim/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-eclim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-eclim/subscriptions","organizations_url":"https://api.github.com/users/emacs-eclim/orgs","repos_url":"https://api.github.com/users/emacs-eclim/repos","events_url":"https://api.github.com/users/emacs-eclim/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-eclim/received_events","type":"Organization","site_admin":false},"repo":{"id":48100541,"name":"emacs-eclim","full_name":"emacs-eclim/emacs-eclim","owner":{"login":"emacs-eclim","id":16318861,"avatar_url":"https://avatars.githubusercontent.com/u/16318861?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-eclim","html_url":"https://github.com/emacs-eclim","followers_url":"https://api.github.com/users/emacs-eclim/followers","following_url":"https://api.github.com/users/emacs-eclim/following{/other_user}","gists_url":"https://api.github.com/users/emacs-eclim/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-eclim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-eclim/subscriptions","organizations_url":"https://api.github.com/users/emacs-eclim/orgs","repos_url":"https://api.github.com/users/emacs-eclim/repos","events_url":"https://api.github.com/users/emacs-eclim/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-eclim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emacs-eclim/emacs-eclim","description":"This project brings some of the great eclipse features to emacs developers. It is based on the eclim project, which provides eclipse features for vim.","fork":true,"url":"https://api.github.com/repos/emacs-eclim/emacs-eclim","forks_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/forks","keys_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/teams","hooks_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/hooks","issue_events_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/issues/events{/number}","events_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/events","assignees_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/assignees{/user}","branches_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/branches{/branch}","tags_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/tags","blobs_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/git/refs{/sha}","trees_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/statuses/{sha}","languages_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/languages","stargazers_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/stargazers","contributors_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/contributors","subscribers_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/subscribers","subscription_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/subscription","commits_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/commits{/sha}","git_commits_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/git/commits{/sha}","comments_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/comments{/number}","issue_comment_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/issues/comments{/number}","contents_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/contents/{+path}","compare_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/merges","archive_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/downloads","issues_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/issues{/number}","pulls_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls{/number}","milestones_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/milestones{/number}","notifications_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/labels{/name}","releases_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/releases{/id}","deployments_url":"https://api.github.com/repos/emacs-eclim/emacs-eclim/deployments","created_at":"2015-12-16T09:28:02Z","updated_at":"2016-04-08T22:13:08Z","pushed_at":"2016-04-18T18:29:29Z","git_url":"git://github.com/emacs-eclim/emacs-eclim.git","ssh_url":"git@github.com:emacs-eclim/emacs-eclim.git","clone_url":"https://github.com/emacs-eclim/emacs-eclim.git","svn_url":"https://github.com/emacs-eclim/emacs-eclim","homepage":"http://www.emacswiki.org/emacs/EmacsEclim","size":868,"stargazers_count":14,"watchers_count":14,"language":"Emacs Lisp","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":10,"forks":8,"open_issues":10,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/28"},"html":{"href":"https://github.com/emacs-eclim/emacs-eclim/pull/28"},"issue":{"href":"https://api.github.com/repos/emacs-eclim/emacs-eclim/issues/28"},"comments":{"href":"https://api.github.com/repos/emacs-eclim/emacs-eclim/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emacs-eclim/emacs-eclim/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/emacs-eclim/emacs-eclim/statuses/b6daef5acf3e8cece565f410853ec4eebb4f8925"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nloyola","id":334607,"avatar_url":"https://avatars.githubusercontent.com/u/334607?v=3","gravatar_id":"","url":"https://api.github.com/users/nloyola","html_url":"https://github.com/nloyola","followers_url":"https://api.github.com/users/nloyola/followers","following_url":"https://api.github.com/users/nloyola/following{/other_user}","gists_url":"https://api.github.com/users/nloyola/gists{/gist_id}","starred_url":"https://api.github.com/users/nloyola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nloyola/subscriptions","organizations_url":"https://api.github.com/users/nloyola/orgs","repos_url":"https://api.github.com/users/nloyola/repos","events_url":"https://api.github.com/users/nloyola/events{/privacy}","received_events_url":"https://api.github.com/users/nloyola/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":36,"deletions":2,"changed_files":2}}