{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/59843308","id":59843308,"diff_hunk":"@@ -606,10 +597,7 @@ def cb_rate_set_form_vars\n       \"weekly\"  => \"Weekly\",\n       \"monthly\" => \"Monthly\"\n     }\n-    if params[:typ] == \"copy\"","path":"app/controllers/chargeback_controller.rb","position":40,"original_position":40,"commit_id":"958f2f886debacdd5a3a4dac13e7eb3e8152bc79","original_commit_id":"958f2f886debacdd5a3a4dac13e7eb3e8152bc79","user":{"login":"lpichler","id":14937244,"avatar_url":"https://avatars.githubusercontent.com/u/14937244?v=3","gravatar_id":"","url":"https://api.github.com/users/lpichler","html_url":"https://github.com/lpichler","followers_url":"https://api.github.com/users/lpichler/followers","following_url":"https://api.github.com/users/lpichler/following{/other_user}","gists_url":"https://api.github.com/users/lpichler/gists{/gist_id}","starred_url":"https://api.github.com/users/lpichler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpichler/subscriptions","organizations_url":"https://api.github.com/users/lpichler/orgs","repos_url":"https://api.github.com/users/lpichler/repos","events_url":"https://api.github.com/users/lpichler/events{/privacy}","received_events_url":"https://api.github.com/users/lpichler/received_events","type":"User","site_admin":false},"body":"same here, unwanted removal ?","created_at":"2016-04-15T08:39:54Z","updated_at":"2016-04-15T08:39:54Z","html_url":"https://github.com/ManageIQ/manageiq/pull/7953#discussion_r59843308","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/59843308"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7953#discussion_r59843308"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953","id":66468584,"html_url":"https://github.com/ManageIQ/manageiq/pull/7953","diff_url":"https://github.com/ManageIQ/manageiq/pull/7953.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/7953.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7953","number":7953,"state":"open","locked":false,"title":"Improve tier range on chargeback edit view","user":{"login":"amaurygonzalez","id":14124243,"avatar_url":"https://avatars.githubusercontent.com/u/14124243?v=3","gravatar_id":"","url":"https://api.github.com/users/amaurygonzalez","html_url":"https://github.com/amaurygonzalez","followers_url":"https://api.github.com/users/amaurygonzalez/followers","following_url":"https://api.github.com/users/amaurygonzalez/following{/other_user}","gists_url":"https://api.github.com/users/amaurygonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/amaurygonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amaurygonzalez/subscriptions","organizations_url":"https://api.github.com/users/amaurygonzalez/orgs","repos_url":"https://api.github.com/users/amaurygonzalez/repos","events_url":"https://api.github.com/users/amaurygonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/amaurygonzalez/received_events","type":"User","site_admin":false},"body":"When defining tiers, currently the user needs to type Infinity in the upper layer. It should be done in a way that is better understood by the customer. \r\nAfter talk with @lpichler and @himdel, my proposal is is to use placeholder, when input is empty placeholder is appeared and it means infinity value. \r\n\r\n![Chargeback with Infinity place holder](http://res.cloudinary.com/ddtbdqfq7/image/upload/v1460621766/Tier_xvjmr0.png)\r\n","created_at":"2016-04-14T11:31:05Z","updated_at":"2016-04-15T08:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2a117245e6bc2963ae6384d7f50bd5102f2ede0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/7953/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/958f2f886debacdd5a3a4dac13e7eb3e8152bc79","head":{"label":"rhus:improve-tier-range-on-chargeback-edit-view","ref":"improve-tier-range-on-chargeback-edit-view","sha":"958f2f886debacdd5a3a4dac13e7eb3e8152bc79","user":{"login":"rhus","id":14151044,"avatar_url":"https://avatars.githubusercontent.com/u/14151044?v=3","gravatar_id":"","url":"https://api.github.com/users/rhus","html_url":"https://github.com/rhus","followers_url":"https://api.github.com/users/rhus/followers","following_url":"https://api.github.com/users/rhus/following{/other_user}","gists_url":"https://api.github.com/users/rhus/gists{/gist_id}","starred_url":"https://api.github.com/users/rhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhus/subscriptions","organizations_url":"https://api.github.com/users/rhus/orgs","repos_url":"https://api.github.com/users/rhus/repos","events_url":"https://api.github.com/users/rhus/events{/privacy}","received_events_url":"https://api.github.com/users/rhus/received_events","type":"Organization","site_admin":false},"repo":{"id":42049284,"name":"manageiq","full_name":"rhus/manageiq","owner":{"login":"rhus","id":14151044,"avatar_url":"https://avatars.githubusercontent.com/u/14151044?v=3","gravatar_id":"","url":"https://api.github.com/users/rhus","html_url":"https://github.com/rhus","followers_url":"https://api.github.com/users/rhus/followers","following_url":"https://api.github.com/users/rhus/following{/other_user}","gists_url":"https://api.github.com/users/rhus/gists{/gist_id}","starred_url":"https://api.github.com/users/rhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhus/subscriptions","organizations_url":"https://api.github.com/users/rhus/orgs","repos_url":"https://api.github.com/users/rhus/repos","events_url":"https://api.github.com/users/rhus/events{/privacy}","received_events_url":"https://api.github.com/users/rhus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhus/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/rhus/manageiq","forks_url":"https://api.github.com/repos/rhus/manageiq/forks","keys_url":"https://api.github.com/repos/rhus/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhus/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhus/manageiq/teams","hooks_url":"https://api.github.com/repos/rhus/manageiq/hooks","issue_events_url":"https://api.github.com/repos/rhus/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/rhus/manageiq/events","assignees_url":"https://api.github.com/repos/rhus/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/rhus/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/rhus/manageiq/tags","blobs_url":"https://api.github.com/repos/rhus/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhus/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhus/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhus/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhus/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/rhus/manageiq/languages","stargazers_url":"https://api.github.com/repos/rhus/manageiq/stargazers","contributors_url":"https://api.github.com/repos/rhus/manageiq/contributors","subscribers_url":"https://api.github.com/repos/rhus/manageiq/subscribers","subscription_url":"https://api.github.com/repos/rhus/manageiq/subscription","commits_url":"https://api.github.com/repos/rhus/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhus/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhus/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhus/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhus/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/rhus/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhus/manageiq/merges","archive_url":"https://api.github.com/repos/rhus/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhus/manageiq/downloads","issues_url":"https://api.github.com/repos/rhus/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/rhus/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/rhus/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/rhus/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhus/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/rhus/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/rhus/manageiq/deployments","created_at":"2015-09-07T11:29:14Z","updated_at":"2016-01-29T13:22:09Z","pushed_at":"2016-04-15T08:21:00Z","git_url":"git://github.com/rhus/manageiq.git","ssh_url":"git@github.com:rhus/manageiq.git","clone_url":"https://github.com/rhus/manageiq.git","svn_url":"https://github.com/rhus/manageiq","homepage":"manageiq.org","size":118371,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2fde06fd65b0088773d6ebe374ffe84b49a69722","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-04-13T14:44:53Z","pushed_at":"2016-04-15T08:24:18Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":155801,"stargazers_count":253,"watchers_count":253,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":268,"mirror_url":null,"open_issues_count":652,"forks":268,"open_issues":652,"watchers":253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/7953"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7953"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/7953/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/7953/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/958f2f886debacdd5a3a4dac13e7eb3e8152bc79"}}}}