{"action":"created","issue":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/949","repository_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/949/labels{/name}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/949/comments","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/949/events","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/949","id":135468809,"number":949,"title":"Additional fixes to support sklearn grid search. ","user":{"login":"jconwell","id":521309,"avatar_url":"https://avatars.githubusercontent.com/u/521309?v=3","gravatar_id":"","url":"https://api.github.com/users/jconwell","html_url":"https://github.com/jconwell","followers_url":"https://api.github.com/users/jconwell/followers","following_url":"https://api.github.com/users/jconwell/following{/other_user}","gists_url":"https://api.github.com/users/jconwell/gists{/gist_id}","starred_url":"https://api.github.com/users/jconwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jconwell/subscriptions","organizations_url":"https://api.github.com/users/jconwell/orgs","repos_url":"https://api.github.com/users/jconwell/repos","events_url":"https://api.github.com/users/jconwell/events{/privacy}","received_events_url":"https://api.github.com/users/jconwell/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-22T16:32:59Z","updated_at":"2016-02-26T21:09:07Z","closed_at":"2016-02-26T21:08:54Z","pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/949","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/949","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/949.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/949.patch"},"body":"Additional fixes to support sklearn grid search.  Added score method (required by grid search), and fixed get/set_params for how sklearn updates estimator parameters during grid search operations.\r\n\r\nNOTE: As of this point _**parallel**_ grid search doesn't work when using a pipeline.  Pipelined estimators take their initial regressors from a file path set in the estimator parameters.  So if you have a grid search running across 4 jobs, each estimator will be reading its initial regressor from the same path. More than likely we'd have to subclass gridsearch to override initial and final regressor paths based on the job number that is running.  Or something like that.  \r\n\r\nPull request details:\r\n\r\n__init__()\r\nAdded a few more vw parameters.  Unfortunately sklearn wants an explicitly named parameter for each estimator parameter, vs passing in a dictionary of key value pairs.  \r\n\r\ntransform() \r\ndouble check if vw is finished \r\n\r\npredict()\r\nadding support for oaa models\r\n\r\nscore()\r\nthe score method is required for sklearn's grid search\r\n\r\nget_params()\r\nreturns estimator's parameters exactly as needed for __init__ to be called with that copy of the parameters.\r\n\r\nset_params()\r\nupdated to handle passes and convert_to_vw"},"comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments/189484143","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/949#issuecomment-189484143","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/949","id":189484143,"user":{"login":"JohnLangford","id":79590,"avatar_url":"https://avatars.githubusercontent.com/u/79590?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnLangford","html_url":"https://github.com/JohnLangford","followers_url":"https://api.github.com/users/JohnLangford/followers","following_url":"https://api.github.com/users/JohnLangford/following{/other_user}","gists_url":"https://api.github.com/users/JohnLangford/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLangford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLangford/subscriptions","organizations_url":"https://api.github.com/users/JohnLangford/orgs","repos_url":"https://api.github.com/users/JohnLangford/repos","events_url":"https://api.github.com/users/JohnLangford/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLangford/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T21:09:07Z","updated_at":"2016-02-26T21:09:07Z","body":"Looks good from what I can tell, merging."}}