{"push_id":1183362959,"size":57,"distinct_size":1,"ref":"refs/heads/PCHR-1082-Implement-new-design-for-Advanced-Search-page","head":"7c7bfd5c7fdf1de151af199e8c5074f254fd9274","before":"d7debd5e230571b690bc2da84ae7e9bc57acaba2","commits":[{"sha":"2fdfb5b91a6ad2157ddf1ce94da283037728c75e","author":{"name":"vidhatanand","email":"4729765a432dd00c1d113260c4c12a08733ce359@gmail.com"},"message":"PCHR-1146 : Commenting out the line causung this issue","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/2fdfb5b91a6ad2157ddf1ce94da283037728c75e"},{"sha":"497ec5dafebcbf9928ab55d248301521ebc356d8","author":{"name":"vidhatanand","email":"4729765a432dd00c1d113260c4c12a08733ce359@gmail.com"},"message":"Merge pull request #973 from civicrm/PCHR-1146-Bug-default-location-type\n\nPCHR-1146 : Commenting out the line causing \"Default location type\" to reset.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/497ec5dafebcbf9928ab55d248301521ebc356d8"},{"sha":"3089f8281a0fad195bde889848a4f0be62182bfc","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1210: Remove the carry forward expiration date fields from the AbsenceType\n\nTo make things simpler on the entitlement calculation, it was decided to remove\nthese fields from the AbsenceType. Now, the expiration of carry forward days will\nonly be calculated in terms of duration.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/3089f8281a0fad195bde889848a4f0be62182bfc"},{"sha":"887dae1da7d771c80d78d2928a7e76ea6fd3f7ad","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1210: Refactor AbsenceType BAO tests to run faster\n\nThe dependency on CiviUnitTestCase was making the tests perfomance\nvery poor. By removing it, the average time to run the tests decreased from\n31s to 1.8s \\o/\n\nIn order to remove CiviUnitTestCase, a small change to the createReservedType\nmethod was required. It was using the getConnection() method to get a\nconnection witht the test database and insert data on it. I replaced this with\nthe CRM_Core_DAO and its executeQuery method.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/887dae1da7d771c80d78d2928a7e76ea6fd3f7ad"},{"sha":"d9867a1e7a5750bb1365dd4d37e53905f93c6a5e","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1210: Refactoring to the AbsenceType BAO\n\nThe getDefaultValues method was renamed to getValuesArray, to make it\nconsistent with the other BAOs. A test for this method was also added.\n\nAdded comments for some methods that were missing them.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/d9867a1e7a5750bb1365dd4d37e53905f93c6a5e"},{"sha":"412544935e19ec4a9a65f2dbeb22da2ff0ed8327","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"Merge pull request #977 from civicrm/PCHR-1210-remove-carry-forward-expiration-date-from-absence-type\n\nPCHR-1210: Remove the carry forward expiration date from Absence Type","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/412544935e19ec4a9a65f2dbeb22da2ff0ed8327"},{"sha":"9324743756ccebf4b467a5f1bcf2d59f163b2232","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add the getPreviousPeriod to the AbsencePeriod BAO\n\nThis method returns the previous AbsencePeriod for another AbsencePeriod\ninstance. That is, the period where weight is equal to this AbsencePeriod weight - 1.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/9324743756ccebf4b467a5f1bcf2d59f163b2232"},{"sha":"6159744ad2f029dd092fef53d4da635318371782","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add the getContractEntitlementForPeriod to the Entitlement BAO\n\nA simple helper method that returns an Entitlement instance for the given Contract,\nAbsencePeriod and AbsenceType.\n\nThis was created mainly to encapsulate the Entitlement retrieval during the Entitlement\nCalculation.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/6159744ad2f029dd092fef53d4da635318371782"},{"sha":"f7e45c64b62d421bd872a0f46e7c4cdeb249c989","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add helpers methods to deal with the AbsenceType expiration date\n\nAdded methods:\n- carryForwardNeverExpires: Returns true if type allows carry forward and doesn't\nhas an expiration duration\n- hasExpirationDuration: Returns true if type carry forward has an expiration\nduration\n- getExpirationDurationDate: Based on a startDate and the type's expiration\nduration, calculates the carry forward expiration date.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/f7e45c64b62d421bd872a0f46e7c4cdeb249c989"},{"sha":"91d24a85c1946ef731ecac8ac74142614430490f","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Move the AbsenceType expiration date calculation to AbsencePeriod\n\nSince this calculation was based on the period dates, I decided to move the\ngetExpirationDurationDate from the AbsenceType BAO to AbsencePeriod.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/91d24a85c1946ef731ecac8ac74142614430490f"},{"sha":"4fc984972cd421266ac3770ed9ac14ba2490ecd2","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add the EntitlementCalculation.getBroughtForward method\n\nThis method is part of the entitlement calculation process and returns the\nnumber of days brought forward from the previous period.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/4fc984972cd421266ac3770ed9ac14ba2490ecd2"},{"sha":"b5f61e706e4e2e5803068cf1b3015d694ab7aa4d","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add the EntitlementCalculation.getContractualEntitlement method\n\nThis method uses the HRJobLeave to retrieve the contractual entitlement for an\nabsence type set for a contract. If it was set that it should add public holidays,\nthe number of public holidays of the calculation absence period is retrieved and\nadded to the entitlement.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/b5f61e706e4e2e5803068cf1b3015d694ab7aa4d"},{"sha":"af4b835551adb812a8ef10b3f587b9c2ac59591a","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add the EntitlementCalculation.getProRata method\n\nThe Pro Rata is given by:\n  (no. working days to work / no. of working days) x contractual entitlement.\n\nTo get number of working days to work, we need the contract start and end\ndates. This information is stored by a HRJobDetails entity, so a helper method\nwas created to retrieve the JobDetails of the calculation's contract.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/af4b835551adb812a8ef10b3f587b9c2ac59591a"},{"sha":"a2521c32bf4bd5497bc88d72dba3d2949ec1f2d6","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add the EntitlementCalculation.getProposedEntitlement method\n\nThis is a quite simple method that returns the Proposed Entitlement calculated\nfor a contract and absence type for the given absence period.\n\nThe Proposed Entitlement is basically the calculated ProRata + No. Days BroughtForward","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/a2521c32bf4bd5497bc88d72dba3d2949ec1f2d6"},{"sha":"3b46aac08945e455a63dcf8b0e3959a688cac444","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Minor refactoring and adding helpers methods to EntitlementCalculation\n\nPart of the getPreviousPeriodProposedEntitlement was extracted to the\ngetPreviousPeriodEntitlement, which is returns the Entitlement instance.\n\nAlso, getPreviousPeriodProposedEntitlement is now public, so that it can\nbe used to help populate the Entitlement Calculation page in the future.\nThe getNumberOfLeavesTakenOnThePreviousPeriod was also made public\nfor the same reason.\n\nStill thinking about the date that will be needed for the  Entitlement Calculation\npage, a new helper method was added: getNumberOfDaysRemainingInThePreviousPeriod\n\nFinally, getJobLeaveForAbsenceType and getContractDetails were made\nprivate, as this is how they should have been from start.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/3b46aac08945e455a63dcf8b0e3959a688cac444"},{"sha":"89e2ef08fb34e1ba29f061541f51b597950b81af","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Add the brought_forward_expiration_date to the Entitlement BAO\n\nWith this change we also moved the calculation of the number of days remaining in a\nentitlement to the Entitlement BAO. Among other things, this calculation uses the\nbrought_forward_expiration_date to determine if remaning brought forward days\nshould be included in the total of remaining days.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/89e2ef08fb34e1ba29f061541f51b597950b81af"},{"sha":"71f9f84bce101a7908772de8e96b51bf567f5a47","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1060: Small refactoring to improve readability\n\nOn EntitlementCalculation:\nA few new methods were extracted to improve the code readability.\n\nAlso, the return from some expensive methods is now cached to avoid repeated\nAPI and database queries.\n\nOn AbsencePeriod BAO:\nRemoved an unnecessary if in getExpirationDurationDate()","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/71f9f84bce101a7908772de8e96b51bf567f5a47"},{"sha":"1381994454436f2f4aa6706f413984c07ac93fac","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"Merge pull request #978 from civicrm/PCHR-1060-create-entitlementcalculation-class\n\nPCHR-1060: Create the EntitlementCalculation class","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/1381994454436f2f4aa6706f413984c07ac93fac"},{"sha":"7e899e9a132b8523150992be9633af5cabbca739","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1039: Add the getActiveContracts to the HRJobContract BAO\n\nThis method returns all the active contracts between a startDate and\nan endDate. If no dates are given, the current date will be used instead.\n\nThe hierarchy of JobContract class and its related entities is a little bit\ncomplicated and without this method, one would have to take care of a\nlot of things like checking the latest contract revision and looking for date\non the jobdetails entity.\n\nA new API action was added as well. It has the same name and basically\njust relay the job to the BAO method.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/7e899e9a132b8523150992be9633af5cabbca739"},{"sha":"dfce5dd9763069cee9e271d923d92b76d21bd8a1","author":{"name":"Davi Alexandre","email":"f8f463b53b7d0b868331a3657177852ecbc0d89c@davialexandre.com.br"},"message":"PCHR-1039: Fix the hrjobcontract ext installation for the EntitlementCalculationTest\n\nThe hrjobcontract has a lot of upgrade functions, but the install() method from CiviEnvBuilder\nis not capable of running them automatically. Because of that, if the test relies on a table or\nfield that is created during the upgrade, it will fail. To solve this, we instantiate the\nextension's upgrader and call it's install method.\n\nThe upgrade function upgrade_1015 was missing on the Upgrader.upgradeBundle method,\nso it was added in order to get the extension properly upgraded.","distinct":false,"url":"https://api.github.com/repos/civicrm/civihr/commits/dfce5dd9763069cee9e271d923d92b76d21bd8a1"}]}
{"actor":{"display_login":"danilo-compucorp"}}