{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5481","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5481/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5481/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5481/events","html_url":"https://github.com/cockroachdb/cockroach/pull/5481","id":142765693,"number":5481,"title":"acceptance: adding repair test","user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars.githubusercontent.com/u/1614265?v=3","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-22T20:11:47Z","updated_at":"2016-03-23T17:28:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/5481","html_url":"https://github.com/cockroachdb/cockroach/pull/5481","diff_url":"https://github.com/cockroachdb/cockroach/pull/5481.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/5481.patch"},"body":"This commit adds a dynamic client which is designed to handle clusters with\r\nchanging shapes. So it is adaptable to adding and removing nodes.\r\n\r\nAlso, this includes the first isolated load. This is the first of many loads\r\nthat we will be able to apply to tests in a more generic way. This load is\r\ndesigned to be a non-contentious one that just inserts into a table and checks\r\nthat the values in the table are still correct.\r\n\r\nThe repair test so far is only an insert test. I will be following this up with\r\nchanges to cluster to handle adding and permanently removing nodes.\r\n\r\nThis is part of #5345.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/5481)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/200453454","html_url":"https://github.com/cockroachdb/cockroach/pull/5481#issuecomment-200453454","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/5481","id":200453454,"user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars.githubusercontent.com/u/1614265?v=3","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T17:28:08Z","updated_at":"2016-03-23T17:28:08Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.\n\n---\n\n*[acceptance/dynamic_client.go, line 102 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/5481#-KDV1z5ISUf8uEJC5yl1:-KDZVdizSMwp2loEPXLJ:-1192106222) ([raw file](https://github.com/cockroachdb/cockroach/blob/def4e1f32a8c857fb19fd8f395526fc9767718b6/acceptance/dynamic_client.go#L102)):*\nIn what way is it terser?  It's the same code, mine is just spaced a little differently.\nAlso, yes, I am fully aware the this list is going to change.  I thought it might diverge, which is why I was thinking of having two copies.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/5481)*\n<!-- Sent from Reviewable.io -->\n"}}