{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/1869","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/1869/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1869/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/1869/events","html_url":"https://github.com/openssl/openssl/pull/1869","id":187731849,"number":1869,"title":"TLSv1.3: Don't check the record version","user":{"login":"mattcaswell","id":7422273,"avatar_url":"https://avatars.githubusercontent.com/u/7422273?v=3","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-11-07T14:54:08Z","updated_at":"2016-11-07T23:38:15Z","closed_at":"2016-11-07T15:55:00Z","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1869","html_url":"https://github.com/openssl/openssl/pull/1869","diff_url":"https://github.com/openssl/openssl/pull/1869.diff","patch_url":"https://github.com/openssl/openssl/pull/1869.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nContributors guide: https://github.com/openssl/openssl/blob/master/CONTRIBUTING\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [x] tests are added or updated\r\n\r\n##### Description of change\r\n<!-- Provide a description of the changes.\r\n\r\nIf it fixes a github issue, add Fixes #XXXX.\r\n-->\r\nThe record layer version field must be ignored in TLSv1.3, so we remove the check when using that version."},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/258999165","html_url":"https://github.com/openssl/openssl/pull/1869#issuecomment-258999165","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1869","id":258999165,"user":{"login":"kaduk","id":1894506,"avatar_url":"https://avatars.githubusercontent.com/u/1894506?v=3","gravatar_id":"","url":"https://api.github.com/users/kaduk","html_url":"https://github.com/kaduk","followers_url":"https://api.github.com/users/kaduk/followers","following_url":"https://api.github.com/users/kaduk/following{/other_user}","gists_url":"https://api.github.com/users/kaduk/gists{/gist_id}","starred_url":"https://api.github.com/users/kaduk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaduk/subscriptions","organizations_url":"https://api.github.com/users/kaduk/orgs","repos_url":"https://api.github.com/users/kaduk/repos","events_url":"https://api.github.com/users/kaduk/events{/privacy}","received_events_url":"https://api.github.com/users/kaduk/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T23:38:15Z","updated_at":"2016-11-07T23:38:15Z","body":"Assuming that I found the right spot (tls_open_record()), Boring seems to just check the first octet.\r\nNSS (tls13_UnprotectRecord()) seems to check both octets."}}
{"actor":{"display_login":"kaduk"}}