{"action":"closed","number":155,"pull_request":{"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/155","id":81914792,"html_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/155","diff_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/155.diff","patch_url":"https://github.com/apple/swift-corelibs-libdispatch/pull/155.patch","issue_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/155","number":155,"state":"closed","locked":false,"title":"Fix building on armv7","user":{"login":"hpux735","id":1170900,"avatar_url":"https://avatars.githubusercontent.com/u/1170900?v=3","gravatar_id":"","url":"https://api.github.com/users/hpux735","html_url":"https://github.com/hpux735","followers_url":"https://api.github.com/users/hpux735/followers","following_url":"https://api.github.com/users/hpux735/following{/other_user}","gists_url":"https://api.github.com/users/hpux735/gists{/gist_id}","starred_url":"https://api.github.com/users/hpux735/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpux735/subscriptions","organizations_url":"https://api.github.com/users/hpux735/orgs","repos_url":"https://api.github.com/users/hpux735/repos","events_url":"https://api.github.com/users/hpux735/events{/privacy}","received_events_url":"https://api.github.com/users/hpux735/received_events","type":"User","site_admin":false},"body":"This patch enables compilation from build-script on armv7.  I don't expect this patch to be without controversy; rather I'd like this to be the opening point for some discussion about the specific implementation.\r\n\r\nIn particular, I'd like to draw attention to this PR at foundation: https://github.com/apple/swift-corelibs-foundation/pull/399/files which addresses val_list in the same way as presented here.\r\n\r\nFurthermore, PAGE_SIZE is, for some reason, undefined on ARM.  The definition provided here is an assumption, and kind of a hack.  I'd happy to receive some guidance whether there is a better way to move forward.\r\n\r\nThanks!","created_at":"2016-08-19T01:39:32Z","updated_at":"2016-08-27T07:01:13Z","closed_at":"2016-08-27T07:01:13Z","merged_at":"2016-08-27T07:01:13Z","merge_commit_sha":"7fe8323838b0491691e515a7f826ffe508668856","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/155/commits","review_comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/155/comments","review_comment_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/155/comments","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/b81c4c2668552433f931c65b352034ff4b0bfd99","head":{"label":"hpux735:hpux735/arm","ref":"hpux735/arm","sha":"b81c4c2668552433f931c65b352034ff4b0bfd99","user":{"login":"hpux735","id":1170900,"avatar_url":"https://avatars.githubusercontent.com/u/1170900?v=3","gravatar_id":"","url":"https://api.github.com/users/hpux735","html_url":"https://github.com/hpux735","followers_url":"https://api.github.com/users/hpux735/followers","following_url":"https://api.github.com/users/hpux735/following{/other_user}","gists_url":"https://api.github.com/users/hpux735/gists{/gist_id}","starred_url":"https://api.github.com/users/hpux735/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpux735/subscriptions","organizations_url":"https://api.github.com/users/hpux735/orgs","repos_url":"https://api.github.com/users/hpux735/repos","events_url":"https://api.github.com/users/hpux735/events{/privacy}","received_events_url":"https://api.github.com/users/hpux735/received_events","type":"User","site_admin":false},"repo":{"id":52128101,"name":"swift-corelibs-libdispatch","full_name":"hpux735/swift-corelibs-libdispatch","owner":{"login":"hpux735","id":1170900,"avatar_url":"https://avatars.githubusercontent.com/u/1170900?v=3","gravatar_id":"","url":"https://api.github.com/users/hpux735","html_url":"https://github.com/hpux735","followers_url":"https://api.github.com/users/hpux735/followers","following_url":"https://api.github.com/users/hpux735/following{/other_user}","gists_url":"https://api.github.com/users/hpux735/gists{/gist_id}","starred_url":"https://api.github.com/users/hpux735/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpux735/subscriptions","organizations_url":"https://api.github.com/users/hpux735/orgs","repos_url":"https://api.github.com/users/hpux735/repos","events_url":"https://api.github.com/users/hpux735/events{/privacy}","received_events_url":"https://api.github.com/users/hpux735/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hpux735/swift-corelibs-libdispatch","description":"The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware","fork":true,"url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch","forks_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/forks","keys_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/teams","hooks_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/hooks","issue_events_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/issues/events{/number}","events_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/events","assignees_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/assignees{/user}","branches_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/branches{/branch}","tags_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/tags","blobs_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/languages","stargazers_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/stargazers","contributors_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/contributors","subscribers_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/subscribers","subscription_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/subscription","commits_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/contents/{+path}","compare_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/merges","archive_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/downloads","issues_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/issues{/number}","pulls_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/labels{/name}","releases_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/releases{/id}","deployments_url":"https://api.github.com/repos/hpux735/swift-corelibs-libdispatch/deployments","created_at":"2016-02-20T00:35:40Z","updated_at":"2016-02-20T00:35:41Z","pushed_at":"2016-08-25T19:25:46Z","git_url":"git://github.com/hpux735/swift-corelibs-libdispatch.git","ssh_url":"git@github.com:hpux735/swift-corelibs-libdispatch.git","clone_url":"https://github.com/hpux735/swift-corelibs-libdispatch.git","svn_url":"https://github.com/hpux735/swift-corelibs-libdispatch","homepage":"swift.org","size":1318,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"e9057356ac4a59a13e715fd2381c2588d716d0c4","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":45863965,"name":"swift-corelibs-libdispatch","full_name":"apple/swift-corelibs-libdispatch","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-corelibs-libdispatch","description":"The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware","fork":false,"url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch","forks_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/forks","keys_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/teams","hooks_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/events","assignees_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/tags","blobs_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/languages","stargazers_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/subscription","commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/merges","archive_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/downloads","issues_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/deployments","created_at":"2015-11-09T20:13:55Z","updated_at":"2016-08-25T10:59:05Z","pushed_at":"2016-08-27T07:01:13Z","git_url":"git://github.com/apple/swift-corelibs-libdispatch.git","ssh_url":"git@github.com:apple/swift-corelibs-libdispatch.git","clone_url":"https://github.com/apple/swift-corelibs-libdispatch.git","svn_url":"https://github.com/apple/swift-corelibs-libdispatch","homepage":"swift.org","size":1629,"stargazers_count":762,"watchers_count":762,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":4,"forks":126,"open_issues":4,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/155"},"html":{"href":"https://github.com/apple/swift-corelibs-libdispatch/pull/155"},"issue":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/155"},"comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-corelibs-libdispatch/statuses/b81c4c2668552433f931c65b352034ff4b0bfd99"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MadCoder","id":44708,"avatar_url":"https://avatars.githubusercontent.com/u/44708?v=3","gravatar_id":"","url":"https://api.github.com/users/MadCoder","html_url":"https://github.com/MadCoder","followers_url":"https://api.github.com/users/MadCoder/followers","following_url":"https://api.github.com/users/MadCoder/following{/other_user}","gists_url":"https://api.github.com/users/MadCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/MadCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MadCoder/subscriptions","organizations_url":"https://api.github.com/users/MadCoder/orgs","repos_url":"https://api.github.com/users/MadCoder/repos","events_url":"https://api.github.com/users/MadCoder/events{/privacy}","received_events_url":"https://api.github.com/users/MadCoder/received_events","type":"User","site_admin":false},"comments":0,"review_comments":15,"commits":1,"additions":12,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"MadCoder"}}