{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments/81191759","pull_request_review_id":2190000,"id":81191759,"diff_hunk":"@@ -84,6 +85,32 @@ suite('Analyzer', () => {\n           ['MyNamespace.SubBehavior', 'MyNamespace.SimpleBehavior']);\n     });\n \n+    // TODO(fks) 09-28-2016: Fix off-by-one error in warning sourceRange line\n+    // numbers.\n+    test('throws when cant find behavior', async() => {\n+      try {\n+        await analyzer.analyze('static/html-missing-behaviors.html');\n+      } catch (err) {\n+        assert.instanceOf(err, WarningCarryingException);\n+        const warning: Warning = err.warning;\n+        assert.equal(\n+            err.message,\n+            'Unable to resolve behavior `Polymer.ExpectedMissingBehavior`. ' +\n+                'Did you import it? Is it annotated with @polymerBehavior?');\n+        assert.deepEqual(warning.sourceRange, {\n+          file: 'static/html-missing-behaviors.html',\n+          start: {\n+            line: 23,  // Actual Expected: 24","path":"src/test/analyzer_test.ts","position":27,"original_position":27,"commit_id":"7cd0dd38f534db7d7f0913e7b7f6b680698fea0f","original_commit_id":"7cd0dd38f534db7d7f0913e7b7f6b680698fea0f","user":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"body":"what does this `// Actual Expected: 24` comment mean?","created_at":"2016-09-29T17:36:14Z","updated_at":"2016-09-29T17:38:06Z","html_url":"https://github.com/Polymer/polymer-analyzer/pull/331#discussion_r81191759","pull_request_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments/81191759"},"html":{"href":"https://github.com/Polymer/polymer-analyzer/pull/331#discussion_r81191759"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331","id":87323891,"html_url":"https://github.com/Polymer/polymer-analyzer/pull/331","diff_url":"https://github.com/Polymer/polymer-analyzer/pull/331.diff","patch_url":"https://github.com/Polymer/polymer-analyzer/pull/331.patch","issue_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/331","number":331,"state":"closed","locked":false,"title":"\"behavior not found\" errors are now WarningCarryingExceptions","user":{"login":"FredKSchott","id":622227,"avatar_url":"https://avatars.githubusercontent.com/u/622227?v=3","gravatar_id":"","url":"https://api.github.com/users/FredKSchott","html_url":"https://github.com/FredKSchott","followers_url":"https://api.github.com/users/FredKSchott/followers","following_url":"https://api.github.com/users/FredKSchott/following{/other_user}","gists_url":"https://api.github.com/users/FredKSchott/gists{/gist_id}","starred_url":"https://api.github.com/users/FredKSchott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FredKSchott/subscriptions","organizations_url":"https://api.github.com/users/FredKSchott/orgs","repos_url":"https://api.github.com/users/FredKSchott/repos","events_url":"https://api.github.com/users/FredKSchott/events{/privacy}","received_events_url":"https://api.github.com/users/FredKSchott/received_events","type":"User","site_admin":false},"body":"This shouldn't conflict with #330 but an additional PR will be needed so that we can push this warning onto the document itself, instead of throwing a `WarningCarryingException`.\r\n\r\n/cc @rictic @justinfagnani \r\n\r\n","created_at":"2016-09-29T14:26:46Z","updated_at":"2016-09-29T17:38:06Z","closed_at":"2016-09-29T17:36:27Z","merged_at":"2016-09-29T17:36:27Z","merge_commit_sha":"e0c27eaa31d2c85caa2c10d5fa376e7052ebca87","assignee":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"assignees":[{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/331/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/7cd0dd38f534db7d7f0913e7b7f6b680698fea0f","head":{"label":"Polymer:behavior-not-found-warning","ref":"behavior-not-found-warning","sha":"7cd0dd38f534db7d7f0913e7b7f6b680698fea0f","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":30035812,"name":"polymer-analyzer","full_name":"Polymer/polymer-analyzer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-analyzer","description":"A utility for analyzing polymer elements.","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-analyzer","forks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-analyzer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-analyzer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-analyzer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-analyzer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/deployments","created_at":"2015-01-29T18:56:38Z","updated_at":"2016-09-26T17:46:35Z","pushed_at":"2016-09-29T17:36:30Z","git_url":"git://github.com/Polymer/polymer-analyzer.git","ssh_url":"git@github.com:Polymer/polymer-analyzer.git","clone_url":"https://github.com/Polymer/polymer-analyzer.git","svn_url":"https://github.com/Polymer/polymer-analyzer","homepage":"","size":30080,"stargazers_count":89,"watchers_count":89,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":33,"forks":38,"open_issues":33,"watchers":89,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"69deffc18a8be4ab5a7e95f2b50f7d69307ba7c8","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":30035812,"name":"polymer-analyzer","full_name":"Polymer/polymer-analyzer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-analyzer","description":"A utility for analyzing polymer elements.","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-analyzer","forks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-analyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-analyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-analyzer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-analyzer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-analyzer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-analyzer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-analyzer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-analyzer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-analyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-analyzer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-analyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-analyzer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-analyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-analyzer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-analyzer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-analyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-analyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-analyzer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-analyzer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-analyzer/deployments","created_at":"2015-01-29T18:56:38Z","updated_at":"2016-09-26T17:46:35Z","pushed_at":"2016-09-29T17:36:30Z","git_url":"git://github.com/Polymer/polymer-analyzer.git","ssh_url":"git@github.com:Polymer/polymer-analyzer.git","clone_url":"https://github.com/Polymer/polymer-analyzer.git","svn_url":"https://github.com/Polymer/polymer-analyzer","homepage":"","size":30080,"stargazers_count":89,"watchers_count":89,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":38,"mirror_url":null,"open_issues_count":33,"forks":38,"open_issues":33,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331"},"html":{"href":"https://github.com/Polymer/polymer-analyzer/pull/331"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/331"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer-analyzer/statuses/7cd0dd38f534db7d7f0913e7b7f6b680698fea0f"}}}}
{"actor":{"display_login":"justinfagnani"}}