{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18943","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18943/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18943/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18943/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18943","id":184635761,"number":18943,"title":"[RDY] Make ranged attacks use a zero-centered dispersion distribution.","user":{"login":"mutability","id":3055062,"avatar_url":"https://avatars.githubusercontent.com/u/3055062?v=3","gravatar_id":"","url":"https://api.github.com/users/mutability","html_url":"https://github.com/mutability","followers_url":"https://api.github.com/users/mutability/followers","following_url":"https://api.github.com/users/mutability/following{/other_user}","gists_url":"https://api.github.com/users/mutability/gists{/gist_id}","starred_url":"https://api.github.com/users/mutability/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mutability/subscriptions","organizations_url":"https://api.github.com/users/mutability/orgs","repos_url":"https://api.github.com/users/mutability/repos","events_url":"https://api.github.com/users/mutability/events{/privacy}","received_events_url":"https://api.github.com/users/mutability/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"assignees":[{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2016-10-22T15:15:20Z","updated_at":"2016-10-28T13:24:52Z","closed_at":"2016-10-27T19:01:11Z","pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/18943","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18943","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18943.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18943.patch"},"body":"See #18905 for some background.\r\n\r\n * The dispersion arg to Creature::projectile_attack is now a\r\n   measure of the possible dispersion for any shot (i.e. based\r\n   on gun / shooter characteristics with no per shot randomness).\r\n   Change callers to pass a fixed dispersion and not do a random\r\n   roll there.\r\n\r\n   NB: some callers (mdefense::acidsplash) did not use a random\r\n   roll already.\r\n\r\n * The per-shot dispersion is calculated within projectile_attack,\r\n   normally distributed around zero with a standard deviation based\r\n   on the dispersion passed in. Currently scaled so the passed\r\n   dispersion is 2.4 standard deviations, which gives a curve roughly\r\n   similar to the old code.\r\n\r\n * To get a cone of misses that \"looks right\" while still maintaining\r\n   the right sort of hit balance, add an extra parameter controlling how\r\n   close the shot needs to be to actually hit, rather than having \"hit\r\n   the right tile\" be sufficient. Currently needs to be within 0.5 tiles\r\n   (old code was effectively within 1.0 tiles)\r\n\r\n * Don't re-roll \"unintended hits\" on the target square if the trajectory\r\n   happens to pass through it, we already computed it once and a miss\r\n   is a miss."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/256919243","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/18943#issuecomment-256919243","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/18943","id":256919243,"user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T13:24:52Z","updated_at":"2016-10-28T13:24:52Z","body":"The problem is largely based upon moving the randomness into `projectile_attack`.\r\n\r\nThe graphs are generated using the output from the stats dumper so `dump.cpp` would be the logical starting point. The graph script itself is found at `tools/graphs/aiming.r`. Example invocations can be found in the original series of PR's that started the changes on aiming."}}
{"actor":{"display_login":"mugling"}}