{"action":"closed","number":3664,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3664","id":87791218,"html_url":"https://github.com/videojs/video.js/pull/3664","diff_url":"https://github.com/videojs/video.js/pull/3664.diff","patch_url":"https://github.com/videojs/video.js/pull/3664.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3664","number":3664,"state":"closed","locked":false,"title":"feat: add a safe getComputedStyle to videojs.","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"## Description\n\nThis is used internally in the seek bar and mouse time display.\nIn firefox, in an iframe that is hidden with \"display: none\",\ngetComputedStyle() returns \"null\" which can break things.\nSee https://bugzilla.mozilla.org/show_bug.cgi?id=548397 for more\ndetails.\n## Specific Changes proposed\n- add a `getComputedStyle` util\n- expose `videojs.getComputedStyle`\n- use the util in mouse time display and seek bar\n","created_at":"2016-10-03T21:02:04Z","updated_at":"2016-11-03T19:59:34Z","closed_at":"2016-11-03T19:59:34Z","merged_at":"2016-11-03T19:59:34Z","merge_commit_sha":"9702618c0238461ec4a7444f52618fc0c29ae4bb","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/videojs/video.js/milestones/13","html_url":"https://github.com/videojs/video.js/milestones/5.13","labels_url":"https://api.github.com/repos/videojs/video.js/milestones/13/labels","id":2033063,"number":13,"title":"5.13","description":"","creator":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":7,"state":"open","created_at":"2016-09-27T19:56:16Z","updated_at":"2016-11-03T19:59:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/3664/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/3664/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3664/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/0d15f4b39c31d77fda09a45b4acf925596db867e","head":{"label":"gkatsev:safe-get-computed-style","ref":"safe-get-computed-style","sha":"0d15f4b39c31d77fda09a45b4acf925596db867e","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"repo":{"id":5810290,"name":"video.js","full_name":"gkatsev/video.js","owner":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkatsev/video.js","description":"Universal video embed.","fork":true,"url":"https://api.github.com/repos/gkatsev/video.js","forks_url":"https://api.github.com/repos/gkatsev/video.js/forks","keys_url":"https://api.github.com/repos/gkatsev/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkatsev/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkatsev/video.js/teams","hooks_url":"https://api.github.com/repos/gkatsev/video.js/hooks","issue_events_url":"https://api.github.com/repos/gkatsev/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/gkatsev/video.js/events","assignees_url":"https://api.github.com/repos/gkatsev/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/gkatsev/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/gkatsev/video.js/tags","blobs_url":"https://api.github.com/repos/gkatsev/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkatsev/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkatsev/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkatsev/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkatsev/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/gkatsev/video.js/languages","stargazers_url":"https://api.github.com/repos/gkatsev/video.js/stargazers","contributors_url":"https://api.github.com/repos/gkatsev/video.js/contributors","subscribers_url":"https://api.github.com/repos/gkatsev/video.js/subscribers","subscription_url":"https://api.github.com/repos/gkatsev/video.js/subscription","commits_url":"https://api.github.com/repos/gkatsev/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkatsev/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkatsev/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkatsev/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkatsev/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/gkatsev/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkatsev/video.js/merges","archive_url":"https://api.github.com/repos/gkatsev/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkatsev/video.js/downloads","issues_url":"https://api.github.com/repos/gkatsev/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/gkatsev/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/gkatsev/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/gkatsev/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkatsev/video.js/labels{/name}","releases_url":"https://api.github.com/repos/gkatsev/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/gkatsev/video.js/deployments","created_at":"2012-09-14T14:23:52Z","updated_at":"2015-05-01T22:22:54Z","pushed_at":"2016-11-03T19:53:41Z","git_url":"git://github.com/gkatsev/video.js.git","ssh_url":"git@github.com:gkatsev/video.js.git","clone_url":"https://github.com/gkatsev/video.js.git","svn_url":"https://github.com/gkatsev/video.js","homepage":"videojs.com","size":91651,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"920c54a65cf614618bdf91aa0c57ca9f27ffac7f","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","deployments_url":"https://api.github.com/repos/videojs/video.js/deployments","created_at":"2010-05-14T18:45:10Z","updated_at":"2016-11-03T19:57:03Z","pushed_at":"2016-11-03T19:59:34Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":114523,"stargazers_count":14084,"watchers_count":14084,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":4082,"mirror_url":null,"open_issues_count":218,"forks":4082,"open_issues":218,"watchers":14084,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3664"},"html":{"href":"https://github.com/videojs/video.js/pull/3664"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/3664"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/3664/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3664/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/3664/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/0d15f4b39c31d77fda09a45b4acf925596db867e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"comments":0,"review_comments":7,"commits":2,"additions":49,"deletions":7,"changed_files":4}}
{"actor":{"display_login":"gkatsev"}}