{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/49491269","id":49491269,"diff_hunk":"@@ -70,6 +70,8 @@ func NewAllocator(lcDs, glDs datastore.DataStore) (*Allocator, error) {\n \t\t}\n \t}\n \n+\ta.checkConsistency(localAddressSpace)","path":"ipam/allocator.go","position":4,"original_position":4,"commit_id":"6c3bc59fe09963d9ce490487adf13b6f2b26bbe0","original_commit_id":"6c3bc59fe09963d9ce490487adf13b6f2b26bbe0","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"body":"It needs more thinking. In a  mutlihost scenario, the consistency check operation has to be done only once.\r\nIf every host does it, then a a daemon booted later on a second host may destroy addresses allocated in the meanwhile by the daemon on the first host. Also at the moment I do not know how to handle the case where one host runs 1.9.1 and another host runs 1.10.","created_at":"2016-01-12T18:15:14Z","updated_at":"2016-01-12T18:15:14Z","html_url":"https://github.com/docker/libnetwork/pull/866#discussion_r49491269","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/866","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/49491269"},"html":{"href":"https://github.com/docker/libnetwork/pull/866#discussion_r49491269"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/866"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/866","id":55689358,"html_url":"https://github.com/docker/libnetwork/pull/866","diff_url":"https://github.com/docker/libnetwork/pull/866.diff","patch_url":"https://github.com/docker/libnetwork/pull/866.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/866","number":866,"state":"open","locked":false,"title":"IPAM to migrate from old bitmask to new one","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"body":"- In docker 1.9.0 and 1.9.1 versions, because of a bug in bitseq package (https://github.com/docker/libnetwork/pull/771) some IP address reservation/release patterns may corrupt the ip address database and cause several issues (containers with same IP among others).\r\nThe only way to recover is to restart the daemon after deleting the local kv store file. Besides the disruptive workaround, still the issues may happen again, depending of the new reservation/release patterns.\r\n\r\n- This change will allow docker engine to self repair the IP database without need for the user to play with the `/var/lib/docker/network/files/local-kv.db` file.\r\n\r\n- Following debug logs from upgrading docker 1.9.1 to latest with this change:\r\n\r\nDEBU[0000] Detected corrupted bitmask: App: ipam/default/data, ID: LocalDefault/172.17.0.0/16, DBIndex: 0x7, bits: 65536, unselected: 65533, sequence: (0xc0000000, 1)->(0x0, 2046)->(0x1, 1)->(0x0, 0)->end. Fixing it. \r\nDEBU[0000] Detected corrupted bitmask: App: ipam/default/data, ID: LocalDefault/172.20.0.0/16, DBIndex: 0x4, bits: 65536, unselected: 65533, sequence: (0xc0000000, 1)->(0x0, 2046)->(0x1, 1)->(0x0, 0)->end. Fixing it. \r\nDEBU[0000] ReleasePool(LocalDefault/172.17.0.0/16)\r\nDEBU[0000] RequestPool(LocalDefault, 172.17.0.0/16, , map[], false)\r\nDEBU[0000] ReleasePool(LocalDefault/172.20.0.0/16)\r\nDEBU[0000] RequestPool(LocalDefault, 172.20.0.0/16, , map[], false)\r\nDEBU[0000] Registering ipam driver: \"default\"\r\n","created_at":"2016-01-11T22:42:39Z","updated_at":"2016-01-12T18:15:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fe53bb5cf1bab9c4a51e5cf3c6780df6074f93a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/866/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/866/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/866/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/6c3bc59fe09963d9ce490487adf13b6f2b26bbe0","head":{"label":"aboch:bsf","ref":"bsf","sha":"6c3bc59fe09963d9ce490487adf13b6f2b26bbe0","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"repo":{"id":34007834,"name":"libnetwork_new","full_name":"aboch/libnetwork_new","owner":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aboch/libnetwork_new","description":"networking for containers","fork":true,"url":"https://api.github.com/repos/aboch/libnetwork_new","forks_url":"https://api.github.com/repos/aboch/libnetwork_new/forks","keys_url":"https://api.github.com/repos/aboch/libnetwork_new/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aboch/libnetwork_new/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aboch/libnetwork_new/teams","hooks_url":"https://api.github.com/repos/aboch/libnetwork_new/hooks","issue_events_url":"https://api.github.com/repos/aboch/libnetwork_new/issues/events{/number}","events_url":"https://api.github.com/repos/aboch/libnetwork_new/events","assignees_url":"https://api.github.com/repos/aboch/libnetwork_new/assignees{/user}","branches_url":"https://api.github.com/repos/aboch/libnetwork_new/branches{/branch}","tags_url":"https://api.github.com/repos/aboch/libnetwork_new/tags","blobs_url":"https://api.github.com/repos/aboch/libnetwork_new/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aboch/libnetwork_new/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aboch/libnetwork_new/git/refs{/sha}","trees_url":"https://api.github.com/repos/aboch/libnetwork_new/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aboch/libnetwork_new/statuses/{sha}","languages_url":"https://api.github.com/repos/aboch/libnetwork_new/languages","stargazers_url":"https://api.github.com/repos/aboch/libnetwork_new/stargazers","contributors_url":"https://api.github.com/repos/aboch/libnetwork_new/contributors","subscribers_url":"https://api.github.com/repos/aboch/libnetwork_new/subscribers","subscription_url":"https://api.github.com/repos/aboch/libnetwork_new/subscription","commits_url":"https://api.github.com/repos/aboch/libnetwork_new/commits{/sha}","git_commits_url":"https://api.github.com/repos/aboch/libnetwork_new/git/commits{/sha}","comments_url":"https://api.github.com/repos/aboch/libnetwork_new/comments{/number}","issue_comment_url":"https://api.github.com/repos/aboch/libnetwork_new/issues/comments{/number}","contents_url":"https://api.github.com/repos/aboch/libnetwork_new/contents/{+path}","compare_url":"https://api.github.com/repos/aboch/libnetwork_new/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aboch/libnetwork_new/merges","archive_url":"https://api.github.com/repos/aboch/libnetwork_new/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aboch/libnetwork_new/downloads","issues_url":"https://api.github.com/repos/aboch/libnetwork_new/issues{/number}","pulls_url":"https://api.github.com/repos/aboch/libnetwork_new/pulls{/number}","milestones_url":"https://api.github.com/repos/aboch/libnetwork_new/milestones{/number}","notifications_url":"https://api.github.com/repos/aboch/libnetwork_new/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aboch/libnetwork_new/labels{/name}","releases_url":"https://api.github.com/repos/aboch/libnetwork_new/releases{/id}","created_at":"2015-04-15T17:16:09Z","updated_at":"2015-05-03T07:22:06Z","pushed_at":"2016-01-11T22:54:22Z","git_url":"git://github.com/aboch/libnetwork_new.git","ssh_url":"git@github.com:aboch/libnetwork_new.git","clone_url":"https://github.com/aboch/libnetwork_new.git","svn_url":"https://github.com/aboch/libnetwork_new","homepage":"","size":7053,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"e44d9080b3c81d2304032fc6b9d581b0d600c6e2","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"Docker Networking","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","created_at":"2015-02-20T01:20:15Z","updated_at":"2016-01-12T06:54:59Z","pushed_at":"2016-01-12T09:40:38Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":10761,"stargazers_count":566,"watchers_count":566,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"open_issues_count":138,"forks":245,"open_issues":138,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/866"},"html":{"href":"https://github.com/docker/libnetwork/pull/866"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/866"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/866/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/866/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/866/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/6c3bc59fe09963d9ce490487adf13b6f2b26bbe0"}}}}