{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/68656642","id":68656642,"diff_hunk":"@@ -11601,13 +11641,14 @@ GenTreePtr          Compiler::gtNewTempAssign(unsigned tmp, GenTreePtr val)\n     // struct types. But we don't have a convenient way to do that for all SIMD temps.\n \n     CORINFO_CLASS_HANDLE structHnd = gtGetStructHandleIfPresent(val);\n-    if (varTypeIsStruct(valTyp) && (structHnd != NO_CLASS_HANDLE))\n+    if (varTypeIsStruct(valTyp) && ((structHnd != NO_CLASS_HANDLE) || (varTypeIsSIMD(valTyp))))","path":"src/jit/gentree.cpp","position":142,"original_position":142,"commit_id":"1b35c0a24c08657dfa0c1217f362eec794c0286b","original_commit_id":"1b35c0a24c08657dfa0c1217f362eec794c0286b","user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"body":"Here too a comment would be useful that we permit simd type nodes with structHdn = null.","created_at":"2016-06-27T21:08:11Z","updated_at":"2016-06-27T21:08:11Z","html_url":"https://github.com/dotnet/coreclr/pull/6017#discussion_r68656642","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6017","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/68656642"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6017#discussion_r68656642"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6017"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6017","id":75371379,"html_url":"https://github.com/dotnet/coreclr/pull/6017","diff_url":"https://github.com/dotnet/coreclr/pull/6017.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6017.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6017","number":6017,"state":"open","locked":false,"title":"Fix three SIMD-related bugs.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"The first two bugs involve SIMD nodes that are created by the JIT\r\nfor intermediate SIMD operations. These interediate operations\r\nare not directly represented in metadata) and may therefore use\r\nSIMD types that are not present in metadata. For example, metadata\r\nmay only use Vector<T>, but the IR may represent some intermediate\r\noperations using the natural vector type for the target machine.\r\nIn these cases, the JIT will not be able to derive a type handle\r\nfor the SIMD type, which was causing a couple of issues:\r\n- `gtNewTempAssign` was generating a `GT_ASG` node instead of a\r\n  `GT_COPYBLK` when given trees involving these operations and\r\n  types\r\n- `gtGetStructHandleIfPresent` was returning an invalid type handle\r\n  when dealing with SIMD-typed `GT_IND` nodes\r\n\r\nThe fix for the former is to check for SIMD-typed trees in\r\n`gtNewTempAssign` and `gtNewCpObjNode`; the fix for the latter is\r\nto check for SIMD-typed trees before checking for the array index\r\nflag on a `GT_IND` in `gtGetStructHandleIfPresent`.\r\n\r\nThe third bug is that `gtNewTempAssign` was not setting the\r\n`lvSIMDType` flag on local vars after changing their type to a SIMD\r\ntype.","created_at":"2016-06-27T20:07:00Z","updated_at":"2016-06-27T21:08:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ba99b3561fd8d3ff5321569d89a6b33c8541aab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6017/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6017/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6017/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/1b35c0a24c08657dfa0c1217f362eec794c0286b","head":{"label":"pgavlin:SIMDBugFixes","ref":"SIMDBugFixes","sha":"1b35c0a24c08657dfa0c1217f362eec794c0286b","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"repo":{"id":30321049,"name":"coreclr","full_name":"pgavlin/coreclr","owner":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgavlin/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/pgavlin/coreclr","forks_url":"https://api.github.com/repos/pgavlin/coreclr/forks","keys_url":"https://api.github.com/repos/pgavlin/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgavlin/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgavlin/coreclr/teams","hooks_url":"https://api.github.com/repos/pgavlin/coreclr/hooks","issue_events_url":"https://api.github.com/repos/pgavlin/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/pgavlin/coreclr/events","assignees_url":"https://api.github.com/repos/pgavlin/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/pgavlin/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/pgavlin/coreclr/tags","blobs_url":"https://api.github.com/repos/pgavlin/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgavlin/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgavlin/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgavlin/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgavlin/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/pgavlin/coreclr/languages","stargazers_url":"https://api.github.com/repos/pgavlin/coreclr/stargazers","contributors_url":"https://api.github.com/repos/pgavlin/coreclr/contributors","subscribers_url":"https://api.github.com/repos/pgavlin/coreclr/subscribers","subscription_url":"https://api.github.com/repos/pgavlin/coreclr/subscription","commits_url":"https://api.github.com/repos/pgavlin/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgavlin/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgavlin/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgavlin/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgavlin/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/pgavlin/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgavlin/coreclr/merges","archive_url":"https://api.github.com/repos/pgavlin/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgavlin/coreclr/downloads","issues_url":"https://api.github.com/repos/pgavlin/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/pgavlin/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/pgavlin/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/pgavlin/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgavlin/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/pgavlin/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/pgavlin/coreclr/deployments","created_at":"2015-02-04T21:04:39Z","updated_at":"2016-02-26T17:14:54Z","pushed_at":"2016-06-27T20:24:55Z","git_url":"git://github.com/pgavlin/coreclr.git","ssh_url":"git@github.com:pgavlin/coreclr.git","clone_url":"https://github.com/pgavlin/coreclr.git","svn_url":"https://github.com/pgavlin/coreclr","homepage":"","size":88530,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7081a2b5ecab517d5e9cbe49267682c520468404","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-06-27T20:31:02Z","pushed_at":"2016-06-27T20:24:56Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://dotnet.github.io/","size":96449,"stargazers_count":6553,"watchers_count":6553,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1509,"mirror_url":null,"open_issues_count":835,"forks":1509,"open_issues":835,"watchers":6553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6017"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6017"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6017"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6017/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6017/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6017/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/1b35c0a24c08657dfa0c1217f362eec794c0286b"}}}}
{"actor":{"display_login":"sivarv"}}