{"action":"opened","number":15635,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15635","id":83045055,"html_url":"https://github.com/cms-sw/cmssw/pull/15635","diff_url":"https://github.com/cms-sw/cmssw/pull/15635.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15635.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15635","number":15635,"state":"open","locked":false,"title":"Use unique_ptr, not auto_ptr in RecoLocalTracker","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"body":"In preparation for removing framework support for deprecated auto_ptr arguments in put() calls, this pull request replaces the use of auto_ptr with unique_ptr in RecoLocalTracker packages. Also, std::make_unique is used when appropriate. Also, there were a few cases where a reference to an auto_ptr was an input argument to a function, which is a bad practice because it obscures the possible transfer of ownership. In the cases here, ownership was not transferred, so the object itself was passed by reference.","created_at":"2016-08-29T05:04:43Z","updated_at":"2016-08-29T05:04:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15635/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15635/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15635/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/479acbb7101e32c1921c9e90c48045edaca00284","head":{"label":"wmtan:UseUniquePtrInRecoLocalTracker","ref":"UseUniquePtrInRecoLocalTracker","sha":"479acbb7101e32c1921c9e90c48045edaca00284","user":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"repo":{"id":10977262,"name":"cmssw","full_name":"wmtan/cmssw","owner":{"login":"wmtan","id":4268350,"avatar_url":"https://avatars.githubusercontent.com/u/4268350?v=3","gravatar_id":"","url":"https://api.github.com/users/wmtan","html_url":"https://github.com/wmtan","followers_url":"https://api.github.com/users/wmtan/followers","following_url":"https://api.github.com/users/wmtan/following{/other_user}","gists_url":"https://api.github.com/users/wmtan/gists{/gist_id}","starred_url":"https://api.github.com/users/wmtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmtan/subscriptions","organizations_url":"https://api.github.com/users/wmtan/orgs","repos_url":"https://api.github.com/users/wmtan/repos","events_url":"https://api.github.com/users/wmtan/events{/privacy}","received_events_url":"https://api.github.com/users/wmtan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmtan/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/wmtan/cmssw","forks_url":"https://api.github.com/repos/wmtan/cmssw/forks","keys_url":"https://api.github.com/repos/wmtan/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmtan/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmtan/cmssw/teams","hooks_url":"https://api.github.com/repos/wmtan/cmssw/hooks","issue_events_url":"https://api.github.com/repos/wmtan/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/wmtan/cmssw/events","assignees_url":"https://api.github.com/repos/wmtan/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/wmtan/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/wmtan/cmssw/tags","blobs_url":"https://api.github.com/repos/wmtan/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmtan/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmtan/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmtan/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmtan/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/wmtan/cmssw/languages","stargazers_url":"https://api.github.com/repos/wmtan/cmssw/stargazers","contributors_url":"https://api.github.com/repos/wmtan/cmssw/contributors","subscribers_url":"https://api.github.com/repos/wmtan/cmssw/subscribers","subscription_url":"https://api.github.com/repos/wmtan/cmssw/subscription","commits_url":"https://api.github.com/repos/wmtan/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmtan/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmtan/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmtan/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmtan/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/wmtan/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmtan/cmssw/merges","archive_url":"https://api.github.com/repos/wmtan/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmtan/cmssw/downloads","issues_url":"https://api.github.com/repos/wmtan/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/wmtan/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/wmtan/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/wmtan/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmtan/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/wmtan/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/wmtan/cmssw/deployments","created_at":"2013-06-26T19:44:14Z","updated_at":"2014-06-24T22:32:58Z","pushed_at":"2016-08-29T04:57:43Z","git_url":"git://github.com/wmtan/cmssw.git","ssh_url":"git@github.com:wmtan/cmssw.git","clone_url":"https://github.com/wmtan/cmssw.git","svn_url":"https://github.com/wmtan/cmssw","homepage":null,"size":770260,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"20a5e53654cfcd0185f03c3b332951e528ffc8a5","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-08-26T14:12:00Z","pushed_at":"2016-08-29T03:05:11Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1103235,"stargazers_count":337,"watchers_count":337,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1960,"mirror_url":null,"open_issues_count":357,"forks":1960,"open_issues":357,"watchers":337,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15635"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15635"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15635"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15635/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15635/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15635/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/479acbb7101e32c1921c9e90c48045edaca00284"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":122,"deletions":158,"changed_files":30}}
{"actor":{"display_login":"wmtan"}}