{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/52509423","id":52509423,"diff_hunk":"@@ -184,7 +185,7 @@ protected function sortReplacements(array $replace)\n      * Get a translation according to an integer value.\n      *\n      * @param  string  $key\n-     * @param  int     $number","path":"src/Illuminate/Translation/Translator.php","position":12,"original_position":12,"commit_id":"f34e34234ac791f96d68a17b83c04081d4c6f16b","original_commit_id":"f34e34234ac791f96d68a17b83c04081d4c6f16b","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"You need to update the contract too.","created_at":"2016-02-10T19:20:47Z","updated_at":"2016-02-10T19:20:47Z","html_url":"https://github.com/laravel/framework/pull/12237#discussion_r52509423","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/12237","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/52509423"},"html":{"href":"https://github.com/laravel/framework/pull/12237#discussion_r52509423"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/12237"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/12237","id":58926839,"html_url":"https://github.com/laravel/framework/pull/12237","diff_url":"https://github.com/laravel/framework/pull/12237.diff","patch_url":"https://github.com/laravel/framework/pull/12237.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/12237","number":12237,"state":"open","locked":false,"title":"[5.2] Make trans_choice receive arrays and countable objects","user":{"login":"mlanin","id":467159,"avatar_url":"https://avatars.githubusercontent.com/u/467159?v=3","gravatar_id":"","url":"https://api.github.com/users/mlanin","html_url":"https://github.com/mlanin","followers_url":"https://api.github.com/users/mlanin/followers","following_url":"https://api.github.com/users/mlanin/following{/other_user}","gists_url":"https://api.github.com/users/mlanin/gists{/gist_id}","starred_url":"https://api.github.com/users/mlanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlanin/subscriptions","organizations_url":"https://api.github.com/users/mlanin/orgs","repos_url":"https://api.github.com/users/mlanin/repos","events_url":"https://api.github.com/users/mlanin/events{/privacy}","received_events_url":"https://api.github.com/users/mlanin/received_events","type":"User","site_admin":false},"body":"`trans_choice` function or `Translator::transChoice` method can receive only integers to make a proper translation selection. But when you are using this functions, most of the time you are using them with collections and arrays, so you have to always surround your variables with count() like this:\r\n\r\n`{{ trans_choice('pages', count($pages)) }}`\r\n\r\nThis PR helps this functions to receive arrays and `Countable` objects too and they will count elements for you.","created_at":"2016-02-10T17:46:32Z","updated_at":"2016-02-10T19:20:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c6600fdc16ea6637aecb0f8dd9444e9df18a13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/12237/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/12237/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/12237/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/f34e34234ac791f96d68a17b83c04081d4c6f16b","head":{"label":"mlanin-forks:5.2","ref":"5.2","sha":"f34e34234ac791f96d68a17b83c04081d4c6f16b","user":{"login":"mlanin-forks","id":16178925,"avatar_url":"https://avatars.githubusercontent.com/u/16178925?v=3","gravatar_id":"","url":"https://api.github.com/users/mlanin-forks","html_url":"https://github.com/mlanin-forks","followers_url":"https://api.github.com/users/mlanin-forks/followers","following_url":"https://api.github.com/users/mlanin-forks/following{/other_user}","gists_url":"https://api.github.com/users/mlanin-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/mlanin-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlanin-forks/subscriptions","organizations_url":"https://api.github.com/users/mlanin-forks/orgs","repos_url":"https://api.github.com/users/mlanin-forks/repos","events_url":"https://api.github.com/users/mlanin-forks/events{/privacy}","received_events_url":"https://api.github.com/users/mlanin-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":51456087,"name":"framework","full_name":"mlanin-forks/framework","owner":{"login":"mlanin-forks","id":16178925,"avatar_url":"https://avatars.githubusercontent.com/u/16178925?v=3","gravatar_id":"","url":"https://api.github.com/users/mlanin-forks","html_url":"https://github.com/mlanin-forks","followers_url":"https://api.github.com/users/mlanin-forks/followers","following_url":"https://api.github.com/users/mlanin-forks/following{/other_user}","gists_url":"https://api.github.com/users/mlanin-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/mlanin-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlanin-forks/subscriptions","organizations_url":"https://api.github.com/users/mlanin-forks/orgs","repos_url":"https://api.github.com/users/mlanin-forks/repos","events_url":"https://api.github.com/users/mlanin-forks/events{/privacy}","received_events_url":"https://api.github.com/users/mlanin-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlanin-forks/framework","description":"","fork":true,"url":"https://api.github.com/repos/mlanin-forks/framework","forks_url":"https://api.github.com/repos/mlanin-forks/framework/forks","keys_url":"https://api.github.com/repos/mlanin-forks/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlanin-forks/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlanin-forks/framework/teams","hooks_url":"https://api.github.com/repos/mlanin-forks/framework/hooks","issue_events_url":"https://api.github.com/repos/mlanin-forks/framework/issues/events{/number}","events_url":"https://api.github.com/repos/mlanin-forks/framework/events","assignees_url":"https://api.github.com/repos/mlanin-forks/framework/assignees{/user}","branches_url":"https://api.github.com/repos/mlanin-forks/framework/branches{/branch}","tags_url":"https://api.github.com/repos/mlanin-forks/framework/tags","blobs_url":"https://api.github.com/repos/mlanin-forks/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlanin-forks/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlanin-forks/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlanin-forks/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlanin-forks/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/mlanin-forks/framework/languages","stargazers_url":"https://api.github.com/repos/mlanin-forks/framework/stargazers","contributors_url":"https://api.github.com/repos/mlanin-forks/framework/contributors","subscribers_url":"https://api.github.com/repos/mlanin-forks/framework/subscribers","subscription_url":"https://api.github.com/repos/mlanin-forks/framework/subscription","commits_url":"https://api.github.com/repos/mlanin-forks/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlanin-forks/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlanin-forks/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlanin-forks/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlanin-forks/framework/contents/{+path}","compare_url":"https://api.github.com/repos/mlanin-forks/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlanin-forks/framework/merges","archive_url":"https://api.github.com/repos/mlanin-forks/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlanin-forks/framework/downloads","issues_url":"https://api.github.com/repos/mlanin-forks/framework/issues{/number}","pulls_url":"https://api.github.com/repos/mlanin-forks/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/mlanin-forks/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/mlanin-forks/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlanin-forks/framework/labels{/name}","releases_url":"https://api.github.com/repos/mlanin-forks/framework/releases{/id}","deployments_url":"https://api.github.com/repos/mlanin-forks/framework/deployments","created_at":"2016-02-10T17:01:21Z","updated_at":"2016-02-10T17:01:26Z","pushed_at":"2016-02-10T17:35:43Z","git_url":"git://github.com/mlanin-forks/framework.git","ssh_url":"git@github.com:mlanin-forks/framework.git","clone_url":"https://github.com/mlanin-forks/framework.git","svn_url":"https://github.com/mlanin-forks/framework","homepage":"http://laravel.com","size":21078,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"laravel:5.2","ref":"5.2","sha":"5e201839c70086a80989595c0d9034dff34caf0f","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2016-02-10T17:50:25Z","pushed_at":"2016-02-10T19:05:25Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":34238,"stargazers_count":4750,"watchers_count":4750,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2771,"mirror_url":null,"open_issues_count":108,"forks":2771,"open_issues":108,"watchers":4750,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/12237"},"html":{"href":"https://github.com/laravel/framework/pull/12237"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/12237"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/12237/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/12237/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/12237/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/f34e34234ac791f96d68a17b83c04081d4c6f16b"}}}}