{"action":"created","issue":{"url":"https://api.github.com/repos/NYULibraries/ichabod/issues/233","repository_url":"https://api.github.com/repos/NYULibraries/ichabod","labels_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/233/comments","events_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/233/events","html_url":"https://github.com/NYULibraries/ichabod/pull/233","id":160451306,"number":233,"title":"Feature/jv fda rest reader","user":{"login":"sgbalogh","id":10469527,"avatar_url":"https://avatars.githubusercontent.com/u/10469527?v=3","gravatar_id":"","url":"https://api.github.com/users/sgbalogh","html_url":"https://github.com/sgbalogh","followers_url":"https://api.github.com/users/sgbalogh/followers","following_url":"https://api.github.com/users/sgbalogh/following{/other_user}","gists_url":"https://api.github.com/users/sgbalogh/gists{/gist_id}","starred_url":"https://api.github.com/users/sgbalogh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgbalogh/subscriptions","organizations_url":"https://api.github.com/users/sgbalogh/orgs","repos_url":"https://api.github.com/users/sgbalogh/repos","events_url":"https://api.github.com/users/sgbalogh/events{/privacy}","received_events_url":"https://api.github.com/users/sgbalogh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":90,"created_at":"2016-06-15T15:26:31Z","updated_at":"2016-08-12T20:59:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NYULibraries/ichabod/pulls/233","html_url":"https://github.com/NYULibraries/ichabod/pull/233","diff_url":"https://github.com/NYULibraries/ichabod/pull/233.diff","patch_url":"https://github.com/NYULibraries/ichabod/pull/233.patch"},"body":"This branch still has work to be done (most significantly, it's lacking tests), but wanted to make a PR just to get some initial comments.\r\n\r\nI created a [resource set](https://github.com/NYULibraries/ichabod/blob/feature/jv_fda_rest_reader/app/resource_sets/vinopal_fda_collection.rb) for JV's FDA collection, which uses a new [FDA source reader](https://github.com/NYULibraries/ichabod/blob/feature/jv_fda_rest_reader/lib/ichabod/resource_set/source_readers/fda_collection_rest_reader.rb) that I also added, which connects to the FDA via the new DSpace REST API. My hope is that the source reader is generic enough to be used for a variety of FDA collections. In fact, the only unique information that the JV resource set provides to the reader is the corresponding FDA collection ID.\r\n\r\nHere are some questions I have:\r\n- If we would want to use the source reader for a variety of FDA collections, are there other considerations that might make it more versatile? For instance, a way for a resource set specification to provide its own arbitrary mapping of FDA fields into NYUCore?\r\n- I'm using the ruby Rest-Client gem to handle HTTP connections; should I be using something else, or is that ok? I just noticed that the NYU Press source reader uses Faraday.\r\n- A comment: When constructing parameters for the HTTP connections made, I had to set `:verify_ssl => false`, simply because my machines kept complaining about SSL certificate trust issues whenever that was not the case. Has anyone else run into this problem? I need to research it a bit more (and see if it has to do with my OpenSSL or if it has to do with archive.nyu.edu) –– but I acknowledge that we will definitely want to verify ssl when this is actually being used.\r\n\r\nI also realized that I don't understand the concept of `editor` being used in Hydra. I'm assuming this has something to do with user access levels?\r\n\r\nAny comments would be very much appreciated! This has been a really good experiment for me to learn a bit about how Hydra works, but I have a lot more to learn..."},"comment":{"url":"https://api.github.com/repos/NYULibraries/ichabod/issues/comments/239558420","html_url":"https://github.com/NYULibraries/ichabod/pull/233#issuecomment-239558420","issue_url":"https://api.github.com/repos/NYULibraries/ichabod/issues/233","id":239558420,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T20:59:54Z","updated_at":"2016-08-12T20:59:54Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7429998/badge)](https://coveralls.io/builds/7429998)\n\nCoverage decreased (-0.02%) to 99.225% when pulling **9d5bf20c688333ee08b2a132f17e75f57fdb9bc2 on feature/jv_fda_rest_reader** into **fd17f491b6790b087d3ab1acf1a5b013d74abf22 on development**.\n"}}
{"actor":{"display_login":"coveralls"}}