{"action":"created","issue":{"url":"https://api.github.com/repos/sclorg/postgresql-container/issues/122","repository_url":"https://api.github.com/repos/sclorg/postgresql-container","labels_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/122/comments","events_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/122/events","html_url":"https://github.com/sclorg/postgresql-container/pull/122","id":161273288,"number":122,"title":"Add enable/disable replication option.","user":{"login":"dtschan","id":482784,"avatar_url":"https://avatars.githubusercontent.com/u/482784?v=3","gravatar_id":"","url":"https://api.github.com/users/dtschan","html_url":"https://github.com/dtschan","followers_url":"https://api.github.com/users/dtschan/followers","following_url":"https://api.github.com/users/dtschan/following{/other_user}","gists_url":"https://api.github.com/users/dtschan/gists{/gist_id}","starred_url":"https://api.github.com/users/dtschan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtschan/subscriptions","organizations_url":"https://api.github.com/users/dtschan/orgs","repos_url":"https://api.github.com/users/dtschan/repos","events_url":"https://api.github.com/users/dtschan/events{/privacy}","received_events_url":"https://api.github.com/users/dtschan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hhorak","id":1405588,"avatar_url":"https://avatars.githubusercontent.com/u/1405588?v=3","gravatar_id":"","url":"https://api.github.com/users/hhorak","html_url":"https://github.com/hhorak","followers_url":"https://api.github.com/users/hhorak/followers","following_url":"https://api.github.com/users/hhorak/following{/other_user}","gists_url":"https://api.github.com/users/hhorak/gists{/gist_id}","starred_url":"https://api.github.com/users/hhorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhorak/subscriptions","organizations_url":"https://api.github.com/users/hhorak/orgs","repos_url":"https://api.github.com/users/hhorak/repos","events_url":"https://api.github.com/users/hhorak/events{/privacy}","received_events_url":"https://api.github.com/users/hhorak/received_events","type":"User","site_admin":false},"assignees":[{"login":"hhorak","id":1405588,"avatar_url":"https://avatars.githubusercontent.com/u/1405588?v=3","gravatar_id":"","url":"https://api.github.com/users/hhorak","html_url":"https://github.com/hhorak","followers_url":"https://api.github.com/users/hhorak/followers","following_url":"https://api.github.com/users/hhorak/following{/other_user}","gists_url":"https://api.github.com/users/hhorak/gists{/gist_id}","starred_url":"https://api.github.com/users/hhorak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhorak/subscriptions","organizations_url":"https://api.github.com/users/hhorak/orgs","repos_url":"https://api.github.com/users/hhorak/repos","events_url":"https://api.github.com/users/hhorak/events{/privacy}","received_events_url":"https://api.github.com/users/hhorak/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2016-06-20T19:22:01Z","updated_at":"2016-09-20T19:19:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/122","html_url":"https://github.com/sclorg/postgresql-container/pull/122","diff_url":"https://github.com/sclorg/postgresql-container/pull/122.diff","patch_url":"https://github.com/sclorg/postgresql-container/pull/122.patch"},"body":"This pull request adds an option to enable or disable replication while keeping the current default configuration. Rationale:\r\nThe OpenShift Enterprise 3.2 postgresql-persistent templates use images built from this repository and persistent volumes with a default size between 0.5 to 1 GiB. However `openshift-custom-postgresql.conf.template` configures a WAL size of 6.25 GiB (400 segments of 16 MiB) for replication purposes which means that most users PostgreSQL containers will fail after some time with an out of disk error. Not all users have larger persistent volumes available so increasing the default persistent volume is not always be an option. On the other hand not all users and use cases require replication."},"comment":{"url":"https://api.github.com/repos/sclorg/postgresql-container/issues/comments/248404252","html_url":"https://github.com/sclorg/postgresql-container/pull/122#issuecomment-248404252","issue_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/122","id":248404252,"user":{"login":"dtschan","id":482784,"avatar_url":"https://avatars.githubusercontent.com/u/482784?v=3","gravatar_id":"","url":"https://api.github.com/users/dtschan","html_url":"https://github.com/dtschan","followers_url":"https://api.github.com/users/dtschan/followers","following_url":"https://api.github.com/users/dtschan/following{/other_user}","gists_url":"https://api.github.com/users/dtschan/gists{/gist_id}","starred_url":"https://api.github.com/users/dtschan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtschan/subscriptions","organizations_url":"https://api.github.com/users/dtschan/orgs","repos_url":"https://api.github.com/users/dtschan/repos","events_url":"https://api.github.com/users/dtschan/events{/privacy}","received_events_url":"https://api.github.com/users/dtschan/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T19:19:52Z","updated_at":"2016-09-20T19:19:52Z","body":"Updated pull request to current state of discussion, particulary comments https://github.com/sclorg/postgresql-container/pull/122#issuecomment-227340527\r\n\r\n>  OK, master shares configuration with default non-replicating server, which is probably not the right thing. There are 'run-postgresql', 'run-postgresql-master' and 'run-postgresql-slave' candidates for CMD, we shouldn't have another option to turn the replication on/off.\r\n\r\n and https://github.com/sclorg/postgresql-container/pull/122#issuecomment-227344919\r\n\r\n> yeah, there is a symlink, because it seemed like master server will be the same as non-replication server. Since we see it is no longer truth, we shouldn't use the symlink and have a separate CMDs for both use cases.\r\n\r\n`run-postgresql` now no longer has replication enabled, while `run-postgresql-master` and `run-postgresql-slave` still have. Please review again.\r\n"}}
{"actor":{"display_login":"dtschan"}}