{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/13817","labels_url":"https://api.github.com/repos/golang/go/issues/13817/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/13817/comments","events_url":"https://api.github.com/repos/golang/go/issues/13817/events","html_url":"https://github.com/golang/go/issues/13817","id":124830529,"number":13817,"title":"runtime/pprof: testCPUProfile hides real issues","user":{"login":"aclements","id":2688315,"avatar_url":"https://avatars.githubusercontent.com/u/2688315?v=3","gravatar_id":"","url":"https://api.github.com/users/aclements","html_url":"https://github.com/aclements","followers_url":"https://api.github.com/users/aclements/followers","following_url":"https://api.github.com/users/aclements/following{/other_user}","gists_url":"https://api.github.com/users/aclements/gists{/gist_id}","starred_url":"https://api.github.com/users/aclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aclements/subscriptions","organizations_url":"https://api.github.com/users/aclements/orgs","repos_url":"https://api.github.com/users/aclements/repos","events_url":"https://api.github.com/users/aclements/events{/privacy}","received_events_url":"https://api.github.com/users/aclements/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"aclements","id":2688315,"avatar_url":"https://avatars.githubusercontent.com/u/2688315?v=3","gravatar_id":"","url":"https://api.github.com/users/aclements","html_url":"https://github.com/aclements","followers_url":"https://api.github.com/users/aclements/followers","following_url":"https://api.github.com/users/aclements/following{/other_user}","gists_url":"https://api.github.com/users/aclements/gists{/gist_id}","starred_url":"https://api.github.com/users/aclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aclements/subscriptions","organizations_url":"https://api.github.com/users/aclements/orgs","repos_url":"https://api.github.com/users/aclements/repos","events_url":"https://api.github.com/users/aclements/events{/privacy}","received_events_url":"https://api.github.com/users/aclements/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/32","html_url":"https://github.com/golang/go/milestones/Go1.7Early","labels_url":"https://api.github.com/repos/golang/go/milestones/32/labels","id":1414136,"number":32,"title":"Go1.7Early","description":"","creator":{"login":"bradfitz","id":2621,"avatar_url":"https://avatars.githubusercontent.com/u/2621?v=3","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":0,"state":"open","created_at":"2015-11-16T16:57:54Z","updated_at":"2016-01-21T21:12:55Z","due_on":"2016-05-01T07:00:00Z","closed_at":null},"comments":1,"created_at":"2016-01-04T20:19:04Z","updated_at":"2016-01-21T21:15:34Z","closed_at":null,"body":"In response to #7095, we made the profiling tests pass if they get at least one sample. This is masking real issues. For example, on ARM, TestStackBarrierProfiling usually gets fewer than 10 samples, when it should be getting around 500 (discovered in #13405). It would be better if, when this got fewer samples than expected, it simply retried the test a few times. This would keep the test fast under common circumstances while still keeping it robust. (This is technically a repeated fixed-horizon hypothesis test, which technically means it's bad. What we really want is a sequential hypothesis test, but as long as the difference between \"working\" and \"broken\" [effect size] we're looking for is large enough, the simple thing is fine.)\r\n\r\n@randall77 @RLH @dvyukov "},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/173709998","html_url":"https://github.com/golang/go/issues/13817#issuecomment-173709998","issue_url":"https://api.github.com/repos/golang/go/issues/13817","id":173709998,"user":{"login":"aclements","id":2688315,"avatar_url":"https://avatars.githubusercontent.com/u/2688315?v=3","gravatar_id":"","url":"https://api.github.com/users/aclements","html_url":"https://github.com/aclements","followers_url":"https://api.github.com/users/aclements/followers","following_url":"https://api.github.com/users/aclements/following{/other_user}","gists_url":"https://api.github.com/users/aclements/gists{/gist_id}","starred_url":"https://api.github.com/users/aclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aclements/subscriptions","organizations_url":"https://api.github.com/users/aclements/orgs","repos_url":"https://api.github.com/users/aclements/repos","events_url":"https://api.github.com/users/aclements/events{/privacy}","received_events_url":"https://api.github.com/users/aclements/received_events","type":"User","site_admin":false},"created_at":"2016-01-21T21:15:34Z","updated_at":"2016-01-21T21:15:34Z","body":"I'm sure this is going to turn up issues that are best dealt with by keeping an eye on the builders, so I've moved it to 1.7Early. It's also likely there are going to be issues we simply can't fix in the less used platforms because of kernel problems."}}