{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/12330","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12330/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12330/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12330/events","html_url":"https://github.com/joomla/joomla-cms/pull/12330","id":181534653,"number":12330,"title":"[3.6.3] Regression. The wrong editor is loaded","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"},{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/release-blocker","name":"release-blocker","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/16","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.3","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/16/labels","id":1901872,"number":16,"title":"Joomla 3.6.3","description":"","creator":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":336,"state":"open","created_at":"2016-07-25T09:08:01Z","updated_at":"2016-10-06T21:49:30Z","due_on":"2016-10-11T00:00:00Z","closed_at":null},"comments":6,"created_at":"2016-10-06T21:49:29Z","updated_at":"2016-10-06T22:41:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12330","html_url":"https://github.com/joomla/joomla-cms/pull/12330","diff_url":"https://github.com/joomla/joomla-cms/pull/12330.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12330.patch"},"body":"### Summary of Changes\r\n\r\nInit the config value to load the correct editor. \r\n\r\n### Testing Instructions\r\n\r\n- Install 3.6.3-rc2\r\n- set up your default editor (global config) to tinyMCE\r\n- go to your user config\r\n- set the editor to \"codemirror\"\r\n- try to create or edit an article.\r\n- you notice that the tinymce is loaded\r\n- apply this patch\r\n- the codemirror is loaded (as per user setting)\r\n\r\n### Documentation Changes Required\r\n\r\nNone\r\n\r\n### Other things\r\n\r\n@mbabker this reversts part of: #11838 can you take a look here maybe there is a better fix?"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/252108766","html_url":"https://github.com/joomla/joomla-cms/pull/12330#issuecomment-252108766","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12330","id":252108766,"user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T22:41:02Z","updated_at":"2016-10-06T22:41:02Z","body":"Part of the problem is until the line you added back, there are essentially\ntwo different configuration objects in play.  The registry from JFactory\nand the one created by the app.  The line you've added back essentially\nturns the app's registry into a reference to the registry in JFactory so\nthat they both use the same data object.  This invalidates all config\nvalues set in the app constructor (session related stuff, and some things\nthe CMS never really used, but that's really beyond the point here).\n\nSo there are a few possible fixes.  JFactory::getApplication() or\nJApplicationCms::getInstance() could possibly inject in\nJFactory::getConfig() which would force the reference behavior to be set\ncorrectly.  Or the JApplicationCms constructor get the\nJFactory::getConfig() registry to use that as the class' config value if\nnothing else is injected in (but only if nothing is injected otherwise we\nbreak the parameter injection in the constructor).\n\nI doubt many will want to test the fixes, generally any code structure\nchange I suggest or implement gets reverted for some edge case scenario\nthat stops working or ignored because it's too technical for most.  So\naccept reverting to a known buggy state and be done with it, which is what\nthis PR is doing.\n\nOn Thursday, October 6, 2016, zero-24 <notifications@github.com> wrote:\n\n> Yes i have seen this too but i have no idea how to fix it right?\n>\n> If i got it right the cMS does not inject a config before this line?\n> As the getinstance method does not set the constructor settings?\n> https://github.com/joomla/joomla-cms/blob/staging/\n> libraries/cms/application/cms.php#L396\n>\n> Maybe i'm also just on the complete wrong way?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/joomla/joomla-cms/pull/12330#issuecomment-252106646>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAWfoUFhrT6MfiUPQWm2cH9_CTQ7lkKpks5qxXY_gaJpZM4KQdII>\n> .\n>\n"}}
{"actor":{"display_login":"mbabker"}}