{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/72540522","id":72540522,"diff_hunk":"@@ -183,15 +203,13 @@ module Analyser =\n                 assert false\n \n               | (name, _atts, ct) :: [] ->\n-                let pos = ct.Parsetree.ptyp_loc.Location.loc_end.Lexing.pos_cnum in\n-                let s = get_string_of_file pos pos_end in\n-                let (_,comment_opt) =  My_ir.just_after_special !file_name s in\n+                  let pos = Loc.ptyp_end ct in\n+                  let (_,comment_opt) = just_after_special pos pos_end in","path":"ocamldoc/odoc_sig.ml","position":null,"original_position":35,"commit_id":"b7471d5bcb0e88d8ed048d4b68d7a8bea0ab0fb0","original_commit_id":"5667afe418bdfe5d29afec6b6f30a98b311fbb73","user":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars.githubusercontent.com/u/7689388?v=3","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"body":"Good question? Fixed.","created_at":"2016-07-27T23:08:01Z","updated_at":"2016-07-27T23:08:01Z","html_url":"https://github.com/ocaml/ocaml/pull/720#discussion_r72540522","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/720","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/72540522"},"html":{"href":"https://github.com/ocaml/ocaml/pull/720#discussion_r72540522"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/720"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/720","id":78944858,"html_url":"https://github.com/ocaml/ocaml/pull/720","diff_url":"https://github.com/ocaml/ocaml/pull/720.diff","patch_url":"https://github.com/ocaml/ocaml/pull/720.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/720","number":720,"state":"open","locked":false,"title":"MPR#7290: ocamldoc, more support for inline record","user":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars.githubusercontent.com/u/7689388?v=3","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"body":"This pull request improves the support of inline record within ocamldoc:\r\n  * First, all code path should be implemented and using inline record should not\r\nlead anymore to ocamldoc crashes\r\n  * Second, the PR adds a light support for documentation comments within inline record.\r\nHowever, the backend support for these documentation comments could be improved.\r\n\r\nNote that the first commit in this PR is a questionable refactoring commit that I implemented when trying to decrease my perception of the signal to noise ratio in `odoc_sig.ml`, it can be reverted.\r\n\r\n(see also the associated [mantis ticket](http://caml.inria.fr/mantis/view.php?id=7290))","created_at":"2016-07-26T23:49:19Z","updated_at":"2016-07-27T23:08:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"803bade3c697962efead530316fc4951cb51e729","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/720/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/720/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/720/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/b7471d5bcb0e88d8ed048d4b68d7a8bea0ab0fb0","head":{"label":"Octachron:ocamldoc_inline_record_light","ref":"ocamldoc_inline_record_light","sha":"b7471d5bcb0e88d8ed048d4b68d7a8bea0ab0fb0","user":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars.githubusercontent.com/u/7689388?v=3","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"repo":{"id":20154083,"name":"ocaml","full_name":"Octachron/ocaml","owner":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars.githubusercontent.com/u/7689388?v=3","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Octachron/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/Octachron/ocaml","forks_url":"https://api.github.com/repos/Octachron/ocaml/forks","keys_url":"https://api.github.com/repos/Octachron/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Octachron/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Octachron/ocaml/teams","hooks_url":"https://api.github.com/repos/Octachron/ocaml/hooks","issue_events_url":"https://api.github.com/repos/Octachron/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/Octachron/ocaml/events","assignees_url":"https://api.github.com/repos/Octachron/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/Octachron/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/Octachron/ocaml/tags","blobs_url":"https://api.github.com/repos/Octachron/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Octachron/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Octachron/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Octachron/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Octachron/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/Octachron/ocaml/languages","stargazers_url":"https://api.github.com/repos/Octachron/ocaml/stargazers","contributors_url":"https://api.github.com/repos/Octachron/ocaml/contributors","subscribers_url":"https://api.github.com/repos/Octachron/ocaml/subscribers","subscription_url":"https://api.github.com/repos/Octachron/ocaml/subscription","commits_url":"https://api.github.com/repos/Octachron/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Octachron/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Octachron/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Octachron/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Octachron/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/Octachron/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Octachron/ocaml/merges","archive_url":"https://api.github.com/repos/Octachron/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Octachron/ocaml/downloads","issues_url":"https://api.github.com/repos/Octachron/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/Octachron/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/Octachron/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/Octachron/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Octachron/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/Octachron/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/Octachron/ocaml/deployments","created_at":"2014-05-25T12:35:17Z","updated_at":"2016-02-29T20:01:52Z","pushed_at":"2016-07-27T22:55:34Z","git_url":"git://github.com/Octachron/ocaml.git","ssh_url":"git@github.com:Octachron/ocaml.git","clone_url":"https://github.com/Octachron/ocaml.git","svn_url":"https://github.com/Octachron/ocaml","homepage":null,"size":148349,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"38c3db40c7533aece24279317dba28f7ce7d1f5a","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2016-07-27T18:00:24Z","pushed_at":"2016-07-27T22:55:35Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":244626,"stargazers_count":864,"watchers_count":864,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":263,"mirror_url":null,"open_issues_count":116,"forks":263,"open_issues":116,"watchers":864,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/720"},"html":{"href":"https://github.com/ocaml/ocaml/pull/720"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/720"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/720/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/720/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/720/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/b7471d5bcb0e88d8ed048d4b68d7a8bea0ab0fb0"}}}}
{"actor":{"display_login":"Octachron"}}