{"action":"created","comment":{"url":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/comments/93133751","pull_request_review_id":13648397,"id":93133751,"diff_hunk":"@@ -279,14 +294,16 @@ public void Frame_OnChatMessage_SayText2(any data)\n \n \tif (iResults == Plugin_Changed)\n \t{\n-\t\tfor (int i = 0; i < GetArraySize(hRecipients); i++)\n-\t\t{\n-\t\t\tint client = GetArrayCell(hRecipients, i);\n-\n-\t\t\tif (IsClientInGame(client))\n-\t\t\t{\n-\t\t\t\tCSayText2(client, sBuffer, iSender, bChat);\n-\t\t\t}\n+\t\tif(!bProto) {\n+\t\t\tHandle hMsg = StartMessage(\"SayText2\", iRecipients, iNumRecipients, USERMSG_RELIABLE|USERMSG_BLOCKHOOKS);\n+\t\t\t\n+\t\t\tBfWriteByte(hMsg, iSender);\n+\t\t\tBfWriteByte(hMsg, bChat);\n+\t\t\tBfWriteString(hMsg, sBuffer);\n+\t\t\tEndMessage();\n+\t\t\n+\t\t} else {\n+\t\t\tPbSetString(bfMsg, \"msg_name\", sBuffer);","path":"scripting/chat-processor.sp","position":112,"original_position":112,"commit_id":"4e7b14b464f85e74cbaaf2cf7d5617f59b351ce3","original_commit_id":"4e7b14b464f85e74cbaaf2cf7d5617f59b351ce3","user":{"login":"peace-maker","id":1635147,"avatar_url":"https://avatars.githubusercontent.com/u/1635147?v=3","gravatar_id":"","url":"https://api.github.com/users/peace-maker","html_url":"https://github.com/peace-maker","followers_url":"https://api.github.com/users/peace-maker/followers","following_url":"https://api.github.com/users/peace-maker/following{/other_user}","gists_url":"https://api.github.com/users/peace-maker/gists{/gist_id}","starred_url":"https://api.github.com/users/peace-maker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peace-maker/subscriptions","organizations_url":"https://api.github.com/users/peace-maker/orgs","repos_url":"https://api.github.com/users/peace-maker/repos","events_url":"https://api.github.com/users/peace-maker/events{/privacy}","received_events_url":"https://api.github.com/users/peace-maker/received_events","type":"User","site_admin":false},"body":"Did you try copying the value of \"textallchat\" from the original protobuf message when creating your own here?\r\n\r\nMight have to do some observations on the value if some consumer changes sFlag in the forward, so we adjust the value correctly.","created_at":"2016-12-19T22:28:07Z","updated_at":"2016-12-19T22:29:08Z","html_url":"https://github.com/Drixevel/Chat-Processor/pull/6#discussion_r93133751","pull_request_url":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/comments/93133751"},"html":{"href":"https://github.com/Drixevel/Chat-Processor/pull/6#discussion_r93133751"},"pull_request":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6","id":98507670,"html_url":"https://github.com/Drixevel/Chat-Processor/pull/6","diff_url":"https://github.com/Drixevel/Chat-Processor/pull/6.diff","patch_url":"https://github.com/Drixevel/Chat-Processor/pull/6.patch","issue_url":"https://api.github.com/repos/Drixevel/Chat-Processor/issues/6","number":6,"state":"closed","locked":false,"title":"Hopefully fix duplicate issues properly.","user":{"login":"SM91337","id":16342357,"avatar_url":"https://avatars.githubusercontent.com/u/16342357?v=3","gravatar_id":"","url":"https://api.github.com/users/SM91337","html_url":"https://github.com/SM91337","followers_url":"https://api.github.com/users/SM91337/followers","following_url":"https://api.github.com/users/SM91337/following{/other_user}","gists_url":"https://api.github.com/users/SM91337/gists{/gist_id}","starred_url":"https://api.github.com/users/SM91337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SM91337/subscriptions","organizations_url":"https://api.github.com/users/SM91337/orgs","repos_url":"https://api.github.com/users/SM91337/repos","events_url":"https://api.github.com/users/SM91337/events{/privacy}","received_events_url":"https://api.github.com/users/SM91337/received_events","type":"User","site_admin":false},"body":"Remove previous duplicate fix as it breaks chat message being shown to sender.\r\nRewrite Protobuf messages instead of creating a new one.\r\nCreate one usermessage to all recipients instead of multiple for BitBuffer.\r\nCheck recipients array to see if the recipient already exists before we add him.\r\nMake sure sender is always in the recipients array.","created_at":"2016-12-19T05:02:50Z","updated_at":"2016-12-19T22:29:08Z","closed_at":"2016-12-19T17:10:26Z","merged_at":"2016-12-19T17:10:26Z","merge_commit_sha":"1115b4c613ebd845df7d090166825ed98537ad2f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6/commits","review_comments_url":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6/comments","review_comment_url":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Drixevel/Chat-Processor/issues/6/comments","statuses_url":"https://api.github.com/repos/Drixevel/Chat-Processor/statuses/4e7b14b464f85e74cbaaf2cf7d5617f59b351ce3","head":{"label":"SM91337:master","ref":"master","sha":"4e7b14b464f85e74cbaaf2cf7d5617f59b351ce3","user":{"login":"SM91337","id":16342357,"avatar_url":"https://avatars.githubusercontent.com/u/16342357?v=3","gravatar_id":"","url":"https://api.github.com/users/SM91337","html_url":"https://github.com/SM91337","followers_url":"https://api.github.com/users/SM91337/followers","following_url":"https://api.github.com/users/SM91337/following{/other_user}","gists_url":"https://api.github.com/users/SM91337/gists{/gist_id}","starred_url":"https://api.github.com/users/SM91337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SM91337/subscriptions","organizations_url":"https://api.github.com/users/SM91337/orgs","repos_url":"https://api.github.com/users/SM91337/repos","events_url":"https://api.github.com/users/SM91337/events{/privacy}","received_events_url":"https://api.github.com/users/SM91337/received_events","type":"User","site_admin":false},"repo":{"id":76827675,"name":"Chat-Processor","full_name":"SM91337/Chat-Processor","owner":{"login":"SM91337","id":16342357,"avatar_url":"https://avatars.githubusercontent.com/u/16342357?v=3","gravatar_id":"","url":"https://api.github.com/users/SM91337","html_url":"https://github.com/SM91337","followers_url":"https://api.github.com/users/SM91337/followers","following_url":"https://api.github.com/users/SM91337/following{/other_user}","gists_url":"https://api.github.com/users/SM91337/gists{/gist_id}","starred_url":"https://api.github.com/users/SM91337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SM91337/subscriptions","organizations_url":"https://api.github.com/users/SM91337/orgs","repos_url":"https://api.github.com/users/SM91337/repos","events_url":"https://api.github.com/users/SM91337/events{/privacy}","received_events_url":"https://api.github.com/users/SM91337/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SM91337/Chat-Processor","description":"Chat processor for Sourcemod.","fork":true,"url":"https://api.github.com/repos/SM91337/Chat-Processor","forks_url":"https://api.github.com/repos/SM91337/Chat-Processor/forks","keys_url":"https://api.github.com/repos/SM91337/Chat-Processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SM91337/Chat-Processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SM91337/Chat-Processor/teams","hooks_url":"https://api.github.com/repos/SM91337/Chat-Processor/hooks","issue_events_url":"https://api.github.com/repos/SM91337/Chat-Processor/issues/events{/number}","events_url":"https://api.github.com/repos/SM91337/Chat-Processor/events","assignees_url":"https://api.github.com/repos/SM91337/Chat-Processor/assignees{/user}","branches_url":"https://api.github.com/repos/SM91337/Chat-Processor/branches{/branch}","tags_url":"https://api.github.com/repos/SM91337/Chat-Processor/tags","blobs_url":"https://api.github.com/repos/SM91337/Chat-Processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SM91337/Chat-Processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SM91337/Chat-Processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/SM91337/Chat-Processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SM91337/Chat-Processor/statuses/{sha}","languages_url":"https://api.github.com/repos/SM91337/Chat-Processor/languages","stargazers_url":"https://api.github.com/repos/SM91337/Chat-Processor/stargazers","contributors_url":"https://api.github.com/repos/SM91337/Chat-Processor/contributors","subscribers_url":"https://api.github.com/repos/SM91337/Chat-Processor/subscribers","subscription_url":"https://api.github.com/repos/SM91337/Chat-Processor/subscription","commits_url":"https://api.github.com/repos/SM91337/Chat-Processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/SM91337/Chat-Processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/SM91337/Chat-Processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/SM91337/Chat-Processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/SM91337/Chat-Processor/contents/{+path}","compare_url":"https://api.github.com/repos/SM91337/Chat-Processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SM91337/Chat-Processor/merges","archive_url":"https://api.github.com/repos/SM91337/Chat-Processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SM91337/Chat-Processor/downloads","issues_url":"https://api.github.com/repos/SM91337/Chat-Processor/issues{/number}","pulls_url":"https://api.github.com/repos/SM91337/Chat-Processor/pulls{/number}","milestones_url":"https://api.github.com/repos/SM91337/Chat-Processor/milestones{/number}","notifications_url":"https://api.github.com/repos/SM91337/Chat-Processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SM91337/Chat-Processor/labels{/name}","releases_url":"https://api.github.com/repos/SM91337/Chat-Processor/releases{/id}","deployments_url":"https://api.github.com/repos/SM91337/Chat-Processor/deployments","created_at":"2016-12-19T04:20:32Z","updated_at":"2016-12-19T04:20:33Z","pushed_at":"2016-12-19T05:01:31Z","git_url":"git://github.com/SM91337/Chat-Processor.git","ssh_url":"git@github.com:SM91337/Chat-Processor.git","clone_url":"https://github.com/SM91337/Chat-Processor.git","svn_url":"https://github.com/SM91337/Chat-Processor","homepage":null,"size":824,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Drixevel:master","ref":"master","sha":"c8d00d7c503069a3d5b2539877cee927a247cbe8","user":{"login":"Drixevel","id":4638377,"avatar_url":"https://avatars.githubusercontent.com/u/4638377?v=3","gravatar_id":"","url":"https://api.github.com/users/Drixevel","html_url":"https://github.com/Drixevel","followers_url":"https://api.github.com/users/Drixevel/followers","following_url":"https://api.github.com/users/Drixevel/following{/other_user}","gists_url":"https://api.github.com/users/Drixevel/gists{/gist_id}","starred_url":"https://api.github.com/users/Drixevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drixevel/subscriptions","organizations_url":"https://api.github.com/users/Drixevel/orgs","repos_url":"https://api.github.com/users/Drixevel/repos","events_url":"https://api.github.com/users/Drixevel/events{/privacy}","received_events_url":"https://api.github.com/users/Drixevel/received_events","type":"User","site_admin":false},"repo":{"id":66183105,"name":"Chat-Processor","full_name":"Drixevel/Chat-Processor","owner":{"login":"Drixevel","id":4638377,"avatar_url":"https://avatars.githubusercontent.com/u/4638377?v=3","gravatar_id":"","url":"https://api.github.com/users/Drixevel","html_url":"https://github.com/Drixevel","followers_url":"https://api.github.com/users/Drixevel/followers","following_url":"https://api.github.com/users/Drixevel/following{/other_user}","gists_url":"https://api.github.com/users/Drixevel/gists{/gist_id}","starred_url":"https://api.github.com/users/Drixevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drixevel/subscriptions","organizations_url":"https://api.github.com/users/Drixevel/orgs","repos_url":"https://api.github.com/users/Drixevel/repos","events_url":"https://api.github.com/users/Drixevel/events{/privacy}","received_events_url":"https://api.github.com/users/Drixevel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Drixevel/Chat-Processor","description":"Chat processor for Sourcemod.","fork":false,"url":"https://api.github.com/repos/Drixevel/Chat-Processor","forks_url":"https://api.github.com/repos/Drixevel/Chat-Processor/forks","keys_url":"https://api.github.com/repos/Drixevel/Chat-Processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Drixevel/Chat-Processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Drixevel/Chat-Processor/teams","hooks_url":"https://api.github.com/repos/Drixevel/Chat-Processor/hooks","issue_events_url":"https://api.github.com/repos/Drixevel/Chat-Processor/issues/events{/number}","events_url":"https://api.github.com/repos/Drixevel/Chat-Processor/events","assignees_url":"https://api.github.com/repos/Drixevel/Chat-Processor/assignees{/user}","branches_url":"https://api.github.com/repos/Drixevel/Chat-Processor/branches{/branch}","tags_url":"https://api.github.com/repos/Drixevel/Chat-Processor/tags","blobs_url":"https://api.github.com/repos/Drixevel/Chat-Processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Drixevel/Chat-Processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Drixevel/Chat-Processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Drixevel/Chat-Processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Drixevel/Chat-Processor/statuses/{sha}","languages_url":"https://api.github.com/repos/Drixevel/Chat-Processor/languages","stargazers_url":"https://api.github.com/repos/Drixevel/Chat-Processor/stargazers","contributors_url":"https://api.github.com/repos/Drixevel/Chat-Processor/contributors","subscribers_url":"https://api.github.com/repos/Drixevel/Chat-Processor/subscribers","subscription_url":"https://api.github.com/repos/Drixevel/Chat-Processor/subscription","commits_url":"https://api.github.com/repos/Drixevel/Chat-Processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Drixevel/Chat-Processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Drixevel/Chat-Processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Drixevel/Chat-Processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Drixevel/Chat-Processor/contents/{+path}","compare_url":"https://api.github.com/repos/Drixevel/Chat-Processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Drixevel/Chat-Processor/merges","archive_url":"https://api.github.com/repos/Drixevel/Chat-Processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Drixevel/Chat-Processor/downloads","issues_url":"https://api.github.com/repos/Drixevel/Chat-Processor/issues{/number}","pulls_url":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls{/number}","milestones_url":"https://api.github.com/repos/Drixevel/Chat-Processor/milestones{/number}","notifications_url":"https://api.github.com/repos/Drixevel/Chat-Processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Drixevel/Chat-Processor/labels{/name}","releases_url":"https://api.github.com/repos/Drixevel/Chat-Processor/releases{/id}","deployments_url":"https://api.github.com/repos/Drixevel/Chat-Processor/deployments","created_at":"2016-08-21T05:40:41Z","updated_at":"2016-12-15T23:21:27Z","pushed_at":"2016-12-19T17:10:27Z","git_url":"git://github.com/Drixevel/Chat-Processor.git","ssh_url":"git@github.com:Drixevel/Chat-Processor.git","clone_url":"https://github.com/Drixevel/Chat-Processor.git","svn_url":"https://github.com/Drixevel/Chat-Processor","homepage":null,"size":825,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6"},"html":{"href":"https://github.com/Drixevel/Chat-Processor/pull/6"},"issue":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/issues/6"},"comments":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/Drixevel/Chat-Processor/statuses/4e7b14b464f85e74cbaaf2cf7d5617f59b351ce3"}}}}
{"actor":{"display_login":"peace-maker"}}