{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/94255926","pull_request_review_id":14787254,"id":94255926,"diff_hunk":"@@ -33,9 +33,13 @@ function getCurrentFiberOwnerName() : string | null {\n     }\n     switch (fiber.tag) {\n       case IndeterminateComponent:\n-      case FunctionalComponent:\n       case ClassComponent:\n         return getComponentName(fiber);\n+      case FunctionalComponent:","path":"src/renderers/shared/fiber/ReactDebugCurrentFiber.js","position":7,"original_position":7,"commit_id":"21aee2141c987b43ca4445eafd3c2e51a2771f6c","original_commit_id":"21aee2141c987b43ca4445eafd3c2e51a2771f6c","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"Why would you move them together with `HostComponent`? I'm not sure I'm following.","created_at":"2016-12-30T20:25:42Z","updated_at":"2016-12-30T20:25:42Z","html_url":"https://github.com/facebook/react/pull/8635#discussion_r94255926","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/8635","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/94255926"},"html":{"href":"https://github.com/facebook/react/pull/8635#discussion_r94255926"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/8635"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8635","id":99295380,"html_url":"https://github.com/facebook/react/pull/8635","diff_url":"https://github.com/facebook/react/pull/8635.diff","patch_url":"https://github.com/facebook/react/pull/8635.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/8635","number":8635,"state":"open","locked":false,"title":"Fiber: warn for refs on SFCs","user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"body":"While working on the fiber implementation of ReactTestRenderer I came across this warning which is not yet implemented for fiber.\r\n\r\nInitial questions:\r\n\r\n* Are there any areas of the fiber impl where errors and warnings are expected to live? This is the first instance added to BeginWork which I think may indicate this warning should exist elsewhere\r\n* This doesn’t actually stop any ref from being attached. How should that be done?\r\n* A related test seems to show refs throwing an error if used on a top-level SFC. Should that exist in the same area of the code or elsewhere?","created_at":"2016-12-24T04:56:40Z","updated_at":"2016-12-30T20:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2beee0e909113d52ffd736107365624d46f1d17b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/8635/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/8635/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/8635/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/21aee2141c987b43ca4445eafd3c2e51a2771f6c","head":{"label":"iamdustan:statelss-component","ref":"statelss-component","sha":"21aee2141c987b43ca4445eafd3c2e51a2771f6c","user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"repo":{"id":30816284,"name":"react","full_name":"iamdustan/react","owner":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamdustan/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/iamdustan/react","forks_url":"https://api.github.com/repos/iamdustan/react/forks","keys_url":"https://api.github.com/repos/iamdustan/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamdustan/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamdustan/react/teams","hooks_url":"https://api.github.com/repos/iamdustan/react/hooks","issue_events_url":"https://api.github.com/repos/iamdustan/react/issues/events{/number}","events_url":"https://api.github.com/repos/iamdustan/react/events","assignees_url":"https://api.github.com/repos/iamdustan/react/assignees{/user}","branches_url":"https://api.github.com/repos/iamdustan/react/branches{/branch}","tags_url":"https://api.github.com/repos/iamdustan/react/tags","blobs_url":"https://api.github.com/repos/iamdustan/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamdustan/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamdustan/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamdustan/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamdustan/react/statuses/{sha}","languages_url":"https://api.github.com/repos/iamdustan/react/languages","stargazers_url":"https://api.github.com/repos/iamdustan/react/stargazers","contributors_url":"https://api.github.com/repos/iamdustan/react/contributors","subscribers_url":"https://api.github.com/repos/iamdustan/react/subscribers","subscription_url":"https://api.github.com/repos/iamdustan/react/subscription","commits_url":"https://api.github.com/repos/iamdustan/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamdustan/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamdustan/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamdustan/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamdustan/react/contents/{+path}","compare_url":"https://api.github.com/repos/iamdustan/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamdustan/react/merges","archive_url":"https://api.github.com/repos/iamdustan/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamdustan/react/downloads","issues_url":"https://api.github.com/repos/iamdustan/react/issues{/number}","pulls_url":"https://api.github.com/repos/iamdustan/react/pulls{/number}","milestones_url":"https://api.github.com/repos/iamdustan/react/milestones{/number}","notifications_url":"https://api.github.com/repos/iamdustan/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamdustan/react/labels{/name}","releases_url":"https://api.github.com/repos/iamdustan/react/releases{/id}","deployments_url":"https://api.github.com/repos/iamdustan/react/deployments","created_at":"2015-02-15T03:06:11Z","updated_at":"2016-05-20T21:20:27Z","pushed_at":"2016-12-28T16:08:49Z","git_url":"git://github.com/iamdustan/react.git","ssh_url":"git@github.com:iamdustan/react.git","clone_url":"https://github.com/iamdustan/react.git","svn_url":"https://github.com/iamdustan/react","homepage":"http://facebook.github.io/react/","size":80849,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"86765baaef4f5ff5e4f3f2727a016cf7a196a6ee","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-12-30T20:11:17Z","pushed_at":"2016-12-30T19:37:48Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":111495,"stargazers_count":56759,"watchers_count":56759,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10229,"mirror_url":null,"open_issues_count":671,"forks":10229,"open_issues":671,"watchers":56759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/8635"},"html":{"href":"https://github.com/facebook/react/pull/8635"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/8635"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/8635/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/8635/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/8635/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/21aee2141c987b43ca4445eafd3c2e51a2771f6c"}}}}
{"actor":{"display_login":"gaearon"}}