{"action":"created","issue":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/184","repository_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase","labels_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/184/comments","events_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/184/events","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/184","id":183424071,"number":184,"title":"Fix typings, addresses issue #179","user":{"login":"giordy","id":6016950,"avatar_url":"https://avatars.githubusercontent.com/u/6016950?v=3","gravatar_id":"","url":"https://api.github.com/users/giordy","html_url":"https://github.com/giordy","followers_url":"https://api.github.com/users/giordy/followers","following_url":"https://api.github.com/users/giordy/following{/other_user}","gists_url":"https://api.github.com/users/giordy/gists{/gist_id}","starred_url":"https://api.github.com/users/giordy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giordy/subscriptions","organizations_url":"https://api.github.com/users/giordy/orgs","repos_url":"https://api.github.com/users/giordy/repos","events_url":"https://api.github.com/users/giordy/events{/privacy}","received_events_url":"https://api.github.com/users/giordy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-17T13:59:49Z","updated_at":"2016-10-18T18:20:47Z","closed_at":"2016-10-18T17:49:04Z","pull_request":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/pulls/184","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/184","diff_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/184.diff","patch_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/184.patch"},"body":"This PR should fix issue #179 \r\n\r\nI followed the handbook that you can find at: https://www.typescriptlang.org/docs/handbook/declaration-files/introduction.html\r\nMore precisely, this is the template that seems to fit the project's use case: https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-d-ts.html\r\n\r\nI also renamed the typings file from `firebase.d.ts ` to `index.d.ts`, as suggested in the documentation.\r\n\r\nI tested this with TypeScript 1.8 and 2.0 and in both cases the app compiled and loaded correctly and the firebase framework loaded properly (I got the \"firebase.init done\" message from the example in the README).\r\n\r\nI couldn't test more elaborated use cases."},"comment":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/comments/254594367","html_url":"https://github.com/EddyVerbruggen/nativescript-plugin-firebase/pull/184#issuecomment-254594367","issue_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-plugin-firebase/issues/184","id":254594367,"user":{"login":"giordy","id":6016950,"avatar_url":"https://avatars.githubusercontent.com/u/6016950?v=3","gravatar_id":"","url":"https://api.github.com/users/giordy","html_url":"https://github.com/giordy","followers_url":"https://api.github.com/users/giordy/followers","following_url":"https://api.github.com/users/giordy/following{/other_user}","gists_url":"https://api.github.com/users/giordy/gists{/gist_id}","starred_url":"https://api.github.com/users/giordy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giordy/subscriptions","organizations_url":"https://api.github.com/users/giordy/orgs","repos_url":"https://api.github.com/users/giordy/repos","events_url":"https://api.github.com/users/giordy/events{/privacy}","received_events_url":"https://api.github.com/users/giordy/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T18:20:47Z","updated_at":"2016-10-18T18:20:47Z","body":"@EddyVerbruggen ha! didn't notice it ^_^'\r\nIn the tests I didn't change it however it seems like a good idea to update it"}}
{"actor":{"display_login":"giordy"}}