{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3679","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3679/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3679/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3679/events","html_url":"https://github.com/fish-shell/fish-shell/pull/3679","id":197615721,"number":3679,"title":" Append paths from /etc/manpaths and /etc/manpaths.d/* to MANPATH, for #1092","user":{"login":"smammy","id":2546386,"avatar_url":"https://avatars.githubusercontent.com/u/2546386?v=3","gravatar_id":"","url":"https://api.github.com/users/smammy","html_url":"https://github.com/smammy","followers_url":"https://api.github.com/users/smammy/followers","following_url":"https://api.github.com/users/smammy/following{/other_user}","gists_url":"https://api.github.com/users/smammy/gists{/gist_id}","starred_url":"https://api.github.com/users/smammy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smammy/subscriptions","organizations_url":"https://api.github.com/users/smammy/orgs","repos_url":"https://api.github.com/users/smammy/repos","events_url":"https://api.github.com/users/smammy/events{/privacy}","received_events_url":"https://api.github.com/users/smammy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/13","html_url":"https://github.com/fish-shell/fish-shell/milestone/13","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/13/labels","id":1624432,"number":13,"title":"fish 2.5.0","description":"next release in the 2.x series (minor releases)\r\nin general, no backward incompatible changes should be accepted for this release","creator":{"login":"zanchey","id":520741,"avatar_url":"https://avatars.githubusercontent.com/u/520741?v=3","gravatar_id":"","url":"https://api.github.com/users/zanchey","html_url":"https://github.com/zanchey","followers_url":"https://api.github.com/users/zanchey/followers","following_url":"https://api.github.com/users/zanchey/following{/other_user}","gists_url":"https://api.github.com/users/zanchey/gists{/gist_id}","starred_url":"https://api.github.com/users/zanchey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanchey/subscriptions","organizations_url":"https://api.github.com/users/zanchey/orgs","repos_url":"https://api.github.com/users/zanchey/repos","events_url":"https://api.github.com/users/zanchey/events{/privacy}","received_events_url":"https://api.github.com/users/zanchey/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":98,"state":"open","created_at":"2016-03-06T13:32:50Z","updated_at":"2016-12-27T22:17:38Z","due_on":"2017-01-08T08:00:00Z","closed_at":null},"comments":5,"created_at":"2016-12-26T19:53:16Z","updated_at":"2016-12-27T22:21:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3679","html_url":"https://github.com/fish-shell/fish-shell/pull/3679","diff_url":"https://github.com/fish-shell/fish-shell/pull/3679.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/3679.patch"},"body":"* Only append paths if `MANPATH` is already set, to match behavior of macOS `path_helper` utility.\r\n* Use the same technique as is used above to set PATH from /etc/paths and /etc/paths.d/*.\r\n\r\n## Description\r\n\r\n* I updated the patch so that it only modifies `MANPATH` if it is already set, per feedback. Thanks to @ridiculousfish, @floam, and @faho.\r\n* There's clearly some refactoring that could be done between the `/etc/paths` and `/etc/manpaths` code right above it, but I figure that should be a separate change.\r\n\r\nFixes issue #1092\r\n\r\n## TODOs:\r\n<!-- Just check off what what we know been done so far. We can help you with this stuff. -->\r\n- [ ] Changes to fish usage are reflected in user documenation/manpages.\r\n- [ ] Tests have been added for regressions fixed\r\n"},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/269391030","html_url":"https://github.com/fish-shell/fish-shell/pull/3679#issuecomment-269391030","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3679","id":269391030,"user":{"login":"ridiculousfish","id":920838,"avatar_url":"https://avatars.githubusercontent.com/u/920838?v=3","gravatar_id":"","url":"https://api.github.com/users/ridiculousfish","html_url":"https://github.com/ridiculousfish","followers_url":"https://api.github.com/users/ridiculousfish/followers","following_url":"https://api.github.com/users/ridiculousfish/following{/other_user}","gists_url":"https://api.github.com/users/ridiculousfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ridiculousfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridiculousfish/subscriptions","organizations_url":"https://api.github.com/users/ridiculousfish/orgs","repos_url":"https://api.github.com/users/ridiculousfish/repos","events_url":"https://api.github.com/users/ridiculousfish/events{/privacy}","received_events_url":"https://api.github.com/users/ridiculousfish/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T22:21:21Z","updated_at":"2016-12-27T22:21:21Z","body":"> It's probably worth noting that we set MANPATH in the man function. This executes manpath to figure out the path. Does that not use the helper?\r\n\r\nNo, I think `manpath` does not use path_helper.\r\n\r\nfish's `man` function prepends to MANPATH but only for the duration of `man`. The reason is so that fish's builtins get picked up by `man`, but only within fish (if you invoke bash from fish, you don't want fish's man pages to show up within bash)  So what `man` does is still right."}}
{"actor":{"display_login":"ridiculousfish"}}