{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/xcbuild/pulls/comments/67980383","id":67980383,"diff_hunk":"@@ -88,7 +89,7 @@ class Manager {\n     /*\n      * Load from a developer root. Returns nullptr on error.\n      */\n-    static std::shared_ptr<Manager> Open(libutil::Filesystem const *filesystem, std::string const &path);\n+    static std::shared_ptr<Manager> Open(config::Config const *config, libutil::Filesystem const *filesystem, std::string const &path);","path":"Libraries/xcsdk/Headers/xcsdk/SDK/Manager.h","position":13,"original_position":13,"commit_id":"a3258c52c6f3a7e68b4f02fc63cd84861e568e2c","original_commit_id":"a3258c52c6f3a7e68b4f02fc63cd84861e568e2c","user":{"login":"Ktwu","id":470651,"avatar_url":"https://avatars.githubusercontent.com/u/470651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ktwu","html_url":"https://github.com/Ktwu","followers_url":"https://api.github.com/users/Ktwu/followers","following_url":"https://api.github.com/users/Ktwu/following{/other_user}","gists_url":"https://api.github.com/users/Ktwu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ktwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ktwu/subscriptions","organizations_url":"https://api.github.com/users/Ktwu/orgs","repos_url":"https://api.github.com/users/Ktwu/repos","events_url":"https://api.github.com/users/Ktwu/events{/privacy}","received_events_url":"https://api.github.com/users/Ktwu/received_events","type":"User","site_admin":false},"body":"I've been told by an Oculus engineer that general styling is always to use references unless you absolutely need to use a pointer :)","created_at":"2016-06-22T01:11:33Z","updated_at":"2016-06-22T01:11:33Z","html_url":"https://github.com/facebook/xcbuild/pull/69#discussion_r67980383","pull_request_url":"https://api.github.com/repos/facebook/xcbuild/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/comments/67980383"},"html":{"href":"https://github.com/facebook/xcbuild/pull/69#discussion_r67980383"},"pull_request":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/xcbuild/pulls/69","id":74534266,"html_url":"https://github.com/facebook/xcbuild/pull/69","diff_url":"https://github.com/facebook/xcbuild/pull/69.diff","patch_url":"https://github.com/facebook/xcbuild/pull/69.patch","issue_url":"https://api.github.com/repos/facebook/xcbuild/issues/69","number":69,"state":"open","locked":false,"title":"Add ability to for xcbuild to read from a configuration file","user":{"login":"Ktwu","id":470651,"avatar_url":"https://avatars.githubusercontent.com/u/470651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ktwu","html_url":"https://github.com/Ktwu","followers_url":"https://api.github.com/users/Ktwu/followers","following_url":"https://api.github.com/users/Ktwu/following{/other_user}","gists_url":"https://api.github.com/users/Ktwu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ktwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ktwu/subscriptions","organizations_url":"https://api.github.com/users/Ktwu/orgs","repos_url":"https://api.github.com/users/Ktwu/repos","events_url":"https://api.github.com/users/Ktwu/events{/privacy}","received_events_url":"https://api.github.com/users/Ktwu/received_events","type":"User","site_admin":false},"body":"Xcode can be modified to include extra platform paths to find SDKs and extra toolchains using the 'defaults' utility.  xcbuild should have something similar.\r\n\r\nSince xcbuild is cross-platform, I opted to use /var/db/xcbuild_defaults.plist as a configuration file.  In order to read from this file, plutil functionality has been split up and exposed as part of the plist library.\r\n\r\nAccessing the configuration also all managed by the config library.  Right now it only has the ability to load the defaults plist file.","created_at":"2016-06-21T00:21:40Z","updated_at":"2016-06-22T01:11:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c1ff4cd524a76afdd4cf81e73e265a5ca9bf83a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/xcbuild/pulls/69/commits","review_comments_url":"https://api.github.com/repos/facebook/xcbuild/pulls/69/comments","review_comment_url":"https://api.github.com/repos/facebook/xcbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/xcbuild/issues/69/comments","statuses_url":"https://api.github.com/repos/facebook/xcbuild/statuses/a3258c52c6f3a7e68b4f02fc63cd84861e568e2c","head":{"label":"Ktwu:final-config","ref":"final-config","sha":"a3258c52c6f3a7e68b4f02fc63cd84861e568e2c","user":{"login":"Ktwu","id":470651,"avatar_url":"https://avatars.githubusercontent.com/u/470651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ktwu","html_url":"https://github.com/Ktwu","followers_url":"https://api.github.com/users/Ktwu/followers","following_url":"https://api.github.com/users/Ktwu/following{/other_user}","gists_url":"https://api.github.com/users/Ktwu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ktwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ktwu/subscriptions","organizations_url":"https://api.github.com/users/Ktwu/orgs","repos_url":"https://api.github.com/users/Ktwu/repos","events_url":"https://api.github.com/users/Ktwu/events{/privacy}","received_events_url":"https://api.github.com/users/Ktwu/received_events","type":"User","site_admin":false},"repo":{"id":59503840,"name":"xcbuild","full_name":"Ktwu/xcbuild","owner":{"login":"Ktwu","id":470651,"avatar_url":"https://avatars.githubusercontent.com/u/470651?v=3","gravatar_id":"","url":"https://api.github.com/users/Ktwu","html_url":"https://github.com/Ktwu","followers_url":"https://api.github.com/users/Ktwu/followers","following_url":"https://api.github.com/users/Ktwu/following{/other_user}","gists_url":"https://api.github.com/users/Ktwu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ktwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ktwu/subscriptions","organizations_url":"https://api.github.com/users/Ktwu/orgs","repos_url":"https://api.github.com/users/Ktwu/repos","events_url":"https://api.github.com/users/Ktwu/events{/privacy}","received_events_url":"https://api.github.com/users/Ktwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ktwu/xcbuild","description":"Xcode-compatible build tool.","fork":true,"url":"https://api.github.com/repos/Ktwu/xcbuild","forks_url":"https://api.github.com/repos/Ktwu/xcbuild/forks","keys_url":"https://api.github.com/repos/Ktwu/xcbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ktwu/xcbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ktwu/xcbuild/teams","hooks_url":"https://api.github.com/repos/Ktwu/xcbuild/hooks","issue_events_url":"https://api.github.com/repos/Ktwu/xcbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Ktwu/xcbuild/events","assignees_url":"https://api.github.com/repos/Ktwu/xcbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Ktwu/xcbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Ktwu/xcbuild/tags","blobs_url":"https://api.github.com/repos/Ktwu/xcbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ktwu/xcbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ktwu/xcbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ktwu/xcbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ktwu/xcbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Ktwu/xcbuild/languages","stargazers_url":"https://api.github.com/repos/Ktwu/xcbuild/stargazers","contributors_url":"https://api.github.com/repos/Ktwu/xcbuild/contributors","subscribers_url":"https://api.github.com/repos/Ktwu/xcbuild/subscribers","subscription_url":"https://api.github.com/repos/Ktwu/xcbuild/subscription","commits_url":"https://api.github.com/repos/Ktwu/xcbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ktwu/xcbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ktwu/xcbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ktwu/xcbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ktwu/xcbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Ktwu/xcbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ktwu/xcbuild/merges","archive_url":"https://api.github.com/repos/Ktwu/xcbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ktwu/xcbuild/downloads","issues_url":"https://api.github.com/repos/Ktwu/xcbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Ktwu/xcbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Ktwu/xcbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Ktwu/xcbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ktwu/xcbuild/labels{/name}","releases_url":"https://api.github.com/repos/Ktwu/xcbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Ktwu/xcbuild/deployments","created_at":"2016-05-23T17:25:18Z","updated_at":"2016-05-23T17:25:22Z","pushed_at":"2016-06-21T19:24:44Z","git_url":"git://github.com/Ktwu/xcbuild.git","ssh_url":"git@github.com:Ktwu/xcbuild.git","clone_url":"https://github.com/Ktwu/xcbuild.git","svn_url":"https://github.com/Ktwu/xcbuild","homepage":null,"size":3434,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"8e2cd85fe15aabec24e586a28eaf3a8fbd03d014","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":43019030,"name":"xcbuild","full_name":"facebook/xcbuild","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/xcbuild","description":"Xcode-compatible build tool.","fork":false,"url":"https://api.github.com/repos/facebook/xcbuild","forks_url":"https://api.github.com/repos/facebook/xcbuild/forks","keys_url":"https://api.github.com/repos/facebook/xcbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/xcbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/xcbuild/teams","hooks_url":"https://api.github.com/repos/facebook/xcbuild/hooks","issue_events_url":"https://api.github.com/repos/facebook/xcbuild/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/xcbuild/events","assignees_url":"https://api.github.com/repos/facebook/xcbuild/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/xcbuild/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/xcbuild/tags","blobs_url":"https://api.github.com/repos/facebook/xcbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/xcbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/xcbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/xcbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/xcbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/xcbuild/languages","stargazers_url":"https://api.github.com/repos/facebook/xcbuild/stargazers","contributors_url":"https://api.github.com/repos/facebook/xcbuild/contributors","subscribers_url":"https://api.github.com/repos/facebook/xcbuild/subscribers","subscription_url":"https://api.github.com/repos/facebook/xcbuild/subscription","commits_url":"https://api.github.com/repos/facebook/xcbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/xcbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/xcbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/xcbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/xcbuild/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/xcbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/xcbuild/merges","archive_url":"https://api.github.com/repos/facebook/xcbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/xcbuild/downloads","issues_url":"https://api.github.com/repos/facebook/xcbuild/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/xcbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/xcbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/xcbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/xcbuild/labels{/name}","releases_url":"https://api.github.com/repos/facebook/xcbuild/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/xcbuild/deployments","created_at":"2015-09-23T18:24:01Z","updated_at":"2016-06-21T21:07:02Z","pushed_at":"2016-06-21T19:24:44Z","git_url":"git://github.com/facebook/xcbuild.git","ssh_url":"git@github.com:facebook/xcbuild.git","clone_url":"https://github.com/facebook/xcbuild.git","svn_url":"https://github.com/facebook/xcbuild","homepage":null,"size":3538,"stargazers_count":973,"watchers_count":973,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":24,"forks":49,"open_issues":24,"watchers":973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/69"},"html":{"href":"https://github.com/facebook/xcbuild/pull/69"},"issue":{"href":"https://api.github.com/repos/facebook/xcbuild/issues/69"},"comments":{"href":"https://api.github.com/repos/facebook/xcbuild/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/xcbuild/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/xcbuild/statuses/a3258c52c6f3a7e68b4f02fc63cd84861e568e2c"}}}}
{"actor":{"display_login":"Ktwu"}}