{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/88457913","pull_request_review_id":9030361,"id":88457913,"diff_hunk":"@@ -11,6 +11,5 @@\n )\n from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker\n phase2_tracker.toModify(ClusterShapeHitFilterESProducer,\n-    PixelShapeFile = 'RecoPixelVertexing/PixelLowPtUtilities/data/pixelShape_Phase1Tk.par',\n-    doPixelShapeCut = cms.bool(False)\n+    PixelShapeFile = 'RecoPixelVertexing/PixelLowPtUtilities/data/pixelShape_Phase2Tk.par',","path":"RecoPixelVertexing/PixelLowPtUtilities/python/ClusterShapeHitFilterESProducer_cfi.py","position":6,"original_position":6,"commit_id":"73649c382ef2fb1781d6f4838099812b3c9395fb","original_commit_id":"73649c382ef2fb1781d6f4838099812b3c9395fb","user":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"body":"You are right. \r\nI am not sure how to menage this problem in the different geometries.\r\n@kpedro88 @atricomi @boudoul do you have any suggestion?","created_at":"2016-11-17T14:05:30Z","updated_at":"2016-11-17T14:05:30Z","html_url":"https://github.com/cms-sw/cmssw/pull/16470#discussion_r88457913","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/88457913"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/16470#discussion_r88457913"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470","id":92337704,"html_url":"https://github.com/cms-sw/cmssw/pull/16470","diff_url":"https://github.com/cms-sw/cmssw/pull/16470.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16470.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16470","number":16470,"state":"open","locked":false,"title":"Fix phase2 pixel in GeometrySearch","user":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"body":"This PR has been developed in CMSSW_8_1_X_2016-11-01-2300 and tested on top of the PR #16407. This is the evolution of the story: with a private branch that produce the hit on track maps for phase2 geometry, I produced the ratio clusters/clusters on track in D4:\r\n![ontrackmultmap_v4021_baseline](https://cloud.githubusercontent.com/assets/5331004/20005936/65407394-a295-11e6-98c2-cb284fb1922e.png)\r\nIt is pretty clear that the forward phase2 pixel detector is missing some hits and the last rings of the last forward layers[8-11] are not included in the search. \r\nThe problem has been cured using not anymore the class `PixelForwardLayerBuilder` but instead adapting `Phase2OTEndcapLayerBuilder` to be also used for the forward phase2 pixel. In this respect the naming has been changed everywhere.\r\nAfter this fix, the new map for D4 looks like:\r\n![ontrackmultmap_v4021_fixphase2pixelgeometry_rebase](https://cloud.githubusercontent.com/assets/5331004/20006102/56e5273a-a296-11e6-8257-0ef19732a0bc.png)\r\nThe code has been changed in such a way that the other D* should not be affected.\r\n\r\nThis impact some track variables such as the #hits vs eta, just two examples for [single mu](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_FourMuExtended/plots_ootb/hitsAndPt.pdf) and for [ttbar](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_TTbar/plots_ootb/hitsAndPt.pdf). But both seem now much more reasonable respect to before. If you want to have a look at the full set of results you can find them [here](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_FourMuExtended/) and [there](http://ebrondol.web.cern.ch/ebrondol/Phase2Tracking/fixPhase2PixelGeometry/20161103_TTbar/). No huge differences have been noticed in eff/fakes.\r\n\r\nThe documentation in `RecoTracker/TkDetLayers/doc/TkDetLayersTree.pdf` has also been update - including the tilted update that was never introduced.\r\n\r\nThanks to @VinInn @rovere @venturia \r\nInforming @delaere @boudoul  @atricomi @kpedro88 ","created_at":"2016-11-04T13:15:39Z","updated_at":"2016-11-17T14:05:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"103476f8d81096f8a68f2fc447c786fb261c2f17","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":1936,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-11-17T11:47:13Z","due_on":"2016-11-26T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16470/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/73649c382ef2fb1781d6f4838099812b3c9395fb","head":{"label":"ebrondol:fixPhase2PixelGeometry_rebase","ref":"fixPhase2PixelGeometry_rebase","sha":"73649c382ef2fb1781d6f4838099812b3c9395fb","user":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"repo":{"id":18753381,"name":"cmssw","full_name":"ebrondol/cmssw","owner":{"login":"ebrondol","id":5331004,"avatar_url":"https://avatars.githubusercontent.com/u/5331004?v=3","gravatar_id":"","url":"https://api.github.com/users/ebrondol","html_url":"https://github.com/ebrondol","followers_url":"https://api.github.com/users/ebrondol/followers","following_url":"https://api.github.com/users/ebrondol/following{/other_user}","gists_url":"https://api.github.com/users/ebrondol/gists{/gist_id}","starred_url":"https://api.github.com/users/ebrondol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebrondol/subscriptions","organizations_url":"https://api.github.com/users/ebrondol/orgs","repos_url":"https://api.github.com/users/ebrondol/repos","events_url":"https://api.github.com/users/ebrondol/events{/privacy}","received_events_url":"https://api.github.com/users/ebrondol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebrondol/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/ebrondol/cmssw","forks_url":"https://api.github.com/repos/ebrondol/cmssw/forks","keys_url":"https://api.github.com/repos/ebrondol/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebrondol/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebrondol/cmssw/teams","hooks_url":"https://api.github.com/repos/ebrondol/cmssw/hooks","issue_events_url":"https://api.github.com/repos/ebrondol/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/ebrondol/cmssw/events","assignees_url":"https://api.github.com/repos/ebrondol/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/ebrondol/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/ebrondol/cmssw/tags","blobs_url":"https://api.github.com/repos/ebrondol/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebrondol/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebrondol/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebrondol/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebrondol/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/ebrondol/cmssw/languages","stargazers_url":"https://api.github.com/repos/ebrondol/cmssw/stargazers","contributors_url":"https://api.github.com/repos/ebrondol/cmssw/contributors","subscribers_url":"https://api.github.com/repos/ebrondol/cmssw/subscribers","subscription_url":"https://api.github.com/repos/ebrondol/cmssw/subscription","commits_url":"https://api.github.com/repos/ebrondol/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebrondol/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebrondol/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebrondol/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebrondol/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/ebrondol/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebrondol/cmssw/merges","archive_url":"https://api.github.com/repos/ebrondol/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebrondol/cmssw/downloads","issues_url":"https://api.github.com/repos/ebrondol/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/ebrondol/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/ebrondol/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/ebrondol/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebrondol/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/ebrondol/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/ebrondol/cmssw/deployments","created_at":"2014-04-14T08:22:32Z","updated_at":"2015-10-28T20:46:48Z","pushed_at":"2016-11-16T16:47:47Z","git_url":"git://github.com/ebrondol/cmssw.git","ssh_url":"git@github.com:ebrondol/cmssw.git","clone_url":"https://github.com/ebrondol/cmssw.git","svn_url":"https://github.com/ebrondol/cmssw","homepage":"cms-sw.github.io/cmssw","size":906862,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"ff01954d53367eb16087dbc5be2949efe408adc0","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-11-16T20:50:01Z","pushed_at":"2016-11-17T13:12:48Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1145920,"stargazers_count":362,"watchers_count":362,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2026,"mirror_url":null,"open_issues_count":372,"forks":2026,"open_issues":372,"watchers":362,"default_branch":"CMSSW_9_0_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/16470"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/16470"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/16470/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/16470/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/73649c382ef2fb1781d6f4838099812b3c9395fb"}}}}
{"actor":{"display_login":"ebrondol"}}