{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/73125455","id":73125455,"diff_hunk":"@@ -132,6 +136,14 @@ def caveats\n   end\n \n   test do\n-    system \"#{bin}/identify\", test_fixtures(\"test.png\")\n+    system bin/\"identify\", test_fixtures(\"test.png\")\n+    # Test recommended features and delegates.\n+    features = shell_output(\"#{bin}/convert -version\")\n+    assert_match \"freetype\", features if build.with? \"freetype\"","path":"Formula/imagemagick.rb","position":127,"original_position":127,"commit_id":"5078d335b638a5ca4886de9e95af8a7e5dbec888","original_commit_id":"5078d335b638a5ca4886de9e95af8a7e5dbec888","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"body":"Sure, I'll remove the `build.with?`. (Otherwise there will be six lines that are going to be executed.)","created_at":"2016-08-02T09:47:52Z","updated_at":"2016-08-02T09:47:52Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/3511#discussion_r73125455","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/73125455"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/3511#discussion_r73125455"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511","id":79666719,"html_url":"https://github.com/Homebrew/homebrew-core/pull/3511","diff_url":"https://github.com/Homebrew/homebrew-core/pull/3511.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/3511.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3511","number":3511,"state":"open","locked":false,"title":"imagemagick: improve option and configure argument handling","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-core/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally prior to submission with `brew install <formula>` (where `<formula>` is the name of the formula you're submitting)?\r\n- [x] Does your submission pass `brew audit --strict --online <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nThis is a continuation of the work in 8d6f16e. In this commit we fix and/or improve the configure arguments related to the recommended and optional features, and make them consistent. We follow these rules:\r\n\r\n1. Only specify `--disable-*` or `--without-*` for Homebrew-recommended, default-on-in-configure features.\r\n\r\n2. Specify `--enable-*` or `--disable-*` (`--with-*` or `--without-*`) when building with or without Homebrew-recommended yet default-off-in-configure features. Currently affected features: opencl and modules.\r\n\r\n3. Only specify `--enable-*` or `--with-*` for Homebrew-optional features.\r\n\r\nFeatures in the respective groups (by rule) are now sorted to ease management. The recommended and optional dependencies are also sorted respectively.\r\n\r\nNote that I made X an exception of rule 3 (by explicitly specifying `--without-x` when building without x11) because in my experience, autodetection of X could cause buildtime issues. Interested parties are recommended to investigate this issue. (Specifically, I wasn't specifying `--with-x11`, but X was autodetected anyway, and as a result I got `X11/Xos.h` missing or something like that during build — which of course shouldn't be missing. I think `--with-x11` might be broken too, but I'm not really interested in that.)\r\n\r\nTo accompany the configure argument fixes and/or improvements, I have added tests to make sure the Homebrew-recommended features and delegates are present.\r\n\r\nNotable functional changes, including but not limited to\r\n\r\n1. We now explicitly specify `--enable-opencl` when building with OpenCL support (recommended). Previous bottles don't actually include OpenCL support, so I bumped the revision accordingly.\r\n\r\n2. Previously we were specifying `--with-gs-font-dir` when building *without* ghostscript, which presumably is a mistake. Now it goes together with `--with-gslib`. (Please correct me if I'm wrong.)\r\n\r\nBy the way, let me know one-liners are preferred over those `if..else..end` blocks.","created_at":"2016-08-02T02:19:39Z","updated_at":"2016-08-02T09:47:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6639ea3b2c991a3f3b2c9a9b325505450c6580e9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3511/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/5078d335b638a5ca4886de9e95af8a7e5dbec888","head":{"label":"zmwangx:imagemagick-fix-options","ref":"imagemagick-fix-options","sha":"5078d335b638a5ca4886de9e95af8a7e5dbec888","user":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"repo":{"id":55401272,"name":"homebrew-core","full_name":"zmwangx/homebrew-core","owner":{"login":"zmwangx","id":4149852,"avatar_url":"https://avatars.githubusercontent.com/u/4149852?v=3","gravatar_id":"","url":"https://api.github.com/users/zmwangx","html_url":"https://github.com/zmwangx","followers_url":"https://api.github.com/users/zmwangx/followers","following_url":"https://api.github.com/users/zmwangx/following{/other_user}","gists_url":"https://api.github.com/users/zmwangx/gists{/gist_id}","starred_url":"https://api.github.com/users/zmwangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmwangx/subscriptions","organizations_url":"https://api.github.com/users/zmwangx/orgs","repos_url":"https://api.github.com/users/zmwangx/repos","events_url":"https://api.github.com/users/zmwangx/events{/privacy}","received_events_url":"https://api.github.com/users/zmwangx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmwangx/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/zmwangx/homebrew-core","forks_url":"https://api.github.com/repos/zmwangx/homebrew-core/forks","keys_url":"https://api.github.com/repos/zmwangx/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmwangx/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmwangx/homebrew-core/teams","hooks_url":"https://api.github.com/repos/zmwangx/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/zmwangx/homebrew-core/events","assignees_url":"https://api.github.com/repos/zmwangx/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/zmwangx/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/zmwangx/homebrew-core/tags","blobs_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmwangx/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/zmwangx/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/zmwangx/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/zmwangx/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/zmwangx/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/zmwangx/homebrew-core/subscription","commits_url":"https://api.github.com/repos/zmwangx/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmwangx/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmwangx/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmwangx/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/zmwangx/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmwangx/homebrew-core/merges","archive_url":"https://api.github.com/repos/zmwangx/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmwangx/homebrew-core/downloads","issues_url":"https://api.github.com/repos/zmwangx/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/zmwangx/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/zmwangx/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/zmwangx/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmwangx/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/zmwangx/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/zmwangx/homebrew-core/deployments","created_at":"2016-04-04T10:04:01Z","updated_at":"2016-04-04T10:04:16Z","pushed_at":"2016-08-02T02:14:05Z","git_url":"git://github.com/zmwangx/homebrew-core.git","ssh_url":"git@github.com:zmwangx/homebrew-core.git","clone_url":"https://github.com/zmwangx/homebrew-core.git","svn_url":"https://github.com/zmwangx/homebrew-core","homepage":"http://brew.sh","size":64978,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"8427e8c7683b2676f81977d74a617b2922da2a24","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-08-02T09:14:33Z","pushed_at":"2016-08-02T09:43:06Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":102554,"stargazers_count":622,"watchers_count":622,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1089,"mirror_url":null,"open_issues_count":181,"forks":1089,"open_issues":181,"watchers":622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/3511"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3511"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/3511/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/3511/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/5078d335b638a5ca4886de9e95af8a7e5dbec888"}}}}
{"actor":{"display_login":"zmwangx"}}