{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/googlei18n/compreffor/pulls/17","id":82077388,"html_url":"https://github.com/googlei18n/compreffor/pull/17","diff_url":"https://github.com/googlei18n/compreffor/pull/17.diff","patch_url":"https://github.com/googlei18n/compreffor/pull/17.patch","issue_url":"https://api.github.com/repos/googlei18n/compreffor/issues/17","number":17,"state":"closed","locked":false,"title":"cffCompressor.cc: use std::thread::hardware_concurrency() for NUM_THREADS","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"body":"The current default value is set to 100, which is too large and results in 'oversubscription' (i.e. number of threads exceeding available logical cores).\r\nThat means the workload is decomposed into too small chunks, leading to unnecessary 'context switching' of the CPU from one thread to another, that can slow the overall performace.\r\n\r\nThe `hardware_concurrency` function returns the number of hardware threads available on the system (e.g. CPU cores or hyperthreading units), or 0 if the information is not available.\r\n\r\nhttp://www.cplusplus.com/reference/thread/thread/hardware_concurrency/\r\n\r\nI'm new to both C++ and multi-threading, so any suggestions or comments are appreciated,\r\nthanks!","created_at":"2016-08-20T12:21:55Z","updated_at":"2016-09-15T15:49:14Z","closed_at":"2016-09-15T15:49:14Z","merged_at":"2016-09-15T15:49:14Z","merge_commit_sha":"af820499c016b3e812c4d738af187560bf447003","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlei18n/compreffor/pulls/17/commits","review_comments_url":"https://api.github.com/repos/googlei18n/compreffor/pulls/17/comments","review_comment_url":"https://api.github.com/repos/googlei18n/compreffor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlei18n/compreffor/issues/17/comments","statuses_url":"https://api.github.com/repos/googlei18n/compreffor/statuses/f0dae6ca92bcca1445823b14bda911372481bdb1","head":{"label":"anthrotype:hardware-threads","ref":"hardware-threads","sha":"f0dae6ca92bcca1445823b14bda911372481bdb1","user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"repo":{"id":36726468,"name":"compreffor","full_name":"anthrotype/compreffor","owner":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anthrotype/compreffor","description":"A CFF table subroutinizer for FontTools","fork":true,"url":"https://api.github.com/repos/anthrotype/compreffor","forks_url":"https://api.github.com/repos/anthrotype/compreffor/forks","keys_url":"https://api.github.com/repos/anthrotype/compreffor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthrotype/compreffor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthrotype/compreffor/teams","hooks_url":"https://api.github.com/repos/anthrotype/compreffor/hooks","issue_events_url":"https://api.github.com/repos/anthrotype/compreffor/issues/events{/number}","events_url":"https://api.github.com/repos/anthrotype/compreffor/events","assignees_url":"https://api.github.com/repos/anthrotype/compreffor/assignees{/user}","branches_url":"https://api.github.com/repos/anthrotype/compreffor/branches{/branch}","tags_url":"https://api.github.com/repos/anthrotype/compreffor/tags","blobs_url":"https://api.github.com/repos/anthrotype/compreffor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthrotype/compreffor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthrotype/compreffor/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthrotype/compreffor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthrotype/compreffor/statuses/{sha}","languages_url":"https://api.github.com/repos/anthrotype/compreffor/languages","stargazers_url":"https://api.github.com/repos/anthrotype/compreffor/stargazers","contributors_url":"https://api.github.com/repos/anthrotype/compreffor/contributors","subscribers_url":"https://api.github.com/repos/anthrotype/compreffor/subscribers","subscription_url":"https://api.github.com/repos/anthrotype/compreffor/subscription","commits_url":"https://api.github.com/repos/anthrotype/compreffor/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthrotype/compreffor/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthrotype/compreffor/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthrotype/compreffor/issues/comments{/number}","contents_url":"https://api.github.com/repos/anthrotype/compreffor/contents/{+path}","compare_url":"https://api.github.com/repos/anthrotype/compreffor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthrotype/compreffor/merges","archive_url":"https://api.github.com/repos/anthrotype/compreffor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthrotype/compreffor/downloads","issues_url":"https://api.github.com/repos/anthrotype/compreffor/issues{/number}","pulls_url":"https://api.github.com/repos/anthrotype/compreffor/pulls{/number}","milestones_url":"https://api.github.com/repos/anthrotype/compreffor/milestones{/number}","notifications_url":"https://api.github.com/repos/anthrotype/compreffor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthrotype/compreffor/labels{/name}","releases_url":"https://api.github.com/repos/anthrotype/compreffor/releases{/id}","deployments_url":"https://api.github.com/repos/anthrotype/compreffor/deployments","created_at":"2015-06-02T10:44:11Z","updated_at":"2016-04-30T15:54:45Z","pushed_at":"2016-09-10T11:25:23Z","git_url":"git://github.com/anthrotype/compreffor.git","ssh_url":"git@github.com:anthrotype/compreffor.git","clone_url":"https://github.com/anthrotype/compreffor.git","svn_url":"https://github.com/anthrotype/compreffor","homepage":null,"size":318,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlei18n:master","ref":"master","sha":"c59b55d821c28a11729751d4a85b0547a76eeb18","user":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"repo":{"id":36692932,"name":"compreffor","full_name":"googlei18n/compreffor","owner":{"login":"googlei18n","id":5503833,"avatar_url":"https://avatars.githubusercontent.com/u/5503833?v=3","gravatar_id":"","url":"https://api.github.com/users/googlei18n","html_url":"https://github.com/googlei18n","followers_url":"https://api.github.com/users/googlei18n/followers","following_url":"https://api.github.com/users/googlei18n/following{/other_user}","gists_url":"https://api.github.com/users/googlei18n/gists{/gist_id}","starred_url":"https://api.github.com/users/googlei18n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlei18n/subscriptions","organizations_url":"https://api.github.com/users/googlei18n/orgs","repos_url":"https://api.github.com/users/googlei18n/repos","events_url":"https://api.github.com/users/googlei18n/events{/privacy}","received_events_url":"https://api.github.com/users/googlei18n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlei18n/compreffor","description":"A CFF table subroutinizer for FontTools","fork":false,"url":"https://api.github.com/repos/googlei18n/compreffor","forks_url":"https://api.github.com/repos/googlei18n/compreffor/forks","keys_url":"https://api.github.com/repos/googlei18n/compreffor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlei18n/compreffor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlei18n/compreffor/teams","hooks_url":"https://api.github.com/repos/googlei18n/compreffor/hooks","issue_events_url":"https://api.github.com/repos/googlei18n/compreffor/issues/events{/number}","events_url":"https://api.github.com/repos/googlei18n/compreffor/events","assignees_url":"https://api.github.com/repos/googlei18n/compreffor/assignees{/user}","branches_url":"https://api.github.com/repos/googlei18n/compreffor/branches{/branch}","tags_url":"https://api.github.com/repos/googlei18n/compreffor/tags","blobs_url":"https://api.github.com/repos/googlei18n/compreffor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlei18n/compreffor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlei18n/compreffor/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlei18n/compreffor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlei18n/compreffor/statuses/{sha}","languages_url":"https://api.github.com/repos/googlei18n/compreffor/languages","stargazers_url":"https://api.github.com/repos/googlei18n/compreffor/stargazers","contributors_url":"https://api.github.com/repos/googlei18n/compreffor/contributors","subscribers_url":"https://api.github.com/repos/googlei18n/compreffor/subscribers","subscription_url":"https://api.github.com/repos/googlei18n/compreffor/subscription","commits_url":"https://api.github.com/repos/googlei18n/compreffor/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlei18n/compreffor/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlei18n/compreffor/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlei18n/compreffor/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlei18n/compreffor/contents/{+path}","compare_url":"https://api.github.com/repos/googlei18n/compreffor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlei18n/compreffor/merges","archive_url":"https://api.github.com/repos/googlei18n/compreffor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlei18n/compreffor/downloads","issues_url":"https://api.github.com/repos/googlei18n/compreffor/issues{/number}","pulls_url":"https://api.github.com/repos/googlei18n/compreffor/pulls{/number}","milestones_url":"https://api.github.com/repos/googlei18n/compreffor/milestones{/number}","notifications_url":"https://api.github.com/repos/googlei18n/compreffor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlei18n/compreffor/labels{/name}","releases_url":"https://api.github.com/repos/googlei18n/compreffor/releases{/id}","deployments_url":"https://api.github.com/repos/googlei18n/compreffor/deployments","created_at":"2015-06-01T22:34:10Z","updated_at":"2016-06-20T15:05:54Z","pushed_at":"2016-09-15T15:49:14Z","git_url":"git://github.com/googlei18n/compreffor.git","ssh_url":"git@github.com:googlei18n/compreffor.git","clone_url":"https://github.com/googlei18n/compreffor.git","svn_url":"https://github.com/googlei18n/compreffor","homepage":null,"size":316,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":6,"forks":8,"open_issues":6,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/17"},"html":{"href":"https://github.com/googlei18n/compreffor/pull/17"},"issue":{"href":"https://api.github.com/repos/googlei18n/compreffor/issues/17"},"comments":{"href":"https://api.github.com/repos/googlei18n/compreffor/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlei18n/compreffor/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/googlei18n/compreffor/statuses/f0dae6ca92bcca1445823b14bda911372481bdb1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"commits":2,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"anthrotype"}}