{"action":"closed","number":1052,"pull_request":{"url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1052","id":83711626,"html_url":"https://github.com/jonathanmccann/liferay-portal/pull/1052","diff_url":"https://github.com/jonathanmccann/liferay-portal/pull/1052.diff","patch_url":"https://github.com/jonathanmccann/liferay-portal/pull/1052.patch","issue_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1052","number":1052,"state":"closed","locked":false,"title":"[TECHNICAL-SUPPORT] LPS-62831","user":{"login":"SamZiemer","id":8029905,"avatar_url":"https://avatars.githubusercontent.com/u/8029905?v=3","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"body":"/cc @mbowerman\r\n\r\nNotes from Michael:\r\n\r\n> I think it might also be possible to improve performance if we take the logic out of isPrivateLayout and stick it into the addCriteria method. However, it seemed too complicated to put it into the addCriteria method since I wasn't sure how to do ORs or a LIKE on a list of primKey candidates, among other things.\r\n\r\n> You can see [my comment](https://issues.liferay.com/browse/LPS-62831?focusedCommentId=854447&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-854447) on the LPS for more information, but I've verified that my fix not only resolves the issue, but gives a huge performance boost as well.","created_at":"2016-09-01T21:38:13Z","updated_at":"2016-09-01T22:05:24Z","closed_at":"2016-09-01T22:05:24Z","merged_at":null,"merge_commit_sha":"1b29f83a6686ec445ae0bdd1b4bf217d4e6d27ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1052/commits","review_comments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1052/comments","review_comment_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1052/comments","statuses_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/statuses/6b11e9292bb8cab94c4cacd4f15d48e5f095f2e1","head":{"label":"SamZiemer:mbowerman-LPS-62831","ref":"mbowerman-LPS-62831","sha":"6b11e9292bb8cab94c4cacd4f15d48e5f095f2e1","user":{"login":"SamZiemer","id":8029905,"avatar_url":"https://avatars.githubusercontent.com/u/8029905?v=3","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"repo":{"id":21368461,"name":"liferay-portal","full_name":"SamZiemer/liferay-portal","owner":{"login":"SamZiemer","id":8029905,"avatar_url":"https://avatars.githubusercontent.com/u/8029905?v=3","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamZiemer/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/SamZiemer/liferay-portal","forks_url":"https://api.github.com/repos/SamZiemer/liferay-portal/forks","keys_url":"https://api.github.com/repos/SamZiemer/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamZiemer/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamZiemer/liferay-portal/teams","hooks_url":"https://api.github.com/repos/SamZiemer/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/SamZiemer/liferay-portal/events","assignees_url":"https://api.github.com/repos/SamZiemer/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/SamZiemer/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/SamZiemer/liferay-portal/tags","blobs_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamZiemer/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/SamZiemer/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/SamZiemer/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/SamZiemer/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/SamZiemer/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/SamZiemer/liferay-portal/subscription","commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamZiemer/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/SamZiemer/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamZiemer/liferay-portal/merges","archive_url":"https://api.github.com/repos/SamZiemer/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamZiemer/liferay-portal/downloads","issues_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/SamZiemer/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/SamZiemer/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamZiemer/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/SamZiemer/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/deployments","created_at":"2014-06-30T22:51:45Z","updated_at":"2016-04-05T22:40:10Z","pushed_at":"2016-09-01T21:38:04Z","git_url":"git://github.com/SamZiemer/liferay-portal.git","ssh_url":"git@github.com:SamZiemer/liferay-portal.git","clone_url":"https://github.com/SamZiemer/liferay-portal.git","svn_url":"https://github.com/SamZiemer/liferay-portal","homepage":"http://liferay.com","size":7546789,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"jonathanmccann:master","ref":"master","sha":"b3ee96fcb9ef4766cc17dd5c14ccbdfc1e4c54a3","user":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"repo":{"id":4877415,"name":"liferay-portal","full_name":"jonathanmccann/liferay-portal","owner":{"login":"jonathanmccann","id":1919610,"avatar_url":"https://avatars.githubusercontent.com/u/1919610?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanmccann","html_url":"https://github.com/jonathanmccann","followers_url":"https://api.github.com/users/jonathanmccann/followers","following_url":"https://api.github.com/users/jonathanmccann/following{/other_user}","gists_url":"https://api.github.com/users/jonathanmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanmccann/subscriptions","organizations_url":"https://api.github.com/users/jonathanmccann/orgs","repos_url":"https://api.github.com/users/jonathanmccann/repos","events_url":"https://api.github.com/users/jonathanmccann/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanmccann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathanmccann/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/jonathanmccann/liferay-portal","forks_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/forks","keys_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/teams","hooks_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/events","assignees_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/tags","blobs_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/subscription","commits_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/merges","archive_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/downloads","issues_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/deployments","created_at":"2012-07-03T20:58:23Z","updated_at":"2016-04-05T22:39:53Z","pushed_at":"2016-09-01T22:05:18Z","git_url":"git://github.com/jonathanmccann/liferay-portal.git","ssh_url":"git@github.com:jonathanmccann/liferay-portal.git","clone_url":"https://github.com/jonathanmccann/liferay-portal.git","svn_url":"https://github.com/jonathanmccann/liferay-portal","homepage":"http://liferay.com","size":7550454,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1052"},"html":{"href":"https://github.com/jonathanmccann/liferay-portal/pull/1052"},"issue":{"href":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1052"},"comments":{"href":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1052/comments"},"review_comments":{"href":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1052/comments"},"review_comment":{"href":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1052/commits"},"statuses":{"href":"https://api.github.com/repos/jonathanmccann/liferay-portal/statuses/6b11e9292bb8cab94c4cacd4f15d48e5f095f2e1"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":49,"additions":2028,"deletions":283,"changed_files":66}}
{"actor":{"display_login":"jonathanmccann"}}