{"action":"created","issue":{"url":"https://api.github.com/repos/google/googletest/issues/893","repository_url":"https://api.github.com/repos/google/googletest","labels_url":"https://api.github.com/repos/google/googletest/issues/893/labels{/name}","comments_url":"https://api.github.com/repos/google/googletest/issues/893/comments","events_url":"https://api.github.com/repos/google/googletest/issues/893/events","html_url":"https://github.com/google/googletest/issues/893","id":181320649,"number":893,"title":"Failed to compile: OpenThread is not declared","user":{"login":"AlexanderPaniutin","id":14287789,"avatar_url":"https://avatars.githubusercontent.com/u/14287789?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexanderPaniutin","html_url":"https://github.com/AlexanderPaniutin","followers_url":"https://api.github.com/users/AlexanderPaniutin/followers","following_url":"https://api.github.com/users/AlexanderPaniutin/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderPaniutin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderPaniutin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderPaniutin/subscriptions","organizations_url":"https://api.github.com/users/AlexanderPaniutin/orgs","repos_url":"https://api.github.com/users/AlexanderPaniutin/repos","events_url":"https://api.github.com/users/AlexanderPaniutin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderPaniutin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-06T04:11:30Z","updated_at":"2016-10-06T16:16:09Z","closed_at":null,"body":"Still fails for me on gtest-port.cc\r\n\r\n> x:\\Projects\\GitHub\\googletest\\googletest\\build>cmake -G \"MSYS Makefiles\" ..\r\n-- The CXX compiler identification is GNU 4.9.3\r\n-- The C compiler identification is GNU 4.9.3\r\n-- Check for working CXX compiler: C:/MinGW/bin/g++.exe\r\n-- Check for working CXX compiler: C:/MinGW/bin/g++.exe -- works\r\n-- Detecting CXX compiler ABI info\r\n-- Detecting CXX compiler ABI info - done\r\n-- Detecting CXX compile features\r\n-- Detecting CXX compile features - done\r\n-- Check for working C compiler: C:/MinGW/bin/gcc.exe\r\n-- Check for working C compiler: C:/MinGW/bin/gcc.exe -- works\r\n-- Detecting C compiler ABI info\r\n-- Detecting C compiler ABI info - done\r\n-- Detecting C compile features\r\n-- Detecting C compile features - done\r\n-- Found PythonInterp: X:/Python34/python.exe (found version \"3.4.1\")\r\n-- Configuring done\r\n-- Generating done\r\n-- Build files have been written to: X:/Projects/GitHub/googletest/googletest/build\r\n\r\n>x:\\Projects\\GitHub\\googletest\\googletest\\build>make\r\nScanning dependencies of target gtest\r\n[ 25%] Building CXX object CMakeFiles/gtest.dir/src/gtest-all.cc.obj\r\nIn file included from x:/Projects/GitHub/googletest/googletest/src/gtest-all.cc:45:0:\r\nX:/Projects/GitHub/googletest/googletest/src/gtest-port.cc: In static member function 'static void testing::internal::ThreadLocalR\r\negistryImpl::StartWatcherThreadFor(DWORD)':\r\nX:/Projects/GitHub/googletest/googletest/src/gtest-port.cc:495:21: error: '::OpenThread' has not been declared\r\n     HANDLE thread = ::OpenThread(SYNCHRONIZE | THREAD_QUERY_INFORMATION,\r\n                     ^\r\nmake[9]: *** [CMakeFiles/gtest.dir/src/gtest-all.cc.obj] Error 1\r\nmake[8]: *** [CMakeFiles/gtest.dir/all] Error 2\r\nmake[7]: *** [all] Error 2\r\n\r\n>x:\\Projects\\GitHub\\googletest\\googletest\\build>cmake --version\r\ncmake version 3.6.0\r\n\r\n>CMake suite maintained and supported by Kitware (kitware.com/cmake).\r\n\r\n>x:\\Projects\\GitHub\\googletest\\googletest\\build>g++ --version\r\ng++ (GCC) 4.9.3\r\nCopyright (C) 2015 Free Software Foundation, Inc.\r\nThis is free software; see the source for copying conditions.  There is NO\r\nwarranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\r\n\r\nI cant find OpenThread in a source directory. is it another project `[OpenThread](https://github.com/openthread)`"},"comment":{"url":"https://api.github.com/repos/google/googletest/issues/comments/252012446","html_url":"https://github.com/google/googletest/issues/893#issuecomment-252012446","issue_url":"https://api.github.com/repos/google/googletest/issues/893","id":252012446,"user":{"login":"AlexanderPaniutin","id":14287789,"avatar_url":"https://avatars.githubusercontent.com/u/14287789?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexanderPaniutin","html_url":"https://github.com/AlexanderPaniutin","followers_url":"https://api.github.com/users/AlexanderPaniutin/followers","following_url":"https://api.github.com/users/AlexanderPaniutin/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderPaniutin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderPaniutin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderPaniutin/subscriptions","organizations_url":"https://api.github.com/users/AlexanderPaniutin/orgs","repos_url":"https://api.github.com/users/AlexanderPaniutin/repos","events_url":"https://api.github.com/users/AlexanderPaniutin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderPaniutin/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T16:16:09Z","updated_at":"2016-10-06T16:16:09Z","body":"Found OpenThread in winbase.h but it seems like gtest_port.cc is not getting a declaration.\r\nAlso found a few comments like \"Do not include windows.h but use forward declarations instead\".\r\nI did add \r\n> WINBASEAPI HANDLE WINAPI OpenThread(DWORD,BOOL,DWORD);\r\nand removed **::** in front of OpenThread and it did work out.\r\n\r\nDoes it make sense to open a PR so you can take a look?\r\n\r\n>x:\\Projects\\GitHub\\googletest\\googletest\\build>cmake -G \"MSYS Makefiles\" ..\r\n-- The CXX compiler identification is GNU 4.9.3\r\n-- The C compiler identification is GNU 4.9.3\r\n-- Check for working CXX compiler: C:/MinGW/bin/g++.exe\r\n-- Check for working CXX compiler: C:/MinGW/bin/g++.exe -- works\r\n-- Detecting CXX compiler ABI info\r\n-- Detecting CXX compiler ABI info - done\r\n-- Detecting CXX compile features\r\n-- Detecting CXX compile features - done\r\n-- Check for working C compiler: C:/MinGW/bin/gcc.exe\r\n-- Check for working C compiler: C:/MinGW/bin/gcc.exe -- works\r\n-- Detecting C compiler ABI info\r\n-- Detecting C compiler ABI info - done\r\n-- Detecting C compile features\r\n-- Detecting C compile features - done\r\n-- Found PythonInterp: X:/Python34/python.exe (found version \"3.4.1\")\r\n-- Configuring done\r\n-- Generating done\r\n-- Build files have been written to: X:/Projects/GitHub/googletest/googletest/build\r\n\r\n>x:\\Projects\\GitHub\\googletest\\googletest\\build>make\r\nScanning dependencies of target gtest\r\n[ 25%] Building CXX object CMakeFiles/gtest.dir/src/gtest-all.cc.obj\r\n[ 50%] Linking CXX static library libgtest.a\r\n[ 50%] Built target gtest\r\nScanning dependencies of target gtest_main\r\n[ 75%] Building CXX object CMakeFiles/gtest_main.dir/src/gtest_main.cc.obj\r\n[100%] Linking CXX static library libgtest_main.a\r\n[100%] Built target gtest_main"}}
{"actor":{"display_login":"AlexanderPaniutin"}}