{"action":"created","issue":{"url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/1496","repository_url":"https://api.github.com/repos/jonmak08/liferay-portal","labels_url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/1496/labels{/name}","comments_url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/1496/comments","events_url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/1496/events","html_url":"https://github.com/jonmak08/liferay-portal/pull/1496","id":137431053,"number":1496,"title":"LPS-63179 - include newline char after minified javascript to prevent commenting out the first line of the next file if the current one ends in a comment","user":{"login":"mjbradford89","id":6517855,"avatar_url":"https://avatars.githubusercontent.com/u/6517855?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbradford89","html_url":"https://github.com/mjbradford89","followers_url":"https://api.github.com/users/mjbradford89/followers","following_url":"https://api.github.com/users/mjbradford89/following{/other_user}","gists_url":"https://api.github.com/users/mjbradford89/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbradford89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbradford89/subscriptions","organizations_url":"https://api.github.com/users/mjbradford89/orgs","repos_url":"https://api.github.com/users/mjbradford89/repos","events_url":"https://api.github.com/users/mjbradford89/events{/privacy}","received_events_url":"https://api.github.com/users/mjbradford89/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-01T01:08:46Z","updated_at":"2016-03-01T22:25:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jonmak08/liferay-portal/pulls/1496","html_url":"https://github.com/jonmak08/liferay-portal/pull/1496","diff_url":"https://github.com/jonmak08/liferay-portal/pull/1496.diff","patch_url":"https://github.com/jonmak08/liferay-portal/pull/1496.patch"},"body":"Hey Jon,\r\n\r\nAttached is an update for https://issues.liferay.com/browse/LPS-63179.\r\n\r\nThis issue was happening when a JS file ended in a comment, like most of our Metal files do, and is minified and combo loaded.  The next file is stuck on the same line and is commented out, causing errors.\r\n\r\nPlease let me know if there are any issues.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/comments/190934400","html_url":"https://github.com/jonmak08/liferay-portal/pull/1496#issuecomment-190934400","issue_url":"https://api.github.com/repos/jonmak08/liferay-portal/issues/1496","id":190934400,"user":{"login":"mjbradford89","id":6517855,"avatar_url":"https://avatars.githubusercontent.com/u/6517855?v=3","gravatar_id":"","url":"https://api.github.com/users/mjbradford89","html_url":"https://github.com/mjbradford89","followers_url":"https://api.github.com/users/mjbradford89/followers","following_url":"https://api.github.com/users/mjbradford89/following{/other_user}","gists_url":"https://api.github.com/users/mjbradford89/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbradford89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbradford89/subscriptions","organizations_url":"https://api.github.com/users/mjbradford89/orgs","repos_url":"https://api.github.com/users/mjbradford89/repos","events_url":"https://api.github.com/users/mjbradford89/events{/privacy}","received_events_url":"https://api.github.com/users/mjbradford89/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T22:25:52Z","updated_at":"2016-03-01T22:25:52Z","body":"No comments other places don't cause an issue.  Only when it's the very last line of a file, because the next file will be put immediately after the comment.  so it usually ends up looking like \r\n> exports.default = array;\r\n});\r\n//# sourceMappingURL=array.js.mapdefine(\"frontend-js-metal-web@1.0.0/metal/src/async/async\""}}