{"action":"created","comment":{"url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments/68802751","id":68802751,"diff_hunk":"@@ -2,30 +2,31 @@ import { Component, ElementRef, EventEmitter, Optional } from '@angular/core'; /\n import { COMMON_DIRECTIVES, NgControl, NgModel } from '@angular/common';\n import { OutsideClick } from './../../utils/outside-click/OutsideClick';\n import { KeyCodes } from './../../utils/key-codes/KeyCodes';\n+import { NovoLabelService } from './../../novo-elements';\n \n @Component({\n     selector: 'novo-select',\n     directives: [COMMON_DIRECTIVES],\n-    inputs: ['options', 'placeholder', 'readonly', 'footerConfig'],\n+    inputs: ['options', 'placeholder', 'readonly', 'headerConfig'],\n     outputs: ['onSelect'],\n     template: `\n         <button (click)=\"toggleActive($event)\" tabIndex=\"-1\" type=\"button\" [ngClass]=\"{empty: empty}\">{{selected.label}}<i class=\"bhi-collapse\"></i></button>\n-        <ul class=\"novo-select-list\" tabIndex=\"-1\" [ngClass]=\"{footer: footerConfig}\">\n+        <ul class=\"novo-select-list\" tabIndex=\"-1\" [ngClass]=\"{header: headerConfig}\">\n             <ng-content></ng-content>\n+            <li *ngIf=\"headerConfig\" class=\"select-header\" [ngClass]=\"{open: header.open}\">\n+                <button  *ngIf=\"!header.open\" (click)=\"toggleHeader($event); false\" tabIndex=\"-1\" type=\"button\" class=\"header\"><i class=\"bhi-add-thin\"></i>&nbsp;{{headerConfig.label}}</button>\n+                <div *ngIf=\"header.open\" [ngClass]=\"{active: header.open}\">\n+                    <input autofocus type=\"text\" [placeholder]=\"headerConfig.placeholder\" [attr.id]=\"name\" autocomplete=\"false\" [(ngModel)]=\"header.value\" [ngClass]=\"{invalid: !header.valid}\"/>\n+                    <footer>\n+                        <button (click)=\"toggleHeader($event, false)\">{{labels.selectHeaderCancel}}</button>\n+                        <button (click)=\"saveHeader()\" class=\"primary\">{{labels.selectHeaderSave}}</button>","path":"src/elements/select/Select.js","position":23,"original_position":23,"commit_id":"237dd2e21450824bdee1b227d858703026ea096c","original_commit_id":"237dd2e21450824bdee1b227d858703026ea096c","user":{"login":"jgodi","id":870799,"avatar_url":"https://avatars.githubusercontent.com/u/870799?v=3","gravatar_id":"","url":"https://api.github.com/users/jgodi","html_url":"https://github.com/jgodi","followers_url":"https://api.github.com/users/jgodi/followers","following_url":"https://api.github.com/users/jgodi/following{/other_user}","gists_url":"https://api.github.com/users/jgodi/gists{/gist_id}","starred_url":"https://api.github.com/users/jgodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgodi/subscriptions","organizations_url":"https://api.github.com/users/jgodi/orgs","repos_url":"https://api.github.com/users/jgodi/repos","events_url":"https://api.github.com/users/jgodi/events{/privacy}","received_events_url":"https://api.github.com/users/jgodi/received_events","type":"User","site_admin":false},"body":"save/cancel?","created_at":"2016-06-28T17:25:42Z","updated_at":"2016-06-28T17:25:42Z","html_url":"https://github.com/bullhorn/novo-elements/pull/78#discussion_r68802751","pull_request_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments/68802751"},"html":{"href":"https://github.com/bullhorn/novo-elements/pull/78#discussion_r68802751"},"pull_request":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78","id":75193759,"html_url":"https://github.com/bullhorn/novo-elements/pull/78","diff_url":"https://github.com/bullhorn/novo-elements/pull/78.diff","patch_url":"https://github.com/bullhorn/novo-elements/pull/78.patch","issue_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/78","number":78,"state":"open","locked":false,"title":"fix(Select) : Clean up select footer, convert to header for UX/ease-o…","user":{"login":"escarre","id":7002678,"avatar_url":"https://avatars.githubusercontent.com/u/7002678?v=3","gravatar_id":"","url":"https://api.github.com/users/escarre","html_url":"https://github.com/escarre","followers_url":"https://api.github.com/users/escarre/followers","following_url":"https://api.github.com/users/escarre/following{/other_user}","gists_url":"https://api.github.com/users/escarre/gists{/gist_id}","starred_url":"https://api.github.com/users/escarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escarre/subscriptions","organizations_url":"https://api.github.com/users/escarre/orgs","repos_url":"https://api.github.com/users/escarre/repos","events_url":"https://api.github.com/users/escarre/events{/privacy}","received_events_url":"https://api.github.com/users/escarre/received_events","type":"User","site_admin":false},"body":"This PR makes changes requested in Issue #72 . It also moves the footer from the base of the select list to the top - with the possibility of a long list, a user might not scroll to the bottom or be aware of the 'Add New Item' capability. \r\n\r\n##### **What did you change?**\r\n- footerConfig has been renamed to headerConfig\r\n- header is an li not a div\r\n- left aligns '+ Add New Item' with other li items\r\n- repositions as a header to solve other UX issues\r\n\r\n##### **Reviewers**\r\n@jgodi \r\n\r\n##### **Checklist (completed via merger)**\r\n* [ ] Changes are limited to a single goal (no scope creep)\r\n* [ ] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [contributing guide](https://github.com/bullhorn/novo-elements/blob/master/CONTRIBUTING.md)\r\n* [ ] Passes all existing automated tests\r\n* [ ] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Visually tested in supported browsers and devices\r\n…f-use\r\n\r\nFix issue #72.\r\n\r\nBreaking Changes: Renames Select footerConfig to Select headerConfig","created_at":"2016-06-25T02:47:08Z","updated_at":"2016-06-28T17:25:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbcf3b066905333479fc7d1810b6ed4bd2e301d8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78/commits","review_comments_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78/comments","review_comment_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/78/comments","statuses_url":"https://api.github.com/repos/bullhorn/novo-elements/statuses/237dd2e21450824bdee1b227d858703026ea096c","head":{"label":"escarre:bug/select-footer","ref":"bug/select-footer","sha":"237dd2e21450824bdee1b227d858703026ea096c","user":{"login":"escarre","id":7002678,"avatar_url":"https://avatars.githubusercontent.com/u/7002678?v=3","gravatar_id":"","url":"https://api.github.com/users/escarre","html_url":"https://github.com/escarre","followers_url":"https://api.github.com/users/escarre/followers","following_url":"https://api.github.com/users/escarre/following{/other_user}","gists_url":"https://api.github.com/users/escarre/gists{/gist_id}","starred_url":"https://api.github.com/users/escarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escarre/subscriptions","organizations_url":"https://api.github.com/users/escarre/orgs","repos_url":"https://api.github.com/users/escarre/repos","events_url":"https://api.github.com/users/escarre/events{/privacy}","received_events_url":"https://api.github.com/users/escarre/received_events","type":"User","site_admin":false},"repo":{"id":61244010,"name":"novo-elements","full_name":"escarre/novo-elements","owner":{"login":"escarre","id":7002678,"avatar_url":"https://avatars.githubusercontent.com/u/7002678?v=3","gravatar_id":"","url":"https://api.github.com/users/escarre","html_url":"https://github.com/escarre","followers_url":"https://api.github.com/users/escarre/followers","following_url":"https://api.github.com/users/escarre/following{/other_user}","gists_url":"https://api.github.com/users/escarre/gists{/gist_id}","starred_url":"https://api.github.com/users/escarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escarre/subscriptions","organizations_url":"https://api.github.com/users/escarre/orgs","repos_url":"https://api.github.com/users/escarre/repos","events_url":"https://api.github.com/users/escarre/events{/privacy}","received_events_url":"https://api.github.com/users/escarre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/escarre/novo-elements","description":"UI Repository for Bullhorn's Novo Theme","fork":true,"url":"https://api.github.com/repos/escarre/novo-elements","forks_url":"https://api.github.com/repos/escarre/novo-elements/forks","keys_url":"https://api.github.com/repos/escarre/novo-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/escarre/novo-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/escarre/novo-elements/teams","hooks_url":"https://api.github.com/repos/escarre/novo-elements/hooks","issue_events_url":"https://api.github.com/repos/escarre/novo-elements/issues/events{/number}","events_url":"https://api.github.com/repos/escarre/novo-elements/events","assignees_url":"https://api.github.com/repos/escarre/novo-elements/assignees{/user}","branches_url":"https://api.github.com/repos/escarre/novo-elements/branches{/branch}","tags_url":"https://api.github.com/repos/escarre/novo-elements/tags","blobs_url":"https://api.github.com/repos/escarre/novo-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/escarre/novo-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/escarre/novo-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/escarre/novo-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/escarre/novo-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/escarre/novo-elements/languages","stargazers_url":"https://api.github.com/repos/escarre/novo-elements/stargazers","contributors_url":"https://api.github.com/repos/escarre/novo-elements/contributors","subscribers_url":"https://api.github.com/repos/escarre/novo-elements/subscribers","subscription_url":"https://api.github.com/repos/escarre/novo-elements/subscription","commits_url":"https://api.github.com/repos/escarre/novo-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/escarre/novo-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/escarre/novo-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/escarre/novo-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/escarre/novo-elements/contents/{+path}","compare_url":"https://api.github.com/repos/escarre/novo-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/escarre/novo-elements/merges","archive_url":"https://api.github.com/repos/escarre/novo-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/escarre/novo-elements/downloads","issues_url":"https://api.github.com/repos/escarre/novo-elements/issues{/number}","pulls_url":"https://api.github.com/repos/escarre/novo-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/escarre/novo-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/escarre/novo-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/escarre/novo-elements/labels{/name}","releases_url":"https://api.github.com/repos/escarre/novo-elements/releases{/id}","deployments_url":"https://api.github.com/repos/escarre/novo-elements/deployments","created_at":"2016-06-15T21:59:58Z","updated_at":"2016-06-15T21:59:59Z","pushed_at":"2016-06-28T14:42:43Z","git_url":"git://github.com/escarre/novo-elements.git","ssh_url":"git@github.com:escarre/novo-elements.git","clone_url":"https://github.com/escarre/novo-elements.git","svn_url":"https://github.com/escarre/novo-elements","homepage":"http://bullhorn.github.io/novo-elements","size":52395,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bullhorn:master","ref":"master","sha":"32a88684f048ef87d47ac80db2bbb14744b8c73a","user":{"login":"bullhorn","id":4107582,"avatar_url":"https://avatars.githubusercontent.com/u/4107582?v=3","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"repo":{"id":56453136,"name":"novo-elements","full_name":"bullhorn/novo-elements","owner":{"login":"bullhorn","id":4107582,"avatar_url":"https://avatars.githubusercontent.com/u/4107582?v=3","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bullhorn/novo-elements","description":"UI Repository for Bullhorn's Novo Theme","fork":false,"url":"https://api.github.com/repos/bullhorn/novo-elements","forks_url":"https://api.github.com/repos/bullhorn/novo-elements/forks","keys_url":"https://api.github.com/repos/bullhorn/novo-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bullhorn/novo-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bullhorn/novo-elements/teams","hooks_url":"https://api.github.com/repos/bullhorn/novo-elements/hooks","issue_events_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/events{/number}","events_url":"https://api.github.com/repos/bullhorn/novo-elements/events","assignees_url":"https://api.github.com/repos/bullhorn/novo-elements/assignees{/user}","branches_url":"https://api.github.com/repos/bullhorn/novo-elements/branches{/branch}","tags_url":"https://api.github.com/repos/bullhorn/novo-elements/tags","blobs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bullhorn/novo-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/bullhorn/novo-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bullhorn/novo-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/bullhorn/novo-elements/languages","stargazers_url":"https://api.github.com/repos/bullhorn/novo-elements/stargazers","contributors_url":"https://api.github.com/repos/bullhorn/novo-elements/contributors","subscribers_url":"https://api.github.com/repos/bullhorn/novo-elements/subscribers","subscription_url":"https://api.github.com/repos/bullhorn/novo-elements/subscription","commits_url":"https://api.github.com/repos/bullhorn/novo-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/bullhorn/novo-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/bullhorn/novo-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/bullhorn/novo-elements/contents/{+path}","compare_url":"https://api.github.com/repos/bullhorn/novo-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bullhorn/novo-elements/merges","archive_url":"https://api.github.com/repos/bullhorn/novo-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bullhorn/novo-elements/downloads","issues_url":"https://api.github.com/repos/bullhorn/novo-elements/issues{/number}","pulls_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/bullhorn/novo-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/bullhorn/novo-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bullhorn/novo-elements/labels{/name}","releases_url":"https://api.github.com/repos/bullhorn/novo-elements/releases{/id}","deployments_url":"https://api.github.com/repos/bullhorn/novo-elements/deployments","created_at":"2016-04-17T19:00:11Z","updated_at":"2016-06-17T13:51:23Z","pushed_at":"2016-06-28T14:42:43Z","git_url":"git://github.com/bullhorn/novo-elements.git","ssh_url":"git@github.com:bullhorn/novo-elements.git","clone_url":"https://github.com/bullhorn/novo-elements.git","svn_url":"https://github.com/bullhorn/novo-elements","homepage":"http://bullhorn.github.io/novo-elements","size":63316,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78"},"html":{"href":"https://github.com/bullhorn/novo-elements/pull/78"},"issue":{"href":"https://api.github.com/repos/bullhorn/novo-elements/issues/78"},"comments":{"href":"https://api.github.com/repos/bullhorn/novo-elements/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/bullhorn/novo-elements/statuses/237dd2e21450824bdee1b227d858703026ea096c"}}}}
{"actor":{"display_login":"jgodi"}}