{"action":"closed","number":147,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/147","id":66928232,"html_url":"https://github.com/puppetlabs/puppetlabs_spec_helper/pull/147","diff_url":"https://github.com/puppetlabs/puppetlabs_spec_helper/pull/147.diff","patch_url":"https://github.com/puppetlabs/puppetlabs_spec_helper/pull/147.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/issues/147","number":147,"state":"closed","locked":false,"title":"Remove RuboCop to fix spec testing on Ruby 1.8","user":{"login":"leoarnold","id":4201235,"avatar_url":"https://avatars.githubusercontent.com/u/4201235?v=3","gravatar_id":"","url":"https://api.github.com/users/leoarnold","html_url":"https://github.com/leoarnold","followers_url":"https://api.github.com/users/leoarnold/followers","following_url":"https://api.github.com/users/leoarnold/following{/other_user}","gists_url":"https://api.github.com/users/leoarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/leoarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoarnold/subscriptions","organizations_url":"https://api.github.com/users/leoarnold/orgs","repos_url":"https://api.github.com/users/leoarnold/repos","events_url":"https://api.github.com/users/leoarnold/events{/privacy}","received_events_url":"https://api.github.com/users/leoarnold/received_events","type":"User","site_admin":false},"body":"Ruby 1.8 is deprecated, but is still supported by PE 3.8 which is still maintained.\r\nAs @alexjfisher pointed out in the discussion following up the merge of PR #140,\r\nRuboCop (or at least one of its dependencies) is not compatible with Ruby 1.8.\r\nHence spec testing on Ruby 1.8 will break because `bundle install` fails.\r\n\r\nSince the GemSpec is generated with Jeweler which does not support different\r\ngem dependencies for different Ruby versions, I suggest remove RuboCop for the moment.","created_at":"2016-04-18T21:51:32Z","updated_at":"2016-06-13T11:42:41Z","closed_at":"2016-06-13T11:42:41Z","merged_at":null,"merge_commit_sha":"37a24e00beca99c744ead0099009659d1e4585f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/147/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/147/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/issues/147/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/statuses/b4c55ab945bb612d649ac714871da971df973576","head":{"label":"leoarnold:add_rubocop","ref":"add_rubocop","sha":"b4c55ab945bb612d649ac714871da971df973576","user":{"login":"leoarnold","id":4201235,"avatar_url":"https://avatars.githubusercontent.com/u/4201235?v=3","gravatar_id":"","url":"https://api.github.com/users/leoarnold","html_url":"https://github.com/leoarnold","followers_url":"https://api.github.com/users/leoarnold/followers","following_url":"https://api.github.com/users/leoarnold/following{/other_user}","gists_url":"https://api.github.com/users/leoarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/leoarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoarnold/subscriptions","organizations_url":"https://api.github.com/users/leoarnold/orgs","repos_url":"https://api.github.com/users/leoarnold/repos","events_url":"https://api.github.com/users/leoarnold/events{/privacy}","received_events_url":"https://api.github.com/users/leoarnold/received_events","type":"User","site_admin":false},"repo":{"id":53506112,"name":"puppetlabs_spec_helper","full_name":"leoarnold/puppetlabs_spec_helper","owner":{"login":"leoarnold","id":4201235,"avatar_url":"https://avatars.githubusercontent.com/u/4201235?v=3","gravatar_id":"","url":"https://api.github.com/users/leoarnold","html_url":"https://github.com/leoarnold","followers_url":"https://api.github.com/users/leoarnold/followers","following_url":"https://api.github.com/users/leoarnold/following{/other_user}","gists_url":"https://api.github.com/users/leoarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/leoarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoarnold/subscriptions","organizations_url":"https://api.github.com/users/leoarnold/orgs","repos_url":"https://api.github.com/users/leoarnold/repos","events_url":"https://api.github.com/users/leoarnold/events{/privacy}","received_events_url":"https://api.github.com/users/leoarnold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leoarnold/puppetlabs_spec_helper","description":"A set of shared spec helpers specific to Puppetlabs projects","fork":true,"url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper","forks_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/forks","keys_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/teams","hooks_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/hooks","issue_events_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/issues/events{/number}","events_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/events","assignees_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/assignees{/user}","branches_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/branches{/branch}","tags_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/tags","blobs_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/statuses/{sha}","languages_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/languages","stargazers_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/stargazers","contributors_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/contributors","subscribers_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/subscribers","subscription_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/subscription","commits_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/contents/{+path}","compare_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/merges","archive_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/downloads","issues_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/issues{/number}","pulls_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/pulls{/number}","milestones_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/milestones{/number}","notifications_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/labels{/name}","releases_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/releases{/id}","deployments_url":"https://api.github.com/repos/leoarnold/puppetlabs_spec_helper/deployments","created_at":"2016-03-09T14:55:34Z","updated_at":"2016-03-09T14:55:35Z","pushed_at":"2016-04-18T21:50:33Z","git_url":"git://github.com/leoarnold/puppetlabs_spec_helper.git","ssh_url":"git@github.com:leoarnold/puppetlabs_spec_helper.git","clone_url":"https://github.com/leoarnold/puppetlabs_spec_helper.git","svn_url":"https://github.com/leoarnold/puppetlabs_spec_helper","homepage":"","size":219,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"e9df51ee8d96ae41f09c8214028026b1c2bcd7ea","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":3037349,"name":"puppetlabs_spec_helper","full_name":"puppetlabs/puppetlabs_spec_helper","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs_spec_helper","description":"A set of shared spec helpers specific to Puppetlabs projects","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/deployments","created_at":"2011-12-22T23:35:46Z","updated_at":"2016-05-27T17:17:07Z","pushed_at":"2016-06-13T09:53:50Z","git_url":"git://github.com/puppetlabs/puppetlabs_spec_helper.git","ssh_url":"git@github.com:puppetlabs/puppetlabs_spec_helper.git","clone_url":"https://github.com/puppetlabs/puppetlabs_spec_helper.git","svn_url":"https://github.com/puppetlabs/puppetlabs_spec_helper","homepage":"","size":298,"stargazers_count":99,"watchers_count":99,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":10,"forks":98,"open_issues":10,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/147"},"html":{"href":"https://github.com/puppetlabs/puppetlabs_spec_helper/pull/147"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/issues/147"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs_spec_helper/statuses/b4c55ab945bb612d649ac714871da971df973576"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":5,"deletions":13,"changed_files":4}}
{"actor":{"display_login":"leoarnold"}}