{"action":"created","comment":{"url":"https://api.github.com/repos/slamdata/slamdata/pulls/comments/83697596","pull_request_review_id":4524403,"id":83697596,"diff_hunk":"@@ -163,32 +165,27 @@ buildFunnel r records = do\n   legendNames ∷ Array String\n   legendNames =\n     A.fromFoldable\n-      $ foldMap (_.name ⋙ foldMap Set.singleton) funnelData\n-\n-  titles ∷ Array (DSL ETP.TitleI)\n-  titles = funnelData <#> \\{name, x, y} → do\n-    for_ name E.text\n-    E.textStyle do\n-      E.fontFamily \"Ubunut, sans\"\n-      E.fontSize 12\n-    traverse_ (E.top ∘ ET.Percent) y\n-    traverse_ (E.left ∘ ET.Percent) x\n-    E.textCenter\n-    E.textBottom\n+      $ foldMap (_.items ⋙ M.keys ⋙ Set.fromFoldable) funnelData\n \n   series ∷ ∀ i. DSL (funnel ∷ ETP.I|i)\n-  series = for_ funnelData \\{x, y, w, h, items, name} → E.funnel do\n+  series = for_ funnelData \\{x, y, w, h, items, name: serieName} → E.funnel do\n     traverse_ E.widthPct w\n     traverse_ E.heightPct h\n-    for_ name E.name\n+    for_ serieName E.name\n     case r.order of\n       Asc → E.ascending\n       Desc → E.descending\n     case r.align of\n       LeftAlign → E.funnelLeft\n       RightAlign → E.funnelRight\n       CenterAlign → E.funnelCenter\n-    E.label $ E.normal $ E.textStyle $ E.fontFamily \"Ubuntu, sans\"\n+    E.label do\n+      E.normal do\n+        E.textStyle $ E.fontFamily \"Ubuntu, sans\"","path":"src/SlamData/Workspace/Card/BuildChart/Funnel/Eval.purs","position":78,"original_position":78,"commit_id":"3fd6782254f944a7fb3b5d13314e3b169776df0c","original_commit_id":"3fd6782254f944a7fb3b5d13314e3b169776df0c","user":{"login":"cryogenian","id":10245930,"avatar_url":"https://avatars.githubusercontent.com/u/10245930?v=3","gravatar_id":"","url":"https://api.github.com/users/cryogenian","html_url":"https://github.com/cryogenian","followers_url":"https://api.github.com/users/cryogenian/followers","following_url":"https://api.github.com/users/cryogenian/following{/other_user}","gists_url":"https://api.github.com/users/cryogenian/gists{/gist_id}","starred_url":"https://api.github.com/users/cryogenian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryogenian/subscriptions","organizations_url":"https://api.github.com/users/cryogenian/orgs","repos_url":"https://api.github.com/users/cryogenian/repos","events_url":"https://api.github.com/users/cryogenian/events{/privacy}","received_events_url":"https://api.github.com/users/cryogenian/received_events","type":"User","site_admin":false},"body":"I agree, there are definitely lots of comands that could be moved to common builders. Maybe it should be fixed in #926? Or you prefer me adding it in this pr?  ","created_at":"2016-10-17T17:53:10Z","updated_at":"2016-10-17T17:53:10Z","html_url":"https://github.com/slamdata/slamdata/pull/1134#discussion_r83697596","pull_request_url":"https://api.github.com/repos/slamdata/slamdata/pulls/1134","_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/comments/83697596"},"html":{"href":"https://github.com/slamdata/slamdata/pull/1134#discussion_r83697596"},"pull_request":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/1134"}}},"pull_request":{"url":"https://api.github.com/repos/slamdata/slamdata/pulls/1134","id":89669044,"html_url":"https://github.com/slamdata/slamdata/pull/1134","diff_url":"https://github.com/slamdata/slamdata/pull/1134.diff","patch_url":"https://github.com/slamdata/slamdata/pull/1134.patch","issue_url":"https://api.github.com/repos/slamdata/slamdata/issues/1134","number":1134,"state":"open","locked":false,"title":"Couple chart fixes","user":{"login":"cryogenian","id":10245930,"avatar_url":"https://avatars.githubusercontent.com/u/10245930?v=3","gravatar_id":"","url":"https://api.github.com/users/cryogenian","html_url":"https://github.com/cryogenian","followers_url":"https://api.github.com/users/cryogenian/followers","following_url":"https://api.github.com/users/cryogenian/following{/other_user}","gists_url":"https://api.github.com/users/cryogenian/gists{/gist_id}","starred_url":"https://api.github.com/users/cryogenian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryogenian/subscriptions","organizations_url":"https://api.github.com/users/cryogenian/orgs","repos_url":"https://api.github.com/users/cryogenian/repos","events_url":"https://api.github.com/users/cryogenian/events{/privacy}","received_events_url":"https://api.github.com/users/cryogenian/received_events","type":"User","site_admin":false},"body":"I've checked all configuration for my test data and it seems that with this fix it works at least not so bad. \r\n\r\n\r\n+ Axes in area chart are black now \r\n+ Funnel chart fixed\r\n+ Radar titles don't overlap with labels anymore. \r\n\r\n@natefaubion Please review","created_at":"2016-10-17T17:41:04Z","updated_at":"2016-10-17T17:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e82e25a5afbe1937e524a73b0a797169a6db0a3c","assignee":{"login":"natefaubion","id":144058,"avatar_url":"https://avatars.githubusercontent.com/u/144058?v=3","gravatar_id":"","url":"https://api.github.com/users/natefaubion","html_url":"https://github.com/natefaubion","followers_url":"https://api.github.com/users/natefaubion/followers","following_url":"https://api.github.com/users/natefaubion/following{/other_user}","gists_url":"https://api.github.com/users/natefaubion/gists{/gist_id}","starred_url":"https://api.github.com/users/natefaubion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefaubion/subscriptions","organizations_url":"https://api.github.com/users/natefaubion/orgs","repos_url":"https://api.github.com/users/natefaubion/repos","events_url":"https://api.github.com/users/natefaubion/events{/privacy}","received_events_url":"https://api.github.com/users/natefaubion/received_events","type":"User","site_admin":false},"assignees":[{"login":"natefaubion","id":144058,"avatar_url":"https://avatars.githubusercontent.com/u/144058?v=3","gravatar_id":"","url":"https://api.github.com/users/natefaubion","html_url":"https://github.com/natefaubion","followers_url":"https://api.github.com/users/natefaubion/followers","following_url":"https://api.github.com/users/natefaubion/following{/other_user}","gists_url":"https://api.github.com/users/natefaubion/gists{/gist_id}","starred_url":"https://api.github.com/users/natefaubion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefaubion/subscriptions","organizations_url":"https://api.github.com/users/natefaubion/orgs","repos_url":"https://api.github.com/users/natefaubion/repos","events_url":"https://api.github.com/users/natefaubion/events{/privacy}","received_events_url":"https://api.github.com/users/natefaubion/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/slamdata/slamdata/pulls/1134/commits","review_comments_url":"https://api.github.com/repos/slamdata/slamdata/pulls/1134/comments","review_comment_url":"https://api.github.com/repos/slamdata/slamdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slamdata/slamdata/issues/1134/comments","statuses_url":"https://api.github.com/repos/slamdata/slamdata/statuses/3fd6782254f944a7fb3b5d13314e3b169776df0c","head":{"label":"cryogenian:funnel-fix","ref":"funnel-fix","sha":"3fd6782254f944a7fb3b5d13314e3b169776df0c","user":{"login":"cryogenian","id":10245930,"avatar_url":"https://avatars.githubusercontent.com/u/10245930?v=3","gravatar_id":"","url":"https://api.github.com/users/cryogenian","html_url":"https://github.com/cryogenian","followers_url":"https://api.github.com/users/cryogenian/followers","following_url":"https://api.github.com/users/cryogenian/following{/other_user}","gists_url":"https://api.github.com/users/cryogenian/gists{/gist_id}","starred_url":"https://api.github.com/users/cryogenian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryogenian/subscriptions","organizations_url":"https://api.github.com/users/cryogenian/orgs","repos_url":"https://api.github.com/users/cryogenian/repos","events_url":"https://api.github.com/users/cryogenian/events{/privacy}","received_events_url":"https://api.github.com/users/cryogenian/received_events","type":"User","site_admin":false},"repo":{"id":30622455,"name":"slamdata","full_name":"cryogenian/slamdata","owner":{"login":"cryogenian","id":10245930,"avatar_url":"https://avatars.githubusercontent.com/u/10245930?v=3","gravatar_id":"","url":"https://api.github.com/users/cryogenian","html_url":"https://github.com/cryogenian","followers_url":"https://api.github.com/users/cryogenian/followers","following_url":"https://api.github.com/users/cryogenian/following{/other_user}","gists_url":"https://api.github.com/users/cryogenian/gists{/gist_id}","starred_url":"https://api.github.com/users/cryogenian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryogenian/subscriptions","organizations_url":"https://api.github.com/users/cryogenian/orgs","repos_url":"https://api.github.com/users/cryogenian/repos","events_url":"https://api.github.com/users/cryogenian/events{/privacy}","received_events_url":"https://api.github.com/users/cryogenian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cryogenian/slamdata","description":"The web-based front-end for SlamData.","fork":true,"url":"https://api.github.com/repos/cryogenian/slamdata","forks_url":"https://api.github.com/repos/cryogenian/slamdata/forks","keys_url":"https://api.github.com/repos/cryogenian/slamdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cryogenian/slamdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cryogenian/slamdata/teams","hooks_url":"https://api.github.com/repos/cryogenian/slamdata/hooks","issue_events_url":"https://api.github.com/repos/cryogenian/slamdata/issues/events{/number}","events_url":"https://api.github.com/repos/cryogenian/slamdata/events","assignees_url":"https://api.github.com/repos/cryogenian/slamdata/assignees{/user}","branches_url":"https://api.github.com/repos/cryogenian/slamdata/branches{/branch}","tags_url":"https://api.github.com/repos/cryogenian/slamdata/tags","blobs_url":"https://api.github.com/repos/cryogenian/slamdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cryogenian/slamdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cryogenian/slamdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/cryogenian/slamdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cryogenian/slamdata/statuses/{sha}","languages_url":"https://api.github.com/repos/cryogenian/slamdata/languages","stargazers_url":"https://api.github.com/repos/cryogenian/slamdata/stargazers","contributors_url":"https://api.github.com/repos/cryogenian/slamdata/contributors","subscribers_url":"https://api.github.com/repos/cryogenian/slamdata/subscribers","subscription_url":"https://api.github.com/repos/cryogenian/slamdata/subscription","commits_url":"https://api.github.com/repos/cryogenian/slamdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/cryogenian/slamdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/cryogenian/slamdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/cryogenian/slamdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/cryogenian/slamdata/contents/{+path}","compare_url":"https://api.github.com/repos/cryogenian/slamdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cryogenian/slamdata/merges","archive_url":"https://api.github.com/repos/cryogenian/slamdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cryogenian/slamdata/downloads","issues_url":"https://api.github.com/repos/cryogenian/slamdata/issues{/number}","pulls_url":"https://api.github.com/repos/cryogenian/slamdata/pulls{/number}","milestones_url":"https://api.github.com/repos/cryogenian/slamdata/milestones{/number}","notifications_url":"https://api.github.com/repos/cryogenian/slamdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cryogenian/slamdata/labels{/name}","releases_url":"https://api.github.com/repos/cryogenian/slamdata/releases{/id}","deployments_url":"https://api.github.com/repos/cryogenian/slamdata/deployments","created_at":"2015-02-11T00:36:12Z","updated_at":"2015-07-22T14:28:43Z","pushed_at":"2016-10-17T17:36:17Z","git_url":"git://github.com/cryogenian/slamdata.git","ssh_url":"git@github.com:cryogenian/slamdata.git","clone_url":"https://github.com/cryogenian/slamdata.git","svn_url":"https://github.com/cryogenian/slamdata","homepage":null,"size":349377,"stargazers_count":0,"watchers_count":0,"language":"PureScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"slamdata:master","ref":"master","sha":"8193231ce5ed184bb77f443a129b539928b36f79","user":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"repo":{"id":30566154,"name":"slamdata","full_name":"slamdata/slamdata","owner":{"login":"slamdata","id":5385602,"avatar_url":"https://avatars.githubusercontent.com/u/5385602?v=3","gravatar_id":"","url":"https://api.github.com/users/slamdata","html_url":"https://github.com/slamdata","followers_url":"https://api.github.com/users/slamdata/followers","following_url":"https://api.github.com/users/slamdata/following{/other_user}","gists_url":"https://api.github.com/users/slamdata/gists{/gist_id}","starred_url":"https://api.github.com/users/slamdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slamdata/subscriptions","organizations_url":"https://api.github.com/users/slamdata/orgs","repos_url":"https://api.github.com/users/slamdata/repos","events_url":"https://api.github.com/users/slamdata/events{/privacy}","received_events_url":"https://api.github.com/users/slamdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slamdata/slamdata","description":"The web-based front-end for SlamData.","fork":false,"url":"https://api.github.com/repos/slamdata/slamdata","forks_url":"https://api.github.com/repos/slamdata/slamdata/forks","keys_url":"https://api.github.com/repos/slamdata/slamdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slamdata/slamdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slamdata/slamdata/teams","hooks_url":"https://api.github.com/repos/slamdata/slamdata/hooks","issue_events_url":"https://api.github.com/repos/slamdata/slamdata/issues/events{/number}","events_url":"https://api.github.com/repos/slamdata/slamdata/events","assignees_url":"https://api.github.com/repos/slamdata/slamdata/assignees{/user}","branches_url":"https://api.github.com/repos/slamdata/slamdata/branches{/branch}","tags_url":"https://api.github.com/repos/slamdata/slamdata/tags","blobs_url":"https://api.github.com/repos/slamdata/slamdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slamdata/slamdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slamdata/slamdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/slamdata/slamdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slamdata/slamdata/statuses/{sha}","languages_url":"https://api.github.com/repos/slamdata/slamdata/languages","stargazers_url":"https://api.github.com/repos/slamdata/slamdata/stargazers","contributors_url":"https://api.github.com/repos/slamdata/slamdata/contributors","subscribers_url":"https://api.github.com/repos/slamdata/slamdata/subscribers","subscription_url":"https://api.github.com/repos/slamdata/slamdata/subscription","commits_url":"https://api.github.com/repos/slamdata/slamdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/slamdata/slamdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/slamdata/slamdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/slamdata/slamdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/slamdata/slamdata/contents/{+path}","compare_url":"https://api.github.com/repos/slamdata/slamdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slamdata/slamdata/merges","archive_url":"https://api.github.com/repos/slamdata/slamdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slamdata/slamdata/downloads","issues_url":"https://api.github.com/repos/slamdata/slamdata/issues{/number}","pulls_url":"https://api.github.com/repos/slamdata/slamdata/pulls{/number}","milestones_url":"https://api.github.com/repos/slamdata/slamdata/milestones{/number}","notifications_url":"https://api.github.com/repos/slamdata/slamdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slamdata/slamdata/labels{/name}","releases_url":"https://api.github.com/repos/slamdata/slamdata/releases{/id}","deployments_url":"https://api.github.com/repos/slamdata/slamdata/deployments","created_at":"2015-02-10T00:14:37Z","updated_at":"2016-10-14T21:46:31Z","pushed_at":"2016-10-17T17:41:04Z","git_url":"git://github.com/slamdata/slamdata.git","ssh_url":"git@github.com:slamdata/slamdata.git","clone_url":"https://github.com/slamdata/slamdata.git","svn_url":"https://github.com/slamdata/slamdata","homepage":null,"size":362019,"stargazers_count":172,"watchers_count":172,"language":"PureScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":41,"forks":40,"open_issues":41,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/1134"},"html":{"href":"https://github.com/slamdata/slamdata/pull/1134"},"issue":{"href":"https://api.github.com/repos/slamdata/slamdata/issues/1134"},"comments":{"href":"https://api.github.com/repos/slamdata/slamdata/issues/1134/comments"},"review_comments":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/1134/comments"},"review_comment":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slamdata/slamdata/pulls/1134/commits"},"statuses":{"href":"https://api.github.com/repos/slamdata/slamdata/statuses/3fd6782254f944a7fb3b5d13314e3b169776df0c"}}}}
{"actor":{"display_login":"cryogenian"}}