{"action":"created","comment":{"url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/comments/82491424","pull_request_review_id":3398284,"id":82491424,"diff_hunk":"@@ -80,24 +83,24 @@ def number_of_016_files(self):\n \n         return elm_016_count\n \n-    def get_files_for_017(self, pattern):\n+    def get_files_for_017(self, pattern: str) -> List[str]:\n         pattern = pattern.replace('.', '/')\n         all_files = glob.glob(f'{self.repo_dir}/**/{pattern}.elm', recursive=True)\n \n-        return [ file for file in all_files\n-            if self.what_kinda_file(file) == ELM_017_FILE\n+        return [ filename for filename in all_files","path":"our_repo.py","position":62,"original_position":62,"commit_id":"edfe7c23cccf021e71c680175f7031b3564f2401","original_commit_id":"edfe7c23cccf021e71c680175f7031b3564f2401","user":{"login":"ento","id":21108,"avatar_url":"https://avatars.githubusercontent.com/u/21108?v=3","gravatar_id":"","url":"https://api.github.com/users/ento","html_url":"https://github.com/ento","followers_url":"https://api.github.com/users/ento/followers","following_url":"https://api.github.com/users/ento/following{/other_user}","gists_url":"https://api.github.com/users/ento/gists{/gist_id}","starred_url":"https://api.github.com/users/ento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ento/subscriptions","organizations_url":"https://api.github.com/users/ento/orgs","repos_url":"https://api.github.com/users/ento/repos","events_url":"https://api.github.com/users/ento/events{/privacy}","received_events_url":"https://api.github.com/users/ento/received_events","type":"User","site_admin":false},"body":"😻 ","created_at":"2016-10-08T01:05:00Z","updated_at":"2016-10-08T01:44:09Z","html_url":"https://github.com/NoRedInk/slack-today-i-did/pull/6#discussion_r82491424","pull_request_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/comments/82491424"},"html":{"href":"https://github.com/NoRedInk/slack-today-i-did/pull/6#discussion_r82491424"},"pull_request":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6","id":87955179,"html_url":"https://github.com/NoRedInk/slack-today-i-did/pull/6","diff_url":"https://github.com/NoRedInk/slack-today-i-did/pull/6.diff","patch_url":"https://github.com/NoRedInk/slack-today-i-did/pull/6.patch","issue_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/6","number":6,"state":"open","locked":false,"title":"code review cleanups","user":{"login":"eeue56","id":1139198,"avatar_url":"https://avatars.githubusercontent.com/u/1139198?v=3","gravatar_id":"","url":"https://api.github.com/users/eeue56","html_url":"https://github.com/eeue56","followers_url":"https://api.github.com/users/eeue56/followers","following_url":"https://api.github.com/users/eeue56/following{/other_user}","gists_url":"https://api.github.com/users/eeue56/gists{/gist_id}","starred_url":"https://api.github.com/users/eeue56/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeue56/subscriptions","organizations_url":"https://api.github.com/users/eeue56/orgs","repos_url":"https://api.github.com/users/eeue56/repos","events_url":"https://api.github.com/users/eeue56/events{/privacy}","received_events_url":"https://api.github.com/users/eeue56/received_events","type":"User","site_admin":false},"body":"Various code review cleanups from Marica's reviews. \r\n\r\n\r\nDiscovered some design patterns I want to fix outside of this PR:\r\n\r\n1) functions and statements should return something like `ChannelMessage`. Basically, no user-defined function should really be called `self.send_channel_message` - instead, it should just return things and whatever it returns gets sent. This will help reduce multiple payloads and make point 2 easier to implement\r\n2) All functions should return things to the channel for the channel to use (e.g `NOW` should send the current time to the slack channel)\r\n3) It should be way easier to manipulate the main parse loop. I've done this before via `register_step : (a -> M b) -> M a -> M b`, basically a function that is injected into the main parse loop and can manipulate ","created_at":"2016-10-04T19:10:34Z","updated_at":"2016-10-08T01:44:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1675c43c44682cc2bc9d55ab203b692818b240e5","assignee":{"login":"ento","id":21108,"avatar_url":"https://avatars.githubusercontent.com/u/21108?v=3","gravatar_id":"","url":"https://api.github.com/users/ento","html_url":"https://github.com/ento","followers_url":"https://api.github.com/users/ento/followers","following_url":"https://api.github.com/users/ento/following{/other_user}","gists_url":"https://api.github.com/users/ento/gists{/gist_id}","starred_url":"https://api.github.com/users/ento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ento/subscriptions","organizations_url":"https://api.github.com/users/ento/orgs","repos_url":"https://api.github.com/users/ento/repos","events_url":"https://api.github.com/users/ento/events{/privacy}","received_events_url":"https://api.github.com/users/ento/received_events","type":"User","site_admin":false},"assignees":[{"login":"ento","id":21108,"avatar_url":"https://avatars.githubusercontent.com/u/21108?v=3","gravatar_id":"","url":"https://api.github.com/users/ento","html_url":"https://github.com/ento","followers_url":"https://api.github.com/users/ento/followers","following_url":"https://api.github.com/users/ento/following{/other_user}","gists_url":"https://api.github.com/users/ento/gists{/gist_id}","starred_url":"https://api.github.com/users/ento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ento/subscriptions","organizations_url":"https://api.github.com/users/ento/orgs","repos_url":"https://api.github.com/users/ento/repos","events_url":"https://api.github.com/users/ento/events{/privacy}","received_events_url":"https://api.github.com/users/ento/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6/commits","review_comments_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6/comments","review_comment_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/6/comments","statuses_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/statuses/edfe7c23cccf021e71c680175f7031b3564f2401","head":{"label":"NoRedInk:code-review-cleanups","ref":"code-review-cleanups","sha":"edfe7c23cccf021e71c680175f7031b3564f2401","user":{"login":"NoRedInk","id":1747062,"avatar_url":"https://avatars.githubusercontent.com/u/1747062?v=3","gravatar_id":"","url":"https://api.github.com/users/NoRedInk","html_url":"https://github.com/NoRedInk","followers_url":"https://api.github.com/users/NoRedInk/followers","following_url":"https://api.github.com/users/NoRedInk/following{/other_user}","gists_url":"https://api.github.com/users/NoRedInk/gists{/gist_id}","starred_url":"https://api.github.com/users/NoRedInk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoRedInk/subscriptions","organizations_url":"https://api.github.com/users/NoRedInk/orgs","repos_url":"https://api.github.com/users/NoRedInk/repos","events_url":"https://api.github.com/users/NoRedInk/events{/privacy}","received_events_url":"https://api.github.com/users/NoRedInk/received_events","type":"Organization","site_admin":false},"repo":{"id":69111624,"name":"slack-today-i-did","full_name":"NoRedInk/slack-today-i-did","owner":{"login":"NoRedInk","id":1747062,"avatar_url":"https://avatars.githubusercontent.com/u/1747062?v=3","gravatar_id":"","url":"https://api.github.com/users/NoRedInk","html_url":"https://github.com/NoRedInk","followers_url":"https://api.github.com/users/NoRedInk/followers","following_url":"https://api.github.com/users/NoRedInk/following{/other_user}","gists_url":"https://api.github.com/users/NoRedInk/gists{/gist_id}","starred_url":"https://api.github.com/users/NoRedInk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoRedInk/subscriptions","organizations_url":"https://api.github.com/users/NoRedInk/orgs","repos_url":"https://api.github.com/users/NoRedInk/repos","events_url":"https://api.github.com/users/NoRedInk/events{/privacy}","received_events_url":"https://api.github.com/users/NoRedInk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NoRedInk/slack-today-i-did","description":null,"fork":false,"url":"https://api.github.com/repos/NoRedInk/slack-today-i-did","forks_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/forks","keys_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/teams","hooks_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/hooks","issue_events_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/events{/number}","events_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/events","assignees_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/assignees{/user}","branches_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/branches{/branch}","tags_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/tags","blobs_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/refs{/sha}","trees_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/statuses/{sha}","languages_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/languages","stargazers_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/stargazers","contributors_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/contributors","subscribers_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/subscribers","subscription_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/subscription","commits_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/commits{/sha}","git_commits_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/commits{/sha}","comments_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/comments{/number}","issue_comment_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/comments{/number}","contents_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/contents/{+path}","compare_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/merges","archive_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/downloads","issues_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues{/number}","pulls_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls{/number}","milestones_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/milestones{/number}","notifications_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/labels{/name}","releases_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/releases{/id}","deployments_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/deployments","created_at":"2016-09-24T15:47:39Z","updated_at":"2016-10-06T21:00:26Z","pushed_at":"2016-10-08T01:43:39Z","git_url":"git://github.com/NoRedInk/slack-today-i-did.git","ssh_url":"git@github.com:NoRedInk/slack-today-i-did.git","clone_url":"https://github.com/NoRedInk/slack-today-i-did.git","svn_url":"https://github.com/NoRedInk/slack-today-i-did","homepage":null,"size":43,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"NoRedInk:master","ref":"master","sha":"2ae455786ba6f0b469616ed064d378b10a7a7feb","user":{"login":"NoRedInk","id":1747062,"avatar_url":"https://avatars.githubusercontent.com/u/1747062?v=3","gravatar_id":"","url":"https://api.github.com/users/NoRedInk","html_url":"https://github.com/NoRedInk","followers_url":"https://api.github.com/users/NoRedInk/followers","following_url":"https://api.github.com/users/NoRedInk/following{/other_user}","gists_url":"https://api.github.com/users/NoRedInk/gists{/gist_id}","starred_url":"https://api.github.com/users/NoRedInk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoRedInk/subscriptions","organizations_url":"https://api.github.com/users/NoRedInk/orgs","repos_url":"https://api.github.com/users/NoRedInk/repos","events_url":"https://api.github.com/users/NoRedInk/events{/privacy}","received_events_url":"https://api.github.com/users/NoRedInk/received_events","type":"Organization","site_admin":false},"repo":{"id":69111624,"name":"slack-today-i-did","full_name":"NoRedInk/slack-today-i-did","owner":{"login":"NoRedInk","id":1747062,"avatar_url":"https://avatars.githubusercontent.com/u/1747062?v=3","gravatar_id":"","url":"https://api.github.com/users/NoRedInk","html_url":"https://github.com/NoRedInk","followers_url":"https://api.github.com/users/NoRedInk/followers","following_url":"https://api.github.com/users/NoRedInk/following{/other_user}","gists_url":"https://api.github.com/users/NoRedInk/gists{/gist_id}","starred_url":"https://api.github.com/users/NoRedInk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoRedInk/subscriptions","organizations_url":"https://api.github.com/users/NoRedInk/orgs","repos_url":"https://api.github.com/users/NoRedInk/repos","events_url":"https://api.github.com/users/NoRedInk/events{/privacy}","received_events_url":"https://api.github.com/users/NoRedInk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NoRedInk/slack-today-i-did","description":null,"fork":false,"url":"https://api.github.com/repos/NoRedInk/slack-today-i-did","forks_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/forks","keys_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/teams","hooks_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/hooks","issue_events_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/events{/number}","events_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/events","assignees_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/assignees{/user}","branches_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/branches{/branch}","tags_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/tags","blobs_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/refs{/sha}","trees_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/statuses/{sha}","languages_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/languages","stargazers_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/stargazers","contributors_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/contributors","subscribers_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/subscribers","subscription_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/subscription","commits_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/commits{/sha}","git_commits_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/git/commits{/sha}","comments_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/comments{/number}","issue_comment_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/comments{/number}","contents_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/contents/{+path}","compare_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/merges","archive_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/downloads","issues_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues{/number}","pulls_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls{/number}","milestones_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/milestones{/number}","notifications_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/labels{/name}","releases_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/releases{/id}","deployments_url":"https://api.github.com/repos/NoRedInk/slack-today-i-did/deployments","created_at":"2016-09-24T15:47:39Z","updated_at":"2016-10-06T21:00:26Z","pushed_at":"2016-10-08T01:43:39Z","git_url":"git://github.com/NoRedInk/slack-today-i-did.git","ssh_url":"git@github.com:NoRedInk/slack-today-i-did.git","clone_url":"https://github.com/NoRedInk/slack-today-i-did.git","svn_url":"https://github.com/NoRedInk/slack-today-i-did","homepage":null,"size":43,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6"},"html":{"href":"https://github.com/NoRedInk/slack-today-i-did/pull/6"},"issue":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/6"},"comments":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/NoRedInk/slack-today-i-did/statuses/edfe7c23cccf021e71c680175f7031b3564f2401"}}}}
{"actor":{"display_login":"ento"}}