{"action":"created","issue":{"url":"https://api.github.com/repos/justinrainbow/json-schema/issues/263","repository_url":"https://api.github.com/repos/justinrainbow/json-schema","labels_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/263/comments","events_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/263/events","html_url":"https://github.com/justinrainbow/json-schema/pull/263","id":153233888,"number":263,"title":"Fixed cached schemas management in RefResolver.","user":{"login":"Alex-PK","id":983447,"avatar_url":"https://avatars.githubusercontent.com/u/983447?v=3","gravatar_id":"","url":"https://api.github.com/users/Alex-PK","html_url":"https://github.com/Alex-PK","followers_url":"https://api.github.com/users/Alex-PK/followers","following_url":"https://api.github.com/users/Alex-PK/following{/other_user}","gists_url":"https://api.github.com/users/Alex-PK/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-PK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-PK/subscriptions","organizations_url":"https://api.github.com/users/Alex-PK/orgs","repos_url":"https://api.github.com/users/Alex-PK/repos","events_url":"https://api.github.com/users/Alex-PK/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-PK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-05-05T13:38:57Z","updated_at":"2016-08-19T17:15:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/justinrainbow/json-schema/pulls/263","html_url":"https://github.com/justinrainbow/json-schema/pull/263","diff_url":"https://github.com/justinrainbow/json-schema/pull/263.diff","patch_url":"https://github.com/justinrainbow/json-schema/pull/263.patch"},"body":"Hi,\r\n\r\nwhile trying out your package today I discovered that schema caching was not working very well, as the cache was not passed by reference.\r\n\r\nThe base draft-04 schema from json-schema.org was being downloaded multiple times (as it has a cyclic reference to itself), and the download hung on the second try, maybe due to a flaky connection on my side.\r\n\r\nThis patch \"centralizes\" the schemas cache in the RefResolver class into a private array, avoiding the need to pass it around in the functions calls. As they are all private, this shouldn't impact any other part of the system.\r\n\r\nAll the tests are passing.\r\n\r\nCheers."},"comment":{"url":"https://api.github.com/repos/justinrainbow/json-schema/issues/comments/241077928","html_url":"https://github.com/justinrainbow/json-schema/pull/263#issuecomment-241077928","issue_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/263","id":241077928,"user":{"login":"bighappyface","id":1407330,"avatar_url":"https://avatars.githubusercontent.com/u/1407330?v=3","gravatar_id":"","url":"https://api.github.com/users/bighappyface","html_url":"https://github.com/bighappyface","followers_url":"https://api.github.com/users/bighappyface/followers","following_url":"https://api.github.com/users/bighappyface/following{/other_user}","gists_url":"https://api.github.com/users/bighappyface/gists{/gist_id}","starred_url":"https://api.github.com/users/bighappyface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bighappyface/subscriptions","organizations_url":"https://api.github.com/users/bighappyface/orgs","repos_url":"https://api.github.com/users/bighappyface/repos","events_url":"https://api.github.com/users/bighappyface/events{/privacy}","received_events_url":"https://api.github.com/users/bighappyface/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T17:15:27Z","updated_at":"2016-08-19T17:15:27Z","body":"Hey @Alex-PK I this PR may not be necessary anymore:\r\n\r\nhttps://github.com/justinrainbow/json-schema/pull/290\r\n\r\nForgive me for not diving in deeper but are both PRs going for the same thing? If so, please close this PR and my apologies for taking a later PR over this one."}}
{"actor":{"display_login":"bighappyface"}}