{"action":"created","comment":{"url":"https://api.github.com/repos/joyent/containerpilot/pulls/comments/62238241","id":62238241,"diff_hunk":"@@ -52,6 +58,11 @@ func parseEndpoints(endpoints interface{}) []string {\n \treturn nil\n }\n \n+// HandleEtcd is the handler function for creating the etcd backend\n+func HandleEtcd(raw interface{}) (discovery.DiscoveryService, error) {","path":"discovery/etcd/etcd.go","position":26,"original_position":26,"commit_id":"8ac11232ac92017b6a81364708a6a924f1b5d878","original_commit_id":"8ac11232ac92017b6a81364708a6a924f1b5d878","user":{"login":"tgross","id":1409219,"avatar_url":"https://avatars.githubusercontent.com/u/1409219?v=3","gravatar_id":"","url":"https://api.github.com/users/tgross","html_url":"https://github.com/tgross","followers_url":"https://api.github.com/users/tgross/followers","following_url":"https://api.github.com/users/tgross/following{/other_user}","gists_url":"https://api.github.com/users/tgross/gists{/gist_id}","starred_url":"https://api.github.com/users/tgross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgross/subscriptions","organizations_url":"https://api.github.com/users/tgross/orgs","repos_url":"https://api.github.com/users/tgross/repos","events_url":"https://api.github.com/users/tgross/events{/privacy}","received_events_url":"https://api.github.com/users/tgross/received_events","type":"User","site_admin":false},"body":"Can this be `EtcdConfigHook` too?","created_at":"2016-05-05T19:11:07Z","updated_at":"2016-05-05T19:11:07Z","html_url":"https://github.com/joyent/containerpilot/pull/144#discussion_r62238241","pull_request_url":"https://api.github.com/repos/joyent/containerpilot/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/comments/62238241"},"html":{"href":"https://github.com/joyent/containerpilot/pull/144#discussion_r62238241"},"pull_request":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/joyent/containerpilot/pulls/144","id":68809595,"html_url":"https://github.com/joyent/containerpilot/pull/144","diff_url":"https://github.com/joyent/containerpilot/pull/144.diff","patch_url":"https://github.com/joyent/containerpilot/pull/144.patch","issue_url":"https://api.github.com/repos/joyent/containerpilot/issues/144","number":144,"state":"open","locked":false,"title":"Refactor of config and discovery registration","user":{"login":"justenwalker","id":222027,"avatar_url":"https://avatars.githubusercontent.com/u/222027?v=3","gravatar_id":"","url":"https://api.github.com/users/justenwalker","html_url":"https://github.com/justenwalker","followers_url":"https://api.github.com/users/justenwalker/followers","following_url":"https://api.github.com/users/justenwalker/following{/other_user}","gists_url":"https://api.github.com/users/justenwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/justenwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justenwalker/subscriptions","organizations_url":"https://api.github.com/users/justenwalker/orgs","repos_url":"https://api.github.com/users/justenwalker/repos","events_url":"https://api.github.com/users/justenwalker/events{/privacy}","received_events_url":"https://api.github.com/users/justenwalker/received_events","type":"User","site_admin":false},"body":"For #143 \r\n\r\n- Decoupled the service discovery backends from `config.go`\r\n- Added README for creating new discovery backends\r\n- Refactored config parser to allow for pluggable config sections (for now just discovery backends)\r\n- Fixed the return code in `lint.sh` script\r\n- Fixed some lint warnings/errors\r\n\r\n","created_at":"2016-05-04T04:25:06Z","updated_at":"2016-05-05T19:11:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7045597e651b9ceb9be5531963ea587a37043f99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joyent/containerpilot/pulls/144/commits","review_comments_url":"https://api.github.com/repos/joyent/containerpilot/pulls/144/comments","review_comment_url":"https://api.github.com/repos/joyent/containerpilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joyent/containerpilot/issues/144/comments","statuses_url":"https://api.github.com/repos/joyent/containerpilot/statuses/8ac11232ac92017b6a81364708a6a924f1b5d878","head":{"label":"justenwalker:gh143_refactor_discovery_registration","ref":"gh143_refactor_discovery_registration","sha":"8ac11232ac92017b6a81364708a6a924f1b5d878","user":{"login":"justenwalker","id":222027,"avatar_url":"https://avatars.githubusercontent.com/u/222027?v=3","gravatar_id":"","url":"https://api.github.com/users/justenwalker","html_url":"https://github.com/justenwalker","followers_url":"https://api.github.com/users/justenwalker/followers","following_url":"https://api.github.com/users/justenwalker/following{/other_user}","gists_url":"https://api.github.com/users/justenwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/justenwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justenwalker/subscriptions","organizations_url":"https://api.github.com/users/justenwalker/orgs","repos_url":"https://api.github.com/users/justenwalker/repos","events_url":"https://api.github.com/users/justenwalker/events{/privacy}","received_events_url":"https://api.github.com/users/justenwalker/received_events","type":"User","site_admin":false},"repo":{"id":47218030,"name":"containerpilot","full_name":"justenwalker/containerpilot","owner":{"login":"justenwalker","id":222027,"avatar_url":"https://avatars.githubusercontent.com/u/222027?v=3","gravatar_id":"","url":"https://api.github.com/users/justenwalker","html_url":"https://github.com/justenwalker","followers_url":"https://api.github.com/users/justenwalker/followers","following_url":"https://api.github.com/users/justenwalker/following{/other_user}","gists_url":"https://api.github.com/users/justenwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/justenwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justenwalker/subscriptions","organizations_url":"https://api.github.com/users/justenwalker/orgs","repos_url":"https://api.github.com/users/justenwalker/repos","events_url":"https://api.github.com/users/justenwalker/events{/privacy}","received_events_url":"https://api.github.com/users/justenwalker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justenwalker/containerpilot","description":"A service for autodiscovery and configuration of applications running in containers","fork":true,"url":"https://api.github.com/repos/justenwalker/containerpilot","forks_url":"https://api.github.com/repos/justenwalker/containerpilot/forks","keys_url":"https://api.github.com/repos/justenwalker/containerpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justenwalker/containerpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justenwalker/containerpilot/teams","hooks_url":"https://api.github.com/repos/justenwalker/containerpilot/hooks","issue_events_url":"https://api.github.com/repos/justenwalker/containerpilot/issues/events{/number}","events_url":"https://api.github.com/repos/justenwalker/containerpilot/events","assignees_url":"https://api.github.com/repos/justenwalker/containerpilot/assignees{/user}","branches_url":"https://api.github.com/repos/justenwalker/containerpilot/branches{/branch}","tags_url":"https://api.github.com/repos/justenwalker/containerpilot/tags","blobs_url":"https://api.github.com/repos/justenwalker/containerpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justenwalker/containerpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justenwalker/containerpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/justenwalker/containerpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justenwalker/containerpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/justenwalker/containerpilot/languages","stargazers_url":"https://api.github.com/repos/justenwalker/containerpilot/stargazers","contributors_url":"https://api.github.com/repos/justenwalker/containerpilot/contributors","subscribers_url":"https://api.github.com/repos/justenwalker/containerpilot/subscribers","subscription_url":"https://api.github.com/repos/justenwalker/containerpilot/subscription","commits_url":"https://api.github.com/repos/justenwalker/containerpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/justenwalker/containerpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/justenwalker/containerpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/justenwalker/containerpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/justenwalker/containerpilot/contents/{+path}","compare_url":"https://api.github.com/repos/justenwalker/containerpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justenwalker/containerpilot/merges","archive_url":"https://api.github.com/repos/justenwalker/containerpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justenwalker/containerpilot/downloads","issues_url":"https://api.github.com/repos/justenwalker/containerpilot/issues{/number}","pulls_url":"https://api.github.com/repos/justenwalker/containerpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/justenwalker/containerpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/justenwalker/containerpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justenwalker/containerpilot/labels{/name}","releases_url":"https://api.github.com/repos/justenwalker/containerpilot/releases{/id}","deployments_url":"https://api.github.com/repos/justenwalker/containerpilot/deployments","created_at":"2015-12-01T21:18:18Z","updated_at":"2016-04-13T02:28:11Z","pushed_at":"2016-05-05T15:54:59Z","git_url":"git://github.com/justenwalker/containerpilot.git","ssh_url":"git@github.com:justenwalker/containerpilot.git","clone_url":"https://github.com/justenwalker/containerpilot.git","svn_url":"https://github.com/justenwalker/containerpilot","homepage":null,"size":439,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:master","ref":"master","sha":"7c8c42f2cd827949ab80f28d6488df80d15844ec","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":44767194,"name":"containerpilot","full_name":"joyent/containerpilot","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars.githubusercontent.com/u/10161?v=3","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/containerpilot","description":"A service for autodiscovery and configuration of applications running in containers","fork":false,"url":"https://api.github.com/repos/joyent/containerpilot","forks_url":"https://api.github.com/repos/joyent/containerpilot/forks","keys_url":"https://api.github.com/repos/joyent/containerpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/containerpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/containerpilot/teams","hooks_url":"https://api.github.com/repos/joyent/containerpilot/hooks","issue_events_url":"https://api.github.com/repos/joyent/containerpilot/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/containerpilot/events","assignees_url":"https://api.github.com/repos/joyent/containerpilot/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/containerpilot/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/containerpilot/tags","blobs_url":"https://api.github.com/repos/joyent/containerpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/containerpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/containerpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/containerpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/containerpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/containerpilot/languages","stargazers_url":"https://api.github.com/repos/joyent/containerpilot/stargazers","contributors_url":"https://api.github.com/repos/joyent/containerpilot/contributors","subscribers_url":"https://api.github.com/repos/joyent/containerpilot/subscribers","subscription_url":"https://api.github.com/repos/joyent/containerpilot/subscription","commits_url":"https://api.github.com/repos/joyent/containerpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/containerpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/containerpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/containerpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyent/containerpilot/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/containerpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/containerpilot/merges","archive_url":"https://api.github.com/repos/joyent/containerpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/containerpilot/downloads","issues_url":"https://api.github.com/repos/joyent/containerpilot/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/containerpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/containerpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/containerpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/containerpilot/labels{/name}","releases_url":"https://api.github.com/repos/joyent/containerpilot/releases{/id}","deployments_url":"https://api.github.com/repos/joyent/containerpilot/deployments","created_at":"2015-10-22T19:06:39Z","updated_at":"2016-05-04T09:46:28Z","pushed_at":"2016-05-05T15:50:35Z","git_url":"git://github.com/joyent/containerpilot.git","ssh_url":"git@github.com:joyent/containerpilot.git","clone_url":"https://github.com/joyent/containerpilot.git","svn_url":"https://github.com/joyent/containerpilot","homepage":null,"size":427,"stargazers_count":345,"watchers_count":345,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":13,"forks":36,"open_issues":13,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/144"},"html":{"href":"https://github.com/joyent/containerpilot/pull/144"},"issue":{"href":"https://api.github.com/repos/joyent/containerpilot/issues/144"},"comments":{"href":"https://api.github.com/repos/joyent/containerpilot/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/containerpilot/statuses/8ac11232ac92017b6a81364708a6a924f1b5d878"}}}}