{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7559","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7559/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7559/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7559/events","html_url":"https://github.com/nodejs/node/pull/7559","id":164058135,"number":7559,"title":"win, fs: fix realpath behavior on substed drives","user":{"login":"bzoz","id":17704638,"avatar_url":"https://avatars.githubusercontent.com/u/17704638?v=3","gravatar_id":"","url":"https://api.github.com/users/bzoz","html_url":"https://github.com/bzoz","followers_url":"https://api.github.com/users/bzoz/followers","following_url":"https://api.github.com/users/bzoz/following{/other_user}","gists_url":"https://api.github.com/users/bzoz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzoz/subscriptions","organizations_url":"https://api.github.com/users/bzoz/orgs","repos_url":"https://api.github.com/users/bzoz/repos","events_url":"https://api.github.com/users/bzoz/events{/privacy}","received_events_url":"https://api.github.com/users/bzoz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc"},{"url":"https://api.github.com/repos/nodejs/node/labels/in%20progress","name":"in progress","color":"ededed"},{"url":"https://api.github.com/repos/nodejs/node/labels/windows","name":"windows","color":"9944dd"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-07-06T11:49:53Z","updated_at":"2016-08-10T09:12:16Z","closed_at":"2016-08-10T09:12:16Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7559","html_url":"https://github.com/nodejs/node/pull/7559","diff_url":"https://github.com/nodejs/node/pull/7559.diff","patch_url":"https://github.com/nodejs/node/pull/7559.patch"},"body":"##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nfs, win\r\n\r\n##### Description of change\r\nWork in progress for issues related to new realpath implementation (https://github.com/nodejs/node/issues/7175).\r\n\r\nBefore v6 on drives created with subst and network mapped drives realpath used to return filename on the mapped drive. With v6 (https://github.com/nodejs/node/commit/b488b19eaf2b2e7a3ca5eccd2445e245847a5f76) it now returns filename on the original device or on the network share. This restores the old behavior by:\r\n\r\n1. Restoring old javascript implementation (separate commit just for reviewing here, can be squashed with the next)\r\n2. Using it when path returned by new implementation is on a different device than the original path\r\n\r\n\r\nThis PR addresses only issues related to the filename resolved being different on v6 and v4 (e.g. https://github.com/nodejs/node/issues/7294). There are other issues, for example related to permissions on Windows like https://github.com/nodejs/node/issues/7192 and other on Linux as described in https://github.com/nodejs/node/issues/7175. Some of those are to be addressed in different patch [(comment)](https://github.com/nodejs/node/issues/7175#issuecomment-229574363).\r\n\r\n@trevnorris this fixes some of the Windows issues. Can you review to make sure it's compatible with your changes?"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/238809863","html_url":"https://github.com/nodejs/node/pull/7559#issuecomment-238809863","issue_url":"https://api.github.com/repos/nodejs/node/issues/7559","id":238809863,"user":{"login":"bzoz","id":17704638,"avatar_url":"https://avatars.githubusercontent.com/u/17704638?v=3","gravatar_id":"","url":"https://api.github.com/users/bzoz","html_url":"https://github.com/bzoz","followers_url":"https://api.github.com/users/bzoz/followers","following_url":"https://api.github.com/users/bzoz/following{/other_user}","gists_url":"https://api.github.com/users/bzoz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzoz/subscriptions","organizations_url":"https://api.github.com/users/bzoz/orgs","repos_url":"https://api.github.com/users/bzoz/repos","events_url":"https://api.github.com/users/bzoz/events{/privacy}","received_events_url":"https://api.github.com/users/bzoz/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T09:12:16Z","updated_at":"2016-08-10T09:12:16Z","body":"This will be addressed when https://github.com/nodejs/node/pull/7899 lands."}}
{"actor":{"display_login":"bzoz"}}