{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/8818","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/8818/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/8818/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/8818/events","html_url":"https://github.com/mrdoob/three.js/pull/8818","id":153336845,"number":8818,"title":"Simple cone geometry","user":{"login":"abelnation","id":200054,"avatar_url":"https://avatars.githubusercontent.com/u/200054?v=3","gravatar_id":"","url":"https://api.github.com/users/abelnation","html_url":"https://github.com/abelnation","followers_url":"https://api.github.com/users/abelnation/followers","following_url":"https://api.github.com/users/abelnation/following{/other_user}","gists_url":"https://api.github.com/users/abelnation/gists{/gist_id}","starred_url":"https://api.github.com/users/abelnation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abelnation/subscriptions","organizations_url":"https://api.github.com/users/abelnation/orgs","repos_url":"https://api.github.com/users/abelnation/repos","events_url":"https://api.github.com/users/abelnation/events{/privacy}","received_events_url":"https://api.github.com/users/abelnation/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-05T22:06:23Z","updated_at":"2016-05-06T18:17:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/8818","html_url":"https://github.com/mrdoob/three.js/pull/8818","diff_url":"https://github.com/mrdoob/three.js/pull/8818.diff","patch_url":"https://github.com/mrdoob/three.js/pull/8818.patch"},"body":"Addresses #8720, at least in a trivial way.  \r\n\r\nCreates a new primitive, `ConeGeometry` and `ConeBufferGeometry`, that are just wrappers around the corresponding `Cyilinder` geometries.  \r\n\r\nNote that, the \"point\" in a cylinder that has one radius as `0` is rendered just like any other side face of the cylinder, i.e. with two triangles.  In the `r=0` case, one of those triangles is reduced to zero-area, so this solution unnecessarily renders 1 extra invisible triangle per radial segment.  I spent some time trying to optimize the CylinderBufferGeometry logic to detect and remove those extra vertices and indices, but found that it dirtied the otherwise nice logic of the cynlinder generation code.  \r\n\r\n@mrdoob @WestLangley \r\n"},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/217519616","html_url":"https://github.com/mrdoob/three.js/pull/8818#issuecomment-217519616","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/8818","id":217519616,"user":{"login":"abelnation","id":200054,"avatar_url":"https://avatars.githubusercontent.com/u/200054?v=3","gravatar_id":"","url":"https://api.github.com/users/abelnation","html_url":"https://github.com/abelnation","followers_url":"https://api.github.com/users/abelnation/followers","following_url":"https://api.github.com/users/abelnation/following{/other_user}","gists_url":"https://api.github.com/users/abelnation/gists{/gist_id}","starred_url":"https://api.github.com/users/abelnation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abelnation/subscriptions","organizations_url":"https://api.github.com/users/abelnation/orgs","repos_url":"https://api.github.com/users/abelnation/repos","events_url":"https://api.github.com/users/abelnation/events{/privacy}","received_events_url":"https://api.github.com/users/abelnation/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T18:17:33Z","updated_at":"2016-05-06T18:17:33Z","body":"@mrdoob @Mugen87 what is the process for merging PR's?  does the author merge when it get's the thumbs up? or does some primary other contributor take care of merging the pr's?"}}