{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/66959049","id":66959049,"diff_hunk":"@@ -591,7 +642,7 @@ def test_bilinear_kernel_2D(self):\n             # getting the normalized kernel\n             kernel = bilinear_kernel_2D(ratio=ratio, normalize=True)\n             f = theano.function([], kernel)\n-            kernel_2D = kernel_2D / float(ratio**2)\n+            kernel_2D = kernel_2D / float(ratio ** 2)","path":"theano/tensor/nnet/tests/test_abstract_conv.py","position":425,"original_position":425,"commit_id":"3a5f52a8775e76ff5643951b547f8376a952ad9b","original_commit_id":"3a5f52a8775e76ff5643951b547f8376a952ad9b","user":{"login":"f0k","id":629706,"avatar_url":"https://avatars.githubusercontent.com/u/629706?v=3","gravatar_id":"","url":"https://api.github.com/users/f0k","html_url":"https://github.com/f0k","followers_url":"https://api.github.com/users/f0k/followers","following_url":"https://api.github.com/users/f0k/following{/other_user}","gists_url":"https://api.github.com/users/f0k/gists{/gist_id}","starred_url":"https://api.github.com/users/f0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f0k/subscriptions","organizations_url":"https://api.github.com/users/f0k/orgs","repos_url":"https://api.github.com/users/f0k/repos","events_url":"https://api.github.com/users/f0k/events{/privacy}","received_events_url":"https://api.github.com/users/f0k/received_events","type":"User","site_admin":false},"body":"Not the business of this PR!","created_at":"2016-06-14T12:24:49Z","updated_at":"2016-06-14T12:24:49Z","html_url":"https://github.com/Theano/Theano/pull/4587#discussion_r66959049","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4587","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/66959049"},"html":{"href":"https://github.com/Theano/Theano/pull/4587#discussion_r66959049"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4587"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4587","id":72638702,"html_url":"https://github.com/Theano/Theano/pull/4587","diff_url":"https://github.com/Theano/Theano/pull/4587.diff","patch_url":"https://github.com/Theano/Theano/pull/4587.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4587","number":4587,"state":"open","locked":false,"title":"Implementation of 2D dilated convolution/correlation.","user":{"login":"niasla","id":2981820,"avatar_url":"https://avatars.githubusercontent.com/u/2981820?v=3","gravatar_id":"","url":"https://api.github.com/users/niasla","html_url":"https://github.com/niasla","followers_url":"https://api.github.com/users/niasla/followers","following_url":"https://api.github.com/users/niasla/following{/other_user}","gists_url":"https://api.github.com/users/niasla/gists{/gist_id}","starred_url":"https://api.github.com/users/niasla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niasla/subscriptions","organizations_url":"https://api.github.com/users/niasla/orgs","repos_url":"https://api.github.com/users/niasla/repos","events_url":"https://api.github.com/users/niasla/events{/privacy}","received_events_url":"https://api.github.com/users/niasla/received_events","type":"User","site_admin":false},"body":"Comments:\r\n- For some reason when tensor.nnet.conv2d is called then convop is implemented with the debug slow version in abstract_conv.py. Modified already opt.py (both cpu and gpu versions) and dnn.py (both gpuarray and cuda). The idea is that whenever tensor.nnet.conv2d is called we need to check wether there is dilation and if there is the call conv_gemm implementation. \r\n- Following the previous point, the TestDnnConv2d in test_sandbox/cuda/tests/abstractconv.py fails. The reason is the use of cuDNN implementation of dilated architectures in tests (should we skip them or adapt with the abstract iface?)\r\n","created_at":"2016-06-05T19:58:04Z","updated_at":"2016-06-14T12:24:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db83f8cd9f874516ed071ed949d7982a711fc726","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4587/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4587/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4587/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/3a5f52a8775e76ff5643951b547f8376a952ad9b","head":{"label":"niasla:dilated_convolution","ref":"dilated_convolution","sha":"3a5f52a8775e76ff5643951b547f8376a952ad9b","user":{"login":"niasla","id":2981820,"avatar_url":"https://avatars.githubusercontent.com/u/2981820?v=3","gravatar_id":"","url":"https://api.github.com/users/niasla","html_url":"https://github.com/niasla","followers_url":"https://api.github.com/users/niasla/followers","following_url":"https://api.github.com/users/niasla/following{/other_user}","gists_url":"https://api.github.com/users/niasla/gists{/gist_id}","starred_url":"https://api.github.com/users/niasla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niasla/subscriptions","organizations_url":"https://api.github.com/users/niasla/orgs","repos_url":"https://api.github.com/users/niasla/repos","events_url":"https://api.github.com/users/niasla/events{/privacy}","received_events_url":"https://api.github.com/users/niasla/received_events","type":"User","site_admin":false},"repo":{"id":59785574,"name":"Theano","full_name":"niasla/Theano","owner":{"login":"niasla","id":2981820,"avatar_url":"https://avatars.githubusercontent.com/u/2981820?v=3","gravatar_id":"","url":"https://api.github.com/users/niasla","html_url":"https://github.com/niasla","followers_url":"https://api.github.com/users/niasla/followers","following_url":"https://api.github.com/users/niasla/following{/other_user}","gists_url":"https://api.github.com/users/niasla/gists{/gist_id}","starred_url":"https://api.github.com/users/niasla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niasla/subscriptions","organizations_url":"https://api.github.com/users/niasla/orgs","repos_url":"https://api.github.com/users/niasla/repos","events_url":"https://api.github.com/users/niasla/events{/privacy}","received_events_url":"https://api.github.com/users/niasla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niasla/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/niasla/Theano","forks_url":"https://api.github.com/repos/niasla/Theano/forks","keys_url":"https://api.github.com/repos/niasla/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niasla/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niasla/Theano/teams","hooks_url":"https://api.github.com/repos/niasla/Theano/hooks","issue_events_url":"https://api.github.com/repos/niasla/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/niasla/Theano/events","assignees_url":"https://api.github.com/repos/niasla/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/niasla/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/niasla/Theano/tags","blobs_url":"https://api.github.com/repos/niasla/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niasla/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niasla/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/niasla/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niasla/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/niasla/Theano/languages","stargazers_url":"https://api.github.com/repos/niasla/Theano/stargazers","contributors_url":"https://api.github.com/repos/niasla/Theano/contributors","subscribers_url":"https://api.github.com/repos/niasla/Theano/subscribers","subscription_url":"https://api.github.com/repos/niasla/Theano/subscription","commits_url":"https://api.github.com/repos/niasla/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/niasla/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/niasla/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/niasla/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/niasla/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/niasla/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niasla/Theano/merges","archive_url":"https://api.github.com/repos/niasla/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niasla/Theano/downloads","issues_url":"https://api.github.com/repos/niasla/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/niasla/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/niasla/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/niasla/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niasla/Theano/labels{/name}","releases_url":"https://api.github.com/repos/niasla/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/niasla/Theano/deployments","created_at":"2016-05-26T21:53:53Z","updated_at":"2016-05-26T21:53:57Z","pushed_at":"2016-06-14T06:45:48Z","git_url":"git://github.com/niasla/Theano.git","ssh_url":"git@github.com:niasla/Theano.git","clone_url":"https://github.com/niasla/Theano.git","svn_url":"https://github.com/niasla/Theano","homepage":"http://www.deeplearning.net/software/theano","size":53604,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"02e1e3f8382eb950e09617d8f5ca25c9a4b80f80","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-06-14T10:49:24Z","pushed_at":"2016-06-14T08:45:31Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":74483,"stargazers_count":3931,"watchers_count":3931,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1426,"mirror_url":null,"open_issues_count":680,"forks":1426,"open_issues":680,"watchers":3931,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4587"},"html":{"href":"https://github.com/Theano/Theano/pull/4587"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4587"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4587/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4587/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4587/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/3a5f52a8775e76ff5643951b547f8376a952ad9b"}}}}
{"actor":{"display_login":"f0k"}}