{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3191","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3191/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3191/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3191/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/3191","id":187011431,"number":3191,"title":"Fix lwip_mac_address buffer overflow and set_ip_bytes out of bound access","user":{"login":"tung7970","id":9383560,"avatar_url":"https://avatars.githubusercontent.com/u/9383560?v=3","gravatar_id":"","url":"https://api.github.com/users/tung7970","html_url":"https://github.com/tung7970","followers_url":"https://api.github.com/users/tung7970/followers","following_url":"https://api.github.com/users/tung7970/following{/other_user}","gists_url":"https://api.github.com/users/tung7970/gists{/gist_id}","starred_url":"https://api.github.com/users/tung7970/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tung7970/subscriptions","organizations_url":"https://api.github.com/users/tung7970/orgs","repos_url":"https://api.github.com/users/tung7970/repos","events_url":"https://api.github.com/users/tung7970/events{/privacy}","received_events_url":"https://api.github.com/users/tung7970/received_events","type":"User","site_admin":false},"labels":[{"id":390046351,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20CI","name":"needs: CI","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-03T09:35:12Z","updated_at":"2016-11-07T17:04:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3191","html_url":"https://github.com/ARMmbed/mbed-os/pull/3191","diff_url":"https://github.com/ARMmbed/mbed-os/pull/3191.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/3191.patch"},"body":"## Description\r\n\r\n1.  Fix lwip_mac_address buffer overflow. \r\n\r\nThe size of lwip_mac_address is NSAPI_MAC_SIZE, but in mbed_lwip_set_mac_address(), the max size in snprintf is set to 19. This might overflow the lwip_mac_address buffer.\r\n\r\nThis patch sets the size of lwip_mac_address to NSAPI_MAC_SIZE + 1, and sets snprintf limit to NSAPI_MAC_SIZE.\r\n\r\n2. netsocket - Fix set_ip_bytes out-of-bound access\r\n\r\nset_ip_bytes() does a 16-byte memcpy from the input buffer to\r\nthe local nsapi_addr_t despite the address version.\r\n\r\nIf the address version is ipv4, the input buffer may only be\r\n4-byte in size. This causes a out-of-bound access on the input buffer.\r\n\r\n## Status\r\nREADY\r\n\r\n## Migrations\r\nNO\r\n\r\n## Deploy notes\r\nNONE"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/258895471","html_url":"https://github.com/ARMmbed/mbed-os/pull/3191#issuecomment-258895471","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3191","id":258895471,"user":{"login":"bridadan","id":3123977,"avatar_url":"https://avatars.githubusercontent.com/u/3123977?v=3","gravatar_id":"","url":"https://api.github.com/users/bridadan","html_url":"https://github.com/bridadan","followers_url":"https://api.github.com/users/bridadan/followers","following_url":"https://api.github.com/users/bridadan/following{/other_user}","gists_url":"https://api.github.com/users/bridadan/gists{/gist_id}","starred_url":"https://api.github.com/users/bridadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridadan/subscriptions","organizations_url":"https://api.github.com/users/bridadan/orgs","repos_url":"https://api.github.com/users/bridadan/repos","events_url":"https://api.github.com/users/bridadan/events{/privacy}","received_events_url":"https://api.github.com/users/bridadan/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T17:04:08Z","updated_at":"2016-11-07T17:04:08Z","body":"There was a git issue with one of the machines which caused this to fail. Should be fixed now. Restarting!\r\n\r\n/morph test-nightly"}}
{"actor":{"display_login":"bridadan"}}