{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/285","repository_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin","labels_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/285/comments","events_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/285/events","html_url":"https://github.com/jenkinsci/ghprb-plugin/issues/285","id":137990293,"number":285,"title":"Plugin Tests Don't Run Correctly","user":{"login":"tlusk","id":458460,"avatar_url":"https://avatars.githubusercontent.com/u/458460?v=3","gravatar_id":"","url":"https://api.github.com/users/tlusk","html_url":"https://github.com/tlusk","followers_url":"https://api.github.com/users/tlusk/followers","following_url":"https://api.github.com/users/tlusk/following{/other_user}","gists_url":"https://api.github.com/users/tlusk/gists{/gist_id}","starred_url":"https://api.github.com/users/tlusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlusk/subscriptions","organizations_url":"https://api.github.com/users/tlusk/orgs","repos_url":"https://api.github.com/users/tlusk/repos","events_url":"https://api.github.com/users/tlusk/events{/privacy}","received_events_url":"https://api.github.com/users/tlusk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-02T20:56:17Z","updated_at":"2016-03-03T19:53:04Z","closed_at":null,"body":"I forked and built the plugin with the intent of making some changes to it, but I can't get the plugin tests to run correctly no matter what I do.\r\n\r\nFirst issue is it's throwing hundreds of `java.lang.NoClassDefFoundError: jenkins/model/TransientActionFactory` exceptions.  Turns out this was caused when a dependency to the plugin for `org.jenkins-ci.plugins:job-dsl:1.39` was added.  This is because the version of jenkins the plugin is being built against doesn't have the `TransientActionFactory` class the `job-dsl` plugin references.\r\n\r\nThis error can also be seen in all the logs on the jenkins server building the official plugin.  From what I can tell the unit tests aren't being run correctly there either.  [Check the console output on any of the builds here.](https://jenkins.ci.cloudbees.com/job/plugins/job/ghprb-plugin/)\r\n\r\nI then tried upping the version it's being built against to `1.554.1`, and while that fixes the TransientActionFactory error I'm now getting NullPointerExceptions coming from the mocked `RequestImpl.bindJSON` method.\r\n\r\nI also tried checking out older tags of the plugin and building/running the tests on them, but no matter what version I try the tests never run.\r\n\r\nSo the question is, am I missing something here?  Or do the tests just not work, and have they ever worked?"},"comment":{"url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/comments/191934198","html_url":"https://github.com/jenkinsci/ghprb-plugin/issues/285#issuecomment-191934198","issue_url":"https://api.github.com/repos/jenkinsci/ghprb-plugin/issues/285","id":191934198,"user":{"login":"tlusk","id":458460,"avatar_url":"https://avatars.githubusercontent.com/u/458460?v=3","gravatar_id":"","url":"https://api.github.com/users/tlusk","html_url":"https://github.com/tlusk","followers_url":"https://api.github.com/users/tlusk/followers","following_url":"https://api.github.com/users/tlusk/following{/other_user}","gists_url":"https://api.github.com/users/tlusk/gists{/gist_id}","starred_url":"https://api.github.com/users/tlusk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlusk/subscriptions","organizations_url":"https://api.github.com/users/tlusk/orgs","repos_url":"https://api.github.com/users/tlusk/repos","events_url":"https://api.github.com/users/tlusk/events{/privacy}","received_events_url":"https://api.github.com/users/tlusk/received_events","type":"User","site_admin":false},"created_at":"2016-03-03T19:53:04Z","updated_at":"2016-03-03T19:53:04Z","body":"@daspilker is correct on that, unfortunately upgrading the jenkins version isn't as straightforward as changing the jenkins core in the pom as version `1.548` / `1.554` and above cause issues in the unit tests related to the mocked out `RequestImpl` class.\r\n\r\nI managed the suppress the warnings in #287 by adding a custom logging properties file for the test which suppress anything below `SEVERE` coming from the hudson namespace.  It also filters out all the hudson INFO tags which bloat the console output too as a bonus, leaving only unit test warnings and errors.\r\n\r\nThe jenkins core should probably be updated at some point though.  I don't think compatibility is needed to be maintained anymore on 1.532, a version from late 2013."}}