{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/7","id":67426641,"html_url":"https://github.com/wikimedia/cassandra-metrics-collector/pull/7","diff_url":"https://github.com/wikimedia/cassandra-metrics-collector/pull/7.diff","patch_url":"https://github.com/wikimedia/cassandra-metrics-collector/pull/7.patch","issue_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/issues/7","number":7,"state":"closed","locked":false,"title":"hack-in support for Cassandra 2.2","user":{"login":"eevans","id":64348,"avatar_url":"https://avatars.githubusercontent.com/u/64348?v=3","gravatar_id":"","url":"https://api.github.com/users/eevans","html_url":"https://github.com/eevans","followers_url":"https://api.github.com/users/eevans/followers","following_url":"https://api.github.com/users/eevans/following{/other_user}","gists_url":"https://api.github.com/users/eevans/gists{/gist_id}","starred_url":"https://api.github.com/users/eevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevans/subscriptions","organizations_url":"https://api.github.com/users/eevans/orgs","repos_url":"https://api.github.com/users/eevans/repos","events_url":"https://api.github.com/users/eevans/events{/privacy}","received_events_url":"https://api.github.com/users/eevans/received_events","type":"User","site_admin":false},"body":"Somewhere between 2.1.13, and 2.2.5, Cassandra was refactored to wrap all of the codahale/dropwizard metric mbeans in Cassandra delegators.  This would have been awesome if it were done this way from the beginning, but after-the-fact it broke cmcd by changing the object names of everything.\r\n\r\nIn order to retain compatibility with the 2.1 series, this changeset introduces a second collector class (a 2.2-specific one), and uses a factory (*gasp*) to create instances of either based on the version (which for now has to be passed along via a system property).\r\n\r\nThis is unpleasant, but can be backed out rather easily after we no longer have a need for Cassandra 2.1 compatibility.\r\n\r\nBug: https://phabricator.wikimedia.org/T126629","created_at":"2016-04-21T21:38:06Z","updated_at":"2016-05-04T14:02:22Z","closed_at":"2016-05-04T14:02:22Z","merged_at":null,"merge_commit_sha":"3fdab008958f17275864a33b43a12f5516e0e6b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/7/commits","review_comments_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/7/comments","review_comment_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/issues/7/comments","statuses_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/statuses/3cd994148a9f1739dfbdc6a6c5652be3f0d4787d","head":{"label":"eevans:v3","ref":"v3","sha":"3cd994148a9f1739dfbdc6a6c5652be3f0d4787d","user":{"login":"eevans","id":64348,"avatar_url":"https://avatars.githubusercontent.com/u/64348?v=3","gravatar_id":"","url":"https://api.github.com/users/eevans","html_url":"https://github.com/eevans","followers_url":"https://api.github.com/users/eevans/followers","following_url":"https://api.github.com/users/eevans/following{/other_user}","gists_url":"https://api.github.com/users/eevans/gists{/gist_id}","starred_url":"https://api.github.com/users/eevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevans/subscriptions","organizations_url":"https://api.github.com/users/eevans/orgs","repos_url":"https://api.github.com/users/eevans/repos","events_url":"https://api.github.com/users/eevans/events{/privacy}","received_events_url":"https://api.github.com/users/eevans/received_events","type":"User","site_admin":false},"repo":{"id":40387604,"name":"cassandra-metrics-collector","full_name":"eevans/cassandra-metrics-collector","owner":{"login":"eevans","id":64348,"avatar_url":"https://avatars.githubusercontent.com/u/64348?v=3","gravatar_id":"","url":"https://api.github.com/users/eevans","html_url":"https://github.com/eevans","followers_url":"https://api.github.com/users/eevans/followers","following_url":"https://api.github.com/users/eevans/following{/other_user}","gists_url":"https://api.github.com/users/eevans/gists{/gist_id}","starred_url":"https://api.github.com/users/eevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eevans/subscriptions","organizations_url":"https://api.github.com/users/eevans/orgs","repos_url":"https://api.github.com/users/eevans/repos","events_url":"https://api.github.com/users/eevans/events{/privacy}","received_events_url":"https://api.github.com/users/eevans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eevans/cassandra-metrics-collector","description":"Cassandra JMX metrics collector","fork":true,"url":"https://api.github.com/repos/eevans/cassandra-metrics-collector","forks_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/forks","keys_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/teams","hooks_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/hooks","issue_events_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/issues/events{/number}","events_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/events","assignees_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/assignees{/user}","branches_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/branches{/branch}","tags_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/tags","blobs_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/languages","stargazers_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/stargazers","contributors_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/contributors","subscribers_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/subscribers","subscription_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/subscription","commits_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/contents/{+path}","compare_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/merges","archive_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/downloads","issues_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/issues{/number}","pulls_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/labels{/name}","releases_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/releases{/id}","deployments_url":"https://api.github.com/repos/eevans/cassandra-metrics-collector/deployments","created_at":"2015-08-08T01:37:19Z","updated_at":"2016-02-18T02:04:14Z","pushed_at":"2016-05-04T00:26:49Z","git_url":"git://github.com/eevans/cassandra-metrics-collector.git","ssh_url":"git@github.com:eevans/cassandra-metrics-collector.git","clone_url":"https://github.com/eevans/cassandra-metrics-collector.git","svn_url":"https://github.com/eevans/cassandra-metrics-collector","homepage":"","size":88,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wikimedia:master","ref":"master","sha":"9674a25cff6bfb4ca44270cd9e0cd71e97fb22c3","user":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"repo":{"id":38376495,"name":"cassandra-metrics-collector","full_name":"wikimedia/cassandra-metrics-collector","owner":{"login":"wikimedia","id":56668,"avatar_url":"https://avatars.githubusercontent.com/u/56668?v=3","gravatar_id":"","url":"https://api.github.com/users/wikimedia","html_url":"https://github.com/wikimedia","followers_url":"https://api.github.com/users/wikimedia/followers","following_url":"https://api.github.com/users/wikimedia/following{/other_user}","gists_url":"https://api.github.com/users/wikimedia/gists{/gist_id}","starred_url":"https://api.github.com/users/wikimedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wikimedia/subscriptions","organizations_url":"https://api.github.com/users/wikimedia/orgs","repos_url":"https://api.github.com/users/wikimedia/repos","events_url":"https://api.github.com/users/wikimedia/events{/privacy}","received_events_url":"https://api.github.com/users/wikimedia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wikimedia/cassandra-metrics-collector","description":"Cassandra JMX metrics collector","fork":false,"url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector","forks_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/forks","keys_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/teams","hooks_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/hooks","issue_events_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/issues/events{/number}","events_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/events","assignees_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/assignees{/user}","branches_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/branches{/branch}","tags_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/tags","blobs_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/languages","stargazers_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/stargazers","contributors_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/contributors","subscribers_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/subscribers","subscription_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/subscription","commits_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/contents/{+path}","compare_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/merges","archive_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/downloads","issues_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/issues{/number}","pulls_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/labels{/name}","releases_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/releases{/id}","deployments_url":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/deployments","created_at":"2015-07-01T14:43:15Z","updated_at":"2016-04-29T03:38:09Z","pushed_at":"2016-05-04T13:49:02Z","git_url":"git://github.com/wikimedia/cassandra-metrics-collector.git","ssh_url":"git@github.com:wikimedia/cassandra-metrics-collector.git","clone_url":"https://github.com/wikimedia/cassandra-metrics-collector.git","svn_url":"https://github.com/wikimedia/cassandra-metrics-collector","homepage":"","size":91,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/7"},"html":{"href":"https://github.com/wikimedia/cassandra-metrics-collector/pull/7"},"issue":{"href":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/issues/7"},"comments":{"href":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/wikimedia/cassandra-metrics-collector/statuses/3cd994148a9f1739dfbdc6a6c5652be3f0d4787d"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":9,"review_comments":0,"commits":2,"additions":526,"deletions":190,"changed_files":10}}