{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/30","id":56098819,"html_url":"https://github.com/nylas/nylas-nodejs/pull/30","diff_url":"https://github.com/nylas/nylas-nodejs/pull/30.diff","patch_url":"https://github.com/nylas/nylas-nodejs/pull/30.patch","issue_url":"https://api.github.com/repos/nylas/nylas-nodejs/issues/30","number":30,"state":"closed","locked":false,"title":"Bump delta stream reconnect timeout to 15s, reduce verbosity of reconnect logging","user":{"login":"ericyhwang","id":6915076,"avatar_url":"https://avatars.githubusercontent.com/u/6915076?v=3","gravatar_id":"","url":"https://api.github.com/users/ericyhwang","html_url":"https://github.com/ericyhwang","followers_url":"https://api.github.com/users/ericyhwang/followers","following_url":"https://api.github.com/users/ericyhwang/following{/other_user}","gists_url":"https://api.github.com/users/ericyhwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ericyhwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericyhwang/subscriptions","organizations_url":"https://api.github.com/users/ericyhwang/orgs","repos_url":"https://api.github.com/users/ericyhwang/repos","events_url":"https://api.github.com/users/ericyhwang/events{/privacy}","received_events_url":"https://api.github.com/users/ericyhwang/received_events","type":"User","site_admin":false},"body":"@khamidou \r\n\r\nIt seems like the Nylas server has recently changed to send heartbeats on the streaming delta connection only every 5 seconds, increased from every 1 second. This client library happens to have been configured to time out and reconnect after 5 seconds with no heartbeat.\r\n\r\nThings do still work. However, that's more requests to the Nylas server than needed, plus it results in a lot of log spam.\r\n\r\nThis PR:\r\n- Increases the default reconnect timeout to 15 seconds, up from 5 seconds. (2-3 missed 5s heartbeats, instead of 4-5 missed 1s heartbeats)\r\n- Puts the reconnect timeout onto `Delta. streamingTimeoutMs` so it can be changed by clients in the future without needing to change this library.\r\n- Reduces internal logging on reconnects to only log the URL, instead of the entire DeltaStream object.","created_at":"2016-01-14T21:48:36Z","updated_at":"2016-01-14T21:54:36Z","closed_at":"2016-01-14T21:54:35Z","merged_at":"2016-01-14T21:54:35Z","merge_commit_sha":"559515ce47b905bbec82f3335131cd82ae13a1ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/30/commits","review_comments_url":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/30/comments","review_comment_url":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nylas/nylas-nodejs/issues/30/comments","statuses_url":"https://api.github.com/repos/nylas/nylas-nodejs/statuses/85e592df9e0c7c59e42af1335adcede5ee0663e6","head":{"label":"lever:less-delta-reconnect-logging","ref":"less-delta-reconnect-logging","sha":"85e592df9e0c7c59e42af1335adcede5ee0663e6","user":{"login":"lever","id":1829309,"avatar_url":"https://avatars.githubusercontent.com/u/1829309?v=3","gravatar_id":"","url":"https://api.github.com/users/lever","html_url":"https://github.com/lever","followers_url":"https://api.github.com/users/lever/followers","following_url":"https://api.github.com/users/lever/following{/other_user}","gists_url":"https://api.github.com/users/lever/gists{/gist_id}","starred_url":"https://api.github.com/users/lever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lever/subscriptions","organizations_url":"https://api.github.com/users/lever/orgs","repos_url":"https://api.github.com/users/lever/repos","events_url":"https://api.github.com/users/lever/events{/privacy}","received_events_url":"https://api.github.com/users/lever/received_events","type":"Organization","site_admin":false},"repo":{"id":37492059,"name":"nylas-nodejs","full_name":"lever/nylas-nodejs","owner":{"login":"lever","id":1829309,"avatar_url":"https://avatars.githubusercontent.com/u/1829309?v=3","gravatar_id":"","url":"https://api.github.com/users/lever","html_url":"https://github.com/lever","followers_url":"https://api.github.com/users/lever/followers","following_url":"https://api.github.com/users/lever/following{/other_user}","gists_url":"https://api.github.com/users/lever/gists{/gist_id}","starred_url":"https://api.github.com/users/lever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lever/subscriptions","organizations_url":"https://api.github.com/users/lever/orgs","repos_url":"https://api.github.com/users/lever/repos","events_url":"https://api.github.com/users/lever/events{/privacy}","received_events_url":"https://api.github.com/users/lever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lever/nylas-nodejs","description":"A NodeJS wrapper for the Nylas REST API for Email, Contacts and Calendar","fork":true,"url":"https://api.github.com/repos/lever/nylas-nodejs","forks_url":"https://api.github.com/repos/lever/nylas-nodejs/forks","keys_url":"https://api.github.com/repos/lever/nylas-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lever/nylas-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lever/nylas-nodejs/teams","hooks_url":"https://api.github.com/repos/lever/nylas-nodejs/hooks","issue_events_url":"https://api.github.com/repos/lever/nylas-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/lever/nylas-nodejs/events","assignees_url":"https://api.github.com/repos/lever/nylas-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/lever/nylas-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/lever/nylas-nodejs/tags","blobs_url":"https://api.github.com/repos/lever/nylas-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lever/nylas-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lever/nylas-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lever/nylas-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lever/nylas-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/lever/nylas-nodejs/languages","stargazers_url":"https://api.github.com/repos/lever/nylas-nodejs/stargazers","contributors_url":"https://api.github.com/repos/lever/nylas-nodejs/contributors","subscribers_url":"https://api.github.com/repos/lever/nylas-nodejs/subscribers","subscription_url":"https://api.github.com/repos/lever/nylas-nodejs/subscription","commits_url":"https://api.github.com/repos/lever/nylas-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lever/nylas-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lever/nylas-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lever/nylas-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/lever/nylas-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/lever/nylas-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lever/nylas-nodejs/merges","archive_url":"https://api.github.com/repos/lever/nylas-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lever/nylas-nodejs/downloads","issues_url":"https://api.github.com/repos/lever/nylas-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/lever/nylas-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/lever/nylas-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/lever/nylas-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lever/nylas-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/lever/nylas-nodejs/releases{/id}","created_at":"2015-06-15T21:22:34Z","updated_at":"2016-01-14T21:08:42Z","pushed_at":"2016-01-14T21:41:31Z","git_url":"git://github.com/lever/nylas-nodejs.git","ssh_url":"git@github.com:lever/nylas-nodejs.git","clone_url":"https://github.com/lever/nylas-nodejs.git","svn_url":"https://github.com/lever/nylas-nodejs","homepage":"","size":140,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nylas:master","ref":"master","sha":"38839d44622879cece6a9e93a47f9639197b8570","user":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"repo":{"id":31620232,"name":"nylas-nodejs","full_name":"nylas/nylas-nodejs","owner":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nylas/nylas-nodejs","description":"A NodeJS wrapper for the Nylas REST API for Email, Contacts and Calendar","fork":false,"url":"https://api.github.com/repos/nylas/nylas-nodejs","forks_url":"https://api.github.com/repos/nylas/nylas-nodejs/forks","keys_url":"https://api.github.com/repos/nylas/nylas-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nylas/nylas-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nylas/nylas-nodejs/teams","hooks_url":"https://api.github.com/repos/nylas/nylas-nodejs/hooks","issue_events_url":"https://api.github.com/repos/nylas/nylas-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/nylas/nylas-nodejs/events","assignees_url":"https://api.github.com/repos/nylas/nylas-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/nylas/nylas-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/nylas/nylas-nodejs/tags","blobs_url":"https://api.github.com/repos/nylas/nylas-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nylas/nylas-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nylas/nylas-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nylas/nylas-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nylas/nylas-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/nylas/nylas-nodejs/languages","stargazers_url":"https://api.github.com/repos/nylas/nylas-nodejs/stargazers","contributors_url":"https://api.github.com/repos/nylas/nylas-nodejs/contributors","subscribers_url":"https://api.github.com/repos/nylas/nylas-nodejs/subscribers","subscription_url":"https://api.github.com/repos/nylas/nylas-nodejs/subscription","commits_url":"https://api.github.com/repos/nylas/nylas-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nylas/nylas-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nylas/nylas-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nylas/nylas-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nylas/nylas-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/nylas/nylas-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nylas/nylas-nodejs/merges","archive_url":"https://api.github.com/repos/nylas/nylas-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nylas/nylas-nodejs/downloads","issues_url":"https://api.github.com/repos/nylas/nylas-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/nylas/nylas-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/nylas/nylas-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/nylas/nylas-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nylas/nylas-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/nylas/nylas-nodejs/releases{/id}","created_at":"2015-03-03T20:41:13Z","updated_at":"2016-01-13T21:50:43Z","pushed_at":"2016-01-14T21:54:35Z","git_url":"git://github.com/nylas/nylas-nodejs.git","ssh_url":"git@github.com:nylas/nylas-nodejs.git","clone_url":"https://github.com/nylas/nylas-nodejs.git","svn_url":"https://github.com/nylas/nylas-nodejs","homepage":"","size":183,"stargazers_count":23,"watchers_count":23,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":8,"forks":14,"open_issues":8,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/30"},"html":{"href":"https://github.com/nylas/nylas-nodejs/pull/30"},"issue":{"href":"https://api.github.com/repos/nylas/nylas-nodejs/issues/30"},"comments":{"href":"https://api.github.com/repos/nylas/nylas-nodejs/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nylas/nylas-nodejs/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/nylas/nylas-nodejs/statuses/85e592df9e0c7c59e42af1335adcede5ee0663e6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"khamidou","id":44081,"avatar_url":"https://avatars.githubusercontent.com/u/44081?v=3","gravatar_id":"","url":"https://api.github.com/users/khamidou","html_url":"https://github.com/khamidou","followers_url":"https://api.github.com/users/khamidou/followers","following_url":"https://api.github.com/users/khamidou/following{/other_user}","gists_url":"https://api.github.com/users/khamidou/gists{/gist_id}","starred_url":"https://api.github.com/users/khamidou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khamidou/subscriptions","organizations_url":"https://api.github.com/users/khamidou/orgs","repos_url":"https://api.github.com/users/khamidou/repos","events_url":"https://api.github.com/users/khamidou/events{/privacy}","received_events_url":"https://api.github.com/users/khamidou/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":18,"deletions":17,"changed_files":3}}