{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/helios/pulls/comments/60952045","id":60952045,"diff_hunk":"@@ -546,8 +546,15 @@ int run(final Namespace options, final HeliosClient client, final PrintStream ou\n       builder.setToken(token);\n     }\n \n-    builder.setAddCapabilities(options.<String>getList(addCapabilityArg.getDest()));\n-    builder.setDropCapabilities(options.<String>getList(dropCapabilityArg.getDest()));\n+    final List<String> addCaps = options.<String>getList(addCapabilityArg.getDest());","path":"helios-tools/src/main/java/com/spotify/helios/cli/command/JobCreateCommand.java","position":38,"original_position":38,"commit_id":"2a9572a931e128023f160804cad2b5451335e774","original_commit_id":"2a9572a931e128023f160804cad2b5451335e774","user":{"login":"mattnworb","id":113840,"avatar_url":"https://avatars.githubusercontent.com/u/113840?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnworb","html_url":"https://github.com/mattnworb","followers_url":"https://api.github.com/users/mattnworb/followers","following_url":"https://api.github.com/users/mattnworb/following{/other_user}","gists_url":"https://api.github.com/users/mattnworb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnworb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnworb/subscriptions","organizations_url":"https://api.github.com/users/mattnworb/orgs","repos_url":"https://api.github.com/users/mattnworb/repos","events_url":"https://api.github.com/users/mattnworb/events{/privacy}","received_events_url":"https://api.github.com/users/mattnworb/received_events","type":"User","site_admin":false},"body":"I don't have a strong preference, just trying to fix a broken part of the current implementation","created_at":"2016-04-25T17:22:07Z","updated_at":"2016-04-25T17:22:07Z","html_url":"https://github.com/spotify/helios/pull/905#discussion_r60952045","pull_request_url":"https://api.github.com/repos/spotify/helios/pulls/905","_links":{"self":{"href":"https://api.github.com/repos/spotify/helios/pulls/comments/60952045"},"html":{"href":"https://github.com/spotify/helios/pull/905#discussion_r60952045"},"pull_request":{"href":"https://api.github.com/repos/spotify/helios/pulls/905"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/helios/pulls/905","id":67754685,"html_url":"https://github.com/spotify/helios/pull/905","diff_url":"https://github.com/spotify/helios/pull/905.diff","patch_url":"https://github.com/spotify/helios/pull/905.patch","issue_url":"https://api.github.com/repos/spotify/helios/issues/905","number":905,"state":"open","locked":false,"title":"fix JobCreateCommand: don't overwrite capabilities from json file","user":{"login":"mattnworb","id":113840,"avatar_url":"https://avatars.githubusercontent.com/u/113840?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnworb","html_url":"https://github.com/mattnworb","followers_url":"https://api.github.com/users/mattnworb/followers","following_url":"https://api.github.com/users/mattnworb/following{/other_user}","gists_url":"https://api.github.com/users/mattnworb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnworb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnworb/subscriptions","organizations_url":"https://api.github.com/users/mattnworb/orgs","repos_url":"https://api.github.com/users/mattnworb/repos","events_url":"https://api.github.com/users/mattnworb/events{/privacy}","received_events_url":"https://api.github.com/users/mattnworb/received_events","type":"User","site_admin":false},"body":"Added or dropped capabilities from a job json file were overwritten if the CLI switch had an empty value (i.e. was not specified).","created_at":"2016-04-25T17:08:26Z","updated_at":"2016-04-25T17:22:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ede2b191f652c8e5b59a1e0a5326aa567ec8baed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/helios/pulls/905/commits","review_comments_url":"https://api.github.com/repos/spotify/helios/pulls/905/comments","review_comment_url":"https://api.github.com/repos/spotify/helios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/helios/issues/905/comments","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/2a9572a931e128023f160804cad2b5451335e774","head":{"label":"spotify:fix-add-caps","ref":"fix-add-caps","sha":"2a9572a931e128023f160804cad2b5451335e774","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":20171642,"name":"helios","full_name":"spotify/helios","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/helios","description":"Docker container orchestration platform","fork":false,"url":"https://api.github.com/repos/spotify/helios","forks_url":"https://api.github.com/repos/spotify/helios/forks","keys_url":"https://api.github.com/repos/spotify/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/helios/teams","hooks_url":"https://api.github.com/repos/spotify/helios/hooks","issue_events_url":"https://api.github.com/repos/spotify/helios/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/helios/events","assignees_url":"https://api.github.com/repos/spotify/helios/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/helios/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/helios/tags","blobs_url":"https://api.github.com/repos/spotify/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/helios/languages","stargazers_url":"https://api.github.com/repos/spotify/helios/stargazers","contributors_url":"https://api.github.com/repos/spotify/helios/contributors","subscribers_url":"https://api.github.com/repos/spotify/helios/subscribers","subscription_url":"https://api.github.com/repos/spotify/helios/subscription","commits_url":"https://api.github.com/repos/spotify/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/helios/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/helios/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/helios/merges","archive_url":"https://api.github.com/repos/spotify/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/helios/downloads","issues_url":"https://api.github.com/repos/spotify/helios/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/helios/labels{/name}","releases_url":"https://api.github.com/repos/spotify/helios/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/helios/deployments","created_at":"2014-05-26T02:29:06Z","updated_at":"2016-04-25T12:52:26Z","pushed_at":"2016-04-25T17:08:26Z","git_url":"git://github.com/spotify/helios.git","ssh_url":"git@github.com:spotify/helios.git","clone_url":"https://github.com/spotify/helios.git","svn_url":"https://github.com/spotify/helios","homepage":null,"size":8152,"stargazers_count":1396,"watchers_count":1396,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":21,"forks":111,"open_issues":21,"watchers":1396,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"ef7f0ee862eb095e3a97ce72131e37cdc7aa25c1","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":20171642,"name":"helios","full_name":"spotify/helios","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/helios","description":"Docker container orchestration platform","fork":false,"url":"https://api.github.com/repos/spotify/helios","forks_url":"https://api.github.com/repos/spotify/helios/forks","keys_url":"https://api.github.com/repos/spotify/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/helios/teams","hooks_url":"https://api.github.com/repos/spotify/helios/hooks","issue_events_url":"https://api.github.com/repos/spotify/helios/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/helios/events","assignees_url":"https://api.github.com/repos/spotify/helios/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/helios/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/helios/tags","blobs_url":"https://api.github.com/repos/spotify/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/helios/languages","stargazers_url":"https://api.github.com/repos/spotify/helios/stargazers","contributors_url":"https://api.github.com/repos/spotify/helios/contributors","subscribers_url":"https://api.github.com/repos/spotify/helios/subscribers","subscription_url":"https://api.github.com/repos/spotify/helios/subscription","commits_url":"https://api.github.com/repos/spotify/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/helios/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/helios/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/helios/merges","archive_url":"https://api.github.com/repos/spotify/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/helios/downloads","issues_url":"https://api.github.com/repos/spotify/helios/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/helios/labels{/name}","releases_url":"https://api.github.com/repos/spotify/helios/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/helios/deployments","created_at":"2014-05-26T02:29:06Z","updated_at":"2016-04-25T12:52:26Z","pushed_at":"2016-04-25T17:08:26Z","git_url":"git://github.com/spotify/helios.git","ssh_url":"git@github.com:spotify/helios.git","clone_url":"https://github.com/spotify/helios.git","svn_url":"https://github.com/spotify/helios","homepage":null,"size":8152,"stargazers_count":1396,"watchers_count":1396,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"open_issues_count":21,"forks":111,"open_issues":21,"watchers":1396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/helios/pulls/905"},"html":{"href":"https://github.com/spotify/helios/pull/905"},"issue":{"href":"https://api.github.com/repos/spotify/helios/issues/905"},"comments":{"href":"https://api.github.com/repos/spotify/helios/issues/905/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/helios/pulls/905/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/helios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/helios/pulls/905/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/helios/statuses/2a9572a931e128023f160804cad2b5451335e774"}}}}