{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/oktal/pistache/pulls/5","id":77243544,"html_url":"https://github.com/oktal/pistache/pull/5","diff_url":"https://github.com/oktal/pistache/pull/5.diff","patch_url":"https://github.com/oktal/pistache/pull/5.patch","issue_url":"https://api.github.com/repos/oktal/pistache/issues/5","number":5,"state":"open","locked":false,"title":"[IMPORTANT] Memory related fixes","user":{"login":"santanusinha","id":1593063,"avatar_url":"https://avatars.githubusercontent.com/u/1593063?v=3","gravatar_id":"","url":"https://api.github.com/users/santanusinha","html_url":"https://github.com/santanusinha","followers_url":"https://api.github.com/users/santanusinha/followers","following_url":"https://api.github.com/users/santanusinha/following{/other_user}","gists_url":"https://api.github.com/users/santanusinha/gists{/gist_id}","starred_url":"https://api.github.com/users/santanusinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santanusinha/subscriptions","organizations_url":"https://api.github.com/users/santanusinha/orgs","repos_url":"https://api.github.com/users/santanusinha/repos","events_url":"https://api.github.com/users/santanusinha/events{/privacy}","received_events_url":"https://api.github.com/users/santanusinha/received_events","type":"User","site_admin":false},"body":"This pull fixes 3 issues reported by valgrind.\r\n\r\n**UMR issue:** Two variables were being used to loop but were not initialized in constructor) added them.\r\n**Major memory leak:** The HttpHeaders destructor was not virtual leading to memory leak in Net::Http::Header::Accept::parseRaw which add MimeType objects to a vector. This would leak ~150 bytes every single request. I ran about 400K requests (Hello world) and it already leaked 74MB+ memory. This would make the framework completely unusable.\r\n\r\nI request you to kindly run valgrind on your programs to detect these kinds of issues.","created_at":"2016-07-13T07:43:43Z","updated_at":"2016-07-13T07:43:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oktal/pistache/pulls/5/commits","review_comments_url":"https://api.github.com/repos/oktal/pistache/pulls/5/comments","review_comment_url":"https://api.github.com/repos/oktal/pistache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oktal/pistache/issues/5/comments","statuses_url":"https://api.github.com/repos/oktal/pistache/statuses/15b94f2d816ec326ef36f14d7b262126b124d500","head":{"label":"santanusinha:master","ref":"master","sha":"15b94f2d816ec326ef36f14d7b262126b124d500","user":{"login":"santanusinha","id":1593063,"avatar_url":"https://avatars.githubusercontent.com/u/1593063?v=3","gravatar_id":"","url":"https://api.github.com/users/santanusinha","html_url":"https://github.com/santanusinha","followers_url":"https://api.github.com/users/santanusinha/followers","following_url":"https://api.github.com/users/santanusinha/following{/other_user}","gists_url":"https://api.github.com/users/santanusinha/gists{/gist_id}","starred_url":"https://api.github.com/users/santanusinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santanusinha/subscriptions","organizations_url":"https://api.github.com/users/santanusinha/orgs","repos_url":"https://api.github.com/users/santanusinha/repos","events_url":"https://api.github.com/users/santanusinha/events{/privacy}","received_events_url":"https://api.github.com/users/santanusinha/received_events","type":"User","site_admin":false},"repo":{"id":63225025,"name":"pistache","full_name":"santanusinha/pistache","owner":{"login":"santanusinha","id":1593063,"avatar_url":"https://avatars.githubusercontent.com/u/1593063?v=3","gravatar_id":"","url":"https://api.github.com/users/santanusinha","html_url":"https://github.com/santanusinha","followers_url":"https://api.github.com/users/santanusinha/followers","following_url":"https://api.github.com/users/santanusinha/following{/other_user}","gists_url":"https://api.github.com/users/santanusinha/gists{/gist_id}","starred_url":"https://api.github.com/users/santanusinha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santanusinha/subscriptions","organizations_url":"https://api.github.com/users/santanusinha/orgs","repos_url":"https://api.github.com/users/santanusinha/repos","events_url":"https://api.github.com/users/santanusinha/events{/privacy}","received_events_url":"https://api.github.com/users/santanusinha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/santanusinha/pistache","description":"A high-performance REST Toolkit written in C++","fork":true,"url":"https://api.github.com/repos/santanusinha/pistache","forks_url":"https://api.github.com/repos/santanusinha/pistache/forks","keys_url":"https://api.github.com/repos/santanusinha/pistache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/santanusinha/pistache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/santanusinha/pistache/teams","hooks_url":"https://api.github.com/repos/santanusinha/pistache/hooks","issue_events_url":"https://api.github.com/repos/santanusinha/pistache/issues/events{/number}","events_url":"https://api.github.com/repos/santanusinha/pistache/events","assignees_url":"https://api.github.com/repos/santanusinha/pistache/assignees{/user}","branches_url":"https://api.github.com/repos/santanusinha/pistache/branches{/branch}","tags_url":"https://api.github.com/repos/santanusinha/pistache/tags","blobs_url":"https://api.github.com/repos/santanusinha/pistache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/santanusinha/pistache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/santanusinha/pistache/git/refs{/sha}","trees_url":"https://api.github.com/repos/santanusinha/pistache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/santanusinha/pistache/statuses/{sha}","languages_url":"https://api.github.com/repos/santanusinha/pistache/languages","stargazers_url":"https://api.github.com/repos/santanusinha/pistache/stargazers","contributors_url":"https://api.github.com/repos/santanusinha/pistache/contributors","subscribers_url":"https://api.github.com/repos/santanusinha/pistache/subscribers","subscription_url":"https://api.github.com/repos/santanusinha/pistache/subscription","commits_url":"https://api.github.com/repos/santanusinha/pistache/commits{/sha}","git_commits_url":"https://api.github.com/repos/santanusinha/pistache/git/commits{/sha}","comments_url":"https://api.github.com/repos/santanusinha/pistache/comments{/number}","issue_comment_url":"https://api.github.com/repos/santanusinha/pistache/issues/comments{/number}","contents_url":"https://api.github.com/repos/santanusinha/pistache/contents/{+path}","compare_url":"https://api.github.com/repos/santanusinha/pistache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/santanusinha/pistache/merges","archive_url":"https://api.github.com/repos/santanusinha/pistache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/santanusinha/pistache/downloads","issues_url":"https://api.github.com/repos/santanusinha/pistache/issues{/number}","pulls_url":"https://api.github.com/repos/santanusinha/pistache/pulls{/number}","milestones_url":"https://api.github.com/repos/santanusinha/pistache/milestones{/number}","notifications_url":"https://api.github.com/repos/santanusinha/pistache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/santanusinha/pistache/labels{/name}","releases_url":"https://api.github.com/repos/santanusinha/pistache/releases{/id}","deployments_url":"https://api.github.com/repos/santanusinha/pistache/deployments","created_at":"2016-07-13T07:36:19Z","updated_at":"2016-07-13T07:36:20Z","pushed_at":"2016-07-13T07:36:56Z","git_url":"git://github.com/santanusinha/pistache.git","ssh_url":"git@github.com:santanusinha/pistache.git","clone_url":"https://github.com/santanusinha/pistache.git","svn_url":"https://github.com/santanusinha/pistache","homepage":null,"size":1471,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oktal:master","ref":"master","sha":"41fada1ced950cdde632c0e41e6178b52ca02ac6","user":{"login":"oktal","id":859699,"avatar_url":"https://avatars.githubusercontent.com/u/859699?v=3","gravatar_id":"","url":"https://api.github.com/users/oktal","html_url":"https://github.com/oktal","followers_url":"https://api.github.com/users/oktal/followers","following_url":"https://api.github.com/users/oktal/following{/other_user}","gists_url":"https://api.github.com/users/oktal/gists{/gist_id}","starred_url":"https://api.github.com/users/oktal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktal/subscriptions","organizations_url":"https://api.github.com/users/oktal/orgs","repos_url":"https://api.github.com/users/oktal/repos","events_url":"https://api.github.com/users/oktal/events{/privacy}","received_events_url":"https://api.github.com/users/oktal/received_events","type":"User","site_admin":false},"repo":{"id":40620758,"name":"pistache","full_name":"oktal/pistache","owner":{"login":"oktal","id":859699,"avatar_url":"https://avatars.githubusercontent.com/u/859699?v=3","gravatar_id":"","url":"https://api.github.com/users/oktal","html_url":"https://github.com/oktal","followers_url":"https://api.github.com/users/oktal/followers","following_url":"https://api.github.com/users/oktal/following{/other_user}","gists_url":"https://api.github.com/users/oktal/gists{/gist_id}","starred_url":"https://api.github.com/users/oktal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktal/subscriptions","organizations_url":"https://api.github.com/users/oktal/orgs","repos_url":"https://api.github.com/users/oktal/repos","events_url":"https://api.github.com/users/oktal/events{/privacy}","received_events_url":"https://api.github.com/users/oktal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oktal/pistache","description":"A high-performance REST Toolkit written in C++","fork":false,"url":"https://api.github.com/repos/oktal/pistache","forks_url":"https://api.github.com/repos/oktal/pistache/forks","keys_url":"https://api.github.com/repos/oktal/pistache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oktal/pistache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oktal/pistache/teams","hooks_url":"https://api.github.com/repos/oktal/pistache/hooks","issue_events_url":"https://api.github.com/repos/oktal/pistache/issues/events{/number}","events_url":"https://api.github.com/repos/oktal/pistache/events","assignees_url":"https://api.github.com/repos/oktal/pistache/assignees{/user}","branches_url":"https://api.github.com/repos/oktal/pistache/branches{/branch}","tags_url":"https://api.github.com/repos/oktal/pistache/tags","blobs_url":"https://api.github.com/repos/oktal/pistache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oktal/pistache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oktal/pistache/git/refs{/sha}","trees_url":"https://api.github.com/repos/oktal/pistache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oktal/pistache/statuses/{sha}","languages_url":"https://api.github.com/repos/oktal/pistache/languages","stargazers_url":"https://api.github.com/repos/oktal/pistache/stargazers","contributors_url":"https://api.github.com/repos/oktal/pistache/contributors","subscribers_url":"https://api.github.com/repos/oktal/pistache/subscribers","subscription_url":"https://api.github.com/repos/oktal/pistache/subscription","commits_url":"https://api.github.com/repos/oktal/pistache/commits{/sha}","git_commits_url":"https://api.github.com/repos/oktal/pistache/git/commits{/sha}","comments_url":"https://api.github.com/repos/oktal/pistache/comments{/number}","issue_comment_url":"https://api.github.com/repos/oktal/pistache/issues/comments{/number}","contents_url":"https://api.github.com/repos/oktal/pistache/contents/{+path}","compare_url":"https://api.github.com/repos/oktal/pistache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oktal/pistache/merges","archive_url":"https://api.github.com/repos/oktal/pistache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oktal/pistache/downloads","issues_url":"https://api.github.com/repos/oktal/pistache/issues{/number}","pulls_url":"https://api.github.com/repos/oktal/pistache/pulls{/number}","milestones_url":"https://api.github.com/repos/oktal/pistache/milestones{/number}","notifications_url":"https://api.github.com/repos/oktal/pistache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oktal/pistache/labels{/name}","releases_url":"https://api.github.com/repos/oktal/pistache/releases{/id}","deployments_url":"https://api.github.com/repos/oktal/pistache/deployments","created_at":"2015-08-12T19:44:15Z","updated_at":"2016-07-12T21:22:51Z","pushed_at":"2016-06-29T13:20:26Z","git_url":"git://github.com/oktal/pistache.git","ssh_url":"git@github.com:oktal/pistache.git","clone_url":"https://github.com/oktal/pistache.git","svn_url":"https://github.com/oktal/pistache","homepage":null,"size":1471,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oktal/pistache/pulls/5"},"html":{"href":"https://github.com/oktal/pistache/pull/5"},"issue":{"href":"https://api.github.com/repos/oktal/pistache/issues/5"},"comments":{"href":"https://api.github.com/repos/oktal/pistache/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/oktal/pistache/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/oktal/pistache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oktal/pistache/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/oktal/pistache/statuses/15b94f2d816ec326ef36f14d7b262126b124d500"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":9,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"santanusinha"}}