{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/70557585","id":70557585,"diff_hunk":"@@ -157,26 +157,46 @@ def check_librt(cfg, env):\n     return ret\n \n @conf\n+def check_package(cfg, env, libname):\n+    '''use pkg-config to look for an installed library that has a LIBNAME.pc file'''\n+    cfg.check_cfg(package=libname, mandatory=False, global_define=True,\n+                  args=['--libs', '--cflags'])","path":"Tools/ardupilotwaf/cxx_checks.py","position":7,"original_position":7,"commit_id":"65f24872d2640e73a3e33229f92508f3234ca92a","original_commit_id":"ec83fd03640860dd5c99a49d33fd37d0c5dd925e","user":{"login":"guludo","id":6026123,"avatar_url":"https://avatars.githubusercontent.com/u/6026123?v=3","gravatar_id":"","url":"https://api.github.com/users/guludo","html_url":"https://github.com/guludo","followers_url":"https://api.github.com/users/guludo/followers","following_url":"https://api.github.com/users/guludo/following{/other_user}","gists_url":"https://api.github.com/users/guludo/gists{/gist_id}","starred_url":"https://api.github.com/users/guludo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guludo/subscriptions","organizations_url":"https://api.github.com/users/guludo/orgs","repos_url":"https://api.github.com/users/guludo/repos","events_url":"https://api.github.com/users/guludo/events{/privacy}","received_events_url":"https://api.github.com/users/guludo/received_events","type":"User","site_admin":false},"body":"I think it's safer to use have `uselib_store=libname.upper()` here as we are embedding the env values in the global scope.","created_at":"2016-07-13T02:46:59Z","updated_at":"2016-07-13T02:46:59Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/4461#discussion_r70557585","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/70557585"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/4461#discussion_r70557585"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461"}}},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461","id":77222109,"html_url":"https://github.com/ArduPilot/ardupilot/pull/4461","diff_url":"https://github.com/ArduPilot/ardupilot/pull/4461.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/4461.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4461","number":4461,"state":"open","locked":false,"title":"improve pkg-config library checking and add --static option","user":{"login":"tridge","id":831867,"avatar_url":"https://avatars.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"body":"this improves handling of library checks where the LIBNAME.pc file may refer to non-default include or lib directories\r\n","created_at":"2016-07-13T02:37:01Z","updated_at":"2016-07-13T02:46:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da47c19f22a976f0e8f24bd386d9ab495b1381b9","assignee":{"login":"lucasdemarchi","id":31864,"avatar_url":"https://avatars.githubusercontent.com/u/31864?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucasdemarchi","id":31864,"avatar_url":"https://avatars.githubusercontent.com/u/31864?v=3","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4461/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/65f24872d2640e73a3e33229f92508f3234ca92a","head":{"label":"tridge:pr-lib-checks","ref":"pr-lib-checks","sha":"65f24872d2640e73a3e33229f92508f3234ca92a","user":{"login":"tridge","id":831867,"avatar_url":"https://avatars.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"repo":{"id":7513848,"name":"ardupilot","full_name":"tridge/ardupilot","owner":{"login":"tridge","id":831867,"avatar_url":"https://avatars.githubusercontent.com/u/831867?v=3","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tridge/ardupilot","description":"","fork":true,"url":"https://api.github.com/repos/tridge/ardupilot","forks_url":"https://api.github.com/repos/tridge/ardupilot/forks","keys_url":"https://api.github.com/repos/tridge/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tridge/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tridge/ardupilot/teams","hooks_url":"https://api.github.com/repos/tridge/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/tridge/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/tridge/ardupilot/events","assignees_url":"https://api.github.com/repos/tridge/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/tridge/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/tridge/ardupilot/tags","blobs_url":"https://api.github.com/repos/tridge/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tridge/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tridge/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/tridge/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tridge/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/tridge/ardupilot/languages","stargazers_url":"https://api.github.com/repos/tridge/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/tridge/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/tridge/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/tridge/ardupilot/subscription","commits_url":"https://api.github.com/repos/tridge/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/tridge/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/tridge/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/tridge/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/tridge/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/tridge/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tridge/ardupilot/merges","archive_url":"https://api.github.com/repos/tridge/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tridge/ardupilot/downloads","issues_url":"https://api.github.com/repos/tridge/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/tridge/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/tridge/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/tridge/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tridge/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/tridge/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/tridge/ardupilot/deployments","created_at":"2013-01-09T02:57:15Z","updated_at":"2016-05-27T12:28:44Z","pushed_at":"2016-07-13T02:39:43Z","git_url":"git://github.com/tridge/ardupilot.git","ssh_url":"git@github.com:tridge/ardupilot.git","clone_url":"https://github.com/tridge/ardupilot.git","svn_url":"https://github.com/tridge/ardupilot","homepage":null,"size":115669,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":11,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"f3f34be9c407e14e2cac8c7532191d4657cbfd9e","user":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars.githubusercontent.com/u/17919847?v=3","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2016-07-13T00:32:51Z","pushed_at":"2016-07-13T02:39:45Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":139911,"stargazers_count":1957,"watchers_count":1957,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4140,"mirror_url":null,"open_issues_count":780,"forks":4140,"open_issues":780,"watchers":1957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/4461"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4461"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/4461/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/4461/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/65f24872d2640e73a3e33229f92508f3234ca92a"}}}}
{"actor":{"display_login":"guludo"}}