{"action":"closed","issue":{"url":"https://api.github.com/repos/errbotio/errbot/issues/736","repository_url":"https://api.github.com/repos/errbotio/errbot","labels_url":"https://api.github.com/repos/errbotio/errbot/issues/736/labels{/name}","comments_url":"https://api.github.com/repos/errbotio/errbot/issues/736/comments","events_url":"https://api.github.com/repos/errbotio/errbot/issues/736/events","html_url":"https://github.com/errbotio/errbot/issues/736","id":153087338,"number":736,"title":"No error message on plugin configuration exception","user":{"login":"cweiske","id":59036,"avatar_url":"https://avatars.githubusercontent.com/u/59036?v=3","gravatar_id":"","url":"https://api.github.com/users/cweiske","html_url":"https://github.com/cweiske","followers_url":"https://api.github.com/users/cweiske/followers","following_url":"https://api.github.com/users/cweiske/following{/other_user}","gists_url":"https://api.github.com/users/cweiske/gists{/gist_id}","starred_url":"https://api.github.com/users/cweiske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweiske/subscriptions","organizations_url":"https://api.github.com/users/cweiske/orgs","repos_url":"https://api.github.com/users/cweiske/repos","events_url":"https://api.github.com/users/cweiske/events{/privacy}","received_events_url":"https://api.github.com/users/cweiske/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/errbotio/errbot/labels/%23plugins","name":"#plugins","color":"c5def5"},{"url":"https://api.github.com/repos/errbotio/errbot/labels/%23usability","name":"#usability","color":"c5def5"},{"url":"https://api.github.com/repos/errbotio/errbot/labels/priority:%20low","name":"priority: low","color":"fef2c0"},{"url":"https://api.github.com/repos/errbotio/errbot/labels/type:%20bug","name":"type: bug","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":{"login":"gbin","id":975564,"avatar_url":"https://avatars.githubusercontent.com/u/975564?v=3","gravatar_id":"","url":"https://api.github.com/users/gbin","html_url":"https://github.com/gbin","followers_url":"https://api.github.com/users/gbin/followers","following_url":"https://api.github.com/users/gbin/following{/other_user}","gists_url":"https://api.github.com/users/gbin/gists{/gist_id}","starred_url":"https://api.github.com/users/gbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbin/subscriptions","organizations_url":"https://api.github.com/users/gbin/orgs","repos_url":"https://api.github.com/users/gbin/repos","events_url":"https://api.github.com/users/gbin/events{/privacy}","received_events_url":"https://api.github.com/users/gbin/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-04T18:50:54Z","updated_at":"2016-05-06T23:48:52Z","closed_at":"2016-05-06T23:48:52Z","body":"When plugin configuration fails (`check_configuration` raises a `errbot.utils.ValidationException`), I still get the message \"Plugin configuration done.\".\r\n\r\nThere should be an error message to the user instead.\r\n\r\nExample:\r\n```\r\n >>> !plugin config exec {'command': 'failure'}\r\n20:42:25 INFO     errbot.plugins.ACLS       Matching ACL {} against username gbin@localhost for command Plugins:plugin_config\r\n20:42:25 INFO     errbot.plugins.ACLS       Check if plugin_config is admin only command.\r\n20:42:25 INFO     errbot.errBot             Processing command 'plugin_config' with parameters 'exec {'command': 'failure'}' from gbin@localhost\r\n20:42:26 INFO     errbot.plugin_manager     Activating exec with min_err_version = 4.0.0 and max_version = 4.0.99\r\n20:42:26 ERROR    errbot.plugin_manager     Something is wrong with the configuration of the plugin exec\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python2.7/dist-packages/errbot/plugin_manager.py\", line 277, in activate_plugin_with_version_check\r\n    obj.check_configuration(config)\r\n  File \"/home/cweiske/Dev/tools/xmppexecbot/exec.py\", line 44, in check_configuration\r\n    self.executable_exists(configuration['command'])\r\n  File \"/home/cweiske/Dev/tools/xmppexecbot/exec.py\", line 31, in executable_exists\r\n    raise ValidationException('Command not in PATH')\r\nValidationException: Command not in PATH\r\n20:42:26 ERROR    errbot.plugin_manager     Error loading exec\r\nTraceback (most recent call last):\r\n  File \"/usr/local/lib/python2.7/dist-packages/errbot/plugin_manager.py\", line 452, in activate_plugin\r\n    self.activate_plugin_with_version_check(name, self.get_plugin_configuration(name))\r\n  File \"/usr/local/lib/python2.7/dist-packages/errbot/plugin_manager.py\", line 283, in activate_plugin_with_version_check\r\n    raise PluginConfigurationException(unicode(ex))\r\nPluginConfigurationException: Command not in PATH\r\n \r\n╌╌[MD  ]╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌\r\nPlugin configuration done.\r\n```"}}