{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/56329873","id":56329873,"diff_hunk":"@@ -36,7 +36,7 @@ type Settings struct {\n // Validate validates the Settings data and returns an error describing\n // all problems or nil if there are none.\n func (s Settings) Validate() error {\n-\tvalidKeys := []string{\"winlogbeat\", \"output\", \"shipper\", \"logging\"}\n+\tvalidKeys := []string{\"winlogbeat\", \"output\", \"beat\", \"logging\"}","path":"winlogbeat/config/config.go","position":5,"original_position":5,"commit_id":"91d24f5c3448c49a54da1c1b50b69409d30dc9fa","original_commit_id":"91d24f5c3448c49a54da1c1b50b69409d30dc9fa","user":{"login":"andrewkroh","id":4565752,"avatar_url":"https://avatars.githubusercontent.com/u/4565752?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewkroh","html_url":"https://github.com/andrewkroh","followers_url":"https://api.github.com/users/andrewkroh/followers","following_url":"https://api.github.com/users/andrewkroh/following{/other_user}","gists_url":"https://api.github.com/users/andrewkroh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkroh/subscriptions","organizations_url":"https://api.github.com/users/andrewkroh/orgs","repos_url":"https://api.github.com/users/andrewkroh/repos","events_url":"https://api.github.com/users/andrewkroh/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkroh/received_events","type":"User","site_admin":false},"body":"I think it will become a `ucfg.Option` that can be passed to `Unpack` that causes an error when a key is encountered that does not exist in the struct. I think urso has an open ticket in the repo to add the feature. \r\n\r\nOnce it's implemented this can be removed. It would hard to move to libbeat because not all Beats put their options under a top-level \"beatname\" key.","created_at":"2016-03-16T13:13:14Z","updated_at":"2016-03-16T13:13:14Z","html_url":"https://github.com/elastic/beats/pull/1165#discussion_r56329873","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/1165","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/56329873"},"html":{"href":"https://github.com/elastic/beats/pull/1165#discussion_r56329873"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/1165"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/1165","id":63051778,"html_url":"https://github.com/elastic/beats/pull/1165","diff_url":"https://github.com/elastic/beats/pull/1165.diff","patch_url":"https://github.com/elastic/beats/pull/1165.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/1165","number":1165,"state":"open","locked":false,"title":"Rename shipper config to beat","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"body":"This change is backward compatible, as shipper is still accepted but a warning will be printed out that shipper is deprecated. In case beat and shipper are set, an error is returned.\r\n\r\n* Docs were updated with new name\r\n* CHANEGLOG updated with change message","created_at":"2016-03-16T11:48:01Z","updated_at":"2016-03-16T13:13:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17cc493a2e14fef4f545f19a4d2b813586828901","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/1165/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/1165/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/1165/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/91d24f5c3448c49a54da1c1b50b69409d30dc9fa","head":{"label":"ruflin:beat-alias","ref":"beat-alias","sha":"91d24f5c3448c49a54da1c1b50b69409d30dc9fa","user":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"repo":{"id":40544282,"name":"beats","full_name":"ruflin/beats","owner":{"login":"ruflin","id":244900,"avatar_url":"https://avatars.githubusercontent.com/u/244900?v=3","gravatar_id":"","url":"https://api.github.com/users/ruflin","html_url":"https://github.com/ruflin","followers_url":"https://api.github.com/users/ruflin/followers","following_url":"https://api.github.com/users/ruflin/following{/other_user}","gists_url":"https://api.github.com/users/ruflin/gists{/gist_id}","starred_url":"https://api.github.com/users/ruflin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruflin/subscriptions","organizations_url":"https://api.github.com/users/ruflin/orgs","repos_url":"https://api.github.com/users/ruflin/repos","events_url":"https://api.github.com/users/ruflin/events{/privacy}","received_events_url":"https://api.github.com/users/ruflin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruflin/beats","description":"Beats - Lightweight shippers for Elasticsearch & Logstash","fork":true,"url":"https://api.github.com/repos/ruflin/beats","forks_url":"https://api.github.com/repos/ruflin/beats/forks","keys_url":"https://api.github.com/repos/ruflin/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruflin/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruflin/beats/teams","hooks_url":"https://api.github.com/repos/ruflin/beats/hooks","issue_events_url":"https://api.github.com/repos/ruflin/beats/issues/events{/number}","events_url":"https://api.github.com/repos/ruflin/beats/events","assignees_url":"https://api.github.com/repos/ruflin/beats/assignees{/user}","branches_url":"https://api.github.com/repos/ruflin/beats/branches{/branch}","tags_url":"https://api.github.com/repos/ruflin/beats/tags","blobs_url":"https://api.github.com/repos/ruflin/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruflin/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruflin/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruflin/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruflin/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/ruflin/beats/languages","stargazers_url":"https://api.github.com/repos/ruflin/beats/stargazers","contributors_url":"https://api.github.com/repos/ruflin/beats/contributors","subscribers_url":"https://api.github.com/repos/ruflin/beats/subscribers","subscription_url":"https://api.github.com/repos/ruflin/beats/subscription","commits_url":"https://api.github.com/repos/ruflin/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruflin/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruflin/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruflin/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruflin/beats/contents/{+path}","compare_url":"https://api.github.com/repos/ruflin/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruflin/beats/merges","archive_url":"https://api.github.com/repos/ruflin/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruflin/beats/downloads","issues_url":"https://api.github.com/repos/ruflin/beats/issues{/number}","pulls_url":"https://api.github.com/repos/ruflin/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/ruflin/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/ruflin/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruflin/beats/labels{/name}","releases_url":"https://api.github.com/repos/ruflin/beats/releases{/id}","deployments_url":"https://api.github.com/repos/ruflin/beats/deployments","created_at":"2015-08-11T13:49:02Z","updated_at":"2016-01-19T03:22:25Z","pushed_at":"2016-03-16T13:00:57Z","git_url":"git://github.com/ruflin/beats.git","ssh_url":"git@github.com:ruflin/beats.git","clone_url":"https://github.com/ruflin/beats.git","svn_url":"https://github.com/ruflin/beats","homepage":"https://www.elastic.co/products/beats","size":31235,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"0a621eee7a18892f30adabe4ae798034bcc9ea60","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":"Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2016-03-16T08:34:59Z","pushed_at":"2016-03-16T13:00:58Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":31235,"stargazers_count":2536,"watchers_count":2536,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":350,"mirror_url":null,"open_issues_count":210,"forks":350,"open_issues":210,"watchers":2536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/1165"},"html":{"href":"https://github.com/elastic/beats/pull/1165"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/1165"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/1165/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/1165/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/1165/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/91d24f5c3448c49a54da1c1b50b69409d30dc9fa"}}}}