{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/comments/79144090","id":79144090,"diff_hunk":"@@ -84,6 +88,15 @@ M2MBase::M2MBase(const M2MBase& other) :\n     _is_under_observation(other._is_under_observation),\n     _function_pointer(NULL)\n {\n+    _resource_type = alloc_copy(other._resource_type, other._resource_type_length);\n+    _resource_type_length = other._resource_type_length;\n+    _uri_path = alloc_copy(other._uri_path, other._uri_path_length);\n+    _uri_path_length = other._uri_path_length;\n+    _interface_description = alloc_copy(other._interface_description, other._uri_path_length);\n+    _interface_description_length = other._interface_description_length;\n+    _name = other._name;","path":"source/m2mbase.cpp","position":49,"original_position":49,"commit_id":"929541e798264c4cfff1550b6550b69c68032c25","original_commit_id":"929541e798264c4cfff1550b6550b69c68032c25","user":{"login":"TeroJaasko","id":12545862,"avatar_url":"https://avatars.githubusercontent.com/u/12545862?v=3","gravatar_id":"","url":"https://api.github.com/users/TeroJaasko","html_url":"https://github.com/TeroJaasko","followers_url":"https://api.github.com/users/TeroJaasko/followers","following_url":"https://api.github.com/users/TeroJaasko/following{/other_user}","gists_url":"https://api.github.com/users/TeroJaasko/gists{/gist_id}","starred_url":"https://api.github.com/users/TeroJaasko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeroJaasko/subscriptions","organizations_url":"https://api.github.com/users/TeroJaasko/orgs","repos_url":"https://api.github.com/users/TeroJaasko/repos","events_url":"https://api.github.com/users/TeroJaasko/events{/privacy}","received_events_url":"https://api.github.com/users/TeroJaasko/received_events","type":"User","site_admin":false},"body":"Is this new _name assignment really needed here, or is it part of the name-related code which is mostly in comments?","created_at":"2016-09-16T10:31:18Z","updated_at":"2016-09-16T10:31:19Z","html_url":"https://github.com/ARMmbed/mbed-client/pull/286#discussion_r79144090","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/comments/79144090"},"html":{"href":"https://github.com/ARMmbed/mbed-client/pull/286#discussion_r79144090"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286","id":85407126,"html_url":"https://github.com/ARMmbed/mbed-client/pull/286","diff_url":"https://github.com/ARMmbed/mbed-client/pull/286.diff","patch_url":"https://github.com/ARMmbed/mbed-client/pull/286.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues/286","number":286,"state":"open","locked":false,"title":"String to uint8_t* class member change for base class","user":{"login":"karsev","id":15995156,"avatar_url":"https://avatars.githubusercontent.com/u/15995156?v=3","gravatar_id":"","url":"https://api.github.com/users/karsev","html_url":"https://github.com/karsev","followers_url":"https://api.github.com/users/karsev/followers","following_url":"https://api.github.com/users/karsev/following{/other_user}","gists_url":"https://api.github.com/users/karsev/gists{/gist_id}","starred_url":"https://api.github.com/users/karsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karsev/subscriptions","organizations_url":"https://api.github.com/users/karsev/orgs","repos_url":"https://api.github.com/users/karsev/repos","events_url":"https://api.github.com/users/karsev/events{/privacy}","received_events_url":"https://api.github.com/users/karsev/received_events","type":"User","site_admin":false},"body":"@TeroJaasko ","created_at":"2016-09-15T13:46:38Z","updated_at":"2016-09-16T10:31:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63779de8924f095ac3fd02c820d9949f3a870fef","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues/286/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client/statuses/929541e798264c4cfff1550b6550b69c68032c25","head":{"label":"ARMmbed:base_memory_opt","ref":"base_memory_opt","sha":"929541e798264c4cfff1550b6550b69c68032c25","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":31664591,"name":"mbed-client","full_name":"ARMmbed/mbed-client","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-client","description":"C++ API for mbed-client","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-client","forks_url":"https://api.github.com/repos/ARMmbed/mbed-client/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-client/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-client/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-client/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-client/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-client/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-client/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-client/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-client/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-client/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-client/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-client/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-client/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-client/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-client/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-client/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-client/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-client/deployments","created_at":"2015-03-04T15:39:06Z","updated_at":"2016-08-17T06:16:16Z","pushed_at":"2016-09-16T07:49:22Z","git_url":"git://github.com/ARMmbed/mbed-client.git","ssh_url":"git@github.com:ARMmbed/mbed-client.git","clone_url":"https://github.com/ARMmbed/mbed-client.git","svn_url":"https://github.com/ARMmbed/mbed-client","homepage":"","size":3285,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":8,"forks":24,"open_issues":8,"watchers":37,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"51dbe894981ab0b576a42120a1ab087908f18995","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":31664591,"name":"mbed-client","full_name":"ARMmbed/mbed-client","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-client","description":"C++ API for mbed-client","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-client","forks_url":"https://api.github.com/repos/ARMmbed/mbed-client/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-client/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-client/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-client/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-client/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-client/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-client/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-client/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-client/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-client/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-client/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-client/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-client/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-client/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-client/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-client/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-client/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-client/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-client/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-client/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-client/deployments","created_at":"2015-03-04T15:39:06Z","updated_at":"2016-08-17T06:16:16Z","pushed_at":"2016-09-16T07:49:22Z","git_url":"git://github.com/ARMmbed/mbed-client.git","ssh_url":"git@github.com:ARMmbed/mbed-client.git","clone_url":"https://github.com/ARMmbed/mbed-client.git","svn_url":"https://github.com/ARMmbed/mbed-client","homepage":"","size":3285,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":8,"forks":24,"open_issues":8,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286"},"html":{"href":"https://github.com/ARMmbed/mbed-client/pull/286"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/issues/286"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-client/statuses/929541e798264c4cfff1550b6550b69c68032c25"}}}}
{"actor":{"display_login":"TeroJaasko"}}