{"action":"created","comment":{"url":"https://api.github.com/repos/open-guides/og-aws/pulls/comments/84831533","pull_request_review_id":5583142,"id":84831533,"diff_hunk":"@@ -28,7 +33,31 @@ If you’ve found this guide useful, you have many ways to help:\n -\t**Include opinions and common practice:** Thoughtful opinion is helpful. If there are multiple conventions or ideas on something held by experts, mention the different ones.\n -\t**Clarity:** Strive for consistency with conventions listed here, but clarity is most important.\n \n-### Writing Conventions\n+### Pull Request Review\n+\n+When creating a PR or reviewing one, it’s helpful to consider a few questions:\n+\n+1.\tAre relevant docs linked (AWS and third party blogs)?\n+2.\tCan more details be added without lengthening it significantly?\n+3.\tCan the same information be conveyed with more succinctly or more clearly?\n+4.\tCopy editing: Does it match the [writing style](#writing-style) and [conventions](#writing-conventions) (including emoji symbols, punctuation, and grammar)?\n+5.\tAre there any other parts of the guide that should be updated at the same time? (Examples are adding new sections to the table of contents, adding new internal links, rows to tables, etc.)\n+6.\tAre there additional improvements that should be filed as issues?\n+\n+### Editorial Process\n+\n+-\tRoles:\n+\t-\t**Project leads:** Own overall quality of the Guide, direction, and process.\n+\t-\t**Editors:** Contributors own specific sections or aspects of the Guide, reviewing PRs and/or writing. requires expert knowledge.\n+\t-\t**Experts:** People with expert knowledge in various areas, who have agreed to review or help on demand with tougher questions or PRs.","path":"CONTRIBUTING.md","position":56,"original_position":56,"commit_id":"2b5b3a7edc09de70348754b9975be6faa6e64faf","original_commit_id":"2b5b3a7edc09de70348754b9975be6faa6e64faf","user":{"login":"ThanosBaskous","id":1161523,"avatar_url":"https://avatars.githubusercontent.com/u/1161523?v=3","gravatar_id":"","url":"https://api.github.com/users/ThanosBaskous","html_url":"https://github.com/ThanosBaskous","followers_url":"https://api.github.com/users/ThanosBaskous/followers","following_url":"https://api.github.com/users/ThanosBaskous/following{/other_user}","gists_url":"https://api.github.com/users/ThanosBaskous/gists{/gist_id}","starred_url":"https://api.github.com/users/ThanosBaskous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThanosBaskous/subscriptions","organizations_url":"https://api.github.com/users/ThanosBaskous/orgs","repos_url":"https://api.github.com/users/ThanosBaskous/repos","events_url":"https://api.github.com/users/ThanosBaskous/events{/privacy}","received_events_url":"https://api.github.com/users/ThanosBaskous/received_events","type":"User","site_admin":false},"body":"Punctuation: I don't think the comma is necessary.","created_at":"2016-10-25T05:07:47Z","updated_at":"2016-10-25T05:07:47Z","html_url":"https://github.com/open-guides/og-aws/pull/260#discussion_r84831533","pull_request_url":"https://api.github.com/repos/open-guides/og-aws/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/open-guides/og-aws/pulls/comments/84831533"},"html":{"href":"https://github.com/open-guides/og-aws/pull/260#discussion_r84831533"},"pull_request":{"href":"https://api.github.com/repos/open-guides/og-aws/pulls/260"}}},"pull_request":{"url":"https://api.github.com/repos/open-guides/og-aws/pulls/260","id":90739831,"html_url":"https://github.com/open-guides/og-aws/pull/260","diff_url":"https://github.com/open-guides/og-aws/pull/260.diff","patch_url":"https://github.com/open-guides/og-aws/pull/260.patch","issue_url":"https://api.github.com/repos/open-guides/og-aws/issues/260","number":260,"state":"open","locked":false,"title":"A couple process things","user":{"login":"jlevy","id":2058167,"avatar_url":"https://avatars.githubusercontent.com/u/2058167?v=3","gravatar_id":"","url":"https://api.github.com/users/jlevy","html_url":"https://github.com/jlevy","followers_url":"https://api.github.com/users/jlevy/followers","following_url":"https://api.github.com/users/jlevy/following{/other_user}","gists_url":"https://api.github.com/users/jlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/jlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlevy/subscriptions","organizations_url":"https://api.github.com/users/jlevy/orgs","repos_url":"https://api.github.com/users/jlevy/repos","events_url":"https://api.github.com/users/jlevy/events{/privacy}","received_events_url":"https://api.github.com/users/jlevy/received_events","type":"User","site_admin":false},"body":"More on reviewing a PR\r\n\r\nDrop the Airtable link since it's better just to use Slack\r\n\r\nAlso trimmed some trailing whitespace.","created_at":"2016-10-25T05:03:38Z","updated_at":"2016-10-25T05:10:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f762e433647b0e76505a14431b2f8df9327efc3d","assignee":{"login":"ThanosBaskous","id":1161523,"avatar_url":"https://avatars.githubusercontent.com/u/1161523?v=3","gravatar_id":"","url":"https://api.github.com/users/ThanosBaskous","html_url":"https://github.com/ThanosBaskous","followers_url":"https://api.github.com/users/ThanosBaskous/followers","following_url":"https://api.github.com/users/ThanosBaskous/following{/other_user}","gists_url":"https://api.github.com/users/ThanosBaskous/gists{/gist_id}","starred_url":"https://api.github.com/users/ThanosBaskous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThanosBaskous/subscriptions","organizations_url":"https://api.github.com/users/ThanosBaskous/orgs","repos_url":"https://api.github.com/users/ThanosBaskous/repos","events_url":"https://api.github.com/users/ThanosBaskous/events{/privacy}","received_events_url":"https://api.github.com/users/ThanosBaskous/received_events","type":"User","site_admin":false},"assignees":[{"login":"ThanosBaskous","id":1161523,"avatar_url":"https://avatars.githubusercontent.com/u/1161523?v=3","gravatar_id":"","url":"https://api.github.com/users/ThanosBaskous","html_url":"https://github.com/ThanosBaskous","followers_url":"https://api.github.com/users/ThanosBaskous/followers","following_url":"https://api.github.com/users/ThanosBaskous/following{/other_user}","gists_url":"https://api.github.com/users/ThanosBaskous/gists{/gist_id}","starred_url":"https://api.github.com/users/ThanosBaskous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThanosBaskous/subscriptions","organizations_url":"https://api.github.com/users/ThanosBaskous/orgs","repos_url":"https://api.github.com/users/ThanosBaskous/repos","events_url":"https://api.github.com/users/ThanosBaskous/events{/privacy}","received_events_url":"https://api.github.com/users/ThanosBaskous/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-guides/og-aws/pulls/260/commits","review_comments_url":"https://api.github.com/repos/open-guides/og-aws/pulls/260/comments","review_comment_url":"https://api.github.com/repos/open-guides/og-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-guides/og-aws/issues/260/comments","statuses_url":"https://api.github.com/repos/open-guides/og-aws/statuses/2b5b3a7edc09de70348754b9975be6faa6e64faf","head":{"label":"open-guides:review-notes","ref":"review-notes","sha":"2b5b3a7edc09de70348754b9975be6faa6e64faf","user":{"login":"open-guides","id":17152571,"avatar_url":"https://avatars.githubusercontent.com/u/17152571?v=3","gravatar_id":"","url":"https://api.github.com/users/open-guides","html_url":"https://github.com/open-guides","followers_url":"https://api.github.com/users/open-guides/followers","following_url":"https://api.github.com/users/open-guides/following{/other_user}","gists_url":"https://api.github.com/users/open-guides/gists{/gist_id}","starred_url":"https://api.github.com/users/open-guides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-guides/subscriptions","organizations_url":"https://api.github.com/users/open-guides/orgs","repos_url":"https://api.github.com/users/open-guides/repos","events_url":"https://api.github.com/users/open-guides/events{/privacy}","received_events_url":"https://api.github.com/users/open-guides/received_events","type":"Organization","site_admin":false},"repo":{"id":63266213,"name":"og-aws","full_name":"open-guides/og-aws","owner":{"login":"open-guides","id":17152571,"avatar_url":"https://avatars.githubusercontent.com/u/17152571?v=3","gravatar_id":"","url":"https://api.github.com/users/open-guides","html_url":"https://github.com/open-guides","followers_url":"https://api.github.com/users/open-guides/followers","following_url":"https://api.github.com/users/open-guides/following{/other_user}","gists_url":"https://api.github.com/users/open-guides/gists{/gist_id}","starred_url":"https://api.github.com/users/open-guides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-guides/subscriptions","organizations_url":"https://api.github.com/users/open-guides/orgs","repos_url":"https://api.github.com/users/open-guides/repos","events_url":"https://api.github.com/users/open-guides/events{/privacy}","received_events_url":"https://api.github.com/users/open-guides/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-guides/og-aws","description":"📙 Amazon Web Services — a practical guide","fork":false,"url":"https://api.github.com/repos/open-guides/og-aws","forks_url":"https://api.github.com/repos/open-guides/og-aws/forks","keys_url":"https://api.github.com/repos/open-guides/og-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-guides/og-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-guides/og-aws/teams","hooks_url":"https://api.github.com/repos/open-guides/og-aws/hooks","issue_events_url":"https://api.github.com/repos/open-guides/og-aws/issues/events{/number}","events_url":"https://api.github.com/repos/open-guides/og-aws/events","assignees_url":"https://api.github.com/repos/open-guides/og-aws/assignees{/user}","branches_url":"https://api.github.com/repos/open-guides/og-aws/branches{/branch}","tags_url":"https://api.github.com/repos/open-guides/og-aws/tags","blobs_url":"https://api.github.com/repos/open-guides/og-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-guides/og-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-guides/og-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-guides/og-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-guides/og-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/open-guides/og-aws/languages","stargazers_url":"https://api.github.com/repos/open-guides/og-aws/stargazers","contributors_url":"https://api.github.com/repos/open-guides/og-aws/contributors","subscribers_url":"https://api.github.com/repos/open-guides/og-aws/subscribers","subscription_url":"https://api.github.com/repos/open-guides/og-aws/subscription","commits_url":"https://api.github.com/repos/open-guides/og-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-guides/og-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-guides/og-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-guides/og-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-guides/og-aws/contents/{+path}","compare_url":"https://api.github.com/repos/open-guides/og-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-guides/og-aws/merges","archive_url":"https://api.github.com/repos/open-guides/og-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-guides/og-aws/downloads","issues_url":"https://api.github.com/repos/open-guides/og-aws/issues{/number}","pulls_url":"https://api.github.com/repos/open-guides/og-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/open-guides/og-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/open-guides/og-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-guides/og-aws/labels{/name}","releases_url":"https://api.github.com/repos/open-guides/og-aws/releases{/id}","deployments_url":"https://api.github.com/repos/open-guides/og-aws/deployments","created_at":"2016-07-13T17:30:16Z","updated_at":"2016-10-25T05:09:38Z","pushed_at":"2016-10-25T05:03:38Z","git_url":"git://github.com/open-guides/og-aws.git","ssh_url":"git@github.com:open-guides/og-aws.git","clone_url":"https://github.com/open-guides/og-aws.git","svn_url":"https://github.com/open-guides/og-aws","homepage":"","size":5520,"stargazers_count":13565,"watchers_count":13565,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":743,"mirror_url":null,"open_issues_count":82,"forks":743,"open_issues":82,"watchers":13565,"default_branch":"master"}},"base":{"label":"open-guides:master","ref":"master","sha":"9a95eb331c17b0f6ba384a4b72b28fe53f0338cd","user":{"login":"open-guides","id":17152571,"avatar_url":"https://avatars.githubusercontent.com/u/17152571?v=3","gravatar_id":"","url":"https://api.github.com/users/open-guides","html_url":"https://github.com/open-guides","followers_url":"https://api.github.com/users/open-guides/followers","following_url":"https://api.github.com/users/open-guides/following{/other_user}","gists_url":"https://api.github.com/users/open-guides/gists{/gist_id}","starred_url":"https://api.github.com/users/open-guides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-guides/subscriptions","organizations_url":"https://api.github.com/users/open-guides/orgs","repos_url":"https://api.github.com/users/open-guides/repos","events_url":"https://api.github.com/users/open-guides/events{/privacy}","received_events_url":"https://api.github.com/users/open-guides/received_events","type":"Organization","site_admin":false},"repo":{"id":63266213,"name":"og-aws","full_name":"open-guides/og-aws","owner":{"login":"open-guides","id":17152571,"avatar_url":"https://avatars.githubusercontent.com/u/17152571?v=3","gravatar_id":"","url":"https://api.github.com/users/open-guides","html_url":"https://github.com/open-guides","followers_url":"https://api.github.com/users/open-guides/followers","following_url":"https://api.github.com/users/open-guides/following{/other_user}","gists_url":"https://api.github.com/users/open-guides/gists{/gist_id}","starred_url":"https://api.github.com/users/open-guides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-guides/subscriptions","organizations_url":"https://api.github.com/users/open-guides/orgs","repos_url":"https://api.github.com/users/open-guides/repos","events_url":"https://api.github.com/users/open-guides/events{/privacy}","received_events_url":"https://api.github.com/users/open-guides/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-guides/og-aws","description":"📙 Amazon Web Services — a practical guide","fork":false,"url":"https://api.github.com/repos/open-guides/og-aws","forks_url":"https://api.github.com/repos/open-guides/og-aws/forks","keys_url":"https://api.github.com/repos/open-guides/og-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-guides/og-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-guides/og-aws/teams","hooks_url":"https://api.github.com/repos/open-guides/og-aws/hooks","issue_events_url":"https://api.github.com/repos/open-guides/og-aws/issues/events{/number}","events_url":"https://api.github.com/repos/open-guides/og-aws/events","assignees_url":"https://api.github.com/repos/open-guides/og-aws/assignees{/user}","branches_url":"https://api.github.com/repos/open-guides/og-aws/branches{/branch}","tags_url":"https://api.github.com/repos/open-guides/og-aws/tags","blobs_url":"https://api.github.com/repos/open-guides/og-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-guides/og-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-guides/og-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-guides/og-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-guides/og-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/open-guides/og-aws/languages","stargazers_url":"https://api.github.com/repos/open-guides/og-aws/stargazers","contributors_url":"https://api.github.com/repos/open-guides/og-aws/contributors","subscribers_url":"https://api.github.com/repos/open-guides/og-aws/subscribers","subscription_url":"https://api.github.com/repos/open-guides/og-aws/subscription","commits_url":"https://api.github.com/repos/open-guides/og-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-guides/og-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-guides/og-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-guides/og-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-guides/og-aws/contents/{+path}","compare_url":"https://api.github.com/repos/open-guides/og-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-guides/og-aws/merges","archive_url":"https://api.github.com/repos/open-guides/og-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-guides/og-aws/downloads","issues_url":"https://api.github.com/repos/open-guides/og-aws/issues{/number}","pulls_url":"https://api.github.com/repos/open-guides/og-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/open-guides/og-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/open-guides/og-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-guides/og-aws/labels{/name}","releases_url":"https://api.github.com/repos/open-guides/og-aws/releases{/id}","deployments_url":"https://api.github.com/repos/open-guides/og-aws/deployments","created_at":"2016-07-13T17:30:16Z","updated_at":"2016-10-25T05:09:38Z","pushed_at":"2016-10-25T05:03:38Z","git_url":"git://github.com/open-guides/og-aws.git","ssh_url":"git@github.com:open-guides/og-aws.git","clone_url":"https://github.com/open-guides/og-aws.git","svn_url":"https://github.com/open-guides/og-aws","homepage":"","size":5520,"stargazers_count":13565,"watchers_count":13565,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":743,"mirror_url":null,"open_issues_count":82,"forks":743,"open_issues":82,"watchers":13565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-guides/og-aws/pulls/260"},"html":{"href":"https://github.com/open-guides/og-aws/pull/260"},"issue":{"href":"https://api.github.com/repos/open-guides/og-aws/issues/260"},"comments":{"href":"https://api.github.com/repos/open-guides/og-aws/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/open-guides/og-aws/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/open-guides/og-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-guides/og-aws/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/open-guides/og-aws/statuses/2b5b3a7edc09de70348754b9975be6faa6e64faf"}}}}
{"actor":{"display_login":"ThanosBaskous"}}