{"action":"created","issue":{"url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46","repository_url":"https://api.github.com/repos/voxpupuli/puppet-kafka","labels_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46/comments","events_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46/events","html_url":"https://github.com/voxpupuli/puppet-kafka/pull/46","id":139829350,"number":46,"title":"Fix classes broker::consumer and broker::producer","user":{"login":"dhoppe","id":1111056,"avatar_url":"https://avatars.githubusercontent.com/u/1111056?v=3","gravatar_id":"","url":"https://api.github.com/users/dhoppe","html_url":"https://github.com/dhoppe","followers_url":"https://api.github.com/users/dhoppe/followers","following_url":"https://api.github.com/users/dhoppe/following{/other_user}","gists_url":"https://api.github.com/users/dhoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/dhoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhoppe/subscriptions","organizations_url":"https://api.github.com/users/dhoppe/orgs","repos_url":"https://api.github.com/users/dhoppe/repos","events_url":"https://api.github.com/users/dhoppe/events{/privacy}","received_events_url":"https://api.github.com/users/dhoppe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-10T09:13:56Z","updated_at":"2016-03-10T09:16:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-kafka/pulls/46","html_url":"https://github.com/voxpupuli/puppet-kafka/pull/46","diff_url":"https://github.com/voxpupuli/puppet-kafka/pull/46.diff","patch_url":"https://github.com/voxpupuli/puppet-kafka/pull/46.patch"},"body":"I am writing a couple of beaker tests and came across the following problems:\r\n\r\nThe generated Inits Scripts were broken because of\r\n- missing equal signs\r\n- empty parameters\r\n- obsolete parameters\r\n- some parameters are required\r\n- wrong process names\r\n\r\nThe file resource did not notified the correct service and the config parameters for properties file or Init Script should be managed at the main class. \r\n\r\nI know that this would force a major release, but on the other hand this part of the Kafka module could not have worked before. "},"comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/comments/194747501","html_url":"https://github.com/voxpupuli/puppet-kafka/pull/46#issuecomment-194747501","issue_url":"https://api.github.com/repos/voxpupuli/puppet-kafka/issues/46","id":194747501,"user":{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars.githubusercontent.com/u/341866?v=3","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"created_at":"2016-03-10T09:16:32Z","updated_at":"2016-03-10T09:16:32Z","body":"could you add a note to the README.md that a major release is required the next time?"}}