{"action":"created","issue":{"url":"https://api.github.com/repos/zmap/zmap/issues/380","repository_url":"https://api.github.com/repos/zmap/zmap","labels_url":"https://api.github.com/repos/zmap/zmap/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/zmap/zmap/issues/380/comments","events_url":"https://api.github.com/repos/zmap/zmap/issues/380/events","html_url":"https://github.com/zmap/zmap/pull/380","id":177279067,"number":380,"title":"Add clang-format check to TravisCI build","user":{"login":"dadrian","id":1158264,"avatar_url":"https://avatars.githubusercontent.com/u/1158264?v=3","gravatar_id":"","url":"https://api.github.com/users/dadrian","html_url":"https://github.com/dadrian","followers_url":"https://api.github.com/users/dadrian/followers","following_url":"https://api.github.com/users/dadrian/following{/other_user}","gists_url":"https://api.github.com/users/dadrian/gists{/gist_id}","starred_url":"https://api.github.com/users/dadrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadrian/subscriptions","organizations_url":"https://api.github.com/users/dadrian/orgs","repos_url":"https://api.github.com/users/dadrian/repos","events_url":"https://api.github.com/users/dadrian/events{/privacy}","received_events_url":"https://api.github.com/users/dadrian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-15T20:20:33Z","updated_at":"2016-09-16T15:29:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zmap/zmap/pulls/380","html_url":"https://github.com/zmap/zmap/pull/380","diff_url":"https://github.com/zmap/zmap/pull/380.diff","patch_url":"https://github.com/zmap/zmap/pull/380.patch"},"body":"I'm not totally sure we want this, but I got nerd sniped hard core on it yesterday.\r\n\r\nThis adds a `.clang-format` file to ZMap, written for Clang Formatter 4.0, and adds the commands `make format` and `make format-check`, which format, and check to see if formatting is required, respectively. `make format-check` is added to the TravisCI build process on OS X only, since current versions of Ubuntu do not have clang-format 4.0 available (Trusty have 3.5, Xenial has 3.8).\r\n\r\nThe formatting rules follow kernel style with one deviation: use 4-space tabs, spaces instead of tabs, rather than 8-space tab characters as tabs.\r\n\r\nThis also runs the formatter on the code. The non-formatting changes are in the following files:\r\n* `.clang-format`\r\n* `.travis.yml`\r\n* `scripts/check_style.sh`\r\n* `scripts/style.py`\r\n\r\n@zakird @paul-pearce @ppannuto "},"comment":{"url":"https://api.github.com/repos/zmap/zmap/issues/comments/247630956","html_url":"https://github.com/zmap/zmap/pull/380#issuecomment-247630956","issue_url":"https://api.github.com/repos/zmap/zmap/issues/380","id":247630956,"user":{"login":"dadrian","id":1158264,"avatar_url":"https://avatars.githubusercontent.com/u/1158264?v=3","gravatar_id":"","url":"https://api.github.com/users/dadrian","html_url":"https://github.com/dadrian","followers_url":"https://api.github.com/users/dadrian/followers","following_url":"https://api.github.com/users/dadrian/following{/other_user}","gists_url":"https://api.github.com/users/dadrian/gists{/gist_id}","starred_url":"https://api.github.com/users/dadrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadrian/subscriptions","organizations_url":"https://api.github.com/users/dadrian/orgs","repos_url":"https://api.github.com/users/dadrian/repos","events_url":"https://api.github.com/users/dadrian/events{/privacy}","received_events_url":"https://api.github.com/users/dadrian/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T15:29:11Z","updated_at":"2016-09-16T15:29:11Z","body":"It appears the the formatter is currently aligning function arguments when a function declaration spans more than one line, rather than just indenting lines 2-N twice. It's unclear if that is consistent with kernel style or not, it's certainly not what we were doing previously. Thoughts?"}}
{"actor":{"display_login":"dadrian"}}