{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/13226","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13226/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13226/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13226/events","html_url":"https://github.com/joomla/joomla-cms/issues/13226","id":195769404,"number":13226,"title":"[com_fields] New methods in library have no unittests","user":{"login":"Hackwar","id":313866,"avatar_url":"https://avatars.githubusercontent.com/u/313866?v=3","gravatar_id":"","url":"https://api.github.com/users/Hackwar","html_url":"https://github.com/Hackwar","followers_url":"https://api.github.com/users/Hackwar/followers","following_url":"https://api.github.com/users/Hackwar/following{/other_user}","gists_url":"https://api.github.com/users/Hackwar/gists{/gist_id}","starred_url":"https://api.github.com/users/Hackwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hackwar/subscriptions","organizations_url":"https://api.github.com/users/Hackwar/orgs","repos_url":"https://api.github.com/users/Hackwar/repos","events_url":"https://api.github.com/users/Hackwar/events{/privacy}","received_events_url":"https://api.github.com/users/Hackwar/received_events","type":"User","site_admin":false},"labels":[{"id":138443932,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/No%20Code%20Attached%20Yet","name":"No Code Attached Yet","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-15T10:30:40Z","updated_at":"2016-12-30T12:33:06Z","closed_at":null,"body":"The new field feature added at least 3 methods to JFormField and maybe there are even more. Neither of those methods has unittests. We should actually have unittests for both the methods in /libraries and the fields plugin, since these interact with third party code, similar to the finder code. But I could live without covering the plugins code. The methods in /libraries are a must however.\r\n\r\nThis is part of a code review of the fields feature. See #13222, #13223, #13224, #13225 and other connected issues."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/269766748","html_url":"https://github.com/joomla/joomla-cms/issues/13226#issuecomment-269766748","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13226","id":269766748,"user":{"login":"laoneo","id":251072,"avatar_url":"https://avatars.githubusercontent.com/u/251072?v=3","gravatar_id":"","url":"https://api.github.com/users/laoneo","html_url":"https://github.com/laoneo","followers_url":"https://api.github.com/users/laoneo/followers","following_url":"https://api.github.com/users/laoneo/following{/other_user}","gists_url":"https://api.github.com/users/laoneo/gists{/gist_id}","starred_url":"https://api.github.com/users/laoneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laoneo/subscriptions","organizations_url":"https://api.github.com/users/laoneo/orgs","repos_url":"https://api.github.com/users/laoneo/repos","events_url":"https://api.github.com/users/laoneo/events{/privacy}","received_events_url":"https://api.github.com/users/laoneo/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T12:33:06Z","updated_at":"2016-12-30T12:33:06Z","body":"The new functions in JFormField will get removed with pr #13319. So I guess we can close this one then."}}
{"actor":{"display_login":"laoneo"}}