{"action":"closed","number":850,"pull_request":{"url":"https://api.github.com/repos/qorelanguage/qore/pulls/850","id":69640122,"html_url":"https://github.com/qorelanguage/qore/pull/850","diff_url":"https://github.com/qorelanguage/qore/pull/850.diff","patch_url":"https://github.com/qorelanguage/qore/pull/850.patch","issue_url":"https://api.github.com/repos/qorelanguage/qore/issues/850","number":850,"state":"closed","locked":false,"title":"Feature/csv util multi type","user":{"login":"tmandys","id":10338727,"avatar_url":"https://avatars.githubusercontent.com/u/10338727?v=3","gravatar_id":"","url":"https://api.github.com/users/tmandys","html_url":"https://github.com/tmandys","followers_url":"https://api.github.com/users/tmandys/followers","following_url":"https://api.github.com/users/tmandys/following{/other_user}","gists_url":"https://api.github.com/users/tmandys/gists{/gist_id}","starred_url":"https://api.github.com/users/tmandys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmandys/subscriptions","organizations_url":"https://api.github.com/users/tmandys/orgs","repos_url":"https://api.github.com/users/tmandys/repos","events_url":"https://api.github.com/users/tmandys/events{/privacy}","received_events_url":"https://api.github.com/users/tmandys/received_events","type":"User","site_admin":false},"body":"I have finished multi-type support for CSV. Please review implementation. The key is headers defining particular headers as hash if multi-type is to be used. I tried similar approach as FixedLengthUtil but finally I've simplified by options.resolve_type function to evaluate line type. Advantage is we can reuse the same code for both iterator and writer, no overriding of virtual function.\r\nHopefully implementation does not break any functionality. Unit test and doc is updated too. Unfortunately there are no stress tests for CsvUtil testing all possible options. Extra test file included but the same is in doxygen part.\r\n[test.zip](https://github.com/qorelanguage/qore/files/258943/test.zip)\r\n\r\n","created_at":"2016-05-11T09:25:06Z","updated_at":"2016-06-02T17:26:31Z","closed_at":"2016-06-02T17:26:31Z","merged_at":null,"merge_commit_sha":"8876c3ab6d946c9c3aadf00577506531c68c87d5","assignee":{"login":"tmandys","id":10338727,"avatar_url":"https://avatars.githubusercontent.com/u/10338727?v=3","gravatar_id":"","url":"https://api.github.com/users/tmandys","html_url":"https://github.com/tmandys","followers_url":"https://api.github.com/users/tmandys/followers","following_url":"https://api.github.com/users/tmandys/following{/other_user}","gists_url":"https://api.github.com/users/tmandys/gists{/gist_id}","starred_url":"https://api.github.com/users/tmandys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmandys/subscriptions","organizations_url":"https://api.github.com/users/tmandys/orgs","repos_url":"https://api.github.com/users/tmandys/repos","events_url":"https://api.github.com/users/tmandys/events{/privacy}","received_events_url":"https://api.github.com/users/tmandys/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/qorelanguage/qore/pulls/850/commits","review_comments_url":"https://api.github.com/repos/qorelanguage/qore/pulls/850/comments","review_comment_url":"https://api.github.com/repos/qorelanguage/qore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qorelanguage/qore/issues/850/comments","statuses_url":"https://api.github.com/repos/qorelanguage/qore/statuses/ce2c0e2f34526a8f81fd6017a4abd166a06cb711","head":{"label":"qorelanguage:feature/CsvUtil-multi-type","ref":"feature/CsvUtil-multi-type","sha":"ce2c0e2f34526a8f81fd6017a4abd166a06cb711","user":{"login":"qorelanguage","id":13414799,"avatar_url":"https://avatars.githubusercontent.com/u/13414799?v=3","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"repo":{"id":39378616,"name":"qore","full_name":"qorelanguage/qore","owner":{"login":"qorelanguage","id":13414799,"avatar_url":"https://avatars.githubusercontent.com/u/13414799?v=3","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qorelanguage/qore","description":"Qore Programming Language","fork":false,"url":"https://api.github.com/repos/qorelanguage/qore","forks_url":"https://api.github.com/repos/qorelanguage/qore/forks","keys_url":"https://api.github.com/repos/qorelanguage/qore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qorelanguage/qore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qorelanguage/qore/teams","hooks_url":"https://api.github.com/repos/qorelanguage/qore/hooks","issue_events_url":"https://api.github.com/repos/qorelanguage/qore/issues/events{/number}","events_url":"https://api.github.com/repos/qorelanguage/qore/events","assignees_url":"https://api.github.com/repos/qorelanguage/qore/assignees{/user}","branches_url":"https://api.github.com/repos/qorelanguage/qore/branches{/branch}","tags_url":"https://api.github.com/repos/qorelanguage/qore/tags","blobs_url":"https://api.github.com/repos/qorelanguage/qore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qorelanguage/qore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qorelanguage/qore/git/refs{/sha}","trees_url":"https://api.github.com/repos/qorelanguage/qore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qorelanguage/qore/statuses/{sha}","languages_url":"https://api.github.com/repos/qorelanguage/qore/languages","stargazers_url":"https://api.github.com/repos/qorelanguage/qore/stargazers","contributors_url":"https://api.github.com/repos/qorelanguage/qore/contributors","subscribers_url":"https://api.github.com/repos/qorelanguage/qore/subscribers","subscription_url":"https://api.github.com/repos/qorelanguage/qore/subscription","commits_url":"https://api.github.com/repos/qorelanguage/qore/commits{/sha}","git_commits_url":"https://api.github.com/repos/qorelanguage/qore/git/commits{/sha}","comments_url":"https://api.github.com/repos/qorelanguage/qore/comments{/number}","issue_comment_url":"https://api.github.com/repos/qorelanguage/qore/issues/comments{/number}","contents_url":"https://api.github.com/repos/qorelanguage/qore/contents/{+path}","compare_url":"https://api.github.com/repos/qorelanguage/qore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qorelanguage/qore/merges","archive_url":"https://api.github.com/repos/qorelanguage/qore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qorelanguage/qore/downloads","issues_url":"https://api.github.com/repos/qorelanguage/qore/issues{/number}","pulls_url":"https://api.github.com/repos/qorelanguage/qore/pulls{/number}","milestones_url":"https://api.github.com/repos/qorelanguage/qore/milestones{/number}","notifications_url":"https://api.github.com/repos/qorelanguage/qore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qorelanguage/qore/labels{/name}","releases_url":"https://api.github.com/repos/qorelanguage/qore/releases{/id}","deployments_url":"https://api.github.com/repos/qorelanguage/qore/deployments","created_at":"2015-07-20T10:52:09Z","updated_at":"2016-03-06T02:15:27Z","pushed_at":"2016-06-02T17:00:19Z","git_url":"git://github.com/qorelanguage/qore.git","ssh_url":"git@github.com:qorelanguage/qore.git","clone_url":"https://github.com/qorelanguage/qore.git","svn_url":"https://github.com/qorelanguage/qore","homepage":null,"size":33420,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":104,"forks":4,"open_issues":104,"watchers":8,"default_branch":"develop"}},"base":{"label":"qorelanguage:develop","ref":"develop","sha":"d84e7ae2905b190d76ee191f49fb8aa26ebdf3d7","user":{"login":"qorelanguage","id":13414799,"avatar_url":"https://avatars.githubusercontent.com/u/13414799?v=3","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"repo":{"id":39378616,"name":"qore","full_name":"qorelanguage/qore","owner":{"login":"qorelanguage","id":13414799,"avatar_url":"https://avatars.githubusercontent.com/u/13414799?v=3","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qorelanguage/qore","description":"Qore Programming Language","fork":false,"url":"https://api.github.com/repos/qorelanguage/qore","forks_url":"https://api.github.com/repos/qorelanguage/qore/forks","keys_url":"https://api.github.com/repos/qorelanguage/qore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qorelanguage/qore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qorelanguage/qore/teams","hooks_url":"https://api.github.com/repos/qorelanguage/qore/hooks","issue_events_url":"https://api.github.com/repos/qorelanguage/qore/issues/events{/number}","events_url":"https://api.github.com/repos/qorelanguage/qore/events","assignees_url":"https://api.github.com/repos/qorelanguage/qore/assignees{/user}","branches_url":"https://api.github.com/repos/qorelanguage/qore/branches{/branch}","tags_url":"https://api.github.com/repos/qorelanguage/qore/tags","blobs_url":"https://api.github.com/repos/qorelanguage/qore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qorelanguage/qore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qorelanguage/qore/git/refs{/sha}","trees_url":"https://api.github.com/repos/qorelanguage/qore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qorelanguage/qore/statuses/{sha}","languages_url":"https://api.github.com/repos/qorelanguage/qore/languages","stargazers_url":"https://api.github.com/repos/qorelanguage/qore/stargazers","contributors_url":"https://api.github.com/repos/qorelanguage/qore/contributors","subscribers_url":"https://api.github.com/repos/qorelanguage/qore/subscribers","subscription_url":"https://api.github.com/repos/qorelanguage/qore/subscription","commits_url":"https://api.github.com/repos/qorelanguage/qore/commits{/sha}","git_commits_url":"https://api.github.com/repos/qorelanguage/qore/git/commits{/sha}","comments_url":"https://api.github.com/repos/qorelanguage/qore/comments{/number}","issue_comment_url":"https://api.github.com/repos/qorelanguage/qore/issues/comments{/number}","contents_url":"https://api.github.com/repos/qorelanguage/qore/contents/{+path}","compare_url":"https://api.github.com/repos/qorelanguage/qore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qorelanguage/qore/merges","archive_url":"https://api.github.com/repos/qorelanguage/qore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qorelanguage/qore/downloads","issues_url":"https://api.github.com/repos/qorelanguage/qore/issues{/number}","pulls_url":"https://api.github.com/repos/qorelanguage/qore/pulls{/number}","milestones_url":"https://api.github.com/repos/qorelanguage/qore/milestones{/number}","notifications_url":"https://api.github.com/repos/qorelanguage/qore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qorelanguage/qore/labels{/name}","releases_url":"https://api.github.com/repos/qorelanguage/qore/releases{/id}","deployments_url":"https://api.github.com/repos/qorelanguage/qore/deployments","created_at":"2015-07-20T10:52:09Z","updated_at":"2016-03-06T02:15:27Z","pushed_at":"2016-06-02T17:00:19Z","git_url":"git://github.com/qorelanguage/qore.git","ssh_url":"git@github.com:qorelanguage/qore.git","clone_url":"https://github.com/qorelanguage/qore.git","svn_url":"https://github.com/qorelanguage/qore","homepage":null,"size":33420,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":104,"forks":4,"open_issues":104,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/qorelanguage/qore/pulls/850"},"html":{"href":"https://github.com/qorelanguage/qore/pull/850"},"issue":{"href":"https://api.github.com/repos/qorelanguage/qore/issues/850"},"comments":{"href":"https://api.github.com/repos/qorelanguage/qore/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/qorelanguage/qore/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/qorelanguage/qore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qorelanguage/qore/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/qorelanguage/qore/statuses/ce2c0e2f34526a8f81fd6017a4abd166a06cb711"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":9,"review_comments":16,"commits":17,"additions":367,"deletions":104,"changed_files":3}}
{"actor":{"display_login":"davidnich"}}