{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/60035847","id":60035847,"diff_hunk":"@@ -0,0 +1,328 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package etcd3\n+\n+import (\n+\t\"fmt\"\n+\t\"net/http\"\n+\t\"strings\"\n+\t\"sync\"\n+\n+\t\"k8s.io/kubernetes/pkg/api/unversioned\"\n+\t\"k8s.io/kubernetes/pkg/runtime\"\n+\t\"k8s.io/kubernetes/pkg/storage\"\n+\t\"k8s.io/kubernetes/pkg/watch\"\n+\n+\t\"github.com/coreos/etcd/clientv3\"\n+\tetcdrpc \"github.com/coreos/etcd/etcdserver/api/v3rpc/rpctypes\"\n+\t\"github.com/golang/glog\"\n+\t\"golang.org/x/net/context\"\n+)\n+\n+const (\n+\t// We have set a buffer in order to reduce times of context switches.\n+\tincomingBufSize = 100\n+\toutgoingBufSize = 100\n+)\n+\n+type watcher struct {\n+\tclient    *clientv3.Client\n+\tcodec     runtime.Codec\n+\tversioner storage.Versioner\n+}\n+\n+// watchChan implements watch.Interface.\n+type watchChan struct {\n+\twatcher           *watcher\n+\tkey               string\n+\tinitialRev        int64\n+\trecursive         bool\n+\tfilter            storage.FilterFunc\n+\tctx               context.Context\n+\tcancel            context.CancelFunc\n+\tincomingEventChan chan *event\n+\tresultChan        chan watch.Event\n+\terrChan           chan error\n+}\n+\n+func newWatcher(client *clientv3.Client, codec runtime.Codec, versioner storage.Versioner) *watcher {\n+\treturn &watcher{\n+\t\tclient:    client,\n+\t\tcodec:     codec,\n+\t\tversioner: versioner,\n+\t}\n+}\n+\n+// Watch watches on a key and returns a watch.Interface that transfers relevant notifications.\n+// If rev is zero, it will return the existing object(s) and then start watching from\n+// the maximum revision+1 from returned objects.\n+// If rev is non-zero, it will watch events happened after given revision.\n+// If recursive is false, it watches on given key.\n+// If recursive is true, it watches any children and directories under the key, excluding the root key itself.\n+// filter must be non-nil. Only if filter returns true will the changes be returned.\n+func (w *watcher) Watch(ctx context.Context, key string, rev int64, recursive bool, filter storage.FilterFunc) (watch.Interface, error) {\n+\tif recursive && !strings.HasSuffix(key, \"/\") {\n+\t\tkey += \"/\"\n+\t}\n+\twc := &watchChan{\n+\t\twatcher:           w,\n+\t\tkey:               key,\n+\t\tinitialRev:        rev,\n+\t\trecursive:         recursive,\n+\t\tfilter:            filter,\n+\t\tincomingEventChan: make(chan *event, incomingBufSize),\n+\t\tresultChan:        make(chan watch.Event, outgoingBufSize),\n+\t\terrChan:           make(chan error, 1),\n+\t}\n+\twc.ctx, wc.cancel = context.WithCancel(ctx)\n+\tgo wc.run()\n+\treturn wc, nil\n+}\n+\n+func (wc *watchChan) run() {\n+\tgo wc.startWatching()\n+\n+\tvar resultChanWG sync.WaitGroup\n+\tresultChanWG.Add(1)\n+\tgo wc.processEvent(&resultChanWG)\n+\n+\tvar errResult *watch.Event\n+\tselect {\n+\tcase err := <-wc.errChan:\n+\t\terrResult = parseError(err)","path":"pkg/storage/etcd3/watcher.go","position":106,"original_position":106,"commit_id":"2dbd2d2685e65cbff26e280353ddc49f46c29a15","original_commit_id":"2dbd2d2685e65cbff26e280353ddc49f46c29a15","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"why not just wc.resultChan <- *parseError(err)\r\n\r\nand get rid of errResult completely?","created_at":"2016-04-18T10:23:49Z","updated_at":"2016-04-18T10:23:49Z","html_url":"https://github.com/kubernetes/kubernetes/pull/23694#discussion_r60035847","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/60035847"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23694#discussion_r60035847"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694","id":64846571,"html_url":"https://github.com/kubernetes/kubernetes/pull/23694","diff_url":"https://github.com/kubernetes/kubernetes/pull/23694.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23694.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694","number":23694,"state":"open","locked":false,"title":"etcd3/store: watcher implementation","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"body":"ref: https://github.com/kubernetes/kubernetes/issues/22448\r\n\r\nThis PR does:\r\n- Provide a watcher that uses etcd v3 API to watch changes via etcd and process them based on existing logic of storage.Interface.Watch(), WatchList().\r\n- By using the watcher, very trivial to implement Watch() and WatchList() in etcd3 storage.Interface implementation.\r\n\r\n\r\n","created_at":"2016-03-31T19:40:12Z","updated_at":"2016-04-18T10:23:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d5d7f029d4a3fd287af34c4f4e02c6d78df42fc","assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2dbd2d2685e65cbff26e280353ddc49f46c29a15","head":{"label":"hongchaodeng:w","ref":"w","sha":"2dbd2d2685e65cbff26e280353ddc49f46c29a15","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"repo":{"id":45423343,"name":"kubernetes","full_name":"hongchaodeng/kubernetes","owner":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hongchaodeng/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/hongchaodeng/kubernetes","forks_url":"https://api.github.com/repos/hongchaodeng/kubernetes/forks","keys_url":"https://api.github.com/repos/hongchaodeng/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hongchaodeng/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hongchaodeng/kubernetes/teams","hooks_url":"https://api.github.com/repos/hongchaodeng/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hongchaodeng/kubernetes/events","assignees_url":"https://api.github.com/repos/hongchaodeng/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hongchaodeng/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hongchaodeng/kubernetes/tags","blobs_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hongchaodeng/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hongchaodeng/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hongchaodeng/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hongchaodeng/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hongchaodeng/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hongchaodeng/kubernetes/subscription","commits_url":"https://api.github.com/repos/hongchaodeng/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hongchaodeng/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hongchaodeng/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hongchaodeng/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hongchaodeng/kubernetes/merges","archive_url":"https://api.github.com/repos/hongchaodeng/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hongchaodeng/kubernetes/downloads","issues_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hongchaodeng/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hongchaodeng/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hongchaodeng/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hongchaodeng/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hongchaodeng/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hongchaodeng/kubernetes/deployments","created_at":"2015-11-02T21:30:01Z","updated_at":"2016-04-17T11:13:25Z","pushed_at":"2016-04-18T00:27:30Z","git_url":"git://github.com/hongchaodeng/kubernetes.git","ssh_url":"git@github.com:hongchaodeng/kubernetes.git","clone_url":"https://github.com/hongchaodeng/kubernetes.git","svn_url":"https://github.com/hongchaodeng/kubernetes","homepage":"http://kubernetes.io","size":187729,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e81663c8242b54eafa9c97d947339a02b0d23780","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-04-18T08:41:14Z","pushed_at":"2016-04-18T10:01:27Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":376006,"stargazers_count":13920,"watchers_count":13920,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4125,"mirror_url":null,"open_issues_count":3398,"forks":4125,"open_issues":3398,"watchers":13920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/23694"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/23694/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23694/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2dbd2d2685e65cbff26e280353ddc49f46c29a15"}}}}