{"action":"created","issue":{"url":"https://api.github.com/repos/zcash/zcash/issues/1104","repository_url":"https://api.github.com/repos/zcash/zcash","labels_url":"https://api.github.com/repos/zcash/zcash/issues/1104/labels{/name}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/1104/comments","events_url":"https://api.github.com/repos/zcash/zcash/issues/1104/events","html_url":"https://github.com/zcash/zcash/pull/1104","id":165832905,"number":1104,"title":"Update libsnark","user":{"login":"ebfull","id":3794471,"avatar_url":"https://avatars.githubusercontent.com/u/3794471?v=3","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zcash/zcash/labels/review%20needed","name":"review needed","color":"bfd4f2"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-07-15T16:57:40Z","updated_at":"2016-07-18T18:00:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/1104","html_url":"https://github.com/zcash/zcash/pull/1104","diff_url":"https://github.com/zcash/zcash/pull/1104.diff","patch_url":"https://github.com/zcash/zcash/pull/1104.patch"},"body":"We have now forked libsnark's current master and applied the following patches:\r\n\r\n* [`9216072`: Remove code that we don't use.](https://github.com/zcash/libsnark/commit/9216072c3b20d65359f4d5f3982c8270dab422b6) (unblocks #69)\r\n* [`dcb78b2`: Modify makefile to stop compiling things we removed.](https://github.com/zcash/libsnark/commit/dcb78b24d9de86522f7f976741111e9e66804889)\r\n* [`a6b0ad0`: Use libsodium's PRNG](https://github.com/zcash/libsnark/commit/a6b0ad0c801fe96d0e12e5961279cdf306a412fa) (closes #780)\r\n* [`4036716`: Don't (de)serialize the constraint system in the proving key.](https://github.com/zcash/libsnark/commit/403671675ada05caf7446f9676fa3c54d5830325) (closes #491)\r\n* [`a703148`: Taylor's compilation patch](https://github.com/zcash/libsnark/commit/a7031481fd8d2360337321401fe8e24f0359317a) (@defuse can you submit this to upstream?)\r\n\r\nThis PR adopts those changes, and makes the requisite changes to Zcash to support them. I have decided to not bring libsnark in tree for the time being, though it should be incredibly easy to do later if we're *absolutely* sure we should."},"comment":{"url":"https://api.github.com/repos/zcash/zcash/issues/comments/233407527","html_url":"https://github.com/zcash/zcash/pull/1104#issuecomment-233407527","issue_url":"https://api.github.com/repos/zcash/zcash/issues/1104","id":233407527,"user":{"login":"ebfull","id":3794471,"avatar_url":"https://avatars.githubusercontent.com/u/3794471?v=3","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T18:00:06Z","updated_at":"2016-07-18T18:00:06Z","body":"We can continue to chip away at it. I think once we see the code coverage results from this we can purge a lot more code out.\r\n\r\nThanks for reviewing!\r\n\r\n@zkbot r+"}}
{"actor":{"display_login":"ebfull"}}