{"action":"created","issue":{"url":"https://api.github.com/repos/bcherny/json-schema-to-typescript/issues/43","repository_url":"https://api.github.com/repos/bcherny/json-schema-to-typescript","labels_url":"https://api.github.com/repos/bcherny/json-schema-to-typescript/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/bcherny/json-schema-to-typescript/issues/43/comments","events_url":"https://api.github.com/repos/bcherny/json-schema-to-typescript/issues/43/events","html_url":"https://github.com/bcherny/json-schema-to-typescript/pull/43","id":179587136,"number":43,"title":"Deep schema","user":{"login":"darcyparker","id":945058,"avatar_url":"https://avatars.githubusercontent.com/u/945058?v=3","gravatar_id":"","url":"https://api.github.com/users/darcyparker","html_url":"https://github.com/darcyparker","followers_url":"https://api.github.com/users/darcyparker/followers","following_url":"https://api.github.com/users/darcyparker/following{/other_user}","gists_url":"https://api.github.com/users/darcyparker/gists{/gist_id}","starred_url":"https://api.github.com/users/darcyparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcyparker/subscriptions","organizations_url":"https://api.github.com/users/darcyparker/orgs","repos_url":"https://api.github.com/users/darcyparker/repos","events_url":"https://api.github.com/users/darcyparker/events{/privacy}","received_events_url":"https://api.github.com/users/darcyparker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-27T19:17:13Z","updated_at":"2016-09-27T19:40:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bcherny/json-schema-to-typescript/pulls/43","html_url":"https://github.com/bcherny/json-schema-to-typescript/pull/43","diff_url":"https://github.com/bcherny/json-schema-to-typescript/pull/43.diff","patch_url":"https://github.com/bcherny/json-schema-to-typescript/pull/43.patch"},"body":"Reduces size of call stack for https://github.com/bcherny/json-schema-to-typescript/issues/35\r\n\r\n@donaldpipowitch can you test this branch?\r\n\r\nThere is more opportunity to improve. But it may not be necessary."},"comment":{"url":"https://api.github.com/repos/bcherny/json-schema-to-typescript/issues/comments/249975267","html_url":"https://github.com/bcherny/json-schema-to-typescript/pull/43#issuecomment-249975267","issue_url":"https://api.github.com/repos/bcherny/json-schema-to-typescript/issues/43","id":249975267,"user":{"login":"darcyparker","id":945058,"avatar_url":"https://avatars.githubusercontent.com/u/945058?v=3","gravatar_id":"","url":"https://api.github.com/users/darcyparker","html_url":"https://github.com/darcyparker","followers_url":"https://api.github.com/users/darcyparker/followers","following_url":"https://api.github.com/users/darcyparker/following{/other_user}","gists_url":"https://api.github.com/users/darcyparker/gists{/gist_id}","starred_url":"https://api.github.com/users/darcyparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darcyparker/subscriptions","organizations_url":"https://api.github.com/users/darcyparker/orgs","repos_url":"https://api.github.com/users/darcyparker/repos","events_url":"https://api.github.com/users/darcyparker/events{/privacy}","received_events_url":"https://api.github.com/users/darcyparker/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T19:40:51Z","updated_at":"2016-09-27T19:40:51Z","body":"Ok - great. Sounds like its' getting better. The next piece to focus on is `toTsDeclaration()` call of `this.toTsType()` which calls `generateTsType()` which sometimes calls `toTsDeclaration()` again...\r\n\r\nI commented about this recursion here:\r\nhttps://github.com/darcyparker/json-schema-to-typescript/blob/c6396e19d7e1ff213d33c3b39a5716e7710d9d8a/src/index.ts#L300-L302\r\n\r\nTrampolining may be a good approach. But @bcherny may have some other thoughts too? I can continue to think about it over the next few days to see if I have more thoughts on how to optimize."}}
{"actor":{"display_login":"darcyparker"}}