{"action":"created","comment":{"url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/comments/84591594","pull_request_review_id":5361559,"id":84591594,"diff_hunk":"@@ -45,35 +48,35 @@ defaults write com.apple.systemuiserver menuExtras -array \\\n \t\"/System/Library/CoreServices/Menu Extras/Clock.menu\"\n \n # Set highlight color to green\n-defaults write NSGlobalDomain AppleHighlightColor -string \"0.764700 0.976500 0.568600\"\n+defaults write -g AppleHighlightColor -string \"0.764700 0.976500 0.568600\"","path":".macos","position":17,"original_position":17,"commit_id":"f7fa2ba36922e2d611ca2bb66eeba2b4892be82c","original_commit_id":"f7fa2ba36922e2d611ca2bb66eeba2b4892be82c","user":{"login":"grimreaper","id":433817,"avatar_url":"https://avatars.githubusercontent.com/u/433817?v=3","gravatar_id":"","url":"https://api.github.com/users/grimreaper","html_url":"https://github.com/grimreaper","followers_url":"https://api.github.com/users/grimreaper/followers","following_url":"https://api.github.com/users/grimreaper/following{/other_user}","gists_url":"https://api.github.com/users/grimreaper/gists{/gist_id}","starred_url":"https://api.github.com/users/grimreaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimreaper/subscriptions","organizations_url":"https://api.github.com/users/grimreaper/orgs","repos_url":"https://api.github.com/users/grimreaper/repos","events_url":"https://api.github.com/users/grimreaper/events{/privacy}","received_events_url":"https://api.github.com/users/grimreaper/received_events","type":"User","site_admin":false},"body":"this is superfluous \r\n    -g | -globalDomain | NSGlobalDomain\r\n               Specify the global domain. '-g' and '-globalDomain' may be used as synonyms for NSGlobalDomain.\r\n\r\nIts unlikely that this will change","created_at":"2016-10-23T07:42:10Z","updated_at":"2016-10-23T07:42:10Z","html_url":"https://github.com/mathiasbynens/dotfiles/pull/720#discussion_r84591594","pull_request_url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720","_links":{"self":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/comments/84591594"},"html":{"href":"https://github.com/mathiasbynens/dotfiles/pull/720#discussion_r84591594"},"pull_request":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720"}}},"pull_request":{"url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720","id":89600793,"html_url":"https://github.com/mathiasbynens/dotfiles/pull/720","diff_url":"https://github.com/mathiasbynens/dotfiles/pull/720.diff","patch_url":"https://github.com/mathiasbynens/dotfiles/pull/720.patch","issue_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/720","number":720,"state":"open","locked":false,"title":"Janitorial stuff","user":{"login":"Menubalk","id":6699838,"avatar_url":"https://avatars.githubusercontent.com/u/6699838?v=3","gravatar_id":"","url":"https://api.github.com/users/Menubalk","html_url":"https://github.com/Menubalk","followers_url":"https://api.github.com/users/Menubalk/followers","following_url":"https://api.github.com/users/Menubalk/following{/other_user}","gists_url":"https://api.github.com/users/Menubalk/gists{/gist_id}","starred_url":"https://api.github.com/users/Menubalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Menubalk/subscriptions","organizations_url":"https://api.github.com/users/Menubalk/orgs","repos_url":"https://api.github.com/users/Menubalk/repos","events_url":"https://api.github.com/users/Menubalk/events{/privacy}","received_events_url":"https://api.github.com/users/Menubalk/received_events","type":"User","site_admin":false},"body":"Commits pretty much say it all. Really like your dotfiles, based my 'supercharged' ones on them so thought I'd contribute back for a bit.\r\n\r\n- Changing NSGlobalDomain to -g makes it less prone to problems if Apple changes things\r\n- Commenting out all the stuff that either does nothing or spits out an error should clear up output\r\n- Reordering is just more logical (categorical, then alphabetical)\r\n- Removal of superflous text isn't necessary but does look nicer :)\r\n- Don't write .DS_Store files to USB volumes\r\n\r\nCheers!\r\n","created_at":"2016-10-17T10:52:25Z","updated_at":"2016-10-23T07:42:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a5ca3ba5efcfae0a3fe4ff232d130b06bd8f95c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720/commits","review_comments_url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720/comments","review_comment_url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/720/comments","statuses_url":"https://api.github.com/repos/mathiasbynens/dotfiles/statuses/f7fa2ba36922e2d611ca2bb66eeba2b4892be82c","head":{"label":"Menubalk:compatibility","ref":"compatibility","sha":"f7fa2ba36922e2d611ca2bb66eeba2b4892be82c","user":{"login":"Menubalk","id":6699838,"avatar_url":"https://avatars.githubusercontent.com/u/6699838?v=3","gravatar_id":"","url":"https://api.github.com/users/Menubalk","html_url":"https://github.com/Menubalk","followers_url":"https://api.github.com/users/Menubalk/followers","following_url":"https://api.github.com/users/Menubalk/following{/other_user}","gists_url":"https://api.github.com/users/Menubalk/gists{/gist_id}","starred_url":"https://api.github.com/users/Menubalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Menubalk/subscriptions","organizations_url":"https://api.github.com/users/Menubalk/orgs","repos_url":"https://api.github.com/users/Menubalk/repos","events_url":"https://api.github.com/users/Menubalk/events{/privacy}","received_events_url":"https://api.github.com/users/Menubalk/received_events","type":"User","site_admin":false},"repo":{"id":70861550,"name":"dotfiles","full_name":"Menubalk/dotfiles","owner":{"login":"Menubalk","id":6699838,"avatar_url":"https://avatars.githubusercontent.com/u/6699838?v=3","gravatar_id":"","url":"https://api.github.com/users/Menubalk","html_url":"https://github.com/Menubalk","followers_url":"https://api.github.com/users/Menubalk/followers","following_url":"https://api.github.com/users/Menubalk/following{/other_user}","gists_url":"https://api.github.com/users/Menubalk/gists{/gist_id}","starred_url":"https://api.github.com/users/Menubalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Menubalk/subscriptions","organizations_url":"https://api.github.com/users/Menubalk/orgs","repos_url":"https://api.github.com/users/Menubalk/repos","events_url":"https://api.github.com/users/Menubalk/events{/privacy}","received_events_url":"https://api.github.com/users/Menubalk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Menubalk/dotfiles","description":"AutoDev Setup 9000","fork":true,"url":"https://api.github.com/repos/Menubalk/dotfiles","forks_url":"https://api.github.com/repos/Menubalk/dotfiles/forks","keys_url":"https://api.github.com/repos/Menubalk/dotfiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Menubalk/dotfiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Menubalk/dotfiles/teams","hooks_url":"https://api.github.com/repos/Menubalk/dotfiles/hooks","issue_events_url":"https://api.github.com/repos/Menubalk/dotfiles/issues/events{/number}","events_url":"https://api.github.com/repos/Menubalk/dotfiles/events","assignees_url":"https://api.github.com/repos/Menubalk/dotfiles/assignees{/user}","branches_url":"https://api.github.com/repos/Menubalk/dotfiles/branches{/branch}","tags_url":"https://api.github.com/repos/Menubalk/dotfiles/tags","blobs_url":"https://api.github.com/repos/Menubalk/dotfiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Menubalk/dotfiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Menubalk/dotfiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/Menubalk/dotfiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Menubalk/dotfiles/statuses/{sha}","languages_url":"https://api.github.com/repos/Menubalk/dotfiles/languages","stargazers_url":"https://api.github.com/repos/Menubalk/dotfiles/stargazers","contributors_url":"https://api.github.com/repos/Menubalk/dotfiles/contributors","subscribers_url":"https://api.github.com/repos/Menubalk/dotfiles/subscribers","subscription_url":"https://api.github.com/repos/Menubalk/dotfiles/subscription","commits_url":"https://api.github.com/repos/Menubalk/dotfiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/Menubalk/dotfiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/Menubalk/dotfiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/Menubalk/dotfiles/issues/comments{/number}","contents_url":"https://api.github.com/repos/Menubalk/dotfiles/contents/{+path}","compare_url":"https://api.github.com/repos/Menubalk/dotfiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Menubalk/dotfiles/merges","archive_url":"https://api.github.com/repos/Menubalk/dotfiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Menubalk/dotfiles/downloads","issues_url":"https://api.github.com/repos/Menubalk/dotfiles/issues{/number}","pulls_url":"https://api.github.com/repos/Menubalk/dotfiles/pulls{/number}","milestones_url":"https://api.github.com/repos/Menubalk/dotfiles/milestones{/number}","notifications_url":"https://api.github.com/repos/Menubalk/dotfiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Menubalk/dotfiles/labels{/name}","releases_url":"https://api.github.com/repos/Menubalk/dotfiles/releases{/id}","deployments_url":"https://api.github.com/repos/Menubalk/dotfiles/deployments","created_at":"2016-10-14T01:12:25Z","updated_at":"2016-10-21T06:19:49Z","pushed_at":"2016-10-21T06:59:40Z","git_url":"git://github.com/Menubalk/dotfiles.git","ssh_url":"git@github.com:Menubalk/dotfiles.git","clone_url":"https://github.com/Menubalk/dotfiles.git","svn_url":"https://github.com/Menubalk/dotfiles","homepage":"","size":7064,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mathiasbynens:master","ref":"master","sha":"b9cb025c7f7c7014904adc76fc5f5f96937ebaa8","user":{"login":"mathiasbynens","id":81942,"avatar_url":"https://avatars.githubusercontent.com/u/81942?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"repo":{"id":2329766,"name":"dotfiles","full_name":"mathiasbynens/dotfiles","owner":{"login":"mathiasbynens","id":81942,"avatar_url":"https://avatars.githubusercontent.com/u/81942?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathiasbynens/dotfiles","description":":wrench: .files, including ~/.macos — sensible hacker defaults for macOS","fork":false,"url":"https://api.github.com/repos/mathiasbynens/dotfiles","forks_url":"https://api.github.com/repos/mathiasbynens/dotfiles/forks","keys_url":"https://api.github.com/repos/mathiasbynens/dotfiles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathiasbynens/dotfiles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathiasbynens/dotfiles/teams","hooks_url":"https://api.github.com/repos/mathiasbynens/dotfiles/hooks","issue_events_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/events{/number}","events_url":"https://api.github.com/repos/mathiasbynens/dotfiles/events","assignees_url":"https://api.github.com/repos/mathiasbynens/dotfiles/assignees{/user}","branches_url":"https://api.github.com/repos/mathiasbynens/dotfiles/branches{/branch}","tags_url":"https://api.github.com/repos/mathiasbynens/dotfiles/tags","blobs_url":"https://api.github.com/repos/mathiasbynens/dotfiles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathiasbynens/dotfiles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathiasbynens/dotfiles/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathiasbynens/dotfiles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathiasbynens/dotfiles/statuses/{sha}","languages_url":"https://api.github.com/repos/mathiasbynens/dotfiles/languages","stargazers_url":"https://api.github.com/repos/mathiasbynens/dotfiles/stargazers","contributors_url":"https://api.github.com/repos/mathiasbynens/dotfiles/contributors","subscribers_url":"https://api.github.com/repos/mathiasbynens/dotfiles/subscribers","subscription_url":"https://api.github.com/repos/mathiasbynens/dotfiles/subscription","commits_url":"https://api.github.com/repos/mathiasbynens/dotfiles/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathiasbynens/dotfiles/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathiasbynens/dotfiles/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathiasbynens/dotfiles/contents/{+path}","compare_url":"https://api.github.com/repos/mathiasbynens/dotfiles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathiasbynens/dotfiles/merges","archive_url":"https://api.github.com/repos/mathiasbynens/dotfiles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathiasbynens/dotfiles/downloads","issues_url":"https://api.github.com/repos/mathiasbynens/dotfiles/issues{/number}","pulls_url":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls{/number}","milestones_url":"https://api.github.com/repos/mathiasbynens/dotfiles/milestones{/number}","notifications_url":"https://api.github.com/repos/mathiasbynens/dotfiles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathiasbynens/dotfiles/labels{/name}","releases_url":"https://api.github.com/repos/mathiasbynens/dotfiles/releases{/id}","deployments_url":"https://api.github.com/repos/mathiasbynens/dotfiles/deployments","created_at":"2011-09-05T18:07:54Z","updated_at":"2016-10-23T05:00:32Z","pushed_at":"2016-10-20T14:06:41Z","git_url":"git://github.com/mathiasbynens/dotfiles.git","ssh_url":"git@github.com:mathiasbynens/dotfiles.git","clone_url":"https://github.com/mathiasbynens/dotfiles.git","svn_url":"https://github.com/mathiasbynens/dotfiles","homepage":"https://mths.be/dotfiles","size":24114,"stargazers_count":15209,"watchers_count":15209,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5617,"mirror_url":null,"open_issues_count":134,"forks":5617,"open_issues":134,"watchers":15209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720"},"html":{"href":"https://github.com/mathiasbynens/dotfiles/pull/720"},"issue":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/720"},"comments":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/issues/720/comments"},"review_comments":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720/comments"},"review_comment":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/pulls/720/commits"},"statuses":{"href":"https://api.github.com/repos/mathiasbynens/dotfiles/statuses/f7fa2ba36922e2d611ca2bb66eeba2b4892be82c"}}}}
{"actor":{"display_login":"grimreaper"}}