{"action":"created","comment":{"url":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/comments/79377130","id":79377130,"diff_hunk":"@@ -207,5 +207,158 @@\n \t\t\"Dragonite\":\"False\",\n \t\t\"Mewtwo\":\"False\",\n \t\t\"Mew\":\"False\"\n+\t},\n+\t\"ivs\":{","path":"alarms.json.default","position":5,"original_position":5,"commit_id":"f8b49c7d8927c1c5e988267a7b16daa39f7f2baf","original_commit_id":"f8b49c7d8927c1c5e988267a7b16daa39f7f2baf","user":{"login":"Spiritvn","id":5210757,"avatar_url":"https://avatars.githubusercontent.com/u/5210757?v=3","gravatar_id":"","url":"https://api.github.com/users/Spiritvn","html_url":"https://github.com/Spiritvn","followers_url":"https://api.github.com/users/Spiritvn/followers","following_url":"https://api.github.com/users/Spiritvn/following{/other_user}","gists_url":"https://api.github.com/users/Spiritvn/gists{/gist_id}","starred_url":"https://api.github.com/users/Spiritvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spiritvn/subscriptions","organizations_url":"https://api.github.com/users/Spiritvn/orgs","repos_url":"https://api.github.com/users/Spiritvn/repos","events_url":"https://api.github.com/users/Spiritvn/events{/privacy}","received_events_url":"https://api.github.com/users/Spiritvn/received_events","type":"User","site_admin":false},"body":"I want to keep it simple from the exist functions so i just make a new list, very fast solution but sure not good as yours . But changing into the objects like that seem too much works for me, maybe you should handle it after the merge?","created_at":"2016-09-19T12:13:52Z","updated_at":"2016-09-19T12:13:52Z","html_url":"https://github.com/kvangent/PokeAlarm/pull/220#discussion_r79377130","pull_request_url":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/comments/79377130"},"html":{"href":"https://github.com/kvangent/PokeAlarm/pull/220#discussion_r79377130"},"pull_request":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220","id":84919488,"html_url":"https://github.com/kvangent/PokeAlarm/pull/220","diff_url":"https://github.com/kvangent/PokeAlarm/pull/220.diff","patch_url":"https://github.com/kvangent/PokeAlarm/pull/220.patch","issue_url":"https://api.github.com/repos/kvangent/PokeAlarm/issues/220","number":220,"state":"open","locked":false,"title":"Added IVs notification","user":{"login":"Spiritvn","id":5210757,"avatar_url":"https://avatars.githubusercontent.com/u/5210757?v=3","gravatar_id":"","url":"https://api.github.com/users/Spiritvn","html_url":"https://github.com/Spiritvn","followers_url":"https://api.github.com/users/Spiritvn/followers","following_url":"https://api.github.com/users/Spiritvn/following{/other_user}","gists_url":"https://api.github.com/users/Spiritvn/gists{/gist_id}","starred_url":"https://api.github.com/users/Spiritvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spiritvn/subscriptions","organizations_url":"https://api.github.com/users/Spiritvn/orgs","repos_url":"https://api.github.com/users/Spiritvn/repos","events_url":"https://api.github.com/users/Spiritvn/events{/privacy}","received_events_url":"https://api.github.com/users/Spiritvn/received_events","type":"User","site_admin":false},"body":"<!--- PULL REQUESTS CREATED NOT USING THE BELOW TEMPLATE WILL BE CLOSED WITHOUT RESPONSE --->\r\n<!--- PULL REQUESTS CREATED NOT USING THE BELOW TEMPLATE WILL BE CLOSED WITHOUT RESPONSE --->\r\n<!--- PULL REQUESTS CREATED NOT USING THE BELOW TEMPLATE WILL BE CLOSED WITHOUT RESPONSE --->\r\n<!--- PULL REQUESTS CREATED NOT USING THE BELOW TEMPLATE WILL BE CLOSED WITHOUT RESPONSE --->\r\n\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\nAs the IVs and Skills of Pokemon will be included to PokemonGoMap soon: https://github.com/PokemonGoMap/PokemonGo-Map/pull/1272 and Request https://github.com/kvangent/PokeAlarm/issues/216\r\n\r\nAnd with a ready-work of @azd2 for Telegram, i just improved it to have the IV could be config for each Pokemon separated (**and it should work for all other services beside Telegram**). Such as:\r\n\r\n- Always notification for Snorlax, Dragonite, not care about its IV ( IV > 0)\r\n- I would like to have some Eevee > 90% \r\n\r\nAlso shorter the message, and include None message incase someone's not have the IVs from the Map (Sorry but i dont know how to check if it's included IV and change the message up to the data on telegram_alarm.py as this current code, someone else please improve it) \r\n\r\nSummary by files:\r\n\r\n- alarms.json.default: add default minium IVs of Pokemon \r\n- locale: moves.en.json moves.de.json moves.fr.json for Move List (from @azd2 fork)\r\n- utils.py: add to get moveset (not change anything from @azd2 fork)\r\n- alarm_manager.py: get the IVs config, add some check cases.\r\n- telegram_alarm.py: shorter the IVs & Moves message.\r\n- {other}_alarm.py: add IVs message // But need you guys do more test on the other services because  only use Telegram so i only tested the Telegram\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n\r\nTested some case:\r\n\r\n- Pokemon not in the list\r\n- Pokemon in the list with IV set 0\r\n- Pokemon in the list with IV set to 100\r\n- Pokemon in the list with IV set but no IVs from the Map\r\n- Telegram\r\n- Twitter\r\n- Slack\r\n\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n\r\nUsing:\r\n\r\n- Latest MAP.\r\n- IVs from https://github.com/PokemonGoMap/PokemonGo-Map/pull/1272\r\n\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\nTelegram:\r\n\r\n![alert](https://cloud.githubusercontent.com/assets/5210757/18447062/2dd057ae-794f-11e6-8557-29f374df8ab8.jpg)\r\n\r\n\r\nTwitter:\r\n\r\n![alarm_twitter](https://cloud.githubusercontent.com/assets/5210757/18520816/9df4096a-7ad3-11e6-832d-7563e45e8730.jpg)\r\n\r\n\r\nSlack: \r\n\r\n![alarm_slack](https://cloud.githubusercontent.com/assets/5210757/18520821/a0b86baa-7ad3-11e6-939f-04244ac4624e.png)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Wiki Update\r\n<!--- Please create a Wiki page (or snippet) describing how to use your changes --->\r\n<!--- Please keep them simple and user friendly                                  --->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\n","created_at":"2016-09-12T18:22:48Z","updated_at":"2016-09-19T12:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5edab55bd24a335e1b4f30801b44c61971ef4613","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220/commits","review_comments_url":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220/comments","review_comment_url":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kvangent/PokeAlarm/issues/220/comments","statuses_url":"https://api.github.com/repos/kvangent/PokeAlarm/statuses/f8b49c7d8927c1c5e988267a7b16daa39f7f2baf","head":{"label":"Spiritvn:ivs","ref":"ivs","sha":"f8b49c7d8927c1c5e988267a7b16daa39f7f2baf","user":{"login":"Spiritvn","id":5210757,"avatar_url":"https://avatars.githubusercontent.com/u/5210757?v=3","gravatar_id":"","url":"https://api.github.com/users/Spiritvn","html_url":"https://github.com/Spiritvn","followers_url":"https://api.github.com/users/Spiritvn/followers","following_url":"https://api.github.com/users/Spiritvn/following{/other_user}","gists_url":"https://api.github.com/users/Spiritvn/gists{/gist_id}","starred_url":"https://api.github.com/users/Spiritvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spiritvn/subscriptions","organizations_url":"https://api.github.com/users/Spiritvn/orgs","repos_url":"https://api.github.com/users/Spiritvn/repos","events_url":"https://api.github.com/users/Spiritvn/events{/privacy}","received_events_url":"https://api.github.com/users/Spiritvn/received_events","type":"User","site_admin":false},"repo":{"id":68021373,"name":"PokeAlarm","full_name":"Spiritvn/PokeAlarm","owner":{"login":"Spiritvn","id":5210757,"avatar_url":"https://avatars.githubusercontent.com/u/5210757?v=3","gravatar_id":"","url":"https://api.github.com/users/Spiritvn","html_url":"https://github.com/Spiritvn","followers_url":"https://api.github.com/users/Spiritvn/followers","following_url":"https://api.github.com/users/Spiritvn/following{/other_user}","gists_url":"https://api.github.com/users/Spiritvn/gists{/gist_id}","starred_url":"https://api.github.com/users/Spiritvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spiritvn/subscriptions","organizations_url":"https://api.github.com/users/Spiritvn/orgs","repos_url":"https://api.github.com/users/Spiritvn/repos","events_url":"https://api.github.com/users/Spiritvn/events{/privacy}","received_events_url":"https://api.github.com/users/Spiritvn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Spiritvn/PokeAlarm","description":"PokeAlarm is a third party extension for PokemonGo-Map that allows you to receive external notifications via the service of your choice","fork":true,"url":"https://api.github.com/repos/Spiritvn/PokeAlarm","forks_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/forks","keys_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/teams","hooks_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/hooks","issue_events_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/issues/events{/number}","events_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/events","assignees_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/assignees{/user}","branches_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/branches{/branch}","tags_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/tags","blobs_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/statuses/{sha}","languages_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/languages","stargazers_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/stargazers","contributors_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/contributors","subscribers_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/subscribers","subscription_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/subscription","commits_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/contents/{+path}","compare_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/merges","archive_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/downloads","issues_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/issues{/number}","pulls_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/pulls{/number}","milestones_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/milestones{/number}","notifications_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/labels{/name}","releases_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/releases{/id}","deployments_url":"https://api.github.com/repos/Spiritvn/PokeAlarm/deployments","created_at":"2016-09-12T15:23:29Z","updated_at":"2016-09-17T07:33:26Z","pushed_at":"2016-09-19T11:04:58Z","git_url":"git://github.com/Spiritvn/PokeAlarm.git","ssh_url":"git@github.com:Spiritvn/PokeAlarm.git","clone_url":"https://github.com/Spiritvn/PokeAlarm.git","svn_url":"https://github.com/Spiritvn/PokeAlarm","homepage":"","size":2858,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"kvangent:master","ref":"master","sha":"0228be9220a1a8c1f08f3f2d011e9749f4972033","user":{"login":"kvangent","id":10712294,"avatar_url":"https://avatars.githubusercontent.com/u/10712294?v=3","gravatar_id":"","url":"https://api.github.com/users/kvangent","html_url":"https://github.com/kvangent","followers_url":"https://api.github.com/users/kvangent/followers","following_url":"https://api.github.com/users/kvangent/following{/other_user}","gists_url":"https://api.github.com/users/kvangent/gists{/gist_id}","starred_url":"https://api.github.com/users/kvangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvangent/subscriptions","organizations_url":"https://api.github.com/users/kvangent/orgs","repos_url":"https://api.github.com/users/kvangent/repos","events_url":"https://api.github.com/users/kvangent/events{/privacy}","received_events_url":"https://api.github.com/users/kvangent/received_events","type":"User","site_admin":false},"repo":{"id":64392484,"name":"PokeAlarm","full_name":"kvangent/PokeAlarm","owner":{"login":"kvangent","id":10712294,"avatar_url":"https://avatars.githubusercontent.com/u/10712294?v=3","gravatar_id":"","url":"https://api.github.com/users/kvangent","html_url":"https://github.com/kvangent","followers_url":"https://api.github.com/users/kvangent/followers","following_url":"https://api.github.com/users/kvangent/following{/other_user}","gists_url":"https://api.github.com/users/kvangent/gists{/gist_id}","starred_url":"https://api.github.com/users/kvangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvangent/subscriptions","organizations_url":"https://api.github.com/users/kvangent/orgs","repos_url":"https://api.github.com/users/kvangent/repos","events_url":"https://api.github.com/users/kvangent/events{/privacy}","received_events_url":"https://api.github.com/users/kvangent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kvangent/PokeAlarm","description":"PokeAlarm is a third party extension for PokemonGo-Map that allows you to receive external notifications via the service of your choice","fork":false,"url":"https://api.github.com/repos/kvangent/PokeAlarm","forks_url":"https://api.github.com/repos/kvangent/PokeAlarm/forks","keys_url":"https://api.github.com/repos/kvangent/PokeAlarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kvangent/PokeAlarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kvangent/PokeAlarm/teams","hooks_url":"https://api.github.com/repos/kvangent/PokeAlarm/hooks","issue_events_url":"https://api.github.com/repos/kvangent/PokeAlarm/issues/events{/number}","events_url":"https://api.github.com/repos/kvangent/PokeAlarm/events","assignees_url":"https://api.github.com/repos/kvangent/PokeAlarm/assignees{/user}","branches_url":"https://api.github.com/repos/kvangent/PokeAlarm/branches{/branch}","tags_url":"https://api.github.com/repos/kvangent/PokeAlarm/tags","blobs_url":"https://api.github.com/repos/kvangent/PokeAlarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kvangent/PokeAlarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kvangent/PokeAlarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kvangent/PokeAlarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kvangent/PokeAlarm/statuses/{sha}","languages_url":"https://api.github.com/repos/kvangent/PokeAlarm/languages","stargazers_url":"https://api.github.com/repos/kvangent/PokeAlarm/stargazers","contributors_url":"https://api.github.com/repos/kvangent/PokeAlarm/contributors","subscribers_url":"https://api.github.com/repos/kvangent/PokeAlarm/subscribers","subscription_url":"https://api.github.com/repos/kvangent/PokeAlarm/subscription","commits_url":"https://api.github.com/repos/kvangent/PokeAlarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kvangent/PokeAlarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kvangent/PokeAlarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kvangent/PokeAlarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kvangent/PokeAlarm/contents/{+path}","compare_url":"https://api.github.com/repos/kvangent/PokeAlarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kvangent/PokeAlarm/merges","archive_url":"https://api.github.com/repos/kvangent/PokeAlarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kvangent/PokeAlarm/downloads","issues_url":"https://api.github.com/repos/kvangent/PokeAlarm/issues{/number}","pulls_url":"https://api.github.com/repos/kvangent/PokeAlarm/pulls{/number}","milestones_url":"https://api.github.com/repos/kvangent/PokeAlarm/milestones{/number}","notifications_url":"https://api.github.com/repos/kvangent/PokeAlarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kvangent/PokeAlarm/labels{/name}","releases_url":"https://api.github.com/repos/kvangent/PokeAlarm/releases{/id}","deployments_url":"https://api.github.com/repos/kvangent/PokeAlarm/deployments","created_at":"2016-07-28T12:08:26Z","updated_at":"2016-09-18T05:03:15Z","pushed_at":"2016-09-18T16:17:36Z","git_url":"git://github.com/kvangent/PokeAlarm.git","ssh_url":"git@github.com:kvangent/PokeAlarm.git","clone_url":"https://github.com/kvangent/PokeAlarm.git","svn_url":"https://github.com/kvangent/PokeAlarm","homepage":"","size":5953,"stargazers_count":202,"watchers_count":202,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":12,"forks":93,"open_issues":12,"watchers":202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220"},"html":{"href":"https://github.com/kvangent/PokeAlarm/pull/220"},"issue":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/issues/220"},"comments":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/kvangent/PokeAlarm/statuses/f8b49c7d8927c1c5e988267a7b16daa39f7f2baf"}}}}
{"actor":{"display_login":"Spiritvn"}}