{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/578","repository_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle","labels_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/578/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/578/comments","events_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/578/events","html_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/578","id":157979985,"number":578,"title":"Support embedded object for the show mapper","user":{"login":"claudusd","id":3321326,"avatar_url":"https://avatars.githubusercontent.com/u/3321326?v=3","gravatar_id":"","url":"https://api.github.com/users/claudusd","html_url":"https://github.com/claudusd","followers_url":"https://api.github.com/users/claudusd/followers","following_url":"https://api.github.com/users/claudusd/following{/other_user}","gists_url":"https://api.github.com/users/claudusd/gists{/gist_id}","starred_url":"https://api.github.com/users/claudusd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudusd/subscriptions","organizations_url":"https://api.github.com/users/claudusd/orgs","repos_url":"https://api.github.com/users/claudusd/repos","events_url":"https://api.github.com/users/claudusd/events{/privacy}","received_events_url":"https://api.github.com/users/claudusd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/labels/review%20required","name":"review required","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-06-01T18:49:59Z","updated_at":"2016-06-02T08:30:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/pulls/578","html_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/578","diff_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/578.diff","patch_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/578.patch"},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT! -->\r\n\r\n### Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Remove unneeded sections.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n```markdown\r\n### Fixed\r\n- Support doctrine embedded object in the show mapping\r\n```\r\n\r\n### Subject\r\nThis pr allow to use embedded object in the show mapper. \r\n```php\r\nclass Foo {\r\n    public function getValue()\r\n    {\r\n        return 'myValue';\r\n    }\r\n}\r\n\r\nclass Bar {\r\n    public function getFoo()\r\n    {\r\n        return $this->foo;\r\n    }\r\n}\r\n```\r\n``` php\r\nprotected function configureShowFields(ShowMapper $showMapper)\r\n{\r\n    $showMapper\r\n        ->add('foo.value');\r\n}\r\n```\r\nThe FieldDescription method getValue ignore the embedded object and do \r\n``` php\r\n$bar = new Bar();\r\n$bar->getValue()\r\n```\r\nWith my PR the getter call is on the embedded object and not on the parent object.\r\n``` php\r\n$bar->getFoo()->getValue()\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/comments/223228392","html_url":"https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/578#issuecomment-223228392","issue_url":"https://api.github.com/repos/sonata-project/SonataDoctrineORMAdminBundle/issues/578","id":223228392,"user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars.githubusercontent.com/u/657779?v=3","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"created_at":"2016-06-02T08:30:15Z","updated_at":"2016-06-02T08:30:15Z","body":"Also : it would be nice to document the support for this feature, once we are sure it works in most situations (so maybe in a later PR)."}}
{"actor":{"display_login":"greg0ire"}}