{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/87048663","pull_request_review_id":7676581,"id":87048663,"diff_hunk":"@@ -85,6 +90,18 @@\n @XmlAccessorType(XmlAccessType.FIELD)\n public abstract class InternalTask extends TaskState {\n \n+    @XmlTransient\n+    public static transient final TaskLogger logger = TaskLogger.getInstance();\n+\n+    @XmlTransient\n+    private static transient HashSet<String> authorizedSelectionScripts = null;\n+\n+    @XmlTransient\n+    private static final transient long DEFAULT_AUTHORIZED_SCRIPT_LOAD_PERIOD = 60 * 1000;","path":"scheduler/scheduler-server/src/main/java/org/ow2/proactive/scheduler/task/internal/InternalTask.java","position":37,"original_position":37,"commit_id":"9659770d8b7520cd2d0f39c3f6378005b8613f7a","original_commit_id":"9659770d8b7520cd2d0f39c3f6378005b8613f7a","user":{"login":"sonarqube-activeeon","id":14940028,"avatar_url":"https://avatars.githubusercontent.com/u/14940028?v=3","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Cast one of the operands of this multiplication operation to a \"long\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS2184)\n","created_at":"2016-11-08T18:08:47Z","updated_at":"2016-11-08T18:08:47Z","html_url":"https://github.com/ow2-proactive/scheduling/pull/2719#discussion_r87048663","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/87048663"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/2719#discussion_r87048663"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719","id":92783539,"html_url":"https://github.com/ow2-proactive/scheduling/pull/2719","diff_url":"https://github.com/ow2-proactive/scheduling/pull/2719.diff","patch_url":"https://github.com/ow2-proactive/scheduling/pull/2719.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2719","number":2719,"state":"open","locked":false,"title":"Improve script authorization","user":{"login":"fviale","id":3063713,"avatar_url":"https://avatars.githubusercontent.com/u/3063713?v=3","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"body":"This change includes the following:\r\n\r\n  - Add new scheduler property which defines an authorized script folder for fork and clean scripts\r\n  - Add scheduler property which defines at which period this folder is browsed and scripts are loaded (avoid the need to restart the scheduler)\r\n  - Add similar resource manager period property for authorized selection scripts\r\n  - Implemented the mechanism to check authorization for clean and fork script\r\n  - Fixed the existing selection script authorization by calling trim() on the loaded script content.\r\n  - Added a functional test which verify authorization scenarios for selection, fork, or clean scripts.","created_at":"2016-11-08T14:05:50Z","updated_at":"2016-11-08T18:08:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93ef4a34a24cc4db0d79560ce063b00fc93850ad","assignee":{"login":"fviale","id":3063713,"avatar_url":"https://avatars.githubusercontent.com/u/3063713?v=3","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"assignees":[{"login":"fviale","id":3063713,"avatar_url":"https://avatars.githubusercontent.com/u/3063713?v=3","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones/70","html_url":"https://github.com/ow2-proactive/scheduling/milestones/7.20.0","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones/70/labels","id":2088117,"number":70,"title":"7.20.0","description":null,"creator":{"login":"activeeon-bot","id":12379036,"avatar_url":"https://avatars.githubusercontent.com/u/12379036?v=3","gravatar_id":"","url":"https://api.github.com/users/activeeon-bot","html_url":"https://github.com/activeeon-bot","followers_url":"https://api.github.com/users/activeeon-bot/followers","following_url":"https://api.github.com/users/activeeon-bot/following{/other_user}","gists_url":"https://api.github.com/users/activeeon-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/activeeon-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activeeon-bot/subscriptions","organizations_url":"https://api.github.com/users/activeeon-bot/orgs","repos_url":"https://api.github.com/users/activeeon-bot/repos","events_url":"https://api.github.com/users/activeeon-bot/events{/privacy}","received_events_url":"https://api.github.com/users/activeeon-bot/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2016-10-24T06:30:15Z","updated_at":"2016-11-08T14:05:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2719/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/9659770d8b7520cd2d0f39c3f6378005b8613f7a","head":{"label":"fviale:master","ref":"master","sha":"9659770d8b7520cd2d0f39c3f6378005b8613f7a","user":{"login":"fviale","id":3063713,"avatar_url":"https://avatars.githubusercontent.com/u/3063713?v=3","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"repo":{"id":36877569,"name":"scheduling","full_name":"fviale/scheduling","owner":{"login":"fviale","id":3063713,"avatar_url":"https://avatars.githubusercontent.com/u/3063713?v=3","gravatar_id":"","url":"https://api.github.com/users/fviale","html_url":"https://github.com/fviale","followers_url":"https://api.github.com/users/fviale/followers","following_url":"https://api.github.com/users/fviale/following{/other_user}","gists_url":"https://api.github.com/users/fviale/gists{/gist_id}","starred_url":"https://api.github.com/users/fviale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fviale/subscriptions","organizations_url":"https://api.github.com/users/fviale/orgs","repos_url":"https://api.github.com/users/fviale/repos","events_url":"https://api.github.com/users/fviale/events{/privacy}","received_events_url":"https://api.github.com/users/fviale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fviale/scheduling","description":"Multi-platform Scheduling and Workflows engine","fork":true,"url":"https://api.github.com/repos/fviale/scheduling","forks_url":"https://api.github.com/repos/fviale/scheduling/forks","keys_url":"https://api.github.com/repos/fviale/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fviale/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fviale/scheduling/teams","hooks_url":"https://api.github.com/repos/fviale/scheduling/hooks","issue_events_url":"https://api.github.com/repos/fviale/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/fviale/scheduling/events","assignees_url":"https://api.github.com/repos/fviale/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/fviale/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/fviale/scheduling/tags","blobs_url":"https://api.github.com/repos/fviale/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fviale/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fviale/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/fviale/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fviale/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/fviale/scheduling/languages","stargazers_url":"https://api.github.com/repos/fviale/scheduling/stargazers","contributors_url":"https://api.github.com/repos/fviale/scheduling/contributors","subscribers_url":"https://api.github.com/repos/fviale/scheduling/subscribers","subscription_url":"https://api.github.com/repos/fviale/scheduling/subscription","commits_url":"https://api.github.com/repos/fviale/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/fviale/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/fviale/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/fviale/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/fviale/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/fviale/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fviale/scheduling/merges","archive_url":"https://api.github.com/repos/fviale/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fviale/scheduling/downloads","issues_url":"https://api.github.com/repos/fviale/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/fviale/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/fviale/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/fviale/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fviale/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/fviale/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/fviale/scheduling/deployments","created_at":"2015-06-04T15:07:00Z","updated_at":"2016-01-20T18:13:45Z","pushed_at":"2016-11-08T14:04:34Z","git_url":"git://github.com/fviale/scheduling.git","ssh_url":"git@github.com:fviale/scheduling.git","clone_url":"https://github.com/fviale/scheduling.git","svn_url":"https://github.com/fviale/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":65698,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"9b761bc21333795fc6743b50bcc7110fd958648f","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars.githubusercontent.com/u/11553998?v=3","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725079,"name":"scheduling","full_name":"ow2-proactive/scheduling","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars.githubusercontent.com/u/11553998?v=3","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling","description":"Multi-platform Scheduling and Workflows Engine","fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2016-10-24T10:08:29Z","pushed_at":"2016-11-08T16:11:54Z","git_url":"git://github.com/ow2-proactive/scheduling.git","ssh_url":"git@github.com:ow2-proactive/scheduling.git","clone_url":"https://github.com/ow2-proactive/scheduling.git","svn_url":"https://github.com/ow2-proactive/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":66330,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":152,"forks":20,"open_issues":152,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/2719"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2719"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2719/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2719/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/9659770d8b7520cd2d0f39c3f6378005b8613f7a"}}}}
{"actor":{"display_login":"sonarqube-activeeon"}}