{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/64066458","id":64066458,"diff_hunk":"@@ -2,24 +2,64 @@\n $default-font: 'Fira Sans', Helvetica, Arial, sans-serif;\n $header-font: 'Fira Sans', Helvetica, Arial, sans-serif;\n \n+// default css variables\n+:root {\n+  --color-grey-lightest: #fbfbfb;\n+  --color-grey-lighter: #ebebeb;\n+  --color-grey-light: #d4d4d4;\n+  --color-grey: #b1b1b1;\n+  --color-grey-dark: #858585;\n+  --color-grey-disabled: #999999;\n+\n+  --color-blue: #0996f8;\n+  --color-blue-dark: #0670cc;\n+  --color-blue-darker: #005bab;\n+  --color-blue-darkest: #004480;\n+\n+  --color-blue-focusRing: hsla(208,100%,69%,.75);\n+\n+  --color-green-lightest: #E2FDDC;\n+  --color-green: #57BD35;\n+  --color-green-dark: #40A624;\n+  --color-green-darker: #399320;\n+  --color-green-darkest: #2E761A;\n+\n+  --border-radius-osx: 4px;\n+  --border-radius-outer: 4px;\n+  --border-radius-inner: 3px;\n+}\n+\n //Color Variables\n-$button-background-color: #0095dd;\n-$button-background-disabled-color: #8a9ba8;\n-$button-background-hover-color: #08c;\n+$button-background-color: var(--color-blue);","path":"app/styles/_variables.scss","position":35,"original_position":35,"commit_id":"6a79b2fa2780ce033ddfa2505dd269b91a42cfe4","original_commit_id":"6a79b2fa2780ce033ddfa2505dd269b91a42cfe4","user":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"body":"@shane-tomlinson No it doesn't. So I was following the moz-style-guide by @shorlander here: http://people.mozilla.org/~shorlander/styleguide/ui-elements/buttons-all.html and it was using css variables. I could definitely just use sass variables instead. Should I do that?","created_at":"2016-05-20T16:08:44Z","updated_at":"2016-05-20T16:08:44Z","html_url":"https://github.com/mozilla/fxa-content-server/pull/3755#discussion_r64066458","pull_request_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments/64066458"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/3755#discussion_r64066458"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755","id":70784119,"html_url":"https://github.com/mozilla/fxa-content-server/pull/3755","diff_url":"https://github.com/mozilla/fxa-content-server/pull/3755.diff","patch_url":"https://github.com/mozilla/fxa-content-server/pull/3755.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3755","number":3755,"state":"open","locked":false,"title":"style(colors): restyle buttons, links and labels to conform to mozill…","user":{"login":"TDA","id":432707,"avatar_url":"https://avatars.githubusercontent.com/u/432707?v=3","gravatar_id":"","url":"https://api.github.com/users/TDA","html_url":"https://github.com/TDA","followers_url":"https://api.github.com/users/TDA/followers","following_url":"https://api.github.com/users/TDA/following{/other_user}","gists_url":"https://api.github.com/users/TDA/gists{/gist_id}","starred_url":"https://api.github.com/users/TDA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TDA/subscriptions","organizations_url":"https://api.github.com/users/TDA/orgs","repos_url":"https://api.github.com/users/TDA/repos","events_url":"https://api.github.com/users/TDA/events{/privacy}","received_events_url":"https://api.github.com/users/TDA/received_events","type":"User","site_admin":false},"body":"…a style guide\r\n\r\nedit primary and secondary buttons\r\nedit show-password label\r\nedit links\r\nFixes #3754\r\n\r\n@ryanfeeley \r\n@rfk \r\n@shane-tomlinson \r\n","created_at":"2016-05-19T23:59:07Z","updated_at":"2016-05-20T16:08:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43992e0b74d87a04bf7930da0695ecae46d87958","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3755/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/6a79b2fa2780ce033ddfa2505dd269b91a42cfe4","head":{"label":"mozilla:issue-3754-restyle-buttons","ref":"issue-3754-restyle-buttons","sha":"6a79b2fa2780ce033ddfa2505dd269b91a42cfe4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-content-server/deployments","created_at":"2013-07-30T23:35:35Z","updated_at":"2016-04-29T13:43:48Z","pushed_at":"2016-05-20T11:12:52Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"git@github.com:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":16568,"stargazers_count":91,"watchers_count":91,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":133,"forks":60,"open_issues":133,"watchers":91,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"09585b46d0dfd46859c9b9816d015154f059a140","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":11778024,"name":"fxa-content-server","full_name":"mozilla/fxa-content-server","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-content-server","description":"Firefox Accounts Content Server","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-content-server","forks_url":"https://api.github.com/repos/mozilla/fxa-content-server/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-content-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-content-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-content-server/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-content-server/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-content-server/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-content-server/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-content-server/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-content-server/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-content-server/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-content-server/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-content-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-content-server/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-content-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-content-server/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-content-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-content-server/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-content-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-content-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-content-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-content-server/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-content-server/deployments","created_at":"2013-07-30T23:35:35Z","updated_at":"2016-04-29T13:43:48Z","pushed_at":"2016-05-20T11:12:52Z","git_url":"git://github.com/mozilla/fxa-content-server.git","ssh_url":"git@github.com:mozilla/fxa-content-server.git","clone_url":"https://github.com/mozilla/fxa-content-server.git","svn_url":"https://github.com/mozilla/fxa-content-server","homepage":"","size":16568,"stargazers_count":91,"watchers_count":91,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":133,"forks":60,"open_issues":133,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755"},"html":{"href":"https://github.com/mozilla/fxa-content-server/pull/3755"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3755"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/issues/3755/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/pulls/3755/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-content-server/statuses/6a79b2fa2780ce033ddfa2505dd269b91a42cfe4"}}}}
{"actor":{"display_login":"TDA"}}