{"action":"closed","number":50,"pull_request":{"url":"https://api.github.com/repos/ohmu/node-posix/pulls/50","id":85389709,"html_url":"https://github.com/ohmu/node-posix/pull/50","diff_url":"https://github.com/ohmu/node-posix/pull/50.diff","patch_url":"https://github.com/ohmu/node-posix/pull/50.patch","issue_url":"https://api.github.com/repos/ohmu/node-posix/issues/50","number":50,"state":"closed","locked":false,"title":"Throw errors not strings","user":{"login":"achingbrain","id":665810,"avatar_url":"https://avatars.githubusercontent.com/u/665810?v=3","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},"body":"If we throw instances of `String`, catching code has no way of knowing where the string was thrown from.\r\n\r\nThis PR changes the code to throw instances of `Error` instead so there is a `.stack` property available to show to the developer.","created_at":"2016-09-15T11:51:53Z","updated_at":"2016-09-15T21:33:19Z","closed_at":"2016-09-15T21:33:19Z","merged_at":"2016-09-15T21:33:19Z","merge_commit_sha":"9ab49fe08e6aa03279a4eb10f53458568584ae07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ohmu/node-posix/pulls/50/commits","review_comments_url":"https://api.github.com/repos/ohmu/node-posix/pulls/50/comments","review_comment_url":"https://api.github.com/repos/ohmu/node-posix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ohmu/node-posix/issues/50/comments","statuses_url":"https://api.github.com/repos/ohmu/node-posix/statuses/cf528ea92eccc7d303eb162f0d500b12c147ca49","head":{"label":"achingbrain:throw-actual-errors","ref":"throw-actual-errors","sha":"cf528ea92eccc7d303eb162f0d500b12c147ca49","user":{"login":"achingbrain","id":665810,"avatar_url":"https://avatars.githubusercontent.com/u/665810?v=3","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},"repo":{"id":30600406,"name":"node-posix","full_name":"achingbrain/node-posix","owner":{"login":"achingbrain","id":665810,"avatar_url":"https://avatars.githubusercontent.com/u/665810?v=3","gravatar_id":"","url":"https://api.github.com/users/achingbrain","html_url":"https://github.com/achingbrain","followers_url":"https://api.github.com/users/achingbrain/followers","following_url":"https://api.github.com/users/achingbrain/following{/other_user}","gists_url":"https://api.github.com/users/achingbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/achingbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achingbrain/subscriptions","organizations_url":"https://api.github.com/users/achingbrain/orgs","repos_url":"https://api.github.com/users/achingbrain/repos","events_url":"https://api.github.com/users/achingbrain/events{/privacy}","received_events_url":"https://api.github.com/users/achingbrain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achingbrain/node-posix","description":"The missing POSIX system calls for node.js","fork":true,"url":"https://api.github.com/repos/achingbrain/node-posix","forks_url":"https://api.github.com/repos/achingbrain/node-posix/forks","keys_url":"https://api.github.com/repos/achingbrain/node-posix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achingbrain/node-posix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achingbrain/node-posix/teams","hooks_url":"https://api.github.com/repos/achingbrain/node-posix/hooks","issue_events_url":"https://api.github.com/repos/achingbrain/node-posix/issues/events{/number}","events_url":"https://api.github.com/repos/achingbrain/node-posix/events","assignees_url":"https://api.github.com/repos/achingbrain/node-posix/assignees{/user}","branches_url":"https://api.github.com/repos/achingbrain/node-posix/branches{/branch}","tags_url":"https://api.github.com/repos/achingbrain/node-posix/tags","blobs_url":"https://api.github.com/repos/achingbrain/node-posix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achingbrain/node-posix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achingbrain/node-posix/git/refs{/sha}","trees_url":"https://api.github.com/repos/achingbrain/node-posix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achingbrain/node-posix/statuses/{sha}","languages_url":"https://api.github.com/repos/achingbrain/node-posix/languages","stargazers_url":"https://api.github.com/repos/achingbrain/node-posix/stargazers","contributors_url":"https://api.github.com/repos/achingbrain/node-posix/contributors","subscribers_url":"https://api.github.com/repos/achingbrain/node-posix/subscribers","subscription_url":"https://api.github.com/repos/achingbrain/node-posix/subscription","commits_url":"https://api.github.com/repos/achingbrain/node-posix/commits{/sha}","git_commits_url":"https://api.github.com/repos/achingbrain/node-posix/git/commits{/sha}","comments_url":"https://api.github.com/repos/achingbrain/node-posix/comments{/number}","issue_comment_url":"https://api.github.com/repos/achingbrain/node-posix/issues/comments{/number}","contents_url":"https://api.github.com/repos/achingbrain/node-posix/contents/{+path}","compare_url":"https://api.github.com/repos/achingbrain/node-posix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achingbrain/node-posix/merges","archive_url":"https://api.github.com/repos/achingbrain/node-posix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achingbrain/node-posix/downloads","issues_url":"https://api.github.com/repos/achingbrain/node-posix/issues{/number}","pulls_url":"https://api.github.com/repos/achingbrain/node-posix/pulls{/number}","milestones_url":"https://api.github.com/repos/achingbrain/node-posix/milestones{/number}","notifications_url":"https://api.github.com/repos/achingbrain/node-posix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achingbrain/node-posix/labels{/name}","releases_url":"https://api.github.com/repos/achingbrain/node-posix/releases{/id}","deployments_url":"https://api.github.com/repos/achingbrain/node-posix/deployments","created_at":"2015-02-10T16:04:01Z","updated_at":"2016-09-15T11:48:45Z","pushed_at":"2016-09-15T11:49:52Z","git_url":"git://github.com/achingbrain/node-posix.git","ssh_url":"git@github.com:achingbrain/node-posix.git","clone_url":"https://github.com/achingbrain/node-posix.git","svn_url":"https://github.com/achingbrain/node-posix","homepage":"","size":96,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ohmu:master","ref":"master","sha":"7e3cc0eef7537dfd155c7601bb0d20da42d179f1","user":{"login":"ohmu","id":986303,"avatar_url":"https://avatars.githubusercontent.com/u/986303?v=3","gravatar_id":"","url":"https://api.github.com/users/ohmu","html_url":"https://github.com/ohmu","followers_url":"https://api.github.com/users/ohmu/followers","following_url":"https://api.github.com/users/ohmu/following{/other_user}","gists_url":"https://api.github.com/users/ohmu/gists{/gist_id}","starred_url":"https://api.github.com/users/ohmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohmu/subscriptions","organizations_url":"https://api.github.com/users/ohmu/orgs","repos_url":"https://api.github.com/users/ohmu/repos","events_url":"https://api.github.com/users/ohmu/events{/privacy}","received_events_url":"https://api.github.com/users/ohmu/received_events","type":"Organization","site_admin":false},"repo":{"id":2824073,"name":"node-posix","full_name":"ohmu/node-posix","owner":{"login":"ohmu","id":986303,"avatar_url":"https://avatars.githubusercontent.com/u/986303?v=3","gravatar_id":"","url":"https://api.github.com/users/ohmu","html_url":"https://github.com/ohmu","followers_url":"https://api.github.com/users/ohmu/followers","following_url":"https://api.github.com/users/ohmu/following{/other_user}","gists_url":"https://api.github.com/users/ohmu/gists{/gist_id}","starred_url":"https://api.github.com/users/ohmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohmu/subscriptions","organizations_url":"https://api.github.com/users/ohmu/orgs","repos_url":"https://api.github.com/users/ohmu/repos","events_url":"https://api.github.com/users/ohmu/events{/privacy}","received_events_url":"https://api.github.com/users/ohmu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ohmu/node-posix","description":"The missing POSIX system calls for node.js","fork":false,"url":"https://api.github.com/repos/ohmu/node-posix","forks_url":"https://api.github.com/repos/ohmu/node-posix/forks","keys_url":"https://api.github.com/repos/ohmu/node-posix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ohmu/node-posix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ohmu/node-posix/teams","hooks_url":"https://api.github.com/repos/ohmu/node-posix/hooks","issue_events_url":"https://api.github.com/repos/ohmu/node-posix/issues/events{/number}","events_url":"https://api.github.com/repos/ohmu/node-posix/events","assignees_url":"https://api.github.com/repos/ohmu/node-posix/assignees{/user}","branches_url":"https://api.github.com/repos/ohmu/node-posix/branches{/branch}","tags_url":"https://api.github.com/repos/ohmu/node-posix/tags","blobs_url":"https://api.github.com/repos/ohmu/node-posix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ohmu/node-posix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ohmu/node-posix/git/refs{/sha}","trees_url":"https://api.github.com/repos/ohmu/node-posix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ohmu/node-posix/statuses/{sha}","languages_url":"https://api.github.com/repos/ohmu/node-posix/languages","stargazers_url":"https://api.github.com/repos/ohmu/node-posix/stargazers","contributors_url":"https://api.github.com/repos/ohmu/node-posix/contributors","subscribers_url":"https://api.github.com/repos/ohmu/node-posix/subscribers","subscription_url":"https://api.github.com/repos/ohmu/node-posix/subscription","commits_url":"https://api.github.com/repos/ohmu/node-posix/commits{/sha}","git_commits_url":"https://api.github.com/repos/ohmu/node-posix/git/commits{/sha}","comments_url":"https://api.github.com/repos/ohmu/node-posix/comments{/number}","issue_comment_url":"https://api.github.com/repos/ohmu/node-posix/issues/comments{/number}","contents_url":"https://api.github.com/repos/ohmu/node-posix/contents/{+path}","compare_url":"https://api.github.com/repos/ohmu/node-posix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ohmu/node-posix/merges","archive_url":"https://api.github.com/repos/ohmu/node-posix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ohmu/node-posix/downloads","issues_url":"https://api.github.com/repos/ohmu/node-posix/issues{/number}","pulls_url":"https://api.github.com/repos/ohmu/node-posix/pulls{/number}","milestones_url":"https://api.github.com/repos/ohmu/node-posix/milestones{/number}","notifications_url":"https://api.github.com/repos/ohmu/node-posix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ohmu/node-posix/labels{/name}","releases_url":"https://api.github.com/repos/ohmu/node-posix/releases{/id}","deployments_url":"https://api.github.com/repos/ohmu/node-posix/deployments","created_at":"2011-11-21T23:44:05Z","updated_at":"2016-09-01T00:31:44Z","pushed_at":"2016-09-15T21:33:19Z","git_url":"git://github.com/ohmu/node-posix.git","ssh_url":"git@github.com:ohmu/node-posix.git","clone_url":"https://github.com/ohmu/node-posix.git","svn_url":"https://github.com/ohmu/node-posix","homepage":"","size":107,"stargazers_count":161,"watchers_count":161,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":1,"forks":35,"open_issues":1,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ohmu/node-posix/pulls/50"},"html":{"href":"https://github.com/ohmu/node-posix/pull/50"},"issue":{"href":"https://api.github.com/repos/ohmu/node-posix/issues/50"},"comments":{"href":"https://api.github.com/repos/ohmu/node-posix/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/ohmu/node-posix/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/ohmu/node-posix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ohmu/node-posix/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/ohmu/node-posix/statuses/cf528ea92eccc7d303eb162f0d500b12c147ca49"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"melor","id":396587,"avatar_url":"https://avatars.githubusercontent.com/u/396587?v=3","gravatar_id":"","url":"https://api.github.com/users/melor","html_url":"https://github.com/melor","followers_url":"https://api.github.com/users/melor/followers","following_url":"https://api.github.com/users/melor/following{/other_user}","gists_url":"https://api.github.com/users/melor/gists{/gist_id}","starred_url":"https://api.github.com/users/melor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melor/subscriptions","organizations_url":"https://api.github.com/users/melor/orgs","repos_url":"https://api.github.com/users/melor/repos","events_url":"https://api.github.com/users/melor/events{/privacy}","received_events_url":"https://api.github.com/users/melor/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"melor"}}