{"action":"closed","number":7178,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7178","id":72711005,"html_url":"https://github.com/nodejs/node/pull/7178","diff_url":"https://github.com/nodejs/node/pull/7178.diff","patch_url":"https://github.com/nodejs/node/pull/7178.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/7178","number":7178,"state":"closed","locked":false,"title":"benchmark: fix child-process-exec-stdout on win","user":{"login":"bzoz","id":17704638,"avatar_url":"https://avatars.githubusercontent.com/u/17704638?v=3","gravatar_id":"","url":"https://api.github.com/users/bzoz","html_url":"https://github.com/bzoz","followers_url":"https://api.github.com/users/bzoz/followers","following_url":"https://api.github.com/users/bzoz/following{/other_user}","gists_url":"https://api.github.com/users/bzoz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzoz/subscriptions","organizations_url":"https://api.github.com/users/bzoz/orgs","repos_url":"https://api.github.com/users/bzoz/repos","events_url":"https://api.github.com/users/bzoz/events{/privacy}","received_events_url":"https://api.github.com/users/bzoz/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nbenchmark\r\n\r\n##### Description of change\r\n\r\nThis benchmark fails on Windows when trying to execute command which\r\nis more than 32k in size. This commits skips this one case when running\r\nunder Windows.\r\n\r\ncc @nodejs/benchmarking","created_at":"2016-06-06T13:42:07Z","updated_at":"2016-06-10T15:32:23Z","closed_at":"2016-06-10T15:32:23Z","merged_at":null,"merge_commit_sha":"926565205ef2fb76c5c1459f366e46592beddc0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/7178/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/7178/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7178/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/9d1bfd92d9a6a339e9695ed29ad1ddd26374eaa6","head":{"label":"janeasystems:bartosz-child-process-exec-stdout-windows-fix","ref":"bartosz-child-process-exec-stdout-windows-fix","sha":"9d1bfd92d9a6a339e9695ed29ad1ddd26374eaa6","user":{"login":"janeasystems","id":9194778,"avatar_url":"https://avatars.githubusercontent.com/u/9194778?v=3","gravatar_id":"","url":"https://api.github.com/users/janeasystems","html_url":"https://github.com/janeasystems","followers_url":"https://api.github.com/users/janeasystems/followers","following_url":"https://api.github.com/users/janeasystems/following{/other_user}","gists_url":"https://api.github.com/users/janeasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/janeasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janeasystems/subscriptions","organizations_url":"https://api.github.com/users/janeasystems/orgs","repos_url":"https://api.github.com/users/janeasystems/repos","events_url":"https://api.github.com/users/janeasystems/events{/privacy}","received_events_url":"https://api.github.com/users/janeasystems/received_events","type":"Organization","site_admin":false},"repo":{"id":36501512,"name":"node","full_name":"janeasystems/node","owner":{"login":"janeasystems","id":9194778,"avatar_url":"https://avatars.githubusercontent.com/u/9194778?v=3","gravatar_id":"","url":"https://api.github.com/users/janeasystems","html_url":"https://github.com/janeasystems","followers_url":"https://api.github.com/users/janeasystems/followers","following_url":"https://api.github.com/users/janeasystems/following{/other_user}","gists_url":"https://api.github.com/users/janeasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/janeasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janeasystems/subscriptions","organizations_url":"https://api.github.com/users/janeasystems/orgs","repos_url":"https://api.github.com/users/janeasystems/repos","events_url":"https://api.github.com/users/janeasystems/events{/privacy}","received_events_url":"https://api.github.com/users/janeasystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/janeasystems/node","description":"Node.js, but with bigger and faster version numbers","fork":true,"url":"https://api.github.com/repos/janeasystems/node","forks_url":"https://api.github.com/repos/janeasystems/node/forks","keys_url":"https://api.github.com/repos/janeasystems/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janeasystems/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janeasystems/node/teams","hooks_url":"https://api.github.com/repos/janeasystems/node/hooks","issue_events_url":"https://api.github.com/repos/janeasystems/node/issues/events{/number}","events_url":"https://api.github.com/repos/janeasystems/node/events","assignees_url":"https://api.github.com/repos/janeasystems/node/assignees{/user}","branches_url":"https://api.github.com/repos/janeasystems/node/branches{/branch}","tags_url":"https://api.github.com/repos/janeasystems/node/tags","blobs_url":"https://api.github.com/repos/janeasystems/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janeasystems/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janeasystems/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/janeasystems/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janeasystems/node/statuses/{sha}","languages_url":"https://api.github.com/repos/janeasystems/node/languages","stargazers_url":"https://api.github.com/repos/janeasystems/node/stargazers","contributors_url":"https://api.github.com/repos/janeasystems/node/contributors","subscribers_url":"https://api.github.com/repos/janeasystems/node/subscribers","subscription_url":"https://api.github.com/repos/janeasystems/node/subscription","commits_url":"https://api.github.com/repos/janeasystems/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/janeasystems/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/janeasystems/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/janeasystems/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/janeasystems/node/contents/{+path}","compare_url":"https://api.github.com/repos/janeasystems/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janeasystems/node/merges","archive_url":"https://api.github.com/repos/janeasystems/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janeasystems/node/downloads","issues_url":"https://api.github.com/repos/janeasystems/node/issues{/number}","pulls_url":"https://api.github.com/repos/janeasystems/node/pulls{/number}","milestones_url":"https://api.github.com/repos/janeasystems/node/milestones{/number}","notifications_url":"https://api.github.com/repos/janeasystems/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janeasystems/node/labels{/name}","releases_url":"https://api.github.com/repos/janeasystems/node/releases{/id}","deployments_url":"https://api.github.com/repos/janeasystems/node/deployments","created_at":"2015-05-29T11:56:02Z","updated_at":"2016-01-14T15:48:15Z","pushed_at":"2016-06-10T14:57:03Z","git_url":"git://github.com/janeasystems/node.git","ssh_url":"git@github.com:janeasystems/node.git","clone_url":"https://github.com/janeasystems/node.git","svn_url":"https://github.com/janeasystems/node","homepage":"https://iojs.org","size":213362,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c300ba22128ce8e675650adcd1f6b869dc1b5126","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-06-10T14:58:51Z","pushed_at":"2016-06-10T15:31:11Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":280976,"stargazers_count":23951,"watchers_count":23951,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3491,"mirror_url":null,"open_issues_count":699,"forks":3491,"open_issues":699,"watchers":23951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/7178"},"html":{"href":"https://github.com/nodejs/node/pull/7178"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/7178"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/7178/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/7178/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/7178/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/9d1bfd92d9a6a339e9695ed29ad1ddd26374eaa6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"orangemocha"}}