{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/deploynaut/pulls/comments/82537260","pull_request_review_id":3438534,"id":82537260,"diff_hunk":"@@ -77,6 +77,12 @@ protected function addHandlers($machine) {\n \t\t$class = get_class($machine->getObject());\n \t\tif (empty($this->config()->handlers[$class])) return;\n \n+\t\t// this is the \"internal\" state listener that logs all state transitions into a log file for debugging\n+\t\t$machine->getDispatcher()->addListener(\n+\t\t\t'finite.post_transition',\n+\t\t\t[Injector::inst()->get('DNDeploymentHandlers'), 'onAnyTransition']","path":"code/model/StateMachineFactory.php","position":7,"original_position":7,"commit_id":"ea469306ea8eaeadaa576a4ca05246b8def08437","original_commit_id":"ea469306ea8eaeadaa576a4ca05246b8def08437","user":{"login":"stojg","id":485130,"avatar_url":"https://avatars.githubusercontent.com/u/485130?v=3","gravatar_id":"","url":"https://api.github.com/users/stojg","html_url":"https://github.com/stojg","followers_url":"https://api.github.com/users/stojg/followers","following_url":"https://api.github.com/users/stojg/following{/other_user}","gists_url":"https://api.github.com/users/stojg/gists{/gist_id}","starred_url":"https://api.github.com/users/stojg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stojg/subscriptions","organizations_url":"https://api.github.com/users/stojg/orgs","repos_url":"https://api.github.com/users/stojg/repos","events_url":"https://api.github.com/users/stojg/events{/privacy}","received_events_url":"https://api.github.com/users/stojg/received_events","type":"User","site_admin":false},"body":"maybe call it `onAfterTransition` if we follow SS jargon and make clear to users just looking at that method that the transition has already been done?","created_at":"2016-10-10T01:22:03Z","updated_at":"2016-10-10T01:22:03Z","html_url":"https://github.com/silverstripe/deploynaut/pull/697#discussion_r82537260","pull_request_url":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/deploynaut/pulls/comments/82537260"},"html":{"href":"https://github.com/silverstripe/deploynaut/pull/697#discussion_r82537260"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697","id":88602129,"html_url":"https://github.com/silverstripe/deploynaut/pull/697","diff_url":"https://github.com/silverstripe/deploynaut/pull/697.diff","patch_url":"https://github.com/silverstripe/deploynaut/pull/697.patch","issue_url":"https://api.github.com/repos/silverstripe/deploynaut/issues/697","number":697,"state":"open","locked":false,"title":"Log state transitions in deploy log","user":{"login":"halkyon","id":138450,"avatar_url":"https://avatars.githubusercontent.com/u/138450?v=3","gravatar_id":"","url":"https://api.github.com/users/halkyon","html_url":"https://github.com/halkyon","followers_url":"https://api.github.com/users/halkyon/followers","following_url":"https://api.github.com/users/halkyon/following{/other_user}","gists_url":"https://api.github.com/users/halkyon/gists{/gist_id}","starred_url":"https://api.github.com/users/halkyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkyon/subscriptions","organizations_url":"https://api.github.com/users/halkyon/orgs","repos_url":"https://api.github.com/users/halkyon/repos","events_url":"https://api.github.com/users/halkyon/events{/privacy}","received_events_url":"https://api.github.com/users/halkyon/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-10T01:15:55Z","updated_at":"2016-10-10T01:22:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07b0bafa9098800d5830f7b40d0ce5c298730387","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697/commits","review_comments_url":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697/comments","review_comment_url":"https://api.github.com/repos/silverstripe/deploynaut/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/deploynaut/issues/697/comments","statuses_url":"https://api.github.com/repos/silverstripe/deploynaut/statuses/ea469306ea8eaeadaa576a4ca05246b8def08437","head":{"label":"silverstripe:log-state-transitions","ref":"log-state-transitions","sha":"ea469306ea8eaeadaa576a4ca05246b8def08437","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":23821541,"name":"deploynaut","full_name":"silverstripe/deploynaut","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/deploynaut","description":"A web based tool for performing deployments","fork":false,"url":"https://api.github.com/repos/silverstripe/deploynaut","forks_url":"https://api.github.com/repos/silverstripe/deploynaut/forks","keys_url":"https://api.github.com/repos/silverstripe/deploynaut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/deploynaut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/deploynaut/teams","hooks_url":"https://api.github.com/repos/silverstripe/deploynaut/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/deploynaut/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/deploynaut/events","assignees_url":"https://api.github.com/repos/silverstripe/deploynaut/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/deploynaut/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/deploynaut/tags","blobs_url":"https://api.github.com/repos/silverstripe/deploynaut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/deploynaut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/deploynaut/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/deploynaut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/deploynaut/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/deploynaut/languages","stargazers_url":"https://api.github.com/repos/silverstripe/deploynaut/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/deploynaut/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/deploynaut/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/deploynaut/subscription","commits_url":"https://api.github.com/repos/silverstripe/deploynaut/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/deploynaut/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/deploynaut/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/deploynaut/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/deploynaut/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/deploynaut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/deploynaut/merges","archive_url":"https://api.github.com/repos/silverstripe/deploynaut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/deploynaut/downloads","issues_url":"https://api.github.com/repos/silverstripe/deploynaut/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/deploynaut/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/deploynaut/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/deploynaut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/deploynaut/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/deploynaut/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/deploynaut/deployments","created_at":"2014-09-09T06:09:55Z","updated_at":"2016-10-05T20:29:06Z","pushed_at":"2016-10-10T01:19:43Z","git_url":"git://github.com/silverstripe/deploynaut.git","ssh_url":"git@github.com:silverstripe/deploynaut.git","clone_url":"https://github.com/silverstripe/deploynaut.git","svn_url":"https://github.com/silverstripe/deploynaut","homepage":"","size":8184,"stargazers_count":69,"watchers_count":69,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":51,"forks":31,"open_issues":51,"watchers":69,"default_branch":"1.1"}},"base":{"label":"silverstripe:master","ref":"master","sha":"252c8f74ad727d4be664f44479d0b40ddb2a7489","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":23821541,"name":"deploynaut","full_name":"silverstripe/deploynaut","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/deploynaut","description":"A web based tool for performing deployments","fork":false,"url":"https://api.github.com/repos/silverstripe/deploynaut","forks_url":"https://api.github.com/repos/silverstripe/deploynaut/forks","keys_url":"https://api.github.com/repos/silverstripe/deploynaut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/deploynaut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/deploynaut/teams","hooks_url":"https://api.github.com/repos/silverstripe/deploynaut/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/deploynaut/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/deploynaut/events","assignees_url":"https://api.github.com/repos/silverstripe/deploynaut/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/deploynaut/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/deploynaut/tags","blobs_url":"https://api.github.com/repos/silverstripe/deploynaut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/deploynaut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/deploynaut/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/deploynaut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/deploynaut/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/deploynaut/languages","stargazers_url":"https://api.github.com/repos/silverstripe/deploynaut/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/deploynaut/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/deploynaut/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/deploynaut/subscription","commits_url":"https://api.github.com/repos/silverstripe/deploynaut/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/deploynaut/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/deploynaut/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/deploynaut/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/deploynaut/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/deploynaut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/deploynaut/merges","archive_url":"https://api.github.com/repos/silverstripe/deploynaut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/deploynaut/downloads","issues_url":"https://api.github.com/repos/silverstripe/deploynaut/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/deploynaut/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/deploynaut/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/deploynaut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/deploynaut/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/deploynaut/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/deploynaut/deployments","created_at":"2014-09-09T06:09:55Z","updated_at":"2016-10-05T20:29:06Z","pushed_at":"2016-10-10T01:19:43Z","git_url":"git://github.com/silverstripe/deploynaut.git","ssh_url":"git@github.com:silverstripe/deploynaut.git","clone_url":"https://github.com/silverstripe/deploynaut.git","svn_url":"https://github.com/silverstripe/deploynaut","homepage":"","size":8184,"stargazers_count":69,"watchers_count":69,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":51,"forks":31,"open_issues":51,"watchers":69,"default_branch":"1.1"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697"},"html":{"href":"https://github.com/silverstripe/deploynaut/pull/697"},"issue":{"href":"https://api.github.com/repos/silverstripe/deploynaut/issues/697"},"comments":{"href":"https://api.github.com/repos/silverstripe/deploynaut/issues/697/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/deploynaut/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/deploynaut/pulls/697/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/deploynaut/statuses/ea469306ea8eaeadaa576a4ca05246b8def08437"}}}}
{"actor":{"display_login":"stojg"}}