{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/5201","repository_url":"https://api.github.com/repos/puppetlabs/puppet","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5201/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5201/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5201/events","html_url":"https://github.com/puppetlabs/puppet/pull/5201","id":171280760,"number":5201,"title":"(PUP-6586) Check auth success codes for Windows logon","user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-15T22:54:36Z","updated_at":"2016-08-17T21:45:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5201","html_url":"https://github.com/puppetlabs/puppet/pull/5201","diff_url":"https://github.com/puppetlabs/puppet/pull/5201.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5201.patch"},"body":"The password getter in the Windows user provider issues a logon attempt to verify the password and determine if the value needs synchronized. Prior to this commit, any failure to logon would result in a false return from Puppet::Util::Windows::User.password_is? which would trigger a password reset. As (somewhat) documented in\r\nhttps://msdn.microsoft.com/en-us/library/windows/desktop/ms681385(v=vs.85).aspx, there are several error codes that indicate logon failure for a different reason than incorrect username/password. After some investigation, it was determined that these codes could be used to indicate a successful authentication even if logon failed. This commit modifies the method to explicitly check for these error codes and return 'true' if encountered, to prevent unnecessary password resets."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/240559075","html_url":"https://github.com/puppetlabs/puppet/pull/5201#issuecomment-240559075","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5201","id":240559075,"user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T21:45:31Z","updated_at":"2016-08-17T21:45:31Z","body":"I still want to add an acceptance test to this w/a disabled user. "}}
{"actor":{"display_login":"MosesMendoza"}}