{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/hmda-platform/issues/726","repository_url":"https://api.github.com/repos/cfpb/hmda-platform","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/726/comments","events_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/726/events","html_url":"https://github.com/cfpb/hmda-platform/issues/726","id":194058828,"number":726,"title":"CSV download for edits","user":{"login":"awolfe76","id":2932572,"avatar_url":"https://avatars.githubusercontent.com/u/2932572?v=3","gravatar_id":"","url":"https://api.github.com/users/awolfe76","html_url":"https://github.com/awolfe76","followers_url":"https://api.github.com/users/awolfe76/followers","following_url":"https://api.github.com/users/awolfe76/following{/other_user}","gists_url":"https://api.github.com/users/awolfe76/gists{/gist_id}","starred_url":"https://api.github.com/users/awolfe76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awolfe76/subscriptions","organizations_url":"https://api.github.com/users/awolfe76/orgs","repos_url":"https://api.github.com/users/awolfe76/repos","events_url":"https://api.github.com/users/awolfe76/events{/privacy}","received_events_url":"https://api.github.com/users/awolfe76/received_events","type":"User","site_admin":false},"labels":[{"id":318539567,"url":"https://api.github.com/repos/cfpb/hmda-platform/labels/Data%20Validation","name":"Data Validation","color":"5319e7","default":false},{"id":318539955,"url":"https://api.github.com/repos/cfpb/hmda-platform/labels/File%20Submission","name":"File Submission","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"nickgrippin","id":19194939,"avatar_url":"https://avatars.githubusercontent.com/u/19194939?v=3","gravatar_id":"","url":"https://api.github.com/users/nickgrippin","html_url":"https://github.com/nickgrippin","followers_url":"https://api.github.com/users/nickgrippin/followers","following_url":"https://api.github.com/users/nickgrippin/following{/other_user}","gists_url":"https://api.github.com/users/nickgrippin/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgrippin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgrippin/subscriptions","organizations_url":"https://api.github.com/users/nickgrippin/orgs","repos_url":"https://api.github.com/users/nickgrippin/repos","events_url":"https://api.github.com/users/nickgrippin/events{/privacy}","received_events_url":"https://api.github.com/users/nickgrippin/received_events","type":"User","site_admin":false},"assignees":[{"login":"nickgrippin","id":19194939,"avatar_url":"https://avatars.githubusercontent.com/u/19194939?v=3","gravatar_id":"","url":"https://api.github.com/users/nickgrippin","html_url":"https://github.com/nickgrippin","followers_url":"https://api.github.com/users/nickgrippin/followers","following_url":"https://api.github.com/users/nickgrippin/following{/other_user}","gists_url":"https://api.github.com/users/nickgrippin/gists{/gist_id}","starred_url":"https://api.github.com/users/nickgrippin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickgrippin/subscriptions","organizations_url":"https://api.github.com/users/nickgrippin/orgs","repos_url":"https://api.github.com/users/nickgrippin/repos","events_url":"https://api.github.com/users/nickgrippin/events{/privacy}","received_events_url":"https://api.github.com/users/nickgrippin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/cfpb/hmda-platform/milestones/22","html_url":"https://github.com/cfpb/hmda-platform/milestone/22","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/milestones/22/labels","id":2164242,"number":22,"title":"Sprint 21","description":"","creator":{"login":"Kibrael","id":8459164,"avatar_url":"https://avatars.githubusercontent.com/u/8459164?v=3","gravatar_id":"","url":"https://api.github.com/users/Kibrael","html_url":"https://github.com/Kibrael","followers_url":"https://api.github.com/users/Kibrael/followers","following_url":"https://api.github.com/users/Kibrael/following{/other_user}","gists_url":"https://api.github.com/users/Kibrael/gists{/gist_id}","starred_url":"https://api.github.com/users/Kibrael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kibrael/subscriptions","organizations_url":"https://api.github.com/users/Kibrael/orgs","repos_url":"https://api.github.com/users/Kibrael/repos","events_url":"https://api.github.com/users/Kibrael/events{/privacy}","received_events_url":"https://api.github.com/users/Kibrael/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2016-11-29T17:35:35Z","updated_at":"2016-12-14T17:01:22Z","due_on":"2016-12-25T00:00:00Z","closed_at":null},"comments":3,"created_at":"2016-12-07T14:09:42Z","updated_at":"2016-12-14T19:44:32Z","closed_at":null,"body":"We need to provide a way to allow filers to download their edits in CSV format.\r\n\r\nWe should allow this by:\r\n- [ ] edit type, a single edit type\r\n- [ ] edit type, all edits combined\r\n- [ ] row (depends on #718)\r\n\r\nOne way of doing this may be to add it to the `/institutions/<institution>/filings/<period>/submissions/<submissionId>/edits` and `/institutions/<institution>/filings/<period>/submissions/<submissionId>/edits/<syntactical|validity|quality|macro>` endpoints by adding a `?format=csv` parameter.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/hmda-platform/issues/comments/267135704","html_url":"https://github.com/cfpb/hmda-platform/issues/726#issuecomment-267135704","issue_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/726","id":267135704,"user":{"login":"awolfe76","id":2932572,"avatar_url":"https://avatars.githubusercontent.com/u/2932572?v=3","gravatar_id":"","url":"https://api.github.com/users/awolfe76","html_url":"https://github.com/awolfe76","followers_url":"https://api.github.com/users/awolfe76/followers","following_url":"https://api.github.com/users/awolfe76/following{/other_user}","gists_url":"https://api.github.com/users/awolfe76/gists{/gist_id}","starred_url":"https://api.github.com/users/awolfe76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awolfe76/subscriptions","organizations_url":"https://api.github.com/users/awolfe76/orgs","repos_url":"https://api.github.com/users/awolfe76/repos","events_url":"https://api.github.com/users/awolfe76/events{/privacy}","received_events_url":"https://api.github.com/users/awolfe76/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T19:44:32Z","updated_at":"2016-12-14T19:44:32Z","body":"> Another question: are we including persisted justifications from the macro edits? They're typically returned from the edits endpoint, but I'm not sure if I'm comfortable returning them in CSV format.\r\n\r\nI think we're ok to __not__ include them for now.\r\n\r\n> Also, are we using the pipe-delimited format? (I assumed so)\r\n\r\nI think comma separated will work better for filers.\r\n\r\n---\r\n\r\nYour first option works. Another option would be each edit on its own row. Like this (macro would not have a `loanId`):\r\n\r\n```\r\neditType, editId, loanId\r\nsyntactical, S100, 1234567890\r\nsyntactical, S100, 0987654321\r\nmacro, q800, \r\n```\r\n\r\nEither way we may run into some [limitations of excel](https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=maximum+columns+in+excel).\r\n\r\nAnd what do the `true` and `false` mean in your first example?"}}
{"actor":{"display_login":"awolfe76"}}