{"action":"created","issue":{"url":"https://api.github.com/repos/chiedolabs/react-stl-viewer/issues/3","repository_url":"https://api.github.com/repos/chiedolabs/react-stl-viewer","labels_url":"https://api.github.com/repos/chiedolabs/react-stl-viewer/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/chiedolabs/react-stl-viewer/issues/3/comments","events_url":"https://api.github.com/repos/chiedolabs/react-stl-viewer/issues/3/events","html_url":"https://github.com/chiedolabs/react-stl-viewer/issues/3","id":183204954,"number":3,"title":"CORS limitation","user":{"login":"asafge","id":3135868,"avatar_url":"https://avatars.githubusercontent.com/u/3135868?v=3","gravatar_id":"","url":"https://api.github.com/users/asafge","html_url":"https://github.com/asafge","followers_url":"https://api.github.com/users/asafge/followers","following_url":"https://api.github.com/users/asafge/following{/other_user}","gists_url":"https://api.github.com/users/asafge/gists{/gist_id}","starred_url":"https://api.github.com/users/asafge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asafge/subscriptions","organizations_url":"https://api.github.com/users/asafge/orgs","repos_url":"https://api.github.com/users/asafge/repos","events_url":"https://api.github.com/users/asafge/events{/privacy}","received_events_url":"https://api.github.com/users/asafge/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-15T11:36:52Z","updated_at":"2016-10-15T12:06:32Z","closed_at":"2016-10-15T12:06:32Z","body":"Hi,\r\nThe CORS limitation can be avoided, this is mostly depending on the server's CORS configuration which might allow all origins to access the file.\r\n\r\nOn the client side, the THREE.js loaders actually support this, but needs to have an attribute set:\r\nIn STLViewer.js, right after: `let loader = new THREE.STLLoader();`, Setting `loader.crossOrigin = '';`, allows loading external STL files.\r\n\r\nI'm not if this should be set using an optional parameter or is this OK as a default, but anyway it works and removes the same origin limitation, as long as the server is configured correctly.\r\n\r\nWould love to hear your thoughts on this.\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/chiedolabs/react-stl-viewer/issues/comments/253980427","html_url":"https://github.com/chiedolabs/react-stl-viewer/issues/3#issuecomment-253980427","issue_url":"https://api.github.com/repos/chiedolabs/react-stl-viewer/issues/3","id":253980427,"user":{"login":"asafge","id":3135868,"avatar_url":"https://avatars.githubusercontent.com/u/3135868?v=3","gravatar_id":"","url":"https://api.github.com/users/asafge","html_url":"https://github.com/asafge","followers_url":"https://api.github.com/users/asafge/followers","following_url":"https://api.github.com/users/asafge/following{/other_user}","gists_url":"https://api.github.com/users/asafge/gists{/gist_id}","starred_url":"https://api.github.com/users/asafge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asafge/subscriptions","organizations_url":"https://api.github.com/users/asafge/orgs","repos_url":"https://api.github.com/users/asafge/repos","events_url":"https://api.github.com/users/asafge/events{/privacy}","received_events_url":"https://api.github.com/users/asafge/received_events","type":"User","site_admin":false},"created_at":"2016-10-15T12:06:32Z","updated_at":"2016-10-15T12:06:32Z","body":"@chiedo Sure, thanks for the fast merges :)"}}
{"actor":{"display_login":"asafge"}}