{"action":"created","comment":{"url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments/78785499","id":78785499,"diff_hunk":"@@ -88,3 +88,16 @@ rgbColor24bpp_t hsvToRgb24(const hsvColor_t* c)\n     return r;\n }\n \n+rgbwColor32bpp_t hsvToRgbw32(const hsvColor_t* c)\n+{\n+    rgbwColor32bpp_t r;\n+    rgbColor24bpp_t rgb = hsvToRgb24(c);\n+\n+    r.rgbw.r = rgb.rgb.r;\n+    r.rgbw.g = rgb.rgb.g;\n+    r.rgbw.b = rgb.rgb.b;\n+    r.rgbw.w = c->w;","path":"src/main/common/colorconversion.c","position":12,"original_position":12,"commit_id":"de5a32e00060d72fd5c828d5103469693073e79e","original_commit_id":"de5a32e00060d72fd5c828d5103469693073e79e","user":{"login":"hydra","id":57075,"avatar_url":"https://avatars.githubusercontent.com/u/57075?v=3","gravatar_id":"","url":"https://api.github.com/users/hydra","html_url":"https://github.com/hydra","followers_url":"https://api.github.com/users/hydra/followers","following_url":"https://api.github.com/users/hydra/following{/other_user}","gists_url":"https://api.github.com/users/hydra/gists{/gist_id}","starred_url":"https://api.github.com/users/hydra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hydra/subscriptions","organizations_url":"https://api.github.com/users/hydra/orgs","repos_url":"https://api.github.com/users/hydra/repos","events_url":"https://api.github.com/users/hydra/events{/privacy}","received_events_url":"https://api.github.com/users/hydra/received_events","type":"User","site_admin":false},"body":"this is the source of the issue with 'w' being added to hsvColor_t.\r\n\r\nI feel that perhaps a suitable algorithm i should be used here when sets rgbw.w correctly based on just the hsv values.","created_at":"2016-09-14T16:35:24Z","updated_at":"2016-09-14T16:35:24Z","html_url":"https://github.com/cleanflight/cleanflight/pull/2323#discussion_r78785499","pull_request_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323","_links":{"self":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments/78785499"},"html":{"href":"https://github.com/cleanflight/cleanflight/pull/2323#discussion_r78785499"},"pull_request":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323"}}},"pull_request":{"url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323","id":78403645,"html_url":"https://github.com/cleanflight/cleanflight/pull/2323","diff_url":"https://github.com/cleanflight/cleanflight/pull/2323.diff","patch_url":"https://github.com/cleanflight/cleanflight/pull/2323.patch","issue_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/2323","number":2323,"state":"open","locked":false,"title":"Support of RGBW LEDs","user":{"login":"gaelj","id":8884632,"avatar_url":"https://avatars.githubusercontent.com/u/8884632?v=3","gravatar_id":"","url":"https://api.github.com/users/gaelj","html_url":"https://github.com/gaelj","followers_url":"https://api.github.com/users/gaelj/followers","following_url":"https://api.github.com/users/gaelj/following{/other_user}","gists_url":"https://api.github.com/users/gaelj/gists{/gist_id}","starred_url":"https://api.github.com/users/gaelj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaelj/subscriptions","organizations_url":"https://api.github.com/users/gaelj/orgs","repos_url":"https://api.github.com/users/gaelj/repos","events_url":"https://api.github.com/users/gaelj/events{/privacy}","received_events_url":"https://api.github.com/users/gaelj/received_events","type":"User","site_admin":false},"body":"Addresses #2318.\r\nNeeds testing.\r\nAdds the CLI get / set value `led_type`, which accepts `RGB` (24bits) or `RGBW` (32bits).","created_at":"2016-07-21T23:23:23Z","updated_at":"2016-09-14T16:35:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d09ab748ac76eb6a910313015070c3cb086ecee1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323/commits","review_comments_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323/comments","review_comment_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/2323/comments","statuses_url":"https://api.github.com/repos/cleanflight/cleanflight/statuses/de5a32e00060d72fd5c828d5103469693073e79e","head":{"label":"gaelj:RGBW_led_support","ref":"RGBW_led_support","sha":"de5a32e00060d72fd5c828d5103469693073e79e","user":{"login":"gaelj","id":8884632,"avatar_url":"https://avatars.githubusercontent.com/u/8884632?v=3","gravatar_id":"","url":"https://api.github.com/users/gaelj","html_url":"https://github.com/gaelj","followers_url":"https://api.github.com/users/gaelj/followers","following_url":"https://api.github.com/users/gaelj/following{/other_user}","gists_url":"https://api.github.com/users/gaelj/gists{/gist_id}","starred_url":"https://api.github.com/users/gaelj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaelj/subscriptions","organizations_url":"https://api.github.com/users/gaelj/orgs","repos_url":"https://api.github.com/users/gaelj/repos","events_url":"https://api.github.com/users/gaelj/events{/privacy}","received_events_url":"https://api.github.com/users/gaelj/received_events","type":"User","site_admin":false},"repo":{"id":55726478,"name":"cleanflight","full_name":"gaelj/cleanflight","owner":{"login":"gaelj","id":8884632,"avatar_url":"https://avatars.githubusercontent.com/u/8884632?v=3","gravatar_id":"","url":"https://api.github.com/users/gaelj","html_url":"https://github.com/gaelj","followers_url":"https://api.github.com/users/gaelj/followers","following_url":"https://api.github.com/users/gaelj/following{/other_user}","gists_url":"https://api.github.com/users/gaelj/gists{/gist_id}","starred_url":"https://api.github.com/users/gaelj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaelj/subscriptions","organizations_url":"https://api.github.com/users/gaelj/orgs","repos_url":"https://api.github.com/users/gaelj/repos","events_url":"https://api.github.com/users/gaelj/events{/privacy}","received_events_url":"https://api.github.com/users/gaelj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaelj/cleanflight","description":"Clean-code version of the baseflight flight controller firmware","fork":true,"url":"https://api.github.com/repos/gaelj/cleanflight","forks_url":"https://api.github.com/repos/gaelj/cleanflight/forks","keys_url":"https://api.github.com/repos/gaelj/cleanflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaelj/cleanflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaelj/cleanflight/teams","hooks_url":"https://api.github.com/repos/gaelj/cleanflight/hooks","issue_events_url":"https://api.github.com/repos/gaelj/cleanflight/issues/events{/number}","events_url":"https://api.github.com/repos/gaelj/cleanflight/events","assignees_url":"https://api.github.com/repos/gaelj/cleanflight/assignees{/user}","branches_url":"https://api.github.com/repos/gaelj/cleanflight/branches{/branch}","tags_url":"https://api.github.com/repos/gaelj/cleanflight/tags","blobs_url":"https://api.github.com/repos/gaelj/cleanflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaelj/cleanflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaelj/cleanflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaelj/cleanflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaelj/cleanflight/statuses/{sha}","languages_url":"https://api.github.com/repos/gaelj/cleanflight/languages","stargazers_url":"https://api.github.com/repos/gaelj/cleanflight/stargazers","contributors_url":"https://api.github.com/repos/gaelj/cleanflight/contributors","subscribers_url":"https://api.github.com/repos/gaelj/cleanflight/subscribers","subscription_url":"https://api.github.com/repos/gaelj/cleanflight/subscription","commits_url":"https://api.github.com/repos/gaelj/cleanflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaelj/cleanflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaelj/cleanflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaelj/cleanflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaelj/cleanflight/contents/{+path}","compare_url":"https://api.github.com/repos/gaelj/cleanflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaelj/cleanflight/merges","archive_url":"https://api.github.com/repos/gaelj/cleanflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaelj/cleanflight/downloads","issues_url":"https://api.github.com/repos/gaelj/cleanflight/issues{/number}","pulls_url":"https://api.github.com/repos/gaelj/cleanflight/pulls{/number}","milestones_url":"https://api.github.com/repos/gaelj/cleanflight/milestones{/number}","notifications_url":"https://api.github.com/repos/gaelj/cleanflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaelj/cleanflight/labels{/name}","releases_url":"https://api.github.com/repos/gaelj/cleanflight/releases{/id}","deployments_url":"https://api.github.com/repos/gaelj/cleanflight/deployments","created_at":"2016-04-07T20:39:15Z","updated_at":"2016-04-07T20:39:19Z","pushed_at":"2016-09-11T23:15:02Z","git_url":"git://github.com/gaelj/cleanflight.git","ssh_url":"git@github.com:gaelj/cleanflight.git","clone_url":"https://github.com/gaelj/cleanflight.git","svn_url":"https://github.com/gaelj/cleanflight","homepage":"http://cleanflight.com","size":80622,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gaelj"}},"base":{"label":"cleanflight:master","ref":"master","sha":"a094e3f85ea70b9385a3bab109b20c4899d1c697","user":{"login":"cleanflight","id":8776523,"avatar_url":"https://avatars.githubusercontent.com/u/8776523?v=3","gravatar_id":"","url":"https://api.github.com/users/cleanflight","html_url":"https://github.com/cleanflight","followers_url":"https://api.github.com/users/cleanflight/followers","following_url":"https://api.github.com/users/cleanflight/following{/other_user}","gists_url":"https://api.github.com/users/cleanflight/gists{/gist_id}","starred_url":"https://api.github.com/users/cleanflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleanflight/subscriptions","organizations_url":"https://api.github.com/users/cleanflight/orgs","repos_url":"https://api.github.com/users/cleanflight/repos","events_url":"https://api.github.com/users/cleanflight/events{/privacy}","received_events_url":"https://api.github.com/users/cleanflight/received_events","type":"Organization","site_admin":false},"repo":{"id":9066347,"name":"cleanflight","full_name":"cleanflight/cleanflight","owner":{"login":"cleanflight","id":8776523,"avatar_url":"https://avatars.githubusercontent.com/u/8776523?v=3","gravatar_id":"","url":"https://api.github.com/users/cleanflight","html_url":"https://github.com/cleanflight","followers_url":"https://api.github.com/users/cleanflight/followers","following_url":"https://api.github.com/users/cleanflight/following{/other_user}","gists_url":"https://api.github.com/users/cleanflight/gists{/gist_id}","starred_url":"https://api.github.com/users/cleanflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleanflight/subscriptions","organizations_url":"https://api.github.com/users/cleanflight/orgs","repos_url":"https://api.github.com/users/cleanflight/repos","events_url":"https://api.github.com/users/cleanflight/events{/privacy}","received_events_url":"https://api.github.com/users/cleanflight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cleanflight/cleanflight","description":"Clean-code version of the baseflight flight controller firmware","fork":false,"url":"https://api.github.com/repos/cleanflight/cleanflight","forks_url":"https://api.github.com/repos/cleanflight/cleanflight/forks","keys_url":"https://api.github.com/repos/cleanflight/cleanflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cleanflight/cleanflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cleanflight/cleanflight/teams","hooks_url":"https://api.github.com/repos/cleanflight/cleanflight/hooks","issue_events_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/events{/number}","events_url":"https://api.github.com/repos/cleanflight/cleanflight/events","assignees_url":"https://api.github.com/repos/cleanflight/cleanflight/assignees{/user}","branches_url":"https://api.github.com/repos/cleanflight/cleanflight/branches{/branch}","tags_url":"https://api.github.com/repos/cleanflight/cleanflight/tags","blobs_url":"https://api.github.com/repos/cleanflight/cleanflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cleanflight/cleanflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cleanflight/cleanflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/cleanflight/cleanflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cleanflight/cleanflight/statuses/{sha}","languages_url":"https://api.github.com/repos/cleanflight/cleanflight/languages","stargazers_url":"https://api.github.com/repos/cleanflight/cleanflight/stargazers","contributors_url":"https://api.github.com/repos/cleanflight/cleanflight/contributors","subscribers_url":"https://api.github.com/repos/cleanflight/cleanflight/subscribers","subscription_url":"https://api.github.com/repos/cleanflight/cleanflight/subscription","commits_url":"https://api.github.com/repos/cleanflight/cleanflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/cleanflight/cleanflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/cleanflight/cleanflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/cleanflight/cleanflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/cleanflight/cleanflight/contents/{+path}","compare_url":"https://api.github.com/repos/cleanflight/cleanflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cleanflight/cleanflight/merges","archive_url":"https://api.github.com/repos/cleanflight/cleanflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cleanflight/cleanflight/downloads","issues_url":"https://api.github.com/repos/cleanflight/cleanflight/issues{/number}","pulls_url":"https://api.github.com/repos/cleanflight/cleanflight/pulls{/number}","milestones_url":"https://api.github.com/repos/cleanflight/cleanflight/milestones{/number}","notifications_url":"https://api.github.com/repos/cleanflight/cleanflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cleanflight/cleanflight/labels{/name}","releases_url":"https://api.github.com/repos/cleanflight/cleanflight/releases{/id}","deployments_url":"https://api.github.com/repos/cleanflight/cleanflight/deployments","created_at":"2013-03-27T23:49:19Z","updated_at":"2016-09-13T07:12:05Z","pushed_at":"2016-09-14T16:24:41Z","git_url":"git://github.com/cleanflight/cleanflight.git","ssh_url":"git@github.com:cleanflight/cleanflight.git","clone_url":"https://github.com/cleanflight/cleanflight.git","svn_url":"https://github.com/cleanflight/cleanflight","homepage":"http://cleanflight.com","size":106341,"stargazers_count":1242,"watchers_count":1242,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1262,"mirror_url":null,"open_issues_count":531,"forks":1262,"open_issues":531,"watchers":1242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323"},"html":{"href":"https://github.com/cleanflight/cleanflight/pull/2323"},"issue":{"href":"https://api.github.com/repos/cleanflight/cleanflight/issues/2323"},"comments":{"href":"https://api.github.com/repos/cleanflight/cleanflight/issues/2323/comments"},"review_comments":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323/comments"},"review_comment":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cleanflight/cleanflight/pulls/2323/commits"},"statuses":{"href":"https://api.github.com/repos/cleanflight/cleanflight/statuses/de5a32e00060d72fd5c828d5103469693073e79e"}}}}
{"actor":{"display_login":"hydra"}}