{"action":"created","issue":{"url":"https://api.github.com/repos/metricstory/scalable-rate-limiter/issues/2","repository_url":"https://api.github.com/repos/metricstory/scalable-rate-limiter","labels_url":"https://api.github.com/repos/metricstory/scalable-rate-limiter/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/metricstory/scalable-rate-limiter/issues/2/comments","events_url":"https://api.github.com/repos/metricstory/scalable-rate-limiter/issues/2/events","html_url":"https://github.com/metricstory/scalable-rate-limiter/pull/2","id":197905448,"number":2,"title":"Add daily limit","user":{"login":"WillySchu","id":13688228,"avatar_url":"https://avatars.githubusercontent.com/u/13688228?v=3","gravatar_id":"","url":"https://api.github.com/users/WillySchu","html_url":"https://github.com/WillySchu","followers_url":"https://api.github.com/users/WillySchu/followers","following_url":"https://api.github.com/users/WillySchu/following{/other_user}","gists_url":"https://api.github.com/users/WillySchu/gists{/gist_id}","starred_url":"https://api.github.com/users/WillySchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillySchu/subscriptions","organizations_url":"https://api.github.com/users/WillySchu/orgs","repos_url":"https://api.github.com/users/WillySchu/repos","events_url":"https://api.github.com/users/WillySchu/events{/privacy}","received_events_url":"https://api.github.com/users/WillySchu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-28T19:39:37Z","updated_at":"2016-12-29T19:39:43Z","closed_at":"2016-12-29T19:36:09Z","pull_request":{"url":"https://api.github.com/repos/metricstory/scalable-rate-limiter/pulls/2","html_url":"https://github.com/metricstory/scalable-rate-limiter/pull/2","diff_url":"https://github.com/metricstory/scalable-rate-limiter/pull/2.diff","patch_url":"https://github.com/metricstory/scalable-rate-limiter/pull/2.patch"},"body":"Also a few bugs with the checks, it was checking if it was over the intervalThreshold and not allowedReqsPerInterval\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/metricstory/scalable-rate-limiter/2)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/metricstory/scalable-rate-limiter/issues/comments/269682030","html_url":"https://github.com/metricstory/scalable-rate-limiter/pull/2#issuecomment-269682030","issue_url":"https://api.github.com/repos/metricstory/scalable-rate-limiter/issues/2","id":269682030,"user":{"login":"nutterbrand","id":95765,"avatar_url":"https://avatars.githubusercontent.com/u/95765?v=3","gravatar_id":"","url":"https://api.github.com/users/nutterbrand","html_url":"https://github.com/nutterbrand","followers_url":"https://api.github.com/users/nutterbrand/followers","following_url":"https://api.github.com/users/nutterbrand/following{/other_user}","gists_url":"https://api.github.com/users/nutterbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/nutterbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nutterbrand/subscriptions","organizations_url":"https://api.github.com/users/nutterbrand/orgs","repos_url":"https://api.github.com/users/nutterbrand/repos","events_url":"https://api.github.com/users/nutterbrand/events{/privacy}","received_events_url":"https://api.github.com/users/nutterbrand/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T19:39:43Z","updated_at":"2016-12-29T19:39:43Z","body":"\n\n\n\n\n\n\n\n*[rl.lua, line 15 at r1](https://reviewable.io:443/reviews/metricstory/scalable-rate-limiter/2#-K_6qXiT_r-ZnkgyIntZ:-K_B4s9J_5098X7jJA1F:buosv5w) ([raw file](https://github.com/metricstory/scalable-rate-limiter/blob/8954f506444f1ef352ca39cbe7ef5b46badedaa1/rl.lua#L15)):*\n<details><summary><i>Previously, WillySchu (Will Schumacher) wrote…</i></summary><blockquote>\n\nAs the dailyCount uses the date itself as a key it is unnecessary to expire it at all. When the date rolls over a new counter will automatically be created with the new date as part of its key. The TTL is there just to make sure that the counts are deleted eventually, but we can keep them around for a while for record keeping. As of right now, the daily counts are kept around for 'roughly a month'.\n</blockquote></details>\n\nAh, that makes sense so after midnight PST we will have a new key. You then expire that key in roughly a month. -- makes sense :100: \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/metricstory/scalable-rate-limiter/2)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"nutterbrand"}}