{"action":"created","issue":{"url":"https://api.github.com/repos/nolanlawson/optimize-js/issues/28","repository_url":"https://api.github.com/repos/nolanlawson/optimize-js","labels_url":"https://api.github.com/repos/nolanlawson/optimize-js/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/nolanlawson/optimize-js/issues/28/comments","events_url":"https://api.github.com/repos/nolanlawson/optimize-js/issues/28/events","html_url":"https://github.com/nolanlawson/optimize-js/pull/28","id":184973398,"number":28,"title":"Fix for #7: Not as optimized for Webpack as it could be. ","user":{"login":"aickin","id":44199,"avatar_url":"https://avatars.githubusercontent.com/u/44199?v=3","gravatar_id":"","url":"https://api.github.com/users/aickin","html_url":"https://github.com/aickin","followers_url":"https://api.github.com/users/aickin/followers","following_url":"https://api.github.com/users/aickin/following{/other_user}","gists_url":"https://api.github.com/users/aickin/gists{/gist_id}","starred_url":"https://api.github.com/users/aickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aickin/subscriptions","organizations_url":"https://api.github.com/users/aickin/orgs","repos_url":"https://api.github.com/users/aickin/repos","events_url":"https://api.github.com/users/aickin/events{/privacy}","received_events_url":"https://api.github.com/users/aickin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-24T22:39:22Z","updated_at":"2016-10-29T17:44:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nolanlawson/optimize-js/pulls/28","html_url":"https://github.com/nolanlawson/optimize-js/pull/28","diff_url":"https://github.com/nolanlawson/optimize-js/pull/28.diff","patch_url":"https://github.com/nolanlawson/optimize-js/pull/28.patch"},"body":"Adds ability to wrap functions that are elements of an array literal in an argument list.\r\n\r\nI refactored some of the if-else logic into named functions that were easier for me to understand, but I'm not sure if they will be easier for others or not. Feedback welcome.\r\n\r\n`npm run test` runs green and `npm run coverage` gives 100%.\r\n\r\nRunning on the benchmark repo from The Cost of Small Modules on my MBP (and snipping out non-webpack versions for space), I get:\r\n\r\nChrome  54.0.2840.71\r\n```\r\n100 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,2.51,1.55,4.06\r\nwebpack-optimized,2.88,0.26,3.14\r\n1000 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,7.33,16.92,24.25\r\nwebpack-optimized,9.4,1.65,11.05\r\n5000 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,35.44,47.64,83.09\r\nwebpack-optimized,44.72,6.25,50.97\r\n```\r\n\r\nFirefox 48.0.2\r\n```\r\n100 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,2.07,0.93,3\r\nwebpack-optimized,2.29,0.45,2.74\r\n1000 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,5.28,6.18,11.45\r\nwebpack-optimized,8.5,1.63,10.13\r\n5000 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,22.03,29.4,51.43\r\nwebpack-optimized,36.4,7.36,43.76\r\n```\r\n\r\nSafari 9.1.3\r\n```\r\n100 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,2.19,0.39,2.58\r\nwebpack-optimized,2.16,0.38,2.54\r\n1000 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,3.34,1.52,4.86\r\nwebpack-optimized,2.69,1.69,4.38\r\n5000 modules,,,\r\nBundler,Load time (ms),Run time (ms),Total time (ms)\r\nwebpack,6.97,9.71,16.67\r\nwebpack-optimized,6.19,8.26,14.45\r\n```\r\n\r\nThanks for all your work!"},"comment":{"url":"https://api.github.com/repos/nolanlawson/optimize-js/issues/comments/257105296","html_url":"https://github.com/nolanlawson/optimize-js/pull/28#issuecomment-257105296","issue_url":"https://api.github.com/repos/nolanlawson/optimize-js/issues/28","id":257105296,"user":{"login":"aickin","id":44199,"avatar_url":"https://avatars.githubusercontent.com/u/44199?v=3","gravatar_id":"","url":"https://api.github.com/users/aickin","html_url":"https://github.com/aickin","followers_url":"https://api.github.com/users/aickin/followers","following_url":"https://api.github.com/users/aickin/following{/other_user}","gists_url":"https://api.github.com/users/aickin/gists{/gist_id}","starred_url":"https://api.github.com/users/aickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aickin/subscriptions","organizations_url":"https://api.github.com/users/aickin/orgs","repos_url":"https://api.github.com/users/aickin/repos","events_url":"https://api.github.com/users/aickin/events{/privacy}","received_events_url":"https://api.github.com/users/aickin/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T17:44:05Z","updated_at":"2016-10-29T17:44:05Z","body":"I added four negative test cases for array literals. I feel like I didn't have a ton of creativity in making these test cases, though, so let me know if there are some more ones you'd like!"}}
{"actor":{"display_login":"aickin"}}