{"action":"created","issue":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/252","repository_url":"https://api.github.com/repos/alexcrichton/futures-rs","labels_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/252/comments","events_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/252/events","html_url":"https://github.com/alexcrichton/futures-rs/pull/252","id":190469142,"number":252,"title":"Implement `s.split()` for `Stream + Sink`","user":{"login":"tailhook","id":321799,"avatar_url":"https://avatars.githubusercontent.com/u/321799?v=3","gravatar_id":"","url":"https://api.github.com/users/tailhook","html_url":"https://github.com/tailhook","followers_url":"https://api.github.com/users/tailhook/followers","following_url":"https://api.github.com/users/tailhook/following{/other_user}","gists_url":"https://api.github.com/users/tailhook/gists{/gist_id}","starred_url":"https://api.github.com/users/tailhook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tailhook/subscriptions","organizations_url":"https://api.github.com/users/tailhook/orgs","repos_url":"https://api.github.com/users/tailhook/repos","events_url":"https://api.github.com/users/tailhook/events{/privacy}","received_events_url":"https://api.github.com/users/tailhook/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-19T02:04:20Z","updated_at":"2016-11-19T21:29:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/pulls/252","html_url":"https://github.com/alexcrichton/futures-rs/pull/252","diff_url":"https://github.com/alexcrichton/futures-rs/pull/252.diff","patch_url":"https://github.com/alexcrichton/futures-rs/pull/252.patch"},"body":"Basically, this replaces `tokio_core::io::Framed::split`, it's unclear why framed needs specific implementation instead of generic one like this.\r\n\r\nAlso, I think we should remove `Stream` and `Sink` for `BiLock<T>` in favor of this idea. I don't think using Stream on both instances of the same BiLock is generally useful."},"comment":{"url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/comments/261740853","html_url":"https://github.com/alexcrichton/futures-rs/pull/252#issuecomment-261740853","issue_url":"https://api.github.com/repos/alexcrichton/futures-rs/issues/252","id":261740853,"user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"created_at":"2016-11-19T21:29:03Z","updated_at":"2016-11-19T21:29:03Z","body":"Yeah let's go a head and remove the impls directly on `BiLock` itself, this makes more sense to me 👍 "}}
{"actor":{"display_login":"alexcrichton"}}