{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75059658","id":75059658,"diff_hunk":"@@ -82,17 +82,123 @@ func TestCompatibility_v1_Scheduler(t *testing.T) {\n \t\t  \"kind\": \"Policy\",","path":"plugin/pkg/scheduler/algorithmprovider/defaults/compatibility_test.go","position":1,"original_position":1,"commit_id":"0a466696a795fa7129cd2428413f0e38d3ef8725","original_commit_id":"0a466696a795fa7129cd2428413f0e38d3ef8725","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"update the dire comment above the 1.1, 1.2, and 1.3 test data to match the 1.0 comment :)","created_at":"2016-08-17T04:01:50Z","updated_at":"2016-08-17T04:01:50Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30733#discussion_r75059658","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75059658"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30733#discussion_r75059658"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733","id":81579312,"html_url":"https://github.com/kubernetes/kubernetes/pull/30733","diff_url":"https://github.com/kubernetes/kubernetes/pull/30733.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30733.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30733","number":30733,"state":"open","locked":false,"title":"Update scheduler config file compatibility tests","user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nAdded missing compatibility tests for scheduler config file options.\r\n\r\n**Which issue this PR fixes** \r\nfixes #30099\r\n\r\n**Special notes for your reviewer**:\r\nI came up with the options based on the contents of default.go in each branch.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30733)\n<!-- Reviewable:end -->\n","created_at":"2016-08-17T03:30:31Z","updated_at":"2016-08-17T04:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06a3325892ef1952c7736bdfc22aa164134e2986","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30733/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a466696a795fa7129cd2428413f0e38d3ef8725","head":{"label":"asalkeld:compat-test","ref":"compat-test","sha":"0a466696a795fa7129cd2428413f0e38d3ef8725","user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"repo":{"id":58418755,"name":"kubernetes","full_name":"asalkeld/kubernetes","owner":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asalkeld/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/asalkeld/kubernetes","forks_url":"https://api.github.com/repos/asalkeld/kubernetes/forks","keys_url":"https://api.github.com/repos/asalkeld/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asalkeld/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asalkeld/kubernetes/teams","hooks_url":"https://api.github.com/repos/asalkeld/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/asalkeld/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/asalkeld/kubernetes/events","assignees_url":"https://api.github.com/repos/asalkeld/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/asalkeld/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/asalkeld/kubernetes/tags","blobs_url":"https://api.github.com/repos/asalkeld/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asalkeld/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asalkeld/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/asalkeld/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asalkeld/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/asalkeld/kubernetes/languages","stargazers_url":"https://api.github.com/repos/asalkeld/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/asalkeld/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/asalkeld/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/asalkeld/kubernetes/subscription","commits_url":"https://api.github.com/repos/asalkeld/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/asalkeld/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/asalkeld/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/asalkeld/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/asalkeld/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/asalkeld/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asalkeld/kubernetes/merges","archive_url":"https://api.github.com/repos/asalkeld/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asalkeld/kubernetes/downloads","issues_url":"https://api.github.com/repos/asalkeld/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/asalkeld/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/asalkeld/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/asalkeld/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asalkeld/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/asalkeld/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/asalkeld/kubernetes/deployments","created_at":"2016-05-10T01:04:58Z","updated_at":"2016-05-10T01:05:12Z","pushed_at":"2016-08-17T03:26:49Z","git_url":"git://github.com/asalkeld/kubernetes.git","ssh_url":"git@github.com:asalkeld/kubernetes.git","clone_url":"https://github.com/asalkeld/kubernetes.git","svn_url":"https://github.com/asalkeld/kubernetes","homepage":"http://kubernetes.io","size":307330,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"fc7a7f5f7d5a952cb2879f9edb27cff2289fe1e3","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-17T03:36:21Z","pushed_at":"2016-08-17T03:56:31Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":526058,"stargazers_count":16163,"watchers_count":16163,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5155,"mirror_url":null,"open_issues_count":4212,"forks":5155,"open_issues":4212,"watchers":16163,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30733"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30733"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30733/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30733/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a466696a795fa7129cd2428413f0e38d3ef8725"}}}}
{"actor":{"display_login":"liggitt"}}