{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/85343569","pull_request_review_id":6065064,"id":85343569,"diff_hunk":"@@ -147,7 +147,10 @@ private[spark] abstract class WebUI(\n   }\n \n   /** Return the url of web interface. Only valid after bind(). */\n-  def webUrl: String = s\"http://$publicHostName:$boundPort\"\n+  def webUrl: String = {","path":"core/src/main/scala/org/apache/spark/ui/WebUI.scala","position":null,"original_position":5,"commit_id":"396460926390c10b2348de26333a76029413955c","original_commit_id":"356982620c1cef3a6396e25448a079af03ec35d9","user":{"login":"hayashidac","id":5276569,"avatar_url":"https://avatars.githubusercontent.com/u/5276569?v=3","gravatar_id":"","url":"https://api.github.com/users/hayashidac","html_url":"https://github.com/hayashidac","followers_url":"https://api.github.com/users/hayashidac/followers","following_url":"https://api.github.com/users/hayashidac/following{/other_user}","gists_url":"https://api.github.com/users/hayashidac/gists{/gist_id}","starred_url":"https://api.github.com/users/hayashidac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayashidac/subscriptions","organizations_url":"https://api.github.com/users/hayashidac/orgs","repos_url":"https://api.github.com/users/hayashidac/repos","events_url":"https://api.github.com/users/hayashidac/events{/privacy}","received_events_url":"https://api.github.com/users/hayashidac/received_events","type":"User","site_admin":false},"body":"Sorry, I rebased this change.","created_at":"2016-10-27T14:05:58Z","updated_at":"2016-10-27T14:05:58Z","html_url":"https://github.com/apache/spark/pull/15652#discussion_r85343569","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15652","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/85343569"},"html":{"href":"https://github.com/apache/spark/pull/15652#discussion_r85343569"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15652"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15652","id":91113392,"html_url":"https://github.com/apache/spark/pull/15652","diff_url":"https://github.com/apache/spark/pull/15652.diff","patch_url":"https://github.com/apache/spark/pull/15652.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15652","number":15652,"state":"open","locked":false,"title":"[SPARK-16987] [None] Add spark-default.conf property to define https port for spark history server","user":{"login":"hayashidac","id":5276569,"avatar_url":"https://avatars.githubusercontent.com/u/5276569?v=3","gravatar_id":"","url":"https://api.github.com/users/hayashidac","html_url":"https://github.com/hayashidac","followers_url":"https://api.github.com/users/hayashidac/followers","following_url":"https://api.github.com/users/hayashidac/following{/other_user}","gists_url":"https://api.github.com/users/hayashidac/gists{/gist_id}","starred_url":"https://api.github.com/users/hayashidac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayashidac/subscriptions","organizations_url":"https://api.github.com/users/hayashidac/orgs","repos_url":"https://api.github.com/users/hayashidac/repos","events_url":"https://api.github.com/users/hayashidac/events{/privacy}","received_events_url":"https://api.github.com/users/hayashidac/received_events","type":"User","site_admin":false},"body":"I created a pull request, but there is a problem.\r\nPort should be separated for each particular process such as history server and spark ui.\r\nBut user can configure spark.ssl.port with this code and when configure it, each process will try to create connections with same port and it doesn't work good.\r\nBecause of structure of existing function, it has impact to other functions to solve the problem.\r\nSo there are three answer about it.\r\n1. Use this fix code so user can configure a specific secure port, but spark.ssl.port doesn't work good.\r\n2. Don't change and close issue.\r\n3. We should be able to configure a specific secure port completely, so drastically change many functions.\r\nPlease comments. ","created_at":"2016-10-27T00:23:10Z","updated_at":"2016-10-27T14:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c689cb33c2b5e4d6d45c3c576dcd025dc0ada9d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15652/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15652/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15652/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/396460926390c10b2348de26333a76029413955c","head":{"label":"hayashidac:SPARK-16987","ref":"SPARK-16987","sha":"396460926390c10b2348de26333a76029413955c","user":{"login":"hayashidac","id":5276569,"avatar_url":"https://avatars.githubusercontent.com/u/5276569?v=3","gravatar_id":"","url":"https://api.github.com/users/hayashidac","html_url":"https://github.com/hayashidac","followers_url":"https://api.github.com/users/hayashidac/followers","following_url":"https://api.github.com/users/hayashidac/following{/other_user}","gists_url":"https://api.github.com/users/hayashidac/gists{/gist_id}","starred_url":"https://api.github.com/users/hayashidac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayashidac/subscriptions","organizations_url":"https://api.github.com/users/hayashidac/orgs","repos_url":"https://api.github.com/users/hayashidac/repos","events_url":"https://api.github.com/users/hayashidac/events{/privacy}","received_events_url":"https://api.github.com/users/hayashidac/received_events","type":"User","site_admin":false},"repo":{"id":71790638,"name":"spark","full_name":"hayashidac/spark","owner":{"login":"hayashidac","id":5276569,"avatar_url":"https://avatars.githubusercontent.com/u/5276569?v=3","gravatar_id":"","url":"https://api.github.com/users/hayashidac","html_url":"https://github.com/hayashidac","followers_url":"https://api.github.com/users/hayashidac/followers","following_url":"https://api.github.com/users/hayashidac/following{/other_user}","gists_url":"https://api.github.com/users/hayashidac/gists{/gist_id}","starred_url":"https://api.github.com/users/hayashidac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayashidac/subscriptions","organizations_url":"https://api.github.com/users/hayashidac/orgs","repos_url":"https://api.github.com/users/hayashidac/repos","events_url":"https://api.github.com/users/hayashidac/events{/privacy}","received_events_url":"https://api.github.com/users/hayashidac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hayashidac/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/hayashidac/spark","forks_url":"https://api.github.com/repos/hayashidac/spark/forks","keys_url":"https://api.github.com/repos/hayashidac/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hayashidac/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hayashidac/spark/teams","hooks_url":"https://api.github.com/repos/hayashidac/spark/hooks","issue_events_url":"https://api.github.com/repos/hayashidac/spark/issues/events{/number}","events_url":"https://api.github.com/repos/hayashidac/spark/events","assignees_url":"https://api.github.com/repos/hayashidac/spark/assignees{/user}","branches_url":"https://api.github.com/repos/hayashidac/spark/branches{/branch}","tags_url":"https://api.github.com/repos/hayashidac/spark/tags","blobs_url":"https://api.github.com/repos/hayashidac/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hayashidac/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hayashidac/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/hayashidac/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hayashidac/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/hayashidac/spark/languages","stargazers_url":"https://api.github.com/repos/hayashidac/spark/stargazers","contributors_url":"https://api.github.com/repos/hayashidac/spark/contributors","subscribers_url":"https://api.github.com/repos/hayashidac/spark/subscribers","subscription_url":"https://api.github.com/repos/hayashidac/spark/subscription","commits_url":"https://api.github.com/repos/hayashidac/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/hayashidac/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/hayashidac/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/hayashidac/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/hayashidac/spark/contents/{+path}","compare_url":"https://api.github.com/repos/hayashidac/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hayashidac/spark/merges","archive_url":"https://api.github.com/repos/hayashidac/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hayashidac/spark/downloads","issues_url":"https://api.github.com/repos/hayashidac/spark/issues{/number}","pulls_url":"https://api.github.com/repos/hayashidac/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/hayashidac/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/hayashidac/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hayashidac/spark/labels{/name}","releases_url":"https://api.github.com/repos/hayashidac/spark/releases{/id}","deployments_url":"https://api.github.com/repos/hayashidac/spark/deployments","created_at":"2016-10-24T13:14:44Z","updated_at":"2016-10-24T13:15:09Z","pushed_at":"2016-10-27T14:04:13Z","git_url":"git://github.com/hayashidac/spark.git","ssh_url":"git@github.com:hayashidac/spark.git","clone_url":"https://github.com/hayashidac/spark.git","svn_url":"https://github.com/hayashidac/spark","homepage":null,"size":248316,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"701a9d361b3045a25c42b3c0e44e7755d45ff78c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-10-27T11:38:21Z","pushed_at":"2016-10-27T14:04:15Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":604343,"stargazers_count":10522,"watchers_count":10522,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9794,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":476,"forks":9794,"open_issues":476,"watchers":10522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15652"},"html":{"href":"https://github.com/apache/spark/pull/15652"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15652"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15652/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15652/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15652/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/396460926390c10b2348de26333a76029413955c"}}}}
{"actor":{"display_login":"hayashidac"}}