{"action":"closed","number":32814,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/32814","id":65731218,"html_url":"https://github.com/rust-lang/rust/pull/32814","diff_url":"https://github.com/rust-lang/rust/pull/32814.diff","patch_url":"https://github.com/rust-lang/rust/pull/32814.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/32814","number":32814,"state":"closed","locked":false,"title":"resolve: Improve duplicate glob detection","user":{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false},"body":"This fixes a bug introduced in #31726 in which we erroneously allow multiple imports of the same item under some circumstances.\r\n\r\nMore specifically, we erroneously allow a module that is in a cycle of glob re-exports to have other re-exports (besides the glob from the cycle).\r\nFor example,\r\n```rust\r\npub fn f() {}\r\nmod foo {\r\n    pub use f; // (1) This defines `foo::f`.\r\n    pub use bar::*; // (3) This also defines `foo::f`, which should be a duplicate error but is currently allowed.\r\n}\r\nmod bar {\r\n    pub use foo::*; // (2) This defines `bar::f`.\r\n}\r\n```\r\n\r\nA module in a glob re-export cycle can still have `pub` items after this PR. For example,\r\n```rust\r\nmod foo {\r\n    pub fn f() {}; // (1) This defines `foo::f`.\r\n    pub use bar::*; // (3) This is not a duplicate error since items shadow glob-imported re-exports (cf #31337).\r\n}\r\nmod bar {\r\n    pub use foo::*; // (2) This defines `bar::f`.\r\n}\r\n```\r\nr? @nikomatsakis ","created_at":"2016-04-08T03:11:07Z","updated_at":"2016-04-13T08:20:21Z","closed_at":"2016-04-13T08:20:21Z","merged_at":"2016-04-13T08:20:21Z","merge_commit_sha":"bc6daea2db6d5b5686e857b93c1f71a94268dddb","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/32814/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/32814/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/32814/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/bc6daea2db6d5b5686e857b93c1f71a94268dddb","head":{"label":"jseyfried:improve_duplicate_glob_detection","ref":"improve_duplicate_glob_detection","sha":"bc6daea2db6d5b5686e857b93c1f71a94268dddb","user":{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false},"repo":{"id":45209988,"name":"rust","full_name":"jseyfried/rust","owner":{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jseyfried/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/jseyfried/rust","forks_url":"https://api.github.com/repos/jseyfried/rust/forks","keys_url":"https://api.github.com/repos/jseyfried/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jseyfried/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jseyfried/rust/teams","hooks_url":"https://api.github.com/repos/jseyfried/rust/hooks","issue_events_url":"https://api.github.com/repos/jseyfried/rust/issues/events{/number}","events_url":"https://api.github.com/repos/jseyfried/rust/events","assignees_url":"https://api.github.com/repos/jseyfried/rust/assignees{/user}","branches_url":"https://api.github.com/repos/jseyfried/rust/branches{/branch}","tags_url":"https://api.github.com/repos/jseyfried/rust/tags","blobs_url":"https://api.github.com/repos/jseyfried/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jseyfried/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jseyfried/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/jseyfried/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jseyfried/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/jseyfried/rust/languages","stargazers_url":"https://api.github.com/repos/jseyfried/rust/stargazers","contributors_url":"https://api.github.com/repos/jseyfried/rust/contributors","subscribers_url":"https://api.github.com/repos/jseyfried/rust/subscribers","subscription_url":"https://api.github.com/repos/jseyfried/rust/subscription","commits_url":"https://api.github.com/repos/jseyfried/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/jseyfried/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/jseyfried/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/jseyfried/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/jseyfried/rust/contents/{+path}","compare_url":"https://api.github.com/repos/jseyfried/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jseyfried/rust/merges","archive_url":"https://api.github.com/repos/jseyfried/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jseyfried/rust/downloads","issues_url":"https://api.github.com/repos/jseyfried/rust/issues{/number}","pulls_url":"https://api.github.com/repos/jseyfried/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/jseyfried/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/jseyfried/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jseyfried/rust/labels{/name}","releases_url":"https://api.github.com/repos/jseyfried/rust/releases{/id}","deployments_url":"https://api.github.com/repos/jseyfried/rust/deployments","created_at":"2015-10-29T20:55:18Z","updated_at":"2016-03-27T03:28:50Z","pushed_at":"2016-04-13T06:30:25Z","git_url":"git://github.com/jseyfried/rust.git","ssh_url":"git@github.com:jseyfried/rust.git","clone_url":"https://github.com/jseyfried/rust.git","svn_url":"https://github.com/jseyfried/rust","homepage":"http://www.rust-lang.org","size":291708,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"b622c3e0856767d8e53cf141e2e0a7b6d72a198b","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-04-13T08:13:59Z","pushed_at":"2016-04-13T08:20:15Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":488901,"stargazers_count":16212,"watchers_count":16212,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3092,"mirror_url":null,"open_issues_count":2421,"forks":3092,"open_issues":2421,"watchers":16212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32814"},"html":{"href":"https://github.com/rust-lang/rust/pull/32814"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32814"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/32814/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32814/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/32814/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/bc6daea2db6d5b5686e857b93c1f71a94268dddb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":8,"review_comments":4,"commits":4,"additions":70,"deletions":14,"changed_files":3}}