{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/comments/72713124","id":72713124,"diff_hunk":"@@ -81,7 +82,9 @@\n         BooleanParameterDefinition.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // \"booleanParam\"\n         StringParameterDefinition.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // \"string\"\n         BuildDiscarderProperty.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // \"buildDiscarder\"\n-        LogRotator.LRDescriptor.class.isAnnotationPresent(Symbol.class); // \"logRotator\"\n+        LogRotator.LRDescriptor.class.isAnnotationPresent(Symbol.class) && // \"logRotator\"\n+        TimerTrigger.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // \"disableConcurrentBuilds\"\n+        PipelineTriggersJobProperty.DescriptorImpl.class.isAnnotationPresent(Symbol.class); // \"pipelineTriggers\"","path":"src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java","position":54,"original_position":15,"commit_id":"0342adea5b506b529d4a9e7c3071015e6a4e679a","original_commit_id":"0342adea5b506b529d4a9e7c3071015e6a4e679a","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":":bug: this last clause is unconditionally true, since we declare that dependency. This constant is about symbols present in _core_.","created_at":"2016-07-28T22:15:06Z","updated_at":"2016-07-28T22:15:06Z","html_url":"https://github.com/jenkinsci/workflow-multibranch-plugin/pull/20#discussion_r72713124","pull_request_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/comments/72713124"},"html":{"href":"https://github.com/jenkinsci/workflow-multibranch-plugin/pull/20#discussion_r72713124"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20","id":77479880,"html_url":"https://github.com/jenkinsci/workflow-multibranch-plugin/pull/20","diff_url":"https://github.com/jenkinsci/workflow-multibranch-plugin/pull/20.diff","patch_url":"https://github.com/jenkinsci/workflow-multibranch-plugin/pull/20.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/issues/20","number":20,"state":"open","locked":false,"title":"JENKINS-34005 - update tests for PipelineTriggersJobProperty","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"body":"[JENKINS-34005](https://issues.jenkins-ci.org/browse/JENKINS-34005)\r\n\r\nDepends on https://github.com/jenkinsci/workflow-job-plugin/pull/9\r\n\r\n* Updates existing tests to deal with the fact that there should always be a `PipelineTriggersJobProperty` on a `WorkflowJob`, even if it has no triggers in it.\r\n* Added a new test specifically for `PipelineTriggersJobProperty`.\r\n\r\ncc @reviewbybees esp @jglick ","created_at":"2016-07-14T15:51:23Z","updated_at":"2016-07-28T22:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8da4b77c9aa319e649474ae50d61aeacd32042f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/issues/20/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/statuses/0342adea5b506b529d4a9e7c3071015e6a4e679a","head":{"label":"abayer:jenkins-34005","ref":"jenkins-34005","sha":"0342adea5b506b529d4a9e7c3071015e6a4e679a","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"repo":{"id":60202036,"name":"workflow-multibranch-plugin","full_name":"abayer/workflow-multibranch-plugin","owner":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abayer/workflow-multibranch-plugin","description":"","fork":true,"url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin","forks_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/forks","keys_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/teams","hooks_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/hooks","issue_events_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/events","assignees_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/tags","blobs_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/languages","stargazers_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/stargazers","contributors_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/contributors","subscribers_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/subscribers","subscription_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/subscription","commits_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/merges","archive_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/downloads","issues_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/labels{/name}","releases_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/abayer/workflow-multibranch-plugin/deployments","created_at":"2016-06-01T18:41:49Z","updated_at":"2016-06-01T18:41:50Z","pushed_at":"2016-07-28T21:00:16Z","git_url":"git://github.com/abayer/workflow-multibranch-plugin.git","ssh_url":"git@github.com:abayer/workflow-multibranch-plugin.git","clone_url":"https://github.com/abayer/workflow-multibranch-plugin.git","svn_url":"https://github.com/abayer/workflow-multibranch-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Multibranch+Plugin","size":328,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"2c9681a7e299bb4352092eb7840361c6f5c3d3bb","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543467,"name":"workflow-multibranch-plugin","full_name":"jenkinsci/workflow-multibranch-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/workflow-multibranch-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/deployments","created_at":"2016-04-05T20:28:20Z","updated_at":"2016-07-21T16:16:24Z","pushed_at":"2016-07-28T21:00:17Z","git_url":"git://github.com/jenkinsci/workflow-multibranch-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-multibranch-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-multibranch-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-multibranch-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Multibranch+Plugin","size":342,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20"},"html":{"href":"https://github.com/jenkinsci/workflow-multibranch-plugin/pull/20"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/issues/20"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-multibranch-plugin/statuses/0342adea5b506b529d4a9e7c3071015e6a4e679a"}}}}
{"actor":{"display_login":"jglick"}}