{"action":"created","issue":{"url":"https://api.github.com/repos/approvals/ApprovalTests.Net/issues/145","repository_url":"https://api.github.com/repos/approvals/ApprovalTests.Net","labels_url":"https://api.github.com/repos/approvals/ApprovalTests.Net/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/approvals/ApprovalTests.Net/issues/145/comments","events_url":"https://api.github.com/repos/approvals/ApprovalTests.Net/issues/145/events","html_url":"https://github.com/approvals/ApprovalTests.Net/issues/145","id":138819044,"number":145,"title":"Better Reporter Names","user":{"login":"isidore","id":10874,"avatar_url":"https://avatars.githubusercontent.com/u/10874?v=3","gravatar_id":"","url":"https://api.github.com/users/isidore","html_url":"https://github.com/isidore","followers_url":"https://api.github.com/users/isidore/followers","following_url":"https://api.github.com/users/isidore/following{/other_user}","gists_url":"https://api.github.com/users/isidore/gists{/gist_id}","starred_url":"https://api.github.com/users/isidore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidore/subscriptions","organizations_url":"https://api.github.com/users/isidore/orgs","repos_url":"https://api.github.com/users/isidore/repos","events_url":"https://api.github.com/users/isidore/events{/privacy}","received_events_url":"https://api.github.com/users/isidore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-06T18:16:53Z","updated_at":"2016-03-06T18:37:03Z","closed_at":null,"body":"It was brought to my attention that the Reporters aren't very discoverable. Suggest renaming to start all with the word Report\r\n\r\nThis is large, so wanted feedback before I do.\r\n\r\nNote: I will maintain backwards compatibility for all existing names.\r\n\r\nSuggestions\r\n\r\n\r\n AllFailingTestsClipboardReporter ->  ReportAllFailingTestsToClipboard  \r\n AppConfigReporter -> ReportWithReporterInAppConfig\r\n AppVeyorReporter -> ReportSilentlyWhenOnAppVeyor\r\n AraxisMergeReporter -> ReportWithAraxisMerge\r\n AssertReporter ------> no change (base class)?\r\n BambooReporter -> ReportSilentlyWhenOnBamboo\r\n BeyondCompare3Reporter -> ReportWithBeyondCompare3\r\n BeyondCompare4Reporter.cs -> ReportWithBeyondCompare4\r\n BeyondCompareReporter.cs -> ReportWithBeyondCompare\r\n ClipboardReporter.cs -> ReportToClipboard\r\n CodeCompareReporter.cs -> ReportWithCodeCompare\r\n CruiseControlNetReporter.cs -> ReportSilentlyWhenOnCruiseControlNet\r\n DefaultFrontLoaderReporter.cs --------------> no change ?\r\n DiffReporter.cs -> ReportWithDiffTool\r\n FileLauncherReporter -> ReportByLaunchingFile\r\n FileLauncherWithDelayReporter -> ReportByLaunchingFileWithSmallDelay\r\n FirstWorkingReporter.cs ------------------> no change?\r\n FrameworkAssertReporter.cs -> ReportWithAssertEquals\r\n GenericDiffReporter -----------------> no change (base class)\r\n GoContinuousDeliveryReporter -> ReportSilentlyOnGoContinuousDelivery\r\n ImageReporter -> ReportWithImageTools\r\n IntroductionReporter ---------------> no change (not meant to be used on purpose)\r\n JenkinsReporter -> ReportSilentlyOnJenkins\r\n KDiffReporter.cs -> ReportWithKDiff\r\n MightyMooseAutoTestReporter.cs -> ReportSilentlyWhenUsingMightMoose\r\n MsTestReporter.cs -> ReportWithMsTestAssertEquals\r\n MultiReporter.cs -----------> no change ?\r\n MyGetReporter.cs -> ReportSilentlyOnMyGet\r\n NCrunchReporter.cs -> ReportSilentlyWhenUsingNCrunch\r\n NUnitReporter.cs -> ReportWithNUnitAssertEquals\r\n NotepadLauncher -> ReportWithNotepad\r\n P4MergeImageReporter -> ReportWithP4MergeForImages\r\n P4MergeReporter.cs ->  ReportWithP4Merge\r\n P4MergeTextReporter.cs -> ReportWithP4MergeForText\r\n PowershellClipboardReporter.cs -> ReportToPowershellClipboard\r\n QuietReporter.cs -> ReportSilently\r\n TeamCityReporter.cs -> ReportSilentlyWhenUsingTeamCity\r\n TfsReporter -> ReportSilentlyWhenUsingTfs\r\n TfsVnextReporter.cs -> ReportSilentlyWhenUsingTfsVnext\r\n TortoiseComboImageReporter.cs -> ReportWithTortoiseDiffForImagesOrFileLauncher\r\n TortoiseDiffReporter.cs -> ReportWithTortoiseDiff\r\n TortoiseImageDiffReporter.cs -> ReportWithTortoiseDiffForImages\r\n TortoiseTextDiffReporter.cs -> ReportWithTortoiseDiffForText\r\n VisualStudioReporter.cs -> ReportWithVisualStudio\r\n WinMergeReporter.cs -> ReportWithWinMerge\r\n XUnit2Reporter.cs -> ReportWithXUnit2AssertEquals\r\n XUnitReporter.cs -> ReportWithXUnitAssertEquals\r\n\r\n\r\nWhat do you think?\r\n"},"comment":{"url":"https://api.github.com/repos/approvals/ApprovalTests.Net/issues/comments/192957672","html_url":"https://github.com/approvals/ApprovalTests.Net/issues/145#issuecomment-192957672","issue_url":"https://api.github.com/repos/approvals/ApprovalTests.Net/issues/145","id":192957672,"user":{"login":"JayBazuzi","id":1259628,"avatar_url":"https://avatars.githubusercontent.com/u/1259628?v=3","gravatar_id":"","url":"https://api.github.com/users/JayBazuzi","html_url":"https://github.com/JayBazuzi","followers_url":"https://api.github.com/users/JayBazuzi/followers","following_url":"https://api.github.com/users/JayBazuzi/following{/other_user}","gists_url":"https://api.github.com/users/JayBazuzi/gists{/gist_id}","starred_url":"https://api.github.com/users/JayBazuzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayBazuzi/subscriptions","organizations_url":"https://api.github.com/users/JayBazuzi/orgs","repos_url":"https://api.github.com/users/JayBazuzi/repos","events_url":"https://api.github.com/users/JayBazuzi/events{/privacy}","received_events_url":"https://api.github.com/users/JayBazuzi/received_events","type":"User","site_admin":false},"created_at":"2016-03-06T18:37:03Z","updated_at":"2016-03-06T18:37:03Z","body":"I like it.\r\n\r\nToday, I type `Reporter` and let Intellisense find it, but what you are proposing would be even better.\r\n\r\nTake a step further and make these the attributes, so I can do:\r\n\r\n`[ReportWithKDiff]`\r\n\r\nThis will make intellisense work better, because `typeof(...)` can take anything, but `[...` will only offer Attributes."}}