{"action":"closed","number":145,"pull_request":{"url":"https://api.github.com/repos/RackHD/on-http/pulls/145","id":60440349,"html_url":"https://github.com/RackHD/on-http/pull/145","diff_url":"https://github.com/RackHD/on-http/pull/145.diff","patch_url":"https://github.com/RackHD/on-http/pull/145.patch","issue_url":"https://api.github.com/repos/RackHD/on-http/issues/145","number":145,"state":"closed","locked":false,"title":"Workflow related API fixes","user":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"body":"More smoke test fixes:\r\n\r\n- Missed one occurrence of replacing the deprecated way to check for an active graph for a node.\r\n- Making some changes to the workflow library routes. These routes *already* do not work (https://github.com/RackHD/RackHD/issues/89), but tests have passed with false positives so far because the `/workflows/library` route gets redirected to the `/workflows/<id>` route. Previously, this route improperly returned a 200 no matter what. Because it was changed to return a 404 on failure to find a workflow, a bunch of the false positive tests are now failing as they should be.\r\n\r\nI think this may be controversial in regards to the `/workflows/library/*` addition/change, but I'm kind of at a loss for what to do. I don't want to continue with the current broken behavior just to keep incorrect tests passing.\r\n\r\nResolves https://github.com/RackHD/RackHD/issues/89\r\n\r\n@RackHD/corecommitters @jlongever @heckj @VulpesArtificem","created_at":"2016-02-24T01:15:01Z","updated_at":"2016-02-24T23:03:57Z","closed_at":"2016-02-24T23:03:56Z","merged_at":"2016-02-24T23:03:56Z","merge_commit_sha":"781cb3e8c2758ad23c264980a7ccd4ac35da9ce7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-http/pulls/145/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-http/pulls/145/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-http/issues/145/comments","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/b94ad4ceb2320d1c29ffdae5f66121bb62c07056","head":{"label":"benbp:replace-get-active-graph","ref":"replace-get-active-graph","sha":"b94ad4ceb2320d1c29ffdae5f66121bb62c07056","user":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"repo":{"id":47728727,"name":"on-http","full_name":"benbp/on-http","owner":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benbp/on-http","description":"","fork":true,"url":"https://api.github.com/repos/benbp/on-http","forks_url":"https://api.github.com/repos/benbp/on-http/forks","keys_url":"https://api.github.com/repos/benbp/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benbp/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benbp/on-http/teams","hooks_url":"https://api.github.com/repos/benbp/on-http/hooks","issue_events_url":"https://api.github.com/repos/benbp/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/benbp/on-http/events","assignees_url":"https://api.github.com/repos/benbp/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/benbp/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/benbp/on-http/tags","blobs_url":"https://api.github.com/repos/benbp/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benbp/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benbp/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/benbp/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benbp/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/benbp/on-http/languages","stargazers_url":"https://api.github.com/repos/benbp/on-http/stargazers","contributors_url":"https://api.github.com/repos/benbp/on-http/contributors","subscribers_url":"https://api.github.com/repos/benbp/on-http/subscribers","subscription_url":"https://api.github.com/repos/benbp/on-http/subscription","commits_url":"https://api.github.com/repos/benbp/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/benbp/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/benbp/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/benbp/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/benbp/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/benbp/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benbp/on-http/merges","archive_url":"https://api.github.com/repos/benbp/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benbp/on-http/downloads","issues_url":"https://api.github.com/repos/benbp/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/benbp/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/benbp/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/benbp/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benbp/on-http/labels{/name}","releases_url":"https://api.github.com/repos/benbp/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/benbp/on-http/deployments","created_at":"2015-12-10T00:56:30Z","updated_at":"2015-12-10T00:56:32Z","pushed_at":"2016-02-24T22:26:24Z","git_url":"git://github.com/benbp/on-http.git","ssh_url":"git@github.com:benbp/on-http.git","clone_url":"https://github.com/benbp/on-http.git","svn_url":"https://github.com/benbp/on-http","homepage":null,"size":1940,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"550000ee891c12fd9a3841028aca68de72ab5414","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690081,"name":"on-http","full_name":"RackHD/on-http","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-http","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-http","forks_url":"https://api.github.com/repos/RackHD/on-http/forks","keys_url":"https://api.github.com/repos/RackHD/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-http/teams","hooks_url":"https://api.github.com/repos/RackHD/on-http/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-http/events","assignees_url":"https://api.github.com/repos/RackHD/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-http/tags","blobs_url":"https://api.github.com/repos/RackHD/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-http/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-http/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-http/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-http/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-http/subscription","commits_url":"https://api.github.com/repos/RackHD/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-http/merges","archive_url":"https://api.github.com/repos/RackHD/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-http/downloads","issues_url":"https://api.github.com/repos/RackHD/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-http/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-http/deployments","created_at":"2015-08-31T17:29:08Z","updated_at":"2016-01-31T09:01:04Z","pushed_at":"2016-02-24T23:03:57Z","git_url":"git://github.com/RackHD/on-http.git","ssh_url":"git@github.com:RackHD/on-http.git","clone_url":"https://github.com/RackHD/on-http.git","svn_url":"https://github.com/RackHD/on-http","homepage":null,"size":2258,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":9,"forks":33,"open_issues":9,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/145"},"html":{"href":"https://github.com/RackHD/on-http/pull/145"},"issue":{"href":"https://api.github.com/repos/RackHD/on-http/issues/145"},"comments":{"href":"https://api.github.com/repos/RackHD/on-http/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-http/statuses/b94ad4ceb2320d1c29ffdae5f66121bb62c07056"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"comments":10,"review_comments":3,"commits":5,"additions":83,"deletions":86,"changed_files":10}}