{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/51914677","id":51914677,"diff_hunk":"@@ -11,6 +11,24 @@ namespace System.Net.NetworkInformation.Tests\n {\n     public class PingTest\n     {\n+        private class FinalizingPing : Ping\n+        {\n+            public static volatile bool WasFinalized;\n+\n+            public static void CreateAndRelease()\n+            {\n+                new FinalizingPing();\n+            }\n+\n+            protected override void Dispose(bool disposing)\n+            {\n+                if (!disposing)","path":"src/System.Net.Ping/tests/FunctionalTests/PingTest.cs","position":15,"original_position":15,"commit_id":"3506d137acbcad79a3a449204364796f2c93feca","original_commit_id":"3506d137acbcad79a3a449204364796f2c93feca","user":{"login":"CIPop","id":8635911,"avatar_url":"https://avatars.githubusercontent.com/u/8635911?v=3","gravatar_id":"","url":"https://api.github.com/users/CIPop","html_url":"https://github.com/CIPop","followers_url":"https://api.github.com/users/CIPop/followers","following_url":"https://api.github.com/users/CIPop/following{/other_user}","gists_url":"https://api.github.com/users/CIPop/gists{/gist_id}","starred_url":"https://api.github.com/users/CIPop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CIPop/subscriptions","organizations_url":"https://api.github.com/users/CIPop/orgs","repos_url":"https://api.github.com/users/CIPop/repos","events_url":"https://api.github.com/users/CIPop/events{/privacy}","received_events_url":"https://api.github.com/users/CIPop/received_events","type":"User","site_admin":false},"body":"Please add braces around all if statement blocks.","created_at":"2016-02-04T18:25:01Z","updated_at":"2016-02-04T18:25:01Z","html_url":"https://github.com/dotnet/corefx/pull/5887#discussion_r51914677","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/5887","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/51914677"},"html":{"href":"https://github.com/dotnet/corefx/pull/5887#discussion_r51914677"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5887"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/5887","id":58231856,"html_url":"https://github.com/dotnet/corefx/pull/5887","diff_url":"https://github.com/dotnet/corefx/pull/5887.diff","patch_url":"https://github.com/dotnet/corefx/pull/5887.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/5887","number":5887,"state":"open","locked":false,"title":"Add finalizers to Process and Ping","user":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"body":"Have them call `Dispose(false)`.\r\n\r\n`SuppressFinalize(this)` in constructors if they are not a derived type to lessen the possible negative impact on collection.\r\n\r\nRemove unnecessary `SuppressFinalize(this)` from `ProcessModule`.\r\n\r\nFixes #5886","created_at":"2016-02-04T02:07:09Z","updated_at":"2016-02-04T18:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fc9a0a345b88019ad8232729f96c10f1dae8057","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/5887/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/5887/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/5887/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/3506d137acbcad79a3a449204364796f2c93feca","head":{"label":"JonHanna:fix_5886","ref":"fix_5886","sha":"3506d137acbcad79a3a449204364796f2c93feca","user":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"repo":{"id":38018243,"name":"corefx","full_name":"JonHanna/corefx","owner":{"login":"JonHanna","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/JonHanna","html_url":"https://github.com/JonHanna","followers_url":"https://api.github.com/users/JonHanna/followers","following_url":"https://api.github.com/users/JonHanna/following{/other_user}","gists_url":"https://api.github.com/users/JonHanna/gists{/gist_id}","starred_url":"https://api.github.com/users/JonHanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonHanna/subscriptions","organizations_url":"https://api.github.com/users/JonHanna/orgs","repos_url":"https://api.github.com/users/JonHanna/repos","events_url":"https://api.github.com/users/JonHanna/events{/privacy}","received_events_url":"https://api.github.com/users/JonHanna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JonHanna/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/JonHanna/corefx","forks_url":"https://api.github.com/repos/JonHanna/corefx/forks","keys_url":"https://api.github.com/repos/JonHanna/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonHanna/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonHanna/corefx/teams","hooks_url":"https://api.github.com/repos/JonHanna/corefx/hooks","issue_events_url":"https://api.github.com/repos/JonHanna/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/JonHanna/corefx/events","assignees_url":"https://api.github.com/repos/JonHanna/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/JonHanna/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/JonHanna/corefx/tags","blobs_url":"https://api.github.com/repos/JonHanna/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonHanna/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonHanna/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonHanna/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonHanna/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/JonHanna/corefx/languages","stargazers_url":"https://api.github.com/repos/JonHanna/corefx/stargazers","contributors_url":"https://api.github.com/repos/JonHanna/corefx/contributors","subscribers_url":"https://api.github.com/repos/JonHanna/corefx/subscribers","subscription_url":"https://api.github.com/repos/JonHanna/corefx/subscription","commits_url":"https://api.github.com/repos/JonHanna/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonHanna/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonHanna/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonHanna/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonHanna/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/JonHanna/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonHanna/corefx/merges","archive_url":"https://api.github.com/repos/JonHanna/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonHanna/corefx/downloads","issues_url":"https://api.github.com/repos/JonHanna/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/JonHanna/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/JonHanna/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/JonHanna/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonHanna/corefx/labels{/name}","releases_url":"https://api.github.com/repos/JonHanna/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/JonHanna/corefx/deployments","created_at":"2015-06-25T00:19:13Z","updated_at":"2016-01-12T23:30:27Z","pushed_at":"2016-02-04T16:36:18Z","git_url":"git://github.com/JonHanna/corefx.git","ssh_url":"git@github.com:JonHanna/corefx.git","clone_url":"https://github.com/JonHanna/corefx.git","svn_url":"https://github.com/JonHanna/corefx","homepage":"http://dotnet.github.io/core/","size":51856,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0c14fc469a5cc3309f5f8d6f4281c4a80c36c083","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-02-04T17:38:58Z","pushed_at":"2016-02-04T18:23:48Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":61706,"stargazers_count":9078,"watchers_count":9078,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2104,"mirror_url":null,"open_issues_count":818,"forks":2104,"open_issues":818,"watchers":9078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5887"},"html":{"href":"https://github.com/dotnet/corefx/pull/5887"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5887"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/5887/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5887/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/5887/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/3506d137acbcad79a3a449204364796f2c93feca"}}}}