{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/61960245","id":61960245,"diff_hunk":"@@ -753,6 +757,9 @@ public String getPassword() {\n     }\n \n     public void setPassword(String password) {\n+        if (encryptionService != null) {\n+            encryptionService.decryptValue(password);","path":"catalog/opensearch/catalog-opensearch-source/src/main/java/ddf/catalog/source/opensearch/OpenSearchSource.java","position":33,"original_position":33,"commit_id":"49d68ce03d3919c73ebba46657a661ff3ab96327","original_commit_id":"49d68ce03d3919c73ebba46657a661ff3ab96327","user":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"body":"I see that now. I fix it in every spot where I decrypt the password.","created_at":"2016-05-03T21:34:25Z","updated_at":"2016-05-03T21:34:25Z","html_url":"https://github.com/codice/ddf/pull/754#discussion_r61960245","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/754","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/61960245"},"html":{"href":"https://github.com/codice/ddf/pull/754#discussion_r61960245"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/754"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/754","id":68778002,"html_url":"https://github.com/codice/ddf/pull/754","diff_url":"https://github.com/codice/ddf/pull/754.diff","patch_url":"https://github.com/codice/ddf/pull/754.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/754","number":754,"state":"open","locked":false,"title":"DDF-2094 Add support for decrypting encrypted passwords in sources","user":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThe following sources now support decrypting encrypted passwords:\r\ncatalog-opensearch-source\r\nspatial-csw-source\r\nspatial-wfs-v2_0_0-source\r\nspatial-wfs-v1_0_0-source\r\ncatalog-registry-api-impl\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@ryeats @coyotesqrl @tbatie @jckilmer @bcwaters \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@shaundmorris\r\n@stustison\r\n#### How should this be tested?\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\nDDF-2094\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [X] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n","created_at":"2016-05-03T21:27:08Z","updated_at":"2016-05-03T21:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dd216d9dc5d6d6df7a4ee1b788d2c518698473f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/754/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/754/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/754/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/49d68ce03d3919c73ebba46657a661ff3ab96327","head":{"label":"roelens8:DDF-2094","ref":"DDF-2094","sha":"49d68ce03d3919c73ebba46657a661ff3ab96327","user":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"repo":{"id":37481426,"name":"ddf","full_name":"roelens8/ddf","owner":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roelens8/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/roelens8/ddf","forks_url":"https://api.github.com/repos/roelens8/ddf/forks","keys_url":"https://api.github.com/repos/roelens8/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roelens8/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roelens8/ddf/teams","hooks_url":"https://api.github.com/repos/roelens8/ddf/hooks","issue_events_url":"https://api.github.com/repos/roelens8/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/roelens8/ddf/events","assignees_url":"https://api.github.com/repos/roelens8/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/roelens8/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/roelens8/ddf/tags","blobs_url":"https://api.github.com/repos/roelens8/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roelens8/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roelens8/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/roelens8/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roelens8/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/roelens8/ddf/languages","stargazers_url":"https://api.github.com/repos/roelens8/ddf/stargazers","contributors_url":"https://api.github.com/repos/roelens8/ddf/contributors","subscribers_url":"https://api.github.com/repos/roelens8/ddf/subscribers","subscription_url":"https://api.github.com/repos/roelens8/ddf/subscription","commits_url":"https://api.github.com/repos/roelens8/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/roelens8/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/roelens8/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/roelens8/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/roelens8/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/roelens8/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roelens8/ddf/merges","archive_url":"https://api.github.com/repos/roelens8/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roelens8/ddf/downloads","issues_url":"https://api.github.com/repos/roelens8/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/roelens8/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/roelens8/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/roelens8/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roelens8/ddf/labels{/name}","releases_url":"https://api.github.com/repos/roelens8/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/roelens8/ddf/deployments","created_at":"2015-06-15T17:55:32Z","updated_at":"2015-06-15T17:55:33Z","pushed_at":"2016-05-03T20:49:09Z","git_url":"git://github.com/roelens8/ddf.git","ssh_url":"git@github.com:roelens8/ddf.git","clone_url":"https://github.com/roelens8/ddf.git","svn_url":"https://github.com/roelens8/ddf","homepage":"","size":142595,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"54090224bc6c95748f052cb62b5c5906453bbdd7","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-04-25T16:28:29Z","pushed_at":"2016-05-03T21:31:33Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":163473,"stargazers_count":36,"watchers_count":36,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":16,"forks":75,"open_issues":16,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/754"},"html":{"href":"https://github.com/codice/ddf/pull/754"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/754"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/49d68ce03d3919c73ebba46657a661ff3ab96327"}}}}