{"action":"opened","number":619,"pull_request":{"url":"https://api.github.com/repos/codinguser/gnucash-android/pulls/619","id":95281867,"html_url":"https://github.com/codinguser/gnucash-android/pull/619","diff_url":"https://github.com/codinguser/gnucash-android/pull/619.diff","patch_url":"https://github.com/codinguser/gnucash-android/pull/619.patch","issue_url":"https://api.github.com/repos/codinguser/gnucash-android/issues/619","number":619,"state":"open","locked":false,"title":"Bugfix 617: Weekly scheduled exports are listed with the wrong day","user":{"login":"rivaldi8","id":1187977,"avatar_url":"https://avatars.githubusercontent.com/u/1187977?v=3","gravatar_id":"","url":"https://api.github.com/users/rivaldi8","html_url":"https://github.com/rivaldi8","followers_url":"https://api.github.com/users/rivaldi8/followers","following_url":"https://api.github.com/users/rivaldi8/following{/other_user}","gists_url":"https://api.github.com/users/rivaldi8/gists{/gist_id}","starred_url":"https://api.github.com/users/rivaldi8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivaldi8/subscriptions","organizations_url":"https://api.github.com/users/rivaldi8/orgs","repos_url":"https://api.github.com/users/rivaldi8/repos","events_url":"https://api.github.com/users/rivaldi8/events{/privacy}","received_events_url":"https://api.github.com/users/rivaldi8/received_events","type":"User","site_admin":false},"body":"Fixes #617 \r\n\r\nThere some are important changes, so I thought you might want to review it.\r\n\r\nInstead of storing the days of the week as a string (\"MO;TH\") in `mByDay`, which is painful to work with, I've changed it to store as a List of Calendar constants (`Calendar.MONDAY`) instead. If later we want to support specific days in the month, we can just change the list type to some other class to hold the new information.\r\n\r\nAs this was meant for hotfix/patches, I haven't changed the database structure but, in my opinion, we should think of storing `recurrence_byday` in a separate table. Apart from not conforming with the first normal form, the parsing of the column (`RecurrenceDbAdapter.{byDaysToString,stringToByDays}` ) makes it awkward to work with.","created_at":"2016-11-25T10:30:51Z","updated_at":"2016-11-25T10:30:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/codinguser/gnucash-android/pulls/619/commits","review_comments_url":"https://api.github.com/repos/codinguser/gnucash-android/pulls/619/comments","review_comment_url":"https://api.github.com/repos/codinguser/gnucash-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codinguser/gnucash-android/issues/619/comments","statuses_url":"https://api.github.com/repos/codinguser/gnucash-android/statuses/5911aa6dba047b29cef535bc401002da2512171b","head":{"label":"rivaldi8:bugfix-617-weekly-exports-listed-wrong-day","ref":"bugfix-617-weekly-exports-listed-wrong-day","sha":"5911aa6dba047b29cef535bc401002da2512171b","user":{"login":"rivaldi8","id":1187977,"avatar_url":"https://avatars.githubusercontent.com/u/1187977?v=3","gravatar_id":"","url":"https://api.github.com/users/rivaldi8","html_url":"https://github.com/rivaldi8","followers_url":"https://api.github.com/users/rivaldi8/followers","following_url":"https://api.github.com/users/rivaldi8/following{/other_user}","gists_url":"https://api.github.com/users/rivaldi8/gists{/gist_id}","starred_url":"https://api.github.com/users/rivaldi8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivaldi8/subscriptions","organizations_url":"https://api.github.com/users/rivaldi8/orgs","repos_url":"https://api.github.com/users/rivaldi8/repos","events_url":"https://api.github.com/users/rivaldi8/events{/privacy}","received_events_url":"https://api.github.com/users/rivaldi8/received_events","type":"User","site_admin":false},"repo":{"id":26976580,"name":"gnucash-android","full_name":"rivaldi8/gnucash-android","owner":{"login":"rivaldi8","id":1187977,"avatar_url":"https://avatars.githubusercontent.com/u/1187977?v=3","gravatar_id":"","url":"https://api.github.com/users/rivaldi8","html_url":"https://github.com/rivaldi8","followers_url":"https://api.github.com/users/rivaldi8/followers","following_url":"https://api.github.com/users/rivaldi8/following{/other_user}","gists_url":"https://api.github.com/users/rivaldi8/gists{/gist_id}","starred_url":"https://api.github.com/users/rivaldi8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivaldi8/subscriptions","organizations_url":"https://api.github.com/users/rivaldi8/orgs","repos_url":"https://api.github.com/users/rivaldi8/repos","events_url":"https://api.github.com/users/rivaldi8/events{/privacy}","received_events_url":"https://api.github.com/users/rivaldi8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rivaldi8/gnucash-android","description":"Gnucash for Android mobile companion application. ","fork":true,"url":"https://api.github.com/repos/rivaldi8/gnucash-android","forks_url":"https://api.github.com/repos/rivaldi8/gnucash-android/forks","keys_url":"https://api.github.com/repos/rivaldi8/gnucash-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rivaldi8/gnucash-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rivaldi8/gnucash-android/teams","hooks_url":"https://api.github.com/repos/rivaldi8/gnucash-android/hooks","issue_events_url":"https://api.github.com/repos/rivaldi8/gnucash-android/issues/events{/number}","events_url":"https://api.github.com/repos/rivaldi8/gnucash-android/events","assignees_url":"https://api.github.com/repos/rivaldi8/gnucash-android/assignees{/user}","branches_url":"https://api.github.com/repos/rivaldi8/gnucash-android/branches{/branch}","tags_url":"https://api.github.com/repos/rivaldi8/gnucash-android/tags","blobs_url":"https://api.github.com/repos/rivaldi8/gnucash-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rivaldi8/gnucash-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rivaldi8/gnucash-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/rivaldi8/gnucash-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rivaldi8/gnucash-android/statuses/{sha}","languages_url":"https://api.github.com/repos/rivaldi8/gnucash-android/languages","stargazers_url":"https://api.github.com/repos/rivaldi8/gnucash-android/stargazers","contributors_url":"https://api.github.com/repos/rivaldi8/gnucash-android/contributors","subscribers_url":"https://api.github.com/repos/rivaldi8/gnucash-android/subscribers","subscription_url":"https://api.github.com/repos/rivaldi8/gnucash-android/subscription","commits_url":"https://api.github.com/repos/rivaldi8/gnucash-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/rivaldi8/gnucash-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/rivaldi8/gnucash-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/rivaldi8/gnucash-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/rivaldi8/gnucash-android/contents/{+path}","compare_url":"https://api.github.com/repos/rivaldi8/gnucash-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rivaldi8/gnucash-android/merges","archive_url":"https://api.github.com/repos/rivaldi8/gnucash-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rivaldi8/gnucash-android/downloads","issues_url":"https://api.github.com/repos/rivaldi8/gnucash-android/issues{/number}","pulls_url":"https://api.github.com/repos/rivaldi8/gnucash-android/pulls{/number}","milestones_url":"https://api.github.com/repos/rivaldi8/gnucash-android/milestones{/number}","notifications_url":"https://api.github.com/repos/rivaldi8/gnucash-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rivaldi8/gnucash-android/labels{/name}","releases_url":"https://api.github.com/repos/rivaldi8/gnucash-android/releases{/id}","deployments_url":"https://api.github.com/repos/rivaldi8/gnucash-android/deployments","created_at":"2014-11-21T20:25:05Z","updated_at":"2014-11-21T20:25:06Z","pushed_at":"2016-11-25T10:03:26Z","git_url":"git://github.com/rivaldi8/gnucash-android.git","ssh_url":"git@github.com:rivaldi8/gnucash-android.git","clone_url":"https://github.com/rivaldi8/gnucash-android.git","svn_url":"https://github.com/rivaldi8/gnucash-android","homepage":"","size":19018,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codinguser:hotfix/patches","ref":"hotfix/patches","sha":"d95b5ae310217b6c2c723c4f22fb1eaa2cb16026","user":{"login":"codinguser","id":276699,"avatar_url":"https://avatars.githubusercontent.com/u/276699?v=3","gravatar_id":"","url":"https://api.github.com/users/codinguser","html_url":"https://github.com/codinguser","followers_url":"https://api.github.com/users/codinguser/followers","following_url":"https://api.github.com/users/codinguser/following{/other_user}","gists_url":"https://api.github.com/users/codinguser/gists{/gist_id}","starred_url":"https://api.github.com/users/codinguser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codinguser/subscriptions","organizations_url":"https://api.github.com/users/codinguser/orgs","repos_url":"https://api.github.com/users/codinguser/repos","events_url":"https://api.github.com/users/codinguser/events{/privacy}","received_events_url":"https://api.github.com/users/codinguser/received_events","type":"User","site_admin":false},"repo":{"id":4387088,"name":"gnucash-android","full_name":"codinguser/gnucash-android","owner":{"login":"codinguser","id":276699,"avatar_url":"https://avatars.githubusercontent.com/u/276699?v=3","gravatar_id":"","url":"https://api.github.com/users/codinguser","html_url":"https://github.com/codinguser","followers_url":"https://api.github.com/users/codinguser/followers","following_url":"https://api.github.com/users/codinguser/following{/other_user}","gists_url":"https://api.github.com/users/codinguser/gists{/gist_id}","starred_url":"https://api.github.com/users/codinguser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codinguser/subscriptions","organizations_url":"https://api.github.com/users/codinguser/orgs","repos_url":"https://api.github.com/users/codinguser/repos","events_url":"https://api.github.com/users/codinguser/events{/privacy}","received_events_url":"https://api.github.com/users/codinguser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codinguser/gnucash-android","description":"Gnucash for Android mobile companion application. ","fork":false,"url":"https://api.github.com/repos/codinguser/gnucash-android","forks_url":"https://api.github.com/repos/codinguser/gnucash-android/forks","keys_url":"https://api.github.com/repos/codinguser/gnucash-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codinguser/gnucash-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codinguser/gnucash-android/teams","hooks_url":"https://api.github.com/repos/codinguser/gnucash-android/hooks","issue_events_url":"https://api.github.com/repos/codinguser/gnucash-android/issues/events{/number}","events_url":"https://api.github.com/repos/codinguser/gnucash-android/events","assignees_url":"https://api.github.com/repos/codinguser/gnucash-android/assignees{/user}","branches_url":"https://api.github.com/repos/codinguser/gnucash-android/branches{/branch}","tags_url":"https://api.github.com/repos/codinguser/gnucash-android/tags","blobs_url":"https://api.github.com/repos/codinguser/gnucash-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codinguser/gnucash-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codinguser/gnucash-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/codinguser/gnucash-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codinguser/gnucash-android/statuses/{sha}","languages_url":"https://api.github.com/repos/codinguser/gnucash-android/languages","stargazers_url":"https://api.github.com/repos/codinguser/gnucash-android/stargazers","contributors_url":"https://api.github.com/repos/codinguser/gnucash-android/contributors","subscribers_url":"https://api.github.com/repos/codinguser/gnucash-android/subscribers","subscription_url":"https://api.github.com/repos/codinguser/gnucash-android/subscription","commits_url":"https://api.github.com/repos/codinguser/gnucash-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/codinguser/gnucash-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/codinguser/gnucash-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/codinguser/gnucash-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/codinguser/gnucash-android/contents/{+path}","compare_url":"https://api.github.com/repos/codinguser/gnucash-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codinguser/gnucash-android/merges","archive_url":"https://api.github.com/repos/codinguser/gnucash-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codinguser/gnucash-android/downloads","issues_url":"https://api.github.com/repos/codinguser/gnucash-android/issues{/number}","pulls_url":"https://api.github.com/repos/codinguser/gnucash-android/pulls{/number}","milestones_url":"https://api.github.com/repos/codinguser/gnucash-android/milestones{/number}","notifications_url":"https://api.github.com/repos/codinguser/gnucash-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codinguser/gnucash-android/labels{/name}","releases_url":"https://api.github.com/repos/codinguser/gnucash-android/releases{/id}","deployments_url":"https://api.github.com/repos/codinguser/gnucash-android/deployments","created_at":"2012-05-20T19:58:40Z","updated_at":"2016-11-18T02:08:19Z","pushed_at":"2016-11-23T17:12:58Z","git_url":"git://github.com/codinguser/gnucash-android.git","ssh_url":"git@github.com:codinguser/gnucash-android.git","clone_url":"https://github.com/codinguser/gnucash-android.git","svn_url":"https://github.com/codinguser/gnucash-android","homepage":"","size":22057,"stargazers_count":546,"watchers_count":546,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":307,"mirror_url":null,"open_issues_count":63,"forks":307,"open_issues":63,"watchers":546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codinguser/gnucash-android/pulls/619"},"html":{"href":"https://github.com/codinguser/gnucash-android/pull/619"},"issue":{"href":"https://api.github.com/repos/codinguser/gnucash-android/issues/619"},"comments":{"href":"https://api.github.com/repos/codinguser/gnucash-android/issues/619/comments"},"review_comments":{"href":"https://api.github.com/repos/codinguser/gnucash-android/pulls/619/comments"},"review_comment":{"href":"https://api.github.com/repos/codinguser/gnucash-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codinguser/gnucash-android/pulls/619/commits"},"statuses":{"href":"https://api.github.com/repos/codinguser/gnucash-android/statuses/5911aa6dba047b29cef535bc401002da2512171b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":158,"deletions":101,"changed_files":3}}
{"actor":{"display_login":"rivaldi8"}}