{"action":"created","comment":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments/78488968","id":78488968,"diff_hunk":"@@ -1,10 +1,14 @@\n {\n     \"pets\": \"Pets\",\n+    \"activePet\": \"Active Pet\",\n+    \"noActivePet\": \"No Active Pet\",","path":"common/locales/en/pets.json","position":4,"original_position":4,"commit_id":"72a6d73a9be23fd72ba98fbe74b2f14fbc840bfb","original_commit_id":"72a6d73a9be23fd72ba98fbe74b2f14fbc840bfb","user":{"login":"crookedneighbor","id":2916945,"avatar_url":"https://avatars.githubusercontent.com/u/2916945?v=3","gravatar_id":"","url":"https://api.github.com/users/crookedneighbor","html_url":"https://github.com/crookedneighbor","followers_url":"https://api.github.com/users/crookedneighbor/followers","following_url":"https://api.github.com/users/crookedneighbor/following{/other_user}","gists_url":"https://api.github.com/users/crookedneighbor/gists{/gist_id}","starred_url":"https://api.github.com/users/crookedneighbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crookedneighbor/subscriptions","organizations_url":"https://api.github.com/users/crookedneighbor/orgs","repos_url":"https://api.github.com/users/crookedneighbor/repos","events_url":"https://api.github.com/users/crookedneighbor/events{/privacy}","received_events_url":"https://api.github.com/users/crookedneighbor/received_events","type":"User","site_admin":false},"body":"I thought about that, but it is actually very difficult to do. Say you have strings like:\r\n\r\n```json\r\n\"wizardInfo\": \"stuff about Mages\",\r\n\"warriorInfo\": \"stuff about Warriors\",\r\n\"healerInfo\": \"stuff about Healers\",\r\n\"rogueInfo\": \"stuff about Rogues\",\r\n```\r\n\r\nThen you might do something like:\r\n\r\n```js\r\nreturn window.env.t(user.stats.class + 'Info');\r\n```\r\n\r\nHow do you write the check to pass for that?\r\n\r\nYou could monkey patch the translation function to keep track of the strings that get passed into it and then run your test suite, and if you have full coverage, all your strings would get used... but that seems like more trouble than it is worth and would require coordination among the different tests suites which would be a big pain. \r\n\r\nYou could have the translation function audit itself in production and see which strings never get used, which could also be an interesting way to see which code paths and features aren't being used. But again, that's a pretty large undertaking.\r\n\r\nAnyway, you get the idea.","created_at":"2016-09-13T02:46:39Z","updated_at":"2016-09-13T02:46:39Z","html_url":"https://github.com/HabitRPG/habitrpg/pull/7768#discussion_r78488968","pull_request_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768","_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments/78488968"},"html":{"href":"https://github.com/HabitRPG/habitrpg/pull/7768#discussion_r78488968"},"pull_request":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768"}}},"pull_request":{"url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768","id":76839033,"html_url":"https://github.com/HabitRPG/habitrpg/pull/7768","diff_url":"https://github.com/HabitRPG/habitrpg/pull/7768.diff","patch_url":"https://github.com/HabitRPG/habitrpg/pull/7768.patch","issue_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/7768","number":7768,"state":"open","locked":false,"title":"Add Costume Info to member modal","user":{"login":"MathWhiz","id":12386291,"avatar_url":"https://avatars.githubusercontent.com/u/12386291?v=3","gravatar_id":"","url":"https://api.github.com/users/MathWhiz","html_url":"https://github.com/MathWhiz","followers_url":"https://api.github.com/users/MathWhiz/followers","following_url":"https://api.github.com/users/MathWhiz/following{/other_user}","gists_url":"https://api.github.com/users/MathWhiz/gists{/gist_id}","starred_url":"https://api.github.com/users/MathWhiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathWhiz/subscriptions","organizations_url":"https://api.github.com/users/MathWhiz/orgs","repos_url":"https://api.github.com/users/MathWhiz/repos","events_url":"https://api.github.com/users/MathWhiz/events{/privacy}","received_events_url":"https://api.github.com/users/MathWhiz/received_events","type":"User","site_admin":false},"body":"[//]: # (Note: See http://habitica.wikia.com/wiki/Using_Habitica_Git#Pull_Request for more info)\r\n\r\n[//]: # (Put Issue # or URL here, if applicable. This will automatically close the issue if your PR is merged in)\r\nFixes #5358 \r\n\r\n### Changes\r\n[//]: # (Describe the changes that were made in detail here. Include pictures if necessary)\r\n\r\nSimilar to #5422, this adds costume information to the profile modal\r\n\r\n### Pictures\r\n![screenshot 2016-08-20 at 2 12 54 pm](https://cloud.githubusercontent.com/assets/12386291/17833385/3848034c-66e1-11e6-8e09-cb188fe50514.png)\r\n![screenshot 2016-08-20 at 2 13 10 pm](https://cloud.githubusercontent.com/assets/12386291/17833384/3844ff80-66e1-11e6-89ed-cdaf85fa47a8.png)\r\n![screenshot 2016-08-20 at 2 13 22 pm](https://cloud.githubusercontent.com/assets/12386291/17833387/3850d6e8-66e1-11e6-834c-63b3f4338cff.png)\r\n![screenshot 2016-08-20 at 2 13 33 pm](https://cloud.githubusercontent.com/assets/12386291/17833388/3855eba6-66e1-11e6-9767-069b8d868d2c.png)\r\n\r\n\r\n[//]: # (Put User ID in here - found in Settings -> API)\r\n----\r\nUUID: 95f16006-1504-4a9f-95b6-0c7314dbd7ee\r\n","created_at":"2016-07-09T06:16:58Z","updated_at":"2016-09-13T02:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ef7af13559286fb9ffbc26641c717583d5bdd48","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768/commits","review_comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768/comments","review_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/7768/comments","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/72a6d73a9be23fd72ba98fbe74b2f14fbc840bfb","head":{"label":"MathWhiz:costume_member_modal","ref":"costume_member_modal","sha":"72a6d73a9be23fd72ba98fbe74b2f14fbc840bfb","user":{"login":"MathWhiz","id":12386291,"avatar_url":"https://avatars.githubusercontent.com/u/12386291?v=3","gravatar_id":"","url":"https://api.github.com/users/MathWhiz","html_url":"https://github.com/MathWhiz","followers_url":"https://api.github.com/users/MathWhiz/followers","following_url":"https://api.github.com/users/MathWhiz/following{/other_user}","gists_url":"https://api.github.com/users/MathWhiz/gists{/gist_id}","starred_url":"https://api.github.com/users/MathWhiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathWhiz/subscriptions","organizations_url":"https://api.github.com/users/MathWhiz/orgs","repos_url":"https://api.github.com/users/MathWhiz/repos","events_url":"https://api.github.com/users/MathWhiz/events{/privacy}","received_events_url":"https://api.github.com/users/MathWhiz/received_events","type":"User","site_admin":false},"repo":{"id":51804002,"name":"habitrpg","full_name":"MathWhiz/habitrpg","owner":{"login":"MathWhiz","id":12386291,"avatar_url":"https://avatars.githubusercontent.com/u/12386291?v=3","gravatar_id":"","url":"https://api.github.com/users/MathWhiz","html_url":"https://github.com/MathWhiz","followers_url":"https://api.github.com/users/MathWhiz/followers","following_url":"https://api.github.com/users/MathWhiz/following{/other_user}","gists_url":"https://api.github.com/users/MathWhiz/gists{/gist_id}","starred_url":"https://api.github.com/users/MathWhiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathWhiz/subscriptions","organizations_url":"https://api.github.com/users/MathWhiz/orgs","repos_url":"https://api.github.com/users/MathWhiz/repos","events_url":"https://api.github.com/users/MathWhiz/events{/privacy}","received_events_url":"https://api.github.com/users/MathWhiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MathWhiz/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":true,"url":"https://api.github.com/repos/MathWhiz/habitrpg","forks_url":"https://api.github.com/repos/MathWhiz/habitrpg/forks","keys_url":"https://api.github.com/repos/MathWhiz/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MathWhiz/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MathWhiz/habitrpg/teams","hooks_url":"https://api.github.com/repos/MathWhiz/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/MathWhiz/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/MathWhiz/habitrpg/events","assignees_url":"https://api.github.com/repos/MathWhiz/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/MathWhiz/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/MathWhiz/habitrpg/tags","blobs_url":"https://api.github.com/repos/MathWhiz/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MathWhiz/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MathWhiz/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/MathWhiz/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MathWhiz/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/MathWhiz/habitrpg/languages","stargazers_url":"https://api.github.com/repos/MathWhiz/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/MathWhiz/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/MathWhiz/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/MathWhiz/habitrpg/subscription","commits_url":"https://api.github.com/repos/MathWhiz/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/MathWhiz/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/MathWhiz/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/MathWhiz/habitrpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/MathWhiz/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/MathWhiz/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MathWhiz/habitrpg/merges","archive_url":"https://api.github.com/repos/MathWhiz/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MathWhiz/habitrpg/downloads","issues_url":"https://api.github.com/repos/MathWhiz/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/MathWhiz/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/MathWhiz/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/MathWhiz/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MathWhiz/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/MathWhiz/habitrpg/releases{/id}","deployments_url":"https://api.github.com/repos/MathWhiz/habitrpg/deployments","created_at":"2016-02-16T03:07:16Z","updated_at":"2016-02-16T03:07:24Z","pushed_at":"2016-09-13T02:12:27Z","git_url":"git://github.com/MathWhiz/habitrpg.git","ssh_url":"git@github.com:MathWhiz/habitrpg.git","clone_url":"https://github.com/MathWhiz/habitrpg.git","svn_url":"https://github.com/MathWhiz/habitrpg","homepage":"https://habitica.com","size":450933,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HabitRPG:develop","ref":"develop","sha":"78d5f8c4f573d7b31036afd2967484a7008ce6ee","user":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":4578898,"name":"habitrpg","full_name":"HabitRPG/habitrpg","owner":{"login":"HabitRPG","id":3834775,"avatar_url":"https://avatars.githubusercontent.com/u/3834775?v=3","gravatar_id":"","url":"https://api.github.com/users/HabitRPG","html_url":"https://github.com/HabitRPG","followers_url":"https://api.github.com/users/HabitRPG/followers","following_url":"https://api.github.com/users/HabitRPG/following{/other_user}","gists_url":"https://api.github.com/users/HabitRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/HabitRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HabitRPG/subscriptions","organizations_url":"https://api.github.com/users/HabitRPG/orgs","repos_url":"https://api.github.com/users/HabitRPG/repos","events_url":"https://api.github.com/users/HabitRPG/events{/privacy}","received_events_url":"https://api.github.com/users/HabitRPG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HabitRPG/habitrpg","description":"A habit tracker app which treats your goals like a Role Playing Game.","fork":false,"url":"https://api.github.com/repos/HabitRPG/habitrpg","forks_url":"https://api.github.com/repos/HabitRPG/habitrpg/forks","keys_url":"https://api.github.com/repos/HabitRPG/habitrpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HabitRPG/habitrpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HabitRPG/habitrpg/teams","hooks_url":"https://api.github.com/repos/HabitRPG/habitrpg/hooks","issue_events_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/events{/number}","events_url":"https://api.github.com/repos/HabitRPG/habitrpg/events","assignees_url":"https://api.github.com/repos/HabitRPG/habitrpg/assignees{/user}","branches_url":"https://api.github.com/repos/HabitRPG/habitrpg/branches{/branch}","tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/tags","blobs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/{sha}","languages_url":"https://api.github.com/repos/HabitRPG/habitrpg/languages","stargazers_url":"https://api.github.com/repos/HabitRPG/habitrpg/stargazers","contributors_url":"https://api.github.com/repos/HabitRPG/habitrpg/contributors","subscribers_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscribers","subscription_url":"https://api.github.com/repos/HabitRPG/habitrpg/subscription","commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/HabitRPG/habitrpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/HabitRPG/habitrpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/HabitRPG/habitrpg/contents/{+path}","compare_url":"https://api.github.com/repos/HabitRPG/habitrpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HabitRPG/habitrpg/merges","archive_url":"https://api.github.com/repos/HabitRPG/habitrpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HabitRPG/habitrpg/downloads","issues_url":"https://api.github.com/repos/HabitRPG/habitrpg/issues{/number}","pulls_url":"https://api.github.com/repos/HabitRPG/habitrpg/pulls{/number}","milestones_url":"https://api.github.com/repos/HabitRPG/habitrpg/milestones{/number}","notifications_url":"https://api.github.com/repos/HabitRPG/habitrpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HabitRPG/habitrpg/labels{/name}","releases_url":"https://api.github.com/repos/HabitRPG/habitrpg/releases{/id}","deployments_url":"https://api.github.com/repos/HabitRPG/habitrpg/deployments","created_at":"2012-06-06T22:49:48Z","updated_at":"2016-09-13T02:36:46Z","pushed_at":"2016-09-13T02:30:35Z","git_url":"git://github.com/HabitRPG/habitrpg.git","ssh_url":"git@github.com:HabitRPG/habitrpg.git","clone_url":"https://github.com/HabitRPG/habitrpg.git","svn_url":"https://github.com/HabitRPG/habitrpg","homepage":"https://habitica.com","size":516778,"stargazers_count":4170,"watchers_count":4170,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1746,"mirror_url":null,"open_issues_count":344,"forks":1746,"open_issues":344,"watchers":4170,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768"},"html":{"href":"https://github.com/HabitRPG/habitrpg/pull/7768"},"issue":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/7768"},"comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/issues/7768/comments"},"review_comments":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768/comments"},"review_comment":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/pulls/7768/commits"},"statuses":{"href":"https://api.github.com/repos/HabitRPG/habitrpg/statuses/72a6d73a9be23fd72ba98fbe74b2f14fbc840bfb"}}}}
{"actor":{"display_login":"crookedneighbor"}}