{"action":"created","comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments/54396544","id":54396544,"diff_hunk":"@@ -0,0 +1,101 @@\n+package org.wordpress.android.ui.prefs;\n+\n+import android.app.AlertDialog;\n+import android.app.Dialog;\n+import android.app.DialogFragment;\n+import android.content.DialogInterface;\n+import android.os.Bundle;\n+import android.text.TextUtils;\n+import android.view.LayoutInflater;\n+import android.view.View;\n+\n+import org.wordpress.android.R;\n+import org.wordpress.android.util.AppLog;\n+import org.wordpress.android.widgets.OpenSansEditText;\n+import org.wordpress.android.widgets.WPTextView;\n+\n+public class ProfileInputDialogFragment extends DialogFragment {\n+\n+    private static final String TITLE_TAG = \"title\";\n+    private static final String INITIAL_TEXT_TAG = \"initial_text\";\n+    private static final String HINT_TAG = \"hint\";\n+    private static final String IS_MULTILINE_TAG = \"is_multiline\";\n+    private static final String TEXT_VIEW_ID_TAG = \"text_view_id\";\n+\n+    public static ProfileInputDialogFragment newInstance(String title,\n+                                   String initialText,\n+                                   String hint,\n+                                   boolean isMultiline,\n+                                   int textViewId) {","path":"WordPress/src/main/java/org/wordpress/android/ui/prefs/ProfileInputDialogFragment.java","position":29,"original_position":29,"commit_id":"ab6bb5b7fe79f6d1ffdbdcb0c9af7345ffc18421","original_commit_id":"ab6bb5b7fe79f6d1ffdbdcb0c9af7345ffc18421","user":{"login":"hypest","id":1032913,"avatar_url":"https://avatars.githubusercontent.com/u/1032913?v=3","gravatar_id":"","url":"https://api.github.com/users/hypest","html_url":"https://github.com/hypest","followers_url":"https://api.github.com/users/hypest/followers","following_url":"https://api.github.com/users/hypest/following{/other_user}","gists_url":"https://api.github.com/users/hypest/gists{/gist_id}","starred_url":"https://api.github.com/users/hypest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypest/subscriptions","organizations_url":"https://api.github.com/users/hypest/orgs","repos_url":"https://api.github.com/users/hypest/repos","events_url":"https://api.github.com/users/hypest/events{/privacy}","received_events_url":"https://api.github.com/users/hypest/received_events","type":"User","site_admin":false},"body":"Hey @rishabh7m , sorry for the delayed response!\r\n\r\nSo, yeah, an `int` parameter is just fine here.\r\n\r\nBut, even though this might seem like nitpicking, I'd suggest to name it after a more generic name than \"textViewId\". For ProfileInputDialogFragment, this integer is nothing more than an identifier to pass back to the callback. In that respect, it might be a TextView id or it might be any other identifier basically. I would suggest naming it `callbackId` or something similarly generic. Cheers!","created_at":"2016-02-29T11:11:47Z","updated_at":"2016-02-29T11:11:47Z","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3676#discussion_r54396544","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments/54396544"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Android/pull/3676#discussion_r54396544"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676"}}},"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676","id":57698541,"html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3676","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3676.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/3676.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3676","number":3676,"state":"open","locked":false,"title":"My Profile: Rotating device loses unsaved changes","user":{"login":"rishabh7m","id":6622124,"avatar_url":"https://avatars.githubusercontent.com/u/6622124?v=3","gravatar_id":"","url":"https://api.github.com/users/rishabh7m","html_url":"https://github.com/rishabh7m","followers_url":"https://api.github.com/users/rishabh7m/followers","following_url":"https://api.github.com/users/rishabh7m/following{/other_user}","gists_url":"https://api.github.com/users/rishabh7m/gists{/gist_id}","starred_url":"https://api.github.com/users/rishabh7m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishabh7m/subscriptions","organizations_url":"https://api.github.com/users/rishabh7m/orgs","repos_url":"https://api.github.com/users/rishabh7m/repos","events_url":"https://api.github.com/users/rishabh7m/events{/privacy}","received_events_url":"https://api.github.com/users/rishabh7m/received_events","type":"User","site_admin":false},"body":"fix #3608 ","created_at":"2016-01-29T20:29:30Z","updated_at":"2016-02-29T11:11:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"313d94b0490b84e54b23ce3721626915ce16aace","assignee":{"login":"hypest","id":1032913,"avatar_url":"https://avatars.githubusercontent.com/u/1032913?v=3","gravatar_id":"","url":"https://api.github.com/users/hypest","html_url":"https://github.com/hypest","followers_url":"https://api.github.com/users/hypest/followers","following_url":"https://api.github.com/users/hypest/following{/other_user}","gists_url":"https://api.github.com/users/hypest/gists{/gist_id}","starred_url":"https://api.github.com/users/hypest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypest/subscriptions","organizations_url":"https://api.github.com/users/hypest/orgs","repos_url":"https://api.github.com/users/hypest/repos","events_url":"https://api.github.com/users/hypest/events{/privacy}","received_events_url":"https://api.github.com/users/hypest/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/56","html_url":"https://github.com/wordpress-mobile/WordPress-Android/milestones/5.1","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/56/labels","id":1459724,"number":56,"title":"5.1","description":"","creator":{"login":"maxme","id":40213,"avatar_url":"https://avatars.githubusercontent.com/u/40213?v=3","gravatar_id":"","url":"https://api.github.com/users/maxme","html_url":"https://github.com/maxme","followers_url":"https://api.github.com/users/maxme/followers","following_url":"https://api.github.com/users/maxme/following{/other_user}","gists_url":"https://api.github.com/users/maxme/gists{/gist_id}","starred_url":"https://api.github.com/users/maxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxme/subscriptions","organizations_url":"https://api.github.com/users/maxme/orgs","repos_url":"https://api.github.com/users/maxme/repos","events_url":"https://api.github.com/users/maxme/events{/privacy}","received_events_url":"https://api.github.com/users/maxme/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":38,"state":"open","created_at":"2015-12-14T17:28:23Z","updated_at":"2016-02-17T23:32:07Z","due_on":"2016-03-06T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3676/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/ab6bb5b7fe79f6d1ffdbdcb0c9af7345ffc18421","head":{"label":"rishabh7m:enhancement/3608-profile-unsaved-changes-on-rotate","ref":"enhancement/3608-profile-unsaved-changes-on-rotate","sha":"ab6bb5b7fe79f6d1ffdbdcb0c9af7345ffc18421","user":{"login":"rishabh7m","id":6622124,"avatar_url":"https://avatars.githubusercontent.com/u/6622124?v=3","gravatar_id":"","url":"https://api.github.com/users/rishabh7m","html_url":"https://github.com/rishabh7m","followers_url":"https://api.github.com/users/rishabh7m/followers","following_url":"https://api.github.com/users/rishabh7m/following{/other_user}","gists_url":"https://api.github.com/users/rishabh7m/gists{/gist_id}","starred_url":"https://api.github.com/users/rishabh7m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishabh7m/subscriptions","organizations_url":"https://api.github.com/users/rishabh7m/orgs","repos_url":"https://api.github.com/users/rishabh7m/repos","events_url":"https://api.github.com/users/rishabh7m/events{/privacy}","received_events_url":"https://api.github.com/users/rishabh7m/received_events","type":"User","site_admin":false},"repo":{"id":49152078,"name":"WordPress-Android","full_name":"rishabh7m/WordPress-Android","owner":{"login":"rishabh7m","id":6622124,"avatar_url":"https://avatars.githubusercontent.com/u/6622124?v=3","gravatar_id":"","url":"https://api.github.com/users/rishabh7m","html_url":"https://github.com/rishabh7m","followers_url":"https://api.github.com/users/rishabh7m/followers","following_url":"https://api.github.com/users/rishabh7m/following{/other_user}","gists_url":"https://api.github.com/users/rishabh7m/gists{/gist_id}","starred_url":"https://api.github.com/users/rishabh7m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishabh7m/subscriptions","organizations_url":"https://api.github.com/users/rishabh7m/orgs","repos_url":"https://api.github.com/users/rishabh7m/repos","events_url":"https://api.github.com/users/rishabh7m/events{/privacy}","received_events_url":"https://api.github.com/users/rishabh7m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rishabh7m/WordPress-Android","description":"WordPress for Android","fork":true,"url":"https://api.github.com/repos/rishabh7m/WordPress-Android","forks_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/forks","keys_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/events","assignees_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/merges","archive_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/rishabh7m/WordPress-Android/deployments","created_at":"2016-01-06T18:00:28Z","updated_at":"2016-01-14T18:46:05Z","pushed_at":"2016-02-21T10:27:57Z","git_url":"git://github.com/rishabh7m/WordPress-Android.git","ssh_url":"git@github.com:rishabh7m/WordPress-Android.git","clone_url":"https://github.com/rishabh7m/WordPress-Android.git","svn_url":"https://github.com/rishabh7m/WordPress-Android","homepage":"http://android.wordpress.org","size":147561,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"5550627eaa9da563fe26de8eed7e1b31840fb62b","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9306568,"name":"WordPress-Android","full_name":"wordpress-mobile/WordPress-Android","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-Android","description":"WordPress for Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/deployments","created_at":"2013-04-08T20:52:40Z","updated_at":"2016-02-28T01:28:24Z","pushed_at":"2016-02-29T11:09:58Z","git_url":"git://github.com/wordpress-mobile/WordPress-Android.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Android.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Android.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Android","homepage":"http://android.wordpress.org","size":151704,"stargazers_count":1099,"watchers_count":1099,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":614,"mirror_url":null,"open_issues_count":139,"forks":614,"open_issues":139,"watchers":1099,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Android/pull/3676"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3676"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/3676/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/3676/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/ab6bb5b7fe79f6d1ffdbdcb0c9af7345ffc18421"}}}}