{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/buildtools/issues/999","repository_url":"https://api.github.com/repos/dotnet/buildtools","labels_url":"https://api.github.com/repos/dotnet/buildtools/issues/999/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/999/comments","events_url":"https://api.github.com/repos/dotnet/buildtools/issues/999/events","html_url":"https://github.com/dotnet/buildtools/issues/999","id":174148700,"number":999,"title":"Xunit.PlatformID should be plural","user":{"login":"justinvp","id":710598,"avatar_url":"https://avatars.githubusercontent.com/u/710598?v=3","gravatar_id":"","url":"https://api.github.com/users/justinvp","html_url":"https://github.com/justinvp","followers_url":"https://api.github.com/users/justinvp/followers","following_url":"https://api.github.com/users/justinvp/following{/other_user}","gists_url":"https://api.github.com/users/justinvp/gists{/gist_id}","starred_url":"https://api.github.com/users/justinvp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinvp/subscriptions","organizations_url":"https://api.github.com/users/justinvp/orgs","repos_url":"https://api.github.com/users/justinvp/repos","events_url":"https://api.github.com/users/justinvp/events{/privacy}","received_events_url":"https://api.github.com/users/justinvp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-30T23:17:30Z","updated_at":"2016-08-31T00:51:58Z","closed_at":null,"body":"This is very nit-picky, but it's a pet peeve of mine: It'd be nice if the .NET Core code followed the framework design guidelines, even in test infrastructure code, so it feels familiar to .NET developers.\r\n\r\n[`Xunit.PlatformID`](https://github.com/dotnet/buildtools/blob/master/src/xunit.netcore.extensions/PlatformID.cs) is a flags enum, and according the [design guidelines](https://msdn.microsoft.com/en-us/library/ms229040(v=vs.110).aspx), it should be plural:\r\n\r\n> ✓ DO use a singular type name for an enumeration unless its values are bit fields.\r\n> ✓ DO use a plural type name for an enumeration with bit fields as values, also called flags enum.\r\n\r\nThus, I'd like to rename `PlatformID` to `PlatformIDs` (plural) to follow the .NET conventions we're used to.\r\n\r\nRenaming has an additional benefit: the plural name would no longer conflict with [`System.PlatformID`](https://github.com/dotnet/corefx/blob/c4538cc3e6d3c28318e50ce81d5c2137c91b0d44/src/System.Runtime.Extensions/ref/System.Runtime.Extensions.cs#L685-L694), which is being added back in the dev/api branch in CoreFX. Renaming the test enum means we'll no longer need to  [fully qualify it with the namespace](https://github.com/dotnet/corefx/blob/722c529bb3b4096564c33303568e8e99a350100b/src/System.Globalization/tests/CultureInfo/CultureInfoCurrentCulture.cs#L103) anymore, e.g. instead of `[PlatformSpecific(Xunit.PlatformID.AnyUnix)]` it could simply be `[PlatformSpecific(PlatformIDs.AnyUnix)]`.\r\n\r\nI know this will cause some churn, and for a seemingly minor benefit, but I'd be happy to do the work to make it happen, opening a PR in this repo to do the rename, along with PRs in the repos that need to be updated as a result.\r\n\r\ncc: @weshaggard @stephentoub @Priya91 "},"comment":{"url":"https://api.github.com/repos/dotnet/buildtools/issues/comments/243627076","html_url":"https://github.com/dotnet/buildtools/issues/999#issuecomment-243627076","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/999","id":243627076,"user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T00:51:57Z","updated_at":"2016-08-31T00:51:57Z","body":"I have another reason to rename this which is that in conflicts with System.PlatformID which we have recently exposed and we had to use alias' to disambiguate. @joperezr I believe you hit that issue recently. \r\n\r\nSo I think we should rename it but Platforms might be a little to general, PlatformIDs seems a little better to me. "}}
{"actor":{"display_login":"weshaggard"}}