{"action":"created","issue":{"url":"https://api.github.com/repos/influxdata/influxdb/issues/5863","repository_url":"https://api.github.com/repos/influxdata/influxdb","labels_url":"https://api.github.com/repos/influxdata/influxdb/issues/5863/labels{/name}","comments_url":"https://api.github.com/repos/influxdata/influxdb/issues/5863/comments","events_url":"https://api.github.com/repos/influxdata/influxdb/issues/5863/events","html_url":"https://github.com/influxdata/influxdb/pull/5863","id":137332302,"number":5863,"title":"influx_tsm: multiple improvements","user":{"login":"joelegasse","id":1391698,"avatar_url":"https://avatars.githubusercontent.com/u/1391698?v=3","gravatar_id":"","url":"https://api.github.com/users/joelegasse","html_url":"https://github.com/joelegasse","followers_url":"https://api.github.com/users/joelegasse/followers","following_url":"https://api.github.com/users/joelegasse/following{/other_user}","gists_url":"https://api.github.com/users/joelegasse/gists{/gist_id}","starred_url":"https://api.github.com/users/joelegasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelegasse/subscriptions","organizations_url":"https://api.github.com/users/joelegasse/orgs","repos_url":"https://api.github.com/users/joelegasse/repos","events_url":"https://api.github.com/users/joelegasse/events{/privacy}","received_events_url":"https://api.github.com/users/joelegasse/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-29T18:28:36Z","updated_at":"2016-02-29T19:15:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/influxdata/influxdb/pulls/5863","html_url":"https://github.com/influxdata/influxdb/pull/5863","diff_url":"https://github.com/influxdata/influxdb/pull/5863.diff","patch_url":"https://github.com/influxdata/influxdb/pull/5863.patch"},"body":"The largest change is the drastic improvement in time for converting `b1` shards. On my machine it halved the time from 40s for a ~3GB b1 shard to 20s. Also, there was a data-loss bug in the b1 reader that caused some points to be missed... specifically the first point in the series. It turns out the `SeekTo` method was defined on the value type, not the pointer type. This meant the bolt cursor (a pointer field) was used to perform the seek, and returned the first point to a copy of the `b1.Reader`, which was promptly forgotten about...  :-(\r\n\r\n- Removed a lot of unused code\r\n- Consolidated value types in `tsdb` package\r\n- Improved allocations for converting b1 shards\r\n- Eliminated allocations when sorting cursors\r\n- Eliminated allocations from scrubValues, Infinity and NaN are removed by the cursors now\r\n- Separated out the stats from the conversion tracker\r\n- Removed allocations from shard reader buffers\r\n- Improved logic for shard reader Next()/Read()"},"comment":{"url":"https://api.github.com/repos/influxdata/influxdb/issues/comments/190339970","html_url":"https://github.com/influxdata/influxdb/pull/5863#issuecomment-190339970","issue_url":"https://api.github.com/repos/influxdata/influxdb/issues/5863","id":190339970,"user":{"login":"jwilder","id":219935,"avatar_url":"https://avatars.githubusercontent.com/u/219935?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilder","html_url":"https://github.com/jwilder","followers_url":"https://api.github.com/users/jwilder/followers","following_url":"https://api.github.com/users/jwilder/following{/other_user}","gists_url":"https://api.github.com/users/jwilder/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilder/subscriptions","organizations_url":"https://api.github.com/users/jwilder/orgs","repos_url":"https://api.github.com/users/jwilder/repos","events_url":"https://api.github.com/users/jwilder/events{/privacy}","received_events_url":"https://api.github.com/users/jwilder/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T19:15:08Z","updated_at":"2016-02-29T19:15:08Z","body":"Two small things to fix, but LGTM. :+1: "}}