{"action":"created","issue":{"url":"https://api.github.com/repos/sharvil/api-docs/issues/30","repository_url":"https://api.github.com/repos/sharvil/api-docs","labels_url":"https://api.github.com/repos/sharvil/api-docs/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/sharvil/api-docs/issues/30/comments","events_url":"https://api.github.com/repos/sharvil/api-docs/issues/30/events","html_url":"https://github.com/sharvil/api-docs/pull/30","id":163729833,"number":30,"title":"fix icon selection","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-04T18:43:26Z","updated_at":"2016-07-07T15:36:56Z","closed_at":"2016-07-06T19:56:22Z","pull_request":{"url":"https://api.github.com/repos/sharvil/api-docs/pulls/30","html_url":"https://github.com/sharvil/api-docs/pull/30","diff_url":"https://github.com/sharvil/api-docs/pull/30.diff","patch_url":"https://github.com/sharvil/api-docs/pull/30.patch"},"body":"Currently the package tries to load the icon in the query view based in the full slug name. For many languages which have slugs for several version numbers there is no icon with such a name. And it would be \"bad\" to duplicate the icons for the various variations just to match the slug name.\r\n\r\nTherefore this patch looks at all the available icon files and try to match:\r\n* the full slug name (e.g. `cmake~3.5`)\r\n* then the variation without the minor version after the `.` (e.g. `cmake~3`)\r\n* then the variation without the version after the `~` (e.g. `cmake`)\r\n\r\nThe most specific match will be used. Commonly there are only icons without a version number. But this allows to use different icons when necessary.\r\n\r\nIf no matching icon is found the full slug name is being used (as before). Instead the logic could also fallback to a default icon if that would be desired.\r\n\r\nThis fixes at least the icon problem mentioned in #29."},"comment":{"url":"https://api.github.com/repos/sharvil/api-docs/issues/comments/231116754","html_url":"https://github.com/sharvil/api-docs/pull/30#issuecomment-231116754","issue_url":"https://api.github.com/repos/sharvil/api-docs/issues/30","id":231116754,"user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T15:36:56Z","updated_at":"2016-07-07T15:36:56Z","body":"@sharvil I would like to go ahead and do a patch release with the recent fixes if that ok with you?"}}
{"actor":{"display_login":"dirk-thomas"}}