{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/74418333","id":74418333,"diff_hunk":"@@ -44,13 +44,10 @@ class PlgTwofactorauthTotp extends JPlugin\n \t */\n \tpublic function __construct(&$subject, $config = array())\n \t{\n-\t\tparent::__construct($subject, $config);\n+\t\tinclude_once JPATH_LIBRARIES . '/joomla/encrypt/Totp.php';","path":"plugins/twofactorauth/totp/totp.php","position":5,"original_position":5,"commit_id":"9af26597b56b478b7da90eb05623cf795b88dbf5","original_commit_id":"9af26597b56b478b7da90eb05623cf795b88dbf5","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"body":"The fact you are manually including these files versus using the autoloader confirms my previous statements.","created_at":"2016-08-11T13:09:25Z","updated_at":"2016-08-11T13:09:25Z","html_url":"https://github.com/joomla/joomla-cms/pull/11553#discussion_r74418333","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/74418333"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11553#discussion_r74418333"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553","id":80921222,"html_url":"https://github.com/joomla/joomla-cms/pull/11553","diff_url":"https://github.com/joomla/joomla-cms/pull/11553.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11553.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11553","number":11553,"state":"open","locked":false,"title":"Refactor 2FA from FOF to Joomla Core","user":{"login":"faynt0","id":20767810,"avatar_url":"https://avatars.githubusercontent.com/u/20767810?v=3","gravatar_id":"","url":"https://api.github.com/users/faynt0","html_url":"https://github.com/faynt0","followers_url":"https://api.github.com/users/faynt0/followers","following_url":"https://api.github.com/users/faynt0/following{/other_user}","gists_url":"https://api.github.com/users/faynt0/gists{/gist_id}","starred_url":"https://api.github.com/users/faynt0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faynt0/subscriptions","organizations_url":"https://api.github.com/users/faynt0/orgs","repos_url":"https://api.github.com/users/faynt0/repos","events_url":"https://api.github.com/users/faynt0/events{/privacy}","received_events_url":"https://api.github.com/users/faynt0/received_events","type":"User","site_admin":false},"body":"#### Summary of Changes\r\n* Refactored 2FA from FOF to Joomla Core\r\n* Removed dependecies to FOF\r\n* Refactored 2FA templates to JLayouts\r\n\r\n#### Testing Instructions\r\n* **Step 1** Activate the Twofactor Auth plugins ( Google Auth, Yubikey) in the backend \r\n* **Step 2** Frontend: Go to the \"Edit user profile\" page and activate 2FA (Google Auth) and set up the authenticator\r\n* **Step 2.1** Select Yubikey from the dropdown menu and it's template should be loaded ( Yubikey FOF dependecy was only related to the template)\r\n* **Step 3** Logout and log in using your Google authenticator ( Frontend & Backend)\r\n* **Step 4** After applying the patch Step 1-3 should work as before.\r\n","created_at":"2016-08-11T08:40:39Z","updated_at":"2016-08-11T13:09:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"176b2d7cf825450e35d8ed88b5e38a8f5e822ed4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11553/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/9af26597b56b478b7da90eb05623cf795b88dbf5","head":{"label":"Curtista:Refactor_2FA_to_Joomla_core","ref":"Refactor_2FA_to_Joomla_core","sha":"9af26597b56b478b7da90eb05623cf795b88dbf5","user":{"login":"Curtista","id":10713918,"avatar_url":"https://avatars.githubusercontent.com/u/10713918?v=3","gravatar_id":"","url":"https://api.github.com/users/Curtista","html_url":"https://github.com/Curtista","followers_url":"https://api.github.com/users/Curtista/followers","following_url":"https://api.github.com/users/Curtista/following{/other_user}","gists_url":"https://api.github.com/users/Curtista/gists{/gist_id}","starred_url":"https://api.github.com/users/Curtista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Curtista/subscriptions","organizations_url":"https://api.github.com/users/Curtista/orgs","repos_url":"https://api.github.com/users/Curtista/repos","events_url":"https://api.github.com/users/Curtista/events{/privacy}","received_events_url":"https://api.github.com/users/Curtista/received_events","type":"User","site_admin":false},"repo":{"id":64829772,"name":"joomla-cms","full_name":"Curtista/joomla-cms","owner":{"login":"Curtista","id":10713918,"avatar_url":"https://avatars.githubusercontent.com/u/10713918?v=3","gravatar_id":"","url":"https://api.github.com/users/Curtista","html_url":"https://github.com/Curtista","followers_url":"https://api.github.com/users/Curtista/followers","following_url":"https://api.github.com/users/Curtista/following{/other_user}","gists_url":"https://api.github.com/users/Curtista/gists{/gist_id}","starred_url":"https://api.github.com/users/Curtista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Curtista/subscriptions","organizations_url":"https://api.github.com/users/Curtista/orgs","repos_url":"https://api.github.com/users/Curtista/repos","events_url":"https://api.github.com/users/Curtista/events{/privacy}","received_events_url":"https://api.github.com/users/Curtista/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Curtista/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Curtista/joomla-cms","forks_url":"https://api.github.com/repos/Curtista/joomla-cms/forks","keys_url":"https://api.github.com/repos/Curtista/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Curtista/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Curtista/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Curtista/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Curtista/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Curtista/joomla-cms/events","assignees_url":"https://api.github.com/repos/Curtista/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Curtista/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Curtista/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Curtista/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Curtista/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Curtista/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Curtista/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Curtista/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Curtista/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Curtista/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Curtista/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Curtista/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Curtista/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Curtista/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Curtista/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Curtista/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Curtista/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Curtista/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Curtista/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Curtista/joomla-cms/merges","archive_url":"https://api.github.com/repos/Curtista/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Curtista/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Curtista/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Curtista/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Curtista/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Curtista/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Curtista/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Curtista/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Curtista/joomla-cms/deployments","created_at":"2016-08-03T08:37:50Z","updated_at":"2016-08-09T08:12:58Z","pushed_at":"2016-08-11T11:05:40Z","git_url":"git://github.com/Curtista/joomla-cms.git","ssh_url":"git@github.com:Curtista/joomla-cms.git","clone_url":"https://github.com/Curtista/joomla-cms.git","svn_url":"https://github.com/Curtista/joomla-cms","homepage":"https://www.joomla.org","size":153410,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"540a3bc1f88aa33e00df7f17f54be2218314b819","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-08-10T02:27:14Z","pushed_at":"2016-08-11T12:47:54Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":288418,"stargazers_count":2107,"watchers_count":2107,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2259,"mirror_url":null,"open_issues_count":535,"forks":2259,"open_issues":535,"watchers":2107,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11553"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11553"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11553/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11553/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/9af26597b56b478b7da90eb05623cf795b88dbf5"}}}}
{"actor":{"display_login":"mbabker"}}