{"action":"created","comment":{"url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments/48837283","id":48837283,"diff_hunk":"@@ -214,16 +209,17 @@ Quaternion: cover {\n \tcreateFromEulerAngles: static func (rotationX, rotationY, rotationZ: Float) -> This {\n \t\tThis createRotationZ(rotationZ) * This createRotationY(rotationY) * This createRotationX(rotationX)\n \t}\n-\tcreateRotation: static func (angle: Float, direction: FloatPoint3D) -> This {\n+\tcreateRotation: static func (angle: Float, direction: FloatVector3D) -> This {\n \t\thalfAngle := angle / 2.0f\n \t\tpoint3DNorm := direction norm\n \t\tif (point3DNorm != 0.0f)\n \t\t\tdirection /= point3DNorm\n-\t\tThis new(0.0f, halfAngle * direction) exponential\n+\t\tThis new(0.0f, (halfAngle * direction) toFloatPoint3D()) exponential","path":"source/geometry/Quaternion.ooc","position":36,"original_position":36,"commit_id":"91ce1e115adede022dcaf6432297f41afb8a95aa","original_commit_id":"91ce1e115adede022dcaf6432297f41afb8a95aa","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"body":"That is my suggestion and it is included in this issue https://github.com/cogneco/ooc-kean/issues/1156, but I left it out in this PR.","created_at":"2016-01-05T11:50:13Z","updated_at":"2016-01-05T11:50:13Z","html_url":"https://github.com/cogneco/ooc-kean/pull/1157#discussion_r48837283","pull_request_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157","_links":{"self":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments/48837283"},"html":{"href":"https://github.com/cogneco/ooc-kean/pull/1157#discussion_r48837283"},"pull_request":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157"}}},"pull_request":{"url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157","id":55073245,"html_url":"https://github.com/cogneco/ooc-kean/pull/1157","diff_url":"https://github.com/cogneco/ooc-kean/pull/1157.diff","patch_url":"https://github.com/cogneco/ooc-kean/pull/1157.patch","issue_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/1157","number":1157,"state":"open","locked":false,"title":"Quaternion cleanup","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"body":"Replaced `FloatPoint3D` with `FloatVector3D` where appropriate and some other minor improvements.\r\n\r\n* Breaks API\r\n\r\n@niklasborwell peer review","created_at":"2016-01-05T10:04:32Z","updated_at":"2016-01-05T11:50:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9874aa3302ab30b7d19c3f240e7c322528c95121","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157/commits","review_comments_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157/comments","review_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/1157/comments","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/91ce1e115adede022dcaf6432297f41afb8a95aa","head":{"label":"emilwestergren:quaternion_cleanup","ref":"quaternion_cleanup","sha":"91ce1e115adede022dcaf6432297f41afb8a95aa","user":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"repo":{"id":25524995,"name":"ooc-kean","full_name":"emilwestergren/ooc-kean","owner":{"login":"emilwestergren","id":7700995,"avatar_url":"https://avatars.githubusercontent.com/u/7700995?v=3","gravatar_id":"","url":"https://api.github.com/users/emilwestergren","html_url":"https://github.com/emilwestergren","followers_url":"https://api.github.com/users/emilwestergren/followers","following_url":"https://api.github.com/users/emilwestergren/following{/other_user}","gists_url":"https://api.github.com/users/emilwestergren/gists{/gist_id}","starred_url":"https://api.github.com/users/emilwestergren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilwestergren/subscriptions","organizations_url":"https://api.github.com/users/emilwestergren/orgs","repos_url":"https://api.github.com/users/emilwestergren/repos","events_url":"https://api.github.com/users/emilwestergren/events{/privacy}","received_events_url":"https://api.github.com/users/emilwestergren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emilwestergren/ooc-kean","description":"OOC port of parts of Kean.","fork":true,"url":"https://api.github.com/repos/emilwestergren/ooc-kean","forks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/forks","keys_url":"https://api.github.com/repos/emilwestergren/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emilwestergren/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emilwestergren/ooc-kean/teams","hooks_url":"https://api.github.com/repos/emilwestergren/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/emilwestergren/ooc-kean/events","assignees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/emilwestergren/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/tags","blobs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emilwestergren/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/emilwestergren/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/emilwestergren/ooc-kean/subscription","commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/emilwestergren/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/emilwestergren/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/emilwestergren/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/emilwestergren/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emilwestergren/ooc-kean/merges","archive_url":"https://api.github.com/repos/emilwestergren/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emilwestergren/ooc-kean/downloads","issues_url":"https://api.github.com/repos/emilwestergren/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/emilwestergren/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/emilwestergren/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/emilwestergren/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emilwestergren/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/emilwestergren/ooc-kean/releases{/id}","created_at":"2014-10-21T13:51:19Z","updated_at":"2015-05-08T14:56:04Z","pushed_at":"2016-01-05T10:03:25Z","git_url":"git://github.com/emilwestergren/ooc-kean.git","ssh_url":"git@github.com:emilwestergren/ooc-kean.git","clone_url":"https://github.com/emilwestergren/ooc-kean.git","svn_url":"https://github.com/emilwestergren/ooc-kean","homepage":null,"size":29506,"stargazers_count":0,"watchers_count":0,"language":"ooc","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cogneco:master","ref":"master","sha":"cfcbf4071b2deafea5f1107e0aac04167cde3308","user":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"repo":{"id":25256330,"name":"ooc-kean","full_name":"cogneco/ooc-kean","owner":{"login":"cogneco","id":3601419,"avatar_url":"https://avatars.githubusercontent.com/u/3601419?v=3","gravatar_id":"","url":"https://api.github.com/users/cogneco","html_url":"https://github.com/cogneco","followers_url":"https://api.github.com/users/cogneco/followers","following_url":"https://api.github.com/users/cogneco/following{/other_user}","gists_url":"https://api.github.com/users/cogneco/gists{/gist_id}","starred_url":"https://api.github.com/users/cogneco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cogneco/subscriptions","organizations_url":"https://api.github.com/users/cogneco/orgs","repos_url":"https://api.github.com/users/cogneco/repos","events_url":"https://api.github.com/users/cogneco/events{/privacy}","received_events_url":"https://api.github.com/users/cogneco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cogneco/ooc-kean","description":"ooc port of parts of Kean.","fork":false,"url":"https://api.github.com/repos/cogneco/ooc-kean","forks_url":"https://api.github.com/repos/cogneco/ooc-kean/forks","keys_url":"https://api.github.com/repos/cogneco/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cogneco/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cogneco/ooc-kean/teams","hooks_url":"https://api.github.com/repos/cogneco/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/cogneco/ooc-kean/events","assignees_url":"https://api.github.com/repos/cogneco/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/cogneco/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/cogneco/ooc-kean/tags","blobs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cogneco/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cogneco/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/cogneco/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cogneco/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/cogneco/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/cogneco/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/cogneco/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/cogneco/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/cogneco/ooc-kean/subscription","commits_url":"https://api.github.com/repos/cogneco/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/cogneco/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/cogneco/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/cogneco/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/cogneco/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/cogneco/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cogneco/ooc-kean/merges","archive_url":"https://api.github.com/repos/cogneco/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cogneco/ooc-kean/downloads","issues_url":"https://api.github.com/repos/cogneco/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/cogneco/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/cogneco/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/cogneco/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cogneco/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/cogneco/ooc-kean/releases{/id}","created_at":"2014-10-15T13:42:17Z","updated_at":"2015-05-08T13:13:16Z","pushed_at":"2016-01-05T11:12:34Z","git_url":"git://github.com/cogneco/ooc-kean.git","ssh_url":"git@github.com:cogneco/ooc-kean.git","clone_url":"https://github.com/cogneco/ooc-kean.git","svn_url":"https://github.com/cogneco/ooc-kean","homepage":"","size":29873,"stargazers_count":3,"watchers_count":3,"language":"ooc","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":65,"forks":18,"open_issues":65,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157"},"html":{"href":"https://github.com/cogneco/ooc-kean/pull/1157"},"issue":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/1157"},"comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/issues/1157/comments"},"review_comments":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157/comments"},"review_comment":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cogneco/ooc-kean/pulls/1157/commits"},"statuses":{"href":"https://api.github.com/repos/cogneco/ooc-kean/statuses/91ce1e115adede022dcaf6432297f41afb8a95aa"}}}}