{"action":"created","comment":{"url":"https://api.github.com/repos/scummvm/scummvm/pulls/comments/74824751","id":74824751,"diff_hunk":"@@ -0,0 +1,86 @@\n+/* ScummVM - Graphic Adventure Engine\n+ *\n+ * ScummVM is the legal property of its developers, whose names\n+ * are too numerous to list here. Please refer to the COPYRIGHT\n+ * file distributed with this source distribution.\n+ *\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation; either version 2\n+ * of the License, or (at your option) any later version.\n+\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.\n+ *\n+ */\n+\n+#ifndef MACVENTURE_DATAFILES_H\n+#define MACVENTURE_DATAFILES_H\n+\n+#include \"macventure/macventure.h\"\n+#include \"macventure/windows.h\"\n+\n+#include \"common/unzip.h\"\n+\n+namespace MacVenture {\n+\n+#define MACVENTURE_DATA_BUNDLE Common::String(\"macventure.zip\")\n+\n+Common::String windowTypeName(MVWindowType windowType) {\n+\tswitch (windowType) {\n+\tcase kDocument:","path":"engines/macventure/datafiles.cpp","position":37,"original_position":37,"commit_id":"03a5a277e03b1837417dbf5cc524d97c82b572f5","original_commit_id":"03a5a277e03b1837417dbf5cc524d97c82b572f5","user":{"login":"sev-","id":365188,"avatar_url":"https://avatars.githubusercontent.com/u/365188?v=3","gravatar_id":"","url":"https://api.github.com/users/sev-","html_url":"https://github.com/sev-","followers_url":"https://api.github.com/users/sev-/followers","following_url":"https://api.github.com/users/sev-/following{/other_user}","gists_url":"https://api.github.com/users/sev-/gists{/gist_id}","starred_url":"https://api.github.com/users/sev-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sev-/subscriptions","organizations_url":"https://api.github.com/users/sev-/orgs","repos_url":"https://api.github.com/users/sev-/repos","events_url":"https://api.github.com/users/sev-/events{/privacy}","received_events_url":"https://api.github.com/users/sev-/received_events","type":"User","site_admin":false},"body":"I would put it into a static array of structures and iterate over it","created_at":"2016-08-15T20:05:15Z","updated_at":"2016-08-15T20:05:15Z","html_url":"https://github.com/scummvm/scummvm/pull/807#discussion_r74824751","pull_request_url":"https://api.github.com/repos/scummvm/scummvm/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/comments/74824751"},"html":{"href":"https://github.com/scummvm/scummvm/pull/807#discussion_r74824751"},"pull_request":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/807"}}},"pull_request":{"url":"https://api.github.com/repos/scummvm/scummvm/pulls/807","id":81290428,"html_url":"https://github.com/scummvm/scummvm/pull/807","diff_url":"https://github.com/scummvm/scummvm/pull/807.diff","patch_url":"https://github.com/scummvm/scummvm/pull/807.patch","issue_url":"https://api.github.com/repos/scummvm/scummvm/issues/807","number":807,"state":"open","locked":false,"title":"MACVENTURE: [GSoC] Add MacVenture engine.","user":{"login":"blorente","id":5861182,"avatar_url":"https://avatars.githubusercontent.com/u/5861182?v=3","gravatar_id":"","url":"https://api.github.com/users/blorente","html_url":"https://github.com/blorente","followers_url":"https://api.github.com/users/blorente/followers","following_url":"https://api.github.com/users/blorente/following{/other_user}","gists_url":"https://api.github.com/users/blorente/gists{/gist_id}","starred_url":"https://api.github.com/users/blorente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blorente/subscriptions","organizations_url":"https://api.github.com/users/blorente/orgs","repos_url":"https://api.github.com/users/blorente/repos","events_url":"https://api.github.com/users/blorente/events{/privacy}","received_events_url":"https://api.github.com/users/blorente/received_events","type":"User","site_admin":false},"body":"Add a ScummVM implementation of the [WebVenture engine](https://github.com/mrkite/webventure), which includes support for graphics, sound, text and savefiles.\r\n\r\nIt has been tested with Shadowgate (it is winnable), and it can detect Dèjá Vu and Dèjá Vu II, if the game files are extracted as indicated [here](https://github.com/blorente/MacVenture-Extract-Guide). All of this has only been tested with the Zojoi rereleases, since I don't have access to the originals.\r\n\r\nKnown issues:\r\n- There is a big leak when rendering the game. It has been tracked down, more info can be found [here](https://trello.com/c/NmIcp9OO/55-transparent-surface-leak).\r\n- The border files have to be added manually to the game folder. They can be downloaded [here](https://github.com/blorente/MacVenture-Extract-Guide), or use the attached zip. \r\n[macventure.zip](https://github.com/scummvm/scummvm/files/417832/macventure.zip)\r\n- There are several encapsulation faults and hacks, this is due to the opaque nature of the original implementation, since JavaScript has much looser constraints on types and variables. Therefore, functionality was favored over style for the GSoC, although all these have been marked as `// HACK`, and are slowly being addressed.\r\n","created_at":"2016-08-15T09:42:33Z","updated_at":"2016-08-15T20:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2e520639518465252e4db0723cf746893a7f05e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scummvm/scummvm/pulls/807/commits","review_comments_url":"https://api.github.com/repos/scummvm/scummvm/pulls/807/comments","review_comment_url":"https://api.github.com/repos/scummvm/scummvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scummvm/scummvm/issues/807/comments","statuses_url":"https://api.github.com/repos/scummvm/scummvm/statuses/03a5a277e03b1837417dbf5cc524d97c82b572f5","head":{"label":"blorente:macventure-clean","ref":"macventure-clean","sha":"03a5a277e03b1837417dbf5cc524d97c82b572f5","user":{"login":"blorente","id":5861182,"avatar_url":"https://avatars.githubusercontent.com/u/5861182?v=3","gravatar_id":"","url":"https://api.github.com/users/blorente","html_url":"https://github.com/blorente","followers_url":"https://api.github.com/users/blorente/followers","following_url":"https://api.github.com/users/blorente/following{/other_user}","gists_url":"https://api.github.com/users/blorente/gists{/gist_id}","starred_url":"https://api.github.com/users/blorente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blorente/subscriptions","organizations_url":"https://api.github.com/users/blorente/orgs","repos_url":"https://api.github.com/users/blorente/repos","events_url":"https://api.github.com/users/blorente/events{/privacy}","received_events_url":"https://api.github.com/users/blorente/received_events","type":"User","site_admin":false},"repo":{"id":52895311,"name":"scummvm","full_name":"blorente/scummvm","owner":{"login":"blorente","id":5861182,"avatar_url":"https://avatars.githubusercontent.com/u/5861182?v=3","gravatar_id":"","url":"https://api.github.com/users/blorente","html_url":"https://github.com/blorente","followers_url":"https://api.github.com/users/blorente/followers","following_url":"https://api.github.com/users/blorente/following{/other_user}","gists_url":"https://api.github.com/users/blorente/gists{/gist_id}","starred_url":"https://api.github.com/users/blorente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blorente/subscriptions","organizations_url":"https://api.github.com/users/blorente/orgs","repos_url":"https://api.github.com/users/blorente/repos","events_url":"https://api.github.com/users/blorente/events{/privacy}","received_events_url":"https://api.github.com/users/blorente/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blorente/scummvm","description":"ScummVM main repository","fork":true,"url":"https://api.github.com/repos/blorente/scummvm","forks_url":"https://api.github.com/repos/blorente/scummvm/forks","keys_url":"https://api.github.com/repos/blorente/scummvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blorente/scummvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blorente/scummvm/teams","hooks_url":"https://api.github.com/repos/blorente/scummvm/hooks","issue_events_url":"https://api.github.com/repos/blorente/scummvm/issues/events{/number}","events_url":"https://api.github.com/repos/blorente/scummvm/events","assignees_url":"https://api.github.com/repos/blorente/scummvm/assignees{/user}","branches_url":"https://api.github.com/repos/blorente/scummvm/branches{/branch}","tags_url":"https://api.github.com/repos/blorente/scummvm/tags","blobs_url":"https://api.github.com/repos/blorente/scummvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blorente/scummvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blorente/scummvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/blorente/scummvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blorente/scummvm/statuses/{sha}","languages_url":"https://api.github.com/repos/blorente/scummvm/languages","stargazers_url":"https://api.github.com/repos/blorente/scummvm/stargazers","contributors_url":"https://api.github.com/repos/blorente/scummvm/contributors","subscribers_url":"https://api.github.com/repos/blorente/scummvm/subscribers","subscription_url":"https://api.github.com/repos/blorente/scummvm/subscription","commits_url":"https://api.github.com/repos/blorente/scummvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/blorente/scummvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/blorente/scummvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/blorente/scummvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/blorente/scummvm/contents/{+path}","compare_url":"https://api.github.com/repos/blorente/scummvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blorente/scummvm/merges","archive_url":"https://api.github.com/repos/blorente/scummvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blorente/scummvm/downloads","issues_url":"https://api.github.com/repos/blorente/scummvm/issues{/number}","pulls_url":"https://api.github.com/repos/blorente/scummvm/pulls{/number}","milestones_url":"https://api.github.com/repos/blorente/scummvm/milestones{/number}","notifications_url":"https://api.github.com/repos/blorente/scummvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blorente/scummvm/labels{/name}","releases_url":"https://api.github.com/repos/blorente/scummvm/releases{/id}","deployments_url":"https://api.github.com/repos/blorente/scummvm/deployments","created_at":"2016-03-01T17:18:55Z","updated_at":"2016-06-09T04:46:07Z","pushed_at":"2016-08-15T18:49:23Z","git_url":"git://github.com/blorente/scummvm.git","ssh_url":"git@github.com:blorente/scummvm.git","clone_url":"https://github.com/blorente/scummvm.git","svn_url":"https://github.com/blorente/scummvm","homepage":"http://www.scummvm.org/","size":199944,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"scummvm:master","ref":"master","sha":"cbf5fb0beee0e0157c2d9a8e4cac2d35106e5c34","user":{"login":"scummvm","id":365181,"avatar_url":"https://avatars.githubusercontent.com/u/365181?v=3","gravatar_id":"","url":"https://api.github.com/users/scummvm","html_url":"https://github.com/scummvm","followers_url":"https://api.github.com/users/scummvm/followers","following_url":"https://api.github.com/users/scummvm/following{/other_user}","gists_url":"https://api.github.com/users/scummvm/gists{/gist_id}","starred_url":"https://api.github.com/users/scummvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scummvm/subscriptions","organizations_url":"https://api.github.com/users/scummvm/orgs","repos_url":"https://api.github.com/users/scummvm/repos","events_url":"https://api.github.com/users/scummvm/events{/privacy}","received_events_url":"https://api.github.com/users/scummvm/received_events","type":"Organization","site_admin":false},"repo":{"id":1358940,"name":"scummvm","full_name":"scummvm/scummvm","owner":{"login":"scummvm","id":365181,"avatar_url":"https://avatars.githubusercontent.com/u/365181?v=3","gravatar_id":"","url":"https://api.github.com/users/scummvm","html_url":"https://github.com/scummvm","followers_url":"https://api.github.com/users/scummvm/followers","following_url":"https://api.github.com/users/scummvm/following{/other_user}","gists_url":"https://api.github.com/users/scummvm/gists{/gist_id}","starred_url":"https://api.github.com/users/scummvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scummvm/subscriptions","organizations_url":"https://api.github.com/users/scummvm/orgs","repos_url":"https://api.github.com/users/scummvm/repos","events_url":"https://api.github.com/users/scummvm/events{/privacy}","received_events_url":"https://api.github.com/users/scummvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scummvm/scummvm","description":"ScummVM main repository","fork":false,"url":"https://api.github.com/repos/scummvm/scummvm","forks_url":"https://api.github.com/repos/scummvm/scummvm/forks","keys_url":"https://api.github.com/repos/scummvm/scummvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scummvm/scummvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scummvm/scummvm/teams","hooks_url":"https://api.github.com/repos/scummvm/scummvm/hooks","issue_events_url":"https://api.github.com/repos/scummvm/scummvm/issues/events{/number}","events_url":"https://api.github.com/repos/scummvm/scummvm/events","assignees_url":"https://api.github.com/repos/scummvm/scummvm/assignees{/user}","branches_url":"https://api.github.com/repos/scummvm/scummvm/branches{/branch}","tags_url":"https://api.github.com/repos/scummvm/scummvm/tags","blobs_url":"https://api.github.com/repos/scummvm/scummvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scummvm/scummvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scummvm/scummvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/scummvm/scummvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scummvm/scummvm/statuses/{sha}","languages_url":"https://api.github.com/repos/scummvm/scummvm/languages","stargazers_url":"https://api.github.com/repos/scummvm/scummvm/stargazers","contributors_url":"https://api.github.com/repos/scummvm/scummvm/contributors","subscribers_url":"https://api.github.com/repos/scummvm/scummvm/subscribers","subscription_url":"https://api.github.com/repos/scummvm/scummvm/subscription","commits_url":"https://api.github.com/repos/scummvm/scummvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/scummvm/scummvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/scummvm/scummvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/scummvm/scummvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/scummvm/scummvm/contents/{+path}","compare_url":"https://api.github.com/repos/scummvm/scummvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scummvm/scummvm/merges","archive_url":"https://api.github.com/repos/scummvm/scummvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scummvm/scummvm/downloads","issues_url":"https://api.github.com/repos/scummvm/scummvm/issues{/number}","pulls_url":"https://api.github.com/repos/scummvm/scummvm/pulls{/number}","milestones_url":"https://api.github.com/repos/scummvm/scummvm/milestones{/number}","notifications_url":"https://api.github.com/repos/scummvm/scummvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scummvm/scummvm/labels{/name}","releases_url":"https://api.github.com/repos/scummvm/scummvm/releases{/id}","deployments_url":"https://api.github.com/repos/scummvm/scummvm/deployments","created_at":"2011-02-12T15:50:57Z","updated_at":"2016-08-10T11:47:24Z","pushed_at":"2016-08-15T18:49:23Z","git_url":"git://github.com/scummvm/scummvm.git","ssh_url":"git@github.com:scummvm/scummvm.git","clone_url":"https://github.com/scummvm/scummvm.git","svn_url":"https://github.com/scummvm/scummvm","homepage":"http://www.scummvm.org/","size":263336,"stargazers_count":637,"watchers_count":637,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":22,"forks":330,"open_issues":22,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/807"},"html":{"href":"https://github.com/scummvm/scummvm/pull/807"},"issue":{"href":"https://api.github.com/repos/scummvm/scummvm/issues/807"},"comments":{"href":"https://api.github.com/repos/scummvm/scummvm/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/scummvm/scummvm/statuses/03a5a277e03b1837417dbf5cc524d97c82b572f5"}}}}
{"actor":{"display_login":"sev-"}}