{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/87226640","pull_request_review_id":7846730,"id":87226640,"diff_hunk":"@@ -76,7 +76,11 @@ exports.callCallbacks = function(queue : UpdateQueue, context : any) {\n     if (callback && !node.callbackWasCalled) {\n       node.callbackWasCalled = true;\n       if (typeof context !== 'undefined') {\n-        callback.call(context);\n+        try {\n+          callback.call(context);\n+        } catch (error) {\n+          // do something","path":"src/renderers/shared/fiber/ReactFiberUpdateQueue.js","position":8,"original_position":8,"commit_id":"6c96bb8138faf51112e7dfbb2984deb9215e25b2","original_commit_id":"6c96bb8138faf51112e7dfbb2984deb9215e25b2","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"Could you please add actual logic to handle the error? You can look for how we do this in `ReactFiberCommitWork.js` when calling lifecycle methods.","created_at":"2016-11-09T16:27:19Z","updated_at":"2016-11-09T16:27:19Z","html_url":"https://github.com/facebook/react/pull/8242#discussion_r87226640","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/8242","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/87226640"},"html":{"href":"https://github.com/facebook/react/pull/8242#discussion_r87226640"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/8242"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8242","id":92934831,"html_url":"https://github.com/facebook/react/pull/8242","diff_url":"https://github.com/facebook/react/pull/8242.diff","patch_url":"https://github.com/facebook/react/pull/8242.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/8242","number":8242,"state":"open","locked":false,"title":"Handles risky callbacks on setState. Fixes #8238","user":{"login":"ankeetmaini","id":6652823,"avatar_url":"https://avatars.githubusercontent.com/u/6652823?v=3","gravatar_id":"","url":"https://api.github.com/users/ankeetmaini","html_url":"https://github.com/ankeetmaini","followers_url":"https://api.github.com/users/ankeetmaini/followers","following_url":"https://api.github.com/users/ankeetmaini/following{/other_user}","gists_url":"https://api.github.com/users/ankeetmaini/gists{/gist_id}","starred_url":"https://api.github.com/users/ankeetmaini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankeetmaini/subscriptions","organizations_url":"https://api.github.com/users/ankeetmaini/orgs","repos_url":"https://api.github.com/users/ankeetmaini/repos","events_url":"https://api.github.com/users/ankeetmaini/events{/privacy}","received_events_url":"https://api.github.com/users/ankeetmaini/received_events","type":"User","site_admin":false},"body":"Proposes a fix for #8238.","created_at":"2016-11-09T10:08:30Z","updated_at":"2016-11-09T16:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41e6bf107bdcec7c584099933c4f93ed836da307","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/8242/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/8242/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/8242/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/6c96bb8138faf51112e7dfbb2984deb9215e25b2","head":{"label":"ankeetmaini:handle-error-on-setstate","ref":"handle-error-on-setstate","sha":"6c96bb8138faf51112e7dfbb2984deb9215e25b2","user":{"login":"ankeetmaini","id":6652823,"avatar_url":"https://avatars.githubusercontent.com/u/6652823?v=3","gravatar_id":"","url":"https://api.github.com/users/ankeetmaini","html_url":"https://github.com/ankeetmaini","followers_url":"https://api.github.com/users/ankeetmaini/followers","following_url":"https://api.github.com/users/ankeetmaini/following{/other_user}","gists_url":"https://api.github.com/users/ankeetmaini/gists{/gist_id}","starred_url":"https://api.github.com/users/ankeetmaini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankeetmaini/subscriptions","organizations_url":"https://api.github.com/users/ankeetmaini/orgs","repos_url":"https://api.github.com/users/ankeetmaini/repos","events_url":"https://api.github.com/users/ankeetmaini/events{/privacy}","received_events_url":"https://api.github.com/users/ankeetmaini/received_events","type":"User","site_admin":false},"repo":{"id":60175025,"name":"react","full_name":"ankeetmaini/react","owner":{"login":"ankeetmaini","id":6652823,"avatar_url":"https://avatars.githubusercontent.com/u/6652823?v=3","gravatar_id":"","url":"https://api.github.com/users/ankeetmaini","html_url":"https://github.com/ankeetmaini","followers_url":"https://api.github.com/users/ankeetmaini/followers","following_url":"https://api.github.com/users/ankeetmaini/following{/other_user}","gists_url":"https://api.github.com/users/ankeetmaini/gists{/gist_id}","starred_url":"https://api.github.com/users/ankeetmaini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankeetmaini/subscriptions","organizations_url":"https://api.github.com/users/ankeetmaini/orgs","repos_url":"https://api.github.com/users/ankeetmaini/repos","events_url":"https://api.github.com/users/ankeetmaini/events{/privacy}","received_events_url":"https://api.github.com/users/ankeetmaini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ankeetmaini/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/ankeetmaini/react","forks_url":"https://api.github.com/repos/ankeetmaini/react/forks","keys_url":"https://api.github.com/repos/ankeetmaini/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ankeetmaini/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ankeetmaini/react/teams","hooks_url":"https://api.github.com/repos/ankeetmaini/react/hooks","issue_events_url":"https://api.github.com/repos/ankeetmaini/react/issues/events{/number}","events_url":"https://api.github.com/repos/ankeetmaini/react/events","assignees_url":"https://api.github.com/repos/ankeetmaini/react/assignees{/user}","branches_url":"https://api.github.com/repos/ankeetmaini/react/branches{/branch}","tags_url":"https://api.github.com/repos/ankeetmaini/react/tags","blobs_url":"https://api.github.com/repos/ankeetmaini/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ankeetmaini/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ankeetmaini/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/ankeetmaini/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ankeetmaini/react/statuses/{sha}","languages_url":"https://api.github.com/repos/ankeetmaini/react/languages","stargazers_url":"https://api.github.com/repos/ankeetmaini/react/stargazers","contributors_url":"https://api.github.com/repos/ankeetmaini/react/contributors","subscribers_url":"https://api.github.com/repos/ankeetmaini/react/subscribers","subscription_url":"https://api.github.com/repos/ankeetmaini/react/subscription","commits_url":"https://api.github.com/repos/ankeetmaini/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/ankeetmaini/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/ankeetmaini/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/ankeetmaini/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/ankeetmaini/react/contents/{+path}","compare_url":"https://api.github.com/repos/ankeetmaini/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ankeetmaini/react/merges","archive_url":"https://api.github.com/repos/ankeetmaini/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ankeetmaini/react/downloads","issues_url":"https://api.github.com/repos/ankeetmaini/react/issues{/number}","pulls_url":"https://api.github.com/repos/ankeetmaini/react/pulls{/number}","milestones_url":"https://api.github.com/repos/ankeetmaini/react/milestones{/number}","notifications_url":"https://api.github.com/repos/ankeetmaini/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ankeetmaini/react/labels{/name}","releases_url":"https://api.github.com/repos/ankeetmaini/react/releases{/id}","deployments_url":"https://api.github.com/repos/ankeetmaini/react/deployments","created_at":"2016-06-01T12:28:26Z","updated_at":"2016-06-01T12:28:31Z","pushed_at":"2016-11-09T10:07:42Z","git_url":"git://github.com/ankeetmaini/react.git","ssh_url":"git@github.com:ankeetmaini/react.git","clone_url":"https://github.com/ankeetmaini/react.git","svn_url":"https://github.com/ankeetmaini/react","homepage":"https://facebook.github.io/react/","size":98711,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"84b8bbdfc9d47c82f3facc4e37d58463b5b54078","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2016-11-09T15:09:26Z","pushed_at":"2016-11-09T12:32:32Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":144012,"stargazers_count":53581,"watchers_count":53581,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9489,"mirror_url":null,"open_issues_count":594,"forks":9489,"open_issues":594,"watchers":53581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/8242"},"html":{"href":"https://github.com/facebook/react/pull/8242"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/8242"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/8242/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/8242/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/8242/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/6c96bb8138faf51112e7dfbb2984deb9215e25b2"}}}}
{"actor":{"display_login":"gaearon"}}