{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/70698563","id":70698563,"diff_hunk":"@@ -6474,7 +6474,7 @@ void CodeGen::genJmpMethod(GenTreePtr jmp)\n             }\n         }\n \n-#if FEATURE_VARARG\n+#if FEATURE_VARARG && defined(_TARGET_AMD64_)","path":"src/jit/codegenxarch.cpp","position":5,"original_position":5,"commit_id":"10ef7db1bcf00d3b20f1d77009d4ae7e559053ef","original_commit_id":"10ef7db1bcf00d3b20f1d77009d4ae7e559053ef","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"body":"The logic in 6380-6386 is ok for x86; it does no harm. In Compiler::lvaPromoteStructVar(), when we promote a struct, only for amd64/arm64 will a lvIsRegArg struct have its promoted fields marked as lvIsRegArg=true. But for x86, the struct itself is never marked lvIsRegArg even through it can be promoted (with a single field). So in this code we can load the promoted field varDsc, but we'll immediately \"continue\".","created_at":"2016-07-13T20:07:43Z","updated_at":"2016-07-13T20:07:43Z","html_url":"https://github.com/dotnet/coreclr/pull/6224#discussion_r70698563","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6224","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/70698563"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6224#discussion_r70698563"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6224"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6224","id":77041804,"html_url":"https://github.com/dotnet/coreclr/pull/6224","diff_url":"https://github.com/dotnet/coreclr/pull/6224.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6224.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6224","number":6224,"state":"open","locked":false,"title":"Fix #4177: RyuJIT/x86 NYI related to lvaArgType()","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"body":"For x86, this function can simply return the variable type. There is\r\nno need to map struct types. The function actually will never be\r\ncalled on x86 for struct types because it is only called for register\r\narguments.\r\n\r\nThis NYI was only hit in the case of JMP calls. I fixed two cases\r\nin the JMP implementation where FEATURE_VARARGS code assumed AMD64, due\r\nto the Windows AMD64 ABI convention to pass float varargs values in both\r\ninteger and floating point registers. I put that under `#ifdef _TARGET_AMD64_`.\r\n\r\nThis removes 426 NYI.\r\n\r\n@adiaaida @briansull PTAL\r\ncc @dotnet/jit-contrib ","created_at":"2016-07-11T23:51:24Z","updated_at":"2016-07-13T20:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9e2a8d23794507e6fd4b19d7b8fc3ba3cd61b0f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6224/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6224/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6224/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/10ef7db1bcf00d3b20f1d77009d4ae7e559053ef","head":{"label":"BruceForstall:Fix4177","ref":"Fix4177","sha":"10ef7db1bcf00d3b20f1d77009d4ae7e559053ef","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"repo":{"id":30471921,"name":"coreclr","full_name":"BruceForstall/coreclr","owner":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BruceForstall/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/BruceForstall/coreclr","forks_url":"https://api.github.com/repos/BruceForstall/coreclr/forks","keys_url":"https://api.github.com/repos/BruceForstall/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BruceForstall/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BruceForstall/coreclr/teams","hooks_url":"https://api.github.com/repos/BruceForstall/coreclr/hooks","issue_events_url":"https://api.github.com/repos/BruceForstall/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/BruceForstall/coreclr/events","assignees_url":"https://api.github.com/repos/BruceForstall/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/BruceForstall/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/BruceForstall/coreclr/tags","blobs_url":"https://api.github.com/repos/BruceForstall/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BruceForstall/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BruceForstall/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/BruceForstall/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BruceForstall/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/BruceForstall/coreclr/languages","stargazers_url":"https://api.github.com/repos/BruceForstall/coreclr/stargazers","contributors_url":"https://api.github.com/repos/BruceForstall/coreclr/contributors","subscribers_url":"https://api.github.com/repos/BruceForstall/coreclr/subscribers","subscription_url":"https://api.github.com/repos/BruceForstall/coreclr/subscription","commits_url":"https://api.github.com/repos/BruceForstall/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/BruceForstall/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/BruceForstall/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/BruceForstall/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/BruceForstall/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/BruceForstall/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BruceForstall/coreclr/merges","archive_url":"https://api.github.com/repos/BruceForstall/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BruceForstall/coreclr/downloads","issues_url":"https://api.github.com/repos/BruceForstall/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/BruceForstall/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/BruceForstall/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/BruceForstall/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BruceForstall/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/BruceForstall/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/BruceForstall/coreclr/deployments","created_at":"2015-02-07T22:04:54Z","updated_at":"2016-01-11T21:50:16Z","pushed_at":"2016-07-13T07:07:43Z","git_url":"git://github.com/BruceForstall/coreclr.git","ssh_url":"git@github.com:BruceForstall/coreclr.git","clone_url":"https://github.com/BruceForstall/coreclr.git","svn_url":"https://github.com/BruceForstall/coreclr","homepage":"","size":91618,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0804d53c08804928e3b92e3c50b284453dab4944","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-07-13T17:21:33Z","pushed_at":"2016-07-13T19:25:13Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://dotnet.github.io/","size":100776,"stargazers_count":6676,"watchers_count":6676,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1541,"mirror_url":null,"open_issues_count":893,"forks":1541,"open_issues":893,"watchers":6676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6224"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6224"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6224"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6224/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6224/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6224/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/10ef7db1bcf00d3b20f1d77009d4ae7e559053ef"}}}}
{"actor":{"display_login":"BruceForstall"}}