{"action":"created","issue":{"url":"https://api.github.com/repos/conventional-changelog/git-raw-commits/issues/11","repository_url":"https://api.github.com/repos/conventional-changelog/git-raw-commits","labels_url":"https://api.github.com/repos/conventional-changelog/git-raw-commits/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/conventional-changelog/git-raw-commits/issues/11/comments","events_url":"https://api.github.com/repos/conventional-changelog/git-raw-commits/issues/11/events","html_url":"https://github.com/conventional-changelog/git-raw-commits/pull/11","id":162336029,"number":11,"title":"fix(windows): use execFile for executing git","user":{"login":"Tapppi","id":3275280,"avatar_url":"https://avatars.githubusercontent.com/u/3275280?v=3","gravatar_id":"","url":"https://api.github.com/users/Tapppi","html_url":"https://github.com/Tapppi","followers_url":"https://api.github.com/users/Tapppi/followers","following_url":"https://api.github.com/users/Tapppi/following{/other_user}","gists_url":"https://api.github.com/users/Tapppi/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapppi/subscriptions","organizations_url":"https://api.github.com/users/Tapppi/orgs","repos_url":"https://api.github.com/users/Tapppi/repos","events_url":"https://api.github.com/users/Tapppi/events{/privacy}","received_events_url":"https://api.github.com/users/Tapppi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-26T16:44:35Z","updated_at":"2016-06-26T23:12:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conventional-changelog/git-raw-commits/pulls/11","html_url":"https://github.com/conventional-changelog/git-raw-commits/pull/11","diff_url":"https://github.com/conventional-changelog/git-raw-commits/pull/11.diff","patch_url":"https://github.com/conventional-changelog/git-raw-commits/pull/11.patch"},"body":"Fix problems with variable expansion and escaping by passing arguments straight to git with execFile instead of going through a shell to execute it.\r\n\r\nSo unfortunately the last fix didn't work.. This fix is much better anyways. It uses `child_process.execFile` instead of `exec` to directly pass arguments to the `git` executable. This way the arguments never pass through `cmd` or `shell` and variable expansion becomes a non-problem. There's also a test for the windows variable expansion included. [Tests pass with this fix.](https://ci.appveyor.com/project/Tapppi/git-raw-commits/build/job/eifv2grubbkv7dv2)\r\n\r\n[Stack overflow question describing the problem and a good answer that led to this fix](http://stackoverflow.com/questions/33016094/is-there-a-way-to-prevent-percent-expansion-of-env-variable-in-windows-command-l)\r\n"},"comment":{"url":"https://api.github.com/repos/conventional-changelog/git-raw-commits/issues/comments/228628927","html_url":"https://github.com/conventional-changelog/git-raw-commits/pull/11#issuecomment-228628927","issue_url":"https://api.github.com/repos/conventional-changelog/git-raw-commits/issues/11","id":228628927,"user":{"login":"stevemao","id":6316590,"avatar_url":"https://avatars.githubusercontent.com/u/6316590?v=3","gravatar_id":"","url":"https://api.github.com/users/stevemao","html_url":"https://github.com/stevemao","followers_url":"https://api.github.com/users/stevemao/followers","following_url":"https://api.github.com/users/stevemao/following{/other_user}","gists_url":"https://api.github.com/users/stevemao/gists{/gist_id}","starred_url":"https://api.github.com/users/stevemao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevemao/subscriptions","organizations_url":"https://api.github.com/users/stevemao/orgs","repos_url":"https://api.github.com/users/stevemao/repos","events_url":"https://api.github.com/users/stevemao/events{/privacy}","received_events_url":"https://api.github.com/users/stevemao/received_events","type":"User","site_admin":false},"created_at":"2016-06-26T23:12:44Z","updated_at":"2016-06-26T23:12:44Z","body":"> So unfortunately the last fix didn't work.. \r\n\r\nThe tests passed after your last fix. Why is that?"}}
{"actor":{"display_login":"stevemao"}}