{"action":"created","comment":{"url":"https://api.github.com/repos/druids/django-chamber/pulls/comments/55991895","id":55991895,"diff_hunk":"@@ -30,17 +29,22 @@ class Options(object):\n     def __init__(self, model):\n         self.model = model\n \n-        self.clean_before_save = True\n-        self.clean_after_save = False\n+        self.clean_pre_save = True","path":"chamber/models/__init__.py","position":16,"original_position":16,"commit_id":"dac78f65d16afb8aab930a9e1759fd6a94e712d8","original_commit_id":"dac78f65d16afb8aab930a9e1759fd6a94e712d8","user":{"login":"ondrejSkowronek","id":8625747,"avatar_url":"https://avatars.githubusercontent.com/u/8625747?v=3","gravatar_id":"","url":"https://api.github.com/users/ondrejSkowronek","html_url":"https://github.com/ondrejSkowronek","followers_url":"https://api.github.com/users/ondrejSkowronek/followers","following_url":"https://api.github.com/users/ondrejSkowronek/following{/other_user}","gists_url":"https://api.github.com/users/ondrejSkowronek/gists{/gist_id}","starred_url":"https://api.github.com/users/ondrejSkowronek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ondrejSkowronek/subscriptions","organizations_url":"https://api.github.com/users/ondrejSkowronek/orgs","repos_url":"https://api.github.com/users/ondrejSkowronek/repos","events_url":"https://api.github.com/users/ondrejSkowronek/events{/privacy}","received_events_url":"https://api.github.com/users/ondrejSkowronek/received_events","type":"User","site_admin":false},"body":"i dont like a fact that clean_pre_save is flag and _clean_pre_save is function. Can't you rename clean_pre_save to something like is_clean_pre_save or is_clean_pre_save_enabled?","created_at":"2016-03-14T12:22:58Z","updated_at":"2016-03-14T12:22:58Z","html_url":"https://github.com/druids/django-chamber/pull/9#discussion_r55991895","pull_request_url":"https://api.github.com/repos/druids/django-chamber/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/druids/django-chamber/pulls/comments/55991895"},"html":{"href":"https://github.com/druids/django-chamber/pull/9#discussion_r55991895"},"pull_request":{"href":"https://api.github.com/repos/druids/django-chamber/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/druids/django-chamber/pulls/9","id":62654613,"html_url":"https://github.com/druids/django-chamber/pull/9","diff_url":"https://github.com/druids/django-chamber/pull/9.diff","patch_url":"https://github.com/druids/django-chamber/pull/9.patch","issue_url":"https://api.github.com/repos/druids/django-chamber/issues/9","number":9,"state":"open","locked":false,"title":"Improved smart model methods and meta","user":{"login":"matllubos","id":424409,"avatar_url":"https://avatars.githubusercontent.com/u/424409?v=3","gravatar_id":"","url":"https://api.github.com/users/matllubos","html_url":"https://github.com/matllubos","followers_url":"https://api.github.com/users/matllubos/followers","following_url":"https://api.github.com/users/matllubos/following{/other_user}","gists_url":"https://api.github.com/users/matllubos/gists{/gist_id}","starred_url":"https://api.github.com/users/matllubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matllubos/subscriptions","organizations_url":"https://api.github.com/users/matllubos/orgs","repos_url":"https://api.github.com/users/matllubos/repos","events_url":"https://api.github.com/users/matllubos/events{/privacy}","received_events_url":"https://api.github.com/users/matllubos/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-12T22:36:38Z","updated_at":"2016-03-14T12:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ed1bf06e0348649488786b68b0264ff9c936763","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druids/django-chamber/pulls/9/commits","review_comments_url":"https://api.github.com/repos/druids/django-chamber/pulls/9/comments","review_comment_url":"https://api.github.com/repos/druids/django-chamber/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druids/django-chamber/issues/9/comments","statuses_url":"https://api.github.com/repos/druids/django-chamber/statuses/dac78f65d16afb8aab930a9e1759fd6a94e712d8","head":{"label":"matllubos:ImprovedSmartModel","ref":"ImprovedSmartModel","sha":"dac78f65d16afb8aab930a9e1759fd6a94e712d8","user":{"login":"matllubos","id":424409,"avatar_url":"https://avatars.githubusercontent.com/u/424409?v=3","gravatar_id":"","url":"https://api.github.com/users/matllubos","html_url":"https://github.com/matllubos","followers_url":"https://api.github.com/users/matllubos/followers","following_url":"https://api.github.com/users/matllubos/following{/other_user}","gists_url":"https://api.github.com/users/matllubos/gists{/gist_id}","starred_url":"https://api.github.com/users/matllubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matllubos/subscriptions","organizations_url":"https://api.github.com/users/matllubos/orgs","repos_url":"https://api.github.com/users/matllubos/repos","events_url":"https://api.github.com/users/matllubos/events{/privacy}","received_events_url":"https://api.github.com/users/matllubos/received_events","type":"User","site_admin":false},"repo":{"id":53756569,"name":"django-chamber","full_name":"matllubos/django-chamber","owner":{"login":"matllubos","id":424409,"avatar_url":"https://avatars.githubusercontent.com/u/424409?v=3","gravatar_id":"","url":"https://api.github.com/users/matllubos","html_url":"https://github.com/matllubos","followers_url":"https://api.github.com/users/matllubos/followers","following_url":"https://api.github.com/users/matllubos/following{/other_user}","gists_url":"https://api.github.com/users/matllubos/gists{/gist_id}","starred_url":"https://api.github.com/users/matllubos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matllubos/subscriptions","organizations_url":"https://api.github.com/users/matllubos/orgs","repos_url":"https://api.github.com/users/matllubos/repos","events_url":"https://api.github.com/users/matllubos/events{/privacy}","received_events_url":"https://api.github.com/users/matllubos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matllubos/django-chamber","description":"Utilities library meant as a complement to django-is-core","fork":true,"url":"https://api.github.com/repos/matllubos/django-chamber","forks_url":"https://api.github.com/repos/matllubos/django-chamber/forks","keys_url":"https://api.github.com/repos/matllubos/django-chamber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matllubos/django-chamber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matllubos/django-chamber/teams","hooks_url":"https://api.github.com/repos/matllubos/django-chamber/hooks","issue_events_url":"https://api.github.com/repos/matllubos/django-chamber/issues/events{/number}","events_url":"https://api.github.com/repos/matllubos/django-chamber/events","assignees_url":"https://api.github.com/repos/matllubos/django-chamber/assignees{/user}","branches_url":"https://api.github.com/repos/matllubos/django-chamber/branches{/branch}","tags_url":"https://api.github.com/repos/matllubos/django-chamber/tags","blobs_url":"https://api.github.com/repos/matllubos/django-chamber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matllubos/django-chamber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matllubos/django-chamber/git/refs{/sha}","trees_url":"https://api.github.com/repos/matllubos/django-chamber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matllubos/django-chamber/statuses/{sha}","languages_url":"https://api.github.com/repos/matllubos/django-chamber/languages","stargazers_url":"https://api.github.com/repos/matllubos/django-chamber/stargazers","contributors_url":"https://api.github.com/repos/matllubos/django-chamber/contributors","subscribers_url":"https://api.github.com/repos/matllubos/django-chamber/subscribers","subscription_url":"https://api.github.com/repos/matllubos/django-chamber/subscription","commits_url":"https://api.github.com/repos/matllubos/django-chamber/commits{/sha}","git_commits_url":"https://api.github.com/repos/matllubos/django-chamber/git/commits{/sha}","comments_url":"https://api.github.com/repos/matllubos/django-chamber/comments{/number}","issue_comment_url":"https://api.github.com/repos/matllubos/django-chamber/issues/comments{/number}","contents_url":"https://api.github.com/repos/matllubos/django-chamber/contents/{+path}","compare_url":"https://api.github.com/repos/matllubos/django-chamber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matllubos/django-chamber/merges","archive_url":"https://api.github.com/repos/matllubos/django-chamber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matllubos/django-chamber/downloads","issues_url":"https://api.github.com/repos/matllubos/django-chamber/issues{/number}","pulls_url":"https://api.github.com/repos/matllubos/django-chamber/pulls{/number}","milestones_url":"https://api.github.com/repos/matllubos/django-chamber/milestones{/number}","notifications_url":"https://api.github.com/repos/matllubos/django-chamber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matllubos/django-chamber/labels{/name}","releases_url":"https://api.github.com/repos/matllubos/django-chamber/releases{/id}","deployments_url":"https://api.github.com/repos/matllubos/django-chamber/deployments","created_at":"2016-03-12T22:35:18Z","updated_at":"2016-03-12T22:35:19Z","pushed_at":"2016-03-12T22:35:50Z","git_url":"git://github.com/matllubos/django-chamber.git","ssh_url":"git@github.com:matllubos/django-chamber.git","clone_url":"https://github.com/matllubos/django-chamber.git","svn_url":"https://github.com/matllubos/django-chamber","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druids:v0.1","ref":"v0.1","sha":"61973e451c7ffb6b113f96bdc3b55af7aa25fdc2","user":{"login":"druids","id":16963627,"avatar_url":"https://avatars.githubusercontent.com/u/16963627?v=3","gravatar_id":"","url":"https://api.github.com/users/druids","html_url":"https://github.com/druids","followers_url":"https://api.github.com/users/druids/followers","following_url":"https://api.github.com/users/druids/following{/other_user}","gists_url":"https://api.github.com/users/druids/gists{/gist_id}","starred_url":"https://api.github.com/users/druids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druids/subscriptions","organizations_url":"https://api.github.com/users/druids/orgs","repos_url":"https://api.github.com/users/druids/repos","events_url":"https://api.github.com/users/druids/events{/privacy}","received_events_url":"https://api.github.com/users/druids/received_events","type":"Organization","site_admin":false},"repo":{"id":28164795,"name":"django-chamber","full_name":"druids/django-chamber","owner":{"login":"druids","id":16963627,"avatar_url":"https://avatars.githubusercontent.com/u/16963627?v=3","gravatar_id":"","url":"https://api.github.com/users/druids","html_url":"https://github.com/druids","followers_url":"https://api.github.com/users/druids/followers","following_url":"https://api.github.com/users/druids/following{/other_user}","gists_url":"https://api.github.com/users/druids/gists{/gist_id}","starred_url":"https://api.github.com/users/druids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druids/subscriptions","organizations_url":"https://api.github.com/users/druids/orgs","repos_url":"https://api.github.com/users/druids/repos","events_url":"https://api.github.com/users/druids/events{/privacy}","received_events_url":"https://api.github.com/users/druids/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druids/django-chamber","description":"Utilities library meant as a complement to django-is-core","fork":true,"url":"https://api.github.com/repos/druids/django-chamber","forks_url":"https://api.github.com/repos/druids/django-chamber/forks","keys_url":"https://api.github.com/repos/druids/django-chamber/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druids/django-chamber/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druids/django-chamber/teams","hooks_url":"https://api.github.com/repos/druids/django-chamber/hooks","issue_events_url":"https://api.github.com/repos/druids/django-chamber/issues/events{/number}","events_url":"https://api.github.com/repos/druids/django-chamber/events","assignees_url":"https://api.github.com/repos/druids/django-chamber/assignees{/user}","branches_url":"https://api.github.com/repos/druids/django-chamber/branches{/branch}","tags_url":"https://api.github.com/repos/druids/django-chamber/tags","blobs_url":"https://api.github.com/repos/druids/django-chamber/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druids/django-chamber/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druids/django-chamber/git/refs{/sha}","trees_url":"https://api.github.com/repos/druids/django-chamber/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druids/django-chamber/statuses/{sha}","languages_url":"https://api.github.com/repos/druids/django-chamber/languages","stargazers_url":"https://api.github.com/repos/druids/django-chamber/stargazers","contributors_url":"https://api.github.com/repos/druids/django-chamber/contributors","subscribers_url":"https://api.github.com/repos/druids/django-chamber/subscribers","subscription_url":"https://api.github.com/repos/druids/django-chamber/subscription","commits_url":"https://api.github.com/repos/druids/django-chamber/commits{/sha}","git_commits_url":"https://api.github.com/repos/druids/django-chamber/git/commits{/sha}","comments_url":"https://api.github.com/repos/druids/django-chamber/comments{/number}","issue_comment_url":"https://api.github.com/repos/druids/django-chamber/issues/comments{/number}","contents_url":"https://api.github.com/repos/druids/django-chamber/contents/{+path}","compare_url":"https://api.github.com/repos/druids/django-chamber/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druids/django-chamber/merges","archive_url":"https://api.github.com/repos/druids/django-chamber/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druids/django-chamber/downloads","issues_url":"https://api.github.com/repos/druids/django-chamber/issues{/number}","pulls_url":"https://api.github.com/repos/druids/django-chamber/pulls{/number}","milestones_url":"https://api.github.com/repos/druids/django-chamber/milestones{/number}","notifications_url":"https://api.github.com/repos/druids/django-chamber/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druids/django-chamber/labels{/name}","releases_url":"https://api.github.com/repos/druids/django-chamber/releases{/id}","deployments_url":"https://api.github.com/repos/druids/django-chamber/deployments","created_at":"2014-12-18T02:21:20Z","updated_at":"2016-03-06T17:14:39Z","pushed_at":"2016-03-12T22:36:39Z","git_url":"git://github.com/druids/django-chamber.git","ssh_url":"git@github.com:druids/django-chamber.git","clone_url":"https://github.com/druids/django-chamber.git","svn_url":"https://github.com/druids/django-chamber","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druids/django-chamber/pulls/9"},"html":{"href":"https://github.com/druids/django-chamber/pull/9"},"issue":{"href":"https://api.github.com/repos/druids/django-chamber/issues/9"},"comments":{"href":"https://api.github.com/repos/druids/django-chamber/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/druids/django-chamber/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/druids/django-chamber/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druids/django-chamber/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/druids/django-chamber/statuses/dac78f65d16afb8aab930a9e1759fd6a94e712d8"}}}}