{"action":"created","comment":{"url":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/comments/93206988","pull_request_review_id":13728062,"id":93206988,"diff_hunk":"@@ -83,13 +83,13 @@ I also make available special images and instructions for [AWS EC2](https://gith\n \n This image can be configured by means of environment variables, that one can set on a `Deployment`.\n \n-* [CLUSTER_NAME](https://www.elastic.co/guide/en/elasticsearch/reference/current/setup-configuration.html#cluster-name)\n-* [NODE_MASTER](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.html#master-node)\n-* [NODE_DATA](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.html#data-node)\n-* [NETWORK_HOST](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-network.html#common-network-settings)\n-* [HTTP_ENABLE](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-http.html#_settings_2)\n-* [HTTP_CORS_ENABLE](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-http.html#_settings_2)\n-* [HTTP_CORS_ALLOW_ORIGIN](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-http.html#_settings_2)\n-* [NUMBER_OF_MASTERS](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-discovery-zen.html#master-election)\n-* [MAX_LOCAL_STORAGE_NODES](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.html#max-local-storage-nodes)","path":"README.md","position":12,"original_position":12,"commit_id":"d45b67954f3d9cf7533a032d2e34fd93b85c34bf","original_commit_id":"d45b67954f3d9cf7533a032d2e34fd93b85c34bf","user":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"body":"This works, please remove change.","created_at":"2016-12-20T10:15:33Z","updated_at":"2016-12-20T10:16:27Z","html_url":"https://github.com/pires/docker-elasticsearch/pull/26#discussion_r93206988","pull_request_url":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/comments/93206988"},"html":{"href":"https://github.com/pires/docker-elasticsearch/pull/26#discussion_r93206988"},"pull_request":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26","id":98471728,"html_url":"https://github.com/pires/docker-elasticsearch/pull/26","diff_url":"https://github.com/pires/docker-elasticsearch/pull/26.diff","patch_url":"https://github.com/pires/docker-elasticsearch/pull/26.patch","issue_url":"https://api.github.com/repos/pires/docker-elasticsearch/issues/26","number":26,"state":"open","locked":false,"title":"Environment Variable references changed","user":{"login":"so0k","id":1762599,"avatar_url":"https://avatars.githubusercontent.com/u/1762599?v=3","gravatar_id":"","url":"https://api.github.com/users/so0k","html_url":"https://github.com/so0k","followers_url":"https://api.github.com/users/so0k/followers","following_url":"https://api.github.com/users/so0k/following{/other_user}","gists_url":"https://api.github.com/users/so0k/gists{/gist_id}","starred_url":"https://api.github.com/users/so0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/so0k/subscriptions","organizations_url":"https://api.github.com/users/so0k/orgs","repos_url":"https://api.github.com/users/so0k/repos","events_url":"https://api.github.com/users/so0k/events{/privacy}","received_events_url":"https://api.github.com/users/so0k/received_events","type":"User","site_admin":false},"body":"from version 5 onwards, the documentation has moved.\r\n\r\nI've updated the first link to the location of the parameter for version 5\r\n\r\nI've updated the other links to the latest version for which the links were valid. \r\n\r\nPlease advice what you would prefer to do","created_at":"2016-12-18T11:30:40Z","updated_at":"2016-12-20T10:16:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77f08af59d8c5ba067367cece8acfbec0a781b54","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26/commits","review_comments_url":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26/comments","review_comment_url":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pires/docker-elasticsearch/issues/26/comments","statuses_url":"https://api.github.com/repos/pires/docker-elasticsearch/statuses/d45b67954f3d9cf7533a032d2e34fd93b85c34bf","head":{"label":"so0k:patch-1","ref":"patch-1","sha":"d45b67954f3d9cf7533a032d2e34fd93b85c34bf","user":{"login":"so0k","id":1762599,"avatar_url":"https://avatars.githubusercontent.com/u/1762599?v=3","gravatar_id":"","url":"https://api.github.com/users/so0k","html_url":"https://github.com/so0k","followers_url":"https://api.github.com/users/so0k/followers","following_url":"https://api.github.com/users/so0k/following{/other_user}","gists_url":"https://api.github.com/users/so0k/gists{/gist_id}","starred_url":"https://api.github.com/users/so0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/so0k/subscriptions","organizations_url":"https://api.github.com/users/so0k/orgs","repos_url":"https://api.github.com/users/so0k/repos","events_url":"https://api.github.com/users/so0k/events{/privacy}","received_events_url":"https://api.github.com/users/so0k/received_events","type":"User","site_admin":false},"repo":{"id":76778705,"name":"docker-elasticsearch","full_name":"so0k/docker-elasticsearch","owner":{"login":"so0k","id":1762599,"avatar_url":"https://avatars.githubusercontent.com/u/1762599?v=3","gravatar_id":"","url":"https://api.github.com/users/so0k","html_url":"https://github.com/so0k","followers_url":"https://api.github.com/users/so0k/followers","following_url":"https://api.github.com/users/so0k/following{/other_user}","gists_url":"https://api.github.com/users/so0k/gists{/gist_id}","starred_url":"https://api.github.com/users/so0k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/so0k/subscriptions","organizations_url":"https://api.github.com/users/so0k/orgs","repos_url":"https://api.github.com/users/so0k/repos","events_url":"https://api.github.com/users/so0k/events{/privacy}","received_events_url":"https://api.github.com/users/so0k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/so0k/docker-elasticsearch","description":"Dockerfile for a base Elasticsearch image to be extended by others (allow to install plug-ins, change configuration, etc.)","fork":true,"url":"https://api.github.com/repos/so0k/docker-elasticsearch","forks_url":"https://api.github.com/repos/so0k/docker-elasticsearch/forks","keys_url":"https://api.github.com/repos/so0k/docker-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/so0k/docker-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/so0k/docker-elasticsearch/teams","hooks_url":"https://api.github.com/repos/so0k/docker-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/so0k/docker-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/so0k/docker-elasticsearch/events","assignees_url":"https://api.github.com/repos/so0k/docker-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/so0k/docker-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/so0k/docker-elasticsearch/tags","blobs_url":"https://api.github.com/repos/so0k/docker-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/so0k/docker-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/so0k/docker-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/so0k/docker-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/so0k/docker-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/so0k/docker-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/so0k/docker-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/so0k/docker-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/so0k/docker-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/so0k/docker-elasticsearch/subscription","commits_url":"https://api.github.com/repos/so0k/docker-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/so0k/docker-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/so0k/docker-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/so0k/docker-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/so0k/docker-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/so0k/docker-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/so0k/docker-elasticsearch/merges","archive_url":"https://api.github.com/repos/so0k/docker-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/so0k/docker-elasticsearch/downloads","issues_url":"https://api.github.com/repos/so0k/docker-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/so0k/docker-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/so0k/docker-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/so0k/docker-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/so0k/docker-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/so0k/docker-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/so0k/docker-elasticsearch/deployments","created_at":"2016-12-18T11:24:05Z","updated_at":"2016-12-18T11:24:06Z","pushed_at":"2016-12-18T11:33:40Z","git_url":"git://github.com/so0k/docker-elasticsearch.git","ssh_url":"git@github.com:so0k/docker-elasticsearch.git","clone_url":"https://github.com/so0k/docker-elasticsearch.git","svn_url":"https://github.com/so0k/docker-elasticsearch","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pires:master","ref":"master","sha":"18efc48e086637186f50a2908c9f2b9018ae578d","user":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"repo":{"id":32923692,"name":"docker-elasticsearch","full_name":"pires/docker-elasticsearch","owner":{"login":"pires","id":1752631,"avatar_url":"https://avatars.githubusercontent.com/u/1752631?v=3","gravatar_id":"","url":"https://api.github.com/users/pires","html_url":"https://github.com/pires","followers_url":"https://api.github.com/users/pires/followers","following_url":"https://api.github.com/users/pires/following{/other_user}","gists_url":"https://api.github.com/users/pires/gists{/gist_id}","starred_url":"https://api.github.com/users/pires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pires/subscriptions","organizations_url":"https://api.github.com/users/pires/orgs","repos_url":"https://api.github.com/users/pires/repos","events_url":"https://api.github.com/users/pires/events{/privacy}","received_events_url":"https://api.github.com/users/pires/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pires/docker-elasticsearch","description":"Dockerfile for a base Elasticsearch image to be extended by others (allow to install plug-ins, change configuration, etc.)","fork":false,"url":"https://api.github.com/repos/pires/docker-elasticsearch","forks_url":"https://api.github.com/repos/pires/docker-elasticsearch/forks","keys_url":"https://api.github.com/repos/pires/docker-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pires/docker-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pires/docker-elasticsearch/teams","hooks_url":"https://api.github.com/repos/pires/docker-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/pires/docker-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/pires/docker-elasticsearch/events","assignees_url":"https://api.github.com/repos/pires/docker-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/pires/docker-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/pires/docker-elasticsearch/tags","blobs_url":"https://api.github.com/repos/pires/docker-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pires/docker-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pires/docker-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pires/docker-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pires/docker-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/pires/docker-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/pires/docker-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/pires/docker-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/pires/docker-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/pires/docker-elasticsearch/subscription","commits_url":"https://api.github.com/repos/pires/docker-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pires/docker-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pires/docker-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pires/docker-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pires/docker-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/pires/docker-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pires/docker-elasticsearch/merges","archive_url":"https://api.github.com/repos/pires/docker-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pires/docker-elasticsearch/downloads","issues_url":"https://api.github.com/repos/pires/docker-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/pires/docker-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/pires/docker-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/pires/docker-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pires/docker-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/pires/docker-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/pires/docker-elasticsearch/deployments","created_at":"2015-03-26T11:34:01Z","updated_at":"2016-12-19T17:16:54Z","pushed_at":"2016-12-18T11:33:40Z","git_url":"git://github.com/pires/docker-elasticsearch.git","ssh_url":"git@github.com:pires/docker-elasticsearch.git","clone_url":"https://github.com/pires/docker-elasticsearch.git","svn_url":"https://github.com/pires/docker-elasticsearch","homepage":null,"size":57,"stargazers_count":28,"watchers_count":28,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":1,"forks":31,"open_issues":1,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26"},"html":{"href":"https://github.com/pires/docker-elasticsearch/pull/26"},"issue":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/issues/26"},"comments":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/pires/docker-elasticsearch/statuses/d45b67954f3d9cf7533a032d2e34fd93b85c34bf"}}}}
{"actor":{"display_login":"pires"}}