{"action":"created","issue":{"url":"https://api.github.com/repos/fabric8io/kubeflix/issues/78","repository_url":"https://api.github.com/repos/fabric8io/kubeflix","labels_url":"https://api.github.com/repos/fabric8io/kubeflix/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/fabric8io/kubeflix/issues/78/comments","events_url":"https://api.github.com/repos/fabric8io/kubeflix/issues/78/events","html_url":"https://github.com/fabric8io/kubeflix/issues/78","id":148906772,"number":78,"title":"improvement to the pod selection logic","user":{"login":"raffaelespazzoli","id":6179036,"avatar_url":"https://avatars.githubusercontent.com/u/6179036?v=3","gravatar_id":"","url":"https://api.github.com/users/raffaelespazzoli","html_url":"https://github.com/raffaelespazzoli","followers_url":"https://api.github.com/users/raffaelespazzoli/followers","following_url":"https://api.github.com/users/raffaelespazzoli/following{/other_user}","gists_url":"https://api.github.com/users/raffaelespazzoli/gists{/gist_id}","starred_url":"https://api.github.com/users/raffaelespazzoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffaelespazzoli/subscriptions","organizations_url":"https://api.github.com/users/raffaelespazzoli/orgs","repos_url":"https://api.github.com/users/raffaelespazzoli/repos","events_url":"https://api.github.com/users/raffaelespazzoli/events{/privacy}","received_events_url":"https://api.github.com/users/raffaelespazzoli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-17T00:40:47Z","updated_at":"2016-05-06T14:38:09Z","closed_at":null,"body":"Hi, currently it is assumed that the pods that are hystrix stream sources will have the ``hystrix.enabled`` label.\r\nThis may impose unnecessary constraints on the source pods. There could also be situations where multiple turbine serves need to be run in the same kubernetes cluster and there would be no way to specify which pods each turbine server should connect to.\r\nI'd like to propose the following improvements:\r\n1. ability to specify a selector (as in Kubernetes' pod selector) to select the hystrix source pods. We can still default to ``hystrix.enabled`` if no selector is specified. A selector can match on multiple labels.\r\n2. ability to specify an hystrix cluster for the defined selector. If no cluster is specified that the cluster name could be the pod name (probably more discussion needed here).\r\n3. ability to specify multiple selectors. With this multiple groups of pods would be selected and would report to the same turbine server.\r\n4. ability to specify a different URL suffix for each selector.\r\n\r\nI should be able to provide 1 and 2 based on my previous project.\r\n3 is not urgent for me and my current endeavor but I think it would be useful in the long term\r\n4 goes together with 3 but I'm afraid there is no easy way to do it unless upgrading to turbine 2.x, which wasn't very mature last time I looked at it."},"comment":{"url":"https://api.github.com/repos/fabric8io/kubeflix/issues/comments/217457798","html_url":"https://github.com/fabric8io/kubeflix/issues/78#issuecomment-217457798","issue_url":"https://api.github.com/repos/fabric8io/kubeflix/issues/78","id":217457798,"user":{"login":"iocanel","id":402008,"avatar_url":"https://avatars.githubusercontent.com/u/402008?v=3","gravatar_id":"","url":"https://api.github.com/users/iocanel","html_url":"https://github.com/iocanel","followers_url":"https://api.github.com/users/iocanel/followers","following_url":"https://api.github.com/users/iocanel/following{/other_user}","gists_url":"https://api.github.com/users/iocanel/gists{/gist_id}","starred_url":"https://api.github.com/users/iocanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocanel/subscriptions","organizations_url":"https://api.github.com/users/iocanel/orgs","repos_url":"https://api.github.com/users/iocanel/repos","events_url":"https://api.github.com/users/iocanel/events{/privacy}","received_events_url":"https://api.github.com/users/iocanel/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T14:38:09Z","updated_at":"2016-05-06T14:38:09Z","body":"@raffaelespazzoli:\r\n\r\nregarding the the missing coln, you are right. it should be there.\r\nyou are also right the the spring way of doing things would be using ``TURBINE_INSTANCEURLSUFFIX`` \r\n\r\nI'll update the docs, check again and add even more tests."}}