{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/osquery/pulls/comments/77914105","id":77914105,"diff_hunk":"@@ -31,20 +31,50 @@ namespace osquery {\n const int kDelayUS = 2000;\n const int kTimeoutUS = 1000000;\n \n+#ifdef WIN32\n+static bool namedPipeExists(const std::string& path) {","path":"osquery/extensions/tests/extensions_tests.cpp","position":15,"original_position":15,"commit_id":"326c98d9ba4f2c7565dc1e0e58725c707a0c4410","original_commit_id":"326c98d9ba4f2c7565dc1e0e58725c707a0c4410","user":{"login":"yying","id":4278185,"avatar_url":"https://avatars.githubusercontent.com/u/4278185?v=3","gravatar_id":"","url":"https://api.github.com/users/yying","html_url":"https://github.com/yying","followers_url":"https://api.github.com/users/yying/followers","following_url":"https://api.github.com/users/yying/following{/other_user}","gists_url":"https://api.github.com/users/yying/gists{/gist_id}","starred_url":"https://api.github.com/users/yying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yying/subscriptions","organizations_url":"https://api.github.com/users/yying/orgs","repos_url":"https://api.github.com/users/yying/repos","events_url":"https://api.github.com/users/yying/events{/privacy}","received_events_url":"https://api.github.com/users/yying/received_events","type":"User","site_admin":false},"body":"I think so, I'll probably end up moving this to `osquery/core/fileops.h`.","created_at":"2016-09-07T22:12:24Z","updated_at":"2016-09-07T22:12:24Z","html_url":"https://github.com/facebook/osquery/pull/2441#discussion_r77914105","pull_request_url":"https://api.github.com/repos/facebook/osquery/pulls/2441","_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments/77914105"},"html":{"href":"https://github.com/facebook/osquery/pull/2441#discussion_r77914105"},"pull_request":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2441"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/2441","id":84226201,"html_url":"https://github.com/facebook/osquery/pull/2441","diff_url":"https://github.com/facebook/osquery/pull/2441.diff","patch_url":"https://github.com/facebook/osquery/pull/2441.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/2441","number":2441,"state":"open","locked":false,"title":"Core and Additional Tests","user":{"login":"yying","id":4278185,"avatar_url":"https://avatars.githubusercontent.com/u/4278185?v=3","gravatar_id":"","url":"https://api.github.com/users/yying","html_url":"https://github.com/yying","followers_url":"https://api.github.com/users/yying/followers","following_url":"https://api.github.com/users/yying/following{/other_user}","gists_url":"https://api.github.com/users/yying/gists{/gist_id}","starred_url":"https://api.github.com/users/yying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yying/subscriptions","organizations_url":"https://api.github.com/users/yying/orgs","repos_url":"https://api.github.com/users/yying/repos","events_url":"https://api.github.com/users/yying/events{/privacy}","received_events_url":"https://api.github.com/users/yying/received_events","type":"User","site_admin":false},"body":"Unit tests now build and most pass. The tests that do not pass require certain tables to be implemented.\r\n\r\nCloses #2423 ","created_at":"2016-09-07T02:11:54Z","updated_at":"2016-09-07T22:12:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b377770e3a2908eaf082ee5ca6543aacee014266","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/2441/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/2441/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/2441/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/326c98d9ba4f2c7565dc1e0e58725c707a0c4410","head":{"label":"trailofbits:windows10/test-utils","ref":"windows10/test-utils","sha":"326c98d9ba4f2c7565dc1e0e58725c707a0c4410","user":{"login":"trailofbits","id":2314423,"avatar_url":"https://avatars.githubusercontent.com/u/2314423?v=3","gravatar_id":"","url":"https://api.github.com/users/trailofbits","html_url":"https://github.com/trailofbits","followers_url":"https://api.github.com/users/trailofbits/followers","following_url":"https://api.github.com/users/trailofbits/following{/other_user}","gists_url":"https://api.github.com/users/trailofbits/gists{/gist_id}","starred_url":"https://api.github.com/users/trailofbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailofbits/subscriptions","organizations_url":"https://api.github.com/users/trailofbits/orgs","repos_url":"https://api.github.com/users/trailofbits/repos","events_url":"https://api.github.com/users/trailofbits/events{/privacy}","received_events_url":"https://api.github.com/users/trailofbits/received_events","type":"Organization","site_admin":false},"repo":{"id":54419021,"name":"osquery","full_name":"trailofbits/osquery","owner":{"login":"trailofbits","id":2314423,"avatar_url":"https://avatars.githubusercontent.com/u/2314423?v=3","gravatar_id":"","url":"https://api.github.com/users/trailofbits","html_url":"https://github.com/trailofbits","followers_url":"https://api.github.com/users/trailofbits/followers","following_url":"https://api.github.com/users/trailofbits/following{/other_user}","gists_url":"https://api.github.com/users/trailofbits/gists{/gist_id}","starred_url":"https://api.github.com/users/trailofbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailofbits/subscriptions","organizations_url":"https://api.github.com/users/trailofbits/orgs","repos_url":"https://api.github.com/users/trailofbits/repos","events_url":"https://api.github.com/users/trailofbits/events{/privacy}","received_events_url":"https://api.github.com/users/trailofbits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trailofbits/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":true,"url":"https://api.github.com/repos/trailofbits/osquery","forks_url":"https://api.github.com/repos/trailofbits/osquery/forks","keys_url":"https://api.github.com/repos/trailofbits/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trailofbits/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trailofbits/osquery/teams","hooks_url":"https://api.github.com/repos/trailofbits/osquery/hooks","issue_events_url":"https://api.github.com/repos/trailofbits/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/trailofbits/osquery/events","assignees_url":"https://api.github.com/repos/trailofbits/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/trailofbits/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/trailofbits/osquery/tags","blobs_url":"https://api.github.com/repos/trailofbits/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trailofbits/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trailofbits/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/trailofbits/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trailofbits/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/trailofbits/osquery/languages","stargazers_url":"https://api.github.com/repos/trailofbits/osquery/stargazers","contributors_url":"https://api.github.com/repos/trailofbits/osquery/contributors","subscribers_url":"https://api.github.com/repos/trailofbits/osquery/subscribers","subscription_url":"https://api.github.com/repos/trailofbits/osquery/subscription","commits_url":"https://api.github.com/repos/trailofbits/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/trailofbits/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/trailofbits/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/trailofbits/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/trailofbits/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/trailofbits/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trailofbits/osquery/merges","archive_url":"https://api.github.com/repos/trailofbits/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trailofbits/osquery/downloads","issues_url":"https://api.github.com/repos/trailofbits/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/trailofbits/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/trailofbits/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/trailofbits/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trailofbits/osquery/labels{/name}","releases_url":"https://api.github.com/repos/trailofbits/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/trailofbits/osquery/deployments","created_at":"2016-03-21T20:06:09Z","updated_at":"2016-08-15T12:39:35Z","pushed_at":"2016-09-07T19:53:45Z","git_url":"git://github.com/trailofbits/osquery.git","ssh_url":"git@github.com:trailofbits/osquery.git","clone_url":"https://github.com/trailofbits/osquery.git","svn_url":"https://github.com/trailofbits/osquery","homepage":"https://osquery.io","size":9185,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":16,"forks":1,"open_issues":16,"watchers":5,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"7b8bd9657d5c888d06f1f0caee9cd9044a946bce","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/osquery/deployments","created_at":"2014-07-29T20:27:33Z","updated_at":"2016-09-07T16:14:36Z","pushed_at":"2016-09-07T21:45:43Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"https://osquery.io","size":12920,"stargazers_count":6675,"watchers_count":6675,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":734,"mirror_url":null,"open_issues_count":64,"forks":734,"open_issues":64,"watchers":6675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2441"},"html":{"href":"https://github.com/facebook/osquery/pull/2441"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/2441"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/2441/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2441/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/2441/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/326c98d9ba4f2c7565dc1e0e58725c707a0c4410"}}}}
{"actor":{"display_login":"yying"}}