{"action":"closed","number":55,"pull_request":{"url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/55","id":56278189,"html_url":"https://github.com/FriendsOfCake/cakephp-csvview/pull/55","diff_url":"https://github.com/FriendsOfCake/cakephp-csvview/pull/55.diff","patch_url":"https://github.com/FriendsOfCake/cakephp-csvview/pull/55.patch","issue_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/55","number":55,"state":"closed","locked":false,"title":"Fix CakePHP date(time) object values to be not destroyed but exported…","user":{"login":"dereuromark","id":39854,"avatar_url":"https://avatars.githubusercontent.com/u/39854?v=3","gravatar_id":"","url":"https://api.github.com/users/dereuromark","html_url":"https://github.com/dereuromark","followers_url":"https://api.github.com/users/dereuromark/followers","following_url":"https://api.github.com/users/dereuromark/following{/other_user}","gists_url":"https://api.github.com/users/dereuromark/gists{/gist_id}","starred_url":"https://api.github.com/users/dereuromark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dereuromark/subscriptions","organizations_url":"https://api.github.com/users/dereuromark/orgs","repos_url":"https://api.github.com/users/dereuromark/repos","events_url":"https://api.github.com/users/dereuromark/events{/privacy}","received_events_url":"https://api.github.com/users/dereuromark/received_events","type":"User","site_admin":false},"body":"… again.\r\n\r\nResolves https://github.com/FriendsOfCake/cakephp-csvview/issues/46\r\n\r\nThe main problem is Hash::extract() and that it converts the date into an array upon lookup.\r\nThe isset($x[0]) check cannot work on an array that is\r\n\r\n    [\r\n        'date' => ....,\r\n        ....\r\n    ]\r\n\r\nSo this fixes it but for every other object it will most likely fail, Maybe the array transformation should not be happening for objects in Hash::extract()? Or there should be a to string cast instead.\r\nEither way, this PR at least now solves our specific issue at hand.\r\n\r\nI tested it in my sandbox:\r\nhttp://sandbox3.dereuromark.de/sandbox/csv/pagination\r\nCurrently the datetime fields would be indeed just gone, but as soon as this is merged, I will update the examples and you can see that it works as expected.","created_at":"2016-01-17T13:58:47Z","updated_at":"2016-01-20T20:59:55Z","closed_at":"2016-01-20T20:59:55Z","merged_at":"2016-01-20T20:59:55Z","merge_commit_sha":"ceabd58beba45d14ccc2ca635d844ba6bc1838d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/55/commits","review_comments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/55/comments","review_comment_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/55/comments","statuses_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/statuses/cf6934758ed4c27fc158ccebbe4f597cdf2bec92","head":{"label":"FriendsOfCake:master-date","ref":"master-date","sha":"cf6934758ed4c27fc158ccebbe4f597cdf2bec92","user":{"login":"FriendsOfCake","id":5203126,"avatar_url":"https://avatars.githubusercontent.com/u/5203126?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"repo":{"id":5823079,"name":"cakephp-csvview","full_name":"FriendsOfCake/cakephp-csvview","owner":{"login":"FriendsOfCake","id":5203126,"avatar_url":"https://avatars.githubusercontent.com/u/5203126?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfCake/cakephp-csvview","description":"A view class for generating CSV","fork":false,"url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview","forks_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/forks","keys_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/teams","hooks_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/events","assignees_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/tags","blobs_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/languages","stargazers_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/subscription","commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/merges","archive_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/downloads","issues_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/releases{/id}","created_at":"2012-09-15T18:54:32Z","updated_at":"2016-01-18T02:01:29Z","pushed_at":"2016-01-20T20:59:55Z","git_url":"git://github.com/FriendsOfCake/cakephp-csvview.git","ssh_url":"git@github.com:FriendsOfCake/cakephp-csvview.git","clone_url":"https://github.com/FriendsOfCake/cakephp-csvview.git","svn_url":"https://github.com/FriendsOfCake/cakephp-csvview","homepage":"","size":130,"stargazers_count":100,"watchers_count":100,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":2,"forks":38,"open_issues":2,"watchers":100,"default_branch":"master"}},"base":{"label":"FriendsOfCake:master","ref":"master","sha":"298c6cb026753eefbba88ab74ea9fb65389c5b66","user":{"login":"FriendsOfCake","id":5203126,"avatar_url":"https://avatars.githubusercontent.com/u/5203126?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"repo":{"id":5823079,"name":"cakephp-csvview","full_name":"FriendsOfCake/cakephp-csvview","owner":{"login":"FriendsOfCake","id":5203126,"avatar_url":"https://avatars.githubusercontent.com/u/5203126?v=3","gravatar_id":"","url":"https://api.github.com/users/FriendsOfCake","html_url":"https://github.com/FriendsOfCake","followers_url":"https://api.github.com/users/FriendsOfCake/followers","following_url":"https://api.github.com/users/FriendsOfCake/following{/other_user}","gists_url":"https://api.github.com/users/FriendsOfCake/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsOfCake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsOfCake/subscriptions","organizations_url":"https://api.github.com/users/FriendsOfCake/orgs","repos_url":"https://api.github.com/users/FriendsOfCake/repos","events_url":"https://api.github.com/users/FriendsOfCake/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsOfCake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsOfCake/cakephp-csvview","description":"A view class for generating CSV","fork":false,"url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview","forks_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/forks","keys_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/teams","hooks_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/hooks","issue_events_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/events","assignees_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/tags","blobs_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/languages","stargazers_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/stargazers","contributors_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/contributors","subscribers_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/subscribers","subscription_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/subscription","commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/merges","archive_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/downloads","issues_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/labels{/name}","releases_url":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/releases{/id}","created_at":"2012-09-15T18:54:32Z","updated_at":"2016-01-18T02:01:29Z","pushed_at":"2016-01-20T20:59:55Z","git_url":"git://github.com/FriendsOfCake/cakephp-csvview.git","ssh_url":"git@github.com:FriendsOfCake/cakephp-csvview.git","clone_url":"https://github.com/FriendsOfCake/cakephp-csvview.git","svn_url":"https://github.com/FriendsOfCake/cakephp-csvview","homepage":"","size":130,"stargazers_count":100,"watchers_count":100,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":2,"forks":38,"open_issues":2,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/55"},"html":{"href":"https://github.com/FriendsOfCake/cakephp-csvview/pull/55"},"issue":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/55"},"comments":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsOfCake/cakephp-csvview/statuses/cf6934758ed4c27fc158ccebbe4f597cdf2bec92"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"josegonzalez","id":65675,"avatar_url":"https://avatars.githubusercontent.com/u/65675?v=3","gravatar_id":"","url":"https://api.github.com/users/josegonzalez","html_url":"https://github.com/josegonzalez","followers_url":"https://api.github.com/users/josegonzalez/followers","following_url":"https://api.github.com/users/josegonzalez/following{/other_user}","gists_url":"https://api.github.com/users/josegonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/josegonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegonzalez/subscriptions","organizations_url":"https://api.github.com/users/josegonzalez/orgs","repos_url":"https://api.github.com/users/josegonzalez/repos","events_url":"https://api.github.com/users/josegonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/josegonzalez/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":3,"additions":12,"deletions":7,"changed_files":2}}