{"action":"created","issue":{"url":"https://api.github.com/repos/pgavlin/coreclr/issues/21","repository_url":"https://api.github.com/repos/pgavlin/coreclr","labels_url":"https://api.github.com/repos/pgavlin/coreclr/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/pgavlin/coreclr/issues/21/comments","events_url":"https://api.github.com/repos/pgavlin/coreclr/issues/21/events","html_url":"https://github.com/pgavlin/coreclr/pull/21","id":169720429,"number":21,"title":"Diff + correctness fixes for the LIR backend.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-06T00:50:35Z","updated_at":"2016-08-08T18:05:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pgavlin/coreclr/pulls/21","html_url":"https://github.com/pgavlin/coreclr/pull/21","diff_url":"https://github.com/pgavlin/coreclr/pull/21.diff","patch_url":"https://github.com/pgavlin/coreclr/pull/21.patch"},"body":"### Fixes for diffs\r\nThe current backend happily removes dead stores with the GTF_ORDER bit\r\nset unless the value being stored is a catch arg. The LIR implementation\r\nwas a bit more conservative, refusing to remove dead stores with any of\r\nthe GTF_ALL_EFFECT bits set. Change this to match the current\r\nimplementation.\r\n\r\n### Correctness fixes\r\n- Fix use edge iteration for SIMD nodes.\r\n- Fix broken pattern recognition in SIMD lowering.\r\n- Set the GTF_ASG flag on stores created during SIMD rationalization\r\n  in order to keep later passes from dropping them.\r\n- Fix SIMD copyblk lowering\r\n- Fix GT_CLSVAR lowering for X86\r\n- Fix removal and insertion of KVPs from/to a home bucket in HashTable.\r\n- Remove switch tables when simplifying LIR switches.\r\n\r\n### Misc.\r\n- Move `ContainsNode()` asserts in `LIR::Range` under a higher debug level.\r\n  These checks are run extremely frequently and end up costing an undue\r\n  amount of time in debug/checked builds."},"comment":{"url":"https://api.github.com/repos/pgavlin/coreclr/issues/comments/238324585","html_url":"https://github.com/pgavlin/coreclr/pull/21#issuecomment-238324585","issue_url":"https://api.github.com/repos/pgavlin/coreclr/issues/21","id":238324585,"user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars.githubusercontent.com/u/10901265?v=3","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T18:05:19Z","updated_at":"2016-08-08T18:05:19Z","body":"LGTM"}}
{"actor":{"display_login":"BruceForstall"}}