{"action":"closed","number":8818,"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8818","id":74376370,"html_url":"https://github.com/hrydgard/ppsspp/pull/8818","diff_url":"https://github.com/hrydgard/ppsspp/pull/8818.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/8818.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8818","number":8818,"state":"closed","locked":false,"title":"CWC improvements/fixes","user":{"login":"LunaMoo","id":5485237,"avatar_url":"https://avatars.githubusercontent.com/u/5485237?v=3","gravatar_id":"","url":"https://api.github.com/users/LunaMoo","html_url":"https://github.com/LunaMoo","followers_url":"https://api.github.com/users/LunaMoo/followers","following_url":"https://api.github.com/users/LunaMoo/following{/other_user}","gists_url":"https://api.github.com/users/LunaMoo/gists{/gist_id}","starred_url":"https://api.github.com/users/LunaMoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunaMoo/subscriptions","organizations_url":"https://api.github.com/users/LunaMoo/orgs","repos_url":"https://api.github.com/users/LunaMoo/repos","events_url":"https://api.github.com/users/LunaMoo/events{/privacy}","received_events_url":"https://api.github.com/users/LunaMoo/received_events","type":"User","site_admin":false},"body":" This solves #8658 althrough I would be lazy to do it just because of the argument mentioned there about someone being lazy to restart emulation when it's required by cheat, my own argument for adding it is for cases where broken cheats crash PPSSPP on boot which might suck on non windows platforms currently.\r\n\r\n It additionally fixes a small problem where first line was removed from newly created files, it could remove first cheat if someone opened automatically created file and added cheats without _S/_G lines that we usually add as PSP legacy, but not actually use them.\r\n\r\n Also invalidates JIT for reading values via 0xE/0xD multi-line skip codes, in some cases where code is moved around/loaded in modules those codes can't read original values otherwise. I don't think that's particulary common issue since people rarely ever used those cheats that way on psp, I do it all the time since they're great to stop long scripts from being written constantly as well as for safety checks.\r\n\r\n Saying so I can't really find any more issues with CWC, people will continue to have problems with PSP cheats where address differs and we can't do much about it, so I guess #7375 could also be closed.\r\n\r\nEdit: sorry for pushing it like few times in a row;p I'm quite literally on drugs(well eye drops count as drugs I guess;p) and my vision is quite blurry. Should be fine now.\r\n\r\n--\r\nFixes #8448, fixes #8658, fixes #8023.  Fixes #7375 (remaining jit invalidations.)","created_at":"2016-06-19T22:50:04Z","updated_at":"2016-06-21T04:40:54Z","closed_at":"2016-06-21T04:40:54Z","merged_at":"2016-06-21T04:40:53Z","merge_commit_sha":"2bd0567448ed73e546c4dca2c8274388b121198c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8818/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8818/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/8818/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/101df1da2b734657ba74c6306f1493bacef11a26","head":{"label":"LunaMoo:minorCWC","ref":"minorCWC","sha":"101df1da2b734657ba74c6306f1493bacef11a26","user":{"login":"LunaMoo","id":5485237,"avatar_url":"https://avatars.githubusercontent.com/u/5485237?v=3","gravatar_id":"","url":"https://api.github.com/users/LunaMoo","html_url":"https://github.com/LunaMoo","followers_url":"https://api.github.com/users/LunaMoo/followers","following_url":"https://api.github.com/users/LunaMoo/following{/other_user}","gists_url":"https://api.github.com/users/LunaMoo/gists{/gist_id}","starred_url":"https://api.github.com/users/LunaMoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunaMoo/subscriptions","organizations_url":"https://api.github.com/users/LunaMoo/orgs","repos_url":"https://api.github.com/users/LunaMoo/repos","events_url":"https://api.github.com/users/LunaMoo/events{/privacy}","received_events_url":"https://api.github.com/users/LunaMoo/received_events","type":"User","site_admin":false},"repo":{"id":43588463,"name":"ppsspp","full_name":"LunaMoo/ppsspp","owner":{"login":"LunaMoo","id":5485237,"avatar_url":"https://avatars.githubusercontent.com/u/5485237?v=3","gravatar_id":"","url":"https://api.github.com/users/LunaMoo","html_url":"https://github.com/LunaMoo","followers_url":"https://api.github.com/users/LunaMoo/followers","following_url":"https://api.github.com/users/LunaMoo/following{/other_user}","gists_url":"https://api.github.com/users/LunaMoo/gists{/gist_id}","starred_url":"https://api.github.com/users/LunaMoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LunaMoo/subscriptions","organizations_url":"https://api.github.com/users/LunaMoo/orgs","repos_url":"https://api.github.com/users/LunaMoo/repos","events_url":"https://api.github.com/users/LunaMoo/events{/privacy}","received_events_url":"https://api.github.com/users/LunaMoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LunaMoo/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":true,"url":"https://api.github.com/repos/LunaMoo/ppsspp","forks_url":"https://api.github.com/repos/LunaMoo/ppsspp/forks","keys_url":"https://api.github.com/repos/LunaMoo/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LunaMoo/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LunaMoo/ppsspp/teams","hooks_url":"https://api.github.com/repos/LunaMoo/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/LunaMoo/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/LunaMoo/ppsspp/events","assignees_url":"https://api.github.com/repos/LunaMoo/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/LunaMoo/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/LunaMoo/ppsspp/tags","blobs_url":"https://api.github.com/repos/LunaMoo/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LunaMoo/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LunaMoo/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/LunaMoo/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LunaMoo/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/LunaMoo/ppsspp/languages","stargazers_url":"https://api.github.com/repos/LunaMoo/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/LunaMoo/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/LunaMoo/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/LunaMoo/ppsspp/subscription","commits_url":"https://api.github.com/repos/LunaMoo/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/LunaMoo/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/LunaMoo/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/LunaMoo/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/LunaMoo/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/LunaMoo/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LunaMoo/ppsspp/merges","archive_url":"https://api.github.com/repos/LunaMoo/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LunaMoo/ppsspp/downloads","issues_url":"https://api.github.com/repos/LunaMoo/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/LunaMoo/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/LunaMoo/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/LunaMoo/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LunaMoo/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/LunaMoo/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/LunaMoo/ppsspp/deployments","created_at":"2015-10-03T04:59:49Z","updated_at":"2016-05-16T05:59:16Z","pushed_at":"2016-06-21T04:29:56Z","git_url":"git://github.com/LunaMoo/ppsspp.git","ssh_url":"git@github.com:LunaMoo/ppsspp.git","clone_url":"https://github.com/LunaMoo/ppsspp.git","svn_url":"https://github.com/LunaMoo/ppsspp","homepage":"http://www.ppsspp.org","size":93053,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"3b6d9ca42acbc5dbddf0c712833f8354153bc57f","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac, Linux and Blackberry 10, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/hrydgard/ppsspp/deployments","created_at":"2012-11-01T08:41:48Z","updated_at":"2016-06-20T17:34:01Z","pushed_at":"2016-06-21T04:40:54Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":424911,"stargazers_count":2350,"watchers_count":2350,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":907,"mirror_url":null,"open_issues_count":602,"forks":907,"open_issues":602,"watchers":2350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8818"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/8818"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/8818"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/8818/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8818/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/8818/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/101df1da2b734657ba74c6306f1493bacef11a26"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"unknownbrackets","id":191233,"avatar_url":"https://avatars.githubusercontent.com/u/191233?v=3","gravatar_id":"","url":"https://api.github.com/users/unknownbrackets","html_url":"https://github.com/unknownbrackets","followers_url":"https://api.github.com/users/unknownbrackets/followers","following_url":"https://api.github.com/users/unknownbrackets/following{/other_user}","gists_url":"https://api.github.com/users/unknownbrackets/gists{/gist_id}","starred_url":"https://api.github.com/users/unknownbrackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unknownbrackets/subscriptions","organizations_url":"https://api.github.com/users/unknownbrackets/orgs","repos_url":"https://api.github.com/users/unknownbrackets/repos","events_url":"https://api.github.com/users/unknownbrackets/events{/privacy}","received_events_url":"https://api.github.com/users/unknownbrackets/received_events","type":"User","site_admin":false},"comments":8,"review_comments":6,"commits":4,"additions":66,"deletions":15,"changed_files":7}}
{"actor":{"display_login":"unknownbrackets"}}