{"action":"opened","number":8983,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/8983","id":78558223,"html_url":"https://github.com/facebook/react-native/pull/8983","diff_url":"https://github.com/facebook/react-native/pull/8983.diff","patch_url":"https://github.com/facebook/react-native/pull/8983.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/8983","number":8983,"state":"open","locked":false,"title":"Render NavigationHeader correctly with hidden status bar","user":{"login":"corbt","id":176426,"avatar_url":"https://avatars.githubusercontent.com/u/176426?v=3","gravatar_id":"","url":"https://api.github.com/users/corbt","html_url":"https://github.com/corbt","followers_url":"https://api.github.com/users/corbt/followers","following_url":"https://api.github.com/users/corbt/following{/other_user}","gists_url":"https://api.github.com/users/corbt/gists{/gist_id}","starred_url":"https://api.github.com/users/corbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corbt/subscriptions","organizations_url":"https://api.github.com/users/corbt/orgs","repos_url":"https://api.github.com/users/corbt/repos","events_url":"https://api.github.com/users/corbt/events{/privacy}","received_events_url":"https://api.github.com/users/corbt/received_events","type":"User","site_admin":false},"body":"Currently, the NavigationExperimental `Header` only renders correctly on iOS when the system status bar is visible. There are legitimate reasons to hide the status bar, especially when displaying in landscape.\r\n\r\nThis PR adds a `statusBarHidden` prop to the header, which can be set to `true` when the status bar isn't visible on the screen. Setting this causes the extra space at the top of the header reserved for the status bar to disappear.\r\n\r\nI've tested this change in my own app with `statusBarHidden` set to `true`, `false`, and not defined, and ensured that it works correctly.\r\n","created_at":"2016-07-23T00:54:05Z","updated_at":"2016-07-23T00:54:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/8983/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/8983/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/8983/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/fa1da2751b1b41b7f6a6b8384e446831074ae0e6","head":{"label":"corbt:hidden-status","ref":"hidden-status","sha":"fa1da2751b1b41b7f6a6b8384e446831074ae0e6","user":{"login":"corbt","id":176426,"avatar_url":"https://avatars.githubusercontent.com/u/176426?v=3","gravatar_id":"","url":"https://api.github.com/users/corbt","html_url":"https://github.com/corbt","followers_url":"https://api.github.com/users/corbt/followers","following_url":"https://api.github.com/users/corbt/following{/other_user}","gists_url":"https://api.github.com/users/corbt/gists{/gist_id}","starred_url":"https://api.github.com/users/corbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corbt/subscriptions","organizations_url":"https://api.github.com/users/corbt/orgs","repos_url":"https://api.github.com/users/corbt/repos","events_url":"https://api.github.com/users/corbt/events{/privacy}","received_events_url":"https://api.github.com/users/corbt/received_events","type":"User","site_admin":false},"repo":{"id":42651297,"name":"react-native","full_name":"corbt/react-native","owner":{"login":"corbt","id":176426,"avatar_url":"https://avatars.githubusercontent.com/u/176426?v=3","gravatar_id":"","url":"https://api.github.com/users/corbt","html_url":"https://github.com/corbt","followers_url":"https://api.github.com/users/corbt/followers","following_url":"https://api.github.com/users/corbt/following{/other_user}","gists_url":"https://api.github.com/users/corbt/gists{/gist_id}","starred_url":"https://api.github.com/users/corbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corbt/subscriptions","organizations_url":"https://api.github.com/users/corbt/orgs","repos_url":"https://api.github.com/users/corbt/repos","events_url":"https://api.github.com/users/corbt/events{/privacy}","received_events_url":"https://api.github.com/users/corbt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/corbt/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/corbt/react-native","forks_url":"https://api.github.com/repos/corbt/react-native/forks","keys_url":"https://api.github.com/repos/corbt/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corbt/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corbt/react-native/teams","hooks_url":"https://api.github.com/repos/corbt/react-native/hooks","issue_events_url":"https://api.github.com/repos/corbt/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/corbt/react-native/events","assignees_url":"https://api.github.com/repos/corbt/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/corbt/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/corbt/react-native/tags","blobs_url":"https://api.github.com/repos/corbt/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corbt/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corbt/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/corbt/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corbt/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/corbt/react-native/languages","stargazers_url":"https://api.github.com/repos/corbt/react-native/stargazers","contributors_url":"https://api.github.com/repos/corbt/react-native/contributors","subscribers_url":"https://api.github.com/repos/corbt/react-native/subscribers","subscription_url":"https://api.github.com/repos/corbt/react-native/subscription","commits_url":"https://api.github.com/repos/corbt/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/corbt/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/corbt/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/corbt/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/corbt/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/corbt/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corbt/react-native/merges","archive_url":"https://api.github.com/repos/corbt/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corbt/react-native/downloads","issues_url":"https://api.github.com/repos/corbt/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/corbt/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/corbt/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/corbt/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corbt/react-native/labels{/name}","releases_url":"https://api.github.com/repos/corbt/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/corbt/react-native/deployments","created_at":"2015-09-17T11:01:13Z","updated_at":"2016-06-06T21:02:45Z","pushed_at":"2016-07-23T00:49:05Z","git_url":"git://github.com/corbt/react-native.git","ssh_url":"git@github.com:corbt/react-native.git","clone_url":"https://github.com/corbt/react-native.git","svn_url":"https://github.com/corbt/react-native","homepage":"http://facebook.github.io/react-native/","size":45183,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"eb59ae8423e5b0e462524bf1425d2f086a0e845a","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2016-07-23T00:25:22Z","pushed_at":"2016-07-23T00:26:49Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":114203,"stargazers_count":35258,"watchers_count":35258,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7571,"mirror_url":null,"open_issues_count":1195,"forks":7571,"open_issues":1195,"watchers":35258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/8983"},"html":{"href":"https://github.com/facebook/react-native/pull/8983"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/8983"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/8983/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/8983/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/8983/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/fa1da2751b1b41b7f6a6b8384e446831074ae0e6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"corbt"}}