{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/494","repository_url":"https://api.github.com/repos/angular-ui/ui-sortable","labels_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/494/comments","events_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/494/events","html_url":"https://github.com/angular-ui/ui-sortable/pull/494","id":192343479,"number":494,"title":"Fixed to work with deep descendants","user":{"login":"yenoh2","id":23555613,"avatar_url":"https://avatars.githubusercontent.com/u/23555613?v=3","gravatar_id":"","url":"https://api.github.com/users/yenoh2","html_url":"https://github.com/yenoh2","followers_url":"https://api.github.com/users/yenoh2/followers","following_url":"https://api.github.com/users/yenoh2/following{/other_user}","gists_url":"https://api.github.com/users/yenoh2/gists{/gist_id}","starred_url":"https://api.github.com/users/yenoh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenoh2/subscriptions","organizations_url":"https://api.github.com/users/yenoh2/orgs","repos_url":"https://api.github.com/users/yenoh2/repos","events_url":"https://api.github.com/users/yenoh2/events{/privacy}","received_events_url":"https://api.github.com/users/yenoh2/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/milestones/7","html_url":"https://github.com/angular-ui/ui-sortable/milestones/v0.16.x","labels_url":"https://api.github.com/repos/angular-ui/ui-sortable/milestones/7/labels","id":2167935,"number":7,"title":"v0.16.x","description":null,"creator":{"login":"thgreasi","id":1295829,"avatar_url":"https://avatars.githubusercontent.com/u/1295829?v=3","gravatar_id":"","url":"https://api.github.com/users/thgreasi","html_url":"https://github.com/thgreasi","followers_url":"https://api.github.com/users/thgreasi/followers","following_url":"https://api.github.com/users/thgreasi/following{/other_user}","gists_url":"https://api.github.com/users/thgreasi/gists{/gist_id}","starred_url":"https://api.github.com/users/thgreasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thgreasi/subscriptions","organizations_url":"https://api.github.com/users/thgreasi/orgs","repos_url":"https://api.github.com/users/thgreasi/repos","events_url":"https://api.github.com/users/thgreasi/events{/privacy}","received_events_url":"https://api.github.com/users/thgreasi/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2016-12-01T05:33:04Z","updated_at":"2016-12-04T15:07:53Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-11-29T17:14:02Z","updated_at":"2016-12-05T09:27:36Z","closed_at":"2016-12-04T15:07:53Z","pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/pulls/494","html_url":"https://github.com/angular-ui/ui-sortable/pull/494","diff_url":"https://github.com/angular-ui/ui-sortable/pull/494.diff","patch_url":"https://github.com/angular-ui/ui-sortable/pull/494.patch"},"body":"In trying to use ui-sortable with Angular Material tabs, I found that it didn't work for two reasons. First you can't have two directives with an isolated scope on the same element. Second, ui-sortable didn't support items that aren't a direct decendant. I modified the \"getElementScope\" function to get the applicable scope for the draggable item, if the normal code results in null. I also wrapped the md-tabs directive in a div containing the ui-sortable directive to circumvent the two directives with isolated scopes issues.\r\n\r\nAs far as I can tell, this works. Can you see any issues with my change?\r\n\r\nSee the following example:\r\nhttp://codepen.io/yenoh2/pen/rWxxVJ\r\n\r\nThis seems to be related to \"Using ui.sortable with angular ui.bootstrap.tabs have a weird interaction #248\""},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/comments/264805147","html_url":"https://github.com/angular-ui/ui-sortable/pull/494#issuecomment-264805147","issue_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/494","id":264805147,"user":{"login":"yenoh2","id":23555613,"avatar_url":"https://avatars.githubusercontent.com/u/23555613?v=3","gravatar_id":"","url":"https://api.github.com/users/yenoh2","html_url":"https://github.com/yenoh2","followers_url":"https://api.github.com/users/yenoh2/followers","following_url":"https://api.github.com/users/yenoh2/following{/other_user}","gists_url":"https://api.github.com/users/yenoh2/gists{/gist_id}","starred_url":"https://api.github.com/users/yenoh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenoh2/subscriptions","organizations_url":"https://api.github.com/users/yenoh2/orgs","repos_url":"https://api.github.com/users/yenoh2/repos","events_url":"https://api.github.com/users/yenoh2/events{/privacy}","received_events_url":"https://api.github.com/users/yenoh2/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T09:27:36Z","updated_at":"2016-12-05T09:27:36Z","body":"Thank you.  I enjoyed collaborating on it. Thank you for running with it.\nIt's awesome!\n\n\nOn Dec 4, 2016 4:10 PM, \"Thodoris Greasidis\" <notifications@github.com>\nwrote:\n\n> Thanks for your contribution on this 👍\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/angular-ui/ui-sortable/pull/494#issuecomment-264709263>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AWduHRKASMHlh6GsvlpA2zG8aybNvRa3ks5rEtf5gaJpZM4K_PLQ>\n> .\n>\n"}}
{"actor":{"display_login":"yenoh2"}}