{"action":"created","issue":{"url":"https://api.github.com/repos/critiqjo/lldb.nvim/issues/28","repository_url":"https://api.github.com/repos/critiqjo/lldb.nvim","labels_url":"https://api.github.com/repos/critiqjo/lldb.nvim/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/critiqjo/lldb.nvim/issues/28/comments","events_url":"https://api.github.com/repos/critiqjo/lldb.nvim/issues/28/events","html_url":"https://github.com/critiqjo/lldb.nvim/pull/28","id":159584089,"number":28,"title":"Implemented interactive buffers.","user":{"login":"ckwang","id":521431,"avatar_url":"https://avatars.githubusercontent.com/u/521431?v=3","gravatar_id":"","url":"https://api.github.com/users/ckwang","html_url":"https://github.com/ckwang","followers_url":"https://api.github.com/users/ckwang/followers","following_url":"https://api.github.com/users/ckwang/following{/other_user}","gists_url":"https://api.github.com/users/ckwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ckwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckwang/subscriptions","organizations_url":"https://api.github.com/users/ckwang/orgs","repos_url":"https://api.github.com/users/ckwang/repos","events_url":"https://api.github.com/users/ckwang/events{/privacy}","received_events_url":"https://api.github.com/users/ckwang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-10T08:27:26Z","updated_at":"2016-06-11T16:17:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/critiqjo/lldb.nvim/pulls/28","html_url":"https://github.com/critiqjo/lldb.nvim/pull/28","diff_url":"https://github.com/critiqjo/lldb.nvim/pull/28.diff","patch_url":"https://github.com/critiqjo/lldb.nvim/pull/28.patch"},"body":"Implements the feature in #9, except for the watchpoints.\r\n\r\nIn the end, I skip the syntax idea all together, and perform the regex myself. The ideal way is to extract substring using Vim's syntax mechanism, but the most I can do is looking up what syntax group a specific location belongs to. If I want to do anything more, I might need to scan the whole line, which makes things more complicated.\r\n\r\nAlso, I promoted \"llnotify\" to global namespace because it's now used in layout.vim as well. I understand this is probably something to hide from the user. Maybe we need another commit to re-organize the functions.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/critiqjo/lldb.nvim/issues/comments/225372469","html_url":"https://github.com/critiqjo/lldb.nvim/pull/28#issuecomment-225372469","issue_url":"https://api.github.com/repos/critiqjo/lldb.nvim/issues/28","id":225372469,"user":{"login":"critiqjo","id":1436441,"avatar_url":"https://avatars.githubusercontent.com/u/1436441?v=3","gravatar_id":"","url":"https://api.github.com/users/critiqjo","html_url":"https://github.com/critiqjo","followers_url":"https://api.github.com/users/critiqjo/followers","following_url":"https://api.github.com/users/critiqjo/following{/other_user}","gists_url":"https://api.github.com/users/critiqjo/gists{/gist_id}","starred_url":"https://api.github.com/users/critiqjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/critiqjo/subscriptions","organizations_url":"https://api.github.com/users/critiqjo/orgs","repos_url":"https://api.github.com/users/critiqjo/repos","events_url":"https://api.github.com/users/critiqjo/events{/privacy}","received_events_url":"https://api.github.com/users/critiqjo/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T16:17:02Z","updated_at":"2016-06-11T16:17:02Z","body":"Thanks for the PR. I'll review this by June 13th.\nOn Jun 10, 2016 1:57 PM, \"Chun-Kai Wang\" <notifications@github.com> wrote:\n\n> Implements the feature in #9\n> <https://github.com/critiqjo/lldb.nvim/issues/9>, except for the\n> watchpoints.\n>\n> In the end, I skip the syntax idea all together, and perform the regex\n> myself. The ideal way is to extract substring using Vim's syntax mechanism,\n> but the most I can do is looking up what syntax group a specific location\n> belongs to. If I want to do anything more, I might need to scan the whole\n> line, which makes things more complicated.\n>\n> Also, I promoted \"llnotify\" to global namespace because it's now used in\n> layout.vim as well. I understand this is probably something to hide from\n> the user. Maybe we need another commit to re-organize the functions.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/critiqjo/lldb.nvim/pull/28\n> Commit Summary\n>\n>    - Separated window-related settings to its own function.\n>    - Implemented interactive buffers.\n>\n> File Changes\n>\n>    - *M* autoload/lldb/layout.vim\n>    <https://github.com/critiqjo/lldb.nvim/pull/28/files#diff-0> (75)\n>    - *M* autoload/lldb/remote.vim\n>    <https://github.com/critiqjo/lldb.nvim/pull/28/files#diff-1> (16)\n>    - *M* rplugin/python/lldb_nvim/__init__.py\n>    <https://github.com/critiqjo/lldb.nvim/pull/28/files#diff-2> (8)\n>    - *M* rplugin/python/lldb_nvim/controller.py\n>    <https://github.com/critiqjo/lldb.nvim/pull/28/files#diff-3> (16)\n>\n> Patch Links:\n>\n>    - https://github.com/critiqjo/lldb.nvim/pull/28.patch\n>    - https://github.com/critiqjo/lldb.nvim/pull/28.diff\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/critiqjo/lldb.nvim/pull/28>, or mute the thread\n> <https://github.com/notifications/unsubscribe/ABXrGS9aNVlibjUAwBrNf744jF82a9CYks5qKR_vgaJpZM4Iyuqa>\n> .\n>\n"}}
{"actor":{"display_login":"critiqjo"}}