{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/76707650","id":76707650,"diff_hunk":"@@ -0,0 +1,53 @@\n+//******************************************************************************\n+//\n+// Copyright (c) Microsoft. All rights reserved.\n+//\n+// This code is licensed under the MIT License (MIT).\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+//\n+//******************************************************************************\n+#pragma once\n+\n+#import <Foundation/Foundation.h>\n+#import <Foundation/NSMutableArray.h>\n+#import <Foundation/NSUndoManager.h>\n+\n+@protocol _NSUndoable\n+@required\n+- (void)undo:(BOOL)undoAll;\n+- (BOOL)targets:(id)target;\n+- (void)removeAllWithTarget:(id)target;\n+@end\n+\n+@interface _NSUndoBasicAction : NSObject <_NSUndoable>\n+\n+- (id)_initWithTarget:(id)target selector:(SEL)aSelector object:(id)anObject modes:(NSArray<NSString*>*)runLoopModes;\n+\n+@end\n+\n+@interface _NSUndoGroup : NSObject <_NSUndoable>\n+\n+- (id)init;\n+- (void)addUndoCallToUndoGroup:(_NSUndoBasicAction*)undoCall;","path":"Frameworks/Foundation/_NSUndoManagerInternal.h","position":38,"original_position":38,"commit_id":"b60296e5fb793986c47ecbd5a205cf9724e293a4","original_commit_id":"b60296e5fb793986c47ecbd5a205cf9724e293a4","user":{"login":"DHowett-MSFT","id":14316954,"avatar_url":"https://avatars.githubusercontent.com/u/14316954?v=3","gravatar_id":"","url":"https://api.github.com/users/DHowett-MSFT","html_url":"https://github.com/DHowett-MSFT","followers_url":"https://api.github.com/users/DHowett-MSFT/followers","following_url":"https://api.github.com/users/DHowett-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/DHowett-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/DHowett-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DHowett-MSFT/subscriptions","organizations_url":"https://api.github.com/users/DHowett-MSFT/orgs","repos_url":"https://api.github.com/users/DHowett-MSFT/repos","events_url":"https://api.github.com/users/DHowett-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/DHowett-MSFT/received_events","type":"User","site_admin":false},"body":"(Naming it `addUndoAction:` also matches the kind of thing you're adding to it: an action.)\r\n\r\n---\r\nIn reply to: [76707255](https://github.com/Microsoft/WinObjC/pull/900#discussion_r76707255) [](ancestors = 76707255)","created_at":"2016-08-29T23:36:45Z","updated_at":"2016-08-29T23:36:45Z","html_url":"https://github.com/Microsoft/WinObjC/pull/900#discussion_r76707650","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/76707650"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/900#discussion_r76707650"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900","id":82067401,"html_url":"https://github.com/Microsoft/WinObjC/pull/900","diff_url":"https://github.com/Microsoft/WinObjC/pull/900.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/900.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/900","number":900,"state":"open","locked":false,"title":"NSUndoManager - Basic Undo/Redo Actions","user":{"login":"MSFTFox","id":17168010,"avatar_url":"https://avatars.githubusercontent.com/u/17168010?v=3","gravatar_id":"","url":"https://api.github.com/users/MSFTFox","html_url":"https://github.com/MSFTFox","followers_url":"https://api.github.com/users/MSFTFox/followers","following_url":"https://api.github.com/users/MSFTFox/following{/other_user}","gists_url":"https://api.github.com/users/MSFTFox/gists{/gist_id}","starred_url":"https://api.github.com/users/MSFTFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSFTFox/subscriptions","organizations_url":"https://api.github.com/users/MSFTFox/orgs","repos_url":"https://api.github.com/users/MSFTFox/repos","events_url":"https://api.github.com/users/MSFTFox/events{/privacy}","received_events_url":"https://api.github.com/users/MSFTFox/received_events","type":"User","site_admin":false},"body":"Implement basic undo and redo operations for NSUndoManager with simple top level Undo Grouping.\r\n\r\nVerified by new unit tests.\r\n\r\nFix #808","created_at":"2016-08-20T03:24:06Z","updated_at":"2016-08-29T23:36:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2b4772910d003f5e1a5fd2e0072f83b2ec431a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/900/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/b60296e5fb793986c47ecbd5a205cf9724e293a4","head":{"label":"MSFTFox:henryfox/Undo","ref":"henryfox/Undo","sha":"b60296e5fb793986c47ecbd5a205cf9724e293a4","user":{"login":"MSFTFox","id":17168010,"avatar_url":"https://avatars.githubusercontent.com/u/17168010?v=3","gravatar_id":"","url":"https://api.github.com/users/MSFTFox","html_url":"https://github.com/MSFTFox","followers_url":"https://api.github.com/users/MSFTFox/followers","following_url":"https://api.github.com/users/MSFTFox/following{/other_user}","gists_url":"https://api.github.com/users/MSFTFox/gists{/gist_id}","starred_url":"https://api.github.com/users/MSFTFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSFTFox/subscriptions","organizations_url":"https://api.github.com/users/MSFTFox/orgs","repos_url":"https://api.github.com/users/MSFTFox/repos","events_url":"https://api.github.com/users/MSFTFox/events{/privacy}","received_events_url":"https://api.github.com/users/MSFTFox/received_events","type":"User","site_admin":false},"repo":{"id":63458119,"name":"WinObjC","full_name":"MSFTFox/WinObjC","owner":{"login":"MSFTFox","id":17168010,"avatar_url":"https://avatars.githubusercontent.com/u/17168010?v=3","gravatar_id":"","url":"https://api.github.com/users/MSFTFox","html_url":"https://github.com/MSFTFox","followers_url":"https://api.github.com/users/MSFTFox/followers","following_url":"https://api.github.com/users/MSFTFox/following{/other_user}","gists_url":"https://api.github.com/users/MSFTFox/gists{/gist_id}","starred_url":"https://api.github.com/users/MSFTFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSFTFox/subscriptions","organizations_url":"https://api.github.com/users/MSFTFox/orgs","repos_url":"https://api.github.com/users/MSFTFox/repos","events_url":"https://api.github.com/users/MSFTFox/events{/privacy}","received_events_url":"https://api.github.com/users/MSFTFox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MSFTFox/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/MSFTFox/WinObjC","forks_url":"https://api.github.com/repos/MSFTFox/WinObjC/forks","keys_url":"https://api.github.com/repos/MSFTFox/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSFTFox/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSFTFox/WinObjC/teams","hooks_url":"https://api.github.com/repos/MSFTFox/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/MSFTFox/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/MSFTFox/WinObjC/events","assignees_url":"https://api.github.com/repos/MSFTFox/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/MSFTFox/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/MSFTFox/WinObjC/tags","blobs_url":"https://api.github.com/repos/MSFTFox/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSFTFox/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSFTFox/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSFTFox/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSFTFox/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/MSFTFox/WinObjC/languages","stargazers_url":"https://api.github.com/repos/MSFTFox/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/MSFTFox/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/MSFTFox/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/MSFTFox/WinObjC/subscription","commits_url":"https://api.github.com/repos/MSFTFox/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSFTFox/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSFTFox/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSFTFox/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/MSFTFox/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/MSFTFox/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSFTFox/WinObjC/merges","archive_url":"https://api.github.com/repos/MSFTFox/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSFTFox/WinObjC/downloads","issues_url":"https://api.github.com/repos/MSFTFox/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/MSFTFox/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/MSFTFox/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/MSFTFox/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSFTFox/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/MSFTFox/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/MSFTFox/WinObjC/deployments","created_at":"2016-07-16T00:32:00Z","updated_at":"2016-07-16T00:32:15Z","pushed_at":"2016-08-29T22:09:29Z","git_url":"git://github.com/MSFTFox/WinObjC.git","ssh_url":"git@github.com:MSFTFox/WinObjC.git","clone_url":"https://github.com/MSFTFox/WinObjC.git","svn_url":"https://github.com/MSFTFox/WinObjC","homepage":"","size":331798,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"bcdaf7a8e2b19502947bc587c019514add60a8fe","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-08-28T22:51:01Z","pushed_at":"2016-08-29T22:27:12Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":335743,"stargazers_count":5424,"watchers_count":5424,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":694,"mirror_url":null,"open_issues_count":242,"forks":694,"open_issues":242,"watchers":5424,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/900"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/900"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/900/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/900/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/b60296e5fb793986c47ecbd5a205cf9724e293a4"}}}}
{"actor":{"display_login":"DHowett-MSFT"}}