{"action":"created","comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/comments/70076635","id":70076635,"diff_hunk":"@@ -18,12 +18,13 @@ defmodule PhoenixPubsubRedis.Mixfile do\n   end\n \n   def application do\n-    [applications: [:logger, :redo, :poolboy]]\n+    [applications: [:logger, :poolboy, :redix, :redix_pubsub]]\n   end\n \n   defp deps do\n-    [{:phoenix, \"~> 1.1\"},\n-     {:redo, \"~> 2.0.1\"},\n+    [{:phoenix_pubsub, \"~> 1.0\"},\n+     {:redix, \"~> 0.4.0\"},","path":"mix.exs","position":12,"original_position":12,"commit_id":"318016b88a20e7c89c6e09aecec9c08b9b71f06c","original_commit_id":"318016b88a20e7c89c6e09aecec9c08b9b71f06c","user":{"login":"lexmag","id":248290,"avatar_url":"https://avatars.githubusercontent.com/u/248290?v=3","gravatar_id":"","url":"https://api.github.com/users/lexmag","html_url":"https://github.com/lexmag","followers_url":"https://api.github.com/users/lexmag/followers","following_url":"https://api.github.com/users/lexmag/following{/other_user}","gists_url":"https://api.github.com/users/lexmag/gists{/gist_id}","starred_url":"https://api.github.com/users/lexmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexmag/subscriptions","organizations_url":"https://api.github.com/users/lexmag/orgs","repos_url":"https://api.github.com/users/lexmag/repos","events_url":"https://api.github.com/users/lexmag/events{/privacy}","received_events_url":"https://api.github.com/users/lexmag/received_events","type":"User","site_admin":false},"body":"We can remove this from dependencies since `redix_pubsub` depends on `redix` (also it starts application).","created_at":"2016-07-08T13:52:30Z","updated_at":"2016-07-08T13:52:30Z","html_url":"https://github.com/phoenixframework/phoenix_pubsub_redis/pull/14#discussion_r70076635","pull_request_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/comments/70076635"},"html":{"href":"https://github.com/phoenixframework/phoenix_pubsub_redis/pull/14#discussion_r70076635"},"pull_request":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14","id":68426159,"html_url":"https://github.com/phoenixframework/phoenix_pubsub_redis/pull/14","diff_url":"https://github.com/phoenixframework/phoenix_pubsub_redis/pull/14.diff","patch_url":"https://github.com/phoenixframework/phoenix_pubsub_redis/pull/14.patch","issue_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/issues/14","number":14,"state":"closed","locked":false,"title":"Use Redix","user":{"login":"mitchellhenke","id":1430443,"avatar_url":"https://avatars.githubusercontent.com/u/1430443?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellhenke","html_url":"https://github.com/mitchellhenke","followers_url":"https://api.github.com/users/mitchellhenke/followers","following_url":"https://api.github.com/users/mitchellhenke/following{/other_user}","gists_url":"https://api.github.com/users/mitchellhenke/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellhenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellhenke/subscriptions","organizations_url":"https://api.github.com/users/mitchellhenke/orgs","repos_url":"https://api.github.com/users/mitchellhenke/repos","events_url":"https://api.github.com/users/mitchellhenke/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellhenke/received_events","type":"User","site_admin":false},"body":"So there are some issues yet to work out, but this is my try at replacing redo with redix.\r\n\r\nThe biggest issue is behavior on startup when redis can't be reached.  Right now, if you start an app using these changes, the app will crash (where the previous redo version would not).  It's related to the call on init to connect, and I'm not sure what structure would better handle it.\r\n\r\nRedix always returns `{:ok, pid}` [here](https://github.com/mitchellhenke/phoenix_pubsub_redis/blob/redix/lib/phoenix_pubsub_redis/redis_server.ex#L108) (even if it's not), and this times out because the process returned goes down immediately, causing it to fail [here](https://github.com/mitchellhenke/phoenix_pubsub_redis/blob/redix/lib/phoenix_pubsub_redis/redis_server.ex#L102), and so `Phoenix.PubSub.RedisServer` crashes the entire tree on start since it never finishes starting.\r\n\r\nI hope I'm headed somewhat in the right direction, and would be happy to keep trying if you have time to help me through the aforementioned issue, as well as any others you see.","created_at":"2016-04-29T20:04:47Z","updated_at":"2016-07-08T13:52:30Z","closed_at":"2016-07-05T16:00:01Z","merged_at":"2016-07-05T16:00:01Z","merge_commit_sha":"c94dd3751f80d48451d7e257eaa555863c31c947","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14/commits","review_comments_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14/comments","review_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/issues/14/comments","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/statuses/318016b88a20e7c89c6e09aecec9c08b9b71f06c","head":{"label":"mitchellhenke:redix","ref":"redix","sha":"318016b88a20e7c89c6e09aecec9c08b9b71f06c","user":{"login":"mitchellhenke","id":1430443,"avatar_url":"https://avatars.githubusercontent.com/u/1430443?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellhenke","html_url":"https://github.com/mitchellhenke","followers_url":"https://api.github.com/users/mitchellhenke/followers","following_url":"https://api.github.com/users/mitchellhenke/following{/other_user}","gists_url":"https://api.github.com/users/mitchellhenke/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellhenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellhenke/subscriptions","organizations_url":"https://api.github.com/users/mitchellhenke/orgs","repos_url":"https://api.github.com/users/mitchellhenke/repos","events_url":"https://api.github.com/users/mitchellhenke/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellhenke/received_events","type":"User","site_admin":false},"repo":{"id":52481783,"name":"phoenix_pubsub_redis","full_name":"mitchellhenke/phoenix_pubsub_redis","owner":{"login":"mitchellhenke","id":1430443,"avatar_url":"https://avatars.githubusercontent.com/u/1430443?v=3","gravatar_id":"","url":"https://api.github.com/users/mitchellhenke","html_url":"https://github.com/mitchellhenke","followers_url":"https://api.github.com/users/mitchellhenke/followers","following_url":"https://api.github.com/users/mitchellhenke/following{/other_user}","gists_url":"https://api.github.com/users/mitchellhenke/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellhenke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellhenke/subscriptions","organizations_url":"https://api.github.com/users/mitchellhenke/orgs","repos_url":"https://api.github.com/users/mitchellhenke/repos","events_url":"https://api.github.com/users/mitchellhenke/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellhenke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitchellhenke/phoenix_pubsub_redis","description":"The Redis PubSub adapter for the Phoenix framework","fork":true,"url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis","forks_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/forks","keys_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/teams","hooks_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/hooks","issue_events_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/issues/events{/number}","events_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/events","assignees_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/assignees{/user}","branches_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/branches{/branch}","tags_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/tags","blobs_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/statuses/{sha}","languages_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/languages","stargazers_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/stargazers","contributors_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/contributors","subscribers_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/subscribers","subscription_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/subscription","commits_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/contents/{+path}","compare_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/merges","archive_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/downloads","issues_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/issues{/number}","pulls_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/pulls{/number}","milestones_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/milestones{/number}","notifications_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/labels{/name}","releases_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/releases{/id}","deployments_url":"https://api.github.com/repos/mitchellhenke/phoenix_pubsub_redis/deployments","created_at":"2016-02-24T23:21:53Z","updated_at":"2016-02-24T23:21:53Z","pushed_at":"2016-07-07T14:28:42Z","git_url":"git://github.com/mitchellhenke/phoenix_pubsub_redis.git","ssh_url":"git@github.com:mitchellhenke/phoenix_pubsub_redis.git","clone_url":"https://github.com/mitchellhenke/phoenix_pubsub_redis.git","svn_url":"https://github.com/mitchellhenke/phoenix_pubsub_redis","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phoenixframework:master","ref":"master","sha":"9045d1b906704a57d8da2646191393c8b7559506","user":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35987648,"name":"phoenix_pubsub_redis","full_name":"phoenixframework/phoenix_pubsub_redis","owner":{"login":"phoenixframework","id":6510388,"avatar_url":"https://avatars.githubusercontent.com/u/6510388?v=3","gravatar_id":"","url":"https://api.github.com/users/phoenixframework","html_url":"https://github.com/phoenixframework","followers_url":"https://api.github.com/users/phoenixframework/followers","following_url":"https://api.github.com/users/phoenixframework/following{/other_user}","gists_url":"https://api.github.com/users/phoenixframework/gists{/gist_id}","starred_url":"https://api.github.com/users/phoenixframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoenixframework/subscriptions","organizations_url":"https://api.github.com/users/phoenixframework/orgs","repos_url":"https://api.github.com/users/phoenixframework/repos","events_url":"https://api.github.com/users/phoenixframework/events{/privacy}","received_events_url":"https://api.github.com/users/phoenixframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phoenixframework/phoenix_pubsub_redis","description":"The Redis PubSub adapter for the Phoenix framework","fork":false,"url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis","forks_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/forks","keys_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/teams","hooks_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/hooks","issue_events_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/issues/events{/number}","events_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/events","assignees_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/assignees{/user}","branches_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/branches{/branch}","tags_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/tags","blobs_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/statuses/{sha}","languages_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/languages","stargazers_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/stargazers","contributors_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/contributors","subscribers_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/subscribers","subscription_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/subscription","commits_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/issues/comments{/number}","contents_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/contents/{+path}","compare_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/merges","archive_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/downloads","issues_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/issues{/number}","pulls_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls{/number}","milestones_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/milestones{/number}","notifications_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/labels{/name}","releases_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/releases{/id}","deployments_url":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/deployments","created_at":"2015-05-21T03:00:32Z","updated_at":"2016-07-06T23:30:25Z","pushed_at":"2016-07-07T21:03:00Z","git_url":"git://github.com/phoenixframework/phoenix_pubsub_redis.git","ssh_url":"git@github.com:phoenixframework/phoenix_pubsub_redis.git","clone_url":"https://github.com/phoenixframework/phoenix_pubsub_redis.git","svn_url":"https://github.com/phoenixframework/phoenix_pubsub_redis","homepage":null,"size":44,"stargazers_count":44,"watchers_count":44,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":0,"forks":16,"open_issues":0,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14"},"html":{"href":"https://github.com/phoenixframework/phoenix_pubsub_redis/pull/14"},"issue":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/issues/14"},"comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/phoenixframework/phoenix_pubsub_redis/statuses/318016b88a20e7c89c6e09aecec9c08b9b71f06c"}}}}
{"actor":{"display_login":"lexmag"}}