{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/9093","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/9093/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9093/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/9093/events","html_url":"https://github.com/ceph/ceph/pull/9093","id":154450241,"number":9093,"title":"rbd: do not flush rbd cache if journaling is enabled","user":{"login":"zhouyuan","id":43917,"avatar_url":"https://avatars.githubusercontent.com/u/43917?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyuan","html_url":"https://github.com/zhouyuan","followers_url":"https://api.github.com/users/zhouyuan/followers","following_url":"https://api.github.com/users/zhouyuan/following{/other_user}","gists_url":"https://api.github.com/users/zhouyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyuan/subscriptions","organizations_url":"https://api.github.com/users/zhouyuan/orgs","repos_url":"https://api.github.com/users/zhouyuan/repos","events_url":"https://api.github.com/users/zhouyuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyuan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ceph/ceph/labels/performance","name":"performance","color":"bfdadc"},{"url":"https://api.github.com/repos/ceph/ceph/labels/rbd","name":"rbd","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"dillaman","id":4739042,"avatar_url":"https://avatars.githubusercontent.com/u/4739042?v=3","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2016-05-12T10:35:26Z","updated_at":"2016-05-17T03:47:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9093","html_url":"https://github.com/ceph/ceph/pull/9093","diff_url":"https://github.com/ceph/ceph/pull/9093.diff","patch_url":"https://github.com/ceph/ceph/pull/9093.patch"},"body":"With journaling rbd writes will be persisteted on rbd journal objects.\r\nThe journal will be replayed if crash happen. So it's not necessary to\r\nflush rbd_cache in this case. This will improve the flush latency.\r\n\r\nThis patch adds checking on handling aio_flush: if journaling is\r\nenabled, rbd cache flushing is skipped.\r\nIn a system flush(ImageCtx::flush) the cache is flushed even w/ journaling\r\nwhere we truly do need to flush all IO out to disk.\r\n\r\nFixes: http://tracker.ceph.com/issues/15761\r\n\r\nSigned-off-by: Yuan Zhou <yuan.zhou@intel.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/219612536","html_url":"https://github.com/ceph/ceph/pull/9093#issuecomment-219612536","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9093","id":219612536,"user":{"login":"zhouyuan","id":43917,"avatar_url":"https://avatars.githubusercontent.com/u/43917?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyuan","html_url":"https://github.com/zhouyuan","followers_url":"https://api.github.com/users/zhouyuan/followers","following_url":"https://api.github.com/users/zhouyuan/following{/other_user}","gists_url":"https://api.github.com/users/zhouyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyuan/subscriptions","organizations_url":"https://api.github.com/users/zhouyuan/orgs","repos_url":"https://api.github.com/users/zhouyuan/repos","events_url":"https://api.github.com/users/zhouyuan/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyuan/received_events","type":"User","site_admin":false},"created_at":"2016-05-17T03:47:31Z","updated_at":"2016-05-17T03:47:31Z","body":"@dillaman updated. Thanks for the comments!"}}