{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-core/pulls/comments/63785635","id":63785635,"diff_hunk":"@@ -363,6 +376,14 @@ function lookupServiceFactory(\n     LookupService.prototype.setIpAddress = function (ip, mac) {\n         return waterline.lookups.setIp(ip, mac);\n     };\n+    \n+    LookupService.prototype.validateArpCache = function () {\n+        var self = this;\n+        return arpCache.getCurrent()\n+        .map(function(entry) {\n+            return self.setIpAddress(entry.ip, entry.mac);\n+        })","path":"lib/services/lookup.js","position":240,"original_position":240,"commit_id":"1ff661c9b519a15cc3d14540ef737beb68495ccd","original_commit_id":"1ff661c9b519a15cc3d14540ef737beb68495ccd","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2016-05-18T21:28:19Z","updated_at":"2016-05-18T21:28:19Z","html_url":"https://github.com/RackHD/on-core/pull/145#discussion_r63785635","pull_request_url":"https://api.github.com/repos/RackHD/on-core/pulls/145","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/comments/63785635"},"html":{"href":"https://github.com/RackHD/on-core/pull/145#discussion_r63785635"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-core/pulls/145","id":70602406,"html_url":"https://github.com/RackHD/on-core/pull/145","diff_url":"https://github.com/RackHD/on-core/pull/145.diff","patch_url":"https://github.com/RackHD/on-core/pull/145.patch","issue_url":"https://api.github.com/repos/RackHD/on-core/issues/145","number":145,"state":"open","locked":false,"title":"Move ARP handler into lookups service","user":{"login":"jlongever","id":13769308,"avatar_url":"https://avatars.githubusercontent.com/u/13769308?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongever","html_url":"https://github.com/jlongever","followers_url":"https://api.github.com/users/jlongever/followers","following_url":"https://api.github.com/users/jlongever/following{/other_user}","gists_url":"https://api.github.com/users/jlongever/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongever/subscriptions","organizations_url":"https://api.github.com/users/jlongever/orgs","repos_url":"https://api.github.com/users/jlongever/repos","events_url":"https://api.github.com/users/jlongever/events{/privacy}","received_events_url":"https://api.github.com/users/jlongever/received_events","type":"User","site_admin":false},"body":"Moves the ARP handler into the lookups services deprecating ARP poller in on-taskgraph.  \r\n\r\nSolves a couple known issues with existing ARP poller design:\r\n1. Potential race condition when issuing a POST to /lookups on an IP change,  current ARP poller may see the ARP entry update and update the entry resulting in 500 response on the POST.\r\n2. The existing poller runs as a job in on-taskgraph creating the prerequisite to run on-taskgraph on the same host that is taking the IP request from a client to ensure the hosts ARP table is current.  \r\n\r\n@RackHD/corecommitters @uppalk1 @zyoung51 @tannoa2 @keedya ","created_at":"2016-05-18T21:28:13Z","updated_at":"2016-05-18T21:28:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ae02ac92f747708d1463dbb046d9f354e302a30","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-core/pulls/145/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-core/pulls/145/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-core/issues/145/comments","statuses_url":"https://api.github.com/repos/RackHD/on-core/statuses/1ff661c9b519a15cc3d14540ef737beb68495ccd","head":{"label":"jlongever:feature/check_arp_cache_in_lookups","ref":"feature/check_arp_cache_in_lookups","sha":"1ff661c9b519a15cc3d14540ef737beb68495ccd","user":{"login":"jlongever","id":13769308,"avatar_url":"https://avatars.githubusercontent.com/u/13769308?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongever","html_url":"https://github.com/jlongever","followers_url":"https://api.github.com/users/jlongever/followers","following_url":"https://api.github.com/users/jlongever/following{/other_user}","gists_url":"https://api.github.com/users/jlongever/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongever/subscriptions","organizations_url":"https://api.github.com/users/jlongever/orgs","repos_url":"https://api.github.com/users/jlongever/repos","events_url":"https://api.github.com/users/jlongever/events{/privacy}","received_events_url":"https://api.github.com/users/jlongever/received_events","type":"User","site_admin":false},"repo":{"id":47630071,"name":"on-core","full_name":"jlongever/on-core","owner":{"login":"jlongever","id":13769308,"avatar_url":"https://avatars.githubusercontent.com/u/13769308?v=3","gravatar_id":"","url":"https://api.github.com/users/jlongever","html_url":"https://github.com/jlongever","followers_url":"https://api.github.com/users/jlongever/followers","following_url":"https://api.github.com/users/jlongever/following{/other_user}","gists_url":"https://api.github.com/users/jlongever/gists{/gist_id}","starred_url":"https://api.github.com/users/jlongever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlongever/subscriptions","organizations_url":"https://api.github.com/users/jlongever/orgs","repos_url":"https://api.github.com/users/jlongever/repos","events_url":"https://api.github.com/users/jlongever/events{/privacy}","received_events_url":"https://api.github.com/users/jlongever/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlongever/on-core","description":"","fork":true,"url":"https://api.github.com/repos/jlongever/on-core","forks_url":"https://api.github.com/repos/jlongever/on-core/forks","keys_url":"https://api.github.com/repos/jlongever/on-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlongever/on-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlongever/on-core/teams","hooks_url":"https://api.github.com/repos/jlongever/on-core/hooks","issue_events_url":"https://api.github.com/repos/jlongever/on-core/issues/events{/number}","events_url":"https://api.github.com/repos/jlongever/on-core/events","assignees_url":"https://api.github.com/repos/jlongever/on-core/assignees{/user}","branches_url":"https://api.github.com/repos/jlongever/on-core/branches{/branch}","tags_url":"https://api.github.com/repos/jlongever/on-core/tags","blobs_url":"https://api.github.com/repos/jlongever/on-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlongever/on-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlongever/on-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlongever/on-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlongever/on-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jlongever/on-core/languages","stargazers_url":"https://api.github.com/repos/jlongever/on-core/stargazers","contributors_url":"https://api.github.com/repos/jlongever/on-core/contributors","subscribers_url":"https://api.github.com/repos/jlongever/on-core/subscribers","subscription_url":"https://api.github.com/repos/jlongever/on-core/subscription","commits_url":"https://api.github.com/repos/jlongever/on-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlongever/on-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlongever/on-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlongever/on-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlongever/on-core/contents/{+path}","compare_url":"https://api.github.com/repos/jlongever/on-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlongever/on-core/merges","archive_url":"https://api.github.com/repos/jlongever/on-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlongever/on-core/downloads","issues_url":"https://api.github.com/repos/jlongever/on-core/issues{/number}","pulls_url":"https://api.github.com/repos/jlongever/on-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jlongever/on-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jlongever/on-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlongever/on-core/labels{/name}","releases_url":"https://api.github.com/repos/jlongever/on-core/releases{/id}","deployments_url":"https://api.github.com/repos/jlongever/on-core/deployments","created_at":"2015-12-08T15:17:00Z","updated_at":"2016-01-13T02:03:48Z","pushed_at":"2016-05-18T19:24:24Z","git_url":"git://github.com/jlongever/on-core.git","ssh_url":"git@github.com:jlongever/on-core.git","clone_url":"https://github.com/jlongever/on-core.git","svn_url":"https://github.com/jlongever/on-core","homepage":null,"size":982,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"d2c5066ab31001d05935f90f5094f2f18a9cf009","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690044,"name":"on-core","full_name":"RackHD/on-core","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-core","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-core","forks_url":"https://api.github.com/repos/RackHD/on-core/forks","keys_url":"https://api.github.com/repos/RackHD/on-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-core/teams","hooks_url":"https://api.github.com/repos/RackHD/on-core/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-core/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-core/events","assignees_url":"https://api.github.com/repos/RackHD/on-core/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-core/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-core/tags","blobs_url":"https://api.github.com/repos/RackHD/on-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-core/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-core/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-core/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-core/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-core/subscription","commits_url":"https://api.github.com/repos/RackHD/on-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-core/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-core/merges","archive_url":"https://api.github.com/repos/RackHD/on-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-core/downloads","issues_url":"https://api.github.com/repos/RackHD/on-core/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-core/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-core/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-core/deployments","created_at":"2015-08-31T17:28:32Z","updated_at":"2016-01-31T09:01:09Z","pushed_at":"2016-05-18T21:28:14Z","git_url":"git://github.com/RackHD/on-core.git","ssh_url":"git@github.com:RackHD/on-core.git","clone_url":"https://github.com/RackHD/on-core.git","svn_url":"https://github.com/RackHD/on-core","homepage":null,"size":1044,"stargazers_count":9,"watchers_count":9,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":6,"forks":32,"open_issues":6,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/145"},"html":{"href":"https://github.com/RackHD/on-core/pull/145"},"issue":{"href":"https://api.github.com/repos/RackHD/on-core/issues/145"},"comments":{"href":"https://api.github.com/repos/RackHD/on-core/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-core/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-core/statuses/1ff661c9b519a15cc3d14540ef737beb68495ccd"}}}}