{"action":"opened","number":52,"pull_request":{"url":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/52","id":76199917,"html_url":"https://github.com/jcalazan/ansible-django-stack/pull/52","diff_url":"https://github.com/jcalazan/ansible-django-stack/pull/52.diff","patch_url":"https://github.com/jcalazan/ansible-django-stack/pull/52.patch","issue_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/issues/52","number":52,"state":"open","locked":false,"title":"Remove erroneous usage of default(omit)","user":{"login":"DavidCain","id":901169,"avatar_url":"https://avatars.githubusercontent.com/u/901169?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidCain","html_url":"https://github.com/DavidCain","followers_url":"https://api.github.com/users/DavidCain/followers","following_url":"https://api.github.com/users/DavidCain/following{/other_user}","gists_url":"https://api.github.com/users/DavidCain/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidCain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidCain/subscriptions","organizations_url":"https://api.github.com/users/DavidCain/orgs","repos_url":"https://api.github.com/users/DavidCain/repos","events_url":"https://api.github.com/users/DavidCain/events{/privacy}","received_events_url":"https://api.github.com/users/DavidCain/received_events","type":"User","site_admin":false},"body":"Unfortunately, `default(omit)` \"is a hack that applies only to the argument 4 passed to a module.\" (https://github.com/ansible/ansible/issues/14130)\r\n\r\nThis pattern creates problems for the postactivate script as well as any usage of `environment: \"{{ django_environment }}\"` as any omitted variables will be set to `\"__omit_place_holder__<token>\"`\r\n\r\nThis pattern doesn't currently create any problems since all the key Django environment variables are defined. However, if one were to copy this pattern (say, for creating additional optional Django environment vars) or rely on any omitted environment variables to not be set, you'd have an unexpected result.\r\n\r\n----\r\n\r\n```bash\r\nvagrant up\r\nvagrant ssh\r\nsudo cat /webapps/youtubeadl/bin/postactivate\r\n#!/bin/sh\r\n\r\nexport EMAIL_HOST_PASSWORD=\"__omit_place_holder__05e91510b2a8eaa87af350f16cb45ebaf41346e1\"\r\nexport STATIC_ROOT=\"/webapps/youtubeadl/static/\"\r\n...\r\nexport EMAIL_HOST_USER=\"__omit_place_holder__05e91510b2a8eaa87af350f16cb45ebaf41346e1\"\r\nexport EMAIL_HOST=\"__omit_place_holder__05e91510b2a8eaa87af350f16cb45ebaf41346e1\"\r\n```\r\n\r\n","created_at":"2016-07-04T21:02:01Z","updated_at":"2016-07-04T21:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/52/commits","review_comments_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/52/comments","review_comment_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/issues/52/comments","statuses_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/statuses/4b26b70b71f5c20f5501ecda31ada767f45262c1","head":{"label":"DavidCain:DavidCain/remove_enviornment_default_omit","ref":"DavidCain/remove_enviornment_default_omit","sha":"4b26b70b71f5c20f5501ecda31ada767f45262c1","user":{"login":"DavidCain","id":901169,"avatar_url":"https://avatars.githubusercontent.com/u/901169?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidCain","html_url":"https://github.com/DavidCain","followers_url":"https://api.github.com/users/DavidCain/followers","following_url":"https://api.github.com/users/DavidCain/following{/other_user}","gists_url":"https://api.github.com/users/DavidCain/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidCain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidCain/subscriptions","organizations_url":"https://api.github.com/users/DavidCain/orgs","repos_url":"https://api.github.com/users/DavidCain/repos","events_url":"https://api.github.com/users/DavidCain/events{/privacy}","received_events_url":"https://api.github.com/users/DavidCain/received_events","type":"User","site_admin":false},"repo":{"id":60142687,"name":"ansible-django-stack","full_name":"DavidCain/ansible-django-stack","owner":{"login":"DavidCain","id":901169,"avatar_url":"https://avatars.githubusercontent.com/u/901169?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidCain","html_url":"https://github.com/DavidCain","followers_url":"https://api.github.com/users/DavidCain/followers","following_url":"https://api.github.com/users/DavidCain/following{/other_user}","gists_url":"https://api.github.com/users/DavidCain/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidCain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidCain/subscriptions","organizations_url":"https://api.github.com/users/DavidCain/orgs","repos_url":"https://api.github.com/users/DavidCain/repos","events_url":"https://api.github.com/users/DavidCain/events{/privacy}","received_events_url":"https://api.github.com/users/DavidCain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavidCain/ansible-django-stack","description":"Ansible Playbook for setting up a Django app with Nginx, Gunicorn, PostgreSQL, Celery, RabbitMQ, Supervisor, Virtualenv, and Memcached. A Vagrantfile for provisioning a VirtualBox virtual machine is included as well.","fork":true,"url":"https://api.github.com/repos/DavidCain/ansible-django-stack","forks_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/forks","keys_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/teams","hooks_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/hooks","issue_events_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/issues/events{/number}","events_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/events","assignees_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/assignees{/user}","branches_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/branches{/branch}","tags_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/tags","blobs_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/languages","stargazers_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/stargazers","contributors_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/contributors","subscribers_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/subscribers","subscription_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/subscription","commits_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/contents/{+path}","compare_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/merges","archive_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/downloads","issues_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/issues{/number}","pulls_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/labels{/name}","releases_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/releases{/id}","deployments_url":"https://api.github.com/repos/DavidCain/ansible-django-stack/deployments","created_at":"2016-06-01T03:30:19Z","updated_at":"2016-06-01T03:30:20Z","pushed_at":"2016-07-04T21:01:42Z","git_url":"git://github.com/DavidCain/ansible-django-stack.git","ssh_url":"git@github.com:DavidCain/ansible-django-stack.git","clone_url":"https://github.com/DavidCain/ansible-django-stack.git","svn_url":"https://github.com/DavidCain/ansible-django-stack","homepage":"","size":75,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jcalazan:master","ref":"master","sha":"a78d5256cb308b47197329b69181830bdc9b6c2d","user":{"login":"jcalazan","id":940937,"avatar_url":"https://avatars.githubusercontent.com/u/940937?v=3","gravatar_id":"","url":"https://api.github.com/users/jcalazan","html_url":"https://github.com/jcalazan","followers_url":"https://api.github.com/users/jcalazan/followers","following_url":"https://api.github.com/users/jcalazan/following{/other_user}","gists_url":"https://api.github.com/users/jcalazan/gists{/gist_id}","starred_url":"https://api.github.com/users/jcalazan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcalazan/subscriptions","organizations_url":"https://api.github.com/users/jcalazan/orgs","repos_url":"https://api.github.com/users/jcalazan/repos","events_url":"https://api.github.com/users/jcalazan/events{/privacy}","received_events_url":"https://api.github.com/users/jcalazan/received_events","type":"User","site_admin":false},"repo":{"id":18198998,"name":"ansible-django-stack","full_name":"jcalazan/ansible-django-stack","owner":{"login":"jcalazan","id":940937,"avatar_url":"https://avatars.githubusercontent.com/u/940937?v=3","gravatar_id":"","url":"https://api.github.com/users/jcalazan","html_url":"https://github.com/jcalazan","followers_url":"https://api.github.com/users/jcalazan/followers","following_url":"https://api.github.com/users/jcalazan/following{/other_user}","gists_url":"https://api.github.com/users/jcalazan/gists{/gist_id}","starred_url":"https://api.github.com/users/jcalazan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcalazan/subscriptions","organizations_url":"https://api.github.com/users/jcalazan/orgs","repos_url":"https://api.github.com/users/jcalazan/repos","events_url":"https://api.github.com/users/jcalazan/events{/privacy}","received_events_url":"https://api.github.com/users/jcalazan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcalazan/ansible-django-stack","description":"Ansible Playbook for setting up a Django app with Nginx, Gunicorn, PostgreSQL, Celery, RabbitMQ, Supervisor, Virtualenv, and Memcached. A Vagrantfile for provisioning a VirtualBox virtual machine is included as well.","fork":false,"url":"https://api.github.com/repos/jcalazan/ansible-django-stack","forks_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/forks","keys_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/teams","hooks_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/hooks","issue_events_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/issues/events{/number}","events_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/events","assignees_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/assignees{/user}","branches_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/branches{/branch}","tags_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/tags","blobs_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/statuses/{sha}","languages_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/languages","stargazers_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/stargazers","contributors_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/contributors","subscribers_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/subscribers","subscription_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/subscription","commits_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/contents/{+path}","compare_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/merges","archive_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/downloads","issues_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/issues{/number}","pulls_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls{/number}","milestones_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/milestones{/number}","notifications_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/labels{/name}","releases_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/releases{/id}","deployments_url":"https://api.github.com/repos/jcalazan/ansible-django-stack/deployments","created_at":"2014-03-28T02:42:36Z","updated_at":"2016-07-04T19:30:44Z","pushed_at":"2016-07-04T21:02:01Z","git_url":"git://github.com/jcalazan/ansible-django-stack.git","ssh_url":"git@github.com:jcalazan/ansible-django-stack.git","clone_url":"https://github.com/jcalazan/ansible-django-stack.git","svn_url":"https://github.com/jcalazan/ansible-django-stack","homepage":"","size":89,"stargazers_count":547,"watchers_count":547,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"open_issues_count":12,"forks":203,"open_issues":12,"watchers":547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/52"},"html":{"href":"https://github.com/jcalazan/ansible-django-stack/pull/52"},"issue":{"href":"https://api.github.com/repos/jcalazan/ansible-django-stack/issues/52"},"comments":{"href":"https://api.github.com/repos/jcalazan/ansible-django-stack/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jcalazan/ansible-django-stack/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/jcalazan/ansible-django-stack/statuses/4b26b70b71f5c20f5501ecda31ada767f45262c1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"DavidCain"}}