{"action":"closed","number":1558,"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1558","id":98252809,"html_url":"https://github.com/Microsoft/WinObjC/pull/1558","diff_url":"https://github.com/Microsoft/WinObjC/pull/1558.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/1558.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1558","number":1558,"state":"closed","locked":false,"title":"Fix some CoreText perf low-hanging fruit","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"body":" - Remove NSLayoutManager __lineHasGlyphsAfterIndex(), which is called multiple times per line\r\n    - Instead, directly search for the index of the last visible glyph once, compare against this\r\n\r\n - DWriteWrapper_CoreText\r\n    - Skip first range of attributes in __DWriteTextLayoutCreate()\r\n        - was redundant due to the underlaying Format already taking it into account\r\n    - reserve() ahead of time for glyphRunDescriptionInfo._clusterMap, CTRun->_glyphOrigins, ->_glyphAdvances\r\n        - A lot of time was being spent in reallocation, resizing\r\n\r\n - Remove DWriteWrapper _GetUserDefaultLocaleName(), don't wrap in a wstring, directly use a wchar_t buffer\r\n - Reduce the number of character buffer copies in _CFStringFromLocalizedString() by 1\r\n - Remove unused/not useful _characters member from CTTypesetter\r\n\r\n - Misc\r\n\r\nRelated to #1374\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/microsoft/winobjc/1558)\n<!-- Reviewable:end -->\n","created_at":"2016-12-15T23:36:08Z","updated_at":"2016-12-16T21:41:27Z","closed_at":"2016-12-16T21:41:27Z","merged_at":"2016-12-16T21:41:27Z","merge_commit_sha":"c1ddbd9640612d9b1813b138fde7ebe1dfd67181","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1558/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1558/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/1558/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/e8fc5e3e8c3db0655d2786a6a4b20b95372267d9","head":{"label":"ms-jihua:coretext_perf_lowfruit","ref":"coretext_perf_lowfruit","sha":"e8fc5e3e8c3db0655d2786a6a4b20b95372267d9","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"repo":{"id":63092436,"name":"WinObjC","full_name":"ms-jihua/WinObjC","owner":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ms-jihua/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/ms-jihua/WinObjC","forks_url":"https://api.github.com/repos/ms-jihua/WinObjC/forks","keys_url":"https://api.github.com/repos/ms-jihua/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ms-jihua/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ms-jihua/WinObjC/teams","hooks_url":"https://api.github.com/repos/ms-jihua/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/ms-jihua/WinObjC/events","assignees_url":"https://api.github.com/repos/ms-jihua/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/ms-jihua/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/ms-jihua/WinObjC/tags","blobs_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ms-jihua/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/ms-jihua/WinObjC/languages","stargazers_url":"https://api.github.com/repos/ms-jihua/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/ms-jihua/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/ms-jihua/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/ms-jihua/WinObjC/subscription","commits_url":"https://api.github.com/repos/ms-jihua/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/ms-jihua/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/ms-jihua/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/ms-jihua/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ms-jihua/WinObjC/merges","archive_url":"https://api.github.com/repos/ms-jihua/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ms-jihua/WinObjC/downloads","issues_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/ms-jihua/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/ms-jihua/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/ms-jihua/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ms-jihua/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/ms-jihua/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/ms-jihua/WinObjC/deployments","created_at":"2016-07-11T18:32:57Z","updated_at":"2016-07-11T18:33:10Z","pushed_at":"2016-12-16T20:19:59Z","git_url":"git://github.com/ms-jihua/WinObjC.git","ssh_url":"git@github.com:ms-jihua/WinObjC.git","clone_url":"https://github.com/ms-jihua/WinObjC.git","svn_url":"https://github.com/ms-jihua/WinObjC","homepage":"","size":335713,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"f8c7157eb12457eda54c0c8f0bd8029ab0908658","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-12-16T18:01:52Z","pushed_at":"2016-12-16T21:41:27Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":375294,"stargazers_count":5551,"watchers_count":5551,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":739,"mirror_url":null,"open_issues_count":307,"forks":739,"open_issues":307,"watchers":5551,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1558"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/1558"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1558"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/1558/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1558/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/1558/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/e8fc5e3e8c3db0655d2786a6a4b20b95372267d9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"comments":2,"review_comments":14,"commits":1,"additions":95,"deletions":86,"changed_files":8}}
{"actor":{"display_login":"ms-jihua"}}