{"action":"closed","number":237,"pull_request":{"url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/237","id":63824937,"html_url":"https://github.com/Microsoft/MIEngine/pull/237","diff_url":"https://github.com/Microsoft/MIEngine/pull/237.diff","patch_url":"https://github.com/Microsoft/MIEngine/pull/237.patch","issue_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/237","number":237,"state":"closed","locked":false,"title":"Be more eager about cleaning up GDB variable objects","user":{"login":"andrewcrawley","id":17841637,"avatar_url":"https://avatars.githubusercontent.com/u/17841637?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewcrawley","html_url":"https://github.com/andrewcrawley","followers_url":"https://api.github.com/users/andrewcrawley/followers","following_url":"https://api.github.com/users/andrewcrawley/following{/other_user}","gists_url":"https://api.github.com/users/andrewcrawley/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewcrawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewcrawley/subscriptions","organizations_url":"https://api.github.com/users/andrewcrawley/orgs","repos_url":"https://api.github.com/users/andrewcrawley/repos","events_url":"https://api.github.com/users/andrewcrawley/events{/privacy}","received_events_url":"https://api.github.com/users/andrewcrawley/received_events","type":"User","site_admin":false},"body":"Waiting for VariableInfo objects to be GC'ed before cleaning up the corresponding object on the GDB side means that GDB can end up with a lot of memory usage due to unused objects before the MIEngine side experiences enough memory pressure to trigger a GC.\r\n\r\nWe can fix this by keeping a list of active VariableInfo objects and disposing any that exist when we enter break mode, as they must have been created during an earlier break and are no longer valid anyway.\r\n\r\n@jacdavis @gregg-miskelly @chuckries @paulmaybee ","created_at":"2016-03-23T03:00:50Z","updated_at":"2016-03-23T23:57:56Z","closed_at":"2016-03-23T23:57:55Z","merged_at":"2016-03-23T23:57:55Z","merge_commit_sha":"b2e58881643b2633598c06069905a8cd7f91fb2d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/237/commits","review_comments_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/237/comments","review_comment_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/237/comments","statuses_url":"https://api.github.com/repos/Microsoft/MIEngine/statuses/fec21c1c432aeabae52be66c3fc2186ea33cea68","head":{"label":"andrewcrawley:users/andrewcr/fix-variable-leak","ref":"users/andrewcr/fix-variable-leak","sha":"fec21c1c432aeabae52be66c3fc2186ea33cea68","user":{"login":"andrewcrawley","id":17841637,"avatar_url":"https://avatars.githubusercontent.com/u/17841637?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewcrawley","html_url":"https://github.com/andrewcrawley","followers_url":"https://api.github.com/users/andrewcrawley/followers","following_url":"https://api.github.com/users/andrewcrawley/following{/other_user}","gists_url":"https://api.github.com/users/andrewcrawley/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewcrawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewcrawley/subscriptions","organizations_url":"https://api.github.com/users/andrewcrawley/orgs","repos_url":"https://api.github.com/users/andrewcrawley/repos","events_url":"https://api.github.com/users/andrewcrawley/events{/privacy}","received_events_url":"https://api.github.com/users/andrewcrawley/received_events","type":"User","site_admin":false},"repo":{"id":53908908,"name":"MIEngine","full_name":"andrewcrawley/MIEngine","owner":{"login":"andrewcrawley","id":17841637,"avatar_url":"https://avatars.githubusercontent.com/u/17841637?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewcrawley","html_url":"https://github.com/andrewcrawley","followers_url":"https://api.github.com/users/andrewcrawley/followers","following_url":"https://api.github.com/users/andrewcrawley/following{/other_user}","gists_url":"https://api.github.com/users/andrewcrawley/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewcrawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewcrawley/subscriptions","organizations_url":"https://api.github.com/users/andrewcrawley/orgs","repos_url":"https://api.github.com/users/andrewcrawley/repos","events_url":"https://api.github.com/users/andrewcrawley/events{/privacy}","received_events_url":"https://api.github.com/users/andrewcrawley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewcrawley/MIEngine","description":"The Visual Studio MI Debug Engine (\"MIEngine\") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb, lldb, and clrdbg. ","fork":true,"url":"https://api.github.com/repos/andrewcrawley/MIEngine","forks_url":"https://api.github.com/repos/andrewcrawley/MIEngine/forks","keys_url":"https://api.github.com/repos/andrewcrawley/MIEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewcrawley/MIEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewcrawley/MIEngine/teams","hooks_url":"https://api.github.com/repos/andrewcrawley/MIEngine/hooks","issue_events_url":"https://api.github.com/repos/andrewcrawley/MIEngine/issues/events{/number}","events_url":"https://api.github.com/repos/andrewcrawley/MIEngine/events","assignees_url":"https://api.github.com/repos/andrewcrawley/MIEngine/assignees{/user}","branches_url":"https://api.github.com/repos/andrewcrawley/MIEngine/branches{/branch}","tags_url":"https://api.github.com/repos/andrewcrawley/MIEngine/tags","blobs_url":"https://api.github.com/repos/andrewcrawley/MIEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewcrawley/MIEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewcrawley/MIEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewcrawley/MIEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewcrawley/MIEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewcrawley/MIEngine/languages","stargazers_url":"https://api.github.com/repos/andrewcrawley/MIEngine/stargazers","contributors_url":"https://api.github.com/repos/andrewcrawley/MIEngine/contributors","subscribers_url":"https://api.github.com/repos/andrewcrawley/MIEngine/subscribers","subscription_url":"https://api.github.com/repos/andrewcrawley/MIEngine/subscription","commits_url":"https://api.github.com/repos/andrewcrawley/MIEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewcrawley/MIEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewcrawley/MIEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewcrawley/MIEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewcrawley/MIEngine/contents/{+path}","compare_url":"https://api.github.com/repos/andrewcrawley/MIEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewcrawley/MIEngine/merges","archive_url":"https://api.github.com/repos/andrewcrawley/MIEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewcrawley/MIEngine/downloads","issues_url":"https://api.github.com/repos/andrewcrawley/MIEngine/issues{/number}","pulls_url":"https://api.github.com/repos/andrewcrawley/MIEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewcrawley/MIEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewcrawley/MIEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewcrawley/MIEngine/labels{/name}","releases_url":"https://api.github.com/repos/andrewcrawley/MIEngine/releases{/id}","deployments_url":"https://api.github.com/repos/andrewcrawley/MIEngine/deployments","created_at":"2016-03-15T02:42:54Z","updated_at":"2016-03-15T02:42:55Z","pushed_at":"2016-03-23T23:28:10Z","git_url":"git://github.com/andrewcrawley/MIEngine.git","ssh_url":"git@github.com:andrewcrawley/MIEngine.git","clone_url":"https://github.com/andrewcrawley/MIEngine.git","svn_url":"https://github.com/andrewcrawley/MIEngine","homepage":null,"size":4045,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"e2790b0ba2ce329ddd8366d51f958490d76f8028","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":36405087,"name":"MIEngine","full_name":"Microsoft/MIEngine","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/MIEngine","description":"The Visual Studio MI Debug Engine (\"MIEngine\") provides an open-source Visual Studio Debugger extension that works with MI-enabled debuggers such as gdb, lldb, and clrdbg. ","fork":false,"url":"https://api.github.com/repos/Microsoft/MIEngine","forks_url":"https://api.github.com/repos/Microsoft/MIEngine/forks","keys_url":"https://api.github.com/repos/Microsoft/MIEngine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/MIEngine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/MIEngine/teams","hooks_url":"https://api.github.com/repos/Microsoft/MIEngine/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/MIEngine/events","assignees_url":"https://api.github.com/repos/Microsoft/MIEngine/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/MIEngine/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/MIEngine/tags","blobs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/MIEngine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/MIEngine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/MIEngine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/MIEngine/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/MIEngine/languages","stargazers_url":"https://api.github.com/repos/Microsoft/MIEngine/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/MIEngine/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/MIEngine/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/MIEngine/subscription","commits_url":"https://api.github.com/repos/Microsoft/MIEngine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/MIEngine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/MIEngine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/MIEngine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/MIEngine/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/MIEngine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/MIEngine/merges","archive_url":"https://api.github.com/repos/Microsoft/MIEngine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/MIEngine/downloads","issues_url":"https://api.github.com/repos/Microsoft/MIEngine/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/MIEngine/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/MIEngine/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/MIEngine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/MIEngine/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/MIEngine/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/MIEngine/deployments","created_at":"2015-05-28T00:44:08Z","updated_at":"2016-03-22T00:51:54Z","pushed_at":"2016-03-23T23:57:55Z","git_url":"git://github.com/Microsoft/MIEngine.git","ssh_url":"git@github.com:Microsoft/MIEngine.git","clone_url":"https://github.com/Microsoft/MIEngine.git","svn_url":"https://github.com/Microsoft/MIEngine","homepage":null,"size":4461,"stargazers_count":288,"watchers_count":288,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":33,"forks":77,"open_issues":33,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/237"},"html":{"href":"https://github.com/Microsoft/MIEngine/pull/237"},"issue":{"href":"https://api.github.com/repos/Microsoft/MIEngine/issues/237"},"comments":{"href":"https://api.github.com/repos/Microsoft/MIEngine/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/MIEngine/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/MIEngine/statuses/fec21c1c432aeabae52be66c3fc2186ea33cea68"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chuckries","id":6598594,"avatar_url":"https://avatars.githubusercontent.com/u/6598594?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckries","html_url":"https://github.com/chuckries","followers_url":"https://api.github.com/users/chuckries/followers","following_url":"https://api.github.com/users/chuckries/following{/other_user}","gists_url":"https://api.github.com/users/chuckries/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckries/subscriptions","organizations_url":"https://api.github.com/users/chuckries/orgs","repos_url":"https://api.github.com/users/chuckries/repos","events_url":"https://api.github.com/users/chuckries/events{/privacy}","received_events_url":"https://api.github.com/users/chuckries/received_events","type":"User","site_admin":false},"comments":2,"review_comments":7,"commits":1,"additions":83,"deletions":24,"changed_files":3}}