{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/965","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/965/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/965/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/965/events","html_url":"https://github.com/apache/zeppelin/pull/965","id":158585370,"number":965,"title":"[ZEPPELIN-957] Normalize note name.","user":{"login":"astroshim","id":3348133,"avatar_url":"https://avatars.githubusercontent.com/u/3348133?v=3","gravatar_id":"","url":"https://api.github.com/users/astroshim","html_url":"https://github.com/astroshim","followers_url":"https://api.github.com/users/astroshim/followers","following_url":"https://api.github.com/users/astroshim/following{/other_user}","gists_url":"https://api.github.com/users/astroshim/gists{/gist_id}","starred_url":"https://api.github.com/users/astroshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroshim/subscriptions","organizations_url":"https://api.github.com/users/astroshim/orgs","repos_url":"https://api.github.com/users/astroshim/repos","events_url":"https://api.github.com/users/astroshim/events{/privacy}","received_events_url":"https://api.github.com/users/astroshim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-06T01:10:19Z","updated_at":"2016-06-11T01:23:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/965","html_url":"https://github.com/apache/zeppelin/pull/965","diff_url":"https://github.com/apache/zeppelin/pull/965.diff","patch_url":"https://github.com/apache/zeppelin/pull/965.patch"},"body":"### What is this PR for?\r\nIt's better if notebook name can be normalized.\r\n\r\n\r\n### What type of PR is it?\r\nImprovement\r\n\r\n\r\n### What is the Jira issue?\r\nhttps://issues.apache.org/jira/browse/ZEPPELIN-957\r\n\r\n\r\n### How should this be tested?\r\nTry create notebook name with many slashes and no slashes.\r\nYou can refer to screen shot.\r\n\r\n\r\n### Screenshots (if appropriate)\r\n  - before\r\n![be](https://cloud.githubusercontent.com/assets/3348133/15809552/9bf9e26e-2bce-11e6-942c-df655ee52176.gif)\r\n\r\n\r\n  - after\r\n![af](https://cloud.githubusercontent.com/assets/3348133/15809553/9ff43c48-2bce-11e6-9f69-2b7a00bfc91e.gif)\r\n\r\n\r\n### Questions:\r\n* Does the licenses files need update? no\r\n* Is there breaking changes for older versions? no\r\n* Does this needs documentation? no\r\n"},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/225328801","html_url":"https://github.com/apache/zeppelin/pull/965#issuecomment-225328801","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/965","id":225328801,"user":{"login":"Leemoonsoo","id":1540981,"avatar_url":"https://avatars.githubusercontent.com/u/1540981?v=3","gravatar_id":"","url":"https://api.github.com/users/Leemoonsoo","html_url":"https://github.com/Leemoonsoo","followers_url":"https://api.github.com/users/Leemoonsoo/followers","following_url":"https://api.github.com/users/Leemoonsoo/following{/other_user}","gists_url":"https://api.github.com/users/Leemoonsoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Leemoonsoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leemoonsoo/subscriptions","organizations_url":"https://api.github.com/users/Leemoonsoo/orgs","repos_url":"https://api.github.com/users/Leemoonsoo/repos","events_url":"https://api.github.com/users/Leemoonsoo/events{/privacy}","received_events_url":"https://api.github.com/users/Leemoonsoo/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T01:23:22Z","updated_at":"2016-06-11T01:23:22Z","body":"Thanks @astroshim for the improvement. I've tested and although it's working well, i think there're little more things we can think\r\n\r\n1. Normalization is not applied when change note name.\r\n2. Normalization routine need to be placed in zeppelin-zengine, rather than zeppelin-server\r\n    zeppelin-server is place for the code that enables front-end / back-end communication.\r\n    business logic handles notebook should be in zeppelin-zengine module.\r\n3. It would be great to have a unittest for normalize note name\r\n4. Note name display is bit inconsistent. \r\n\r\nwith this branch\r\n\r\n| Given name when create note  | note name displayed on screen |\r\n| ------------- | ------------- |\r\n| MyNote  | MyNote  |\r\n| /MyNote  | /MyNote  |\r\n| MyNote/sub | **/MyNote/sub** |\r\n| /MyNote/sub | /MyNote/sub |\r\n\r\nbut it should be like\r\n\r\n| Given name when create note  | note name displayed on screen |\r\n| ------------- | ------------- |\r\n| MyNote  | MyNote  |\r\n| /MyNote  | /MyNote  |\r\n| MyNote/sub | **MyNote/sub** |\r\n| /MyNote/sub | /MyNote/sub |\r\n\r\n"}}
{"actor":{"display_login":"Leemoonsoo"}}