{"action":"created","issue":{"url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/38","repository_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc","labels_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/38/comments","events_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/38/events","html_url":"https://github.com/lightningnetwork/lightning-rfc/pull/38","id":193844900,"number":38,"title":"BOLT 2: Move update_fee message from 'Channel Establishment' to 'Normal Operation'","user":{"login":"pm47","id":2028222,"avatar_url":"https://avatars.githubusercontent.com/u/2028222?v=3","gravatar_id":"","url":"https://api.github.com/users/pm47","html_url":"https://github.com/pm47","followers_url":"https://api.github.com/users/pm47/followers","following_url":"https://api.github.com/users/pm47/following{/other_user}","gists_url":"https://api.github.com/users/pm47/gists{/gist_id}","starred_url":"https://api.github.com/users/pm47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pm47/subscriptions","organizations_url":"https://api.github.com/users/pm47/orgs","repos_url":"https://api.github.com/users/pm47/repos","events_url":"https://api.github.com/users/pm47/events{/privacy}","received_events_url":"https://api.github.com/users/pm47/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cdecker","id":120117,"avatar_url":"https://avatars.githubusercontent.com/u/120117?v=3","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"assignees":[{"login":"cdecker","id":120117,"avatar_url":"https://avatars.githubusercontent.com/u/120117?v=3","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-06T18:12:29Z","updated_at":"2016-12-06T22:31:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/pulls/38","html_url":"https://github.com/lightningnetwork/lightning-rfc/pull/38","diff_url":"https://github.com/lightningnetwork/lightning-rfc/pull/38.diff","patch_url":"https://github.com/lightningnetwork/lightning-rfc/pull/38.patch"},"body":"From an implementor's point of view, I think the `update_fee` message is much closer to other `update_*` messages than to channel setup or teardown, and belongs to the Normal operation section. `update_fee` messages will be queued along with htlc-related messages, and applied in order when signing a new commitment.\r\n\r\nNB: a consequence of this is that the `type` of the message changes from `37` to `134`.\r\n\r\nedit:\r\nActually I wonder if we should reserve types:\r\n- `32`-`127` to channel creation, establishment, and in the future: cash in, cash out, reanchoring, ...\r\n- `128`-`255` to commitment update (htlc, fees, signatures)\r\n\r\nBut I am not sure what the rationale was for the current logical grouping?"},"comment":{"url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/comments/265294370","html_url":"https://github.com/lightningnetwork/lightning-rfc/pull/38#issuecomment-265294370","issue_url":"https://api.github.com/repos/lightningnetwork/lightning-rfc/issues/38","id":265294370,"user":{"login":"cdecker","id":120117,"avatar_url":"https://avatars.githubusercontent.com/u/120117?v=3","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T22:31:52Z","updated_at":"2016-12-06T22:31:52Z","body":"Good catch, I think my rationale was that the 32-128 `type`s concerned the channel's lifecycle, while the 128-256 were HTLC lifecycle related, and since `update_fee` concerns the channel, and not an individual HTLC I grouped them into the channel lifecycle.\r\n\r\nBut I agree that `update_fee` cuts across these concerns, so I'm fine with both options."}}
{"actor":{"display_login":"cdecker"}}