{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/55827695","id":55827695,"diff_hunk":"@@ -0,0 +1,175 @@\n+package fixchain\n+\n+import (\n+\t\"bytes\"\n+\t\"encoding/base64\"\n+\t\"errors\"\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"net/http\"\n+\t\"testing\"\n+)\n+\n+type fixTestRoundTripper struct{}\n+\n+func (rt fixTestRoundTripper) RoundTrip(request *http.Request) (*http.Response, error) {","path":"go/fixchain/test_round_trippers.go","position":15,"original_position":15,"commit_id":"eb930184fbe5fcf4f75ce4139f4527a12168ba11","original_commit_id":"eb930184fbe5fcf4f75ce4139f4527a12168ba11","user":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"body":"This code looks like a subset of the other round tripper. Why is it not shared?","created_at":"2016-03-11T13:20:17Z","updated_at":"2016-03-11T13:20:17Z","html_url":"https://github.com/google/certificate-transparency/pull/1127#discussion_r55827695","pull_request_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1127","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/55827695"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1127#discussion_r55827695"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1127"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/1127","id":61926456,"html_url":"https://github.com/google/certificate-transparency/pull/1127","diff_url":"https://github.com/google/certificate-transparency/pull/1127.diff","patch_url":"https://github.com/google/certificate-transparency/pull/1127.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/1127","number":1127,"state":"open","locked":false,"title":"Fixchain","user":{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"body":"The rest of the open source fixchain code.\r\n\r\nTests for fix_and_log.go are not yet present, but will be added very soon.  Submitting pull request now so that code review can get under way while last tests are being completed.\r\n\r\nStructure of new parts:\r\n\r\n-  \\*\\_test.go and test\\_\\* files are all to do with tests.\r\n-  post.go contains the synchronous function that posts a chain to a certificate transparency log.\r\n-  logger.go contains the asynchronous mechanism that posts queued chains to a certificate transparency log.\r\n-  fix_and_log.go contains an asynchronous mechanism that fires up a Fixer and a Logger and passes chains to the Fixer, and then takes the fixed chains output by the Fixer and passes them to the Logger to be logged.\r\n-  main/fixchain.go is an open source example of how to use the FixAndLog structure to fix and log certficate chains, and store any errors that result.","created_at":"2016-03-07T14:47:57Z","updated_at":"2016-03-11T13:20:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39569840d822d76c61a18e1410e09cd5c74ea770","assignee":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1127/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1127/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/1127/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/eb930184fbe5fcf4f75ce4139f4527a12168ba11","head":{"label":"taknira:fixchain","ref":"fixchain","sha":"eb930184fbe5fcf4f75ce4139f4527a12168ba11","user":{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"repo":{"id":46339519,"name":"certificate-transparency","full_name":"taknira/certificate-transparency","owner":{"login":"taknira","id":5446167,"avatar_url":"https://avatars.githubusercontent.com/u/5446167?v=3","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taknira/certificate-transparency","description":"Auditing for TLS certificates.","fork":true,"url":"https://api.github.com/repos/taknira/certificate-transparency","forks_url":"https://api.github.com/repos/taknira/certificate-transparency/forks","keys_url":"https://api.github.com/repos/taknira/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taknira/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taknira/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/taknira/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/taknira/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/taknira/certificate-transparency/events","assignees_url":"https://api.github.com/repos/taknira/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/taknira/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/taknira/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/taknira/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taknira/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taknira/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/taknira/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taknira/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/taknira/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/taknira/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/taknira/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/taknira/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/taknira/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/taknira/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/taknira/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/taknira/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/taknira/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/taknira/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/taknira/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taknira/certificate-transparency/merges","archive_url":"https://api.github.com/repos/taknira/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taknira/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/taknira/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/taknira/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/taknira/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/taknira/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taknira/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/taknira/certificate-transparency/releases{/id}","deployments_url":"https://api.github.com/repos/taknira/certificate-transparency/deployments","created_at":"2015-11-17T10:22:03Z","updated_at":"2016-01-27T14:06:51Z","pushed_at":"2016-03-11T11:15:52Z","git_url":"git://github.com/taknira/certificate-transparency.git","ssh_url":"git@github.com:taknira/certificate-transparency.git","clone_url":"https://github.com/taknira/certificate-transparency.git","svn_url":"https://github.com/taknira/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":19972,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"394433448f4ef24613e5f7356fd245c9372ca436","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19989605,"name":"certificate-transparency","full_name":"google/certificate-transparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency","description":"Auditing for TLS certificates.","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency","forks_url":"https://api.github.com/repos/google/certificate-transparency/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/certificate-transparency/deployments","created_at":"2014-05-20T17:03:47Z","updated_at":"2016-03-10T20:43:48Z","pushed_at":"2016-03-11T11:15:52Z","git_url":"git://github.com/google/certificate-transparency.git","ssh_url":"git@github.com:google/certificate-transparency.git","clone_url":"https://github.com/google/certificate-transparency.git","svn_url":"https://github.com/google/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":22055,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":83,"forks":84,"open_issues":83,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1127"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1127"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1127"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1127/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1127/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1127/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency/statuses/eb930184fbe5fcf4f75ce4139f4527a12168ba11"}}}}