{"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/65643231","id":65643231,"diff_hunk":"@@ -7,33 +7,39 @@\n   <div id=\"mark_verify_result_<%=mark.id%>\" class=\"error\" style=\"display:none;\">\n     <%= I18n.t(\"marker.marks.invalid_mark\") %>\n   </div>\n-  <div class=\"criterion_title\" id=\"<%= \"mark_criterion_title_#{mark_criterion.id}\"%>\" onclick=\"<%=\"focus_mark_criterion(#{mark_criterion.id})\"%>\">\n+  <div class=\"criterion_title\" id=\"<%= \"mark_criterion_title_#{mark_criterion.id}\"%>\">\n+\n     <div id=\"<%=\"mark_criterion_title_#{mark_criterion.id}_expand\"%>\"\n-      class=\"float_left flexible_criterion_expand expanded\" >- &nbsp;</div>\n-    <div id=\"<%=\"mark_criterion_title_#{mark_criterion.id}_name\"%>\"\n-      class=\"mark_criterion_title_div_level float_left\">\n-      <strong><%=(mark_criterion.name)%></strong>\n-    </div>\n-    <div id=\"<%=\"mark_criterion_title_#{mark_criterion.id}_old_mark\"%>\"\n-      class=\"mark_criterion_old_mark float_left\">\n-\t  <strong><%= if(!old_mark.nil? && !old_mark.mark.nil?) then \n-        \"#{I18n.t('marker.marks.old')}#{old_mark.mark.to_s}\"\n-        else \"\" end %></strong>\n-    </div>\n-    <div id=\"mark_flexible_<%=mark.id%>\" class=\"float_right\">\n-      <%= text_field_tag('mark_' + mark.id.to_s, mark.mark,\n-          size: 4,\n-          class: 'mark_grade_input',\n-          'data-action' => url_for(action: :update_mark,\n-                            mark_id: mark.id)) %>\n-  \t /&nbsp; <span id=\"mark_flexible_max_<%=mark.id%>\"><%= mark_criterion.max.to_s%> </span>\n-    </div>\n-    <div class=\"clear\"></div>\n-    <div id=\"<%=\"mark_criterion_inputs_#{mark_criterion.id}\"%>\" class=\"mark_criterion_level_container\">\n-      <div class=\"float_left\" >\n-        <%=mark_criterion.description %>\n+      class=\"float_left flexible_criterion_expand expanded\"\n+      onclick=\"<%=\"focus_mark_criterion(#{mark_criterion.id})\"%>\">- &nbsp;</div>\n+\n+    <div id=\"flexible_criterion\">\n+      <div id=\"<%= \"mark_criterion_title_#{mark_criterion.id}_name\" %>\"\n+           class='flexible_criterion_title_div_level float_left'\n+           onclick=\"<%=\"focus_mark_criterion(#{mark_criterion.id})\"%>\">\n+        <strong><%= (mark_criterion.name) %></strong>\n+      </div>\n+\n+      <div id=\"mark_flexible_<%=mark.id%>\" class=\"mark_flexible\">\n+        <%= text_field_tag('mark_' + mark.id.to_s, mark.mark,\n+                           size: 4,\n+                           class: 'mark_grade_input',\n+                           data: {:id => mark_criterion.id},\n+                           'data-action' => url_for(action: :update_mark,\n+                                                    mark_id: mark.id)) %>\n+        /&nbsp; <span id=\"mark_flexible_max_<%=mark.id%>\"><%= mark_criterion.max.to_s%> </span>\n+      </div>\n+\n+      <div class=\"mark_description\" style=\"display: none;\" data-id='<%= mark_criterion.id %>'>\n+        <%= mark.mark %>\n+      </div>\n+\n+      <div id=\"<%=\"criterion_info_#{mark_criterion.id}\"%>\" class=\"flexible_criterion_info\">\n+        <div id=\"<%=\"mark_criterion_inputs_#{mark_criterion.id}\"%>\">\n+          <%=mark_criterion.description %>","path":"app/views/results/marker/_marker_flexible_criterion_li.html.erb","position":57,"original_position":57,"commit_id":"75909ac1776e4d11c32fc0c8d7f0cb6ba5819b57","original_commit_id":"75909ac1776e4d11c32fc0c8d7f0cb6ba5819b57","user":{"login":"david-yz-liu","id":3333115,"avatar_url":"https://avatars.githubusercontent.com/u/3333115?v=3","gravatar_id":"","url":"https://api.github.com/users/david-yz-liu","html_url":"https://github.com/david-yz-liu","followers_url":"https://api.github.com/users/david-yz-liu/followers","following_url":"https://api.github.com/users/david-yz-liu/following{/other_user}","gists_url":"https://api.github.com/users/david-yz-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/david-yz-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-yz-liu/subscriptions","organizations_url":"https://api.github.com/users/david-yz-liu/orgs","repos_url":"https://api.github.com/users/david-yz-liu/repos","events_url":"https://api.github.com/users/david-yz-liu/events{/privacy}","received_events_url":"https://api.github.com/users/david-yz-liu/received_events","type":"User","site_admin":false},"body":"space after `=`","created_at":"2016-06-03T00:51:46Z","updated_at":"2016-06-03T00:51:46Z","html_url":"https://github.com/MarkUsProject/Markus/pull/2604#discussion_r65643231","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/65643231"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2604#discussion_r65643231"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604","id":72412919,"html_url":"https://github.com/MarkUsProject/Markus/pull/2604","diff_url":"https://github.com/MarkUsProject/Markus/pull/2604.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/2604.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2604","number":2604,"state":"open","locked":false,"title":"Results Panes Styling","user":{"login":"christinem","id":5077973,"avatar_url":"https://avatars.githubusercontent.com/u/5077973?v=3","gravatar_id":"","url":"https://api.github.com/users/christinem","html_url":"https://github.com/christinem","followers_url":"https://api.github.com/users/christinem/followers","following_url":"https://api.github.com/users/christinem/following{/other_user}","gists_url":"https://api.github.com/users/christinem/gists{/gist_id}","starred_url":"https://api.github.com/users/christinem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christinem/subscriptions","organizations_url":"https://api.github.com/users/christinem/orgs","repos_url":"https://api.github.com/users/christinem/repos","events_url":"https://api.github.com/users/christinem/events{/privacy}","received_events_url":"https://api.github.com/users/christinem/received_events","type":"User","site_admin":false},"body":"With @reid and @david-yz-liu 's suggestions, I've made changes to the styling of the results panes for markers and students. \r\n\r\nThe results view code is not as clean as it could be, as I was working with what had been done before. It could use a lot of refactoring.","created_at":"2016-06-02T20:34:56Z","updated_at":"2016-06-03T00:51:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19a0eef8eb772869eaa2f8a67641ae8da3f2cbf3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2604/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/75909ac1776e4d11c32fc0c8d7f0cb6ba5819b57","head":{"label":"christinem:results-panes","ref":"results-panes","sha":"75909ac1776e4d11c32fc0c8d7f0cb6ba5819b57","user":{"login":"christinem","id":5077973,"avatar_url":"https://avatars.githubusercontent.com/u/5077973?v=3","gravatar_id":"","url":"https://api.github.com/users/christinem","html_url":"https://github.com/christinem","followers_url":"https://api.github.com/users/christinem/followers","following_url":"https://api.github.com/users/christinem/following{/other_user}","gists_url":"https://api.github.com/users/christinem/gists{/gist_id}","starred_url":"https://api.github.com/users/christinem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christinem/subscriptions","organizations_url":"https://api.github.com/users/christinem/orgs","repos_url":"https://api.github.com/users/christinem/repos","events_url":"https://api.github.com/users/christinem/events{/privacy}","received_events_url":"https://api.github.com/users/christinem/received_events","type":"User","site_admin":false},"repo":{"id":57914844,"name":"Markus","full_name":"christinem/Markus","owner":{"login":"christinem","id":5077973,"avatar_url":"https://avatars.githubusercontent.com/u/5077973?v=3","gravatar_id":"","url":"https://api.github.com/users/christinem","html_url":"https://github.com/christinem","followers_url":"https://api.github.com/users/christinem/followers","following_url":"https://api.github.com/users/christinem/following{/other_user}","gists_url":"https://api.github.com/users/christinem/gists{/gist_id}","starred_url":"https://api.github.com/users/christinem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christinem/subscriptions","organizations_url":"https://api.github.com/users/christinem/orgs","repos_url":"https://api.github.com/users/christinem/repos","events_url":"https://api.github.com/users/christinem/events{/privacy}","received_events_url":"https://api.github.com/users/christinem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christinem/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/christinem/Markus","forks_url":"https://api.github.com/repos/christinem/Markus/forks","keys_url":"https://api.github.com/repos/christinem/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christinem/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christinem/Markus/teams","hooks_url":"https://api.github.com/repos/christinem/Markus/hooks","issue_events_url":"https://api.github.com/repos/christinem/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/christinem/Markus/events","assignees_url":"https://api.github.com/repos/christinem/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/christinem/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/christinem/Markus/tags","blobs_url":"https://api.github.com/repos/christinem/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christinem/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christinem/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/christinem/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christinem/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/christinem/Markus/languages","stargazers_url":"https://api.github.com/repos/christinem/Markus/stargazers","contributors_url":"https://api.github.com/repos/christinem/Markus/contributors","subscribers_url":"https://api.github.com/repos/christinem/Markus/subscribers","subscription_url":"https://api.github.com/repos/christinem/Markus/subscription","commits_url":"https://api.github.com/repos/christinem/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/christinem/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/christinem/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/christinem/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/christinem/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/christinem/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christinem/Markus/merges","archive_url":"https://api.github.com/repos/christinem/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christinem/Markus/downloads","issues_url":"https://api.github.com/repos/christinem/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/christinem/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/christinem/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/christinem/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christinem/Markus/labels{/name}","releases_url":"https://api.github.com/repos/christinem/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/christinem/Markus/deployments","created_at":"2016-05-02T19:17:23Z","updated_at":"2016-05-02T19:17:27Z","pushed_at":"2016-06-02T20:52:19Z","git_url":"git://github.com/christinem/Markus.git","ssh_url":"git@github.com:christinem/Markus.git","clone_url":"https://github.com/christinem/Markus.git","svn_url":"https://github.com/christinem/Markus","homepage":"http://www.markusproject.org","size":26360,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"1eda0a514b672b8eee8add88816d14d3d7964d77","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/MarkUsProject/Markus/deployments","created_at":"2010-09-26T16:18:08Z","updated_at":"2016-05-30T19:44:34Z","pushed_at":"2016-06-02T20:52:20Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":37140,"stargazers_count":140,"watchers_count":140,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":96,"forks":172,"open_issues":96,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2604"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2604"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2604/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2604/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/75909ac1776e4d11c32fc0c8d7f0cb6ba5819b57"}}}}
{"actor":{"display_login":"david-yz-liu"}}