{"action":"created","issue":{"url":"https://api.github.com/repos/ClearControl/Halcyon/issues/26","repository_url":"https://api.github.com/repos/ClearControl/Halcyon","labels_url":"https://api.github.com/repos/ClearControl/Halcyon/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/ClearControl/Halcyon/issues/26/comments","events_url":"https://api.github.com/repos/ClearControl/Halcyon/issues/26/events","html_url":"https://github.com/ClearControl/Halcyon/issues/26","id":153996872,"number":26,"title":"Avoid duplicating Java FX classes and instead use CSS skins.","user":{"login":"royerloic","id":1870994,"avatar_url":"https://avatars.githubusercontent.com/u/1870994?v=3","gravatar_id":"","url":"https://api.github.com/users/royerloic","html_url":"https://github.com/royerloic","followers_url":"https://api.github.com/users/royerloic/followers","following_url":"https://api.github.com/users/royerloic/following{/other_user}","gists_url":"https://api.github.com/users/royerloic/gists{/gist_id}","starred_url":"https://api.github.com/users/royerloic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/royerloic/subscriptions","organizations_url":"https://api.github.com/users/royerloic/orgs","repos_url":"https://api.github.com/users/royerloic/repos","events_url":"https://api.github.com/users/royerloic/events{/privacy}","received_events_url":"https://api.github.com/users/royerloic/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ClearControl/Halcyon/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ClearControl/Halcyon/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"hkmoon","id":3864647,"avatar_url":"https://avatars.githubusercontent.com/u/3864647?v=3","gravatar_id":"","url":"https://api.github.com/users/hkmoon","html_url":"https://github.com/hkmoon","followers_url":"https://api.github.com/users/hkmoon/followers","following_url":"https://api.github.com/users/hkmoon/following{/other_user}","gists_url":"https://api.github.com/users/hkmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/hkmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkmoon/subscriptions","organizations_url":"https://api.github.com/users/hkmoon/orgs","repos_url":"https://api.github.com/users/hkmoon/repos","events_url":"https://api.github.com/users/hkmoon/events{/privacy}","received_events_url":"https://api.github.com/users/hkmoon/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-05-10T12:43:09Z","updated_at":"2016-05-10T12:59:16Z","closed_at":null,"body":"It seems to me wrong to copy pasting Java classes (for example in the case of the customized slider).\r\nAfter quickly checking online, it seems that the right way to do it is to add acustom CSS that specify which skin and behaviour classes to use. Here is a tutorial:\r\n\r\nhttps://www.youtube.com/watch?v=ts_b2mBix3U\r\n\r\nWe should avoid code duplication. For example in the case of the Slider, we should only need to provide a CSS file and a Skin or Behaviour class (I am not sure anymore which one we needed to modify.)\r\n\r\nAlso, if we need to modify a class, what we really need to do is simply derive from an existing skin or behaviour and just change the method that needs to be customized, instead of duplicating the entire class... \r\n\r\nIn general the rule of thumb is to avoid code duplication.\r\n"},"comment":{"url":"https://api.github.com/repos/ClearControl/Halcyon/issues/comments/218149532","html_url":"https://github.com/ClearControl/Halcyon/issues/26#issuecomment-218149532","issue_url":"https://api.github.com/repos/ClearControl/Halcyon/issues/26","id":218149532,"user":{"login":"hkmoon","id":3864647,"avatar_url":"https://avatars.githubusercontent.com/u/3864647?v=3","gravatar_id":"","url":"https://api.github.com/users/hkmoon","html_url":"https://github.com/hkmoon","followers_url":"https://api.github.com/users/hkmoon/followers","following_url":"https://api.github.com/users/hkmoon/following{/other_user}","gists_url":"https://api.github.com/users/hkmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/hkmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkmoon/subscriptions","organizations_url":"https://api.github.com/users/hkmoon/orgs","repos_url":"https://api.github.com/users/hkmoon/repos","events_url":"https://api.github.com/users/hkmoon/events{/privacy}","received_events_url":"https://api.github.com/users/hkmoon/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T12:59:16Z","updated_at":"2016-05-10T12:59:16Z","body":"I added ```tickLine.setAnimated( false );``` below http://grepcode.com/file/repo1.maven.org/maven2/net.java.openjfx.backport/openjfx-78-backport/1.8.0-ea-b96.1/com/sun/javafx/scene/control/skin/SliderSkin.java#160."}}