{"action":"created","issue":{"url":"https://api.github.com/repos/rsjaffe/MIDI2LR/issues/247","repository_url":"https://api.github.com/repos/rsjaffe/MIDI2LR","labels_url":"https://api.github.com/repos/rsjaffe/MIDI2LR/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/rsjaffe/MIDI2LR/issues/247/comments","events_url":"https://api.github.com/repos/rsjaffe/MIDI2LR/issues/247/events","html_url":"https://github.com/rsjaffe/MIDI2LR/issues/247","id":149819052,"number":247,"title":"A few slightly odd behaviours","user":{"login":"sandyfsx","id":16386915,"avatar_url":"https://avatars.githubusercontent.com/u/16386915?v=3","gravatar_id":"","url":"https://api.github.com/users/sandyfsx","html_url":"https://github.com/sandyfsx","followers_url":"https://api.github.com/users/sandyfsx/followers","following_url":"https://api.github.com/users/sandyfsx/following{/other_user}","gists_url":"https://api.github.com/users/sandyfsx/gists{/gist_id}","starred_url":"https://api.github.com/users/sandyfsx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandyfsx/subscriptions","organizations_url":"https://api.github.com/users/sandyfsx/orgs","repos_url":"https://api.github.com/users/sandyfsx/repos","events_url":"https://api.github.com/users/sandyfsx/events{/privacy}","received_events_url":"https://api.github.com/users/sandyfsx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rsjaffe/MIDI2LR/labels/Keyboard%20Emulation","name":"Keyboard Emulation","color":"fad8c7"},{"url":"https://api.github.com/repos/rsjaffe/MIDI2LR/labels/Troubleshooting","name":"Troubleshooting","color":"006b75"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-20T16:24:08Z","updated_at":"2016-05-10T00:53:44Z","closed_at":null,"body":" \r\n### Expected behavior\r\nThe keyboard shortcut 'X' can be used for both 'reject photo' and within the crop module, switching between landscape and portrait. \r\n\r\n### Actual behavior\r\nWhen a button is assigned to X it only functions as reject photo. Furthermore, it actually changes the function of the actual keyboard button to lose this function too. When the button on the midi controller is assigned back to reject photo, normal function returns.\r\n### Steps to reproduce the behavior\r\nAssign a button on the midi controller to X, open the crop dialogue, press button.\r\n\r\n### Expected behavior\r\nEnable Lens Corrections would tick the box labeled 'Enable profile corrections' under the lens corrections tab in Develop\r\n\r\n### Actual behavior\r\nIt actually toggles the tab on or off. This isn't much use if you want to use it to turn lens corrections on or off as you have to manually turn it on first. I may be mistaken but I couldn't find an option that actually does turn lens profile corrections on and off.\r\n\r\n### System information\r\n\r\n* Operating system (Windows or OS X) and version: Windows 10\r\n* MIDI2LR version: MIDI2LR 1.0.0\r\n* Lightroom version: LR 2015.5\r\n* Lightroom language: English\r\n* Keyboard language: UK English\r\n* MIDI controller: Behringer bcf 2000\r\n* Plugin installation directory: E:\\Documents\\MIDI2LR\\MIDI2LRV1.0.0\r\n* Profiles save directory: E:\\Documents\\MIDI2LR\r\n\r\n### Additional comments\r\nThe only key the send key option doesn't seem to support is return. This would be useful as it is used to accept pretty much all local adjustments, crops etc. I know you can press the button that activated your local adjustment again to deactivate it but hitting return is a catch all button rather than needing individual ones. I don't actually assign all the local adjustments to buttons as this would take up too many buttons.\r\n"},"comment":{"url":"https://api.github.com/repos/rsjaffe/MIDI2LR/issues/comments/218031561","html_url":"https://github.com/rsjaffe/MIDI2LR/issues/247#issuecomment-218031561","issue_url":"https://api.github.com/repos/rsjaffe/MIDI2LR/issues/247","id":218031561,"user":{"login":"DMVpix","id":19232092,"avatar_url":"https://avatars.githubusercontent.com/u/19232092?v=3","gravatar_id":"","url":"https://api.github.com/users/DMVpix","html_url":"https://github.com/DMVpix","followers_url":"https://api.github.com/users/DMVpix/followers","following_url":"https://api.github.com/users/DMVpix/following{/other_user}","gists_url":"https://api.github.com/users/DMVpix/gists{/gist_id}","starred_url":"https://api.github.com/users/DMVpix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DMVpix/subscriptions","organizations_url":"https://api.github.com/users/DMVpix/orgs","repos_url":"https://api.github.com/users/DMVpix/repos","events_url":"https://api.github.com/users/DMVpix/events{/privacy}","received_events_url":"https://api.github.com/users/DMVpix/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T00:53:44Z","updated_at":"2016-05-10T00:53:44Z","body":"Hopefully this answers what you're asking.\r\n\r\nWith MIDI2LR running, while in crop mode \r\n1) pressing X on the keyboard changes the crop rotation (expected behavior),\r\n2) send key X from the controller sets the reject flag (incorrect behavior) and advances to the next photo\r\n\r\nWithout MIDI2LR running, while in crop mode pressing X on the keyboard changes the crop rotation (correct behavior).\r\n\r\nIn Library, from either the keyboard or controller, X rejects the photo, which is the behavior expected.\r\n\r\nThe keyboard input works regardless of whether MIDI2LR is running.or not."}}