{"action":"created","issue":{"url":"https://api.github.com/repos/odota/ui/issues/301","repository_url":"https://api.github.com/repos/odota/ui","labels_url":"https://api.github.com/repos/odota/ui/issues/301/labels{/name}","comments_url":"https://api.github.com/repos/odota/ui/issues/301/comments","events_url":"https://api.github.com/repos/odota/ui/issues/301/events","html_url":"https://github.com/odota/ui/pull/301","id":184203855,"number":301,"title":"fix trends router bug","user":{"login":"howardchung","id":3134520,"avatar_url":"https://avatars.githubusercontent.com/u/3134520?v=3","gravatar_id":"","url":"https://api.github.com/users/howardchung","html_url":"https://github.com/howardchung","followers_url":"https://api.github.com/users/howardchung/followers","following_url":"https://api.github.com/users/howardchung/following{/other_user}","gists_url":"https://api.github.com/users/howardchung/gists{/gist_id}","starred_url":"https://api.github.com/users/howardchung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howardchung/subscriptions","organizations_url":"https://api.github.com/users/howardchung/orgs","repos_url":"https://api.github.com/users/howardchung/repos","events_url":"https://api.github.com/users/howardchung/events{/privacy}","received_events_url":"https://api.github.com/users/howardchung/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/odota/ui/labels/needs%20review","name":"needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-20T11:28:31Z","updated_at":"2016-10-20T21:11:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odota/ui/pulls/301","html_url":"https://github.com/odota/ui/pull/301","diff_url":"https://github.com/odota/ui/pull/301.diff","patch_url":"https://github.com/odota/ui/pull/301.patch"},"body":"fixes #300 \r\n\r\nRCA:\r\nTrends had no router component (withRouter).\r\n\r\nFix:\r\n* Move routing mutation logic to ButtonGarden"},"comment":{"url":"https://api.github.com/repos/odota/ui/issues/comments/255229582","html_url":"https://github.com/odota/ui/pull/301#issuecomment-255229582","issue_url":"https://api.github.com/repos/odota/ui/issues/301","id":255229582,"user":{"login":"mike-robertson","id":8756876,"avatar_url":"https://avatars.githubusercontent.com/u/8756876?v=3","gravatar_id":"","url":"https://api.github.com/users/mike-robertson","html_url":"https://github.com/mike-robertson","followers_url":"https://api.github.com/users/mike-robertson/followers","following_url":"https://api.github.com/users/mike-robertson/following{/other_user}","gists_url":"https://api.github.com/users/mike-robertson/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-robertson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-robertson/subscriptions","organizations_url":"https://api.github.com/users/mike-robertson/orgs","repos_url":"https://api.github.com/users/mike-robertson/repos","events_url":"https://api.github.com/users/mike-robertson/events{/privacy}","received_events_url":"https://api.github.com/users/mike-robertson/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T21:11:40Z","updated_at":"2016-10-20T21:11:40Z","body":"I think what I mean here is why would a button component only manipulate urls on button clicks. I'd say this component shouldn't be aware of what clicking does as much as possible. So maybe add a component in top of this called routingButtonGarden which does this router change inside. Idk, just seems weird that a button knows so much about what clicking it does. "}}
{"actor":{"display_login":"mike-robertson"}}