{"action":"created","comment":{"url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/comments/91796325","pull_request_review_id":12309287,"id":91796325,"diff_hunk":"@@ -19,19 +19,16 @@ import java.io.File\n import java.net.URL\n \n import com.yourmediashelf.fedora.client.FedoraCredentials\n-import nl.knaw.dans.easy.umd.CommandLineOptions.log\n import org.rogach.scallop._\n-import org.slf4j.LoggerFactory\n-\n-import scala.util.{Failure, Success, Try}\n+import org.slf4j.{Logger, LoggerFactory}\n \n class CommandLineOptions(args: Array[String] = \"-ss -tt -f http:// src/test/resources/deasy-input.csv\".split(\" \")) extends ScallopConf(args) {\n \n   appendDefaultToDescription = true\n   editBuilder(_.setHelpWidth(110))","path":"src/main/scala/nl/knaw/dans/easy/umd/CommandLineOptions.scala","position":14,"original_position":14,"commit_id":"b915a61121002aefc0e946f10519406dae9a26f0","original_commit_id":"b915a61121002aefc0e946f10519406dae9a26f0","user":{"login":"jo-pol","id":10553630,"avatar_url":"https://avatars.githubusercontent.com/u/10553630?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-pol","html_url":"https://github.com/jo-pol","followers_url":"https://api.github.com/users/jo-pol/followers","following_url":"https://api.github.com/users/jo-pol/following{/other_user}","gists_url":"https://api.github.com/users/jo-pol/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-pol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-pol/subscriptions","organizations_url":"https://api.github.com/users/jo-pol/orgs","repos_url":"https://api.github.com/users/jo-pol/repos","events_url":"https://api.github.com/users/jo-pol/events{/privacy}","received_events_url":"https://api.github.com/users/jo-pol/received_events","type":"User","site_admin":false},"body":"he;[width 6 characters too wide for an iPad","created_at":"2016-12-09T21:13:47Z","updated_at":"2016-12-09T21:13:47Z","html_url":"https://github.com/DANS-KNAW/easy-update-metadata-dataset/pull/5#discussion_r91796325","pull_request_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/comments/91796325"},"html":{"href":"https://github.com/DANS-KNAW/easy-update-metadata-dataset/pull/5#discussion_r91796325"},"pull_request":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5","id":97325497,"html_url":"https://github.com/DANS-KNAW/easy-update-metadata-dataset/pull/5","diff_url":"https://github.com/DANS-KNAW/easy-update-metadata-dataset/pull/5.diff","patch_url":"https://github.com/DANS-KNAW/easy-update-metadata-dataset/pull/5.patch","issue_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/issues/5","number":5,"state":"open","locked":false,"title":"EASY-1007/1003 datasetState in AMD / dcRights in DC","user":{"login":"jo-pol","id":10553630,"avatar_url":"https://avatars.githubusercontent.com/u/10553630?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-pol","html_url":"https://github.com/jo-pol","followers_url":"https://api.github.com/users/jo-pol/followers","following_url":"https://api.github.com/users/jo-pol/following{/other_user}","gists_url":"https://api.github.com/users/jo-pol/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-pol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-pol/subscriptions","organizations_url":"https://api.github.com/users/jo-pol/orgs","repos_url":"https://api.github.com/users/jo-pol/repos","events_url":"https://api.github.com/users/jo-pol/events{/privacy}","received_events_url":"https://api.github.com/users/jo-pol/received_events","type":"User","site_admin":false},"body":"fixes EASY-1007 + EASY-1003\r\n\r\n#### When applied it will\r\n\r\n* [x] add history when `datasetState` in `AMD` is changed\r\n* [ ] need both old and new value in input file to prevent changing all `rights` items in the `DC` stream\r\n* \r\n\r\n#### Where should the reviewer @DANS-KNAW/easy start?\r\n\r\nThe new introduction in the readme.\r\n* The transformation is isolated in an object of its own with new unit tests.\r\n* New warnings on missing types are fixed.\r\n\r\n#### How should this be manually tested?\r\n\r\nBuild, deploy and run as instructed by the readme.\r\n\r\n#### related pull requests on github\r\nrepo                       | PR\r\n-------------------------- | -----------------\r\neasy-                      | [PR#](PRlink) \r\n\r\n","created_at":"2016-12-09T15:13:58Z","updated_at":"2016-12-09T21:13:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"def055c6496fcaab5d385d3e9072f682fd634210","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5/commits","review_comments_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5/comments","review_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/issues/5/comments","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/statuses/b915a61121002aefc0e946f10519406dae9a26f0","head":{"label":"DANS-KNAW-jp:EASY-1007-datasetState-update","ref":"EASY-1007-datasetState-update","sha":"b915a61121002aefc0e946f10519406dae9a26f0","user":{"login":"DANS-KNAW-jp","id":21305289,"avatar_url":"https://avatars.githubusercontent.com/u/21305289?v=3","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"repo":{"id":65283857,"name":"easy-update-metadata-dataset","full_name":"DANS-KNAW-jp/easy-update-metadata-dataset","owner":{"login":"DANS-KNAW-jp","id":21305289,"avatar_url":"https://avatars.githubusercontent.com/u/21305289?v=3","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DANS-KNAW-jp/easy-update-metadata-dataset","description":"Batch-updates metadata streams in a Fedora Commons repository","fork":true,"url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset","forks_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/forks","keys_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/events","assignees_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/merges","archive_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-update-metadata-dataset/deployments","created_at":"2016-08-09T09:51:45Z","updated_at":"2016-08-29T09:01:40Z","pushed_at":"2016-12-09T20:51:31Z","git_url":"git://github.com/DANS-KNAW-jp/easy-update-metadata-dataset.git","ssh_url":"git@github.com:DANS-KNAW-jp/easy-update-metadata-dataset.git","clone_url":"https://github.com/DANS-KNAW-jp/easy-update-metadata-dataset.git","svn_url":"https://github.com/DANS-KNAW-jp/easy-update-metadata-dataset","homepage":null,"size":56,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DANS-KNAW:master","ref":"master","sha":"a24dcfab7e81ad336b566cc85da1b5415ae775c3","user":{"login":"DANS-KNAW","id":7858446,"avatar_url":"https://avatars.githubusercontent.com/u/7858446?v=3","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"repo":{"id":65281776,"name":"easy-update-metadata-dataset","full_name":"DANS-KNAW/easy-update-metadata-dataset","owner":{"login":"DANS-KNAW","id":7858446,"avatar_url":"https://avatars.githubusercontent.com/u/7858446?v=3","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DANS-KNAW/easy-update-metadata-dataset","description":"Batch-updates metadata streams in a Fedora Commons repository","fork":false,"url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset","forks_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/forks","keys_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/events","assignees_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/merges","archive_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/deployments","created_at":"2016-08-09T09:24:13Z","updated_at":"2016-11-07T16:44:23Z","pushed_at":"2016-12-09T20:51:31Z","git_url":"git://github.com/DANS-KNAW/easy-update-metadata-dataset.git","ssh_url":"git@github.com:DANS-KNAW/easy-update-metadata-dataset.git","clone_url":"https://github.com/DANS-KNAW/easy-update-metadata-dataset.git","svn_url":"https://github.com/DANS-KNAW/easy-update-metadata-dataset","homepage":null,"size":52,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5"},"html":{"href":"https://github.com/DANS-KNAW/easy-update-metadata-dataset/pull/5"},"issue":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/issues/5"},"comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/DANS-KNAW/easy-update-metadata-dataset/statuses/b915a61121002aefc0e946f10519406dae9a26f0"}}}}
{"actor":{"display_login":"jo-pol"}}