{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/comments/62192825","id":62192825,"diff_hunk":"@@ -150,7 +150,8 @@\n   context \"when an invalid JSON is fed to the listener\" do\n     subject { LogStash::Inputs::Gelf.new_event(message, \"host\") }\n     let(:message) { \"Invalid JSON message\" }\n-    if LogStash::Event.respond_to?(:from_java)\n+","path":"spec/inputs/gelf_spec.rb","position":5,"original_position":5,"commit_id":"abc5561db96adc506ef2a616430012678ec54aab","original_commit_id":"e62c0ff4e1c431980d995abc3d058c78af11e447","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"oh boy. this is why the specs never failed on the `LogStash::Event.from_json(json).each { |event| event }` weirdness","created_at":"2016-05-05T14:18:12Z","updated_at":"2016-05-05T14:18:12Z","html_url":"https://github.com/logstash-plugins/logstash-input-gelf/pull/41#discussion_r62192825","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/comments/62192825"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-gelf/pull/41#discussion_r62192825"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41","id":68887434,"html_url":"https://github.com/logstash-plugins/logstash-input-gelf/pull/41","diff_url":"https://github.com/logstash-plugins/logstash-input-gelf/pull/41.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-gelf/pull/41.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/issues/41","number":41,"state":"open","locked":false,"title":"Make this plugin works under 5.0","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"Fix an issue with the java json parse that was return an array instead\r\nof single element, fix the test that were using the wrong condition.\r\n\r\nAnd reformat the changelog to follow the new convention\r\n\r\nFixes #41","created_at":"2016-05-04T16:00:19Z","updated_at":"2016-05-05T14:18:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa2cb176e916d5ed73603f3fb7de84b4c1e4592c","assignee":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars.githubusercontent.com/u/2010?v=3","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/issues/41/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/statuses/abc5561db96adc506ef2a616430012678ec54aab","head":{"label":"ph:fix/make-this-plugin-works-under-5.0","ref":"fix/make-this-plugin-works-under-5.0","sha":"abc5561db96adc506ef2a616430012678ec54aab","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"repo":{"id":26220941,"name":"logstash-input-gelf","full_name":"ph/logstash-input-gelf","owner":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ph/logstash-input-gelf","description":null,"fork":true,"url":"https://api.github.com/repos/ph/logstash-input-gelf","forks_url":"https://api.github.com/repos/ph/logstash-input-gelf/forks","keys_url":"https://api.github.com/repos/ph/logstash-input-gelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ph/logstash-input-gelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ph/logstash-input-gelf/teams","hooks_url":"https://api.github.com/repos/ph/logstash-input-gelf/hooks","issue_events_url":"https://api.github.com/repos/ph/logstash-input-gelf/issues/events{/number}","events_url":"https://api.github.com/repos/ph/logstash-input-gelf/events","assignees_url":"https://api.github.com/repos/ph/logstash-input-gelf/assignees{/user}","branches_url":"https://api.github.com/repos/ph/logstash-input-gelf/branches{/branch}","tags_url":"https://api.github.com/repos/ph/logstash-input-gelf/tags","blobs_url":"https://api.github.com/repos/ph/logstash-input-gelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ph/logstash-input-gelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ph/logstash-input-gelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/ph/logstash-input-gelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ph/logstash-input-gelf/statuses/{sha}","languages_url":"https://api.github.com/repos/ph/logstash-input-gelf/languages","stargazers_url":"https://api.github.com/repos/ph/logstash-input-gelf/stargazers","contributors_url":"https://api.github.com/repos/ph/logstash-input-gelf/contributors","subscribers_url":"https://api.github.com/repos/ph/logstash-input-gelf/subscribers","subscription_url":"https://api.github.com/repos/ph/logstash-input-gelf/subscription","commits_url":"https://api.github.com/repos/ph/logstash-input-gelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/ph/logstash-input-gelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/ph/logstash-input-gelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/ph/logstash-input-gelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/ph/logstash-input-gelf/contents/{+path}","compare_url":"https://api.github.com/repos/ph/logstash-input-gelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ph/logstash-input-gelf/merges","archive_url":"https://api.github.com/repos/ph/logstash-input-gelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ph/logstash-input-gelf/downloads","issues_url":"https://api.github.com/repos/ph/logstash-input-gelf/issues{/number}","pulls_url":"https://api.github.com/repos/ph/logstash-input-gelf/pulls{/number}","milestones_url":"https://api.github.com/repos/ph/logstash-input-gelf/milestones{/number}","notifications_url":"https://api.github.com/repos/ph/logstash-input-gelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ph/logstash-input-gelf/labels{/name}","releases_url":"https://api.github.com/repos/ph/logstash-input-gelf/releases{/id}","deployments_url":"https://api.github.com/repos/ph/logstash-input-gelf/deployments","created_at":"2014-11-05T13:35:02Z","updated_at":"2014-11-01T06:33:53Z","pushed_at":"2016-05-05T14:18:04Z","git_url":"git://github.com/ph/logstash-input-gelf.git","ssh_url":"git@github.com:ph/logstash-input-gelf.git","clone_url":"https://github.com/ph/logstash-input-gelf.git","svn_url":"https://github.com/ph/logstash-input-gelf","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"06661b189035481f689c143092d2237aebb3b9af","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25312463,"name":"logstash-input-gelf","full_name":"logstash-plugins/logstash-input-gelf","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-gelf","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/deployments","created_at":"2014-10-16T17:03:07Z","updated_at":"2016-02-23T20:46:35Z","pushed_at":"2016-05-05T14:18:04Z","git_url":"git://github.com/logstash-plugins/logstash-input-gelf.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-gelf.git","clone_url":"https://github.com/logstash-plugins/logstash-input-gelf.git","svn_url":"https://github.com/logstash-plugins/logstash-input-gelf","homepage":null,"size":69,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-gelf/pull/41"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/issues/41"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-gelf/statuses/abc5561db96adc506ef2a616430012678ec54aab"}}}}