{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/51351547","id":51351547,"diff_hunk":"@@ -32,13 +40,12 @@ EngineAux::EngineAux(const ChannelHandleAndGroup& handle_group, EffectsManager*\n }\n \n EngineAux::~EngineAux() {\n-    delete m_pEnabled;","path":"src/engine/engineaux.cpp","position":35,"original_position":35,"commit_id":"163708e47b979fcb8f17b5f59199fbaab5cad848","original_commit_id":"163708e47b979fcb8f17b5f59199fbaab5cad848","user":{"login":"Pegasus-RPG","id":4451008,"avatar_url":"https://avatars.githubusercontent.com/u/4451008?v=3","gravatar_id":"","url":"https://api.github.com/users/Pegasus-RPG","html_url":"https://github.com/Pegasus-RPG","followers_url":"https://api.github.com/users/Pegasus-RPG/followers","following_url":"https://api.github.com/users/Pegasus-RPG/following{/other_user}","gists_url":"https://api.github.com/users/Pegasus-RPG/gists{/gist_id}","starred_url":"https://api.github.com/users/Pegasus-RPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pegasus-RPG/subscriptions","organizations_url":"https://api.github.com/users/Pegasus-RPG/orgs","repos_url":"https://api.github.com/users/Pegasus-RPG/repos","events_url":"https://api.github.com/users/Pegasus-RPG/events{/privacy}","received_events_url":"https://api.github.com/users/Pegasus-RPG/received_events","type":"User","site_admin":false},"body":"Ah, no you don't, thanks to QScopedPointer. Sorry for the noise.","created_at":"2016-01-30T21:46:21Z","updated_at":"2016-01-30T21:46:21Z","html_url":"https://github.com/mixxxdj/mixxx/pull/858#discussion_r51351547","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/51351547"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/858#discussion_r51351547"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858","id":56231395,"html_url":"https://github.com/mixxxdj/mixxx/pull/858","diff_url":"https://github.com/mixxxdj/mixxx/pull/858.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/858.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858","number":858,"state":"open","locked":false,"title":"Move menu logic and VC/Passthrough/Mic checking out of MixxxMainWindow.","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"Drops 1000+ lines from mixxx.h/mixxx.cpp -- now they're \"only\" 1400 lines!\r\n\r\nI'm out for the weekend but figured I'd get this PR started. Some notes:\r\n\r\n* I removed the re-creation of the menu bar when toggling full screen. Bug #885890 and #1076789. I'd like to see if we still need this workaround on Trusty onwards. Maybe various bugs are fixed? In either case, @Pegasus-RPG reported that menubars are still broken on KDE so maybe this isn't the right fix after all.\r\n\r\n* I removed the partial menubar creation during bootup -- for me, QWidget::setMenuBar takes 95% of the time in initMenuBar() so not creating the full menubar doesn't seem like much of a savings to me at the code complexity cost it introduced.\r\n\r\n* I still have some TODO(rryan)'s in WMainMenuBar that I intend to fix before merging.","created_at":"2016-01-15T22:45:46Z","updated_at":"2016-01-30T21:46:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0276125f8dadf60e4485943df1034951de0a9405","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/858/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/163708e47b979fcb8f17b5f59199fbaab5cad848","head":{"label":"rryan:menubar","ref":"menubar","sha":"163708e47b979fcb8f17b5f59199fbaab5cad848","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"repo":{"id":10690290,"name":"mixxx","full_name":"rryan/mixxx","owner":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rryan/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/rryan/mixxx","forks_url":"https://api.github.com/repos/rryan/mixxx/forks","keys_url":"https://api.github.com/repos/rryan/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rryan/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rryan/mixxx/teams","hooks_url":"https://api.github.com/repos/rryan/mixxx/hooks","issue_events_url":"https://api.github.com/repos/rryan/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/rryan/mixxx/events","assignees_url":"https://api.github.com/repos/rryan/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/rryan/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/rryan/mixxx/tags","blobs_url":"https://api.github.com/repos/rryan/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rryan/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rryan/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/rryan/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rryan/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/rryan/mixxx/languages","stargazers_url":"https://api.github.com/repos/rryan/mixxx/stargazers","contributors_url":"https://api.github.com/repos/rryan/mixxx/contributors","subscribers_url":"https://api.github.com/repos/rryan/mixxx/subscribers","subscription_url":"https://api.github.com/repos/rryan/mixxx/subscription","commits_url":"https://api.github.com/repos/rryan/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/rryan/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/rryan/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/rryan/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/rryan/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/rryan/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rryan/mixxx/merges","archive_url":"https://api.github.com/repos/rryan/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rryan/mixxx/downloads","issues_url":"https://api.github.com/repos/rryan/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/rryan/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/rryan/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/rryan/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rryan/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/rryan/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/rryan/mixxx/deployments","created_at":"2013-06-14T14:11:10Z","updated_at":"2014-09-27T19:25:20Z","pushed_at":"2016-01-28T09:07:17Z","git_url":"git://github.com/rryan/mixxx.git","ssh_url":"git@github.com:rryan/mixxx.git","clone_url":"https://github.com/rryan/mixxx.git","svn_url":"https://github.com/rryan/mixxx","homepage":"http://mixxx.org","size":256891,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"f765a69618ecb49e87e9fea84f92fa23ccaab92c","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-01-27T21:34:22Z","pushed_at":"2016-01-30T19:03:32Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":266894,"stargazers_count":455,"watchers_count":455,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":58,"forks":286,"open_issues":58,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/858"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/858"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/858/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/858/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/163708e47b979fcb8f17b5f59199fbaab5cad848"}}}}