{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/comments/57431205","id":57431205,"diff_hunk":"@@ -106,19 +124,35 @@ export class InvocationService {\n         var messageType = clientMessage.getMessageType();\n \n         if (clientMessage.hasFlags(BitsUtil.LISTENER_FLAG)) {\n-            Q.fcall(this.eventHandlers[correlationId].handler, clientMessage);","path":"src/invocation/InvocationService.ts","position":87,"original_position":87,"commit_id":"f332ae2e02667f2f262e0f7196597e17b7328ac8","original_commit_id":"572d9b520caedbce7ae7c311b9615530e5894a7f","user":{"login":"GhostInAMachine","id":11163575,"avatar_url":"https://avatars.githubusercontent.com/u/11163575?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostInAMachine","html_url":"https://github.com/GhostInAMachine","followers_url":"https://api.github.com/users/GhostInAMachine/followers","following_url":"https://api.github.com/users/GhostInAMachine/following{/other_user}","gists_url":"https://api.github.com/users/GhostInAMachine/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostInAMachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostInAMachine/subscriptions","organizations_url":"https://api.github.com/users/GhostInAMachine/orgs","repos_url":"https://api.github.com/users/GhostInAMachine/repos","events_url":"https://api.github.com/users/GhostInAMachine/events{/privacy}","received_events_url":"https://api.github.com/users/GhostInAMachine/received_events","type":"User","site_admin":false},"body":"@mustafaiman Latest commit wraps the callback with setImmediate","created_at":"2016-03-25T09:38:14Z","updated_at":"2016-03-25T09:38:14Z","html_url":"https://github.com/hazelcast/hazelcast-nodejs-client/pull/50#discussion_r57431205","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/comments/57431205"},"html":{"href":"https://github.com/hazelcast/hazelcast-nodejs-client/pull/50#discussion_r57431205"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50","id":63537772,"html_url":"https://github.com/hazelcast/hazelcast-nodejs-client/pull/50","diff_url":"https://github.com/hazelcast/hazelcast-nodejs-client/pull/50.diff","patch_url":"https://github.com/hazelcast/hazelcast-nodejs-client/pull/50.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/issues/50","number":50,"state":"open","locked":false,"title":"Invocation retry","user":{"login":"GhostInAMachine","id":11163575,"avatar_url":"https://avatars.githubusercontent.com/u/11163575?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostInAMachine","html_url":"https://github.com/GhostInAMachine","followers_url":"https://api.github.com/users/GhostInAMachine/followers","following_url":"https://api.github.com/users/GhostInAMachine/following{/other_user}","gists_url":"https://api.github.com/users/GhostInAMachine/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostInAMachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostInAMachine/subscriptions","organizations_url":"https://api.github.com/users/GhostInAMachine/orgs","repos_url":"https://api.github.com/users/GhostInAMachine/repos","events_url":"https://api.github.com/users/GhostInAMachine/events{/privacy}","received_events_url":"https://api.github.com/users/GhostInAMachine/received_events","type":"User","site_admin":false},"body":"You can test retrying by setting up a map interceptor which would throw an exception like NullPointerException and then adding a relevant exception code to isRetryable method in RemoteException class","created_at":"2016-03-21T09:36:15Z","updated_at":"2016-03-25T09:38:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2a1bd844c592d95ea51995d87ab74c6ad6531c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/issues/50/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/statuses/f332ae2e02667f2f262e0f7196597e17b7328ac8","head":{"label":"GhostInAMachine:Invocation_Retry","ref":"Invocation_Retry","sha":"f332ae2e02667f2f262e0f7196597e17b7328ac8","user":{"login":"GhostInAMachine","id":11163575,"avatar_url":"https://avatars.githubusercontent.com/u/11163575?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostInAMachine","html_url":"https://github.com/GhostInAMachine","followers_url":"https://api.github.com/users/GhostInAMachine/followers","following_url":"https://api.github.com/users/GhostInAMachine/following{/other_user}","gists_url":"https://api.github.com/users/GhostInAMachine/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostInAMachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostInAMachine/subscriptions","organizations_url":"https://api.github.com/users/GhostInAMachine/orgs","repos_url":"https://api.github.com/users/GhostInAMachine/repos","events_url":"https://api.github.com/users/GhostInAMachine/events{/privacy}","received_events_url":"https://api.github.com/users/GhostInAMachine/received_events","type":"User","site_admin":false},"repo":{"id":47989854,"name":"hazelcast-nodejs-client","full_name":"GhostInAMachine/hazelcast-nodejs-client","owner":{"login":"GhostInAMachine","id":11163575,"avatar_url":"https://avatars.githubusercontent.com/u/11163575?v=3","gravatar_id":"","url":"https://api.github.com/users/GhostInAMachine","html_url":"https://github.com/GhostInAMachine","followers_url":"https://api.github.com/users/GhostInAMachine/followers","following_url":"https://api.github.com/users/GhostInAMachine/following{/other_user}","gists_url":"https://api.github.com/users/GhostInAMachine/gists{/gist_id}","starred_url":"https://api.github.com/users/GhostInAMachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GhostInAMachine/subscriptions","organizations_url":"https://api.github.com/users/GhostInAMachine/orgs","repos_url":"https://api.github.com/users/GhostInAMachine/repos","events_url":"https://api.github.com/users/GhostInAMachine/events{/privacy}","received_events_url":"https://api.github.com/users/GhostInAMachine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GhostInAMachine/hazelcast-nodejs-client","description":"NodeJS Client for Hazelcast, using Hazelcast Open Client Protocol 1.0 for Hazelcast 3.6 and higher","fork":true,"url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client","forks_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/forks","keys_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/teams","hooks_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/hooks","issue_events_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/issues/events{/number}","events_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/events","assignees_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/assignees{/user}","branches_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/branches{/branch}","tags_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/tags","blobs_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/statuses/{sha}","languages_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/languages","stargazers_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/stargazers","contributors_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/contributors","subscribers_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/subscribers","subscription_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/subscription","commits_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/contents/{+path}","compare_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/merges","archive_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/downloads","issues_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/issues{/number}","pulls_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/pulls{/number}","milestones_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/milestones{/number}","notifications_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/labels{/name}","releases_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/releases{/id}","deployments_url":"https://api.github.com/repos/GhostInAMachine/hazelcast-nodejs-client/deployments","created_at":"2015-12-14T17:15:57Z","updated_at":"2016-03-16T08:45:04Z","pushed_at":"2016-03-25T09:37:12Z","git_url":"git://github.com/GhostInAMachine/hazelcast-nodejs-client.git","ssh_url":"git@github.com:GhostInAMachine/hazelcast-nodejs-client.git","clone_url":"https://github.com/GhostInAMachine/hazelcast-nodejs-client.git","svn_url":"https://github.com/GhostInAMachine/hazelcast-nodejs-client","homepage":null,"size":146,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"64e6d15457a29f87ae534f4be2c079ef2b59b4a4","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":45202495,"name":"hazelcast-nodejs-client","full_name":"hazelcast/hazelcast-nodejs-client","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast-nodejs-client","description":"NodeJS Client for Hazelcast, using Hazelcast Open Client Protocol 1.0 for Hazelcast 3.6 and higher","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client","forks_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/deployments","created_at":"2015-10-29T18:24:48Z","updated_at":"2016-03-16T08:45:04Z","pushed_at":"2016-03-25T09:37:13Z","git_url":"git://github.com/hazelcast/hazelcast-nodejs-client.git","ssh_url":"git@github.com:hazelcast/hazelcast-nodejs-client.git","clone_url":"https://github.com/hazelcast/hazelcast-nodejs-client.git","svn_url":"https://github.com/hazelcast/hazelcast-nodejs-client","homepage":null,"size":214,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":15,"forks":6,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50"},"html":{"href":"https://github.com/hazelcast/hazelcast-nodejs-client/pull/50"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/issues/50"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast-nodejs-client/statuses/f332ae2e02667f2f262e0f7196597e17b7328ac8"}}}}