{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/92090514","pull_request_review_id":12599521,"id":92090514,"diff_hunk":"@@ -0,0 +1,21 @@\n+/* mbed Microcontroller Library\n+ * Copyright (c) 2006-2016 ARM Limited\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+void mbed_sdk_init()\n+{\n+\tprintf(\"\", __TIME__, __DATE__);\t","path":"targets/TARGET_NORDIC/TARGET_NRF5/TARGET_MCU_NRF52832/TARGET_DELTA_DFBM_NQ620/mbed_overrides.c","position":19,"original_position":19,"commit_id":"fbd2cc256cd16d71b3b200cb2b6cd262860f279c","original_commit_id":"b1d8aa72ab39531a8f31cff70a553a26cc625d5b","user":{"login":"TsungtaWu","id":20415931,"avatar_url":"https://avatars.githubusercontent.com/u/20415931?v=3","gravatar_id":"","url":"https://api.github.com/users/TsungtaWu","html_url":"https://github.com/TsungtaWu","followers_url":"https://api.github.com/users/TsungtaWu/followers","following_url":"https://api.github.com/users/TsungtaWu/following{/other_user}","gists_url":"https://api.github.com/users/TsungtaWu/gists{/gist_id}","starred_url":"https://api.github.com/users/TsungtaWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsungtaWu/subscriptions","organizations_url":"https://api.github.com/users/TsungtaWu/orgs","repos_url":"https://api.github.com/users/TsungtaWu/repos","events_url":"https://api.github.com/users/TsungtaWu/events{/privacy}","received_events_url":"https://api.github.com/users/TsungtaWu/received_events","type":"User","site_admin":false},"body":"This line is used to allow compiler to build __TIME__ and __DATE__ in memory, so application can aceess in some cases when debugging. This line is put under mbed_sdk_init is beacuse we like to have those value as reserved in every compile.","created_at":"2016-12-13T03:07:17Z","updated_at":"2016-12-13T03:07:18Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/3423#discussion_r92090514","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/92090514"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3423#discussion_r92090514"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423","id":97505739,"html_url":"https://github.com/ARMmbed/mbed-os/pull/3423","diff_url":"https://github.com/ARMmbed/mbed-os/pull/3423.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/3423.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3423","number":3423,"state":"open","locked":false,"title":"DELTA_DFCM_NNN50 platform porting","user":{"login":"TsungtaWu","id":20415931,"avatar_url":"https://avatars.githubusercontent.com/u/20415931?v=3","gravatar_id":"","url":"https://api.github.com/users/TsungtaWu","html_url":"https://github.com/TsungtaWu","followers_url":"https://api.github.com/users/TsungtaWu/followers","following_url":"https://api.github.com/users/TsungtaWu/following{/other_user}","gists_url":"https://api.github.com/users/TsungtaWu/gists{/gist_id}","starred_url":"https://api.github.com/users/TsungtaWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsungtaWu/subscriptions","organizations_url":"https://api.github.com/users/TsungtaWu/orgs","repos_url":"https://api.github.com/users/TsungtaWu/repos","events_url":"https://api.github.com/users/TsungtaWu/events{/privacy}","received_events_url":"https://api.github.com/users/TsungtaWu/received_events","type":"User","site_admin":false},"body":"We manege to finish the porting of DELTA_DFCM_NNN50 based on the existing platform NRF51_DK.\r\nGreentea result is shown as below\r\nmbedgt: test suite results: 43 OK / 5 ERROR\r\nmbedgt: test case results: 156 OK / 5 ERROR\r\nThe 5 ERROR are\r\nmbed-os-tests-mbed_drivers-ticker\r\nmbed-os-tests-mbed_drivers-timeout\r\nmbed-os-tests-mbed_drivers-wait_us\r\nmbed-os-tests-mbedmicro-rtos-mbed-basic\r\nmbed-os-tests-mbedmicro-rtos-mbed-timer\r\nNevertheless, NRF51_DK platform have the same ERROR. So I consider thoese as the knowing issues.\r\nPlease kindly review this PR.","created_at":"2016-12-12T07:26:51Z","updated_at":"2016-12-13T03:07:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77026ab7edfbe2bf6887ef9300e50bcca923ba36","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3423/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/fbd2cc256cd16d71b3b200cb2b6cd262860f279c","head":{"label":"TsungtaWu:master","ref":"master","sha":"fbd2cc256cd16d71b3b200cb2b6cd262860f279c","user":{"login":"TsungtaWu","id":20415931,"avatar_url":"https://avatars.githubusercontent.com/u/20415931?v=3","gravatar_id":"","url":"https://api.github.com/users/TsungtaWu","html_url":"https://github.com/TsungtaWu","followers_url":"https://api.github.com/users/TsungtaWu/followers","following_url":"https://api.github.com/users/TsungtaWu/following{/other_user}","gists_url":"https://api.github.com/users/TsungtaWu/gists{/gist_id}","starred_url":"https://api.github.com/users/TsungtaWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsungtaWu/subscriptions","organizations_url":"https://api.github.com/users/TsungtaWu/orgs","repos_url":"https://api.github.com/users/TsungtaWu/repos","events_url":"https://api.github.com/users/TsungtaWu/events{/privacy}","received_events_url":"https://api.github.com/users/TsungtaWu/received_events","type":"User","site_admin":false},"repo":{"id":67779319,"name":"mbed-os","full_name":"TsungtaWu/mbed-os","owner":{"login":"TsungtaWu","id":20415931,"avatar_url":"https://avatars.githubusercontent.com/u/20415931?v=3","gravatar_id":"","url":"https://api.github.com/users/TsungtaWu","html_url":"https://github.com/TsungtaWu","followers_url":"https://api.github.com/users/TsungtaWu/followers","following_url":"https://api.github.com/users/TsungtaWu/following{/other_user}","gists_url":"https://api.github.com/users/TsungtaWu/gists{/gist_id}","starred_url":"https://api.github.com/users/TsungtaWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsungtaWu/subscriptions","organizations_url":"https://api.github.com/users/TsungtaWu/orgs","repos_url":"https://api.github.com/users/TsungtaWu/repos","events_url":"https://api.github.com/users/TsungtaWu/events{/privacy}","received_events_url":"https://api.github.com/users/TsungtaWu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TsungtaWu/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/TsungtaWu/mbed-os","forks_url":"https://api.github.com/repos/TsungtaWu/mbed-os/forks","keys_url":"https://api.github.com/repos/TsungtaWu/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TsungtaWu/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TsungtaWu/mbed-os/teams","hooks_url":"https://api.github.com/repos/TsungtaWu/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/TsungtaWu/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/TsungtaWu/mbed-os/events","assignees_url":"https://api.github.com/repos/TsungtaWu/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/TsungtaWu/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/TsungtaWu/mbed-os/tags","blobs_url":"https://api.github.com/repos/TsungtaWu/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TsungtaWu/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TsungtaWu/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/TsungtaWu/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TsungtaWu/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/TsungtaWu/mbed-os/languages","stargazers_url":"https://api.github.com/repos/TsungtaWu/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/TsungtaWu/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/TsungtaWu/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/TsungtaWu/mbed-os/subscription","commits_url":"https://api.github.com/repos/TsungtaWu/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/TsungtaWu/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/TsungtaWu/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/TsungtaWu/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/TsungtaWu/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/TsungtaWu/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TsungtaWu/mbed-os/merges","archive_url":"https://api.github.com/repos/TsungtaWu/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TsungtaWu/mbed-os/downloads","issues_url":"https://api.github.com/repos/TsungtaWu/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/TsungtaWu/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/TsungtaWu/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/TsungtaWu/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TsungtaWu/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/TsungtaWu/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/TsungtaWu/mbed-os/deployments","created_at":"2016-09-09T08:04:19Z","updated_at":"2016-09-09T08:05:35Z","pushed_at":"2016-12-13T02:50:58Z","git_url":"git://github.com/TsungtaWu/mbed-os.git","ssh_url":"git@github.com:TsungtaWu/mbed-os.git","clone_url":"https://github.com/TsungtaWu/mbed-os.git","svn_url":"https://github.com/TsungtaWu/mbed-os","homepage":"https://mbed.com","size":99227,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"ce9d2526f802951989ff0842a3828f7ad76126b8","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2016-12-12T04:58:09Z","pushed_at":"2016-12-13T02:51:00Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":125184,"stargazers_count":852,"watchers_count":852,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":828,"mirror_url":null,"open_issues_count":451,"forks":828,"open_issues":451,"watchers":852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/3423"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3423"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/3423/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/3423/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/fbd2cc256cd16d71b3b200cb2b6cd262860f279c"}}}}
{"actor":{"display_login":"TsungtaWu"}}