{"action":"created","comment":{"url":"https://api.github.com/repos/npm/pivotal-ui/pulls/comments/59491945","id":59491945,"diff_hunk":"@@ -13,47 +13,87 @@ categories:\n  - css_all\n ---\n \n-\n <code class=\"pam\">\n-<i class=\"fa fa-download\" alt=\"Install the Component\">\n+<svg class=\"icon\"><use xlink:href=\"#i-download\"/></svg>\n npm install @npmcorp/pui-css-iconography --save\n-</i>\n </code>\n \n \n-We use [Font Awesome](http://fortawesome.github.io/Font-Awesome/icons/) for scalable vector icons that can be customized - size, color, drop shadow,\n-and anything that can be done with CSS. These icons will always match the font color.\n+We use [Glyphish](http://www.glyphish.com) for scalable icons. They have been packaged up as [@npmcorp/glyphish] for use, and inserting them as SVG `<symbol>` allows us to use the same icon multiple times with only a minimal bit of code for further instances.\n+\n+These icons will always match the font color.","path":"src/pivotal-ui/components/iconography/iconography.scss","position":17,"original_position":17,"commit_id":"8765d0241ab4ba85ddbd9b9723e7a92a7bb0f1f5","original_commit_id":"8765d0241ab4ba85ddbd9b9723e7a92a7bb0f1f5","user":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"body":"They will!","created_at":"2016-04-13T04:37:31Z","updated_at":"2016-04-13T04:37:31Z","html_url":"https://github.com/npm/pivotal-ui/pull/112#discussion_r59491945","pull_request_url":"https://api.github.com/repos/npm/pivotal-ui/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/npm/pivotal-ui/pulls/comments/59491945"},"html":{"href":"https://github.com/npm/pivotal-ui/pull/112#discussion_r59491945"},"pull_request":{"href":"https://api.github.com/repos/npm/pivotal-ui/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/npm/pivotal-ui/pulls/112","id":66234355,"html_url":"https://github.com/npm/pivotal-ui/pull/112","diff_url":"https://github.com/npm/pivotal-ui/pull/112.diff","patch_url":"https://github.com/npm/pivotal-ui/pull/112.patch","issue_url":"https://api.github.com/repos/npm/pivotal-ui/issues/112","number":112,"state":"open","locked":false,"title":"feat(iconography): Add glyphish iconography, including a note about the handlebars helper","user":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"body":"This approach should serve us well, though it's awkward to implement manually in plain HTML.\r\n\r\nThe helper should automate all the tedium for our actual use cases, and leave us with our transfer as minimal as possible per-page.\r\n\r\nColor can be changed by any font-color changing classes.\r\n\r\nSizes can be changed by font-size changing classes.","created_at":"2016-04-12T21:52:41Z","updated_at":"2016-04-13T04:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29f983e843549a842a82f93756c0310dc17ce2ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/npm/pivotal-ui/pulls/112/commits","review_comments_url":"https://api.github.com/repos/npm/pivotal-ui/pulls/112/comments","review_comment_url":"https://api.github.com/repos/npm/pivotal-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/npm/pivotal-ui/issues/112/comments","statuses_url":"https://api.github.com/repos/npm/pivotal-ui/statuses/8765d0241ab4ba85ddbd9b9723e7a92a7bb0f1f5","head":{"label":"aredridel:glyphish-iconography","ref":"glyphish-iconography","sha":"8765d0241ab4ba85ddbd9b9723e7a92a7bb0f1f5","user":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"repo":{"id":52307210,"name":"pivotal-ui","full_name":"aredridel/pivotal-ui","owner":{"login":"aredridel","id":2876,"avatar_url":"https://avatars.githubusercontent.com/u/2876?v=3","gravatar_id":"","url":"https://api.github.com/users/aredridel","html_url":"https://github.com/aredridel","followers_url":"https://api.github.com/users/aredridel/followers","following_url":"https://api.github.com/users/aredridel/following{/other_user}","gists_url":"https://api.github.com/users/aredridel/gists{/gist_id}","starred_url":"https://api.github.com/users/aredridel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aredridel/subscriptions","organizations_url":"https://api.github.com/users/aredridel/orgs","repos_url":"https://api.github.com/users/aredridel/repos","events_url":"https://api.github.com/users/aredridel/events{/privacy}","received_events_url":"https://api.github.com/users/aredridel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aredridel/pivotal-ui","description":"","fork":true,"url":"https://api.github.com/repos/aredridel/pivotal-ui","forks_url":"https://api.github.com/repos/aredridel/pivotal-ui/forks","keys_url":"https://api.github.com/repos/aredridel/pivotal-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aredridel/pivotal-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aredridel/pivotal-ui/teams","hooks_url":"https://api.github.com/repos/aredridel/pivotal-ui/hooks","issue_events_url":"https://api.github.com/repos/aredridel/pivotal-ui/issues/events{/number}","events_url":"https://api.github.com/repos/aredridel/pivotal-ui/events","assignees_url":"https://api.github.com/repos/aredridel/pivotal-ui/assignees{/user}","branches_url":"https://api.github.com/repos/aredridel/pivotal-ui/branches{/branch}","tags_url":"https://api.github.com/repos/aredridel/pivotal-ui/tags","blobs_url":"https://api.github.com/repos/aredridel/pivotal-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aredridel/pivotal-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aredridel/pivotal-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/aredridel/pivotal-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aredridel/pivotal-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/aredridel/pivotal-ui/languages","stargazers_url":"https://api.github.com/repos/aredridel/pivotal-ui/stargazers","contributors_url":"https://api.github.com/repos/aredridel/pivotal-ui/contributors","subscribers_url":"https://api.github.com/repos/aredridel/pivotal-ui/subscribers","subscription_url":"https://api.github.com/repos/aredridel/pivotal-ui/subscription","commits_url":"https://api.github.com/repos/aredridel/pivotal-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/aredridel/pivotal-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/aredridel/pivotal-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/aredridel/pivotal-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/aredridel/pivotal-ui/contents/{+path}","compare_url":"https://api.github.com/repos/aredridel/pivotal-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aredridel/pivotal-ui/merges","archive_url":"https://api.github.com/repos/aredridel/pivotal-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aredridel/pivotal-ui/downloads","issues_url":"https://api.github.com/repos/aredridel/pivotal-ui/issues{/number}","pulls_url":"https://api.github.com/repos/aredridel/pivotal-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/aredridel/pivotal-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/aredridel/pivotal-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aredridel/pivotal-ui/labels{/name}","releases_url":"https://api.github.com/repos/aredridel/pivotal-ui/releases{/id}","deployments_url":"https://api.github.com/repos/aredridel/pivotal-ui/deployments","created_at":"2016-02-22T21:28:00Z","updated_at":"2016-02-22T21:28:05Z","pushed_at":"2016-04-13T02:09:04Z","git_url":"git://github.com/aredridel/pivotal-ui.git","ssh_url":"git@github.com:aredridel/pivotal-ui.git","clone_url":"https://github.com/aredridel/pivotal-ui.git","svn_url":"https://github.com/aredridel/pivotal-ui","homepage":"styleguide.cfapps.io","size":33715,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"npm-branding"}},"base":{"label":"npm:master","ref":"master","sha":"0c9f7fea2e4a1c941ff1615327b1e2d1841eabf8","user":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"repo":{"id":50528473,"name":"pivotal-ui","full_name":"npm/pivotal-ui","owner":{"login":"npm","id":6078720,"avatar_url":"https://avatars.githubusercontent.com/u/6078720?v=3","gravatar_id":"","url":"https://api.github.com/users/npm","html_url":"https://github.com/npm","followers_url":"https://api.github.com/users/npm/followers","following_url":"https://api.github.com/users/npm/following{/other_user}","gists_url":"https://api.github.com/users/npm/gists{/gist_id}","starred_url":"https://api.github.com/users/npm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npm/subscriptions","organizations_url":"https://api.github.com/users/npm/orgs","repos_url":"https://api.github.com/users/npm/repos","events_url":"https://api.github.com/users/npm/events{/privacy}","received_events_url":"https://api.github.com/users/npm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/npm/pivotal-ui","description":"","fork":true,"url":"https://api.github.com/repos/npm/pivotal-ui","forks_url":"https://api.github.com/repos/npm/pivotal-ui/forks","keys_url":"https://api.github.com/repos/npm/pivotal-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/npm/pivotal-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/npm/pivotal-ui/teams","hooks_url":"https://api.github.com/repos/npm/pivotal-ui/hooks","issue_events_url":"https://api.github.com/repos/npm/pivotal-ui/issues/events{/number}","events_url":"https://api.github.com/repos/npm/pivotal-ui/events","assignees_url":"https://api.github.com/repos/npm/pivotal-ui/assignees{/user}","branches_url":"https://api.github.com/repos/npm/pivotal-ui/branches{/branch}","tags_url":"https://api.github.com/repos/npm/pivotal-ui/tags","blobs_url":"https://api.github.com/repos/npm/pivotal-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/npm/pivotal-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/npm/pivotal-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/npm/pivotal-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/npm/pivotal-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/npm/pivotal-ui/languages","stargazers_url":"https://api.github.com/repos/npm/pivotal-ui/stargazers","contributors_url":"https://api.github.com/repos/npm/pivotal-ui/contributors","subscribers_url":"https://api.github.com/repos/npm/pivotal-ui/subscribers","subscription_url":"https://api.github.com/repos/npm/pivotal-ui/subscription","commits_url":"https://api.github.com/repos/npm/pivotal-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/npm/pivotal-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/npm/pivotal-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/npm/pivotal-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/npm/pivotal-ui/contents/{+path}","compare_url":"https://api.github.com/repos/npm/pivotal-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/npm/pivotal-ui/merges","archive_url":"https://api.github.com/repos/npm/pivotal-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/npm/pivotal-ui/downloads","issues_url":"https://api.github.com/repos/npm/pivotal-ui/issues{/number}","pulls_url":"https://api.github.com/repos/npm/pivotal-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/npm/pivotal-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/npm/pivotal-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/npm/pivotal-ui/labels{/name}","releases_url":"https://api.github.com/repos/npm/pivotal-ui/releases{/id}","deployments_url":"https://api.github.com/repos/npm/pivotal-ui/deployments","created_at":"2016-01-27T18:28:21Z","updated_at":"2016-04-07T04:13:36Z","pushed_at":"2016-04-13T02:09:04Z","git_url":"git://github.com/npm/pivotal-ui.git","ssh_url":"git@github.com:npm/pivotal-ui.git","clone_url":"https://github.com/npm/pivotal-ui.git","svn_url":"https://github.com/npm/pivotal-ui","homepage":"styleguide.cfapps.io","size":34771,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/npm/pivotal-ui/pulls/112"},"html":{"href":"https://github.com/npm/pivotal-ui/pull/112"},"issue":{"href":"https://api.github.com/repos/npm/pivotal-ui/issues/112"},"comments":{"href":"https://api.github.com/repos/npm/pivotal-ui/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/npm/pivotal-ui/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/npm/pivotal-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/npm/pivotal-ui/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/npm/pivotal-ui/statuses/8765d0241ab4ba85ddbd9b9723e7a92a7bb0f1f5"}}}}