{"action":"created","comment":{"url":"https://api.github.com/repos/deis/workflow/pulls/comments/49773419","id":49773419,"diff_hunk":"@@ -7,9 +7,15 @@ import (\n func TestRemoteURL(t *testing.T) {\n \tt.Parallel()\n \n+\tactual := RemoteURL(\"example.com\", \"app\")\n \texpected := \"ssh://git@example.com:2222/app.git\"\n \n-\tactual := RemoteURL(\"example.com\", \"app\")\n+\tif actual != expected {\n+\t\tt.Errorf(\"Expected %s, Got %s\", expected, actual)\n+\t}\n+\n+\tactual = RemoteURL(\"deis.10.245.1.3.xip.io:31350\", \"velcro-underdog\")","path":"client/pkg/git/git_test.go","position":12,"original_position":12,"commit_id":"c76257ca80fd4576a5a44b6119bb2f77ac22a4ea","original_commit_id":"c76257ca80fd4576a5a44b6119bb2f77ac22a4ea","user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"body":"we should also keep the original test for \"example.com\" so we can ensure that remote URLs with no port number don't error out :)","created_at":"2016-01-14T19:34:29Z","updated_at":"2016-01-14T19:34:29Z","html_url":"https://github.com/deis/workflow/pull/280#discussion_r49773419","pull_request_url":"https://api.github.com/repos/deis/workflow/pulls/280","_links":{"self":{"href":"https://api.github.com/repos/deis/workflow/pulls/comments/49773419"},"html":{"href":"https://github.com/deis/workflow/pull/280#discussion_r49773419"},"pull_request":{"href":"https://api.github.com/repos/deis/workflow/pulls/280"}}},"pull_request":{"url":"https://api.github.com/repos/deis/workflow/pulls/280","id":56082101,"html_url":"https://github.com/deis/workflow/pull/280","diff_url":"https://github.com/deis/workflow/pull/280.diff","patch_url":"https://github.com/deis/workflow/pull/280.patch","issue_url":"https://api.github.com/repos/deis/workflow/issues/280","number":280,"state":"open","locked":false,"title":"fix(client): replace port in git remote creation","user":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"body":"Closes #279.","created_at":"2016-01-14T19:32:12Z","updated_at":"2016-01-14T19:34:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45fbdacc7cb8b315a6be00651a7b36091ab0273a","assignee":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/workflow/milestones/3","html_url":"https://github.com/deis/workflow/milestones/v2.0-alpha2","labels_url":"https://api.github.com/repos/deis/workflow/milestones/3/labels","id":1465953,"number":3,"title":"v2.0-alpha2","description":"Pre-beta bugs/issues that we can quickly fix.","creator":{"login":"technosophos","id":89193,"avatar_url":"https://avatars.githubusercontent.com/u/89193?v=3","gravatar_id":"","url":"https://api.github.com/users/technosophos","html_url":"https://github.com/technosophos","followers_url":"https://api.github.com/users/technosophos/followers","following_url":"https://api.github.com/users/technosophos/following{/other_user}","gists_url":"https://api.github.com/users/technosophos/gists{/gist_id}","starred_url":"https://api.github.com/users/technosophos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technosophos/subscriptions","organizations_url":"https://api.github.com/users/technosophos/orgs","repos_url":"https://api.github.com/users/technosophos/repos","events_url":"https://api.github.com/users/technosophos/events{/privacy}","received_events_url":"https://api.github.com/users/technosophos/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":19,"state":"open","created_at":"2015-12-18T00:10:40Z","updated_at":"2016-01-14T19:32:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/deis/workflow/pulls/280/commits","review_comments_url":"https://api.github.com/repos/deis/workflow/pulls/280/comments","review_comment_url":"https://api.github.com/repos/deis/workflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/workflow/issues/280/comments","statuses_url":"https://api.github.com/repos/deis/workflow/statuses/c76257ca80fd4576a5a44b6119bb2f77ac22a4ea","head":{"label":"mboersma:fix-deis-create-git-remote","ref":"fix-deis-create-git-remote","sha":"c76257ca80fd4576a5a44b6119bb2f77ac22a4ea","user":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"repo":{"id":45704902,"name":"workflow","full_name":"mboersma/workflow","owner":{"login":"mboersma","id":73019,"avatar_url":"https://avatars.githubusercontent.com/u/73019?v=3","gravatar_id":"","url":"https://api.github.com/users/mboersma","html_url":"https://github.com/mboersma","followers_url":"https://api.github.com/users/mboersma/followers","following_url":"https://api.github.com/users/mboersma/following{/other_user}","gists_url":"https://api.github.com/users/mboersma/gists{/gist_id}","starred_url":"https://api.github.com/users/mboersma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboersma/subscriptions","organizations_url":"https://api.github.com/users/mboersma/orgs","repos_url":"https://api.github.com/users/mboersma/repos","events_url":"https://api.github.com/users/mboersma/events{/privacy}","received_events_url":"https://api.github.com/users/mboersma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mboersma/workflow","description":"PaaS workflow controller and client for Deis v2","fork":true,"url":"https://api.github.com/repos/mboersma/workflow","forks_url":"https://api.github.com/repos/mboersma/workflow/forks","keys_url":"https://api.github.com/repos/mboersma/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mboersma/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mboersma/workflow/teams","hooks_url":"https://api.github.com/repos/mboersma/workflow/hooks","issue_events_url":"https://api.github.com/repos/mboersma/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/mboersma/workflow/events","assignees_url":"https://api.github.com/repos/mboersma/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/mboersma/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/mboersma/workflow/tags","blobs_url":"https://api.github.com/repos/mboersma/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mboersma/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mboersma/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mboersma/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mboersma/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/mboersma/workflow/languages","stargazers_url":"https://api.github.com/repos/mboersma/workflow/stargazers","contributors_url":"https://api.github.com/repos/mboersma/workflow/contributors","subscribers_url":"https://api.github.com/repos/mboersma/workflow/subscribers","subscription_url":"https://api.github.com/repos/mboersma/workflow/subscription","commits_url":"https://api.github.com/repos/mboersma/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mboersma/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mboersma/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mboersma/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mboersma/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/mboersma/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mboersma/workflow/merges","archive_url":"https://api.github.com/repos/mboersma/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mboersma/workflow/downloads","issues_url":"https://api.github.com/repos/mboersma/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/mboersma/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/mboersma/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/mboersma/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mboersma/workflow/labels{/name}","releases_url":"https://api.github.com/repos/mboersma/workflow/releases{/id}","created_at":"2015-11-06T20:12:07Z","updated_at":"2015-11-06T20:12:10Z","pushed_at":"2016-01-14T19:31:20Z","git_url":"git://github.com/mboersma/workflow.git","ssh_url":"git@github.com:mboersma/workflow.git","clone_url":"https://github.com/mboersma/workflow.git","svn_url":"https://github.com/mboersma/workflow","homepage":null,"size":14856,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"d88e6f8df6bac82aa81e8ffbe065e7624db5121c","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":45704630,"name":"workflow","full_name":"deis/workflow","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/workflow","description":"PaaS workflow controller and client for Deis v2","fork":false,"url":"https://api.github.com/repos/deis/workflow","forks_url":"https://api.github.com/repos/deis/workflow/forks","keys_url":"https://api.github.com/repos/deis/workflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/workflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/workflow/teams","hooks_url":"https://api.github.com/repos/deis/workflow/hooks","issue_events_url":"https://api.github.com/repos/deis/workflow/issues/events{/number}","events_url":"https://api.github.com/repos/deis/workflow/events","assignees_url":"https://api.github.com/repos/deis/workflow/assignees{/user}","branches_url":"https://api.github.com/repos/deis/workflow/branches{/branch}","tags_url":"https://api.github.com/repos/deis/workflow/tags","blobs_url":"https://api.github.com/repos/deis/workflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/workflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/workflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/workflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/workflow/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/workflow/languages","stargazers_url":"https://api.github.com/repos/deis/workflow/stargazers","contributors_url":"https://api.github.com/repos/deis/workflow/contributors","subscribers_url":"https://api.github.com/repos/deis/workflow/subscribers","subscription_url":"https://api.github.com/repos/deis/workflow/subscription","commits_url":"https://api.github.com/repos/deis/workflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/workflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/workflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/workflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/workflow/contents/{+path}","compare_url":"https://api.github.com/repos/deis/workflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/workflow/merges","archive_url":"https://api.github.com/repos/deis/workflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/workflow/downloads","issues_url":"https://api.github.com/repos/deis/workflow/issues{/number}","pulls_url":"https://api.github.com/repos/deis/workflow/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/workflow/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/workflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/workflow/labels{/name}","releases_url":"https://api.github.com/repos/deis/workflow/releases{/id}","created_at":"2015-11-06T20:06:05Z","updated_at":"2016-01-11T17:23:38Z","pushed_at":"2016-01-14T19:32:13Z","git_url":"git://github.com/deis/workflow.git","ssh_url":"git@github.com:deis/workflow.git","clone_url":"https://github.com/deis/workflow.git","svn_url":"https://github.com/deis/workflow","homepage":"http://deis.io","size":14950,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":49,"forks":15,"open_issues":49,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/workflow/pulls/280"},"html":{"href":"https://github.com/deis/workflow/pull/280"},"issue":{"href":"https://api.github.com/repos/deis/workflow/issues/280"},"comments":{"href":"https://api.github.com/repos/deis/workflow/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/workflow/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/workflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/workflow/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/deis/workflow/statuses/c76257ca80fd4576a5a44b6119bb2f77ac22a4ea"}}}}