{"action":"opened","number":5897,"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5897","id":87476914,"html_url":"https://github.com/RIOT-OS/RIOT/pull/5897","diff_url":"https://github.com/RIOT-OS/RIOT/pull/5897.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/5897.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5897","number":5897,"state":"open","locked":false,"title":"ieee802154: clean-up (Intra-PAN behavior + broadcast)","user":{"login":"miri64","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"In https://github.com/RIOT-OS/RIOT/pull/5685#discussion_r81125490 we realized, that correcting our Intra-PAN behavior would also effect broadcasting behavior due to inconsistent handling of the broadcast/multicast flags from GNRC. This PR fixes that by getting rid of the IEEE802154_BCAST flag and replacing it with the IEEE802154_ADDR_BCAST constant. This way the broadcast address is handled like any other address in `ieee802154_set_frame_hdr()` since the GNRC glue code now translates the (GNRC-internal) broadcast/multicast flags into the broadcast address, and not that function.\r\n\r\nSince this cleanup is tightly bound to the PAN_COMP clean-up (and it would have been more complicated to work around this changes, since I needed to touch that lines anyway) I decided to incorporate #5685 (due to the dropping of the `bcast` variable that change looks a little different though, so its more of an alternative) and #5759 in here. Hope @aeneby and @cgundogan won't mind ;).\r\n\r\n# Summary of the changes\r\n\r\n* Removal of the device state flag `NETDEV2_IEEE802154_PAN_COMP` + change of the header setting behavior for PANs so that it is independent of external state (except the value of the given PAN IDs ;-))\r\n* Removal of the need for an IEEE802154_BCAST flag. The IEEE 802.15.4 broadcast address is now a global constant and thus can be set outside `ieee802154_set_frame_hdr()` so that it can be handled like any other destination address.","created_at":"2016-09-30T11:24:29Z","updated_at":"2016-09-30T11:24:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"PeterKietzmann","id":7765855,"avatar_url":"https://avatars.githubusercontent.com/u/7765855?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterKietzmann","html_url":"https://github.com/PeterKietzmann","followers_url":"https://api.github.com/users/PeterKietzmann/followers","following_url":"https://api.github.com/users/PeterKietzmann/following{/other_user}","gists_url":"https://api.github.com/users/PeterKietzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterKietzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterKietzmann/subscriptions","organizations_url":"https://api.github.com/users/PeterKietzmann/orgs","repos_url":"https://api.github.com/users/PeterKietzmann/repos","events_url":"https://api.github.com/users/PeterKietzmann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterKietzmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"PeterKietzmann","id":7765855,"avatar_url":"https://avatars.githubusercontent.com/u/7765855?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterKietzmann","html_url":"https://github.com/PeterKietzmann","followers_url":"https://api.github.com/users/PeterKietzmann/followers","following_url":"https://api.github.com/users/PeterKietzmann/following{/other_user}","gists_url":"https://api.github.com/users/PeterKietzmann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterKietzmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterKietzmann/subscriptions","organizations_url":"https://api.github.com/users/PeterKietzmann/orgs","repos_url":"https://api.github.com/users/PeterKietzmann/repos","events_url":"https://api.github.com/users/PeterKietzmann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterKietzmann/received_events","type":"User","site_admin":false},{"login":"smlng","id":10532675,"avatar_url":"https://avatars.githubusercontent.com/u/10532675?v=3","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5897/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5897/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5897/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/916456ecf604b641c0f5d374d152f41b77c7856d","head":{"label":"miri64:ieee802154/enh/cleanup","ref":"ieee802154/enh/cleanup","sha":"916456ecf604b641c0f5d374d152f41b77c7856d","user":{"login":"miri64","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"repo":{"id":7667624,"name":"RIOT","full_name":"miri64/RIOT","owner":{"login":"miri64","id":675644,"avatar_url":"https://avatars.githubusercontent.com/u/675644?v=3","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miri64/RIOT","description":"RIOT OS -  The revolutionary IoT OS","fork":true,"url":"https://api.github.com/repos/miri64/RIOT","forks_url":"https://api.github.com/repos/miri64/RIOT/forks","keys_url":"https://api.github.com/repos/miri64/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miri64/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miri64/RIOT/teams","hooks_url":"https://api.github.com/repos/miri64/RIOT/hooks","issue_events_url":"https://api.github.com/repos/miri64/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/miri64/RIOT/events","assignees_url":"https://api.github.com/repos/miri64/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/miri64/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/miri64/RIOT/tags","blobs_url":"https://api.github.com/repos/miri64/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miri64/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miri64/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/miri64/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miri64/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/miri64/RIOT/languages","stargazers_url":"https://api.github.com/repos/miri64/RIOT/stargazers","contributors_url":"https://api.github.com/repos/miri64/RIOT/contributors","subscribers_url":"https://api.github.com/repos/miri64/RIOT/subscribers","subscription_url":"https://api.github.com/repos/miri64/RIOT/subscription","commits_url":"https://api.github.com/repos/miri64/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/miri64/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/miri64/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/miri64/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/miri64/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/miri64/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miri64/RIOT/merges","archive_url":"https://api.github.com/repos/miri64/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miri64/RIOT/downloads","issues_url":"https://api.github.com/repos/miri64/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/miri64/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/miri64/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/miri64/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miri64/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/miri64/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/miri64/RIOT/deployments","created_at":"2013-01-17T14:31:57Z","updated_at":"2015-05-01T13:02:29Z","pushed_at":"2016-09-30T11:10:20Z","git_url":"git://github.com/miri64/RIOT.git","ssh_url":"git@github.com:miri64/RIOT.git","clone_url":"https://github.com/miri64/RIOT.git","svn_url":"https://github.com/miri64/RIOT","homepage":null,"size":30899,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"d1c3233242d1668b182646edca3553ace699a43f","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2016-09-29T23:49:01Z","pushed_at":"2016-09-30T09:36:40Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":99816,"stargazers_count":935,"watchers_count":935,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":627,"mirror_url":null,"open_issues_count":526,"forks":627,"open_issues":526,"watchers":935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5897"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/5897"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5897"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/5897/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5897/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/5897/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/916456ecf604b641c0f5d374d152f41b77c7856d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":91,"deletions":236,"changed_files":6}}
{"actor":{"display_login":"miri64"}}