{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/182","repository_url":"https://api.github.com/repos/cfpb/college-costs","labels_url":"https://api.github.com/repos/cfpb/college-costs/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/college-costs/issues/182/comments","events_url":"https://api.github.com/repos/cfpb/college-costs/issues/182/events","html_url":"https://github.com/cfpb/college-costs/pull/182","id":160192967,"number":182,"title":"Percentage, private loan fee fixes","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-06-14T14:17:20Z","updated_at":"2016-06-15T19:55:35Z","closed_at":"2016-06-15T14:01:18Z","pull_request":{"url":"https://api.github.com/repos/cfpb/college-costs/pulls/182","html_url":"https://github.com/cfpb/college-costs/pull/182","diff_url":"https://github.com/cfpb/college-costs/pull/182.diff","patch_url":"https://github.com/cfpb/college-costs/pull/182.patch"},"body":"This fixes a bug in percent fields and brings in private loan fees from the URL (or Direct Loan rate).\r\n\r\n## Additions\r\n- Added `prvf` to query handler\r\n- Added a fix for floating point imprecision showing in the percent input fields\r\n - Added `round()` function to fix this imprecision\r\n\r\n## Testing\r\n- Passes existing functional and unit tests\r\n\r\n## Review\r\n- @marteki and @higs4281 and @amymok and anyone who loves floating point errors\r\n- Pull it down, `gulp` it, and check out the `prvf` URL parameter or try to type numbers like `3.666` in percent fields and watch the lack of floating point errors!\r\n\r\n## Checklist\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [x] Visually tested in supported browsers and devices\r\n* [x] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n\r\n## Animated GIF\r\nIt seems like a __MEGASHARK__ kind of day.\r\n\r\n![megashark-bites-bridge](https://cloud.githubusercontent.com/assets/1490703/16046059/1494da12-3219-11e6-8d21-99e4065872e6.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/comments/226301295","html_url":"https://github.com/cfpb/college-costs/pull/182#issuecomment-226301295","issue_url":"https://api.github.com/repos/cfpb/college-costs/issues/182","id":226301295,"user":{"login":"saintsoup52","id":4397508,"avatar_url":"https://avatars.githubusercontent.com/u/4397508?v=3","gravatar_id":"","url":"https://api.github.com/users/saintsoup52","html_url":"https://github.com/saintsoup52","followers_url":"https://api.github.com/users/saintsoup52/followers","following_url":"https://api.github.com/users/saintsoup52/following{/other_user}","gists_url":"https://api.github.com/users/saintsoup52/gists{/gist_id}","starred_url":"https://api.github.com/users/saintsoup52/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saintsoup52/subscriptions","organizations_url":"https://api.github.com/users/saintsoup52/orgs","repos_url":"https://api.github.com/users/saintsoup52/repos","events_url":"https://api.github.com/users/saintsoup52/events{/privacy}","received_events_url":"https://api.github.com/users/saintsoup52/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T19:55:35Z","updated_at":"2016-06-15T19:55:35Z","body":"The default private student loan fee (when not populated) should be 0% based on feedback from RMR"}}
{"actor":{"display_login":"saintsoup52"}}