{"action":"created","comment":{"url":"https://api.github.com/repos/Kentoku/Spider/pulls/comments/83292091","pull_request_review_id":4146251,"id":83292091,"diff_hunk":"@@ -12871,8 +12871,17 @@ int ha_spider::check_error_mode_eof(\n void ha_spider::check_pre_call(\n   bool use_parallel\n ) {\n+  THD* thd = ha_thd();\n+  st_select_lex *select_lex = spider_get_select_lex(this);\n   DBUG_ENTER(\"ha_spider::check_pre_call\");\n   DBUG_PRINT(\"info\",(\"spider this=%p\", this));\n+  if (thd->lex && thd->lex->sql_command != SQLCOM_SELECT || // such like insert .. select ..\n+    select_lex && select_lex->sql_cache == SELECT_LEX::SQL_NO_CACHE //  for mysqldump \n+    )\n+  {","path":"ha_spider.cc","position":112,"original_position":11,"commit_id":"95e6095993385b085b744751c666f0c146325393","original_commit_id":"459fb84677b66144c974df927a34d4415af8d2bf","user":{"login":"Kentoku","id":396296,"avatar_url":"https://avatars.githubusercontent.com/u/396296?v=3","gravatar_id":"","url":"https://api.github.com/users/Kentoku","html_url":"https://github.com/Kentoku","followers_url":"https://api.github.com/users/Kentoku/followers","following_url":"https://api.github.com/users/Kentoku/following{/other_user}","gists_url":"https://api.github.com/users/Kentoku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentoku/subscriptions","organizations_url":"https://api.github.com/users/Kentoku/orgs","repos_url":"https://api.github.com/users/Kentoku/repos","events_url":"https://api.github.com/users/Kentoku/events{/privacy}","received_events_url":"https://api.github.com/users/Kentoku/received_events","type":"User","site_admin":false},"body":"I can understand your situation, but this issue is not caused by other situation. So I'll add a parameter after merging this changes for switching this operation.\r\nThis changes are ready to merge.","created_at":"2016-10-13T19:22:42Z","updated_at":"2016-10-13T19:22:42Z","html_url":"https://github.com/Kentoku/Spider/pull/18#discussion_r83292091","pull_request_url":"https://api.github.com/repos/Kentoku/Spider/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/Kentoku/Spider/pulls/comments/83292091"},"html":{"href":"https://github.com/Kentoku/Spider/pull/18#discussion_r83292091"},"pull_request":{"href":"https://api.github.com/repos/Kentoku/Spider/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/Kentoku/Spider/pulls/18","id":86087134,"html_url":"https://github.com/Kentoku/Spider/pull/18","diff_url":"https://github.com/Kentoku/Spider/pull/18.diff","patch_url":"https://github.com/Kentoku/Spider/pull/18.patch","issue_url":"https://api.github.com/repos/Kentoku/Spider/issues/18","number":18,"state":"open","locked":false,"title":"some fix first,  we would do  \"optimization for limit x, y\"  and \"connection pool\" after","user":{"login":"willhan123","id":5733949,"avatar_url":"https://avatars.githubusercontent.com/u/5733949?v=3","gravatar_id":"","url":"https://api.github.com/users/willhan123","html_url":"https://github.com/willhan123","followers_url":"https://api.github.com/users/willhan123/followers","following_url":"https://api.github.com/users/willhan123/following{/other_user}","gists_url":"https://api.github.com/users/willhan123/gists{/gist_id}","starred_url":"https://api.github.com/users/willhan123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhan123/subscriptions","organizations_url":"https://api.github.com/users/willhan123/orgs","repos_url":"https://api.github.com/users/willhan123/repos","events_url":"https://api.github.com/users/willhan123/events{/privacy}","received_events_url":"https://api.github.com/users/willhan123/received_events","type":"User","site_admin":false},"body":"1. fix cmake in windows\r\n2. pre_sacn wolud cause failing to  mysqldump,   did not pre_scan when mysqldump\r\n3. force_index push down, like select .. from t1 force index(k1) where xxx;\r\n4. fix bug, share wolud init failed， cause dead loop","created_at":"2016-09-21T02:13:23Z","updated_at":"2016-10-13T19:22:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a5622335c0742882e81c08ee1995bfc137ff044","assignee":{"login":"Kentoku","id":396296,"avatar_url":"https://avatars.githubusercontent.com/u/396296?v=3","gravatar_id":"","url":"https://api.github.com/users/Kentoku","html_url":"https://github.com/Kentoku","followers_url":"https://api.github.com/users/Kentoku/followers","following_url":"https://api.github.com/users/Kentoku/following{/other_user}","gists_url":"https://api.github.com/users/Kentoku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentoku/subscriptions","organizations_url":"https://api.github.com/users/Kentoku/orgs","repos_url":"https://api.github.com/users/Kentoku/repos","events_url":"https://api.github.com/users/Kentoku/events{/privacy}","received_events_url":"https://api.github.com/users/Kentoku/received_events","type":"User","site_admin":false},"assignees":[{"login":"Kentoku","id":396296,"avatar_url":"https://avatars.githubusercontent.com/u/396296?v=3","gravatar_id":"","url":"https://api.github.com/users/Kentoku","html_url":"https://github.com/Kentoku","followers_url":"https://api.github.com/users/Kentoku/followers","following_url":"https://api.github.com/users/Kentoku/following{/other_user}","gists_url":"https://api.github.com/users/Kentoku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentoku/subscriptions","organizations_url":"https://api.github.com/users/Kentoku/orgs","repos_url":"https://api.github.com/users/Kentoku/repos","events_url":"https://api.github.com/users/Kentoku/events{/privacy}","received_events_url":"https://api.github.com/users/Kentoku/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Kentoku/Spider/pulls/18/commits","review_comments_url":"https://api.github.com/repos/Kentoku/Spider/pulls/18/comments","review_comment_url":"https://api.github.com/repos/Kentoku/Spider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kentoku/Spider/issues/18/comments","statuses_url":"https://api.github.com/repos/Kentoku/Spider/statuses/95e6095993385b085b744751c666f0c146325393","head":{"label":"willhan123:master","ref":"master","sha":"95e6095993385b085b744751c666f0c146325393","user":{"login":"willhan123","id":5733949,"avatar_url":"https://avatars.githubusercontent.com/u/5733949?v=3","gravatar_id":"","url":"https://api.github.com/users/willhan123","html_url":"https://github.com/willhan123","followers_url":"https://api.github.com/users/willhan123/followers","following_url":"https://api.github.com/users/willhan123/following{/other_user}","gists_url":"https://api.github.com/users/willhan123/gists{/gist_id}","starred_url":"https://api.github.com/users/willhan123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhan123/subscriptions","organizations_url":"https://api.github.com/users/willhan123/orgs","repos_url":"https://api.github.com/users/willhan123/repos","events_url":"https://api.github.com/users/willhan123/events{/privacy}","received_events_url":"https://api.github.com/users/willhan123/received_events","type":"User","site_admin":false},"repo":{"id":67180495,"name":"Spider","full_name":"willhan123/Spider","owner":{"login":"willhan123","id":5733949,"avatar_url":"https://avatars.githubusercontent.com/u/5733949?v=3","gravatar_id":"","url":"https://api.github.com/users/willhan123","html_url":"https://github.com/willhan123","followers_url":"https://api.github.com/users/willhan123/followers","following_url":"https://api.github.com/users/willhan123/following{/other_user}","gists_url":"https://api.github.com/users/willhan123/gists{/gist_id}","starred_url":"https://api.github.com/users/willhan123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhan123/subscriptions","organizations_url":"https://api.github.com/users/willhan123/orgs","repos_url":"https://api.github.com/users/willhan123/repos","events_url":"https://api.github.com/users/willhan123/events{/privacy}","received_events_url":"https://api.github.com/users/willhan123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willhan123/Spider","description":null,"fork":true,"url":"https://api.github.com/repos/willhan123/Spider","forks_url":"https://api.github.com/repos/willhan123/Spider/forks","keys_url":"https://api.github.com/repos/willhan123/Spider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willhan123/Spider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willhan123/Spider/teams","hooks_url":"https://api.github.com/repos/willhan123/Spider/hooks","issue_events_url":"https://api.github.com/repos/willhan123/Spider/issues/events{/number}","events_url":"https://api.github.com/repos/willhan123/Spider/events","assignees_url":"https://api.github.com/repos/willhan123/Spider/assignees{/user}","branches_url":"https://api.github.com/repos/willhan123/Spider/branches{/branch}","tags_url":"https://api.github.com/repos/willhan123/Spider/tags","blobs_url":"https://api.github.com/repos/willhan123/Spider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willhan123/Spider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willhan123/Spider/git/refs{/sha}","trees_url":"https://api.github.com/repos/willhan123/Spider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willhan123/Spider/statuses/{sha}","languages_url":"https://api.github.com/repos/willhan123/Spider/languages","stargazers_url":"https://api.github.com/repos/willhan123/Spider/stargazers","contributors_url":"https://api.github.com/repos/willhan123/Spider/contributors","subscribers_url":"https://api.github.com/repos/willhan123/Spider/subscribers","subscription_url":"https://api.github.com/repos/willhan123/Spider/subscription","commits_url":"https://api.github.com/repos/willhan123/Spider/commits{/sha}","git_commits_url":"https://api.github.com/repos/willhan123/Spider/git/commits{/sha}","comments_url":"https://api.github.com/repos/willhan123/Spider/comments{/number}","issue_comment_url":"https://api.github.com/repos/willhan123/Spider/issues/comments{/number}","contents_url":"https://api.github.com/repos/willhan123/Spider/contents/{+path}","compare_url":"https://api.github.com/repos/willhan123/Spider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willhan123/Spider/merges","archive_url":"https://api.github.com/repos/willhan123/Spider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willhan123/Spider/downloads","issues_url":"https://api.github.com/repos/willhan123/Spider/issues{/number}","pulls_url":"https://api.github.com/repos/willhan123/Spider/pulls{/number}","milestones_url":"https://api.github.com/repos/willhan123/Spider/milestones{/number}","notifications_url":"https://api.github.com/repos/willhan123/Spider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willhan123/Spider/labels{/name}","releases_url":"https://api.github.com/repos/willhan123/Spider/releases{/id}","deployments_url":"https://api.github.com/repos/willhan123/Spider/deployments","created_at":"2016-09-02T01:46:58Z","updated_at":"2016-09-02T01:47:09Z","pushed_at":"2016-10-10T01:56:36Z","git_url":"git://github.com/willhan123/Spider.git","ssh_url":"git@github.com:willhan123/Spider.git","clone_url":"https://github.com/willhan123/Spider.git","svn_url":"https://github.com/willhan123/Spider","homepage":null,"size":690,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Kentoku:master","ref":"master","sha":"4bbc5b6fdbfc0c6727994bdc760368b78b12fc57","user":{"login":"Kentoku","id":396296,"avatar_url":"https://avatars.githubusercontent.com/u/396296?v=3","gravatar_id":"","url":"https://api.github.com/users/Kentoku","html_url":"https://github.com/Kentoku","followers_url":"https://api.github.com/users/Kentoku/followers","following_url":"https://api.github.com/users/Kentoku/following{/other_user}","gists_url":"https://api.github.com/users/Kentoku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentoku/subscriptions","organizations_url":"https://api.github.com/users/Kentoku/orgs","repos_url":"https://api.github.com/users/Kentoku/repos","events_url":"https://api.github.com/users/Kentoku/events{/privacy}","received_events_url":"https://api.github.com/users/Kentoku/received_events","type":"User","site_admin":false},"repo":{"id":48190676,"name":"Spider","full_name":"Kentoku/Spider","owner":{"login":"Kentoku","id":396296,"avatar_url":"https://avatars.githubusercontent.com/u/396296?v=3","gravatar_id":"","url":"https://api.github.com/users/Kentoku","html_url":"https://github.com/Kentoku","followers_url":"https://api.github.com/users/Kentoku/followers","following_url":"https://api.github.com/users/Kentoku/following{/other_user}","gists_url":"https://api.github.com/users/Kentoku/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentoku/subscriptions","organizations_url":"https://api.github.com/users/Kentoku/orgs","repos_url":"https://api.github.com/users/Kentoku/repos","events_url":"https://api.github.com/users/Kentoku/events{/privacy}","received_events_url":"https://api.github.com/users/Kentoku/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kentoku/Spider","description":null,"fork":false,"url":"https://api.github.com/repos/Kentoku/Spider","forks_url":"https://api.github.com/repos/Kentoku/Spider/forks","keys_url":"https://api.github.com/repos/Kentoku/Spider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kentoku/Spider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kentoku/Spider/teams","hooks_url":"https://api.github.com/repos/Kentoku/Spider/hooks","issue_events_url":"https://api.github.com/repos/Kentoku/Spider/issues/events{/number}","events_url":"https://api.github.com/repos/Kentoku/Spider/events","assignees_url":"https://api.github.com/repos/Kentoku/Spider/assignees{/user}","branches_url":"https://api.github.com/repos/Kentoku/Spider/branches{/branch}","tags_url":"https://api.github.com/repos/Kentoku/Spider/tags","blobs_url":"https://api.github.com/repos/Kentoku/Spider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kentoku/Spider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kentoku/Spider/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kentoku/Spider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kentoku/Spider/statuses/{sha}","languages_url":"https://api.github.com/repos/Kentoku/Spider/languages","stargazers_url":"https://api.github.com/repos/Kentoku/Spider/stargazers","contributors_url":"https://api.github.com/repos/Kentoku/Spider/contributors","subscribers_url":"https://api.github.com/repos/Kentoku/Spider/subscribers","subscription_url":"https://api.github.com/repos/Kentoku/Spider/subscription","commits_url":"https://api.github.com/repos/Kentoku/Spider/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kentoku/Spider/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kentoku/Spider/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kentoku/Spider/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kentoku/Spider/contents/{+path}","compare_url":"https://api.github.com/repos/Kentoku/Spider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kentoku/Spider/merges","archive_url":"https://api.github.com/repos/Kentoku/Spider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kentoku/Spider/downloads","issues_url":"https://api.github.com/repos/Kentoku/Spider/issues{/number}","pulls_url":"https://api.github.com/repos/Kentoku/Spider/pulls{/number}","milestones_url":"https://api.github.com/repos/Kentoku/Spider/milestones{/number}","notifications_url":"https://api.github.com/repos/Kentoku/Spider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kentoku/Spider/labels{/name}","releases_url":"https://api.github.com/repos/Kentoku/Spider/releases{/id}","deployments_url":"https://api.github.com/repos/Kentoku/Spider/deployments","created_at":"2015-12-17T18:20:06Z","updated_at":"2016-05-04T14:01:54Z","pushed_at":"2016-10-10T01:56:36Z","git_url":"git://github.com/Kentoku/Spider.git","ssh_url":"git@github.com:Kentoku/Spider.git","clone_url":"https://github.com/Kentoku/Spider.git","svn_url":"https://github.com/Kentoku/Spider","homepage":null,"size":611,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kentoku/Spider/pulls/18"},"html":{"href":"https://github.com/Kentoku/Spider/pull/18"},"issue":{"href":"https://api.github.com/repos/Kentoku/Spider/issues/18"},"comments":{"href":"https://api.github.com/repos/Kentoku/Spider/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/Kentoku/Spider/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/Kentoku/Spider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kentoku/Spider/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/Kentoku/Spider/statuses/95e6095993385b085b744751c666f0c146325393"}}}}
{"actor":{"display_login":"Kentoku"}}