{"action":"created","issue":{"url":"https://api.github.com/repos/johndyer/mediaelement/issues/1829","repository_url":"https://api.github.com/repos/johndyer/mediaelement","labels_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1829/labels{/name}","comments_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1829/comments","events_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1829/events","html_url":"https://github.com/johndyer/mediaelement/pull/1829","id":174164179,"number":1829,"title":"Set source properly on YouTube","user":{"login":"ron666","id":910829,"avatar_url":"https://avatars.githubusercontent.com/u/910829?v=3","gravatar_id":"","url":"https://api.github.com/users/ron666","html_url":"https://github.com/ron666","followers_url":"https://api.github.com/users/ron666/followers","following_url":"https://api.github.com/users/ron666/following{/other_user}","gists_url":"https://api.github.com/users/ron666/gists{/gist_id}","starred_url":"https://api.github.com/users/ron666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron666/subscriptions","organizations_url":"https://api.github.com/users/ron666/orgs","repos_url":"https://api.github.com/users/ron666/repos","events_url":"https://api.github.com/users/ron666/events{/privacy}","received_events_url":"https://api.github.com/users/ron666/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-31T01:31:46Z","updated_at":"2016-12-22T16:53:48Z","closed_at":"2016-09-01T10:54:07Z","pull_request":{"url":"https://api.github.com/repos/johndyer/mediaelement/pulls/1829","html_url":"https://github.com/johndyer/mediaelement/pull/1829","diff_url":"https://github.com/johndyer/mediaelement/pull/1829.diff","patch_url":"https://github.com/johndyer/mediaelement/pull/1829.patch"},"body":"This PR adds a new workflow to set a source properly on YouTube based on comments from #1759. Also solves issues #1410, #1435 and #1704\n"},"comment":{"url":"https://api.github.com/repos/johndyer/mediaelement/issues/comments/268841497","html_url":"https://github.com/johndyer/mediaelement/pull/1829#issuecomment-268841497","issue_url":"https://api.github.com/repos/johndyer/mediaelement/issues/1829","id":268841497,"user":{"login":"johndyer","id":214227,"avatar_url":"https://avatars.githubusercontent.com/u/214227?v=3","gravatar_id":"","url":"https://api.github.com/users/johndyer","html_url":"https://github.com/johndyer","followers_url":"https://api.github.com/users/johndyer/followers","following_url":"https://api.github.com/users/johndyer/following{/other_user}","gists_url":"https://api.github.com/users/johndyer/gists{/gist_id}","starred_url":"https://api.github.com/users/johndyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johndyer/subscriptions","organizations_url":"https://api.github.com/users/johndyer/orgs","repos_url":"https://api.github.com/users/johndyer/repos","events_url":"https://api.github.com/users/johndyer/events{/privacy}","received_events_url":"https://api.github.com/users/johndyer/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T16:53:48Z","updated_at":"2016-12-22T16:53:48Z","body":"FYI - waiting until the success callback will not be necessary in the 3.x\nversion...\n\nOn Thu, Dec 22, 2016 at 9:47 AM, dwatts3624 <notifications@github.com>\nwrote:\n\n> Okay. So right after posting I get it to work! Go figure!\n>\n> For brevity I shortened the code:\n>\n> var player = new MediaElementPlayer(domId, {\n>   success: mediaElementSuccess\n> });function mediaElementSuccess(mediaElement, domObject) {\n>   player.setSrc(ytVideoUrl);\n> }\n>\n> Is this the intended behavior? It works fine but the documentation seems\n> to suggest that my first approach should work.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/johndyer/mediaelement/pull/1829#issuecomment-268826957>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AANE07y-Y-0yeQ3_uH2lRmu2Lb0OT2JAks5rKpuTgaJpZM4JxJMO>\n> .\n>\n\n\n\n-- \nJohn Dyer - http://j.hn/\n"}}
{"actor":{"display_login":"johndyer"}}