{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/29","id":95577311,"html_url":"https://github.com/SmarterApp/TDS_ExamService/pull/29","diff_url":"https://github.com/SmarterApp/TDS_ExamService/pull/29.diff","patch_url":"https://github.com/SmarterApp/TDS_ExamService/pull/29.patch","issue_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/29","number":29,"state":"closed","locked":false,"title":"[Initialize Segments] ComputeSegmentPool + ItemPool Services","user":{"login":"burzum619","id":1046191,"avatar_url":"https://avatars.githubusercontent.com/u/1046191?v=3","gravatar_id":"","url":"https://api.github.com/users/burzum619","html_url":"https://github.com/burzum619","followers_url":"https://api.github.com/users/burzum619/followers","following_url":"https://api.github.com/users/burzum619/following{/other_user}","gists_url":"https://api.github.com/users/burzum619/gists{/gist_id}","starred_url":"https://api.github.com/users/burzum619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burzum619/subscriptions","organizations_url":"https://api.github.com/users/burzum619/orgs","repos_url":"https://api.github.com/users/burzum619/repos","events_url":"https://api.github.com/users/burzum619/events{/privacy}","received_events_url":"https://api.github.com/users/burzum619/received_events","type":"User","site_admin":false},"body":"This pull request covers code related to the \"ComputeSegmentPool\" portion of startExam/initializeExamSegments. The general purpose of this code is to select which items will be available for use in the exam (based on exam accommodations and configuration-based constraints on segments), as well as the calculation of the segment length (the number of items that need to be selected for the segment from the pool). This portion of the code deals exclusively with adaptive algorithm based segments/assessments.\r\n\r\n- ItemPoolService.getItemPool() is the equivalent of the code located in StudentDLL._AA_ItempoolString_FN() [line 2552]\r\n- SegmentPoolService.computeSegmentPool() represents the logic in StudentDll._ComputeSegmentPool_SP() [line 2842]\r\n\r\n- In getItemPool(), the enormous multi-join query has been replaced by in-memory lambda expressions used for filtering eligible items. All relevant data (item constraints, properties, item metadata, etc) aside from the ExamAccommodations are now included as part of the Assessment object.\r\n- computeSegmentPool() does not include \"sessionKey\" as a parameter, and ignores a portion of code that is only access when sessionKey is not null. This is because the sessionKey is only used in the segment calculation when in simulation mode. \r\n- This PR does **not** include code related to simulation mode. The simulation implementation will be completed at a later date.","created_at":"2016-11-28T21:11:49Z","updated_at":"2016-11-29T22:37:16Z","closed_at":"2016-11-29T22:37:15Z","merged_at":"2016-11-29T22:37:15Z","merge_commit_sha":"52582c004e7936bbf246241e0f97ac72d48d7d54","assignee":{"login":"jtreuting","id":341584,"avatar_url":"https://avatars.githubusercontent.com/u/341584?v=3","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},"assignees":[{"login":"jtreuting","id":341584,"avatar_url":"https://avatars.githubusercontent.com/u/341584?v=3","gravatar_id":"","url":"https://api.github.com/users/jtreuting","html_url":"https://github.com/jtreuting","followers_url":"https://api.github.com/users/jtreuting/followers","following_url":"https://api.github.com/users/jtreuting/following{/other_user}","gists_url":"https://api.github.com/users/jtreuting/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreuting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreuting/subscriptions","organizations_url":"https://api.github.com/users/jtreuting/orgs","repos_url":"https://api.github.com/users/jtreuting/repos","events_url":"https://api.github.com/users/jtreuting/events{/privacy}","received_events_url":"https://api.github.com/users/jtreuting/received_events","type":"User","site_admin":false},{"login":"millerts","id":726145,"avatar_url":"https://avatars.githubusercontent.com/u/726145?v=3","gravatar_id":"","url":"https://api.github.com/users/millerts","html_url":"https://github.com/millerts","followers_url":"https://api.github.com/users/millerts/followers","following_url":"https://api.github.com/users/millerts/following{/other_user}","gists_url":"https://api.github.com/users/millerts/gists{/gist_id}","starred_url":"https://api.github.com/users/millerts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerts/subscriptions","organizations_url":"https://api.github.com/users/millerts/orgs","repos_url":"https://api.github.com/users/millerts/repos","events_url":"https://api.github.com/users/millerts/events{/privacy}","received_events_url":"https://api.github.com/users/millerts/received_events","type":"User","site_admin":false},{"login":"jeffjohnson9046","id":1435800,"avatar_url":"https://avatars.githubusercontent.com/u/1435800?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffjohnson9046","html_url":"https://github.com/jeffjohnson9046","followers_url":"https://api.github.com/users/jeffjohnson9046/followers","following_url":"https://api.github.com/users/jeffjohnson9046/following{/other_user}","gists_url":"https://api.github.com/users/jeffjohnson9046/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffjohnson9046/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffjohnson9046/subscriptions","organizations_url":"https://api.github.com/users/jeffjohnson9046/orgs","repos_url":"https://api.github.com/users/jeffjohnson9046/repos","events_url":"https://api.github.com/users/jeffjohnson9046/events{/privacy}","received_events_url":"https://api.github.com/users/jeffjohnson9046/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/29/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/29/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/29/comments","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/statuses/8281355bf8ff241bae8b44a3b8d5b73742195875","head":{"label":"SmarterApp:feature/initialize-segments","ref":"feature/initialize-segments","sha":"8281355bf8ff241bae8b44a3b8d5b73742195875","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":66864369,"name":"TDS_ExamService","full_name":"SmarterApp/TDS_ExamService","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/TDS_ExamService","description":null,"fork":false,"url":"https://api.github.com/repos/SmarterApp/TDS_ExamService","forks_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/forks","keys_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/teams","hooks_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/events","assignees_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/tags","blobs_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/subscription","commits_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/merges","archive_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/downloads","issues_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/deployments","created_at":"2016-08-29T17:20:35Z","updated_at":"2016-11-29T18:52:03Z","pushed_at":"2016-11-29T22:37:15Z","git_url":"git://github.com/SmarterApp/TDS_ExamService.git","ssh_url":"git@github.com:SmarterApp/TDS_ExamService.git","clone_url":"https://github.com/SmarterApp/TDS_ExamService.git","svn_url":"https://github.com/SmarterApp/TDS_ExamService","homepage":null,"size":541,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"2ddc80806647e6726e7eeaff277c8d4178fc1bf1","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":66864369,"name":"TDS_ExamService","full_name":"SmarterApp/TDS_ExamService","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars.githubusercontent.com/u/7026395?v=3","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/TDS_ExamService","description":null,"fork":false,"url":"https://api.github.com/repos/SmarterApp/TDS_ExamService","forks_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/forks","keys_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/teams","hooks_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/events","assignees_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/tags","blobs_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/subscription","commits_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/merges","archive_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/downloads","issues_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/TDS_ExamService/deployments","created_at":"2016-08-29T17:20:35Z","updated_at":"2016-11-29T18:52:03Z","pushed_at":"2016-11-29T22:37:15Z","git_url":"git://github.com/SmarterApp/TDS_ExamService.git","ssh_url":"git@github.com:SmarterApp/TDS_ExamService.git","clone_url":"https://github.com/SmarterApp/TDS_ExamService.git","svn_url":"https://github.com/SmarterApp/TDS_ExamService","homepage":null,"size":541,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/29"},"html":{"href":"https://github.com/SmarterApp/TDS_ExamService/pull/29"},"issue":{"href":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/29"},"comments":{"href":"https://api.github.com/repos/SmarterApp/TDS_ExamService/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/TDS_ExamService/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/TDS_ExamService/statuses/8281355bf8ff241bae8b44a3b8d5b73742195875"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"burzum619","id":1046191,"avatar_url":"https://avatars.githubusercontent.com/u/1046191?v=3","gravatar_id":"","url":"https://api.github.com/users/burzum619","html_url":"https://github.com/burzum619","followers_url":"https://api.github.com/users/burzum619/followers","following_url":"https://api.github.com/users/burzum619/following{/other_user}","gists_url":"https://api.github.com/users/burzum619/gists{/gist_id}","starred_url":"https://api.github.com/users/burzum619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burzum619/subscriptions","organizations_url":"https://api.github.com/users/burzum619/orgs","repos_url":"https://api.github.com/users/burzum619/repos","events_url":"https://api.github.com/users/burzum619/events{/privacy}","received_events_url":"https://api.github.com/users/burzum619/received_events","type":"User","site_admin":false},"comments":0,"review_comments":11,"commits":20,"additions":1009,"deletions":1,"changed_files":10}}
{"actor":{"display_login":"burzum619"}}