{"action":"created","issue":{"url":"https://api.github.com/repos/hiawc/Flicks/issues/1","repository_url":"https://api.github.com/repos/hiawc/Flicks","labels_url":"https://api.github.com/repos/hiawc/Flicks/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/hiawc/Flicks/issues/1/comments","events_url":"https://api.github.com/repos/hiawc/Flicks/issues/1/events","html_url":"https://github.com/hiawc/Flicks/issues/1","id":140469048,"number":1,"title":"[Intro to iOS] Week 1","user":{"login":"hiawc","id":15264166,"avatar_url":"https://avatars.githubusercontent.com/u/15264166?v=3","gravatar_id":"","url":"https://api.github.com/users/hiawc","html_url":"https://github.com/hiawc","followers_url":"https://api.github.com/users/hiawc/followers","following_url":"https://api.github.com/users/hiawc/following{/other_user}","gists_url":"https://api.github.com/users/hiawc/gists{/gist_id}","starred_url":"https://api.github.com/users/hiawc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiawc/subscriptions","organizations_url":"https://api.github.com/users/hiawc/orgs","repos_url":"https://api.github.com/users/hiawc/repos","events_url":"https://api.github.com/users/hiawc/events{/privacy}","received_events_url":"https://api.github.com/users/hiawc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-13T09:41:44Z","updated_at":"2016-03-15T18:05:54Z","closed_at":null,"body":"Here is my week 1 submission. Thank you very much.\r\n/cc @coderschoolreview"},"comment":{"url":"https://api.github.com/repos/hiawc/Flicks/issues/comments/196952559","html_url":"https://github.com/hiawc/Flicks/issues/1#issuecomment-196952559","issue_url":"https://api.github.com/repos/hiawc/Flicks/issues/1","id":196952559,"user":{"login":"coderschoolreview","id":15702670,"avatar_url":"https://avatars.githubusercontent.com/u/15702670?v=3","gravatar_id":"","url":"https://api.github.com/users/coderschoolreview","html_url":"https://github.com/coderschoolreview","followers_url":"https://api.github.com/users/coderschoolreview/followers","following_url":"https://api.github.com/users/coderschoolreview/following{/other_user}","gists_url":"https://api.github.com/users/coderschoolreview/gists{/gist_id}","starred_url":"https://api.github.com/users/coderschoolreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderschoolreview/subscriptions","organizations_url":"https://api.github.com/users/coderschoolreview/orgs","repos_url":"https://api.github.com/users/coderschoolreview/repos","events_url":"https://api.github.com/users/coderschoolreview/events{/privacy}","received_events_url":"https://api.github.com/users/coderschoolreview/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T18:05:54Z","updated_at":"2016-03-15T18:05:54Z","body":":+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.\r\n\r\n## Grading Summary:\r\n* **Functionality**: Good\r\n* **Code Style**: Excellent\r\n* **Visual Design**: Good\r\n* **Usability**: Good\r\n* **Overall**: Good\r\n\r\n## Detailed Notes\r\n\r\n* Great clean code. Good job utilzing the best parts from the style guide:\r\n   - [Ray Wenderlich Swift Style Guide](https://github.com/raywenderlich/swift-style-guide)\r\n* In future homework, we will cover how to implement models that can deserialize from an NSDictionary. [SwiftyJSON](https://github.com/SwiftyJSON/SwiftyJSON) is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like [Pistachio](https://github.com/felixjendrusch/Pistachio).  \r\n* Nice work with the custom Movie cell and encapsulating it so that it can configure itself based on the `movie` instance.\r\n* Nice work loading the images asynchronously.\r\n* Why do you always return 20 for collectionView?\r\n* Note that your images are stretched in the collectionView. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.\r\n* Nice work implementing the error message on network failure.\r\n* Nice job implementing a UIScrollView. UIScrollView is the parent class of UITableView.\r\n* Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read [Design tips for iOS9](https://designcode.io/iosdesign-guidelines). \r\n* Your search function doesn't work?\r\n\r\nGreat job dedicating enough time to do the homework. You learned a lot! Keep up the good work.\r\n"}}