{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/82507502","pull_request_review_id":3412681,"id":82507502,"diff_hunk":"@@ -0,0 +1,25 @@\n+class Pacparser < Formula\n+  desc \"Library to parse proxy auto-config (PAC) files\"\n+  homepage \"https://github.com/pacparser/pacparser\"\n+  url \"https://github.com/pacparser/pacparser/archive/1.3.6.tar.gz\"\n+  sha256 \"c1f6f2ccd4fec329175f882102e47c57328e8e6e16aa9dbd4f8b859f9a028e83\"\n+  head \"https://github.com/pacparser/pacparser.git\"\n+\n+  depends_on \"python\" => :optional\n+\n+  def install\n+    system \"make\", \"-j1\", \"-C\", \"src\", \"install\",\n+           \"PREFIX=#{prefix}\", \"VERSION=#{version}\"\n+\n+    if build.with? \"python\"\n+      system \"make\", \"-j1\", \"-C\", \"src\", \"install-pymod\",\n+             \"EXTRA_ARGS=\\\"--prefix=#{prefix}\\\"\",\n+             \"VERSION=#{version}\"\n+    end\n+  end\n+\n+  test do\n+    ## functional tests are run as part of the make\n+    assert_equal version.to_s, shell_output(\"#{bin}/pactester -v\").strip","path":"Formula/pacparser.rb","position":26,"original_position":23,"commit_id":"7ed508cdf5222a770f597e8d1ad39aceb572cb3a","original_commit_id":"46eb6009363e9671dc5fd04f1f2fba4c44be475b","user":{"login":"leprechau","id":1444686,"avatar_url":"https://avatars.githubusercontent.com/u/1444686?v=3","gravatar_id":"","url":"https://api.github.com/users/leprechau","html_url":"https://github.com/leprechau","followers_url":"https://api.github.com/users/leprechau/followers","following_url":"https://api.github.com/users/leprechau/following{/other_user}","gists_url":"https://api.github.com/users/leprechau/gists{/gist_id}","starred_url":"https://api.github.com/users/leprechau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leprechau/subscriptions","organizations_url":"https://api.github.com/users/leprechau/orgs","repos_url":"https://api.github.com/users/leprechau/repos","events_url":"https://api.github.com/users/leprechau/events{/privacy}","received_events_url":"https://api.github.com/users/leprechau/received_events","type":"User","site_admin":false},"body":"The upstream package has test cases that are run at the end of the make.  Those tests are -pure functional tests and do run through example PAC files.  If/when those tests fail the entire build will fail.","created_at":"2016-10-08T18:34:52Z","updated_at":"2016-10-08T18:34:52Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/5661#discussion_r82507502","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/82507502"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5661#discussion_r82507502"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661","id":88480437,"html_url":"https://github.com/Homebrew/homebrew-core/pull/5661","diff_url":"https://github.com/Homebrew/homebrew-core/pull/5661.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/5661.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5661","number":5661,"state":"open","locked":false,"title":"pacparser 1.3.6 (new formula)","user":{"login":"leprechau","id":1444686,"avatar_url":"https://avatars.githubusercontent.com/u/1444686?v=3","gravatar_id":"","url":"https://api.github.com/users/leprechau","html_url":"https://github.com/leprechau","followers_url":"https://api.github.com/users/leprechau/followers","following_url":"https://api.github.com/users/leprechau/following{/other_user}","gists_url":"https://api.github.com/users/leprechau/gists{/gist_id}","starred_url":"https://api.github.com/users/leprechau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leprechau/subscriptions","organizations_url":"https://api.github.com/users/leprechau/orgs","repos_url":"https://api.github.com/users/leprechau/repos","events_url":"https://api.github.com/users/leprechau/events{/privacy}","received_events_url":"https://api.github.com/users/leprechau/received_events","type":"User","site_admin":false},"body":"Adding pacparser (github.com/pacparser/pacparser).  A library to parse proxy auto-config (PAC) files.","created_at":"2016-10-07T17:51:47Z","updated_at":"2016-10-08T18:34:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaaf18232915009f9f92660bdaffd989b3a8eade","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5661/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/7ed508cdf5222a770f597e8d1ad39aceb572cb3a","head":{"label":"leprechau:new/pacparser","ref":"new/pacparser","sha":"7ed508cdf5222a770f597e8d1ad39aceb572cb3a","user":{"login":"leprechau","id":1444686,"avatar_url":"https://avatars.githubusercontent.com/u/1444686?v=3","gravatar_id":"","url":"https://api.github.com/users/leprechau","html_url":"https://github.com/leprechau","followers_url":"https://api.github.com/users/leprechau/followers","following_url":"https://api.github.com/users/leprechau/following{/other_user}","gists_url":"https://api.github.com/users/leprechau/gists{/gist_id}","starred_url":"https://api.github.com/users/leprechau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leprechau/subscriptions","organizations_url":"https://api.github.com/users/leprechau/orgs","repos_url":"https://api.github.com/users/leprechau/repos","events_url":"https://api.github.com/users/leprechau/events{/privacy}","received_events_url":"https://api.github.com/users/leprechau/received_events","type":"User","site_admin":false},"repo":{"id":62455012,"name":"homebrew-core","full_name":"leprechau/homebrew-core","owner":{"login":"leprechau","id":1444686,"avatar_url":"https://avatars.githubusercontent.com/u/1444686?v=3","gravatar_id":"","url":"https://api.github.com/users/leprechau","html_url":"https://github.com/leprechau","followers_url":"https://api.github.com/users/leprechau/followers","following_url":"https://api.github.com/users/leprechau/following{/other_user}","gists_url":"https://api.github.com/users/leprechau/gists{/gist_id}","starred_url":"https://api.github.com/users/leprechau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leprechau/subscriptions","organizations_url":"https://api.github.com/users/leprechau/orgs","repos_url":"https://api.github.com/users/leprechau/repos","events_url":"https://api.github.com/users/leprechau/events{/privacy}","received_events_url":"https://api.github.com/users/leprechau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leprechau/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/leprechau/homebrew-core","forks_url":"https://api.github.com/repos/leprechau/homebrew-core/forks","keys_url":"https://api.github.com/repos/leprechau/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leprechau/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leprechau/homebrew-core/teams","hooks_url":"https://api.github.com/repos/leprechau/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/leprechau/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/leprechau/homebrew-core/events","assignees_url":"https://api.github.com/repos/leprechau/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/leprechau/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/leprechau/homebrew-core/tags","blobs_url":"https://api.github.com/repos/leprechau/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leprechau/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leprechau/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/leprechau/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leprechau/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/leprechau/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/leprechau/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/leprechau/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/leprechau/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/leprechau/homebrew-core/subscription","commits_url":"https://api.github.com/repos/leprechau/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/leprechau/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/leprechau/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/leprechau/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/leprechau/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/leprechau/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leprechau/homebrew-core/merges","archive_url":"https://api.github.com/repos/leprechau/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leprechau/homebrew-core/downloads","issues_url":"https://api.github.com/repos/leprechau/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/leprechau/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/leprechau/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/leprechau/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leprechau/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/leprechau/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/leprechau/homebrew-core/deployments","created_at":"2016-07-02T14:37:45Z","updated_at":"2016-07-02T14:37:59Z","pushed_at":"2016-10-08T16:09:47Z","git_url":"git://github.com/leprechau/homebrew-core.git","ssh_url":"git@github.com:leprechau/homebrew-core.git","clone_url":"https://github.com/leprechau/homebrew-core.git","svn_url":"https://github.com/leprechau/homebrew-core","homepage":"http://brew.sh","size":82894,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"bc4820f5d1a9c069c12d6809f4f75084371dddb7","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars.githubusercontent.com/u/1503512?v=3","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2016-10-08T17:29:12Z","pushed_at":"2016-10-08T17:32:05Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"http://brew.sh","size":143367,"stargazers_count":869,"watchers_count":869,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1484,"mirror_url":null,"open_issues_count":166,"forks":1484,"open_issues":166,"watchers":869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/5661"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5661"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/5661/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/5661/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/7ed508cdf5222a770f597e8d1ad39aceb572cb3a"}}}}
{"actor":{"display_login":"leprechau"}}