{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/842","repository_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers","labels_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/842/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/842/comments","events_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/842/events","html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/842","id":170504072,"number":842,"title":"Remove Windows SDK powershell script and replace it with a C program","user":{"login":"lenny-lunarg","id":19669994,"avatar_url":"https://avatars.githubusercontent.com/u/19669994?v=3","gravatar_id":"","url":"https://api.github.com/users/lenny-lunarg","html_url":"https://github.com/lenny-lunarg","followers_url":"https://api.github.com/users/lenny-lunarg/followers","following_url":"https://api.github.com/users/lenny-lunarg/following{/other_user}","gists_url":"https://api.github.com/users/lenny-lunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/lenny-lunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenny-lunarg/subscriptions","organizations_url":"https://api.github.com/users/lenny-lunarg/orgs","repos_url":"https://api.github.com/users/lenny-lunarg/repos","events_url":"https://api.github.com/users/lenny-lunarg/events{/privacy}","received_events_url":"https://api.github.com/users/lenny-lunarg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"davidlunarg","id":10409469,"avatar_url":"https://avatars.githubusercontent.com/u/10409469?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlunarg","html_url":"https://github.com/davidlunarg","followers_url":"https://api.github.com/users/davidlunarg/followers","following_url":"https://api.github.com/users/davidlunarg/following{/other_user}","gists_url":"https://api.github.com/users/davidlunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlunarg/subscriptions","organizations_url":"https://api.github.com/users/davidlunarg/orgs","repos_url":"https://api.github.com/users/davidlunarg/repos","events_url":"https://api.github.com/users/davidlunarg/events{/privacy}","received_events_url":"https://api.github.com/users/davidlunarg/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidlunarg","id":10409469,"avatar_url":"https://avatars.githubusercontent.com/u/10409469?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlunarg","html_url":"https://github.com/davidlunarg","followers_url":"https://api.github.com/users/davidlunarg/followers","following_url":"https://api.github.com/users/davidlunarg/following{/other_user}","gists_url":"https://api.github.com/users/davidlunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlunarg/subscriptions","organizations_url":"https://api.github.com/users/davidlunarg/orgs","repos_url":"https://api.github.com/users/davidlunarg/repos","events_url":"https://api.github.com/users/davidlunarg/events{/privacy}","received_events_url":"https://api.github.com/users/davidlunarg/received_events","type":"User","site_admin":false},{"login":"MarkY-LunarG","id":16328578,"avatar_url":"https://avatars.githubusercontent.com/u/16328578?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkY-LunarG","html_url":"https://github.com/MarkY-LunarG","followers_url":"https://api.github.com/users/MarkY-LunarG/followers","following_url":"https://api.github.com/users/MarkY-LunarG/following{/other_user}","gists_url":"https://api.github.com/users/MarkY-LunarG/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkY-LunarG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkY-LunarG/subscriptions","organizations_url":"https://api.github.com/users/MarkY-LunarG/orgs","repos_url":"https://api.github.com/users/MarkY-LunarG/repos","events_url":"https://api.github.com/users/MarkY-LunarG/events{/privacy}","received_events_url":"https://api.github.com/users/MarkY-LunarG/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-10T19:55:20Z","updated_at":"2016-08-11T20:27:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/pulls/842","html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/842","diff_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/842.diff","patch_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/842.patch"},"body":"This pull request removes the ConfigLayersAndVulkanDLL.ps1 script, and replaces it with a new configure_runtime.c program."},"comment":{"url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/comments/239281757","html_url":"https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/842#issuecomment-239281757","issue_url":"https://api.github.com/repos/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/842","id":239281757,"user":{"login":"davidlunarg","id":10409469,"avatar_url":"https://avatars.githubusercontent.com/u/10409469?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlunarg","html_url":"https://github.com/davidlunarg","followers_url":"https://api.github.com/users/davidlunarg/followers","following_url":"https://api.github.com/users/davidlunarg/following{/other_user}","gists_url":"https://api.github.com/users/davidlunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlunarg/subscriptions","organizations_url":"https://api.github.com/users/davidlunarg/orgs","repos_url":"https://api.github.com/users/davidlunarg/repos","events_url":"https://api.github.com/users/davidlunarg/events{/privacy}","received_events_url":"https://api.github.com/users/davidlunarg/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T20:27:32Z","updated_at":"2016-08-11T20:27:32Z","body":"The new lines added to InstallerRT.nsi end with ^M. Existing lines do not.\r\n\r\nThe functions in configure_runtime.c should have a comment header describing what the function does. I realize these descriptions are in the forward declarations at the top of file. I personally prefer the header with code, and a block of forward declarations at the top of the file, with a simple comment like\r\n\"// Forward declarations\" for the whole block.\r\n\r\nThe README.txt file needs to be updated. It still mentions the powershell script.\r\n\r\nHow is the build of configure_runtime.exe done? Should LoaderAndValidationLayers/CMakeLists.txt file be changed so it is built? Or is it it built from the LunarG SDK build process? It seems all .exe files should be built when LVL is built.\r\n\r\nThe InstallerRT.nsi script still mentions the powershell script in comments. These comments need to be updated."}}
{"actor":{"display_login":"davidlunarg"}}