{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/50299414","id":50299414,"diff_hunk":"@@ -1755,12 +1756,12 @@ void LinearScan::identifyCandidates()\n     unsigned int floatVarCount = 0;\n     unsigned int thresholdFPRefCntWtd = 4 * BB_UNITY_WEIGHT;\n     unsigned int maybeFPRefCntWtd = 2 * BB_UNITY_WEIGHT;\n-#ifdef FEATURE_SIMD\n+#if FEATURE_PARTIAL_SIMD_CALLEE_SAVE\n     VarSetOps::AssignNoCopy(compiler, largeVectorVars, VarSetOps::MakeEmpty(compiler));\n     VarSetOps::AssignNoCopy(compiler, largeVectorCalleeSaveCandidateVars, VarSetOps::MakeEmpty(compiler));\n     unsigned int largeVectorVarCount = 0;\n     unsigned int thresholdLargeVectorRefCntWtd = 4 * BB_UNITY_WEIGHT;\n-#endif // FEATURE_SIMD\n+#endif // FEATURE_PARTIAL_SIMD_CALLEE_SAVE","path":"src/jit/lsra.cpp","position":25,"original_position":25,"commit_id":"c12d97f6136600fd65a53d97e98259e38fa296e0","original_commit_id":"c12d97f6136600fd65a53d97e98259e38fa296e0","user":{"login":"AndyAyersMS","id":10121823,"avatar_url":"https://avatars.githubusercontent.com/u/10121823?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"body":"@CarolEidt I'll take a look at it and see how much work is involved.","created_at":"2016-01-20T18:48:25Z","updated_at":"2016-01-20T18:48:25Z","html_url":"https://github.com/dotnet/coreclr/pull/2739#discussion_r50299414","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2739","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/50299414"},"html":{"href":"https://github.com/dotnet/coreclr/pull/2739#discussion_r50299414"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2739"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/2739","id":56564544,"html_url":"https://github.com/dotnet/coreclr/pull/2739","diff_url":"https://github.com/dotnet/coreclr/pull/2739.diff","patch_url":"https://github.com/dotnet/coreclr/pull/2739.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/2739","number":2739,"state":"open","locked":false,"title":"Enable AVX SIMD support for Unix systems.","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"body":"The existing code was assuming that there would be callee-save\r\nregisters for SIMD, but with the Unix ABI there are none.\r\n\r\nFix #983","created_at":"2016-01-20T05:03:14Z","updated_at":"2016-01-20T18:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ea6f684ca7c3f8fc03ae0f96294c1c4ab3b2f40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2739/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2739/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/2739/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/c12d97f6136600fd65a53d97e98259e38fa296e0","head":{"label":"CarolEidt:LinuxAVX983","ref":"LinuxAVX983","sha":"c12d97f6136600fd65a53d97e98259e38fa296e0","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"repo":{"id":31747006,"name":"coreclr","full_name":"CarolEidt/coreclr","owner":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CarolEidt/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/CarolEidt/coreclr","forks_url":"https://api.github.com/repos/CarolEidt/coreclr/forks","keys_url":"https://api.github.com/repos/CarolEidt/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CarolEidt/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CarolEidt/coreclr/teams","hooks_url":"https://api.github.com/repos/CarolEidt/coreclr/hooks","issue_events_url":"https://api.github.com/repos/CarolEidt/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/CarolEidt/coreclr/events","assignees_url":"https://api.github.com/repos/CarolEidt/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/CarolEidt/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/CarolEidt/coreclr/tags","blobs_url":"https://api.github.com/repos/CarolEidt/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CarolEidt/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CarolEidt/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/CarolEidt/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CarolEidt/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/CarolEidt/coreclr/languages","stargazers_url":"https://api.github.com/repos/CarolEidt/coreclr/stargazers","contributors_url":"https://api.github.com/repos/CarolEidt/coreclr/contributors","subscribers_url":"https://api.github.com/repos/CarolEidt/coreclr/subscribers","subscription_url":"https://api.github.com/repos/CarolEidt/coreclr/subscription","commits_url":"https://api.github.com/repos/CarolEidt/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/CarolEidt/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/CarolEidt/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/CarolEidt/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/CarolEidt/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/CarolEidt/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CarolEidt/coreclr/merges","archive_url":"https://api.github.com/repos/CarolEidt/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CarolEidt/coreclr/downloads","issues_url":"https://api.github.com/repos/CarolEidt/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/CarolEidt/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/CarolEidt/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/CarolEidt/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CarolEidt/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/CarolEidt/coreclr/releases{/id}","created_at":"2015-03-06T01:49:09Z","updated_at":"2016-01-16T00:00:55Z","pushed_at":"2016-01-20T05:01:45Z","git_url":"git://github.com/CarolEidt/coreclr.git","ssh_url":"git@github.com:CarolEidt/coreclr.git","clone_url":"https://github.com/CarolEidt/coreclr.git","svn_url":"https://github.com/CarolEidt/coreclr","homepage":"","size":49792,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"76f9db8e1977a98f753d4bb474aa3f392e5daaec","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-01-20T18:46:28Z","pushed_at":"2016-01-20T18:08:43Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":53688,"stargazers_count":5702,"watchers_count":5702,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1245,"mirror_url":null,"open_issues_count":470,"forks":1245,"open_issues":470,"watchers":5702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2739"},"html":{"href":"https://github.com/dotnet/coreclr/pull/2739"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/2739"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/2739/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2739/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2739/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/c12d97f6136600fd65a53d97e98259e38fa296e0"}}}}