{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/7236","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/7236/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/7236/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/7236/events","html_url":"https://github.com/nodejs/node/pull/7236","id":159294798,"number":7236,"title":"tls: avoid calling Buffer.byteLength multiple times","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/performance","name":"performance","color":"5319e7"},{"url":"https://api.github.com/repos/nodejs/node/labels/tls","name":"tls","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-08T22:54:12Z","updated_at":"2016-06-09T16:31:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/7236","html_url":"https://github.com/nodejs/node/pull/7236","diff_url":"https://github.com/nodejs/node/pull/7236.diff","patch_url":"https://github.com/nodejs/node/pull/7236.patch"},"body":"##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows) passes\r\n- [x] a test and/or benchmark is included\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ntls\r\n\r\n##### Description of change\r\n\r\nThere's no reason to be calling Buffer.byteLength() twice. That's just silly.\r\nSmall perf improvement\r\n\r\nRun 1:\r\ntls/convertprotocols.js n=1     v6.2.1 = 11852,  new = 12204 ......  -2.89%\r\ntls/convertprotocols.js n=50000 v6.2.1 = 515660, new = 570610 .....  -9.63%\r\n\r\nRun 2:\r\ntls/convertprotocols.js n=1     v6.2.1 = 11729,  new = 12045 ......  -2.62%\r\ntls/convertprotocols.js n=50000 v6.2.1 = 512080, new = 637730 ..... -19.70%\r\n\r\n@nodejs/crypto"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/224950771","html_url":"https://github.com/nodejs/node/pull/7236#issuecomment-224950771","issue_url":"https://api.github.com/repos/nodejs/node/issues/7236","id":224950771,"user":{"login":"indutny","id":238531,"avatar_url":"https://avatars.githubusercontent.com/u/238531?v=3","gravatar_id":"","url":"https://api.github.com/users/indutny","html_url":"https://github.com/indutny","followers_url":"https://api.github.com/users/indutny/followers","following_url":"https://api.github.com/users/indutny/following{/other_user}","gists_url":"https://api.github.com/users/indutny/gists{/gist_id}","starred_url":"https://api.github.com/users/indutny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indutny/subscriptions","organizations_url":"https://api.github.com/users/indutny/orgs","repos_url":"https://api.github.com/users/indutny/repos","events_url":"https://api.github.com/users/indutny/events{/privacy}","received_events_url":"https://api.github.com/users/indutny/received_events","type":"User","site_admin":false},"created_at":"2016-06-09T16:31:21Z","updated_at":"2016-06-09T16:31:21Z","body":"LGTM"}}
{"actor":{"display_login":"indutny"}}