{"action":"created","issue":{"url":"https://api.github.com/repos/dojo/dijit/issues/125","repository_url":"https://api.github.com/repos/dojo/dijit","labels_url":"https://api.github.com/repos/dojo/dijit/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/dojo/dijit/issues/125/comments","events_url":"https://api.github.com/repos/dojo/dijit/issues/125/events","html_url":"https://github.com/dojo/dijit/pull/125","id":182854195,"number":125,"title":"Fixes #18908: getLocalization calls still existing in dijit despite the method being deprecated","user":{"login":"pottedmeat","id":38750,"avatar_url":"https://avatars.githubusercontent.com/u/38750?v=3","gravatar_id":"","url":"https://api.github.com/users/pottedmeat","html_url":"https://github.com/pottedmeat","followers_url":"https://api.github.com/users/pottedmeat/followers","following_url":"https://api.github.com/users/pottedmeat/following{/other_user}","gists_url":"https://api.github.com/users/pottedmeat/gists{/gist_id}","starred_url":"https://api.github.com/users/pottedmeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pottedmeat/subscriptions","organizations_url":"https://api.github.com/users/pottedmeat/orgs","repos_url":"https://api.github.com/users/pottedmeat/repos","events_url":"https://api.github.com/users/pottedmeat/events{/privacy}","received_events_url":"https://api.github.com/users/pottedmeat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dojo/dijit/labels/CLA:%20Valid","name":"CLA: Valid","color":"007700"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-13T17:42:12Z","updated_at":"2016-10-14T07:02:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dojo/dijit/pulls/125","html_url":"https://github.com/dojo/dijit/pull/125","diff_url":"https://github.com/dojo/dijit/pull/125.diff","patch_url":"https://github.com/dojo/dijit/pull/125.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/dojo/dijit/issues/comments/253724681","html_url":"https://github.com/dojo/dijit/pull/125#issuecomment-253724681","issue_url":"https://api.github.com/repos/dojo/dijit/issues/125","id":253724681,"user":{"login":"wkeese","id":69599,"avatar_url":"https://avatars.githubusercontent.com/u/69599?v=3","gravatar_id":"","url":"https://api.github.com/users/wkeese","html_url":"https://github.com/wkeese","followers_url":"https://api.github.com/users/wkeese/followers","following_url":"https://api.github.com/users/wkeese/following{/other_user}","gists_url":"https://api.github.com/users/wkeese/gists{/gist_id}","starred_url":"https://api.github.com/users/wkeese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkeese/subscriptions","organizations_url":"https://api.github.com/users/wkeese/orgs","repos_url":"https://api.github.com/users/wkeese/repos","events_url":"https://api.github.com/users/wkeese/events{/privacy}","received_events_url":"https://api.github.com/users/wkeese/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T07:02:06Z","updated_at":"2016-10-14T07:02:06Z","body":"Yah, I don't know if there's a silver bullet where you can support CSP without breaking our promise of backwards compatibility.  You should also double check that change breaks non-AMD files.\r\n\r\nI don't have a personal stake in dropping non-AMD support, but it would be the biggest violation of our backwards-compatibility promise ever, and I know people have screamed bloody murder over much more trivial changes.\r\n\r\nIn any case, assuming this change breaks non-AMD files, then before checking it in, all the non-AMD files in the dojo source that depend on dijit would need to be converted to AMD.   That's 95 files in dijit itself and some subset of the 970 non-AMD files in dojox.\r\n"}}
{"actor":{"display_login":"wkeese"}}