{"action":"created","issue":{"url":"https://api.github.com/repos/MCTCP/TerrainControl/issues/488","repository_url":"https://api.github.com/repos/MCTCP/TerrainControl","labels_url":"https://api.github.com/repos/MCTCP/TerrainControl/issues/488/labels{/name}","comments_url":"https://api.github.com/repos/MCTCP/TerrainControl/issues/488/comments","events_url":"https://api.github.com/repos/MCTCP/TerrainControl/issues/488/events","html_url":"https://github.com/MCTCP/TerrainControl/pull/488","id":195622113,"number":488,"title":"Update Forge to 1.11 and fix virtual biome registration.","user":{"login":"bloodmc","id":2998171,"avatar_url":"https://avatars.githubusercontent.com/u/2998171?v=3","gravatar_id":"","url":"https://api.github.com/users/bloodmc","html_url":"https://github.com/bloodmc","followers_url":"https://api.github.com/users/bloodmc/followers","following_url":"https://api.github.com/users/bloodmc/following{/other_user}","gists_url":"https://api.github.com/users/bloodmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bloodmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloodmc/subscriptions","organizations_url":"https://api.github.com/users/bloodmc/orgs","repos_url":"https://api.github.com/users/bloodmc/repos","events_url":"https://api.github.com/users/bloodmc/events{/privacy}","received_events_url":"https://api.github.com/users/bloodmc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-14T19:24:56Z","updated_at":"2016-12-26T16:08:30Z","closed_at":"2016-12-15T16:42:21Z","pull_request":{"url":"https://api.github.com/repos/MCTCP/TerrainControl/pulls/488","html_url":"https://github.com/MCTCP/TerrainControl/pull/488","diff_url":"https://github.com/MCTCP/TerrainControl/pull/488.diff","patch_url":"https://github.com/MCTCP/TerrainControl/pull/488.patch"},"body":"This PR addresses tickets #442, #458, #475 by fixing virtual biome registration with Forge. I also updated Forge to 1.11 so it supports latest master.\r\n\r\nThere were 2 issues with the current code\r\n\r\n- Forge blocking any biome registration with an ID > 255. Forge essentially creates a wrapper around the Biome registry in order to enforce rules such as ensuring the biome ID being registered doesn't surpass 255. While this is fine for the most part, it breaks support for virtual biomes which TerrainControl adds. To workaround the issue, I simply use reflection to bypass Forge's API and register the virtual biomes directly into the biome registry.\r\n- WorldProvider init would cause TC to register the same world twice due to a bug in TCWorldType. I simply check to see if the world has been registered and if so setup the provider instance otherwise I run through normal TC loading logic.\r\n\r\nFor those on 1.10.2, you can find my virtual biome fix here\r\n\r\nhttps://github.com/bloodmc/TerrainControl/tree/1.10.2"},"comment":{"url":"https://api.github.com/repos/MCTCP/TerrainControl/issues/comments/269223263","html_url":"https://github.com/MCTCP/TerrainControl/pull/488#issuecomment-269223263","issue_url":"https://api.github.com/repos/MCTCP/TerrainControl/issues/488","id":269223263,"user":{"login":"bloodmc","id":2998171,"avatar_url":"https://avatars.githubusercontent.com/u/2998171?v=3","gravatar_id":"","url":"https://api.github.com/users/bloodmc","html_url":"https://github.com/bloodmc","followers_url":"https://api.github.com/users/bloodmc/followers","following_url":"https://api.github.com/users/bloodmc/following{/other_user}","gists_url":"https://api.github.com/users/bloodmc/gists{/gist_id}","starred_url":"https://api.github.com/users/bloodmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloodmc/subscriptions","organizations_url":"https://api.github.com/users/bloodmc/orgs","repos_url":"https://api.github.com/users/bloodmc/repos","events_url":"https://api.github.com/users/bloodmc/events{/privacy}","received_events_url":"https://api.github.com/users/bloodmc/received_events","type":"User","site_admin":false},"created_at":"2016-12-26T16:08:30Z","updated_at":"2016-12-26T16:08:30Z","body":"Looks like you are not building it properly as the jar isn't getting remapped. Did you follow the compiling readme?"}}
{"actor":{"display_login":"bloodmc"}}