{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9170","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9170/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9170/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9170/events","html_url":"https://github.com/joomla/joomla-cms/pull/9170","id":134961645,"number":9170,"title":"Correct db schema update errors for 3.5.0","user":{"login":"richard67","id":7413183,"avatar_url":"https://avatars.githubusercontent.com/u/7413183?v=3","gravatar_id":"","url":"https://api.github.com/users/richard67","html_url":"https://github.com/richard67","followers_url":"https://api.github.com/users/richard67/followers","following_url":"https://api.github.com/users/richard67/following{/other_user}","gists_url":"https://api.github.com/users/richard67/gists{/gist_id}","starred_url":"https://api.github.com/users/richard67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard67/subscriptions","organizations_url":"https://api.github.com/users/richard67/orgs","repos_url":"https://api.github.com/users/richard67/repos","events_url":"https://api.github.com/users/richard67/events{/privacy}","received_events_url":"https://api.github.com/users/richard67/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":178,"created_at":"2016-02-19T20:11:55Z","updated_at":"2016-02-25T01:39:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9170","html_url":"https://github.com/joomla/joomla-cms/pull/9170","diff_url":"https://github.com/joomla/joomla-cms/pull/9170.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9170.patch"},"body":"Pull Request for Issue #9156 .\r\n\r\n#### Summary of Changes\r\n\r\nThis PR changes following:\r\n\r\n- Correct handling of alter table statements in the database schema manager for the UTF8MB4 changes\r\n\r\n- Extend the database schema manager by handling alter table statements with drop and add index in one statement for the UTF8MB4 changes\r\n\r\n- Add missing index modifications to the SQL script for the UTF8MB4 changes\r\n\r\n- Add missing index lengths limitations to utf8mb4_bin columns to the joomla installation SQL script.\r\n\r\nIt **shall not** fix all possible problems on updating from 3.4.8 to 3.5.0.\r\n\r\nIt **shall** fix only the errors with fixing database problems being reported after the update.\r\n\r\n#### Testing Instructions\r\n\r\nEither do a Joomla! Update from a 3.4.8 to a \"3.5.0 latest staging plus this PR applied\":\r\n\r\nYou can find an update container here:\r\n[http://test5.richard-fath.de/Joomla_3.5.0-beta2-Beta-Update_Package_test1.zip](http://test5.richard-fath.de/Joomla_3.5.0-beta2-Beta-Update_Package_test1.zip \"http://test5.richard-fath.de/Joomla_3.5.0-beta2-Beta-Update_Package_test1.zip\").\r\n\r\nOr you can use the Joomla! Update component with following custom URL (note it is http, not use https):\r\n[http://test5.richard-fath.de/list_test4.xml](http://test5.richard-fath.de/list_test4.xml \"http://test5.richard-fath.de/list_test4.xml\").\r\n\r\nOr do as @wilsonge described in his issue #9156, i.e.\r\n\r\n- Install a new, clean 3.4.8 into an empty database,\r\n- download the branch of this patch here [https://github.com/richard67/joomla-cms/archive/correct-db-schema-manager-1.zip](https://github.com/richard67/joomla-cms/archive/correct-db-schema-manager-1.zip \"https://github.com/richard67/joomla-cms/archive/correct-db-schema-manager-1.zip\"),\r\n- unzip it into the 3.4.8 installation, so all the files are updated now by the ones from this PR,\r\n- login at the backend and check for database problems (Extenions -> Manage -> Database).\r\n- You will see one or more problems reported, depending on UTF8MB4 of your database server and client.\r\n- Use the \"Fix\" button.\r\n- All database problems should be fixed."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/188552792","html_url":"https://github.com/joomla/joomla-cms/pull/9170#issuecomment-188552792","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9170","id":188552792,"user":{"login":"joomla-cms-bot","id":10873953,"avatar_url":"https://avatars.githubusercontent.com/u/10873953?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla-cms-bot","html_url":"https://github.com/joomla-cms-bot","followers_url":"https://api.github.com/users/joomla-cms-bot/followers","following_url":"https://api.github.com/users/joomla-cms-bot/following{/other_user}","gists_url":"https://api.github.com/users/joomla-cms-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-cms-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-cms-bot/subscriptions","organizations_url":"https://api.github.com/users/joomla-cms-bot/orgs","repos_url":"https://api.github.com/users/joomla-cms-bot/repos","events_url":"https://api.github.com/users/joomla-cms-bot/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-cms-bot/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T01:39:25Z","updated_at":"2016-02-25T01:39:25Z","body":"This PR has received new commits.\n\n**CC:** @810<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/9170\">issues.joomla.org/joomla-cms/9170</a>.</sub>"}}