{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/tranquility/pulls/comments/52051924","id":52051924,"diff_hunk":"@@ -277,14 +267,37 @@ object DruidBeams\n   class Builder[EventType] private[druid](private[tranquility] val config: BuilderConfig[EventType])\n   {\n     /**\n-      * Provide a CuratorFramework instance that will be used for Tranquility's internal coordination. Required.\n+      * Provide a CuratorFramework instance that will be used for Tranquility's internal coordination. Either this\n+      * or \"curatorFactory\" is required. Whichever one is provided later will win.\n+      *\n+      * If you provide Curator this way (as opposed to \"curator\") then you should start and stop it yourself. You can","path":"core/src/main/scala/com/metamx/tranquility/druid/DruidBeams.scala","position":null,"original_position":288,"commit_id":"48c4b787d8e0d95bf15035a7f05cb839c99051c9","original_commit_id":"bd2b6a75e0a0b094c69c7eea9eb9a1d06f8615dc","user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars.githubusercontent.com/u/1214075?v=3","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"body":"yes, definitely.","created_at":"2016-02-05T18:16:40Z","updated_at":"2016-02-05T18:16:40Z","html_url":"https://github.com/druid-io/tranquility/pull/112#discussion_r52051924","pull_request_url":"https://api.github.com/repos/druid-io/tranquility/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/comments/52051924"},"html":{"href":"https://github.com/druid-io/tranquility/pull/112#discussion_r52051924"},"pull_request":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/tranquility/pulls/112","id":58051687,"html_url":"https://github.com/druid-io/tranquility/pull/112","diff_url":"https://github.com/druid-io/tranquility/pull/112.diff","patch_url":"https://github.com/druid-io/tranquility/pull/112.patch","issue_url":"https://api.github.com/repos/druid-io/tranquility/issues/112","number":112,"state":"open","locked":false,"title":"Standardize on configuration files and use of Tranquilizer.","user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars.githubusercontent.com/u/1214075?v=3","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"body":"- Introduce TranquilityConfig.read and DruidBeams.fromConfig.\r\n- Switch all modules from simple tranquilizer to Tranquilizer + flush.\r\n- Switch Java/Scala code examples to Tranquilizer + flush.\r\n- Adjust default config files to have more consistent formatting.\r\n- Allow 'dataSources' to be a list instead of a map in config files.\r\n\r\nAlso:\r\n- Include full date in bundled logback.xml\r\n\r\nFixes #103","created_at":"2016-02-02T21:20:04Z","updated_at":"2016-02-05T18:16:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74779abede34e2910067e5fe9174078bc191a470","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/druid-io/tranquility/pulls/112/commits","review_comments_url":"https://api.github.com/repos/druid-io/tranquility/pulls/112/comments","review_comment_url":"https://api.github.com/repos/druid-io/tranquility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/tranquility/issues/112/comments","statuses_url":"https://api.github.com/repos/druid-io/tranquility/statuses/48c4b787d8e0d95bf15035a7f05cb839c99051c9","head":{"label":"gianm:config-refactor","ref":"config-refactor","sha":"48c4b787d8e0d95bf15035a7f05cb839c99051c9","user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars.githubusercontent.com/u/1214075?v=3","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"repo":{"id":35352803,"name":"tranquility","full_name":"gianm/tranquility","owner":{"login":"gianm","id":1214075,"avatar_url":"https://avatars.githubusercontent.com/u/1214075?v=3","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gianm/tranquility","description":"Regenerates all nearby group members for 2569 to 2986 every 2 seconds for 10 sec.","fork":true,"url":"https://api.github.com/repos/gianm/tranquility","forks_url":"https://api.github.com/repos/gianm/tranquility/forks","keys_url":"https://api.github.com/repos/gianm/tranquility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gianm/tranquility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gianm/tranquility/teams","hooks_url":"https://api.github.com/repos/gianm/tranquility/hooks","issue_events_url":"https://api.github.com/repos/gianm/tranquility/issues/events{/number}","events_url":"https://api.github.com/repos/gianm/tranquility/events","assignees_url":"https://api.github.com/repos/gianm/tranquility/assignees{/user}","branches_url":"https://api.github.com/repos/gianm/tranquility/branches{/branch}","tags_url":"https://api.github.com/repos/gianm/tranquility/tags","blobs_url":"https://api.github.com/repos/gianm/tranquility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gianm/tranquility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gianm/tranquility/git/refs{/sha}","trees_url":"https://api.github.com/repos/gianm/tranquility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gianm/tranquility/statuses/{sha}","languages_url":"https://api.github.com/repos/gianm/tranquility/languages","stargazers_url":"https://api.github.com/repos/gianm/tranquility/stargazers","contributors_url":"https://api.github.com/repos/gianm/tranquility/contributors","subscribers_url":"https://api.github.com/repos/gianm/tranquility/subscribers","subscription_url":"https://api.github.com/repos/gianm/tranquility/subscription","commits_url":"https://api.github.com/repos/gianm/tranquility/commits{/sha}","git_commits_url":"https://api.github.com/repos/gianm/tranquility/git/commits{/sha}","comments_url":"https://api.github.com/repos/gianm/tranquility/comments{/number}","issue_comment_url":"https://api.github.com/repos/gianm/tranquility/issues/comments{/number}","contents_url":"https://api.github.com/repos/gianm/tranquility/contents/{+path}","compare_url":"https://api.github.com/repos/gianm/tranquility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gianm/tranquility/merges","archive_url":"https://api.github.com/repos/gianm/tranquility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gianm/tranquility/downloads","issues_url":"https://api.github.com/repos/gianm/tranquility/issues{/number}","pulls_url":"https://api.github.com/repos/gianm/tranquility/pulls{/number}","milestones_url":"https://api.github.com/repos/gianm/tranquility/milestones{/number}","notifications_url":"https://api.github.com/repos/gianm/tranquility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gianm/tranquility/labels{/name}","releases_url":"https://api.github.com/repos/gianm/tranquility/releases{/id}","deployments_url":"https://api.github.com/repos/gianm/tranquility/deployments","created_at":"2015-05-10T01:47:31Z","updated_at":"2016-01-11T20:27:21Z","pushed_at":"2016-02-05T18:16:35Z","git_url":"git://github.com/gianm/tranquility.git","ssh_url":"git@github.com:gianm/tranquility.git","clone_url":"https://github.com/gianm/tranquility.git","svn_url":"https://github.com/gianm/tranquility","homepage":"","size":770,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"697eb2c80cba35d31d6b4f9ef3057c477915af4e","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":16817857,"name":"tranquility","full_name":"druid-io/tranquility","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/tranquility","description":"Tranquility helps you send real-time event streams to Druid and handles partitioning, replication, service discovery, and schema rollover, seamlessly and without downtime.","fork":false,"url":"https://api.github.com/repos/druid-io/tranquility","forks_url":"https://api.github.com/repos/druid-io/tranquility/forks","keys_url":"https://api.github.com/repos/druid-io/tranquility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/tranquility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/tranquility/teams","hooks_url":"https://api.github.com/repos/druid-io/tranquility/hooks","issue_events_url":"https://api.github.com/repos/druid-io/tranquility/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/tranquility/events","assignees_url":"https://api.github.com/repos/druid-io/tranquility/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/tranquility/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/tranquility/tags","blobs_url":"https://api.github.com/repos/druid-io/tranquility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/tranquility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/tranquility/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/tranquility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/tranquility/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/tranquility/languages","stargazers_url":"https://api.github.com/repos/druid-io/tranquility/stargazers","contributors_url":"https://api.github.com/repos/druid-io/tranquility/contributors","subscribers_url":"https://api.github.com/repos/druid-io/tranquility/subscribers","subscription_url":"https://api.github.com/repos/druid-io/tranquility/subscription","commits_url":"https://api.github.com/repos/druid-io/tranquility/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/tranquility/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/tranquility/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/tranquility/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/tranquility/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/tranquility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/tranquility/merges","archive_url":"https://api.github.com/repos/druid-io/tranquility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/tranquility/downloads","issues_url":"https://api.github.com/repos/druid-io/tranquility/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/tranquility/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/tranquility/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/tranquility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/tranquility/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/tranquility/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/tranquility/deployments","created_at":"2014-02-13T21:30:05Z","updated_at":"2016-02-01T05:07:02Z","pushed_at":"2016-02-05T18:16:36Z","git_url":"git://github.com/druid-io/tranquility.git","ssh_url":"git@github.com:druid-io/tranquility.git","clone_url":"https://github.com/druid-io/tranquility.git","svn_url":"https://github.com/druid-io/tranquility","homepage":"","size":783,"stargazers_count":108,"watchers_count":108,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":19,"forks":42,"open_issues":19,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/112"},"html":{"href":"https://github.com/druid-io/tranquility/pull/112"},"issue":{"href":"https://api.github.com/repos/druid-io/tranquility/issues/112"},"comments":{"href":"https://api.github.com/repos/druid-io/tranquility/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/tranquility/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/tranquility/statuses/48c4b787d8e0d95bf15035a7f05cb839c99051c9"}}}}