{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/80987721","pull_request_review_id":2001897,"id":80987721,"diff_hunk":"@@ -1543,6 +1544,64 @@ func ContainerSignal(containerID string, sig uint64) error {\n \treturn nil\n }\n \n+func getClientIPAddrs() []netlink.Addr {\n+\tl, err := netlink.LinkByName(clientIfaceName)\n+\tif err != nil {\n+\t\tlog.Errorf(\"Could not look up link from client interface name %s due to error %s\",\n+\t\t\tclientIfaceName, err.Error())\n+\t\treturn nil\n+\t}\n+\tips, err := netlink.AddrList(l, netlink.FAMILY_V4)","path":"lib/apiservers/engine/backends/container.go","position":null,"original_position":19,"commit_id":"4762bfef3f3974d7962ad88b49d7d37b72c3c741","original_commit_id":"66676dfe5d6e5352b49ff9adc87b627592456866","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"body":"Renamed.","created_at":"2016-09-28T18:36:31Z","updated_at":"2016-09-28T18:36:31Z","html_url":"https://github.com/vmware/vic/pull/2489#discussion_r80987721","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2489","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/80987721"},"html":{"href":"https://github.com/vmware/vic/pull/2489#discussion_r80987721"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2489"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2489","id":86968521,"html_url":"https://github.com/vmware/vic/pull/2489","diff_url":"https://github.com/vmware/vic/pull/2489.diff","patch_url":"https://github.com/vmware/vic/pull/2489.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2489","number":2489,"state":"open","locked":false,"title":"Implements PORTS output in `docker ps`","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"body":"Adds functionality to show ports mapped to containers when `docker ps` is called.\r\n\r\n<pre>~/go/src/github.com/vmware/vic ps-ports* 19s\r\n❯ docker -H 192.168.218.212:2376 --tls create -p 9000:80 -p 8443:443 nginx && docker -H 192.168.218.212:2376 --tls ps -a\r\nUnable to find image 'nginx:latest' locally\r\nPulling from library/nginx\r\na3ed95caeb02: Pull complete \r\n6a5a5368e0c2: Pull complete \r\n4aceccff346f: Pull complete \r\nc8967f302193: Pull complete \r\nDigest: sha256:0d4dac4abf4f5217f878974a6cffea83b9102ed49b1f9f4c5216db0fd6b0af99\r\nStatus: Downloaded newer image for library/nginx:latest\r\nb1358a9d60a4390c938327f086e7947d7c936a08836abf2c165a508afdb2fa67\r\nCONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS              PORTS                                                         NAMES\r\nb1358a9d60a4        nginx               \"nginx -g daemon off;\"   6 weeks ago         Created             192.168.218.212:9000->80/tcp, 192.168.218.212:8443->443/tcp   insane_galileo\r\n\r\n~/go/src/github.com/vmware/vic ps-ports* 26s\r\n❯ docker -H 192.168.218.212:2376 --tls create -p 8000:80 nginx && docker -H 192.168.218.212:2376 --tls create busybox && docker -H 192.168.218.212:2376 --tls ps -a\r\n75701a6bf7a13c0876901b3a6cb734424431a288774579646fdb4a187a5b980e\r\nUnable to find image 'busybox:latest' locally\r\nPulling from library/busybox\r\na3ed95caeb02: Pull complete \r\n8ddc19f16526: Pull complete \r\nDigest: sha256:65ce39ce3eb0997074a460adfb568d0b9f0f6a4392d97b6035630c9d7bf92402\r\nStatus: Downloaded newer image for library/busybox:latest\r\n1d0359ea0e392566b943bd78ad4d65179db96bc204fd5d5b4cdc48d6bf57aa26\r\nCONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS              PORTS                                                         NAMES\r\n1d0359ea0e39        busybox             \"sh\"                     6 weeks ago         Created                                                                           evil_leavitt\r\n75701a6bf7a1        nginx               \"nginx -g daemon off;\"   6 weeks ago         Created             192.168.218.212:8000->80/tcp                                  sad_banach\r\nb1358a9d60a4        nginx               \"nginx -g daemon off;\"   6 weeks ago         Created             192.168.218.212:9000->80/tcp, 192.168.218.212:8443->443/tcp   insane_galileo\r\n</pre>\r\n\r\nFixes #1701\r\n","created_at":"2016-09-27T16:48:58Z","updated_at":"2016-09-28T18:36:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a0c77815ed4c32d8444d2c8b64b8fdd3c714122","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2489/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2489/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2489/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/4762bfef3f3974d7962ad88b49d7d37b72c3c741","head":{"label":"gigawhitlocks:ps-ports","ref":"ps-ports","sha":"4762bfef3f3974d7962ad88b49d7d37b72c3c741","user":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"repo":{"id":55534993,"name":"vic","full_name":"gigawhitlocks/vic","owner":{"login":"gigawhitlocks","id":3743903,"avatar_url":"https://avatars.githubusercontent.com/u/3743903?v=3","gravatar_id":"","url":"https://api.github.com/users/gigawhitlocks","html_url":"https://github.com/gigawhitlocks","followers_url":"https://api.github.com/users/gigawhitlocks/followers","following_url":"https://api.github.com/users/gigawhitlocks/following{/other_user}","gists_url":"https://api.github.com/users/gigawhitlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/gigawhitlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigawhitlocks/subscriptions","organizations_url":"https://api.github.com/users/gigawhitlocks/orgs","repos_url":"https://api.github.com/users/gigawhitlocks/repos","events_url":"https://api.github.com/users/gigawhitlocks/events{/privacy}","received_events_url":"https://api.github.com/users/gigawhitlocks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gigawhitlocks/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/gigawhitlocks/vic","forks_url":"https://api.github.com/repos/gigawhitlocks/vic/forks","keys_url":"https://api.github.com/repos/gigawhitlocks/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigawhitlocks/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigawhitlocks/vic/teams","hooks_url":"https://api.github.com/repos/gigawhitlocks/vic/hooks","issue_events_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/events{/number}","events_url":"https://api.github.com/repos/gigawhitlocks/vic/events","assignees_url":"https://api.github.com/repos/gigawhitlocks/vic/assignees{/user}","branches_url":"https://api.github.com/repos/gigawhitlocks/vic/branches{/branch}","tags_url":"https://api.github.com/repos/gigawhitlocks/vic/tags","blobs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigawhitlocks/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigawhitlocks/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigawhitlocks/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigawhitlocks/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/gigawhitlocks/vic/languages","stargazers_url":"https://api.github.com/repos/gigawhitlocks/vic/stargazers","contributors_url":"https://api.github.com/repos/gigawhitlocks/vic/contributors","subscribers_url":"https://api.github.com/repos/gigawhitlocks/vic/subscribers","subscription_url":"https://api.github.com/repos/gigawhitlocks/vic/subscription","commits_url":"https://api.github.com/repos/gigawhitlocks/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigawhitlocks/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigawhitlocks/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigawhitlocks/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigawhitlocks/vic/contents/{+path}","compare_url":"https://api.github.com/repos/gigawhitlocks/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigawhitlocks/vic/merges","archive_url":"https://api.github.com/repos/gigawhitlocks/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigawhitlocks/vic/downloads","issues_url":"https://api.github.com/repos/gigawhitlocks/vic/issues{/number}","pulls_url":"https://api.github.com/repos/gigawhitlocks/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/gigawhitlocks/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/gigawhitlocks/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigawhitlocks/vic/labels{/name}","releases_url":"https://api.github.com/repos/gigawhitlocks/vic/releases{/id}","deployments_url":"https://api.github.com/repos/gigawhitlocks/vic/deployments","created_at":"2016-04-05T18:57:06Z","updated_at":"2016-04-05T18:57:13Z","pushed_at":"2016-09-28T18:36:08Z","git_url":"git://github.com/gigawhitlocks/vic.git","ssh_url":"git@github.com:gigawhitlocks/vic.git","clone_url":"https://github.com/gigawhitlocks/vic.git","svn_url":"https://github.com/gigawhitlocks/vic","homepage":null,"size":35433,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"08cb9fd26343bc83f55848b75b586513400f1f8c","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-09-27T15:33:23Z","pushed_at":"2016-09-28T18:36:09Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"","size":80289,"stargazers_count":136,"watchers_count":136,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"open_issues_count":456,"forks":50,"open_issues":456,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2489"},"html":{"href":"https://github.com/vmware/vic/pull/2489"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2489"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2489/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2489/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2489/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/4762bfef3f3974d7962ad88b49d7d37b72c3c741"}}}}
{"actor":{"display_login":"gigawhitlocks"}}