{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/charts/issues/43","repository_url":"https://api.github.com/repos/kubernetes/charts","labels_url":"https://api.github.com/repos/kubernetes/charts/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/43/comments","events_url":"https://api.github.com/repos/kubernetes/charts/issues/43/events","html_url":"https://github.com/kubernetes/charts/pull/43","id":172866148,"number":43,"title":"Use values.yaml to configure PVC in mariadb","user":{"login":"viglesiasce","id":410279,"avatar_url":"https://avatars.githubusercontent.com/u/410279?v=3","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/charts/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-24T05:15:21Z","updated_at":"2016-08-27T00:18:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/43","html_url":"https://github.com/kubernetes/charts/pull/43","diff_url":"https://github.com/kubernetes/charts/pull/43.diff","patch_url":"https://github.com/kubernetes/charts/pull/43.patch"},"body":"I am opening this mostly to talk through the best practices for configuration of PDs for charts.\r\n\r\nThe original approach in the MariaDB chart is to have users edit the deployment. While I think this is reasonable, I think it would be better if users were not changing deployment templates and instead only changing things that were explicitly exposed through the values file.\r\n\r\nThe approach I use here is to have templates for each section of the volume. What I wanted to do (but couldn't figure out with templating/sprig) was to insert the dict as is from values->deployment. If that had worked I would have just had a dataVolume section in values.yaml that listed the exact hierarchy i wanted to nest under the data volume definition."},"comment":{"url":"https://api.github.com/repos/kubernetes/charts/issues/comments/242882276","html_url":"https://github.com/kubernetes/charts/pull/43#issuecomment-242882276","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/43","id":242882276,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-27T00:18:11Z","updated_at":"2016-08-27T00:18:11Z","body":"Build finished. \n"}}
{"actor":{"display_login":"k8s-bot"}}