{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/81633578","pull_request_review_id":2599640,"id":81633578,"diff_hunk":"@@ -295,6 +303,11 @@ public void setup() throws Exception {\n       public void processElement(ProcessContext context) throws Exception {\n         String query = context.element();\n         try (PreparedStatement statement = connection.prepareStatement(query)) {\n+          if (spec.getParameters() != null) {\n+            for (int index = 0; index < spec.getParameters().size(); index++) {\n+              statement.setObject(index + 1, spec.getParameters().get(index));","path":"sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java","position":42,"original_position":42,"commit_id":"a3c54fa30b833fcc136ddbdcabb98db136962588","original_commit_id":"a3c54fa30b833fcc136ddbdcabb98db136962588","user":{"login":"gdubya","id":446033,"avatar_url":"https://avatars.githubusercontent.com/u/446033?v=3","gravatar_id":"","url":"https://api.github.com/users/gdubya","html_url":"https://github.com/gdubya","followers_url":"https://api.github.com/users/gdubya/followers","following_url":"https://api.github.com/users/gdubya/following{/other_user}","gists_url":"https://api.github.com/users/gdubya/gists{/gist_id}","starred_url":"https://api.github.com/users/gdubya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdubya/subscriptions","organizations_url":"https://api.github.com/users/gdubya/orgs","repos_url":"https://api.github.com/users/gdubya/repos","events_url":"https://api.github.com/users/gdubya/events{/privacy}","received_events_url":"https://api.github.com/users/gdubya/received_events","type":"User","site_admin":false},"body":"Because then the list.get() on line 308 would have to offset the index by -1","created_at":"2016-10-03T20:32:03Z","updated_at":"2016-10-03T20:32:03Z","html_url":"https://github.com/apache/incubator-beam/pull/1037#discussion_r81633578","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1037","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/81633578"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1037#discussion_r81633578"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1037"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1037","id":87648559,"html_url":"https://github.com/apache/incubator-beam/pull/1037","diff_url":"https://github.com/apache/incubator-beam/pull/1037.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1037.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1037","number":1037,"state":"open","locked":false,"title":"JdbcIO.Read: Added ability to set parameters on PreparedStatement","user":{"login":"gdubya","id":446033,"avatar_url":"https://avatars.githubusercontent.com/u/446033?v=3","gravatar_id":"","url":"https://api.github.com/users/gdubya","html_url":"https://github.com/gdubya","followers_url":"https://api.github.com/users/gdubya/followers","following_url":"https://api.github.com/users/gdubya/following{/other_user}","gists_url":"https://api.github.com/users/gdubya/gists{/gist_id}","starred_url":"https://api.github.com/users/gdubya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdubya/subscriptions","organizations_url":"https://api.github.com/users/gdubya/orgs","repos_url":"https://api.github.com/users/gdubya/repos","events_url":"https://api.github.com/users/gdubya/events{/privacy}","received_events_url":"https://api.github.com/users/gdubya/received_events","type":"User","site_admin":false},"body":"This is just a small change to add the ability to set parameters when querying a JDBC source.\r\n\r\nFurther improvements could be made regarding handling of the parameter types, but this seemed like a 'good enough' start.\r\n","created_at":"2016-10-02T22:11:29Z","updated_at":"2016-10-03T20:32:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f5e5386b5360a7081fb733f4d6f1adf8ccfb716","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1037/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1037/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1037/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/a3c54fa30b833fcc136ddbdcabb98db136962588","head":{"label":"gdubya:master","ref":"master","sha":"a3c54fa30b833fcc136ddbdcabb98db136962588","user":{"login":"gdubya","id":446033,"avatar_url":"https://avatars.githubusercontent.com/u/446033?v=3","gravatar_id":"","url":"https://api.github.com/users/gdubya","html_url":"https://github.com/gdubya","followers_url":"https://api.github.com/users/gdubya/followers","following_url":"https://api.github.com/users/gdubya/following{/other_user}","gists_url":"https://api.github.com/users/gdubya/gists{/gist_id}","starred_url":"https://api.github.com/users/gdubya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdubya/subscriptions","organizations_url":"https://api.github.com/users/gdubya/orgs","repos_url":"https://api.github.com/users/gdubya/repos","events_url":"https://api.github.com/users/gdubya/events{/privacy}","received_events_url":"https://api.github.com/users/gdubya/received_events","type":"User","site_admin":false},"repo":{"id":69824291,"name":"incubator-beam","full_name":"gdubya/incubator-beam","owner":{"login":"gdubya","id":446033,"avatar_url":"https://avatars.githubusercontent.com/u/446033?v=3","gravatar_id":"","url":"https://api.github.com/users/gdubya","html_url":"https://github.com/gdubya","followers_url":"https://api.github.com/users/gdubya/followers","following_url":"https://api.github.com/users/gdubya/following{/other_user}","gists_url":"https://api.github.com/users/gdubya/gists{/gist_id}","starred_url":"https://api.github.com/users/gdubya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdubya/subscriptions","organizations_url":"https://api.github.com/users/gdubya/orgs","repos_url":"https://api.github.com/users/gdubya/repos","events_url":"https://api.github.com/users/gdubya/events{/privacy}","received_events_url":"https://api.github.com/users/gdubya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdubya/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/gdubya/incubator-beam","forks_url":"https://api.github.com/repos/gdubya/incubator-beam/forks","keys_url":"https://api.github.com/repos/gdubya/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdubya/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdubya/incubator-beam/teams","hooks_url":"https://api.github.com/repos/gdubya/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/gdubya/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/gdubya/incubator-beam/events","assignees_url":"https://api.github.com/repos/gdubya/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/gdubya/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/gdubya/incubator-beam/tags","blobs_url":"https://api.github.com/repos/gdubya/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdubya/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdubya/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdubya/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdubya/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/gdubya/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/gdubya/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/gdubya/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/gdubya/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/gdubya/incubator-beam/subscription","commits_url":"https://api.github.com/repos/gdubya/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdubya/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdubya/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdubya/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdubya/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/gdubya/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdubya/incubator-beam/merges","archive_url":"https://api.github.com/repos/gdubya/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdubya/incubator-beam/downloads","issues_url":"https://api.github.com/repos/gdubya/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/gdubya/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/gdubya/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/gdubya/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdubya/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/gdubya/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/gdubya/incubator-beam/deployments","created_at":"2016-10-02T21:53:28Z","updated_at":"2016-10-02T21:53:34Z","pushed_at":"2016-10-02T22:07:20Z","git_url":"git://github.com/gdubya/incubator-beam.git","ssh_url":"git@github.com:gdubya/incubator-beam.git","clone_url":"https://github.com/gdubya/incubator-beam.git","svn_url":"https://github.com/gdubya/incubator-beam","homepage":null,"size":19686,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"202acd1d6196b12b0d189b947ef202e32581cbed","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-10-02T20:26:55Z","pushed_at":"2016-10-03T20:08:56Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":29050,"stargazers_count":375,"watchers_count":375,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":237,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":49,"forks":237,"open_issues":49,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1037"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1037"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1037"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1037/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1037/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1037/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/a3c54fa30b833fcc136ddbdcabb98db136962588"}}}}
{"actor":{"display_login":"gdubya"}}