{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/77902695","id":77902695,"diff_hunk":"@@ -0,0 +1,4 @@\n+FROM jenkins:2.7.3","path":"incubator/jenkins/master-image/Dockerfile","position":1,"original_position":1,"commit_id":"708c40e78d5a4c3177244939e33d1790ccebb78f","original_commit_id":"b581bc85b1cf02b814c66c8954d0313ca9134393","user":{"login":"viglesiasce","id":410279,"avatar_url":"https://avatars.githubusercontent.com/u/410279?v=3","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"body":"Look at it the same as any other image in a chart. It is the chart maintainers duty to ensure that the image is pushed and works. Additionally CI can/will check for the functionality of the chart so would catch any missing images. \r\n\r\nFor example [in the mariadb chart](https://github.com/kubernetes/charts/blob/master/stable/mariadb/templates/deployment.yaml#L21) the `bitnami/mariadb` image is used. The chart does not give an idea of when or how that image gets pushed or updated. \r\n\r\nI think aspirationally we should have a process in the CI pipeline to auto build/push images. Maybe with a convention on where images would live (images folder) and that the tag would be equivalent to the chart version.\r\n\r\nWas there a particular concern you had?","created_at":"2016-09-07T20:59:37Z","updated_at":"2016-09-07T20:59:37Z","html_url":"https://github.com/kubernetes/charts/pull/61#discussion_r77902695","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/77902695"},"html":{"href":"https://github.com/kubernetes/charts/pull/61#discussion_r77902695"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/61","id":84159729,"html_url":"https://github.com/kubernetes/charts/pull/61","diff_url":"https://github.com/kubernetes/charts/pull/61.diff","patch_url":"https://github.com/kubernetes/charts/pull/61.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/61","number":61,"state":"open","locked":false,"title":"Jenkins","user":{"login":"viglesiasce","id":410279,"avatar_url":"https://avatars.githubusercontent.com/u/410279?v=3","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"body":"This supercedes #33.\r\n\r\nThis chart uses the Kubernetes plugin to launch build agents and is configurable via a config map. A default admin password can be provided via the values file or will be generated by the chart. You can retrieve the generated password by running:\r\n\r\n    printf $(printf '\\%o' `kubectl get secret ${RELEASE_NAME}-jenkins -o jsonpath=\"{.data.jenkins-admin-password[*]}\"`)\r\n\r\nFollow up update post alpha4 will be to add a NOTES.txt that helps guide the user to their password.","created_at":"2016-09-06T17:04:30Z","updated_at":"2016-09-07T20:59:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ffa4a7e4123e6f51b422f503fc2d8ca57a80a7c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/61/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/61/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/61/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/708c40e78d5a4c3177244939e33d1790ccebb78f","head":{"label":"viglesiasce:jenkins","ref":"jenkins","sha":"708c40e78d5a4c3177244939e33d1790ccebb78f","user":{"login":"viglesiasce","id":410279,"avatar_url":"https://avatars.githubusercontent.com/u/410279?v=3","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"repo":{"id":61092892,"name":"charts","full_name":"viglesiasce/charts","owner":{"login":"viglesiasce","id":410279,"avatar_url":"https://avatars.githubusercontent.com/u/410279?v=3","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viglesiasce/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":true,"url":"https://api.github.com/repos/viglesiasce/charts","forks_url":"https://api.github.com/repos/viglesiasce/charts/forks","keys_url":"https://api.github.com/repos/viglesiasce/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viglesiasce/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viglesiasce/charts/teams","hooks_url":"https://api.github.com/repos/viglesiasce/charts/hooks","issue_events_url":"https://api.github.com/repos/viglesiasce/charts/issues/events{/number}","events_url":"https://api.github.com/repos/viglesiasce/charts/events","assignees_url":"https://api.github.com/repos/viglesiasce/charts/assignees{/user}","branches_url":"https://api.github.com/repos/viglesiasce/charts/branches{/branch}","tags_url":"https://api.github.com/repos/viglesiasce/charts/tags","blobs_url":"https://api.github.com/repos/viglesiasce/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viglesiasce/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viglesiasce/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/viglesiasce/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viglesiasce/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/viglesiasce/charts/languages","stargazers_url":"https://api.github.com/repos/viglesiasce/charts/stargazers","contributors_url":"https://api.github.com/repos/viglesiasce/charts/contributors","subscribers_url":"https://api.github.com/repos/viglesiasce/charts/subscribers","subscription_url":"https://api.github.com/repos/viglesiasce/charts/subscription","commits_url":"https://api.github.com/repos/viglesiasce/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/viglesiasce/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/viglesiasce/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/viglesiasce/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/viglesiasce/charts/contents/{+path}","compare_url":"https://api.github.com/repos/viglesiasce/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viglesiasce/charts/merges","archive_url":"https://api.github.com/repos/viglesiasce/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viglesiasce/charts/downloads","issues_url":"https://api.github.com/repos/viglesiasce/charts/issues{/number}","pulls_url":"https://api.github.com/repos/viglesiasce/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/viglesiasce/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/viglesiasce/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viglesiasce/charts/labels{/name}","releases_url":"https://api.github.com/repos/viglesiasce/charts/releases{/id}","deployments_url":"https://api.github.com/repos/viglesiasce/charts/deployments","created_at":"2016-06-14T04:57:41Z","updated_at":"2016-08-17T23:43:20Z","pushed_at":"2016-09-07T18:45:18Z","git_url":"git://github.com/viglesiasce/charts.git","ssh_url":"git@github.com:viglesiasce/charts.git","clone_url":"https://github.com/viglesiasce/charts.git","svn_url":"https://github.com/viglesiasce/charts","homepage":"","size":191,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1f7b16a9edb8b957175f51fe2bc93336f63c7ca0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes using Helm charts with integrated Deployment Manager templates","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2016-09-03T00:29:23Z","pushed_at":"2016-09-07T18:45:19Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":427,"stargazers_count":38,"watchers_count":38,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":20,"forks":36,"open_issues":20,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/61"},"html":{"href":"https://github.com/kubernetes/charts/pull/61"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/61"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/708c40e78d5a4c3177244939e33d1790ccebb78f"}}}}
{"actor":{"display_login":"viglesiasce"}}