{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/server/issues/840","repository_url":"https://api.github.com/repos/nextcloud/server","labels_url":"https://api.github.com/repos/nextcloud/server/issues/840/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/840/comments","events_url":"https://api.github.com/repos/nextcloud/server/issues/840/events","html_url":"https://github.com/nextcloud/server/pull/840","id":170755733,"number":840,"title":"Add dynamic icon creation","user":{"login":"juliushaertl","id":3404133,"avatar_url":"https://avatars.githubusercontent.com/u/3404133?v=3","gravatar_id":"","url":"https://api.github.com/users/juliushaertl","html_url":"https://github.com/juliushaertl","followers_url":"https://api.github.com/users/juliushaertl/followers","following_url":"https://api.github.com/users/juliushaertl/following{/other_user}","gists_url":"https://api.github.com/users/juliushaertl/gists{/gist_id}","starred_url":"https://api.github.com/users/juliushaertl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliushaertl/subscriptions","organizations_url":"https://api.github.com/users/juliushaertl/orgs","repos_url":"https://api.github.com/users/juliushaertl/repos","events_url":"https://api.github.com/users/juliushaertl/events{/privacy}","received_events_url":"https://api.github.com/users/juliushaertl/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nextcloud/server/labels/2.%20developing","name":"2. developing","color":"0052cc"},{"url":"https://api.github.com/repos/nextcloud/server/labels/enhancement","name":"enhancement","color":"0e8a16"},{"url":"https://api.github.com/repos/nextcloud/server/labels/feature:%20theming","name":"feature: theming","color":"c2e0c6"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-11T21:49:11Z","updated_at":"2016-08-15T10:01:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/840","html_url":"https://github.com/nextcloud/server/pull/840","diff_url":"https://github.com/nextcloud/server/pull/840.diff","patch_url":"https://github.com/nextcloud/server/pull/840.patch"},"body":"So this basically addresses #218 and #378. With this change the theming app offers two new endpoints for getting themed icons.\r\nReturn a image with logo and colored background:\r\nhttp://localhost:8080/index.php/apps/theming/favicon/appname\r\nReturn a svg icon replacing the default color with the themed one:\r\nhttp://localhost:8080/index.php/apps/theming/image/appname/filepath\r\n\r\nResults:\r\n![2016-08-11-231339_961x348_scrot](https://cloud.githubusercontent.com/assets/3404133/17605943/2b43e05a-601d-11e6-9d5e-11e5d9c665bd.png)\r\n![2016-08-11-234209_191x31_scrot](https://cloud.githubusercontent.com/assets/3404133/17606053/c22e54d2-601d-11e6-8837-0afb9ee24685.png)\r\n\r\n- [x] use theming logo instead of nextcloud if available\r\n- [x] touch homescreen icons\r\n- [x] search icons.css for classes like icon-folder to replace the icon with a themed one\r\n- [ ] Add caching\r\n- [ ] Unit tests\r\n- [ ] check if there are directory traversal issues\r\n- [ ] code cleanup\r\n\r\nrequired #770 to be merged"},"comment":{"url":"https://api.github.com/repos/nextcloud/server/issues/comments/239768684","html_url":"https://github.com/nextcloud/server/pull/840#issuecomment-239768684","issue_url":"https://api.github.com/repos/nextcloud/server/issues/840","id":239768684,"user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"created_at":"2016-08-15T10:01:43Z","updated_at":"2016-08-15T10:01:43Z","body":"@juliushaertl no the point is that right now all icons are serverd by the webserver. No PHP is involved etc.\r\n\r\nWe can easily add proper caching headers. Just let me know if you need help."}}
{"actor":{"display_login":"rullzer"}}