{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59736224","id":59736224,"diff_hunk":"@@ -0,0 +1,1119 @@\n+﻿// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System.Collections;\n+using System.Collections.Generic;\n+using System.Diagnostics;\n+using System.Text;\n+\n+namespace System\n+{\n+    /// <summary>\n+    /// Helper so we can call some tuple methods recursively without knowing the underlying types.\n+    /// </summary>\n+    internal interface ITupleInternal\n+    {\n+        int GetHashCode(IEqualityComparer comparer);\n+        int Size { get; }\n+    }\n+\n+    public struct ValueTuple : IEquatable<ValueTuple>, IStructuralEquatable, IStructuralComparable, IComparable, ITupleInternal","path":"src/System.Tuples/src/System/ValueTuple/ValueTuple.cs","position":21,"original_position":21,"commit_id":"3d24ac781c7ad848c04327c7fc2830c9cc4ab211","original_commit_id":"77248e5e8e55719dedbb07b9322e9c86106b1492","user":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"body":"We should have better docs for these types. I think the dcos should explain who these types differ from the old tuples.","created_at":"2016-04-14T15:17:53Z","updated_at":"2016-04-14T15:17:53Z","html_url":"https://github.com/dotnet/corefx/pull/7663#discussion_r59736224","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7663","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59736224"},"html":{"href":"https://github.com/dotnet/corefx/pull/7663#discussion_r59736224"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7663"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7663","id":66063573,"html_url":"https://github.com/dotnet/corefx/pull/7663","diff_url":"https://github.com/dotnet/corefx/pull/7663.diff","patch_url":"https://github.com/dotnet/corefx/pull/7663.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7663","number":7663,"state":"open","locked":false,"title":"Adding System.Tuples","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"body":"Added the ValueTuple types that we are discussing for C# 7.\r\n\r\nThe code is based off [System.Tuple](http://referencesource.microsoft.com/#mscorlib/system/tuple.cs,9124c4bea9ab0199) and the tests are based off [TupleTests](https://github.com/dotnet/corefx/blob/cd5d2ea3080927b09022adf06745c1876217c3ca/src/System.Runtime/tests/System/Tuple.cs).\r\n\r\nA few open issues left:\r\n- The hash function is rather poor and needs further discussion.\r\n- I removed `[Serializable]` as it doesn't appear anywhere in corefx.\r\n- the solution and project are named after the package that we discussed `System.Tuples`, but should be probably renamed to `System.ValueTuples` when moved to shipping project.\r\n- Pattern matching may not need the `ITuple` interface after all, so I did no include it.\r\n- There is a small difference between `Tuple.ToString` and `ValueTuple.ToString`, where one prints `(1, ..., 7, (8, 9))`, but the latter prints `(1, ..., 7, 8, 9)`.\r\n- I included xml docs only on ValueTuple\\`2. \r\n\r\n@weshaggard for review.\r\n\r\nCC @dotnet/roslyn-compiler @tmat as FYI.","created_at":"2016-04-11T21:14:19Z","updated_at":"2016-04-14T15:17:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63dbe2831aad2ccccd4c41d45fcc3ab959d2f784","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7663/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7663/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7663/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/3d24ac781c7ad848c04327c7fc2830c9cc4ab211","head":{"label":"jcouv:tuples","ref":"tuples","sha":"3d24ac781c7ad848c04327c7fc2830c9cc4ab211","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"repo":{"id":55807182,"name":"corefx","full_name":"jcouv/corefx","owner":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcouv/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/jcouv/corefx","forks_url":"https://api.github.com/repos/jcouv/corefx/forks","keys_url":"https://api.github.com/repos/jcouv/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcouv/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcouv/corefx/teams","hooks_url":"https://api.github.com/repos/jcouv/corefx/hooks","issue_events_url":"https://api.github.com/repos/jcouv/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/jcouv/corefx/events","assignees_url":"https://api.github.com/repos/jcouv/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/jcouv/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/jcouv/corefx/tags","blobs_url":"https://api.github.com/repos/jcouv/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcouv/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcouv/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcouv/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcouv/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/jcouv/corefx/languages","stargazers_url":"https://api.github.com/repos/jcouv/corefx/stargazers","contributors_url":"https://api.github.com/repos/jcouv/corefx/contributors","subscribers_url":"https://api.github.com/repos/jcouv/corefx/subscribers","subscription_url":"https://api.github.com/repos/jcouv/corefx/subscription","commits_url":"https://api.github.com/repos/jcouv/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcouv/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcouv/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcouv/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcouv/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/jcouv/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcouv/corefx/merges","archive_url":"https://api.github.com/repos/jcouv/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcouv/corefx/downloads","issues_url":"https://api.github.com/repos/jcouv/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/jcouv/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/jcouv/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/jcouv/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcouv/corefx/labels{/name}","releases_url":"https://api.github.com/repos/jcouv/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/jcouv/corefx/deployments","created_at":"2016-04-08T20:16:49Z","updated_at":"2016-04-08T20:17:12Z","pushed_at":"2016-04-13T20:24:58Z","git_url":"git://github.com/jcouv/corefx.git","ssh_url":"git@github.com:jcouv/corefx.git","clone_url":"https://github.com/jcouv/corefx.git","svn_url":"https://github.com/jcouv/corefx","homepage":"http://dotnet.github.io/","size":64339,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0039007006b6cb915f56e6bee4f153d4801c65bd","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-14T14:17:21Z","pushed_at":"2016-04-14T14:47:41Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":86729,"stargazers_count":9492,"watchers_count":9492,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2251,"mirror_url":null,"open_issues_count":947,"forks":2251,"open_issues":947,"watchers":9492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7663"},"html":{"href":"https://github.com/dotnet/corefx/pull/7663"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7663"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7663/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7663/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7663/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/3d24ac781c7ad848c04327c7fc2830c9cc4ab211"}}}}