{"action":"closed","number":1731,"pull_request":{"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1731","id":64582203,"html_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731","diff_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731.diff","patch_url":"https://github.com/react-bootstrap/react-bootstrap/pull/1731.patch","issue_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731","number":1731,"state":"closed","locked":false,"title":"fix(ListGroupItem): Allowing for div children to be rendered.","user":{"login":"TheIronDeveloper","id":364028,"avatar_url":"https://avatars.githubusercontent.com/u/364028?v=3","gravatar_id":"","url":"https://api.github.com/users/TheIronDeveloper","html_url":"https://github.com/TheIronDeveloper","followers_url":"https://api.github.com/users/TheIronDeveloper/followers","following_url":"https://api.github.com/users/TheIronDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/TheIronDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/TheIronDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheIronDeveloper/subscriptions","organizations_url":"https://api.github.com/users/TheIronDeveloper/orgs","repos_url":"https://api.github.com/users/TheIronDeveloper/repos","events_url":"https://api.github.com/users/TheIronDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/TheIronDeveloper/received_events","type":"User","site_admin":false},"body":"Attempting to fix https://github.com/react-bootstrap/react-bootstrap/issues/1271\r\n\r\nThis commit updates `ListGroupItem` to allow passing in block-level\r\nelements (like div) by checking the `typeof` the props.children.\r\n\r\nIf its a string, then we'll wrap the content in the existing `<p>`\r\nand render the content the same way as before.\r\n\r\nIf the children is not a string, then simply render out `props.children`\r\nin place of where the `<p>` tag would be.\r\n\r\nExample usage:\r\n\r\n```javascript\r\nlet header = (<div>Header 5</div>);\r\n\r\nconst listgroupInstance = (\r\n  <ListGroup>\r\n    <ListGroupItem header=\"Header 4\"><div>Item 4</div></ListGroupItem>\r\n    <ListGroupItem header={header}><div>Item 5</div></ListGroupItem>\r\n  </ListGroup>\r\n);\r\n```\r\n\r\nwill output something similar to:\r\n\r\n```\r\n<ul class=\"list-group\">\r\n  <li class=\"list-group-item\">\r\n    <h4 class=\"list-group-item-heading\">Header 4</h4>\r\n    <div>Item 4</div>\r\n  </li>\r\n  <li class=\"list-group-item\">\r\n    <div class=\"list-group-item-heading\">Header 5</div>\r\n    <div>Item 5</div>\r\n  </li>\r\n</ul>\r\n```\r\n\r\n<img width=\"881\" alt=\"screen shot 2016-03-30 at 12 13 46 am\" src=\"https://cloud.githubusercontent.com/assets/364028/14134727/ec32b216-f60d-11e5-9180-2c2c34de9b13.png\">\r\n","created_at":"2016-03-30T07:25:09Z","updated_at":"2016-04-01T14:47:13Z","closed_at":"2016-04-01T14:47:13Z","merged_at":null,"merge_commit_sha":"c90517c4653b10df24ec2a953a36d35ef4e133e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1731/commits","review_comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1731/comments","review_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731/comments","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/7c17e996ff26061ffd04be8921a9c70156bae382","head":{"label":"TheIronDeveloper:updateListGroupItemToSupportDivsAndStuff","ref":"updateListGroupItemToSupportDivsAndStuff","sha":"7c17e996ff26061ffd04be8921a9c70156bae382","user":{"login":"TheIronDeveloper","id":364028,"avatar_url":"https://avatars.githubusercontent.com/u/364028?v=3","gravatar_id":"","url":"https://api.github.com/users/TheIronDeveloper","html_url":"https://github.com/TheIronDeveloper","followers_url":"https://api.github.com/users/TheIronDeveloper/followers","following_url":"https://api.github.com/users/TheIronDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/TheIronDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/TheIronDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheIronDeveloper/subscriptions","organizations_url":"https://api.github.com/users/TheIronDeveloper/orgs","repos_url":"https://api.github.com/users/TheIronDeveloper/repos","events_url":"https://api.github.com/users/TheIronDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/TheIronDeveloper/received_events","type":"User","site_admin":false},"repo":{"id":55033708,"name":"react-bootstrap","full_name":"TheIronDeveloper/react-bootstrap","owner":{"login":"TheIronDeveloper","id":364028,"avatar_url":"https://avatars.githubusercontent.com/u/364028?v=3","gravatar_id":"","url":"https://api.github.com/users/TheIronDeveloper","html_url":"https://github.com/TheIronDeveloper","followers_url":"https://api.github.com/users/TheIronDeveloper/followers","following_url":"https://api.github.com/users/TheIronDeveloper/following{/other_user}","gists_url":"https://api.github.com/users/TheIronDeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/TheIronDeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheIronDeveloper/subscriptions","organizations_url":"https://api.github.com/users/TheIronDeveloper/orgs","repos_url":"https://api.github.com/users/TheIronDeveloper/repos","events_url":"https://api.github.com/users/TheIronDeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/TheIronDeveloper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheIronDeveloper/react-bootstrap","description":"Bootstrap 3 components built with React","fork":true,"url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap","forks_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/forks","keys_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/events","assignees_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/merges","archive_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/TheIronDeveloper/react-bootstrap/deployments","created_at":"2016-03-30T04:56:46Z","updated_at":"2016-03-30T04:56:47Z","pushed_at":"2016-04-01T05:28:10Z","git_url":"git://github.com/TheIronDeveloper/react-bootstrap.git","ssh_url":"git@github.com:TheIronDeveloper/react-bootstrap.git","clone_url":"https://github.com/TheIronDeveloper/react-bootstrap.git","svn_url":"https://github.com/TheIronDeveloper/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":4267,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-bootstrap:master","ref":"master","sha":"04fb6094eb19badfa702af45976a30ee1520f159","user":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":15480067,"name":"react-bootstrap","full_name":"react-bootstrap/react-bootstrap","owner":{"login":"react-bootstrap","id":6853419,"avatar_url":"https://avatars.githubusercontent.com/u/6853419?v=3","gravatar_id":"","url":"https://api.github.com/users/react-bootstrap","html_url":"https://github.com/react-bootstrap","followers_url":"https://api.github.com/users/react-bootstrap/followers","following_url":"https://api.github.com/users/react-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/react-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/react-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/react-bootstrap/orgs","repos_url":"https://api.github.com/users/react-bootstrap/repos","events_url":"https://api.github.com/users/react-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/react-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-bootstrap/react-bootstrap","description":"Bootstrap 3 components built with React","fork":false,"url":"https://api.github.com/repos/react-bootstrap/react-bootstrap","forks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/forks","keys_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/teams","hooks_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/events","assignees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/tags","blobs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/languages","stargazers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/subscription","commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/merges","archive_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/downloads","issues_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/react-bootstrap/react-bootstrap/deployments","created_at":"2013-12-27T19:06:07Z","updated_at":"2016-04-01T14:29:58Z","pushed_at":"2016-04-01T14:43:39Z","git_url":"git://github.com/react-bootstrap/react-bootstrap.git","ssh_url":"git@github.com:react-bootstrap/react-bootstrap.git","clone_url":"https://github.com/react-bootstrap/react-bootstrap.git","svn_url":"https://github.com/react-bootstrap/react-bootstrap","homepage":"http://react-bootstrap.github.io/","size":6736,"stargazers_count":5368,"watchers_count":5368,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":881,"mirror_url":null,"open_issues_count":45,"forks":881,"open_issues":45,"watchers":5368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1731"},"html":{"href":"https://github.com/react-bootstrap/react-bootstrap/pull/1731"},"issue":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731"},"comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/issues/1731/comments"},"review_comments":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1731/comments"},"review_comment":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/pulls/1731/commits"},"statuses":{"href":"https://api.github.com/repos/react-bootstrap/react-bootstrap/statuses/7c17e996ff26061ffd04be8921a9c70156bae382"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":31,"deletions":0,"changed_files":3}}