{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/74918404","id":74918404,"diff_hunk":"@@ -37,36 +36,30 @@\n \n     public abstract String getMessage();\n \n+    // TODO(rfink) This needs to get renamed once a wire-break is acceptable.\n     @JsonProperty(\"exceptionClass\")\n-    public abstract String getExceptionClassName();\n-\n-    /**\n-     * @deprecated Use {@link #getExceptionClassName()} instead.\n-     */\n-    @Deprecated\n-    @JsonIgnore\n-    @SuppressWarnings(\"unchecked\")\n-    public final Class<? extends Exception> getExceptionClass() {\n-        try {\n-            return (Class<? extends Exception>) Class.forName(getExceptionClassName());\n-        } catch (ClassNotFoundException e) {\n-            throw new RuntimeException(e);\n-        }\n-    }\n+    public abstract String getExceptionName();\n \n     @Nullable\n     public abstract List<StackTraceElement> getStackTrace();\n \n+    /** Constructs a new error whose exception name is the fully-qualified name of the given class. */\n     public static SerializableError of(String message, Class<? extends Exception> exceptionClass) {","path":"error-handling/src/main/java/com/palantir/remoting1/errors/SerializableError.java","position":35,"original_position":35,"commit_id":"d620e6e9534492bdaf02de0938714cb37e370b24","original_commit_id":"d620e6e9534492bdaf02de0938714cb37e370b24","user":{"login":"markelliot","id":685891,"avatar_url":"https://avatars.githubusercontent.com/u/685891?v=3","gravatar_id":"","url":"https://api.github.com/users/markelliot","html_url":"https://github.com/markelliot","followers_url":"https://api.github.com/users/markelliot/followers","following_url":"https://api.github.com/users/markelliot/following{/other_user}","gists_url":"https://api.github.com/users/markelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/markelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelliot/subscriptions","organizations_url":"https://api.github.com/users/markelliot/orgs","repos_url":"https://api.github.com/users/markelliot/repos","events_url":"https://api.github.com/users/markelliot/events{/privacy}","received_events_url":"https://api.github.com/users/markelliot/received_events","type":"User","site_admin":false},"body":"Should we change the class parameter to be a string?","created_at":"2016-08-16T11:38:13Z","updated_at":"2016-08-16T11:38:13Z","html_url":"https://github.com/palantir/http-remoting/pull/199#discussion_r74918404","pull_request_url":"https://api.github.com/repos/palantir/http-remoting/pulls/199","_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/74918404"},"html":{"href":"https://github.com/palantir/http-remoting/pull/199#discussion_r74918404"},"pull_request":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/199"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/199","id":81230650,"html_url":"https://github.com/palantir/http-remoting/pull/199","diff_url":"https://github.com/palantir/http-remoting/pull/199.diff","patch_url":"https://github.com/palantir/http-remoting/pull/199.patch","issue_url":"https://api.github.com/repos/palantir/http-remoting/issues/199","number":199,"state":"open","locked":false,"title":"SerializableErrorToExceptionConverter produces RemoteException instea…","user":{"login":"uschi2000","id":6528449,"avatar_url":"https://avatars.githubusercontent.com/u/6528449?v=3","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"body":"…d of rs.ws exception","created_at":"2016-08-14T00:37:25Z","updated_at":"2016-08-16T11:38:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d9e30ec878448ed2be92ba4d83deef50de99e5e","assignee":{"login":"markelliot","id":685891,"avatar_url":"https://avatars.githubusercontent.com/u/685891?v=3","gravatar_id":"","url":"https://api.github.com/users/markelliot","html_url":"https://github.com/markelliot","followers_url":"https://api.github.com/users/markelliot/followers","following_url":"https://api.github.com/users/markelliot/following{/other_user}","gists_url":"https://api.github.com/users/markelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/markelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelliot/subscriptions","organizations_url":"https://api.github.com/users/markelliot/orgs","repos_url":"https://api.github.com/users/markelliot/repos","events_url":"https://api.github.com/users/markelliot/events{/privacy}","received_events_url":"https://api.github.com/users/markelliot/received_events","type":"User","site_admin":false},"assignees":[{"login":"markelliot","id":685891,"avatar_url":"https://avatars.githubusercontent.com/u/685891?v=3","gravatar_id":"","url":"https://api.github.com/users/markelliot","html_url":"https://github.com/markelliot","followers_url":"https://api.github.com/users/markelliot/followers","following_url":"https://api.github.com/users/markelliot/following{/other_user}","gists_url":"https://api.github.com/users/markelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/markelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markelliot/subscriptions","organizations_url":"https://api.github.com/users/markelliot/orgs","repos_url":"https://api.github.com/users/markelliot/repos","events_url":"https://api.github.com/users/markelliot/events{/privacy}","received_events_url":"https://api.github.com/users/markelliot/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/http-remoting/pulls/199/commits","review_comments_url":"https://api.github.com/repos/palantir/http-remoting/pulls/199/comments","review_comment_url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/http-remoting/issues/199/comments","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/d620e6e9534492bdaf02de0938714cb37e370b24","head":{"label":"palantir:rfink/exceptions","ref":"rfink/exceptions","sha":"d620e6e9534492bdaf02de0938714cb37e370b24","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":43088077,"name":"http-remoting","full_name":"palantir/http-remoting","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/http-remoting","description":"a collection of useful utilities for use with HTTP remoting setups that use Feign as a client and Jersey as a server","fork":false,"url":"https://api.github.com/repos/palantir/http-remoting","forks_url":"https://api.github.com/repos/palantir/http-remoting/forks","keys_url":"https://api.github.com/repos/palantir/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/http-remoting/teams","hooks_url":"https://api.github.com/repos/palantir/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/palantir/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/http-remoting/events","assignees_url":"https://api.github.com/repos/palantir/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/http-remoting/tags","blobs_url":"https://api.github.com/repos/palantir/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/http-remoting/languages","stargazers_url":"https://api.github.com/repos/palantir/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/palantir/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/palantir/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/palantir/http-remoting/subscription","commits_url":"https://api.github.com/repos/palantir/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/http-remoting/merges","archive_url":"https://api.github.com/repos/palantir/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/http-remoting/downloads","issues_url":"https://api.github.com/repos/palantir/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/palantir/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/http-remoting/deployments","created_at":"2015-09-24T19:24:22Z","updated_at":"2016-07-25T09:28:49Z","pushed_at":"2016-08-16T01:59:58Z","git_url":"git://github.com/palantir/http-remoting.git","ssh_url":"git@github.com:palantir/http-remoting.git","clone_url":"https://github.com/palantir/http-remoting.git","svn_url":"https://github.com/palantir/http-remoting","homepage":"","size":1124,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":17,"forks":27,"open_issues":17,"watchers":16,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"aa43bb58580fba5f2a96c8f31cacb8dac6007e4b","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":43088077,"name":"http-remoting","full_name":"palantir/http-remoting","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/http-remoting","description":"a collection of useful utilities for use with HTTP remoting setups that use Feign as a client and Jersey as a server","fork":false,"url":"https://api.github.com/repos/palantir/http-remoting","forks_url":"https://api.github.com/repos/palantir/http-remoting/forks","keys_url":"https://api.github.com/repos/palantir/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/http-remoting/teams","hooks_url":"https://api.github.com/repos/palantir/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/palantir/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/http-remoting/events","assignees_url":"https://api.github.com/repos/palantir/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/http-remoting/tags","blobs_url":"https://api.github.com/repos/palantir/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/http-remoting/languages","stargazers_url":"https://api.github.com/repos/palantir/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/palantir/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/palantir/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/palantir/http-remoting/subscription","commits_url":"https://api.github.com/repos/palantir/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/http-remoting/merges","archive_url":"https://api.github.com/repos/palantir/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/http-remoting/downloads","issues_url":"https://api.github.com/repos/palantir/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/palantir/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/http-remoting/deployments","created_at":"2015-09-24T19:24:22Z","updated_at":"2016-07-25T09:28:49Z","pushed_at":"2016-08-16T01:59:58Z","git_url":"git://github.com/palantir/http-remoting.git","ssh_url":"git@github.com:palantir/http-remoting.git","clone_url":"https://github.com/palantir/http-remoting.git","svn_url":"https://github.com/palantir/http-remoting","homepage":"","size":1124,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":17,"forks":27,"open_issues":17,"watchers":16,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/199"},"html":{"href":"https://github.com/palantir/http-remoting/pull/199"},"issue":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/199"},"comments":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/http-remoting/statuses/d620e6e9534492bdaf02de0938714cb37e370b24"}}}}
{"actor":{"display_login":"markelliot"}}