{"action":"created","comment":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/52231079","id":52231079,"diff_hunk":"@@ -89,8 +90,13 @@ public boolean processRow( StepMetaInterface smi, StepDataInterface sdi ) throws\n     if ( first ) {\n \n       first = false;\n-      data.outputRowMeta = getInputRowMeta().clone();\n-      data.inputRowMeta = getInputRowMeta().clone();\n+      if ( r == null ) {","path":"engine/src/org/pentaho/di/trans/steps/excelwriter/ExcelWriterStep.java","position":14,"original_position":14,"commit_id":"f5373e0fe7db78e33b5850ddd0200068a064b05d","original_commit_id":"f5373e0fe7db78e33b5850ddd0200068a064b05d","user":{"login":"matthewtckr","id":5630210,"avatar_url":"https://avatars.githubusercontent.com/u/5630210?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewtckr","html_url":"https://github.com/matthewtckr","followers_url":"https://api.github.com/users/matthewtckr/followers","following_url":"https://api.github.com/users/matthewtckr/following{/other_user}","gists_url":"https://api.github.com/users/matthewtckr/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewtckr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewtckr/subscriptions","organizations_url":"https://api.github.com/users/matthewtckr/orgs","repos_url":"https://api.github.com/users/matthewtckr/repos","events_url":"https://api.github.com/users/matthewtckr/events{/privacy}","received_events_url":"https://api.github.com/users/matthewtckr/received_events","type":"User","site_admin":false},"body":"I would agree for most other steps, but there is some functionality that would allow for an \"empty\" (only header row) file to be created, even if no data rows are received by the step.\r\n\r\nBy placing this here, instead, it will allow the empty file to be created, if configured, and then drop down to line 197/203 to close out the file.\r\n\r\nThere's still an integration test needed for this use-case, which I'll add shortly.","created_at":"2016-02-08T21:48:20Z","updated_at":"2016-02-08T21:48:20Z","html_url":"https://github.com/pentaho/pentaho-kettle/pull/2135#discussion_r52231079","pull_request_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135","_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments/52231079"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/2135#discussion_r52231079"},"pull_request":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135"}}},"pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135","id":58438167,"html_url":"https://github.com/pentaho/pentaho-kettle/pull/2135","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/2135.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/2135.patch","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2135","number":2135,"state":"open","locked":false,"title":"[PDI-14854] Excel Writer NPE when no rows","user":{"login":"matthewtckr","id":5630210,"avatar_url":"https://avatars.githubusercontent.com/u/5630210?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewtckr","html_url":"https://github.com/matthewtckr","followers_url":"https://api.github.com/users/matthewtckr/followers","following_url":"https://api.github.com/users/matthewtckr/following{/other_user}","gists_url":"https://api.github.com/users/matthewtckr/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewtckr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewtckr/subscriptions","organizations_url":"https://api.github.com/users/matthewtckr/orgs","repos_url":"https://api.github.com/users/matthewtckr/repos","events_url":"https://api.github.com/users/matthewtckr/events{/privacy}","received_events_url":"https://api.github.com/users/matthewtckr/received_events","type":"User","site_admin":false},"body":"Generate an empty RowMeta, as some settings require an empty file be created before finishing.","created_at":"2016-02-05T14:53:38Z","updated_at":"2016-02-08T21:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26c81bec2270efb51369ae6b4dd67fb72c417e75","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135/commits","review_comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135/comments","review_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2135/comments","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/f5373e0fe7db78e33b5850ddd0200068a064b05d","head":{"label":"matthewtckr:PDI-14854","ref":"PDI-14854","sha":"f5373e0fe7db78e33b5850ddd0200068a064b05d","user":{"login":"matthewtckr","id":5630210,"avatar_url":"https://avatars.githubusercontent.com/u/5630210?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewtckr","html_url":"https://github.com/matthewtckr","followers_url":"https://api.github.com/users/matthewtckr/followers","following_url":"https://api.github.com/users/matthewtckr/following{/other_user}","gists_url":"https://api.github.com/users/matthewtckr/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewtckr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewtckr/subscriptions","organizations_url":"https://api.github.com/users/matthewtckr/orgs","repos_url":"https://api.github.com/users/matthewtckr/repos","events_url":"https://api.github.com/users/matthewtckr/events{/privacy}","received_events_url":"https://api.github.com/users/matthewtckr/received_events","type":"User","site_admin":false},"repo":{"id":21700661,"name":"pentaho-kettle","full_name":"matthewtckr/pentaho-kettle","owner":{"login":"matthewtckr","id":5630210,"avatar_url":"https://avatars.githubusercontent.com/u/5630210?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewtckr","html_url":"https://github.com/matthewtckr","followers_url":"https://api.github.com/users/matthewtckr/followers","following_url":"https://api.github.com/users/matthewtckr/following{/other_user}","gists_url":"https://api.github.com/users/matthewtckr/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewtckr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewtckr/subscriptions","organizations_url":"https://api.github.com/users/matthewtckr/orgs","repos_url":"https://api.github.com/users/matthewtckr/repos","events_url":"https://api.github.com/users/matthewtckr/events{/privacy}","received_events_url":"https://api.github.com/users/matthewtckr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewtckr/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":true,"url":"https://api.github.com/repos/matthewtckr/pentaho-kettle","forks_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/matthewtckr/pentaho-kettle/deployments","created_at":"2014-07-10T16:02:30Z","updated_at":"2016-01-21T14:18:33Z","pushed_at":"2016-02-08T21:44:40Z","git_url":"git://github.com/matthewtckr/pentaho-kettle.git","ssh_url":"git@github.com:matthewtckr/pentaho-kettle.git","clone_url":"https://github.com/matthewtckr/pentaho-kettle.git","svn_url":"https://github.com/matthewtckr/pentaho-kettle","homepage":null,"size":493132,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pentaho:master","ref":"master","sha":"ccdbd953f350dac80ba1b5cc4930e4d3c3835a64","user":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"repo":{"id":13421878,"name":"pentaho-kettle","full_name":"pentaho/pentaho-kettle","owner":{"login":"pentaho","id":1022787,"avatar_url":"https://avatars.githubusercontent.com/u/1022787?v=3","gravatar_id":"","url":"https://api.github.com/users/pentaho","html_url":"https://github.com/pentaho","followers_url":"https://api.github.com/users/pentaho/followers","following_url":"https://api.github.com/users/pentaho/following{/other_user}","gists_url":"https://api.github.com/users/pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pentaho/subscriptions","organizations_url":"https://api.github.com/users/pentaho/orgs","repos_url":"https://api.github.com/users/pentaho/repos","events_url":"https://api.github.com/users/pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/pentaho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pentaho/pentaho-kettle","description":"Pentaho Data Integration ( ETL ) a.k.a Kettle","fork":false,"url":"https://api.github.com/repos/pentaho/pentaho-kettle","forks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/forks","keys_url":"https://api.github.com/repos/pentaho/pentaho-kettle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pentaho/pentaho-kettle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pentaho/pentaho-kettle/teams","hooks_url":"https://api.github.com/repos/pentaho/pentaho-kettle/hooks","issue_events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/events{/number}","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/events","assignees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/assignees{/user}","branches_url":"https://api.github.com/repos/pentaho/pentaho-kettle/branches{/branch}","tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/tags","blobs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/refs{/sha}","trees_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/{sha}","languages_url":"https://api.github.com/repos/pentaho/pentaho-kettle/languages","stargazers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/stargazers","contributors_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contributors","subscribers_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscribers","subscription_url":"https://api.github.com/repos/pentaho/pentaho-kettle/subscription","commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/commits{/sha}","git_commits_url":"https://api.github.com/repos/pentaho/pentaho-kettle/git/commits{/sha}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/comments{/number}","issue_comment_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments{/number}","contents_url":"https://api.github.com/repos/pentaho/pentaho-kettle/contents/{+path}","compare_url":"https://api.github.com/repos/pentaho/pentaho-kettle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pentaho/pentaho-kettle/merges","archive_url":"https://api.github.com/repos/pentaho/pentaho-kettle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pentaho/pentaho-kettle/downloads","issues_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues{/number}","pulls_url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls{/number}","milestones_url":"https://api.github.com/repos/pentaho/pentaho-kettle/milestones{/number}","notifications_url":"https://api.github.com/repos/pentaho/pentaho-kettle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/labels{/name}","releases_url":"https://api.github.com/repos/pentaho/pentaho-kettle/releases{/id}","deployments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/deployments","created_at":"2013-10-08T18:27:11Z","updated_at":"2016-02-08T09:45:54Z","pushed_at":"2016-02-08T21:44:20Z","git_url":"git://github.com/pentaho/pentaho-kettle.git","ssh_url":"git@github.com:pentaho/pentaho-kettle.git","clone_url":"https://github.com/pentaho/pentaho-kettle.git","svn_url":"https://github.com/pentaho/pentaho-kettle","homepage":null,"size":501344,"stargazers_count":450,"watchers_count":450,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":542,"mirror_url":null,"open_issues_count":37,"forks":542,"open_issues":37,"watchers":450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135"},"html":{"href":"https://github.com/pentaho/pentaho-kettle/pull/2135"},"issue":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2135"},"comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/2135/comments"},"review_comments":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135/comments"},"review_comment":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/2135/commits"},"statuses":{"href":"https://api.github.com/repos/pentaho/pentaho-kettle/statuses/f5373e0fe7db78e33b5850ddd0200068a064b05d"}}}}