{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/63027414","id":63027414,"diff_hunk":"@@ -592,6 +596,25 @@ FileSprayer::FileSprayer(IPropertyTree * _options, IPropertyTree * _progress, IR\n     encryptKey.set(options->queryProp(ANencryptKey));\n     decryptKey.set(options->queryProp(ANdecryptKey));\n \n+    fileUmask = -1;\n+    if (options->hasProp(ANumask))\n+    {\n+        StringBuffer umaskStr;\n+        options->getProp(ANumask, umaskStr);\n+        char *eptr = '\\0';","path":"dali/ft/filecopy.cpp","position":null,"original_position":27,"commit_id":"66f54515adf441f58b22ce1b98c51035e8ee1c29","original_commit_id":"f6ba59772ec88aa88a3c51de2df5bfb2ce54bbe3","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"body":"I used nullptr.  I do not think \"\" is allowed ?","created_at":"2016-05-12T14:14:42Z","updated_at":"2016-05-12T14:14:42Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8625#discussion_r63027414","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/63027414"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8625#discussion_r63027414"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625","id":69387298,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8625","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8625.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8625.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8625","number":8625,"state":"open","locked":false,"title":"HPCC-15516 Despray umask pull method support","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"body":"Pull method of despray now supports umask DZ parameter.\r\n\r\nI modified ws_fsService.cpp so that for 5.6 where multiple DZ are not really supported it will now at least use the umask parameter found in the env.xml for the first DZ so that if you have more than one DZ and you use the same umask for all it will be honored (this is not in 6.0.0 because multiple DZs are properly supported).\r\n\r\n@AttilaVamos , @wangkx please review thoroughly\r\n\r\nNOTE: very similar to: https://github.com/hpcc-systems/HPCC-Platform/pull/8626 for 6.0.0\r\n\r\nSigned-off-by: Mark Kelly <mark.kelly@lexisnexis.com>\r\n","created_at":"2016-05-09T18:17:28Z","updated_at":"2016-05-12T14:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c12c0d844c5d8e2185a1a2bb5bca11e5aa99ed9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8625/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/66f54515adf441f58b22ce1b98c51035e8ee1c29","head":{"label":"mckellyln:hpcc-15516","ref":"hpcc-15516","sha":"66f54515adf441f58b22ce1b98c51035e8ee1c29","user":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"repo":{"id":12089496,"name":"HPCC-Platform","full_name":"mckellyln/HPCC-Platform","owner":{"login":"mckellyln","id":5116200,"avatar_url":"https://avatars.githubusercontent.com/u/5116200?v=3","gravatar_id":"","url":"https://api.github.com/users/mckellyln","html_url":"https://github.com/mckellyln","followers_url":"https://api.github.com/users/mckellyln/followers","following_url":"https://api.github.com/users/mckellyln/following{/other_user}","gists_url":"https://api.github.com/users/mckellyln/gists{/gist_id}","starred_url":"https://api.github.com/users/mckellyln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mckellyln/subscriptions","organizations_url":"https://api.github.com/users/mckellyln/orgs","repos_url":"https://api.github.com/users/mckellyln/repos","events_url":"https://api.github.com/users/mckellyln/events{/privacy}","received_events_url":"https://api.github.com/users/mckellyln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mckellyln/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/mckellyln/HPCC-Platform","forks_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/mckellyln/HPCC-Platform/deployments","created_at":"2013-08-13T18:39:30Z","updated_at":"2015-05-06T15:40:27Z","pushed_at":"2016-05-12T14:12:56Z","git_url":"git://github.com/mckellyln/HPCC-Platform.git","ssh_url":"git@github.com:mckellyln/HPCC-Platform.git","clone_url":"https://github.com/mckellyln/HPCC-Platform.git","svn_url":"https://github.com/mckellyln/HPCC-Platform","homepage":"track.hpccsystems.com","size":164998,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-5.6.4","ref":"candidate-5.6.4","sha":"29610852a07751ecf7acb96e2da1c927cb530b92","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-04-26T14:13:36Z","pushed_at":"2016-05-12T14:12:58Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":195569,"stargazers_count":275,"watchers_count":275,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":422,"forks":144,"open_issues":422,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8625"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8625"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8625/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8625/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/66f54515adf441f58b22ce1b98c51035e8ee1c29"}}}}