{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/californium/pulls/comments/52020263","id":52020263,"diff_hunk":"@@ -1289,13 +1315,21 @@ private void handleTimeout(DTLSFlight flight) {\n \t\t\tLOGGER.log(Level.FINE, \"Re-transmitting flight for [{0}], [{1}] retransmissions left\",\n \t\t\t\t\tnew Object[]{flight.getPeerAddress(), max - flight.getTries() - 1});\n \n-\t\t\tflight.incrementTries();\n-\t\t\tsendFlight(flight);\n+\t\t\ttry {\n+\t\t\t\tflight.incrementTries();\n+\t\t\t\tflight.setNewSequenceNumbers();","path":"scandium-core/src/main/java/org/eclipse/californium/scandium/DTLSConnector.java","position":317,"original_position":317,"commit_id":"db5a539c9310f5eb724ccbfeee662b3483e1d1a9","original_commit_id":"db5a539c9310f5eb724ccbfeee662b3483e1d1a9","user":{"login":"sbernard31","id":840294,"avatar_url":"https://avatars.githubusercontent.com/u/840294?v=3","gravatar_id":"","url":"https://api.github.com/users/sbernard31","html_url":"https://github.com/sbernard31","followers_url":"https://api.github.com/users/sbernard31/followers","following_url":"https://api.github.com/users/sbernard31/following{/other_user}","gists_url":"https://api.github.com/users/sbernard31/gists{/gist_id}","starred_url":"https://api.github.com/users/sbernard31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbernard31/subscriptions","organizations_url":"https://api.github.com/users/sbernard31/orgs","repos_url":"https://api.github.com/users/sbernard31/repos","events_url":"https://api.github.com/users/sbernard31/events{/privacy}","received_events_url":"https://api.github.com/users/sbernard31/received_events","type":"User","site_admin":false},"body":"I 'm not sure we must increment sequence numbers on retransmission ?\r\nDoes we do that before ?\r\n","created_at":"2016-02-05T14:21:05Z","updated_at":"2016-02-05T14:21:05Z","html_url":"https://github.com/eclipse/californium/pull/7#discussion_r52020263","pull_request_url":"https://api.github.com/repos/eclipse/californium/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments/52020263"},"html":{"href":"https://github.com/eclipse/californium/pull/7#discussion_r52020263"},"pull_request":{"href":"https://api.github.com/repos/eclipse/californium/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/californium/pulls/7","id":58141368,"html_url":"https://github.com/eclipse/californium/pull/7","diff_url":"https://github.com/eclipse/californium/pull/7.diff","patch_url":"https://github.com/eclipse/californium/pull/7.patch","issue_url":"https://api.github.com/repos/eclipse/californium/issues/7","number":7,"state":"open","locked":false,"title":"Use SessionListener to trigger sending of pending APPLICATION messages.","user":{"login":"sophokles73","id":5682135,"avatar_url":"https://avatars.githubusercontent.com/u/5682135?v=3","gravatar_id":"","url":"https://api.github.com/users/sophokles73","html_url":"https://github.com/sophokles73","followers_url":"https://api.github.com/users/sophokles73/followers","following_url":"https://api.github.com/users/sophokles73/following{/other_user}","gists_url":"https://api.github.com/users/sophokles73/gists{/gist_id}","starred_url":"https://api.github.com/users/sophokles73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophokles73/subscriptions","organizations_url":"https://api.github.com/users/sophokles73/orgs","repos_url":"https://api.github.com/users/sophokles73/repos","events_url":"https://api.github.com/users/sophokles73/events{/privacy}","received_events_url":"https://api.github.com/users/sophokles73/received_events","type":"User","site_admin":false},"body":"Sending an APPLICATION message to a peer for which no DTLS session\r\nexists yet triggers a new handshake with the peer. Previously it was the\r\nresponsibility of the `Handshaker` class to send the (pending) APPLICATION layer\r\nmessage to the peer once the handshake has been completed.\r\n\r\nHandshakers signal the establishment of a session by means of the\r\n`SessionLifecycle.sessionEstablished()` callback method. In order to\r\nimprove separation of concerns pending APPLICATION layer messages are\r\nnow sent by the `DTLSConnector` on invocation of this callback method.\r\n\r\nThis PR is the first step towards fixing #1 in that it hands back control over the message sending to `DTLSConnector`. The approach to fixing #1 then is to include a callback handler in the `RawData` instance passed in to `DTLSConnector.send(RawData)` which will be called back with the *ID*, *epoch* and *cipher* of the `DTLSSession` used for sending the message to the peer.","created_at":"2016-02-03T14:07:46Z","updated_at":"2016-02-05T14:21:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84e6c4bd2ebcabaf51fcbe5eaf7cce0f25ee218b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/californium/pulls/7/commits","review_comments_url":"https://api.github.com/repos/eclipse/californium/pulls/7/comments","review_comment_url":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/californium/issues/7/comments","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/db5a539c9310f5eb724ccbfeee662b3483e1d1a9","head":{"label":"eclipse:introduce_record_layer","ref":"introduce_record_layer","sha":"db5a539c9310f5eb724ccbfeee662b3483e1d1a9","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":43075480,"name":"californium","full_name":"eclipse/californium","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/californium","description":"","fork":false,"url":"https://api.github.com/repos/eclipse/californium","forks_url":"https://api.github.com/repos/eclipse/californium/forks","keys_url":"https://api.github.com/repos/eclipse/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/californium/teams","hooks_url":"https://api.github.com/repos/eclipse/californium/hooks","issue_events_url":"https://api.github.com/repos/eclipse/californium/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/californium/events","assignees_url":"https://api.github.com/repos/eclipse/californium/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/californium/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/californium/tags","blobs_url":"https://api.github.com/repos/eclipse/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/californium/languages","stargazers_url":"https://api.github.com/repos/eclipse/californium/stargazers","contributors_url":"https://api.github.com/repos/eclipse/californium/contributors","subscribers_url":"https://api.github.com/repos/eclipse/californium/subscribers","subscription_url":"https://api.github.com/repos/eclipse/californium/subscription","commits_url":"https://api.github.com/repos/eclipse/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/californium/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/californium/merges","archive_url":"https://api.github.com/repos/eclipse/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/californium/downloads","issues_url":"https://api.github.com/repos/eclipse/californium/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/californium/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/californium/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/californium/deployments","created_at":"2015-09-24T15:27:15Z","updated_at":"2016-02-02T16:10:09Z","pushed_at":"2016-02-05T12:19:10Z","git_url":"git://github.com/eclipse/californium.git","ssh_url":"git@github.com:eclipse/californium.git","clone_url":"https://github.com/eclipse/californium.git","svn_url":"https://github.com/eclipse/californium","homepage":null,"size":2801,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":22,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d81a5aee7ebac60991358d4238f14280e9ee8dd2","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":43075480,"name":"californium","full_name":"eclipse/californium","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/californium","description":"","fork":false,"url":"https://api.github.com/repos/eclipse/californium","forks_url":"https://api.github.com/repos/eclipse/californium/forks","keys_url":"https://api.github.com/repos/eclipse/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/californium/teams","hooks_url":"https://api.github.com/repos/eclipse/californium/hooks","issue_events_url":"https://api.github.com/repos/eclipse/californium/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/californium/events","assignees_url":"https://api.github.com/repos/eclipse/californium/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/californium/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/californium/tags","blobs_url":"https://api.github.com/repos/eclipse/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/californium/languages","stargazers_url":"https://api.github.com/repos/eclipse/californium/stargazers","contributors_url":"https://api.github.com/repos/eclipse/californium/contributors","subscribers_url":"https://api.github.com/repos/eclipse/californium/subscribers","subscription_url":"https://api.github.com/repos/eclipse/californium/subscription","commits_url":"https://api.github.com/repos/eclipse/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/californium/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/californium/merges","archive_url":"https://api.github.com/repos/eclipse/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/californium/downloads","issues_url":"https://api.github.com/repos/eclipse/californium/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/californium/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/californium/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/californium/deployments","created_at":"2015-09-24T15:27:15Z","updated_at":"2016-02-02T16:10:09Z","pushed_at":"2016-02-05T12:19:10Z","git_url":"git://github.com/eclipse/californium.git","ssh_url":"git@github.com:eclipse/californium.git","clone_url":"https://github.com/eclipse/californium.git","svn_url":"https://github.com/eclipse/californium","homepage":null,"size":2801,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":6,"forks":13,"open_issues":6,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/7"},"html":{"href":"https://github.com/eclipse/californium/pull/7"},"issue":{"href":"https://api.github.com/repos/eclipse/californium/issues/7"},"comments":{"href":"https://api.github.com/repos/eclipse/californium/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/californium/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/californium/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/californium/statuses/db5a539c9310f5eb724ccbfeee662b3483e1d1a9"}}}}