{"action":"created","issue":{"url":"https://api.github.com/repos/HiSPARC/sapphire/issues/60","repository_url":"https://api.github.com/repos/HiSPARC/sapphire","labels_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/60/comments","events_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/60/events","html_url":"https://github.com/HiSPARC/sapphire/pull/60","id":71569072,"number":60,"title":"Refactor groundparticles gamma","user":{"login":"tomkooij","id":6316468,"avatar_url":"https://avatars.githubusercontent.com/u/6316468?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkooij","html_url":"https://github.com/tomkooij","followers_url":"https://api.github.com/users/tomkooij/followers","following_url":"https://api.github.com/users/tomkooij/following{/other_user}","gists_url":"https://api.github.com/users/tomkooij/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkooij/subscriptions","organizations_url":"https://api.github.com/users/tomkooij/orgs","repos_url":"https://api.github.com/users/tomkooij/repos","events_url":"https://api.github.com/users/tomkooij/events{/privacy}","received_events_url":"https://api.github.com/users/tomkooij/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tomkooij","id":6316468,"avatar_url":"https://avatars.githubusercontent.com/u/6316468?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkooij","html_url":"https://github.com/tomkooij","followers_url":"https://api.github.com/users/tomkooij/followers","following_url":"https://api.github.com/users/tomkooij/following{/other_user}","gists_url":"https://api.github.com/users/tomkooij/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkooij/subscriptions","organizations_url":"https://api.github.com/users/tomkooij/orgs","repos_url":"https://api.github.com/users/tomkooij/repos","events_url":"https://api.github.com/users/tomkooij/events{/privacy}","received_events_url":"https://api.github.com/users/tomkooij/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-04-28T12:01:01Z","updated_at":"2016-05-11T13:37:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HiSPARC/sapphire/pulls/60","html_url":"https://github.com/HiSPARC/sapphire/pull/60","diff_url":"https://github.com/HiSPARC/sapphire/pull/60.diff","patch_url":"https://github.com/HiSPARC/sapphire/pull/60.patch"},"body":"Refactored code for detector response to gamma's\r\n\r\nTodo (from old code):\r\n- [x] implement additional query for gamma (particle_id==1) in GroundParticlesSimulation.get_particles_in_detector \r\n- [x] implement simulate_detector_mips_for_gammas() in  GroundParticlesSimulation()\r\n- [x] add simulate_detector_mips_gamma() to HiSparcSimulation() detector.py\r\n    - [x] Insert detection (digitisation) algorithm for Compton scattering\r\n          - [x] cross section (interaction depth based on mean free path)\r\n          - [x] energy transfer -> n_mip\r\n          - [x] add angle of incidence theta\r\n          - [x] add/investigate difference between single float and np.array\r\n    - [x] ... for pair creation \r\n\r\nRefactored code todo:\r\n- [x] delete old branch groundparticles_gamma\r\n- [x] added separate class GroundParcticleSimulationGamma() \r\n- [x] compare GroundParticlesSimulation() and GroundParticlesGammaSimulation()\r\n- [ ] check digitisation algorithm and implementation\r\n    - [x] check detection probability for compton scattering\r\n    - [x] check detection probability for pair production\r\n    - [ ] check energy transfer for compton scattering\r\n    - [x] check energy transfer for pair production\r\n- [ ] add unittests\r\n- [x] PEP8\r\n\r\n\r\n- [x] remove numpy.compress from GroundParticlesGammaSimulation.get_particles_in_detector() https://github.com/HiSPARC/sapphire/blob/refactor_groundparticles_gamma/sapphire/simulations/groundparticles.py#L322\r\n- [x] document  _pair_mean_free_path(Energy): from XCOM2"},"comment":{"url":"https://api.github.com/repos/HiSPARC/sapphire/issues/comments/218461171","html_url":"https://github.com/HiSPARC/sapphire/pull/60#issuecomment-218461171","issue_url":"https://api.github.com/repos/HiSPARC/sapphire/issues/60","id":218461171,"user":{"login":"tomkooij","id":6316468,"avatar_url":"https://avatars.githubusercontent.com/u/6316468?v=3","gravatar_id":"","url":"https://api.github.com/users/tomkooij","html_url":"https://github.com/tomkooij","followers_url":"https://api.github.com/users/tomkooij/followers","following_url":"https://api.github.com/users/tomkooij/following{/other_user}","gists_url":"https://api.github.com/users/tomkooij/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkooij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkooij/subscriptions","organizations_url":"https://api.github.com/users/tomkooij/orgs","repos_url":"https://api.github.com/users/tomkooij/repos","events_url":"https://api.github.com/users/tomkooij/events{/privacy}","received_events_url":"https://api.github.com/users/tomkooij/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T13:37:17Z","updated_at":"2016-05-11T13:37:17Z","body":"The energy transfer from compton scattering is a \"magic\" table right now. I (still) need to replace that with the algorithm that created the table.\r\n\r\nThat is (only slightly) slower but easier to maintain and much easier to debug/verify."}}