{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/12136","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/12136/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/12136/comments","events_url":"https://api.github.com/repos/servo/servo/issues/12136/events","html_url":"https://github.com/servo/servo/pull/12136","id":163477259,"number":12136,"title":"Send servo version in mozbrowser error.","user":{"login":"ConnorGBrewster","id":9086315,"avatar_url":"https://avatars.githubusercontent.com/u/9086315?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorGBrewster","html_url":"https://github.com/ConnorGBrewster","followers_url":"https://api.github.com/users/ConnorGBrewster/followers","following_url":"https://api.github.com/users/ConnorGBrewster/following{/other_user}","gists_url":"https://api.github.com/users/ConnorGBrewster/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorGBrewster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorGBrewster/subscriptions","organizations_url":"https://api.github.com/users/ConnorGBrewster/orgs","repos_url":"https://api.github.com/users/ConnorGBrewster/repos","events_url":"https://api.github.com/users/ConnorGBrewster/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorGBrewster/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"assignees":[{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-07-01T21:29:52Z","updated_at":"2016-07-01T23:16:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/12136","html_url":"https://github.com/servo/servo/pull/12136","diff_url":"https://github.com/servo/servo/pull/12136.diff","patch_url":"https://github.com/servo/servo/pull/12136.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\nAdds support for sending a version string to b.html so we can put the servo version in the auto generated issue reports.\r\n\r\nr? @asajeffrey \r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #12083 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [X] These changes do not require tests because sending servo version on mozbrwosererror for issue reporter.\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12136)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/230066517","html_url":"https://github.com/servo/servo/pull/12136#issuecomment-230066517","issue_url":"https://api.github.com/repos/servo/servo/issues/12136","id":230066517,"user":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T23:16:40Z","updated_at":"2016-07-01T23:16:40Z","body":"It would be nice if we could use the user agent string for this, as it's a more standardized representation of the user string. Unfortunately, the version in util/opts.rs is hardwired to be be `Servo/1.0`. Apart from that, this looks fine. I'll ask on irc if people are OK with including the real version number in the UA string.\n\n---\n\nReviewed 1 of 3 files at r1, 3 of 3 files at r3.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/12136#-:-KLcjGlLA0NqoZz7WT_J:-1882344763)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"asajeffrey"}}