{"action":"created","issue":{"url":"https://api.github.com/repos/jarthod/survey-gizmo-ruby/issues/90","repository_url":"https://api.github.com/repos/jarthod/survey-gizmo-ruby","labels_url":"https://api.github.com/repos/jarthod/survey-gizmo-ruby/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/jarthod/survey-gizmo-ruby/issues/90/comments","events_url":"https://api.github.com/repos/jarthod/survey-gizmo-ruby/issues/90/events","html_url":"https://github.com/jarthod/survey-gizmo-ruby/issues/90","id":194295250,"number":90,"title":"Masking of api tokens","user":{"login":"mkaydev","id":1174468,"avatar_url":"https://avatars.githubusercontent.com/u/1174468?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaydev","html_url":"https://github.com/mkaydev","followers_url":"https://api.github.com/users/mkaydev/followers","following_url":"https://api.github.com/users/mkaydev/following{/other_user}","gists_url":"https://api.github.com/users/mkaydev/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaydev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaydev/subscriptions","organizations_url":"https://api.github.com/users/mkaydev/orgs","repos_url":"https://api.github.com/users/mkaydev/repos","events_url":"https://api.github.com/users/mkaydev/events{/privacy}","received_events_url":"https://api.github.com/users/mkaydev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-08T10:10:53Z","updated_at":"2016-12-08T11:00:25Z","closed_at":null,"body":"I just noticed that the SurveyGizmo::Logger is passed as logger to the connection, too. It logs requested urls (info level).\r\n\r\nIf the api token or api token secret contain special characters that need percent-encoding, the regular expression which masks the tokens from log message will not match.\r\n\r\nI verified that the tokens can contain such characters and that they would appear unmasked (and percent encoded) in the logs."},"comment":{"url":"https://api.github.com/repos/jarthod/survey-gizmo-ruby/issues/comments/265713561","html_url":"https://github.com/jarthod/survey-gizmo-ruby/issues/90#issuecomment-265713561","issue_url":"https://api.github.com/repos/jarthod/survey-gizmo-ruby/issues/90","id":265713561,"user":{"login":"apurvis","id":231694,"avatar_url":"https://avatars.githubusercontent.com/u/231694?v=3","gravatar_id":"","url":"https://api.github.com/users/apurvis","html_url":"https://github.com/apurvis","followers_url":"https://api.github.com/users/apurvis/followers","following_url":"https://api.github.com/users/apurvis/following{/other_user}","gists_url":"https://api.github.com/users/apurvis/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvis/subscriptions","organizations_url":"https://api.github.com/users/apurvis/orgs","repos_url":"https://api.github.com/users/apurvis/repos","events_url":"https://api.github.com/users/apurvis/events{/privacy}","received_events_url":"https://api.github.com/users/apurvis/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T11:00:25Z","updated_at":"2016-12-08T11:00:25Z","body":"can you give an example of such a token (obviously don't post your actual token)?  All my SG tokens have been alphanumeric so far; haven't see a special character ever."}}
{"actor":{"display_login":"apurvis"}}