{"action":"created","comment":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/comments/87390429","pull_request_review_id":8004061,"id":87390429,"diff_hunk":"@@ -731,14 +731,17 @@ def report_error(msg):\n             logger.info('Completed repository check, no problems found.')\n         return not error_found or repair\n \n-    def rollback(self, cleanup=False):\n+    def _rollback(self, *, cleanup):","path":"src/borg/repository.py","position":23,"original_position":23,"commit_id":"79c77e7a682a0dca194de066a7d5bbe131b32126","original_commit_id":"79c77e7a682a0dca194de066a7d5bbe131b32126","user":{"login":"enkore","id":1330164,"avatar_url":"https://avatars.githubusercontent.com/u/1330164?v=3","gravatar_id":"","url":"https://api.github.com/users/enkore","html_url":"https://github.com/enkore","followers_url":"https://api.github.com/users/enkore/followers","following_url":"https://api.github.com/users/enkore/following{/other_user}","gists_url":"https://api.github.com/users/enkore/gists{/gist_id}","starred_url":"https://api.github.com/users/enkore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enkore/subscriptions","organizations_url":"https://api.github.com/users/enkore/orgs","repos_url":"https://api.github.com/users/enkore/repos","events_url":"https://api.github.com/users/enkore/events{/privacy}","received_events_url":"https://api.github.com/users/enkore/received_events","type":"User","site_admin":false},"body":"Why the star-argument?","created_at":"2016-11-10T13:09:55Z","updated_at":"2016-11-10T13:09:55Z","html_url":"https://github.com/borgbackup/borg/pull/1826#discussion_r87390429","pull_request_url":"https://api.github.com/repos/borgbackup/borg/pulls/1826","_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments/87390429"},"html":{"href":"https://github.com/borgbackup/borg/pull/1826#discussion_r87390429"},"pull_request":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1826"}}},"pull_request":{"url":"https://api.github.com/repos/borgbackup/borg/pulls/1826","id":93144434,"html_url":"https://github.com/borgbackup/borg/pull/1826","diff_url":"https://github.com/borgbackup/borg/pull/1826.diff","patch_url":"https://github.com/borgbackup/borg/pull/1826.patch","issue_url":"https://api.github.com/repos/borgbackup/borg/issues/1826","number":1826,"state":"open","locked":false,"title":"Repository: rollback's cleanup parameter is internal.","user":{"login":"textshell","id":6579711,"avatar_url":"https://avatars.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"body":"The rollback‘s cleanup parameter should not be exposed externally, esp. not via rpc.\r\n\r\nThus remove cleanup from public rollback method and have that one call a internal version that allows finer control and is used internally in Repository when needed.","created_at":"2016-11-10T12:48:34Z","updated_at":"2016-11-10T13:09:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7339df5f66434d1dd4c22bf039a143e185482194","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/borgbackup/borg/milestones/32","html_url":"https://github.com/borgbackup/borg/milestones/1.1.0b3","labels_url":"https://api.github.com/repos/borgbackup/borg/milestones/32/labels","id":2009270,"number":32,"title":"1.1.0b3","description":"","creator":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":17,"state":"open","created_at":"2016-09-16T14:13:08Z","updated_at":"2016-11-10T12:52:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/borgbackup/borg/pulls/1826/commits","review_comments_url":"https://api.github.com/repos/borgbackup/borg/pulls/1826/comments","review_comment_url":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borgbackup/borg/issues/1826/comments","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/79c77e7a682a0dca194de066a7d5bbe131b32126","head":{"label":"textshell:feature/repository-cleanup-rollback-api","ref":"feature/repository-cleanup-rollback-api","sha":"79c77e7a682a0dca194de066a7d5bbe131b32126","user":{"login":"textshell","id":6579711,"avatar_url":"https://avatars.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"repo":{"id":64159641,"name":"borg","full_name":"textshell/borg","owner":{"login":"textshell","id":6579711,"avatar_url":"https://avatars.githubusercontent.com/u/6579711?v=3","gravatar_id":"","url":"https://api.github.com/users/textshell","html_url":"https://github.com/textshell","followers_url":"https://api.github.com/users/textshell/followers","following_url":"https://api.github.com/users/textshell/following{/other_user}","gists_url":"https://api.github.com/users/textshell/gists{/gist_id}","starred_url":"https://api.github.com/users/textshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textshell/subscriptions","organizations_url":"https://api.github.com/users/textshell/orgs","repos_url":"https://api.github.com/users/textshell/repos","events_url":"https://api.github.com/users/textshell/events{/privacy}","received_events_url":"https://api.github.com/users/textshell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/textshell/borg","description":"Deduplicating backup program with compression and authenticated encryption.","fork":true,"url":"https://api.github.com/repos/textshell/borg","forks_url":"https://api.github.com/repos/textshell/borg/forks","keys_url":"https://api.github.com/repos/textshell/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/textshell/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/textshell/borg/teams","hooks_url":"https://api.github.com/repos/textshell/borg/hooks","issue_events_url":"https://api.github.com/repos/textshell/borg/issues/events{/number}","events_url":"https://api.github.com/repos/textshell/borg/events","assignees_url":"https://api.github.com/repos/textshell/borg/assignees{/user}","branches_url":"https://api.github.com/repos/textshell/borg/branches{/branch}","tags_url":"https://api.github.com/repos/textshell/borg/tags","blobs_url":"https://api.github.com/repos/textshell/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/textshell/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/textshell/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/textshell/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/textshell/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/textshell/borg/languages","stargazers_url":"https://api.github.com/repos/textshell/borg/stargazers","contributors_url":"https://api.github.com/repos/textshell/borg/contributors","subscribers_url":"https://api.github.com/repos/textshell/borg/subscribers","subscription_url":"https://api.github.com/repos/textshell/borg/subscription","commits_url":"https://api.github.com/repos/textshell/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/textshell/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/textshell/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/textshell/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/textshell/borg/contents/{+path}","compare_url":"https://api.github.com/repos/textshell/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/textshell/borg/merges","archive_url":"https://api.github.com/repos/textshell/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/textshell/borg/downloads","issues_url":"https://api.github.com/repos/textshell/borg/issues{/number}","pulls_url":"https://api.github.com/repos/textshell/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/textshell/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/textshell/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/textshell/borg/labels{/name}","releases_url":"https://api.github.com/repos/textshell/borg/releases{/id}","deployments_url":"https://api.github.com/repos/textshell/borg/deployments","created_at":"2016-07-25T18:46:52Z","updated_at":"2016-07-25T18:46:53Z","pushed_at":"2016-11-10T12:54:42Z","git_url":"git://github.com/textshell/borg.git","ssh_url":"git@github.com:textshell/borg.git","clone_url":"https://github.com/textshell/borg.git","svn_url":"https://github.com/textshell/borg","homepage":"https://borgbackup.readthedocs.io/","size":6017,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borgbackup:master","ref":"master","sha":"0cf4a16c5f66f45a638a1e7b0f2b36304e14a1f1","user":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"repo":{"id":35517126,"name":"borg","full_name":"borgbackup/borg","owner":{"login":"borgbackup","id":12418060,"avatar_url":"https://avatars.githubusercontent.com/u/12418060?v=3","gravatar_id":"","url":"https://api.github.com/users/borgbackup","html_url":"https://github.com/borgbackup","followers_url":"https://api.github.com/users/borgbackup/followers","following_url":"https://api.github.com/users/borgbackup/following{/other_user}","gists_url":"https://api.github.com/users/borgbackup/gists{/gist_id}","starred_url":"https://api.github.com/users/borgbackup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borgbackup/subscriptions","organizations_url":"https://api.github.com/users/borgbackup/orgs","repos_url":"https://api.github.com/users/borgbackup/repos","events_url":"https://api.github.com/users/borgbackup/events{/privacy}","received_events_url":"https://api.github.com/users/borgbackup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/borgbackup/borg","description":"Deduplicating backup program with compression and authenticated encryption.","fork":false,"url":"https://api.github.com/repos/borgbackup/borg","forks_url":"https://api.github.com/repos/borgbackup/borg/forks","keys_url":"https://api.github.com/repos/borgbackup/borg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borgbackup/borg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borgbackup/borg/teams","hooks_url":"https://api.github.com/repos/borgbackup/borg/hooks","issue_events_url":"https://api.github.com/repos/borgbackup/borg/issues/events{/number}","events_url":"https://api.github.com/repos/borgbackup/borg/events","assignees_url":"https://api.github.com/repos/borgbackup/borg/assignees{/user}","branches_url":"https://api.github.com/repos/borgbackup/borg/branches{/branch}","tags_url":"https://api.github.com/repos/borgbackup/borg/tags","blobs_url":"https://api.github.com/repos/borgbackup/borg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borgbackup/borg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borgbackup/borg/git/refs{/sha}","trees_url":"https://api.github.com/repos/borgbackup/borg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borgbackup/borg/statuses/{sha}","languages_url":"https://api.github.com/repos/borgbackup/borg/languages","stargazers_url":"https://api.github.com/repos/borgbackup/borg/stargazers","contributors_url":"https://api.github.com/repos/borgbackup/borg/contributors","subscribers_url":"https://api.github.com/repos/borgbackup/borg/subscribers","subscription_url":"https://api.github.com/repos/borgbackup/borg/subscription","commits_url":"https://api.github.com/repos/borgbackup/borg/commits{/sha}","git_commits_url":"https://api.github.com/repos/borgbackup/borg/git/commits{/sha}","comments_url":"https://api.github.com/repos/borgbackup/borg/comments{/number}","issue_comment_url":"https://api.github.com/repos/borgbackup/borg/issues/comments{/number}","contents_url":"https://api.github.com/repos/borgbackup/borg/contents/{+path}","compare_url":"https://api.github.com/repos/borgbackup/borg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borgbackup/borg/merges","archive_url":"https://api.github.com/repos/borgbackup/borg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borgbackup/borg/downloads","issues_url":"https://api.github.com/repos/borgbackup/borg/issues{/number}","pulls_url":"https://api.github.com/repos/borgbackup/borg/pulls{/number}","milestones_url":"https://api.github.com/repos/borgbackup/borg/milestones{/number}","notifications_url":"https://api.github.com/repos/borgbackup/borg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borgbackup/borg/labels{/name}","releases_url":"https://api.github.com/repos/borgbackup/borg/releases{/id}","deployments_url":"https://api.github.com/repos/borgbackup/borg/deployments","created_at":"2015-05-12T23:10:47Z","updated_at":"2016-11-10T12:08:01Z","pushed_at":"2016-11-10T12:54:42Z","git_url":"git://github.com/borgbackup/borg.git","ssh_url":"git@github.com:borgbackup/borg.git","clone_url":"https://github.com/borgbackup/borg.git","svn_url":"https://github.com/borgbackup/borg","homepage":"https://borgbackup.readthedocs.io/","size":7188,"stargazers_count":1637,"watchers_count":1637,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":238,"forks":163,"open_issues":238,"watchers":1637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1826"},"html":{"href":"https://github.com/borgbackup/borg/pull/1826"},"issue":{"href":"https://api.github.com/repos/borgbackup/borg/issues/1826"},"comments":{"href":"https://api.github.com/repos/borgbackup/borg/issues/1826/comments"},"review_comments":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1826/comments"},"review_comment":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borgbackup/borg/pulls/1826/commits"},"statuses":{"href":"https://api.github.com/repos/borgbackup/borg/statuses/79c77e7a682a0dca194de066a7d5bbe131b32126"}}}}
{"actor":{"display_login":"enkore"}}