{"push_id":1284043348,"size":3,"distinct_size":3,"ref":"refs/heads/add_real_timeline_tests","head":"4875208f45cbd31548d4cc9b1b087e1a21f3797b","before":"fcb928a406db0a23a857aeba845d86de4d94337e","commits":[{"sha":"4c00a17941f5aa1bf323c3e84e9f7e02d86088aa","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Actually add tests for the zero length trips\n\nIn a5f210d8f83b0353dbaddcf59a8dbeb103ebd012, we added sample timelines and\nground truth, but didn't add the actual tests. Finally add them. Note that the\nGabe test fails because the ground truth has changed due to other fixes.","distinct":true,"url":"https://api.github.com/repos/shankari/e-mission-server/commits/4c00a17941f5aa1bf323c3e84e9f7e02d86088aa"},{"sha":"c25997d56f47ec4e1952bf1cc9f6ef12937cb3f1","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Add an UNKNOWN section if the distance from the previous place is greater than a threshold\n\nIn prior commits, we have attempted to fill the holes in timelines caused by\nshort trips without sufficient high confidence motion activity entries to\ncreate a proper section (6aac0d8b6fe13ceb2acc09c6018ac2bd9d169957, 01043f188803053dd951d720c560b5143f52ce9a). However, at least on android, we didn't handle\nthe case in which there were zero high confidence valid actions (https://github.com/e-mission/e-mission-server/issues/356#issuecomment-240630757).\n\nBut while investigating further, we did find such a point\n(https://github.com/e-mission/e-mission-server/issues/385#issuecomment-244826007).\nSo we change the code to compute the distance from the previous place, pass\nthat it, and compare it against a threshold to determine whether we should\ncreate an UNKNOWN section anyway or not.\n\nConfirmed using Gabe's data that this does not re-introduce fake/spurious\ntrips.\n\nIt is not clear that this is required on iOS, because we already check for\nvisit transitions. But it is not a bad check to add, and we can tweak it\nfurther later after testing with @juemura's and @sunil07t's trips.","distinct":true,"url":"https://api.github.com/repos/shankari/e-mission-server/commits/c25997d56f47ec4e1952bf1cc9f6ef12937cb3f1"},{"sha":"4875208f45cbd31548d4cc9b1b087e1a21f3797b","author":{"name":"K. Shankari","email":"8df60ce8d21ba0b217aacda6d3c2977f8128b8cb@eecs.berkeley.edu"},"message":"Change method signature used in the section segmentation test\n\nTo match the object -> entry change from c25997d56f47ec4e1952bf1cc9f6ef12937cb3f1","distinct":true,"url":"https://api.github.com/repos/shankari/e-mission-server/commits/4875208f45cbd31548d4cc9b1b087e1a21f3797b"}]}
{"actor":{"display_login":"shankari"}}