{"action":"created","comment":{"url":"https://api.github.com/repos/angular/protractor/pulls/comments/51068835","id":51068835,"diff_hunk":"@@ -26,16 +26,17 @@ var passingTests = [\n   'node lib/cli.js spec/plugins/browserGetUnsyncedConf.js',\n   'node lib/cli.js spec/plugins/waitForAngularConf.js',\n   'node lib/cli.js spec/interactionConf.js',\n-  'node lib/cli.js spec/directConnectConf.js',\n+  //'node lib/cli.js spec/directConnectConf.js',","path":"scripts/test.js","position":5,"original_position":5,"commit_id":"49dd26940aca2f7b1d4ad6eb408379d7cdf55e76","original_commit_id":"49dd26940aca2f7b1d4ad6eb408379d7cdf55e76","user":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"body":"This didn't run for me because it is using chromedriver directly. My error is: Could not find chromedriver at protractor/selenium/chromedriver","created_at":"2016-01-27T23:38:18Z","updated_at":"2016-01-27T23:38:18Z","html_url":"https://github.com/angular/protractor/pull/2874#discussion_r51068835","pull_request_url":"https://api.github.com/repos/angular/protractor/pulls/2874","_links":{"self":{"href":"https://api.github.com/repos/angular/protractor/pulls/comments/51068835"},"html":{"href":"https://github.com/angular/protractor/pull/2874#discussion_r51068835"},"pull_request":{"href":"https://api.github.com/repos/angular/protractor/pulls/2874"}}},"pull_request":{"url":"https://api.github.com/repos/angular/protractor/pulls/2874","id":57304543,"html_url":"https://github.com/angular/protractor/pull/2874","diff_url":"https://github.com/angular/protractor/pull/2874.diff","patch_url":"https://github.com/angular/protractor/pull/2874.patch","issue_url":"https://api.github.com/repos/angular/protractor/issues/2874","number":2874,"state":"open","locked":false,"title":"feat(attachSession): attach protractor to existing webdriver session","user":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"body":"Attaching an existing selenium browser session to protractor rather than always creating new one. The session can be passed into the config file as a string via the `sessionId`.","created_at":"2016-01-27T02:16:24Z","updated_at":"2016-01-27T23:38:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3151f96b9656c548be423f4c3e1abdebf6565b0","assignee":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/protractor/pulls/2874/commits","review_comments_url":"https://api.github.com/repos/angular/protractor/pulls/2874/comments","review_comment_url":"https://api.github.com/repos/angular/protractor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/protractor/issues/2874/comments","statuses_url":"https://api.github.com/repos/angular/protractor/statuses/49dd26940aca2f7b1d4ad6eb408379d7cdf55e76","head":{"label":"cnishina:wip-driverprovider","ref":"wip-driverprovider","sha":"49dd26940aca2f7b1d4ad6eb408379d7cdf55e76","user":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"repo":{"id":49972885,"name":"protractor","full_name":"cnishina/protractor","owner":{"login":"cnishina","id":1559007,"avatar_url":"https://avatars.githubusercontent.com/u/1559007?v=3","gravatar_id":"","url":"https://api.github.com/users/cnishina","html_url":"https://github.com/cnishina","followers_url":"https://api.github.com/users/cnishina/followers","following_url":"https://api.github.com/users/cnishina/following{/other_user}","gists_url":"https://api.github.com/users/cnishina/gists{/gist_id}","starred_url":"https://api.github.com/users/cnishina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnishina/subscriptions","organizations_url":"https://api.github.com/users/cnishina/orgs","repos_url":"https://api.github.com/users/cnishina/repos","events_url":"https://api.github.com/users/cnishina/events{/privacy}","received_events_url":"https://api.github.com/users/cnishina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cnishina/protractor","description":"E2E test framework for Angular apps","fork":true,"url":"https://api.github.com/repos/cnishina/protractor","forks_url":"https://api.github.com/repos/cnishina/protractor/forks","keys_url":"https://api.github.com/repos/cnishina/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cnishina/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cnishina/protractor/teams","hooks_url":"https://api.github.com/repos/cnishina/protractor/hooks","issue_events_url":"https://api.github.com/repos/cnishina/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/cnishina/protractor/events","assignees_url":"https://api.github.com/repos/cnishina/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/cnishina/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/cnishina/protractor/tags","blobs_url":"https://api.github.com/repos/cnishina/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cnishina/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cnishina/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/cnishina/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cnishina/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/cnishina/protractor/languages","stargazers_url":"https://api.github.com/repos/cnishina/protractor/stargazers","contributors_url":"https://api.github.com/repos/cnishina/protractor/contributors","subscribers_url":"https://api.github.com/repos/cnishina/protractor/subscribers","subscription_url":"https://api.github.com/repos/cnishina/protractor/subscription","commits_url":"https://api.github.com/repos/cnishina/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/cnishina/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/cnishina/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/cnishina/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/cnishina/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/cnishina/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cnishina/protractor/merges","archive_url":"https://api.github.com/repos/cnishina/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cnishina/protractor/downloads","issues_url":"https://api.github.com/repos/cnishina/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/cnishina/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/cnishina/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/cnishina/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cnishina/protractor/labels{/name}","releases_url":"https://api.github.com/repos/cnishina/protractor/releases{/id}","deployments_url":"https://api.github.com/repos/cnishina/protractor/deployments","created_at":"2016-01-19T18:15:59Z","updated_at":"2016-01-19T18:16:00Z","pushed_at":"2016-01-27T02:15:38Z","git_url":"git://github.com/cnishina/protractor.git","ssh_url":"git@github.com:cnishina/protractor.git","clone_url":"https://github.com/cnishina/protractor.git","svn_url":"https://github.com/cnishina/protractor","homepage":"http://www.protractortest.org","size":5088,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"9532779dd340b6db860b9aed3beca3a3673e51e4","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":7639232,"name":"protractor","full_name":"angular/protractor","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/protractor","description":"E2E test framework for Angular apps","fork":false,"url":"https://api.github.com/repos/angular/protractor","forks_url":"https://api.github.com/repos/angular/protractor/forks","keys_url":"https://api.github.com/repos/angular/protractor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/protractor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/protractor/teams","hooks_url":"https://api.github.com/repos/angular/protractor/hooks","issue_events_url":"https://api.github.com/repos/angular/protractor/issues/events{/number}","events_url":"https://api.github.com/repos/angular/protractor/events","assignees_url":"https://api.github.com/repos/angular/protractor/assignees{/user}","branches_url":"https://api.github.com/repos/angular/protractor/branches{/branch}","tags_url":"https://api.github.com/repos/angular/protractor/tags","blobs_url":"https://api.github.com/repos/angular/protractor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/protractor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/protractor/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/protractor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/protractor/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/protractor/languages","stargazers_url":"https://api.github.com/repos/angular/protractor/stargazers","contributors_url":"https://api.github.com/repos/angular/protractor/contributors","subscribers_url":"https://api.github.com/repos/angular/protractor/subscribers","subscription_url":"https://api.github.com/repos/angular/protractor/subscription","commits_url":"https://api.github.com/repos/angular/protractor/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/protractor/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/protractor/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/protractor/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/protractor/contents/{+path}","compare_url":"https://api.github.com/repos/angular/protractor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/protractor/merges","archive_url":"https://api.github.com/repos/angular/protractor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/protractor/downloads","issues_url":"https://api.github.com/repos/angular/protractor/issues{/number}","pulls_url":"https://api.github.com/repos/angular/protractor/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/protractor/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/protractor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/protractor/labels{/name}","releases_url":"https://api.github.com/repos/angular/protractor/releases{/id}","deployments_url":"https://api.github.com/repos/angular/protractor/deployments","created_at":"2013-01-16T04:30:53Z","updated_at":"2016-01-27T22:15:47Z","pushed_at":"2016-01-27T06:38:04Z","git_url":"git://github.com/angular/protractor.git","ssh_url":"git@github.com:angular/protractor.git","clone_url":"https://github.com/angular/protractor.git","svn_url":"https://github.com/angular/protractor","homepage":"http://www.protractortest.org","size":7922,"stargazers_count":4942,"watchers_count":4942,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1061,"mirror_url":null,"open_issues_count":182,"forks":1061,"open_issues":182,"watchers":4942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/protractor/pulls/2874"},"html":{"href":"https://github.com/angular/protractor/pull/2874"},"issue":{"href":"https://api.github.com/repos/angular/protractor/issues/2874"},"comments":{"href":"https://api.github.com/repos/angular/protractor/issues/2874/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/protractor/pulls/2874/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/protractor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/protractor/pulls/2874/commits"},"statuses":{"href":"https://api.github.com/repos/angular/protractor/statuses/49dd26940aca2f7b1d4ad6eb408379d7cdf55e76"}}}}