{"action":"created","issue":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/242","repository_url":"https://api.github.com/repos/conda-forge/conda-smithy","labels_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/242/labels{/name}","comments_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/242/comments","events_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/242/events","html_url":"https://github.com/conda-forge/conda-smithy/pull/242","id":167200826,"number":242,"title":"Fast finish fallback if CircleCI skip fails","user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars.githubusercontent.com/u/3019665?v=3","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-23T20:01:50Z","updated_at":"2016-08-06T05:52:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/pulls/242","html_url":"https://github.com/conda-forge/conda-smithy/pull/242","diff_url":"https://github.com/conda-forge/conda-smithy/pull/242.diff","patch_url":"https://github.com/conda-forge/conda-smithy/pull/242.patch"},"body":"If a recipe does not build on Linux, we made a changed to the `circle.yml` so that CircleCI does not build the feedstock. This was done in PR ( https://github.com/conda-forge/conda-smithy/pull/218 ). It was demonstrated to work correctly in some test cases. Also this has worked largely for CircleCI builds encountered thus far.\r\n\r\nHowever, today I noticed a [build failure]( https://circleci.com/gh/conda-forge/anypytools-feedstock/1 ) for the [anypytools-feedstock]( https://github.com/conda-forge/anypytools-feedstock ) even though that feedstock should only build on AppVeyor. To see if something was systemically going wrong, I added PR ( https://github.com/conda-forge/anypytools-feedstock/pull/1 ), which appeared to do the right thing and generate a [skipped build]( https://circleci.com/gh/conda-forge/anypytools-feedstock/2 ). So, I went ahead and added a [post]( https://discuss.circleci.com/t/circleci-built-skipped-branch-commit/5285 ) on CircleCI's discussion board to see what caused this unusual failure.\r\n\r\nIn the event that this happens again, it seems prudent for us to have a fallback that generates a passing status and runs quickly. This PR proposes the following changes. We still keep the skip as this largely works well. If the skip is ignored, we do not pull the docker image as we don't intend to use it nor do we have the script to. Also, we override the test phase to simply run `true`, which will pass. This should make the build finish fast and exit with a clean status if it runs."},"comment":{"url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/comments/238007676","html_url":"https://github.com/conda-forge/conda-smithy/pull/242#issuecomment-238007676","issue_url":"https://api.github.com/repos/conda-forge/conda-smithy/issues/242","id":238007676,"user":{"login":"jakirkham","id":3019665,"avatar_url":"https://avatars.githubusercontent.com/u/3019665?v=3","gravatar_id":"","url":"https://api.github.com/users/jakirkham","html_url":"https://github.com/jakirkham","followers_url":"https://api.github.com/users/jakirkham/followers","following_url":"https://api.github.com/users/jakirkham/following{/other_user}","gists_url":"https://api.github.com/users/jakirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/jakirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakirkham/subscriptions","organizations_url":"https://api.github.com/users/jakirkham/orgs","repos_url":"https://api.github.com/users/jakirkham/repos","events_url":"https://api.github.com/users/jakirkham/events{/privacy}","received_events_url":"https://api.github.com/users/jakirkham/received_events","type":"User","site_admin":false},"created_at":"2016-08-06T05:52:00Z","updated_at":"2016-08-06T05:52:00Z","body":"Does this seem reasonable @pelson? Basically just thinking that we should have a build fast finish with a passing status if it doesn't skip. The current behavior is not like that, but this changes it to match.\r\n\r\nPart of the reason I ask about this again is we need to make some decision on this before I start digging into matrix support. After all I will need to muck around in these same files and the fewer conflicts we have to resolve the better."}}
{"actor":{"display_login":"jakirkham"}}