{"action":"created","issue":{"url":"https://api.github.com/repos/Windower/Lua/issues/1264","repository_url":"https://api.github.com/repos/Windower/Lua","labels_url":"https://api.github.com/repos/Windower/Lua/issues/1264/labels{/name}","comments_url":"https://api.github.com/repos/Windower/Lua/issues/1264/comments","events_url":"https://api.github.com/repos/Windower/Lua/issues/1264/events","html_url":"https://github.com/Windower/Lua/pull/1264","id":66993773,"number":1264,"title":"Scoreboard - Enable DPS without engaging","user":{"login":"lorand-ffxi","id":8368245,"avatar_url":"https://avatars.githubusercontent.com/u/8368245?v=3","gravatar_id":"","url":"https://api.github.com/users/lorand-ffxi","html_url":"https://github.com/lorand-ffxi","followers_url":"https://api.github.com/users/lorand-ffxi/followers","following_url":"https://api.github.com/users/lorand-ffxi/following{/other_user}","gists_url":"https://api.github.com/users/lorand-ffxi/gists{/gist_id}","starred_url":"https://api.github.com/users/lorand-ffxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorand-ffxi/subscriptions","organizations_url":"https://api.github.com/users/lorand-ffxi/orgs","repos_url":"https://api.github.com/users/lorand-ffxi/repos","events_url":"https://api.github.com/users/lorand-ffxi/events{/privacy}","received_events_url":"https://api.github.com/users/lorand-ffxi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2015-04-07T21:23:24Z","updated_at":"2016-07-15T05:55:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Windower/Lua/pulls/1264","html_url":"https://github.com/Windower/Lua/pull/1264","diff_url":"https://github.com/Windower/Lua/pull/1264.diff","patch_url":"https://github.com/Windower/Lua/pull/1264.patch"},"body":"This is actually my first time ever making a pull request, so I'm not sure what the etiquette is, but here goes...\r\n\r\nI always wished that Scoreboard would track damage while not engaged, especially while playing BLM, SCH, etc.  In order to do this, I added a table to store IDs of mobs that have been attacked.  Damage from party members is always recorded rather than only when a party member is engaged.  The DPS clock will now advance if the mob's HP is above 0 and the mob is engaged (rather than when a party member is engaged), otherwise the mob is removed from the list.  "},"comment":{"url":"https://api.github.com/repos/Windower/Lua/issues/comments/232866052","html_url":"https://github.com/Windower/Lua/pull/1264#issuecomment-232866052","issue_url":"https://api.github.com/repos/Windower/Lua/issues/1264","id":232866052,"user":{"login":"jerryhebert","id":959757,"avatar_url":"https://avatars.githubusercontent.com/u/959757?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryhebert","html_url":"https://github.com/jerryhebert","followers_url":"https://api.github.com/users/jerryhebert/followers","following_url":"https://api.github.com/users/jerryhebert/following{/other_user}","gists_url":"https://api.github.com/users/jerryhebert/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryhebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryhebert/subscriptions","organizations_url":"https://api.github.com/users/jerryhebert/orgs","repos_url":"https://api.github.com/users/jerryhebert/repos","events_url":"https://api.github.com/users/jerryhebert/events{/privacy}","received_events_url":"https://api.github.com/users/jerryhebert/received_events","type":"User","site_admin":false},"created_at":"2016-07-15T05:55:37Z","updated_at":"2016-07-15T05:55:37Z","body":"I'm not sure myself. Like you, I just remember we had lots of discussions about this. There was that native SE command to toggle battle music even if you aren't engaged though and that solved some cases. I can't remember what it was called. I also remember some stuff like Legion was tricky.\r\n\r\nHonestly, this kind of flag seems pretty nice because it lets the user just specify it rather than trying to do it automatically with unreliable triggers.\r\n\r\nThere's some rambling for historical purposes. "}}
{"actor":{"display_login":"jerryhebert"}}