{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/sulu/pulls/comments/93394182","pull_request_review_id":13919236,"id":93394182,"diff_hunk":"@@ -0,0 +1,36 @@\n+<?php\n+\n+/*\n+ * This file is part of Sulu.\n+ *\n+ * (c) MASSIVE ART WebServices GmbH\n+ *\n+ * This source file is subject to the MIT license that is bundled\n+ * with this source code in the file LICENSE.\n+ */\n+\n+namespace Sulu\\Bundle\\MarkupBundle\\Markup;\n+\n+/**\n+ * Interface for tag-extractors.\n+ */\n+interface TagExtractorInterface\n+{\n+    /**\n+     * @param string $html\n+     * @param string $namespace\n+     *\n+     * @return int\n+     */\n+    public function count($html, $namespace);\n+\n+    /**\n+     * Returns found tags and their attributes.\n+     *\n+     * @param string $html\n+     * @param string $namespace\n+     *\n+     * @return array\n+     */\n+    public function extract($html, $namespace);","path":"src/Sulu/Bundle/MarkupBundle/Markup/TagExtractorInterface.php","position":35,"original_position":35,"commit_id":"ad83a92b871a9889bf94656102668a5e129569ba","original_commit_id":"ad83a92b871a9889bf94656102668a5e129569ba","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"The other alternative would be to introduce a `DelegatingTagExtractor` which asks all other registered `TagExtractor`s for tags.","created_at":"2016-12-21T08:29:24Z","updated_at":"2016-12-21T08:29:24Z","html_url":"https://github.com/sulu/sulu/pull/3094#discussion_r93394182","pull_request_url":"https://api.github.com/repos/sulu/sulu/pulls/3094","_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments/93394182"},"html":{"href":"https://github.com/sulu/sulu/pull/3094#discussion_r93394182"},"pull_request":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3094"}}},"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/3094","id":98286079,"html_url":"https://github.com/sulu/sulu/pull/3094","diff_url":"https://github.com/sulu/sulu/pull/3094.diff","patch_url":"https://github.com/sulu/sulu/pull/3094.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/3094","number":3094,"state":"open","locked":false,"title":"Extracted tag-extractor from html-markup-parser","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | yes\r\n| New feature? | yes\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Fixed tickets | fixes #2786 \r\n| Related issues/PRs | https://github.com/sulu/sulu/issues/3105\r\n| License | MIT\r\n| Documentation PR | none\r\n\r\n#### What's in this PR?\r\n\r\nThis PR introduces a new service which will be used to extract tags from html-markup. \r\n\r\n#### TODO\r\n\r\n- [x] tag inside tag","created_at":"2016-12-16T06:44:46Z","updated_at":"2016-12-21T08:29:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a34da592c19028a5d14bc504f0c7abfd434936fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/3094/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/3094/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/3094/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/ad83a92b871a9889bf94656102668a5e129569ba","head":{"label":"wachterjohannes:enhancement/html-extractor","ref":"enhancement/html-extractor","sha":"ad83a92b871a9889bf94656102668a5e129569ba","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"repo":{"id":53324547,"name":"sulu","full_name":"wachterjohannes/sulu","owner":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wachterjohannes/sulu","description":"Sulu core bundles & components","fork":true,"url":"https://api.github.com/repos/wachterjohannes/sulu","forks_url":"https://api.github.com/repos/wachterjohannes/sulu/forks","keys_url":"https://api.github.com/repos/wachterjohannes/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wachterjohannes/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wachterjohannes/sulu/teams","hooks_url":"https://api.github.com/repos/wachterjohannes/sulu/hooks","issue_events_url":"https://api.github.com/repos/wachterjohannes/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/wachterjohannes/sulu/events","assignees_url":"https://api.github.com/repos/wachterjohannes/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/wachterjohannes/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/wachterjohannes/sulu/tags","blobs_url":"https://api.github.com/repos/wachterjohannes/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wachterjohannes/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wachterjohannes/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/wachterjohannes/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wachterjohannes/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/wachterjohannes/sulu/languages","stargazers_url":"https://api.github.com/repos/wachterjohannes/sulu/stargazers","contributors_url":"https://api.github.com/repos/wachterjohannes/sulu/contributors","subscribers_url":"https://api.github.com/repos/wachterjohannes/sulu/subscribers","subscription_url":"https://api.github.com/repos/wachterjohannes/sulu/subscription","commits_url":"https://api.github.com/repos/wachterjohannes/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/wachterjohannes/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/wachterjohannes/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/wachterjohannes/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/wachterjohannes/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/wachterjohannes/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wachterjohannes/sulu/merges","archive_url":"https://api.github.com/repos/wachterjohannes/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wachterjohannes/sulu/downloads","issues_url":"https://api.github.com/repos/wachterjohannes/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/wachterjohannes/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/wachterjohannes/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/wachterjohannes/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wachterjohannes/sulu/labels{/name}","releases_url":"https://api.github.com/repos/wachterjohannes/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/wachterjohannes/sulu/deployments","created_at":"2016-03-07T12:38:55Z","updated_at":"2016-03-07T12:39:01Z","pushed_at":"2016-12-21T07:54:55Z","git_url":"git://github.com/wachterjohannes/sulu.git","ssh_url":"git@github.com:wachterjohannes/sulu.git","clone_url":"https://github.com/wachterjohannes/sulu.git","svn_url":"https://github.com/wachterjohannes/sulu","homepage":"sulu.io","size":85413,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:develop","ref":"develop","sha":"e720328e2c74d945898c7239eed732d0395785c3","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-12-20T00:17:43Z","pushed_at":"2016-12-21T08:16:15Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":85552,"stargazers_count":157,"watchers_count":157,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":449,"forks":70,"open_issues":449,"watchers":157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3094"},"html":{"href":"https://github.com/sulu/sulu/pull/3094"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/3094"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/3094/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3094/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/3094/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/ad83a92b871a9889bf94656102668a5e129569ba"}}}}
{"actor":{"display_login":"danrot"}}