{"action":"created","issue":{"url":"https://api.github.com/repos/embree/embree/issues/95","repository_url":"https://api.github.com/repos/embree/embree","labels_url":"https://api.github.com/repos/embree/embree/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/embree/embree/issues/95/comments","events_url":"https://api.github.com/repos/embree/embree/issues/95/events","html_url":"https://github.com/embree/embree/issues/95","id":168732210,"number":95,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars.githubusercontent.com/u/660477?v=3","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-01T20:16:41Z","updated_at":"2016-08-02T10:03:24Z","closed_at":"2016-08-02T07:59:08Z","body":"I would like to point out that identifiers like \"[`__RTCDevice`](https://github.com/embree/embree/blob/c28dae141a8f0cb370ce32d9d811f88a630f1c5a/include/embree2/rtcore.h#L75)\" and \"[`__RTCORE_RAY_H__`](https://github.com/embree/embree/blob/50a8814b5b586416b1e26872828bc54f76010808/include/embree2/rtcore_ray.h#L17)\" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier \"Do not use identifiers that are reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/embree/embree/issues/comments/236860316","html_url":"https://github.com/embree/embree/issues/95#issuecomment-236860316","issue_url":"https://api.github.com/repos/embree/embree/issues/95","id":236860316,"user":{"login":"cbenthin","id":5039049,"avatar_url":"https://avatars.githubusercontent.com/u/5039049?v=3","gravatar_id":"","url":"https://api.github.com/users/cbenthin","html_url":"https://github.com/cbenthin","followers_url":"https://api.github.com/users/cbenthin/followers","following_url":"https://api.github.com/users/cbenthin/following{/other_user}","gists_url":"https://api.github.com/users/cbenthin/gists{/gist_id}","starred_url":"https://api.github.com/users/cbenthin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbenthin/subscriptions","organizations_url":"https://api.github.com/users/cbenthin/orgs","repos_url":"https://api.github.com/users/cbenthin/repos","events_url":"https://api.github.com/users/cbenthin/events{/privacy}","received_events_url":"https://api.github.com/users/cbenthin/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T10:03:24Z","updated_at":"2016-08-02T10:03:24Z","body":"So far not a single compiler on any OS \"complained\" about this and we didn't get any feedback that this is causing real trouble in other projects (which build on embree). Maybe the compilers are simply more tolerant that the spec says :). That said, I've added the naming change request to our todo list for future embree releases. "}}
{"actor":{"display_login":"cbenthin"}}