{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4036","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4036/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4036/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4036/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/4036","id":166468496,"number":4036,"title":"Display RTC on OSD","user":{"login":"RisingFog","id":2121359,"avatar_url":"https://avatars.githubusercontent.com/u/2121359?v=3","gravatar_id":"","url":"https://api.github.com/users/RisingFog","html_url":"https://github.com/RisingFog","followers_url":"https://api.github.com/users/RisingFog/followers","following_url":"https://api.github.com/users/RisingFog/following{/other_user}","gists_url":"https://api.github.com/users/RisingFog/gists{/gist_id}","starred_url":"https://api.github.com/users/RisingFog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RisingFog/subscriptions","organizations_url":"https://api.github.com/users/RisingFog/orgs","repos_url":"https://api.github.com/users/RisingFog/repos","events_url":"https://api.github.com/users/RisingFog/events{/privacy}","received_events_url":"https://api.github.com/users/RisingFog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-20T00:24:29Z","updated_at":"2016-07-21T20:59:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4036","html_url":"https://github.com/dolphin-emu/dolphin/pull/4036","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4036.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4036.patch"},"body":"This adds an option in the Movie menu to show the current system clock.\r\n\r\nMeant to compliment the recent Custom RTC commits being merged.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4036)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/234382404","html_url":"https://github.com/dolphin-emu/dolphin/pull/4036#issuecomment-234382404","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4036","id":234382404,"user":{"login":"RisingFog","id":2121359,"avatar_url":"https://avatars.githubusercontent.com/u/2121359?v=3","gravatar_id":"","url":"https://api.github.com/users/RisingFog","html_url":"https://github.com/RisingFog","followers_url":"https://api.github.com/users/RisingFog/followers","following_url":"https://api.github.com/users/RisingFog/following{/other_user}","gists_url":"https://api.github.com/users/RisingFog/gists{/gist_id}","starred_url":"https://api.github.com/users/RisingFog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RisingFog/subscriptions","organizations_url":"https://api.github.com/users/RisingFog/orgs","repos_url":"https://api.github.com/users/RisingFog/repos","events_url":"https://api.github.com/users/RisingFog/events{/privacy}","received_events_url":"https://api.github.com/users/RisingFog/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T20:59:50Z","updated_at":"2016-07-21T20:59:50Z","body":"\n\n\n\nReview status: 0 of 11 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[Source/Core/Core/Movie.cpp, line 187 \\[r1\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4036#-KN4g8JosC5DgR-o4lmS-r1-187:-KNEFOskmDe5oD4Bz90n:-358160392) ([raw file](https://github.com/dolphin-emu/dolphin/blob/718d8e570cc25e87ebcd5b30ad630cf41dbe3266/Source/Core/Core/Movie.cpp#L187)):*\n<details><summary><i>Previously, RisingFog (Chris Burgener) wrote…</i></summary>\n> Done.\n</details>\nReverted because std::put_time does not exist in GCC 4.9.\n\n---\n\n*[Source/Core/Core/Movie.cpp, line 184 \\[r2\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4036#-KN6x4VrGntLoy9bNI32:-KNEEgYk2cRPDo5RwK68:-991891367) ([raw file](https://github.com/dolphin-emu/dolphin/blob/5bc1d2ecdec40aff99e51a4aefeb43eac0a9f6b0/Source/Core/Core/Movie.cpp#L184)):*\n<details><summary><i>Previously, JosJuice wrote…</i></summary>\n> Or you could split `GetGCTime` into a `GetTime` function that gives you want you want here and a `GetGCTime` function that just runs `return GetTime() - 0x386D4380` (preferably still with a named constant, but the constant can be function-local this way)\n</details>\nCreated a GetCTTimeJan1970() function which returns GetGCTime() + cJanuary2000 (the constant for seconds between Jan 1st 1970 and Jan 1st 2000).\n\n---\n\n*[Source/Core/Core/Movie.h, line 182 \\[r2\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4036#-KN6xbsQKewSEmz_EvLw:-KNEEtFy-bP3TaMwyqae:733565661) ([raw file](https://github.com/dolphin-emu/dolphin/blob/5bc1d2ecdec40aff99e51a4aefeb43eac0a9f6b0/Source/Core/Core/Movie.h#L182)):*\n<details><summary><i>Previously, JosJuice wrote…</i></summary>\n> Why is this in Movie?\n</details>\nBecause the toggle is kept within the movie function, most calls to the OSD are done within Movie or use Movie functions and the includes needed are already defined.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4036)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"RisingFog"}}