{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/70491960","id":70491960,"diff_hunk":"@@ -1436,33 +1323,40 @@ vdev_raidz_reconstruct(raidz_map_t *rm, int *t, int nt)\n \tdt = &tgts[nbadparity];\n \n \t/*\n+\t * Reconstruct using the new math implementation if\n+\t * rm_ops is set.\n+\t */\n+\tif (rm->rm_ops) {\n+\t\treturn (vdev_raidz_math_reconstruct(rm, parity_valid, dt,\n+\t\t    nbaddata));\n+\t}\n+\n+\t/*\n \t * See if we can use any of our optimized reconstruction routines.\n \t */\n-\tif (!vdev_raidz_default_to_general) {","path":"module/zfs/vdev_raidz.c","position":220,"original_position":220,"commit_id":"a31e1d99826c071478d761058093297bdaa8ccd2","original_commit_id":"a31e1d99826c071478d761058093297bdaa8ccd2","user":{"login":"ironMann","id":276684,"avatar_url":"https://avatars.githubusercontent.com/u/276684?v=3","gravatar_id":"","url":"https://api.github.com/users/ironMann","html_url":"https://github.com/ironMann","followers_url":"https://api.github.com/users/ironMann/followers","following_url":"https://api.github.com/users/ironMann/following{/other_user}","gists_url":"https://api.github.com/users/ironMann/gists{/gist_id}","starred_url":"https://api.github.com/users/ironMann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironMann/subscriptions","organizations_url":"https://api.github.com/users/ironMann/orgs","repos_url":"https://api.github.com/users/ironMann/repos","events_url":"https://api.github.com/users/ironMann/events{/privacy}","received_events_url":"https://api.github.com/users/ironMann/received_events","type":"User","site_admin":false},"body":"I wasn't sure why it was there, since it's not wired to any parameter, and it's technically unitialized (not static).","created_at":"2016-07-12T18:16:41Z","updated_at":"2016-07-12T18:16:41Z","html_url":"https://github.com/zfsonlinux/zfs/pull/4328#discussion_r70491960","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/70491960"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/4328#discussion_r70491960"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328","id":59047532,"html_url":"https://github.com/zfsonlinux/zfs/pull/4328","diff_url":"https://github.com/zfsonlinux/zfs/pull/4328.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/4328.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4328","number":4328,"state":"closed","locked":false,"title":"[RFC] SIMD implementation of vdev_raidz generate and reconstruct routines","user":{"login":"ironMann","id":276684,"avatar_url":"https://avatars.githubusercontent.com/u/276684?v=3","gravatar_id":"","url":"https://api.github.com/users/ironMann","html_url":"https://github.com/ironMann","followers_url":"https://api.github.com/users/ironMann/followers","following_url":"https://api.github.com/users/ironMann/following{/other_user}","gists_url":"https://api.github.com/users/ironMann/gists{/gist_id}","starred_url":"https://api.github.com/users/ironMann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironMann/subscriptions","organizations_url":"https://api.github.com/users/ironMann/orgs","repos_url":"https://api.github.com/users/ironMann/repos","events_url":"https://api.github.com/users/ironMann/events{/privacy}","received_events_url":"https://api.github.com/users/ironMann/received_events","type":"User","site_admin":false},"body":"based on top of @zfsonlinux:master \r\n\r\nThis is a new implementation of RAIDZ1/2/3 routines using x86_64 scalar, SSE, and AVX2 instruction sets. Included are 3 parity generation routines (P, PQ, and PQR) and 7 reconstruction routines, for all RAIDZ level. On module load, a quick benchmark of supported routines will select the fastest for each operation and they will be used in runtime. Original implementation is still present and can be selected via module parameter.\r\n\r\nPatch contains:\r\n\r\n- specialized gen/rec routines for all RAIDZ levels,\r\n- new scalar raidz implementation (unrolled for speed),\r\n- two x86_64 SIMD implementations (SSE and AVX2 instructions sets),\r\n- fastest routines selected on module load (benchmark).\r\n- cmd/raidz_test tool for math exactness verification, code coverage and benchmark\r\n\r\nNew zfs module parameter:\r\n```\r\n- zfs_vdev_raidz_impl (string, can be changed online): selects the implementation to use\r\n    \"fastest\" - use the fastest math available\r\n    \"original\" - use the original raidz code\r\n    \"cycle\" - cycle through all available impl for each new vdev_raidz (default in userspace tests)\r\n    \"scalar\" - new scalar impl\r\n    \"sse\" - new SSE impl if available\r\n    \"avx2\" - new AVX2 impl if available\r\n```","created_at":"2016-02-11T15:36:03Z","updated_at":"2016-07-12T18:16:41Z","closed_at":"2016-06-21T16:42:59Z","merged_at":null,"merge_commit_sha":"6a46ce790a77088f5c31916a95e132d61d985895","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4328/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/a31e1d99826c071478d761058093297bdaa8ccd2","head":{"label":"ironMann:wip-simd","ref":"wip-simd","sha":"a31e1d99826c071478d761058093297bdaa8ccd2","user":{"login":"ironMann","id":276684,"avatar_url":"https://avatars.githubusercontent.com/u/276684?v=3","gravatar_id":"","url":"https://api.github.com/users/ironMann","html_url":"https://github.com/ironMann","followers_url":"https://api.github.com/users/ironMann/followers","following_url":"https://api.github.com/users/ironMann/following{/other_user}","gists_url":"https://api.github.com/users/ironMann/gists{/gist_id}","starred_url":"https://api.github.com/users/ironMann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironMann/subscriptions","organizations_url":"https://api.github.com/users/ironMann/orgs","repos_url":"https://api.github.com/users/ironMann/repos","events_url":"https://api.github.com/users/ironMann/events{/privacy}","received_events_url":"https://api.github.com/users/ironMann/received_events","type":"User","site_admin":false},"repo":{"id":34014985,"name":"zfs","full_name":"ironMann/zfs","owner":{"login":"ironMann","id":276684,"avatar_url":"https://avatars.githubusercontent.com/u/276684?v=3","gravatar_id":"","url":"https://api.github.com/users/ironMann","html_url":"https://github.com/ironMann","followers_url":"https://api.github.com/users/ironMann/followers","following_url":"https://api.github.com/users/ironMann/following{/other_user}","gists_url":"https://api.github.com/users/ironMann/gists{/gist_id}","starred_url":"https://api.github.com/users/ironMann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironMann/subscriptions","organizations_url":"https://api.github.com/users/ironMann/orgs","repos_url":"https://api.github.com/users/ironMann/repos","events_url":"https://api.github.com/users/ironMann/events{/privacy}","received_events_url":"https://api.github.com/users/ironMann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ironMann/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/ironMann/zfs","forks_url":"https://api.github.com/repos/ironMann/zfs/forks","keys_url":"https://api.github.com/repos/ironMann/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironMann/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironMann/zfs/teams","hooks_url":"https://api.github.com/repos/ironMann/zfs/hooks","issue_events_url":"https://api.github.com/repos/ironMann/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/ironMann/zfs/events","assignees_url":"https://api.github.com/repos/ironMann/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/ironMann/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/ironMann/zfs/tags","blobs_url":"https://api.github.com/repos/ironMann/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironMann/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironMann/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironMann/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironMann/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ironMann/zfs/languages","stargazers_url":"https://api.github.com/repos/ironMann/zfs/stargazers","contributors_url":"https://api.github.com/repos/ironMann/zfs/contributors","subscribers_url":"https://api.github.com/repos/ironMann/zfs/subscribers","subscription_url":"https://api.github.com/repos/ironMann/zfs/subscription","commits_url":"https://api.github.com/repos/ironMann/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironMann/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironMann/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironMann/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironMann/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/ironMann/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironMann/zfs/merges","archive_url":"https://api.github.com/repos/ironMann/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironMann/zfs/downloads","issues_url":"https://api.github.com/repos/ironMann/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/ironMann/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ironMann/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ironMann/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironMann/zfs/labels{/name}","releases_url":"https://api.github.com/repos/ironMann/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/ironMann/zfs/deployments","created_at":"2015-04-15T19:47:05Z","updated_at":"2016-02-10T14:11:48Z","pushed_at":"2016-07-12T16:16:30Z","git_url":"git://github.com/ironMann/zfs.git","ssh_url":"git@github.com:ironMann/zfs.git","clone_url":"https://github.com/ironMann/zfs.git","svn_url":"https://github.com/ironMann/zfs","homepage":"http://zfsonlinux.org/","size":30338,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"09fb30e5e91d9f2ed622db6b616084ce1d073384","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2016-07-12T04:53:58Z","pushed_at":"2016-07-12T18:02:59Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":55752,"stargazers_count":1875,"watchers_count":1875,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":477,"mirror_url":null,"open_issues_count":1063,"forks":477,"open_issues":1063,"watchers":1875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/4328"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4328"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/4328/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4328/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/a31e1d99826c071478d761058093297bdaa8ccd2"}}}}
{"actor":{"display_login":"ironMann"}}