{"action":"created","issue":{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/621","repository_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead","labels_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/621/labels{/name}","comments_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/621/comments","events_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/621/events","html_url":"https://github.com/DevExpress/testcafe-hammerhead/issues/621","id":158656091,"number":621,"title":"Code instrumentation window properties should be defined as non-enumerable and non-configurable","user":{"login":"inikulin","id":453071,"avatar_url":"https://avatars.githubusercontent.com/u/453071?v=3","gravatar_id":"","url":"https://api.github.com/users/inikulin","html_url":"https://github.com/inikulin","followers_url":"https://api.github.com/users/inikulin/followers","following_url":"https://api.github.com/users/inikulin/following{/other_user}","gists_url":"https://api.github.com/users/inikulin/gists{/gist_id}","starred_url":"https://api.github.com/users/inikulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikulin/subscriptions","organizations_url":"https://api.github.com/users/inikulin/orgs","repos_url":"https://api.github.com/users/inikulin/repos","events_url":"https://api.github.com/users/inikulin/events{/privacy}","received_events_url":"https://api.github.com/users/inikulin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/labels/AREA:%20client","name":"AREA: client","color":"fef2c0"},{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/labels/SYSTEM:%20sandbox","name":"SYSTEM: sandbox","color":"bfe5bf"},{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/labels/TYPE:%20enhancement","name":"TYPE: enhancement","color":"f7c6c7"}],"state":"open","locked":false,"assignee":{"login":"miherlosev","id":4133518,"avatar_url":"https://avatars.githubusercontent.com/u/4133518?v=3","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-06-06T11:27:37Z","updated_at":"2016-06-07T11:16:14Z","closed_at":null,"body":"Properties like https://github.com/DevExpress/testcafe-hammerhead/blob/master/src/client/sandbox/code-instrumentation/index.js#L38 should be defined this way https://github.com/DevExpress/testcafe-hammerhead/blob/master/src/client/index.js#L166\r\n\r\nI wonder if there will be any negative performance impact."},"comment":{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/comments/224250867","html_url":"https://github.com/DevExpress/testcafe-hammerhead/issues/621#issuecomment-224250867","issue_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/621","id":224250867,"user":{"login":"miherlosev","id":4133518,"avatar_url":"https://avatars.githubusercontent.com/u/4133518?v=3","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T11:16:14Z","updated_at":"2016-06-07T11:16:14Z","body":"Also we should mark all hammerhead specific window properties as non-enumerable, non-configurable and non-writable.\r\nFor example:\r\nhttps://github.com/DevExpress/testcafe-hammerhead/blob/master/src/client/sandbox/backup.js#L11\r\nhttps://github.com/DevExpress/testcafe-hammerhead/blob/master/src/client/sandbox/iframe.js#L84\r\netc."}}
{"actor":{"display_login":"miherlosev"}}