{"action":"created","issue":{"url":"https://api.github.com/repos/dxw/playbook/issues/34","repository_url":"https://api.github.com/repos/dxw/playbook","labels_url":"https://api.github.com/repos/dxw/playbook/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/dxw/playbook/issues/34/comments","events_url":"https://api.github.com/repos/dxw/playbook/issues/34/events","html_url":"https://github.com/dxw/playbook/pull/34","id":170487624,"number":34,"title":"Add note about using \"Fixes:\" in commit messages","user":{"login":"tomdxw","id":2256130,"avatar_url":"https://avatars.githubusercontent.com/u/2256130?v=3","gravatar_id":"","url":"https://api.github.com/users/tomdxw","html_url":"https://github.com/tomdxw","followers_url":"https://api.github.com/users/tomdxw/followers","following_url":"https://api.github.com/users/tomdxw/following{/other_user}","gists_url":"https://api.github.com/users/tomdxw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomdxw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomdxw/subscriptions","organizations_url":"https://api.github.com/users/tomdxw/orgs","repos_url":"https://api.github.com/users/tomdxw/repos","events_url":"https://api.github.com/users/tomdxw/events{/privacy}","received_events_url":"https://api.github.com/users/tomdxw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-10T18:36:51Z","updated_at":"2016-08-16T11:21:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dxw/playbook/pulls/34","html_url":"https://github.com/dxw/playbook/pull/34","diff_url":"https://github.com/dxw/playbook/pull/34.diff","patch_url":"https://github.com/dxw/playbook/pull/34.patch"},"body":"I've been using a mixture of `Ticket: https://dxw.zendesk.com/...`, `Story: https://www.pivotaltracker.com/...` and `Fixes: #123` (for GitHub issues) for a while now, but I'd like to standardise, and it would be good to get some consistency on this.\r\n\r\nOn the subject of commit squashing - I used to make very small commits, but as I've started to use TDD more I've gravitated to larger commits, and it seems like it's easier to write a detailed description for a monolithic commit than it is for microcommits. It also has a side-effect of making rebasing easier which makes my life easier, and will probably be much much easier for the less experienced git users."},"comment":{"url":"https://api.github.com/repos/dxw/playbook/issues/comments/240074635","html_url":"https://github.com/dxw/playbook/pull/34#issuecomment-240074635","issue_url":"https://api.github.com/repos/dxw/playbook/issues/34","id":240074635,"user":{"login":"harry-m","id":146397,"avatar_url":"https://avatars.githubusercontent.com/u/146397?v=3","gravatar_id":"","url":"https://api.github.com/users/harry-m","html_url":"https://github.com/harry-m","followers_url":"https://api.github.com/users/harry-m/followers","following_url":"https://api.github.com/users/harry-m/following{/other_user}","gists_url":"https://api.github.com/users/harry-m/gists{/gist_id}","starred_url":"https://api.github.com/users/harry-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harry-m/subscriptions","organizations_url":"https://api.github.com/users/harry-m/orgs","repos_url":"https://api.github.com/users/harry-m/repos","events_url":"https://api.github.com/users/harry-m/events{/privacy}","received_events_url":"https://api.github.com/users/harry-m/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T11:21:12Z","updated_at":"2016-08-16T11:21:12Z","body":"I agree with @tahb - happy to discuss but I don't think I like the idea of big commits either. For reasons:\r\n\r\n* It's harder to isolate and revert a specific change (like a bit of refactoring in the middle of a story)\r\n* It makes explanations of changes much less connected to the changes themselves. A big commit will change lots of things and each of those things might need a bit of explanation of its own. It's easier to see what explanation applies to what if the commits are smaller\r\n\r\nThat said, I'm not sure I'd immediately identify \"microcommits\" as being good either. I think the granularity should be appropriate for the task at hand."}}
{"actor":{"display_login":"harry-m"}}