{"action":"created","issue":{"url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/19","repository_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts","labels_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/19/comments","events_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/19/events","html_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/19","id":195646402,"number":19,"title":"Added cleanUpPreviousRoundUnitTest.js and startRoundUnitTest.js","user":{"login":"shine2lay","id":5243508,"avatar_url":"https://avatars.githubusercontent.com/u/5243508?v=3","gravatar_id":"","url":"https://api.github.com/users/shine2lay","html_url":"https://github.com/shine2lay","followers_url":"https://api.github.com/users/shine2lay/followers","following_url":"https://api.github.com/users/shine2lay/following{/other_user}","gists_url":"https://api.github.com/users/shine2lay/gists{/gist_id}","starred_url":"https://api.github.com/users/shine2lay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shine2lay/subscriptions","organizations_url":"https://api.github.com/users/shine2lay/orgs","repos_url":"https://api.github.com/users/shine2lay/repos","events_url":"https://api.github.com/users/shine2lay/events{/privacy}","received_events_url":"https://api.github.com/users/shine2lay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rmerom","id":650968,"avatar_url":"https://avatars.githubusercontent.com/u/650968?v=3","gravatar_id":"","url":"https://api.github.com/users/rmerom","html_url":"https://github.com/rmerom","followers_url":"https://api.github.com/users/rmerom/followers","following_url":"https://api.github.com/users/rmerom/following{/other_user}","gists_url":"https://api.github.com/users/rmerom/gists{/gist_id}","starred_url":"https://api.github.com/users/rmerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmerom/subscriptions","organizations_url":"https://api.github.com/users/rmerom/orgs","repos_url":"https://api.github.com/users/rmerom/repos","events_url":"https://api.github.com/users/rmerom/events{/privacy}","received_events_url":"https://api.github.com/users/rmerom/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmerom","id":650968,"avatar_url":"https://avatars.githubusercontent.com/u/650968?v=3","gravatar_id":"","url":"https://api.github.com/users/rmerom","html_url":"https://github.com/rmerom","followers_url":"https://api.github.com/users/rmerom/followers","following_url":"https://api.github.com/users/rmerom/following{/other_user}","gists_url":"https://api.github.com/users/rmerom/gists{/gist_id}","starred_url":"https://api.github.com/users/rmerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmerom/subscriptions","organizations_url":"https://api.github.com/users/rmerom/orgs","repos_url":"https://api.github.com/users/rmerom/repos","events_url":"https://api.github.com/users/rmerom/events{/privacy}","received_events_url":"https://api.github.com/users/rmerom/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-12-14T21:09:40Z","updated_at":"2016-12-15T07:34:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/pulls/19","html_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/19","diff_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/19.diff","patch_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/19.patch"},"body":"also a couple of minor fixes to migration script\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/wetrustplatform/rosca-contracts/19)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/comments/267258880","html_url":"https://github.com/WeTrustPlatform/rosca-contracts/pull/19#issuecomment-267258880","issue_url":"https://api.github.com/repos/WeTrustPlatform/rosca-contracts/issues/19","id":267258880,"user":{"login":"rmerom","id":650968,"avatar_url":"https://avatars.githubusercontent.com/u/650968?v=3","gravatar_id":"","url":"https://api.github.com/users/rmerom","html_url":"https://github.com/rmerom","followers_url":"https://api.github.com/users/rmerom/followers","following_url":"https://api.github.com/users/rmerom/following{/other_user}","gists_url":"https://api.github.com/users/rmerom/gists{/gist_id}","starred_url":"https://api.github.com/users/rmerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmerom/subscriptions","organizations_url":"https://api.github.com/users/rmerom/orgs","repos_url":"https://api.github.com/users/rmerom/repos","events_url":"https://api.github.com/users/rmerom/events{/privacy}","received_events_url":"https://api.github.com/users/rmerom/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T07:34:36Z","updated_at":"2016-12-15T07:34:36Z","body":"\n\n\n\nReview status: 4 of 6 files reviewed at latest revision, 10 unresolved discussions, some commit checks failed.\n\n---\n\n*[test/addMemberUnitTest.js, line 20 at r1](https://reviewable.io:443/reviews/wetrustplatform/rosca-contracts/19#-KYzAaaUsam9_FPwcSqB:-KZ0C7dnc1BLIIfTQCMT:b-9v09ft) ([raw file](https://github.com/wetrustplatform/rosca-contracts/blob/3bc00b11241f1b7e5b095dafb941ac90dd1e323d/test/addMemberUnitTest.js#L20)):*\n<details><summary><i>Previously, shine2lay wrote…</i></summary><blockquote>\n\nyou said to combine the two test cases together in the last PR,\n</blockquote></details>\n\nas discussed, consider removing return and breaking into 2 lines\n\n---\n\n*[test/cleanUpPreviousRoundUnitTest.js, line 46 at r1](https://reviewable.io:443/reviews/wetrustplatform/rosca-contracts/19#-KYzp-y7jW-PUVMlwIzI:-KZ0EHNQ6YoBzBA2QQIT:b-k4z1wq) ([raw file](https://github.com/wetrustplatform/rosca-contracts/blob/3bc00b11241f1b7e5b095dafb941ac90dd1e323d/test/cleanUpPreviousRoundUnitTest.js#L46)):*\n<details><summary><i>Previously, shine2lay wrote…</i></summary><blockquote>\n\nco is a function, and we usually have function name next to the \"(\" so i prefer to leave it that way \n</blockquote></details>\n\nas discussed\n\n---\n\n*[test/cleanUpPreviousRoundUnitTest.js, line 52 at r1](https://reviewable.io:443/reviews/wetrustplatform/rosca-contracts/19#-KYzqKzE52u32sEVT4Lh:-KZ0FmGZc0gFpDA5RfNB:b-k4z1wq) ([raw file](https://github.com/wetrustplatform/rosca-contracts/blob/3bc00b11241f1b7e5b095dafb941ac90dd1e323d/test/cleanUpPreviousRoundUnitTest.js#L52)):*\n<details><summary><i>Previously, shine2lay wrote…</i></summary><blockquote>\n\nits an arbitrary number, one is used as parameter for the function and one checks to make sure that the function behaves by adding the same value \n</blockquote></details>\n\nas discussed\n\n---\n\n*[test/cleanUpPreviousRoundUnitTest.js, line 52 at r2](https://reviewable.io:443/reviews/wetrustplatform/rosca-contracts/19#-KZ0IIzNUahhAg2RD0M-:-KZ0IIzOO8ZaM_jgORJU:b7d7wcs) ([raw file](https://github.com/wetrustplatform/rosca-contracts/blob/d66a381a05ee42df4030f5bd2af5b2c46007aa3c/test/cleanUpPreviousRoundUnitTest.js#L52)):*\n> ```JavaScript\n>             var user = yield rosca.members.call(log.args.winnerAddress);\n>             assert.equal(accounts[1], log.args.winnerAddress);\n>             assert.isOk(user[2], \"chosen address is not a member\");\n> ```\n\ncould you add a comment about what user[0], user[1], user[2] is?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/wetrustplatform/rosca-contracts/19)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"rmerom"}}