{"action":"opened","number":1120,"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1120","id":81702469,"html_url":"https://github.com/mozilla/activity-stream/pull/1120","diff_url":"https://github.com/mozilla/activity-stream/pull/1120.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/1120.patch","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1120","number":1120,"state":"open","locked":false,"title":"fix(test): #1046 Intermittent failures in PerfMeter","user":{"login":"ncloudioj","id":1455254,"avatar_url":"https://avatars.githubusercontent.com/u/1455254?v=3","gravatar_id":"","url":"https://api.github.com/users/ncloudioj","html_url":"https://github.com/ncloudioj","followers_url":"https://api.github.com/users/ncloudioj/followers","following_url":"https://api.github.com/users/ncloudioj/following{/other_user}","gists_url":"https://api.github.com/users/ncloudioj/gists{/gist_id}","starred_url":"https://api.github.com/users/ncloudioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncloudioj/subscriptions","organizations_url":"https://api.github.com/users/ncloudioj/orgs","repos_url":"https://api.github.com/users/ncloudioj/repos","events_url":"https://api.github.com/users/ncloudioj/events{/privacy}","received_events_url":"https://api.github.com/users/ncloudioj/received_events","type":"User","site_admin":false},"body":"There are two failures found in this unit test for Firefox 49+:\r\n* `tabData.tab` is undefined\r\n* the timeout failure when executing the line `yield promiseLoadURI(tab, \"about:about\")` in `test_PerfMeter_tab_restore`\r\n\r\nThe first one is due to the race condition where the `onShow` didn't get executed as the promise got resolved in the \"onNotify\".\r\n\r\nThe cause of the second failure is a little bit obscure, looks like `gBrowser.addTab(appUrl)` sometimes might take some time to do its job, calling `tab.linkBrowser.loadURI(uri)` before it's done will hit the timeout in this case.\r\n\r\nI think the similar issues exist in `test-TabTracker.js` as well, will fix it shortly.\r\n\r\n@oyiptong @emtwo @k88hudson can anyone r? it, please?","created_at":"2016-08-17T19:33:40Z","updated_at":"2016-08-17T19:33:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1120/commits","review_comments_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1120/comments","review_comment_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1120/comments","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/0ff6ae67c432120364ecdc7279ab3272be44b917","head":{"label":"ncloudioj:gh1046-test-failure-prefmeter","ref":"gh1046-test-failure-prefmeter","sha":"0ff6ae67c432120364ecdc7279ab3272be44b917","user":{"login":"ncloudioj","id":1455254,"avatar_url":"https://avatars.githubusercontent.com/u/1455254?v=3","gravatar_id":"","url":"https://api.github.com/users/ncloudioj","html_url":"https://github.com/ncloudioj","followers_url":"https://api.github.com/users/ncloudioj/followers","following_url":"https://api.github.com/users/ncloudioj/following{/other_user}","gists_url":"https://api.github.com/users/ncloudioj/gists{/gist_id}","starred_url":"https://api.github.com/users/ncloudioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncloudioj/subscriptions","organizations_url":"https://api.github.com/users/ncloudioj/orgs","repos_url":"https://api.github.com/users/ncloudioj/repos","events_url":"https://api.github.com/users/ncloudioj/events{/privacy}","received_events_url":"https://api.github.com/users/ncloudioj/received_events","type":"User","site_admin":false},"repo":{"id":55420605,"name":"activity-streams","full_name":"ncloudioj/activity-streams","owner":{"login":"ncloudioj","id":1455254,"avatar_url":"https://avatars.githubusercontent.com/u/1455254?v=3","gravatar_id":"","url":"https://api.github.com/users/ncloudioj","html_url":"https://github.com/ncloudioj","followers_url":"https://api.github.com/users/ncloudioj/followers","following_url":"https://api.github.com/users/ncloudioj/following{/other_user}","gists_url":"https://api.github.com/users/ncloudioj/gists{/gist_id}","starred_url":"https://api.github.com/users/ncloudioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncloudioj/subscriptions","organizations_url":"https://api.github.com/users/ncloudioj/orgs","repos_url":"https://api.github.com/users/ncloudioj/repos","events_url":"https://api.github.com/users/ncloudioj/events{/privacy}","received_events_url":"https://api.github.com/users/ncloudioj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncloudioj/activity-streams","description":" MVP prototype add-on for activity streams","fork":true,"url":"https://api.github.com/repos/ncloudioj/activity-streams","forks_url":"https://api.github.com/repos/ncloudioj/activity-streams/forks","keys_url":"https://api.github.com/repos/ncloudioj/activity-streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncloudioj/activity-streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncloudioj/activity-streams/teams","hooks_url":"https://api.github.com/repos/ncloudioj/activity-streams/hooks","issue_events_url":"https://api.github.com/repos/ncloudioj/activity-streams/issues/events{/number}","events_url":"https://api.github.com/repos/ncloudioj/activity-streams/events","assignees_url":"https://api.github.com/repos/ncloudioj/activity-streams/assignees{/user}","branches_url":"https://api.github.com/repos/ncloudioj/activity-streams/branches{/branch}","tags_url":"https://api.github.com/repos/ncloudioj/activity-streams/tags","blobs_url":"https://api.github.com/repos/ncloudioj/activity-streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncloudioj/activity-streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncloudioj/activity-streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncloudioj/activity-streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncloudioj/activity-streams/statuses/{sha}","languages_url":"https://api.github.com/repos/ncloudioj/activity-streams/languages","stargazers_url":"https://api.github.com/repos/ncloudioj/activity-streams/stargazers","contributors_url":"https://api.github.com/repos/ncloudioj/activity-streams/contributors","subscribers_url":"https://api.github.com/repos/ncloudioj/activity-streams/subscribers","subscription_url":"https://api.github.com/repos/ncloudioj/activity-streams/subscription","commits_url":"https://api.github.com/repos/ncloudioj/activity-streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncloudioj/activity-streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncloudioj/activity-streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncloudioj/activity-streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncloudioj/activity-streams/contents/{+path}","compare_url":"https://api.github.com/repos/ncloudioj/activity-streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncloudioj/activity-streams/merges","archive_url":"https://api.github.com/repos/ncloudioj/activity-streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncloudioj/activity-streams/downloads","issues_url":"https://api.github.com/repos/ncloudioj/activity-streams/issues{/number}","pulls_url":"https://api.github.com/repos/ncloudioj/activity-streams/pulls{/number}","milestones_url":"https://api.github.com/repos/ncloudioj/activity-streams/milestones{/number}","notifications_url":"https://api.github.com/repos/ncloudioj/activity-streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncloudioj/activity-streams/labels{/name}","releases_url":"https://api.github.com/repos/ncloudioj/activity-streams/releases{/id}","deployments_url":"https://api.github.com/repos/ncloudioj/activity-streams/deployments","created_at":"2016-04-04T15:02:16Z","updated_at":"2016-04-04T15:02:17Z","pushed_at":"2016-08-17T19:15:01Z","git_url":"git://github.com/ncloudioj/activity-streams.git","ssh_url":"git@github.com:ncloudioj/activity-streams.git","clone_url":"https://github.com/ncloudioj/activity-streams.git","svn_url":"https://github.com/ncloudioj/activity-streams","homepage":"","size":1741,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"a3bed72e83beb186658ab18ebb2d8d051be9adf5","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-stream","full_name":"mozilla/activity-stream","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-stream","description":" MVP prototype add-on for activity streams","fork":false,"url":"https://api.github.com/repos/mozilla/activity-stream","forks_url":"https://api.github.com/repos/mozilla/activity-stream/forks","keys_url":"https://api.github.com/repos/mozilla/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-stream/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-stream/events","assignees_url":"https://api.github.com/repos/mozilla/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-stream/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-stream/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-stream/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-stream/merges","archive_url":"https://api.github.com/repos/mozilla/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-stream/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-stream/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2016-08-08T03:03:22Z","pushed_at":"2016-08-17T19:33:41Z","git_url":"git://github.com/mozilla/activity-stream.git","ssh_url":"git@github.com:mozilla/activity-stream.git","clone_url":"https://github.com/mozilla/activity-stream.git","svn_url":"https://github.com/mozilla/activity-stream","homepage":"","size":2252,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":156,"forks":33,"open_issues":156,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/1120"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/1120"},"issue":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/1120"},"comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/1120/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/1120/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/1120/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/activity-stream/statuses/0ff6ae67c432120364ecdc7279ab3272be44b917"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":34,"deletions":21,"changed_files":1}}
{"actor":{"display_login":"ncloudioj"}}