{"action":"created","issue":{"url":"https://api.github.com/repos/18F/calc/issues/578","repository_url":"https://api.github.com/repos/18F/calc","labels_url":"https://api.github.com/repos/18F/calc/issues/578/labels{/name}","comments_url":"https://api.github.com/repos/18F/calc/issues/578/comments","events_url":"https://api.github.com/repos/18F/calc/issues/578/events","html_url":"https://github.com/18F/calc/pull/578","id":172136558,"number":578,"title":"Remove steps widget from the a11y tree.","user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/18F/calc/milestones/5","html_url":"https://github.com/18F/calc/milestones/September%209%20Sprint-palooza","labels_url":"https://api.github.com/repos/18F/calc/milestones/5/labels","id":1972147,"number":5,"title":"September 9 Sprint-palooza","description":"In this sprint, we will attempt to finish up Region 10 bulk upload, rejigger the form field order, and more.","creator":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":21,"state":"open","created_at":"2016-08-30T11:06:08Z","updated_at":"2016-09-14T12:06:02Z","due_on":"2016-09-09T00:00:00Z","closed_at":null},"comments":6,"created_at":"2016-08-19T13:54:50Z","updated_at":"2016-09-14T12:06:02Z","closed_at":"2016-09-14T12:06:02Z","pull_request":{"url":"https://api.github.com/repos/18F/calc/pulls/578","html_url":"https://github.com/18F/calc/pull/578","diff_url":"https://github.com/18F/calc/pull/578.diff","patch_url":"https://github.com/18F/calc/pull/578.patch"},"body":"Ok, this is *one* approach to fix #413--by simply removing the steps widget from the accessibility tree entirely.\r\n\r\nI think there's a decent argument for this: the fact that it's repeated on every step could get really annoying to vision-impaired users.  And we're always reiterating the current step via a `<h1>` or `<h2>` header on the page, so the user won't be lost if we hide the widget from them.  Hiding the widget also ensures that they won't be confused by it (which will currently be the case, since there's no way for them to tell which step they're currently on--it just sounds like a list of steps).\r\n\r\nIf this doesn't seem like a good idea to folks, we can go with the solution proposed in #413, whereby we add a `sr-only` \"You have completed this step\" / \"You are currently on this step\" / \"You haven't reached this step yet\" to every single list item.  But this will likely require writing a template helper or something, since it'll get extremely repetitive to write this out for every single step widget we use; as I mentioned earlier, I also have doubts as to the usefulness of even doing this.  It'd be nice to at least do some user testing before embarking on that path."},"comment":{"url":"https://api.github.com/repos/18F/calc/issues/comments/246992033","html_url":"https://github.com/18F/calc/pull/578#issuecomment-246992033","issue_url":"https://api.github.com/repos/18F/calc/issues/578","id":246992033,"user":{"login":"toolness","id":124687,"avatar_url":"https://avatars.githubusercontent.com/u/124687?v=3","gravatar_id":"","url":"https://api.github.com/users/toolness","html_url":"https://github.com/toolness","followers_url":"https://api.github.com/users/toolness/followers","following_url":"https://api.github.com/users/toolness/following{/other_user}","gists_url":"https://api.github.com/users/toolness/gists{/gist_id}","starred_url":"https://api.github.com/users/toolness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolness/subscriptions","organizations_url":"https://api.github.com/users/toolness/orgs","repos_url":"https://api.github.com/users/toolness/repos","events_url":"https://api.github.com/users/toolness/events{/privacy}","received_events_url":"https://api.github.com/users/toolness/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T12:06:01Z","updated_at":"2016-09-14T12:06:01Z","body":"This PR is superseded by #734."}}
{"actor":{"display_login":"toolness"}}