{"action":"created","comment":{"url":"https://api.github.com/repos/librenms/librenms/pulls/comments/79644774","id":79644774,"diff_hunk":"@@ -22,8 +22,8 @@\n global $config;\n \n //NET-SNMP-EXTEND-MIB::nsExtendOutLine.\\\"ups-nut\\\"\n-$ups_model = snmp_get($device, '.1.3.6.1.4.1.8072.1.3.2.4.1.2.7.117.112.115.45.110.117.116.5', '-Oqv');\n-$ups_serial = snmp_get($device, '.1.3.6.1.4.1.8072.1.3.2.4.1.2.7.117.112.115.45.110.117.116.6', '-Oqv');\n+$ups_model = snmp_get($device, '.1.3.6.1.4.1.8072.1.3.2.4.1.2.7.117.112.115.45.110.117.116.4', '-Oqv');","path":"html/pages/device/apps/ups-nut.inc.php","position":12,"original_position":6,"commit_id":"7d7621fd3e03b86eddc4777e31c611ef46dd299d","original_commit_id":"0dd523be45f00e8c3346a2ac9a91aa62948fd004","user":{"login":"murrant","id":39462,"avatar_url":"https://avatars.githubusercontent.com/u/39462?v=3","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"body":"Yeah, don't do that here.  It won't work for distributed setups and could cause slowness.","created_at":"2016-09-20T15:50:46Z","updated_at":"2016-09-20T15:50:46Z","html_url":"https://github.com/librenms/librenms/pull/4448#discussion_r79644774","pull_request_url":"https://api.github.com/repos/librenms/librenms/pulls/4448","_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments/79644774"},"html":{"href":"https://github.com/librenms/librenms/pull/4448#discussion_r79644774"},"pull_request":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4448"}}},"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/4448","id":85438637,"html_url":"https://github.com/librenms/librenms/pull/4448","diff_url":"https://github.com/librenms/librenms/pull/4448.diff","patch_url":"https://github.com/librenms/librenms/pull/4448.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/4448","number":4448,"state":"open","locked":false,"title":"app: ups-nut update 1","user":{"login":"crcro","id":3048315,"avatar_url":"https://avatars.githubusercontent.com/u/3048315?v=3","gravatar_id":"","url":"https://api.github.com/users/crcro","html_url":"https://github.com/crcro","followers_url":"https://api.github.com/users/crcro/followers","following_url":"https://api.github.com/users/crcro/following{/other_user}","gists_url":"https://api.github.com/users/crcro/gists{/gist_id}","starred_url":"https://api.github.com/users/crcro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crcro/subscriptions","organizations_url":"https://api.github.com/users/crcro/orgs","repos_url":"https://api.github.com/users/crcro/repos","events_url":"https://api.github.com/users/crcro/events{/privacy}","received_events_url":"https://api.github.com/users/crcro/received_events","type":"User","site_admin":false},"body":"#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you signed the [Contributors agreement](http://docs.librenms.org/General/Contributing/)\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n- removed battery_low\r\n- changed remaining time from seconds to minutes\r\n","created_at":"2016-09-15T16:39:55Z","updated_at":"2016-09-20T15:50:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fbc5d58ffcb2a7568cfc748c95ba5ef282e3852","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/4448/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/4448/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/4448/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/7d7621fd3e03b86eddc4777e31c611ef46dd299d","head":{"label":"crcro:app-ups-nut-update1","ref":"app-ups-nut-update1","sha":"7d7621fd3e03b86eddc4777e31c611ef46dd299d","user":{"login":"crcro","id":3048315,"avatar_url":"https://avatars.githubusercontent.com/u/3048315?v=3","gravatar_id":"","url":"https://api.github.com/users/crcro","html_url":"https://github.com/crcro","followers_url":"https://api.github.com/users/crcro/followers","following_url":"https://api.github.com/users/crcro/following{/other_user}","gists_url":"https://api.github.com/users/crcro/gists{/gist_id}","starred_url":"https://api.github.com/users/crcro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crcro/subscriptions","organizations_url":"https://api.github.com/users/crcro/orgs","repos_url":"https://api.github.com/users/crcro/repos","events_url":"https://api.github.com/users/crcro/events{/privacy}","received_events_url":"https://api.github.com/users/crcro/received_events","type":"User","site_admin":false},"repo":{"id":66878530,"name":"librenms","full_name":"crcro/librenms","owner":{"login":"crcro","id":3048315,"avatar_url":"https://avatars.githubusercontent.com/u/3048315?v=3","gravatar_id":"","url":"https://api.github.com/users/crcro","html_url":"https://github.com/crcro","followers_url":"https://api.github.com/users/crcro/followers","following_url":"https://api.github.com/users/crcro/following{/other_user}","gists_url":"https://api.github.com/users/crcro/gists{/gist_id}","starred_url":"https://api.github.com/users/crcro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crcro/subscriptions","organizations_url":"https://api.github.com/users/crcro/orgs","repos_url":"https://api.github.com/users/crcro/repos","events_url":"https://api.github.com/users/crcro/events{/privacy}","received_events_url":"https://api.github.com/users/crcro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crcro/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/crcro/librenms","forks_url":"https://api.github.com/repos/crcro/librenms/forks","keys_url":"https://api.github.com/repos/crcro/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crcro/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crcro/librenms/teams","hooks_url":"https://api.github.com/repos/crcro/librenms/hooks","issue_events_url":"https://api.github.com/repos/crcro/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/crcro/librenms/events","assignees_url":"https://api.github.com/repos/crcro/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/crcro/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/crcro/librenms/tags","blobs_url":"https://api.github.com/repos/crcro/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crcro/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crcro/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/crcro/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crcro/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/crcro/librenms/languages","stargazers_url":"https://api.github.com/repos/crcro/librenms/stargazers","contributors_url":"https://api.github.com/repos/crcro/librenms/contributors","subscribers_url":"https://api.github.com/repos/crcro/librenms/subscribers","subscription_url":"https://api.github.com/repos/crcro/librenms/subscription","commits_url":"https://api.github.com/repos/crcro/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/crcro/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/crcro/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/crcro/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/crcro/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/crcro/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crcro/librenms/merges","archive_url":"https://api.github.com/repos/crcro/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crcro/librenms/downloads","issues_url":"https://api.github.com/repos/crcro/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/crcro/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/crcro/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/crcro/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crcro/librenms/labels{/name}","releases_url":"https://api.github.com/repos/crcro/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/crcro/librenms/deployments","created_at":"2016-08-29T20:35:21Z","updated_at":"2016-08-29T20:36:15Z","pushed_at":"2016-09-20T00:37:45Z","git_url":"git://github.com/crcro/librenms.git","ssh_url":"git@github.com:crcro/librenms.git","clone_url":"https://github.com/crcro/librenms.git","svn_url":"https://github.com/crcro/librenms","homepage":"http://www.librenms.org/","size":74481,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"361732bfc203c8476c8baf4e6663963b53099cf6","user":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"name":"librenms","full_name":"librenms/librenms","owner":{"login":"librenms","id":5791783,"avatar_url":"https://avatars.githubusercontent.com/u/5791783?v=3","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/librenms/librenms/deployments","created_at":"2013-10-28T01:37:13Z","updated_at":"2016-09-20T14:04:25Z","pushed_at":"2016-09-20T15:28:11Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":103896,"stargazers_count":501,"watchers_count":501,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":316,"forks":331,"open_issues":316,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4448"},"html":{"href":"https://github.com/librenms/librenms/pull/4448"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/4448"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/4448/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4448/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/4448/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/7d7621fd3e03b86eddc4777e31c611ef46dd299d"}}}}
{"actor":{"display_login":"murrant"}}