{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/51404301","id":51404301,"diff_hunk":"@@ -16,7 +17,7 @@\n \n public class BackupableDBOptionsTest {\n \n-  private final static String ARBITRARY_PATH = \"/tmp\";\n+  private final static String ARBITRARY_PATH = Environment.isWindows() ? System.getenv(\"TEMP\") : \"/tmp\";","path":"java/src/test/java/org/rocksdb/BackupableDBOptionsTest.java","position":13,"original_position":13,"commit_id":"0d9d8ffea3816794af8dae7deb7e50e455bad8ac","original_commit_id":"0d9d8ffea3816794af8dae7deb7e50e455bad8ac","user":{"login":"koldat","id":16866502,"avatar_url":"https://avatars.githubusercontent.com/u/16866502?v=3","gravatar_id":"","url":"https://api.github.com/users/koldat","html_url":"https://github.com/koldat","followers_url":"https://api.github.com/users/koldat/followers","following_url":"https://api.github.com/users/koldat/following{/other_user}","gists_url":"https://api.github.com/users/koldat/gists{/gist_id}","starred_url":"https://api.github.com/users/koldat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldat/subscriptions","organizations_url":"https://api.github.com/users/koldat/orgs","repos_url":"https://api.github.com/users/koldat/repos","events_url":"https://api.github.com/users/koldat/events{/privacy}","received_events_url":"https://api.github.com/users/koldat/received_events","type":"User","site_admin":false},"body":"I did not want to change behavior for other platforms so I fixed only Windows. Yes I can change it.","created_at":"2016-02-01T10:58:30Z","updated_at":"2016-02-01T10:58:30Z","html_url":"https://github.com/facebook/rocksdb/pull/965#discussion_r51404301","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/965","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/51404301"},"html":{"href":"https://github.com/facebook/rocksdb/pull/965#discussion_r51404301"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/965"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/965","id":57512825,"html_url":"https://github.com/facebook/rocksdb/pull/965","diff_url":"https://github.com/facebook/rocksdb/pull/965.diff","patch_url":"https://github.com/facebook/rocksdb/pull/965.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/965","number":965,"state":"open","locked":false,"title":"Adding support for Windows JNI build","user":{"login":"koldat","id":16866502,"avatar_url":"https://avatars.githubusercontent.com/u/16866502?v=3","gravatar_id":"","url":"https://api.github.com/users/koldat","html_url":"https://github.com/koldat","followers_url":"https://api.github.com/users/koldat/followers","following_url":"https://api.github.com/users/koldat/following{/other_user}","gists_url":"https://api.github.com/users/koldat/gists{/gist_id}","starred_url":"https://api.github.com/users/koldat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldat/subscriptions","organizations_url":"https://api.github.com/users/koldat/orgs","repos_url":"https://api.github.com/users/koldat/repos","events_url":"https://api.github.com/users/koldat/events{/privacy}","received_events_url":"https://api.github.com/users/koldat/received_events","type":"User","site_admin":false},"body":"Initial support for building JNI library for Windows. Also some modification in Java unit tests to make it pass.\r\n\r\n@yuslepukhin I was modifying CMakeLists.txt to add support for Windows JNI build. Can you check if changes are OK?\r\n\r\n#703","created_at":"2016-01-28T14:56:30Z","updated_at":"2016-02-01T10:58:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a7a2550aef593a5b08b5ce596fd5e65cbe8ed63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/965/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/965/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/965/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/0d9d8ffea3816794af8dae7deb7e50e455bad8ac","head":{"label":"koldat:jni_for_windows","ref":"jni_for_windows","sha":"0d9d8ffea3816794af8dae7deb7e50e455bad8ac","user":{"login":"koldat","id":16866502,"avatar_url":"https://avatars.githubusercontent.com/u/16866502?v=3","gravatar_id":"","url":"https://api.github.com/users/koldat","html_url":"https://github.com/koldat","followers_url":"https://api.github.com/users/koldat/followers","following_url":"https://api.github.com/users/koldat/following{/other_user}","gists_url":"https://api.github.com/users/koldat/gists{/gist_id}","starred_url":"https://api.github.com/users/koldat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldat/subscriptions","organizations_url":"https://api.github.com/users/koldat/orgs","repos_url":"https://api.github.com/users/koldat/repos","events_url":"https://api.github.com/users/koldat/events{/privacy}","received_events_url":"https://api.github.com/users/koldat/received_events","type":"User","site_admin":false},"repo":{"id":50299642,"name":"rocksdb","full_name":"koldat/rocksdb","owner":{"login":"koldat","id":16866502,"avatar_url":"https://avatars.githubusercontent.com/u/16866502?v=3","gravatar_id":"","url":"https://api.github.com/users/koldat","html_url":"https://github.com/koldat","followers_url":"https://api.github.com/users/koldat/followers","following_url":"https://api.github.com/users/koldat/following{/other_user}","gists_url":"https://api.github.com/users/koldat/gists{/gist_id}","starred_url":"https://api.github.com/users/koldat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koldat/subscriptions","organizations_url":"https://api.github.com/users/koldat/orgs","repos_url":"https://api.github.com/users/koldat/repos","events_url":"https://api.github.com/users/koldat/events{/privacy}","received_events_url":"https://api.github.com/users/koldat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/koldat/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/koldat/rocksdb","forks_url":"https://api.github.com/repos/koldat/rocksdb/forks","keys_url":"https://api.github.com/repos/koldat/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koldat/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koldat/rocksdb/teams","hooks_url":"https://api.github.com/repos/koldat/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/koldat/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/koldat/rocksdb/events","assignees_url":"https://api.github.com/repos/koldat/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/koldat/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/koldat/rocksdb/tags","blobs_url":"https://api.github.com/repos/koldat/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koldat/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koldat/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/koldat/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koldat/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/koldat/rocksdb/languages","stargazers_url":"https://api.github.com/repos/koldat/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/koldat/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/koldat/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/koldat/rocksdb/subscription","commits_url":"https://api.github.com/repos/koldat/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/koldat/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/koldat/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/koldat/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/koldat/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/koldat/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koldat/rocksdb/merges","archive_url":"https://api.github.com/repos/koldat/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koldat/rocksdb/downloads","issues_url":"https://api.github.com/repos/koldat/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/koldat/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/koldat/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/koldat/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koldat/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/koldat/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/koldat/rocksdb/deployments","created_at":"2016-01-24T17:49:02Z","updated_at":"2016-01-24T17:49:06Z","pushed_at":"2016-01-28T14:50:49Z","git_url":"git://github.com/koldat/rocksdb.git","ssh_url":"git@github.com:koldat/rocksdb.git","clone_url":"https://github.com/koldat/rocksdb.git","svn_url":"https://github.com/koldat/rocksdb","homepage":"http://rocksdb.org","size":83663,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"4b50f135401710de452570d7cf8db3722ed88a34","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2016-02-01T06:46:24Z","pushed_at":"2016-02-01T02:12:34Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":88755,"stargazers_count":4734,"watchers_count":4734,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":930,"mirror_url":null,"open_issues_count":175,"forks":930,"open_issues":175,"watchers":4734,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/965"},"html":{"href":"https://github.com/facebook/rocksdb/pull/965"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/965"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/965/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/965/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/965/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/0d9d8ffea3816794af8dae7deb7e50e455bad8ac"}}}}