{"action":"created","issue":{"url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2036","repository_url":"https://api.github.com/repos/quodlibet/quodlibet","labels_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2036/labels{/name}","comments_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2036/comments","events_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2036/events","html_url":"https://github.com/quodlibet/quodlibet/pull/2036","id":177544485,"number":2036,"title":"Added ModeBar","user":{"login":"bernd-wechner","id":7296506,"avatar_url":"https://avatars.githubusercontent.com/u/7296506?v=3","gravatar_id":"","url":"https://api.github.com/users/bernd-wechner","html_url":"https://github.com/bernd-wechner","followers_url":"https://api.github.com/users/bernd-wechner/followers","following_url":"https://api.github.com/users/bernd-wechner/following{/other_user}","gists_url":"https://api.github.com/users/bernd-wechner/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd-wechner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd-wechner/subscriptions","organizations_url":"https://api.github.com/users/bernd-wechner/orgs","repos_url":"https://api.github.com/users/bernd-wechner/repos","events_url":"https://api.github.com/users/bernd-wechner/events{/privacy}","received_events_url":"https://api.github.com/users/bernd-wechner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-17T00:20:06Z","updated_at":"2016-09-20T00:58:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quodlibet/quodlibet/pulls/2036","html_url":"https://github.com/quodlibet/quodlibet/pull/2036","diff_url":"https://github.com/quodlibet/quodlibet/pull/2036.diff","patch_url":"https://github.com/quodlibet/quodlibet/pull/2036.patch"},"body":"My very first QL patch. Am getting my head around git, and github in the process and trying to set up up a workflow. \r\n\r\nAm very open to feedback. But also seriopusly appreciate accepting the request. Happy to modify it so it's optional if preferred, and take advice on how to make it optional. Or to look at internationalizing the label (could not see how to do that easily) or otherwise to make it fit the visions of look and feel I guess.\r\n\r\nReal estate in this area is abundant on any normal sized screen and I found the two mode buttons cryptic at first and find their status hard to see (contrast between up and down images is low). So I added a very rough shod simple text statement as to the current mode. \r\n\r\nAll feedback or improvement suggestions welcome. Am testing the ropes wit QL, PyDev and Git.."},"comment":{"url":"https://api.github.com/repos/quodlibet/quodlibet/issues/comments/248172380","html_url":"https://github.com/quodlibet/quodlibet/pull/2036#issuecomment-248172380","issue_url":"https://api.github.com/repos/quodlibet/quodlibet/issues/2036","id":248172380,"user":{"login":"bernd-wechner","id":7296506,"avatar_url":"https://avatars.githubusercontent.com/u/7296506?v=3","gravatar_id":"","url":"https://api.github.com/users/bernd-wechner","html_url":"https://github.com/bernd-wechner","followers_url":"https://api.github.com/users/bernd-wechner/followers","following_url":"https://api.github.com/users/bernd-wechner/following{/other_user}","gists_url":"https://api.github.com/users/bernd-wechner/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd-wechner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd-wechner/subscriptions","organizations_url":"https://api.github.com/users/bernd-wechner/orgs","repos_url":"https://api.github.com/users/bernd-wechner/repos","events_url":"https://api.github.com/users/bernd-wechner/events{/privacy}","received_events_url":"https://api.github.com/users/bernd-wechner/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T00:58:16Z","updated_at":"2016-09-20T00:58:16Z","body":"Thanks for the feedback so far. Very much appreciated (Am well into a rework of the library scanner on another local branch right now, more on that to come).\r\n\r\nAm rearing to fix this one though as suggested. But some questions if you can spare a moment to handhold a rapidly upskilling newb:\r\n\r\n@lazka \r\n\r\n1) What do you mean by `\"%(repeat)s and %(shuffle)s\"` ? \r\nI'd have though plurals and 'and' are all language specific so a conjunction like `\" \" + _(\"and\") + \" \" ` seems appropriate.\r\n\r\n2) WRT IMO a text feedback is pretty customary on other players and makes it readily visible. That said in my experience it's usually near the what's playing features, that show you the playing track etc, and it might be more at home there. For now was aiming at a MVP (minimum viable product) for a newb to offer up and get comment on.\r\n\r\n@declension \r\n\r\n3) Sounds great and I like. I'll look at a prefs widget to propose as that's an area I want to upskill in. But if UI clutter is an issue, a config file setting with no UI is an option too. It is Quod Libet after all, Whatever You Like ... and that's one reason I've landed with it, namely a confidence that the community culture at least supports mainlining configurability to individual tastes and preferences.\r\n\r\n4) Any tips on how to divine the current nuance of Repeat and Shuffle modes would please me, but I'll poke around too in the iterim. Reason I ask is the Repeat button I see (and I'm only using on browser, the File System one for now) simply toggles on/off doesn't have any nuancal options and Shuffle has only two `In Order` and `One Song` and I admit I find that wholly cryptic (i.e. I have no idea what it means). \r\n\r\n5) Rendering in parenthesis or not or fonts or location is all up for advice as I'm pretty unfussed. The UX desire is to see clearly with a glance at screen the current play mode I guess. That's what I'm angling for.\r\n\r\n6) Will read #1411 later. A quick check now suggests much to digest and I'm not focussed enough right now.\r\n\r\n7) As a total side observation `_` seems overloaded sadly, which surprised me for a language that doesn't support overloading ;-). But I'm getting warnings on unused variables on a list unpack from a function/generator return and so I reflexively replace that variable with `_`. Which is the custom and works fine. But if that is done in the class then the `_` can no longer be used for internationalization. Odd. At a  total guess for now I just named it dummy and I get no more unused variable warning (seems the semantics of that name are respected). Ah, am still learning python after a year or two of coding with it - but have never done internationalization before I guess)"}}
{"actor":{"display_login":"bernd-wechner"}}