{"action":"created","comment":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments/73784157","id":73784157,"diff_hunk":"@@ -58,18 +59,21 @@ public PermissionsPage() {\n \t\tdisableLink(this.permissionsPageLink);\n \t}\n \n-\tpublic PermissionsPage(final GbUser taSelected) {\n-\t\tdisableLink(this.permissionsPageLink);\n-\t\tthis.taSelected = taSelected;\n-\t}\n-\n \t@Override\n \tpublic void onInitialize() {\n \t\tsuper.onInitialize();\n \n+\t\t// grab the selected parameter (if provided)\n+\t\tfinal PageParameters params = getPageParameters();\n+\t\tfinal Optional<String> taUuid = Optional.ofNullable(params.get(\"selected\").toOptionalString());","path":"gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/pages/PermissionsPage.java","position":41,"original_position":41,"commit_id":"5778d4a1066ba990cd831cc36f821661c208f593","original_commit_id":"5778d4a1066ba990cd831cc36f821661c208f593","user":{"login":"steveswinsburg","id":129129,"avatar_url":"https://avatars.githubusercontent.com/u/129129?v=3","gravatar_id":"","url":"https://api.github.com/users/steveswinsburg","html_url":"https://github.com/steveswinsburg","followers_url":"https://api.github.com/users/steveswinsburg/followers","following_url":"https://api.github.com/users/steveswinsburg/following{/other_user}","gists_url":"https://api.github.com/users/steveswinsburg/gists{/gist_id}","starred_url":"https://api.github.com/users/steveswinsburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveswinsburg/subscriptions","organizations_url":"https://api.github.com/users/steveswinsburg/orgs","repos_url":"https://api.github.com/users/steveswinsburg/repos","events_url":"https://api.github.com/users/steveswinsburg/events{/privacy}","received_events_url":"https://api.github.com/users/steveswinsburg/received_events","type":"User","site_admin":false},"body":"is the Optional required? Can't this just be a String?","created_at":"2016-08-06T10:22:25Z","updated_at":"2016-08-06T10:22:25Z","html_url":"https://github.com/sakaiproject/sakai/pull/3141#discussion_r73784157","pull_request_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141","_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments/73784157"},"html":{"href":"https://github.com/sakaiproject/sakai/pull/3141#discussion_r73784157"},"pull_request":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141"}}},"pull_request":{"url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141","id":80175246,"html_url":"https://github.com/sakaiproject/sakai/pull/3141","diff_url":"https://github.com/sakaiproject/sakai/pull/3141.diff","patch_url":"https://github.com/sakaiproject/sakai/pull/3141.patch","issue_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3141","number":3141,"state":"open","locked":false,"title":"3116 fixes Firefox form POST issues","user":{"login":"payten","id":608337,"avatar_url":"https://avatars.githubusercontent.com/u/608337?v=3","gravatar_id":"","url":"https://api.github.com/users/payten","html_url":"https://github.com/payten","followers_url":"https://api.github.com/users/payten/followers","following_url":"https://api.github.com/users/payten/following{/other_user}","gists_url":"https://api.github.com/users/payten/gists{/gist_id}","starred_url":"https://api.github.com/users/payten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payten/subscriptions","organizations_url":"https://api.github.com/users/payten/orgs","repos_url":"https://api.github.com/users/payten/repos","events_url":"https://api.github.com/users/payten/events{/privacy}","received_events_url":"https://api.github.com/users/payten/received_events","type":"User","site_admin":false},"body":"Delivers #3116.\r\n\r\nThis fixes a Firefox bug, whereby navigating the GradebookNG tool and returning to the Grades sepreadsheet causes all subsequent POST requests to fail with a 302 redirect.\r\n\r\nTo fix, set mount points for the 4 GradebookNG pages, so the base page is always consistent.  Secondly, use the class variant of setResponsePage to navigate to those mount points.\r\n\r\nI haven't set a milestone yet.. 11.2 so we can get some reasonable testing in?","created_at":"2016-08-05T01:19:53Z","updated_at":"2016-08-06T10:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd6dc2c747e2f5a34043577b2f14ffa8e370910b","assignee":{"login":"steveswinsburg","id":129129,"avatar_url":"https://avatars.githubusercontent.com/u/129129?v=3","gravatar_id":"","url":"https://api.github.com/users/steveswinsburg","html_url":"https://github.com/steveswinsburg","followers_url":"https://api.github.com/users/steveswinsburg/followers","following_url":"https://api.github.com/users/steveswinsburg/following{/other_user}","gists_url":"https://api.github.com/users/steveswinsburg/gists{/gist_id}","starred_url":"https://api.github.com/users/steveswinsburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveswinsburg/subscriptions","organizations_url":"https://api.github.com/users/steveswinsburg/orgs","repos_url":"https://api.github.com/users/steveswinsburg/repos","events_url":"https://api.github.com/users/steveswinsburg/events{/privacy}","received_events_url":"https://api.github.com/users/steveswinsburg/received_events","type":"User","site_admin":false},"assignees":[{"login":"steveswinsburg","id":129129,"avatar_url":"https://avatars.githubusercontent.com/u/129129?v=3","gravatar_id":"","url":"https://api.github.com/users/steveswinsburg","html_url":"https://github.com/steveswinsburg","followers_url":"https://api.github.com/users/steveswinsburg/followers","following_url":"https://api.github.com/users/steveswinsburg/following{/other_user}","gists_url":"https://api.github.com/users/steveswinsburg/gists{/gist_id}","starred_url":"https://api.github.com/users/steveswinsburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveswinsburg/subscriptions","organizations_url":"https://api.github.com/users/steveswinsburg/orgs","repos_url":"https://api.github.com/users/steveswinsburg/repos","events_url":"https://api.github.com/users/steveswinsburg/events{/privacy}","received_events_url":"https://api.github.com/users/steveswinsburg/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141/commits","review_comments_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141/comments","review_comment_url":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/issues/3141/comments","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/5778d4a1066ba990cd831cc36f821661c208f593","head":{"label":"payten:3116-firefox-post-issue","ref":"3116-firefox-post-issue","sha":"5778d4a1066ba990cd831cc36f821661c208f593","user":{"login":"payten","id":608337,"avatar_url":"https://avatars.githubusercontent.com/u/608337?v=3","gravatar_id":"","url":"https://api.github.com/users/payten","html_url":"https://github.com/payten","followers_url":"https://api.github.com/users/payten/followers","following_url":"https://api.github.com/users/payten/following{/other_user}","gists_url":"https://api.github.com/users/payten/gists{/gist_id}","starred_url":"https://api.github.com/users/payten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payten/subscriptions","organizations_url":"https://api.github.com/users/payten/orgs","repos_url":"https://api.github.com/users/payten/repos","events_url":"https://api.github.com/users/payten/events{/privacy}","received_events_url":"https://api.github.com/users/payten/received_events","type":"User","site_admin":false},"repo":{"id":35420318,"name":"sakai","full_name":"payten/sakai","owner":{"login":"payten","id":608337,"avatar_url":"https://avatars.githubusercontent.com/u/608337?v=3","gravatar_id":"","url":"https://api.github.com/users/payten","html_url":"https://github.com/payten","followers_url":"https://api.github.com/users/payten/followers","following_url":"https://api.github.com/users/payten/following{/other_user}","gists_url":"https://api.github.com/users/payten/gists{/gist_id}","starred_url":"https://api.github.com/users/payten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payten/subscriptions","organizations_url":"https://api.github.com/users/payten/orgs","repos_url":"https://api.github.com/users/payten/repos","events_url":"https://api.github.com/users/payten/events{/privacy}","received_events_url":"https://api.github.com/users/payten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/payten/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":true,"url":"https://api.github.com/repos/payten/sakai","forks_url":"https://api.github.com/repos/payten/sakai/forks","keys_url":"https://api.github.com/repos/payten/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payten/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payten/sakai/teams","hooks_url":"https://api.github.com/repos/payten/sakai/hooks","issue_events_url":"https://api.github.com/repos/payten/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/payten/sakai/events","assignees_url":"https://api.github.com/repos/payten/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/payten/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/payten/sakai/tags","blobs_url":"https://api.github.com/repos/payten/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payten/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payten/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/payten/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payten/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/payten/sakai/languages","stargazers_url":"https://api.github.com/repos/payten/sakai/stargazers","contributors_url":"https://api.github.com/repos/payten/sakai/contributors","subscribers_url":"https://api.github.com/repos/payten/sakai/subscribers","subscription_url":"https://api.github.com/repos/payten/sakai/subscription","commits_url":"https://api.github.com/repos/payten/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/payten/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/payten/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/payten/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/payten/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/payten/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payten/sakai/merges","archive_url":"https://api.github.com/repos/payten/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payten/sakai/downloads","issues_url":"https://api.github.com/repos/payten/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/payten/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/payten/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/payten/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payten/sakai/labels{/name}","releases_url":"https://api.github.com/repos/payten/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/payten/sakai/deployments","created_at":"2015-05-11T11:40:24Z","updated_at":"2015-05-11T11:41:11Z","pushed_at":"2016-08-05T06:48:44Z","git_url":"git://github.com/payten/sakai.git","ssh_url":"git@github.com:payten/sakai.git","clone_url":"https://github.com/payten/sakai.git","svn_url":"https://github.com/payten/sakai","homepage":"https://www.sakaiproject.org","size":369386,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sakaiproject:master","ref":"master","sha":"ea1d829cb9f9c7bdb15be8a813b486c214c86b98","user":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars.githubusercontent.com/u/314726?v=3","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"repo":{"id":28589709,"name":"sakai","full_name":"sakaiproject/sakai","owner":{"login":"sakaiproject","id":314726,"avatar_url":"https://avatars.githubusercontent.com/u/314726?v=3","gravatar_id":"","url":"https://api.github.com/users/sakaiproject","html_url":"https://github.com/sakaiproject","followers_url":"https://api.github.com/users/sakaiproject/followers","following_url":"https://api.github.com/users/sakaiproject/following{/other_user}","gists_url":"https://api.github.com/users/sakaiproject/gists{/gist_id}","starred_url":"https://api.github.com/users/sakaiproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakaiproject/subscriptions","organizations_url":"https://api.github.com/users/sakaiproject/orgs","repos_url":"https://api.github.com/users/sakaiproject/repos","events_url":"https://api.github.com/users/sakaiproject/events{/privacy}","received_events_url":"https://api.github.com/users/sakaiproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sakaiproject/sakai","description":"Sakai is a freely available, feature-rich technology solution for learning, teaching, research and collaboration. Sakai is an open source software suite developed by a diverse and global adopter community.","fork":false,"url":"https://api.github.com/repos/sakaiproject/sakai","forks_url":"https://api.github.com/repos/sakaiproject/sakai/forks","keys_url":"https://api.github.com/repos/sakaiproject/sakai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakaiproject/sakai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakaiproject/sakai/teams","hooks_url":"https://api.github.com/repos/sakaiproject/sakai/hooks","issue_events_url":"https://api.github.com/repos/sakaiproject/sakai/issues/events{/number}","events_url":"https://api.github.com/repos/sakaiproject/sakai/events","assignees_url":"https://api.github.com/repos/sakaiproject/sakai/assignees{/user}","branches_url":"https://api.github.com/repos/sakaiproject/sakai/branches{/branch}","tags_url":"https://api.github.com/repos/sakaiproject/sakai/tags","blobs_url":"https://api.github.com/repos/sakaiproject/sakai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakaiproject/sakai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakaiproject/sakai/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakaiproject/sakai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakaiproject/sakai/statuses/{sha}","languages_url":"https://api.github.com/repos/sakaiproject/sakai/languages","stargazers_url":"https://api.github.com/repos/sakaiproject/sakai/stargazers","contributors_url":"https://api.github.com/repos/sakaiproject/sakai/contributors","subscribers_url":"https://api.github.com/repos/sakaiproject/sakai/subscribers","subscription_url":"https://api.github.com/repos/sakaiproject/sakai/subscription","commits_url":"https://api.github.com/repos/sakaiproject/sakai/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakaiproject/sakai/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakaiproject/sakai/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakaiproject/sakai/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakaiproject/sakai/contents/{+path}","compare_url":"https://api.github.com/repos/sakaiproject/sakai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakaiproject/sakai/merges","archive_url":"https://api.github.com/repos/sakaiproject/sakai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakaiproject/sakai/downloads","issues_url":"https://api.github.com/repos/sakaiproject/sakai/issues{/number}","pulls_url":"https://api.github.com/repos/sakaiproject/sakai/pulls{/number}","milestones_url":"https://api.github.com/repos/sakaiproject/sakai/milestones{/number}","notifications_url":"https://api.github.com/repos/sakaiproject/sakai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakaiproject/sakai/labels{/name}","releases_url":"https://api.github.com/repos/sakaiproject/sakai/releases{/id}","deployments_url":"https://api.github.com/repos/sakaiproject/sakai/deployments","created_at":"2014-12-29T11:14:17Z","updated_at":"2016-08-01T21:10:49Z","pushed_at":"2016-08-06T10:20:37Z","git_url":"git://github.com/sakaiproject/sakai.git","ssh_url":"git@github.com:sakaiproject/sakai.git","clone_url":"https://github.com/sakaiproject/sakai.git","svn_url":"https://github.com/sakaiproject/sakai","homepage":"https://www.sakaiproject.org","size":334339,"stargazers_count":153,"watchers_count":153,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":285,"mirror_url":null,"open_issues_count":75,"forks":285,"open_issues":75,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141"},"html":{"href":"https://github.com/sakaiproject/sakai/pull/3141"},"issue":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/3141"},"comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/issues/3141/comments"},"review_comments":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141/comments"},"review_comment":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sakaiproject/sakai/pulls/3141/commits"},"statuses":{"href":"https://api.github.com/repos/sakaiproject/sakai/statuses/5778d4a1066ba990cd831cc36f821661c208f593"}}}}
{"actor":{"display_login":"steveswinsburg"}}