{"action":"closed","issue":{"url":"https://api.github.com/repos/happner/happner/issues/107","repository_url":"https://api.github.com/repos/happner/happner","labels_url":"https://api.github.com/repos/happner/happner/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/happner/happner/issues/107/comments","events_url":"https://api.github.com/repos/happner/happner/issues/107/events","html_url":"https://github.com/happner/happner/issues/107","id":159361251,"number":107,"title":"deprecate use of .off() with path argument","user":{"login":"JensEggers","id":2249070,"avatar_url":"https://avatars.githubusercontent.com/u/2249070?v=3","gravatar_id":"","url":"https://api.github.com/users/JensEggers","html_url":"https://github.com/JensEggers","followers_url":"https://api.github.com/users/JensEggers/followers","following_url":"https://api.github.com/users/JensEggers/following{/other_user}","gists_url":"https://api.github.com/users/JensEggers/gists{/gist_id}","starred_url":"https://api.github.com/users/JensEggers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JensEggers/subscriptions","organizations_url":"https://api.github.com/users/JensEggers/orgs","repos_url":"https://api.github.com/users/JensEggers/repos","events_url":"https://api.github.com/users/JensEggers/events{/privacy}","received_events_url":"https://api.github.com/users/JensEggers/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/happner/happner/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":{"login":"southbite","id":1958406,"avatar_url":"https://avatars.githubusercontent.com/u/1958406?v=3","gravatar_id":"","url":"https://api.github.com/users/southbite","html_url":"https://github.com/southbite","followers_url":"https://api.github.com/users/southbite/followers","following_url":"https://api.github.com/users/southbite/following{/other_user}","gists_url":"https://api.github.com/users/southbite/gists{/gist_id}","starred_url":"https://api.github.com/users/southbite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southbite/subscriptions","organizations_url":"https://api.github.com/users/southbite/orgs","repos_url":"https://api.github.com/users/southbite/repos","events_url":"https://api.github.com/users/southbite/events{/privacy}","received_events_url":"https://api.github.com/users/southbite/received_events","type":"User","site_admin":false},"assignees":[{"login":"southbite","id":1958406,"avatar_url":"https://avatars.githubusercontent.com/u/1958406?v=3","gravatar_id":"","url":"https://api.github.com/users/southbite","html_url":"https://github.com/southbite","followers_url":"https://api.github.com/users/southbite/followers","following_url":"https://api.github.com/users/southbite/following{/other_user}","gists_url":"https://api.github.com/users/southbite/gists{/gist_id}","starred_url":"https://api.github.com/users/southbite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/southbite/subscriptions","organizations_url":"https://api.github.com/users/southbite/orgs","repos_url":"https://api.github.com/users/southbite/repos","events_url":"https://api.github.com/users/southbite/events{/privacy}","received_events_url":"https://api.github.com/users/southbite/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-06-09T09:12:41Z","updated_at":"2016-07-14T12:00:53Z","closed_at":"2016-07-14T12:00:53Z","body":"This applies to data and events (I believe): .off() called with a path removes all listeners .off() called with a handle removes only the listener identified by the handle. This is confusing and causes unexpected and hard to find problems. Instead, let us follow the Node.js convention: ``` emitter.removeListener(event, listener) emitter.removeAllListeners([event]) ``` Changes: - deprecate the use of .off() with a path argument - add a new function (.offAll() - haha, think of something better) that accepts only a path argument and removes all listeners"}}
{"actor":{"display_login":"southbite"}}