{"action":"opened","number":883,"pull_request":{"url":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/883","id":87004562,"html_url":"https://github.com/jazzband/django-debug-toolbar/pull/883","diff_url":"https://github.com/jazzband/django-debug-toolbar/pull/883.diff","patch_url":"https://github.com/jazzband/django-debug-toolbar/pull/883.patch","issue_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/issues/883","number":883,"state":"open","locked":false,"title":"use HMAC and timing safe comparison","user":{"login":"zt-initech","id":6264272,"avatar_url":"https://avatars.githubusercontent.com/u/6264272?v=3","gravatar_id":"","url":"https://api.github.com/users/zt-initech","html_url":"https://github.com/zt-initech","followers_url":"https://api.github.com/users/zt-initech/followers","following_url":"https://api.github.com/users/zt-initech/following{/other_user}","gists_url":"https://api.github.com/users/zt-initech/gists{/gist_id}","starred_url":"https://api.github.com/users/zt-initech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zt-initech/subscriptions","organizations_url":"https://api.github.com/users/zt-initech/orgs","repos_url":"https://api.github.com/users/zt-initech/repos","events_url":"https://api.github.com/users/zt-initech/events{/privacy}","received_events_url":"https://api.github.com/users/zt-initech/received_events","type":"User","site_admin":false},"body":"Instead of naive code vulnerable to length-extension attack and instead of short-circuiting string comparison.\r\n\r\nhttps://en.wikipedia.org/wiki/Hash-based_message_authentication_code#Design_principles\r\n\r\nhttps://docs.python.org/2/library/hmac.html#hmac.compare_digest","created_at":"2016-09-27T20:21:54Z","updated_at":"2016-09-27T20:21:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/883/commits","review_comments_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/883/comments","review_comment_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/issues/883/comments","statuses_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/statuses/d27d8174c9aea8858c492c357e2b46559306364b","head":{"label":"zt-initech:hmac","ref":"hmac","sha":"d27d8174c9aea8858c492c357e2b46559306364b","user":{"login":"zt-initech","id":6264272,"avatar_url":"https://avatars.githubusercontent.com/u/6264272?v=3","gravatar_id":"","url":"https://api.github.com/users/zt-initech","html_url":"https://github.com/zt-initech","followers_url":"https://api.github.com/users/zt-initech/followers","following_url":"https://api.github.com/users/zt-initech/following{/other_user}","gists_url":"https://api.github.com/users/zt-initech/gists{/gist_id}","starred_url":"https://api.github.com/users/zt-initech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zt-initech/subscriptions","organizations_url":"https://api.github.com/users/zt-initech/orgs","repos_url":"https://api.github.com/users/zt-initech/repos","events_url":"https://api.github.com/users/zt-initech/events{/privacy}","received_events_url":"https://api.github.com/users/zt-initech/received_events","type":"User","site_admin":false},"repo":{"id":69289143,"name":"django-debug-toolbar","full_name":"zt-initech/django-debug-toolbar","owner":{"login":"zt-initech","id":6264272,"avatar_url":"https://avatars.githubusercontent.com/u/6264272?v=3","gravatar_id":"","url":"https://api.github.com/users/zt-initech","html_url":"https://github.com/zt-initech","followers_url":"https://api.github.com/users/zt-initech/followers","following_url":"https://api.github.com/users/zt-initech/following{/other_user}","gists_url":"https://api.github.com/users/zt-initech/gists{/gist_id}","starred_url":"https://api.github.com/users/zt-initech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zt-initech/subscriptions","organizations_url":"https://api.github.com/users/zt-initech/orgs","repos_url":"https://api.github.com/users/zt-initech/repos","events_url":"https://api.github.com/users/zt-initech/events{/privacy}","received_events_url":"https://api.github.com/users/zt-initech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zt-initech/django-debug-toolbar","description":"A configurable set of panels that display various debug information about the current request/response.","fork":true,"url":"https://api.github.com/repos/zt-initech/django-debug-toolbar","forks_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/forks","keys_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/teams","hooks_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/hooks","issue_events_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/issues/events{/number}","events_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/events","assignees_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/assignees{/user}","branches_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/branches{/branch}","tags_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/tags","blobs_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/statuses/{sha}","languages_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/languages","stargazers_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/stargazers","contributors_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/contributors","subscribers_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/subscribers","subscription_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/subscription","commits_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/contents/{+path}","compare_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/merges","archive_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/downloads","issues_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/issues{/number}","pulls_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/pulls{/number}","milestones_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/milestones{/number}","notifications_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/labels{/name}","releases_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/releases{/id}","deployments_url":"https://api.github.com/repos/zt-initech/django-debug-toolbar/deployments","created_at":"2016-09-26T20:16:55Z","updated_at":"2016-09-26T20:16:57Z","pushed_at":"2016-09-27T20:18:07Z","git_url":"git://github.com/zt-initech/django-debug-toolbar.git","ssh_url":"git@github.com:zt-initech/django-debug-toolbar.git","clone_url":"https://github.com/zt-initech/django-debug-toolbar.git","svn_url":"https://github.com/zt-initech/django-debug-toolbar","homepage":"https://django-debug-toolbar.readthedocs.io/","size":3495,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jazzband:master","ref":"master","sha":"637b0b73bc684f6ea600dca5ca1bb1f090fcee93","user":{"login":"jazzband","id":15129049,"avatar_url":"https://avatars.githubusercontent.com/u/15129049?v=3","gravatar_id":"","url":"https://api.github.com/users/jazzband","html_url":"https://github.com/jazzband","followers_url":"https://api.github.com/users/jazzband/followers","following_url":"https://api.github.com/users/jazzband/following{/other_user}","gists_url":"https://api.github.com/users/jazzband/gists{/gist_id}","starred_url":"https://api.github.com/users/jazzband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jazzband/subscriptions","organizations_url":"https://api.github.com/users/jazzband/orgs","repos_url":"https://api.github.com/users/jazzband/repos","events_url":"https://api.github.com/users/jazzband/events{/privacy}","received_events_url":"https://api.github.com/users/jazzband/received_events","type":"Organization","site_admin":false},"repo":{"id":46939,"name":"django-debug-toolbar","full_name":"jazzband/django-debug-toolbar","owner":{"login":"jazzband","id":15129049,"avatar_url":"https://avatars.githubusercontent.com/u/15129049?v=3","gravatar_id":"","url":"https://api.github.com/users/jazzband","html_url":"https://github.com/jazzband","followers_url":"https://api.github.com/users/jazzband/followers","following_url":"https://api.github.com/users/jazzband/following{/other_user}","gists_url":"https://api.github.com/users/jazzband/gists{/gist_id}","starred_url":"https://api.github.com/users/jazzband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jazzband/subscriptions","organizations_url":"https://api.github.com/users/jazzband/orgs","repos_url":"https://api.github.com/users/jazzband/repos","events_url":"https://api.github.com/users/jazzband/events{/privacy}","received_events_url":"https://api.github.com/users/jazzband/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jazzband/django-debug-toolbar","description":"A configurable set of panels that display various debug information about the current request/response.","fork":false,"url":"https://api.github.com/repos/jazzband/django-debug-toolbar","forks_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/forks","keys_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/teams","hooks_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/hooks","issue_events_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/issues/events{/number}","events_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/events","assignees_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/assignees{/user}","branches_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/branches{/branch}","tags_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/tags","blobs_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/statuses/{sha}","languages_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/languages","stargazers_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/stargazers","contributors_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/contributors","subscribers_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/subscribers","subscription_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/subscription","commits_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/contents/{+path}","compare_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/merges","archive_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/downloads","issues_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/issues{/number}","pulls_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls{/number}","milestones_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/milestones{/number}","notifications_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/labels{/name}","releases_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/releases{/id}","deployments_url":"https://api.github.com/repos/jazzband/django-debug-toolbar/deployments","created_at":"2008-08-28T06:58:04Z","updated_at":"2016-09-27T16:15:09Z","pushed_at":"2016-09-27T20:21:54Z","git_url":"git://github.com/jazzband/django-debug-toolbar.git","ssh_url":"git@github.com:jazzband/django-debug-toolbar.git","clone_url":"https://github.com/jazzband/django-debug-toolbar.git","svn_url":"https://github.com/jazzband/django-debug-toolbar","homepage":"https://django-debug-toolbar.readthedocs.io/","size":5666,"stargazers_count":3800,"watchers_count":3800,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":694,"mirror_url":null,"open_issues_count":39,"forks":694,"open_issues":39,"watchers":3800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/883"},"html":{"href":"https://github.com/jazzband/django-debug-toolbar/pull/883"},"issue":{"href":"https://api.github.com/repos/jazzband/django-debug-toolbar/issues/883"},"comments":{"href":"https://api.github.com/repos/jazzband/django-debug-toolbar/issues/883/comments"},"review_comments":{"href":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/883/comments"},"review_comment":{"href":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jazzband/django-debug-toolbar/pulls/883/commits"},"statuses":{"href":"https://api.github.com/repos/jazzband/django-debug-toolbar/statuses/d27d8174c9aea8858c492c357e2b46559306364b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"zt-initech"}}