{"action":"closed","number":493,"pull_request":{"url":"https://api.github.com/repos/floodlight/loxigen/pulls/493","id":72414367,"html_url":"https://github.com/floodlight/loxigen/pull/493","diff_url":"https://github.com/floodlight/loxigen/pull/493.diff","patch_url":"https://github.com/floodlight/loxigen/pull/493.patch","issue_url":"https://api.github.com/repos/floodlight/loxigen/issues/493","number":493,"state":"closed","locked":false,"title":"Patch to optionally ignore the XID field in OFMessage and other types","user":{"login":"rizard","id":4602945,"avatar_url":"https://avatars.githubusercontent.com/u/4602945?v=3","gravatar_id":"","url":"https://api.github.com/users/rizard","html_url":"https://github.com/rizard","followers_url":"https://api.github.com/users/rizard/followers","following_url":"https://api.github.com/users/rizard/following{/other_user}","gists_url":"https://api.github.com/users/rizard/gists{/gist_id}","starred_url":"https://api.github.com/users/rizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizard/subscriptions","organizations_url":"https://api.github.com/users/rizard/orgs","repos_url":"https://api.github.com/users/rizard/repos","events_url":"https://api.github.com/users/rizard/events{/privacy}","received_events_url":"https://api.github.com/users/rizard/received_events","type":"User","site_admin":false},"body":"Reviewer: @rlane @andi-bigswitch \r\n\r\nFor any class with an XID field (detected by a class field named 'xid'), include an equalsIgnoreXid() function to ignore the XID in the equality check. The assumption, of course, is that the XID field is named 'xid' and is a primitive type ('long' at present). This will allow for the content-comparison of two OFMessages without regard to when they were created (or what the XID was set to).\r\n\r\nThis will address the long-lived problem in Floodlight of not being able to use the OFMessageDamper to prevent rapid, duplicate messages from being sent to the switch. A workaround has been used the last couple years that rebuilds the 'other' object in the comparison with the XID of 'this', which is quite inefficient.","created_at":"2016-06-02T20:45:01Z","updated_at":"2016-06-09T14:08:41Z","closed_at":"2016-06-09T14:08:41Z","merged_at":"2016-06-09T14:08:41Z","merge_commit_sha":"ee809117501a5c85cc9484bdc559f6edf5a7d6d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/floodlight/loxigen/pulls/493/commits","review_comments_url":"https://api.github.com/repos/floodlight/loxigen/pulls/493/comments","review_comment_url":"https://api.github.com/repos/floodlight/loxigen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/floodlight/loxigen/issues/493/comments","statuses_url":"https://api.github.com/repos/floodlight/loxigen/statuses/ee809117501a5c85cc9484bdc559f6edf5a7d6d3","head":{"label":"rizard:eq-ignore-xid","ref":"eq-ignore-xid","sha":"ee809117501a5c85cc9484bdc559f6edf5a7d6d3","user":{"login":"rizard","id":4602945,"avatar_url":"https://avatars.githubusercontent.com/u/4602945?v=3","gravatar_id":"","url":"https://api.github.com/users/rizard","html_url":"https://github.com/rizard","followers_url":"https://api.github.com/users/rizard/followers","following_url":"https://api.github.com/users/rizard/following{/other_user}","gists_url":"https://api.github.com/users/rizard/gists{/gist_id}","starred_url":"https://api.github.com/users/rizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizard/subscriptions","organizations_url":"https://api.github.com/users/rizard/orgs","repos_url":"https://api.github.com/users/rizard/repos","events_url":"https://api.github.com/users/rizard/events{/privacy}","received_events_url":"https://api.github.com/users/rizard/received_events","type":"User","site_admin":false},"repo":{"id":26693527,"name":"loxigen","full_name":"rizard/loxigen","owner":{"login":"rizard","id":4602945,"avatar_url":"https://avatars.githubusercontent.com/u/4602945?v=3","gravatar_id":"","url":"https://api.github.com/users/rizard","html_url":"https://github.com/rizard","followers_url":"https://api.github.com/users/rizard/followers","following_url":"https://api.github.com/users/rizard/following{/other_user}","gists_url":"https://api.github.com/users/rizard/gists{/gist_id}","starred_url":"https://api.github.com/users/rizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rizard/subscriptions","organizations_url":"https://api.github.com/users/rizard/orgs","repos_url":"https://api.github.com/users/rizard/repos","events_url":"https://api.github.com/users/rizard/events{/privacy}","received_events_url":"https://api.github.com/users/rizard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rizard/loxigen","description":"OpenFlow protocol bindings for multiple languages","fork":true,"url":"https://api.github.com/repos/rizard/loxigen","forks_url":"https://api.github.com/repos/rizard/loxigen/forks","keys_url":"https://api.github.com/repos/rizard/loxigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rizard/loxigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rizard/loxigen/teams","hooks_url":"https://api.github.com/repos/rizard/loxigen/hooks","issue_events_url":"https://api.github.com/repos/rizard/loxigen/issues/events{/number}","events_url":"https://api.github.com/repos/rizard/loxigen/events","assignees_url":"https://api.github.com/repos/rizard/loxigen/assignees{/user}","branches_url":"https://api.github.com/repos/rizard/loxigen/branches{/branch}","tags_url":"https://api.github.com/repos/rizard/loxigen/tags","blobs_url":"https://api.github.com/repos/rizard/loxigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rizard/loxigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rizard/loxigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/rizard/loxigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rizard/loxigen/statuses/{sha}","languages_url":"https://api.github.com/repos/rizard/loxigen/languages","stargazers_url":"https://api.github.com/repos/rizard/loxigen/stargazers","contributors_url":"https://api.github.com/repos/rizard/loxigen/contributors","subscribers_url":"https://api.github.com/repos/rizard/loxigen/subscribers","subscription_url":"https://api.github.com/repos/rizard/loxigen/subscription","commits_url":"https://api.github.com/repos/rizard/loxigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/rizard/loxigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/rizard/loxigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/rizard/loxigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/rizard/loxigen/contents/{+path}","compare_url":"https://api.github.com/repos/rizard/loxigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rizard/loxigen/merges","archive_url":"https://api.github.com/repos/rizard/loxigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rizard/loxigen/downloads","issues_url":"https://api.github.com/repos/rizard/loxigen/issues{/number}","pulls_url":"https://api.github.com/repos/rizard/loxigen/pulls{/number}","milestones_url":"https://api.github.com/repos/rizard/loxigen/milestones{/number}","notifications_url":"https://api.github.com/repos/rizard/loxigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rizard/loxigen/labels{/name}","releases_url":"https://api.github.com/repos/rizard/loxigen/releases{/id}","deployments_url":"https://api.github.com/repos/rizard/loxigen/deployments","created_at":"2014-11-15T20:52:04Z","updated_at":"2016-05-12T14:38:34Z","pushed_at":"2016-06-09T13:29:01Z","git_url":"git://github.com/rizard/loxigen.git","ssh_url":"git@github.com:rizard/loxigen.git","clone_url":"https://github.com/rizard/loxigen.git","svn_url":"https://github.com/rizard/loxigen","homepage":null,"size":4266,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"floodlight:master","ref":"master","sha":"bbd08a0ba812425e7310286dc0692baae3a24d7b","user":{"login":"floodlight","id":1198172,"avatar_url":"https://avatars.githubusercontent.com/u/1198172?v=3","gravatar_id":"","url":"https://api.github.com/users/floodlight","html_url":"https://github.com/floodlight","followers_url":"https://api.github.com/users/floodlight/followers","following_url":"https://api.github.com/users/floodlight/following{/other_user}","gists_url":"https://api.github.com/users/floodlight/gists{/gist_id}","starred_url":"https://api.github.com/users/floodlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floodlight/subscriptions","organizations_url":"https://api.github.com/users/floodlight/orgs","repos_url":"https://api.github.com/users/floodlight/repos","events_url":"https://api.github.com/users/floodlight/events{/privacy}","received_events_url":"https://api.github.com/users/floodlight/received_events","type":"Organization","site_admin":false},"repo":{"id":8866326,"name":"loxigen","full_name":"floodlight/loxigen","owner":{"login":"floodlight","id":1198172,"avatar_url":"https://avatars.githubusercontent.com/u/1198172?v=3","gravatar_id":"","url":"https://api.github.com/users/floodlight","html_url":"https://github.com/floodlight","followers_url":"https://api.github.com/users/floodlight/followers","following_url":"https://api.github.com/users/floodlight/following{/other_user}","gists_url":"https://api.github.com/users/floodlight/gists{/gist_id}","starred_url":"https://api.github.com/users/floodlight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floodlight/subscriptions","organizations_url":"https://api.github.com/users/floodlight/orgs","repos_url":"https://api.github.com/users/floodlight/repos","events_url":"https://api.github.com/users/floodlight/events{/privacy}","received_events_url":"https://api.github.com/users/floodlight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/floodlight/loxigen","description":"OpenFlow protocol bindings for multiple languages","fork":false,"url":"https://api.github.com/repos/floodlight/loxigen","forks_url":"https://api.github.com/repos/floodlight/loxigen/forks","keys_url":"https://api.github.com/repos/floodlight/loxigen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floodlight/loxigen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floodlight/loxigen/teams","hooks_url":"https://api.github.com/repos/floodlight/loxigen/hooks","issue_events_url":"https://api.github.com/repos/floodlight/loxigen/issues/events{/number}","events_url":"https://api.github.com/repos/floodlight/loxigen/events","assignees_url":"https://api.github.com/repos/floodlight/loxigen/assignees{/user}","branches_url":"https://api.github.com/repos/floodlight/loxigen/branches{/branch}","tags_url":"https://api.github.com/repos/floodlight/loxigen/tags","blobs_url":"https://api.github.com/repos/floodlight/loxigen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floodlight/loxigen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floodlight/loxigen/git/refs{/sha}","trees_url":"https://api.github.com/repos/floodlight/loxigen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floodlight/loxigen/statuses/{sha}","languages_url":"https://api.github.com/repos/floodlight/loxigen/languages","stargazers_url":"https://api.github.com/repos/floodlight/loxigen/stargazers","contributors_url":"https://api.github.com/repos/floodlight/loxigen/contributors","subscribers_url":"https://api.github.com/repos/floodlight/loxigen/subscribers","subscription_url":"https://api.github.com/repos/floodlight/loxigen/subscription","commits_url":"https://api.github.com/repos/floodlight/loxigen/commits{/sha}","git_commits_url":"https://api.github.com/repos/floodlight/loxigen/git/commits{/sha}","comments_url":"https://api.github.com/repos/floodlight/loxigen/comments{/number}","issue_comment_url":"https://api.github.com/repos/floodlight/loxigen/issues/comments{/number}","contents_url":"https://api.github.com/repos/floodlight/loxigen/contents/{+path}","compare_url":"https://api.github.com/repos/floodlight/loxigen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floodlight/loxigen/merges","archive_url":"https://api.github.com/repos/floodlight/loxigen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floodlight/loxigen/downloads","issues_url":"https://api.github.com/repos/floodlight/loxigen/issues{/number}","pulls_url":"https://api.github.com/repos/floodlight/loxigen/pulls{/number}","milestones_url":"https://api.github.com/repos/floodlight/loxigen/milestones{/number}","notifications_url":"https://api.github.com/repos/floodlight/loxigen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floodlight/loxigen/labels{/name}","releases_url":"https://api.github.com/repos/floodlight/loxigen/releases{/id}","deployments_url":"https://api.github.com/repos/floodlight/loxigen/deployments","created_at":"2013-03-18T23:10:16Z","updated_at":"2016-04-28T14:43:24Z","pushed_at":"2016-06-09T14:08:40Z","git_url":"git://github.com/floodlight/loxigen.git","ssh_url":"git@github.com:floodlight/loxigen.git","clone_url":"https://github.com/floodlight/loxigen.git","svn_url":"https://github.com/floodlight/loxigen","homepage":null,"size":4931,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"open_issues_count":9,"forks":78,"open_issues":9,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/floodlight/loxigen/pulls/493"},"html":{"href":"https://github.com/floodlight/loxigen/pull/493"},"issue":{"href":"https://api.github.com/repos/floodlight/loxigen/issues/493"},"comments":{"href":"https://api.github.com/repos/floodlight/loxigen/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/floodlight/loxigen/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/floodlight/loxigen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/floodlight/loxigen/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/floodlight/loxigen/statuses/ee809117501a5c85cc9484bdc559f6edf5a7d6d3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bsn-abat","id":1144962,"avatar_url":"https://avatars.githubusercontent.com/u/1144962?v=3","gravatar_id":"","url":"https://api.github.com/users/bsn-abat","html_url":"https://github.com/bsn-abat","followers_url":"https://api.github.com/users/bsn-abat/followers","following_url":"https://api.github.com/users/bsn-abat/following{/other_user}","gists_url":"https://api.github.com/users/bsn-abat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsn-abat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsn-abat/subscriptions","organizations_url":"https://api.github.com/users/bsn-abat/orgs","repos_url":"https://api.github.com/users/bsn-abat/repos","events_url":"https://api.github.com/users/bsn-abat/events{/privacy}","received_events_url":"https://api.github.com/users/bsn-abat/received_events","type":"User","site_admin":false},"comments":13,"review_comments":6,"commits":3,"additions":33,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"bsn-abat"}}