{"action":"created","issue":{"url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor/issues/47","repository_url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor","labels_url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor/issues/47/comments","events_url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor/issues/47/events","html_url":"https://github.com/gaearon/redux-devtools-log-monitor/pull/47","id":145465201,"number":47,"title":"Added shift toggle","user":{"login":"khankuan","id":1406170,"avatar_url":"https://avatars.githubusercontent.com/u/1406170?v=3","gravatar_id":"","url":"https://api.github.com/users/khankuan","html_url":"https://github.com/khankuan","followers_url":"https://api.github.com/users/khankuan/followers","following_url":"https://api.github.com/users/khankuan/following{/other_user}","gists_url":"https://api.github.com/users/khankuan/gists{/gist_id}","starred_url":"https://api.github.com/users/khankuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khankuan/subscriptions","organizations_url":"https://api.github.com/users/khankuan/orgs","repos_url":"https://api.github.com/users/khankuan/repos","events_url":"https://api.github.com/users/khankuan/events{/privacy}","received_events_url":"https://api.github.com/users/khankuan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-04-03T07:42:13Z","updated_at":"2016-11-02T08:05:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor/pulls/47","html_url":"https://github.com/gaearon/redux-devtools-log-monitor/pull/47","diff_url":"https://github.com/gaearon/redux-devtools-log-monitor/pull/47.diff","patch_url":"https://github.com/gaearon/redux-devtools-log-monitor/pull/47.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor/issues/comments/257797352","html_url":"https://github.com/gaearon/redux-devtools-log-monitor/pull/47#issuecomment-257797352","issue_url":"https://api.github.com/repos/gaearon/redux-devtools-log-monitor/issues/47","id":257797352,"user":{"login":"zalmoxisus","id":7957859,"avatar_url":"https://avatars.githubusercontent.com/u/7957859?v=3","gravatar_id":"","url":"https://api.github.com/users/zalmoxisus","html_url":"https://github.com/zalmoxisus","followers_url":"https://api.github.com/users/zalmoxisus/followers","following_url":"https://api.github.com/users/zalmoxisus/following{/other_user}","gists_url":"https://api.github.com/users/zalmoxisus/gists{/gist_id}","starred_url":"https://api.github.com/users/zalmoxisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalmoxisus/subscriptions","organizations_url":"https://api.github.com/users/zalmoxisus/orgs","repos_url":"https://api.github.com/users/zalmoxisus/repos","events_url":"https://api.github.com/users/zalmoxisus/events{/privacy}","received_events_url":"https://api.github.com/users/zalmoxisus/received_events","type":"User","site_admin":false},"created_at":"2016-11-02T08:05:37Z","updated_at":"2016-11-02T08:05:37Z","body":"@khankuan, weird :)\r\n\r\nThe reducer works ok, but, when having other actions dispatched meantime, the selection is lost.\r\n\r\nReturning `null` for other than `START_CONSECUTIVE_TOGGLE` actions here,  leads to unexpected behaviours. For example, when scrolling, `initialScrollTop` is dispatched and the selection gets dismissed. Also, I guess wile selecting some app's actions can dispatched and we don't want to lose the selection.\r\n\r\nI'd suggest to dismiss the selection only when regular `COMMIT` is dispatched. However, we cannot handle this case here as for the extension we call monitors reducers only for its actions. So, a solution is when dispatching `COMMIT`, to dispatch also `{ type: START_CONSECUTIVE_TOGGLE, id: null }`.\r\n\r\nAnother case is when the selected action got removed (due to commiting, reseting, reaching maxAge...), for that we shouldn't take it into consideration just by checking if it's present when making the second shift toggle. "}}
{"actor":{"display_login":"zalmoxisus"}}