{"action":"created","issue":{"url":"https://api.github.com/repos/endlessm/ostree/issues/46","repository_url":"https://api.github.com/repos/endlessm/ostree","labels_url":"https://api.github.com/repos/endlessm/ostree/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/endlessm/ostree/issues/46/comments","events_url":"https://api.github.com/repos/endlessm/ostree/issues/46/events","html_url":"https://github.com/endlessm/ostree/pull/46","id":174307429,"number":46,"title":"repo-pull: properly store the cancellable","user":{"login":"GeorgesStavracas","id":3518204,"avatar_url":"https://avatars.githubusercontent.com/u/3518204?v=3","gravatar_id":"","url":"https://api.github.com/users/GeorgesStavracas","html_url":"https://github.com/GeorgesStavracas","followers_url":"https://api.github.com/users/GeorgesStavracas/followers","following_url":"https://api.github.com/users/GeorgesStavracas/following{/other_user}","gists_url":"https://api.github.com/users/GeorgesStavracas/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgesStavracas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgesStavracas/subscriptions","organizations_url":"https://api.github.com/users/GeorgesStavracas/orgs","repos_url":"https://api.github.com/users/GeorgesStavracas/repos","events_url":"https://api.github.com/users/GeorgesStavracas/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgesStavracas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-31T15:40:57Z","updated_at":"2016-08-31T16:05:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/endlessm/ostree/pulls/46","html_url":"https://github.com/endlessm/ostree/pull/46","diff_url":"https://github.com/endlessm/ostree/pull/46.diff","patch_url":"https://github.com/endlessm/ostree/pull/46.patch"},"body":"OSTree function ostree_repo_pull_with_options starts a\r\nseries of operations that makes heavy use of the PullData's\r\ncancellable.\r\n\r\nThis isn't effective, however, since nowhere in the code\r\nthe OtPullData.cancellable field is set. This is visible,\r\nfor example, when trying to cancel a Flatpak pull and nothing\r\nhappens, because the cancellable is not properly passed\r\nto the pull data.\r\n\r\nFix that by setting the cancellable field of the pull data. It\r\nowns a reference for safety reasons, and unreferences it at the\r\nend of the operation.\r\n\r\nhttps://phabricator.endlessm.com/T12885"},"comment":{"url":"https://api.github.com/repos/endlessm/ostree/issues/comments/243813739","html_url":"https://github.com/endlessm/ostree/pull/46#issuecomment-243813739","issue_url":"https://api.github.com/repos/endlessm/ostree/issues/46","id":243813739,"user":{"login":"dbnicholson","id":6495518,"avatar_url":"https://avatars.githubusercontent.com/u/6495518?v=3","gravatar_id":"","url":"https://api.github.com/users/dbnicholson","html_url":"https://github.com/dbnicholson","followers_url":"https://api.github.com/users/dbnicholson/followers","following_url":"https://api.github.com/users/dbnicholson/following{/other_user}","gists_url":"https://api.github.com/users/dbnicholson/gists{/gist_id}","starred_url":"https://api.github.com/users/dbnicholson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbnicholson/subscriptions","organizations_url":"https://api.github.com/users/dbnicholson/orgs","repos_url":"https://api.github.com/users/dbnicholson/repos","events_url":"https://api.github.com/users/dbnicholson/events{/privacy}","received_events_url":"https://api.github.com/users/dbnicholson/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T16:05:11Z","updated_at":"2016-08-31T16:05:11Z","body":"Looks good, nice find. Corresponds to upstream's https://github.com/ostreedev/ostree/commit/cafc517c6bb93bb45777b6969125cb9599f217f6."}}
{"actor":{"display_login":"dbnicholson"}}