{"action":"closed","number":969,"pull_request":{"url":"https://api.github.com/repos/yeoman/generator/pulls/969","id":89900731,"html_url":"https://github.com/yeoman/generator/pull/969","diff_url":"https://github.com/yeoman/generator/pull/969.diff","patch_url":"https://github.com/yeoman/generator/pull/969.patch","issue_url":"https://api.github.com/repos/yeoman/generator/issues/969","number":969,"state":"closed","locked":false,"title":"Fix deprecation message for using `NamedBase`","user":{"login":"mischah","id":441011,"avatar_url":"https://avatars.githubusercontent.com/u/441011?v=3","gravatar_id":"","url":"https://api.github.com/users/mischah","html_url":"https://github.com/mischah","followers_url":"https://api.github.com/users/mischah/followers","following_url":"https://api.github.com/users/mischah/following{/other_user}","gists_url":"https://api.github.com/users/mischah/gists{/gist_id}","starred_url":"https://api.github.com/users/mischah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischah/subscriptions","organizations_url":"https://api.github.com/users/mischah/orgs","repos_url":"https://api.github.com/users/mischah/repos","events_url":"https://api.github.com/users/mischah/events{/privacy}","received_events_url":"https://api.github.com/users/mischah/received_events","type":"User","site_admin":false},"body":"Fixes #886\r\n\r\nChanges deprecation message when using \r\n\r\n```\r\nyeoman.generators.NamedBase.extend()\r\n```\r\n\r\n**Before:**\r\n\r\n<img width=\"937\" alt=\"yeoman generators namedbase extend-before\" src=\"https://cloud.githubusercontent.com/assets/441011/19496678/dbdbe7be-9588-11e6-9d1c-cf8dddd0db93.png\">\r\n\r\n**After:**\r\n\r\n<img width=\"937\" alt=\"yeoman generators namedbase extend-after\" src=\"https://cloud.githubusercontent.com/assets/441011/19496683/e3d2f566-9588-11e6-9e3f-aa5f422b9802.png\">\r\n\r\n---\r\n\r\nCorrect deprecation messages remain untouched.\r\n\r\n```\r\nyeoman.generators.Base.extend()\r\n```\r\n\r\n<img width=\"937\" alt=\"yeoman generators base extend-after\" src=\"https://cloud.githubusercontent.com/assets/441011/19496695/f5502944-9588-11e6-9bad-cbccda5e1f2d.png\">\r\n\r\n\r\n```\r\nyeoman.NamedBase.extend()\r\n```\r\n\r\n<img width=\"937\" alt=\"yeoman namedbase extend-after\" src=\"https://cloud.githubusercontent.com/assets/441011/19496706/06158d5a-9589-11e6-9171-7375d910aec4.png\">","created_at":"2016-10-18T21:18:00Z","updated_at":"2016-10-18T21:22:47Z","closed_at":"2016-10-18T21:22:47Z","merged_at":"2016-10-18T21:22:47Z","merge_commit_sha":"d3b4eca9b2c49515c5a160035a60324176957bcd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yeoman/generator/pulls/969/commits","review_comments_url":"https://api.github.com/repos/yeoman/generator/pulls/969/comments","review_comment_url":"https://api.github.com/repos/yeoman/generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yeoman/generator/issues/969/comments","statuses_url":"https://api.github.com/repos/yeoman/generator/statuses/ec95cabd0c3c85da4cc10fb5d337ef022f0ed9a5","head":{"label":"mischah:fix-deprecation-messages","ref":"fix-deprecation-messages","sha":"ec95cabd0c3c85da4cc10fb5d337ef022f0ed9a5","user":{"login":"mischah","id":441011,"avatar_url":"https://avatars.githubusercontent.com/u/441011?v=3","gravatar_id":"","url":"https://api.github.com/users/mischah","html_url":"https://github.com/mischah","followers_url":"https://api.github.com/users/mischah/followers","following_url":"https://api.github.com/users/mischah/following{/other_user}","gists_url":"https://api.github.com/users/mischah/gists{/gist_id}","starred_url":"https://api.github.com/users/mischah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischah/subscriptions","organizations_url":"https://api.github.com/users/mischah/orgs","repos_url":"https://api.github.com/users/mischah/repos","events_url":"https://api.github.com/users/mischah/events{/privacy}","received_events_url":"https://api.github.com/users/mischah/received_events","type":"User","site_admin":false},"repo":{"id":70279166,"name":"generator","full_name":"mischah/generator","owner":{"login":"mischah","id":441011,"avatar_url":"https://avatars.githubusercontent.com/u/441011?v=3","gravatar_id":"","url":"https://api.github.com/users/mischah","html_url":"https://github.com/mischah","followers_url":"https://api.github.com/users/mischah/followers","following_url":"https://api.github.com/users/mischah/following{/other_user}","gists_url":"https://api.github.com/users/mischah/gists{/gist_id}","starred_url":"https://api.github.com/users/mischah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischah/subscriptions","organizations_url":"https://api.github.com/users/mischah/orgs","repos_url":"https://api.github.com/users/mischah/repos","events_url":"https://api.github.com/users/mischah/events{/privacy}","received_events_url":"https://api.github.com/users/mischah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mischah/generator","description":"Rails-inspired generator system that provides scaffolding for your apps","fork":true,"url":"https://api.github.com/repos/mischah/generator","forks_url":"https://api.github.com/repos/mischah/generator/forks","keys_url":"https://api.github.com/repos/mischah/generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mischah/generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mischah/generator/teams","hooks_url":"https://api.github.com/repos/mischah/generator/hooks","issue_events_url":"https://api.github.com/repos/mischah/generator/issues/events{/number}","events_url":"https://api.github.com/repos/mischah/generator/events","assignees_url":"https://api.github.com/repos/mischah/generator/assignees{/user}","branches_url":"https://api.github.com/repos/mischah/generator/branches{/branch}","tags_url":"https://api.github.com/repos/mischah/generator/tags","blobs_url":"https://api.github.com/repos/mischah/generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mischah/generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mischah/generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mischah/generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mischah/generator/statuses/{sha}","languages_url":"https://api.github.com/repos/mischah/generator/languages","stargazers_url":"https://api.github.com/repos/mischah/generator/stargazers","contributors_url":"https://api.github.com/repos/mischah/generator/contributors","subscribers_url":"https://api.github.com/repos/mischah/generator/subscribers","subscription_url":"https://api.github.com/repos/mischah/generator/subscription","commits_url":"https://api.github.com/repos/mischah/generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mischah/generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mischah/generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mischah/generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mischah/generator/contents/{+path}","compare_url":"https://api.github.com/repos/mischah/generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mischah/generator/merges","archive_url":"https://api.github.com/repos/mischah/generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mischah/generator/downloads","issues_url":"https://api.github.com/repos/mischah/generator/issues{/number}","pulls_url":"https://api.github.com/repos/mischah/generator/pulls{/number}","milestones_url":"https://api.github.com/repos/mischah/generator/milestones{/number}","notifications_url":"https://api.github.com/repos/mischah/generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mischah/generator/labels{/name}","releases_url":"https://api.github.com/repos/mischah/generator/releases{/id}","deployments_url":"https://api.github.com/repos/mischah/generator/deployments","created_at":"2016-10-07T20:07:24Z","updated_at":"2016-10-07T20:07:25Z","pushed_at":"2016-10-18T21:15:01Z","git_url":"git://github.com/mischah/generator.git","ssh_url":"git@github.com:mischah/generator.git","clone_url":"https://github.com/mischah/generator.git","svn_url":"https://github.com/mischah/generator","homepage":"http://yeoman.io","size":3193,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yeoman:master","ref":"master","sha":"5cbc80fe00b1cc29cf64ccb9588ce5e213dc6e3d","user":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"repo":{"id":5151909,"name":"generator","full_name":"yeoman/generator","owner":{"login":"yeoman","id":1714870,"avatar_url":"https://avatars.githubusercontent.com/u/1714870?v=3","gravatar_id":"","url":"https://api.github.com/users/yeoman","html_url":"https://github.com/yeoman","followers_url":"https://api.github.com/users/yeoman/followers","following_url":"https://api.github.com/users/yeoman/following{/other_user}","gists_url":"https://api.github.com/users/yeoman/gists{/gist_id}","starred_url":"https://api.github.com/users/yeoman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeoman/subscriptions","organizations_url":"https://api.github.com/users/yeoman/orgs","repos_url":"https://api.github.com/users/yeoman/repos","events_url":"https://api.github.com/users/yeoman/events{/privacy}","received_events_url":"https://api.github.com/users/yeoman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yeoman/generator","description":"Rails-inspired generator system that provides scaffolding for your apps","fork":false,"url":"https://api.github.com/repos/yeoman/generator","forks_url":"https://api.github.com/repos/yeoman/generator/forks","keys_url":"https://api.github.com/repos/yeoman/generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yeoman/generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yeoman/generator/teams","hooks_url":"https://api.github.com/repos/yeoman/generator/hooks","issue_events_url":"https://api.github.com/repos/yeoman/generator/issues/events{/number}","events_url":"https://api.github.com/repos/yeoman/generator/events","assignees_url":"https://api.github.com/repos/yeoman/generator/assignees{/user}","branches_url":"https://api.github.com/repos/yeoman/generator/branches{/branch}","tags_url":"https://api.github.com/repos/yeoman/generator/tags","blobs_url":"https://api.github.com/repos/yeoman/generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yeoman/generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yeoman/generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/yeoman/generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yeoman/generator/statuses/{sha}","languages_url":"https://api.github.com/repos/yeoman/generator/languages","stargazers_url":"https://api.github.com/repos/yeoman/generator/stargazers","contributors_url":"https://api.github.com/repos/yeoman/generator/contributors","subscribers_url":"https://api.github.com/repos/yeoman/generator/subscribers","subscription_url":"https://api.github.com/repos/yeoman/generator/subscription","commits_url":"https://api.github.com/repos/yeoman/generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/yeoman/generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/yeoman/generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/yeoman/generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/yeoman/generator/contents/{+path}","compare_url":"https://api.github.com/repos/yeoman/generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yeoman/generator/merges","archive_url":"https://api.github.com/repos/yeoman/generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yeoman/generator/downloads","issues_url":"https://api.github.com/repos/yeoman/generator/issues{/number}","pulls_url":"https://api.github.com/repos/yeoman/generator/pulls{/number}","milestones_url":"https://api.github.com/repos/yeoman/generator/milestones{/number}","notifications_url":"https://api.github.com/repos/yeoman/generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yeoman/generator/labels{/name}","releases_url":"https://api.github.com/repos/yeoman/generator/releases{/id}","deployments_url":"https://api.github.com/repos/yeoman/generator/deployments","created_at":"2012-07-23T13:07:31Z","updated_at":"2016-10-07T09:10:23Z","pushed_at":"2016-10-18T21:22:47Z","git_url":"git://github.com/yeoman/generator.git","ssh_url":"git@github.com:yeoman/generator.git","clone_url":"https://github.com/yeoman/generator.git","svn_url":"https://github.com/yeoman/generator","homepage":"http://yeoman.io","size":3925,"stargazers_count":638,"watchers_count":638,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":206,"mirror_url":null,"open_issues_count":39,"forks":206,"open_issues":39,"watchers":638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yeoman/generator/pulls/969"},"html":{"href":"https://github.com/yeoman/generator/pull/969"},"issue":{"href":"https://api.github.com/repos/yeoman/generator/issues/969"},"comments":{"href":"https://api.github.com/repos/yeoman/generator/issues/969/comments"},"review_comments":{"href":"https://api.github.com/repos/yeoman/generator/pulls/969/comments"},"review_comment":{"href":"https://api.github.com/repos/yeoman/generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yeoman/generator/pulls/969/commits"},"statuses":{"href":"https://api.github.com/repos/yeoman/generator/statuses/ec95cabd0c3c85da4cc10fb5d337ef022f0ed9a5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"SBoudrias","id":923865,"avatar_url":"https://avatars.githubusercontent.com/u/923865?v=3","gravatar_id":"","url":"https://api.github.com/users/SBoudrias","html_url":"https://github.com/SBoudrias","followers_url":"https://api.github.com/users/SBoudrias/followers","following_url":"https://api.github.com/users/SBoudrias/following{/other_user}","gists_url":"https://api.github.com/users/SBoudrias/gists{/gist_id}","starred_url":"https://api.github.com/users/SBoudrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SBoudrias/subscriptions","organizations_url":"https://api.github.com/users/SBoudrias/orgs","repos_url":"https://api.github.com/users/SBoudrias/repos","events_url":"https://api.github.com/users/SBoudrias/events{/privacy}","received_events_url":"https://api.github.com/users/SBoudrias/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"SBoudrias"}}