{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/68518056","id":68518056,"diff_hunk":"@@ -555,42 +589,54 @@ private function builderMergExtDownloadedFilePath pMergExtVersion, pEdition\n    return builderRepoFolder() & slash & \"MergExt-\" & pEdition & \"-\" & pMergExtVersion & \".zip\"\n end builderMergExtDownloadedFilePath\n \n-command builderMergExtEnsureZip pMergExtVersion, pEdition\n-   local tZipPath\n-   put builderMergExtDownloadedFilePath(pMergExtVersion, pEdition) into tZipPath\n-   if there is not a file tZipPath then\n-      local tUrl\n-      put builderMergExtUrl(pMergExtVersion, pEdition) into tUrl\n-      builderLog \"message\", \"Downloading MergExt to\" && tZipPath\n-      get shell(merge(\"curl -o '[[tZipPath]]' '[[tUrl]]'\"))\n-      if the result is not zero then\n-         builderLog \"error\", \"Failed to download MergExt zip:\" && it\n-         throw \"failure\"\n-      end if\n-   end if\n-end builderMergExtEnsureZip\n+private command builderMergExtUnpack pMergExtVersion, pEdition\n+   local tFolder\n+   put builderUnpackFolder() & slash & \"Ext\" into tFolder\n+   \n+   local tZipFile\n+   put builderMergExtDownloadedFilePath(pMergExtVersion, pEdition) into tZipFile\n+   \n+   local tURL\n+   put builderMergExtUrl(pMergExtVersion, pEdition) into tURL\n+   \n+   builderEnsureZip tZipFile, tURL\n+   \n+   builderUnpackZip tZipFile, tFolder\n+end builderMergExtUnpack\n \n-command builderMergExtUnpack pMergExtVersion, pEdition\n-   builderMergExtEnsureZip pMergExtVersion, pEdition\n+////////////////////////////////////////////////////////////////////////////////\n+\n+function builderTSNetUrl pTSNetVersion\n+   return \"https://downloads.livecode.com/tsNet/tsNet_\" & pTSNetVersion & \".zip\"","path":"builder/builder_utilities.livecodescript","position":98,"original_position":98,"commit_id":"3ba244744ce09b61891d14bebd018ae921a0a000","original_commit_id":"3ba244744ce09b61891d14bebd018ae921a0a000","user":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"body":"I have renamed the one with the dash so they match and should pass the current tests","created_at":"2016-06-27T03:01:31Z","updated_at":"2016-06-27T03:01:31Z","html_url":"https://github.com/livecode/livecode/pull/4196#discussion_r68518056","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/4196","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/68518056"},"html":{"href":"https://github.com/livecode/livecode/pull/4196#discussion_r68518056"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4196"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/4196","id":74944648,"html_url":"https://github.com/livecode/livecode/pull/4196","diff_url":"https://github.com/livecode/livecode/pull/4196.diff","patch_url":"https://github.com/livecode/livecode/pull/4196.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/4196","number":4196,"state":"open","locked":false,"title":"[[ tsNet ]] Implement changes required to support tsNet libURL driver","user":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"body":"This patch provides support for the inclusion of\r\ntsNet into the livecode package. All additional\r\nexternals (mergExt & tsNet) will now be found\r\nin the same `Tools/Ext` directory.\r\n\r\nSupport has been implemented for a directory within\r\n`Tools/Ext` to contain livecode files that may insert\r\nthemselves into the IDE message path and standalone\r\nbuild process. This was required for tsNet's script\r\nbased libURL driver. These files will have\r\n`revLoadLibrary` and `revUnloadLibrary` sent to\r\nthem so they may manage their own lifecycle as\r\nback script, front script, library, behavior or\r\njust loaded stack.\r\n\r\nIn the course of development a bug was identified\r\nand resolved where android externals were potentially\r\nbeing filtered from the included files. The\r\n`revSBLibrary` was elevated to an always loaded\r\nback script in the IDE due to the many scripts\r\ndepending on it.\r\n\r\nThere are dependencies between this patch and an\r\nassociated patch to the livecode-ide repo.","created_at":"2016-06-23T12:18:14Z","updated_at":"2016-06-27T03:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c9d27e7c71595f789ea1b14fbbb599c1ddd33c2","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/livecode/livecode/milestones/109","html_url":"https://github.com/livecode/livecode/milestones/8.1.0-dp-2","labels_url":"https://api.github.com/repos/livecode/livecode/milestones/109/labels","id":1778952,"number":109,"title":"8.1.0-dp-2","description":null,"creator":{"login":"livecodeali","id":3985854,"avatar_url":"https://avatars.githubusercontent.com/u/3985854?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeali","html_url":"https://github.com/livecodeali","followers_url":"https://api.github.com/users/livecodeali/followers","following_url":"https://api.github.com/users/livecodeali/following{/other_user}","gists_url":"https://api.github.com/users/livecodeali/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeali/subscriptions","organizations_url":"https://api.github.com/users/livecodeali/orgs","repos_url":"https://api.github.com/users/livecodeali/repos","events_url":"https://api.github.com/users/livecodeali/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeali/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":74,"state":"open","created_at":"2016-05-20T14:38:34Z","updated_at":"2016-06-25T00:03:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/4196/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/4196/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/4196/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/3ba244744ce09b61891d14bebd018ae921a0a000","head":{"label":"montegoulding:tsnet","ref":"tsnet","sha":"3ba244744ce09b61891d14bebd018ae921a0a000","user":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"repo":{"id":9335660,"name":"livecode","full_name":"montegoulding/livecode","owner":{"login":"montegoulding","id":351144,"avatar_url":"https://avatars.githubusercontent.com/u/351144?v=3","gravatar_id":"","url":"https://api.github.com/users/montegoulding","html_url":"https://github.com/montegoulding","followers_url":"https://api.github.com/users/montegoulding/followers","following_url":"https://api.github.com/users/montegoulding/following{/other_user}","gists_url":"https://api.github.com/users/montegoulding/gists{/gist_id}","starred_url":"https://api.github.com/users/montegoulding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/montegoulding/subscriptions","organizations_url":"https://api.github.com/users/montegoulding/orgs","repos_url":"https://api.github.com/users/montegoulding/repos","events_url":"https://api.github.com/users/montegoulding/events{/privacy}","received_events_url":"https://api.github.com/users/montegoulding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/montegoulding/livecode","description":"","fork":true,"url":"https://api.github.com/repos/montegoulding/livecode","forks_url":"https://api.github.com/repos/montegoulding/livecode/forks","keys_url":"https://api.github.com/repos/montegoulding/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/montegoulding/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/montegoulding/livecode/teams","hooks_url":"https://api.github.com/repos/montegoulding/livecode/hooks","issue_events_url":"https://api.github.com/repos/montegoulding/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/montegoulding/livecode/events","assignees_url":"https://api.github.com/repos/montegoulding/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/montegoulding/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/montegoulding/livecode/tags","blobs_url":"https://api.github.com/repos/montegoulding/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/montegoulding/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/montegoulding/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/montegoulding/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/montegoulding/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/montegoulding/livecode/languages","stargazers_url":"https://api.github.com/repos/montegoulding/livecode/stargazers","contributors_url":"https://api.github.com/repos/montegoulding/livecode/contributors","subscribers_url":"https://api.github.com/repos/montegoulding/livecode/subscribers","subscription_url":"https://api.github.com/repos/montegoulding/livecode/subscription","commits_url":"https://api.github.com/repos/montegoulding/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/montegoulding/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/montegoulding/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/montegoulding/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/montegoulding/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/montegoulding/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/montegoulding/livecode/merges","archive_url":"https://api.github.com/repos/montegoulding/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/montegoulding/livecode/downloads","issues_url":"https://api.github.com/repos/montegoulding/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/montegoulding/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/montegoulding/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/montegoulding/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/montegoulding/livecode/labels{/name}","releases_url":"https://api.github.com/repos/montegoulding/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/montegoulding/livecode/deployments","created_at":"2013-04-10T01:45:36Z","updated_at":"2014-09-12T04:52:48Z","pushed_at":"2016-06-27T00:11:32Z","git_url":"git://github.com/montegoulding/livecode.git","ssh_url":"git@github.com:montegoulding/livecode.git","clone_url":"https://github.com/montegoulding/livecode.git","svn_url":"https://github.com/montegoulding/livecode","homepage":null,"size":116039,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"livecode:develop","ref":"develop","sha":"b558abb21128b34b977d08536f892ec49e68216a","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"LiveCode cross-platform development environment (engine)","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecode/livecode/deployments","created_at":"2013-04-10T00:15:57Z","updated_at":"2016-06-21T09:02:12Z","pushed_at":"2016-06-27T00:11:34Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":"https://livecode.com/","size":176595,"stargazers_count":130,"watchers_count":130,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":53,"forks":103,"open_issues":53,"watchers":130,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4196"},"html":{"href":"https://github.com/livecode/livecode/pull/4196"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/4196"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/4196/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4196/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4196/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/3ba244744ce09b61891d14bebd018ae921a0a000"}}}}
{"actor":{"display_login":"montegoulding"}}