{"action":"created","comment":{"url":"https://api.github.com/repos/activemerchant/active_merchant/pulls/comments/65956941","id":65956941,"diff_hunk":"@@ -195,14 +215,11 @@ def add_customer_data(post, options)\n       end\n \n       def add_optional_data(post, options)\n-        add_pair(post, :GiftAidPayment, options[:gift_aid_payment]) unless options[:gift_aid_payment].blank?","path":"lib/active_merchant/billing/gateways/sage_pay.rb","position":31,"original_position":31,"commit_id":"6e831778f30ee10ca2acf6d423582795676ac794","original_commit_id":"6e831778f30ee10ca2acf6d423582795676ac794","user":{"login":"aprofeit","id":1313339,"avatar_url":"https://avatars.githubusercontent.com/u/1313339?v=3","gravatar_id":"","url":"https://api.github.com/users/aprofeit","html_url":"https://github.com/aprofeit","followers_url":"https://api.github.com/users/aprofeit/followers","following_url":"https://api.github.com/users/aprofeit/following{/other_user}","gists_url":"https://api.github.com/users/aprofeit/gists{/gist_id}","starred_url":"https://api.github.com/users/aprofeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprofeit/subscriptions","organizations_url":"https://api.github.com/users/aprofeit/orgs","repos_url":"https://api.github.com/users/aprofeit/repos","events_url":"https://api.github.com/users/aprofeit/events{/privacy}","received_events_url":"https://api.github.com/users/aprofeit/received_events","type":"User","site_admin":false},"body":"The logic seems to have slightly changed here, previously it would add nothing if `option[:gift_aid_payment]` was `blank?`, now it looks like it will include `nil` for all keys which aren't present in `options`. Was this intentional / are we sure this is okay?","created_at":"2016-06-06T19:55:29Z","updated_at":"2016-06-06T19:55:29Z","html_url":"https://github.com/activemerchant/active_merchant/pull/2052#discussion_r65956941","pull_request_url":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052","_links":{"self":{"href":"https://api.github.com/repos/activemerchant/active_merchant/pulls/comments/65956941"},"html":{"href":"https://github.com/activemerchant/active_merchant/pull/2052#discussion_r65956941"},"pull_request":{"href":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052"}}},"pull_request":{"url":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052","id":64326539,"html_url":"https://github.com/activemerchant/active_merchant/pull/2052","diff_url":"https://github.com/activemerchant/active_merchant/pull/2052.diff","patch_url":"https://github.com/activemerchant/active_merchant/pull/2052.patch","issue_url":"https://api.github.com/repos/activemerchant/active_merchant/issues/2052","number":2052,"state":"open","locked":false,"title":"Add all optional fields to SagePay requests","user":{"login":"cristianstanescu","id":977712,"avatar_url":"https://avatars.githubusercontent.com/u/977712?v=3","gravatar_id":"","url":"https://api.github.com/users/cristianstanescu","html_url":"https://github.com/cristianstanescu","followers_url":"https://api.github.com/users/cristianstanescu/followers","following_url":"https://api.github.com/users/cristianstanescu/following{/other_user}","gists_url":"https://api.github.com/users/cristianstanescu/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianstanescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianstanescu/subscriptions","organizations_url":"https://api.github.com/users/cristianstanescu/orgs","repos_url":"https://api.github.com/users/cristianstanescu/repos","events_url":"https://api.github.com/users/cristianstanescu/events{/privacy}","received_events_url":"https://api.github.com/users/cristianstanescu/received_events","type":"User","site_admin":false},"body":"SagePay direct integration allows sending multiple optional fields with requests. This PR add all missing optional fields available with SagePay's protocol version 3.00 as described in the \"Sage Pay Direct Integration and Protocol Guidelines 3.00\" appendix \"A1. You submit your transaction registration POST\"","created_at":"2016-03-28T14:26:20Z","updated_at":"2016-06-06T19:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed6993e3a1f61ce8ee8996e751a5f61a3fdd0fc1","assignee":{"login":"timbeiko","id":9390255,"avatar_url":"https://avatars.githubusercontent.com/u/9390255?v=3","gravatar_id":"","url":"https://api.github.com/users/timbeiko","html_url":"https://github.com/timbeiko","followers_url":"https://api.github.com/users/timbeiko/followers","following_url":"https://api.github.com/users/timbeiko/following{/other_user}","gists_url":"https://api.github.com/users/timbeiko/gists{/gist_id}","starred_url":"https://api.github.com/users/timbeiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timbeiko/subscriptions","organizations_url":"https://api.github.com/users/timbeiko/orgs","repos_url":"https://api.github.com/users/timbeiko/repos","events_url":"https://api.github.com/users/timbeiko/events{/privacy}","received_events_url":"https://api.github.com/users/timbeiko/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052/commits","review_comments_url":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052/comments","review_comment_url":"https://api.github.com/repos/activemerchant/active_merchant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/activemerchant/active_merchant/issues/2052/comments","statuses_url":"https://api.github.com/repos/activemerchant/active_merchant/statuses/6e831778f30ee10ca2acf6d423582795676ac794","head":{"label":"cristianstanescu:complete_optional_fields_for_sage_pay","ref":"complete_optional_fields_for_sage_pay","sha":"6e831778f30ee10ca2acf6d423582795676ac794","user":{"login":"cristianstanescu","id":977712,"avatar_url":"https://avatars.githubusercontent.com/u/977712?v=3","gravatar_id":"","url":"https://api.github.com/users/cristianstanescu","html_url":"https://github.com/cristianstanescu","followers_url":"https://api.github.com/users/cristianstanescu/followers","following_url":"https://api.github.com/users/cristianstanescu/following{/other_user}","gists_url":"https://api.github.com/users/cristianstanescu/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianstanescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianstanescu/subscriptions","organizations_url":"https://api.github.com/users/cristianstanescu/orgs","repos_url":"https://api.github.com/users/cristianstanescu/repos","events_url":"https://api.github.com/users/cristianstanescu/events{/privacy}","received_events_url":"https://api.github.com/users/cristianstanescu/received_events","type":"User","site_admin":false},"repo":{"id":43946182,"name":"active_merchant","full_name":"cristianstanescu/active_merchant","owner":{"login":"cristianstanescu","id":977712,"avatar_url":"https://avatars.githubusercontent.com/u/977712?v=3","gravatar_id":"","url":"https://api.github.com/users/cristianstanescu","html_url":"https://github.com/cristianstanescu","followers_url":"https://api.github.com/users/cristianstanescu/followers","following_url":"https://api.github.com/users/cristianstanescu/following{/other_user}","gists_url":"https://api.github.com/users/cristianstanescu/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianstanescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianstanescu/subscriptions","organizations_url":"https://api.github.com/users/cristianstanescu/orgs","repos_url":"https://api.github.com/users/cristianstanescu/repos","events_url":"https://api.github.com/users/cristianstanescu/events{/privacy}","received_events_url":"https://api.github.com/users/cristianstanescu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cristianstanescu/active_merchant","description":"Active Merchant is a simple payment abstraction library extracted from Shopify. The aim of the project is to feel natural to Ruby users and to abstract as many parts as possible away from the user to offer a consistent interface across all supported gateways.","fork":true,"url":"https://api.github.com/repos/cristianstanescu/active_merchant","forks_url":"https://api.github.com/repos/cristianstanescu/active_merchant/forks","keys_url":"https://api.github.com/repos/cristianstanescu/active_merchant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cristianstanescu/active_merchant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cristianstanescu/active_merchant/teams","hooks_url":"https://api.github.com/repos/cristianstanescu/active_merchant/hooks","issue_events_url":"https://api.github.com/repos/cristianstanescu/active_merchant/issues/events{/number}","events_url":"https://api.github.com/repos/cristianstanescu/active_merchant/events","assignees_url":"https://api.github.com/repos/cristianstanescu/active_merchant/assignees{/user}","branches_url":"https://api.github.com/repos/cristianstanescu/active_merchant/branches{/branch}","tags_url":"https://api.github.com/repos/cristianstanescu/active_merchant/tags","blobs_url":"https://api.github.com/repos/cristianstanescu/active_merchant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cristianstanescu/active_merchant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cristianstanescu/active_merchant/git/refs{/sha}","trees_url":"https://api.github.com/repos/cristianstanescu/active_merchant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cristianstanescu/active_merchant/statuses/{sha}","languages_url":"https://api.github.com/repos/cristianstanescu/active_merchant/languages","stargazers_url":"https://api.github.com/repos/cristianstanescu/active_merchant/stargazers","contributors_url":"https://api.github.com/repos/cristianstanescu/active_merchant/contributors","subscribers_url":"https://api.github.com/repos/cristianstanescu/active_merchant/subscribers","subscription_url":"https://api.github.com/repos/cristianstanescu/active_merchant/subscription","commits_url":"https://api.github.com/repos/cristianstanescu/active_merchant/commits{/sha}","git_commits_url":"https://api.github.com/repos/cristianstanescu/active_merchant/git/commits{/sha}","comments_url":"https://api.github.com/repos/cristianstanescu/active_merchant/comments{/number}","issue_comment_url":"https://api.github.com/repos/cristianstanescu/active_merchant/issues/comments{/number}","contents_url":"https://api.github.com/repos/cristianstanescu/active_merchant/contents/{+path}","compare_url":"https://api.github.com/repos/cristianstanescu/active_merchant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cristianstanescu/active_merchant/merges","archive_url":"https://api.github.com/repos/cristianstanescu/active_merchant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cristianstanescu/active_merchant/downloads","issues_url":"https://api.github.com/repos/cristianstanescu/active_merchant/issues{/number}","pulls_url":"https://api.github.com/repos/cristianstanescu/active_merchant/pulls{/number}","milestones_url":"https://api.github.com/repos/cristianstanescu/active_merchant/milestones{/number}","notifications_url":"https://api.github.com/repos/cristianstanescu/active_merchant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cristianstanescu/active_merchant/labels{/name}","releases_url":"https://api.github.com/repos/cristianstanescu/active_merchant/releases{/id}","deployments_url":"https://api.github.com/repos/cristianstanescu/active_merchant/deployments","created_at":"2015-10-09T09:32:36Z","updated_at":"2016-03-21T10:19:26Z","pushed_at":"2016-03-28T14:17:24Z","git_url":"git://github.com/cristianstanescu/active_merchant.git","ssh_url":"git@github.com:cristianstanescu/active_merchant.git","clone_url":"https://github.com/cristianstanescu/active_merchant.git","svn_url":"https://github.com/cristianstanescu/active_merchant","homepage":"http://activemerchant.org","size":13984,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"activemerchant:master","ref":"master","sha":"0bd04175ce91e571642d64985b19a608bbfb3dc0","user":{"login":"activemerchant","id":12955944,"avatar_url":"https://avatars.githubusercontent.com/u/12955944?v=3","gravatar_id":"","url":"https://api.github.com/users/activemerchant","html_url":"https://github.com/activemerchant","followers_url":"https://api.github.com/users/activemerchant/followers","following_url":"https://api.github.com/users/activemerchant/following{/other_user}","gists_url":"https://api.github.com/users/activemerchant/gists{/gist_id}","starred_url":"https://api.github.com/users/activemerchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activemerchant/subscriptions","organizations_url":"https://api.github.com/users/activemerchant/orgs","repos_url":"https://api.github.com/users/activemerchant/repos","events_url":"https://api.github.com/users/activemerchant/events{/privacy}","received_events_url":"https://api.github.com/users/activemerchant/received_events","type":"Organization","site_admin":false},"repo":{"id":18294,"name":"active_merchant","full_name":"activemerchant/active_merchant","owner":{"login":"activemerchant","id":12955944,"avatar_url":"https://avatars.githubusercontent.com/u/12955944?v=3","gravatar_id":"","url":"https://api.github.com/users/activemerchant","html_url":"https://github.com/activemerchant","followers_url":"https://api.github.com/users/activemerchant/followers","following_url":"https://api.github.com/users/activemerchant/following{/other_user}","gists_url":"https://api.github.com/users/activemerchant/gists{/gist_id}","starred_url":"https://api.github.com/users/activemerchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activemerchant/subscriptions","organizations_url":"https://api.github.com/users/activemerchant/orgs","repos_url":"https://api.github.com/users/activemerchant/repos","events_url":"https://api.github.com/users/activemerchant/events{/privacy}","received_events_url":"https://api.github.com/users/activemerchant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/activemerchant/active_merchant","description":"Active Merchant is a simple payment abstraction library extracted from Shopify. The aim of the project is to feel natural to Ruby users and to abstract as many parts as possible away from the user to offer a consistent interface across all supported gateways.","fork":false,"url":"https://api.github.com/repos/activemerchant/active_merchant","forks_url":"https://api.github.com/repos/activemerchant/active_merchant/forks","keys_url":"https://api.github.com/repos/activemerchant/active_merchant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activemerchant/active_merchant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activemerchant/active_merchant/teams","hooks_url":"https://api.github.com/repos/activemerchant/active_merchant/hooks","issue_events_url":"https://api.github.com/repos/activemerchant/active_merchant/issues/events{/number}","events_url":"https://api.github.com/repos/activemerchant/active_merchant/events","assignees_url":"https://api.github.com/repos/activemerchant/active_merchant/assignees{/user}","branches_url":"https://api.github.com/repos/activemerchant/active_merchant/branches{/branch}","tags_url":"https://api.github.com/repos/activemerchant/active_merchant/tags","blobs_url":"https://api.github.com/repos/activemerchant/active_merchant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activemerchant/active_merchant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activemerchant/active_merchant/git/refs{/sha}","trees_url":"https://api.github.com/repos/activemerchant/active_merchant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activemerchant/active_merchant/statuses/{sha}","languages_url":"https://api.github.com/repos/activemerchant/active_merchant/languages","stargazers_url":"https://api.github.com/repos/activemerchant/active_merchant/stargazers","contributors_url":"https://api.github.com/repos/activemerchant/active_merchant/contributors","subscribers_url":"https://api.github.com/repos/activemerchant/active_merchant/subscribers","subscription_url":"https://api.github.com/repos/activemerchant/active_merchant/subscription","commits_url":"https://api.github.com/repos/activemerchant/active_merchant/commits{/sha}","git_commits_url":"https://api.github.com/repos/activemerchant/active_merchant/git/commits{/sha}","comments_url":"https://api.github.com/repos/activemerchant/active_merchant/comments{/number}","issue_comment_url":"https://api.github.com/repos/activemerchant/active_merchant/issues/comments{/number}","contents_url":"https://api.github.com/repos/activemerchant/active_merchant/contents/{+path}","compare_url":"https://api.github.com/repos/activemerchant/active_merchant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activemerchant/active_merchant/merges","archive_url":"https://api.github.com/repos/activemerchant/active_merchant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activemerchant/active_merchant/downloads","issues_url":"https://api.github.com/repos/activemerchant/active_merchant/issues{/number}","pulls_url":"https://api.github.com/repos/activemerchant/active_merchant/pulls{/number}","milestones_url":"https://api.github.com/repos/activemerchant/active_merchant/milestones{/number}","notifications_url":"https://api.github.com/repos/activemerchant/active_merchant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activemerchant/active_merchant/labels{/name}","releases_url":"https://api.github.com/repos/activemerchant/active_merchant/releases{/id}","deployments_url":"https://api.github.com/repos/activemerchant/active_merchant/deployments","created_at":"2008-05-20T13:53:26Z","updated_at":"2016-06-04T06:44:54Z","pushed_at":"2016-06-06T19:55:10Z","git_url":"git://github.com/activemerchant/active_merchant.git","ssh_url":"git@github.com:activemerchant/active_merchant.git","clone_url":"https://github.com/activemerchant/active_merchant.git","svn_url":"https://github.com/activemerchant/active_merchant","homepage":"http://activemerchant.org","size":24973,"stargazers_count":3343,"watchers_count":3343,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1888,"mirror_url":null,"open_issues_count":89,"forks":1888,"open_issues":89,"watchers":3343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052"},"html":{"href":"https://github.com/activemerchant/active_merchant/pull/2052"},"issue":{"href":"https://api.github.com/repos/activemerchant/active_merchant/issues/2052"},"comments":{"href":"https://api.github.com/repos/activemerchant/active_merchant/issues/2052/comments"},"review_comments":{"href":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052/comments"},"review_comment":{"href":"https://api.github.com/repos/activemerchant/active_merchant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/activemerchant/active_merchant/pulls/2052/commits"},"statuses":{"href":"https://api.github.com/repos/activemerchant/active_merchant/statuses/6e831778f30ee10ca2acf6d423582795676ac794"}}}}
{"actor":{"display_login":"aprofeit"}}