{"push_id":1057784914,"size":7,"distinct_size":5,"ref":"refs/heads/feature/simplify-rubocop-rules","head":"0e97f2ea5034421305fe746d0aa60599cf509f3d","before":"fede59763789d16aa50d39dd6db0f9912e6aa508","commits":[{"sha":"aaf80ee4b5a2f9129c74cf0c6363aeabac798d7e","author":{"email":"b7d5d31a54205163f78a2f9fac940800676389df@gmail.com","name":"Rob Nichols"},"message":"Improve stubbing of runner tests, and make current directory change around the test","distinct":false,"url":"https://api.github.com/repos/EnvironmentAgency/before_commit/commits/aaf80ee4b5a2f9129c74cf0c6363aeabac798d7e"},{"sha":"bccd8ff85bbcfdfc1f5ae4e07651d07fd695dd92","author":{"email":"6fe862b00aea18b0da8dd5bc09e55116a7e494cf@gmail.com","name":"Alan Cruikshanks"},"message":"Merge pull request #12 from EnvironmentAgency/fix/stalled-tests-causing-problems\n\nFixes problems associated with tests occasionally stalling","distinct":false,"url":"https://api.github.com/repos/EnvironmentAgency/before_commit/commits/bccd8ff85bbcfdfc1f5ae4e07651d07fd695dd92"},{"sha":"5fed50d16e54b41af87a075362cf91048c0c7f6a","author":{"email":"6fe862b00aea18b0da8dd5bc09e55116a7e494cf@gmail.com","name":"Alan Cruikshanks"},"message":"Simplify rubocop rules\n\nThe bulk of the rules were taken from an old GDS repo which contained their specific rule set (the files have been replaced by [govuk-lint](https://github.com/alphagov/govuk-lint).\n\nThe original thinking was to keep our projects in line with those from GDS. However as we have progressed the general feeling in the team is that we would rather move to be closer to the defaults in the [community style guide](https://github.com/bbatsov/ruby-style-guide), with any exceptions being those agreed by the team.\n\nThese changes remove the inherited GDS rules, and retains only those currently agreed by the team. It also switches the syntax in the configuration to that recommended by the Rubocop team.","distinct":true,"url":"https://api.github.com/repos/EnvironmentAgency/before_commit/commits/5fed50d16e54b41af87a075362cf91048c0c7f6a"},{"sha":"a6a7af285fea4dc8045cb4f1395e2e130a57f8b8","author":{"email":"6fe862b00aea18b0da8dd5bc09e55116a7e494cf@gmail.com","name":"Alan Cruikshanks"},"message":"Remove service specific exclusions\n\nSome of the exclusions for certain rules were service specific. The aim of this gem is to be a general tool for all our projects and those exclusions would be better placed within the originating code itself using Rubocop's ability to disable cops within source code.\n\nhttps://github.com/bbatsov/rubocop#disabling-cops-within-source-code\n\nThis change removes those service specific exclusions.","distinct":true,"url":"https://api.github.com/repos/EnvironmentAgency/before_commit/commits/a6a7af285fea4dc8045cb4f1395e2e130a57f8b8"},{"sha":"0a0ec70f4b282d2d7c4482b5e31fd51ec5eada19","author":{"email":"6fe862b00aea18b0da8dd5bc09e55116a7e494cf@gmail.com","name":"Alan Cruikshanks"},"message":"Amend Metric max values\n\nAfter discussion with the team it was agreed the existing values were too high, but the defaults are too low. We have come to concensus on\n\n- Metrics/MethodLength = 15\n- Metrics/ModuleLength = 200","distinct":true,"url":"https://api.github.com/repos/EnvironmentAgency/before_commit/commits/0a0ec70f4b282d2d7c4482b5e31fd51ec5eada19"},{"sha":"f35e6109af4c3d4158d7fd02a12cdd4d2bac5a16","author":{"email":"6fe862b00aea18b0da8dd5bc09e55116a7e494cf@gmail.com","name":"Alan Cruikshanks"},"message":"Include cop names in rubocop offense output","distinct":true,"url":"https://api.github.com/repos/EnvironmentAgency/before_commit/commits/f35e6109af4c3d4158d7fd02a12cdd4d2bac5a16"},{"sha":"0e97f2ea5034421305fe746d0aa60599cf509f3d","author":{"email":"6fe862b00aea18b0da8dd5bc09e55116a7e494cf@gmail.com","name":"Alan Cruikshanks"},"message":"Include style guide url in offense output","distinct":true,"url":"https://api.github.com/repos/EnvironmentAgency/before_commit/commits/0e97f2ea5034421305fe746d0aa60599cf509f3d"}]}