{"action":"created","comment":{"url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/comments/81997990","pull_request_review_id":2936292,"id":81997990,"diff_hunk":"@@ -42,15 +35,25 @@ class ReportingStrategyWrapper(wrapped: SupervisorStrategy, comment: String) ext\n \n   private def reportException(context: ActorContext, exception: Throwable) = {\n     val configuration = Configuration(context.system.settings.config)\n+\n     val wsClient = {\n       val environment = Environment.simple(mode = Mode.Prod)\n-      val wsConfig = new WSConfigParser(configuration, environment).parse\n-      val ningWsConfig = new NingWSClientConfigParser(wsConfig, configuration, environment).parse\n-      NingWSClient(ningWsConfig)\n+\n+      val parser = new WSConfigParser(configuration, environment)\n+      val config = new AhcWSClientConfig(wsClientConfig = parser.parse())\n+      val builder = new AhcConfigBuilder(config)\n+      val ahcConfig = builder.configure().build()\n+\n+      implicit val system = ActorSystem()","path":"src/main/scala/fly/play/jiraExceptionProcessor/ReportingSupervisorStrategy.scala","position":38,"original_position":38,"commit_id":"94279944e2d10b9e76abe52fe70456473b761160","original_commit_id":"94279944e2d10b9e76abe52fe70456473b761160","user":{"login":"EECOLOR","id":1486362,"avatar_url":"https://avatars.githubusercontent.com/u/1486362?v=3","gravatar_id":"","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"body":"It's good practice to give the actor system a name. Otherwise the name will become `default` which does not help with debugging.","created_at":"2016-10-05T15:19:39Z","updated_at":"2016-10-05T15:19:39Z","html_url":"https://github.com/Kaliber/play-jira-exception-processor/pull/14#discussion_r81997990","pull_request_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/comments/81997990"},"html":{"href":"https://github.com/Kaliber/play-jira-exception-processor/pull/14#discussion_r81997990"},"pull_request":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14","id":88079939,"html_url":"https://github.com/Kaliber/play-jira-exception-processor/pull/14","diff_url":"https://github.com/Kaliber/play-jira-exception-processor/pull/14.diff","patch_url":"https://github.com/Kaliber/play-jira-exception-processor/pull/14.patch","issue_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/14","number":14,"state":"open","locked":false,"title":"Play upgrade to 2.5.8","user":{"login":"jorkzijlstra","id":15804835,"avatar_url":"https://avatars.githubusercontent.com/u/15804835?v=3","gravatar_id":"","url":"https://api.github.com/users/jorkzijlstra","html_url":"https://github.com/jorkzijlstra","followers_url":"https://api.github.com/users/jorkzijlstra/followers","following_url":"https://api.github.com/users/jorkzijlstra/following{/other_user}","gists_url":"https://api.github.com/users/jorkzijlstra/gists{/gist_id}","starred_url":"https://api.github.com/users/jorkzijlstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorkzijlstra/subscriptions","organizations_url":"https://api.github.com/users/jorkzijlstra/orgs","repos_url":"https://api.github.com/users/jorkzijlstra/repos","events_url":"https://api.github.com/users/jorkzijlstra/events{/privacy}","received_events_url":"https://api.github.com/users/jorkzijlstra/received_events","type":"User","site_admin":false},"body":"update play to 2.5.8,\r\nplay-mail to 5.0.0,\r\nscala to 2.11.8\r\nsbt to 0.13.12","created_at":"2016-10-05T13:41:12Z","updated_at":"2016-10-05T15:24:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b65cfe85b143eea2667f5fe8c924285d4eb11142","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14/commits","review_comments_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14/comments","review_comment_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/14/comments","statuses_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/statuses/94279944e2d10b9e76abe52fe70456473b761160","head":{"label":"Kaliber:play_2.5.x","ref":"play_2.5.x","sha":"94279944e2d10b9e76abe52fe70456473b761160","user":{"login":"Kaliber","id":13070255,"avatar_url":"https://avatars.githubusercontent.com/u/13070255?v=3","gravatar_id":"","url":"https://api.github.com/users/Kaliber","html_url":"https://github.com/Kaliber","followers_url":"https://api.github.com/users/Kaliber/followers","following_url":"https://api.github.com/users/Kaliber/following{/other_user}","gists_url":"https://api.github.com/users/Kaliber/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaliber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaliber/subscriptions","organizations_url":"https://api.github.com/users/Kaliber/orgs","repos_url":"https://api.github.com/users/Kaliber/repos","events_url":"https://api.github.com/users/Kaliber/events{/privacy}","received_events_url":"https://api.github.com/users/Kaliber/received_events","type":"Organization","site_admin":false},"repo":{"id":8456650,"name":"play-jira-exception-processor","full_name":"Kaliber/play-jira-exception-processor","owner":{"login":"Kaliber","id":13070255,"avatar_url":"https://avatars.githubusercontent.com/u/13070255?v=3","gravatar_id":"","url":"https://api.github.com/users/Kaliber","html_url":"https://github.com/Kaliber","followers_url":"https://api.github.com/users/Kaliber/followers","following_url":"https://api.github.com/users/Kaliber/following{/other_user}","gists_url":"https://api.github.com/users/Kaliber/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaliber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaliber/subscriptions","organizations_url":"https://api.github.com/users/Kaliber/orgs","repos_url":"https://api.github.com/users/Kaliber/repos","events_url":"https://api.github.com/users/Kaliber/events{/privacy}","received_events_url":"https://api.github.com/users/Kaliber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kaliber/play-jira-exception-processor","description":"Error reporting to Jira with fallback to email for Play","fork":false,"url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor","forks_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/forks","keys_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/teams","hooks_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/hooks","issue_events_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/events{/number}","events_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/events","assignees_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/assignees{/user}","branches_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/branches{/branch}","tags_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/tags","blobs_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/languages","stargazers_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/stargazers","contributors_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/contributors","subscribers_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/subscribers","subscription_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/subscription","commits_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/contents/{+path}","compare_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/merges","archive_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/downloads","issues_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues{/number}","pulls_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/labels{/name}","releases_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/releases{/id}","deployments_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/deployments","created_at":"2013-02-27T13:38:28Z","updated_at":"2016-01-15T13:23:18Z","pushed_at":"2016-10-05T13:41:12Z","git_url":"git://github.com/Kaliber/play-jira-exception-processor.git","ssh_url":"git@github.com:Kaliber/play-jira-exception-processor.git","clone_url":"https://github.com/Kaliber/play-jira-exception-processor.git","svn_url":"https://github.com/Kaliber/play-jira-exception-processor","homepage":"","size":56,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"Kaliber:master","ref":"master","sha":"d66b457ad62b9dea391588404713e818238147e3","user":{"login":"Kaliber","id":13070255,"avatar_url":"https://avatars.githubusercontent.com/u/13070255?v=3","gravatar_id":"","url":"https://api.github.com/users/Kaliber","html_url":"https://github.com/Kaliber","followers_url":"https://api.github.com/users/Kaliber/followers","following_url":"https://api.github.com/users/Kaliber/following{/other_user}","gists_url":"https://api.github.com/users/Kaliber/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaliber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaliber/subscriptions","organizations_url":"https://api.github.com/users/Kaliber/orgs","repos_url":"https://api.github.com/users/Kaliber/repos","events_url":"https://api.github.com/users/Kaliber/events{/privacy}","received_events_url":"https://api.github.com/users/Kaliber/received_events","type":"Organization","site_admin":false},"repo":{"id":8456650,"name":"play-jira-exception-processor","full_name":"Kaliber/play-jira-exception-processor","owner":{"login":"Kaliber","id":13070255,"avatar_url":"https://avatars.githubusercontent.com/u/13070255?v=3","gravatar_id":"","url":"https://api.github.com/users/Kaliber","html_url":"https://github.com/Kaliber","followers_url":"https://api.github.com/users/Kaliber/followers","following_url":"https://api.github.com/users/Kaliber/following{/other_user}","gists_url":"https://api.github.com/users/Kaliber/gists{/gist_id}","starred_url":"https://api.github.com/users/Kaliber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kaliber/subscriptions","organizations_url":"https://api.github.com/users/Kaliber/orgs","repos_url":"https://api.github.com/users/Kaliber/repos","events_url":"https://api.github.com/users/Kaliber/events{/privacy}","received_events_url":"https://api.github.com/users/Kaliber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kaliber/play-jira-exception-processor","description":"Error reporting to Jira with fallback to email for Play","fork":false,"url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor","forks_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/forks","keys_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/teams","hooks_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/hooks","issue_events_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/events{/number}","events_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/events","assignees_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/assignees{/user}","branches_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/branches{/branch}","tags_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/tags","blobs_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/languages","stargazers_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/stargazers","contributors_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/contributors","subscribers_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/subscribers","subscription_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/subscription","commits_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/contents/{+path}","compare_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/merges","archive_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/downloads","issues_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues{/number}","pulls_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/labels{/name}","releases_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/releases{/id}","deployments_url":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/deployments","created_at":"2013-02-27T13:38:28Z","updated_at":"2016-01-15T13:23:18Z","pushed_at":"2016-10-05T13:41:12Z","git_url":"git://github.com/Kaliber/play-jira-exception-processor.git","ssh_url":"git@github.com:Kaliber/play-jira-exception-processor.git","clone_url":"https://github.com/Kaliber/play-jira-exception-processor.git","svn_url":"https://github.com/Kaliber/play-jira-exception-processor","homepage":"","size":56,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14"},"html":{"href":"https://github.com/Kaliber/play-jira-exception-processor/pull/14"},"issue":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/14"},"comments":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/Kaliber/play-jira-exception-processor/statuses/94279944e2d10b9e76abe52fe70456473b761160"}}}}
{"actor":{"display_login":"EECOLOR"}}