{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/3095","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/3095/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/3095/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/3095/events","html_url":"https://github.com/Automattic/wp-calypso/pull/3095","id":131505660,"number":3095,"title":"Security: Avoid destructuring as it breaks `this` context","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars.githubusercontent.com/u/1779930?v=3","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Security","name":"Security","color":"006b75"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-04T23:30:13Z","updated_at":"2016-02-04T23:42:06Z","closed_at":"2016-02-04T23:37:09Z","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/3095","html_url":"https://github.com/Automattic/wp-calypso/pull/3095","diff_url":"https://github.com/Automattic/wp-calypso/pull/3095.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/3095.patch"},"body":"This pull request seeks to resolve an error where the [update password form](http://calypso.localhost:3000/me/security) can result in an error when attempting to save a password. The object destructuring appears to alter the `this` context of `saveSettings` which is depended upon by [the callback to the user settings save](https://github.com/Automattic/wp-calypso/blob/2f7b89146b8a18e7af8b93437512b78075546786/client/lib/user-settings/index.js#L115).\r\n\r\n__Testing instructions:__\r\n\r\n1. Navigate to the [update password page](http://calypso.localhost:3000/me/security)\r\n2. Enter a new password\r\n3. Click Save Password\r\n4. Note that a success notice is shown, and no errors exist in the developer tools console\r\n5. Confirm that your password has changed successfully by logging out and in again"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/180105378","html_url":"https://github.com/Automattic/wp-calypso/pull/3095#issuecomment-180105378","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/3095","id":180105378,"user":{"login":"artpi","id":3775068,"avatar_url":"https://avatars.githubusercontent.com/u/3775068?v=3","gravatar_id":"","url":"https://api.github.com/users/artpi","html_url":"https://github.com/artpi","followers_url":"https://api.github.com/users/artpi/followers","following_url":"https://api.github.com/users/artpi/following{/other_user}","gists_url":"https://api.github.com/users/artpi/gists{/gist_id}","starred_url":"https://api.github.com/users/artpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpi/subscriptions","organizations_url":"https://api.github.com/users/artpi/orgs","repos_url":"https://api.github.com/users/artpi/repos","events_url":"https://api.github.com/users/artpi/events{/privacy}","received_events_url":"https://api.github.com/users/artpi/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T23:42:06Z","updated_at":"2016-02-04T23:42:06Z","body":"(My fault)"}}