{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/react-redux/issues/433","repository_url":"https://api.github.com/repos/reactjs/react-redux","labels_url":"https://api.github.com/repos/reactjs/react-redux/issues/433/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/react-redux/issues/433/comments","events_url":"https://api.github.com/repos/reactjs/react-redux/issues/433/events","html_url":"https://github.com/reactjs/react-redux/pull/433","id":165084991,"number":433,"title":"Add Typescript definitions.","user":{"login":"DaanDeMeyer","id":9395011,"avatar_url":"https://avatars.githubusercontent.com/u/9395011?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanDeMeyer","html_url":"https://github.com/DaanDeMeyer","followers_url":"https://api.github.com/users/DaanDeMeyer/followers","following_url":"https://api.github.com/users/DaanDeMeyer/following{/other_user}","gists_url":"https://api.github.com/users/DaanDeMeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanDeMeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanDeMeyer/subscriptions","organizations_url":"https://api.github.com/users/DaanDeMeyer/orgs","repos_url":"https://api.github.com/users/DaanDeMeyer/repos","events_url":"https://api.github.com/users/DaanDeMeyer/events{/privacy}","received_events_url":"https://api.github.com/users/DaanDeMeyer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-07-12T13:49:05Z","updated_at":"2016-11-07T16:05:37Z","closed_at":"2016-09-16T20:55:53Z","pull_request":{"url":"https://api.github.com/repos/reactjs/react-redux/pulls/433","html_url":"https://github.com/reactjs/react-redux/pull/433","diff_url":"https://github.com/reactjs/react-redux/pull/433.diff","patch_url":"https://github.com/reactjs/react-redux/pull/433.patch"},"body":"Having Typescript definitions in the repository itself saves users from having to download the definitions separately and changes to the main redux definitions can be more easily applied to the react-redux definitions.\n\nI've taken the definitions from the DefinitelyTyped repository. The only change I made is the addition of the generic State type to the connect function so the State parameter of the mapStateToProps function can actually be typed instead of being of the 'any' type. \n\nThe rest of the definitions seem to be correct.\n"},"comment":{"url":"https://api.github.com/repos/reactjs/react-redux/issues/comments/258877750","html_url":"https://github.com/reactjs/react-redux/pull/433#issuecomment-258877750","issue_url":"https://api.github.com/repos/reactjs/react-redux/issues/433","id":258877750,"user":{"login":"timdorr","id":17882,"avatar_url":"https://avatars.githubusercontent.com/u/17882?v=3","gravatar_id":"","url":"https://api.github.com/users/timdorr","html_url":"https://github.com/timdorr","followers_url":"https://api.github.com/users/timdorr/followers","following_url":"https://api.github.com/users/timdorr/following{/other_user}","gists_url":"https://api.github.com/users/timdorr/gists{/gist_id}","starred_url":"https://api.github.com/users/timdorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdorr/subscriptions","organizations_url":"https://api.github.com/users/timdorr/orgs","repos_url":"https://api.github.com/users/timdorr/repos","events_url":"https://api.github.com/users/timdorr/events{/privacy}","received_events_url":"https://api.github.com/users/timdorr/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T16:05:37Z","updated_at":"2016-11-07T16:05:37Z","body":"It's more that our current set of maintainers don't use TS, so we don't have any ability to maintain those typings. If you want to see it here, I'm more than happy to accept a PR, but understand that we'll rely on the community to guide those typings. That's how we did the TS and Flow typings on Redux.\r\n\r\nI can basically just read through comments and mash the appropriate button. I'm a typing dunce 😄 "}}
{"actor":{"display_login":"timdorr"}}