{"action":"created","issue":{"url":"https://api.github.com/repos/stavro/arc/issues/36","labels_url":"https://api.github.com/repos/stavro/arc/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/stavro/arc/issues/36/comments","events_url":"https://api.github.com/repos/stavro/arc/issues/36/events","html_url":"https://github.com/stavro/arc/pull/36","id":125113348,"number":36,"title":"Storage Type From Config","user":{"login":"baoist","id":68718,"avatar_url":"https://avatars.githubusercontent.com/u/68718?v=3","gravatar_id":"","url":"https://api.github.com/users/baoist","html_url":"https://github.com/baoist","followers_url":"https://api.github.com/users/baoist/followers","following_url":"https://api.github.com/users/baoist/following{/other_user}","gists_url":"https://api.github.com/users/baoist/gists{/gist_id}","starred_url":"https://api.github.com/users/baoist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baoist/subscriptions","organizations_url":"https://api.github.com/users/baoist/orgs","repos_url":"https://api.github.com/users/baoist/repos","events_url":"https://api.github.com/users/baoist/events{/privacy}","received_events_url":"https://api.github.com/users/baoist/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-06T05:29:33Z","updated_at":"2016-01-07T18:07:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stavro/arc/pulls/36","html_url":"https://github.com/stavro/arc/pull/36","diff_url":"https://github.com/stavro/arc/pull/36.diff","patch_url":"https://github.com/stavro/arc/pull/36.patch"},"body":"Source issue #32.\r\n\r\nChanges:\r\n- Storage method specific in config, rather than implementation definition (defaults to `Arc.Storage.S3`). This allows the user to change the storage type for testing.\r\n\r\nLet me know if you think this is a worthwhile change, or if you want to see more tests."},"comment":{"url":"https://api.github.com/repos/stavro/arc/issues/comments/169759163","html_url":"https://github.com/stavro/arc/pull/36#issuecomment-169759163","issue_url":"https://api.github.com/repos/stavro/arc/issues/36","id":169759163,"user":{"login":"baoist","id":68718,"avatar_url":"https://avatars.githubusercontent.com/u/68718?v=3","gravatar_id":"","url":"https://api.github.com/users/baoist","html_url":"https://github.com/baoist","followers_url":"https://api.github.com/users/baoist/followers","following_url":"https://api.github.com/users/baoist/following{/other_user}","gists_url":"https://api.github.com/users/baoist/gists{/gist_id}","starred_url":"https://api.github.com/users/baoist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baoist/subscriptions","organizations_url":"https://api.github.com/users/baoist/orgs","repos_url":"https://api.github.com/users/baoist/repos","events_url":"https://api.github.com/users/baoist/events{/privacy}","received_events_url":"https://api.github.com/users/baoist/received_events","type":"User","site_admin":false},"created_at":"2016-01-07T18:07:56Z","updated_at":"2016-01-07T18:07:56Z","body":"Oh, that makes a lot of sense.\r\n\r\nI can look more later today or tomorrow, but I think it could be done similarly to the config in `ex_aws` (https://github.com/CargoSense/ex_aws#client-configuration). Particularly, using the default config and then allowing an override/switch with:\r\n```\r\n  def config_root do\r\n    Application.get_all_env(:my_other_ex_aws)\r\n  end\r\n```\r\n\r\nOtherwise, we can close this out. If this is the case, it might be worth noting how you can set up `__storage` to use local for testing in the README."}}