{"action":"created","comment":{"url":"https://api.github.com/repos/frctl/mandelbrot/pulls/comments/55304281","id":55304281,"diff_hunk":"@@ -20,11 +19,11 @@\n     // text-overflow: ellipsis;\n }\n .Header-button {\n+    @include border-inline('end', 1px solid $color-alpha-tint-light);\n     touch-action: manipulation;\n     border: 0;\n     height: 50px;\n     width: 50px;\n-    display: none;","path":"assets/scss/components/_header.scss","position":17,"original_position":17,"commit_id":"0fd7f8ed7b0bc052d3aad8e8f7969483e0fdb7be","original_commit_id":"0fd7f8ed7b0bc052d3aad8e8f7969483e0fdb7be","user":{"login":"paulrobertlloyd","id":813383,"avatar_url":"https://avatars.githubusercontent.com/u/813383?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrobertlloyd","html_url":"https://github.com/paulrobertlloyd","followers_url":"https://api.github.com/users/paulrobertlloyd/followers","following_url":"https://api.github.com/users/paulrobertlloyd/following{/other_user}","gists_url":"https://api.github.com/users/paulrobertlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobertlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobertlloyd/subscriptions","organizations_url":"https://api.github.com/users/paulrobertlloyd/orgs","repos_url":"https://api.github.com/users/paulrobertlloyd/repos","events_url":"https://api.github.com/users/paulrobertlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobertlloyd/received_events","type":"User","site_admin":false},"body":"Removed as overridden with later value.","created_at":"2016-03-08T01:35:43Z","updated_at":"2016-03-08T01:35:43Z","html_url":"https://github.com/frctl/mandelbrot/pull/4#discussion_r55304281","pull_request_url":"https://api.github.com/repos/frctl/mandelbrot/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/frctl/mandelbrot/pulls/comments/55304281"},"html":{"href":"https://github.com/frctl/mandelbrot/pull/4#discussion_r55304281"},"pull_request":{"href":"https://api.github.com/repos/frctl/mandelbrot/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/frctl/mandelbrot/pulls/4","id":62010989,"html_url":"https://github.com/frctl/mandelbrot/pull/4","diff_url":"https://github.com/frctl/mandelbrot/pull/4.diff","patch_url":"https://github.com/frctl/mandelbrot/pull/4.patch","issue_url":"https://api.github.com/repos/frctl/mandelbrot/issues/4","number":4,"state":"open","locked":false,"title":"[WIP]: I18n options and UI that supports RTL language direction","user":{"login":"paulrobertlloyd","id":813383,"avatar_url":"https://avatars.githubusercontent.com/u/813383?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrobertlloyd","html_url":"https://github.com/paulrobertlloyd","followers_url":"https://api.github.com/users/paulrobertlloyd/followers","following_url":"https://api.github.com/users/paulrobertlloyd/following{/other_user}","gists_url":"https://api.github.com/users/paulrobertlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobertlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobertlloyd/subscriptions","organizations_url":"https://api.github.com/users/paulrobertlloyd/orgs","repos_url":"https://api.github.com/users/paulrobertlloyd/repos","events_url":"https://api.github.com/users/paulrobertlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobertlloyd/received_events","type":"User","site_admin":false},"body":"First pass at ensuring the UI works with both left-to-right and right-to-left languages. (See: https://github.com/frctl/mandelbrot/issues/3)\r\n\r\n* Adds two new theme config options:  \r\n  `plugins.web.options.lang` (defaults to `en`)  \r\n  `plugins.web.options.langdir` (defaults to `ltr`)\r\n* Adds four Sass mixins that allow the use of logical values in place of physical ones for `margin-left|right`, `padding-left|right`, `border-left|right` and `left|right`. Basically left is now `start`and right is now `end`.\r\n* Fixes a few tiny bugs, but nothing significant; will leave further changes to subsequent PRs.\r\n\r\n*However…*\r\n\r\nThis PR requires some JavaScript help from @allmarkedup; when text direction is set to `rtl`, the panel resizing behaviour goes a bit crazy, and the navigation sidebar doesn’t collapse/work. Is it easy to test for text-direction in the JS, and adjust behaviour as necessary?","created_at":"2016-03-08T01:31:58Z","updated_at":"2016-03-08T01:35:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d462413269977d14a18c9ca67cd72df1bef24717","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/frctl/mandelbrot/pulls/4/commits","review_comments_url":"https://api.github.com/repos/frctl/mandelbrot/pulls/4/comments","review_comment_url":"https://api.github.com/repos/frctl/mandelbrot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frctl/mandelbrot/issues/4/comments","statuses_url":"https://api.github.com/repos/frctl/mandelbrot/statuses/0fd7f8ed7b0bc052d3aad8e8f7969483e0fdb7be","head":{"label":"paulrobertlloyd:i18noptions","ref":"i18noptions","sha":"0fd7f8ed7b0bc052d3aad8e8f7969483e0fdb7be","user":{"login":"paulrobertlloyd","id":813383,"avatar_url":"https://avatars.githubusercontent.com/u/813383?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrobertlloyd","html_url":"https://github.com/paulrobertlloyd","followers_url":"https://api.github.com/users/paulrobertlloyd/followers","following_url":"https://api.github.com/users/paulrobertlloyd/following{/other_user}","gists_url":"https://api.github.com/users/paulrobertlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobertlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobertlloyd/subscriptions","organizations_url":"https://api.github.com/users/paulrobertlloyd/orgs","repos_url":"https://api.github.com/users/paulrobertlloyd/repos","events_url":"https://api.github.com/users/paulrobertlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobertlloyd/received_events","type":"User","site_admin":false},"repo":{"id":53365726,"name":"mandelbrot","full_name":"paulrobertlloyd/mandelbrot","owner":{"login":"paulrobertlloyd","id":813383,"avatar_url":"https://avatars.githubusercontent.com/u/813383?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrobertlloyd","html_url":"https://github.com/paulrobertlloyd","followers_url":"https://api.github.com/users/paulrobertlloyd/followers","following_url":"https://api.github.com/users/paulrobertlloyd/following{/other_user}","gists_url":"https://api.github.com/users/paulrobertlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobertlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobertlloyd/subscriptions","organizations_url":"https://api.github.com/users/paulrobertlloyd/orgs","repos_url":"https://api.github.com/users/paulrobertlloyd/repos","events_url":"https://api.github.com/users/paulrobertlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobertlloyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulrobertlloyd/mandelbrot","description":"The default web UI theme Fractal.","fork":true,"url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot","forks_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/forks","keys_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/teams","hooks_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/hooks","issue_events_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/issues/events{/number}","events_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/events","assignees_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/assignees{/user}","branches_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/branches{/branch}","tags_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/tags","blobs_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/statuses/{sha}","languages_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/languages","stargazers_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/stargazers","contributors_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/contributors","subscribers_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/subscribers","subscription_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/subscription","commits_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/contents/{+path}","compare_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/merges","archive_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/downloads","issues_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/issues{/number}","pulls_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/pulls{/number}","milestones_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/milestones{/number}","notifications_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/labels{/name}","releases_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/releases{/id}","deployments_url":"https://api.github.com/repos/paulrobertlloyd/mandelbrot/deployments","created_at":"2016-03-07T23:05:55Z","updated_at":"2016-03-07T23:05:56Z","pushed_at":"2016-03-08T01:16:05Z","git_url":"git://github.com/paulrobertlloyd/mandelbrot.git","ssh_url":"git@github.com:paulrobertlloyd/mandelbrot.git","clone_url":"https://github.com/paulrobertlloyd/mandelbrot.git","svn_url":"https://github.com/paulrobertlloyd/mandelbrot","homepage":"","size":6023,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"frctl:master","ref":"master","sha":"e82fcaf5dc54e4e2c64f9049a6a2e4eb32710f51","user":{"login":"frctl","id":13216321,"avatar_url":"https://avatars.githubusercontent.com/u/13216321?v=3","gravatar_id":"","url":"https://api.github.com/users/frctl","html_url":"https://github.com/frctl","followers_url":"https://api.github.com/users/frctl/followers","following_url":"https://api.github.com/users/frctl/following{/other_user}","gists_url":"https://api.github.com/users/frctl/gists{/gist_id}","starred_url":"https://api.github.com/users/frctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frctl/subscriptions","organizations_url":"https://api.github.com/users/frctl/orgs","repos_url":"https://api.github.com/users/frctl/repos","events_url":"https://api.github.com/users/frctl/events{/privacy}","received_events_url":"https://api.github.com/users/frctl/received_events","type":"Organization","site_admin":false},"repo":{"id":52365948,"name":"mandelbrot","full_name":"frctl/mandelbrot","owner":{"login":"frctl","id":13216321,"avatar_url":"https://avatars.githubusercontent.com/u/13216321?v=3","gravatar_id":"","url":"https://api.github.com/users/frctl","html_url":"https://github.com/frctl","followers_url":"https://api.github.com/users/frctl/followers","following_url":"https://api.github.com/users/frctl/following{/other_user}","gists_url":"https://api.github.com/users/frctl/gists{/gist_id}","starred_url":"https://api.github.com/users/frctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frctl/subscriptions","organizations_url":"https://api.github.com/users/frctl/orgs","repos_url":"https://api.github.com/users/frctl/repos","events_url":"https://api.github.com/users/frctl/events{/privacy}","received_events_url":"https://api.github.com/users/frctl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frctl/mandelbrot","description":"The default web UI theme Fractal.","fork":false,"url":"https://api.github.com/repos/frctl/mandelbrot","forks_url":"https://api.github.com/repos/frctl/mandelbrot/forks","keys_url":"https://api.github.com/repos/frctl/mandelbrot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frctl/mandelbrot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frctl/mandelbrot/teams","hooks_url":"https://api.github.com/repos/frctl/mandelbrot/hooks","issue_events_url":"https://api.github.com/repos/frctl/mandelbrot/issues/events{/number}","events_url":"https://api.github.com/repos/frctl/mandelbrot/events","assignees_url":"https://api.github.com/repos/frctl/mandelbrot/assignees{/user}","branches_url":"https://api.github.com/repos/frctl/mandelbrot/branches{/branch}","tags_url":"https://api.github.com/repos/frctl/mandelbrot/tags","blobs_url":"https://api.github.com/repos/frctl/mandelbrot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frctl/mandelbrot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frctl/mandelbrot/git/refs{/sha}","trees_url":"https://api.github.com/repos/frctl/mandelbrot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frctl/mandelbrot/statuses/{sha}","languages_url":"https://api.github.com/repos/frctl/mandelbrot/languages","stargazers_url":"https://api.github.com/repos/frctl/mandelbrot/stargazers","contributors_url":"https://api.github.com/repos/frctl/mandelbrot/contributors","subscribers_url":"https://api.github.com/repos/frctl/mandelbrot/subscribers","subscription_url":"https://api.github.com/repos/frctl/mandelbrot/subscription","commits_url":"https://api.github.com/repos/frctl/mandelbrot/commits{/sha}","git_commits_url":"https://api.github.com/repos/frctl/mandelbrot/git/commits{/sha}","comments_url":"https://api.github.com/repos/frctl/mandelbrot/comments{/number}","issue_comment_url":"https://api.github.com/repos/frctl/mandelbrot/issues/comments{/number}","contents_url":"https://api.github.com/repos/frctl/mandelbrot/contents/{+path}","compare_url":"https://api.github.com/repos/frctl/mandelbrot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frctl/mandelbrot/merges","archive_url":"https://api.github.com/repos/frctl/mandelbrot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frctl/mandelbrot/downloads","issues_url":"https://api.github.com/repos/frctl/mandelbrot/issues{/number}","pulls_url":"https://api.github.com/repos/frctl/mandelbrot/pulls{/number}","milestones_url":"https://api.github.com/repos/frctl/mandelbrot/milestones{/number}","notifications_url":"https://api.github.com/repos/frctl/mandelbrot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frctl/mandelbrot/labels{/name}","releases_url":"https://api.github.com/repos/frctl/mandelbrot/releases{/id}","deployments_url":"https://api.github.com/repos/frctl/mandelbrot/deployments","created_at":"2016-02-23T14:45:53Z","updated_at":"2016-03-03T14:43:16Z","pushed_at":"2016-03-08T01:31:58Z","git_url":"git://github.com/frctl/mandelbrot.git","ssh_url":"git@github.com:frctl/mandelbrot.git","clone_url":"https://github.com/frctl/mandelbrot.git","svn_url":"https://github.com/frctl/mandelbrot","homepage":"","size":5997,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/frctl/mandelbrot/pulls/4"},"html":{"href":"https://github.com/frctl/mandelbrot/pull/4"},"issue":{"href":"https://api.github.com/repos/frctl/mandelbrot/issues/4"},"comments":{"href":"https://api.github.com/repos/frctl/mandelbrot/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/frctl/mandelbrot/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/frctl/mandelbrot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frctl/mandelbrot/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/frctl/mandelbrot/statuses/0fd7f8ed7b0bc052d3aad8e8f7969483e0fdb7be"}}}}