{"action":"created","comment":{"url":"https://api.github.com/repos/hpcloud/fissile/pulls/comments/83736435","pull_request_review_id":4533018,"id":83736435,"diff_hunk":"@@ -315,21 +406,21 @@ func (j roleBuildJob) Run() {\n \t\t\tj.resultsCh <- err\n \t\t\treturn\n \t\t} else if hasImage {\n-\t\t\tj.ui.Println(\"Skipping image build because it exists\")\n+\t\t\tj.ui.Printf(\"Skipping build of role images %s because it exists\\n\", color.YellowString(j.role.Name))","path":"builder/role_image.go","position":299,"original_position":299,"commit_id":"c07149a9d84e199a4cb1d2e5344aa82b882df286","original_commit_id":"c07149a9d84e199a4cb1d2e5344aa82b882df286","user":{"login":"viovanov","id":918484,"avatar_url":"https://avatars.githubusercontent.com/u/918484?v=3","gravatar_id":"","url":"https://api.github.com/users/viovanov","html_url":"https://github.com/viovanov","followers_url":"https://api.github.com/users/viovanov/followers","following_url":"https://api.github.com/users/viovanov/following{/other_user}","gists_url":"https://api.github.com/users/viovanov/gists{/gist_id}","starred_url":"https://api.github.com/users/viovanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viovanov/subscriptions","organizations_url":"https://api.github.com/users/viovanov/orgs","repos_url":"https://api.github.com/users/viovanov/repos","events_url":"https://api.github.com/users/viovanov/events{/privacy}","received_events_url":"https://api.github.com/users/viovanov/received_events","type":"User","site_admin":false},"body":"`images` should be singular, correct?","created_at":"2016-10-17T21:19:34Z","updated_at":"2016-10-17T21:20:51Z","html_url":"https://github.com/hpcloud/fissile/pull/159#discussion_r83736435","pull_request_url":"https://api.github.com/repos/hpcloud/fissile/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/comments/83736435"},"html":{"href":"https://github.com/hpcloud/fissile/pull/159#discussion_r83736435"},"pull_request":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/hpcloud/fissile/pulls/159","id":89435856,"html_url":"https://github.com/hpcloud/fissile/pull/159","diff_url":"https://github.com/hpcloud/fissile/pull/159.diff","patch_url":"https://github.com/hpcloud/fissile/pull/159.patch","issue_url":"https://api.github.com/repos/hpcloud/fissile/issues/159","number":159,"state":"open","locked":false,"title":"HCF-583 Put all packages into one layer","user":{"login":"Mook-as","id":3977982,"avatar_url":"https://avatars.githubusercontent.com/u/3977982?v=3","gravatar_id":"","url":"https://api.github.com/users/Mook-as","html_url":"https://github.com/Mook-as","followers_url":"https://api.github.com/users/Mook-as/followers","following_url":"https://api.github.com/users/Mook-as/following{/other_user}","gists_url":"https://api.github.com/users/Mook-as/gists{/gist_id}","starred_url":"https://api.github.com/users/Mook-as/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mook-as/subscriptions","organizations_url":"https://api.github.com/users/Mook-as/orgs","repos_url":"https://api.github.com/users/Mook-as/repos","events_url":"https://api.github.com/users/Mook-as/events{/privacy}","received_events_url":"https://api.github.com/users/Mook-as/received_events","type":"User","site_admin":false},"body":"This combines all the packages (and specs) into one layer, which is then shared by the various roles.  It reduces the _total_ disk usage of all the images in aggregate as shared packages (e.g. ruby) only take up disk space once, rather than being stored separately per role.  This does mean though that each image separately would be larger (as they now contain every package for the whole thing).\r\n\r\nEstimate is something like 40G total -> 8G in `/var/lib/docker`.","created_at":"2016-10-14T18:52:53Z","updated_at":"2016-10-17T21:20:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9b948579d3868aff71b8b73a8a1bda5953f1c0a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcloud/fissile/pulls/159/commits","review_comments_url":"https://api.github.com/repos/hpcloud/fissile/pulls/159/comments","review_comment_url":"https://api.github.com/repos/hpcloud/fissile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcloud/fissile/issues/159/comments","statuses_url":"https://api.github.com/repos/hpcloud/fissile/statuses/c07149a9d84e199a4cb1d2e5344aa82b882df286","head":{"label":"hpcloud:HCF-583-mega-package-image","ref":"HCF-583-mega-package-image","sha":"c07149a9d84e199a4cb1d2e5344aa82b882df286","user":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42498148,"name":"fissile","full_name":"hpcloud/fissile","owner":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcloud/fissile","description":"Turn a BOSH release into Docker images / files","fork":false,"url":"https://api.github.com/repos/hpcloud/fissile","forks_url":"https://api.github.com/repos/hpcloud/fissile/forks","keys_url":"https://api.github.com/repos/hpcloud/fissile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcloud/fissile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcloud/fissile/teams","hooks_url":"https://api.github.com/repos/hpcloud/fissile/hooks","issue_events_url":"https://api.github.com/repos/hpcloud/fissile/issues/events{/number}","events_url":"https://api.github.com/repos/hpcloud/fissile/events","assignees_url":"https://api.github.com/repos/hpcloud/fissile/assignees{/user}","branches_url":"https://api.github.com/repos/hpcloud/fissile/branches{/branch}","tags_url":"https://api.github.com/repos/hpcloud/fissile/tags","blobs_url":"https://api.github.com/repos/hpcloud/fissile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcloud/fissile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcloud/fissile/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcloud/fissile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcloud/fissile/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcloud/fissile/languages","stargazers_url":"https://api.github.com/repos/hpcloud/fissile/stargazers","contributors_url":"https://api.github.com/repos/hpcloud/fissile/contributors","subscribers_url":"https://api.github.com/repos/hpcloud/fissile/subscribers","subscription_url":"https://api.github.com/repos/hpcloud/fissile/subscription","commits_url":"https://api.github.com/repos/hpcloud/fissile/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcloud/fissile/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcloud/fissile/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcloud/fissile/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcloud/fissile/contents/{+path}","compare_url":"https://api.github.com/repos/hpcloud/fissile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcloud/fissile/merges","archive_url":"https://api.github.com/repos/hpcloud/fissile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcloud/fissile/downloads","issues_url":"https://api.github.com/repos/hpcloud/fissile/issues{/number}","pulls_url":"https://api.github.com/repos/hpcloud/fissile/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcloud/fissile/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcloud/fissile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcloud/fissile/labels{/name}","releases_url":"https://api.github.com/repos/hpcloud/fissile/releases{/id}","deployments_url":"https://api.github.com/repos/hpcloud/fissile/deployments","created_at":"2015-09-15T05:51:21Z","updated_at":"2016-10-13T13:34:24Z","pushed_at":"2016-10-17T17:06:10Z","git_url":"git://github.com/hpcloud/fissile.git","ssh_url":"git@github.com:hpcloud/fissile.git","clone_url":"https://github.com/hpcloud/fissile.git","svn_url":"https://github.com/hpcloud/fissile","homepage":"","size":27753,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":13,"default_branch":"develop"}},"base":{"label":"hpcloud:develop","ref":"develop","sha":"5603825835d42d5ea5616c106d82e171347b305d","user":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42498148,"name":"fissile","full_name":"hpcloud/fissile","owner":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcloud/fissile","description":"Turn a BOSH release into Docker images / files","fork":false,"url":"https://api.github.com/repos/hpcloud/fissile","forks_url":"https://api.github.com/repos/hpcloud/fissile/forks","keys_url":"https://api.github.com/repos/hpcloud/fissile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcloud/fissile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcloud/fissile/teams","hooks_url":"https://api.github.com/repos/hpcloud/fissile/hooks","issue_events_url":"https://api.github.com/repos/hpcloud/fissile/issues/events{/number}","events_url":"https://api.github.com/repos/hpcloud/fissile/events","assignees_url":"https://api.github.com/repos/hpcloud/fissile/assignees{/user}","branches_url":"https://api.github.com/repos/hpcloud/fissile/branches{/branch}","tags_url":"https://api.github.com/repos/hpcloud/fissile/tags","blobs_url":"https://api.github.com/repos/hpcloud/fissile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcloud/fissile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcloud/fissile/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcloud/fissile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcloud/fissile/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcloud/fissile/languages","stargazers_url":"https://api.github.com/repos/hpcloud/fissile/stargazers","contributors_url":"https://api.github.com/repos/hpcloud/fissile/contributors","subscribers_url":"https://api.github.com/repos/hpcloud/fissile/subscribers","subscription_url":"https://api.github.com/repos/hpcloud/fissile/subscription","commits_url":"https://api.github.com/repos/hpcloud/fissile/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcloud/fissile/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcloud/fissile/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcloud/fissile/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcloud/fissile/contents/{+path}","compare_url":"https://api.github.com/repos/hpcloud/fissile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcloud/fissile/merges","archive_url":"https://api.github.com/repos/hpcloud/fissile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcloud/fissile/downloads","issues_url":"https://api.github.com/repos/hpcloud/fissile/issues{/number}","pulls_url":"https://api.github.com/repos/hpcloud/fissile/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcloud/fissile/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcloud/fissile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcloud/fissile/labels{/name}","releases_url":"https://api.github.com/repos/hpcloud/fissile/releases{/id}","deployments_url":"https://api.github.com/repos/hpcloud/fissile/deployments","created_at":"2015-09-15T05:51:21Z","updated_at":"2016-10-13T13:34:24Z","pushed_at":"2016-10-17T17:06:10Z","git_url":"git://github.com/hpcloud/fissile.git","ssh_url":"git@github.com:hpcloud/fissile.git","clone_url":"https://github.com/hpcloud/fissile.git","svn_url":"https://github.com/hpcloud/fissile","homepage":"","size":27753,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/159"},"html":{"href":"https://github.com/hpcloud/fissile/pull/159"},"issue":{"href":"https://api.github.com/repos/hpcloud/fissile/issues/159"},"comments":{"href":"https://api.github.com/repos/hpcloud/fissile/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcloud/fissile/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/hpcloud/fissile/statuses/c07149a9d84e199a4cb1d2e5344aa82b882df286"}}}}
{"actor":{"display_login":"viovanov"}}