{"action":"created","comment":{"url":"https://api.github.com/repos/xenolf/lego/pulls/comments/57272796","id":57272796,"diff_hunk":"@@ -88,179 +72,29 @@ func (s *dnsChallenge) Solve(chlng challenge, domain string) error {\n }\n \n // checkDNSPropagation checks if the expected TXT record has been propagated to all authoritative nameservers.\n-func checkDNSPropagation(fqdn, value string) (bool, error) {\n-\t// Initial attempt to resolve at the recursive NS\n-\tr, err := dnsQuery(fqdn, dns.TypeTXT, recursiveNameserver, true)\n-\tif err != nil {\n-\t\treturn false, err\n-\t}\n-\tif r.Rcode == dns.RcodeSuccess {\n-\t\t// If we see a CNAME here then use the alias\n-\t\tfor _, rr := range r.Answer {\n-\t\t\tif cn, ok := rr.(*dns.CNAME); ok {\n-\t\t\t\tif cn.Hdr.Name == fqdn {\n-\t\t\t\t\tfqdn = cn.Target\n-\t\t\t\t\tbreak\n-\t\t\t\t}\n-\t\t\t}\n-\t\t}\n-\t}\n-\n-\tauthoritativeNss, err := lookupNameservers(fqdn)\n-\tif err != nil {\n-\t\treturn false, err\n-\t}\n-\n-\treturn checkAuthoritativeNss(fqdn, value, authoritativeNss)\n+func checkDNSPropagation(fqdn *Domain, value string) (bool, error) {","path":"acme/dns_challenge.go","position":112,"original_position":112,"commit_id":"8a38a332d73f6de7bebc3d6c7561800acacddf2a","original_commit_id":"8a38a332d73f6de7bebc3d6c7561800acacddf2a","user":{"login":"willseward","id":5386568,"avatar_url":"https://avatars.githubusercontent.com/u/5386568?v=3","gravatar_id":"","url":"https://api.github.com/users/willseward","html_url":"https://github.com/willseward","followers_url":"https://api.github.com/users/willseward/followers","following_url":"https://api.github.com/users/willseward/following{/other_user}","gists_url":"https://api.github.com/users/willseward/gists{/gist_id}","starred_url":"https://api.github.com/users/willseward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willseward/subscriptions","organizations_url":"https://api.github.com/users/willseward/orgs","repos_url":"https://api.github.com/users/willseward/repos","events_url":"https://api.github.com/users/willseward/events{/privacy}","received_events_url":"https://api.github.com/users/willseward/received_events","type":"User","site_admin":false},"body":"That function exists to permit testing with no-op functions","created_at":"2016-03-24T04:09:55Z","updated_at":"2016-03-24T04:09:55Z","html_url":"https://github.com/xenolf/lego/pull/159#discussion_r57272796","pull_request_url":"https://api.github.com/repos/xenolf/lego/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/xenolf/lego/pulls/comments/57272796"},"html":{"href":"https://github.com/xenolf/lego/pull/159#discussion_r57272796"},"pull_request":{"href":"https://api.github.com/repos/xenolf/lego/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/xenolf/lego/pulls/159","id":63315599,"html_url":"https://github.com/xenolf/lego/pull/159","diff_url":"https://github.com/xenolf/lego/pull/159.diff","patch_url":"https://github.com/xenolf/lego/pull/159.patch","issue_url":"https://api.github.com/repos/xenolf/lego/issues/159","number":159,"state":"open","locked":false,"title":"refactored for authzone lookup - DO CNAME fix","user":{"login":"willseward","id":5386568,"avatar_url":"https://avatars.githubusercontent.com/u/5386568?v=3","gravatar_id":"","url":"https://api.github.com/users/willseward","html_url":"https://github.com/willseward","followers_url":"https://api.github.com/users/willseward/followers","following_url":"https://api.github.com/users/willseward/following{/other_user}","gists_url":"https://api.github.com/users/willseward/gists{/gist_id}","starred_url":"https://api.github.com/users/willseward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willseward/subscriptions","organizations_url":"https://api.github.com/users/willseward/orgs","repos_url":"https://api.github.com/users/willseward/repos","events_url":"https://api.github.com/users/willseward/events{/privacy}","received_events_url":"https://api.github.com/users/willseward/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2016-03-18T01:08:48Z","updated_at":"2016-03-24T04:09:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceec8f41ae53aa0c9114f86d7b55485dc7a521c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xenolf/lego/pulls/159/commits","review_comments_url":"https://api.github.com/repos/xenolf/lego/pulls/159/comments","review_comment_url":"https://api.github.com/repos/xenolf/lego/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xenolf/lego/issues/159/comments","statuses_url":"https://api.github.com/repos/xenolf/lego/statuses/8a38a332d73f6de7bebc3d6c7561800acacddf2a","head":{"label":"willseward:authoritative-zone-lookup","ref":"authoritative-zone-lookup","sha":"8a38a332d73f6de7bebc3d6c7561800acacddf2a","user":{"login":"willseward","id":5386568,"avatar_url":"https://avatars.githubusercontent.com/u/5386568?v=3","gravatar_id":"","url":"https://api.github.com/users/willseward","html_url":"https://github.com/willseward","followers_url":"https://api.github.com/users/willseward/followers","following_url":"https://api.github.com/users/willseward/following{/other_user}","gists_url":"https://api.github.com/users/willseward/gists{/gist_id}","starred_url":"https://api.github.com/users/willseward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willseward/subscriptions","organizations_url":"https://api.github.com/users/willseward/orgs","repos_url":"https://api.github.com/users/willseward/repos","events_url":"https://api.github.com/users/willseward/events{/privacy}","received_events_url":"https://api.github.com/users/willseward/received_events","type":"User","site_admin":false},"repo":{"id":53768029,"name":"lego","full_name":"willseward/lego","owner":{"login":"willseward","id":5386568,"avatar_url":"https://avatars.githubusercontent.com/u/5386568?v=3","gravatar_id":"","url":"https://api.github.com/users/willseward","html_url":"https://github.com/willseward","followers_url":"https://api.github.com/users/willseward/followers","following_url":"https://api.github.com/users/willseward/following{/other_user}","gists_url":"https://api.github.com/users/willseward/gists{/gist_id}","starred_url":"https://api.github.com/users/willseward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willseward/subscriptions","organizations_url":"https://api.github.com/users/willseward/orgs","repos_url":"https://api.github.com/users/willseward/repos","events_url":"https://api.github.com/users/willseward/events{/privacy}","received_events_url":"https://api.github.com/users/willseward/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willseward/lego","description":"Let's Encrypt client and ACME library written in Go","fork":true,"url":"https://api.github.com/repos/willseward/lego","forks_url":"https://api.github.com/repos/willseward/lego/forks","keys_url":"https://api.github.com/repos/willseward/lego/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willseward/lego/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willseward/lego/teams","hooks_url":"https://api.github.com/repos/willseward/lego/hooks","issue_events_url":"https://api.github.com/repos/willseward/lego/issues/events{/number}","events_url":"https://api.github.com/repos/willseward/lego/events","assignees_url":"https://api.github.com/repos/willseward/lego/assignees{/user}","branches_url":"https://api.github.com/repos/willseward/lego/branches{/branch}","tags_url":"https://api.github.com/repos/willseward/lego/tags","blobs_url":"https://api.github.com/repos/willseward/lego/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willseward/lego/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willseward/lego/git/refs{/sha}","trees_url":"https://api.github.com/repos/willseward/lego/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willseward/lego/statuses/{sha}","languages_url":"https://api.github.com/repos/willseward/lego/languages","stargazers_url":"https://api.github.com/repos/willseward/lego/stargazers","contributors_url":"https://api.github.com/repos/willseward/lego/contributors","subscribers_url":"https://api.github.com/repos/willseward/lego/subscribers","subscription_url":"https://api.github.com/repos/willseward/lego/subscription","commits_url":"https://api.github.com/repos/willseward/lego/commits{/sha}","git_commits_url":"https://api.github.com/repos/willseward/lego/git/commits{/sha}","comments_url":"https://api.github.com/repos/willseward/lego/comments{/number}","issue_comment_url":"https://api.github.com/repos/willseward/lego/issues/comments{/number}","contents_url":"https://api.github.com/repos/willseward/lego/contents/{+path}","compare_url":"https://api.github.com/repos/willseward/lego/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willseward/lego/merges","archive_url":"https://api.github.com/repos/willseward/lego/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willseward/lego/downloads","issues_url":"https://api.github.com/repos/willseward/lego/issues{/number}","pulls_url":"https://api.github.com/repos/willseward/lego/pulls{/number}","milestones_url":"https://api.github.com/repos/willseward/lego/milestones{/number}","notifications_url":"https://api.github.com/repos/willseward/lego/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willseward/lego/labels{/name}","releases_url":"https://api.github.com/repos/willseward/lego/releases{/id}","deployments_url":"https://api.github.com/repos/willseward/lego/deployments","created_at":"2016-03-13T04:48:53Z","updated_at":"2016-03-13T04:48:53Z","pushed_at":"2016-03-23T16:29:30Z","git_url":"git://github.com/willseward/lego.git","ssh_url":"git@github.com:willseward/lego.git","clone_url":"https://github.com/willseward/lego.git","svn_url":"https://github.com/willseward/lego","homepage":"","size":472,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xenolf:master","ref":"master","sha":"636fb51fb049cf65c260ba8ea6dc4dc7cfebafa9","user":{"login":"xenolf","id":578256,"avatar_url":"https://avatars.githubusercontent.com/u/578256?v=3","gravatar_id":"","url":"https://api.github.com/users/xenolf","html_url":"https://github.com/xenolf","followers_url":"https://api.github.com/users/xenolf/followers","following_url":"https://api.github.com/users/xenolf/following{/other_user}","gists_url":"https://api.github.com/users/xenolf/gists{/gist_id}","starred_url":"https://api.github.com/users/xenolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenolf/subscriptions","organizations_url":"https://api.github.com/users/xenolf/orgs","repos_url":"https://api.github.com/users/xenolf/repos","events_url":"https://api.github.com/users/xenolf/events{/privacy}","received_events_url":"https://api.github.com/users/xenolf/received_events","type":"User","site_admin":false},"repo":{"id":37038121,"name":"lego","full_name":"xenolf/lego","owner":{"login":"xenolf","id":578256,"avatar_url":"https://avatars.githubusercontent.com/u/578256?v=3","gravatar_id":"","url":"https://api.github.com/users/xenolf","html_url":"https://github.com/xenolf","followers_url":"https://api.github.com/users/xenolf/followers","following_url":"https://api.github.com/users/xenolf/following{/other_user}","gists_url":"https://api.github.com/users/xenolf/gists{/gist_id}","starred_url":"https://api.github.com/users/xenolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xenolf/subscriptions","organizations_url":"https://api.github.com/users/xenolf/orgs","repos_url":"https://api.github.com/users/xenolf/repos","events_url":"https://api.github.com/users/xenolf/events{/privacy}","received_events_url":"https://api.github.com/users/xenolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xenolf/lego","description":"Let's Encrypt client and ACME library written in Go","fork":false,"url":"https://api.github.com/repos/xenolf/lego","forks_url":"https://api.github.com/repos/xenolf/lego/forks","keys_url":"https://api.github.com/repos/xenolf/lego/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xenolf/lego/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xenolf/lego/teams","hooks_url":"https://api.github.com/repos/xenolf/lego/hooks","issue_events_url":"https://api.github.com/repos/xenolf/lego/issues/events{/number}","events_url":"https://api.github.com/repos/xenolf/lego/events","assignees_url":"https://api.github.com/repos/xenolf/lego/assignees{/user}","branches_url":"https://api.github.com/repos/xenolf/lego/branches{/branch}","tags_url":"https://api.github.com/repos/xenolf/lego/tags","blobs_url":"https://api.github.com/repos/xenolf/lego/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xenolf/lego/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xenolf/lego/git/refs{/sha}","trees_url":"https://api.github.com/repos/xenolf/lego/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xenolf/lego/statuses/{sha}","languages_url":"https://api.github.com/repos/xenolf/lego/languages","stargazers_url":"https://api.github.com/repos/xenolf/lego/stargazers","contributors_url":"https://api.github.com/repos/xenolf/lego/contributors","subscribers_url":"https://api.github.com/repos/xenolf/lego/subscribers","subscription_url":"https://api.github.com/repos/xenolf/lego/subscription","commits_url":"https://api.github.com/repos/xenolf/lego/commits{/sha}","git_commits_url":"https://api.github.com/repos/xenolf/lego/git/commits{/sha}","comments_url":"https://api.github.com/repos/xenolf/lego/comments{/number}","issue_comment_url":"https://api.github.com/repos/xenolf/lego/issues/comments{/number}","contents_url":"https://api.github.com/repos/xenolf/lego/contents/{+path}","compare_url":"https://api.github.com/repos/xenolf/lego/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xenolf/lego/merges","archive_url":"https://api.github.com/repos/xenolf/lego/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xenolf/lego/downloads","issues_url":"https://api.github.com/repos/xenolf/lego/issues{/number}","pulls_url":"https://api.github.com/repos/xenolf/lego/pulls{/number}","milestones_url":"https://api.github.com/repos/xenolf/lego/milestones{/number}","notifications_url":"https://api.github.com/repos/xenolf/lego/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xenolf/lego/labels{/name}","releases_url":"https://api.github.com/repos/xenolf/lego/releases{/id}","deployments_url":"https://api.github.com/repos/xenolf/lego/deployments","created_at":"2015-06-08T00:36:41Z","updated_at":"2016-03-23T23:18:52Z","pushed_at":"2016-03-23T22:55:18Z","git_url":"git://github.com/xenolf/lego.git","ssh_url":"git@github.com:xenolf/lego.git","clone_url":"https://github.com/xenolf/lego.git","svn_url":"https://github.com/xenolf/lego","homepage":"","size":527,"stargazers_count":1043,"watchers_count":1043,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":17,"forks":64,"open_issues":17,"watchers":1043,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xenolf/lego/pulls/159"},"html":{"href":"https://github.com/xenolf/lego/pull/159"},"issue":{"href":"https://api.github.com/repos/xenolf/lego/issues/159"},"comments":{"href":"https://api.github.com/repos/xenolf/lego/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/xenolf/lego/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/xenolf/lego/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xenolf/lego/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/xenolf/lego/statuses/8a38a332d73f6de7bebc3d6c7561800acacddf2a"}}}}