{"action":"created","comment":{"url":"https://api.github.com/repos/ostreedev/ostree/pulls/comments/69606920","id":69606920,"diff_hunk":"@@ -2133,6 +2195,65 @@ repo_remote_fetch_summary (OstreeRepo    *self,\n   return ret;\n }\n \n+static void\n+delta_superblock_fetch_on_complete (GObject        *object,\n+                         GAsyncResult   *result,\n+                         gpointer        user_data)\n+{\n+  OstreeFetcher *fetcher = (OstreeFetcher *)object;\n+  FetchDeltaSuperBlockData *fetch_data = user_data;\n+  OtPullData *pull_data = fetch_data->pull_data;\n+  GError *local_error = NULL;\n+  GError **error = &local_error;\n+  GInputStream* input = _ostree_fetcher_stream_uri_finish (fetcher, result, error);\n+  GBytes* delta_superblock_data = NULL;\n+\n+  if (input)\n+    {\n+      delta_superblock_data = g_input_stream_read_bytes ( input, OSTREE_MAX_METADATA_SIZE, pull_data->cancellable, error);","path":"src/libostree/ostree-repo-pull.c","position":611,"original_position":286,"commit_id":"01fc763c69909b621843f445edbbb37d4e950b3a","original_commit_id":"13199c1d945dca07cd8f345cc9724540a67cac94","user":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars.githubusercontent.com/u/244096?v=3","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"Are you going to be able to update this PR relatively soon for these error handling cleanups?\r\n\r\nI'd like to at least land critical things like the memleak fixes and fix existing error handling soon without pulling in right away all of the pull code path reworks which are higher risk.","created_at":"2016-07-05T17:47:10Z","updated_at":"2016-07-05T17:47:10Z","html_url":"https://github.com/ostreedev/ostree/pull/353#discussion_r69606920","pull_request_url":"https://api.github.com/repos/ostreedev/ostree/pulls/353","_links":{"self":{"href":"https://api.github.com/repos/ostreedev/ostree/pulls/comments/69606920"},"html":{"href":"https://github.com/ostreedev/ostree/pull/353#discussion_r69606920"},"pull_request":{"href":"https://api.github.com/repos/ostreedev/ostree/pulls/353"}}},"pull_request":{"url":"https://api.github.com/repos/ostreedev/ostree/pulls/353","id":74343164,"html_url":"https://github.com/ostreedev/ostree/pull/353","diff_url":"https://github.com/ostreedev/ostree/pull/353.diff","patch_url":"https://github.com/ostreedev/ostree/pull/353.patch","issue_url":"https://api.github.com/repos/ostreedev/ostree/issues/353","number":353,"state":"open","locked":false,"title":"More pull code changes","user":{"login":"Mathnerd314","id":322214,"avatar_url":"https://avatars.githubusercontent.com/u/322214?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathnerd314","html_url":"https://github.com/Mathnerd314","followers_url":"https://api.github.com/users/Mathnerd314/followers","following_url":"https://api.github.com/users/Mathnerd314/following{/other_user}","gists_url":"https://api.github.com/users/Mathnerd314/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathnerd314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathnerd314/subscriptions","organizations_url":"https://api.github.com/users/Mathnerd314/orgs","repos_url":"https://api.github.com/users/Mathnerd314/repos","events_url":"https://api.github.com/users/Mathnerd314/events{/privacy}","received_events_url":"https://api.github.com/users/Mathnerd314/received_events","type":"User","site_admin":false},"body":"As someone on #fedora-meeting told me, \"Merge early, merge often.\" Maybe that means I should merge more frequently than once a week?\r\n\r\nThe end goal is to get of synchronous fetches completely; this is a halfway step that fetches refs asynchronously but still does the summary on the main thread.\r\n\r\nBut there are also some global refactorings mixed in, namely OSTREE_SHA256_STRING_LEN and \r\nOSTREE_OBJECT_TYPE_COMMIT_META. Plus -Wempty-body and some confused logic in refs.","created_at":"2016-06-18T17:48:06Z","updated_at":"2016-07-05T17:47:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26a12aa31e331f742367a151c53af0d3cf965e57","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ostreedev/ostree/pulls/353/commits","review_comments_url":"https://api.github.com/repos/ostreedev/ostree/pulls/353/comments","review_comment_url":"https://api.github.com/repos/ostreedev/ostree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ostreedev/ostree/issues/353/comments","statuses_url":"https://api.github.com/repos/ostreedev/ostree/statuses/01fc763c69909b621843f445edbbb37d4e950b3a","head":{"label":"Mathnerd314:libsoup","ref":"libsoup","sha":"01fc763c69909b621843f445edbbb37d4e950b3a","user":{"login":"Mathnerd314","id":322214,"avatar_url":"https://avatars.githubusercontent.com/u/322214?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathnerd314","html_url":"https://github.com/Mathnerd314","followers_url":"https://api.github.com/users/Mathnerd314/followers","following_url":"https://api.github.com/users/Mathnerd314/following{/other_user}","gists_url":"https://api.github.com/users/Mathnerd314/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathnerd314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathnerd314/subscriptions","organizations_url":"https://api.github.com/users/Mathnerd314/orgs","repos_url":"https://api.github.com/users/Mathnerd314/repos","events_url":"https://api.github.com/users/Mathnerd314/events{/privacy}","received_events_url":"https://api.github.com/users/Mathnerd314/received_events","type":"User","site_admin":false},"repo":{"id":59446188,"name":"ostree","full_name":"Mathnerd314/ostree","owner":{"login":"Mathnerd314","id":322214,"avatar_url":"https://avatars.githubusercontent.com/u/322214?v=3","gravatar_id":"","url":"https://api.github.com/users/Mathnerd314","html_url":"https://github.com/Mathnerd314","followers_url":"https://api.github.com/users/Mathnerd314/followers","following_url":"https://api.github.com/users/Mathnerd314/following{/other_user}","gists_url":"https://api.github.com/users/Mathnerd314/gists{/gist_id}","starred_url":"https://api.github.com/users/Mathnerd314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mathnerd314/subscriptions","organizations_url":"https://api.github.com/users/Mathnerd314/orgs","repos_url":"https://api.github.com/users/Mathnerd314/repos","events_url":"https://api.github.com/users/Mathnerd314/events{/privacy}","received_events_url":"https://api.github.com/users/Mathnerd314/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mathnerd314/ostree","description":"Operating system and container binary deployment and upgrades","fork":true,"url":"https://api.github.com/repos/Mathnerd314/ostree","forks_url":"https://api.github.com/repos/Mathnerd314/ostree/forks","keys_url":"https://api.github.com/repos/Mathnerd314/ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mathnerd314/ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mathnerd314/ostree/teams","hooks_url":"https://api.github.com/repos/Mathnerd314/ostree/hooks","issue_events_url":"https://api.github.com/repos/Mathnerd314/ostree/issues/events{/number}","events_url":"https://api.github.com/repos/Mathnerd314/ostree/events","assignees_url":"https://api.github.com/repos/Mathnerd314/ostree/assignees{/user}","branches_url":"https://api.github.com/repos/Mathnerd314/ostree/branches{/branch}","tags_url":"https://api.github.com/repos/Mathnerd314/ostree/tags","blobs_url":"https://api.github.com/repos/Mathnerd314/ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mathnerd314/ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mathnerd314/ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mathnerd314/ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mathnerd314/ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/Mathnerd314/ostree/languages","stargazers_url":"https://api.github.com/repos/Mathnerd314/ostree/stargazers","contributors_url":"https://api.github.com/repos/Mathnerd314/ostree/contributors","subscribers_url":"https://api.github.com/repos/Mathnerd314/ostree/subscribers","subscription_url":"https://api.github.com/repos/Mathnerd314/ostree/subscription","commits_url":"https://api.github.com/repos/Mathnerd314/ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mathnerd314/ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mathnerd314/ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mathnerd314/ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mathnerd314/ostree/contents/{+path}","compare_url":"https://api.github.com/repos/Mathnerd314/ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mathnerd314/ostree/merges","archive_url":"https://api.github.com/repos/Mathnerd314/ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mathnerd314/ostree/downloads","issues_url":"https://api.github.com/repos/Mathnerd314/ostree/issues{/number}","pulls_url":"https://api.github.com/repos/Mathnerd314/ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/Mathnerd314/ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/Mathnerd314/ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mathnerd314/ostree/labels{/name}","releases_url":"https://api.github.com/repos/Mathnerd314/ostree/releases{/id}","deployments_url":"https://api.github.com/repos/Mathnerd314/ostree/deployments","created_at":"2016-05-23T02:24:57Z","updated_at":"2016-05-23T02:25:00Z","pushed_at":"2016-06-22T18:41:09Z","git_url":"git://github.com/Mathnerd314/ostree.git","ssh_url":"git@github.com:Mathnerd314/ostree.git","clone_url":"https://github.com/Mathnerd314/ostree.git","svn_url":"https://github.com/Mathnerd314/ostree","homepage":"https://ostree.readthedocs.org/en/latest/","size":9914,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ostreedev:master","ref":"master","sha":"23049bbd011924b1e34514b14e58d82519346d36","user":{"login":"ostreedev","id":17928213,"avatar_url":"https://avatars.githubusercontent.com/u/17928213?v=3","gravatar_id":"","url":"https://api.github.com/users/ostreedev","html_url":"https://github.com/ostreedev","followers_url":"https://api.github.com/users/ostreedev/followers","following_url":"https://api.github.com/users/ostreedev/following{/other_user}","gists_url":"https://api.github.com/users/ostreedev/gists{/gist_id}","starred_url":"https://api.github.com/users/ostreedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostreedev/subscriptions","organizations_url":"https://api.github.com/users/ostreedev/orgs","repos_url":"https://api.github.com/users/ostreedev/repos","events_url":"https://api.github.com/users/ostreedev/events{/privacy}","received_events_url":"https://api.github.com/users/ostreedev/received_events","type":"Organization","site_admin":false},"repo":{"id":4614541,"name":"ostree","full_name":"ostreedev/ostree","owner":{"login":"ostreedev","id":17928213,"avatar_url":"https://avatars.githubusercontent.com/u/17928213?v=3","gravatar_id":"","url":"https://api.github.com/users/ostreedev","html_url":"https://github.com/ostreedev","followers_url":"https://api.github.com/users/ostreedev/followers","following_url":"https://api.github.com/users/ostreedev/following{/other_user}","gists_url":"https://api.github.com/users/ostreedev/gists{/gist_id}","starred_url":"https://api.github.com/users/ostreedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostreedev/subscriptions","organizations_url":"https://api.github.com/users/ostreedev/orgs","repos_url":"https://api.github.com/users/ostreedev/repos","events_url":"https://api.github.com/users/ostreedev/events{/privacy}","received_events_url":"https://api.github.com/users/ostreedev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ostreedev/ostree","description":"Operating system and container binary deployment and upgrades","fork":false,"url":"https://api.github.com/repos/ostreedev/ostree","forks_url":"https://api.github.com/repos/ostreedev/ostree/forks","keys_url":"https://api.github.com/repos/ostreedev/ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ostreedev/ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ostreedev/ostree/teams","hooks_url":"https://api.github.com/repos/ostreedev/ostree/hooks","issue_events_url":"https://api.github.com/repos/ostreedev/ostree/issues/events{/number}","events_url":"https://api.github.com/repos/ostreedev/ostree/events","assignees_url":"https://api.github.com/repos/ostreedev/ostree/assignees{/user}","branches_url":"https://api.github.com/repos/ostreedev/ostree/branches{/branch}","tags_url":"https://api.github.com/repos/ostreedev/ostree/tags","blobs_url":"https://api.github.com/repos/ostreedev/ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ostreedev/ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ostreedev/ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/ostreedev/ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ostreedev/ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/ostreedev/ostree/languages","stargazers_url":"https://api.github.com/repos/ostreedev/ostree/stargazers","contributors_url":"https://api.github.com/repos/ostreedev/ostree/contributors","subscribers_url":"https://api.github.com/repos/ostreedev/ostree/subscribers","subscription_url":"https://api.github.com/repos/ostreedev/ostree/subscription","commits_url":"https://api.github.com/repos/ostreedev/ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/ostreedev/ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/ostreedev/ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/ostreedev/ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/ostreedev/ostree/contents/{+path}","compare_url":"https://api.github.com/repos/ostreedev/ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ostreedev/ostree/merges","archive_url":"https://api.github.com/repos/ostreedev/ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ostreedev/ostree/downloads","issues_url":"https://api.github.com/repos/ostreedev/ostree/issues{/number}","pulls_url":"https://api.github.com/repos/ostreedev/ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/ostreedev/ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/ostreedev/ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ostreedev/ostree/labels{/name}","releases_url":"https://api.github.com/repos/ostreedev/ostree/releases{/id}","deployments_url":"https://api.github.com/repos/ostreedev/ostree/deployments","created_at":"2012-06-10T11:22:40Z","updated_at":"2016-07-05T03:44:42Z","pushed_at":"2016-07-05T00:45:10Z","git_url":"git://github.com/ostreedev/ostree.git","ssh_url":"git@github.com:ostreedev/ostree.git","clone_url":"https://github.com/ostreedev/ostree.git","svn_url":"https://github.com/ostreedev/ostree","homepage":"https://ostree.readthedocs.org/en/latest/","size":11084,"stargazers_count":44,"watchers_count":44,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":23,"forks":36,"open_issues":23,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ostreedev/ostree/pulls/353"},"html":{"href":"https://github.com/ostreedev/ostree/pull/353"},"issue":{"href":"https://api.github.com/repos/ostreedev/ostree/issues/353"},"comments":{"href":"https://api.github.com/repos/ostreedev/ostree/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/ostreedev/ostree/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/ostreedev/ostree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ostreedev/ostree/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/ostreedev/ostree/statuses/01fc763c69909b621843f445edbbb37d4e950b3a"}}}}
{"actor":{"display_login":"cgwalters"}}