{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/2269","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/2269/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/2269/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/2269/events","html_url":"https://github.com/ampproject/amphtml/pull/2269","id":136223103,"number":2269,"title":"Assorted fixes to amp-analytics","user":{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-24T23:30:17Z","updated_at":"2016-03-04T04:23:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/2269","html_url":"https://github.com/ampproject/amphtml/pull/2269","diff_url":"https://github.com/ampproject/amphtml/pull/2269.diff","patch_url":"https://github.com/ampproject/amphtml/pull/2269.patch"},"body":"This PR includes:\r\n- Removed comments from example for `atinternet`. Comments are not allowed\r\n  in JSON.\r\n- Added example of `extraUrlParams` in `googleanalytics` and custom config\r\n  examples. Fixes #1991.\r\n- Added `extraUrlParamsReplaceMap` for `googleanalytics`. The feature is\r\n  used for (custom dimensions and metrics)[https://developers.google.com/analytics/devguides/collection/analyticsjs/custom-dims-mets].\r\n- Pulled out `clientId` var. This allows publishers to override the value.\r\n  Partly fixes #1940. Part 2 to follow.\r\n- Added trailing commas in a few places.\r\n"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/192094669","html_url":"https://github.com/ampproject/amphtml/pull/2269#issuecomment-192094669","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/2269","id":192094669,"user":{"login":"rudygalfi","id":3888212,"avatar_url":"https://avatars.githubusercontent.com/u/3888212?v=3","gravatar_id":"","url":"https://api.github.com/users/rudygalfi","html_url":"https://github.com/rudygalfi","followers_url":"https://api.github.com/users/rudygalfi/followers","following_url":"https://api.github.com/users/rudygalfi/following{/other_user}","gists_url":"https://api.github.com/users/rudygalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/rudygalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudygalfi/subscriptions","organizations_url":"https://api.github.com/users/rudygalfi/orgs","repos_url":"https://api.github.com/users/rudygalfi/repos","events_url":"https://api.github.com/users/rudygalfi/events{/privacy}","received_events_url":"https://api.github.com/users/rudygalfi/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T04:23:43Z","updated_at":"2016-03-04T04:23:43Z","body":"Sorry for the delay. Looks good so far. Can you rebase so we can do a final round of review?"}}