{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/1N50MN14/html-element/pulls/20","id":60009248,"html_url":"https://github.com/1N50MN14/html-element/pull/20","diff_url":"https://github.com/1N50MN14/html-element/pull/20.diff","patch_url":"https://github.com/1N50MN14/html-element/pull/20.patch","issue_url":"https://api.github.com/repos/1N50MN14/html-element/issues/20","number":20,"state":"closed","locked":false,"title":"fix(htmlescape): Fix incorrect quote escaping in style attributes","user":{"login":"obartra","id":3877773,"avatar_url":"https://avatars.githubusercontent.com/u/3877773?v=3","gravatar_id":"","url":"https://api.github.com/users/obartra","html_url":"https://github.com/obartra","followers_url":"https://api.github.com/users/obartra/followers","following_url":"https://api.github.com/users/obartra/following{/other_user}","gists_url":"https://api.github.com/users/obartra/gists{/gist_id}","starred_url":"https://api.github.com/users/obartra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obartra/subscriptions","organizations_url":"https://api.github.com/users/obartra/orgs","repos_url":"https://api.github.com/users/obartra/repos","events_url":"https://api.github.com/users/obartra/events{/privacy}","received_events_url":"https://api.github.com/users/obartra/received_events","type":"User","site_admin":false},"body":"Avoid escaping double quotes in style attributes.\r\n\r\nThis solves cases like `background-image: url('test.png')` or `background-image: url(\"test.png\")`.\r\n\r\nNot switching them to single quotes (it just leaves user input as it was) because that could lead to issues to other attributes (e.g. `content`).\r\n\r\nImo it makes more sense to rely on the format the user has specified rather than escaping all quotes.\r\n\r\nCloses #19 \r\n","created_at":"2016-02-19T21:22:27Z","updated_at":"2016-04-19T03:08:12Z","closed_at":"2016-04-19T03:08:12Z","merged_at":null,"merge_commit_sha":"3119b38ff55f155cc338c083ae625d2a9b4a8e16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/1N50MN14/html-element/pulls/20/commits","review_comments_url":"https://api.github.com/repos/1N50MN14/html-element/pulls/20/comments","review_comment_url":"https://api.github.com/repos/1N50MN14/html-element/pulls/comments{/number}","comments_url":"https://api.github.com/repos/1N50MN14/html-element/issues/20/comments","statuses_url":"https://api.github.com/repos/1N50MN14/html-element/statuses/6a73a00cb01bfd9fdf9467c94f21cd5af61e4ab9","head":{"label":"obartra:fix-quotes","ref":"fix-quotes","sha":"6a73a00cb01bfd9fdf9467c94f21cd5af61e4ab9","user":{"login":"obartra","id":3877773,"avatar_url":"https://avatars.githubusercontent.com/u/3877773?v=3","gravatar_id":"","url":"https://api.github.com/users/obartra","html_url":"https://github.com/obartra","followers_url":"https://api.github.com/users/obartra/followers","following_url":"https://api.github.com/users/obartra/following{/other_user}","gists_url":"https://api.github.com/users/obartra/gists{/gist_id}","starred_url":"https://api.github.com/users/obartra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obartra/subscriptions","organizations_url":"https://api.github.com/users/obartra/orgs","repos_url":"https://api.github.com/users/obartra/repos","events_url":"https://api.github.com/users/obartra/events{/privacy}","received_events_url":"https://api.github.com/users/obartra/received_events","type":"User","site_admin":false},"repo":{"id":52017410,"name":"html-element","full_name":"obartra/html-element","owner":{"login":"obartra","id":3877773,"avatar_url":"https://avatars.githubusercontent.com/u/3877773?v=3","gravatar_id":"","url":"https://api.github.com/users/obartra","html_url":"https://github.com/obartra","followers_url":"https://api.github.com/users/obartra/followers","following_url":"https://api.github.com/users/obartra/following{/other_user}","gists_url":"https://api.github.com/users/obartra/gists{/gist_id}","starred_url":"https://api.github.com/users/obartra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obartra/subscriptions","organizations_url":"https://api.github.com/users/obartra/orgs","repos_url":"https://api.github.com/users/obartra/repos","events_url":"https://api.github.com/users/obartra/events{/privacy}","received_events_url":"https://api.github.com/users/obartra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obartra/html-element","description":"A simple HTMLElement shim on the server","fork":true,"url":"https://api.github.com/repos/obartra/html-element","forks_url":"https://api.github.com/repos/obartra/html-element/forks","keys_url":"https://api.github.com/repos/obartra/html-element/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obartra/html-element/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obartra/html-element/teams","hooks_url":"https://api.github.com/repos/obartra/html-element/hooks","issue_events_url":"https://api.github.com/repos/obartra/html-element/issues/events{/number}","events_url":"https://api.github.com/repos/obartra/html-element/events","assignees_url":"https://api.github.com/repos/obartra/html-element/assignees{/user}","branches_url":"https://api.github.com/repos/obartra/html-element/branches{/branch}","tags_url":"https://api.github.com/repos/obartra/html-element/tags","blobs_url":"https://api.github.com/repos/obartra/html-element/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obartra/html-element/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obartra/html-element/git/refs{/sha}","trees_url":"https://api.github.com/repos/obartra/html-element/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obartra/html-element/statuses/{sha}","languages_url":"https://api.github.com/repos/obartra/html-element/languages","stargazers_url":"https://api.github.com/repos/obartra/html-element/stargazers","contributors_url":"https://api.github.com/repos/obartra/html-element/contributors","subscribers_url":"https://api.github.com/repos/obartra/html-element/subscribers","subscription_url":"https://api.github.com/repos/obartra/html-element/subscription","commits_url":"https://api.github.com/repos/obartra/html-element/commits{/sha}","git_commits_url":"https://api.github.com/repos/obartra/html-element/git/commits{/sha}","comments_url":"https://api.github.com/repos/obartra/html-element/comments{/number}","issue_comment_url":"https://api.github.com/repos/obartra/html-element/issues/comments{/number}","contents_url":"https://api.github.com/repos/obartra/html-element/contents/{+path}","compare_url":"https://api.github.com/repos/obartra/html-element/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obartra/html-element/merges","archive_url":"https://api.github.com/repos/obartra/html-element/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obartra/html-element/downloads","issues_url":"https://api.github.com/repos/obartra/html-element/issues{/number}","pulls_url":"https://api.github.com/repos/obartra/html-element/pulls{/number}","milestones_url":"https://api.github.com/repos/obartra/html-element/milestones{/number}","notifications_url":"https://api.github.com/repos/obartra/html-element/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obartra/html-element/labels{/name}","releases_url":"https://api.github.com/repos/obartra/html-element/releases{/id}","deployments_url":"https://api.github.com/repos/obartra/html-element/deployments","created_at":"2016-02-18T15:32:04Z","updated_at":"2016-02-18T15:32:05Z","pushed_at":"2016-02-19T21:34:08Z","git_url":"git://github.com/obartra/html-element.git","ssh_url":"git@github.com:obartra/html-element.git","clone_url":"https://github.com/obartra/html-element.git","svn_url":"https://github.com/obartra/html-element","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"1N50MN14:master","ref":"master","sha":"2d8695e05747a09eccb47041f644c98710857bb5","user":{"login":"1N50MN14","id":2000696,"avatar_url":"https://avatars.githubusercontent.com/u/2000696?v=3","gravatar_id":"","url":"https://api.github.com/users/1N50MN14","html_url":"https://github.com/1N50MN14","followers_url":"https://api.github.com/users/1N50MN14/followers","following_url":"https://api.github.com/users/1N50MN14/following{/other_user}","gists_url":"https://api.github.com/users/1N50MN14/gists{/gist_id}","starred_url":"https://api.github.com/users/1N50MN14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1N50MN14/subscriptions","organizations_url":"https://api.github.com/users/1N50MN14/orgs","repos_url":"https://api.github.com/users/1N50MN14/repos","events_url":"https://api.github.com/users/1N50MN14/events{/privacy}","received_events_url":"https://api.github.com/users/1N50MN14/received_events","type":"User","site_admin":false},"repo":{"id":8443772,"name":"html-element","full_name":"1N50MN14/html-element","owner":{"login":"1N50MN14","id":2000696,"avatar_url":"https://avatars.githubusercontent.com/u/2000696?v=3","gravatar_id":"","url":"https://api.github.com/users/1N50MN14","html_url":"https://github.com/1N50MN14","followers_url":"https://api.github.com/users/1N50MN14/followers","following_url":"https://api.github.com/users/1N50MN14/following{/other_user}","gists_url":"https://api.github.com/users/1N50MN14/gists{/gist_id}","starred_url":"https://api.github.com/users/1N50MN14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1N50MN14/subscriptions","organizations_url":"https://api.github.com/users/1N50MN14/orgs","repos_url":"https://api.github.com/users/1N50MN14/repos","events_url":"https://api.github.com/users/1N50MN14/events{/privacy}","received_events_url":"https://api.github.com/users/1N50MN14/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/1N50MN14/html-element","description":"A simple HTMLElement shim on the server","fork":false,"url":"https://api.github.com/repos/1N50MN14/html-element","forks_url":"https://api.github.com/repos/1N50MN14/html-element/forks","keys_url":"https://api.github.com/repos/1N50MN14/html-element/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1N50MN14/html-element/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1N50MN14/html-element/teams","hooks_url":"https://api.github.com/repos/1N50MN14/html-element/hooks","issue_events_url":"https://api.github.com/repos/1N50MN14/html-element/issues/events{/number}","events_url":"https://api.github.com/repos/1N50MN14/html-element/events","assignees_url":"https://api.github.com/repos/1N50MN14/html-element/assignees{/user}","branches_url":"https://api.github.com/repos/1N50MN14/html-element/branches{/branch}","tags_url":"https://api.github.com/repos/1N50MN14/html-element/tags","blobs_url":"https://api.github.com/repos/1N50MN14/html-element/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1N50MN14/html-element/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1N50MN14/html-element/git/refs{/sha}","trees_url":"https://api.github.com/repos/1N50MN14/html-element/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1N50MN14/html-element/statuses/{sha}","languages_url":"https://api.github.com/repos/1N50MN14/html-element/languages","stargazers_url":"https://api.github.com/repos/1N50MN14/html-element/stargazers","contributors_url":"https://api.github.com/repos/1N50MN14/html-element/contributors","subscribers_url":"https://api.github.com/repos/1N50MN14/html-element/subscribers","subscription_url":"https://api.github.com/repos/1N50MN14/html-element/subscription","commits_url":"https://api.github.com/repos/1N50MN14/html-element/commits{/sha}","git_commits_url":"https://api.github.com/repos/1N50MN14/html-element/git/commits{/sha}","comments_url":"https://api.github.com/repos/1N50MN14/html-element/comments{/number}","issue_comment_url":"https://api.github.com/repos/1N50MN14/html-element/issues/comments{/number}","contents_url":"https://api.github.com/repos/1N50MN14/html-element/contents/{+path}","compare_url":"https://api.github.com/repos/1N50MN14/html-element/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1N50MN14/html-element/merges","archive_url":"https://api.github.com/repos/1N50MN14/html-element/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1N50MN14/html-element/downloads","issues_url":"https://api.github.com/repos/1N50MN14/html-element/issues{/number}","pulls_url":"https://api.github.com/repos/1N50MN14/html-element/pulls{/number}","milestones_url":"https://api.github.com/repos/1N50MN14/html-element/milestones{/number}","notifications_url":"https://api.github.com/repos/1N50MN14/html-element/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1N50MN14/html-element/labels{/name}","releases_url":"https://api.github.com/repos/1N50MN14/html-element/releases{/id}","deployments_url":"https://api.github.com/repos/1N50MN14/html-element/deployments","created_at":"2013-02-26T22:43:49Z","updated_at":"2016-04-04T06:01:08Z","pushed_at":"2016-03-07T15:29:35Z","git_url":"git://github.com/1N50MN14/html-element.git","ssh_url":"git@github.com:1N50MN14/html-element.git","clone_url":"https://github.com/1N50MN14/html-element.git","svn_url":"https://github.com/1N50MN14/html-element","homepage":null,"size":36,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/1N50MN14/html-element/pulls/20"},"html":{"href":"https://github.com/1N50MN14/html-element/pull/20"},"issue":{"href":"https://api.github.com/repos/1N50MN14/html-element/issues/20"},"comments":{"href":"https://api.github.com/repos/1N50MN14/html-element/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/1N50MN14/html-element/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/1N50MN14/html-element/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/1N50MN14/html-element/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/1N50MN14/html-element/statuses/6a73a00cb01bfd9fdf9467c94f21cd5af61e4ab9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":22,"changed_files":2}}