{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/75574906","id":75574906,"diff_hunk":"@@ -314,6 +314,23 @@ public static function get($name) {\n \tpublic static function get_all() {\n \t\treturn self::current_session()->inst_getAll();\n \t}\n+\t\n+\t/**\n+\t * Get or return variables, depending on method signature:\n+\t *\n+\t * Session::data()              returns Session::get_all()\n+\t * Session::data($name)         returns Session::get($name)\n+\t * Session::data($name, $value) returns Session::set($name, $value)\n+\t */\n+\tpublic static function data() {\n+\t\t$args = func_get_args();\n+\t\t$num_args = count($args);","path":"control/Session.php","position":23,"original_position":23,"commit_id":"1aa7705a2c8dba3523514fb0ea73806863b2d179","original_commit_id":"1aa7705a2c8dba3523514fb0ea73806863b2d179","user":{"login":"dhensby","id":563596,"avatar_url":"https://avatars.githubusercontent.com/u/563596?v=3","gravatar_id":"","url":"https://api.github.com/users/dhensby","html_url":"https://github.com/dhensby","followers_url":"https://api.github.com/users/dhensby/followers","following_url":"https://api.github.com/users/dhensby/following{/other_user}","gists_url":"https://api.github.com/users/dhensby/gists{/gist_id}","starred_url":"https://api.github.com/users/dhensby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhensby/subscriptions","organizations_url":"https://api.github.com/users/dhensby/orgs","repos_url":"https://api.github.com/users/dhensby/repos","events_url":"https://api.github.com/users/dhensby/events{/privacy}","received_events_url":"https://api.github.com/users/dhensby/received_events","type":"User","site_admin":false},"body":"`func_num_args()`","created_at":"2016-08-20T08:04:14Z","updated_at":"2016-08-20T08:04:14Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5904#discussion_r75574906","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/75574906"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/5904#discussion_r75574906"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904","id":82067344,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5904","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/5904.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/5904.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5904","number":5904,"state":"open","locked":false,"title":"'data' method as an alias for get, set and get_all","user":{"login":"JorisDebonnet","id":3286264,"avatar_url":"https://avatars.githubusercontent.com/u/3286264?v=3","gravatar_id":"","url":"https://api.github.com/users/JorisDebonnet","html_url":"https://github.com/JorisDebonnet","followers_url":"https://api.github.com/users/JorisDebonnet/followers","following_url":"https://api.github.com/users/JorisDebonnet/following{/other_user}","gists_url":"https://api.github.com/users/JorisDebonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisDebonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisDebonnet/subscriptions","organizations_url":"https://api.github.com/users/JorisDebonnet/orgs","repos_url":"https://api.github.com/users/JorisDebonnet/repos","events_url":"https://api.github.com/users/JorisDebonnet/events{/privacy}","received_events_url":"https://api.github.com/users/JorisDebonnet/received_events","type":"User","site_admin":false},"body":"I like syntactic sugar. Would it be wrong to start supporting multi-signature methods? I would love to do this for Config as well. They are backwards compatible, and nobody has to use them if they don't like them. ","created_at":"2016-08-20T03:21:36Z","updated_at":"2016-08-20T08:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04029f3ea918c8f232277caca13f6b2fc2f316e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5904/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/1aa7705a2c8dba3523514fb0ea73806863b2d179","head":{"label":"JorisDebonnet:patch-2","ref":"patch-2","sha":"1aa7705a2c8dba3523514fb0ea73806863b2d179","user":{"login":"JorisDebonnet","id":3286264,"avatar_url":"https://avatars.githubusercontent.com/u/3286264?v=3","gravatar_id":"","url":"https://api.github.com/users/JorisDebonnet","html_url":"https://github.com/JorisDebonnet","followers_url":"https://api.github.com/users/JorisDebonnet/followers","following_url":"https://api.github.com/users/JorisDebonnet/following{/other_user}","gists_url":"https://api.github.com/users/JorisDebonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisDebonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisDebonnet/subscriptions","organizations_url":"https://api.github.com/users/JorisDebonnet/orgs","repos_url":"https://api.github.com/users/JorisDebonnet/repos","events_url":"https://api.github.com/users/JorisDebonnet/events{/privacy}","received_events_url":"https://api.github.com/users/JorisDebonnet/received_events","type":"User","site_admin":false},"repo":{"id":20162993,"name":"silverstripe-framework","full_name":"JorisDebonnet/silverstripe-framework","owner":{"login":"JorisDebonnet","id":3286264,"avatar_url":"https://avatars.githubusercontent.com/u/3286264?v=3","gravatar_id":"","url":"https://api.github.com/users/JorisDebonnet","html_url":"https://github.com/JorisDebonnet","followers_url":"https://api.github.com/users/JorisDebonnet/followers","following_url":"https://api.github.com/users/JorisDebonnet/following{/other_user}","gists_url":"https://api.github.com/users/JorisDebonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisDebonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisDebonnet/subscriptions","organizations_url":"https://api.github.com/users/JorisDebonnet/orgs","repos_url":"https://api.github.com/users/JorisDebonnet/repos","events_url":"https://api.github.com/users/JorisDebonnet/events{/privacy}","received_events_url":"https://api.github.com/users/JorisDebonnet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JorisDebonnet/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework","forks_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/JorisDebonnet/silverstripe-framework/deployments","created_at":"2014-05-25T19:06:31Z","updated_at":"2016-03-04T02:50:08Z","pushed_at":"2016-08-20T03:19:59Z","git_url":"git://github.com/JorisDebonnet/silverstripe-framework.git","ssh_url":"git@github.com:JorisDebonnet/silverstripe-framework.git","clone_url":"https://github.com/JorisDebonnet/silverstripe-framework.git","svn_url":"https://github.com/JorisDebonnet/silverstripe-framework","homepage":"http://silverstripe.org/","size":56128,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3"}},"base":{"label":"silverstripe:3","ref":"3","sha":"6d4625f067646c19fa7a793f83eed1e4dfb7a09e","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2016-08-16T09:39:52Z","pushed_at":"2016-08-20T03:21:37Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":114717,"stargazers_count":519,"watchers_count":519,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":610,"mirror_url":null,"open_issues_count":623,"forks":610,"open_issues":623,"watchers":519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/5904"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5904"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5904/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5904/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/1aa7705a2c8dba3523514fb0ea73806863b2d179"}}}}
{"actor":{"display_login":"dhensby"}}