{"action":"created","issue":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/1114","repository_url":"https://api.github.com/repos/tbeu/Modelica","labels_url":"https://api.github.com/repos/tbeu/Modelica/issues/1114/labels{/name}","comments_url":"https://api.github.com/repos/tbeu/Modelica/issues/1114/comments","events_url":"https://api.github.com/repos/tbeu/Modelica/issues/1114/events","html_url":"https://github.com/tbeu/Modelica/issues/1114","id":197086635,"number":1114,"title":"Regression testing for MSL 3.2.1","user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"labels":[{"id":504692710,"url":"https://api.github.com/repos/tbeu/Modelica/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false},"assignees":[{"login":"beutlich","id":14896695,"avatar_url":"https://avatars.githubusercontent.com/u/14896695?v=3","gravatar_id":"","url":"https://api.github.com/users/beutlich","html_url":"https://github.com/beutlich","followers_url":"https://api.github.com/users/beutlich/followers","following_url":"https://api.github.com/users/beutlich/following{/other_user}","gists_url":"https://api.github.com/users/beutlich/gists{/gist_id}","starred_url":"https://api.github.com/users/beutlich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beutlich/subscriptions","organizations_url":"https://api.github.com/users/beutlich/orgs","repos_url":"https://api.github.com/users/beutlich/repos","events_url":"https://api.github.com/users/beutlich/events{/privacy}","received_events_url":"https://api.github.com/users/beutlich/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tbeu/Modelica/milestones/47","html_url":"https://github.com/tbeu/Modelica/milestone/47","labels_url":"https://api.github.com/repos/tbeu/Modelica/milestones/47/labels","id":2209218,"number":47,"title":"MSL3.2.1","description":"Backward compatible bug-fix release.","creator":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":267,"state":"closed","created_at":"2016-12-21T08:16:13Z","updated_at":"2016-12-22T03:26:15Z","due_on":"2013-03-31T07:00:00Z","closed_at":"2016-12-21T08:16:13Z"},"comments":10,"created_at":"2016-12-22T03:26:15Z","updated_at":"2016-12-22T03:27:55Z","closed_at":null,"body":"**Reported by otter on 20 May 2013 18:32 UTC**\nI run a regression test of MSL trunk (MSL 3.2.1) with respect to MSL 3.2 with Dymola 2014. The first list \"Differences that indicate errors\" (about 20 models) needs to be inspected by the respective library officer. The second list \"False validation failed\" is for your information (but is uncritical):\n\n**Differences that indicate errors that need to be investigated**\n\n * Modelica.Blocks.Examples.[wiki:BooleanNetwork]1 Different results for some variables (e.g. nand1.u[1]) (Martin/Hans take care of this).\n\n * Modelica.Electrical.Analog.Examples.[wiki:CharacteristicThyristors]\nVariable IdealThyristor1.off is wrong.\n\n * Modelica.Electrical.Analog.Examples.[wiki:AmplifierWithOpAmpDetailed]\nVariable opAmp.x completely wrong after 0.0024 s.\n\n * Modelica.Electrical.Machines.Examples.[wiki:AsynchronousInductionMachines].\nAIMC_withLosses Completely different results (either different models, or different initializaton).\n\n * Modelica.Magnetic.[wiki:FluxTubes].Examples.[wiki:SolenoidActuator].[wiki:ComparisonQuasiStationary] \nVariable advancedFeed_x.v is wrong.\n\n * Modelica.Fluid.Examples.[wiki:PumpingSystem]\nSeveral variables slightly different (PT1.y, pumps.medium.T, reservoir.level)\n\n * Modelica.Fluid.Examples.[wiki:HeatingSystem]\nSeveral variables slightly different (mediums[1].p, radiator.mediums[1].p)\n\n * Modelica.Fluid.Examples.Tanks.[wiki:TanksWithOverflow]\nVariables different (lowerTank.medium.h, upperTank.medium.h)\n\n * Modelica.Fluid.Examples.AST_BatchPlant.[wiki:BatchPlant]_StandardWater\nVariables are different.\n\n * Modelica.Fluid.Examples.[wiki:BranchingDynamicPipes]\nVariables are quite different (e.g. pipe4.mediums[4].T starts at 300 K in MSL 3.2.1 and at 295 K in MSL 3.2). Either initialization is differently defined (most likely), or the changes in the used medium model MoistAir result in these changes.\n\n * Modelica.Fluid.Examples.[wiki:HeatExchanger].[wiki:HeatExchangerSimulation]\nVariables are quite different (e.g. HEX.pipe_1.mediums[17].T starts at 300 K in MSL 3.2.1 and at 304 K in MSL 3.2) So, it seems that initialization is different.\n\n * Modelica.Fluid.Examples.[wiki:TraceSubstances].RoomCO2WithControls\nVariables are quite different (ductIn.mCs_scaled, ductOut.mCs_scaled) Uses MoistAir model (where the medium range was enlarged) Is this a medium problem?\n\n * Modelica.Thermal.[wiki:FluidHeatFlow].Examples.[wiki:PumpAndValve]\nCompletely different results (heatCapacitor.T, pipe.T)\n\n * ModelicaTest.Fluid.[wiki:TestComponents].Fittings.[wiki:TestJunctionTraceSubstances]\nSlight difference in variable junction1.mC_scaled[1]\n\n * ModelicaTest.Fluid.[wiki:TestComponents].Fittings.[wiki:TestMultiPortTraceSubstances]Completely different results (volume1.mC_scaled[1], volume2.mC_scaled[1], volume3.mC_scaled[1]) Again the MoistAir medium model. Could it be that extraProperties are not correctly handled?\n\n * ModelicaTest.Fluid.[wiki:TestComponents].Machines.[wiki:TestWaterPumpPowerCharacteristic]Different results of variable pump.medium.h\n\n * ModelicaTest.Fluid.[wiki:TestComponents].Pipes.[wiki:DynamicPipesAndFittings]Several variables quite different (e.g. pipe7.mediums[5].h)\n\n * ModelicaTest.Fluid.[wiki:TestComponents].Pipes.[wiki:DynamicPipesWithTraceSubstances] \nMany variables quite different\n\n * ModelicaTest.Fluid.[wiki:TestComponents].Vessels.[wiki:TestTankWithTopPorts]\nSlightly different result for variable tank.medium.h\n\n**False \"Validation failed\" (models seem to be o.k.).**\n\n * Modelica.Electrical.Analog.Examples.HeatingNPN_OrGate\nNo visible difference.\n\n * Modelica.Electrical.Digital.Examples.Multiplexer \nModelica.Electrical.Digital.Examples.[wiki:FlipFlop] \nModelica.Electrical.Digital.Examples.[wiki:HalfAdder] \nModelica.Electrical.Digital.Examples.[wiki:FullAdder] \nModelica.Electrical.Digital.Examples.Adder4 \nModelica.Electrical.Digital.Examples.Counter3 \nModelica.Electrical.Digital.Examples.Counter\nNo difference between variables, but new discrete state variable in MSL 3.2.1, no present in MSL 3.2.\n\n * Modelica.Electrical.Machines.Examples.DCMachines.DCPM_withLosses\nNo visible difference.\n\n * Modelica.Electrical.Spice3.Examples.Oscillator\nNo difference between variables, but new discrete state variable in MSL 3.2.1, no present in MSL 3.2.\n\n * Modelica.Mechanics.[wiki:MultiBody].Examples.Elementary.[wiki:RollingWheelSetPulling]\nNo visible difference.\n\n * Modelica.Fluid.Examples.[wiki:IncompressibleFluidNetwork]\nQuite different models (heating source, different step startTime, different end time).\n\n * Modelica.Media.Examples.[wiki:TwoPhaseWater].[wiki:TestTwoPhaseStates]\nNo visible difference.\n\n * ModelicaTest.Blocks.Limiters\nNo difference. New variable introduced.\n\n * ModelicaTest.Tables.[wiki:CombiTimeTable].Test1-60\nNew variable nextTime event introduced in MSL 3.2.1\n\n * ModelicaTest.Fluid.[wiki:TestComponents].Machines.TestWaterPumpDCMotor\nModelicaTest.Fluid.[wiki:TestComponents].Machines.TestWaterPumpDCMotorHeatTransfer\nNo visible difference.\n\n * ModelicaTest.[wiki:MultiBody].Forces.[wiki:DifferentiationOfForces]\nModelicaTest.[wiki:MultiBody].Forces.[wiki:FrameForcesAndTorques]\nSlightly different results. The reason was that the model was slightly changed in MSL 3.2.1 in order to remove an obsolete component. Changed this so that exactly the same models are used. The difference is then gone.\n\n * ModelicaTest.[wiki:MultiBody].Forces.[wiki:ForceWithTwoMasses]\nModelicaTest.[wiki:MultiBody].Forces.[wiki:FrameForces]\nModelicaTest.[wiki:MultiBody].Forces.[wiki:FrameTorques] \nModelicaTest.[wiki:MultiBody].Forces.Torque2 \nModelicaTest.[wiki:MultiBody].Parts.[wiki:FreeBodies]\nDifferent results, since models have been changed. Renamed the above models to \"XXX2\", and re-introduced the original models form MSL 3.2 and compared. Results are now the same.\n\n * ModelicaTest.[wiki:MultiBody].Joints.Universal\nDifferent results, since one parameter of the models is different. The MSL 3.2 model uses a default value for rCM of a body, leading to a non-meaningful model. Change the 3.2 rCM model value to the same value as in MSL 3.2.1. The results are then the same.\n\n * ModelicaTest.[wiki:MultiBody].Parts.Rotor1D.Rotor1D_2\nModelicaTest.[wiki:MultiBody].Parts.Rotor1D.Rotor1D_3\nNo visible difference.\n\n * ModelicaTest.[wiki:MultiBody].Parts.[wiki:PointMass] ModelicaTest.[wiki:MultiBody].Sensors.[wiki:AbsoluteSensor]\nDifferent initial conditions in MSL 3.2 and 3.2.1. When changing the initial conditions in MSL 3.2.1 back to the ones in MSL 3.2, the results are identical.\n\n----\n\nMigrated-From: https://trac.modelica.org/Modelica/ticket/1114"},"comment":{"url":"https://api.github.com/repos/tbeu/Modelica/issues/comments/268709577","html_url":"https://github.com/tbeu/Modelica/issues/1114#issuecomment-268709577","issue_url":"https://api.github.com/repos/tbeu/Modelica/issues/1114","id":268709577,"user":{"login":"modelica-trac-importer","id":22202507,"avatar_url":"https://avatars.githubusercontent.com/u/22202507?v=3","gravatar_id":"","url":"https://api.github.com/users/modelica-trac-importer","html_url":"https://github.com/modelica-trac-importer","followers_url":"https://api.github.com/users/modelica-trac-importer/followers","following_url":"https://api.github.com/users/modelica-trac-importer/following{/other_user}","gists_url":"https://api.github.com/users/modelica-trac-importer/gists{/gist_id}","starred_url":"https://api.github.com/users/modelica-trac-importer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modelica-trac-importer/subscriptions","organizations_url":"https://api.github.com/users/modelica-trac-importer/orgs","repos_url":"https://api.github.com/users/modelica-trac-importer/repos","events_url":"https://api.github.com/users/modelica-trac-importer/events{/privacy}","received_events_url":"https://api.github.com/users/modelica-trac-importer/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T03:27:55Z","updated_at":"2016-12-22T03:27:55Z","body":"**Comment by msielemann on 24 May 2013 13:35 UTC**\nModelica.Fluid.Examples.Tanks.TanksWithOverflow\n\n * Difference is due to a reformulation of the temperature prescription in Sources.MassFlowSource_T \n * Since then, we do not use `medium.T = T_in_internal;` for all media anymore\n * For media with independent variables ph, we use`medium.h = Medium.specificEnthalpy(Medium.setState_pTX(medium.p, T_in_internal, X_in_internal));`\n * With was done in [5946]\n   * rfranke  21.01.2013 11:14:54\nChange graphics of MassFlowSource_T/h.ports from vector to...\n * This may be due to an error too large in the inversion (e.g., delp=1.0e-7 too large), too few allowed iterations (e.g., constant Integer IMAX=50 too low), inconsistency between IF97 polynomials based on independents ph and pT or any other reason.\n * The difference in massFlowRate.medium.T massFlowRate.medium.T = 20.0231 degC from the user-prescribed parameter massFlowRate.T = 20 degC is surprisingly high\n * This could be solved in a number of ways\n    * Analyze rationale for change in [5946] and consider reverting this change\n    * Increase accuracy in the IF97 h_pT() functions (assuming this is a numerical artifact, not a fundamentally justified inconsistency)\n    * Ignore the difference during regression testing...\n * I have no clear opinion... To everybody involved: **Please comment!**\n"}}
{"actor":{"display_login":"modelica-trac-importer"}}