{"action":"created","issue":{"url":"https://api.github.com/repos/npct/pct-shiny/issues/442","repository_url":"https://api.github.com/repos/npct/pct-shiny","labels_url":"https://api.github.com/repos/npct/pct-shiny/issues/442/labels{/name}","comments_url":"https://api.github.com/repos/npct/pct-shiny/issues/442/comments","events_url":"https://api.github.com/repos/npct/pct-shiny/issues/442/events","html_url":"https://github.com/npct/pct-shiny/issues/442","id":190486061,"number":442,"title":"National build 19/11/2016: issues","user":{"login":"AnnaGoodman1","id":11818225,"avatar_url":"https://avatars.githubusercontent.com/u/11818225?v=3","gravatar_id":"","url":"https://api.github.com/users/AnnaGoodman1","html_url":"https://github.com/AnnaGoodman1","followers_url":"https://api.github.com/users/AnnaGoodman1/followers","following_url":"https://api.github.com/users/AnnaGoodman1/following{/other_user}","gists_url":"https://api.github.com/users/AnnaGoodman1/gists{/gist_id}","starred_url":"https://api.github.com/users/AnnaGoodman1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnnaGoodman1/subscriptions","organizations_url":"https://api.github.com/users/AnnaGoodman1/orgs","repos_url":"https://api.github.com/users/AnnaGoodman1/repos","events_url":"https://api.github.com/users/AnnaGoodman1/events{/privacy}","received_events_url":"https://api.github.com/users/AnnaGoodman1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-19T09:10:13Z","updated_at":"2016-11-20T21:50:39Z","closed_at":null,"body":"The issues I have found are:\r\n•\tthe centroid values have not been updated on the map interface\r\n•\tThe quiet route hilliness data is not correct – e.g. avslope_q value is incorrect in the straight lines download, and change_elev and av_incline are incorrect in the routes download.  These values have incorrectly been set to be the same as for the fastest routes.  The correct values are in the file ‘161113_CorrectHilliness_rf_rq.csv’ that I uploaded last weekend in issue #439.\r\n•\tthere has been reversion in the data downloads, we have lost Nikolai’s implementation here (https://github.com/npct/pct-shiny/issues/432) of only applying 3 sig fig to decimals.\r\n•\tError message when you click on geojson route network file (“ERROR: trying to get slot \"data\" from an object of a basic class (\"NULL\") with no slot”)\r\n•\tThe variables ‘serror’, ‘ferror’ should be removed from the fast/quiet routes download, they are  for internal checking.  Rq_inc and rqinc are duplicative of each other and also of distq_f  so ideally they would also be removed.  And there are now also lots of scenario parameters in there that would need to be defined in the codebook or in some cases perhaps ideally removed (it doesn't make much sense to have average slope in there twice, once as a percentage and once not… or distance twice, once in meters and once inkm). NB @Robinlovelace , I thought the process was that only variables in the codebook appeared in the data downloads? Could we bring that system back, it did seem good. \r\n•\tThere is a typo in the data download name ‘routes_quite.geojson’ (less important, but good to fix)\r\n\r\nAlso can I check \r\n•\tAre nat_rf and and nat_rq are now both based on the full eligible set of 226,103 lines (see file 161111_NatLinesSet.csv, comment #439)? \r\n•\tHave those 2584 quiet lines that did not get correctly routed the first time having now been re-routed and merged in (again see 439 and associated ‘161113_MissingQuietLines.xlsx’ CSV)? Otherwise will get problems especially in London of showing straight lines where should be routes.  (None of these routes are in the Isle of Wight, so I have enough to check directly whether this has been done)\r\n\r\nLastly I see that the old files pct_area.csv and pct_lines.zip are still at https://github.com/npct/pct-bigdata, can these be deleted please? And where are the new files saved?\r\n"},"comment":{"url":"https://api.github.com/repos/npct/pct-shiny/issues/comments/261808576","html_url":"https://github.com/npct/pct-shiny/issues/442#issuecomment-261808576","issue_url":"https://api.github.com/repos/npct/pct-shiny/issues/442","id":261808576,"user":{"login":"nikolai-b","id":6289830,"avatar_url":"https://avatars.githubusercontent.com/u/6289830?v=3","gravatar_id":"","url":"https://api.github.com/users/nikolai-b","html_url":"https://github.com/nikolai-b","followers_url":"https://api.github.com/users/nikolai-b/followers","following_url":"https://api.github.com/users/nikolai-b/following{/other_user}","gists_url":"https://api.github.com/users/nikolai-b/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolai-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolai-b/subscriptions","organizations_url":"https://api.github.com/users/nikolai-b/orgs","repos_url":"https://api.github.com/users/nikolai-b/repos","events_url":"https://api.github.com/users/nikolai-b/events{/privacy}","received_events_url":"https://api.github.com/users/nikolai-b/received_events","type":"User","site_admin":false},"created_at":"2016-11-20T21:50:39Z","updated_at":"2016-11-20T21:50:39Z","body":"> The centroid values have not been updated on the map interface\r\n\r\nI assume this is for @mem48 but if it is something I should try to fix I will need a bit more detail.\r\n\r\n> The quiet route hilliness data is not correct \r\n\r\nI know @mem48 merged in your hilliness data but I guess there was a mistake, I'll believe I have all I need to fix this.\r\n\r\n> There has been reversion in the data downloads\r\n\r\nYes, I believe this was reverted by mistake.  I've reapplied them.\r\n\r\n> \tError message when you click on geojson route network file\r\n\r\nAgain, I believe this was fixed and has been _unfixed_ by mistake.  I will fix it again.\r\n\r\n> The variables ‘serror’, ‘ferror’ should be removed from the fast/quiet routes download,\r\n\r\n@Robinlovelace has done this in https://github.com/npct/pct-load/pull/66\r\n\r\n> There is a typo in the data download name ‘routes_quite.geojson’\r\n\r\nFixed, thanks.\r\n\r\n> Are nat_rf and and nat_rq are now both based on the full eligible set of 226,103 lines \r\n\r\nI believe so.  I would have to defer to @mem48 but my understanding is that they are.\r\n\r\n> Have those 2584 quiet lines that did not get correctly routed the first time having now been re-routed and merged in?\r\n\r\nAgain, I believe they have been."}}
{"actor":{"display_login":"nikolai-b"}}