{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/77560076","id":77560076,"diff_hunk":"@@ -23,6 +23,8 @@ This rule has a number or object option:\n * `\"ignoreComments\": true` ignores all trailing comments and comments on their own line\n * `\"ignoreTrailingComments\": true` ignores only trailing comments\n * `\"ignoreUrls\": true` ignores lines that contain a URL\n+* `\"ignoreStrings\": true` ignores lines that contain a string (\" or ')","path":"docs/rules/max-len.md","position":4,"original_position":4,"commit_id":"5b0b368fdca9f07fcd6534f979eb684e61fef6e0","original_commit_id":"5b0b368fdca9f07fcd6534f979eb684e61fef6e0","user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"body":"Maybe \"contain a double-quoted or single-quoted string\"?","created_at":"2016-09-06T00:03:50Z","updated_at":"2016-09-06T00:03:50Z","html_url":"https://github.com/eslint/eslint/pull/7049#discussion_r77560076","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/7049","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/77560076"},"html":{"href":"https://github.com/eslint/eslint/pull/7049#discussion_r77560076"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7049"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/7049","id":83889641,"html_url":"https://github.com/eslint/eslint/pull/7049","diff_url":"https://github.com/eslint/eslint/pull/7049.diff","patch_url":"https://github.com/eslint/eslint/pull/7049.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/7049","number":7049,"state":"open","locked":false,"title":"New: `max-len`: `ignoreStrings`+`ignoreTemplateLiterals` (fixes #5805)","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"**What issue does this pull request address?**\r\n#5805\r\n\r\n**What changes did you make? (Give an overview)**\r\n - added `getAllStrings` and `getAllTemplateLiterals` to source-code\r\n - grouped both by line number in `max-len`, and ignored lines that contained strings/template literals, matching the options\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nThe overall approach.","created_at":"2016-09-03T08:11:43Z","updated_at":"2016-09-06T00:03:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fdd8975c2258117443ee216451f6a47d0ccdc7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/7049/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/7049/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/7049/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/5b0b368fdca9f07fcd6534f979eb684e61fef6e0","head":{"label":"ljharb:ljharb/max_len_ignore_strings","ref":"ljharb/max_len_ignore_strings","sha":"5b0b368fdca9f07fcd6534f979eb684e61fef6e0","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"repo":{"id":27574511,"name":"eslint","full_name":"ljharb/eslint","owner":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ljharb/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/ljharb/eslint","forks_url":"https://api.github.com/repos/ljharb/eslint/forks","keys_url":"https://api.github.com/repos/ljharb/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ljharb/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ljharb/eslint/teams","hooks_url":"https://api.github.com/repos/ljharb/eslint/hooks","issue_events_url":"https://api.github.com/repos/ljharb/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/ljharb/eslint/events","assignees_url":"https://api.github.com/repos/ljharb/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/ljharb/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/ljharb/eslint/tags","blobs_url":"https://api.github.com/repos/ljharb/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ljharb/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ljharb/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ljharb/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ljharb/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/ljharb/eslint/languages","stargazers_url":"https://api.github.com/repos/ljharb/eslint/stargazers","contributors_url":"https://api.github.com/repos/ljharb/eslint/contributors","subscribers_url":"https://api.github.com/repos/ljharb/eslint/subscribers","subscription_url":"https://api.github.com/repos/ljharb/eslint/subscription","commits_url":"https://api.github.com/repos/ljharb/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ljharb/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ljharb/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ljharb/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ljharb/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/ljharb/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ljharb/eslint/merges","archive_url":"https://api.github.com/repos/ljharb/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ljharb/eslint/downloads","issues_url":"https://api.github.com/repos/ljharb/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/ljharb/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/ljharb/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/ljharb/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ljharb/eslint/labels{/name}","releases_url":"https://api.github.com/repos/ljharb/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/ljharb/eslint/deployments","created_at":"2014-12-05T04:34:56Z","updated_at":"2016-03-09T08:37:59Z","pushed_at":"2016-09-05T01:39:58Z","git_url":"git://github.com/ljharb/eslint.git","ssh_url":"git@github.com:ljharb/eslint.git","clone_url":"https://github.com/ljharb/eslint.git","svn_url":"https://github.com/ljharb/eslint","homepage":"http://eslint.org","size":12564,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"fa760f951fe45606c59aa8f4c18258409891622d","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2016-09-05T21:56:04Z","pushed_at":"2016-09-05T23:24:10Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":18490,"stargazers_count":5781,"watchers_count":5781,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1134,"mirror_url":null,"open_issues_count":219,"forks":1134,"open_issues":219,"watchers":5781,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7049"},"html":{"href":"https://github.com/eslint/eslint/pull/7049"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/7049"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/7049/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7049/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/7049/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/5b0b368fdca9f07fcd6534f979eb684e61fef6e0"}}}}
{"actor":{"display_login":"platinumazure"}}