{"action":"created","issue":{"url":"https://api.github.com/repos/rspec/rspec-core/issues/2321","repository_url":"https://api.github.com/repos/rspec/rspec-core","labels_url":"https://api.github.com/repos/rspec/rspec-core/issues/2321/labels{/name}","comments_url":"https://api.github.com/repos/rspec/rspec-core/issues/2321/comments","events_url":"https://api.github.com/repos/rspec/rspec-core/issues/2321/events","html_url":"https://github.com/rspec/rspec-core/pull/2321","id":174808627,"number":2321,"title":"Add --force-color flag","user":{"login":"CodingItWrong","id":15832198,"avatar_url":"https://avatars.githubusercontent.com/u/15832198?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingItWrong","html_url":"https://github.com/CodingItWrong","followers_url":"https://api.github.com/users/CodingItWrong/followers","following_url":"https://api.github.com/users/CodingItWrong/following{/other_user}","gists_url":"https://api.github.com/users/CodingItWrong/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingItWrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingItWrong/subscriptions","organizations_url":"https://api.github.com/users/CodingItWrong/orgs","repos_url":"https://api.github.com/users/CodingItWrong/repos","events_url":"https://api.github.com/users/CodingItWrong/events{/privacy}","received_events_url":"https://api.github.com/users/CodingItWrong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-02T17:20:46Z","updated_at":"2016-09-19T12:01:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rspec/rspec-core/pulls/2321","html_url":"https://github.com/rspec/rspec-core/pull/2321","diff_url":"https://github.com/rspec/rspec-core/pull/2321.diff","patch_url":"https://github.com/rspec/rspec-core/pull/2321.patch"},"body":"Fixes #2230 by adding a --force-color flag to use alongside --no-color, while preserving backward-compatibility with the --color flag.\r\n\r\nPlease let me know anything I can do to improve this PR! A few thoughts:\r\n\r\n- configuration.rb is a bit more complex than it otherwise might need to be because of --color backward compatibility, but I think it's worth it\r\n- Setting config.no_color = true in spec_helper.rb felt a bit dirty, but I do think the best default behavior in the specs is to _not_ have color in the output, and that was the most reliable way I could find to accomplish that.\r\n- The specs that distinguish the behavior of force_color and no_color when --tty is passed can probably be removed, now that they've demonstrated that that flag doesn't affect their behavior.\r\n- The name of the --force-color flag gets a bit confusing with the ConfigurationOptions method `force` (e.g. it \"forces force_color\"), but I think --force-color is the best external name, and it probably doesn't make sense to consider any renaming of the internal `force` method just for this.\r\n- Reading `no_color = true` and `no_color = false` gets a bit confusing, but this wouldn't extend to end users: they just use --force-color or --no-color and get the expected result. The two different properties are needed, as I describe in the commit message for 9af8f0c, because the default behavior is different from both the force_color and no_color behavior, so there are several different states."},"comment":{"url":"https://api.github.com/repos/rspec/rspec-core/issues/comments/247974547","html_url":"https://github.com/rspec/rspec-core/pull/2321#issuecomment-247974547","issue_url":"https://api.github.com/repos/rspec/rspec-core/issues/2321","id":247974547,"user":{"login":"CodingItWrong","id":15832198,"avatar_url":"https://avatars.githubusercontent.com/u/15832198?v=3","gravatar_id":"","url":"https://api.github.com/users/CodingItWrong","html_url":"https://github.com/CodingItWrong","followers_url":"https://api.github.com/users/CodingItWrong/followers","following_url":"https://api.github.com/users/CodingItWrong/following{/other_user}","gists_url":"https://api.github.com/users/CodingItWrong/gists{/gist_id}","starred_url":"https://api.github.com/users/CodingItWrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodingItWrong/subscriptions","organizations_url":"https://api.github.com/users/CodingItWrong/orgs","repos_url":"https://api.github.com/users/CodingItWrong/repos","events_url":"https://api.github.com/users/CodingItWrong/events{/privacy}","received_events_url":"https://api.github.com/users/CodingItWrong/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T12:01:10Z","updated_at":"2016-09-19T12:01:10Z","body":"OK, the `abort` feature is pushed up now. Any thoughts on that Cucumber feature failing in JRuby?"}}
{"actor":{"display_login":"CodingItWrong"}}