{"action":"opened","number":102,"pull_request":{"url":"https://api.github.com/repos/pwndbg/pwndbg/pulls/102","id":76655832,"html_url":"https://github.com/pwndbg/pwndbg/pull/102","diff_url":"https://github.com/pwndbg/pwndbg/pull/102.diff","patch_url":"https://github.com/pwndbg/pwndbg/pull/102.patch","issue_url":"https://api.github.com/repos/pwndbg/pwndbg/issues/102","number":102,"state":"open","locked":false,"title":"fixed potential wrong config param type resolution","user":{"login":"anthraxx","id":203012,"avatar_url":"https://avatars.githubusercontent.com/u/203012?v=3","gravatar_id":"","url":"https://api.github.com/users/anthraxx","html_url":"https://github.com/anthraxx","followers_url":"https://api.github.com/users/anthraxx/followers","following_url":"https://api.github.com/users/anthraxx/following{/other_user}","gists_url":"https://api.github.com/users/anthraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/anthraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthraxx/subscriptions","organizations_url":"https://api.github.com/users/anthraxx/orgs","repos_url":"https://api.github.com/users/anthraxx/repos","events_url":"https://api.github.com/users/anthraxx/events{/privacy}","received_events_url":"https://api.github.com/users/anthraxx/received_events","type":"User","site_admin":false},"body":"This fixes an issue that can potentially happen with unordered dicts\r\nin python3. A boolean typed config parameter can be handles as\r\ninteger dependin on the order of iteration in getParam(value).\r\n\r\nThe reason for this is because True/False are both, bool and int\r\nat the same time, however its not the other way around.\r\n\r\n```\r\nchecking type <class 'bool'>\r\nmatched True against <class 'bool'>\r\n\r\nchecking type <class 'str'>\r\nchecking type <class 'int'>\r\nmatched True against <class 'int'>\r\n\r\nIn [1]: isinstance(True, bool)\r\nOut[1]: True\r\n\r\nIn [3]: isinstance(True, int)\r\nOut[3]: True\r\n\r\nIn [4]: isinstance(1, bool)\r\nOut[4]: False\r\n```","created_at":"2016-07-07T20:00:33Z","updated_at":"2016-07-07T20:00:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pwndbg/pwndbg/pulls/102/commits","review_comments_url":"https://api.github.com/repos/pwndbg/pwndbg/pulls/102/comments","review_comment_url":"https://api.github.com/repos/pwndbg/pwndbg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pwndbg/pwndbg/issues/102/comments","statuses_url":"https://api.github.com/repos/pwndbg/pwndbg/statuses/8fc2be3552a473024c22113cf034381bc00371fe","head":{"label":"anthraxx:bugfix/config-type-order","ref":"bugfix/config-type-order","sha":"8fc2be3552a473024c22113cf034381bc00371fe","user":{"login":"anthraxx","id":203012,"avatar_url":"https://avatars.githubusercontent.com/u/203012?v=3","gravatar_id":"","url":"https://api.github.com/users/anthraxx","html_url":"https://github.com/anthraxx","followers_url":"https://api.github.com/users/anthraxx/followers","following_url":"https://api.github.com/users/anthraxx/following{/other_user}","gists_url":"https://api.github.com/users/anthraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/anthraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthraxx/subscriptions","organizations_url":"https://api.github.com/users/anthraxx/orgs","repos_url":"https://api.github.com/users/anthraxx/repos","events_url":"https://api.github.com/users/anthraxx/events{/privacy}","received_events_url":"https://api.github.com/users/anthraxx/received_events","type":"User","site_admin":false},"repo":{"id":60566902,"name":"pwndbg","full_name":"anthraxx/pwndbg","owner":{"login":"anthraxx","id":203012,"avatar_url":"https://avatars.githubusercontent.com/u/203012?v=3","gravatar_id":"","url":"https://api.github.com/users/anthraxx","html_url":"https://github.com/anthraxx","followers_url":"https://api.github.com/users/anthraxx/followers","following_url":"https://api.github.com/users/anthraxx/following{/other_user}","gists_url":"https://api.github.com/users/anthraxx/gists{/gist_id}","starred_url":"https://api.github.com/users/anthraxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthraxx/subscriptions","organizations_url":"https://api.github.com/users/anthraxx/orgs","repos_url":"https://api.github.com/users/anthraxx/repos","events_url":"https://api.github.com/users/anthraxx/events{/privacy}","received_events_url":"https://api.github.com/users/anthraxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anthraxx/pwndbg","description":"Makes debugging suck less","fork":true,"url":"https://api.github.com/repos/anthraxx/pwndbg","forks_url":"https://api.github.com/repos/anthraxx/pwndbg/forks","keys_url":"https://api.github.com/repos/anthraxx/pwndbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anthraxx/pwndbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anthraxx/pwndbg/teams","hooks_url":"https://api.github.com/repos/anthraxx/pwndbg/hooks","issue_events_url":"https://api.github.com/repos/anthraxx/pwndbg/issues/events{/number}","events_url":"https://api.github.com/repos/anthraxx/pwndbg/events","assignees_url":"https://api.github.com/repos/anthraxx/pwndbg/assignees{/user}","branches_url":"https://api.github.com/repos/anthraxx/pwndbg/branches{/branch}","tags_url":"https://api.github.com/repos/anthraxx/pwndbg/tags","blobs_url":"https://api.github.com/repos/anthraxx/pwndbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anthraxx/pwndbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anthraxx/pwndbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/anthraxx/pwndbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anthraxx/pwndbg/statuses/{sha}","languages_url":"https://api.github.com/repos/anthraxx/pwndbg/languages","stargazers_url":"https://api.github.com/repos/anthraxx/pwndbg/stargazers","contributors_url":"https://api.github.com/repos/anthraxx/pwndbg/contributors","subscribers_url":"https://api.github.com/repos/anthraxx/pwndbg/subscribers","subscription_url":"https://api.github.com/repos/anthraxx/pwndbg/subscription","commits_url":"https://api.github.com/repos/anthraxx/pwndbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/anthraxx/pwndbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/anthraxx/pwndbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/anthraxx/pwndbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/anthraxx/pwndbg/contents/{+path}","compare_url":"https://api.github.com/repos/anthraxx/pwndbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anthraxx/pwndbg/merges","archive_url":"https://api.github.com/repos/anthraxx/pwndbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anthraxx/pwndbg/downloads","issues_url":"https://api.github.com/repos/anthraxx/pwndbg/issues{/number}","pulls_url":"https://api.github.com/repos/anthraxx/pwndbg/pulls{/number}","milestones_url":"https://api.github.com/repos/anthraxx/pwndbg/milestones{/number}","notifications_url":"https://api.github.com/repos/anthraxx/pwndbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anthraxx/pwndbg/labels{/name}","releases_url":"https://api.github.com/repos/anthraxx/pwndbg/releases{/id}","deployments_url":"https://api.github.com/repos/anthraxx/pwndbg/deployments","created_at":"2016-06-06T23:15:41Z","updated_at":"2016-06-06T23:15:41Z","pushed_at":"2016-07-07T19:59:41Z","git_url":"git://github.com/anthraxx/pwndbg.git","ssh_url":"git@github.com:anthraxx/pwndbg.git","clone_url":"https://github.com/anthraxx/pwndbg.git","svn_url":"https://github.com/anthraxx/pwndbg","homepage":null,"size":5490,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pwndbg:master","ref":"master","sha":"d816e103a6092766398bc74ae2ed844ff3f9598b","user":{"login":"pwndbg","id":19614813,"avatar_url":"https://avatars.githubusercontent.com/u/19614813?v=3","gravatar_id":"","url":"https://api.github.com/users/pwndbg","html_url":"https://github.com/pwndbg","followers_url":"https://api.github.com/users/pwndbg/followers","following_url":"https://api.github.com/users/pwndbg/following{/other_user}","gists_url":"https://api.github.com/users/pwndbg/gists{/gist_id}","starred_url":"https://api.github.com/users/pwndbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwndbg/subscriptions","organizations_url":"https://api.github.com/users/pwndbg/orgs","repos_url":"https://api.github.com/users/pwndbg/repos","events_url":"https://api.github.com/users/pwndbg/events{/privacy}","received_events_url":"https://api.github.com/users/pwndbg/received_events","type":"Organization","site_admin":false},"repo":{"id":31181767,"name":"pwndbg","full_name":"pwndbg/pwndbg","owner":{"login":"pwndbg","id":19614813,"avatar_url":"https://avatars.githubusercontent.com/u/19614813?v=3","gravatar_id":"","url":"https://api.github.com/users/pwndbg","html_url":"https://github.com/pwndbg","followers_url":"https://api.github.com/users/pwndbg/followers","following_url":"https://api.github.com/users/pwndbg/following{/other_user}","gists_url":"https://api.github.com/users/pwndbg/gists{/gist_id}","starred_url":"https://api.github.com/users/pwndbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwndbg/subscriptions","organizations_url":"https://api.github.com/users/pwndbg/orgs","repos_url":"https://api.github.com/users/pwndbg/repos","events_url":"https://api.github.com/users/pwndbg/events{/privacy}","received_events_url":"https://api.github.com/users/pwndbg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pwndbg/pwndbg","description":"Makes debugging suck less","fork":false,"url":"https://api.github.com/repos/pwndbg/pwndbg","forks_url":"https://api.github.com/repos/pwndbg/pwndbg/forks","keys_url":"https://api.github.com/repos/pwndbg/pwndbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pwndbg/pwndbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pwndbg/pwndbg/teams","hooks_url":"https://api.github.com/repos/pwndbg/pwndbg/hooks","issue_events_url":"https://api.github.com/repos/pwndbg/pwndbg/issues/events{/number}","events_url":"https://api.github.com/repos/pwndbg/pwndbg/events","assignees_url":"https://api.github.com/repos/pwndbg/pwndbg/assignees{/user}","branches_url":"https://api.github.com/repos/pwndbg/pwndbg/branches{/branch}","tags_url":"https://api.github.com/repos/pwndbg/pwndbg/tags","blobs_url":"https://api.github.com/repos/pwndbg/pwndbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pwndbg/pwndbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pwndbg/pwndbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/pwndbg/pwndbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pwndbg/pwndbg/statuses/{sha}","languages_url":"https://api.github.com/repos/pwndbg/pwndbg/languages","stargazers_url":"https://api.github.com/repos/pwndbg/pwndbg/stargazers","contributors_url":"https://api.github.com/repos/pwndbg/pwndbg/contributors","subscribers_url":"https://api.github.com/repos/pwndbg/pwndbg/subscribers","subscription_url":"https://api.github.com/repos/pwndbg/pwndbg/subscription","commits_url":"https://api.github.com/repos/pwndbg/pwndbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/pwndbg/pwndbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/pwndbg/pwndbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/pwndbg/pwndbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/pwndbg/pwndbg/contents/{+path}","compare_url":"https://api.github.com/repos/pwndbg/pwndbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pwndbg/pwndbg/merges","archive_url":"https://api.github.com/repos/pwndbg/pwndbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pwndbg/pwndbg/downloads","issues_url":"https://api.github.com/repos/pwndbg/pwndbg/issues{/number}","pulls_url":"https://api.github.com/repos/pwndbg/pwndbg/pulls{/number}","milestones_url":"https://api.github.com/repos/pwndbg/pwndbg/milestones{/number}","notifications_url":"https://api.github.com/repos/pwndbg/pwndbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pwndbg/pwndbg/labels{/name}","releases_url":"https://api.github.com/repos/pwndbg/pwndbg/releases{/id}","deployments_url":"https://api.github.com/repos/pwndbg/pwndbg/deployments","created_at":"2015-02-22T21:35:19Z","updated_at":"2016-07-05T00:05:18Z","pushed_at":"2016-07-07T01:10:51Z","git_url":"git://github.com/pwndbg/pwndbg.git","ssh_url":"git@github.com:pwndbg/pwndbg.git","clone_url":"https://github.com/pwndbg/pwndbg.git","svn_url":"https://github.com/pwndbg/pwndbg","homepage":null,"size":5511,"stargazers_count":308,"watchers_count":308,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":24,"forks":38,"open_issues":24,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pwndbg/pwndbg/pulls/102"},"html":{"href":"https://github.com/pwndbg/pwndbg/pull/102"},"issue":{"href":"https://api.github.com/repos/pwndbg/pwndbg/issues/102"},"comments":{"href":"https://api.github.com/repos/pwndbg/pwndbg/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/pwndbg/pwndbg/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/pwndbg/pwndbg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pwndbg/pwndbg/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/pwndbg/pwndbg/statuses/8fc2be3552a473024c22113cf034381bc00371fe"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"anthraxx"}}