{"action":"closed","number":36384,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/36384","id":84759814,"html_url":"https://github.com/rust-lang/rust/pull/36384","diff_url":"https://github.com/rust-lang/rust/pull/36384.diff","patch_url":"https://github.com/rust-lang/rust/pull/36384.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/36384","number":36384,"state":"closed","locked":false,"title":"Improve shallow `Clone` deriving","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"body":"`Copy` unions now support `#[derive(Clone)]`.\r\nLess code is generated for `#[derive(Clone, Copy)]`.\r\n+\r\nUnions now support `#[derive(Eq)]`.\r\nLess code is generated for `#[derive(Eq)]`.\r\n\r\n---\r\nExample of code reduction:\r\n```\r\n#[derive(Copy, Clone)]\r\nenum E {\r\n\tA { a: u8, b: u16 },\r\n\tB { c: [u8; 100] },\r\n}\r\n```\r\nBefore:\r\n```\r\nfn clone(&self) -> E {\r\n    match (&*self,) {\r\n        (&E::A { a: ref __self_0, b: ref __self_1 },) => {\r\n            ::std::clone::assert_receiver_is_clone(&(*__self_0));\r\n            ::std::clone::assert_receiver_is_clone(&(*__self_1));\r\n            *self\r\n        }\r\n        (&E::B { c: ref __self_0 },) => {\r\n            ::std::clone::assert_receiver_is_clone(&(*__self_0));\r\n            *self\r\n        }\r\n    }\r\n}\r\n```\r\nAfter:\r\n```\r\nfn clone(&self) -> E {\r\n    {\r\n        let _: ::std::clone::AssertParamIsClone<u8>;\r\n        let _: ::std::clone::AssertParamIsClone<u16>;\r\n        let _: ::std::clone::AssertParamIsClone<[u8; 100]>;\r\n        *self\r\n    }\r\n}\r\n```\r\n\r\nAll the matches are removed, bound assertions are more lightweight.\r\n`let _: Checker<CheckMe>;`, unlike `checker(&check_me);`, doesn't have to be translated by rustc_trans and then inlined by LLVM, it doesn't even exist in MIR, this means faster compilation.\r\n\r\n---\r\nUnion impls are generated like this:\r\n```\r\nunion U {\r\n\ta: u8,\r\n\tb: u16,\r\n\tc: [u8; 100],\r\n}\r\n```\r\n```\r\nfn clone(&self) -> U {\r\n    {\r\n        let _: ::std::clone::AssertParamIsCopy<Self>;\r\n        *self\r\n    }\r\n}\r\n```\r\n\r\nFixes https://github.com/rust-lang/rust/issues/36043\r\ncc @durka \r\nr? @alexcrichton ","created_at":"2016-09-10T16:10:04Z","updated_at":"2016-09-15T16:58:32Z","closed_at":"2016-09-15T16:58:32Z","merged_at":"2016-09-15T16:58:32Z","merge_commit_sha":"62cb7510ac6285c93ec691198a92f910582d31a2","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/36384/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/36384/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/36384/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/62cb7510ac6285c93ec691198a92f910582d31a2","head":{"label":"petrochenkov:derclone","ref":"derclone","sha":"62cb7510ac6285c93ec691198a92f910582d31a2","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"repo":{"id":26977039,"name":"rust","full_name":"petrochenkov/rust","owner":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petrochenkov/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/petrochenkov/rust","forks_url":"https://api.github.com/repos/petrochenkov/rust/forks","keys_url":"https://api.github.com/repos/petrochenkov/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petrochenkov/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petrochenkov/rust/teams","hooks_url":"https://api.github.com/repos/petrochenkov/rust/hooks","issue_events_url":"https://api.github.com/repos/petrochenkov/rust/issues/events{/number}","events_url":"https://api.github.com/repos/petrochenkov/rust/events","assignees_url":"https://api.github.com/repos/petrochenkov/rust/assignees{/user}","branches_url":"https://api.github.com/repos/petrochenkov/rust/branches{/branch}","tags_url":"https://api.github.com/repos/petrochenkov/rust/tags","blobs_url":"https://api.github.com/repos/petrochenkov/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petrochenkov/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petrochenkov/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/petrochenkov/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petrochenkov/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/petrochenkov/rust/languages","stargazers_url":"https://api.github.com/repos/petrochenkov/rust/stargazers","contributors_url":"https://api.github.com/repos/petrochenkov/rust/contributors","subscribers_url":"https://api.github.com/repos/petrochenkov/rust/subscribers","subscription_url":"https://api.github.com/repos/petrochenkov/rust/subscription","commits_url":"https://api.github.com/repos/petrochenkov/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/petrochenkov/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/petrochenkov/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/petrochenkov/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/petrochenkov/rust/contents/{+path}","compare_url":"https://api.github.com/repos/petrochenkov/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petrochenkov/rust/merges","archive_url":"https://api.github.com/repos/petrochenkov/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petrochenkov/rust/downloads","issues_url":"https://api.github.com/repos/petrochenkov/rust/issues{/number}","pulls_url":"https://api.github.com/repos/petrochenkov/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/petrochenkov/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/petrochenkov/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petrochenkov/rust/labels{/name}","releases_url":"https://api.github.com/repos/petrochenkov/rust/releases{/id}","deployments_url":"https://api.github.com/repos/petrochenkov/rust/deployments","created_at":"2014-11-21T20:39:20Z","updated_at":"2016-01-14T18:00:04Z","pushed_at":"2016-09-13T21:01:06Z","git_url":"git://github.com/petrochenkov/rust.git","ssh_url":"git@github.com:petrochenkov/rust.git","clone_url":"https://github.com/petrochenkov/rust.git","svn_url":"https://github.com/petrochenkov/rust","homepage":"http://www.rust-lang.org","size":298948,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"a5f4cc527de4230359c81799852f6bc770eba0e6","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2016-09-15T15:25:34Z","pushed_at":"2016-09-15T16:58:26Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":511554,"stargazers_count":18296,"watchers_count":18296,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3526,"mirror_url":null,"open_issues_count":2826,"forks":3526,"open_issues":2826,"watchers":18296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36384"},"html":{"href":"https://github.com/rust-lang/rust/pull/36384"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36384"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/36384/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36384/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/36384/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/62cb7510ac6285c93ec691198a92f910582d31a2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":27,"review_comments":0,"commits":2,"additions":293,"deletions":121,"changed_files":14}}
{"actor":{"display_login":"bors"}}