{"action":"created","issue":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/104","labels_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/104/comments","events_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/104/events","html_url":"https://github.com/01org/TPM2.0-TSS/issues/104","id":127771646,"number":104,"title":"factor tpm20.h header","user":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/milestones/5","html_url":"https://github.com/01org/TPM2.0-TSS/milestones/header%20cleanup","labels_url":"https://api.github.com/repos/01org/TPM2.0-TSS/milestones/5/labels","id":1526856,"number":5,"title":"header cleanup","description":null,"creator":{"login":"flihp","id":1550813,"avatar_url":"https://avatars.githubusercontent.com/u/1550813?v=3","gravatar_id":"","url":"https://api.github.com/users/flihp","html_url":"https://github.com/flihp","followers_url":"https://api.github.com/users/flihp/followers","following_url":"https://api.github.com/users/flihp/following{/other_user}","gists_url":"https://api.github.com/users/flihp/gists{/gist_id}","starred_url":"https://api.github.com/users/flihp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flihp/subscriptions","organizations_url":"https://api.github.com/users/flihp/orgs","repos_url":"https://api.github.com/users/flihp/repos","events_url":"https://api.github.com/users/flihp/events{/privacy}","received_events_url":"https://api.github.com/users/flihp/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2016-01-20T19:19:47Z","updated_at":"2016-01-20T20:00:06Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-01-20T20:00:06Z","updated_at":"2016-01-20T21:03:33Z","closed_at":null,"body":"This is a convenience header that pulls in other headers. Since we're installing it it should only reference other installed headers. Thus we probably have to break it up into two separate headers: the installed version will pull in other tss2 headers, the version that's not installed (probably named tpm20_util.h) will pull in everything else."},"comment":{"url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/comments/173358112","html_url":"https://github.com/01org/TPM2.0-TSS/issues/104#issuecomment-173358112","issue_url":"https://api.github.com/repos/01org/TPM2.0-TSS/issues/104","id":173358112,"user":{"login":"wcarthur1","id":4679032,"avatar_url":"https://avatars.githubusercontent.com/u/4679032?v=3","gravatar_id":"","url":"https://api.github.com/users/wcarthur1","html_url":"https://github.com/wcarthur1","followers_url":"https://api.github.com/users/wcarthur1/followers","following_url":"https://api.github.com/users/wcarthur1/following{/other_user}","gists_url":"https://api.github.com/users/wcarthur1/gists{/gist_id}","starred_url":"https://api.github.com/users/wcarthur1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcarthur1/subscriptions","organizations_url":"https://api.github.com/users/wcarthur1/orgs","repos_url":"https://api.github.com/users/wcarthur1/repos","events_url":"https://api.github.com/users/wcarthur1/events{/privacy}","received_events_url":"https://api.github.com/users/wcarthur1/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T21:03:33Z","updated_at":"2016-01-20T21:03:33Z","body":"Below…\r\n\r\nWill Arthur\r\nIntel Corporation\r\nServer Security Firmware\r\n803-216-2101\r\n\r\nFrom: Philip Tricca [mailto:notifications@github.com]\r\nSent: Wednesday, January 20, 2016 3:35 PM\r\nTo: 01org/TPM2.0-TSS <TPM2.0-TSS@noreply.github.com>\r\nCc: Arthur, Will C <will.c.arthur@intel.com>\r\nSubject: Re: [TPM2.0-TSS] factor tpm20.h header (#104)\r\n\r\n\r\nI just ran into another interesting one:\r\nThe tcti_util.h file is one that we decided should not be installed. It defines a pile of structures that are specific to the Intel TCTIs. These are opaque blobs in the spec and only have meaning to specific TCTI implementations so I think we're right in that it doesn't belong with the tss2 headers.\r\n\r\nAFAIK, it does need to be installed with the TCTI headers that we provide though. Consumers need to know what these structures are in order to use our TCTIs.\r\n\r\n[Arthur, Will C] Why do they need these structures?  I would think that the tss2_tcti.h file should be enough.  May need to move the last three structures in tcti_util.h file into tss2_tcti.h.\r\n\r\nHow do you feel about moving these structures, or maybe the whole file in with the other headers in $(includedir)/tcti ?\r\n\r\n[Arthur, Will C]  I’d rather keep the opaque parts of tcti_util.h away from application developers.\r\n\r\n\r\n\r\n—\r\nReply to this email directly or view it on GitHub<https://github.com/01org/TPM2.0-TSS/issues/104#issuecomment-173351383>.\r\n"}}