{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/comments/57814748","id":57814748,"diff_hunk":"@@ -34,9 +34,11 @@ Copyright 2015 Google Inc. All Rights Reserved.\n         </div>\n         <ul class=\"nav navbar-nav\">\n           <li><a href=\"/\">Books</a></li>\n-          <li><a href=\"/books/mine\">My Books</a></li>\n+          <div class=\"form-group ${isAuthConfigured ? '' : 'hidden'}\">","path":"bookshelf/src/main/webapp/base.jsp","position":5,"original_position":5,"commit_id":"12b71dde763bb4ea26d441e604c944c92ed29b05","original_commit_id":"12b71dde763bb4ea26d441e604c944c92ed29b05","user":{"login":"shun-fan","id":7222445,"avatar_url":"https://avatars.githubusercontent.com/u/7222445?v=3","gravatar_id":"","url":"https://api.github.com/users/shun-fan","html_url":"https://github.com/shun-fan","followers_url":"https://api.github.com/users/shun-fan/followers","following_url":"https://api.github.com/users/shun-fan/following{/other_user}","gists_url":"https://api.github.com/users/shun-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shun-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shun-fan/subscriptions","organizations_url":"https://api.github.com/users/shun-fan/orgs","repos_url":"https://api.github.com/users/shun-fan/repos","events_url":"https://api.github.com/users/shun-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shun-fan/received_events","type":"User","site_admin":false},"body":"Ok, this and the next comment make sense. If you want to continue testing your version we can use that. My only suggestion would be do all the property checking in one place, such as the init function in ListBookServlet","created_at":"2016-03-29T22:56:24Z","updated_at":"2016-03-29T22:56:24Z","html_url":"https://github.com/GoogleCloudPlatform/getting-started-java/pull/64#discussion_r57814748","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/comments/57814748"},"html":{"href":"https://github.com/GoogleCloudPlatform/getting-started-java/pull/64#discussion_r57814748"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64","id":64526123,"html_url":"https://github.com/GoogleCloudPlatform/getting-started-java/pull/64","diff_url":"https://github.com/GoogleCloudPlatform/getting-started-java/pull/64.diff","patch_url":"https://github.com/GoogleCloudPlatform/getting-started-java/pull/64.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/64","number":64,"state":"open","locked":false,"title":"Hide login when client id and secret are not set","user":{"login":"shun-fan","id":7222445,"avatar_url":"https://avatars.githubusercontent.com/u/7222445?v=3","gravatar_id":"","url":"https://api.github.com/users/shun-fan","html_url":"https://github.com/shun-fan","followers_url":"https://api.github.com/users/shun-fan/followers","following_url":"https://api.github.com/users/shun-fan/following{/other_user}","gists_url":"https://api.github.com/users/shun-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shun-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shun-fan/subscriptions","organizations_url":"https://api.github.com/users/shun-fan/orgs","repos_url":"https://api.github.com/users/shun-fan/repos","events_url":"https://api.github.com/users/shun-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shun-fan/received_events","type":"User","site_admin":false},"body":"I also moved setting the bucket attribute with setting the auth check\r\n\r\n@tswast ","created_at":"2016-03-29T20:12:29Z","updated_at":"2016-03-29T22:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9fc0f23199c213973242d6febd9e151435f66fb","assignee":{"login":"lesv","id":1136014,"avatar_url":"https://avatars.githubusercontent.com/u/1136014?v=3","gravatar_id":"","url":"https://api.github.com/users/lesv","html_url":"https://github.com/lesv","followers_url":"https://api.github.com/users/lesv/followers","following_url":"https://api.github.com/users/lesv/following{/other_user}","gists_url":"https://api.github.com/users/lesv/gists{/gist_id}","starred_url":"https://api.github.com/users/lesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesv/subscriptions","organizations_url":"https://api.github.com/users/lesv/orgs","repos_url":"https://api.github.com/users/lesv/repos","events_url":"https://api.github.com/users/lesv/events{/privacy}","received_events_url":"https://api.github.com/users/lesv/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/64/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/statuses/12b71dde763bb4ea26d441e604c944c92ed29b05","head":{"label":"GoogleCloudPlatform:hide-login","ref":"hide-login","sha":"12b71dde763bb4ea26d441e604c944c92ed29b05","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":45934199,"name":"getting-started-java","full_name":"GoogleCloudPlatform/getting-started-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/getting-started-java","description":"","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/deployments","created_at":"2015-11-10T19:10:49Z","updated_at":"2016-03-28T13:21:28Z","pushed_at":"2016-03-29T20:24:25Z","git_url":"git://github.com/GoogleCloudPlatform/getting-started-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/getting-started-java.git","clone_url":"https://github.com/GoogleCloudPlatform/getting-started-java.git","svn_url":"https://github.com/GoogleCloudPlatform/getting-started-java","homepage":null,"size":226,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6d56c3e0d01c47279366463bdedad3ebd6368a71","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":45934199,"name":"getting-started-java","full_name":"GoogleCloudPlatform/getting-started-java","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/getting-started-java","description":"","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/deployments","created_at":"2015-11-10T19:10:49Z","updated_at":"2016-03-28T13:21:28Z","pushed_at":"2016-03-29T20:24:25Z","git_url":"git://github.com/GoogleCloudPlatform/getting-started-java.git","ssh_url":"git@github.com:GoogleCloudPlatform/getting-started-java.git","clone_url":"https://github.com/GoogleCloudPlatform/getting-started-java.git","svn_url":"https://github.com/GoogleCloudPlatform/getting-started-java","homepage":null,"size":226,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64"},"html":{"href":"https://github.com/GoogleCloudPlatform/getting-started-java/pull/64"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/64"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/getting-started-java/statuses/12b71dde763bb4ea26d441e604c944c92ed29b05"}}}}