{"action":"created","comment":{"url":"https://api.github.com/repos/cbernet/heppy/pulls/comments/63006369","id":63006369,"diff_hunk":"@@ -0,0 +1,19 @@\n+from heppy.framework.analyzer import Analyzer\n+import copy\n+\n+\n+\n+class Merger(Analyzer):\n+        \n+    def process(self, event):\n+        inputA = getattr(event, self.cfg_ana.inputA)\n+        inputB = getattr(event, self.cfg_ana.inputB)\n+        \n+        #should this be a deep copy?","path":"analyzers/Merger.py","position":12,"original_position":12,"commit_id":"23a1957e5a58bb348cb15e49ba4d92b38950031e","original_commit_id":"23a1957e5a58bb348cb15e49ba4d92b38950031e","user":{"login":"cbernet","id":4138171,"avatar_url":"https://avatars.githubusercontent.com/u/4138171?v=3","gravatar_id":"","url":"https://api.github.com/users/cbernet","html_url":"https://github.com/cbernet","followers_url":"https://api.github.com/users/cbernet/followers","following_url":"https://api.github.com/users/cbernet/following{/other_user}","gists_url":"https://api.github.com/users/cbernet/gists{/gist_id}","starred_url":"https://api.github.com/users/cbernet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbernet/subscriptions","organizations_url":"https://api.github.com/users/cbernet/orgs","repos_url":"https://api.github.com/users/cbernet/repos","events_url":"https://api.github.com/users/cbernet/events{/privacy}","received_events_url":"https://api.github.com/users/cbernet/received_events","type":"User","site_admin":false},"body":"remove \r\nno it is perfect as it is.","created_at":"2016-05-12T11:51:16Z","updated_at":"2016-05-12T11:51:16Z","html_url":"https://github.com/cbernet/heppy/pull/11#discussion_r63006369","pull_request_url":"https://api.github.com/repos/cbernet/heppy/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/cbernet/heppy/pulls/comments/63006369"},"html":{"href":"https://github.com/cbernet/heppy/pull/11#discussion_r63006369"},"pull_request":{"href":"https://api.github.com/repos/cbernet/heppy/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/cbernet/heppy/pulls/11","id":66633492,"html_url":"https://github.com/cbernet/heppy/pull/11","diff_url":"https://github.com/cbernet/heppy/pull/11.diff","patch_url":"https://github.com/cbernet/heppy/pull/11.patch","issue_url":"https://api.github.com/repos/cbernet/heppy/issues/11","number":11,"state":"open","locked":false,"title":"Pfprototype","user":{"login":"alicerobson","id":14326746,"avatar_url":"https://avatars.githubusercontent.com/u/14326746?v=3","gravatar_id":"","url":"https://api.github.com/users/alicerobson","html_url":"https://github.com/alicerobson","followers_url":"https://api.github.com/users/alicerobson/followers","following_url":"https://api.github.com/users/alicerobson/following{/other_user}","gists_url":"https://api.github.com/users/alicerobson/gists{/gist_id}","starred_url":"https://api.github.com/users/alicerobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicerobson/subscriptions","organizations_url":"https://api.github.com/users/alicerobson/orgs","repos_url":"https://api.github.com/users/alicerobson/repos","events_url":"https://api.github.com/users/alicerobson/events{/privacy}","received_events_url":"https://api.github.com/users/alicerobson/received_events","type":"User","site_admin":false},"body":"Integration of aliceproto files into Colin’s code (extracted 11 April).\r\n\r\nAll files have been moved from aliceproto directory. There may still be some need for further moves. I have not moved the positions of other files although this too may be a good plan at some point.\r\n\r\nThere is now a papas/graphtools directory.\r\nI also created a graphbuilder class - the mergedclusterbuilder now derives directly from this rather than from blockbuilder. The pfblockbuilder also uses graphbuilder.\r\n\r\nI fixed the problems with the test case that you found. I have run\r\npython -m unittest discover\r\nand all seems well. I even remembered to delete the .pyc files first :-).\r\n\r\nSome other notes\r\n(1) The original reconstuction method is still called from the simulation and retains its filename\r\n The new reconstruction is stored in alicepfreconstruction (for now)\r\n(2) The new reconstruction does not add back in muons and electrons (todo)\r\n(3) In PapasSim the naming of the particles stored in the event probably needs some rationalisation \r\n(4) the pfreconstrution had some separate developments added in since I started my developments. I have added some of this back into the new alicepfreconstruction eg the logger. The locking of elements also appeared to have changed (todo - discuss if this needs changing or not)\r\n(5) I implemented the log info for the \"if debugprint\" but then  undid it as I have not yet figured out how to actually find this log output (output is v useful for me when something is amiss)\r\n(6) I added in additonal functionality for the clusters to avoid a further issue connected to angularsize when looking at links between merged clusters.\r\nAlice\r\n","created_at":"2016-04-15T12:18:56Z","updated_at":"2016-05-12T11:51:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90ebcbd5053581de6ddff78dd930a19004e318da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cbernet/heppy/pulls/11/commits","review_comments_url":"https://api.github.com/repos/cbernet/heppy/pulls/11/comments","review_comment_url":"https://api.github.com/repos/cbernet/heppy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbernet/heppy/issues/11/comments","statuses_url":"https://api.github.com/repos/cbernet/heppy/statuses/23a1957e5a58bb348cb15e49ba4d92b38950031e","head":{"label":"alicerobson:pfprototype","ref":"pfprototype","sha":"23a1957e5a58bb348cb15e49ba4d92b38950031e","user":{"login":"alicerobson","id":14326746,"avatar_url":"https://avatars.githubusercontent.com/u/14326746?v=3","gravatar_id":"","url":"https://api.github.com/users/alicerobson","html_url":"https://github.com/alicerobson","followers_url":"https://api.github.com/users/alicerobson/followers","following_url":"https://api.github.com/users/alicerobson/following{/other_user}","gists_url":"https://api.github.com/users/alicerobson/gists{/gist_id}","starred_url":"https://api.github.com/users/alicerobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicerobson/subscriptions","organizations_url":"https://api.github.com/users/alicerobson/orgs","repos_url":"https://api.github.com/users/alicerobson/repos","events_url":"https://api.github.com/users/alicerobson/events{/privacy}","received_events_url":"https://api.github.com/users/alicerobson/received_events","type":"User","site_admin":false},"repo":{"id":42855691,"name":"heppy","full_name":"alicerobson/heppy","owner":{"login":"alicerobson","id":14326746,"avatar_url":"https://avatars.githubusercontent.com/u/14326746?v=3","gravatar_id":"","url":"https://api.github.com/users/alicerobson","html_url":"https://github.com/alicerobson","followers_url":"https://api.github.com/users/alicerobson/followers","following_url":"https://api.github.com/users/alicerobson/following{/other_user}","gists_url":"https://api.github.com/users/alicerobson/gists{/gist_id}","starred_url":"https://api.github.com/users/alicerobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicerobson/subscriptions","organizations_url":"https://api.github.com/users/alicerobson/orgs","repos_url":"https://api.github.com/users/alicerobson/repos","events_url":"https://api.github.com/users/alicerobson/events{/privacy}","received_events_url":"https://api.github.com/users/alicerobson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alicerobson/heppy","description":"A python event processing framework for high energy physics based on ROOT","fork":true,"url":"https://api.github.com/repos/alicerobson/heppy","forks_url":"https://api.github.com/repos/alicerobson/heppy/forks","keys_url":"https://api.github.com/repos/alicerobson/heppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alicerobson/heppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alicerobson/heppy/teams","hooks_url":"https://api.github.com/repos/alicerobson/heppy/hooks","issue_events_url":"https://api.github.com/repos/alicerobson/heppy/issues/events{/number}","events_url":"https://api.github.com/repos/alicerobson/heppy/events","assignees_url":"https://api.github.com/repos/alicerobson/heppy/assignees{/user}","branches_url":"https://api.github.com/repos/alicerobson/heppy/branches{/branch}","tags_url":"https://api.github.com/repos/alicerobson/heppy/tags","blobs_url":"https://api.github.com/repos/alicerobson/heppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alicerobson/heppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alicerobson/heppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/alicerobson/heppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alicerobson/heppy/statuses/{sha}","languages_url":"https://api.github.com/repos/alicerobson/heppy/languages","stargazers_url":"https://api.github.com/repos/alicerobson/heppy/stargazers","contributors_url":"https://api.github.com/repos/alicerobson/heppy/contributors","subscribers_url":"https://api.github.com/repos/alicerobson/heppy/subscribers","subscription_url":"https://api.github.com/repos/alicerobson/heppy/subscription","commits_url":"https://api.github.com/repos/alicerobson/heppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/alicerobson/heppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/alicerobson/heppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/alicerobson/heppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/alicerobson/heppy/contents/{+path}","compare_url":"https://api.github.com/repos/alicerobson/heppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alicerobson/heppy/merges","archive_url":"https://api.github.com/repos/alicerobson/heppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alicerobson/heppy/downloads","issues_url":"https://api.github.com/repos/alicerobson/heppy/issues{/number}","pulls_url":"https://api.github.com/repos/alicerobson/heppy/pulls{/number}","milestones_url":"https://api.github.com/repos/alicerobson/heppy/milestones{/number}","notifications_url":"https://api.github.com/repos/alicerobson/heppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alicerobson/heppy/labels{/name}","releases_url":"https://api.github.com/repos/alicerobson/heppy/releases{/id}","deployments_url":"https://api.github.com/repos/alicerobson/heppy/deployments","created_at":"2015-09-21T09:09:16Z","updated_at":"2015-09-21T09:09:16Z","pushed_at":"2016-05-10T14:19:31Z","git_url":"git://github.com/alicerobson/heppy.git","ssh_url":"git@github.com:alicerobson/heppy.git","clone_url":"https://github.com/alicerobson/heppy.git","svn_url":"https://github.com/alicerobson/heppy","homepage":"","size":552,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbernet:master","ref":"master","sha":"1c043dfad888e7ebdb8e7d28b5e508bd06977515","user":{"login":"cbernet","id":4138171,"avatar_url":"https://avatars.githubusercontent.com/u/4138171?v=3","gravatar_id":"","url":"https://api.github.com/users/cbernet","html_url":"https://github.com/cbernet","followers_url":"https://api.github.com/users/cbernet/followers","following_url":"https://api.github.com/users/cbernet/following{/other_user}","gists_url":"https://api.github.com/users/cbernet/gists{/gist_id}","starred_url":"https://api.github.com/users/cbernet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbernet/subscriptions","organizations_url":"https://api.github.com/users/cbernet/orgs","repos_url":"https://api.github.com/users/cbernet/repos","events_url":"https://api.github.com/users/cbernet/events{/privacy}","received_events_url":"https://api.github.com/users/cbernet/received_events","type":"User","site_admin":false},"repo":{"id":20684927,"name":"heppy","full_name":"cbernet/heppy","owner":{"login":"cbernet","id":4138171,"avatar_url":"https://avatars.githubusercontent.com/u/4138171?v=3","gravatar_id":"","url":"https://api.github.com/users/cbernet","html_url":"https://github.com/cbernet","followers_url":"https://api.github.com/users/cbernet/followers","following_url":"https://api.github.com/users/cbernet/following{/other_user}","gists_url":"https://api.github.com/users/cbernet/gists{/gist_id}","starred_url":"https://api.github.com/users/cbernet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbernet/subscriptions","organizations_url":"https://api.github.com/users/cbernet/orgs","repos_url":"https://api.github.com/users/cbernet/repos","events_url":"https://api.github.com/users/cbernet/events{/privacy}","received_events_url":"https://api.github.com/users/cbernet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbernet/heppy","description":"A python event processing framework for high energy physics based on ROOT","fork":false,"url":"https://api.github.com/repos/cbernet/heppy","forks_url":"https://api.github.com/repos/cbernet/heppy/forks","keys_url":"https://api.github.com/repos/cbernet/heppy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbernet/heppy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbernet/heppy/teams","hooks_url":"https://api.github.com/repos/cbernet/heppy/hooks","issue_events_url":"https://api.github.com/repos/cbernet/heppy/issues/events{/number}","events_url":"https://api.github.com/repos/cbernet/heppy/events","assignees_url":"https://api.github.com/repos/cbernet/heppy/assignees{/user}","branches_url":"https://api.github.com/repos/cbernet/heppy/branches{/branch}","tags_url":"https://api.github.com/repos/cbernet/heppy/tags","blobs_url":"https://api.github.com/repos/cbernet/heppy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbernet/heppy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbernet/heppy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbernet/heppy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbernet/heppy/statuses/{sha}","languages_url":"https://api.github.com/repos/cbernet/heppy/languages","stargazers_url":"https://api.github.com/repos/cbernet/heppy/stargazers","contributors_url":"https://api.github.com/repos/cbernet/heppy/contributors","subscribers_url":"https://api.github.com/repos/cbernet/heppy/subscribers","subscription_url":"https://api.github.com/repos/cbernet/heppy/subscription","commits_url":"https://api.github.com/repos/cbernet/heppy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbernet/heppy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbernet/heppy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbernet/heppy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbernet/heppy/contents/{+path}","compare_url":"https://api.github.com/repos/cbernet/heppy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbernet/heppy/merges","archive_url":"https://api.github.com/repos/cbernet/heppy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbernet/heppy/downloads","issues_url":"https://api.github.com/repos/cbernet/heppy/issues{/number}","pulls_url":"https://api.github.com/repos/cbernet/heppy/pulls{/number}","milestones_url":"https://api.github.com/repos/cbernet/heppy/milestones{/number}","notifications_url":"https://api.github.com/repos/cbernet/heppy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbernet/heppy/labels{/name}","releases_url":"https://api.github.com/repos/cbernet/heppy/releases{/id}","deployments_url":"https://api.github.com/repos/cbernet/heppy/deployments","created_at":"2014-06-10T12:51:12Z","updated_at":"2016-02-08T14:39:46Z","pushed_at":"2016-05-10T14:22:20Z","git_url":"git://github.com/cbernet/heppy.git","ssh_url":"git@github.com:cbernet/heppy.git","clone_url":"https://github.com/cbernet/heppy.git","svn_url":"https://github.com/cbernet/heppy","homepage":"","size":561,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbernet/heppy/pulls/11"},"html":{"href":"https://github.com/cbernet/heppy/pull/11"},"issue":{"href":"https://api.github.com/repos/cbernet/heppy/issues/11"},"comments":{"href":"https://api.github.com/repos/cbernet/heppy/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/cbernet/heppy/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/cbernet/heppy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbernet/heppy/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/cbernet/heppy/statuses/23a1957e5a58bb348cb15e49ba4d92b38950031e"}}}}