{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/for-GET/jesse/pulls/21","id":75212803,"html_url":"https://github.com/for-GET/jesse/pull/21","diff_url":"https://github.com/for-GET/jesse/pull/21.diff","patch_url":"https://github.com/for-GET/jesse/pull/21.patch","issue_url":"https://api.github.com/repos/for-GET/jesse/issues/21","number":21,"state":"closed","locked":false,"title":"Fixing a minor error with OTP 19.0's dialyzer","user":{"login":"wk8","id":2536231,"avatar_url":"https://avatars.githubusercontent.com/u/2536231?v=3","gravatar_id":"","url":"https://api.github.com/users/wk8","html_url":"https://github.com/wk8","followers_url":"https://api.github.com/users/wk8/followers","following_url":"https://api.github.com/users/wk8/following{/other_user}","gists_url":"https://api.github.com/users/wk8/gists{/gist_id}","starred_url":"https://api.github.com/users/wk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wk8/subscriptions","organizations_url":"https://api.github.com/users/wk8/orgs","repos_url":"https://api.github.com/users/wk8/repos","events_url":"https://api.github.com/users/wk8/events{/privacy}","received_events_url":"https://api.github.com/users/wk8/received_events","type":"User","site_admin":false},"body":"It seems that OTP 19.0's dialyzer doesn't tolerate building records that\r\nviolate their specs any more; prior to this patch, it would raise the following\r\nwarnings:\r\n\r\n```\r\njesse_cli.erl:61: The pattern {'ok', _} can never match the type {'error',_}\r\njesse_cli.erl:79: The pattern {'ok', _} can never match the type {'error',_}\r\njesse_schema_validator.erl:72: Function result/1 will never be called\r\njesse_state.erl:141: Record construction #state{current_path::[],error_list::[],id::'undefined'} violates the declared type of field id::binary()\r\njesse_state.erl:273: The pattern <'undefined', Id> can never match the type <binary() | [any()] | {'error',[any()],binary() | maybe_improper_list(binary() | maybe_improper_list(any(),binary() | []) | char(),binary() | [])} | {'incomplete',[any()],binary()},[binary() | maybe_improper_list(any(),binary() | []) | char()]>\r\njesse_tests_util.erl:85: The pattern {'ok', _} can never match the type {'error',_}\r\n```","created_at":"2016-06-25T19:45:36Z","updated_at":"2016-06-25T21:40:09Z","closed_at":"2016-06-25T21:40:09Z","merged_at":"2016-06-25T21:40:09Z","merge_commit_sha":"ff03f66aac10ce7d9dbf43e46c2f730daa1f5a07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/for-GET/jesse/pulls/21/commits","review_comments_url":"https://api.github.com/repos/for-GET/jesse/pulls/21/comments","review_comment_url":"https://api.github.com/repos/for-GET/jesse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/for-GET/jesse/issues/21/comments","statuses_url":"https://api.github.com/repos/for-GET/jesse/statuses/930b42aed8b4ba849dd0b51c8eed12c75253f82e","head":{"label":"wk8:wk8/upgrade_to_erl_19","ref":"wk8/upgrade_to_erl_19","sha":"930b42aed8b4ba849dd0b51c8eed12c75253f82e","user":{"login":"wk8","id":2536231,"avatar_url":"https://avatars.githubusercontent.com/u/2536231?v=3","gravatar_id":"","url":"https://api.github.com/users/wk8","html_url":"https://github.com/wk8","followers_url":"https://api.github.com/users/wk8/followers","following_url":"https://api.github.com/users/wk8/following{/other_user}","gists_url":"https://api.github.com/users/wk8/gists{/gist_id}","starred_url":"https://api.github.com/users/wk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wk8/subscriptions","organizations_url":"https://api.github.com/users/wk8/orgs","repos_url":"https://api.github.com/users/wk8/repos","events_url":"https://api.github.com/users/wk8/events{/privacy}","received_events_url":"https://api.github.com/users/wk8/received_events","type":"User","site_admin":false},"repo":{"id":61920865,"name":"jesse","full_name":"wk8/jesse","owner":{"login":"wk8","id":2536231,"avatar_url":"https://avatars.githubusercontent.com/u/2536231?v=3","gravatar_id":"","url":"https://api.github.com/users/wk8","html_url":"https://github.com/wk8","followers_url":"https://api.github.com/users/wk8/followers","following_url":"https://api.github.com/users/wk8/following{/other_user}","gists_url":"https://api.github.com/users/wk8/gists{/gist_id}","starred_url":"https://api.github.com/users/wk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wk8/subscriptions","organizations_url":"https://api.github.com/users/wk8/orgs","repos_url":"https://api.github.com/users/wk8/repos","events_url":"https://api.github.com/users/wk8/events{/privacy}","received_events_url":"https://api.github.com/users/wk8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wk8/jesse","description":"jesse (JSon Schema Erlang) is an implementation of a JSON Schema validator for Erlang.","fork":true,"url":"https://api.github.com/repos/wk8/jesse","forks_url":"https://api.github.com/repos/wk8/jesse/forks","keys_url":"https://api.github.com/repos/wk8/jesse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wk8/jesse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wk8/jesse/teams","hooks_url":"https://api.github.com/repos/wk8/jesse/hooks","issue_events_url":"https://api.github.com/repos/wk8/jesse/issues/events{/number}","events_url":"https://api.github.com/repos/wk8/jesse/events","assignees_url":"https://api.github.com/repos/wk8/jesse/assignees{/user}","branches_url":"https://api.github.com/repos/wk8/jesse/branches{/branch}","tags_url":"https://api.github.com/repos/wk8/jesse/tags","blobs_url":"https://api.github.com/repos/wk8/jesse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wk8/jesse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wk8/jesse/git/refs{/sha}","trees_url":"https://api.github.com/repos/wk8/jesse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wk8/jesse/statuses/{sha}","languages_url":"https://api.github.com/repos/wk8/jesse/languages","stargazers_url":"https://api.github.com/repos/wk8/jesse/stargazers","contributors_url":"https://api.github.com/repos/wk8/jesse/contributors","subscribers_url":"https://api.github.com/repos/wk8/jesse/subscribers","subscription_url":"https://api.github.com/repos/wk8/jesse/subscription","commits_url":"https://api.github.com/repos/wk8/jesse/commits{/sha}","git_commits_url":"https://api.github.com/repos/wk8/jesse/git/commits{/sha}","comments_url":"https://api.github.com/repos/wk8/jesse/comments{/number}","issue_comment_url":"https://api.github.com/repos/wk8/jesse/issues/comments{/number}","contents_url":"https://api.github.com/repos/wk8/jesse/contents/{+path}","compare_url":"https://api.github.com/repos/wk8/jesse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wk8/jesse/merges","archive_url":"https://api.github.com/repos/wk8/jesse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wk8/jesse/downloads","issues_url":"https://api.github.com/repos/wk8/jesse/issues{/number}","pulls_url":"https://api.github.com/repos/wk8/jesse/pulls{/number}","milestones_url":"https://api.github.com/repos/wk8/jesse/milestones{/number}","notifications_url":"https://api.github.com/repos/wk8/jesse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wk8/jesse/labels{/name}","releases_url":"https://api.github.com/repos/wk8/jesse/releases{/id}","deployments_url":"https://api.github.com/repos/wk8/jesse/deployments","created_at":"2016-06-25T01:14:31Z","updated_at":"2016-06-25T01:14:33Z","pushed_at":"2016-06-25T19:48:08Z","git_url":"git://github.com/wk8/jesse.git","ssh_url":"git@github.com:wk8/jesse.git","clone_url":"https://github.com/wk8/jesse.git","svn_url":"https://github.com/wk8/jesse","homepage":"","size":1806,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"for-GET:master","ref":"master","sha":"a1ab58c42b98152d7b61730d0a456c1bb5c1a29a","user":{"login":"for-GET","id":5500015,"avatar_url":"https://avatars.githubusercontent.com/u/5500015?v=3","gravatar_id":"","url":"https://api.github.com/users/for-GET","html_url":"https://github.com/for-GET","followers_url":"https://api.github.com/users/for-GET/followers","following_url":"https://api.github.com/users/for-GET/following{/other_user}","gists_url":"https://api.github.com/users/for-GET/gists{/gist_id}","starred_url":"https://api.github.com/users/for-GET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/for-GET/subscriptions","organizations_url":"https://api.github.com/users/for-GET/orgs","repos_url":"https://api.github.com/users/for-GET/repos","events_url":"https://api.github.com/users/for-GET/events{/privacy}","received_events_url":"https://api.github.com/users/for-GET/received_events","type":"Organization","site_admin":false},"repo":{"id":47450647,"name":"jesse","full_name":"for-GET/jesse","owner":{"login":"for-GET","id":5500015,"avatar_url":"https://avatars.githubusercontent.com/u/5500015?v=3","gravatar_id":"","url":"https://api.github.com/users/for-GET","html_url":"https://github.com/for-GET","followers_url":"https://api.github.com/users/for-GET/followers","following_url":"https://api.github.com/users/for-GET/following{/other_user}","gists_url":"https://api.github.com/users/for-GET/gists{/gist_id}","starred_url":"https://api.github.com/users/for-GET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/for-GET/subscriptions","organizations_url":"https://api.github.com/users/for-GET/orgs","repos_url":"https://api.github.com/users/for-GET/repos","events_url":"https://api.github.com/users/for-GET/events{/privacy}","received_events_url":"https://api.github.com/users/for-GET/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/for-GET/jesse","description":"jesse (JSon Schema Erlang) is an implementation of a JSON Schema validator for Erlang.","fork":false,"url":"https://api.github.com/repos/for-GET/jesse","forks_url":"https://api.github.com/repos/for-GET/jesse/forks","keys_url":"https://api.github.com/repos/for-GET/jesse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/for-GET/jesse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/for-GET/jesse/teams","hooks_url":"https://api.github.com/repos/for-GET/jesse/hooks","issue_events_url":"https://api.github.com/repos/for-GET/jesse/issues/events{/number}","events_url":"https://api.github.com/repos/for-GET/jesse/events","assignees_url":"https://api.github.com/repos/for-GET/jesse/assignees{/user}","branches_url":"https://api.github.com/repos/for-GET/jesse/branches{/branch}","tags_url":"https://api.github.com/repos/for-GET/jesse/tags","blobs_url":"https://api.github.com/repos/for-GET/jesse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/for-GET/jesse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/for-GET/jesse/git/refs{/sha}","trees_url":"https://api.github.com/repos/for-GET/jesse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/for-GET/jesse/statuses/{sha}","languages_url":"https://api.github.com/repos/for-GET/jesse/languages","stargazers_url":"https://api.github.com/repos/for-GET/jesse/stargazers","contributors_url":"https://api.github.com/repos/for-GET/jesse/contributors","subscribers_url":"https://api.github.com/repos/for-GET/jesse/subscribers","subscription_url":"https://api.github.com/repos/for-GET/jesse/subscription","commits_url":"https://api.github.com/repos/for-GET/jesse/commits{/sha}","git_commits_url":"https://api.github.com/repos/for-GET/jesse/git/commits{/sha}","comments_url":"https://api.github.com/repos/for-GET/jesse/comments{/number}","issue_comment_url":"https://api.github.com/repos/for-GET/jesse/issues/comments{/number}","contents_url":"https://api.github.com/repos/for-GET/jesse/contents/{+path}","compare_url":"https://api.github.com/repos/for-GET/jesse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/for-GET/jesse/merges","archive_url":"https://api.github.com/repos/for-GET/jesse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/for-GET/jesse/downloads","issues_url":"https://api.github.com/repos/for-GET/jesse/issues{/number}","pulls_url":"https://api.github.com/repos/for-GET/jesse/pulls{/number}","milestones_url":"https://api.github.com/repos/for-GET/jesse/milestones{/number}","notifications_url":"https://api.github.com/repos/for-GET/jesse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/for-GET/jesse/labels{/name}","releases_url":"https://api.github.com/repos/for-GET/jesse/releases{/id}","deployments_url":"https://api.github.com/repos/for-GET/jesse/deployments","created_at":"2015-12-05T09:50:17Z","updated_at":"2016-06-19T06:21:53Z","pushed_at":"2016-06-25T21:40:09Z","git_url":"git://github.com/for-GET/jesse.git","ssh_url":"git@github.com:for-GET/jesse.git","clone_url":"https://github.com/for-GET/jesse.git","svn_url":"https://github.com/for-GET/jesse","homepage":"","size":2915,"stargazers_count":22,"watchers_count":22,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/for-GET/jesse/pulls/21"},"html":{"href":"https://github.com/for-GET/jesse/pull/21"},"issue":{"href":"https://api.github.com/repos/for-GET/jesse/issues/21"},"comments":{"href":"https://api.github.com/repos/for-GET/jesse/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/for-GET/jesse/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/for-GET/jesse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/for-GET/jesse/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/for-GET/jesse/statuses/930b42aed8b4ba849dd0b51c8eed12c75253f82e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andreineculau","id":708161,"avatar_url":"https://avatars.githubusercontent.com/u/708161?v=3","gravatar_id":"","url":"https://api.github.com/users/andreineculau","html_url":"https://github.com/andreineculau","followers_url":"https://api.github.com/users/andreineculau/followers","following_url":"https://api.github.com/users/andreineculau/following{/other_user}","gists_url":"https://api.github.com/users/andreineculau/gists{/gist_id}","starred_url":"https://api.github.com/users/andreineculau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreineculau/subscriptions","organizations_url":"https://api.github.com/users/andreineculau/orgs","repos_url":"https://api.github.com/users/andreineculau/repos","events_url":"https://api.github.com/users/andreineculau/events{/privacy}","received_events_url":"https://api.github.com/users/andreineculau/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"andreineculau"}}