{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/6009","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/6009/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/6009/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/6009/events","html_url":"https://github.com/eslint/eslint/issues/6009","id":151905569,"number":6009,"title":"Proposal: Leave issues/PRs open for a set amount of time","user":{"login":"nzakas","id":38546,"avatar_url":"https://avatars.githubusercontent.com/u/38546?v=3","gravatar_id":"","url":"https://api.github.com/users/nzakas","html_url":"https://github.com/nzakas","followers_url":"https://api.github.com/users/nzakas/followers","following_url":"https://api.github.com/users/nzakas/following{/other_user}","gists_url":"https://api.github.com/users/nzakas/gists{/gist_id}","starred_url":"https://api.github.com/users/nzakas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nzakas/subscriptions","organizations_url":"https://api.github.com/users/nzakas/orgs","repos_url":"https://api.github.com/users/nzakas/repos","events_url":"https://api.github.com/users/nzakas/events{/privacy}","received_events_url":"https://api.github.com/users/nzakas/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/eslint/eslint/labels/chore","name":"chore","color":"c2e0c6"},{"url":"https://api.github.com/repos/eslint/eslint/labels/evaluating","name":"evaluating","color":"fef2c0"},{"url":"https://api.github.com/repos/eslint/eslint/labels/infrastructure","name":"infrastructure","color":"666666"},{"url":"https://api.github.com/repos/eslint/eslint/labels/needs%20bikeshedding","name":"needs bikeshedding","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-29T16:03:15Z","updated_at":"2016-05-06T02:31:12Z","closed_at":null,"body":"The team is fairly large and distributed at this point, with people from a lot of different time zones all over the world (United States, Japan, Russia, Turkey...probably more?). Given that, and the different rates at which people can get online to review issues and PRs, I'd like to propose that we adopt the system used by Node.js, which is basically:\r\n\r\n1. PRs should remain open for at least 48 hours before merging (72 hours if over the weekend)\r\n2. Issues should remain open for at least 48 hours before closing (72 hours if over the weekend) - this refers to closing because we aren't going to address the issue. Closing for other reasons (because it's a duplicate, because it's a question that's been answered, etc.) wouldn't need to wait.\r\n\r\nThe goal is to give more members of the team the opportunity to give feedback on PRs and to ensure issues aren't closed prematurely before people have been able to chime in.\r\n\r\nWe can always make exceptions as necessary, but those should be reserved for high-priority situations (such as converting every rule to a new format, where waiting will create a lot of merge conflicts for other PRs).\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/217333678","html_url":"https://github.com/eslint/eslint/issues/6009#issuecomment-217333678","issue_url":"https://api.github.com/repos/eslint/eslint/issues/6009","id":217333678,"user":{"login":"ilyavolodin","id":1380062,"avatar_url":"https://avatars.githubusercontent.com/u/1380062?v=3","gravatar_id":"","url":"https://api.github.com/users/ilyavolodin","html_url":"https://github.com/ilyavolodin","followers_url":"https://api.github.com/users/ilyavolodin/followers","following_url":"https://api.github.com/users/ilyavolodin/following{/other_user}","gists_url":"https://api.github.com/users/ilyavolodin/gists{/gist_id}","starred_url":"https://api.github.com/users/ilyavolodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilyavolodin/subscriptions","organizations_url":"https://api.github.com/users/ilyavolodin/orgs","repos_url":"https://api.github.com/users/ilyavolodin/repos","events_url":"https://api.github.com/users/ilyavolodin/events{/privacy}","received_events_url":"https://api.github.com/users/ilyavolodin/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T02:31:12Z","updated_at":"2016-05-06T02:31:12Z","body":"After trying it for a few day, I really don't think we should do this. What I noticed is that if a PR doesn't get merged on the first day, it tends to hang around for a while. People forget to check it and then we have messages like \"Complete lost track of this, sorry.\". Same with issues. While I see the reason behind this suggestion, I think it will do more harm then good. We rarely have situations where PR gets merged in and then somebody jumps in and say that it shouldn't have."}}