{"action":"created","issue":{"url":"https://api.github.com/repos/TobyLobster/ImportLDraw/issues/1","repository_url":"https://api.github.com/repos/TobyLobster/ImportLDraw","labels_url":"https://api.github.com/repos/TobyLobster/ImportLDraw/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/TobyLobster/ImportLDraw/issues/1/comments","events_url":"https://api.github.com/repos/TobyLobster/ImportLDraw/issues/1/events","html_url":"https://github.com/TobyLobster/ImportLDraw/issues/1","id":157718903,"number":1,"title":"First impressions","user":{"login":"BertVanRaemdonck","id":10909554,"avatar_url":"https://avatars.githubusercontent.com/u/10909554?v=3","gravatar_id":"","url":"https://api.github.com/users/BertVanRaemdonck","html_url":"https://github.com/BertVanRaemdonck","followers_url":"https://api.github.com/users/BertVanRaemdonck/followers","following_url":"https://api.github.com/users/BertVanRaemdonck/following{/other_user}","gists_url":"https://api.github.com/users/BertVanRaemdonck/gists{/gist_id}","starred_url":"https://api.github.com/users/BertVanRaemdonck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertVanRaemdonck/subscriptions","organizations_url":"https://api.github.com/users/BertVanRaemdonck/orgs","repos_url":"https://api.github.com/users/BertVanRaemdonck/repos","events_url":"https://api.github.com/users/BertVanRaemdonck/events{/privacy}","received_events_url":"https://api.github.com/users/BertVanRaemdonck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-05-31T16:49:41Z","updated_at":"2016-06-07T10:54:00Z","closed_at":null,"body":"You blew me away, Toby! I was planning to spend my summer on improving the LDRImporter, and now you show up with something way better than I could ever hope to achieve. Your importer tackles mpd models perfectly, does a great job with normals, has no problem with generated parts and attains an insane speed (my 5111 piece WIP Big Ben in about 30 seconds!). Furthermore, the code looks very transparent at first sight. It's great that we could be an inspiration to you, and it joys me to see little pieces of our own code return here. So awesome job!\r\n\r\nThat being said, here are some remarks I have after a first tryout:\r\n- I think the default scale is quite big. When I tried to change the scale, nothing changed, however. Changing other values like the gap size did have an effect though, and I can spot nothing in the code that fixes the scale on a certain value...\r\n- I see you have a fresnel node for the transparent materials, but not for the rest. Why not? The Fresnel effect is something present in every material. The roughness of the diffuse might be a little bit higher for my taste too.\r\n- When importing certain pieces, like the minifig binoculars, I get the warning that the program found double sided polygons. From what I understand from the code, this is something that lies with the parts themselves, and is nothing that the importer can fix. However, the result is something that is really messy to fix in Blender. Are you sure there is nothing you can do to make the part as good as possible? You could guess a normal and apply that consistently, so that it wouldn't be too much work to adjust everything manually in Blender.\r\n\r\nFurthermore, your program looks really complete, but there are still some goals worth striving for:\r\n- Don't do the logo's with geometry, but with a normal map. This requires UV-unwrapping of the studs though, something I've been told is quite tricky.\r\n- Display mold marks on the bricks in logical places. This can be done with normal maps, or perhaps with geometry. I have a .dat file of such a logo with mold mark lying around by the way.\r\n- Render slopes with the grainy texture (a voronoi texture works beautifully for this, see my custom LDRImporter branch). As far as I know, though, there is no way to automatically decide which faces should get this texture, so it would require a hard coded list, which means quite a bit of work.\r\n- Don't use an edge split modifier with an angle limit. Parts like 2489 get smooth edges due to this, even where they shouldn't. A solution could be to interpret the \"2\" lines from the .dat files, and use them to determine which edges should be sharp and which ones smooth.\r\n- Implement bevels with a bevel shader. There is one available online, but this uses osl, which requires you to render with cpu. I'm looking myself into a way of building a custom node that blurs normal maps, but I'm still in the research stage.\r\n- Give the option to remove unnecessary geometry. You might be able to detect cases in which a stud is covered by a brick, or the underside of a brick is obscured. This might lighten the load of the computer, but with how fast your importer is, that isn't much of a problem!\r\n\r\nThat's everything I can think about after an exhilarating first test. Keep up the good work!"},"comment":{"url":"https://api.github.com/repos/TobyLobster/ImportLDraw/issues/comments/224246462","html_url":"https://github.com/TobyLobster/ImportLDraw/issues/1#issuecomment-224246462","issue_url":"https://api.github.com/repos/TobyLobster/ImportLDraw/issues/1","id":224246462,"user":{"login":"TobyLobster","id":9774304,"avatar_url":"https://avatars.githubusercontent.com/u/9774304?v=3","gravatar_id":"","url":"https://api.github.com/users/TobyLobster","html_url":"https://github.com/TobyLobster","followers_url":"https://api.github.com/users/TobyLobster/followers","following_url":"https://api.github.com/users/TobyLobster/following{/other_user}","gists_url":"https://api.github.com/users/TobyLobster/gists{/gist_id}","starred_url":"https://api.github.com/users/TobyLobster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TobyLobster/subscriptions","organizations_url":"https://api.github.com/users/TobyLobster/orgs","repos_url":"https://api.github.com/users/TobyLobster/repos","events_url":"https://api.github.com/users/TobyLobster/events{/privacy}","received_events_url":"https://api.github.com/users/TobyLobster/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T10:54:00Z","updated_at":"2016-06-07T10:54:00Z","body":"Oops - my mistake. v1.0.5 now released to fix this."}}
{"actor":{"display_login":"TobyLobster"}}