{"action":"created","issue":{"url":"https://api.github.com/repos/TYPO3Fluid/Fluid/issues/64","labels_url":"https://api.github.com/repos/TYPO3Fluid/Fluid/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/TYPO3Fluid/Fluid/issues/64/comments","events_url":"https://api.github.com/repos/TYPO3Fluid/Fluid/issues/64/events","html_url":"https://github.com/TYPO3Fluid/Fluid/issues/64","id":128263196,"number":64,"title":"Performance Tests","user":{"login":"mneuhaus","id":316605,"avatar_url":"https://avatars.githubusercontent.com/u/316605?v=3","gravatar_id":"","url":"https://api.github.com/users/mneuhaus","html_url":"https://github.com/mneuhaus","followers_url":"https://api.github.com/users/mneuhaus/followers","following_url":"https://api.github.com/users/mneuhaus/following{/other_user}","gists_url":"https://api.github.com/users/mneuhaus/gists{/gist_id}","starred_url":"https://api.github.com/users/mneuhaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mneuhaus/subscriptions","organizations_url":"https://api.github.com/users/mneuhaus/orgs","repos_url":"https://api.github.com/users/mneuhaus/repos","events_url":"https://api.github.com/users/mneuhaus/events{/privacy}","received_events_url":"https://api.github.com/users/mneuhaus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-22T22:38:11Z","updated_at":"2016-01-23T11:50:38Z","closed_at":null,"body":"As initially found by christian there is a performance hit compare to the typo3cms/fluid variant, which results in some cases in a almost doubled rendering time.\r\n\r\nthe main issue seems that most viewHelpers reverted to non static variants, so lets fix that :) \r\n\r\n**todo**:\r\n- we'll make render optional by making it an automatic call to renderStatic with ```$this->arguments```\r\n- make every standalone viewHelper static or compiled\r\n- maybe reintroduce viewHelperInstance reusing\r\n\r\ncc @NamelessCoder @helhum @lolli42 \r\nrelated: https://review.typo3.org/#/c/42425/112"},"comment":{"url":"https://api.github.com/repos/TYPO3Fluid/Fluid/issues/comments/174177004","html_url":"https://github.com/TYPO3Fluid/Fluid/issues/64#issuecomment-174177004","issue_url":"https://api.github.com/repos/TYPO3Fluid/Fluid/issues/64","id":174177004,"user":{"login":"lolli42","id":2178068,"avatar_url":"https://avatars.githubusercontent.com/u/2178068?v=3","gravatar_id":"","url":"https://api.github.com/users/lolli42","html_url":"https://github.com/lolli42","followers_url":"https://api.github.com/users/lolli42/followers","following_url":"https://api.github.com/users/lolli42/following{/other_user}","gists_url":"https://api.github.com/users/lolli42/gists{/gist_id}","starred_url":"https://api.github.com/users/lolli42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolli42/subscriptions","organizations_url":"https://api.github.com/users/lolli42/orgs","repos_url":"https://api.github.com/users/lolli42/repos","events_url":"https://api.github.com/users/lolli42/events{/privacy}","received_events_url":"https://api.github.com/users/lolli42/received_events","type":"User","site_admin":false},"created_at":"2016-01-23T11:50:38Z","updated_at":"2016-01-23T11:50:38Z","body":"For the instance re-usage: I'd heavily recommend to stay away from that. Making VH's pseudo singletons doesn't help but opens a large pit hole of possible issues if a dev doesn't understand the impact and its possible side effects: A single VH either has state (then a fresh instance per call is required) or it doesn't (then it provides a static method that is called). This already isn't trivial for everyone to understand. If something in between is introduced (not static, but class re-usage with maybe a cleanup method, done just because our injection is so expensive?) will catapult the complexity of the VH implementation and i'd bet we'd see tons of not-so-funny issues like \"hey, i have a bug i don't understand if i insert the same element a second time on the page\". Also keep in mind that often VH's are coded by people who are not really that deep in the system. Do not do that, keep it simple."}}