{"action":"created","comment":{"url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/comments/77667969","id":77667969,"diff_hunk":"@@ -369,6 +384,11 @@ class convolutional_layer : public feedforward_layer<Activation> {\n         params_.w_stride = w_stride;\n         params_.h_stride = h_stride;\n         params_.tbl      = tbl;\n+\n+        // init padding buffer\n+        if (params_.pad_type == padding::same) {\n+\t\t\tcws_.prev_delta_padded_.resize(1, vec_t(params_.in_padded.size(), float_t(0)));","path":"tiny_dnn/layers/convolutional_layer.h","position":46,"original_position":46,"commit_id":"54fb968570183cbcbabcaf0acd4a7202766efb7b","original_commit_id":"54fb968570183cbcbabcaf0acd4a7202766efb7b","user":{"login":"nyanp","id":378738,"avatar_url":"https://avatars.githubusercontent.com/u/378738?v=3","gravatar_id":"","url":"https://api.github.com/users/nyanp","html_url":"https://github.com/nyanp","followers_url":"https://api.github.com/users/nyanp/followers","following_url":"https://api.github.com/users/nyanp/following{/other_user}","gists_url":"https://api.github.com/users/nyanp/gists{/gist_id}","starred_url":"https://api.github.com/users/nyanp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyanp/subscriptions","organizations_url":"https://api.github.com/users/nyanp/orgs","repos_url":"https://api.github.com/users/nyanp/repos","events_url":"https://api.github.com/users/nyanp/events{/privacy}","received_events_url":"https://api.github.com/users/nyanp/received_events","type":"User","site_admin":false},"body":"@edgarriba \r\nWe need NxKx(W-padded)x(H-padded) storage for ```prev_delta_padded_``` but this line reserve 1xKx(W-padded)x(H-padded). We can override ```set_sample_count``` and reserve appropriate buffer there. see example in [max pooling](https://github.com/tiny-dnn/tiny-dnn/blob/master/tiny_dnn/layers/max_pooling_layer.h#L162_L165).","created_at":"2016-09-06T16:18:16Z","updated_at":"2016-09-06T16:18:16Z","html_url":"https://github.com/tiny-dnn/tiny-dnn/pull/298#discussion_r77667969","pull_request_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/comments/77667969"},"html":{"href":"https://github.com/tiny-dnn/tiny-dnn/pull/298#discussion_r77667969"},"pull_request":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298","id":83029908,"html_url":"https://github.com/tiny-dnn/tiny-dnn/pull/298","diff_url":"https://github.com/tiny-dnn/tiny-dnn/pull/298.diff","patch_url":"https://github.com/tiny-dnn/tiny-dnn/pull/298.patch","issue_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/issues/298","number":298,"state":"open","locked":false,"title":"fix padding::same issue","user":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-28T22:48:14Z","updated_at":"2016-09-06T16:18:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27bb2e3cf2c329c22abb8e32be5955604af097f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298/commits","review_comments_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298/comments","review_comment_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/issues/298/comments","statuses_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/statuses/54fb968570183cbcbabcaf0acd4a7202766efb7b","head":{"label":"edgarriba:fix-padding","ref":"fix-padding","sha":"54fb968570183cbcbabcaf0acd4a7202766efb7b","user":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"repo":{"id":56904717,"name":"tiny-cnn","full_name":"edgarriba/tiny-cnn","owner":{"login":"edgarriba","id":5157099,"avatar_url":"https://avatars.githubusercontent.com/u/5157099?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarriba","html_url":"https://github.com/edgarriba","followers_url":"https://api.github.com/users/edgarriba/followers","following_url":"https://api.github.com/users/edgarriba/following{/other_user}","gists_url":"https://api.github.com/users/edgarriba/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarriba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarriba/subscriptions","organizations_url":"https://api.github.com/users/edgarriba/orgs","repos_url":"https://api.github.com/users/edgarriba/repos","events_url":"https://api.github.com/users/edgarriba/events{/privacy}","received_events_url":"https://api.github.com/users/edgarriba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgarriba/tiny-cnn","description":"header only, dependency-free deep learning framework in C++11","fork":true,"url":"https://api.github.com/repos/edgarriba/tiny-cnn","forks_url":"https://api.github.com/repos/edgarriba/tiny-cnn/forks","keys_url":"https://api.github.com/repos/edgarriba/tiny-cnn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgarriba/tiny-cnn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgarriba/tiny-cnn/teams","hooks_url":"https://api.github.com/repos/edgarriba/tiny-cnn/hooks","issue_events_url":"https://api.github.com/repos/edgarriba/tiny-cnn/issues/events{/number}","events_url":"https://api.github.com/repos/edgarriba/tiny-cnn/events","assignees_url":"https://api.github.com/repos/edgarriba/tiny-cnn/assignees{/user}","branches_url":"https://api.github.com/repos/edgarriba/tiny-cnn/branches{/branch}","tags_url":"https://api.github.com/repos/edgarriba/tiny-cnn/tags","blobs_url":"https://api.github.com/repos/edgarriba/tiny-cnn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgarriba/tiny-cnn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgarriba/tiny-cnn/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgarriba/tiny-cnn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgarriba/tiny-cnn/statuses/{sha}","languages_url":"https://api.github.com/repos/edgarriba/tiny-cnn/languages","stargazers_url":"https://api.github.com/repos/edgarriba/tiny-cnn/stargazers","contributors_url":"https://api.github.com/repos/edgarriba/tiny-cnn/contributors","subscribers_url":"https://api.github.com/repos/edgarriba/tiny-cnn/subscribers","subscription_url":"https://api.github.com/repos/edgarriba/tiny-cnn/subscription","commits_url":"https://api.github.com/repos/edgarriba/tiny-cnn/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgarriba/tiny-cnn/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgarriba/tiny-cnn/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgarriba/tiny-cnn/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgarriba/tiny-cnn/contents/{+path}","compare_url":"https://api.github.com/repos/edgarriba/tiny-cnn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgarriba/tiny-cnn/merges","archive_url":"https://api.github.com/repos/edgarriba/tiny-cnn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgarriba/tiny-cnn/downloads","issues_url":"https://api.github.com/repos/edgarriba/tiny-cnn/issues{/number}","pulls_url":"https://api.github.com/repos/edgarriba/tiny-cnn/pulls{/number}","milestones_url":"https://api.github.com/repos/edgarriba/tiny-cnn/milestones{/number}","notifications_url":"https://api.github.com/repos/edgarriba/tiny-cnn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgarriba/tiny-cnn/labels{/name}","releases_url":"https://api.github.com/repos/edgarriba/tiny-cnn/releases{/id}","deployments_url":"https://api.github.com/repos/edgarriba/tiny-cnn/deployments","created_at":"2016-04-23T06:43:16Z","updated_at":"2016-08-12T15:57:11Z","pushed_at":"2016-09-06T15:12:50Z","git_url":"git://github.com/edgarriba/tiny-cnn.git","ssh_url":"git@github.com:edgarriba/tiny-cnn.git","clone_url":"https://github.com/edgarriba/tiny-cnn.git","svn_url":"https://github.com/edgarriba/tiny-cnn","homepage":"","size":16610,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tiny-dnn:master","ref":"master","sha":"23aab6c3398ce0a99cdb6faaab2e2c5e78f4bba6","user":{"login":"tiny-dnn","id":20644649,"avatar_url":"https://avatars.githubusercontent.com/u/20644649?v=3","gravatar_id":"","url":"https://api.github.com/users/tiny-dnn","html_url":"https://github.com/tiny-dnn","followers_url":"https://api.github.com/users/tiny-dnn/followers","following_url":"https://api.github.com/users/tiny-dnn/following{/other_user}","gists_url":"https://api.github.com/users/tiny-dnn/gists{/gist_id}","starred_url":"https://api.github.com/users/tiny-dnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiny-dnn/subscriptions","organizations_url":"https://api.github.com/users/tiny-dnn/orgs","repos_url":"https://api.github.com/users/tiny-dnn/repos","events_url":"https://api.github.com/users/tiny-dnn/events{/privacy}","received_events_url":"https://api.github.com/users/tiny-dnn/received_events","type":"Organization","site_admin":false},"repo":{"id":7205740,"name":"tiny-dnn","full_name":"tiny-dnn/tiny-dnn","owner":{"login":"tiny-dnn","id":20644649,"avatar_url":"https://avatars.githubusercontent.com/u/20644649?v=3","gravatar_id":"","url":"https://api.github.com/users/tiny-dnn","html_url":"https://github.com/tiny-dnn","followers_url":"https://api.github.com/users/tiny-dnn/followers","following_url":"https://api.github.com/users/tiny-dnn/following{/other_user}","gists_url":"https://api.github.com/users/tiny-dnn/gists{/gist_id}","starred_url":"https://api.github.com/users/tiny-dnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiny-dnn/subscriptions","organizations_url":"https://api.github.com/users/tiny-dnn/orgs","repos_url":"https://api.github.com/users/tiny-dnn/repos","events_url":"https://api.github.com/users/tiny-dnn/events{/privacy}","received_events_url":"https://api.github.com/users/tiny-dnn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tiny-dnn/tiny-dnn","description":"header only, dependency-free deep learning framework in C++11","fork":false,"url":"https://api.github.com/repos/tiny-dnn/tiny-dnn","forks_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/forks","keys_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/teams","hooks_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/hooks","issue_events_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/issues/events{/number}","events_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/events","assignees_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/assignees{/user}","branches_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/branches{/branch}","tags_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/tags","blobs_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/statuses/{sha}","languages_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/languages","stargazers_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/stargazers","contributors_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/contributors","subscribers_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/subscribers","subscription_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/subscription","commits_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/contents/{+path}","compare_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/merges","archive_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/downloads","issues_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/issues{/number}","pulls_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls{/number}","milestones_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/milestones{/number}","notifications_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/labels{/name}","releases_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/releases{/id}","deployments_url":"https://api.github.com/repos/tiny-dnn/tiny-dnn/deployments","created_at":"2012-12-17T14:08:06Z","updated_at":"2016-09-06T12:30:07Z","pushed_at":"2016-09-06T15:39:30Z","git_url":"git://github.com/tiny-dnn/tiny-dnn.git","ssh_url":"git@github.com:tiny-dnn/tiny-dnn.git","clone_url":"https://github.com/tiny-dnn/tiny-dnn.git","svn_url":"https://github.com/tiny-dnn/tiny-dnn","homepage":"","size":43110,"stargazers_count":1241,"watchers_count":1241,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":435,"mirror_url":null,"open_issues_count":99,"forks":435,"open_issues":99,"watchers":1241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298"},"html":{"href":"https://github.com/tiny-dnn/tiny-dnn/pull/298"},"issue":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/issues/298"},"comments":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/tiny-dnn/tiny-dnn/statuses/54fb968570183cbcbabcaf0acd4a7202766efb7b"}}}}
{"actor":{"display_login":"nyanp"}}