{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/3343","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/3343/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/3343/comments","events_url":"https://api.github.com/repos/apple/swift/issues/3343/events","html_url":"https://github.com/apple/swift/pull/3343","id":163834501,"number":3343,"title":"Glibc validation test now performed also on FreeBSD","user":{"login":"uraimo","id":181436,"avatar_url":"https://avatars.githubusercontent.com/u/181436?v=3","gravatar_id":"","url":"https://api.github.com/users/uraimo","html_url":"https://github.com/uraimo","followers_url":"https://api.github.com/users/uraimo/followers","following_url":"https://api.github.com/users/uraimo/following{/other_user}","gists_url":"https://api.github.com/users/uraimo/gists{/gist_id}","starred_url":"https://api.github.com/users/uraimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uraimo/subscriptions","organizations_url":"https://api.github.com/users/uraimo/orgs","repos_url":"https://api.github.com/users/uraimo/repos","events_url":"https://api.github.com/users/uraimo/events{/privacy}","received_events_url":"https://api.github.com/users/uraimo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-05T12:02:13Z","updated_at":"2016-07-05T13:58:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3343","html_url":"https://github.com/apple/swift/pull/3343","diff_url":"https://github.com/apple/swift/pull/3343.diff","patch_url":"https://github.com/apple/swift/pull/3343.patch"},"body":"#### What's in this pull request?\r\n\r\nAs discussed in #3276, the glibc validation tests could be performed at least on FreeBSD too, this PR removes the requirement for a Linux OS. \r\nI didn't build on FreeBSD but I've verified these two tests with a small c program, so both should pass (closing an invalid fd gives EBADF, presence of the TIOCGWINSZ tty ioctl constant).\r\nCouldn't verify it on Android (and that's why it's not included here) since i don't have a device ATM, but both tests should pass.\r\n\r\n* * * *\r\n\r\n<!-- This selection should only be completed by Swift admin -->\r\nBefore merging this pull request to apple/swift repository:\r\n- [x] Test pull request on Swift continuous integration.\r\n\r\n<details>\r\n  <summary>Triggering Swift CI</summary>\r\n\r\nThe swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:\r\n\r\n**Smoke Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please smoke test\r\n        All supported platforms     | @swift-ci Please smoke test and merge\r\n        OS X platform               | @swift-ci Please smoke test OS X platform\r\n        Linux platform              | @swift-ci Please smoke test Linux platform\r\n\r\n**Validation Testing**\r\n\r\n        Platform     | Comment\r\n        ------------ | -------------\r\n        All supported platforms     | @swift-ci Please test\r\n        All supported platforms     | @swift-ci Please test and merge\r\n        OS X platform               | @swift-ci Please test OS X platform\r\n        OS X platform               | @swift-ci Please benchmark\r\n        Linux platform              | @swift-ci Please test Linux platform\r\n\r\n\r\n**Lint Testing**\r\n\r\n        Language     | Comment\r\n        ------------ | -------------\r\n        Python       | @swift-ci Please Python lint\r\n\r\nNote: Only members of the Apple organization can trigger swift-ci.\r\n</details>\r\n<!-- Thank you for your contribution to Swift! -->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/230485867","html_url":"https://github.com/apple/swift/pull/3343#issuecomment-230485867","issue_url":"https://api.github.com/repos/apple/swift/issues/3343","id":230485867,"user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T13:58:45Z","updated_at":"2016-07-05T13:58:45Z","body":"Awesome, thanks @uraimo! I'll give it a try on Android and submit a follow-up pull request soon.\r\n\r\n@swift-ci please test and merge"}}
{"actor":{"display_login":"modocache"}}