{"action":"created","comment":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/76524736","id":76524736,"diff_hunk":"@@ -591,14 +616,32 @@ return( calloc(1,sizeof(SplineChar *)) );\n return( glyphs );\n }\n \n+static SplineChar **TTFGlyphsFromNames(SplineFont *sf,char *names) {","path":"fontforge/tottfgpos.c","position":108,"original_position":108,"commit_id":"bccbc6aeefb56f2420e46efa580840979cf5bff4","original_commit_id":"bccbc6aeefb56f2420e46efa580840979cf5bff4","user":{"login":"frank-trampe","id":2512464,"avatar_url":"https://avatars.githubusercontent.com/u/2512464?v=3","gravatar_id":"","url":"https://api.github.com/users/frank-trampe","html_url":"https://github.com/frank-trampe","followers_url":"https://api.github.com/users/frank-trampe/followers","following_url":"https://api.github.com/users/frank-trampe/following{/other_user}","gists_url":"https://api.github.com/users/frank-trampe/gists{/gist_id}","starred_url":"https://api.github.com/users/frank-trampe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frank-trampe/subscriptions","organizations_url":"https://api.github.com/users/frank-trampe/orgs","repos_url":"https://api.github.com/users/frank-trampe/repos","events_url":"https://api.github.com/users/frank-trampe/events{/privacy}","received_events_url":"https://api.github.com/users/frank-trampe/received_events","type":"User","site_admin":false},"body":"And I definitely need to add a comment explaining what this function does. It is a wrapper for SFGlyphsFromNames that forwards only glyphs with valid TrueType encodings. Which, when we're exporting to TrueType, is all we need and all we can do safely.\r\n","created_at":"2016-08-28T01:51:37Z","updated_at":"2016-08-28T01:51:37Z","html_url":"https://github.com/fontforge/fontforge/pull/2781#discussion_r76524736","pull_request_url":"https://api.github.com/repos/fontforge/fontforge/pulls/2781","_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments/76524736"},"html":{"href":"https://github.com/fontforge/fontforge/pull/2781#discussion_r76524736"},"pull_request":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2781"}}},"pull_request":{"url":"https://api.github.com/repos/fontforge/fontforge/pulls/2781","id":82270514,"html_url":"https://github.com/fontforge/fontforge/pull/2781","diff_url":"https://github.com/fontforge/fontforge/pull/2781.diff","patch_url":"https://github.com/fontforge/fontforge/pull/2781.patch","issue_url":"https://api.github.com/repos/fontforge/fontforge/issues/2781","number":2781,"state":"open","locked":false,"title":"Fix a few crashes relating to empty/invalid lookups.","user":{"login":"frank-trampe","id":2512464,"avatar_url":"https://avatars.githubusercontent.com/u/2512464?v=3","gravatar_id":"","url":"https://api.github.com/users/frank-trampe","html_url":"https://github.com/frank-trampe","followers_url":"https://api.github.com/users/frank-trampe/followers","following_url":"https://api.github.com/users/frank-trampe/following{/other_user}","gists_url":"https://api.github.com/users/frank-trampe/gists{/gist_id}","starred_url":"https://api.github.com/users/frank-trampe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frank-trampe/subscriptions","organizations_url":"https://api.github.com/users/frank-trampe/orgs","repos_url":"https://api.github.com/users/frank-trampe/repos","events_url":"https://api.github.com/users/frank-trampe/events{/privacy}","received_events_url":"https://api.github.com/users/frank-trampe/received_events","type":"User","site_admin":false},"body":"This branch still requires testing. Wait for Frank to merge.\r\n\r\nProvide a general summary of your changes in the **Title** above.\r\n\r\n### Important\r\nMark with [x] to select. Leave as [ ] to unselect.\r\n\r\n### Motivation and Context\r\n- [x] Why is this change required? What problem does it solve?\r\n\r\nThis fixes a crash reported by @pmjdebruijn when exporting to OpenType after subsetting a typeface.\r\n\r\n- [ ] If it fixes an open issue, include the text `Closes #1` (where 1 would be the issue number) to your commit message.\r\n\r\n### Types of changes\r\nWhat types of changes does your code introduce? Check all the boxes that apply:\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Description\r\n- [ ] Describe your changes in detail.\r\n\r\n### Final checklist\r\nGo over all the following points and check all the boxes that apply. \r\nIf you're unsure about any of these, don't hesitate to ask. We're here to help! Various areas of the codebase have been worked on by different people in recent years, so if you are unfamiliar with the general area you're working in, please feel free to chat with people who have experience in that area. See the list [here](https://github.com/fontforge/fontforge/blob/master/CONTRIBUTING.md#people-to-ask).\r\n- [ ] My code follows the code style of this project found [here](https://github.com/fontforge/fontforge/blob/master/CONTRIBUTING.md#coding-style).\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the [**CONTRIBUTING**](https://github.com/fontforge/fontforge/blob/master/CONTRIBUTING.md) guidelines.\r\n\r\nYour pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. FontForge is a big program, so Travis can easily take over 20 minutes to confirm your changes are buildable. Please be patient. More details about using Travis can be found [here](https://github.com/fontforge/fontforge/blob/master/CONTRIBUTING.md#using-travis-ci).  \r\n  \r\nIf it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. If no error is shown, just re-run the Travis test for your pull-request (that failed) to see a fresh report since the last report may be for someone else that did a later pull request, or for mainline code. If you add new code to fix your issue/problem, then take note that you need to check the next pull request in the Travis system. Travis issue numbers are different from GitHub issue numbers.\r\n\r\n","created_at":"2016-08-22T21:55:47Z","updated_at":"2016-08-28T01:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"406fccc873fa98ebd1337b31bd6743c553380d34","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fontforge/fontforge/pulls/2781/commits","review_comments_url":"https://api.github.com/repos/fontforge/fontforge/pulls/2781/comments","review_comment_url":"https://api.github.com/repos/fontforge/fontforge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fontforge/fontforge/issues/2781/comments","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/bccbc6aeefb56f2420e46efa580840979cf5bff4","head":{"label":"fontforge:subset_reference_crash_1_1","ref":"subset_reference_crash_1_1","sha":"bccbc6aeefb56f2420e46efa580840979cf5bff4","user":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=3","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"repo":{"id":5390156,"name":"fontforge","full_name":"fontforge/fontforge","owner":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=3","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fontforge/fontforge","description":"Free (libre) font editor for Windows, Mac OS X and GNU+Linux","fork":false,"url":"https://api.github.com/repos/fontforge/fontforge","forks_url":"https://api.github.com/repos/fontforge/fontforge/forks","keys_url":"https://api.github.com/repos/fontforge/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fontforge/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fontforge/fontforge/teams","hooks_url":"https://api.github.com/repos/fontforge/fontforge/hooks","issue_events_url":"https://api.github.com/repos/fontforge/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/fontforge/fontforge/events","assignees_url":"https://api.github.com/repos/fontforge/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/fontforge/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/fontforge/fontforge/tags","blobs_url":"https://api.github.com/repos/fontforge/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fontforge/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fontforge/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/fontforge/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/fontforge/fontforge/languages","stargazers_url":"https://api.github.com/repos/fontforge/fontforge/stargazers","contributors_url":"https://api.github.com/repos/fontforge/fontforge/contributors","subscribers_url":"https://api.github.com/repos/fontforge/fontforge/subscribers","subscription_url":"https://api.github.com/repos/fontforge/fontforge/subscription","commits_url":"https://api.github.com/repos/fontforge/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/fontforge/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/fontforge/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/fontforge/fontforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/fontforge/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/fontforge/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fontforge/fontforge/merges","archive_url":"https://api.github.com/repos/fontforge/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fontforge/fontforge/downloads","issues_url":"https://api.github.com/repos/fontforge/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/fontforge/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/fontforge/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/fontforge/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fontforge/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/fontforge/fontforge/releases{/id}","deployments_url":"https://api.github.com/repos/fontforge/fontforge/deployments","created_at":"2012-08-12T17:08:20Z","updated_at":"2016-08-27T08:54:08Z","pushed_at":"2016-08-28T00:32:40Z","git_url":"git://github.com/fontforge/fontforge.git","ssh_url":"git@github.com:fontforge/fontforge.git","clone_url":"https://github.com/fontforge/fontforge.git","svn_url":"https://github.com/fontforge/fontforge","homepage":"http://fontforge.github.io/","size":89689,"stargazers_count":1113,"watchers_count":1113,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":232,"mirror_url":null,"open_issues_count":748,"forks":232,"open_issues":748,"watchers":1113,"default_branch":"master"}},"base":{"label":"fontforge:master","ref":"master","sha":"cf2de9661debc969e6978c50a48ab804673771cc","user":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=3","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"repo":{"id":5390156,"name":"fontforge","full_name":"fontforge/fontforge","owner":{"login":"fontforge","id":2048660,"avatar_url":"https://avatars.githubusercontent.com/u/2048660?v=3","gravatar_id":"","url":"https://api.github.com/users/fontforge","html_url":"https://github.com/fontforge","followers_url":"https://api.github.com/users/fontforge/followers","following_url":"https://api.github.com/users/fontforge/following{/other_user}","gists_url":"https://api.github.com/users/fontforge/gists{/gist_id}","starred_url":"https://api.github.com/users/fontforge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fontforge/subscriptions","organizations_url":"https://api.github.com/users/fontforge/orgs","repos_url":"https://api.github.com/users/fontforge/repos","events_url":"https://api.github.com/users/fontforge/events{/privacy}","received_events_url":"https://api.github.com/users/fontforge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fontforge/fontforge","description":"Free (libre) font editor for Windows, Mac OS X and GNU+Linux","fork":false,"url":"https://api.github.com/repos/fontforge/fontforge","forks_url":"https://api.github.com/repos/fontforge/fontforge/forks","keys_url":"https://api.github.com/repos/fontforge/fontforge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fontforge/fontforge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fontforge/fontforge/teams","hooks_url":"https://api.github.com/repos/fontforge/fontforge/hooks","issue_events_url":"https://api.github.com/repos/fontforge/fontforge/issues/events{/number}","events_url":"https://api.github.com/repos/fontforge/fontforge/events","assignees_url":"https://api.github.com/repos/fontforge/fontforge/assignees{/user}","branches_url":"https://api.github.com/repos/fontforge/fontforge/branches{/branch}","tags_url":"https://api.github.com/repos/fontforge/fontforge/tags","blobs_url":"https://api.github.com/repos/fontforge/fontforge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fontforge/fontforge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fontforge/fontforge/git/refs{/sha}","trees_url":"https://api.github.com/repos/fontforge/fontforge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fontforge/fontforge/statuses/{sha}","languages_url":"https://api.github.com/repos/fontforge/fontforge/languages","stargazers_url":"https://api.github.com/repos/fontforge/fontforge/stargazers","contributors_url":"https://api.github.com/repos/fontforge/fontforge/contributors","subscribers_url":"https://api.github.com/repos/fontforge/fontforge/subscribers","subscription_url":"https://api.github.com/repos/fontforge/fontforge/subscription","commits_url":"https://api.github.com/repos/fontforge/fontforge/commits{/sha}","git_commits_url":"https://api.github.com/repos/fontforge/fontforge/git/commits{/sha}","comments_url":"https://api.github.com/repos/fontforge/fontforge/comments{/number}","issue_comment_url":"https://api.github.com/repos/fontforge/fontforge/issues/comments{/number}","contents_url":"https://api.github.com/repos/fontforge/fontforge/contents/{+path}","compare_url":"https://api.github.com/repos/fontforge/fontforge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fontforge/fontforge/merges","archive_url":"https://api.github.com/repos/fontforge/fontforge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fontforge/fontforge/downloads","issues_url":"https://api.github.com/repos/fontforge/fontforge/issues{/number}","pulls_url":"https://api.github.com/repos/fontforge/fontforge/pulls{/number}","milestones_url":"https://api.github.com/repos/fontforge/fontforge/milestones{/number}","notifications_url":"https://api.github.com/repos/fontforge/fontforge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fontforge/fontforge/labels{/name}","releases_url":"https://api.github.com/repos/fontforge/fontforge/releases{/id}","deployments_url":"https://api.github.com/repos/fontforge/fontforge/deployments","created_at":"2012-08-12T17:08:20Z","updated_at":"2016-08-27T08:54:08Z","pushed_at":"2016-08-28T00:32:40Z","git_url":"git://github.com/fontforge/fontforge.git","ssh_url":"git@github.com:fontforge/fontforge.git","clone_url":"https://github.com/fontforge/fontforge.git","svn_url":"https://github.com/fontforge/fontforge","homepage":"http://fontforge.github.io/","size":89689,"stargazers_count":1113,"watchers_count":1113,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":232,"mirror_url":null,"open_issues_count":748,"forks":232,"open_issues":748,"watchers":1113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2781"},"html":{"href":"https://github.com/fontforge/fontforge/pull/2781"},"issue":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/2781"},"comments":{"href":"https://api.github.com/repos/fontforge/fontforge/issues/2781/comments"},"review_comments":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2781/comments"},"review_comment":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fontforge/fontforge/pulls/2781/commits"},"statuses":{"href":"https://api.github.com/repos/fontforge/fontforge/statuses/bccbc6aeefb56f2420e46efa580840979cf5bff4"}}}}
{"actor":{"display_login":"frank-trampe"}}