{"action":"created","issue":{"url":"https://api.github.com/repos/haringsrob/commerce/issues/1","repository_url":"https://api.github.com/repos/haringsrob/commerce","labels_url":"https://api.github.com/repos/haringsrob/commerce/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/haringsrob/commerce/issues/1/comments","events_url":"https://api.github.com/repos/haringsrob/commerce/issues/1/events","html_url":"https://github.com/haringsrob/commerce/pull/1","id":143694361,"number":1,"title":"implement recommendations from PR review https://www.drupal.org/node/…","user":{"login":"agoradesign","id":5078744,"avatar_url":"https://avatars.githubusercontent.com/u/5078744?v=3","gravatar_id":"","url":"https://api.github.com/users/agoradesign","html_url":"https://github.com/agoradesign","followers_url":"https://api.github.com/users/agoradesign/followers","following_url":"https://api.github.com/users/agoradesign/following{/other_user}","gists_url":"https://api.github.com/users/agoradesign/gists{/gist_id}","starred_url":"https://api.github.com/users/agoradesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoradesign/subscriptions","organizations_url":"https://api.github.com/users/agoradesign/orgs","repos_url":"https://api.github.com/users/agoradesign/repos","events_url":"https://api.github.com/users/agoradesign/events{/privacy}","received_events_url":"https://api.github.com/users/agoradesign/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-26T11:47:16Z","updated_at":"2016-03-27T14:18:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/haringsrob/commerce/pulls/1","html_url":"https://github.com/haringsrob/commerce/pull/1","diff_url":"https://github.com/haringsrob/commerce/pull/1.diff","patch_url":"https://github.com/haringsrob/commerce/pull/1.patch"},"body":"…2674888#comment-10987951\r\n\r\nHi Rob,\r\nI've implemented the recommendations from Matt (https://www.drupal.org/node/2674888#comment-10987951). All changes SHOULD work, I didn't have time to run the code.\r\n\r\nYour PR is not in sync with the master branch at the moment - also didn't have time to sync your changes with master before. However it should be a better help for you rather than only writing a comment...\r\n\r\nI've put the CANONICAL_QUERY_PARAM constant into the ProductVariationInterface. However I'm not happy with that either. This is cleaner than just the string and makes it easier to replace, however it's still unflexible. What do you think about adding a (static) function, that returns 'dv' just for now. So there won't be an API change, when e.g. a configuration will be introduced in future, or an alter hook.."},"comment":{"url":"https://api.github.com/repos/haringsrob/commerce/issues/comments/202071590","html_url":"https://github.com/haringsrob/commerce/pull/1#issuecomment-202071590","issue_url":"https://api.github.com/repos/haringsrob/commerce/issues/1","id":202071590,"user":{"login":"haringsrob","id":866743,"avatar_url":"https://avatars.githubusercontent.com/u/866743?v=3","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"created_at":"2016-03-27T14:18:54Z","updated_at":"2016-03-27T14:18:54Z","body":"Hi,\r\n\r\nI'll test this maybe tonight, otherwise tomorrow. Thanks!"}}