{"action":"created","issue":{"url":"https://api.github.com/repos/Tonejs/Tone.js/issues/172","repository_url":"https://api.github.com/repos/Tonejs/Tone.js","labels_url":"https://api.github.com/repos/Tonejs/Tone.js/issues/172/labels{/name}","comments_url":"https://api.github.com/repos/Tonejs/Tone.js/issues/172/comments","events_url":"https://api.github.com/repos/Tonejs/Tone.js/issues/172/events","html_url":"https://github.com/Tonejs/Tone.js/issues/172","id":183803999,"number":172,"title":"Using 'set' on an instrument that contains a PolySynth does not work correctly","user":{"login":"gerardabello","id":2431197,"avatar_url":"https://avatars.githubusercontent.com/u/2431197?v=3","gravatar_id":"","url":"https://api.github.com/users/gerardabello","html_url":"https://github.com/gerardabello","followers_url":"https://api.github.com/users/gerardabello/followers","following_url":"https://api.github.com/users/gerardabello/following{/other_user}","gists_url":"https://api.github.com/users/gerardabello/gists{/gist_id}","starred_url":"https://api.github.com/users/gerardabello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerardabello/subscriptions","organizations_url":"https://api.github.com/users/gerardabello/orgs","repos_url":"https://api.github.com/users/gerardabello/repos","events_url":"https://api.github.com/users/gerardabello/events{/privacy}","received_events_url":"https://api.github.com/users/gerardabello/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-18T21:10:36Z","updated_at":"2016-10-19T19:11:39Z","closed_at":null,"body":"I created simple class that extends Tone.Instrument that contains a Tone.PolySynth (called `this.voice`) and some effects. Using the default `set` method, I cannot do `set('voice.detune', 10)` because `voice.detune` does not exist (it exists on the underlying instrument, but not in the PolySynth itself). You can manually call `voice.set('detune',10)` because the `set` method of PolySynth understands that you want to update all the underlying voices, but it is not used if you wrap the PolySynth inside another instrument.\r\n\r\nI am doing something wrong or this can be improved?\r\n\r\nI have a solution but I'm not sure if this is an issue or not."},"comment":{"url":"https://api.github.com/repos/Tonejs/Tone.js/issues/comments/254911744","html_url":"https://github.com/Tonejs/Tone.js/issues/172#issuecomment-254911744","issue_url":"https://api.github.com/repos/Tonejs/Tone.js/issues/172","id":254911744,"user":{"login":"tambien","id":1323402,"avatar_url":"https://avatars.githubusercontent.com/u/1323402?v=3","gravatar_id":"","url":"https://api.github.com/users/tambien","html_url":"https://github.com/tambien","followers_url":"https://api.github.com/users/tambien/followers","following_url":"https://api.github.com/users/tambien/following{/other_user}","gists_url":"https://api.github.com/users/tambien/gists{/gist_id}","starred_url":"https://api.github.com/users/tambien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tambien/subscriptions","organizations_url":"https://api.github.com/users/tambien/orgs","repos_url":"https://api.github.com/users/tambien/repos","events_url":"https://api.github.com/users/tambien/events{/privacy}","received_events_url":"https://api.github.com/users/tambien/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T19:11:39Z","updated_at":"2016-10-19T19:11:39Z","body":"Not sure off the top of my head why this wouldn't work. There is one small particularity with PolySynth.set that you mentioned. it is different than the other `set` methods which all inherit from the same place. PolySynth's `set` method has to iterate over all of it's voices. \r\n\r\nit'd be great to see your solution."}}
{"actor":{"display_login":"tambien"}}