{"action":"created","comment":{"url":"https://api.github.com/repos/zopefoundation/ZODB/pulls/comments/70470547","id":70470547,"diff_hunk":"@@ -113,18 +113,24 @@ def handle_all_serials(oid, *args):\n \n     The original interface just returned the serialno for the\n     object.\n+\n+    The updated multi-commit API returns nothing from store(), and\n+    returns a sequence of resolved oids from tpc_vote.\n     \"\"\"\n     d = {}\n     for arg in args:\n         if isinstance(arg, bytes):\n             d[oid] = arg\n-        elif arg is None:\n-            pass\n-        else:\n-            for oid, serial in arg:\n-                if not isinstance(serial, bytes):\n-                    raise serial # error from ZEO server\n-                d[oid] = serial\n+        elif arg:\n+            for t in arg:\n+                if isinstance(t, bytes):\n+                    # This will be the tid returned by tpc_finish.","path":"src/ZODB/tests/StorageTestBase.py","position":22,"original_position":22,"commit_id":"87748b157fa749a848fece3b11b2489a4dc80d0b","original_commit_id":"87748b157fa749a848fece3b11b2489a4dc80d0b","user":{"login":"jimfulton","id":772727,"avatar_url":"https://avatars.githubusercontent.com/u/772727?v=3","gravatar_id":"","url":"https://api.github.com/users/jimfulton","html_url":"https://github.com/jimfulton","followers_url":"https://api.github.com/users/jimfulton/followers","following_url":"https://api.github.com/users/jimfulton/following{/other_user}","gists_url":"https://api.github.com/users/jimfulton/gists{/gist_id}","starred_url":"https://api.github.com/users/jimfulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimfulton/subscriptions","organizations_url":"https://api.github.com/users/jimfulton/orgs","repos_url":"https://api.github.com/users/jimfulton/repos","events_url":"https://api.github.com/users/jimfulton/events{/privacy}","received_events_url":"https://api.github.com/users/jimfulton/received_events","type":"User","site_admin":false},"body":"The right thing to do would be to look at the call points and decide WTF.\r\n\r\nGiven that this is the 4 branch, I guess I'd be willing to accept this if the tests pass and if we leave an XXX comment here saying that the this should get another review after reviewing the call points.","created_at":"2016-07-12T16:14:36Z","updated_at":"2016-07-12T16:14:36Z","html_url":"https://github.com/zopefoundation/ZODB/pull/86#discussion_r70470547","pull_request_url":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/ZODB/pulls/comments/70470547"},"html":{"href":"https://github.com/zopefoundation/ZODB/pull/86#discussion_r70470547"},"pull_request":{"href":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86","id":76854577,"html_url":"https://github.com/zopefoundation/ZODB/pull/86","diff_url":"https://github.com/zopefoundation/ZODB/pull/86.diff","patch_url":"https://github.com/zopefoundation/ZODB/pull/86.patch","issue_url":"https://api.github.com/repos/zopefoundation/ZODB/issues/86","number":86,"state":"open","locked":false,"title":"Fix handle_all_serials for the new and old protocols.","user":{"login":"jamadden","id":1256082,"avatar_url":"https://avatars.githubusercontent.com/u/1256082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamadden","html_url":"https://github.com/jamadden","followers_url":"https://api.github.com/users/jamadden/followers","following_url":"https://api.github.com/users/jamadden/following{/other_user}","gists_url":"https://api.github.com/users/jamadden/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadden/subscriptions","organizations_url":"https://api.github.com/users/jamadden/orgs","repos_url":"https://api.github.com/users/jamadden/repos","events_url":"https://api.github.com/users/jamadden/events{/privacy}","received_events_url":"https://api.github.com/users/jamadden/received_events","type":"User","site_admin":false},"body":"Same as #85 but for ZODB 4.","created_at":"2016-07-09T19:11:37Z","updated_at":"2016-07-12T16:14:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"592240fb1e52be8d70e56423a882d248272a687d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86/commits","review_comments_url":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86/comments","review_comment_url":"https://api.github.com/repos/zopefoundation/ZODB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zopefoundation/ZODB/issues/86/comments","statuses_url":"https://api.github.com/repos/zopefoundation/ZODB/statuses/87748b157fa749a848fece3b11b2489a4dc80d0b","head":{"label":"NextThought:handle-serials4","ref":"handle-serials4","sha":"87748b157fa749a848fece3b11b2489a4dc80d0b","user":{"login":"NextThought","id":2072248,"avatar_url":"https://avatars.githubusercontent.com/u/2072248?v=3","gravatar_id":"","url":"https://api.github.com/users/NextThought","html_url":"https://github.com/NextThought","followers_url":"https://api.github.com/users/NextThought/followers","following_url":"https://api.github.com/users/NextThought/following{/other_user}","gists_url":"https://api.github.com/users/NextThought/gists{/gist_id}","starred_url":"https://api.github.com/users/NextThought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NextThought/subscriptions","organizations_url":"https://api.github.com/users/NextThought/orgs","repos_url":"https://api.github.com/users/NextThought/repos","events_url":"https://api.github.com/users/NextThought/events{/privacy}","received_events_url":"https://api.github.com/users/NextThought/received_events","type":"Organization","site_admin":false},"repo":{"id":16962967,"name":"ZODB","full_name":"NextThought/ZODB","owner":{"login":"NextThought","id":2072248,"avatar_url":"https://avatars.githubusercontent.com/u/2072248?v=3","gravatar_id":"","url":"https://api.github.com/users/NextThought","html_url":"https://github.com/NextThought","followers_url":"https://api.github.com/users/NextThought/followers","following_url":"https://api.github.com/users/NextThought/following{/other_user}","gists_url":"https://api.github.com/users/NextThought/gists{/gist_id}","starred_url":"https://api.github.com/users/NextThought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NextThought/subscriptions","organizations_url":"https://api.github.com/users/NextThought/orgs","repos_url":"https://api.github.com/users/NextThought/repos","events_url":"https://api.github.com/users/NextThought/events{/privacy}","received_events_url":"https://api.github.com/users/NextThought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NextThought/ZODB","description":"The ZODB object database","fork":true,"url":"https://api.github.com/repos/NextThought/ZODB","forks_url":"https://api.github.com/repos/NextThought/ZODB/forks","keys_url":"https://api.github.com/repos/NextThought/ZODB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NextThought/ZODB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NextThought/ZODB/teams","hooks_url":"https://api.github.com/repos/NextThought/ZODB/hooks","issue_events_url":"https://api.github.com/repos/NextThought/ZODB/issues/events{/number}","events_url":"https://api.github.com/repos/NextThought/ZODB/events","assignees_url":"https://api.github.com/repos/NextThought/ZODB/assignees{/user}","branches_url":"https://api.github.com/repos/NextThought/ZODB/branches{/branch}","tags_url":"https://api.github.com/repos/NextThought/ZODB/tags","blobs_url":"https://api.github.com/repos/NextThought/ZODB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NextThought/ZODB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NextThought/ZODB/git/refs{/sha}","trees_url":"https://api.github.com/repos/NextThought/ZODB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NextThought/ZODB/statuses/{sha}","languages_url":"https://api.github.com/repos/NextThought/ZODB/languages","stargazers_url":"https://api.github.com/repos/NextThought/ZODB/stargazers","contributors_url":"https://api.github.com/repos/NextThought/ZODB/contributors","subscribers_url":"https://api.github.com/repos/NextThought/ZODB/subscribers","subscription_url":"https://api.github.com/repos/NextThought/ZODB/subscription","commits_url":"https://api.github.com/repos/NextThought/ZODB/commits{/sha}","git_commits_url":"https://api.github.com/repos/NextThought/ZODB/git/commits{/sha}","comments_url":"https://api.github.com/repos/NextThought/ZODB/comments{/number}","issue_comment_url":"https://api.github.com/repos/NextThought/ZODB/issues/comments{/number}","contents_url":"https://api.github.com/repos/NextThought/ZODB/contents/{+path}","compare_url":"https://api.github.com/repos/NextThought/ZODB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NextThought/ZODB/merges","archive_url":"https://api.github.com/repos/NextThought/ZODB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NextThought/ZODB/downloads","issues_url":"https://api.github.com/repos/NextThought/ZODB/issues{/number}","pulls_url":"https://api.github.com/repos/NextThought/ZODB/pulls{/number}","milestones_url":"https://api.github.com/repos/NextThought/ZODB/milestones{/number}","notifications_url":"https://api.github.com/repos/NextThought/ZODB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NextThought/ZODB/labels{/name}","releases_url":"https://api.github.com/repos/NextThought/ZODB/releases{/id}","deployments_url":"https://api.github.com/repos/NextThought/ZODB/deployments","created_at":"2014-02-18T20:40:34Z","updated_at":"2015-04-07T17:31:21Z","pushed_at":"2016-07-12T16:11:29Z","git_url":"git://github.com/NextThought/ZODB.git","ssh_url":"git@github.com:NextThought/ZODB.git","clone_url":"https://github.com/NextThought/ZODB.git","svn_url":"https://github.com/NextThought/ZODB","homepage":"www.zodb.org","size":23917,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zopefoundation:4","ref":"4","sha":"45831d69316807fc39c4b0bb5afbfd2586dbda1f","user":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":7357595,"name":"ZODB","full_name":"zopefoundation/ZODB","owner":{"login":"zopefoundation","id":1163184,"avatar_url":"https://avatars.githubusercontent.com/u/1163184?v=3","gravatar_id":"","url":"https://api.github.com/users/zopefoundation","html_url":"https://github.com/zopefoundation","followers_url":"https://api.github.com/users/zopefoundation/followers","following_url":"https://api.github.com/users/zopefoundation/following{/other_user}","gists_url":"https://api.github.com/users/zopefoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/zopefoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zopefoundation/subscriptions","organizations_url":"https://api.github.com/users/zopefoundation/orgs","repos_url":"https://api.github.com/users/zopefoundation/repos","events_url":"https://api.github.com/users/zopefoundation/events{/privacy}","received_events_url":"https://api.github.com/users/zopefoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zopefoundation/ZODB","description":"The ZODB object database","fork":false,"url":"https://api.github.com/repos/zopefoundation/ZODB","forks_url":"https://api.github.com/repos/zopefoundation/ZODB/forks","keys_url":"https://api.github.com/repos/zopefoundation/ZODB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zopefoundation/ZODB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zopefoundation/ZODB/teams","hooks_url":"https://api.github.com/repos/zopefoundation/ZODB/hooks","issue_events_url":"https://api.github.com/repos/zopefoundation/ZODB/issues/events{/number}","events_url":"https://api.github.com/repos/zopefoundation/ZODB/events","assignees_url":"https://api.github.com/repos/zopefoundation/ZODB/assignees{/user}","branches_url":"https://api.github.com/repos/zopefoundation/ZODB/branches{/branch}","tags_url":"https://api.github.com/repos/zopefoundation/ZODB/tags","blobs_url":"https://api.github.com/repos/zopefoundation/ZODB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zopefoundation/ZODB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zopefoundation/ZODB/git/refs{/sha}","trees_url":"https://api.github.com/repos/zopefoundation/ZODB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zopefoundation/ZODB/statuses/{sha}","languages_url":"https://api.github.com/repos/zopefoundation/ZODB/languages","stargazers_url":"https://api.github.com/repos/zopefoundation/ZODB/stargazers","contributors_url":"https://api.github.com/repos/zopefoundation/ZODB/contributors","subscribers_url":"https://api.github.com/repos/zopefoundation/ZODB/subscribers","subscription_url":"https://api.github.com/repos/zopefoundation/ZODB/subscription","commits_url":"https://api.github.com/repos/zopefoundation/ZODB/commits{/sha}","git_commits_url":"https://api.github.com/repos/zopefoundation/ZODB/git/commits{/sha}","comments_url":"https://api.github.com/repos/zopefoundation/ZODB/comments{/number}","issue_comment_url":"https://api.github.com/repos/zopefoundation/ZODB/issues/comments{/number}","contents_url":"https://api.github.com/repos/zopefoundation/ZODB/contents/{+path}","compare_url":"https://api.github.com/repos/zopefoundation/ZODB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zopefoundation/ZODB/merges","archive_url":"https://api.github.com/repos/zopefoundation/ZODB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zopefoundation/ZODB/downloads","issues_url":"https://api.github.com/repos/zopefoundation/ZODB/issues{/number}","pulls_url":"https://api.github.com/repos/zopefoundation/ZODB/pulls{/number}","milestones_url":"https://api.github.com/repos/zopefoundation/ZODB/milestones{/number}","notifications_url":"https://api.github.com/repos/zopefoundation/ZODB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zopefoundation/ZODB/labels{/name}","releases_url":"https://api.github.com/repos/zopefoundation/ZODB/releases{/id}","deployments_url":"https://api.github.com/repos/zopefoundation/ZODB/deployments","created_at":"2012-12-28T17:47:39Z","updated_at":"2016-06-30T04:48:02Z","pushed_at":"2016-07-12T16:11:29Z","git_url":"git://github.com/zopefoundation/ZODB.git","ssh_url":"git@github.com:zopefoundation/ZODB.git","clone_url":"https://github.com/zopefoundation/ZODB.git","svn_url":"https://github.com/zopefoundation/ZODB","homepage":"www.zodb.org","size":27030,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":18,"forks":18,"open_issues":18,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86"},"html":{"href":"https://github.com/zopefoundation/ZODB/pull/86"},"issue":{"href":"https://api.github.com/repos/zopefoundation/ZODB/issues/86"},"comments":{"href":"https://api.github.com/repos/zopefoundation/ZODB/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/zopefoundation/ZODB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zopefoundation/ZODB/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/zopefoundation/ZODB/statuses/87748b157fa749a848fece3b11b2489a4dc80d0b"}}}}
{"actor":{"display_login":"jimfulton"}}