{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/67253586","id":67253586,"diff_hunk":"@@ -1,10 +1,69 @@\n #define LIGHTING_INTERVAL 5 // frequency, in 1/10ths of a second, of the lighting process\n \n+#ifndef LIGHTING_INSTANT_UPDATES\n+#define LIGHTING_INTERVAL       5    // Frequency, in 1/10ths of a second, of the lighting process.\n+#include \"..\\controllers\\Processes\\lighting.dm\"\n+#endif\n+\n #define LIGHTING_FALLOFF 1 // type of falloff to use for lighting; 1 for circular, 2 for square\n #define LIGHTING_LAMBERTIAN 0 // use lambertian shading for light sources\n #define LIGHTING_HEIGHT 1 // height off the ground of light sources on the pseudo-z-axis, you should probably leave this alone\n \n #define LIGHTING_LAYER 10 // drawing layer for lighting overlays\n-#define LIGHTING_ICON 'icons/effects/lighting_overlay.dmi' // icon used for lighting shading effects\n+#define LIGHTING_ICON 'icons/effects/lighting_overlay.png' // icon used for lighting shading effects\n \n #define LIGHTING_ROUND_VALUE (1 / 128) //Value used to round lumcounts, values smaller than 1/255 don't matter (if they do, thanks sinking points), greater values will make lighting less precise, but in turn increase performance, VERY SLIGHTLY.\n+\n+#define LIGHTING_SOFT_THRESHOLD 0.05 // If the max of the lighting lumcounts of each spectrum drops below this, disable luminosity on the lighting overlays.\n+\n+// If I were you I'd leave this alone.\n+#define LIGHTING_BASE_MATRIX \\\n+\tlist                     \\\n+\t(                        \\\n+\t\tLIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, 0, \\\n+\t\tLIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, 0, \\\n+\t\tLIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, 0, \\\n+\t\tLIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, LIGHTING_SOFT_THRESHOLD, 0, \\\n+\t\t0, 0, 0, 1           \\\n+\t)                        \\\n+\n+// Helpers so we can (more easily) control the colour matrices.\n+#define CL_MATRIX_RR 1\n+#define CL_MATRIX_RG 2\n+#define CL_MATRIX_RB 3\n+#define CL_MATRIX_RA 4\n+#define CL_MATRIX_GR 5\n+#define CL_MATRIX_GG 6\n+#define CL_MATRIX_GB 7\n+#define CL_MATRIX_GA 8\n+#define CL_MATRIX_BR 9\n+#define CL_MATRIX_BG 10\n+#define CL_MATRIX_BB 11\n+#define CL_MATRIX_BA 12\n+#define CL_MATRIX_AR 13\n+#define CL_MATRIX_AG 14\n+#define CL_MATRIX_AB 15\n+#define CL_MATRIX_AA 16\n+#define CL_MATRIX_CR 17\n+#define CL_MATRIX_CG 18\n+#define CL_MATRIX_CB 19\n+#define CL_MATRIX_CA 20\n+\n+//Some defines to generalise colours used in lighting.","path":"code/__DEFINES/lighting.dm","position":53,"original_position":53,"commit_id":"f418bac3da0c409f5415844d1a7befb9b3e50c04","original_commit_id":"f418bac3da0c409f5415844d1a7befb9b3e50c04","user":{"login":"tigercat2000","id":10103534,"avatar_url":"https://avatars.githubusercontent.com/u/10103534?v=3","gravatar_id":"","url":"https://api.github.com/users/tigercat2000","html_url":"https://github.com/tigercat2000","followers_url":"https://api.github.com/users/tigercat2000/followers","following_url":"https://api.github.com/users/tigercat2000/following{/other_user}","gists_url":"https://api.github.com/users/tigercat2000/gists{/gist_id}","starred_url":"https://api.github.com/users/tigercat2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigercat2000/subscriptions","organizations_url":"https://api.github.com/users/tigercat2000/orgs","repos_url":"https://api.github.com/users/tigercat2000/repos","events_url":"https://api.github.com/users/tigercat2000/events{/privacy}","received_events_url":"https://api.github.com/users/tigercat2000/received_events","type":"User","site_admin":false},"body":"these are already defined and used in [__DEFINES/misc.dm](https://github.com/ParadiseSS13/Paradise/blob/master/code/__DEFINES/misc.dm#L106-L128)","created_at":"2016-06-15T21:57:16Z","updated_at":"2016-06-15T21:57:16Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/4670#discussion_r67253586","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/67253586"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/4670#discussion_r67253586"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670"}}},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670","id":73764008,"html_url":"https://github.com/ParadiseSS13/Paradise/pull/4670","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/4670.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/4670.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4670","number":4670,"state":"open","locked":false,"title":"[WIP]Porting lighting system from /vg/ (Goonlight)","user":{"login":"Signmark","id":19763675,"avatar_url":"https://avatars.githubusercontent.com/u/19763675?v=3","gravatar_id":"","url":"https://api.github.com/users/Signmark","html_url":"https://github.com/Signmark","followers_url":"https://api.github.com/users/Signmark/followers","following_url":"https://api.github.com/users/Signmark/following{/other_user}","gists_url":"https://api.github.com/users/Signmark/gists{/gist_id}","starred_url":"https://api.github.com/users/Signmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Signmark/subscriptions","organizations_url":"https://api.github.com/users/Signmark/orgs","repos_url":"https://api.github.com/users/Signmark/repos","events_url":"https://api.github.com/users/Signmark/events{/privacy}","received_events_url":"https://api.github.com/users/Signmark/received_events","type":"User","site_admin":false},"body":"TODO:\r\n- [x] Fix the moving shuttle lighting shit (see the last pic below)\r\n- [ ] Find something else to check\r\n\r\nHere comes the Goonlight (thanks to @PJB3005 for this system). Looks amazing!\r\n![image](https://cloud.githubusercontent.com/assets/19763675/16048836/f006c2cc-326e-11e6-961c-7cffd0faa15d.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/19763675/16048894/28c782a4-326f-11e6-8c62-c0f55923f33f.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/19763675/16048902/30e5e9da-326f-11e6-99b0-cce93682c4b2.png)\r\n\r\n\r\nSo now i got only one major bug which is need to be fixed - shuttle turfs turns full dark after moving:\r\n![image](https://cloud.githubusercontent.com/assets/19763675/16048940/54d2effa-326f-11e6-842c-3f7492bbffba.png)\r\n\r\n","created_at":"2016-06-14T15:41:42Z","updated_at":"2016-06-15T21:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1b3ea57e9c6b1a7ec8cdd86a07c7c6b7b2ccd55","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4670/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/f418bac3da0c409f5415844d1a7befb9b3e50c04","head":{"label":"Signmark:goonlight","ref":"goonlight","sha":"f418bac3da0c409f5415844d1a7befb9b3e50c04","user":{"login":"Signmark","id":19763675,"avatar_url":"https://avatars.githubusercontent.com/u/19763675?v=3","gravatar_id":"","url":"https://api.github.com/users/Signmark","html_url":"https://github.com/Signmark","followers_url":"https://api.github.com/users/Signmark/followers","following_url":"https://api.github.com/users/Signmark/following{/other_user}","gists_url":"https://api.github.com/users/Signmark/gists{/gist_id}","starred_url":"https://api.github.com/users/Signmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Signmark/subscriptions","organizations_url":"https://api.github.com/users/Signmark/orgs","repos_url":"https://api.github.com/users/Signmark/repos","events_url":"https://api.github.com/users/Signmark/events{/privacy}","received_events_url":"https://api.github.com/users/Signmark/received_events","type":"User","site_admin":false},"repo":{"id":60471902,"name":"Paradise","full_name":"Signmark/Paradise","owner":{"login":"Signmark","id":19763675,"avatar_url":"https://avatars.githubusercontent.com/u/19763675?v=3","gravatar_id":"","url":"https://api.github.com/users/Signmark","html_url":"https://github.com/Signmark","followers_url":"https://api.github.com/users/Signmark/followers","following_url":"https://api.github.com/users/Signmark/following{/other_user}","gists_url":"https://api.github.com/users/Signmark/gists{/gist_id}","starred_url":"https://api.github.com/users/Signmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Signmark/subscriptions","organizations_url":"https://api.github.com/users/Signmark/orgs","repos_url":"https://api.github.com/users/Signmark/repos","events_url":"https://api.github.com/users/Signmark/events{/privacy}","received_events_url":"https://api.github.com/users/Signmark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Signmark/Paradise","description":"Paradise Station's GitHub main repository.","fork":true,"url":"https://api.github.com/repos/Signmark/Paradise","forks_url":"https://api.github.com/repos/Signmark/Paradise/forks","keys_url":"https://api.github.com/repos/Signmark/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Signmark/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Signmark/Paradise/teams","hooks_url":"https://api.github.com/repos/Signmark/Paradise/hooks","issue_events_url":"https://api.github.com/repos/Signmark/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/Signmark/Paradise/events","assignees_url":"https://api.github.com/repos/Signmark/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/Signmark/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/Signmark/Paradise/tags","blobs_url":"https://api.github.com/repos/Signmark/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Signmark/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Signmark/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/Signmark/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Signmark/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/Signmark/Paradise/languages","stargazers_url":"https://api.github.com/repos/Signmark/Paradise/stargazers","contributors_url":"https://api.github.com/repos/Signmark/Paradise/contributors","subscribers_url":"https://api.github.com/repos/Signmark/Paradise/subscribers","subscription_url":"https://api.github.com/repos/Signmark/Paradise/subscription","commits_url":"https://api.github.com/repos/Signmark/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/Signmark/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/Signmark/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/Signmark/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/Signmark/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/Signmark/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Signmark/Paradise/merges","archive_url":"https://api.github.com/repos/Signmark/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Signmark/Paradise/downloads","issues_url":"https://api.github.com/repos/Signmark/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/Signmark/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/Signmark/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/Signmark/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Signmark/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/Signmark/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/Signmark/Paradise/deployments","created_at":"2016-06-05T17:23:17Z","updated_at":"2016-06-05T17:23:29Z","pushed_at":"2016-06-15T21:08:53Z","git_url":"git://github.com/Signmark/Paradise.git","ssh_url":"git@github.com:Signmark/Paradise.git","clone_url":"https://github.com/Signmark/Paradise.git","svn_url":"https://github.com/Signmark/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":859035,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"c4fcb00da2b4bb69f94a723a2188ee3d95e002a2","user":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"name":"Paradise","full_name":"ParadiseSS13/Paradise","owner":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2016-06-04T16:53:28Z","pushed_at":"2016-06-15T21:32:04Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":934874,"stargazers_count":62,"watchers_count":62,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":172,"mirror_url":null,"open_issues_count":282,"forks":172,"open_issues":282,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/4670"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4670"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4670/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4670/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/f418bac3da0c409f5415844d1a7befb9b3e50c04"}}}}
{"actor":{"display_login":"tigercat2000"}}