{"action":"created","comment":{"url":"https://api.github.com/repos/j-delaney/planner-helper/pulls/comments/74712709","id":74712709,"diff_hunk":"@@ -5,153 +5,101 @@ function GradeDist(errorHandler) {\n         {label: 'C', dataField: 'cPercent'},\n         {label: 'D', dataField: 'dPercent'},\n         {label: 'F', dataField: 'fPercent'},\n-        {label: 'W', dataField: 'wPercent'},\n         {label: 'P', dataField: 'pPercent'},\n-        {label: 'NP', dataField: 'npPercent'},\n-        {label: 'GPA', dataField: 'gpa'}\n+        {label: 'NP', dataField: 'npPercent'}\n     ], 'Grade Distribution data does not exist for this professor.', errorHandler);\n }\n \n GradeDist.prototype = Object.create(DataSection.prototype);\n GradeDist.prototype.constructor = GradeDist;\n \n GradeDist.prototype.getNewData = function (teacher, course, callback) {\n-    var url = 'http://asucsd.ucsd.edu/gradeDistribution?' +\n-        'GradeDistribution%5BTERM_CODE%5D=' +\n-        '&GradeDistribution%5BSUBJECT_CODE%5D='+ course.subjectCode +\n-        '&GradeDistribution%5BCOURSE_CODE%5D=' + course.courseCode +\n-        '&GradeDistribution%5BCRSE_TITLE%5D=' +\n-        '&GradeDistribution%5BINSTRUCTOR%5D=' + encodeURIComponent(teacher.nomiddle) +\n-        '&GradeDistribution%5BGPA%5D=' +\n-        '&GradeDistribution_page=1' +\n-        '&ajax=gradedistribution-grid';\n+    // function that has to be here\n+    this.fetchHTMLHttp(\"\", function (page) {","path":"src/inject/gradeDist.js","position":26,"original_position":26,"commit_id":"c02415edec0d2cd0d7fd455278908dce730dc250","original_commit_id":"c02415edec0d2cd0d7fd455278908dce730dc250","user":{"login":"cameronellis","id":9893986,"avatar_url":"https://avatars.githubusercontent.com/u/9893986?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronellis","html_url":"https://github.com/cameronellis","followers_url":"https://api.github.com/users/cameronellis/followers","following_url":"https://api.github.com/users/cameronellis/following{/other_user}","gists_url":"https://api.github.com/users/cameronellis/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronellis/subscriptions","organizations_url":"https://api.github.com/users/cameronellis/orgs","repos_url":"https://api.github.com/users/cameronellis/repos","events_url":"https://api.github.com/users/cameronellis/events{/privacy}","received_events_url":"https://api.github.com/users/cameronellis/received_events","type":"User","site_admin":false},"body":"Thank you for the resource and the hint! It worked. That was easier than I expected","created_at":"2016-08-15T01:05:15Z","updated_at":"2016-08-15T01:05:15Z","html_url":"https://github.com/j-delaney/planner-helper/pull/34#discussion_r74712709","pull_request_url":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/j-delaney/planner-helper/pulls/comments/74712709"},"html":{"href":"https://github.com/j-delaney/planner-helper/pull/34#discussion_r74712709"},"pull_request":{"href":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34","id":81229484,"html_url":"https://github.com/j-delaney/planner-helper/pull/34","diff_url":"https://github.com/j-delaney/planner-helper/pull/34.diff","patch_url":"https://github.com/j-delaney/planner-helper/pull/34.patch","issue_url":"https://api.github.com/repos/j-delaney/planner-helper/issues/34","number":34,"state":"open","locked":false,"title":"YQLGradeDist","user":{"login":"cameronellis","id":9893986,"avatar_url":"https://avatars.githubusercontent.com/u/9893986?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronellis","html_url":"https://github.com/cameronellis","followers_url":"https://api.github.com/users/cameronellis/followers","following_url":"https://api.github.com/users/cameronellis/following{/other_user}","gists_url":"https://api.github.com/users/cameronellis/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronellis/subscriptions","organizations_url":"https://api.github.com/users/cameronellis/orgs","repos_url":"https://api.github.com/users/cameronellis/repos","events_url":"https://api.github.com/users/cameronellis/events{/privacy}","received_events_url":"https://api.github.com/users/cameronellis/received_events","type":"User","site_admin":false},"body":"This commit contains code that scrapes grade distribution data from the cape website. Compared to the other source for grade distribution data which is currently outdated.\r\n\r\n## Development Notes:\r\n- It's 50 lines shorter\r\n- It's easier to read (in my opinion)\r\n-  Uses YQL (Yahoo Query Language - https://developer.yahoo.com/yql/): This greatly simplifies the data scraping process and will make the app easier to maintain in the future. It will also help the performance of the app \r\n- Replaced Http with Https (see: https://www.httpvshttps.com/): This makes the app (slightly) faster and more secure\r\n- The code is documented with javadoc conventions\r\n- W and GPA labels have been removed: W is not a value in cape and GPA is already given under the CAPE column\r\n- Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience: is still present like before.\r\n- There are some professors it's unable to get grade distribution data for. This is because of the difference in professor names on cape and the variables teacher.lname and teacher.fname (e.g. Ilkay Altintas, vs Ilkay Callaf). This is a problem we've addressed before and should not be very difficult to handle in the future\r\n\r\n ","created_at":"2016-08-13T23:22:40Z","updated_at":"2016-08-15T01:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9856d53e4b20513ba41447ea312d2ed9451ccd24","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34/commits","review_comments_url":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34/comments","review_comment_url":"https://api.github.com/repos/j-delaney/planner-helper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/j-delaney/planner-helper/issues/34/comments","statuses_url":"https://api.github.com/repos/j-delaney/planner-helper/statuses/c02415edec0d2cd0d7fd455278908dce730dc250","head":{"label":"cameronellis:YQLGradeDist","ref":"YQLGradeDist","sha":"c02415edec0d2cd0d7fd455278908dce730dc250","user":{"login":"cameronellis","id":9893986,"avatar_url":"https://avatars.githubusercontent.com/u/9893986?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronellis","html_url":"https://github.com/cameronellis","followers_url":"https://api.github.com/users/cameronellis/followers","following_url":"https://api.github.com/users/cameronellis/following{/other_user}","gists_url":"https://api.github.com/users/cameronellis/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronellis/subscriptions","organizations_url":"https://api.github.com/users/cameronellis/orgs","repos_url":"https://api.github.com/users/cameronellis/repos","events_url":"https://api.github.com/users/cameronellis/events{/privacy}","received_events_url":"https://api.github.com/users/cameronellis/received_events","type":"User","site_admin":false},"repo":{"id":62016161,"name":"planner-helper","full_name":"cameronellis/planner-helper","owner":{"login":"cameronellis","id":9893986,"avatar_url":"https://avatars.githubusercontent.com/u/9893986?v=3","gravatar_id":"","url":"https://api.github.com/users/cameronellis","html_url":"https://github.com/cameronellis","followers_url":"https://api.github.com/users/cameronellis/followers","following_url":"https://api.github.com/users/cameronellis/following{/other_user}","gists_url":"https://api.github.com/users/cameronellis/gists{/gist_id}","starred_url":"https://api.github.com/users/cameronellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameronellis/subscriptions","organizations_url":"https://api.github.com/users/cameronellis/orgs","repos_url":"https://api.github.com/users/cameronellis/repos","events_url":"https://api.github.com/users/cameronellis/events{/privacy}","received_events_url":"https://api.github.com/users/cameronellis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cameronellis/planner-helper","description":"Course planning tool for students at UC San Diego: Displays grade distribution data, ratemyprofessor reviews, and CAPE data","fork":true,"url":"https://api.github.com/repos/cameronellis/planner-helper","forks_url":"https://api.github.com/repos/cameronellis/planner-helper/forks","keys_url":"https://api.github.com/repos/cameronellis/planner-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cameronellis/planner-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cameronellis/planner-helper/teams","hooks_url":"https://api.github.com/repos/cameronellis/planner-helper/hooks","issue_events_url":"https://api.github.com/repos/cameronellis/planner-helper/issues/events{/number}","events_url":"https://api.github.com/repos/cameronellis/planner-helper/events","assignees_url":"https://api.github.com/repos/cameronellis/planner-helper/assignees{/user}","branches_url":"https://api.github.com/repos/cameronellis/planner-helper/branches{/branch}","tags_url":"https://api.github.com/repos/cameronellis/planner-helper/tags","blobs_url":"https://api.github.com/repos/cameronellis/planner-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cameronellis/planner-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cameronellis/planner-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/cameronellis/planner-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cameronellis/planner-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/cameronellis/planner-helper/languages","stargazers_url":"https://api.github.com/repos/cameronellis/planner-helper/stargazers","contributors_url":"https://api.github.com/repos/cameronellis/planner-helper/contributors","subscribers_url":"https://api.github.com/repos/cameronellis/planner-helper/subscribers","subscription_url":"https://api.github.com/repos/cameronellis/planner-helper/subscription","commits_url":"https://api.github.com/repos/cameronellis/planner-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/cameronellis/planner-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/cameronellis/planner-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/cameronellis/planner-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/cameronellis/planner-helper/contents/{+path}","compare_url":"https://api.github.com/repos/cameronellis/planner-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cameronellis/planner-helper/merges","archive_url":"https://api.github.com/repos/cameronellis/planner-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cameronellis/planner-helper/downloads","issues_url":"https://api.github.com/repos/cameronellis/planner-helper/issues{/number}","pulls_url":"https://api.github.com/repos/cameronellis/planner-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/cameronellis/planner-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/cameronellis/planner-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cameronellis/planner-helper/labels{/name}","releases_url":"https://api.github.com/repos/cameronellis/planner-helper/releases{/id}","deployments_url":"https://api.github.com/repos/cameronellis/planner-helper/deployments","created_at":"2016-06-27T01:13:15Z","updated_at":"2016-08-14T00:36:32Z","pushed_at":"2016-08-14T00:42:45Z","git_url":"git://github.com/cameronellis/planner-helper.git","ssh_url":"git@github.com:cameronellis/planner-helper.git","clone_url":"https://github.com/cameronellis/planner-helper.git","svn_url":"https://github.com/cameronellis/planner-helper","homepage":"https://chrome.google.com/webstore/detail/planner-helper/omoljdnncdeeglgmagijlamhjlagobep","size":252,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"j-delaney:develop","ref":"develop","sha":"41bc5e7becc1553d5d3b7530236b892dc3d27ee4","user":{"login":"j-delaney","id":3589480,"avatar_url":"https://avatars.githubusercontent.com/u/3589480?v=3","gravatar_id":"","url":"https://api.github.com/users/j-delaney","html_url":"https://github.com/j-delaney","followers_url":"https://api.github.com/users/j-delaney/followers","following_url":"https://api.github.com/users/j-delaney/following{/other_user}","gists_url":"https://api.github.com/users/j-delaney/gists{/gist_id}","starred_url":"https://api.github.com/users/j-delaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-delaney/subscriptions","organizations_url":"https://api.github.com/users/j-delaney/orgs","repos_url":"https://api.github.com/users/j-delaney/repos","events_url":"https://api.github.com/users/j-delaney/events{/privacy}","received_events_url":"https://api.github.com/users/j-delaney/received_events","type":"User","site_admin":false},"repo":{"id":33279992,"name":"planner-helper","full_name":"j-delaney/planner-helper","owner":{"login":"j-delaney","id":3589480,"avatar_url":"https://avatars.githubusercontent.com/u/3589480?v=3","gravatar_id":"","url":"https://api.github.com/users/j-delaney","html_url":"https://github.com/j-delaney","followers_url":"https://api.github.com/users/j-delaney/followers","following_url":"https://api.github.com/users/j-delaney/following{/other_user}","gists_url":"https://api.github.com/users/j-delaney/gists{/gist_id}","starred_url":"https://api.github.com/users/j-delaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-delaney/subscriptions","organizations_url":"https://api.github.com/users/j-delaney/orgs","repos_url":"https://api.github.com/users/j-delaney/repos","events_url":"https://api.github.com/users/j-delaney/events{/privacy}","received_events_url":"https://api.github.com/users/j-delaney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j-delaney/planner-helper","description":"Easily fetch Rate My Professor, CAPEs, and grade distributions in UCSD's WebReg","fork":false,"url":"https://api.github.com/repos/j-delaney/planner-helper","forks_url":"https://api.github.com/repos/j-delaney/planner-helper/forks","keys_url":"https://api.github.com/repos/j-delaney/planner-helper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j-delaney/planner-helper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j-delaney/planner-helper/teams","hooks_url":"https://api.github.com/repos/j-delaney/planner-helper/hooks","issue_events_url":"https://api.github.com/repos/j-delaney/planner-helper/issues/events{/number}","events_url":"https://api.github.com/repos/j-delaney/planner-helper/events","assignees_url":"https://api.github.com/repos/j-delaney/planner-helper/assignees{/user}","branches_url":"https://api.github.com/repos/j-delaney/planner-helper/branches{/branch}","tags_url":"https://api.github.com/repos/j-delaney/planner-helper/tags","blobs_url":"https://api.github.com/repos/j-delaney/planner-helper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j-delaney/planner-helper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j-delaney/planner-helper/git/refs{/sha}","trees_url":"https://api.github.com/repos/j-delaney/planner-helper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j-delaney/planner-helper/statuses/{sha}","languages_url":"https://api.github.com/repos/j-delaney/planner-helper/languages","stargazers_url":"https://api.github.com/repos/j-delaney/planner-helper/stargazers","contributors_url":"https://api.github.com/repos/j-delaney/planner-helper/contributors","subscribers_url":"https://api.github.com/repos/j-delaney/planner-helper/subscribers","subscription_url":"https://api.github.com/repos/j-delaney/planner-helper/subscription","commits_url":"https://api.github.com/repos/j-delaney/planner-helper/commits{/sha}","git_commits_url":"https://api.github.com/repos/j-delaney/planner-helper/git/commits{/sha}","comments_url":"https://api.github.com/repos/j-delaney/planner-helper/comments{/number}","issue_comment_url":"https://api.github.com/repos/j-delaney/planner-helper/issues/comments{/number}","contents_url":"https://api.github.com/repos/j-delaney/planner-helper/contents/{+path}","compare_url":"https://api.github.com/repos/j-delaney/planner-helper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j-delaney/planner-helper/merges","archive_url":"https://api.github.com/repos/j-delaney/planner-helper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j-delaney/planner-helper/downloads","issues_url":"https://api.github.com/repos/j-delaney/planner-helper/issues{/number}","pulls_url":"https://api.github.com/repos/j-delaney/planner-helper/pulls{/number}","milestones_url":"https://api.github.com/repos/j-delaney/planner-helper/milestones{/number}","notifications_url":"https://api.github.com/repos/j-delaney/planner-helper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j-delaney/planner-helper/labels{/name}","releases_url":"https://api.github.com/repos/j-delaney/planner-helper/releases{/id}","deployments_url":"https://api.github.com/repos/j-delaney/planner-helper/deployments","created_at":"2015-04-02T00:19:17Z","updated_at":"2016-06-27T00:11:42Z","pushed_at":"2016-08-13T23:22:40Z","git_url":"git://github.com/j-delaney/planner-helper.git","ssh_url":"git@github.com:j-delaney/planner-helper.git","clone_url":"https://github.com/j-delaney/planner-helper.git","svn_url":"https://github.com/j-delaney/planner-helper","homepage":"https://chrome.google.com/webstore/detail/planner-helper/omoljdnncdeeglgmagijlamhjlagobep","size":257,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":9,"forks":15,"open_issues":9,"watchers":24,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34"},"html":{"href":"https://github.com/j-delaney/planner-helper/pull/34"},"issue":{"href":"https://api.github.com/repos/j-delaney/planner-helper/issues/34"},"comments":{"href":"https://api.github.com/repos/j-delaney/planner-helper/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/j-delaney/planner-helper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/j-delaney/planner-helper/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/j-delaney/planner-helper/statuses/c02415edec0d2cd0d7fd455278908dce730dc250"}}}}
{"actor":{"display_login":"cameronellis"}}