{"action":"created","comment":{"url":"https://api.github.com/repos/septract/starling-tool/pulls/comments/89304907","pull_request_review_id":9850396,"id":89304907,"diff_hunk":"@@ -648,9 +666,17 @@ let reify\n                  ViewDefiner<SVBoolExpr option>>)\n   : Result<Model<Term<'a, Set<GuardedIteratedSubview>, IteratedOView>,\n                  ViewDefiner<SVBoolExpr option>>, Error> =\n-    model\n-    |> mapAxioms (mapTerm id (reifyView model.ViewProtos model.ViewDefs) id)\n-    |> tryMapViewDefs (Downclosure.check model.ViewProtos)\n+    let deferredCheckR =","path":"Reifier.fs","position":279,"original_position":279,"commit_id":"2a2dafe31b610050951700b03b49a4bead1dd04f","original_commit_id":"2a2dafe31b610050951700b03b49a4bead1dd04f","user":{"login":"septract","id":220662,"avatar_url":"https://avatars.githubusercontent.com/u/220662?v=3","gravatar_id":"","url":"https://api.github.com/users/septract","html_url":"https://github.com/septract","followers_url":"https://api.github.com/users/septract/followers","following_url":"https://api.github.com/users/septract/following{/other_user}","gists_url":"https://api.github.com/users/septract/gists{/gist_id}","starred_url":"https://api.github.com/users/septract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/septract/subscriptions","organizations_url":"https://api.github.com/users/septract/orgs","repos_url":"https://api.github.com/users/septract/repos","events_url":"https://api.github.com/users/septract/events{/privacy}","received_events_url":"https://api.github.com/users/septract/received_events","type":"User","site_admin":false},"body":"What is this?","created_at":"2016-11-23T12:20:31Z","updated_at":"2016-11-23T12:20:31Z","html_url":"https://github.com/septract/starling-tool/pull/66#discussion_r89304907","pull_request_url":"https://api.github.com/repos/septract/starling-tool/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/septract/starling-tool/pulls/comments/89304907"},"html":{"href":"https://github.com/septract/starling-tool/pull/66#discussion_r89304907"},"pull_request":{"href":"https://api.github.com/repos/septract/starling-tool/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/septract/starling-tool/pulls/66","id":89236061,"html_url":"https://github.com/septract/starling-tool/pull/66","diff_url":"https://github.com/septract/starling-tool/pull/66.diff","patch_url":"https://github.com/septract/starling-tool/pull/66.patch","issue_url":"https://api.github.com/repos/septract/starling-tool/issues/66","number":66,"state":"open","locked":false,"title":"Add downclosure checks to HSF and MuZ3","user":{"login":"CaptainHayashi","id":374963,"avatar_url":"https://avatars.githubusercontent.com/u/374963?v=3","gravatar_id":"","url":"https://api.github.com/users/CaptainHayashi","html_url":"https://github.com/CaptainHayashi","followers_url":"https://api.github.com/users/CaptainHayashi/followers","following_url":"https://api.github.com/users/CaptainHayashi/following{/other_user}","gists_url":"https://api.github.com/users/CaptainHayashi/gists{/gist_id}","starred_url":"https://api.github.com/users/CaptainHayashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaptainHayashi/subscriptions","organizations_url":"https://api.github.com/users/CaptainHayashi/orgs","repos_url":"https://api.github.com/users/CaptainHayashi/repos","events_url":"https://api.github.com/users/CaptainHayashi/events{/privacy}","received_events_url":"https://api.github.com/users/CaptainHayashi/received_events","type":"User","site_admin":false},"body":"As above.\n\nThis also rearranges the Z3 backend to serve as a preprocessor for subsequent backends.  This works well if the Z3 output is going to grasshopper or a human, but poorly if it's going to HSF (and possibly even soundness-breaking if it's going to MuZ3?), so I might change the default option to suppress it if people think that'd be better.\n\nZ3 also has a few new output stages to print failures in more detail (`smt-failures`), amongst others.  `sat` has been renamed `smt-sat` and now reports any proof terms Z3 can't solve but another solver can.\n\nWhile doing this work I seem to have found some soundness and completeness bugs in MuZ3 (as in, I don't think the backend is working at all!), but I haven't addressed them here.\n","created_at":"2016-10-13T16:22:56Z","updated_at":"2016-11-23T12:20:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c016114ea075e770e4dd2fd0f86c7e4e0f3f1e0a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/septract/starling-tool/pulls/66/commits","review_comments_url":"https://api.github.com/repos/septract/starling-tool/pulls/66/comments","review_comment_url":"https://api.github.com/repos/septract/starling-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/septract/starling-tool/issues/66/comments","statuses_url":"https://api.github.com/repos/septract/starling-tool/statuses/2a2dafe31b610050951700b03b49a4bead1dd04f","head":{"label":"septract:mw-iterated-hsf","ref":"mw-iterated-hsf","sha":"2a2dafe31b610050951700b03b49a4bead1dd04f","user":{"login":"septract","id":220662,"avatar_url":"https://avatars.githubusercontent.com/u/220662?v=3","gravatar_id":"","url":"https://api.github.com/users/septract","html_url":"https://github.com/septract","followers_url":"https://api.github.com/users/septract/followers","following_url":"https://api.github.com/users/septract/following{/other_user}","gists_url":"https://api.github.com/users/septract/gists{/gist_id}","starred_url":"https://api.github.com/users/septract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/septract/subscriptions","organizations_url":"https://api.github.com/users/septract/orgs","repos_url":"https://api.github.com/users/septract/repos","events_url":"https://api.github.com/users/septract/events{/privacy}","received_events_url":"https://api.github.com/users/septract/received_events","type":"User","site_admin":false},"repo":{"id":43949917,"name":"starling-tool","full_name":"septract/starling-tool","owner":{"login":"septract","id":220662,"avatar_url":"https://avatars.githubusercontent.com/u/220662?v=3","gravatar_id":"","url":"https://api.github.com/users/septract","html_url":"https://github.com/septract","followers_url":"https://api.github.com/users/septract/followers","following_url":"https://api.github.com/users/septract/following{/other_user}","gists_url":"https://api.github.com/users/septract/gists{/gist_id}","starred_url":"https://api.github.com/users/septract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/septract/subscriptions","organizations_url":"https://api.github.com/users/septract/orgs","repos_url":"https://api.github.com/users/septract/repos","events_url":"https://api.github.com/users/septract/events{/privacy}","received_events_url":"https://api.github.com/users/septract/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/septract/starling-tool","description":"An automatic verifier for concurrent algorithms.","fork":false,"url":"https://api.github.com/repos/septract/starling-tool","forks_url":"https://api.github.com/repos/septract/starling-tool/forks","keys_url":"https://api.github.com/repos/septract/starling-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/septract/starling-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/septract/starling-tool/teams","hooks_url":"https://api.github.com/repos/septract/starling-tool/hooks","issue_events_url":"https://api.github.com/repos/septract/starling-tool/issues/events{/number}","events_url":"https://api.github.com/repos/septract/starling-tool/events","assignees_url":"https://api.github.com/repos/septract/starling-tool/assignees{/user}","branches_url":"https://api.github.com/repos/septract/starling-tool/branches{/branch}","tags_url":"https://api.github.com/repos/septract/starling-tool/tags","blobs_url":"https://api.github.com/repos/septract/starling-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/septract/starling-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/septract/starling-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/septract/starling-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/septract/starling-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/septract/starling-tool/languages","stargazers_url":"https://api.github.com/repos/septract/starling-tool/stargazers","contributors_url":"https://api.github.com/repos/septract/starling-tool/contributors","subscribers_url":"https://api.github.com/repos/septract/starling-tool/subscribers","subscription_url":"https://api.github.com/repos/septract/starling-tool/subscription","commits_url":"https://api.github.com/repos/septract/starling-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/septract/starling-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/septract/starling-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/septract/starling-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/septract/starling-tool/contents/{+path}","compare_url":"https://api.github.com/repos/septract/starling-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/septract/starling-tool/merges","archive_url":"https://api.github.com/repos/septract/starling-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/septract/starling-tool/downloads","issues_url":"https://api.github.com/repos/septract/starling-tool/issues{/number}","pulls_url":"https://api.github.com/repos/septract/starling-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/septract/starling-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/septract/starling-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/septract/starling-tool/labels{/name}","releases_url":"https://api.github.com/repos/septract/starling-tool/releases{/id}","deployments_url":"https://api.github.com/repos/septract/starling-tool/deployments","created_at":"2015-10-09T10:51:44Z","updated_at":"2016-11-01T11:26:54Z","pushed_at":"2016-11-23T10:25:13Z","git_url":"git://github.com/septract/starling-tool.git","ssh_url":"git@github.com:septract/starling-tool.git","clone_url":"https://github.com/septract/starling-tool.git","svn_url":"https://github.com/septract/starling-tool","homepage":"","size":1837,"stargazers_count":4,"watchers_count":4,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":4,"default_branch":"master"}},"base":{"label":"septract:master","ref":"master","sha":"a4457f6b64aabe651fe0a94b44219a832b58cf26","user":{"login":"septract","id":220662,"avatar_url":"https://avatars.githubusercontent.com/u/220662?v=3","gravatar_id":"","url":"https://api.github.com/users/septract","html_url":"https://github.com/septract","followers_url":"https://api.github.com/users/septract/followers","following_url":"https://api.github.com/users/septract/following{/other_user}","gists_url":"https://api.github.com/users/septract/gists{/gist_id}","starred_url":"https://api.github.com/users/septract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/septract/subscriptions","organizations_url":"https://api.github.com/users/septract/orgs","repos_url":"https://api.github.com/users/septract/repos","events_url":"https://api.github.com/users/septract/events{/privacy}","received_events_url":"https://api.github.com/users/septract/received_events","type":"User","site_admin":false},"repo":{"id":43949917,"name":"starling-tool","full_name":"septract/starling-tool","owner":{"login":"septract","id":220662,"avatar_url":"https://avatars.githubusercontent.com/u/220662?v=3","gravatar_id":"","url":"https://api.github.com/users/septract","html_url":"https://github.com/septract","followers_url":"https://api.github.com/users/septract/followers","following_url":"https://api.github.com/users/septract/following{/other_user}","gists_url":"https://api.github.com/users/septract/gists{/gist_id}","starred_url":"https://api.github.com/users/septract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/septract/subscriptions","organizations_url":"https://api.github.com/users/septract/orgs","repos_url":"https://api.github.com/users/septract/repos","events_url":"https://api.github.com/users/septract/events{/privacy}","received_events_url":"https://api.github.com/users/septract/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/septract/starling-tool","description":"An automatic verifier for concurrent algorithms.","fork":false,"url":"https://api.github.com/repos/septract/starling-tool","forks_url":"https://api.github.com/repos/septract/starling-tool/forks","keys_url":"https://api.github.com/repos/septract/starling-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/septract/starling-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/septract/starling-tool/teams","hooks_url":"https://api.github.com/repos/septract/starling-tool/hooks","issue_events_url":"https://api.github.com/repos/septract/starling-tool/issues/events{/number}","events_url":"https://api.github.com/repos/septract/starling-tool/events","assignees_url":"https://api.github.com/repos/septract/starling-tool/assignees{/user}","branches_url":"https://api.github.com/repos/septract/starling-tool/branches{/branch}","tags_url":"https://api.github.com/repos/septract/starling-tool/tags","blobs_url":"https://api.github.com/repos/septract/starling-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/septract/starling-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/septract/starling-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/septract/starling-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/septract/starling-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/septract/starling-tool/languages","stargazers_url":"https://api.github.com/repos/septract/starling-tool/stargazers","contributors_url":"https://api.github.com/repos/septract/starling-tool/contributors","subscribers_url":"https://api.github.com/repos/septract/starling-tool/subscribers","subscription_url":"https://api.github.com/repos/septract/starling-tool/subscription","commits_url":"https://api.github.com/repos/septract/starling-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/septract/starling-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/septract/starling-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/septract/starling-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/septract/starling-tool/contents/{+path}","compare_url":"https://api.github.com/repos/septract/starling-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/septract/starling-tool/merges","archive_url":"https://api.github.com/repos/septract/starling-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/septract/starling-tool/downloads","issues_url":"https://api.github.com/repos/septract/starling-tool/issues{/number}","pulls_url":"https://api.github.com/repos/septract/starling-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/septract/starling-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/septract/starling-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/septract/starling-tool/labels{/name}","releases_url":"https://api.github.com/repos/septract/starling-tool/releases{/id}","deployments_url":"https://api.github.com/repos/septract/starling-tool/deployments","created_at":"2015-10-09T10:51:44Z","updated_at":"2016-11-01T11:26:54Z","pushed_at":"2016-11-23T10:25:13Z","git_url":"git://github.com/septract/starling-tool.git","ssh_url":"git@github.com:septract/starling-tool.git","clone_url":"https://github.com/septract/starling-tool.git","svn_url":"https://github.com/septract/starling-tool","homepage":"","size":1837,"stargazers_count":4,"watchers_count":4,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/septract/starling-tool/pulls/66"},"html":{"href":"https://github.com/septract/starling-tool/pull/66"},"issue":{"href":"https://api.github.com/repos/septract/starling-tool/issues/66"},"comments":{"href":"https://api.github.com/repos/septract/starling-tool/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/septract/starling-tool/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/septract/starling-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/septract/starling-tool/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/septract/starling-tool/statuses/2a2dafe31b610050951700b03b49a4bead1dd04f"}}}}
{"actor":{"display_login":"septract"}}