{"action":"created","issue":{"url":"https://api.github.com/repos/liqd/adhocracy3/issues/2843","repository_url":"https://api.github.com/repos/liqd/adhocracy3","labels_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2843/labels{/name}","comments_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2843/comments","events_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2843/events","html_url":"https://github.com/liqd/adhocracy3/pull/2843","id":188295597,"number":2843,"title":"Service Konto Frontend","user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"labels":[{"id":123261240,"url":"https://api.github.com/repos/liqd/adhocracy3/labels/frontend","name":"frontend","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":{"login":"der-john","id":16540898,"avatar_url":"https://avatars.githubusercontent.com/u/16540898?v=3","gravatar_id":"","url":"https://api.github.com/users/der-john","html_url":"https://github.com/der-john","followers_url":"https://api.github.com/users/der-john/followers","following_url":"https://api.github.com/users/der-john/following{/other_user}","gists_url":"https://api.github.com/users/der-john/gists{/gist_id}","starred_url":"https://api.github.com/users/der-john/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-john/subscriptions","organizations_url":"https://api.github.com/users/der-john/orgs","repos_url":"https://api.github.com/users/der-john/repos","events_url":"https://api.github.com/users/der-john/events{/privacy}","received_events_url":"https://api.github.com/users/der-john/received_events","type":"User","site_admin":false},"assignees":[{"login":"der-john","id":16540898,"avatar_url":"https://avatars.githubusercontent.com/u/16540898?v=3","gravatar_id":"","url":"https://api.github.com/users/der-john","html_url":"https://github.com/der-john","followers_url":"https://api.github.com/users/der-john/followers","following_url":"https://api.github.com/users/der-john/following{/other_user}","gists_url":"https://api.github.com/users/der-john/gists{/gist_id}","starred_url":"https://api.github.com/users/der-john/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-john/subscriptions","organizations_url":"https://api.github.com/users/der-john/orgs","repos_url":"https://api.github.com/users/der-john/repos","events_url":"https://api.github.com/users/der-john/events{/privacy}","received_events_url":"https://api.github.com/users/der-john/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-11-09T16:46:33Z","updated_at":"2016-11-22T14:28:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/liqd/adhocracy3/pulls/2843","html_url":"https://github.com/liqd/adhocracy3/pull/2843","diff_url":"https://github.com/liqd/adhocracy3/pull/2843.diff","patch_url":"https://github.com/liqd/adhocracy3/pull/2843.patch"},"body":"This implements the frontend part of service konto:\r\n\r\n- On the login page there is an additional button saying \"login with Service-Konto Berlin\". Clicking it opens a popup with the URL specified in `adhocracy.frontend.service_konto_login_url`. If this value is not set, no button is shown.\r\n- Once the login in the popup succeeds, it must redirect to `{frontendUrl}/service_konto_finish?token={token}`. This page is empty, but it hands back the token to adhocracy.\r\n- Once adhocracy receives the token, it closes the popup and attempts to login with the token. The success/error handling is identical to that of regular login.\r\n\r\nNote that all of this is is implemented in core. You could argue that it is specific to meinberlin, but the steps described above are actually very generic (except for the term \"service konto\"). It may need some small adjustments to be truly generic, but they can be done when necessary.\r\n\r\nOne note on implementation: I first thought it would be a good idea to use `adhCrossWindowMessaging`. It later turned out that this was not a good idea (see \tb1c567b), but some changes to that service are still included because I did not bother to rebase."},"comment":{"url":"https://api.github.com/repos/liqd/adhocracy3/issues/comments/262254523","html_url":"https://github.com/liqd/adhocracy3/pull/2843#issuecomment-262254523","issue_url":"https://api.github.com/repos/liqd/adhocracy3/issues/2843","id":262254523,"user":{"login":"der-john","id":16540898,"avatar_url":"https://avatars.githubusercontent.com/u/16540898?v=3","gravatar_id":"","url":"https://api.github.com/users/der-john","html_url":"https://github.com/der-john","followers_url":"https://api.github.com/users/der-john/followers","following_url":"https://api.github.com/users/der-john/following{/other_user}","gists_url":"https://api.github.com/users/der-john/gists{/gist_id}","starred_url":"https://api.github.com/users/der-john/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/der-john/subscriptions","organizations_url":"https://api.github.com/users/der-john/orgs","repos_url":"https://api.github.com/users/der-john/repos","events_url":"https://api.github.com/users/der-john/events{/privacy}","received_events_url":"https://api.github.com/users/der-john/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T14:28:47Z","updated_at":"2016-11-22T14:28:47Z","body":"looks good to me thus far. untested."}}
{"actor":{"display_login":"der-john"}}