{"action":"created","comment":{"url":"https://api.github.com/repos/0xfe/vexflow/pulls/comments/72903090","id":72903090,"diff_hunk":"@@ -334,7 +336,7 @@ export class SVGContext {\n       height *= -1;\n     }\n \n-    this.rect(x, y, width - 0.5, height - 0.5, this.attributes);","path":"src/svgcontext.js","position":21,"original_position":21,"commit_id":"19d678e4a150a9475a134b4431256958aa240f53","original_commit_id":"19d678e4a150a9475a134b4431256958aa240f53","user":{"login":"Silverwolf90","id":1631625,"avatar_url":"https://avatars.githubusercontent.com/u/1631625?v=3","gravatar_id":"","url":"https://api.github.com/users/Silverwolf90","html_url":"https://github.com/Silverwolf90","followers_url":"https://api.github.com/users/Silverwolf90/followers","following_url":"https://api.github.com/users/Silverwolf90/following{/other_user}","gists_url":"https://api.github.com/users/Silverwolf90/gists{/gist_id}","starred_url":"https://api.github.com/users/Silverwolf90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silverwolf90/subscriptions","organizations_url":"https://api.github.com/users/Silverwolf90/orgs","repos_url":"https://api.github.com/users/Silverwolf90/repos","events_url":"https://api.github.com/users/Silverwolf90/events{/privacy}","received_events_url":"https://api.github.com/users/Silverwolf90/received_events","type":"User","site_admin":false},"body":"I had to take out these adjustments to get Barlines to behave as expected. Were these to mitigate anti-aliasing artifacts?","created_at":"2016-07-31T11:59:37Z","updated_at":"2016-07-31T11:59:37Z","html_url":"https://github.com/0xfe/vexflow/pull/407#discussion_r72903090","pull_request_url":"https://api.github.com/repos/0xfe/vexflow/pulls/407","_links":{"self":{"href":"https://api.github.com/repos/0xfe/vexflow/pulls/comments/72903090"},"html":{"href":"https://github.com/0xfe/vexflow/pull/407#discussion_r72903090"},"pull_request":{"href":"https://api.github.com/repos/0xfe/vexflow/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/0xfe/vexflow/pulls/407","id":79471069,"html_url":"https://github.com/0xfe/vexflow/pull/407","diff_url":"https://github.com/0xfe/vexflow/pull/407.diff","patch_url":"https://github.com/0xfe/vexflow/pull/407.patch","issue_url":"https://api.github.com/repos/0xfe/vexflow/issues/407","number":407,"state":"open","locked":false,"title":"Improve glyph+stem proportions.","user":{"login":"Silverwolf90","id":1631625,"avatar_url":"https://avatars.githubusercontent.com/u/1631625?v=3","gravatar_id":"","url":"https://api.github.com/users/Silverwolf90","html_url":"https://github.com/Silverwolf90","followers_url":"https://api.github.com/users/Silverwolf90/followers","following_url":"https://api.github.com/users/Silverwolf90/following{/other_user}","gists_url":"https://api.github.com/users/Silverwolf90/gists{/gist_id}","starred_url":"https://api.github.com/users/Silverwolf90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silverwolf90/subscriptions","organizations_url":"https://api.github.com/users/Silverwolf90/orgs","repos_url":"https://api.github.com/users/Silverwolf90/repos","events_url":"https://api.github.com/users/Silverwolf90/events{/privacy}","received_events_url":"https://api.github.com/users/Silverwolf90/received_events","type":"User","site_admin":false},"body":"This is still a WIP -- looks like down-stemmed gracenote flags aren't working as expected. But I wanted to open this up in case anyone had any objections. I'll fix the gracenotes shortly.\r\n\r\n----\r\n\r\nNow that glyph widths are not hard-coded, we can more easily increase glyph sizes to be more standard (and more visually pleasing).\r\n\r\nBefore this change, the default stem height was 32px. But this is non-standard given a stave with a default 10px staff space. Typically in standard music notation, the default stem height is 3.5 staff spaces (ie: 35px given a 10px staff spcae). The reason it was set to 32px is because the noteheads were too small, so a 35px stem looked too long. I've increased the size of the noteheads, in order for their height to take up an entire staff space. And increased the Stem to the standard 35px.\r\n\r\nThe crux of this change was replacing the `head_width` property of notehead glyphs in `tables.js`. It was replaced with a `.getWidth(fontScale)`.\r\n\r\nI also extracted some of the common font scales into the `Flow` object.\r\n\r\nHere are some of the tests with the new glyph sizes:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/17273647/ad809756-56b4-11e6-9ec1-12b25e13dc60.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/17273652/bea5dd84-56b4-11e6-9c64-3f974c1a379a.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/17273694/27f74ff6-56b6-11e6-972c-0c4c41fa8317.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/17273696/36982f94-56b6-11e6-9c83-ba0e24d54912.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/17273697/3e73ed3e-56b6-11e6-9318-9c9d1aaed0e8.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/17273701/56ccb4c4-56b6-11e6-9450-7720a48dbb1b.png)\r\n\r\n@mscuthbert and @gristow, do think this is a visual improvement?\r\n","created_at":"2016-07-30T23:36:17Z","updated_at":"2016-07-31T11:59:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"664bb740a3c7bfa0ad0a141d31d373b44f5674fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/0xfe/vexflow/pulls/407/commits","review_comments_url":"https://api.github.com/repos/0xfe/vexflow/pulls/407/comments","review_comment_url":"https://api.github.com/repos/0xfe/vexflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xfe/vexflow/issues/407/comments","statuses_url":"https://api.github.com/repos/0xfe/vexflow/statuses/19d678e4a150a9475a134b4431256958aa240f53","head":{"label":"Silverwolf90:fix/notehead-stem-proportions","ref":"fix/notehead-stem-proportions","sha":"19d678e4a150a9475a134b4431256958aa240f53","user":{"login":"Silverwolf90","id":1631625,"avatar_url":"https://avatars.githubusercontent.com/u/1631625?v=3","gravatar_id":"","url":"https://api.github.com/users/Silverwolf90","html_url":"https://github.com/Silverwolf90","followers_url":"https://api.github.com/users/Silverwolf90/followers","following_url":"https://api.github.com/users/Silverwolf90/following{/other_user}","gists_url":"https://api.github.com/users/Silverwolf90/gists{/gist_id}","starred_url":"https://api.github.com/users/Silverwolf90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silverwolf90/subscriptions","organizations_url":"https://api.github.com/users/Silverwolf90/orgs","repos_url":"https://api.github.com/users/Silverwolf90/repos","events_url":"https://api.github.com/users/Silverwolf90/events{/privacy}","received_events_url":"https://api.github.com/users/Silverwolf90/received_events","type":"User","site_admin":false},"repo":{"id":13641396,"name":"vexflow","full_name":"Silverwolf90/vexflow","owner":{"login":"Silverwolf90","id":1631625,"avatar_url":"https://avatars.githubusercontent.com/u/1631625?v=3","gravatar_id":"","url":"https://api.github.com/users/Silverwolf90","html_url":"https://github.com/Silverwolf90","followers_url":"https://api.github.com/users/Silverwolf90/followers","following_url":"https://api.github.com/users/Silverwolf90/following{/other_user}","gists_url":"https://api.github.com/users/Silverwolf90/gists{/gist_id}","starred_url":"https://api.github.com/users/Silverwolf90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silverwolf90/subscriptions","organizations_url":"https://api.github.com/users/Silverwolf90/orgs","repos_url":"https://api.github.com/users/Silverwolf90/repos","events_url":"https://api.github.com/users/Silverwolf90/events{/privacy}","received_events_url":"https://api.github.com/users/Silverwolf90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Silverwolf90/vexflow","description":"A JavaScript library for rendering music notation and guitar tablature.","fork":true,"url":"https://api.github.com/repos/Silverwolf90/vexflow","forks_url":"https://api.github.com/repos/Silverwolf90/vexflow/forks","keys_url":"https://api.github.com/repos/Silverwolf90/vexflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Silverwolf90/vexflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Silverwolf90/vexflow/teams","hooks_url":"https://api.github.com/repos/Silverwolf90/vexflow/hooks","issue_events_url":"https://api.github.com/repos/Silverwolf90/vexflow/issues/events{/number}","events_url":"https://api.github.com/repos/Silverwolf90/vexflow/events","assignees_url":"https://api.github.com/repos/Silverwolf90/vexflow/assignees{/user}","branches_url":"https://api.github.com/repos/Silverwolf90/vexflow/branches{/branch}","tags_url":"https://api.github.com/repos/Silverwolf90/vexflow/tags","blobs_url":"https://api.github.com/repos/Silverwolf90/vexflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Silverwolf90/vexflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Silverwolf90/vexflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/Silverwolf90/vexflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Silverwolf90/vexflow/statuses/{sha}","languages_url":"https://api.github.com/repos/Silverwolf90/vexflow/languages","stargazers_url":"https://api.github.com/repos/Silverwolf90/vexflow/stargazers","contributors_url":"https://api.github.com/repos/Silverwolf90/vexflow/contributors","subscribers_url":"https://api.github.com/repos/Silverwolf90/vexflow/subscribers","subscription_url":"https://api.github.com/repos/Silverwolf90/vexflow/subscription","commits_url":"https://api.github.com/repos/Silverwolf90/vexflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/Silverwolf90/vexflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/Silverwolf90/vexflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/Silverwolf90/vexflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/Silverwolf90/vexflow/contents/{+path}","compare_url":"https://api.github.com/repos/Silverwolf90/vexflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Silverwolf90/vexflow/merges","archive_url":"https://api.github.com/repos/Silverwolf90/vexflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Silverwolf90/vexflow/downloads","issues_url":"https://api.github.com/repos/Silverwolf90/vexflow/issues{/number}","pulls_url":"https://api.github.com/repos/Silverwolf90/vexflow/pulls{/number}","milestones_url":"https://api.github.com/repos/Silverwolf90/vexflow/milestones{/number}","notifications_url":"https://api.github.com/repos/Silverwolf90/vexflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Silverwolf90/vexflow/labels{/name}","releases_url":"https://api.github.com/repos/Silverwolf90/vexflow/releases{/id}","deployments_url":"https://api.github.com/repos/Silverwolf90/vexflow/deployments","created_at":"2013-10-17T06:56:45Z","updated_at":"2014-08-12T09:44:33Z","pushed_at":"2016-07-31T11:56:23Z","git_url":"git://github.com/Silverwolf90/vexflow.git","ssh_url":"git@github.com:Silverwolf90/vexflow.git","clone_url":"https://github.com/Silverwolf90/vexflow.git","svn_url":"https://github.com/Silverwolf90/vexflow","homepage":"http://www.vexflow.com","size":20656,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"0xfe:master","ref":"master","sha":"e0ea04638c64b909198ec7cd58de16ff5ea74c20","user":{"login":"0xfe","id":241299,"avatar_url":"https://avatars.githubusercontent.com/u/241299?v=3","gravatar_id":"","url":"https://api.github.com/users/0xfe","html_url":"https://github.com/0xfe","followers_url":"https://api.github.com/users/0xfe/followers","following_url":"https://api.github.com/users/0xfe/following{/other_user}","gists_url":"https://api.github.com/users/0xfe/gists{/gist_id}","starred_url":"https://api.github.com/users/0xfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xfe/subscriptions","organizations_url":"https://api.github.com/users/0xfe/orgs","repos_url":"https://api.github.com/users/0xfe/repos","events_url":"https://api.github.com/users/0xfe/events{/privacy}","received_events_url":"https://api.github.com/users/0xfe/received_events","type":"User","site_admin":false},"repo":{"id":814715,"name":"vexflow","full_name":"0xfe/vexflow","owner":{"login":"0xfe","id":241299,"avatar_url":"https://avatars.githubusercontent.com/u/241299?v=3","gravatar_id":"","url":"https://api.github.com/users/0xfe","html_url":"https://github.com/0xfe","followers_url":"https://api.github.com/users/0xfe/followers","following_url":"https://api.github.com/users/0xfe/following{/other_user}","gists_url":"https://api.github.com/users/0xfe/gists{/gist_id}","starred_url":"https://api.github.com/users/0xfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xfe/subscriptions","organizations_url":"https://api.github.com/users/0xfe/orgs","repos_url":"https://api.github.com/users/0xfe/repos","events_url":"https://api.github.com/users/0xfe/events{/privacy}","received_events_url":"https://api.github.com/users/0xfe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0xfe/vexflow","description":"A JavaScript library for rendering music notation and guitar tablature.","fork":false,"url":"https://api.github.com/repos/0xfe/vexflow","forks_url":"https://api.github.com/repos/0xfe/vexflow/forks","keys_url":"https://api.github.com/repos/0xfe/vexflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xfe/vexflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xfe/vexflow/teams","hooks_url":"https://api.github.com/repos/0xfe/vexflow/hooks","issue_events_url":"https://api.github.com/repos/0xfe/vexflow/issues/events{/number}","events_url":"https://api.github.com/repos/0xfe/vexflow/events","assignees_url":"https://api.github.com/repos/0xfe/vexflow/assignees{/user}","branches_url":"https://api.github.com/repos/0xfe/vexflow/branches{/branch}","tags_url":"https://api.github.com/repos/0xfe/vexflow/tags","blobs_url":"https://api.github.com/repos/0xfe/vexflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xfe/vexflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xfe/vexflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xfe/vexflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xfe/vexflow/statuses/{sha}","languages_url":"https://api.github.com/repos/0xfe/vexflow/languages","stargazers_url":"https://api.github.com/repos/0xfe/vexflow/stargazers","contributors_url":"https://api.github.com/repos/0xfe/vexflow/contributors","subscribers_url":"https://api.github.com/repos/0xfe/vexflow/subscribers","subscription_url":"https://api.github.com/repos/0xfe/vexflow/subscription","commits_url":"https://api.github.com/repos/0xfe/vexflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xfe/vexflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xfe/vexflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xfe/vexflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xfe/vexflow/contents/{+path}","compare_url":"https://api.github.com/repos/0xfe/vexflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xfe/vexflow/merges","archive_url":"https://api.github.com/repos/0xfe/vexflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xfe/vexflow/downloads","issues_url":"https://api.github.com/repos/0xfe/vexflow/issues{/number}","pulls_url":"https://api.github.com/repos/0xfe/vexflow/pulls{/number}","milestones_url":"https://api.github.com/repos/0xfe/vexflow/milestones{/number}","notifications_url":"https://api.github.com/repos/0xfe/vexflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xfe/vexflow/labels{/name}","releases_url":"https://api.github.com/repos/0xfe/vexflow/releases{/id}","deployments_url":"https://api.github.com/repos/0xfe/vexflow/deployments","created_at":"2010-08-03T14:47:36Z","updated_at":"2016-07-29T12:54:57Z","pushed_at":"2016-07-31T11:56:24Z","git_url":"git://github.com/0xfe/vexflow.git","ssh_url":"git@github.com:0xfe/vexflow.git","clone_url":"https://github.com/0xfe/vexflow.git","svn_url":"https://github.com/0xfe/vexflow","homepage":"http://www.vexflow.com","size":20579,"stargazers_count":1513,"watchers_count":1513,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":52,"forks":334,"open_issues":52,"watchers":1513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/0xfe/vexflow/pulls/407"},"html":{"href":"https://github.com/0xfe/vexflow/pull/407"},"issue":{"href":"https://api.github.com/repos/0xfe/vexflow/issues/407"},"comments":{"href":"https://api.github.com/repos/0xfe/vexflow/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/0xfe/vexflow/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/0xfe/vexflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xfe/vexflow/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/0xfe/vexflow/statuses/19d678e4a150a9475a134b4431256958aa240f53"}}}}
{"actor":{"display_login":"Silverwolf90"}}