{"action":"created","issue":{"url":"https://api.github.com/repos/qTox/qTox/issues/3737","repository_url":"https://api.github.com/repos/qTox/qTox","labels_url":"https://api.github.com/repos/qTox/qTox/issues/3737/labels{/name}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/3737/comments","events_url":"https://api.github.com/repos/qTox/qTox/issues/3737/events","html_url":"https://github.com/qTox/qTox/pull/3737","id":178737599,"number":3737,"title":"[RFC] Improve emoji support","user":{"login":"sudden6","id":5585762,"avatar_url":"https://avatars.githubusercontent.com/u/5585762?v=3","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-22T22:32:27Z","updated_at":"2016-09-22T23:22:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qTox/qTox/pulls/3737","html_url":"https://github.com/qTox/qTox/pull/3737","diff_url":"https://github.com/qTox/qTox/pull/3737.diff","patch_url":"https://github.com/qTox/qTox/pull/3737.patch"},"body":"* qTox allways compiles all smileys into the binary, this causes an unnecessary large binary and resource consumption during compilation see https://github.com/qTox/qTox/issues/3728 , removing some emoji could also speed up Travis builds\r\n\r\n* while digging through the source code I noticed qTox already loads emoji from many paths, they are just undocumented or UNIX only, I choose to add one common path for Windows and Linux so even a qTox binary without any compiled in smileys can load them.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qtox/qtox/3737)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/qTox/qTox/issues/comments/249056352","html_url":"https://github.com/qTox/qTox/pull/3737#issuecomment-249056352","issue_url":"https://api.github.com/repos/qTox/qTox/issues/3737","id":249056352,"user":{"login":"zetok","id":3148759,"avatar_url":"https://avatars.githubusercontent.com/u/3148759?v=3","gravatar_id":"","url":"https://api.github.com/users/zetok","html_url":"https://github.com/zetok","followers_url":"https://api.github.com/users/zetok/followers","following_url":"https://api.github.com/users/zetok/following{/other_user}","gists_url":"https://api.github.com/users/zetok/gists{/gist_id}","starred_url":"https://api.github.com/users/zetok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetok/subscriptions","organizations_url":"https://api.github.com/users/zetok/orgs","repos_url":"https://api.github.com/users/zetok/repos","events_url":"https://api.github.com/users/zetok/events{/privacy}","received_events_url":"https://api.github.com/users/zetok/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T23:22:30Z","updated_at":"2016-09-22T23:22:30Z","body":"\n\n\n\nReview status: 0 of 6 files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[doc/user_manual_en.md, line 12 at r1](https://reviewable.io:443/reviews/qtox/qtox/3737#-KSJ8Ynkav84EyCTADHp:-KSJ8Ynkav84EyCTADHq:bcoklrx) ([raw file](https://github.com/qtox/qtox/blob/1ba524e4d3763f84275ab066638c51c01824e877/doc/user_manual_en.md#L12)):*\n> ```Markdown\n> * [Multi Window Mode](#multi-window-mode)\n> * [Keyboard Shortcuts](#keyboard-shortcuts)\n> * [Emoji Packs](#emoji-packs)\n> ```\n\n`s/emoji/Emoticons/` ?\n\n---\n\n*[doc/user_manual_en.md, line 365 at r1](https://reviewable.io:443/reviews/qtox/qtox/3737#-KSJ9AuVJLTp3YJatqQK:-KSJ9AuVJLTp3YJatqQL:b2bc6ta) ([raw file](https://github.com/qtox/qtox/blob/1ba524e4d3763f84275ab066638c51c01824e877/doc/user_manual_en.md#L365)):*\n> ```Markdown\n> \n> qTox provides support for custom emoji packs. To install a new emoji pack\n> put it in `%appdata%/roaming/tox/emoji` for Windows or `~/.config/tox/emoji`\n> ```\n\n`~/.config/` is not the place where emoticons should go.  [`XDG_DATA_HOME`](https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html) can be used for it.\n\n---\n\n*[doc/user_manual_en.md, line 367 at r1](https://reviewable.io:443/reviews/qtox/qtox/3737#-KSJAENOG4U7O8gkyQBB:-KSJAENPog-jIipLSz6U:bkkmzs4) ([raw file](https://github.com/qtox/qtox/blob/1ba524e4d3763f84275ab066638c51c01824e877/doc/user_manual_en.md#L367)):*\n> ```Markdown\n> put it in `%appdata%/roaming/tox/emoji` for Windows or `~/.config/tox/emoji`\n> for Linux. The emoji files have to be in a subfolder also containing\n> `emoticon.xml`, see the structure of https://github.com/qTox/qTox/tree/4ecbf616dcf2594cf0e65cedeb7ddc7281532c37/smileys\n> ```\n\nCan be formatted:\n\n```\n`emoticon.xml`, see the structure of\nhttps://github.com/qTox/qTox/tree/4ecbf616dcf2594cf0e65cede/smileys for further\ninformation.\n```\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/qtox/qtox/3737)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"zetok"}}