{"action":"created","comment":{"url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/comments/57375765","id":57375765,"diff_hunk":"@@ -1644,28 +1644,31 @@ module.exports = function (config) {\n \n       }\n \n-      var suspend = null;\n-      var resume = null;\n       for(var s in data.suspendResumeRecords) {\n         var suspendresumedatum = data.suspendResumeRecords[s];\n \n-        suspend = cfg.builder.makeDeviceEventSuspend()\n-          .with_deviceTime(suspendresumedatum.suspendDeviceTime)\n-          .with_reason({suspended: 'manual'})\n-          .set('index', suspendresumedatum.index);\n-        cfg.tzoUtil.fillInUTCInfo(suspend, suspendresumedatum.suspendJsDate);\n-        suspend = suspend.done();\n-        postrecords.push(suspend);\n-\n         if(suspendresumedatum.resumeJsDate > suspendresumedatum.suspendJsDate) {\n+          var suspendResume = cfg.builder.makeDeviceEventSuspendResume()\n+            .with_deviceTime(suspendresumedatum.suspendDeviceTime)\n+            .with_reason({suspended: 'manual', resumed: 'manual'})\n+            .with_duration(suspendresumedatum.resumeJsDate - suspendresumedatum.suspendJsDate)\n+            .with_payload({\n+              resumeDeviceTime : suspendresumedatum.resumeDeviceTime\n+            })\n+            .set('index', suspendresumedatum.index);\n+          cfg.tzoUtil.fillInUTCInfo(suspendResume, suspendresumedatum.suspendJsDate);\n+          postrecords.push(suspendResume.done());\n+        }\n+        else {","path":"lib/drivers/animasDriver.js","position":29,"original_position":29,"commit_id":"45422593cccab0b7bd1657ab4e640b80a09a4fd2","original_commit_id":"45422593cccab0b7bd1657ab4e640b80a09a4fd2","user":{"login":"jebeck","id":1588547,"avatar_url":"https://avatars.githubusercontent.com/u/1588547?v=3","gravatar_id":"","url":"https://api.github.com/users/jebeck","html_url":"https://github.com/jebeck","followers_url":"https://api.github.com/users/jebeck/followers","following_url":"https://api.github.com/users/jebeck/following{/other_user}","gists_url":"https://api.github.com/users/jebeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jebeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebeck/subscriptions","organizations_url":"https://api.github.com/users/jebeck/orgs","repos_url":"https://api.github.com/users/jebeck/repos","events_url":"https://api.github.com/users/jebeck/events{/privacy}","received_events_url":"https://api.github.com/users/jebeck/received_events","type":"User","site_admin":false},"body":"So remind me, when you set the clock back after a suspend, is the resume date the same Jan 1, 2007 as it is when there's no resume (e.g., before uploading) or is it just a date before the suspend? If the latter, do we want to treat it slightly differently? Stick the out-of-order resume in the payload at least?","created_at":"2016-03-24T19:39:22Z","updated_at":"2016-03-24T19:39:22Z","html_url":"https://github.com/tidepool-org/chrome-uploader/pull/257#discussion_r57375765","pull_request_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/comments/57375765"},"html":{"href":"https://github.com/tidepool-org/chrome-uploader/pull/257#discussion_r57375765"},"pull_request":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257","id":63706609,"html_url":"https://github.com/tidepool-org/chrome-uploader/pull/257","diff_url":"https://github.com/tidepool-org/chrome-uploader/pull/257.diff","patch_url":"https://github.com/tidepool-org/chrome-uploader/pull/257.patch","issue_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/257","number":257,"state":"open","locked":false,"title":"Joining Animas suspend/resume events","user":{"login":"gniezen","id":418233,"avatar_url":"https://avatars.githubusercontent.com/u/418233?v=3","gravatar_id":"","url":"https://api.github.com/users/gniezen","html_url":"https://github.com/gniezen","followers_url":"https://api.github.com/users/gniezen/followers","following_url":"https://api.github.com/users/gniezen/following{/other_user}","gists_url":"https://api.github.com/users/gniezen/gists{/gist_id}","starred_url":"https://api.github.com/users/gniezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gniezen/subscriptions","organizations_url":"https://api.github.com/users/gniezen/orgs","repos_url":"https://api.github.com/users/gniezen/repos","events_url":"https://api.github.com/users/gniezen/events{/privacy}","received_events_url":"https://api.github.com/users/gniezen/received_events","type":"User","site_admin":false},"body":"We need to do this in Uploader, as we're uploading these to the Data Service API and cannot use the Jellyfish functionality.","created_at":"2016-03-22T11:41:39Z","updated_at":"2016-03-24T19:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b92bba667f2caadef74448a4a2555efb4f9ad3bc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257/commits","review_comments_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257/comments","review_comment_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/257/comments","statuses_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/statuses/45422593cccab0b7bd1657ab4e640b80a09a4fd2","head":{"label":"tidepool-org:gniezen/animas-join-suspend-resume","ref":"gniezen/animas-join-suspend-resume","sha":"45422593cccab0b7bd1657ab4e640b80a09a4fd2","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20790599,"name":"chrome-uploader","full_name":"tidepool-org/chrome-uploader","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/chrome-uploader","description":"A Chrome app for uploading diabetes device data to Tidepool's backend","fork":false,"url":"https://api.github.com/repos/tidepool-org/chrome-uploader","forks_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/forks","keys_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/teams","hooks_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/events","assignees_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/tags","blobs_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/subscription","commits_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/merges","archive_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/downloads","issues_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/releases{/id}","deployments_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/deployments","created_at":"2014-06-13T03:12:49Z","updated_at":"2016-02-08T19:46:27Z","pushed_at":"2016-03-24T15:42:14Z","git_url":"git://github.com/tidepool-org/chrome-uploader.git","ssh_url":"git@github.com:tidepool-org/chrome-uploader.git","clone_url":"https://github.com/tidepool-org/chrome-uploader.git","svn_url":"https://github.com/tidepool-org/chrome-uploader","homepage":"","size":5842,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":12,"forks":20,"open_issues":12,"watchers":18,"default_branch":"master"}},"base":{"label":"tidepool-org:gniezen/animas-data-services","ref":"gniezen/animas-data-services","sha":"023d93c0dacbeeae5f81d0da9dee383124daf8b1","user":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20790599,"name":"chrome-uploader","full_name":"tidepool-org/chrome-uploader","owner":{"login":"tidepool-org","id":4390820,"avatar_url":"https://avatars.githubusercontent.com/u/4390820?v=3","gravatar_id":"","url":"https://api.github.com/users/tidepool-org","html_url":"https://github.com/tidepool-org","followers_url":"https://api.github.com/users/tidepool-org/followers","following_url":"https://api.github.com/users/tidepool-org/following{/other_user}","gists_url":"https://api.github.com/users/tidepool-org/gists{/gist_id}","starred_url":"https://api.github.com/users/tidepool-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tidepool-org/subscriptions","organizations_url":"https://api.github.com/users/tidepool-org/orgs","repos_url":"https://api.github.com/users/tidepool-org/repos","events_url":"https://api.github.com/users/tidepool-org/events{/privacy}","received_events_url":"https://api.github.com/users/tidepool-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tidepool-org/chrome-uploader","description":"A Chrome app for uploading diabetes device data to Tidepool's backend","fork":false,"url":"https://api.github.com/repos/tidepool-org/chrome-uploader","forks_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/forks","keys_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/teams","hooks_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/hooks","issue_events_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/events{/number}","events_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/events","assignees_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/assignees{/user}","branches_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/branches{/branch}","tags_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/tags","blobs_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/refs{/sha}","trees_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/statuses/{sha}","languages_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/languages","stargazers_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/stargazers","contributors_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/contributors","subscribers_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/subscribers","subscription_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/subscription","commits_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/commits{/sha}","git_commits_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/git/commits{/sha}","comments_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/comments{/number}","issue_comment_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/comments{/number}","contents_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/contents/{+path}","compare_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/merges","archive_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/downloads","issues_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues{/number}","pulls_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls{/number}","milestones_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/milestones{/number}","notifications_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/labels{/name}","releases_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/releases{/id}","deployments_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/deployments","created_at":"2014-06-13T03:12:49Z","updated_at":"2016-02-08T19:46:27Z","pushed_at":"2016-03-24T15:42:14Z","git_url":"git://github.com/tidepool-org/chrome-uploader.git","ssh_url":"git@github.com:tidepool-org/chrome-uploader.git","clone_url":"https://github.com/tidepool-org/chrome-uploader.git","svn_url":"https://github.com/tidepool-org/chrome-uploader","homepage":"","size":5842,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":12,"forks":20,"open_issues":12,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257"},"html":{"href":"https://github.com/tidepool-org/chrome-uploader/pull/257"},"issue":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/257"},"comments":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/tidepool-org/chrome-uploader/statuses/45422593cccab0b7bd1657ab4e640b80a09a4fd2"}}}}