{"action":"created","issue":{"url":"https://api.github.com/repos/sd16spring/TextMining/issues/15","repository_url":"https://api.github.com/repos/sd16spring/TextMining","labels_url":"https://api.github.com/repos/sd16spring/TextMining/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/sd16spring/TextMining/issues/15/comments","events_url":"https://api.github.com/repos/sd16spring/TextMining/issues/15/events","html_url":"https://github.com/sd16spring/TextMining/pull/15","id":136276431,"number":15,"title":"Text Mining Mini Project","user":{"login":"emilykohler","id":16826067,"avatar_url":"https://avatars.githubusercontent.com/u/16826067?v=3","gravatar_id":"","url":"https://api.github.com/users/emilykohler","html_url":"https://github.com/emilykohler","followers_url":"https://api.github.com/users/emilykohler/followers","following_url":"https://api.github.com/users/emilykohler/following{/other_user}","gists_url":"https://api.github.com/users/emilykohler/gists{/gist_id}","starred_url":"https://api.github.com/users/emilykohler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilykohler/subscriptions","organizations_url":"https://api.github.com/users/emilykohler/orgs","repos_url":"https://api.github.com/users/emilykohler/repos","events_url":"https://api.github.com/users/emilykohler/events{/privacy}","received_events_url":"https://api.github.com/users/emilykohler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-25T04:21:25Z","updated_at":"2016-03-21T15:43:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sd16spring/TextMining/pulls/15","html_url":"https://github.com/sd16spring/TextMining/pull/15","diff_url":"https://github.com/sd16spring/TextMining/pull/15.diff","patch_url":"https://github.com/sd16spring/TextMining/pull/15.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/sd16spring/textmining/15)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sd16spring/TextMining/issues/comments/199346353","html_url":"https://github.com/sd16spring/TextMining/pull/15#issuecomment-199346353","issue_url":"https://api.github.com/repos/sd16spring/TextMining/issues/15","id":199346353,"user":{"login":"YuzhongHuang","id":8729902,"avatar_url":"https://avatars.githubusercontent.com/u/8729902?v=3","gravatar_id":"","url":"https://api.github.com/users/YuzhongHuang","html_url":"https://github.com/YuzhongHuang","followers_url":"https://api.github.com/users/YuzhongHuang/followers","following_url":"https://api.github.com/users/YuzhongHuang/following{/other_user}","gists_url":"https://api.github.com/users/YuzhongHuang/gists{/gist_id}","starred_url":"https://api.github.com/users/YuzhongHuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YuzhongHuang/subscriptions","organizations_url":"https://api.github.com/users/YuzhongHuang/orgs","repos_url":"https://api.github.com/users/YuzhongHuang/repos","events_url":"https://api.github.com/users/YuzhongHuang/events{/privacy}","received_events_url":"https://api.github.com/users/YuzhongHuang/received_events","type":"User","site_admin":false},"created_at":"2016-03-21T15:43:16Z","updated_at":"2016-03-21T15:43:16Z","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n*[a discussion](https://reviewable.io:443/reviews/sd16spring/textmining/15#-KDOoLlBUs4M8sMC5Tzd:-KDOoLlBUs4M8sMC5Tze:2071123345) (no related file):*\nInteresting project. Code looks good overall. Some code is unnecessary and can be replaced with more concise code. I've suggested some changes in the comments. Please take a look. Deletes the unused testing code for final turn in the future. Great job overall. Looking forward for your future work!\n\n---\n\n*[text_analysis.py, line 2 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/textmining/15#-KDM-bQSI2i217LXjZxg:-KDM-bQSI2i217LXjZxh:1506814761) ([raw file](https://github.com/sd16spring/textmining/blob/32cdc8df66d1e375a3e80965b3fb2453d98292d1/text_analysis.py#L2)):*\nA brief description of what does the code do overall would be helpful for others to understand\n\n---\n\n*[text_analysis.py, line 23 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/textmining/15#-KDOkSm9fo5FMXm6UsLM:-KDOkSm9fo5FMXm6UsLN:-1952757504) ([raw file](https://github.com/sd16spring/textmining/blob/32cdc8df66d1e375a3e80965b3fb2453d98292d1/text_analysis.py#L23)):*\nDelete unused code for final turn in.\n\n---\n\n*[text_analysis.py, line 69 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/textmining/15#-KDOlFAQ6BQqWG8GFx5s:-KDOlFATP0cF-8xa3AjZ:223384674) ([raw file](https://github.com/sd16spring/textmining/blob/32cdc8df66d1e375a3e80965b3fb2453d98292d1/text_analysis.py#L69)):*\nWhy not call pickle_simple_text in pickle_url instead of writing the code again?\n\n---\n\n*[text_analysis.py, line 95 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/textmining/15#-KDOm8qaRVqN3EwrSGb0:-KDOm8qbPyZLS-zFxYET:1553474035) ([raw file](https://github.com/sd16spring/textmining/blob/32cdc8df66d1e375a3e80965b3fb2453d98292d1/text_analysis.py#L95)):*\nYou can use .get method to simplify the try except  syntax as you used before.\n\n---\n\n*[text_analysis.py, line 177 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/textmining/15#-KDOnawxRsQWyeIpdUU2:-KDOnawybwhxCZ8mq3mY:-1179512125) ([raw file](https://github.com/sd16spring/textmining/blob/32cdc8df66d1e375a3e80965b3fb2453d98292d1/text_analysis.py#L177)):*\nThe step to store the strings to another variable seems unnecessary?\n\n---\n\n*[text_analysis.py, line 197 \\[r1\\]](https://reviewable.io:443/reviews/sd16spring/textmining/15#-KDOo8uo9KyztA5OCvqQ:-KDOo8upO5weT0zT0Zuv:2048094025) ([raw file](https://github.com/sd16spring/textmining/blob/32cdc8df66d1e375a3e80965b3fb2453d98292d1/text_analysis.py#L197)):*\nAdding some comments when calculates the cosine similarity here will be helpful\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/sd16spring/textmining/15)*\n<!-- Sent from Reviewable.io -->\n"}}