{"action":"created","issue":{"url":"https://api.github.com/repos/elegantthemes/Divi-Beta/issues/867","repository_url":"https://api.github.com/repos/elegantthemes/Divi-Beta","labels_url":"https://api.github.com/repos/elegantthemes/Divi-Beta/issues/867/labels{/name}","comments_url":"https://api.github.com/repos/elegantthemes/Divi-Beta/issues/867/comments","events_url":"https://api.github.com/repos/elegantthemes/Divi-Beta/issues/867/events","html_url":"https://github.com/elegantthemes/Divi-Beta/issues/867","id":197800249,"number":867,"title":"VB :: tinyMCE error appears in some cases","user":{"login":"SlavaET","id":3446682,"avatar_url":"https://avatars.githubusercontent.com/u/3446682?v=3","gravatar_id":"","url":"https://api.github.com/users/SlavaET","html_url":"https://github.com/SlavaET","followers_url":"https://api.github.com/users/SlavaET/followers","following_url":"https://api.github.com/users/SlavaET/following{/other_user}","gists_url":"https://api.github.com/users/SlavaET/gists{/gist_id}","starred_url":"https://api.github.com/users/SlavaET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlavaET/subscriptions","organizations_url":"https://api.github.com/users/SlavaET/orgs","repos_url":"https://api.github.com/users/SlavaET/repos","events_url":"https://api.github.com/users/SlavaET/events{/privacy}","received_events_url":"https://api.github.com/users/SlavaET/received_events","type":"User","site_admin":false},"labels":[{"id":427134871,"url":"https://api.github.com/repos/elegantthemes/Divi-Beta/labels/BUG","name":"BUG","color":"ef5555","default":false}],"state":"open","locked":false,"assignee":{"login":"SlavaET","id":3446682,"avatar_url":"https://avatars.githubusercontent.com/u/3446682?v=3","gravatar_id":"","url":"https://api.github.com/users/SlavaET","html_url":"https://github.com/SlavaET","followers_url":"https://api.github.com/users/SlavaET/followers","following_url":"https://api.github.com/users/SlavaET/following{/other_user}","gists_url":"https://api.github.com/users/SlavaET/gists{/gist_id}","starred_url":"https://api.github.com/users/SlavaET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlavaET/subscriptions","organizations_url":"https://api.github.com/users/SlavaET/orgs","repos_url":"https://api.github.com/users/SlavaET/repos","events_url":"https://api.github.com/users/SlavaET/events{/privacy}","received_events_url":"https://api.github.com/users/SlavaET/received_events","type":"User","site_admin":false},"assignees":[{"login":"SlavaET","id":3446682,"avatar_url":"https://avatars.githubusercontent.com/u/3446682?v=3","gravatar_id":"","url":"https://api.github.com/users/SlavaET","html_url":"https://github.com/SlavaET","followers_url":"https://api.github.com/users/SlavaET/followers","following_url":"https://api.github.com/users/SlavaET/following{/other_user}","gists_url":"https://api.github.com/users/SlavaET/gists{/gist_id}","starred_url":"https://api.github.com/users/SlavaET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlavaET/subscriptions","organizations_url":"https://api.github.com/users/SlavaET/orgs","repos_url":"https://api.github.com/users/SlavaET/repos","events_url":"https://api.github.com/users/SlavaET/events{/privacy}","received_events_url":"https://api.github.com/users/SlavaET/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-12-28T05:56:51Z","updated_at":"2016-12-29T06:38:33Z","closed_at":null,"body":"### Problem:\r\nIt's quite inconsistent, but I can catch it:\r\n![tinymce-error](https://cloud.githubusercontent.com/assets/3446682/21514880/789e1188-ccf4-11e6-9b89-729298798dec.gif)\r\n\r\n### Steps To Reproduce:\r\n1. Toggle accordion items and switch between inline editors on page. Error will appear at some point."},"comment":{"url":"https://api.github.com/repos/elegantthemes/Divi-Beta/issues/comments/269588407","html_url":"https://github.com/elegantthemes/Divi-Beta/issues/867#issuecomment-269588407","issue_url":"https://api.github.com/repos/elegantthemes/Divi-Beta/issues/867","id":269588407,"user":{"login":"SlavaET","id":3446682,"avatar_url":"https://avatars.githubusercontent.com/u/3446682?v=3","gravatar_id":"","url":"https://api.github.com/users/SlavaET","html_url":"https://github.com/SlavaET","followers_url":"https://api.github.com/users/SlavaET/followers","following_url":"https://api.github.com/users/SlavaET/following{/other_user}","gists_url":"https://api.github.com/users/SlavaET/gists{/gist_id}","starred_url":"https://api.github.com/users/SlavaET/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlavaET/subscriptions","organizations_url":"https://api.github.com/users/SlavaET/orgs","repos_url":"https://api.github.com/users/SlavaET/repos","events_url":"https://api.github.com/users/SlavaET/events{/privacy}","received_events_url":"https://api.github.com/users/SlavaET/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T06:38:33Z","updated_at":"2016-12-29T06:38:33Z","body":"I found a way to reproduce this error quite consistently:\r\n1) Toggle accordion item;\r\n2) Quicly click in the opening toggle item content to activate the inline editor before the toggling animation is finished;\r\n3) Click any button in opened inline editor popover or in some other module to activate the inline editor in different place.\r\n![accordion-tinymce-error](https://cloud.githubusercontent.com/assets/3446682/21538012/86d4e898-cdc2-11e6-810e-4af47afee515.gif)\r\n\r\nAs far as I understand this error occurs because inline editor is activate too early and when the toggling animation is finished we re-render the accordion module. At that point inline editor loses the original module where it was opened and it leads to an error when you try using it or deactivating it.\r\nI added mechanism which prevents inline-editor from activating if module is not ready yet and implemented it for accordion ( this error doesn't occur in any other module as far as I can tell, even in Toggle module it works fine ).\r\nSo basically we just wait until the animation is finished and then allow to activate the inline editor disabling the ability to activate it during the module animation."}}
{"actor":{"display_login":"SlavaET"}}