{"action":"created","issue":{"url":"https://api.github.com/repos/Mirantis/k8s-AppController/issues/93","repository_url":"https://api.github.com/repos/Mirantis/k8s-AppController","labels_url":"https://api.github.com/repos/Mirantis/k8s-AppController/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/Mirantis/k8s-AppController/issues/93/comments","events_url":"https://api.github.com/repos/Mirantis/k8s-AppController/issues/93/events","html_url":"https://github.com/Mirantis/k8s-AppController/pull/93","id":181144797,"number":93,"title":"Used glide to vendor dependencies","user":{"login":"zefciu","id":135876,"avatar_url":"https://avatars.githubusercontent.com/u/135876?v=3","gravatar_id":"","url":"https://api.github.com/users/zefciu","html_url":"https://github.com/zefciu","followers_url":"https://api.github.com/users/zefciu/followers","following_url":"https://api.github.com/users/zefciu/following{/other_user}","gists_url":"https://api.github.com/users/zefciu/gists{/gist_id}","starred_url":"https://api.github.com/users/zefciu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zefciu/subscriptions","organizations_url":"https://api.github.com/users/zefciu/orgs","repos_url":"https://api.github.com/users/zefciu/repos","events_url":"https://api.github.com/users/zefciu/events{/privacy}","received_events_url":"https://api.github.com/users/zefciu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Mirantis/k8s-AppController/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-05T12:54:56Z","updated_at":"2016-10-05T13:46:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Mirantis/k8s-AppController/pulls/93","html_url":"https://github.com/Mirantis/k8s-AppController/pull/93","diff_url":"https://github.com/Mirantis/k8s-AppController/pull/93.diff","patch_url":"https://github.com/Mirantis/k8s-AppController/pull/93.patch"},"body":"In order to introduce glog (and possibly other dependencies) we need\r\na flat vendor directory (glog panics if two versions of it are\r\nimported). We decided to use glide. It seems to be developer-friendly\r\nand also offers mechanism for consistend deploys\r\n\r\nSome questions you may have:\r\n\r\nQ: What with the size of repo\r\nA: We don't store any additional code in repo. Only the hashes in\r\n   glide.lock\r\n\r\nQ: How can I use my own k8s version.\r\nA: Edit the glide.lock and put your commit hash there\r\n\r\nQ: The difference between update and install\r\nA: glide update will modify glide.lock. glide install only installs\r\n   stuff\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mirantis/k8s-appcontroller/93)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Mirantis/k8s-AppController/issues/comments/251679116","html_url":"https://github.com/Mirantis/k8s-AppController/pull/93#issuecomment-251679116","issue_url":"https://api.github.com/repos/Mirantis/k8s-AppController/issues/93","id":251679116,"user":{"login":"jellonek","id":658436,"avatar_url":"https://avatars.githubusercontent.com/u/658436?v=3","gravatar_id":"","url":"https://api.github.com/users/jellonek","html_url":"https://github.com/jellonek","followers_url":"https://api.github.com/users/jellonek/followers","following_url":"https://api.github.com/users/jellonek/following{/other_user}","gists_url":"https://api.github.com/users/jellonek/gists{/gist_id}","starred_url":"https://api.github.com/users/jellonek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jellonek/subscriptions","organizations_url":"https://api.github.com/users/jellonek/orgs","repos_url":"https://api.github.com/users/jellonek/repos","events_url":"https://api.github.com/users/jellonek/events{/privacy}","received_events_url":"https://api.github.com/users/jellonek/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T13:46:33Z","updated_at":"2016-10-05T13:46:33Z","body":"\n\n\n\nReviewed 6 of 6 files at r1.\nReview status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[Dockerfile, line 17 at r1](https://reviewable.io:443/reviews/mirantis/k8s-appcontroller/93#-KTK4HcQP-kle7kY7I1o:-KTK4HcQP-kle7kY7I1p:be1hziw) ([raw file](https://github.com/mirantis/k8s-appcontroller/blob/c081cf6ad0f6d817655f9102cc49c1f4816f31c6/Dockerfile#L17)):*\n> ```Dockerfile\n>     mv /go/src/github.com/Mirantis/k8s-AppController/manifests /opt/kubeac/manifests &&\\\n>     rm -fr /go\n> ```\n\nUnnecessary empty line.\n\n---\n\n*[README.md, line 120 at r1](https://reviewable.io:443/reviews/mirantis/k8s-appcontroller/93#-KTK3a6ZqMJ1QRsDXJ7d:-KTK3a6ZqMJ1QRsDXJ7e:be1hzkt) ([raw file](https://github.com/mirantis/k8s-appcontroller/blob/c081cf6ad0f6d817655f9102cc49c1f4816f31c6/README.md#L120)):*\n> ```Markdown\n> \n> You can also override this behaviour by using `-l` flag for `kubeac deploy` command available on AppController pod, but this should be only done for testing purposes and is not encouraged in production.\n> ```\n\nUnnecessary empty lines\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/mirantis/k8s-appcontroller/93)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jellonek"}}