{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3466","repository_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3466/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3466/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3466/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3466","id":191904477,"number":3466,"title":"Improve BiomeDictionary's interaction with the new registries","user":{"login":"diesieben07","id":1915984,"avatar_url":"https://avatars.githubusercontent.com/u/1915984?v=3","gravatar_id":"","url":"https://api.github.com/users/diesieben07","html_url":"https://github.com/diesieben07","followers_url":"https://api.github.com/users/diesieben07/followers","following_url":"https://api.github.com/users/diesieben07/following{/other_user}","gists_url":"https://api.github.com/users/diesieben07/gists{/gist_id}","starred_url":"https://api.github.com/users/diesieben07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesieben07/subscriptions","organizations_url":"https://api.github.com/users/diesieben07/orgs","repos_url":"https://api.github.com/users/diesieben07/repos","events_url":"https://api.github.com/users/diesieben07/events{/privacy}","received_events_url":"https://api.github.com/users/diesieben07/received_events","type":"User","site_admin":false},"labels":[{"id":324959623,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/BreakingChange","name":"BreakingChange","color":"f7c6c7","default":false},{"id":352069126,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Cleanup","name":"Cleanup","color":"eeeeee","default":false},{"id":306653555,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels/Feature","name":"Feature","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"assignees":[{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2016-11-28T02:04:30Z","updated_at":"2016-11-30T23:49:30Z","closed_at":"2016-11-30T23:48:44Z","pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3466","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3466","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3466.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3466.patch"},"body":"Main point here is that `BiomeDictionary.registerBiomeType` no longer silently ignores unregistered biomes without any kind of indication.\r\nAt the same time update the class to decouple from vanilla's registries and use the cleaner forge interface.\r\nThis now makes the return type redundant, should I change as part of the \"1.11.x binary change\"?\r\n\r\nThere is a lot more that's wrong with the class:\r\n\r\n- The formatting is all over the place and does not follow forge's standards.\r\n- There are unused, seemingly random methods like `registerAllBiomes`, which does nothing but log a warning.\r\n\r\nShould this be cleaned up?"},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/264034204","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3466#issuecomment-264034204","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3466","id":264034204,"user":{"login":"LexManos","id":702211,"avatar_url":"https://avatars.githubusercontent.com/u/702211?v=3","gravatar_id":"","url":"https://api.github.com/users/LexManos","html_url":"https://github.com/LexManos","followers_url":"https://api.github.com/users/LexManos/followers","following_url":"https://api.github.com/users/LexManos/following{/other_user}","gists_url":"https://api.github.com/users/LexManos/gists{/gist_id}","starred_url":"https://api.github.com/users/LexManos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LexManos/subscriptions","organizations_url":"https://api.github.com/users/LexManos/orgs","repos_url":"https://api.github.com/users/LexManos/repos","events_url":"https://api.github.com/users/LexManos/events{/privacy}","received_events_url":"https://api.github.com/users/LexManos/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T23:49:30Z","updated_at":"2016-11-30T23:49:30Z","body":"This is nothing more then a code cleanup, I don't see any 'improvements' here. However we're still {getting close to the end} of our 1.11 update phase so I guess we can accept it."}}
{"actor":{"display_login":"LexManos"}}