{"action":"created","comment":{"url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/comments/94275239","pull_request_review_id":14805540,"id":94275239,"diff_hunk":"@@ -36,6 +36,8 @@ https://github.com/FrankHassanabad/Oauth2orizeRecipes/wiki/Security-Scenarios\n * Single Sign On (SSO) Example\n * Example of trusted clients\n * REST tokeninfo endPoint for verifying a token is valid.\n-* Authorization tokens are only useable once\n+* Authorization tokens are only useable once and are short expiring JWT tokens\n+* Full tokens are NOT stored in the DB since they are JWT signed tokens.  Only ID's of tokens are.","path":"README.md","position":6,"original_position":6,"commit_id":"023bac5e701c8cbbc0b534229e71867ae259f5e0","original_commit_id":"023bac5e701c8cbbc0b534229e71867ae259f5e0","user":{"login":"FrankHassanabad","id":1151048,"avatar_url":"https://avatars.githubusercontent.com/u/1151048?v=3","gravatar_id":"","url":"https://api.github.com/users/FrankHassanabad","html_url":"https://github.com/FrankHassanabad","followers_url":"https://api.github.com/users/FrankHassanabad/followers","following_url":"https://api.github.com/users/FrankHassanabad/following{/other_user}","gists_url":"https://api.github.com/users/FrankHassanabad/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankHassanabad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankHassanabad/subscriptions","organizations_url":"https://api.github.com/users/FrankHassanabad/orgs","repos_url":"https://api.github.com/users/FrankHassanabad/repos","events_url":"https://api.github.com/users/FrankHassanabad/events{/privacy}","received_events_url":"https://api.github.com/users/FrankHassanabad/received_events","type":"User","site_admin":false},"body":"\"Only ID's of tokens are stored\"","created_at":"2016-12-31T16:08:06Z","updated_at":"2016-12-31T16:08:06Z","html_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes/pull/49#discussion_r94275239","pull_request_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/comments/94275239"},"html":{"href":"https://github.com/FrankHassanabad/Oauth2orizeRecipes/pull/49#discussion_r94275239"},"pull_request":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49","id":99807635,"html_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes/pull/49","diff_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes/pull/49.diff","patch_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes/pull/49.patch","issue_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/49","number":49,"state":"open","locked":false,"title":"Changed the code to NOT store full tokens in the data store (memory)","user":{"login":"FrankHassanabad","id":1151048,"avatar_url":"https://avatars.githubusercontent.com/u/1151048?v=3","gravatar_id":"","url":"https://api.github.com/users/FrankHassanabad","html_url":"https://github.com/FrankHassanabad","followers_url":"https://api.github.com/users/FrankHassanabad/followers","following_url":"https://api.github.com/users/FrankHassanabad/following{/other_user}","gists_url":"https://api.github.com/users/FrankHassanabad/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankHassanabad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankHassanabad/subscriptions","organizations_url":"https://api.github.com/users/FrankHassanabad/orgs","repos_url":"https://api.github.com/users/FrankHassanabad/repos","events_url":"https://api.github.com/users/FrankHassanabad/events{/privacy}","received_events_url":"https://api.github.com/users/FrankHassanabad/received_events","type":"User","site_admin":false},"body":" * This is good security practice since a breach of the DB will not lead to tokens being stolen\r\n * This is good security practice because admins of the DB do not have access to sensitive information\r\n * Reworked the unit tests to be more standard\r\n * Added removeAll to the different DB token types\r\n * Covered all the DB code now with tests","created_at":"2016-12-31T16:07:48Z","updated_at":"2016-12-31T16:08:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26da1500539d0095f7dcb0631c55fe2411a4ef45","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49/commits","review_comments_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49/comments","review_comment_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/49/comments","statuses_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/statuses/023bac5e701c8cbbc0b534229e71867ae259f5e0","head":{"label":"FrankHassanabad:only-store-accesstoken-id","ref":"only-store-accesstoken-id","sha":"023bac5e701c8cbbc0b534229e71867ae259f5e0","user":{"login":"FrankHassanabad","id":1151048,"avatar_url":"https://avatars.githubusercontent.com/u/1151048?v=3","gravatar_id":"","url":"https://api.github.com/users/FrankHassanabad","html_url":"https://github.com/FrankHassanabad","followers_url":"https://api.github.com/users/FrankHassanabad/followers","following_url":"https://api.github.com/users/FrankHassanabad/following{/other_user}","gists_url":"https://api.github.com/users/FrankHassanabad/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankHassanabad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankHassanabad/subscriptions","organizations_url":"https://api.github.com/users/FrankHassanabad/orgs","repos_url":"https://api.github.com/users/FrankHassanabad/repos","events_url":"https://api.github.com/users/FrankHassanabad/events{/privacy}","received_events_url":"https://api.github.com/users/FrankHassanabad/received_events","type":"User","site_admin":false},"repo":{"id":11940974,"name":"Oauth2orizeRecipes","full_name":"FrankHassanabad/Oauth2orizeRecipes","owner":{"login":"FrankHassanabad","id":1151048,"avatar_url":"https://avatars.githubusercontent.com/u/1151048?v=3","gravatar_id":"","url":"https://api.github.com/users/FrankHassanabad","html_url":"https://github.com/FrankHassanabad","followers_url":"https://api.github.com/users/FrankHassanabad/followers","following_url":"https://api.github.com/users/FrankHassanabad/following{/other_user}","gists_url":"https://api.github.com/users/FrankHassanabad/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankHassanabad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankHassanabad/subscriptions","organizations_url":"https://api.github.com/users/FrankHassanabad/orgs","repos_url":"https://api.github.com/users/FrankHassanabad/repos","events_url":"https://api.github.com/users/FrankHassanabad/events{/privacy}","received_events_url":"https://api.github.com/users/FrankHassanabad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes","description":"OAuth2 security recipes and examples based on OAuth2orize","fork":false,"url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes","forks_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/forks","keys_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/teams","hooks_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/hooks","issue_events_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/events{/number}","events_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/events","assignees_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/assignees{/user}","branches_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/branches{/branch}","tags_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/tags","blobs_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/statuses/{sha}","languages_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/languages","stargazers_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/stargazers","contributors_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/contributors","subscribers_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/subscribers","subscription_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/subscription","commits_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/contents/{+path}","compare_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/merges","archive_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/downloads","issues_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues{/number}","pulls_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls{/number}","milestones_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/milestones{/number}","notifications_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/labels{/name}","releases_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/releases{/id}","deployments_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/deployments","created_at":"2013-08-07T04:01:13Z","updated_at":"2016-12-26T13:24:54Z","pushed_at":"2016-12-31T16:07:48Z","git_url":"git://github.com/FrankHassanabad/Oauth2orizeRecipes.git","ssh_url":"git@github.com:FrankHassanabad/Oauth2orizeRecipes.git","clone_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes.git","svn_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes","homepage":null,"size":411,"stargazers_count":193,"watchers_count":193,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":1,"forks":40,"open_issues":1,"watchers":193,"default_branch":"master"}},"base":{"label":"FrankHassanabad:master","ref":"master","sha":"92441735c83911e7470b0f9259f3c64dcf8338de","user":{"login":"FrankHassanabad","id":1151048,"avatar_url":"https://avatars.githubusercontent.com/u/1151048?v=3","gravatar_id":"","url":"https://api.github.com/users/FrankHassanabad","html_url":"https://github.com/FrankHassanabad","followers_url":"https://api.github.com/users/FrankHassanabad/followers","following_url":"https://api.github.com/users/FrankHassanabad/following{/other_user}","gists_url":"https://api.github.com/users/FrankHassanabad/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankHassanabad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankHassanabad/subscriptions","organizations_url":"https://api.github.com/users/FrankHassanabad/orgs","repos_url":"https://api.github.com/users/FrankHassanabad/repos","events_url":"https://api.github.com/users/FrankHassanabad/events{/privacy}","received_events_url":"https://api.github.com/users/FrankHassanabad/received_events","type":"User","site_admin":false},"repo":{"id":11940974,"name":"Oauth2orizeRecipes","full_name":"FrankHassanabad/Oauth2orizeRecipes","owner":{"login":"FrankHassanabad","id":1151048,"avatar_url":"https://avatars.githubusercontent.com/u/1151048?v=3","gravatar_id":"","url":"https://api.github.com/users/FrankHassanabad","html_url":"https://github.com/FrankHassanabad","followers_url":"https://api.github.com/users/FrankHassanabad/followers","following_url":"https://api.github.com/users/FrankHassanabad/following{/other_user}","gists_url":"https://api.github.com/users/FrankHassanabad/gists{/gist_id}","starred_url":"https://api.github.com/users/FrankHassanabad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrankHassanabad/subscriptions","organizations_url":"https://api.github.com/users/FrankHassanabad/orgs","repos_url":"https://api.github.com/users/FrankHassanabad/repos","events_url":"https://api.github.com/users/FrankHassanabad/events{/privacy}","received_events_url":"https://api.github.com/users/FrankHassanabad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes","description":"OAuth2 security recipes and examples based on OAuth2orize","fork":false,"url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes","forks_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/forks","keys_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/teams","hooks_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/hooks","issue_events_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/events{/number}","events_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/events","assignees_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/assignees{/user}","branches_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/branches{/branch}","tags_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/tags","blobs_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/statuses/{sha}","languages_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/languages","stargazers_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/stargazers","contributors_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/contributors","subscribers_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/subscribers","subscription_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/subscription","commits_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/contents/{+path}","compare_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/merges","archive_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/downloads","issues_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues{/number}","pulls_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls{/number}","milestones_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/milestones{/number}","notifications_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/labels{/name}","releases_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/releases{/id}","deployments_url":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/deployments","created_at":"2013-08-07T04:01:13Z","updated_at":"2016-12-26T13:24:54Z","pushed_at":"2016-12-31T16:07:48Z","git_url":"git://github.com/FrankHassanabad/Oauth2orizeRecipes.git","ssh_url":"git@github.com:FrankHassanabad/Oauth2orizeRecipes.git","clone_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes.git","svn_url":"https://github.com/FrankHassanabad/Oauth2orizeRecipes","homepage":null,"size":411,"stargazers_count":193,"watchers_count":193,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":1,"forks":40,"open_issues":1,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49"},"html":{"href":"https://github.com/FrankHassanabad/Oauth2orizeRecipes/pull/49"},"issue":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/49"},"comments":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/FrankHassanabad/Oauth2orizeRecipes/statuses/023bac5e701c8cbbc0b534229e71867ae259f5e0"}}}}
{"actor":{"display_login":"FrankHassanabad"}}