{"action":"created","issue":{"url":"https://api.github.com/repos/tablexi/nucore-open/issues/765","repository_url":"https://api.github.com/repos/tablexi/nucore-open","labels_url":"https://api.github.com/repos/tablexi/nucore-open/issues/765/labels{/name}","comments_url":"https://api.github.com/repos/tablexi/nucore-open/issues/765/comments","events_url":"https://api.github.com/repos/tablexi/nucore-open/issues/765/events","html_url":"https://github.com/tablexi/nucore-open/pull/765","id":173561334,"number":765,"title":"[#127094] Normal users could place orders in the past","user":{"login":"jhanggi","id":1099111,"avatar_url":"https://avatars.githubusercontent.com/u/1099111?v=3","gravatar_id":"","url":"https://api.github.com/users/jhanggi","html_url":"https://github.com/jhanggi","followers_url":"https://api.github.com/users/jhanggi/followers","following_url":"https://api.github.com/users/jhanggi/following{/other_user}","gists_url":"https://api.github.com/users/jhanggi/gists{/gist_id}","starred_url":"https://api.github.com/users/jhanggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhanggi/subscriptions","organizations_url":"https://api.github.com/users/jhanggi/orgs","repos_url":"https://api.github.com/users/jhanggi/repos","events_url":"https://api.github.com/users/jhanggi/events{/privacy}","received_events_url":"https://api.github.com/users/jhanggi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-26T23:18:25Z","updated_at":"2016-08-30T15:26:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tablexi/nucore-open/pulls/765","html_url":"https://github.com/tablexi/nucore-open/pull/765","diff_url":"https://github.com/tablexi/nucore-open/pull/765.diff","patch_url":"https://github.com/tablexi/nucore-open/pull/765.patch"},"body":"The big problem is that the account assignment on `order_detail` was autosaving the reservation without enforcing the non-admin validations (`save_as_user`).\r\n\r\nThe first idea I tried was doing `update_column`s so callbacks didn't get triggered, but it turns out we do need validations.\r\n\r\nNext idea was flipping `save` and `save_with_extended_validations` so the extended validations (in the future and within 14 day window) are enforced by default, but not when purchasing as an admin. However, too many of our tests rely on those validations not being enforced as part of setup.\r\n\r\nThis refactor makes sure that `reservation` is not built until the last moment possible.\r\n"},"comment":{"url":"https://api.github.com/repos/tablexi/nucore-open/issues/comments/243478016","html_url":"https://github.com/tablexi/nucore-open/pull/765#issuecomment-243478016","issue_url":"https://api.github.com/repos/tablexi/nucore-open/issues/765","id":243478016,"user":{"login":"drench","id":46662,"avatar_url":"https://avatars.githubusercontent.com/u/46662?v=3","gravatar_id":"","url":"https://api.github.com/users/drench","html_url":"https://github.com/drench","followers_url":"https://api.github.com/users/drench/followers","following_url":"https://api.github.com/users/drench/following{/other_user}","gists_url":"https://api.github.com/users/drench/gists{/gist_id}","starred_url":"https://api.github.com/users/drench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drench/subscriptions","organizations_url":"https://api.github.com/users/drench/orgs","repos_url":"https://api.github.com/users/drench/repos","events_url":"https://api.github.com/users/drench/events{/privacy}","received_events_url":"https://api.github.com/users/drench/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T15:26:14Z","updated_at":"2016-08-30T15:26:14Z","body":"Nice extraction and cleanup. One comment on test coverage."}}
{"actor":{"display_login":"drench"}}