{"action":"closed","number":4293,"pull_request":{"url":"https://api.github.com/repos/coreos/etcd/pulls/4293","id":57279219,"html_url":"https://github.com/coreos/etcd/pull/4293","diff_url":"https://github.com/coreos/etcd/pull/4293.diff","patch_url":"https://github.com/coreos/etcd/pull/4293.patch","issue_url":"https://api.github.com/repos/coreos/etcd/issues/4293","number":4293,"state":"closed","locked":false,"title":"raft: Always call bcastAppend after maybeCommit","user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"body":"Mentioned in #4278, although not apparently linked to any test failure.\r\n\r\nI tried moving most `bcastAppend` calls into `appendEntry` but that caused a bunch of tests to fail.","created_at":"2016-01-26T21:57:58Z","updated_at":"2016-01-27T17:58:22Z","closed_at":"2016-01-27T17:58:22Z","merged_at":"2016-01-27T17:58:22Z","merge_commit_sha":"2e5cfb51ee728cad913b2deeff7e59b8a71652c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/etcd/pulls/4293/commits","review_comments_url":"https://api.github.com/repos/coreos/etcd/pulls/4293/comments","review_comment_url":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/etcd/issues/4293/comments","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/0771d713e6a2cafaa0546e01c1e39afec67212c3","head":{"label":"bdarnell:bcast-after-commit","ref":"bcast-after-commit","sha":"0771d713e6a2cafaa0546e01c1e39afec67212c3","user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"repo":{"id":24914743,"name":"etcd","full_name":"bdarnell/etcd","owner":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdarnell/etcd","description":"A highly-available key value store for shared configuration and service discovery","fork":true,"url":"https://api.github.com/repos/bdarnell/etcd","forks_url":"https://api.github.com/repos/bdarnell/etcd/forks","keys_url":"https://api.github.com/repos/bdarnell/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdarnell/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdarnell/etcd/teams","hooks_url":"https://api.github.com/repos/bdarnell/etcd/hooks","issue_events_url":"https://api.github.com/repos/bdarnell/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/bdarnell/etcd/events","assignees_url":"https://api.github.com/repos/bdarnell/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/bdarnell/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/bdarnell/etcd/tags","blobs_url":"https://api.github.com/repos/bdarnell/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdarnell/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdarnell/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdarnell/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdarnell/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/bdarnell/etcd/languages","stargazers_url":"https://api.github.com/repos/bdarnell/etcd/stargazers","contributors_url":"https://api.github.com/repos/bdarnell/etcd/contributors","subscribers_url":"https://api.github.com/repos/bdarnell/etcd/subscribers","subscription_url":"https://api.github.com/repos/bdarnell/etcd/subscription","commits_url":"https://api.github.com/repos/bdarnell/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdarnell/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdarnell/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdarnell/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdarnell/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/bdarnell/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdarnell/etcd/merges","archive_url":"https://api.github.com/repos/bdarnell/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdarnell/etcd/downloads","issues_url":"https://api.github.com/repos/bdarnell/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/bdarnell/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/bdarnell/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/bdarnell/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdarnell/etcd/labels{/name}","releases_url":"https://api.github.com/repos/bdarnell/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/bdarnell/etcd/deployments","created_at":"2014-10-07T22:38:59Z","updated_at":"2014-10-07T21:58:44Z","pushed_at":"2016-01-26T21:56:29Z","git_url":"git://github.com/bdarnell/etcd.git","ssh_url":"git@github.com:bdarnell/etcd.git","clone_url":"https://github.com/bdarnell/etcd.git","svn_url":"https://github.com/bdarnell/etcd","homepage":"","size":19968,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"179a8f97689d3cb7293ec31d38417cb0d0a767a6","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"name":"etcd","full_name":"coreos/etcd","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/coreos/etcd","forks_url":"https://api.github.com/repos/coreos/etcd/forks","keys_url":"https://api.github.com/repos/coreos/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/etcd/teams","hooks_url":"https://api.github.com/repos/coreos/etcd/hooks","issue_events_url":"https://api.github.com/repos/coreos/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/etcd/events","assignees_url":"https://api.github.com/repos/coreos/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/etcd/tags","blobs_url":"https://api.github.com/repos/coreos/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/etcd/languages","stargazers_url":"https://api.github.com/repos/coreos/etcd/stargazers","contributors_url":"https://api.github.com/repos/coreos/etcd/contributors","subscribers_url":"https://api.github.com/repos/coreos/etcd/subscribers","subscription_url":"https://api.github.com/repos/coreos/etcd/subscription","commits_url":"https://api.github.com/repos/coreos/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/etcd/merges","archive_url":"https://api.github.com/repos/coreos/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/etcd/downloads","issues_url":"https://api.github.com/repos/coreos/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/etcd/labels{/name}","releases_url":"https://api.github.com/repos/coreos/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2016-01-27T15:56:45Z","pushed_at":"2016-01-27T17:58:22Z","git_url":"git://github.com/coreos/etcd.git","ssh_url":"git@github.com:coreos/etcd.git","clone_url":"https://github.com/coreos/etcd.git","svn_url":"https://github.com/coreos/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":22905,"stargazers_count":8570,"watchers_count":8570,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1384,"mirror_url":null,"open_issues_count":153,"forks":1384,"open_issues":153,"watchers":8570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4293"},"html":{"href":"https://github.com/coreos/etcd/pull/4293"},"issue":{"href":"https://api.github.com/repos/coreos/etcd/issues/4293"},"comments":{"href":"https://api.github.com/repos/coreos/etcd/issues/4293/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4293/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/etcd/pulls/4293/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/etcd/statuses/0771d713e6a2cafaa0546e01c1e39afec67212c3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"xiang90","id":4479947,"avatar_url":"https://avatars.githubusercontent.com/u/4479947?v=3","gravatar_id":"","url":"https://api.github.com/users/xiang90","html_url":"https://github.com/xiang90","followers_url":"https://api.github.com/users/xiang90/followers","following_url":"https://api.github.com/users/xiang90/following{/other_user}","gists_url":"https://api.github.com/users/xiang90/gists{/gist_id}","starred_url":"https://api.github.com/users/xiang90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiang90/subscriptions","organizations_url":"https://api.github.com/users/xiang90/orgs","repos_url":"https://api.github.com/users/xiang90/repos","events_url":"https://api.github.com/users/xiang90/events{/privacy}","received_events_url":"https://api.github.com/users/xiang90/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":1,"changed_files":1}}