{"action":"created","issue":{"url":"https://api.github.com/repos/Haroenv/config/issues/1","repository_url":"https://api.github.com/repos/Haroenv/config","labels_url":"https://api.github.com/repos/Haroenv/config/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Haroenv/config/issues/1/comments","events_url":"https://api.github.com/repos/Haroenv/config/issues/1/events","html_url":"https://github.com/Haroenv/config/issues/1","id":141528374,"number":1,"title":"clean up aliases","user":{"login":"Haroenv","id":6270048,"avatar_url":"https://avatars.githubusercontent.com/u/6270048?v=3","gravatar_id":"","url":"https://api.github.com/users/Haroenv","html_url":"https://github.com/Haroenv","followers_url":"https://api.github.com/users/Haroenv/followers","following_url":"https://api.github.com/users/Haroenv/following{/other_user}","gists_url":"https://api.github.com/users/Haroenv/gists{/gist_id}","starred_url":"https://api.github.com/users/Haroenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haroenv/subscriptions","organizations_url":"https://api.github.com/users/Haroenv/orgs","repos_url":"https://api.github.com/users/Haroenv/repos","events_url":"https://api.github.com/users/Haroenv/events{/privacy}","received_events_url":"https://api.github.com/users/Haroenv/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Haroenv/config/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-17T09:33:51Z","updated_at":"2016-03-17T09:43:48Z","closed_at":null,"body":"convert to functions:\r\n\r\n>I guess you know how to do basic translations like export to set -x in fish, and using regular functions instead of alias (although you could use alias in fish, too, but functions will perform faster due to fish lazy loading).\r\n\r\n>Functions should go into ~/.config/functions so that fish can lazy load them, which is faster than forcing the shell to run all of that at startup.\r\n\r\n@bucaran"},"comment":{"url":"https://api.github.com/repos/Haroenv/config/issues/comments/197791102","html_url":"https://github.com/Haroenv/config/issues/1#issuecomment-197791102","issue_url":"https://api.github.com/repos/Haroenv/config/issues/1","id":197791102,"user":{"login":"bucaran","id":8317250,"avatar_url":"https://avatars.githubusercontent.com/u/8317250?v=3","gravatar_id":"","url":"https://api.github.com/users/bucaran","html_url":"https://github.com/bucaran","followers_url":"https://api.github.com/users/bucaran/followers","following_url":"https://api.github.com/users/bucaran/following{/other_user}","gists_url":"https://api.github.com/users/bucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/bucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bucaran/subscriptions","organizations_url":"https://api.github.com/users/bucaran/orgs","repos_url":"https://api.github.com/users/bucaran/repos","events_url":"https://api.github.com/users/bucaran/events{/privacy}","received_events_url":"https://api.github.com/users/bucaran/received_events","type":"User","site_admin":false},"created_at":"2016-03-17T09:43:48Z","updated_at":"2016-03-17T09:43:48Z","body":"This is a solid start.\r\n\r\nSo, now that you are on board with me, let me point out that fish has no concept of \"private\" functions, everything is global, for example, those functions you define inside `fish_prompt` will be created every time `fish_prompt` runs, i.e, every time. \r\n\r\nNothing extremely awful about that, as long as you give them a nice `__my_thing`-like prefix you will not run into anything ever.\r\n\r\nAlso, **be careful** when committing your history file to GitHub, passwords or access tokens could creep in there easily.\r\n\r\n"}}