{"action":"opened","number":78,"pull_request":{"url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/78","id":56313048,"html_url":"https://github.com/percona/percona-xtradb-cluster/pull/78","diff_url":"https://github.com/percona/percona-xtradb-cluster/pull/78.diff","patch_url":"https://github.com/percona/percona-xtradb-cluster/pull/78.patch","issue_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/78","number":78,"state":"open","locked":false,"title":"- PXC#490: crash-safe slaves: relay_log_recovery breaks replication (…","user":{"login":"kbauskar","id":14107301,"avatar_url":"https://avatars.githubusercontent.com/u/14107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kbauskar","html_url":"https://github.com/kbauskar","followers_url":"https://api.github.com/users/kbauskar/followers","following_url":"https://api.github.com/users/kbauskar/following{/other_user}","gists_url":"https://api.github.com/users/kbauskar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbauskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbauskar/subscriptions","organizations_url":"https://api.github.com/users/kbauskar/orgs","repos_url":"https://api.github.com/users/kbauskar/repos","events_url":"https://api.github.com/users/kbauskar/events{/privacy}","received_events_url":"https://api.github.com/users/kbauskar/received_events","type":"User","site_admin":false},"body":"…CID#62894)\r\n\r\n  Issue:\r\n  ------\r\n\r\n  Replication info table like slave_master_info, slave_relay_log_info are\r\n  created in InnoDB to support crash-safe replication that was introduce in\r\n  MySQL-5.6\r\n\r\n  Being a innodb tables they default qualify for galera replication but they\r\n  shouldn't as per the protocol as they are meant to be kept on active\r\n  ASYNC slave only.\r\n\r\n  MySQL flow does block bin-logging of events performed on these tables but\r\n  WSREP replication missed blocking its replication.\r\n  This causes start of trx in galera cluster which was not needed.\r\n\r\n  Infact, the condition to append_key that starts trx in the galera eco-system\r\n  was not adequated to handle case where-in bin-logging is turned-off for\r\n  a specific flow like update performed to replication info table.\r\n\r\n  Solution:\r\n  ---------\r\n\r\n  Corrected condition that trigger start of replication in galera cluster.\r\n  If bin-logging is turned-off then we avoid starting trx in galera eco-system.\r\n\r\n  Note: We also explicitly allows replication when binlog-format = STATEMENT.\r\n  This is an existing semantics so nothing new here but we made is explict\r\n  and there-by kept the hook open only for STATEMENT and not for MIXED.\r\n  It is interesting to learn that this hook is needed only for pt-table-checksum\r\n  to operate that unfortunately relied on so called non-supported functionality\r\n  of PXC cluster (replication under SBR is not supported).","created_at":"2016-01-18T08:27:28Z","updated_at":"2016-01-18T08:27:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/78/commits","review_comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/78/comments","review_comment_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/78/comments","statuses_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/6e4c2d93a9edca1e196ebf49190d419117428bc8","head":{"label":"kbauskar:5.6-pxc-490","ref":"5.6-pxc-490","sha":"6e4c2d93a9edca1e196ebf49190d419117428bc8","user":{"login":"kbauskar","id":14107301,"avatar_url":"https://avatars.githubusercontent.com/u/14107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kbauskar","html_url":"https://github.com/kbauskar","followers_url":"https://api.github.com/users/kbauskar/followers","following_url":"https://api.github.com/users/kbauskar/following{/other_user}","gists_url":"https://api.github.com/users/kbauskar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbauskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbauskar/subscriptions","organizations_url":"https://api.github.com/users/kbauskar/orgs","repos_url":"https://api.github.com/users/kbauskar/repos","events_url":"https://api.github.com/users/kbauskar/events{/privacy}","received_events_url":"https://api.github.com/users/kbauskar/received_events","type":"User","site_admin":false},"repo":{"id":43105441,"name":"percona-xtradb-cluster","full_name":"kbauskar/percona-xtradb-cluster","owner":{"login":"kbauskar","id":14107301,"avatar_url":"https://avatars.githubusercontent.com/u/14107301?v=3","gravatar_id":"","url":"https://api.github.com/users/kbauskar","html_url":"https://github.com/kbauskar","followers_url":"https://api.github.com/users/kbauskar/followers","following_url":"https://api.github.com/users/kbauskar/following{/other_user}","gists_url":"https://api.github.com/users/kbauskar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbauskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbauskar/subscriptions","organizations_url":"https://api.github.com/users/kbauskar/orgs","repos_url":"https://api.github.com/users/kbauskar/repos","events_url":"https://api.github.com/users/kbauskar/events{/privacy}","received_events_url":"https://api.github.com/users/kbauskar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbauskar/percona-xtradb-cluster","description":"A High Scalability Solution for MySQL Clustering and High Availability","fork":true,"url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster","forks_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/forks","keys_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/teams","hooks_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/hooks","issue_events_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/events","assignees_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/tags","blobs_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/languages","stargazers_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/stargazers","contributors_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/contributors","subscribers_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/subscribers","subscription_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/subscription","commits_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/merges","archive_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/downloads","issues_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/labels{/name}","releases_url":"https://api.github.com/repos/kbauskar/percona-xtradb-cluster/releases{/id}","created_at":"2015-09-25T02:39:48Z","updated_at":"2016-01-11T10:15:43Z","pushed_at":"2016-01-14T04:32:33Z","git_url":"git://github.com/kbauskar/percona-xtradb-cluster.git","ssh_url":"git@github.com:kbauskar/percona-xtradb-cluster.git","clone_url":"https://github.com/kbauskar/percona-xtradb-cluster.git","svn_url":"https://github.com/kbauskar/percona-xtradb-cluster","homepage":"http://www.percona.com/software/percona-xtradb-cluster","size":391256,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"5e0c55795c8c3ee7b1411d8d1782d9d439187633","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753937,"name":"percona-xtradb-cluster","full_name":"percona/percona-xtradb-cluster","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-xtradb-cluster","description":"A High Scalability Solution for MySQL Clustering and High Availability","fork":false,"url":"https://api.github.com/repos/percona/percona-xtradb-cluster","forks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/forks","keys_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/teams","hooks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/events","assignees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/tags","blobs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/languages","stargazers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscription","commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/merges","archive_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/downloads","issues_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/releases{/id}","created_at":"2015-02-13T11:39:22Z","updated_at":"2016-01-11T10:06:05Z","pushed_at":"2016-01-18T08:27:28Z","git_url":"git://github.com/percona/percona-xtradb-cluster.git","ssh_url":"git@github.com:percona/percona-xtradb-cluster.git","clone_url":"https://github.com/percona/percona-xtradb-cluster.git","svn_url":"https://github.com/percona/percona-xtradb-cluster","homepage":"http://www.percona.com/software/percona-xtradb-cluster","size":391323,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":4,"forks":16,"open_issues":4,"watchers":21,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/78"},"html":{"href":"https://github.com/percona/percona-xtradb-cluster/pull/78"},"issue":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/78"},"comments":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/6e4c2d93a9edca1e196ebf49190d419117428bc8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":210,"deletions":22,"changed_files":8}}