{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/66815837","id":66815837,"diff_hunk":"@@ -0,0 +1,350 @@\n+/*\n+Copyright 2016 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package aws_ebs\n+\n+import (\n+\t\"errors\"\n+\t\"testing\"\n+\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\t\"k8s.io/kubernetes/pkg/cloudprovider/providers/aws\"\n+\t\"k8s.io/kubernetes/pkg/volume\"\n+\tvolumetest \"k8s.io/kubernetes/pkg/volume/testing\"\n+\n+\t\"github.com/golang/glog\"\n+)\n+\n+func TestGetDeviceName_Volume(t *testing.T) {\n+\tplugin := newPlugin()\n+\tname := \"my-aws-volume\"\n+\tspec := createVSpec(name, false)\n+\n+\tdeviceName, err := plugin.GetDeviceName(spec)\n+\tif err != nil {\n+\t\tt.Errorf(\"GetDeviceName error: %v\", err)\n+\t}\n+\tif deviceName != name {\n+\t\tt.Errorf(\"GetDeviceName error: expected %s, got %s\", name, deviceName)\n+\t}\n+}\n+\n+func TestGetDeviceName_PersistentVolume(t *testing.T) {\n+\tplugin := newPlugin()\n+\tname := \"my-aws-pv\"\n+\tspec := createPVSpec(name, true)\n+\n+\tdeviceName, err := plugin.GetDeviceName(spec)\n+\tif err != nil {\n+\t\tt.Errorf(\"GetDeviceName error: %v\", err)\n+\t}\n+\tif deviceName != name {\n+\t\tt.Errorf(\"GetDeviceName error: expected %s, got %s\", name, deviceName)\n+\t}\n+}\n+\n+// One testcase for TestAttachDetach table test below\n+type testcase struct {\n+\tname string\n+\t// For fake AWS:\n+\tattach         attachCall\n+\tdetach         detachCall\n+\tdiskIsAttached diskIsAttachedCall\n+\tt              *testing.T\n+\n+\t// Actual test to run\n+\ttest func(test *testcase) error\n+\t// Expected return of the test\n+\texpectedReturn error\n+}\n+\n+func TestAttachDetach(t *testing.T) {\n+\tdiskName := \"disk\"\n+\tinstanceID := \"instance\"\n+\treadOnly := false\n+\tspec := createVSpec(diskName, readOnly)\n+\tattachError := errors.New(\"Fake attach error\")\n+\tdetachError := errors.New(\"Fake detach error\")\n+\tdiskCheckError := errors.New(\"Fake DiskIsAttached error\")\n+\ttests := []testcase{\n+\t\t// Successful Attach call\n+\t\t{\n+\t\t\tname:           \"Attach_Positive\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, false, nil},\n+\t\t\tattach:         attachCall{diskName, instanceID, readOnly, \"/dev/sda\", nil},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tattacher := newAttacher(testcase)\n+\t\t\t\treturn attacher.Attach(spec, instanceID)\n+\t\t\t},\n+\t\t},\n+\n+\t\t// Disk is already attached\n+\t\t{\n+\t\t\tname:           \"Attach_Positive_AlreadyAttached\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, true, nil},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tattacher := newAttacher(testcase)\n+\t\t\t\treturn attacher.Attach(spec, instanceID)\n+\t\t\t},\n+\t\t},\n+\n+\t\t// DiskIsAttached fails and Attach succeeds\n+\t\t{\n+\t\t\tname:           \"Attach_Positive_CheckFails\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, false, diskCheckError},\n+\t\t\tattach:         attachCall{diskName, instanceID, readOnly, \"/dev/sda\", nil},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tattacher := newAttacher(testcase)\n+\t\t\t\treturn attacher.Attach(spec, instanceID)\n+\t\t\t},\n+\t\t},\n+\n+\t\t// Attach call fails\n+\t\t{\n+\t\t\tname:           \"Attach_Negative\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, false, diskCheckError},\n+\t\t\tattach:         attachCall{diskName, instanceID, readOnly, \"\", attachError},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tattacher := newAttacher(testcase)\n+\t\t\t\treturn attacher.Attach(spec, instanceID)\n+\t\t\t},\n+\t\t\texpectedReturn: attachError,\n+\t\t},\n+\n+\t\t// Detach succeeds\n+\t\t{\n+\t\t\tname:           \"Detach_Positive\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, true, nil},\n+\t\t\tdetach:         detachCall{diskName, instanceID, \"/dev/sda\", nil},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tdetacher := newDetacher(testcase)\n+\t\t\t\treturn detacher.Detach(diskName, instanceID)\n+\t\t\t},\n+\t\t},\n+\n+\t\t// Disk is already detached\n+\t\t{\n+\t\t\tname:           \"Detach_Positive_AlreadyDetached\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, false, nil},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tdetacher := newDetacher(testcase)\n+\t\t\t\treturn detacher.Detach(diskName, instanceID)\n+\t\t\t},\n+\t\t},\n+\n+\t\t// Detach succeeds when DiskIsAttached fails\n+\t\t{\n+\t\t\tname:           \"Detach_Positive_CheckFails\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, false, diskCheckError},\n+\t\t\tdetach:         detachCall{diskName, instanceID, \"/dev/sda\", nil},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tdetacher := newDetacher(testcase)\n+\t\t\t\treturn detacher.Detach(diskName, instanceID)\n+\t\t\t},\n+\t\t},\n+\n+\t\t// Detach fails\n+\t\t{\n+\t\t\tname:           \"Detach_Negative\",\n+\t\t\tdiskIsAttached: diskIsAttachedCall{diskName, instanceID, false, diskCheckError},\n+\t\t\tdetach:         detachCall{diskName, instanceID, \"\", detachError},\n+\t\t\ttest: func(testcase *testcase) error {\n+\t\t\t\tdetacher := newDetacher(testcase)\n+\t\t\t\treturn detacher.Detach(diskName, instanceID)\n+\t\t\t},\n+\t\t\texpectedReturn: detachError,\n+\t\t},\n+\t}\n+\n+\tfor _, testcase := range tests {\n+\t\ttestcase.t = t\n+\t\terr := testcase.test(&testcase)\n+\t\tif err != testcase.expectedReturn {\n+\t\t\tt.Errorf(\"%s failed: expected err=%q, got %q\", testcase.name, testcase.expectedReturn.Error(), err.Error())\n+\t\t}\n+\t\tt.Logf(\"Test %q succeeded\", testcase.name)\n+\t}\n+}\n+\n+// newPlugin creates a new gcePersistentDiskPlugin with fake cloud, NewAttacher\n+// and NewDetacher won't work.\n+func newPlugin() *awsElasticBlockStorePlugin {\n+\thost := volumetest.NewFakeVolumeHost(\"/tmp\", nil, nil)\n+\tplugins := ProbeVolumePlugins()\n+\tplugin := plugins[0]\n+\tplugin.Init(host)\n+\treturn plugin.(*awsElasticBlockStorePlugin)\n+}\n+\n+func newAttacher(testcase *testcase) *awsElasticBlockStoreAttacher {\n+\treturn &awsElasticBlockStoreAttacher{\n+\t\thost:       nil,\n+\t\tawsVolumes: testcase,\n+\t}\n+}\n+\n+func newDetacher(testcase *testcase) *awsElasticBlockStoreDetacher {\n+\treturn &awsElasticBlockStoreDetacher{\n+\t\tawsVolumes: testcase,\n+\t}\n+}\n+\n+func createVSpec(name string, readOnly bool) *volume.Spec {\n+\treturn &volume.Spec{\n+\t\tVolume: &api.Volume{\n+\t\t\tVolumeSource: api.VolumeSource{\n+\t\t\t\tAWSElasticBlockStore: &api.AWSElasticBlockStoreVolumeSource{\n+\t\t\t\t\tVolumeID: name,\n+\t\t\t\t\tReadOnly: readOnly,\n+\t\t\t\t},\n+\t\t\t},\n+\t\t},\n+\t}\n+}\n+\n+func createPVSpec(name string, readOnly bool) *volume.Spec {\n+\treturn &volume.Spec{\n+\t\tPersistentVolume: &api.PersistentVolume{\n+\t\t\tSpec: api.PersistentVolumeSpec{\n+\t\t\t\tPersistentVolumeSource: api.PersistentVolumeSource{\n+\t\t\t\t\tAWSElasticBlockStore: &api.AWSElasticBlockStoreVolumeSource{\n+\t\t\t\t\t\tVolumeID: name,\n+\t\t\t\t\t\tReadOnly: readOnly,\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t},\n+\t\t},\n+\t}\n+}\n+\n+// Fake AWS implementation\n+\n+type attachCall struct {\n+\tdiskName      string\n+\tinstanceID    string\n+\treadOnly      bool\n+\tretDeviceName string\n+\tret           error\n+}\n+\n+type detachCall struct {\n+\tdiskName      string\n+\tinstanceID    string\n+\tretDeviceName string\n+\tret           error\n+}\n+\n+type diskIsAttachedCall struct {\n+\tdiskName, instanceID string\n+\tisAttached           bool\n+\tret                  error\n+}\n+\n+func (testcase *testcase) AttachDisk(diskName string, instanceID string, readOnly bool) (string, error) {\n+\texpected := &testcase.attach\n+\n+\tif expected.diskName == \"\" && expected.instanceID == \"\" {\n+\t\t// testcase.attach looks uninitialized, test did not expect to call\n+\t\t// AttachDisk\n+\t\ttestcase.t.Errorf(\"Unexpected AttachDisk call!\")\n+\t\treturn \"\", errors.New(\"Unexpected AttachDisk call!\")\n+\t}\n+\n+\tif expected.diskName != diskName {\n+\t\ttestcase.t.Errorf(\"Unexpected AttachDisk call: expected diskName %s, got %s\", expected.diskName, diskName)\n+\t\treturn \"\", errors.New(\"Unexpected AttachDisk call: wrong diskName\")\n+\t}\n+\n+\tif expected.instanceID != instanceID {\n+\t\ttestcase.t.Errorf(\"Unexpected AttachDisk call: expected instanceID %s, got %s\", expected.instanceID, instanceID)\n+\t\treturn \"\", errors.New(\"Unexpected AttachDisk call: wrong instanceID\")\n+\t}\n+\n+\tif expected.readOnly != readOnly {\n+\t\ttestcase.t.Errorf(\"Unexpected AttachDisk call: expected readOnly %v, got %v\", expected.readOnly, readOnly)\n+\t\treturn \"\", errors.New(\"Unexpected AttachDisk call: wrong readOnly\")\n+\t}\n+\n+\tglog.V(4).Infof(\"AttachDisk call: %s, %s, %v, returning %q, %v\", diskName, instanceID, readOnly, expected.retDeviceName, expected.ret)\n+\n+\treturn expected.retDeviceName, expected.ret\n+}\n+\n+func (testcase *testcase) DetachDisk(diskName string, instanceID string) (string, error) {\n+\texpected := &testcase.detach\n+\n+\tif expected.diskName == \"\" && expected.instanceID == \"\" {\n+\t\t// testcase.detach looks uninitialized, test did not expect to call\n+\t\t// DetachDisk\n+\t\ttestcase.t.Errorf(\"Unexpected DetachDisk call!\")\n+\t\treturn \"\", errors.New(\"Unexpected DetachDisk call!\")\n+\t}\n+\n+\tif expected.diskName != diskName {\n+\t\ttestcase.t.Errorf(\"Unexpected DetachDisk call: expected diskName %s, got %s\", expected.diskName, diskName)\n+\t\treturn \"\", errors.New(\"Unexpected DetachDisk call: wrong diskName\")\n+\t}\n+\n+\tif expected.instanceID != instanceID {\n+\t\ttestcase.t.Errorf(\"Unexpected DetachDisk call: expected instanceID %s, got %s\", expected.instanceID, instanceID)\n+\t\treturn \"\", errors.New(\"Unexpected DetachDisk call: wrong instanceID\")\n+\t}\n+\n+\tglog.V(4).Infof(\"DetachDisk call: %s, %s, returning %q, %v\", diskName, instanceID, expected.retDeviceName, expected.ret)\n+\n+\treturn expected.retDeviceName, expected.ret\n+}\n+\n+func (testcase *testcase) DiskIsAttached(diskName, instanceID string) (bool, error) {\n+\texpected := &testcase.diskIsAttached\n+\n+\tif expected.diskName == \"\" && expected.instanceID == \"\" {","path":"pkg/volume/aws_ebs/attacher_test.go","position":314,"original_position":314,"commit_id":"73dc07a8221a2ed62c13bfd31fd77acf7ea5e068","original_commit_id":"73dc07a8221a2ed62c13bfd31fd77acf7ea5e068","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"&& -> ||","created_at":"2016-06-13T15:44:08Z","updated_at":"2016-06-13T15:44:08Z","html_url":"https://github.com/kubernetes/kubernetes/pull/27280#discussion_r66815837","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/66815837"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27280#discussion_r66815837"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280","id":73595409,"html_url":"https://github.com/kubernetes/kubernetes/pull/27280","diff_url":"https://github.com/kubernetes/kubernetes/pull/27280.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27280.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27280","number":27280,"state":"open","locked":false,"title":"Add AWS volume plugin attach tests.","user":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"body":"@kubernetes/sig-storage \r\n\r\nThis it a test, it does not really matter if it catches 1.3 train or the next one.","created_at":"2016-06-13T15:30:11Z","updated_at":"2016-06-13T15:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d5caaba3a27d6cfd639b9a1683dae84a79a3a6b","assignee":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27280/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/73dc07a8221a2ed62c13bfd31fd77acf7ea5e068","head":{"label":"jsafrane:aws-cinder-attach-test","ref":"aws-cinder-attach-test","sha":"73dc07a8221a2ed62c13bfd31fd77acf7ea5e068","user":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"repo":{"id":33241093,"name":"kubernetes","full_name":"jsafrane/kubernetes","owner":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars.githubusercontent.com/u/1745006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsafrane/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/jsafrane/kubernetes","forks_url":"https://api.github.com/repos/jsafrane/kubernetes/forks","keys_url":"https://api.github.com/repos/jsafrane/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsafrane/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsafrane/kubernetes/teams","hooks_url":"https://api.github.com/repos/jsafrane/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jsafrane/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jsafrane/kubernetes/events","assignees_url":"https://api.github.com/repos/jsafrane/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jsafrane/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jsafrane/kubernetes/tags","blobs_url":"https://api.github.com/repos/jsafrane/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsafrane/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsafrane/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsafrane/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsafrane/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jsafrane/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jsafrane/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jsafrane/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jsafrane/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jsafrane/kubernetes/subscription","commits_url":"https://api.github.com/repos/jsafrane/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsafrane/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsafrane/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsafrane/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsafrane/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jsafrane/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsafrane/kubernetes/merges","archive_url":"https://api.github.com/repos/jsafrane/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsafrane/kubernetes/downloads","issues_url":"https://api.github.com/repos/jsafrane/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jsafrane/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jsafrane/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jsafrane/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsafrane/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jsafrane/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jsafrane/kubernetes/deployments","created_at":"2015-04-01T10:16:41Z","updated_at":"2016-01-15T18:08:52Z","pushed_at":"2016-06-13T15:28:45Z","git_url":"git://github.com/jsafrane/kubernetes.git","ssh_url":"git@github.com:jsafrane/kubernetes.git","clone_url":"https://github.com/jsafrane/kubernetes.git","svn_url":"https://github.com/jsafrane/kubernetes","homepage":"http://kubernetes.io","size":265995,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"024316e5a1971bb31267208f11d987c27a2d7216","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-13T15:22:20Z","pushed_at":"2016-06-13T15:30:11Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":478201,"stargazers_count":14884,"watchers_count":14884,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4572,"mirror_url":null,"open_issues_count":3723,"forks":4572,"open_issues":3723,"watchers":14884,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27280"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27280"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27280/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27280/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/73dc07a8221a2ed62c13bfd31fd77acf7ea5e068"}}}}
{"actor":{"display_login":"rootfs"}}