{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/60640755","id":60640755,"diff_hunk":"@@ -327,16 +376,70 @@ public void finishDoesNotOverwriteWrittenElements() throws Exception {\n \n   @Test\n   public void finishOnPendingViewsSetsEmptyElements() throws Exception {\n-    immediatelyInvokeCallback(mapView, secondWindow);\n+    immediatelyInvokeCallback(mapView, SECOND_WINDOW);\n     Future<Map<String, Integer>> mapFuture =\n         getFutureOfView(\n             container.createReaderForViews(ImmutableList.<PCollectionView<?>>of(mapView)),\n             mapView,\n-            secondWindow);\n+            SECOND_WINDOW);\n \n     assertThat(mapFuture.get().isEmpty(), is(true));\n   }\n \n+  @Test\n+  public void isReadyInEmptyReaderThrows() {\n+    ReadyCheckingSideInputReader reader =\n+        container.createReaderForViews(ImmutableList.<PCollectionView<?>>of());\n+    thrown.expect(IllegalArgumentException.class);\n+    thrown.expectMessage(\"does not contain\");\n+    thrown.expectMessage(ImmutableList.of().toString());\n+    reader.isReady(mapView, GlobalWindow.INSTANCE);\n+  }\n+\n+  @Test\n+  public void allViewsReadyInWindowForSomeNotReadyViewsFalseUntilElements() {\n+    container.write(\n+        mapView,\n+        ImmutableList.of(\n+            WindowedValue.of(\n+                KV.of(\"one\", 1),\n+                FIRST_WINDOW.maxTimestamp().minus(100L),\n+                SECOND_WINDOW,\n+                PaneInfo.ON_TIME_AND_ONLY_FIRING)));\n+\n+    ReadyCheckingSideInputReader reader =\n+        container.createReaderForViews(ImmutableList.of(mapView, singletonView));\n+    assertThat(reader.isReady(mapView, SECOND_WINDOW), is(true));\n+    assertThat(reader.isReady(singletonView, SECOND_WINDOW), is(false));\n+\n+    container.write(\n+        singletonView,\n+        ImmutableList.of(\n+            WindowedValue.of(\n+                1.25,\n+                FIRST_WINDOW.maxTimestamp().minus(100L),\n+                SECOND_WINDOW,\n+                PaneInfo.ON_TIME_AND_ONLY_FIRING)));\n+    assertThat(reader.isReady(mapView, SECOND_WINDOW), is(true));\n+    assertThat(reader.isReady(singletonView, SECOND_WINDOW), is(true));\n+\n+    assertThat(reader.isReady(mapView, GlobalWindow.INSTANCE), is(false));\n+    assertThat(reader.isReady(singletonView, GlobalWindow.INSTANCE), is(false));\n+  }\n+\n+  @Test\n+  public void allViewsReadyInWindowForEmptyWindowTrue() {","path":"sdks/java/core/src/test/java/org/apache/beam/sdk/runners/inprocess/InProcessSideInputContainerTest.java","position":343,"original_position":343,"commit_id":"96bf32b51db6cf8b25485e5b3534de54c8394b82","original_commit_id":"c118b5af34190a2c69452bf454b779141ac3d591","user":{"login":"peihe","id":10201797,"avatar_url":"https://avatars.githubusercontent.com/u/10201797?v=3","gravatar_id":"","url":"https://api.github.com/users/peihe","html_url":"https://github.com/peihe","followers_url":"https://api.github.com/users/peihe/followers","following_url":"https://api.github.com/users/peihe/following{/other_user}","gists_url":"https://api.github.com/users/peihe/gists{/gist_id}","starred_url":"https://api.github.com/users/peihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peihe/subscriptions","organizations_url":"https://api.github.com/users/peihe/orgs","repos_url":"https://api.github.com/users/peihe/repos","events_url":"https://api.github.com/users/peihe/events{/privacy}","received_events_url":"https://api.github.com/users/peihe/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2016-04-21T19:25:16Z","updated_at":"2016-04-21T19:25:16Z","html_url":"https://github.com/apache/incubator-beam/pull/220#discussion_r60640755","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/60640755"},"html":{"href":"https://github.com/apache/incubator-beam/pull/220#discussion_r60640755"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/220","id":67263422,"html_url":"https://github.com/apache/incubator-beam/pull/220","diff_url":"https://github.com/apache/incubator-beam/pull/220.diff","patch_url":"https://github.com/apache/incubator-beam/pull/220.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/220","number":220,"state":"open","locked":false,"title":"[BEAM-22] Allow InProcess Evaluators to check Side Input completion","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [x] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\nThis checks to ensure that the PCollectionView in the SideInputWindow\r\nfor the provided window either has elements available or is empty.\r\n\r\nSchedule a future to ensure that the SideInputWindows are appropriately\r\nfilled with an empty iterable after retreiving the element.\r\n\r\nThis is allows the ParDoEvaluator to not attempt to process elements\r\nthat cannot currently be completed.","created_at":"2016-04-20T21:42:25Z","updated_at":"2016-04-21T19:25:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5696689d18664fd6db8d3b8595d0f0efdbf96ac4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/220/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/220/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/220/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/96bf32b51db6cf8b25485e5b3534de54c8394b82","head":{"label":"tgroh:ippr_side_input_is_ready","ref":"ippr_side_input_is_ready","sha":"96bf32b51db6cf8b25485e5b3534de54c8394b82","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"repo":{"id":52644388,"name":"incubator-beam","full_name":"tgroh/incubator-beam","owner":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgroh/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/tgroh/incubator-beam","forks_url":"https://api.github.com/repos/tgroh/incubator-beam/forks","keys_url":"https://api.github.com/repos/tgroh/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgroh/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgroh/incubator-beam/teams","hooks_url":"https://api.github.com/repos/tgroh/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/tgroh/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/tgroh/incubator-beam/events","assignees_url":"https://api.github.com/repos/tgroh/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/tgroh/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/tgroh/incubator-beam/tags","blobs_url":"https://api.github.com/repos/tgroh/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgroh/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgroh/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgroh/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgroh/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/tgroh/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/tgroh/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/tgroh/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/tgroh/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/tgroh/incubator-beam/subscription","commits_url":"https://api.github.com/repos/tgroh/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgroh/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgroh/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgroh/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgroh/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/tgroh/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgroh/incubator-beam/merges","archive_url":"https://api.github.com/repos/tgroh/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgroh/incubator-beam/downloads","issues_url":"https://api.github.com/repos/tgroh/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/tgroh/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/tgroh/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/tgroh/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgroh/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/tgroh/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/tgroh/incubator-beam/deployments","created_at":"2016-02-27T01:43:32Z","updated_at":"2016-02-27T01:43:35Z","pushed_at":"2016-04-21T19:11:43Z","git_url":"git://github.com/tgroh/incubator-beam.git","ssh_url":"git@github.com:tgroh/incubator-beam.git","clone_url":"https://github.com/tgroh/incubator-beam.git","svn_url":"https://github.com/tgroh/incubator-beam","homepage":null,"size":13284,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"de601a833cf3e92e973b090c672ad25849c52a96","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-04-21T07:55:07Z","pushed_at":"2016-04-21T19:11:44Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":14074,"stargazers_count":137,"watchers_count":137,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":20,"forks":67,"open_issues":20,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/220"},"html":{"href":"https://github.com/apache/incubator-beam/pull/220"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/220"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/96bf32b51db6cf8b25485e5b3534de54c8394b82"}}}}