{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/comments/51943783","id":51943783,"diff_hunk":"@@ -34,13 +34,13 @@ module.exports = {\n             callbackServer();\n \n             try {\n-              let args = {'environment':'production', 'next': 'http://127.0.0.1:18000'};\n+              var args = {'environment':'production', 'next': 'http://127.0.0.1:18000'};","path":"lib/commands/connect/auth_connection.js","position":28,"original_position":28,"commit_id":"fa580862a2f393ec0dbd5114248afbc7f36cc029","original_commit_id":"fa580862a2f393ec0dbd5114248afbc7f36cc029","user":{"login":"gulopine","id":2522,"avatar_url":"https://avatars.githubusercontent.com/u/2522?v=3","gravatar_id":"","url":"https://api.github.com/users/gulopine","html_url":"https://github.com/gulopine","followers_url":"https://api.github.com/users/gulopine/followers","following_url":"https://api.github.com/users/gulopine/following{/other_user}","gists_url":"https://api.github.com/users/gulopine/gists{/gist_id}","starred_url":"https://api.github.com/users/gulopine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulopine/subscriptions","organizations_url":"https://api.github.com/users/gulopine/orgs","repos_url":"https://api.github.com/users/gulopine/repos","events_url":"https://api.github.com/users/gulopine/events{/privacy}","received_events_url":"https://api.github.com/users/gulopine/received_events","type":"User","site_admin":false},"body":"I'll admit, I noticed this one after I said they were all function-level. This is actually bad code anyway, and should be rewritten to avoid putting the assignment inside the `try` block at all, but that's a separate issue.","created_at":"2016-02-04T21:53:08Z","updated_at":"2016-02-04T21:53:08Z","html_url":"https://github.com/heroku/heroku-connect-plugin/pull/19#discussion_r51943783","pull_request_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/comments/51943783"},"html":{"href":"https://github.com/heroku/heroku-connect-plugin/pull/19#discussion_r51943783"},"pull_request":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19","id":58340327,"html_url":"https://github.com/heroku/heroku-connect-plugin/pull/19","diff_url":"https://github.com/heroku/heroku-connect-plugin/pull/19.diff","patch_url":"https://github.com/heroku/heroku-connect-plugin/pull/19.patch","issue_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/19","number":19,"state":"open","locked":false,"title":"use var instead of let, for more familiar semantics","user":{"login":"gulopine","id":2522,"avatar_url":"https://avatars.githubusercontent.com/u/2522?v=3","gravatar_id":"","url":"https://api.github.com/users/gulopine","html_url":"https://github.com/gulopine","followers_url":"https://api.github.com/users/gulopine/followers","following_url":"https://api.github.com/users/gulopine/following{/other_user}","gists_url":"https://api.github.com/users/gulopine/gists{/gist_id}","starred_url":"https://api.github.com/users/gulopine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulopine/subscriptions","organizations_url":"https://api.github.com/users/gulopine/orgs","repos_url":"https://api.github.com/users/gulopine/repos","events_url":"https://api.github.com/users/gulopine/events{/privacy}","received_events_url":"https://api.github.com/users/gulopine/received_events","type":"User","site_admin":false},"body":"Functionality, none of these places exhibit different behavior between `var` and `let`, but it's better to be in a habit of using semantics that are more familiar to us, either from a Python background or a more traditional JavaScript background. `let` is geared more toward a C++/Java background, and is likely to get us into trouble if we're not particularly careful with it.","created_at":"2016-02-04T20:00:31Z","updated_at":"2016-02-04T21:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06fcd6de78f9a988f94029883e393d1ecb37def7","assignee":{"login":"sibson","id":125162,"avatar_url":"https://avatars.githubusercontent.com/u/125162?v=3","gravatar_id":"","url":"https://api.github.com/users/sibson","html_url":"https://github.com/sibson","followers_url":"https://api.github.com/users/sibson/followers","following_url":"https://api.github.com/users/sibson/following{/other_user}","gists_url":"https://api.github.com/users/sibson/gists{/gist_id}","starred_url":"https://api.github.com/users/sibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibson/subscriptions","organizations_url":"https://api.github.com/users/sibson/orgs","repos_url":"https://api.github.com/users/sibson/repos","events_url":"https://api.github.com/users/sibson/events{/privacy}","received_events_url":"https://api.github.com/users/sibson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19/commits","review_comments_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19/comments","review_comment_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/19/comments","statuses_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/statuses/fa580862a2f393ec0dbd5114248afbc7f36cc029","head":{"label":"heroku:var-let","ref":"var-let","sha":"fa580862a2f393ec0dbd5114248afbc7f36cc029","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":34745923,"name":"heroku-connect-plugin","full_name":"heroku/heroku-connect-plugin","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku-connect-plugin","description":"Toolbelt plugin for Heroku Connect (experimental)","fork":false,"url":"https://api.github.com/repos/heroku/heroku-connect-plugin","forks_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/forks","keys_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/teams","hooks_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/events","assignees_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/tags","blobs_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/subscription","commits_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/merges","archive_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/downloads","issues_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/deployments","created_at":"2015-04-28T17:40:42Z","updated_at":"2016-01-26T05:29:09Z","pushed_at":"2016-02-04T21:19:07Z","git_url":"git://github.com/heroku/heroku-connect-plugin.git","ssh_url":"git@github.com:heroku/heroku-connect-plugin.git","clone_url":"https://github.com/heroku/heroku-connect-plugin.git","svn_url":"https://github.com/heroku/heroku-connect-plugin","homepage":null,"size":62,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"6317838ec279c9375e455ee54615b2b666fa5c4f","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":34745923,"name":"heroku-connect-plugin","full_name":"heroku/heroku-connect-plugin","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/heroku-connect-plugin","description":"Toolbelt plugin for Heroku Connect (experimental)","fork":false,"url":"https://api.github.com/repos/heroku/heroku-connect-plugin","forks_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/forks","keys_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/teams","hooks_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/hooks","issue_events_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/events","assignees_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/tags","blobs_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/languages","stargazers_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/stargazers","contributors_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/contributors","subscribers_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/subscribers","subscription_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/subscription","commits_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/merges","archive_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/downloads","issues_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/labels{/name}","releases_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/heroku-connect-plugin/deployments","created_at":"2015-04-28T17:40:42Z","updated_at":"2016-01-26T05:29:09Z","pushed_at":"2016-02-04T21:19:07Z","git_url":"git://github.com/heroku/heroku-connect-plugin.git","ssh_url":"git@github.com:heroku/heroku-connect-plugin.git","clone_url":"https://github.com/heroku/heroku-connect-plugin.git","svn_url":"https://github.com/heroku/heroku-connect-plugin","homepage":null,"size":62,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19"},"html":{"href":"https://github.com/heroku/heroku-connect-plugin/pull/19"},"issue":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/19"},"comments":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/heroku-connect-plugin/statuses/fa580862a2f393ec0dbd5114248afbc7f36cc029"}}}}