{"action":"closed","number":1351,"pull_request":{"url":"https://api.github.com/repos/mtgred/netrunner/pulls/1351","id":62919138,"html_url":"https://github.com/mtgred/netrunner/pull/1351","diff_url":"https://github.com/mtgred/netrunner/pull/1351.diff","patch_url":"https://github.com/mtgred/netrunner/pull/1351.patch","issue_url":"https://api.github.com/repos/mtgred/netrunner/issues/1351","number":1351,"state":"closed","locked":false,"title":"Modified all-installed to handle nested hosted cards","user":{"login":"Tondo","id":747635,"avatar_url":"https://avatars.githubusercontent.com/u/747635?v=3","gravatar_id":"","url":"https://api.github.com/users/Tondo","html_url":"https://github.com/Tondo","followers_url":"https://api.github.com/users/Tondo/followers","following_url":"https://api.github.com/users/Tondo/following{/other_user}","gists_url":"https://api.github.com/users/Tondo/gists{/gist_id}","starred_url":"https://api.github.com/users/Tondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tondo/subscriptions","organizations_url":"https://api.github.com/users/Tondo/orgs","repos_url":"https://api.github.com/users/Tondo/repos","events_url":"https://api.github.com/users/Tondo/events{/privacy}","received_events_url":"https://api.github.com/users/Tondo/received_events","type":"User","site_admin":false},"body":"As described in #1160, all-installed was not returning cards that were hosted on already hosted cards. Now the function searches recursively for any hosted cards, and should handle any level of nesting.\r\n\r\nThough #1160 only mentioned it as a bug for the runner, the problem also seemed to exist for the corp when I tested it, so I made the same changes to the corp-side as well.\r\n\r\nI should mention that this is the first time I'm writing clojure code (though I've written some functional programming code before), so please review the code and let me know if there's anything I should fix up. \r\n\r\nEdit: Also added a test for all-installed for the runner-side.","created_at":"2016-03-15T14:58:03Z","updated_at":"2016-03-18T09:57:52Z","closed_at":"2016-03-18T09:57:52Z","merged_at":"2016-03-18T09:57:52Z","merge_commit_sha":"37fb2d1196095d6df09a2762833628c671ff5d00","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mtgred/netrunner/pulls/1351/commits","review_comments_url":"https://api.github.com/repos/mtgred/netrunner/pulls/1351/comments","review_comment_url":"https://api.github.com/repos/mtgred/netrunner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mtgred/netrunner/issues/1351/comments","statuses_url":"https://api.github.com/repos/mtgred/netrunner/statuses/1990eac9428ed289714801c05e2922500170859c","head":{"label":"Tondo:all-installedHostedFix","ref":"all-installedHostedFix","sha":"1990eac9428ed289714801c05e2922500170859c","user":{"login":"Tondo","id":747635,"avatar_url":"https://avatars.githubusercontent.com/u/747635?v=3","gravatar_id":"","url":"https://api.github.com/users/Tondo","html_url":"https://github.com/Tondo","followers_url":"https://api.github.com/users/Tondo/followers","following_url":"https://api.github.com/users/Tondo/following{/other_user}","gists_url":"https://api.github.com/users/Tondo/gists{/gist_id}","starred_url":"https://api.github.com/users/Tondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tondo/subscriptions","organizations_url":"https://api.github.com/users/Tondo/orgs","repos_url":"https://api.github.com/users/Tondo/repos","events_url":"https://api.github.com/users/Tondo/events{/privacy}","received_events_url":"https://api.github.com/users/Tondo/received_events","type":"User","site_admin":false},"repo":{"id":53525410,"name":"netrunner","full_name":"Tondo/netrunner","owner":{"login":"Tondo","id":747635,"avatar_url":"https://avatars.githubusercontent.com/u/747635?v=3","gravatar_id":"","url":"https://api.github.com/users/Tondo","html_url":"https://github.com/Tondo","followers_url":"https://api.github.com/users/Tondo/followers","following_url":"https://api.github.com/users/Tondo/following{/other_user}","gists_url":"https://api.github.com/users/Tondo/gists{/gist_id}","starred_url":"https://api.github.com/users/Tondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tondo/subscriptions","organizations_url":"https://api.github.com/users/Tondo/orgs","repos_url":"https://api.github.com/users/Tondo/repos","events_url":"https://api.github.com/users/Tondo/events{/privacy}","received_events_url":"https://api.github.com/users/Tondo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tondo/netrunner","description":"","fork":true,"url":"https://api.github.com/repos/Tondo/netrunner","forks_url":"https://api.github.com/repos/Tondo/netrunner/forks","keys_url":"https://api.github.com/repos/Tondo/netrunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tondo/netrunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tondo/netrunner/teams","hooks_url":"https://api.github.com/repos/Tondo/netrunner/hooks","issue_events_url":"https://api.github.com/repos/Tondo/netrunner/issues/events{/number}","events_url":"https://api.github.com/repos/Tondo/netrunner/events","assignees_url":"https://api.github.com/repos/Tondo/netrunner/assignees{/user}","branches_url":"https://api.github.com/repos/Tondo/netrunner/branches{/branch}","tags_url":"https://api.github.com/repos/Tondo/netrunner/tags","blobs_url":"https://api.github.com/repos/Tondo/netrunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tondo/netrunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tondo/netrunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tondo/netrunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tondo/netrunner/statuses/{sha}","languages_url":"https://api.github.com/repos/Tondo/netrunner/languages","stargazers_url":"https://api.github.com/repos/Tondo/netrunner/stargazers","contributors_url":"https://api.github.com/repos/Tondo/netrunner/contributors","subscribers_url":"https://api.github.com/repos/Tondo/netrunner/subscribers","subscription_url":"https://api.github.com/repos/Tondo/netrunner/subscription","commits_url":"https://api.github.com/repos/Tondo/netrunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tondo/netrunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tondo/netrunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tondo/netrunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tondo/netrunner/contents/{+path}","compare_url":"https://api.github.com/repos/Tondo/netrunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tondo/netrunner/merges","archive_url":"https://api.github.com/repos/Tondo/netrunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tondo/netrunner/downloads","issues_url":"https://api.github.com/repos/Tondo/netrunner/issues{/number}","pulls_url":"https://api.github.com/repos/Tondo/netrunner/pulls{/number}","milestones_url":"https://api.github.com/repos/Tondo/netrunner/milestones{/number}","notifications_url":"https://api.github.com/repos/Tondo/netrunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tondo/netrunner/labels{/name}","releases_url":"https://api.github.com/repos/Tondo/netrunner/releases{/id}","deployments_url":"https://api.github.com/repos/Tondo/netrunner/deployments","created_at":"2016-03-09T19:26:20Z","updated_at":"2016-03-09T19:26:21Z","pushed_at":"2016-03-16T20:18:05Z","git_url":"git://github.com/Tondo/netrunner.git","ssh_url":"git@github.com:Tondo/netrunner.git","clone_url":"https://github.com/Tondo/netrunner.git","svn_url":"https://github.com/Tondo/netrunner","homepage":"http://www.jinteki.net","size":10766,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mtgred:master","ref":"master","sha":"0aa976f2e3e21a2bbde33713b0d84f03c36353d9","user":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"repo":{"id":19079918,"name":"netrunner","full_name":"mtgred/netrunner","owner":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtgred/netrunner","description":"","fork":false,"url":"https://api.github.com/repos/mtgred/netrunner","forks_url":"https://api.github.com/repos/mtgred/netrunner/forks","keys_url":"https://api.github.com/repos/mtgred/netrunner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtgred/netrunner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtgred/netrunner/teams","hooks_url":"https://api.github.com/repos/mtgred/netrunner/hooks","issue_events_url":"https://api.github.com/repos/mtgred/netrunner/issues/events{/number}","events_url":"https://api.github.com/repos/mtgred/netrunner/events","assignees_url":"https://api.github.com/repos/mtgred/netrunner/assignees{/user}","branches_url":"https://api.github.com/repos/mtgred/netrunner/branches{/branch}","tags_url":"https://api.github.com/repos/mtgred/netrunner/tags","blobs_url":"https://api.github.com/repos/mtgred/netrunner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtgred/netrunner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtgred/netrunner/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtgred/netrunner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtgred/netrunner/statuses/{sha}","languages_url":"https://api.github.com/repos/mtgred/netrunner/languages","stargazers_url":"https://api.github.com/repos/mtgred/netrunner/stargazers","contributors_url":"https://api.github.com/repos/mtgred/netrunner/contributors","subscribers_url":"https://api.github.com/repos/mtgred/netrunner/subscribers","subscription_url":"https://api.github.com/repos/mtgred/netrunner/subscription","commits_url":"https://api.github.com/repos/mtgred/netrunner/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtgred/netrunner/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtgred/netrunner/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtgred/netrunner/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtgred/netrunner/contents/{+path}","compare_url":"https://api.github.com/repos/mtgred/netrunner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtgred/netrunner/merges","archive_url":"https://api.github.com/repos/mtgred/netrunner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtgred/netrunner/downloads","issues_url":"https://api.github.com/repos/mtgred/netrunner/issues{/number}","pulls_url":"https://api.github.com/repos/mtgred/netrunner/pulls{/number}","milestones_url":"https://api.github.com/repos/mtgred/netrunner/milestones{/number}","notifications_url":"https://api.github.com/repos/mtgred/netrunner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtgred/netrunner/labels{/name}","releases_url":"https://api.github.com/repos/mtgred/netrunner/releases{/id}","deployments_url":"https://api.github.com/repos/mtgred/netrunner/deployments","created_at":"2014-04-23T17:57:52Z","updated_at":"2016-03-17T14:30:52Z","pushed_at":"2016-03-18T09:57:52Z","git_url":"git://github.com/mtgred/netrunner.git","ssh_url":"git@github.com:mtgred/netrunner.git","clone_url":"https://github.com/mtgred/netrunner.git","svn_url":"https://github.com/mtgred/netrunner","homepage":"http://www.jinteki.net","size":11268,"stargazers_count":341,"watchers_count":341,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":142,"forks":154,"open_issues":142,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1351"},"html":{"href":"https://github.com/mtgred/netrunner/pull/1351"},"issue":{"href":"https://api.github.com/repos/mtgred/netrunner/issues/1351"},"comments":{"href":"https://api.github.com/repos/mtgred/netrunner/issues/1351/comments"},"review_comments":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1351/comments"},"review_comment":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mtgred/netrunner/pulls/1351/commits"},"statuses":{"href":"https://api.github.com/repos/mtgred/netrunner/statuses/1990eac9428ed289714801c05e2922500170859c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mtgred","id":284114,"avatar_url":"https://avatars.githubusercontent.com/u/284114?v=3","gravatar_id":"","url":"https://api.github.com/users/mtgred","html_url":"https://github.com/mtgred","followers_url":"https://api.github.com/users/mtgred/followers","following_url":"https://api.github.com/users/mtgred/following{/other_user}","gists_url":"https://api.github.com/users/mtgred/gists{/gist_id}","starred_url":"https://api.github.com/users/mtgred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtgred/subscriptions","organizations_url":"https://api.github.com/users/mtgred/orgs","repos_url":"https://api.github.com/users/mtgred/repos","events_url":"https://api.github.com/users/mtgred/events{/privacy}","received_events_url":"https://api.github.com/users/mtgred/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":6,"additions":52,"deletions":6,"changed_files":2}}