{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Firmware/issues/4402","repository_url":"https://api.github.com/repos/PX4/Firmware","labels_url":"https://api.github.com/repos/PX4/Firmware/issues/4402/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/4402/comments","events_url":"https://api.github.com/repos/PX4/Firmware/issues/4402/events","html_url":"https://github.com/PX4/Firmware/pull/4402","id":151879938,"number":4402,"title":"sdlog2: move from STAT.MainState to COMM.MainState","user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars.githubusercontent.com/u/1419688?v=3","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/PX4/Firmware/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"LorenzMeier","id":1208119,"avatar_url":"https://avatars.githubusercontent.com/u/1208119?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-04-29T14:26:33Z","updated_at":"2016-04-29T14:35:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/4402","html_url":"https://github.com/PX4/Firmware/pull/4402","diff_url":"https://github.com/PX4/Firmware/pull/4402.diff","patch_url":"https://github.com/PX4/Firmware/pull/4402.patch"},"body":"This fixes a bug where vehicle_system_status and the commander internal\r\nstate were conflicting.\r\n\r\nThis will need adaptations in logging tools.\r\nThe change for FlightPlot is here: https://github.com/DrTon/FlightPlot/pull/62"},"comment":{"url":"https://api.github.com/repos/PX4/Firmware/issues/comments/215738172","html_url":"https://github.com/PX4/Firmware/pull/4402#issuecomment-215738172","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/4402","id":215738172,"user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars.githubusercontent.com/u/1419688?v=3","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T14:35:06Z","updated_at":"2016-04-29T14:35:06Z","body":"Right, technically feasible. Two points against it:\r\n\r\n- I don't want tools to look at the commander internal state, otherwise commander state machine changes will be hard.\r\n- The tools are sort of outdated in that respect anyway, see:\r\nhttps://github.com/DrTon/FlightPlot/blob/master/src/me/drton/flightplot/export/PX4TrackReader.java\r\nhttps://github.com/mavlink/mavlink/blob/master/pymavlink/tools/mavgraph.py#L41\r\n\r\nMaybe we should publish to both for some transition time?"}}