{"action":"created","issue":{"url":"https://api.github.com/repos/leezer3/OpenBVE/issues/119","repository_url":"https://api.github.com/repos/leezer3/OpenBVE","labels_url":"https://api.github.com/repos/leezer3/OpenBVE/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/leezer3/OpenBVE/issues/119/comments","events_url":"https://api.github.com/repos/leezer3/OpenBVE/issues/119/events","html_url":"https://github.com/leezer3/OpenBVE/pull/119","id":194813859,"number":119,"title":"Unify build system into a single makefile and single solution","user":{"login":"Sirflankalot","id":7861353,"avatar_url":"https://avatars.githubusercontent.com/u/7861353?v=3","gravatar_id":"","url":"https://api.github.com/users/Sirflankalot","html_url":"https://github.com/Sirflankalot","followers_url":"https://api.github.com/users/Sirflankalot/followers","following_url":"https://api.github.com/users/Sirflankalot/following{/other_user}","gists_url":"https://api.github.com/users/Sirflankalot/gists{/gist_id}","starred_url":"https://api.github.com/users/Sirflankalot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sirflankalot/subscriptions","organizations_url":"https://api.github.com/users/Sirflankalot/orgs","repos_url":"https://api.github.com/users/Sirflankalot/repos","events_url":"https://api.github.com/users/Sirflankalot/events{/privacy}","received_events_url":"https://api.github.com/users/Sirflankalot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-12-11T05:20:23Z","updated_at":"2016-12-12T23:18:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/leezer3/OpenBVE/pulls/119","html_url":"https://github.com/leezer3/OpenBVE/pull/119","diff_url":"https://github.com/leezer3/OpenBVE/pull/119.diff","patch_url":"https://github.com/leezer3/OpenBVE/pull/119.patch"},"body":"These rather drastic series of changes reorganizes the project so that everything can be built at once and the project is flatter.\r\n\r\n**Changes:**\r\n- All projects are now a top level folder inside source/ instead of being nested inside each other. \r\n- Debug builds get built into bin_debug/ and release builds get built into bin_release/.\r\n- There is both a makefile and a solution so that building on linux is less finicky.\r\n- Capitalization schemes were made consistent so that linux (which has a case-sensitive filesystem) plays nice with various components\r\n- Travis-ci uses linux makefile so output is easier to dissect.\r\n- Makefile uses higher warning level so that mono catches more bugs. \r\n- One or two small code changes were necessary for it to compile on linux. Errors were caused by not specifying the full name of a type and mono getting confused, or a minor problem with the wrong function being called when specifying the perspective matrix.\r\n\r\nI have tested this and all programs build and run fine. Should pass travis-ci checks. You might have to check the builds that were happening after success to make sure it works well with the new build system. It *should* based on what I can ascertain, but I can't really test it. \r\n\r\n**Edit:** Fix description of errors on linux."},"comment":{"url":"https://api.github.com/repos/leezer3/OpenBVE/issues/comments/266585030","html_url":"https://github.com/leezer3/OpenBVE/pull/119#issuecomment-266585030","issue_url":"https://api.github.com/repos/leezer3/OpenBVE/issues/119","id":266585030,"user":{"login":"Sirflankalot","id":7861353,"avatar_url":"https://avatars.githubusercontent.com/u/7861353?v=3","gravatar_id":"","url":"https://api.github.com/users/Sirflankalot","html_url":"https://github.com/Sirflankalot","followers_url":"https://api.github.com/users/Sirflankalot/followers","following_url":"https://api.github.com/users/Sirflankalot/following{/other_user}","gists_url":"https://api.github.com/users/Sirflankalot/gists{/gist_id}","starred_url":"https://api.github.com/users/Sirflankalot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sirflankalot/subscriptions","organizations_url":"https://api.github.com/users/Sirflankalot/orgs","repos_url":"https://api.github.com/users/Sirflankalot/repos","events_url":"https://api.github.com/users/Sirflankalot/events{/privacy}","received_events_url":"https://api.github.com/users/Sirflankalot/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T23:18:15Z","updated_at":"2016-12-12T23:18:15Z","body":"Yay! Great to hear!\r\n\r\nRegarding the issues.\r\n\r\n- I honestly haven't a clue how to fix that. I may be able to do something where if it detects a change in a sentinel file and make it touch every file to force a restart, or I could have it call itself with --always-make. I'll see what I can do, but don't expect anything soon, nor anything fancy.\r\n- Alright, I'll look at the commands being used and put together a mac app build. If you have a sec could you just give me a rundown of what happens? I've never actually done mac building before at all (plus I don't one). I will look at what is there to try to implement something but it will take some trial and error without some help. \r\n- Should be easy to fix.\r\n\r\nI am adding some commits to increase the amount of tests we do on travis-ci to test more edge cases (including one that uses gmcs to build!).\r\n"}}
{"actor":{"display_login":"Sirflankalot"}}