{"action":"created","comment":{"url":"https://api.github.com/repos/ddf-project/DDF/pulls/comments/62821522","id":62821522,"diff_hunk":"@@ -204,4 +204,38 @@ trait TransformationHandlerBaseSuite extends BaseSuite with Matchers {\n       smithsData.Transform.sort(columns, new util.ArrayList[Boolean]())\n     }\n   }\n+\n+  test(\"test sort inPlace false\") {\n+    val ddf: DDF = loadSmithsDDF().VIEWS.project(\"subject, variable, value\")\n+    val columns = new util.ArrayList[String]()","path":"ddf-test/src/main/scala/io/ddf/test/it/etl/TransformationHandlerBaseSuite.scala","position":7,"original_position":7,"commit_id":"75f8856fcdc5f327f3f450adf2c3f2e26f7126e7","original_commit_id":"75f8856fcdc5f327f3f450adf2c3f2e26f7126e7","user":{"login":"nhanitvn","id":1751491,"avatar_url":"https://avatars.githubusercontent.com/u/1751491?v=3","gravatar_id":"","url":"https://api.github.com/users/nhanitvn","html_url":"https://github.com/nhanitvn","followers_url":"https://api.github.com/users/nhanitvn/followers","following_url":"https://api.github.com/users/nhanitvn/following{/other_user}","gists_url":"https://api.github.com/users/nhanitvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nhanitvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhanitvn/subscriptions","organizations_url":"https://api.github.com/users/nhanitvn/orgs","repos_url":"https://api.github.com/users/nhanitvn/repos","events_url":"https://api.github.com/users/nhanitvn/events{/privacy}","received_events_url":"https://api.github.com/users/nhanitvn/received_events","type":"User","site_admin":false},"body":"Is there a shorter way to specify columns and ascending? May be construct a Scala list and convert to the Java one","created_at":"2016-05-11T09:59:31Z","updated_at":"2016-05-11T09:59:31Z","html_url":"https://github.com/ddf-project/DDF/pull/330#discussion_r62821522","pull_request_url":"https://api.github.com/repos/ddf-project/DDF/pulls/330","_links":{"self":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/comments/62821522"},"html":{"href":"https://github.com/ddf-project/DDF/pull/330#discussion_r62821522"},"pull_request":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/ddf-project/DDF/pulls/330","id":69478294,"html_url":"https://github.com/ddf-project/DDF/pull/330","diff_url":"https://github.com/ddf-project/DDF/pull/330.diff","patch_url":"https://github.com/ddf-project/DDF/pull/330.patch","issue_url":"https://api.github.com/repos/ddf-project/DDF/issues/330","number":330,"state":"open","locked":false,"title":"Add inplace flag sort to sort operation","user":{"login":"ducleminh","id":16630333,"avatar_url":"https://avatars.githubusercontent.com/u/16630333?v=3","gravatar_id":"","url":"https://api.github.com/users/ducleminh","html_url":"https://github.com/ducleminh","followers_url":"https://api.github.com/users/ducleminh/followers","following_url":"https://api.github.com/users/ducleminh/following{/other_user}","gists_url":"https://api.github.com/users/ducleminh/gists{/gist_id}","starred_url":"https://api.github.com/users/ducleminh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ducleminh/subscriptions","organizations_url":"https://api.github.com/users/ducleminh/orgs","repos_url":"https://api.github.com/users/ducleminh/repos","events_url":"https://api.github.com/users/ducleminh/events{/privacy}","received_events_url":"https://api.github.com/users/ducleminh/received_events","type":"User","site_admin":false},"body":"### Description and related tickets, documents\r\nAdd inplace flag sort to sort operation\r\n\r\nReviewers: @hai-adatao @nhanitvn @Huandao0812 @phvu \r\n\r\n### Breaking changes & backward compatible issues\r\nIs this PR a breaking change or has backward compatible issue (e.g: changes in API names, interfaces, signature / remove something...)?\r\nIf yes, please state out what and tag, and if it can possibly affect BA, please tag aht, tuananh, khangpham and baonguyen\r\n\r\n### How to test\r\nDescribe how this PR is tested. In case manual testing is required, describe how to do so.\r\n\r\n### PR Progress\r\nMake sure all checkboxes below are checked before merged\r\n- [x] Branch is in format `prefix/description` (see [this](http://www.guyroutledge.co.uk/blog/git-branch-naming-conventions/))\r\n- [x] Merge check has no conflicts. PR checks passed.\r\n- [x] Code review is done. \r\n\r\n","created_at":"2016-05-10T09:56:03Z","updated_at":"2016-05-11T09:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"593f30d4f666b02a8dfa62e7430479962e280a62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ddf-project/DDF/pulls/330/commits","review_comments_url":"https://api.github.com/repos/ddf-project/DDF/pulls/330/comments","review_comment_url":"https://api.github.com/repos/ddf-project/DDF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ddf-project/DDF/issues/330/comments","statuses_url":"https://api.github.com/repos/ddf-project/DDF/statuses/75f8856fcdc5f327f3f450adf2c3f2e26f7126e7","head":{"label":"ddf-project:improve/add-inplace-flag-sort","ref":"improve/add-inplace-flag-sort","sha":"75f8856fcdc5f327f3f450adf2c3f2e26f7126e7","user":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"repo":{"id":21636061,"name":"DDF","full_name":"ddf-project/DDF","owner":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ddf-project/DDF","description":"Distributed DataFrame: Productivity = Power x Simplicity For Scientists & Engineers, on any Data Engine","fork":false,"url":"https://api.github.com/repos/ddf-project/DDF","forks_url":"https://api.github.com/repos/ddf-project/DDF/forks","keys_url":"https://api.github.com/repos/ddf-project/DDF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddf-project/DDF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddf-project/DDF/teams","hooks_url":"https://api.github.com/repos/ddf-project/DDF/hooks","issue_events_url":"https://api.github.com/repos/ddf-project/DDF/issues/events{/number}","events_url":"https://api.github.com/repos/ddf-project/DDF/events","assignees_url":"https://api.github.com/repos/ddf-project/DDF/assignees{/user}","branches_url":"https://api.github.com/repos/ddf-project/DDF/branches{/branch}","tags_url":"https://api.github.com/repos/ddf-project/DDF/tags","blobs_url":"https://api.github.com/repos/ddf-project/DDF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddf-project/DDF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddf-project/DDF/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddf-project/DDF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddf-project/DDF/statuses/{sha}","languages_url":"https://api.github.com/repos/ddf-project/DDF/languages","stargazers_url":"https://api.github.com/repos/ddf-project/DDF/stargazers","contributors_url":"https://api.github.com/repos/ddf-project/DDF/contributors","subscribers_url":"https://api.github.com/repos/ddf-project/DDF/subscribers","subscription_url":"https://api.github.com/repos/ddf-project/DDF/subscription","commits_url":"https://api.github.com/repos/ddf-project/DDF/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddf-project/DDF/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddf-project/DDF/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddf-project/DDF/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddf-project/DDF/contents/{+path}","compare_url":"https://api.github.com/repos/ddf-project/DDF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddf-project/DDF/merges","archive_url":"https://api.github.com/repos/ddf-project/DDF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddf-project/DDF/downloads","issues_url":"https://api.github.com/repos/ddf-project/DDF/issues{/number}","pulls_url":"https://api.github.com/repos/ddf-project/DDF/pulls{/number}","milestones_url":"https://api.github.com/repos/ddf-project/DDF/milestones{/number}","notifications_url":"https://api.github.com/repos/ddf-project/DDF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddf-project/DDF/labels{/name}","releases_url":"https://api.github.com/repos/ddf-project/DDF/releases{/id}","deployments_url":"https://api.github.com/repos/ddf-project/DDF/deployments","created_at":"2014-07-09T02:16:59Z","updated_at":"2016-04-21T10:48:47Z","pushed_at":"2016-05-11T09:51:29Z","git_url":"git://github.com/ddf-project/DDF.git","ssh_url":"git@github.com:ddf-project/DDF.git","clone_url":"https://github.com/ddf-project/DDF.git","svn_url":"https://github.com/ddf-project/DDF","homepage":"http://ddf.io","size":168887,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":27,"forks":41,"open_issues":27,"watchers":129,"default_branch":"master"}},"base":{"label":"ddf-project:adatao","ref":"adatao","sha":"12807f4960225a38a0087d91a2d2f4d1e9d1e102","user":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"repo":{"id":21636061,"name":"DDF","full_name":"ddf-project/DDF","owner":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ddf-project/DDF","description":"Distributed DataFrame: Productivity = Power x Simplicity For Scientists & Engineers, on any Data Engine","fork":false,"url":"https://api.github.com/repos/ddf-project/DDF","forks_url":"https://api.github.com/repos/ddf-project/DDF/forks","keys_url":"https://api.github.com/repos/ddf-project/DDF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddf-project/DDF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddf-project/DDF/teams","hooks_url":"https://api.github.com/repos/ddf-project/DDF/hooks","issue_events_url":"https://api.github.com/repos/ddf-project/DDF/issues/events{/number}","events_url":"https://api.github.com/repos/ddf-project/DDF/events","assignees_url":"https://api.github.com/repos/ddf-project/DDF/assignees{/user}","branches_url":"https://api.github.com/repos/ddf-project/DDF/branches{/branch}","tags_url":"https://api.github.com/repos/ddf-project/DDF/tags","blobs_url":"https://api.github.com/repos/ddf-project/DDF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddf-project/DDF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddf-project/DDF/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddf-project/DDF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddf-project/DDF/statuses/{sha}","languages_url":"https://api.github.com/repos/ddf-project/DDF/languages","stargazers_url":"https://api.github.com/repos/ddf-project/DDF/stargazers","contributors_url":"https://api.github.com/repos/ddf-project/DDF/contributors","subscribers_url":"https://api.github.com/repos/ddf-project/DDF/subscribers","subscription_url":"https://api.github.com/repos/ddf-project/DDF/subscription","commits_url":"https://api.github.com/repos/ddf-project/DDF/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddf-project/DDF/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddf-project/DDF/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddf-project/DDF/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddf-project/DDF/contents/{+path}","compare_url":"https://api.github.com/repos/ddf-project/DDF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddf-project/DDF/merges","archive_url":"https://api.github.com/repos/ddf-project/DDF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddf-project/DDF/downloads","issues_url":"https://api.github.com/repos/ddf-project/DDF/issues{/number}","pulls_url":"https://api.github.com/repos/ddf-project/DDF/pulls{/number}","milestones_url":"https://api.github.com/repos/ddf-project/DDF/milestones{/number}","notifications_url":"https://api.github.com/repos/ddf-project/DDF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddf-project/DDF/labels{/name}","releases_url":"https://api.github.com/repos/ddf-project/DDF/releases{/id}","deployments_url":"https://api.github.com/repos/ddf-project/DDF/deployments","created_at":"2014-07-09T02:16:59Z","updated_at":"2016-04-21T10:48:47Z","pushed_at":"2016-05-11T09:51:29Z","git_url":"git://github.com/ddf-project/DDF.git","ssh_url":"git@github.com:ddf-project/DDF.git","clone_url":"https://github.com/ddf-project/DDF.git","svn_url":"https://github.com/ddf-project/DDF","homepage":"http://ddf.io","size":168887,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":27,"forks":41,"open_issues":27,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/330"},"html":{"href":"https://github.com/ddf-project/DDF/pull/330"},"issue":{"href":"https://api.github.com/repos/ddf-project/DDF/issues/330"},"comments":{"href":"https://api.github.com/repos/ddf-project/DDF/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/ddf-project/DDF/statuses/75f8856fcdc5f327f3f450adf2c3f2e26f7126e7"}}}}