{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/bosh-init/issues/73","repository_url":"https://api.github.com/repos/cloudfoundry/bosh-init","labels_url":"https://api.github.com/repos/cloudfoundry/bosh-init/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh-init/issues/73/comments","events_url":"https://api.github.com/repos/cloudfoundry/bosh-init/issues/73/events","html_url":"https://github.com/cloudfoundry/bosh-init/pull/73","id":149437689,"number":73,"title":"Add extra validations to bosh-init manifest: cloud_provider.mbus and cloud_provider.agent.mbus properties should user https protocol and have the same creds and ports","user":{"login":"allomov","id":122246,"avatar_url":"https://avatars.githubusercontent.com/u/122246?v=3","gravatar_id":"","url":"https://api.github.com/users/allomov","html_url":"https://github.com/allomov","followers_url":"https://api.github.com/users/allomov/followers","following_url":"https://api.github.com/users/allomov/following{/other_user}","gists_url":"https://api.github.com/users/allomov/gists{/gist_id}","starred_url":"https://api.github.com/users/allomov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allomov/subscriptions","organizations_url":"https://api.github.com/users/allomov/orgs","repos_url":"https://api.github.com/users/allomov/repos","events_url":"https://api.github.com/users/allomov/events{/privacy}","received_events_url":"https://api.github.com/users/allomov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-19T11:58:33Z","updated_at":"2016-04-28T13:37:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudfoundry/bosh-init/pulls/73","html_url":"https://github.com/cloudfoundry/bosh-init/pull/73","diff_url":"https://github.com/cloudfoundry/bosh-init/pull/73.diff","patch_url":"https://github.com/cloudfoundry/bosh-init/pull/73.patch"},"body":"Hey, all.\r\n\r\nThis PR add validations to prevent two a common errors that are not so easy to debug for a newcomer. \r\n\r\nThe first problem is that [bosh-agent does not expect having http](https://github.com/cloudfoundry/bosh-agent/blob/e726cc12a3ca0d875a3c7bbf42414365a67aa7f6/mbus/handler_provider.go#L50) as mbus protocol, so it simply skips connecting to mbus. This means that mbus properties should always have https protocol.\r\n\r\nThe second error is typos in passwords/usernames/ports of mbus parameters. This PR adds checks if this properties are similar in mbus URLs in  `cloud_properties.mbus` and `cloud_properties.properties.agent.mbus`.\r\n\r\nWhat do you think on this changes?"},"comment":{"url":"https://api.github.com/repos/cloudfoundry/bosh-init/issues/comments/215424958","html_url":"https://github.com/cloudfoundry/bosh-init/pull/73#issuecomment-215424958","issue_url":"https://api.github.com/repos/cloudfoundry/bosh-init/issues/73","id":215424958,"user":{"login":"allomov","id":122246,"avatar_url":"https://avatars.githubusercontent.com/u/122246?v=3","gravatar_id":"","url":"https://api.github.com/users/allomov","html_url":"https://github.com/allomov","followers_url":"https://api.github.com/users/allomov/followers","following_url":"https://api.github.com/users/allomov/following{/other_user}","gists_url":"https://api.github.com/users/allomov/gists{/gist_id}","starred_url":"https://api.github.com/users/allomov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allomov/subscriptions","organizations_url":"https://api.github.com/users/allomov/orgs","repos_url":"https://api.github.com/users/allomov/repos","events_url":"https://api.github.com/users/allomov/events{/privacy}","received_events_url":"https://api.github.com/users/allomov/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T13:37:10Z","updated_at":"2016-04-28T13:37:10Z","body":"@cppforlife as far as I understand, `cloud_provider.mbus` is a required field. Could you confirm it's true?"}}