{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/54566902","id":54566902,"diff_hunk":"@@ -61,9 +61,9 @@ public void generateSequenceTest() throws Exception {\n \t\tassertEquals(expectedList, actualList);\n \t}\n \n-\t@Test\n-\tpublic void socketTextStreamTest() throws Exception {\n-\t\t// TODO: does not work because we cannot set the internal socket anymore\n+// TODO: does not work because we cannot set the internal socket anymore\n+//\t@Test\n+//\tpublic void socketTextStreamTest() throws Exception {","path":"flink-streaming-java/src/test/java/org/apache/flink/streaming/api/SourceFunctionTest.java","position":9,"original_position":9,"commit_id":"f3a255c5317d3e883e03ee73ac1737cda563d7ca","original_commit_id":"f3a255c5317d3e883e03ee73ac1737cda563d7ca","user":{"login":"tillrohrmann","id":5756858,"avatar_url":"https://avatars.githubusercontent.com/u/5756858?v=3","gravatar_id":"","url":"https://api.github.com/users/tillrohrmann","html_url":"https://github.com/tillrohrmann","followers_url":"https://api.github.com/users/tillrohrmann/followers","following_url":"https://api.github.com/users/tillrohrmann/following{/other_user}","gists_url":"https://api.github.com/users/tillrohrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/tillrohrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillrohrmann/subscriptions","organizations_url":"https://api.github.com/users/tillrohrmann/orgs","repos_url":"https://api.github.com/users/tillrohrmann/repos","events_url":"https://api.github.com/users/tillrohrmann/events{/privacy}","received_events_url":"https://api.github.com/users/tillrohrmann/received_events","type":"User","site_admin":false},"body":"Why not removing this test?","created_at":"2016-03-01T13:39:15Z","updated_at":"2016-03-01T13:39:15Z","html_url":"https://github.com/apache/flink/pull/1750#discussion_r54566902","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/1750","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/54566902"},"html":{"href":"https://github.com/apache/flink/pull/1750#discussion_r54566902"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/1750"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/1750","id":61242130,"html_url":"https://github.com/apache/flink/pull/1750","diff_url":"https://github.com/apache/flink/pull/1750.diff","patch_url":"https://github.com/apache/flink/pull/1750.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/1750","number":1750,"state":"open","locked":false,"title":"[FLINK-3554] [streaming] Emit a MAX Watermark after finite sources finished","user":{"login":"StephanEwen","id":1727146,"avatar_url":"https://avatars.githubusercontent.com/u/1727146?v=3","gravatar_id":"","url":"https://api.github.com/users/StephanEwen","html_url":"https://github.com/StephanEwen","followers_url":"https://api.github.com/users/StephanEwen/followers","following_url":"https://api.github.com/users/StephanEwen/following{/other_user}","gists_url":"https://api.github.com/users/StephanEwen/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanEwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanEwen/subscriptions","organizations_url":"https://api.github.com/users/StephanEwen/orgs","repos_url":"https://api.github.com/users/StephanEwen/repos","events_url":"https://api.github.com/users/StephanEwen/events{/privacy}","received_events_url":"https://api.github.com/users/StephanEwen/received_events","type":"User","site_admin":false},"body":"Finite sources now emit a MAX_LONG watermark once they cleanly finished.\r\n\r\nThis prevents loss of pending windows over finite sources when they finish.\r\n\r\nCanceling and stopping sources will NOT emit a MAX Watermark.","created_at":"2016-03-01T13:34:01Z","updated_at":"2016-03-01T13:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92686d9e1937d4c989d523230ac79c01f9773d96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/1750/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/1750/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/1750/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/f3a255c5317d3e883e03ee73ac1737cda563d7ca","head":{"label":"StephanEwen:finite_max_watermark","ref":"finite_max_watermark","sha":"f3a255c5317d3e883e03ee73ac1737cda563d7ca","user":{"login":"StephanEwen","id":1727146,"avatar_url":"https://avatars.githubusercontent.com/u/1727146?v=3","gravatar_id":"","url":"https://api.github.com/users/StephanEwen","html_url":"https://github.com/StephanEwen","followers_url":"https://api.github.com/users/StephanEwen/followers","following_url":"https://api.github.com/users/StephanEwen/following{/other_user}","gists_url":"https://api.github.com/users/StephanEwen/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanEwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanEwen/subscriptions","organizations_url":"https://api.github.com/users/StephanEwen/orgs","repos_url":"https://api.github.com/users/StephanEwen/repos","events_url":"https://api.github.com/users/StephanEwen/events{/privacy}","received_events_url":"https://api.github.com/users/StephanEwen/received_events","type":"User","site_admin":false},"repo":{"id":21171031,"name":"incubator-flink","full_name":"StephanEwen/incubator-flink","owner":{"login":"StephanEwen","id":1727146,"avatar_url":"https://avatars.githubusercontent.com/u/1727146?v=3","gravatar_id":"","url":"https://api.github.com/users/StephanEwen","html_url":"https://github.com/StephanEwen","followers_url":"https://api.github.com/users/StephanEwen/followers","following_url":"https://api.github.com/users/StephanEwen/following{/other_user}","gists_url":"https://api.github.com/users/StephanEwen/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanEwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanEwen/subscriptions","organizations_url":"https://api.github.com/users/StephanEwen/orgs","repos_url":"https://api.github.com/users/StephanEwen/repos","events_url":"https://api.github.com/users/StephanEwen/events{/privacy}","received_events_url":"https://api.github.com/users/StephanEwen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StephanEwen/incubator-flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/StephanEwen/incubator-flink","forks_url":"https://api.github.com/repos/StephanEwen/incubator-flink/forks","keys_url":"https://api.github.com/repos/StephanEwen/incubator-flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StephanEwen/incubator-flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StephanEwen/incubator-flink/teams","hooks_url":"https://api.github.com/repos/StephanEwen/incubator-flink/hooks","issue_events_url":"https://api.github.com/repos/StephanEwen/incubator-flink/issues/events{/number}","events_url":"https://api.github.com/repos/StephanEwen/incubator-flink/events","assignees_url":"https://api.github.com/repos/StephanEwen/incubator-flink/assignees{/user}","branches_url":"https://api.github.com/repos/StephanEwen/incubator-flink/branches{/branch}","tags_url":"https://api.github.com/repos/StephanEwen/incubator-flink/tags","blobs_url":"https://api.github.com/repos/StephanEwen/incubator-flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StephanEwen/incubator-flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StephanEwen/incubator-flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/StephanEwen/incubator-flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StephanEwen/incubator-flink/statuses/{sha}","languages_url":"https://api.github.com/repos/StephanEwen/incubator-flink/languages","stargazers_url":"https://api.github.com/repos/StephanEwen/incubator-flink/stargazers","contributors_url":"https://api.github.com/repos/StephanEwen/incubator-flink/contributors","subscribers_url":"https://api.github.com/repos/StephanEwen/incubator-flink/subscribers","subscription_url":"https://api.github.com/repos/StephanEwen/incubator-flink/subscription","commits_url":"https://api.github.com/repos/StephanEwen/incubator-flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/StephanEwen/incubator-flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/StephanEwen/incubator-flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/StephanEwen/incubator-flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/StephanEwen/incubator-flink/contents/{+path}","compare_url":"https://api.github.com/repos/StephanEwen/incubator-flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StephanEwen/incubator-flink/merges","archive_url":"https://api.github.com/repos/StephanEwen/incubator-flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StephanEwen/incubator-flink/downloads","issues_url":"https://api.github.com/repos/StephanEwen/incubator-flink/issues{/number}","pulls_url":"https://api.github.com/repos/StephanEwen/incubator-flink/pulls{/number}","milestones_url":"https://api.github.com/repos/StephanEwen/incubator-flink/milestones{/number}","notifications_url":"https://api.github.com/repos/StephanEwen/incubator-flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StephanEwen/incubator-flink/labels{/name}","releases_url":"https://api.github.com/repos/StephanEwen/incubator-flink/releases{/id}","deployments_url":"https://api.github.com/repos/StephanEwen/incubator-flink/deployments","created_at":"2014-06-24T15:57:00Z","updated_at":"2016-01-14T19:38:16Z","pushed_at":"2016-03-01T13:32:22Z","git_url":"git://github.com/StephanEwen/incubator-flink.git","ssh_url":"git@github.com:StephanEwen/incubator-flink.git","clone_url":"https://github.com/StephanEwen/incubator-flink.git","svn_url":"https://github.com/StephanEwen/incubator-flink","homepage":null,"size":80951,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e8e88afdc4807277a1d8df8663b33e60b5688d0d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2016-02-28T14:38:19Z","pushed_at":"2016-03-01T13:34:02Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":107034,"stargazers_count":1025,"watchers_count":1025,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":659,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":92,"forks":659,"open_issues":92,"watchers":1025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/1750"},"html":{"href":"https://github.com/apache/flink/pull/1750"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/1750"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/1750/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/1750/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/1750/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/f3a255c5317d3e883e03ee73ac1737cda563d7ca"}}}}