{"action":"created","comment":{"url":"https://api.github.com/repos/freebsd/pkg/pulls/comments/92981265","pull_request_review_id":13496234,"id":92981265,"diff_hunk":"@@ -293,24 +297,22 @@ pkgdb_upgrade(struct pkgdb *db)\n \telse if (db_version > DBVERSION) {\n \t\tif (db_version / 1000 <= DB_SCHEMA_MAJOR) {\n \t\t\t/* VIEWS and TRIGGERS used as compatibility hack */\n-\t\t\tpkg_emit_error(\"warning: database version %\" PRId64\n+\t\t\tpkg_errno(\"warning: database version %\" PRId64\n \t\t\t    \" is newer than libpkg(3) version %d, but still \"\n \t\t\t    \"compatible\", db_version, DBVERSION);\n \t\t\treturn (EPKG_OK);\n \t\t} else {\n-\t\t\tpkg_emit_error(\"database version %\" PRId64 \" is newer \"\n+\t\t\tpkg_fatal_errno(\"database version %\" PRId64 \" is newer \"","path":"libpkg/pkgdb.c","position":22,"original_position":22,"commit_id":"6bccf22366c01a0c901c65077e5066c651edd0fa","original_commit_id":"6bccf22366c01a0c901c65077e5066c651edd0fa","user":{"login":"bapt","id":103607,"avatar_url":"https://avatars.githubusercontent.com/u/103607?v=3","gravatar_id":"","url":"https://api.github.com/users/bapt","html_url":"https://github.com/bapt","followers_url":"https://api.github.com/users/bapt/followers","following_url":"https://api.github.com/users/bapt/following{/other_user}","gists_url":"https://api.github.com/users/bapt/gists{/gist_id}","starred_url":"https://api.github.com/users/bapt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bapt/subscriptions","organizations_url":"https://api.github.com/users/bapt/orgs","repos_url":"https://api.github.com/users/bapt/repos","events_url":"https://api.github.com/users/bapt/events{/privacy}","received_events_url":"https://api.github.com/users/bapt/received_events","type":"User","site_admin":false},"body":"it was not using errno on purpose","created_at":"2016-12-19T07:43:13Z","updated_at":"2016-12-19T07:43:13Z","html_url":"https://github.com/freebsd/pkg/pull/1518#discussion_r92981265","pull_request_url":"https://api.github.com/repos/freebsd/pkg/pulls/1518","_links":{"self":{"href":"https://api.github.com/repos/freebsd/pkg/pulls/comments/92981265"},"html":{"href":"https://github.com/freebsd/pkg/pull/1518#discussion_r92981265"},"pull_request":{"href":"https://api.github.com/repos/freebsd/pkg/pulls/1518"}}},"pull_request":{"url":"https://api.github.com/repos/freebsd/pkg/pulls/1518","id":98500707,"html_url":"https://github.com/freebsd/pkg/pull/1518","diff_url":"https://github.com/freebsd/pkg/pull/1518.diff","patch_url":"https://github.com/freebsd/pkg/pull/1518.patch","issue_url":"https://api.github.com/repos/freebsd/pkg/issues/1518","number":1518,"state":"open","locked":false,"title":"libpkg: use pkg_fatal_errno/pkg_errno everywhere","user":{"login":"ThomasAdam","id":101281,"avatar_url":"https://avatars.githubusercontent.com/u/101281?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasAdam","html_url":"https://github.com/ThomasAdam","followers_url":"https://api.github.com/users/ThomasAdam/followers","following_url":"https://api.github.com/users/ThomasAdam/following{/other_user}","gists_url":"https://api.github.com/users/ThomasAdam/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasAdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasAdam/subscriptions","organizations_url":"https://api.github.com/users/ThomasAdam/orgs","repos_url":"https://api.github.com/users/ThomasAdam/repos","events_url":"https://api.github.com/users/ThomasAdam/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasAdam/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nPlease see the following patches which:\r\n\r\n1.  Switches `libpkg` over to use the recently added `pkg_fatal_errno` and `pkg_errno` macros.  Now we're standardizing on this.\r\n\r\n2.  Updates the `unchecked_malloc.cocci` script to better cover missing NULL checks from various heap-allocation memory tools.\r\n\r\n","created_at":"2016-12-19T02:59:38Z","updated_at":"2016-12-19T07:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42fec9143e82449456b17662760aca26cd1bcf43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/freebsd/pkg/pulls/1518/commits","review_comments_url":"https://api.github.com/repos/freebsd/pkg/pulls/1518/comments","review_comment_url":"https://api.github.com/repos/freebsd/pkg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freebsd/pkg/issues/1518/comments","statuses_url":"https://api.github.com/repos/freebsd/pkg/statuses/6bccf22366c01a0c901c65077e5066c651edd0fa","head":{"label":"ThomasAdam:ta/add-missing-null","ref":"ta/add-missing-null","sha":"6bccf22366c01a0c901c65077e5066c651edd0fa","user":{"login":"ThomasAdam","id":101281,"avatar_url":"https://avatars.githubusercontent.com/u/101281?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasAdam","html_url":"https://github.com/ThomasAdam","followers_url":"https://api.github.com/users/ThomasAdam/followers","following_url":"https://api.github.com/users/ThomasAdam/following{/other_user}","gists_url":"https://api.github.com/users/ThomasAdam/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasAdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasAdam/subscriptions","organizations_url":"https://api.github.com/users/ThomasAdam/orgs","repos_url":"https://api.github.com/users/ThomasAdam/repos","events_url":"https://api.github.com/users/ThomasAdam/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasAdam/received_events","type":"User","site_admin":false},"repo":{"id":69600124,"name":"pkg","full_name":"ThomasAdam/pkg","owner":{"login":"ThomasAdam","id":101281,"avatar_url":"https://avatars.githubusercontent.com/u/101281?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasAdam","html_url":"https://github.com/ThomasAdam","followers_url":"https://api.github.com/users/ThomasAdam/followers","following_url":"https://api.github.com/users/ThomasAdam/following{/other_user}","gists_url":"https://api.github.com/users/ThomasAdam/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasAdam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasAdam/subscriptions","organizations_url":"https://api.github.com/users/ThomasAdam/orgs","repos_url":"https://api.github.com/users/ThomasAdam/repos","events_url":"https://api.github.com/users/ThomasAdam/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasAdam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThomasAdam/pkg","description":"Package management tool for FreeBSD. Help at #pkgng on Freenode or pkg@FreeBSD.org","fork":true,"url":"https://api.github.com/repos/ThomasAdam/pkg","forks_url":"https://api.github.com/repos/ThomasAdam/pkg/forks","keys_url":"https://api.github.com/repos/ThomasAdam/pkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomasAdam/pkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomasAdam/pkg/teams","hooks_url":"https://api.github.com/repos/ThomasAdam/pkg/hooks","issue_events_url":"https://api.github.com/repos/ThomasAdam/pkg/issues/events{/number}","events_url":"https://api.github.com/repos/ThomasAdam/pkg/events","assignees_url":"https://api.github.com/repos/ThomasAdam/pkg/assignees{/user}","branches_url":"https://api.github.com/repos/ThomasAdam/pkg/branches{/branch}","tags_url":"https://api.github.com/repos/ThomasAdam/pkg/tags","blobs_url":"https://api.github.com/repos/ThomasAdam/pkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomasAdam/pkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomasAdam/pkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomasAdam/pkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomasAdam/pkg/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomasAdam/pkg/languages","stargazers_url":"https://api.github.com/repos/ThomasAdam/pkg/stargazers","contributors_url":"https://api.github.com/repos/ThomasAdam/pkg/contributors","subscribers_url":"https://api.github.com/repos/ThomasAdam/pkg/subscribers","subscription_url":"https://api.github.com/repos/ThomasAdam/pkg/subscription","commits_url":"https://api.github.com/repos/ThomasAdam/pkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomasAdam/pkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomasAdam/pkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomasAdam/pkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomasAdam/pkg/contents/{+path}","compare_url":"https://api.github.com/repos/ThomasAdam/pkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomasAdam/pkg/merges","archive_url":"https://api.github.com/repos/ThomasAdam/pkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomasAdam/pkg/downloads","issues_url":"https://api.github.com/repos/ThomasAdam/pkg/issues{/number}","pulls_url":"https://api.github.com/repos/ThomasAdam/pkg/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomasAdam/pkg/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomasAdam/pkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomasAdam/pkg/labels{/name}","releases_url":"https://api.github.com/repos/ThomasAdam/pkg/releases{/id}","deployments_url":"https://api.github.com/repos/ThomasAdam/pkg/deployments","created_at":"2016-09-29T19:22:14Z","updated_at":"2016-09-29T19:22:17Z","pushed_at":"2016-12-19T02:56:18Z","git_url":"git://github.com/ThomasAdam/pkg.git","ssh_url":"git@github.com:ThomasAdam/pkg.git","clone_url":"https://github.com/ThomasAdam/pkg.git","svn_url":"https://github.com/ThomasAdam/pkg","homepage":"http://wiki.freebsd.org/pkgng","size":25684,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freebsd:master","ref":"master","sha":"f390c1157c27d0f9b9f86bffbbba572265e7189a","user":{"login":"freebsd","id":811839,"avatar_url":"https://avatars.githubusercontent.com/u/811839?v=3","gravatar_id":"","url":"https://api.github.com/users/freebsd","html_url":"https://github.com/freebsd","followers_url":"https://api.github.com/users/freebsd/followers","following_url":"https://api.github.com/users/freebsd/following{/other_user}","gists_url":"https://api.github.com/users/freebsd/gists{/gist_id}","starred_url":"https://api.github.com/users/freebsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freebsd/subscriptions","organizations_url":"https://api.github.com/users/freebsd/orgs","repos_url":"https://api.github.com/users/freebsd/repos","events_url":"https://api.github.com/users/freebsd/events{/privacy}","received_events_url":"https://api.github.com/users/freebsd/received_events","type":"Organization","site_admin":false},"repo":{"id":1530481,"name":"pkg","full_name":"freebsd/pkg","owner":{"login":"freebsd","id":811839,"avatar_url":"https://avatars.githubusercontent.com/u/811839?v=3","gravatar_id":"","url":"https://api.github.com/users/freebsd","html_url":"https://github.com/freebsd","followers_url":"https://api.github.com/users/freebsd/followers","following_url":"https://api.github.com/users/freebsd/following{/other_user}","gists_url":"https://api.github.com/users/freebsd/gists{/gist_id}","starred_url":"https://api.github.com/users/freebsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freebsd/subscriptions","organizations_url":"https://api.github.com/users/freebsd/orgs","repos_url":"https://api.github.com/users/freebsd/repos","events_url":"https://api.github.com/users/freebsd/events{/privacy}","received_events_url":"https://api.github.com/users/freebsd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freebsd/pkg","description":"Package management tool for FreeBSD. Help at #pkgng on Freenode or pkg@FreeBSD.org","fork":false,"url":"https://api.github.com/repos/freebsd/pkg","forks_url":"https://api.github.com/repos/freebsd/pkg/forks","keys_url":"https://api.github.com/repos/freebsd/pkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freebsd/pkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freebsd/pkg/teams","hooks_url":"https://api.github.com/repos/freebsd/pkg/hooks","issue_events_url":"https://api.github.com/repos/freebsd/pkg/issues/events{/number}","events_url":"https://api.github.com/repos/freebsd/pkg/events","assignees_url":"https://api.github.com/repos/freebsd/pkg/assignees{/user}","branches_url":"https://api.github.com/repos/freebsd/pkg/branches{/branch}","tags_url":"https://api.github.com/repos/freebsd/pkg/tags","blobs_url":"https://api.github.com/repos/freebsd/pkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freebsd/pkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freebsd/pkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/freebsd/pkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freebsd/pkg/statuses/{sha}","languages_url":"https://api.github.com/repos/freebsd/pkg/languages","stargazers_url":"https://api.github.com/repos/freebsd/pkg/stargazers","contributors_url":"https://api.github.com/repos/freebsd/pkg/contributors","subscribers_url":"https://api.github.com/repos/freebsd/pkg/subscribers","subscription_url":"https://api.github.com/repos/freebsd/pkg/subscription","commits_url":"https://api.github.com/repos/freebsd/pkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/freebsd/pkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/freebsd/pkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/freebsd/pkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/freebsd/pkg/contents/{+path}","compare_url":"https://api.github.com/repos/freebsd/pkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freebsd/pkg/merges","archive_url":"https://api.github.com/repos/freebsd/pkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freebsd/pkg/downloads","issues_url":"https://api.github.com/repos/freebsd/pkg/issues{/number}","pulls_url":"https://api.github.com/repos/freebsd/pkg/pulls{/number}","milestones_url":"https://api.github.com/repos/freebsd/pkg/milestones{/number}","notifications_url":"https://api.github.com/repos/freebsd/pkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freebsd/pkg/labels{/name}","releases_url":"https://api.github.com/repos/freebsd/pkg/releases{/id}","deployments_url":"https://api.github.com/repos/freebsd/pkg/deployments","created_at":"2011-03-26T20:35:45Z","updated_at":"2016-12-08T05:27:17Z","pushed_at":"2016-12-19T02:59:38Z","git_url":"git://github.com/freebsd/pkg.git","ssh_url":"git@github.com:freebsd/pkg.git","clone_url":"https://github.com/freebsd/pkg.git","svn_url":"https://github.com/freebsd/pkg","homepage":"http://wiki.freebsd.org/pkgng","size":25580,"stargazers_count":476,"watchers_count":476,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":210,"forks":154,"open_issues":210,"watchers":476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freebsd/pkg/pulls/1518"},"html":{"href":"https://github.com/freebsd/pkg/pull/1518"},"issue":{"href":"https://api.github.com/repos/freebsd/pkg/issues/1518"},"comments":{"href":"https://api.github.com/repos/freebsd/pkg/issues/1518/comments"},"review_comments":{"href":"https://api.github.com/repos/freebsd/pkg/pulls/1518/comments"},"review_comment":{"href":"https://api.github.com/repos/freebsd/pkg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freebsd/pkg/pulls/1518/commits"},"statuses":{"href":"https://api.github.com/repos/freebsd/pkg/statuses/6bccf22366c01a0c901c65077e5066c651edd0fa"}}}}
{"actor":{"display_login":"bapt"}}