{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3366","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3366/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3366/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3366/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3366","id":123136522,"number":3366,"title":"[Testing required] VideoBackends: New post-processing system","user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars.githubusercontent.com/u/11288319?v=3","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dolphin-emu/dolphin/labels/needs%20testing","name":"needs testing","color":"fbca04"},{"url":"https://api.github.com/repos/dolphin-emu/dolphin/labels/WIP","name":"WIP","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":41,"created_at":"2015-12-20T06:23:09Z","updated_at":"2016-03-15T05:23:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3366","html_url":"https://github.com/dolphin-emu/dolphin/pull/3366","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3366.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3366.patch"},"body":"Originally started out as just a adding depth buffer access, but to do useful effects we need a more advanced system. I branched the old code off at https://github.com/stenzek/dolphin/tree/postprocess-depth-access-only\r\n\r\nDone:\r\n - multipass\r\n - copying/scaling\r\n - ability to pull in external textures (e.g. random/noise)\r\n - trigger post-processing at specific points (perspective switch, efb copy)\r\n - separate post and resize filters (also used for anaglyph)\r\n - chaining multiple effects/shaders\r\n - new config format\r\n\r\nNote about XFB: Using post-processing shaders that require the depth buffer will not work consistently with XFB, expect flickering. This is due to not storing a copy of the depth buffer when copying EFB->XFB, and even if we did, it could still potentially be different, if the game modified the XFB contents.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3366)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/196668299","html_url":"https://github.com/dolphin-emu/dolphin/pull/3366#issuecomment-196668299","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3366","id":196668299,"user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars.githubusercontent.com/u/11288319?v=3","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T05:23:38Z","updated_at":"2016-03-15T05:23:38Z","body":"> @stenzek I think it's this commit Tinob/Ishiiruka@4822c37\r\nThis has nothing to do with post-processing. Please stop linking random revisions, and at least look at the diff of the PR to avoid bringing up features that are actually implemented..\r\n\r\n> Without option to disable filtering upscaling shaders like these https://github.com/Tinob/Ishiiruka/tree/master/Data/Sys/Shaders/Scaling\r\nWhere do you think the idea for scaling shaders/implementation came from? :)\r\nIt's practically taken from this PR plus a few changes from what I saw..\r\nNot making any config changes at this point, this feature has been \"complete\" for a while now."}}