{"action":"created","issue":{"url":"https://api.github.com/repos/GideonLeGrange/panstamp-java/issues/19","labels_url":"https://api.github.com/repos/GideonLeGrange/panstamp-java/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/GideonLeGrange/panstamp-java/issues/19/comments","events_url":"https://api.github.com/repos/GideonLeGrange/panstamp-java/issues/19/events","html_url":"https://github.com/GideonLeGrange/panstamp-java/pull/19","id":128335495,"number":19,"title":"Fix size of bytes in write, use bytes from register, not from endpoint","user":{"login":"MathiasMoog","id":16824723,"avatar_url":"https://avatars.githubusercontent.com/u/16824723?v=3","gravatar_id":"","url":"https://api.github.com/users/MathiasMoog","html_url":"https://github.com/MathiasMoog","followers_url":"https://api.github.com/users/MathiasMoog/followers","following_url":"https://api.github.com/users/MathiasMoog/following{/other_user}","gists_url":"https://api.github.com/users/MathiasMoog/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasMoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasMoog/subscriptions","organizations_url":"https://api.github.com/users/MathiasMoog/orgs","repos_url":"https://api.github.com/users/MathiasMoog/repos","events_url":"https://api.github.com/users/MathiasMoog/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasMoog/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-23T15:56:09Z","updated_at":"2016-01-24T21:30:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GideonLeGrange/panstamp-java/pulls/19","html_url":"https://github.com/GideonLeGrange/panstamp-java/pull/19","diff_url":"https://github.com/GideonLeGrange/panstamp-java/pull/19.diff","patch_url":"https://github.com/GideonLeGrange/panstamp-java/pull/19.patch"},"body":"Dear Gideon,\r\n\r\nI fixed a bug in the NumberEndpoint. If there are more than one Endpoints in a register, the size of the byte Array is wrong in the write Method.\r\nIch extended the code similar to the IntegerEndpoint and take the bytes from the register and not from the endpoint.\r\n\r\nBest Regards\r\n\r\n  Mathias\r\n\r\nBy the way, I have an extension for the panstamp-tools library, a Get value (query) similar to Set value. If you like I can send you the code fragment or create a pull request\r\n"},"comment":{"url":"https://api.github.com/repos/GideonLeGrange/panstamp-java/issues/comments/174343305","html_url":"https://github.com/GideonLeGrange/panstamp-java/pull/19#issuecomment-174343305","issue_url":"https://api.github.com/repos/GideonLeGrange/panstamp-java/issues/19","id":174343305,"user":{"login":"GideonLeGrange","id":1131028,"avatar_url":"https://avatars.githubusercontent.com/u/1131028?v=3","gravatar_id":"","url":"https://api.github.com/users/GideonLeGrange","html_url":"https://github.com/GideonLeGrange","followers_url":"https://api.github.com/users/GideonLeGrange/followers","following_url":"https://api.github.com/users/GideonLeGrange/following{/other_user}","gists_url":"https://api.github.com/users/GideonLeGrange/gists{/gist_id}","starred_url":"https://api.github.com/users/GideonLeGrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GideonLeGrange/subscriptions","organizations_url":"https://api.github.com/users/GideonLeGrange/orgs","repos_url":"https://api.github.com/users/GideonLeGrange/repos","events_url":"https://api.github.com/users/GideonLeGrange/events{/privacy}","received_events_url":"https://api.github.com/users/GideonLeGrange/received_events","type":"User","site_admin":false},"created_at":"2016-01-24T21:30:27Z","updated_at":"2016-01-24T21:30:27Z","body":"Hi Mathias\r\n\r\nYou're right, `NumberEndpoint.write` is incorrect. Thank you for picking this up and fixing it. \r\n\r\nI want to accept your pull request, but there is one problem. You've made `PanStamp.sendQueryMessage` public. It is part of the internals of the panstamp-java library and should not be public. If you need more functionality, I'll rather figure out how to adapt the public interface to address that. \r\n\r\nCan you please remove the commits after `d7aed64` from the pull request so I can accept it? \r\n\r\nMany thanks\r\nGideon "}}