{"action":"created","issue":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/962","repository_url":"https://api.github.com/repos/BloomBooks/BloomDesktop","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/962/labels{/name}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/962/comments","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/962/events","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/962","id":140204836,"number":962,"title":"(3.5) BL-3222 prevent crash if we can't save prefs","user":{"login":"hatton","id":8448,"avatar_url":"https://avatars.githubusercontent.com/u/8448?v=3","gravatar_id":"","url":"https://api.github.com/users/hatton","html_url":"https://github.com/hatton","followers_url":"https://api.github.com/users/hatton/followers","following_url":"https://api.github.com/users/hatton/following{/other_user}","gists_url":"https://api.github.com/users/hatton/gists{/gist_id}","starred_url":"https://api.github.com/users/hatton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatton/subscriptions","organizations_url":"https://api.github.com/users/hatton/orgs","repos_url":"https://api.github.com/users/hatton/repos","events_url":"https://api.github.com/users/hatton/events{/privacy}","received_events_url":"https://api.github.com/users/hatton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-11T15:00:52Z","updated_at":"2016-03-11T16:19:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/962","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/962","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/962.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/962.patch"},"body":"In a libpalaso PR, I'll fix the actual problem.\r\nThis introduces a way to report non fatal problems like this in different way depending on the channel.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/bloombooks/bloomdesktop/962)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments/195436579","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/962#issuecomment-195436579","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/962","id":195436579,"user":{"login":"JohnThomson","id":1360521,"avatar_url":"https://avatars.githubusercontent.com/u/1360521?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnThomson","html_url":"https://github.com/JohnThomson","followers_url":"https://api.github.com/users/JohnThomson/followers","following_url":"https://api.github.com/users/JohnThomson/following{/other_user}","gists_url":"https://api.github.com/users/JohnThomson/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnThomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnThomson/subscriptions","organizations_url":"https://api.github.com/users/JohnThomson/orgs","repos_url":"https://api.github.com/users/JohnThomson/repos","events_url":"https://api.github.com/users/JohnThomson/events{/privacy}","received_events_url":"https://api.github.com/users/JohnThomson/received_events","type":"User","site_admin":false},"created_at":"2016-03-11T16:19:13Z","updated_at":"2016-03-11T16:19:13Z","body":"\n\n\n\nReviewed 3 of 3 files at r1.\nReview status: 2 of 3 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/BloomExe/NonFatalProblem.cs, line 32 \\[r1\\]](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/962#-KCaRgGPAZ-URSYLwQKt:-KCaRgGPAZ-URSYLwQKu:346949973) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/2b9379ea5786879cd59b192f418b39295ea6c5a8/src/BloomExe/NonFatalProblem.cs#L32)):*\nIs it intentional that for any OTHER channel (e.g., uganda) even things that should be thrown in release builds will not be thrown?\n\nWhat if we changed it to channel.startsWith(s), and return an empty string as the sole item for Release, so it always matches? Also, if we made a special channel like betaKentWorkshop, it would be treated as beta.\n\n---\n\n*[src/BloomExe/NonFatalProblem.cs, line 61 \\[r1\\]](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/962#-KCaQYPpiTOJCrAgLcve:-KCaQYPpiTOJCrAgLcvf:650582888) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/2b9379ea5786879cd59b192f418b39295ea6c5a8/src/BloomExe/NonFatalProblem.cs#L61)):*\nIt's a pity to duplicate this logic. With a comment that ThrowIf and InformIf must have the same options in the same order, it might work to just return Matches((ThrowIf)t). Or as long as they DO have the same items, Matches(ThrowIf.Parse(t.ToString()).\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/bloombooks/bloomdesktop/962)*\n<!-- Sent from Reviewable.io -->\n"}}