{"action":"created","comment":{"url":"https://api.github.com/repos/MoOx/phenomic/pulls/comments/77115802","id":77115802,"diff_hunk":"@@ -233,29 +233,27 @@ class PageContainer extends Component<DefaultProps, Props, void> {\n     const LayoutFallback = getLayout(props.defaultLayout, props)\n     const Layout = getLayout(page.type, props) || LayoutFallback\n \n-    return (\n-      <div>\n-        {\n-          !page.error && page.loading && PageLoading &&\n-          <PageLoading />\n-        }\n-        {\n-          !!page.error && !PageError &&\n+    if (page.error) {\n+      if (!PageError) {\n+        return (\n           <div style={ { \"text-align\": \"center\" } }>\n             <h1>{ page.error }</h1>\n             <p>{ page.errorText }</p>\n           </div>\n-        }\n-        {\n-          !!page.error && PageError &&\n-          <PageError { ...page } />\n-        }\n-        {\n-          !page.error && !page.loading && Layout &&\n-          <Layout ref={ this.saveContentRef } { ...page } />\n-        }\n-      </div>\n-    )\n+        )\n+      }\n+      return <PageError { ...page } />\n+    }\n+    else {\n+      if (page.loading && PageLoading) {\n+        return <PageLoading />\n+      }\n+      else if (Layout) {\n+        return <Layout ref={ this.saveContentRef } { ...page } />\n+      }\n+    }\n+\n+    return null","path":"src/PageContainer/component.js","position":43,"original_position":43,"commit_id":"755b9c3f6ad7efac7e37dd05ecd04fe28d054c01","original_commit_id":"755b9c3f6ad7efac7e37dd05ecd04fe28d054c01","user":{"login":"thangngoc89","id":3049054,"avatar_url":"https://avatars.githubusercontent.com/u/3049054?v=3","gravatar_id":"","url":"https://api.github.com/users/thangngoc89","html_url":"https://github.com/thangngoc89","followers_url":"https://api.github.com/users/thangngoc89/followers","following_url":"https://api.github.com/users/thangngoc89/following{/other_user}","gists_url":"https://api.github.com/users/thangngoc89/gists{/gist_id}","starred_url":"https://api.github.com/users/thangngoc89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thangngoc89/subscriptions","organizations_url":"https://api.github.com/users/thangngoc89/orgs","repos_url":"https://api.github.com/users/thangngoc89/repos","events_url":"https://api.github.com/users/thangngoc89/events{/privacy}","received_events_url":"https://api.github.com/users/thangngoc89/received_events","type":"User","site_admin":false},"body":"I learned new thing today. Thanks :100: ","created_at":"2016-09-01T05:27:07Z","updated_at":"2016-09-01T05:27:07Z","html_url":"https://github.com/MoOx/phenomic/pull/691#discussion_r77115802","pull_request_url":"https://api.github.com/repos/MoOx/phenomic/pulls/691","_links":{"self":{"href":"https://api.github.com/repos/MoOx/phenomic/pulls/comments/77115802"},"html":{"href":"https://github.com/MoOx/phenomic/pull/691#discussion_r77115802"},"pull_request":{"href":"https://api.github.com/repos/MoOx/phenomic/pulls/691"}}},"pull_request":{"url":"https://api.github.com/repos/MoOx/phenomic/pulls/691","id":83396437,"html_url":"https://github.com/MoOx/phenomic/pull/691","diff_url":"https://github.com/MoOx/phenomic/pull/691.diff","patch_url":"https://github.com/MoOx/phenomic/pull/691.patch","issue_url":"https://api.github.com/repos/MoOx/phenomic/issues/691","number":691,"state":"closed","locked":false,"title":"Removed: ``PageContainer`` does not wrap its child into a ``<div>``","user":{"login":"MoOx","id":157534,"avatar_url":"https://avatars.githubusercontent.com/u/157534?v=3","gravatar_id":"","url":"https://api.github.com/users/MoOx","html_url":"https://github.com/MoOx","followers_url":"https://api.github.com/users/MoOx/followers","following_url":"https://api.github.com/users/MoOx/following{/other_user}","gists_url":"https://api.github.com/users/MoOx/gists{/gist_id}","starred_url":"https://api.github.com/users/MoOx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoOx/subscriptions","organizations_url":"https://api.github.com/users/MoOx/orgs","repos_url":"https://api.github.com/users/MoOx/repos","events_url":"https://api.github.com/users/MoOx/events{/privacy}","received_events_url":"https://api.github.com/users/MoOx/received_events","type":"User","site_admin":false},"body":"Closes #690 \r\n\r\npoke @DavidWells ","created_at":"2016-08-31T06:39:53Z","updated_at":"2016-09-01T05:27:07Z","closed_at":"2016-09-01T05:23:12Z","merged_at":"2016-09-01T05:23:12Z","merge_commit_sha":"780e01093f0f2cac40622f135244995c37e07500","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MoOx/phenomic/pulls/691/commits","review_comments_url":"https://api.github.com/repos/MoOx/phenomic/pulls/691/comments","review_comment_url":"https://api.github.com/repos/MoOx/phenomic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MoOx/phenomic/issues/691/comments","statuses_url":"https://api.github.com/repos/MoOx/phenomic/statuses/755b9c3f6ad7efac7e37dd05ecd04fe28d054c01","head":{"label":"MoOx:feat.props-to-pagecontainer","ref":"feat.props-to-pagecontainer","sha":"755b9c3f6ad7efac7e37dd05ecd04fe28d054c01","user":{"login":"MoOx","id":157534,"avatar_url":"https://avatars.githubusercontent.com/u/157534?v=3","gravatar_id":"","url":"https://api.github.com/users/MoOx","html_url":"https://github.com/MoOx","followers_url":"https://api.github.com/users/MoOx/followers","following_url":"https://api.github.com/users/MoOx/following{/other_user}","gists_url":"https://api.github.com/users/MoOx/gists{/gist_id}","starred_url":"https://api.github.com/users/MoOx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoOx/subscriptions","organizations_url":"https://api.github.com/users/MoOx/orgs","repos_url":"https://api.github.com/users/MoOx/repos","events_url":"https://api.github.com/users/MoOx/events{/privacy}","received_events_url":"https://api.github.com/users/MoOx/received_events","type":"User","site_admin":false},"repo":{"id":41730120,"name":"phenomic","full_name":"MoOx/phenomic","owner":{"login":"MoOx","id":157534,"avatar_url":"https://avatars.githubusercontent.com/u/157534?v=3","gravatar_id":"","url":"https://api.github.com/users/MoOx","html_url":"https://github.com/MoOx","followers_url":"https://api.github.com/users/MoOx/followers","following_url":"https://api.github.com/users/MoOx/following{/other_user}","gists_url":"https://api.github.com/users/MoOx/gists{/gist_id}","starred_url":"https://api.github.com/users/MoOx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoOx/subscriptions","organizations_url":"https://api.github.com/users/MoOx/orgs","repos_url":"https://api.github.com/users/MoOx/repos","events_url":"https://api.github.com/users/MoOx/events{/privacy}","received_events_url":"https://api.github.com/users/MoOx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MoOx/phenomic","description":":scream: Modern static* website generator based on the React and Webpack ecosystem :sparkles:","fork":false,"url":"https://api.github.com/repos/MoOx/phenomic","forks_url":"https://api.github.com/repos/MoOx/phenomic/forks","keys_url":"https://api.github.com/repos/MoOx/phenomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoOx/phenomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoOx/phenomic/teams","hooks_url":"https://api.github.com/repos/MoOx/phenomic/hooks","issue_events_url":"https://api.github.com/repos/MoOx/phenomic/issues/events{/number}","events_url":"https://api.github.com/repos/MoOx/phenomic/events","assignees_url":"https://api.github.com/repos/MoOx/phenomic/assignees{/user}","branches_url":"https://api.github.com/repos/MoOx/phenomic/branches{/branch}","tags_url":"https://api.github.com/repos/MoOx/phenomic/tags","blobs_url":"https://api.github.com/repos/MoOx/phenomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoOx/phenomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoOx/phenomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoOx/phenomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoOx/phenomic/statuses/{sha}","languages_url":"https://api.github.com/repos/MoOx/phenomic/languages","stargazers_url":"https://api.github.com/repos/MoOx/phenomic/stargazers","contributors_url":"https://api.github.com/repos/MoOx/phenomic/contributors","subscribers_url":"https://api.github.com/repos/MoOx/phenomic/subscribers","subscription_url":"https://api.github.com/repos/MoOx/phenomic/subscription","commits_url":"https://api.github.com/repos/MoOx/phenomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoOx/phenomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoOx/phenomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoOx/phenomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoOx/phenomic/contents/{+path}","compare_url":"https://api.github.com/repos/MoOx/phenomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoOx/phenomic/merges","archive_url":"https://api.github.com/repos/MoOx/phenomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoOx/phenomic/downloads","issues_url":"https://api.github.com/repos/MoOx/phenomic/issues{/number}","pulls_url":"https://api.github.com/repos/MoOx/phenomic/pulls{/number}","milestones_url":"https://api.github.com/repos/MoOx/phenomic/milestones{/number}","notifications_url":"https://api.github.com/repos/MoOx/phenomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoOx/phenomic/labels{/name}","releases_url":"https://api.github.com/repos/MoOx/phenomic/releases{/id}","deployments_url":"https://api.github.com/repos/MoOx/phenomic/deployments","created_at":"2015-09-01T09:40:57Z","updated_at":"2016-09-01T00:20:48Z","pushed_at":"2016-09-01T05:23:15Z","git_url":"git://github.com/MoOx/phenomic.git","ssh_url":"git@github.com:MoOx/phenomic.git","clone_url":"https://github.com/MoOx/phenomic.git","svn_url":"https://github.com/MoOx/phenomic","homepage":"https://phenomic.io/","size":8088,"stargazers_count":928,"watchers_count":928,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":112,"forks":47,"open_issues":112,"watchers":928,"default_branch":"master"}},"base":{"label":"MoOx:master","ref":"master","sha":"4862a1b8dcecd9f1a54fa8abba153499928829a7","user":{"login":"MoOx","id":157534,"avatar_url":"https://avatars.githubusercontent.com/u/157534?v=3","gravatar_id":"","url":"https://api.github.com/users/MoOx","html_url":"https://github.com/MoOx","followers_url":"https://api.github.com/users/MoOx/followers","following_url":"https://api.github.com/users/MoOx/following{/other_user}","gists_url":"https://api.github.com/users/MoOx/gists{/gist_id}","starred_url":"https://api.github.com/users/MoOx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoOx/subscriptions","organizations_url":"https://api.github.com/users/MoOx/orgs","repos_url":"https://api.github.com/users/MoOx/repos","events_url":"https://api.github.com/users/MoOx/events{/privacy}","received_events_url":"https://api.github.com/users/MoOx/received_events","type":"User","site_admin":false},"repo":{"id":41730120,"name":"phenomic","full_name":"MoOx/phenomic","owner":{"login":"MoOx","id":157534,"avatar_url":"https://avatars.githubusercontent.com/u/157534?v=3","gravatar_id":"","url":"https://api.github.com/users/MoOx","html_url":"https://github.com/MoOx","followers_url":"https://api.github.com/users/MoOx/followers","following_url":"https://api.github.com/users/MoOx/following{/other_user}","gists_url":"https://api.github.com/users/MoOx/gists{/gist_id}","starred_url":"https://api.github.com/users/MoOx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoOx/subscriptions","organizations_url":"https://api.github.com/users/MoOx/orgs","repos_url":"https://api.github.com/users/MoOx/repos","events_url":"https://api.github.com/users/MoOx/events{/privacy}","received_events_url":"https://api.github.com/users/MoOx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MoOx/phenomic","description":":scream: Modern static* website generator based on the React and Webpack ecosystem :sparkles:","fork":false,"url":"https://api.github.com/repos/MoOx/phenomic","forks_url":"https://api.github.com/repos/MoOx/phenomic/forks","keys_url":"https://api.github.com/repos/MoOx/phenomic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoOx/phenomic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoOx/phenomic/teams","hooks_url":"https://api.github.com/repos/MoOx/phenomic/hooks","issue_events_url":"https://api.github.com/repos/MoOx/phenomic/issues/events{/number}","events_url":"https://api.github.com/repos/MoOx/phenomic/events","assignees_url":"https://api.github.com/repos/MoOx/phenomic/assignees{/user}","branches_url":"https://api.github.com/repos/MoOx/phenomic/branches{/branch}","tags_url":"https://api.github.com/repos/MoOx/phenomic/tags","blobs_url":"https://api.github.com/repos/MoOx/phenomic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoOx/phenomic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoOx/phenomic/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoOx/phenomic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoOx/phenomic/statuses/{sha}","languages_url":"https://api.github.com/repos/MoOx/phenomic/languages","stargazers_url":"https://api.github.com/repos/MoOx/phenomic/stargazers","contributors_url":"https://api.github.com/repos/MoOx/phenomic/contributors","subscribers_url":"https://api.github.com/repos/MoOx/phenomic/subscribers","subscription_url":"https://api.github.com/repos/MoOx/phenomic/subscription","commits_url":"https://api.github.com/repos/MoOx/phenomic/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoOx/phenomic/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoOx/phenomic/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoOx/phenomic/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoOx/phenomic/contents/{+path}","compare_url":"https://api.github.com/repos/MoOx/phenomic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoOx/phenomic/merges","archive_url":"https://api.github.com/repos/MoOx/phenomic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoOx/phenomic/downloads","issues_url":"https://api.github.com/repos/MoOx/phenomic/issues{/number}","pulls_url":"https://api.github.com/repos/MoOx/phenomic/pulls{/number}","milestones_url":"https://api.github.com/repos/MoOx/phenomic/milestones{/number}","notifications_url":"https://api.github.com/repos/MoOx/phenomic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoOx/phenomic/labels{/name}","releases_url":"https://api.github.com/repos/MoOx/phenomic/releases{/id}","deployments_url":"https://api.github.com/repos/MoOx/phenomic/deployments","created_at":"2015-09-01T09:40:57Z","updated_at":"2016-09-01T00:20:48Z","pushed_at":"2016-09-01T05:23:15Z","git_url":"git://github.com/MoOx/phenomic.git","ssh_url":"git@github.com:MoOx/phenomic.git","clone_url":"https://github.com/MoOx/phenomic.git","svn_url":"https://github.com/MoOx/phenomic","homepage":"https://phenomic.io/","size":8088,"stargazers_count":928,"watchers_count":928,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":112,"forks":47,"open_issues":112,"watchers":928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MoOx/phenomic/pulls/691"},"html":{"href":"https://github.com/MoOx/phenomic/pull/691"},"issue":{"href":"https://api.github.com/repos/MoOx/phenomic/issues/691"},"comments":{"href":"https://api.github.com/repos/MoOx/phenomic/issues/691/comments"},"review_comments":{"href":"https://api.github.com/repos/MoOx/phenomic/pulls/691/comments"},"review_comment":{"href":"https://api.github.com/repos/MoOx/phenomic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MoOx/phenomic/pulls/691/commits"},"statuses":{"href":"https://api.github.com/repos/MoOx/phenomic/statuses/755b9c3f6ad7efac7e37dd05ecd04fe28d054c01"}}}}
{"actor":{"display_login":"thangngoc89"}}