{"action":"opened","number":841,"pull_request":{"url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/841","id":68398453,"html_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/841","diff_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/841.diff","patch_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/841.patch","issue_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/841","number":841,"state":"open","locked":false,"title":"Update ApiDocExtractor.php","user":{"login":"flip111","id":2244480,"avatar_url":"https://avatars.githubusercontent.com/u/2244480?v=3","gravatar_id":"","url":"https://api.github.com/users/flip111","html_url":"https://github.com/flip111","followers_url":"https://api.github.com/users/flip111/followers","following_url":"https://api.github.com/users/flip111/following{/other_user}","gists_url":"https://api.github.com/users/flip111/gists{/gist_id}","starred_url":"https://api.github.com/users/flip111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flip111/subscriptions","organizations_url":"https://api.github.com/users/flip111/orgs","repos_url":"https://api.github.com/users/flip111/repos","events_url":"https://api.github.com/users/flip111/events{/privacy}","received_events_url":"https://api.github.com/users/flip111/received_events","type":"User","site_admin":false},"body":"[the original code](https://github.com/nelmio/NelmioApiDocBundle/commit/cca97cf6af060a5bd3d61e6c83554425e097ee13#diff-d29530867a19f2c302d4fadcfcd23e48R224) doesn't seem to do anything with `$parameters` because `$parameters` is not declared in the function scope, so basically you are creating a new `$parameters` in function scope and not do anything with it. `array_walk` is suppose to modify the `$val` by reference. So basically this has been broken for more than a year until [this commit](https://github.com/nelmio/NelmioApiDocBundle/commit/f625d9671c9a7a4cd886949755a33e74f656a497). Now the new code is still really confusing ans possibly slower than a normal foreach. I guess `array_walk` has been left in because of the original code.\r\n\r\nThis would yet be another implementation of the same\r\n```php\r\n                $parameters = array_map(function($item) {\r\n                    return $item['required'] = false;\r\n                }, $parameters);\r\n```","created_at":"2016-04-29T16:30:40Z","updated_at":"2016-04-29T16:30:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/841/commits","review_comments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/841/comments","review_comment_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/841/comments","statuses_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/statuses/8921c48b320f4485cbb3eed45e20c1a8d7d9f3f3","head":{"label":"flip111:patch-1","ref":"patch-1","sha":"8921c48b320f4485cbb3eed45e20c1a8d7d9f3f3","user":{"login":"flip111","id":2244480,"avatar_url":"https://avatars.githubusercontent.com/u/2244480?v=3","gravatar_id":"","url":"https://api.github.com/users/flip111","html_url":"https://github.com/flip111","followers_url":"https://api.github.com/users/flip111/followers","following_url":"https://api.github.com/users/flip111/following{/other_user}","gists_url":"https://api.github.com/users/flip111/gists{/gist_id}","starred_url":"https://api.github.com/users/flip111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flip111/subscriptions","organizations_url":"https://api.github.com/users/flip111/orgs","repos_url":"https://api.github.com/users/flip111/repos","events_url":"https://api.github.com/users/flip111/events{/privacy}","received_events_url":"https://api.github.com/users/flip111/received_events","type":"User","site_admin":false},"repo":{"id":57397923,"name":"NelmioApiDocBundle","full_name":"flip111/NelmioApiDocBundle","owner":{"login":"flip111","id":2244480,"avatar_url":"https://avatars.githubusercontent.com/u/2244480?v=3","gravatar_id":"","url":"https://api.github.com/users/flip111","html_url":"https://github.com/flip111","followers_url":"https://api.github.com/users/flip111/followers","following_url":"https://api.github.com/users/flip111/following{/other_user}","gists_url":"https://api.github.com/users/flip111/gists{/gist_id}","starred_url":"https://api.github.com/users/flip111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flip111/subscriptions","organizations_url":"https://api.github.com/users/flip111/orgs","repos_url":"https://api.github.com/users/flip111/repos","events_url":"https://api.github.com/users/flip111/events{/privacy}","received_events_url":"https://api.github.com/users/flip111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flip111/NelmioApiDocBundle","description":"Generates documentation for your REST API from annotations","fork":true,"url":"https://api.github.com/repos/flip111/NelmioApiDocBundle","forks_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/forks","keys_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/teams","hooks_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/hooks","issue_events_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/issues/events{/number}","events_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/events","assignees_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/assignees{/user}","branches_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/branches{/branch}","tags_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/tags","blobs_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/languages","stargazers_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/stargazers","contributors_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/contributors","subscribers_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/subscribers","subscription_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/subscription","commits_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/contents/{+path}","compare_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/merges","archive_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/downloads","issues_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/issues{/number}","pulls_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/labels{/name}","releases_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/releases{/id}","deployments_url":"https://api.github.com/repos/flip111/NelmioApiDocBundle/deployments","created_at":"2016-04-29T16:20:43Z","updated_at":"2016-04-29T16:20:44Z","pushed_at":"2016-04-29T16:29:39Z","git_url":"git://github.com/flip111/NelmioApiDocBundle.git","ssh_url":"git@github.com:flip111/NelmioApiDocBundle.git","clone_url":"https://github.com/flip111/NelmioApiDocBundle.git","svn_url":"https://github.com/flip111/NelmioApiDocBundle","homepage":"","size":1922,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nelmio:master","ref":"master","sha":"2d214fc93464e59ea817ef2ea5a8388eef84be3c","user":{"login":"nelmio","id":460596,"avatar_url":"https://avatars.githubusercontent.com/u/460596?v=3","gravatar_id":"","url":"https://api.github.com/users/nelmio","html_url":"https://github.com/nelmio","followers_url":"https://api.github.com/users/nelmio/followers","following_url":"https://api.github.com/users/nelmio/following{/other_user}","gists_url":"https://api.github.com/users/nelmio/gists{/gist_id}","starred_url":"https://api.github.com/users/nelmio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelmio/subscriptions","organizations_url":"https://api.github.com/users/nelmio/orgs","repos_url":"https://api.github.com/users/nelmio/repos","events_url":"https://api.github.com/users/nelmio/events{/privacy}","received_events_url":"https://api.github.com/users/nelmio/received_events","type":"Organization","site_admin":false},"repo":{"id":4006755,"name":"NelmioApiDocBundle","full_name":"nelmio/NelmioApiDocBundle","owner":{"login":"nelmio","id":460596,"avatar_url":"https://avatars.githubusercontent.com/u/460596?v=3","gravatar_id":"","url":"https://api.github.com/users/nelmio","html_url":"https://github.com/nelmio","followers_url":"https://api.github.com/users/nelmio/followers","following_url":"https://api.github.com/users/nelmio/following{/other_user}","gists_url":"https://api.github.com/users/nelmio/gists{/gist_id}","starred_url":"https://api.github.com/users/nelmio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelmio/subscriptions","organizations_url":"https://api.github.com/users/nelmio/orgs","repos_url":"https://api.github.com/users/nelmio/repos","events_url":"https://api.github.com/users/nelmio/events{/privacy}","received_events_url":"https://api.github.com/users/nelmio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nelmio/NelmioApiDocBundle","description":"Generates documentation for your REST API from annotations","fork":false,"url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle","forks_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/forks","keys_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/teams","hooks_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/hooks","issue_events_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/events{/number}","events_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/events","assignees_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/assignees{/user}","branches_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/branches{/branch}","tags_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/tags","blobs_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/languages","stargazers_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/stargazers","contributors_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/contributors","subscribers_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/subscribers","subscription_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/subscription","commits_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/contents/{+path}","compare_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/merges","archive_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/downloads","issues_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues{/number}","pulls_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/labels{/name}","releases_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/releases{/id}","deployments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/deployments","created_at":"2012-04-12T16:28:15Z","updated_at":"2016-04-29T13:09:32Z","pushed_at":"2016-04-26T12:59:08Z","git_url":"git://github.com/nelmio/NelmioApiDocBundle.git","ssh_url":"git@github.com:nelmio/NelmioApiDocBundle.git","clone_url":"https://github.com/nelmio/NelmioApiDocBundle.git","svn_url":"https://github.com/nelmio/NelmioApiDocBundle","homepage":"","size":3259,"stargazers_count":1042,"watchers_count":1042,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":452,"mirror_url":null,"open_issues_count":147,"forks":452,"open_issues":147,"watchers":1042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/841"},"html":{"href":"https://github.com/nelmio/NelmioApiDocBundle/pull/841"},"issue":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/841"},"comments":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/841/comments"},"review_comments":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/841/comments"},"review_comment":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/841/commits"},"statuses":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/statuses/8921c48b320f4485cbb3eed45e20c1a8d7d9f3f3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}