{"action":"created","issue":{"url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/92","repository_url":"https://api.github.com/repos/MovingBlocks/DestinationSol","labels_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/92/comments","events_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/92/events","html_url":"https://github.com/MovingBlocks/DestinationSol/pull/92","id":147560039,"number":92,"title":"[Work In Progress] Gestalt integration","user":{"login":"rzats","id":13783592,"avatar_url":"https://avatars.githubusercontent.com/u/13783592?v=3","gravatar_id":"","url":"https://api.github.com/users/rzats","html_url":"https://github.com/rzats","followers_url":"https://api.github.com/users/rzats/followers","following_url":"https://api.github.com/users/rzats/following{/other_user}","gists_url":"https://api.github.com/users/rzats/gists{/gist_id}","starred_url":"https://api.github.com/users/rzats/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzats/subscriptions","organizations_url":"https://api.github.com/users/rzats/orgs","repos_url":"https://api.github.com/users/rzats/repos","events_url":"https://api.github.com/users/rzats/events{/privacy}","received_events_url":"https://api.github.com/users/rzats/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MovingBlocks/DestinationSol/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/MovingBlocks/DestinationSol/milestones/4","html_url":"https://github.com/MovingBlocks/DestinationSol/milestones/v2.0.0%20-%20Initial%20Gestalt%20integration","labels_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/milestones/4/labels","id":1702830,"number":4,"title":"v2.0.0 - Initial Gestalt integration","description":"Adopting the first major piece from our work with Terasology.","creator":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-04-13T02:59:53Z","updated_at":"2016-04-13T03:00:02Z","due_on":null,"closed_at":null},"comments":34,"created_at":"2016-04-11T21:26:05Z","updated_at":"2016-08-10T17:22:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/92","html_url":"https://github.com/MovingBlocks/DestinationSol/pull/92","diff_url":"https://github.com/MovingBlocks/DestinationSol/pull/92.diff","patch_url":"https://github.com/MovingBlocks/DestinationSol/pull/92.patch"},"body":"**Important:** This PR contains significant amounts of whitespace-only changes caused by IntelliJ autoformatting. Append `?w=1` to the end of the diff view URL to display non-whitespace changes only.\r\n\r\n### Contains\r\n\r\nA work-in progress, proof-of-concept integration of Destination Sol with [gestalt-asset-core](https://github.com/MovingBlocks/gestalt/tree/develop/gestalt-asset-core), as initially suggested by [this forum post](http://forum.terasology.org/threads/hello-world.1446/#post-12892).\r\n\r\n##### Features and TODO list\r\n\r\n- [X] A ClasspathModule providing access to core functionality and resources, with required metadata being stored in a module.info file and parsed using a specialized `ModuleManager` class.\r\n\r\n- [X] A generalized `AssetHelper` class registering asset types within a `ModuleEnvironment` containing the core ClasspathModule (and, potentially, external ArchiveModules), as well as providing generalized wrappers to simple asset operations (get asset of type, get all assets of type).\r\n\r\n- [X] `OggSound` asset type (including implementations for `AssetData`, `Asset`, `AbstractAssetFileFormat`, `AbstractAssetAlterationFileFormat`). Acts as a data wrapper for:\r\n  - a `gdx.audio.Sound` object - obtained from a `FileHandle` generated by reconstructing the path of the input asset file in `OggSoundFileFormat`;\r\n  - configuration parameters fetched from a metadata file (`loopTime` / `baseVolume`);\r\n  - a parameter programmatically defined configuration parameter (`basePitch`).\r\n\r\n- [x] Asset-based sound manager class - a refactored version of [`SoundManager`](https://github.com/MovingBlocks/DestinationSol/blob/develop/main/src/org/destinationsol/game/sound/SoundManager.java) that utilises the OggSound class to implement cleaner sound fetching and improved playback code.\r\n\r\n- [x] A refactor for the game to support said manager class\r\n\r\n- [ ] Texture asset type and file format. Should read the game's textures and metadata atlas files (with sol.atlas being split into different files corresponding to each texture file).\r\n\r\n- [ ] Asset-based texture manager class - a refactored version of [`AtlasTextureProvider`](https://github.com/MovingBlocks/DestinationSol/blob/develop/main/src/org/destinationsol/AtlasTextureProvider.java).\r\n\r\n- [ ] Other asset types - complete list up for discussion.\r\n\r\n- [ ] Test the integration's compatibility with Android and GWT facades.\r\n\r\n### How to test\r\n\r\nLaunch the game from source! An asset fetching test in SolApplication should output a list of available `OggSound` and `OggMusic` Urns - verify this.\r\n\r\nThe sound system is now fully integrated into the game, with all the sounds being fetched from an `OggSoundManager`, so simply start a new game and play around with things - the sounds currently being played will be logged to the console."},"comment":{"url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/comments/238939006","html_url":"https://github.com/MovingBlocks/DestinationSol/pull/92#issuecomment-238939006","issue_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/92","id":238939006,"user":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T17:22:58Z","updated_at":"2016-08-10T17:22:58Z","body":"> Hmm. The 'X' option was only added with Java 7, maybe it isn't in Android java?\r\n\r\nYep it is something like that. The version of `SimpleDateFormat` Android uses is Java 6 style. It is a weird mix of different version levels in places like that.\r\n\r\nThe Swagger link goes to example handling that figures out the running environment then considers different date formats based on that. \r\n\r\nI'm not sure where we should attempt a fix / config tweak. Will get back for another round later but would appreciate any ideas :-)"}}
{"actor":{"display_login":"Cervator"}}