{"action":"created","issue":{"url":"https://api.github.com/repos/fastbuild/fastbuild/issues/96","repository_url":"https://api.github.com/repos/fastbuild/fastbuild","labels_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/96/comments","events_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/96/events","html_url":"https://github.com/fastbuild/fastbuild/pull/96","id":153171241,"number":96,"title":"Uniquify database using root bff filename","user":{"login":"jelmansouri","id":1864495,"avatar_url":"https://avatars.githubusercontent.com/u/1864495?v=3","gravatar_id":"","url":"https://api.github.com/users/jelmansouri","html_url":"https://github.com/jelmansouri","followers_url":"https://api.github.com/users/jelmansouri/followers","following_url":"https://api.github.com/users/jelmansouri/following{/other_user}","gists_url":"https://api.github.com/users/jelmansouri/gists{/gist_id}","starred_url":"https://api.github.com/users/jelmansouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelmansouri/subscriptions","organizations_url":"https://api.github.com/users/jelmansouri/orgs","repos_url":"https://api.github.com/users/jelmansouri/repos","events_url":"https://api.github.com/users/jelmansouri/events{/privacy}","received_events_url":"https://api.github.com/users/jelmansouri/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fastbuild/fastbuild/labels/Blocked","name":"Blocked","color":"fbca04"},{"url":"https://api.github.com/repos/fastbuild/fastbuild/labels/Enhancement","name":"Enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-05T05:40:26Z","updated_at":"2016-06-18T16:49:55Z","closed_at":"2016-06-11T20:42:27Z","pull_request":{"url":"https://api.github.com/repos/fastbuild/fastbuild/pulls/96","html_url":"https://github.com/fastbuild/fastbuild/pull/96","diff_url":"https://github.com/fastbuild/fastbuild/pull/96.diff","patch_url":"https://github.com/fastbuild/fastbuild/pull/96.patch"},"body":"Instead of invalidating the cache when building using different bff file I enforce one fdb by bff by adding .fdb to the bff file.\r\nSince flushing the fdb file would not be necessary, It would be more efficient this way and it covers our prod use cases.\r\n\r\nTested on Rainbow6 with the following scenario:\r\n * folder containing fbuild.vs2012.bff & fbuild.vs2015.bff\r\n * switching between the two files and making sure that the fdb file gets properly created and updated\r\n * checking that file time-stamp comparison on the list of files on the fdb is still working\r\n\r\nUnfortunately I could not run the FBuiltTests since I hacked very minimally the FBuild root bff to get a non dist build work with VS2012."},"comment":{"url":"https://api.github.com/repos/fastbuild/fastbuild/issues/comments/226952512","html_url":"https://github.com/fastbuild/fastbuild/pull/96#issuecomment-226952512","issue_url":"https://api.github.com/repos/fastbuild/fastbuild/issues/96","id":226952512,"user":{"login":"ffulin","id":11589403,"avatar_url":"https://avatars.githubusercontent.com/u/11589403?v=3","gravatar_id":"","url":"https://api.github.com/users/ffulin","html_url":"https://github.com/ffulin","followers_url":"https://api.github.com/users/ffulin/followers","following_url":"https://api.github.com/users/ffulin/following{/other_user}","gists_url":"https://api.github.com/users/ffulin/gists{/gist_id}","starred_url":"https://api.github.com/users/ffulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ffulin/subscriptions","organizations_url":"https://api.github.com/users/ffulin/orgs","repos_url":"https://api.github.com/users/ffulin/repos","events_url":"https://api.github.com/users/ffulin/events{/privacy}","received_events_url":"https://api.github.com/users/ffulin/received_events","type":"User","site_admin":false},"created_at":"2016-06-18T16:49:55Z","updated_at":"2016-06-18T16:49:55Z","body":"I've re-integrated this change and resolved the issue with the tests (https://github.com/fastbuild/fastbuild/commit/43f3e5dc201055d1a3ad7a6e5225ed1e93ad66ad)\r\n\r\nThe issue was caused by the test relying on the existing naming behaviour of the fdb, which changed.  I've robustified the test and also modified the pull request to retain the existing behaviour so that fdb file names will not change for existing users. (i.e. fbuild.bff -> fbuild.fdb instead of fbuild.bff.fdb)\r\n\r\nThanks for the fix!"}}
{"actor":{"display_login":"ffulin"}}