{"action":"created","comment":{"url":"https://api.github.com/repos/simgrid/simgrid/pulls/comments/90926390","pull_request_review_id":11439814,"id":90926390,"diff_hunk":"@@ -907,16 +910,92 @@ int PMPI_Ssend_init(void* buf, int count, MPI_Datatype datatype, int dst, int ta\n   return retval;\n }\n \n-int PMPI_Start(MPI_Request * request)\n+int persistent_send(MPI_Request *request)\n {\n   int retval = 0;\n+  MPI_Request req = *request;\n \n-  smpi_bench_end();\n+  //smpi_bench_end();\n   if (request == nullptr || *request == MPI_REQUEST_NULL) {\n     retval = MPI_ERR_REQUEST;\n   } else {\n+\n+    int rank = req->comm != MPI_COMM_NULL ? smpi_process_index() : -1;","path":"src/smpi/smpi_pmpi.cpp","position":29,"original_position":29,"commit_id":"66c90eeb72aeb9733b53ac1c0bcb2eb01087f040","original_commit_id":"66c90eeb72aeb9733b53ac1c0bcb2eb01087f040","user":{"login":"rktesser","id":6716029,"avatar_url":"https://avatars.githubusercontent.com/u/6716029?v=3","gravatar_id":"","url":"https://api.github.com/users/rktesser","html_url":"https://github.com/rktesser","followers_url":"https://api.github.com/users/rktesser/followers","following_url":"https://api.github.com/users/rktesser/following{/other_user}","gists_url":"https://api.github.com/users/rktesser/gists{/gist_id}","starred_url":"https://api.github.com/users/rktesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rktesser/subscriptions","organizations_url":"https://api.github.com/users/rktesser/orgs","repos_url":"https://api.github.com/users/rktesser/repos","events_url":"https://api.github.com/users/rktesser/events{/privacy}","received_events_url":"https://api.github.com/users/rktesser/received_events","type":"User","site_admin":false},"body":"This is function is based on PMPI_Isend (actually, most of the code was copied from it). This test is present in that function too.","created_at":"2016-12-05T18:32:34Z","updated_at":"2016-12-05T18:32:34Z","html_url":"https://github.com/simgrid/simgrid/pull/125#discussion_r90926390","pull_request_url":"https://api.github.com/repos/simgrid/simgrid/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/comments/90926390"},"html":{"href":"https://github.com/simgrid/simgrid/pull/125#discussion_r90926390"},"pull_request":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/simgrid/simgrid/pulls/125","id":96443768,"html_url":"https://github.com/simgrid/simgrid/pull/125","diff_url":"https://github.com/simgrid/simgrid/pull/125.diff","patch_url":"https://github.com/simgrid/simgrid/pull/125.patch","issue_url":"https://api.github.com/repos/simgrid/simgrid/issues/125","number":125,"state":"open","locked":false,"title":"Simgrid for MPI load balancing simulation","user":{"login":"rktesser","id":6716029,"avatar_url":"https://avatars.githubusercontent.com/u/6716029?v=3","gravatar_id":"","url":"https://api.github.com/users/rktesser","html_url":"https://github.com/rktesser","followers_url":"https://api.github.com/users/rktesser/followers","following_url":"https://api.github.com/users/rktesser/following{/other_user}","gists_url":"https://api.github.com/users/rktesser/gists{/gist_id}","starred_url":"https://api.github.com/users/rktesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rktesser/subscriptions","organizations_url":"https://api.github.com/users/rktesser/orgs","repos_url":"https://api.github.com/users/rktesser/repos","events_url":"https://api.github.com/users/rktesser/events{/privacy}","received_events_url":"https://api.github.com/users/rktesser/received_events","type":"User","site_admin":false},"body":"As requested by Martin Quinson, I created this pull request to work on integrating into SimGrid the changes I did to to support my MPI load balancing simulation.","created_at":"2016-12-04T19:47:15Z","updated_at":"2016-12-05T18:32:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a616a4948e8b2019273049fc026a0de58851d013","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/simgrid/simgrid/pulls/125/commits","review_comments_url":"https://api.github.com/repos/simgrid/simgrid/pulls/125/comments","review_comment_url":"https://api.github.com/repos/simgrid/simgrid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simgrid/simgrid/issues/125/comments","statuses_url":"https://api.github.com/repos/simgrid/simgrid/statuses/66c90eeb72aeb9733b53ac1c0bcb2eb01087f040","head":{"label":"rktesser:simgrid-merge","ref":"simgrid-merge","sha":"66c90eeb72aeb9733b53ac1c0bcb2eb01087f040","user":{"login":"rktesser","id":6716029,"avatar_url":"https://avatars.githubusercontent.com/u/6716029?v=3","gravatar_id":"","url":"https://api.github.com/users/rktesser","html_url":"https://github.com/rktesser","followers_url":"https://api.github.com/users/rktesser/followers","following_url":"https://api.github.com/users/rktesser/following{/other_user}","gists_url":"https://api.github.com/users/rktesser/gists{/gist_id}","starred_url":"https://api.github.com/users/rktesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rktesser/subscriptions","organizations_url":"https://api.github.com/users/rktesser/orgs","repos_url":"https://api.github.com/users/rktesser/repos","events_url":"https://api.github.com/users/rktesser/events{/privacy}","received_events_url":"https://api.github.com/users/rktesser/received_events","type":"User","site_admin":false},"repo":{"id":75557621,"name":"simgrid","full_name":"rktesser/simgrid","owner":{"login":"rktesser","id":6716029,"avatar_url":"https://avatars.githubusercontent.com/u/6716029?v=3","gravatar_id":"","url":"https://api.github.com/users/rktesser","html_url":"https://github.com/rktesser","followers_url":"https://api.github.com/users/rktesser/followers","following_url":"https://api.github.com/users/rktesser/following{/other_user}","gists_url":"https://api.github.com/users/rktesser/gists{/gist_id}","starred_url":"https://api.github.com/users/rktesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rktesser/subscriptions","organizations_url":"https://api.github.com/users/rktesser/orgs","repos_url":"https://api.github.com/users/rktesser/repos","events_url":"https://api.github.com/users/rktesser/events{/privacy}","received_events_url":"https://api.github.com/users/rktesser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rktesser/simgrid","description":"Framework for the simulation of distributed applications (P2P, Clouds, Grids and others)","fork":true,"url":"https://api.github.com/repos/rktesser/simgrid","forks_url":"https://api.github.com/repos/rktesser/simgrid/forks","keys_url":"https://api.github.com/repos/rktesser/simgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rktesser/simgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rktesser/simgrid/teams","hooks_url":"https://api.github.com/repos/rktesser/simgrid/hooks","issue_events_url":"https://api.github.com/repos/rktesser/simgrid/issues/events{/number}","events_url":"https://api.github.com/repos/rktesser/simgrid/events","assignees_url":"https://api.github.com/repos/rktesser/simgrid/assignees{/user}","branches_url":"https://api.github.com/repos/rktesser/simgrid/branches{/branch}","tags_url":"https://api.github.com/repos/rktesser/simgrid/tags","blobs_url":"https://api.github.com/repos/rktesser/simgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rktesser/simgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rktesser/simgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/rktesser/simgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rktesser/simgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/rktesser/simgrid/languages","stargazers_url":"https://api.github.com/repos/rktesser/simgrid/stargazers","contributors_url":"https://api.github.com/repos/rktesser/simgrid/contributors","subscribers_url":"https://api.github.com/repos/rktesser/simgrid/subscribers","subscription_url":"https://api.github.com/repos/rktesser/simgrid/subscription","commits_url":"https://api.github.com/repos/rktesser/simgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/rktesser/simgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/rktesser/simgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/rktesser/simgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/rktesser/simgrid/contents/{+path}","compare_url":"https://api.github.com/repos/rktesser/simgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rktesser/simgrid/merges","archive_url":"https://api.github.com/repos/rktesser/simgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rktesser/simgrid/downloads","issues_url":"https://api.github.com/repos/rktesser/simgrid/issues{/number}","pulls_url":"https://api.github.com/repos/rktesser/simgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/rktesser/simgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/rktesser/simgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rktesser/simgrid/labels{/name}","releases_url":"https://api.github.com/repos/rktesser/simgrid/releases{/id}","deployments_url":"https://api.github.com/repos/rktesser/simgrid/deployments","created_at":"2016-12-04T19:02:00Z","updated_at":"2016-12-04T19:02:06Z","pushed_at":"2016-12-04T19:40:56Z","git_url":"git://github.com/rktesser/simgrid.git","ssh_url":"git@github.com:rktesser/simgrid.git","clone_url":"https://github.com/rktesser/simgrid.git","svn_url":"https://github.com/rktesser/simgrid","homepage":"http://simgrid.org/","size":73582,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simgrid:master","ref":"master","sha":"c39c0618dd7435062d2d7dc9866db9fecc4a5038","user":{"login":"simgrid","id":19318675,"avatar_url":"https://avatars.githubusercontent.com/u/19318675?v=3","gravatar_id":"","url":"https://api.github.com/users/simgrid","html_url":"https://github.com/simgrid","followers_url":"https://api.github.com/users/simgrid/followers","following_url":"https://api.github.com/users/simgrid/following{/other_user}","gists_url":"https://api.github.com/users/simgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/simgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simgrid/subscriptions","organizations_url":"https://api.github.com/users/simgrid/orgs","repos_url":"https://api.github.com/users/simgrid/repos","events_url":"https://api.github.com/users/simgrid/events{/privacy}","received_events_url":"https://api.github.com/users/simgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":3389701,"name":"simgrid","full_name":"simgrid/simgrid","owner":{"login":"simgrid","id":19318675,"avatar_url":"https://avatars.githubusercontent.com/u/19318675?v=3","gravatar_id":"","url":"https://api.github.com/users/simgrid","html_url":"https://github.com/simgrid","followers_url":"https://api.github.com/users/simgrid/followers","following_url":"https://api.github.com/users/simgrid/following{/other_user}","gists_url":"https://api.github.com/users/simgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/simgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simgrid/subscriptions","organizations_url":"https://api.github.com/users/simgrid/orgs","repos_url":"https://api.github.com/users/simgrid/repos","events_url":"https://api.github.com/users/simgrid/events{/privacy}","received_events_url":"https://api.github.com/users/simgrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simgrid/simgrid","description":"Framework for the simulation of distributed applications (P2P, Clouds, Grids and others)","fork":false,"url":"https://api.github.com/repos/simgrid/simgrid","forks_url":"https://api.github.com/repos/simgrid/simgrid/forks","keys_url":"https://api.github.com/repos/simgrid/simgrid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simgrid/simgrid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simgrid/simgrid/teams","hooks_url":"https://api.github.com/repos/simgrid/simgrid/hooks","issue_events_url":"https://api.github.com/repos/simgrid/simgrid/issues/events{/number}","events_url":"https://api.github.com/repos/simgrid/simgrid/events","assignees_url":"https://api.github.com/repos/simgrid/simgrid/assignees{/user}","branches_url":"https://api.github.com/repos/simgrid/simgrid/branches{/branch}","tags_url":"https://api.github.com/repos/simgrid/simgrid/tags","blobs_url":"https://api.github.com/repos/simgrid/simgrid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simgrid/simgrid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simgrid/simgrid/git/refs{/sha}","trees_url":"https://api.github.com/repos/simgrid/simgrid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simgrid/simgrid/statuses/{sha}","languages_url":"https://api.github.com/repos/simgrid/simgrid/languages","stargazers_url":"https://api.github.com/repos/simgrid/simgrid/stargazers","contributors_url":"https://api.github.com/repos/simgrid/simgrid/contributors","subscribers_url":"https://api.github.com/repos/simgrid/simgrid/subscribers","subscription_url":"https://api.github.com/repos/simgrid/simgrid/subscription","commits_url":"https://api.github.com/repos/simgrid/simgrid/commits{/sha}","git_commits_url":"https://api.github.com/repos/simgrid/simgrid/git/commits{/sha}","comments_url":"https://api.github.com/repos/simgrid/simgrid/comments{/number}","issue_comment_url":"https://api.github.com/repos/simgrid/simgrid/issues/comments{/number}","contents_url":"https://api.github.com/repos/simgrid/simgrid/contents/{+path}","compare_url":"https://api.github.com/repos/simgrid/simgrid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simgrid/simgrid/merges","archive_url":"https://api.github.com/repos/simgrid/simgrid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simgrid/simgrid/downloads","issues_url":"https://api.github.com/repos/simgrid/simgrid/issues{/number}","pulls_url":"https://api.github.com/repos/simgrid/simgrid/pulls{/number}","milestones_url":"https://api.github.com/repos/simgrid/simgrid/milestones{/number}","notifications_url":"https://api.github.com/repos/simgrid/simgrid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simgrid/simgrid/labels{/name}","releases_url":"https://api.github.com/repos/simgrid/simgrid/releases{/id}","deployments_url":"https://api.github.com/repos/simgrid/simgrid/deployments","created_at":"2012-02-08T17:59:38Z","updated_at":"2016-10-22T20:52:15Z","pushed_at":"2016-12-05T15:10:16Z","git_url":"git://github.com/simgrid/simgrid.git","ssh_url":"git@github.com:simgrid/simgrid.git","clone_url":"https://github.com/simgrid/simgrid.git","svn_url":"https://github.com/simgrid/simgrid","homepage":"http://simgrid.org/","size":80517,"stargazers_count":31,"watchers_count":31,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":26,"forks":32,"open_issues":26,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/125"},"html":{"href":"https://github.com/simgrid/simgrid/pull/125"},"issue":{"href":"https://api.github.com/repos/simgrid/simgrid/issues/125"},"comments":{"href":"https://api.github.com/repos/simgrid/simgrid/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simgrid/simgrid/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/simgrid/simgrid/statuses/66c90eeb72aeb9733b53ac1c0bcb2eb01087f040"}}}}
{"actor":{"display_login":"rktesser"}}