{"action":"created","issue":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/698","repository_url":"https://api.github.com/repos/AutoFixture/AutoFixture","labels_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/698/labels{/name}","comments_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/698/comments","events_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/698/events","html_url":"https://github.com/AutoFixture/AutoFixture/pull/698","id":172628350,"number":698,"title":"Improve NSubstitute","user":{"login":"Zvirja","id":1074182,"avatar_url":"https://avatars.githubusercontent.com/u/1074182?v=3","gravatar_id":"","url":"https://api.github.com/users/Zvirja","html_url":"https://github.com/Zvirja","followers_url":"https://api.github.com/users/Zvirja/followers","following_url":"https://api.github.com/users/Zvirja/following{/other_user}","gists_url":"https://api.github.com/users/Zvirja/gists{/gist_id}","starred_url":"https://api.github.com/users/Zvirja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zvirja/subscriptions","organizations_url":"https://api.github.com/users/Zvirja/orgs","repos_url":"https://api.github.com/users/Zvirja/repos","events_url":"https://api.github.com/users/Zvirja/events{/privacy}","received_events_url":"https://api.github.com/users/Zvirja/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-08-23T07:17:25Z","updated_at":"2016-08-26T08:07:47Z","closed_at":"2016-08-25T20:33:40Z","pull_request":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/pulls/698","html_url":"https://github.com/AutoFixture/AutoFixture/pull/698","diff_url":"https://github.com/AutoFixture/AutoFixture/pull/698.diff","patch_url":"https://github.com/AutoFixture/AutoFixture/pull/698.patch"},"body":"Apply a few code changes to improve NSubstitute integration codebase.\r\nEach time I have issues with NSubstitute integration (e.g. because of concurrency) I find that it's hard to understand what is going on in the integration. Therefore, I decided to simplify a few places and add comment.\r\n\r\nAlso, I resolved a couple of small issues.\r\n\r\nIf you wish, I could split into multiple PRs. I found that changes are rather tiny, so no real sense for that.\r\n\r\n---\r\nBTW: The current code analysis rules don't allow to use string interpolation from C# 6 . Each time it's used, code analysis fails and asks to use culture specific overload of `string.Format()`. Do we need to disable that rule? Obviously, AF doesn't worry about that - it's a dev tool. See example in warning 3 [here](https://ci.appveyor.com/project/AutoFixture/autofixture/build/1.0.317-kggqwrqe)."},"comment":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/comments/242660693","html_url":"https://github.com/AutoFixture/AutoFixture/pull/698#issuecomment-242660693","issue_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/698","id":242660693,"user":{"login":"Zvirja","id":1074182,"avatar_url":"https://avatars.githubusercontent.com/u/1074182?v=3","gravatar_id":"","url":"https://api.github.com/users/Zvirja","html_url":"https://github.com/Zvirja","followers_url":"https://api.github.com/users/Zvirja/followers","following_url":"https://api.github.com/users/Zvirja/following{/other_user}","gists_url":"https://api.github.com/users/Zvirja/gists{/gist_id}","starred_url":"https://api.github.com/users/Zvirja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zvirja/subscriptions","organizations_url":"https://api.github.com/users/Zvirja/orgs","repos_url":"https://api.github.com/users/Zvirja/repos","events_url":"https://api.github.com/users/Zvirja/events{/privacy}","received_events_url":"https://api.github.com/users/Zvirja/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T08:07:47Z","updated_at":"2016-08-26T08:07:47Z","body":"@moodmosaic Thanks for the input. Could you please also answer to the following question? Do you thing it would be fine to disable code analysis rule that enforces to always explicitly specify culture or you believe that we need it?"}}
{"actor":{"display_login":"Zvirja"}}