{"action":"created","issue":{"url":"https://api.github.com/repos/github/VisualStudio/issues/20","repository_url":"https://api.github.com/repos/github/VisualStudio","labels_url":"https://api.github.com/repos/github/VisualStudio/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/github/VisualStudio/issues/20/comments","events_url":"https://api.github.com/repos/github/VisualStudio/issues/20/events","html_url":"https://github.com/github/VisualStudio/issues/20","id":98002953,"number":20,"title":"Pull Requests","user":{"login":"shana","id":310137,"avatar_url":"https://avatars.githubusercontent.com/u/310137?v=3","gravatar_id":"","url":"https://api.github.com/users/shana","html_url":"https://github.com/shana","followers_url":"https://api.github.com/users/shana/followers","following_url":"https://api.github.com/users/shana/following{/other_user}","gists_url":"https://api.github.com/users/shana/gists{/gist_id}","starred_url":"https://api.github.com/users/shana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana/subscriptions","organizations_url":"https://api.github.com/users/shana/orgs","repos_url":"https://api.github.com/users/shana/repos","events_url":"https://api.github.com/users/shana/events{/privacy}","received_events_url":"https://api.github.com/users/shana/received_events","type":"User","site_admin":true},"labels":[{"url":"https://api.github.com/repos/github/VisualStudio/labels/feature","name":"feature","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/github/VisualStudio/milestones/2","html_url":"https://github.com/github/VisualStudio/milestones/1.2%20-%20Pull%20Requests%20(and%20more)","labels_url":"https://api.github.com/repos/github/VisualStudio/milestones/2/labels","id":1253532,"number":2,"title":"1.2 - Pull Requests (and more)","description":"This will be the next big release. It'll include the Pull Request feature which will be a big deal.","creator":{"login":"shana","id":310137,"avatar_url":"https://avatars.githubusercontent.com/u/310137?v=3","gravatar_id":"","url":"https://api.github.com/users/shana","html_url":"https://github.com/shana","followers_url":"https://api.github.com/users/shana/followers","following_url":"https://api.github.com/users/shana/following{/other_user}","gists_url":"https://api.github.com/users/shana/gists{/gist_id}","starred_url":"https://api.github.com/users/shana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shana/subscriptions","organizations_url":"https://api.github.com/users/shana/orgs","repos_url":"https://api.github.com/users/shana/repos","events_url":"https://api.github.com/users/shana/events{/privacy}","received_events_url":"https://api.github.com/users/shana/received_events","type":"User","site_admin":true},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-08-13T12:38:18Z","updated_at":"2015-09-28T09:01:43Z","due_on":null,"closed_at":null},"comments":38,"created_at":"2015-07-29T18:43:40Z","updated_at":"2016-02-04T02:34:08Z","closed_at":null,"body":"Imported from https://github.com/github/VisualStudioInternal/issues/428\r\n\r\nSo this is the broad list of things that go into PRs. I've set checkmarks on the bare minimum PR support without which there's probably no point in shipping. Any things that we wouldn't support initially would instead jump to the website to show the information, if possible.\r\n\r\n### PR Feature 1\r\n\r\n- [x] Create Pull Request\r\n  - [x] Entry form for title, description and create button\r\n  - [x] Commit list\r\n    - [ ] Commit detail (file changes list per commit)\r\n  - [ ] File changes list (of the PR)\r\n  - [ ] Diff of file change selected (from commit detail or PR changes detail), no special adornments\r\n\r\n### PR Feature 2\r\n\r\n- [x] List Pull Requests\r\n  - [x] Filtering\r\n\r\n### PR Feature 3\r\n\r\n- [ ] Pull Request detail\r\n    - [ ] Commit list\r\n      - [ ] Commit detail (file changes list )\r\n    - [ ] File changes list (of the PR)\r\n    - [ ] Conversation list\r\n    - [ ] Diff of file change (from commit detail or PR changes list)\r\n      - [ ] Add comment on diff view line\r\n      - [ ] See comments on diff view line\r\n\r\n### Things to figure out\r\n\r\n- [ ] Need a way of assigning someone to a PR\r\n- [ ] Need a merge button somewhere\r\n- [ ] Sorting\r\n\r\n# Mockups\r\n\r\n## Pull Request List\r\n\r\n![pullrequestlistfiltering](https://cloud.githubusercontent.com/assets/310137/8367053/3b43ebde-1b9b-11e5-8aba-5bf6a7829ba0.png)\r\n\r\n## Pull Request Creation / Detail\r\n\r\nThe pull request creation wouldn't have a Conversation tab because, well, it's a new PR, but viewing an existing PR would have it. Still debating whether to use tabs or dropdowns (for space conservation), but tabs do provide useful information.\r\n\r\nNot seen in the mockups is the ability to see individual changes list per-commit, which is a very useful feature. Considering having the commit entry as a collapsible pane that shows a list of changed files in the same way as the PR file change list.\r\n\r\n![pullrequestcreation1](https://cloud.githubusercontent.com/assets/310137/8367180/29af31f2-1b9c-11e5-847b-afdb1c731c1f.png)\r\n![pullrequestcreation2](https://cloud.githubusercontent.com/assets/310137/8367183/304673a4-1b9c-11e5-9da9-afcd4311adeb.png)\r\n![pullrequestcreation3](https://cloud.githubusercontent.com/assets/310137/8367186/3493d6d6-1b9c-11e5-8284-abafb5356778.png)\r\n\r\n## Pull Request Detail, alternate form with pull downs\r\n\r\n![pullrequestcommitlist1](https://cloud.githubusercontent.com/assets/310137/8367238/87c04dee-1b9c-11e5-8127-fb94c1c39b0f.png)\r\n\r\n![pullrequestconversation1](https://cloud.githubusercontent.com/assets/310137/8367198/4b832fae-1b9c-11e5-9204-ebeeb94735a6.png)\r\n"},"comment":{"url":"https://api.github.com/repos/github/VisualStudio/issues/comments/179584357","html_url":"https://github.com/github/VisualStudio/issues/20#issuecomment-179584357","issue_url":"https://api.github.com/repos/github/VisualStudio/issues/20","id":179584357,"user":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"created_at":"2016-02-04T02:34:08Z","updated_at":"2016-02-04T02:34:08Z","body":"This is the one I was referring to earlier:\r\n\r\n<img width=\"344\" alt=\"screen shot 2016-02-04 at 1 02 10 pm\" src=\"https://cloud.githubusercontent.com/assets/359239/12804073/9504d15c-cb3f-11e5-8cd7-7eb7ed5d21da.png\">\r\n\r\n> In retrospect, it makes more sense to make these GHD and GHfVS components similar so we can, at the very least, reuse code and designs between the two.\r\n\r\n![](https://cloud.githubusercontent.com/assets/359239/12804051/59d2c4a4-cb3f-11e5-9f7f-211e96946e6d.gif)\r\n\r\nMore sharing of styles is totally :thumbsup: with me. And if this is a chance for us to give Desktop a bit of spruce up \"for free\" then let's see what we can do...\r\n\r\n"}}