{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/kovri/pulls/comments/85543297","pull_request_review_id":6254843,"id":85543297,"diff_hunk":"@@ -66,6 +66,17 @@ enum struct NetDbDuration : const uint16_t {\n   ExploreTunnelsInterval = 30,  // seconds\n };\n \n+/// @enum NetDbRouterPrefs\n+/// @brief Constants defining NetDb preferences\n+/// for how many known routers are wanted for\n+/// a large variety of peers to build tunnels\n+enum struct NetDbRouterPrefs : const uint16_t {","path":"src/core/net_db.h","position":19,"original_position":8,"commit_id":"2f9e6c19518bc2e2ae2a31ad3e7ed96e4b70b19d","original_commit_id":"f9a710cb3e93c5bc7da16f2d8fc52ef9ff57b2a0","user":{"login":"anonimal","id":12156341,"avatar_url":"https://avatars.githubusercontent.com/u/12156341?v=3","gravatar_id":"","url":"https://api.github.com/users/anonimal","html_url":"https://github.com/anonimal","followers_url":"https://api.github.com/users/anonimal/followers","following_url":"https://api.github.com/users/anonimal/following{/other_user}","gists_url":"https://api.github.com/users/anonimal/gists{/gist_id}","starred_url":"https://api.github.com/users/anonimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anonimal/subscriptions","organizations_url":"https://api.github.com/users/anonimal/orgs","repos_url":"https://api.github.com/users/anonimal/repos","events_url":"https://api.github.com/users/anonimal/events{/privacy}","received_events_url":"https://api.github.com/users/anonimal/received_events","type":"User","site_admin":false},"body":"Currently, `Router` is implied, `NetDbPreferences` *could* be better for now.","created_at":"2016-10-28T14:39:19Z","updated_at":"2016-10-28T14:39:19Z","html_url":"https://github.com/monero-project/kovri/pull/413#discussion_r85543297","pull_request_url":"https://api.github.com/repos/monero-project/kovri/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/monero-project/kovri/pulls/comments/85543297"},"html":{"href":"https://github.com/monero-project/kovri/pull/413#discussion_r85543297"},"pull_request":{"href":"https://api.github.com/repos/monero-project/kovri/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/monero-project/kovri/pulls/413","id":91239611,"html_url":"https://github.com/monero-project/kovri/pull/413","diff_url":"https://github.com/monero-project/kovri/pull/413.diff","patch_url":"https://github.com/monero-project/kovri/pull/413.patch","issue_url":"https://api.github.com/repos/monero-project/kovri/issues/413","number":413,"state":"open","locked":false,"title":"NetDb: styling fixes and refactoring of arbitrary values","user":{"login":"olarks","id":22985323,"avatar_url":"https://avatars.githubusercontent.com/u/22985323?v=3","gravatar_id":"","url":"https://api.github.com/users/olarks","html_url":"https://github.com/olarks","followers_url":"https://api.github.com/users/olarks/followers","following_url":"https://api.github.com/users/olarks/following{/other_user}","gists_url":"https://api.github.com/users/olarks/gists{/gist_id}","starred_url":"https://api.github.com/users/olarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olarks/subscriptions","organizations_url":"https://api.github.com/users/olarks/orgs","repos_url":"https://api.github.com/users/olarks/repos","events_url":"https://api.github.com/users/olarks/events{/privacy}","received_events_url":"https://api.github.com/users/olarks/received_events","type":"User","site_admin":false},"body":"**By submitting this pull-request, I confirm the following:**\r\n\r\n- I have read and understood the [Contributing Guide](https://github.com/monero-project/kovri/blob/master/doc/CONTRIBUTING.md).\r\n- I have checked that another pull-request for this purpose does not exist.\r\n- I have considered and confirmed that this submission will be valuable to others.\r\n- I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.\r\n- I give this submission freely under the BSD 3-clause license.\r\n\r\n*Place an X inside the bracket (or click the box in preview) to confirm*\r\n- [ X] I confirm.\r\n\r\n---\r\n\r\n*Enter your pull-request summary here*\r\n","created_at":"2016-10-27T16:49:14Z","updated_at":"2016-10-28T14:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3b2a3150b849a377ab41a36d0b231aacd31c20b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/kovri/pulls/413/commits","review_comments_url":"https://api.github.com/repos/monero-project/kovri/pulls/413/comments","review_comment_url":"https://api.github.com/repos/monero-project/kovri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/kovri/issues/413/comments","statuses_url":"https://api.github.com/repos/monero-project/kovri/statuses/2f9e6c19518bc2e2ae2a31ad3e7ed96e4b70b19d","head":{"label":"olarks:net_db_refactor","ref":"net_db_refactor","sha":"2f9e6c19518bc2e2ae2a31ad3e7ed96e4b70b19d","user":{"login":"olarks","id":22985323,"avatar_url":"https://avatars.githubusercontent.com/u/22985323?v=3","gravatar_id":"","url":"https://api.github.com/users/olarks","html_url":"https://github.com/olarks","followers_url":"https://api.github.com/users/olarks/followers","following_url":"https://api.github.com/users/olarks/following{/other_user}","gists_url":"https://api.github.com/users/olarks/gists{/gist_id}","starred_url":"https://api.github.com/users/olarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olarks/subscriptions","organizations_url":"https://api.github.com/users/olarks/orgs","repos_url":"https://api.github.com/users/olarks/repos","events_url":"https://api.github.com/users/olarks/events{/privacy}","received_events_url":"https://api.github.com/users/olarks/received_events","type":"User","site_admin":false},"repo":{"id":71583963,"name":"kovri","full_name":"olarks/kovri","owner":{"login":"olarks","id":22985323,"avatar_url":"https://avatars.githubusercontent.com/u/22985323?v=3","gravatar_id":"","url":"https://api.github.com/users/olarks","html_url":"https://github.com/olarks","followers_url":"https://api.github.com/users/olarks/followers","following_url":"https://api.github.com/users/olarks/following{/other_user}","gists_url":"https://api.github.com/users/olarks/gists{/gist_id}","starred_url":"https://api.github.com/users/olarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olarks/subscriptions","organizations_url":"https://api.github.com/users/olarks/orgs","repos_url":"https://api.github.com/users/olarks/repos","events_url":"https://api.github.com/users/olarks/events{/privacy}","received_events_url":"https://api.github.com/users/olarks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olarks/kovri","description":"The Kovri I2P Router Project","fork":true,"url":"https://api.github.com/repos/olarks/kovri","forks_url":"https://api.github.com/repos/olarks/kovri/forks","keys_url":"https://api.github.com/repos/olarks/kovri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olarks/kovri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olarks/kovri/teams","hooks_url":"https://api.github.com/repos/olarks/kovri/hooks","issue_events_url":"https://api.github.com/repos/olarks/kovri/issues/events{/number}","events_url":"https://api.github.com/repos/olarks/kovri/events","assignees_url":"https://api.github.com/repos/olarks/kovri/assignees{/user}","branches_url":"https://api.github.com/repos/olarks/kovri/branches{/branch}","tags_url":"https://api.github.com/repos/olarks/kovri/tags","blobs_url":"https://api.github.com/repos/olarks/kovri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olarks/kovri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olarks/kovri/git/refs{/sha}","trees_url":"https://api.github.com/repos/olarks/kovri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olarks/kovri/statuses/{sha}","languages_url":"https://api.github.com/repos/olarks/kovri/languages","stargazers_url":"https://api.github.com/repos/olarks/kovri/stargazers","contributors_url":"https://api.github.com/repos/olarks/kovri/contributors","subscribers_url":"https://api.github.com/repos/olarks/kovri/subscribers","subscription_url":"https://api.github.com/repos/olarks/kovri/subscription","commits_url":"https://api.github.com/repos/olarks/kovri/commits{/sha}","git_commits_url":"https://api.github.com/repos/olarks/kovri/git/commits{/sha}","comments_url":"https://api.github.com/repos/olarks/kovri/comments{/number}","issue_comment_url":"https://api.github.com/repos/olarks/kovri/issues/comments{/number}","contents_url":"https://api.github.com/repos/olarks/kovri/contents/{+path}","compare_url":"https://api.github.com/repos/olarks/kovri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olarks/kovri/merges","archive_url":"https://api.github.com/repos/olarks/kovri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olarks/kovri/downloads","issues_url":"https://api.github.com/repos/olarks/kovri/issues{/number}","pulls_url":"https://api.github.com/repos/olarks/kovri/pulls{/number}","milestones_url":"https://api.github.com/repos/olarks/kovri/milestones{/number}","notifications_url":"https://api.github.com/repos/olarks/kovri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olarks/kovri/labels{/name}","releases_url":"https://api.github.com/repos/olarks/kovri/releases{/id}","deployments_url":"https://api.github.com/repos/olarks/kovri/deployments","created_at":"2016-10-21T17:08:03Z","updated_at":"2016-10-21T17:08:05Z","pushed_at":"2016-10-28T12:00:35Z","git_url":"git://github.com/olarks/kovri.git","ssh_url":"git@github.com:olarks/kovri.git","clone_url":"https://github.com/olarks/kovri.git","svn_url":"https://github.com/olarks/kovri","homepage":"","size":6830,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"c31dccf7c117cf1f4d66a88cf9a83d09c7bf432d","user":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":46236248,"name":"kovri","full_name":"monero-project/kovri","owner":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monero-project/kovri","description":"The Kovri I2P Router Project","fork":false,"url":"https://api.github.com/repos/monero-project/kovri","forks_url":"https://api.github.com/repos/monero-project/kovri/forks","keys_url":"https://api.github.com/repos/monero-project/kovri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/kovri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/kovri/teams","hooks_url":"https://api.github.com/repos/monero-project/kovri/hooks","issue_events_url":"https://api.github.com/repos/monero-project/kovri/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/kovri/events","assignees_url":"https://api.github.com/repos/monero-project/kovri/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/kovri/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/kovri/tags","blobs_url":"https://api.github.com/repos/monero-project/kovri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/kovri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/kovri/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/kovri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/kovri/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/kovri/languages","stargazers_url":"https://api.github.com/repos/monero-project/kovri/stargazers","contributors_url":"https://api.github.com/repos/monero-project/kovri/contributors","subscribers_url":"https://api.github.com/repos/monero-project/kovri/subscribers","subscription_url":"https://api.github.com/repos/monero-project/kovri/subscription","commits_url":"https://api.github.com/repos/monero-project/kovri/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/kovri/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/kovri/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/kovri/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/kovri/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/kovri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/kovri/merges","archive_url":"https://api.github.com/repos/monero-project/kovri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/kovri/downloads","issues_url":"https://api.github.com/repos/monero-project/kovri/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/kovri/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/kovri/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/kovri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/kovri/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/kovri/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/kovri/deployments","created_at":"2015-11-15T21:18:13Z","updated_at":"2016-10-23T16:33:06Z","pushed_at":"2016-10-28T12:00:35Z","git_url":"git://github.com/monero-project/kovri.git","ssh_url":"git@github.com:monero-project/kovri.git","clone_url":"https://github.com/monero-project/kovri.git","svn_url":"https://github.com/monero-project/kovri","homepage":"","size":6867,"stargazers_count":53,"watchers_count":53,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":81,"forks":20,"open_issues":81,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/kovri/pulls/413"},"html":{"href":"https://github.com/monero-project/kovri/pull/413"},"issue":{"href":"https://api.github.com/repos/monero-project/kovri/issues/413"},"comments":{"href":"https://api.github.com/repos/monero-project/kovri/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/kovri/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/kovri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/kovri/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/kovri/statuses/2f9e6c19518bc2e2ae2a31ad3e7ed96e4b70b19d"}}}}
{"actor":{"display_login":"anonimal"}}