{"action":"created","issue":{"url":"https://api.github.com/repos/Diaoul/subliminal/issues/537","repository_url":"https://api.github.com/repos/Diaoul/subliminal","labels_url":"https://api.github.com/repos/Diaoul/subliminal/issues/537/labels{/name}","comments_url":"https://api.github.com/repos/Diaoul/subliminal/issues/537/comments","events_url":"https://api.github.com/repos/Diaoul/subliminal/issues/537/events","html_url":"https://github.com/Diaoul/subliminal/issues/537","id":119006598,"number":537,"title":"Year-match isn't treated equally among providers","user":{"login":"pannal","id":1359593,"avatar_url":"https://avatars.githubusercontent.com/u/1359593?v=3","gravatar_id":"","url":"https://api.github.com/users/pannal","html_url":"https://github.com/pannal","followers_url":"https://api.github.com/users/pannal/followers","following_url":"https://api.github.com/users/pannal/following{/other_user}","gists_url":"https://api.github.com/users/pannal/gists{/gist_id}","starred_url":"https://api.github.com/users/pannal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pannal/subscriptions","organizations_url":"https://api.github.com/users/pannal/orgs","repos_url":"https://api.github.com/users/pannal/repos","events_url":"https://api.github.com/users/pannal/events{/privacy}","received_events_url":"https://api.github.com/users/pannal/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Diaoul/subliminal/labels/type/bug","name":"type/bug","color":"e11d21"}],"state":"closed","locked":false,"assignee":{"login":"Diaoul","id":319220,"avatar_url":"https://avatars.githubusercontent.com/u/319220?v=3","gravatar_id":"","url":"https://api.github.com/users/Diaoul","html_url":"https://github.com/Diaoul","followers_url":"https://api.github.com/users/Diaoul/followers","following_url":"https://api.github.com/users/Diaoul/following{/other_user}","gists_url":"https://api.github.com/users/Diaoul/gists{/gist_id}","starred_url":"https://api.github.com/users/Diaoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diaoul/subscriptions","organizations_url":"https://api.github.com/users/Diaoul/orgs","repos_url":"https://api.github.com/users/Diaoul/repos","events_url":"https://api.github.com/users/Diaoul/events{/privacy}","received_events_url":"https://api.github.com/users/Diaoul/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/Diaoul/subliminal/milestones/4","html_url":"https://github.com/Diaoul/subliminal/milestones/1.2","labels_url":"https://api.github.com/repos/Diaoul/subliminal/milestones/4/labels","id":1476711,"number":4,"title":"1.2","description":"","creator":{"login":"Diaoul","id":319220,"avatar_url":"https://avatars.githubusercontent.com/u/319220?v=3","gravatar_id":"","url":"https://api.github.com/users/Diaoul","html_url":"https://github.com/Diaoul","followers_url":"https://api.github.com/users/Diaoul/followers","following_url":"https://api.github.com/users/Diaoul/following{/other_user}","gists_url":"https://api.github.com/users/Diaoul/gists{/gist_id}","starred_url":"https://api.github.com/users/Diaoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diaoul/subscriptions","organizations_url":"https://api.github.com/users/Diaoul/orgs","repos_url":"https://api.github.com/users/Diaoul/repos","events_url":"https://api.github.com/users/Diaoul/events{/privacy}","received_events_url":"https://api.github.com/users/Diaoul/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":5,"state":"open","created_at":"2015-12-29T06:39:24Z","updated_at":"2016-02-04T00:01:06Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2015-11-26T09:44:33Z","updated_at":"2016-02-04T00:20:50Z","closed_at":"2016-02-04T00:01:06Z","body":"Hey,\r\n\r\nWhen comparing the match determination of OpenSubtitles to other providers, there seems to be a huge difference: OpenSubtitles provider only adds the year match to the matches list [if the video had a year (bool(video.year)) and both the video and the subtitle have the same year set](https://github.com/Diaoul/subliminal/blob/develop/subliminal/providers/opensubtitles.py#L76)  (and it's a movie).\r\n\r\nIn comparison to that, [let's say Addic7ed](https://github.com/Diaoul/subliminal/blob/develop/subliminal/providers/addic7ed.py#L55): It blindly compares the value of `video.year` with the value of `subtitle.year` - which adds `year` to the matches list, if both values are None.\r\n\r\n~~If I'm not wrong, this results in a pretty distinct behaviour: All other providers besides OpenSubtitles match 44 points too high - or OpenSubtitles generally matches 44 points too low, if the year isn't set on the video.~~\r\nEdit: not really, because Addic7ed only matches for TV series. Still, when I look at podnapisi, the year attribute isn't checked at all and doesn't get added to the matches list even for movies.\r\n\r\nI'd expect consistent behaviour, and I think the OpenSubtitles provider is wrong, because a None-year should match if both the video and the subtitles have it."},"comment":{"url":"https://api.github.com/repos/Diaoul/subliminal/issues/comments/179547391","html_url":"https://github.com/Diaoul/subliminal/issues/537#issuecomment-179547391","issue_url":"https://api.github.com/repos/Diaoul/subliminal/issues/537","id":179547391,"user":{"login":"Diaoul","id":319220,"avatar_url":"https://avatars.githubusercontent.com/u/319220?v=3","gravatar_id":"","url":"https://api.github.com/users/Diaoul","html_url":"https://github.com/Diaoul","followers_url":"https://api.github.com/users/Diaoul/followers","following_url":"https://api.github.com/users/Diaoul/following{/other_user}","gists_url":"https://api.github.com/users/Diaoul/gists{/gist_id}","starred_url":"https://api.github.com/users/Diaoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diaoul/subscriptions","organizations_url":"https://api.github.com/users/Diaoul/orgs","repos_url":"https://api.github.com/users/Diaoul/repos","events_url":"https://api.github.com/users/Diaoul/events{/privacy}","received_events_url":"https://api.github.com/users/Diaoul/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T00:20:50Z","updated_at":"2016-02-04T00:20:50Z","body":"I'm not exactly satisfied with the solution. `None` year won't match for OpenSubtitles as they give the original year of the series. It should match.\r\nOne way around this is to query imdb during scan_video to get the `series_year` and match that as well as `year`. See #338"}}