{"action":"created","comment":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/85533362","pull_request_review_id":6245381,"id":85533362,"diff_hunk":"@@ -286,7 +284,60 @@ fn destroy_filesystems(m: &MethodInfo<MTFn<TData>, TData>) -> MethodResult {\n }\n \n fn list_filesystems(m: &MethodInfo<MTFn<TData>, TData>) -> MethodResult {\n-    Ok(vec![m.msg.method_return().append3(\"/dbus/cache/path\", 0, \"Ok\")])\n+    let message: &Message = m.msg;\n+    let mut iter = message.iter_init();\n+\n+    if iter.arg_type() != 0 {","path":"src/dbus_api.rs","position":54,"original_position":37,"commit_id":"7f541bba726f5c43e5e9fd2f6256f5bf98ec0e20","original_commit_id":"f1438ffc138b52f88303af54ca414cd080612f1b","user":{"login":"trgill","id":13203542,"avatar_url":"https://avatars.githubusercontent.com/u/13203542?v=3","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false},"body":"Ok, the only other completed method that takes no arguments is list_pools.  I updated it.\r\n\r\nI think the check makes sense. But if folks disagree, I'll take them out.","created_at":"2016-10-28T13:50:30Z","updated_at":"2016-10-28T13:50:30Z","html_url":"https://github.com/stratis-storage/stratisd/pull/106#discussion_r85533362","pull_request_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments/85533362"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/106#discussion_r85533362"},"pull_request":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106","id":91219487,"html_url":"https://github.com/stratis-storage/stratisd/pull/106","diff_url":"https://github.com/stratis-storage/stratisd/pull/106.diff","patch_url":"https://github.com/stratis-storage/stratisd/pull/106.patch","issue_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/106","number":106,"state":"open","locked":false,"title":"Initial implementation of list_filesystems","user":{"login":"trgill","id":13203542,"avatar_url":"https://avatars.githubusercontent.com/u/13203542?v=3","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false},"body":"Added Filesystem trait to engine.rs\r\nCreated filesystem.rs in sim_engine/\r\nAdded filesystem to mod.rs\r\nAdded list_filesystem to the sim_engine/pool.rs\r\nAdded name, mount_point, and size to the SimFilesystem\r\nLoop on the items in filesystems (not filesystems.next())\r\nRemove mut from filesystems (not needed)\r\nAdd object_manager() to the base interface\r\n\r\nSigned-off-by: Todd Gill <tgill@redhat.com>","created_at":"2016-10-27T15:04:29Z","updated_at":"2016-10-28T13:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f5fb7b4909bb3ceb32c42a6abd8be3ef5e73c38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106/commits","review_comments_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106/comments","review_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/106/comments","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/7f541bba726f5c43e5e9fd2f6256f5bf98ec0e20","head":{"label":"trgill:list_filesystems","ref":"list_filesystems","sha":"7f541bba726f5c43e5e9fd2f6256f5bf98ec0e20","user":{"login":"trgill","id":13203542,"avatar_url":"https://avatars.githubusercontent.com/u/13203542?v=3","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false},"repo":{"id":69361555,"name":"stratisd","full_name":"trgill/stratisd","owner":{"login":"trgill","id":13203542,"avatar_url":"https://avatars.githubusercontent.com/u/13203542?v=3","gravatar_id":"","url":"https://api.github.com/users/trgill","html_url":"https://github.com/trgill","followers_url":"https://api.github.com/users/trgill/followers","following_url":"https://api.github.com/users/trgill/following{/other_user}","gists_url":"https://api.github.com/users/trgill/gists{/gist_id}","starred_url":"https://api.github.com/users/trgill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trgill/subscriptions","organizations_url":"https://api.github.com/users/trgill/orgs","repos_url":"https://api.github.com/users/trgill/repos","events_url":"https://api.github.com/users/trgill/events{/privacy}","received_events_url":"https://api.github.com/users/trgill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trgill/stratisd","description":null,"fork":true,"url":"https://api.github.com/repos/trgill/stratisd","forks_url":"https://api.github.com/repos/trgill/stratisd/forks","keys_url":"https://api.github.com/repos/trgill/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trgill/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trgill/stratisd/teams","hooks_url":"https://api.github.com/repos/trgill/stratisd/hooks","issue_events_url":"https://api.github.com/repos/trgill/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/trgill/stratisd/events","assignees_url":"https://api.github.com/repos/trgill/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/trgill/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/trgill/stratisd/tags","blobs_url":"https://api.github.com/repos/trgill/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trgill/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trgill/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/trgill/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trgill/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/trgill/stratisd/languages","stargazers_url":"https://api.github.com/repos/trgill/stratisd/stargazers","contributors_url":"https://api.github.com/repos/trgill/stratisd/contributors","subscribers_url":"https://api.github.com/repos/trgill/stratisd/subscribers","subscription_url":"https://api.github.com/repos/trgill/stratisd/subscription","commits_url":"https://api.github.com/repos/trgill/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/trgill/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/trgill/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/trgill/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/trgill/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/trgill/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trgill/stratisd/merges","archive_url":"https://api.github.com/repos/trgill/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trgill/stratisd/downloads","issues_url":"https://api.github.com/repos/trgill/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/trgill/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/trgill/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/trgill/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trgill/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/trgill/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/trgill/stratisd/deployments","created_at":"2016-09-27T13:47:50Z","updated_at":"2016-09-27T13:47:51Z","pushed_at":"2016-10-28T13:45:52Z","git_url":"git://github.com/trgill/stratisd.git","ssh_url":"git@github.com:trgill/stratisd.git","clone_url":"https://github.com/trgill/stratisd.git","svn_url":"https://github.com/trgill/stratisd","homepage":null,"size":203,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratis-storage:master","ref":"master","sha":"8ff71032b730c83126bf0d6a4528853376d82a62","user":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars.githubusercontent.com/u/21202300?v=3","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"repo":{"id":66564704,"name":"stratisd","full_name":"stratis-storage/stratisd","owner":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars.githubusercontent.com/u/21202300?v=3","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratis-storage/stratisd","description":null,"fork":false,"url":"https://api.github.com/repos/stratis-storage/stratisd","forks_url":"https://api.github.com/repos/stratis-storage/stratisd/forks","keys_url":"https://api.github.com/repos/stratis-storage/stratisd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratis-storage/stratisd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratis-storage/stratisd/teams","hooks_url":"https://api.github.com/repos/stratis-storage/stratisd/hooks","issue_events_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/events{/number}","events_url":"https://api.github.com/repos/stratis-storage/stratisd/events","assignees_url":"https://api.github.com/repos/stratis-storage/stratisd/assignees{/user}","branches_url":"https://api.github.com/repos/stratis-storage/stratisd/branches{/branch}","tags_url":"https://api.github.com/repos/stratis-storage/stratisd/tags","blobs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratis-storage/stratisd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratis-storage/stratisd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratis-storage/stratisd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratis-storage/stratisd/statuses/{sha}","languages_url":"https://api.github.com/repos/stratis-storage/stratisd/languages","stargazers_url":"https://api.github.com/repos/stratis-storage/stratisd/stargazers","contributors_url":"https://api.github.com/repos/stratis-storage/stratisd/contributors","subscribers_url":"https://api.github.com/repos/stratis-storage/stratisd/subscribers","subscription_url":"https://api.github.com/repos/stratis-storage/stratisd/subscription","commits_url":"https://api.github.com/repos/stratis-storage/stratisd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratis-storage/stratisd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratis-storage/stratisd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratis-storage/stratisd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratis-storage/stratisd/contents/{+path}","compare_url":"https://api.github.com/repos/stratis-storage/stratisd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratis-storage/stratisd/merges","archive_url":"https://api.github.com/repos/stratis-storage/stratisd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratis-storage/stratisd/downloads","issues_url":"https://api.github.com/repos/stratis-storage/stratisd/issues{/number}","pulls_url":"https://api.github.com/repos/stratis-storage/stratisd/pulls{/number}","milestones_url":"https://api.github.com/repos/stratis-storage/stratisd/milestones{/number}","notifications_url":"https://api.github.com/repos/stratis-storage/stratisd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratis-storage/stratisd/labels{/name}","releases_url":"https://api.github.com/repos/stratis-storage/stratisd/releases{/id}","deployments_url":"https://api.github.com/repos/stratis-storage/stratisd/deployments","created_at":"2016-08-25T14:24:19Z","updated_at":"2016-10-25T09:59:05Z","pushed_at":"2016-10-28T13:45:52Z","git_url":"git://github.com/stratis-storage/stratisd.git","ssh_url":"git@github.com:stratis-storage/stratisd.git","clone_url":"https://github.com/stratis-storage/stratisd.git","svn_url":"https://github.com/stratis-storage/stratisd","homepage":null,"size":197,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106"},"html":{"href":"https://github.com/stratis-storage/stratisd/pull/106"},"issue":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/106"},"comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratis-storage/stratisd/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/stratis-storage/stratisd/statuses/7f541bba726f5c43e5e9fd2f6256f5bf98ec0e20"}}}}
{"actor":{"display_login":"trgill"}}