{"action":"created","comment":{"url":"https://api.github.com/repos/iamdustan/react-hardware/pulls/comments/60723066","id":60723066,"diff_hunk":"@@ -4,6 +4,11 @@ import ReactHardwareComponent from '../ReactHardwareComponent';\n import ReactHardwareReconcileTransaction from '../ReactHardwareReconcileTransaction';\n \n describe('ReactHardwareComponent', () => {\n+  it('should warn if it gets an unknown type', () => {\n+    // TODO: check so it is the correct error\n+    expect(() => new ReactHardwareComponent({ type: 'foo' })).toThrow();","path":"src/__tests__/ReactHardwareComponent-test.js","position":6,"original_position":6,"commit_id":"0dd6195f6379f8992670f76fa8888daa161ab862","original_commit_id":"0dd6195f6379f8992670f76fa8888daa161ab862","user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"body":"nit: remove outter spacing in single line object literals (following React code style) `{type: 'foo'}`","created_at":"2016-04-22T11:01:40Z","updated_at":"2016-04-22T11:01:40Z","html_url":"https://github.com/iamdustan/react-hardware/pull/7#discussion_r60723066","pull_request_url":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/iamdustan/react-hardware/pulls/comments/60723066"},"html":{"href":"https://github.com/iamdustan/react-hardware/pull/7#discussion_r60723066"},"pull_request":{"href":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7","id":67418128,"html_url":"https://github.com/iamdustan/react-hardware/pull/7","diff_url":"https://github.com/iamdustan/react-hardware/pull/7.diff","patch_url":"https://github.com/iamdustan/react-hardware/pull/7.patch","issue_url":"https://api.github.com/repos/iamdustan/react-hardware/issues/7","number":7,"state":"open","locked":false,"title":"Cleaned up ReactHardwareComponent","user":{"login":"edvinerikson","id":3890572,"avatar_url":"https://avatars.githubusercontent.com/u/3890572?v=3","gravatar_id":"","url":"https://api.github.com/users/edvinerikson","html_url":"https://github.com/edvinerikson","followers_url":"https://api.github.com/users/edvinerikson/followers","following_url":"https://api.github.com/users/edvinerikson/following{/other_user}","gists_url":"https://api.github.com/users/edvinerikson/gists{/gist_id}","starred_url":"https://api.github.com/users/edvinerikson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edvinerikson/subscriptions","organizations_url":"https://api.github.com/users/edvinerikson/orgs","repos_url":"https://api.github.com/users/edvinerikson/repos","events_url":"https://api.github.com/users/edvinerikson/events{/privacy}","received_events_url":"https://api.github.com/users/edvinerikson/received_events","type":"User","site_admin":false},"body":"* checks if the native component is supported, warns otherwise.  \r\n  `<foo />` will warn. `<pin />` will not.\r\n  Currently only `pin` and `container` is available\r\n  Not sure if I should check in `receiveComponent` too.\r\n* Added different view configs for the components.\r\n* cleaned up the test a little bit.\r\n* removed the possibility to use any native component name.  \r\n  e.g `<foo />` and `<pin />` would act the same, but not anymore.\r\n","created_at":"2016-04-21T20:36:27Z","updated_at":"2016-04-22T11:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74551d544db628156cd2c9dfc35735e5110d0217","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7/commits","review_comments_url":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7/comments","review_comment_url":"https://api.github.com/repos/iamdustan/react-hardware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iamdustan/react-hardware/issues/7/comments","statuses_url":"https://api.github.com/repos/iamdustan/react-hardware/statuses/0dd6195f6379f8992670f76fa8888daa161ab862","head":{"label":"edvinerikson:native-components","ref":"native-components","sha":"0dd6195f6379f8992670f76fa8888daa161ab862","user":{"login":"edvinerikson","id":3890572,"avatar_url":"https://avatars.githubusercontent.com/u/3890572?v=3","gravatar_id":"","url":"https://api.github.com/users/edvinerikson","html_url":"https://github.com/edvinerikson","followers_url":"https://api.github.com/users/edvinerikson/followers","following_url":"https://api.github.com/users/edvinerikson/following{/other_user}","gists_url":"https://api.github.com/users/edvinerikson/gists{/gist_id}","starred_url":"https://api.github.com/users/edvinerikson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edvinerikson/subscriptions","organizations_url":"https://api.github.com/users/edvinerikson/orgs","repos_url":"https://api.github.com/users/edvinerikson/repos","events_url":"https://api.github.com/users/edvinerikson/events{/privacy}","received_events_url":"https://api.github.com/users/edvinerikson/received_events","type":"User","site_admin":false},"repo":{"id":56797389,"name":"react-hardware","full_name":"edvinerikson/react-hardware","owner":{"login":"edvinerikson","id":3890572,"avatar_url":"https://avatars.githubusercontent.com/u/3890572?v=3","gravatar_id":"","url":"https://api.github.com/users/edvinerikson","html_url":"https://github.com/edvinerikson","followers_url":"https://api.github.com/users/edvinerikson/followers","following_url":"https://api.github.com/users/edvinerikson/following{/other_user}","gists_url":"https://api.github.com/users/edvinerikson/gists{/gist_id}","starred_url":"https://api.github.com/users/edvinerikson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edvinerikson/subscriptions","organizations_url":"https://api.github.com/users/edvinerikson/orgs","repos_url":"https://api.github.com/users/edvinerikson/repos","events_url":"https://api.github.com/users/edvinerikson/events{/privacy}","received_events_url":"https://api.github.com/users/edvinerikson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edvinerikson/react-hardware","description":"A React renderer for Hardware.","fork":true,"url":"https://api.github.com/repos/edvinerikson/react-hardware","forks_url":"https://api.github.com/repos/edvinerikson/react-hardware/forks","keys_url":"https://api.github.com/repos/edvinerikson/react-hardware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edvinerikson/react-hardware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edvinerikson/react-hardware/teams","hooks_url":"https://api.github.com/repos/edvinerikson/react-hardware/hooks","issue_events_url":"https://api.github.com/repos/edvinerikson/react-hardware/issues/events{/number}","events_url":"https://api.github.com/repos/edvinerikson/react-hardware/events","assignees_url":"https://api.github.com/repos/edvinerikson/react-hardware/assignees{/user}","branches_url":"https://api.github.com/repos/edvinerikson/react-hardware/branches{/branch}","tags_url":"https://api.github.com/repos/edvinerikson/react-hardware/tags","blobs_url":"https://api.github.com/repos/edvinerikson/react-hardware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edvinerikson/react-hardware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edvinerikson/react-hardware/git/refs{/sha}","trees_url":"https://api.github.com/repos/edvinerikson/react-hardware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edvinerikson/react-hardware/statuses/{sha}","languages_url":"https://api.github.com/repos/edvinerikson/react-hardware/languages","stargazers_url":"https://api.github.com/repos/edvinerikson/react-hardware/stargazers","contributors_url":"https://api.github.com/repos/edvinerikson/react-hardware/contributors","subscribers_url":"https://api.github.com/repos/edvinerikson/react-hardware/subscribers","subscription_url":"https://api.github.com/repos/edvinerikson/react-hardware/subscription","commits_url":"https://api.github.com/repos/edvinerikson/react-hardware/commits{/sha}","git_commits_url":"https://api.github.com/repos/edvinerikson/react-hardware/git/commits{/sha}","comments_url":"https://api.github.com/repos/edvinerikson/react-hardware/comments{/number}","issue_comment_url":"https://api.github.com/repos/edvinerikson/react-hardware/issues/comments{/number}","contents_url":"https://api.github.com/repos/edvinerikson/react-hardware/contents/{+path}","compare_url":"https://api.github.com/repos/edvinerikson/react-hardware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edvinerikson/react-hardware/merges","archive_url":"https://api.github.com/repos/edvinerikson/react-hardware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edvinerikson/react-hardware/downloads","issues_url":"https://api.github.com/repos/edvinerikson/react-hardware/issues{/number}","pulls_url":"https://api.github.com/repos/edvinerikson/react-hardware/pulls{/number}","milestones_url":"https://api.github.com/repos/edvinerikson/react-hardware/milestones{/number}","notifications_url":"https://api.github.com/repos/edvinerikson/react-hardware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edvinerikson/react-hardware/labels{/name}","releases_url":"https://api.github.com/repos/edvinerikson/react-hardware/releases{/id}","deployments_url":"https://api.github.com/repos/edvinerikson/react-hardware/deployments","created_at":"2016-04-21T18:40:07Z","updated_at":"2016-04-21T18:40:08Z","pushed_at":"2016-04-21T20:48:58Z","git_url":"git://github.com/edvinerikson/react-hardware.git","ssh_url":"git@github.com:edvinerikson/react-hardware.git","clone_url":"https://github.com/edvinerikson/react-hardware.git","svn_url":"https://github.com/edvinerikson/react-hardware","homepage":"http://iamdustan.com/react-hardware","size":854,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iamdustan:master","ref":"master","sha":"516d2a8854028577a7d7928729042c8738181bb0","user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"repo":{"id":35565534,"name":"react-hardware","full_name":"iamdustan/react-hardware","owner":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars.githubusercontent.com/u/227879?v=3","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamdustan/react-hardware","description":"A React renderer for Hardware.","fork":false,"url":"https://api.github.com/repos/iamdustan/react-hardware","forks_url":"https://api.github.com/repos/iamdustan/react-hardware/forks","keys_url":"https://api.github.com/repos/iamdustan/react-hardware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamdustan/react-hardware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamdustan/react-hardware/teams","hooks_url":"https://api.github.com/repos/iamdustan/react-hardware/hooks","issue_events_url":"https://api.github.com/repos/iamdustan/react-hardware/issues/events{/number}","events_url":"https://api.github.com/repos/iamdustan/react-hardware/events","assignees_url":"https://api.github.com/repos/iamdustan/react-hardware/assignees{/user}","branches_url":"https://api.github.com/repos/iamdustan/react-hardware/branches{/branch}","tags_url":"https://api.github.com/repos/iamdustan/react-hardware/tags","blobs_url":"https://api.github.com/repos/iamdustan/react-hardware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamdustan/react-hardware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamdustan/react-hardware/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamdustan/react-hardware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamdustan/react-hardware/statuses/{sha}","languages_url":"https://api.github.com/repos/iamdustan/react-hardware/languages","stargazers_url":"https://api.github.com/repos/iamdustan/react-hardware/stargazers","contributors_url":"https://api.github.com/repos/iamdustan/react-hardware/contributors","subscribers_url":"https://api.github.com/repos/iamdustan/react-hardware/subscribers","subscription_url":"https://api.github.com/repos/iamdustan/react-hardware/subscription","commits_url":"https://api.github.com/repos/iamdustan/react-hardware/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamdustan/react-hardware/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamdustan/react-hardware/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamdustan/react-hardware/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamdustan/react-hardware/contents/{+path}","compare_url":"https://api.github.com/repos/iamdustan/react-hardware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamdustan/react-hardware/merges","archive_url":"https://api.github.com/repos/iamdustan/react-hardware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamdustan/react-hardware/downloads","issues_url":"https://api.github.com/repos/iamdustan/react-hardware/issues{/number}","pulls_url":"https://api.github.com/repos/iamdustan/react-hardware/pulls{/number}","milestones_url":"https://api.github.com/repos/iamdustan/react-hardware/milestones{/number}","notifications_url":"https://api.github.com/repos/iamdustan/react-hardware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamdustan/react-hardware/labels{/name}","releases_url":"https://api.github.com/repos/iamdustan/react-hardware/releases{/id}","deployments_url":"https://api.github.com/repos/iamdustan/react-hardware/deployments","created_at":"2015-05-13T18:01:21Z","updated_at":"2016-04-22T02:33:19Z","pushed_at":"2016-04-21T20:48:58Z","git_url":"git://github.com/iamdustan/react-hardware.git","ssh_url":"git@github.com:iamdustan/react-hardware.git","clone_url":"https://github.com/iamdustan/react-hardware.git","svn_url":"https://github.com/iamdustan/react-hardware","homepage":"http://iamdustan.com/react-hardware","size":857,"stargazers_count":150,"watchers_count":150,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7"},"html":{"href":"https://github.com/iamdustan/react-hardware/pull/7"},"issue":{"href":"https://api.github.com/repos/iamdustan/react-hardware/issues/7"},"comments":{"href":"https://api.github.com/repos/iamdustan/react-hardware/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/iamdustan/react-hardware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iamdustan/react-hardware/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/iamdustan/react-hardware/statuses/0dd6195f6379f8992670f76fa8888daa161ab862"}}}}