{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/4557","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/4557/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4557/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/4557/events","html_url":"https://github.com/ampproject/amphtml/issues/4557","id":171554295,"number":4557,"title":"`this.domain_` is undefined in `preconnectCallback`","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ampproject/amphtml/labels/Type:%20Bug","name":"Type: Bug","color":"f7c6c7"},{"url":"https://api.github.com/repos/ampproject/amphtml/labels/Type:%20Production%20Bug","name":"Type: Production Bug","color":"e11d21"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ampproject/amphtml/milestones/18","html_url":"https://github.com/ampproject/amphtml/milestones/Current","labels_url":"https://api.github.com/repos/ampproject/amphtml/milestones/18/labels","id":1739456,"number":18,"title":"Current","description":"This milestone tracks issues currently being worked on.","creator":{"login":"ericlindley-g","id":16807766,"avatar_url":"https://avatars.githubusercontent.com/u/16807766?v=3","gravatar_id":"","url":"https://api.github.com/users/ericlindley-g","html_url":"https://github.com/ericlindley-g","followers_url":"https://api.github.com/users/ericlindley-g/followers","following_url":"https://api.github.com/users/ericlindley-g/following{/other_user}","gists_url":"https://api.github.com/users/ericlindley-g/gists{/gist_id}","starred_url":"https://api.github.com/users/ericlindley-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericlindley-g/subscriptions","organizations_url":"https://api.github.com/users/ericlindley-g/orgs","repos_url":"https://api.github.com/users/ericlindley-g/repos","events_url":"https://api.github.com/users/ericlindley-g/events{/privacy}","received_events_url":"https://api.github.com/users/ericlindley-g/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":114,"state":"open","created_at":"2016-04-29T23:08:57Z","updated_at":"2016-08-18T18:29:59Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-08-17T01:25:42Z","updated_at":"2016-08-18T18:29:59Z","closed_at":"2016-08-18T18:29:59Z","body":"`preconnect.js:185Uncaught TypeError: Cannot read property 'indexOf' of undefined`\r\n\r\nIt looks like this is occurring through https://github.com/ampproject/amphtml/blob/master/extensions/amp-o2-player/0.1/amp-o2-player.js#L25 since `this.domain_` is not and `preconnectCallback` is called before `layoutCallback`.\r\n\r\n@yevheniiminin do you mind taking a look at this?"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/240813447","html_url":"https://github.com/ampproject/amphtml/issues/4557#issuecomment-240813447","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4557","id":240813447,"user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T18:29:58Z","updated_at":"2016-08-18T18:29:58Z","body":"fixed by https://github.com/ampproject/amphtml/pull/4539"}}
{"actor":{"display_login":"erwinmombay"}}