{"action":"created","issue":{"url":"https://api.github.com/repos/BVLC/caffe/issues/3570","repository_url":"https://api.github.com/repos/BVLC/caffe","labels_url":"https://api.github.com/repos/BVLC/caffe/issues/3570/labels{/name}","comments_url":"https://api.github.com/repos/BVLC/caffe/issues/3570/comments","events_url":"https://api.github.com/repos/BVLC/caffe/issues/3570/events","html_url":"https://github.com/BVLC/caffe/pull/3570","id":127504262,"number":3570,"title":"ND Crop layer","user":{"login":"BlGene","id":1850503,"avatar_url":"https://avatars.githubusercontent.com/u/1850503?v=3","gravatar_id":"","url":"https://api.github.com/users/BlGene","html_url":"https://github.com/BlGene","followers_url":"https://api.github.com/users/BlGene/followers","following_url":"https://api.github.com/users/BlGene/following{/other_user}","gists_url":"https://api.github.com/users/BlGene/gists{/gist_id}","starred_url":"https://api.github.com/users/BlGene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlGene/subscriptions","organizations_url":"https://api.github.com/users/BlGene/orgs","repos_url":"https://api.github.com/users/BlGene/repos","events_url":"https://api.github.com/users/BlGene/events{/privacy}","received_events_url":"https://api.github.com/users/BlGene/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/BVLC/caffe/labels/enhancement","name":"enhancement","color":"c7def8"},{"url":"https://api.github.com/repos/BVLC/caffe/labels/ES","name":"ES","color":"bfdadc"},{"url":"https://api.github.com/repos/BVLC/caffe/labels/focus","name":"focus","color":"006b75"},{"url":"https://api.github.com/repos/BVLC/caffe/labels/JL","name":"JL","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-01-19T18:05:19Z","updated_at":"2016-03-04T11:03:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BVLC/caffe/pulls/3570","html_url":"https://github.com/BVLC/caffe/pull/3570","diff_url":"https://github.com/BVLC/caffe/pull/3570.diff","patch_url":"https://github.com/BVLC/caffe/pull/3570.patch"},"body":"Something along the lines of what a ND crop layer would look like.\r\nBased on: PR #1976 -> PR #3565 -> this\r\n\r\n### Todo\r\n- [x] Test for D > 4  \r\n- [x] Test backwards\r\n- [x] GPU kernel copy instead of memcopy (?)\r\n- [x] const indices and offsets\r\n- [x] GPU backwards/forwards\r\n- [x] CPU backwards\r\n- [x] parameter size checks\r\n- [x] lint\r\n\r\nPlease see PR #3613 for how to set the crop parameters."},"comment":{"url":"https://api.github.com/repos/BVLC/caffe/issues/comments/192234827","html_url":"https://github.com/BVLC/caffe/pull/3570#issuecomment-192234827","issue_url":"https://api.github.com/repos/BVLC/caffe/issues/3570","id":192234827,"user":{"login":"shelhamer","id":311113,"avatar_url":"https://avatars.githubusercontent.com/u/311113?v=3","gravatar_id":"","url":"https://api.github.com/users/shelhamer","html_url":"https://github.com/shelhamer","followers_url":"https://api.github.com/users/shelhamer/followers","following_url":"https://api.github.com/users/shelhamer/following{/other_user}","gists_url":"https://api.github.com/users/shelhamer/gists{/gist_id}","starred_url":"https://api.github.com/users/shelhamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelhamer/subscriptions","organizations_url":"https://api.github.com/users/shelhamer/orgs","repos_url":"https://api.github.com/users/shelhamer/repos","events_url":"https://api.github.com/users/shelhamer/events{/privacy}","received_events_url":"https://api.github.com/users/shelhamer/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T11:03:35Z","updated_at":"2016-03-04T11:03:35Z","body":"@BlGene I revised the tests in my [latest commits to shelhamer/caffe:nd-crop](https://github.com/shelhamer/caffe/commits/crop-nd) to\r\n\r\n- align with test conventions\r\n- add a 5D test\r\n- switch to the standard gradient checker\r\n\r\nso that all the TODOs are covered. Can you incorporate my changes into this branch for merge? Please squash commits to simplify history (including mine, I don't mind) into something like\r\n\r\n- a40439d original crop layer (longjon)\r\n- 1e9d279 extend to N-D (BlGene) with 409fa12, 9a4c15c, and 6437271 squashed\r\n- tests (BlGene)\r\n- test grooming: style, 5D, standard grad check (shelhamer)\r\n\r\nI've added tests to #3613 so we can merge both once this is ready."}}