{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/comments/53821240","id":53821240,"diff_hunk":"@@ -108,24 +126,41 @@\n     }\n \n     #scrim {\n-      position: fixed;\n-      top: -120px;\n+      position: absolute;\n+      top: 0;\n+      bottom: 0;\n       left: 0;\n       right: 0;\n-      bottom: -120px;\n       background: var(--app-drawer-scrim-background, rgba(0, 0, 0, 0.5));\n       opacity: 0;\n-      transition: opacity 0.2s ease;\n+      visibility: hidden;","path":"app-drawer/app-drawer.html","position":64,"original_position":64,"commit_id":"5f5df2628e87490e0fce7a4008ccbaaa243274b2","original_commit_id":"5f5df2628e87490e0fce7a4008ccbaaa243274b2","user":{"login":"frankiefu","id":116360,"avatar_url":"https://avatars.githubusercontent.com/u/116360?v=3","gravatar_id":"","url":"https://api.github.com/users/frankiefu","html_url":"https://github.com/frankiefu","followers_url":"https://api.github.com/users/frankiefu/followers","following_url":"https://api.github.com/users/frankiefu/following{/other_user}","gists_url":"https://api.github.com/users/frankiefu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiefu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiefu/subscriptions","organizations_url":"https://api.github.com/users/frankiefu/orgs","repos_url":"https://api.github.com/users/frankiefu/repos","events_url":"https://api.github.com/users/frankiefu/events{/privacy}","received_events_url":"https://api.github.com/users/frankiefu/received_events","type":"User","site_admin":false},"body":"Do we need to set `visibility: hidden` on #scrim?  Seems like we don't need to do that here and also L159.","created_at":"2016-02-23T18:03:46Z","updated_at":"2016-02-23T18:03:46Z","html_url":"https://github.com/PolymerLabs/app-layout/pull/79#discussion_r53821240","pull_request_url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/comments/53821240"},"html":{"href":"https://github.com/PolymerLabs/app-layout/pull/79#discussion_r53821240"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79","id":60281715,"html_url":"https://github.com/PolymerLabs/app-layout/pull/79","diff_url":"https://github.com/PolymerLabs/app-layout/pull/79.diff","patch_url":"https://github.com/PolymerLabs/app-layout/pull/79.patch","issue_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues/79","number":79,"state":"open","locked":false,"title":"Fixed persistent drawer that doesn't cover content","user":{"login":"keanulee","id":1319720,"avatar_url":"https://avatars.githubusercontent.com/u/1319720?v=3","gravatar_id":"","url":"https://api.github.com/users/keanulee","html_url":"https://github.com/keanulee","followers_url":"https://api.github.com/users/keanulee/followers","following_url":"https://api.github.com/users/keanulee/following{/other_user}","gists_url":"https://api.github.com/users/keanulee/gists{/gist_id}","starred_url":"https://api.github.com/users/keanulee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keanulee/subscriptions","organizations_url":"https://api.github.com/users/keanulee/orgs","repos_url":"https://api.github.com/users/keanulee/repos","events_url":"https://api.github.com/users/keanulee/events{/privacy}","received_events_url":"https://api.github.com/users/keanulee/received_events","type":"User","site_admin":false},"body":"Let’s try this again… this should not cover the content when the drawer is persistent","created_at":"2016-02-23T03:22:15Z","updated_at":"2016-02-23T18:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a98ab2d9408a340f6038d126b6e47ad9bcc8c58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues/79/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/app-layout/statuses/5f5df2628e87490e0fce7a4008ccbaaa243274b2","head":{"label":"PolymerLabs:fixed-drawer-v2","ref":"fixed-drawer-v2","sha":"5f5df2628e87490e0fce7a4008ccbaaa243274b2","user":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40323291,"name":"app-layout","full_name":"PolymerLabs/app-layout","owner":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/app-layout","description":"App layout elements","fork":false,"url":"https://api.github.com/repos/PolymerLabs/app-layout","forks_url":"https://api.github.com/repos/PolymerLabs/app-layout/forks","keys_url":"https://api.github.com/repos/PolymerLabs/app-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/app-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/app-layout/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/app-layout/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/app-layout/events","assignees_url":"https://api.github.com/repos/PolymerLabs/app-layout/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/app-layout/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/app-layout/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/app-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/app-layout/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/app-layout/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/app-layout/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/app-layout/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/app-layout/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/app-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/app-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/app-layout/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/app-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/app-layout/merges","archive_url":"https://api.github.com/repos/PolymerLabs/app-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/app-layout/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/app-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/app-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/app-layout/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/app-layout/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/app-layout/deployments","created_at":"2015-08-06T19:34:10Z","updated_at":"2016-02-23T10:02:26Z","pushed_at":"2016-02-23T03:22:15Z","git_url":"git://github.com/PolymerLabs/app-layout.git","ssh_url":"git@github.com:PolymerLabs/app-layout.git","clone_url":"https://github.com/PolymerLabs/app-layout.git","svn_url":"https://github.com/PolymerLabs/app-layout","homepage":"","size":41273,"stargazers_count":120,"watchers_count":120,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":14,"forks":30,"open_issues":14,"watchers":120,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"4bae6da484c153e48da93a35d356333cdee08026","user":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":40323291,"name":"app-layout","full_name":"PolymerLabs/app-layout","owner":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars.githubusercontent.com/u/5912903?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/app-layout","description":"App layout elements","fork":false,"url":"https://api.github.com/repos/PolymerLabs/app-layout","forks_url":"https://api.github.com/repos/PolymerLabs/app-layout/forks","keys_url":"https://api.github.com/repos/PolymerLabs/app-layout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/app-layout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/app-layout/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/app-layout/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/app-layout/events","assignees_url":"https://api.github.com/repos/PolymerLabs/app-layout/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/app-layout/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/app-layout/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/app-layout/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/app-layout/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/app-layout/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/app-layout/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/app-layout/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/app-layout/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/app-layout/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/app-layout/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/app-layout/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/app-layout/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/app-layout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/app-layout/merges","archive_url":"https://api.github.com/repos/PolymerLabs/app-layout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/app-layout/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/app-layout/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/app-layout/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/app-layout/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/app-layout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/app-layout/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/app-layout/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/app-layout/deployments","created_at":"2015-08-06T19:34:10Z","updated_at":"2016-02-23T10:02:26Z","pushed_at":"2016-02-23T03:22:15Z","git_url":"git://github.com/PolymerLabs/app-layout.git","ssh_url":"git@github.com:PolymerLabs/app-layout.git","clone_url":"https://github.com/PolymerLabs/app-layout.git","svn_url":"https://github.com/PolymerLabs/app-layout","homepage":"","size":41273,"stargazers_count":120,"watchers_count":120,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":14,"forks":30,"open_issues":14,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79"},"html":{"href":"https://github.com/PolymerLabs/app-layout/pull/79"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/issues/79"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/app-layout/statuses/5f5df2628e87490e0fce7a4008ccbaaa243274b2"}}}}