{"action":"created","comment":{"url":"https://api.github.com/repos/monero-project/monero/pulls/comments/86082627","pull_request_review_id":6758066,"id":86082627,"diff_hunk":"@@ -0,0 +1,96 @@\n+// Copyright (c) 2016, The Monero Project\n+// \n+// All rights reserved.\n+// \n+// Redistribution and use in source and binary forms, with or without modification, are\n+// permitted provided that the following conditions are met:\n+// \n+// 1. Redistributions of source code must retain the above copyright notice, this list of\n+//    conditions and the following disclaimer.\n+// \n+// 2. Redistributions in binary form must reproduce the above copyright notice, this list\n+//    of conditions and the following disclaimer in the documentation and/or other\n+//    materials provided with the distribution.\n+// \n+// 3. Neither the name of the copyright holder nor the names of its contributors may be\n+//    used to endorse or promote products derived from this software without specific\n+//    prior written permission.\n+// \n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\" AND ANY\n+// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF\n+// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL\n+// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,\n+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,\n+// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF\n+// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+#include \"zmq_client.h\"\n+\n+namespace cryptonote\n+{\n+\n+namespace rpc\n+{\n+\n+ZmqClient::ZmqClient() : context(1 /* one zmq thread */),\n+              req_socket(NULL),\n+              sub_socket(NULL)\n+{\n+}\n+\n+ZmqClient::~ZmqClient()","path":"src/rpc/zmq_client.cpp","position":43,"original_position":43,"commit_id":"e56446f362aabafeeb33705d9920de3c1d7cd71c","original_commit_id":"f0342fefdf4708c9ef6eba603aa06872320cb738","user":{"login":"tewinget","id":5104870,"avatar_url":"https://avatars.githubusercontent.com/u/5104870?v=3","gravatar_id":"","url":"https://api.github.com/users/tewinget","html_url":"https://github.com/tewinget","followers_url":"https://api.github.com/users/tewinget/followers","following_url":"https://api.github.com/users/tewinget/following{/other_user}","gists_url":"https://api.github.com/users/tewinget/gists{/gist_id}","starred_url":"https://api.github.com/users/tewinget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tewinget/subscriptions","organizations_url":"https://api.github.com/users/tewinget/orgs","repos_url":"https://api.github.com/users/tewinget/repos","events_url":"https://api.github.com/users/tewinget/events{/privacy}","received_events_url":"https://api.github.com/users/tewinget/received_events","type":"User","site_admin":false},"body":"addressed","created_at":"2016-11-02T07:06:10Z","updated_at":"2016-11-02T07:06:10Z","html_url":"https://github.com/monero-project/monero/pull/1172#discussion_r86082627","pull_request_url":"https://api.github.com/repos/monero-project/monero/pulls/1172","_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments/86082627"},"html":{"href":"https://github.com/monero-project/monero/pull/1172#discussion_r86082627"},"pull_request":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1172"}}},"pull_request":{"url":"https://api.github.com/repos/monero-project/monero/pulls/1172","id":87683676,"html_url":"https://github.com/monero-project/monero/pull/1172","diff_url":"https://github.com/monero-project/monero/pull/1172.diff","patch_url":"https://github.com/monero-project/monero/pull/1172.patch","issue_url":"https://api.github.com/repos/monero-project/monero/issues/1172","number":1172,"state":"open","locked":false,"title":"Daemon ZMQ RPC server and client, wallet using it","user":{"login":"tewinget","id":5104870,"avatar_url":"https://avatars.githubusercontent.com/u/5104870?v=3","gravatar_id":"","url":"https://api.github.com/users/tewinget","html_url":"https://github.com/tewinget","followers_url":"https://api.github.com/users/tewinget/followers","following_url":"https://api.github.com/users/tewinget/following{/other_user}","gists_url":"https://api.github.com/users/tewinget/gists{/gist_id}","starred_url":"https://api.github.com/users/tewinget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tewinget/subscriptions","organizations_url":"https://api.github.com/users/tewinget/orgs","repos_url":"https://api.github.com/users/tewinget/repos","events_url":"https://api.github.com/users/tewinget/events{/privacy}","received_events_url":"https://api.github.com/users/tewinget/received_events","type":"User","site_admin":false},"body":"Lots of rough edges, 0% chance of merging as-is, but PR for visibility and testing purposes.\n\nCurrently hard-coded localhost:31337, needs to be parametrized.\n\nSome daemon RPC calls have not yet been implemented, as attention was diverted to just those which the wallet needs.\n","created_at":"2016-10-03T09:09:13Z","updated_at":"2016-11-02T07:06:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fcd47339acb9a02fc4c00605615402074130b5f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/monero-project/monero/pulls/1172/commits","review_comments_url":"https://api.github.com/repos/monero-project/monero/pulls/1172/comments","review_comment_url":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monero-project/monero/issues/1172/comments","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/e56446f362aabafeeb33705d9920de3c1d7cd71c","head":{"label":"tewinget:zmq-dev","ref":"zmq-dev","sha":"e56446f362aabafeeb33705d9920de3c1d7cd71c","user":{"login":"tewinget","id":5104870,"avatar_url":"https://avatars.githubusercontent.com/u/5104870?v=3","gravatar_id":"","url":"https://api.github.com/users/tewinget","html_url":"https://github.com/tewinget","followers_url":"https://api.github.com/users/tewinget/followers","following_url":"https://api.github.com/users/tewinget/following{/other_user}","gists_url":"https://api.github.com/users/tewinget/gists{/gist_id}","starred_url":"https://api.github.com/users/tewinget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tewinget/subscriptions","organizations_url":"https://api.github.com/users/tewinget/orgs","repos_url":"https://api.github.com/users/tewinget/repos","events_url":"https://api.github.com/users/tewinget/events{/privacy}","received_events_url":"https://api.github.com/users/tewinget/received_events","type":"User","site_admin":false},"repo":{"id":20365466,"name":"bitmonero","full_name":"tewinget/bitmonero","owner":{"login":"tewinget","id":5104870,"avatar_url":"https://avatars.githubusercontent.com/u/5104870?v=3","gravatar_id":"","url":"https://api.github.com/users/tewinget","html_url":"https://github.com/tewinget","followers_url":"https://api.github.com/users/tewinget/followers","following_url":"https://api.github.com/users/tewinget/following{/other_user}","gists_url":"https://api.github.com/users/tewinget/gists{/gist_id}","starred_url":"https://api.github.com/users/tewinget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tewinget/subscriptions","organizations_url":"https://api.github.com/users/tewinget/orgs","repos_url":"https://api.github.com/users/tewinget/repos","events_url":"https://api.github.com/users/tewinget/events{/privacy}","received_events_url":"https://api.github.com/users/tewinget/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tewinget/bitmonero","description":"Anonymous cryptocurrency","fork":true,"url":"https://api.github.com/repos/tewinget/bitmonero","forks_url":"https://api.github.com/repos/tewinget/bitmonero/forks","keys_url":"https://api.github.com/repos/tewinget/bitmonero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tewinget/bitmonero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tewinget/bitmonero/teams","hooks_url":"https://api.github.com/repos/tewinget/bitmonero/hooks","issue_events_url":"https://api.github.com/repos/tewinget/bitmonero/issues/events{/number}","events_url":"https://api.github.com/repos/tewinget/bitmonero/events","assignees_url":"https://api.github.com/repos/tewinget/bitmonero/assignees{/user}","branches_url":"https://api.github.com/repos/tewinget/bitmonero/branches{/branch}","tags_url":"https://api.github.com/repos/tewinget/bitmonero/tags","blobs_url":"https://api.github.com/repos/tewinget/bitmonero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tewinget/bitmonero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tewinget/bitmonero/git/refs{/sha}","trees_url":"https://api.github.com/repos/tewinget/bitmonero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tewinget/bitmonero/statuses/{sha}","languages_url":"https://api.github.com/repos/tewinget/bitmonero/languages","stargazers_url":"https://api.github.com/repos/tewinget/bitmonero/stargazers","contributors_url":"https://api.github.com/repos/tewinget/bitmonero/contributors","subscribers_url":"https://api.github.com/repos/tewinget/bitmonero/subscribers","subscription_url":"https://api.github.com/repos/tewinget/bitmonero/subscription","commits_url":"https://api.github.com/repos/tewinget/bitmonero/commits{/sha}","git_commits_url":"https://api.github.com/repos/tewinget/bitmonero/git/commits{/sha}","comments_url":"https://api.github.com/repos/tewinget/bitmonero/comments{/number}","issue_comment_url":"https://api.github.com/repos/tewinget/bitmonero/issues/comments{/number}","contents_url":"https://api.github.com/repos/tewinget/bitmonero/contents/{+path}","compare_url":"https://api.github.com/repos/tewinget/bitmonero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tewinget/bitmonero/merges","archive_url":"https://api.github.com/repos/tewinget/bitmonero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tewinget/bitmonero/downloads","issues_url":"https://api.github.com/repos/tewinget/bitmonero/issues{/number}","pulls_url":"https://api.github.com/repos/tewinget/bitmonero/pulls{/number}","milestones_url":"https://api.github.com/repos/tewinget/bitmonero/milestones{/number}","notifications_url":"https://api.github.com/repos/tewinget/bitmonero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tewinget/bitmonero/labels{/name}","releases_url":"https://api.github.com/repos/tewinget/bitmonero/releases{/id}","deployments_url":"https://api.github.com/repos/tewinget/bitmonero/deployments","created_at":"2014-05-31T21:23:53Z","updated_at":"2016-05-20T08:20:26Z","pushed_at":"2016-11-02T06:25:21Z","git_url":"git://github.com/tewinget/bitmonero.git","ssh_url":"git@github.com:tewinget/bitmonero.git","clone_url":"https://github.com/tewinget/bitmonero.git","svn_url":"https://github.com/tewinget/bitmonero","homepage":"monero.cc","size":70242,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"monero-project:master","ref":"master","sha":"d51f1af75f782495a59e8af511f32aeadd7cd94e","user":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"repo":{"id":19316619,"name":"monero","full_name":"monero-project/monero","owner":{"login":"monero-project","id":7450663,"avatar_url":"https://avatars.githubusercontent.com/u/7450663?v=3","gravatar_id":"","url":"https://api.github.com/users/monero-project","html_url":"https://github.com/monero-project","followers_url":"https://api.github.com/users/monero-project/followers","following_url":"https://api.github.com/users/monero-project/following{/other_user}","gists_url":"https://api.github.com/users/monero-project/gists{/gist_id}","starred_url":"https://api.github.com/users/monero-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monero-project/subscriptions","organizations_url":"https://api.github.com/users/monero-project/orgs","repos_url":"https://api.github.com/users/monero-project/repos","events_url":"https://api.github.com/users/monero-project/events{/privacy}","received_events_url":"https://api.github.com/users/monero-project/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monero-project/monero","description":"Monero: the secure, private, untraceable cryptocurrency","fork":false,"url":"https://api.github.com/repos/monero-project/monero","forks_url":"https://api.github.com/repos/monero-project/monero/forks","keys_url":"https://api.github.com/repos/monero-project/monero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monero-project/monero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monero-project/monero/teams","hooks_url":"https://api.github.com/repos/monero-project/monero/hooks","issue_events_url":"https://api.github.com/repos/monero-project/monero/issues/events{/number}","events_url":"https://api.github.com/repos/monero-project/monero/events","assignees_url":"https://api.github.com/repos/monero-project/monero/assignees{/user}","branches_url":"https://api.github.com/repos/monero-project/monero/branches{/branch}","tags_url":"https://api.github.com/repos/monero-project/monero/tags","blobs_url":"https://api.github.com/repos/monero-project/monero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monero-project/monero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monero-project/monero/git/refs{/sha}","trees_url":"https://api.github.com/repos/monero-project/monero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monero-project/monero/statuses/{sha}","languages_url":"https://api.github.com/repos/monero-project/monero/languages","stargazers_url":"https://api.github.com/repos/monero-project/monero/stargazers","contributors_url":"https://api.github.com/repos/monero-project/monero/contributors","subscribers_url":"https://api.github.com/repos/monero-project/monero/subscribers","subscription_url":"https://api.github.com/repos/monero-project/monero/subscription","commits_url":"https://api.github.com/repos/monero-project/monero/commits{/sha}","git_commits_url":"https://api.github.com/repos/monero-project/monero/git/commits{/sha}","comments_url":"https://api.github.com/repos/monero-project/monero/comments{/number}","issue_comment_url":"https://api.github.com/repos/monero-project/monero/issues/comments{/number}","contents_url":"https://api.github.com/repos/monero-project/monero/contents/{+path}","compare_url":"https://api.github.com/repos/monero-project/monero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monero-project/monero/merges","archive_url":"https://api.github.com/repos/monero-project/monero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monero-project/monero/downloads","issues_url":"https://api.github.com/repos/monero-project/monero/issues{/number}","pulls_url":"https://api.github.com/repos/monero-project/monero/pulls{/number}","milestones_url":"https://api.github.com/repos/monero-project/monero/milestones{/number}","notifications_url":"https://api.github.com/repos/monero-project/monero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monero-project/monero/labels{/name}","releases_url":"https://api.github.com/repos/monero-project/monero/releases{/id}","deployments_url":"https://api.github.com/repos/monero-project/monero/deployments","created_at":"2014-04-30T14:38:28Z","updated_at":"2016-11-02T05:04:00Z","pushed_at":"2016-11-02T06:25:22Z","git_url":"git://github.com/monero-project/monero.git","ssh_url":"git@github.com:monero-project/monero.git","clone_url":"https://github.com/monero-project/monero.git","svn_url":"https://github.com/monero-project/monero","homepage":"https://getmonero.org","size":72784,"stargazers_count":318,"watchers_count":318,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"open_issues_count":131,"forks":212,"open_issues":131,"watchers":318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1172"},"html":{"href":"https://github.com/monero-project/monero/pull/1172"},"issue":{"href":"https://api.github.com/repos/monero-project/monero/issues/1172"},"comments":{"href":"https://api.github.com/repos/monero-project/monero/issues/1172/comments"},"review_comments":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1172/comments"},"review_comment":{"href":"https://api.github.com/repos/monero-project/monero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monero-project/monero/pulls/1172/commits"},"statuses":{"href":"https://api.github.com/repos/monero-project/monero/statuses/e56446f362aabafeeb33705d9920de3c1d7cd71c"}}}}
{"actor":{"display_login":"tewinget"}}