{"action":"created","issue":{"url":"https://api.github.com/repos/erikras/redux-form/issues/623","repository_url":"https://api.github.com/repos/erikras/redux-form","labels_url":"https://api.github.com/repos/erikras/redux-form/issues/623/labels{/name}","comments_url":"https://api.github.com/repos/erikras/redux-form/issues/623/comments","events_url":"https://api.github.com/repos/erikras/redux-form/issues/623/events","html_url":"https://github.com/erikras/redux-form/issues/623","id":131867848,"number":623,"title":"hot reload causing destroy","user":{"login":"arolson101","id":5304092,"avatar_url":"https://avatars.githubusercontent.com/u/5304092?v=3","gravatar_id":"","url":"https://api.github.com/users/arolson101","html_url":"https://github.com/arolson101","followers_url":"https://api.github.com/users/arolson101/followers","following_url":"https://api.github.com/users/arolson101/following{/other_user}","gists_url":"https://api.github.com/users/arolson101/gists{/gist_id}","starred_url":"https://api.github.com/users/arolson101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arolson101/subscriptions","organizations_url":"https://api.github.com/users/arolson101/orgs","repos_url":"https://api.github.com/users/arolson101/repos","events_url":"https://api.github.com/users/arolson101/events{/privacy}","received_events_url":"https://api.github.com/users/arolson101/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-02-06T15:39:46Z","updated_at":"2016-12-11T20:52:27Z","closed_at":null,"body":"I'm using webpack-dev-server and I have hot reload working, but my form data gets destroyed because componentWillUnmount is called.  From what I can gather from the [hot loader demo](http://gaearon.github.io/react-hot-loader/) unmount shouldn't be called.  Is this expected, or have I hooked things up wrong?\n\nHere is the callstack:\n\n```\ndestroy (actions.js:23)\n(anonymous function) (bindActionData.js:22)\n(anonymous function) (bindActionCreators.js:14)\ncomponentWillUnmount (createHigherOrd…mponent.js:115)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:243)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactChildReconciler.unmountChildren (ReactChildReconciler.js:115)\nReactMultiChild.Mixin.unmountChildren (ReactMultiChild.js:398)\nReactDOMComponent.Mixin.unmountComponent (ReactDOMComponent.js:911)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactChildReconciler.unmountChildren (ReactChildReconciler.js:115)\nReactMultiChild.Mixin.unmountChildren (ReactMultiChild.js:398)\nReactDOMComponent.Mixin.unmountComponent (ReactDOMComponent.js:911)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactChildReconciler.unmountChildren (ReactChildReconciler.js:115)\nReactMultiChild.Mixin.unmountChildren (ReactMultiChild.js:398)\nReactDOMComponent.Mixin.unmountComponent (ReactDOMComponent.js:911)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin.unmountComponent (ReactCompositeComponent.js:246)\nReactReconciler.unmountComponent (ReactReconciler.js:52)\nReactCompositeComponentMixin._updateRenderedComponent (ReactCompositeComponent.js:567)\nReactCompositeComponentMixin._performComponentUpdate (ReactCompositeComponent.js:544)\nReactCompositeComponentMixin.updateComponent (ReactCompositeComponent.js:473)\nReactCompositeComponent_updateComponent (ReactPerf.js:66)\nReactCompositeComponentMixin.receiveComponent (ReactCompositeComponent.js:405)\nReactReconciler.receiveComponent (ReactReconciler.js:87)\nReactChildReconciler.updateChildren (ReactChildReconciler.js:84)\nReactMultiChild.Mixin._reconcilerUpdateChildren (ReactMultiChild.js:216)\nReactMultiChild.Mixin._updateChildren (ReactMultiChild.js:351)\nReactMultiChild.Mixin.updateChildren (ReactMultiChild.js:326)\nReactDOMComponent.Mixin._updateDOMChildren (ReactDOMComponent.js:871)\nReactDOMComponent.Mixin.updateComponent (ReactDOMComponent.js:700)\nReactDOMComponent.Mixin.receiveComponent (ReactDOMComponent.js:645)\nReactReconciler.receiveComponent (ReactReconciler.js:87)\nReactCompositeComponentMixin._updateRenderedComponent (ReactCompositeComponent.js:562)\nReactCompositeComponentMixin._performComponentUpdate (ReactCompositeComponent.js:544)\nReactCompositeComponentMixin.updateComponent (ReactCompositeComponent.js:473)\nReactCompositeComponent_updateComponent (ReactPerf.js:66)\nReactCompositeComponentMixin.receiveComponent (ReactCompositeComponent.js:405)\nReactReconciler.receiveComponent (ReactReconciler.js:87)\nReactCompositeComponentMixin._updateRenderedComponent (ReactCompositeComponent.js:562)\nReactCompositeComponentMixin._performComponentUpdate (ReactCompositeComponent.js:544)\nReactCompositeComponentMixin.updateComponent (ReactCompositeComponent.js:473)\nReactCompositeComponent_updateComponent (ReactPerf.js:66)\nReactCompositeComponentMixin.receiveComponent (ReactCompositeComponent.js:405)\nReactReconciler.receiveComponent (ReactReconciler.js:87)\nReactCompositeComponentMixin._updateRenderedComponent (ReactCompositeComponent.js:562)\nReactCompositeComponentMixin._performComponentUpdate (ReactCompositeComponent.js:544)\nReactCompositeComponentMixin.updateComponent (ReactCompositeComponent.js:473)\nReactCompositeComponent_updateComponent (ReactPerf.js:66)\nReactCompositeComponentMixin.receiveComponent (ReactCompositeComponent.js:405)\nReactReconciler.receiveComponent (ReactReconciler.js:87)\nReactCompositeComponentMixin._updateRenderedComponent (ReactCompositeComponent.js:562)\nReactCompositeComponentMixin._performComponentUpdate (ReactCompositeComponent.js:544)\nReactCompositeComponentMixin.updateComponent (ReactCompositeComponent.js:473)\nReactCompositeComponent_updateComponent (ReactPerf.js:66)\nReactCompositeComponentMixin.receiveComponent (ReactCompositeComponent.js:405)\nReactReconciler.receiveComponent (ReactReconciler.js:87)\nReactChildReconciler.updateChildren (ReactChildReconciler.js:84)\nReactMultiChild.Mixin._reconcilerUpdateChildren (ReactMultiChild.js:216)\nReactMultiChild.Mixin._updateChildren (ReactMultiChild.js:351)\nReactMultiChild.Mixin.updateChildren (ReactMultiChild.js:326)\nReactDOMComponent.Mixin._updateDOMChildren (ReactDOMComponent.js:871)\nReactDOMComponent.Mixin.updateComponent (ReactDOMComponent.js:700)\nReactDOMComponent.Mixin.receiveComponent (ReactDOMComponent.js:645)\nReactReconciler.receiveComponent (ReactReconciler.js:87)\nReactCompositeComponentMixin._updateRenderedComponent (ReactCompositeComponent.js:562)\nReactCompositeComponentMixin._performComponentUpdate (ReactCompositeComponent.js:544)\nReactCompositeComponentMixin.updateComponent (ReactCompositeComponent.js:473)\nReactCompositeComponent_updateComponent (ReactPerf.js:66)\nReactCompositeComponentMixin.performUpdateIfNecessary (ReactCompositeComponent.js:421)\nReactReconciler.performUpdateIfNecessary (ReactReconciler.js:102)\nrunBatchedUpdates (ReactUpdates.js:129)\nMixin.perform (Transaction.js:136)\nMixin.perform (Transaction.js:136)\nassign.perform (ReactUpdates.js:86)\nflushBatchedUpdates (ReactUpdates.js:147)\nReactUpdates_flushBatchedUpdates (ReactPerf.js:66)\nMixin.closeAll (Transaction.js:202)\nMixin.perform (Transaction.js:149)\nReactDefaultBatchingStrategy.batchedUpdates (ReactDefaultBat…Strategy.js:62)\nenqueueUpdate (ReactUpdates.js:176)\nenqueueUpdate (ReactUpdateQueue.js:24)\nReactUpdateQueue.enqueueForceUpdate (ReactUpdateQueue.js:143)\nReactComponent.forceUpdate (ReactComponent.js:86)\nforceUpdateIfPending (deepForceUpdate.js:18)\ntraverseRenderedChildren (traverseRenderedChildren.js:4)\ntraverseRenderedChildren (traverseRenderedChildren.js:7)\ndeepForceUpdate (deepForceUpdate.js:33)\nforceUpdateAll (requestForceUpdateAll.js:27)\n```\n"},"comment":{"url":"https://api.github.com/repos/erikras/redux-form/issues/comments/266307031","html_url":"https://github.com/erikras/redux-form/issues/623#issuecomment-266307031","issue_url":"https://api.github.com/repos/erikras/redux-form/issues/623","id":266307031,"user":{"login":"sunnysingh","id":916763,"avatar_url":"https://avatars.githubusercontent.com/u/916763?v=3","gravatar_id":"","url":"https://api.github.com/users/sunnysingh","html_url":"https://github.com/sunnysingh","followers_url":"https://api.github.com/users/sunnysingh/followers","following_url":"https://api.github.com/users/sunnysingh/following{/other_user}","gists_url":"https://api.github.com/users/sunnysingh/gists{/gist_id}","starred_url":"https://api.github.com/users/sunnysingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunnysingh/subscriptions","organizations_url":"https://api.github.com/users/sunnysingh/orgs","repos_url":"https://api.github.com/users/sunnysingh/repos","events_url":"https://api.github.com/users/sunnysingh/events{/privacy}","received_events_url":"https://api.github.com/users/sunnysingh/received_events","type":"User","site_admin":false},"created_at":"2016-12-11T20:52:27Z","updated_at":"2016-12-11T20:52:27Z","body":"Is there a reason the commit that fixed this issue no longer exists in v6.3.2? https://github.com/erikras/redux-form/commit/0b8dd945713239f444bff28e46ceae225ada3066#diff-d749bb1257f721af37259e0346e623be\r\n\r\nI'm currently using the destroyOnUnmount fix but there is no way to specify this globally (as far as I am aware of) so it seems hacky to add this option to every wrapped form."}}
{"actor":{"display_login":"sunnysingh"}}