{"action":"created","issue":{"url":"https://api.github.com/repos/maidsafe/crust/issues/711","repository_url":"https://api.github.com/repos/maidsafe/crust","labels_url":"https://api.github.com/repos/maidsafe/crust/issues/711/labels{/name}","comments_url":"https://api.github.com/repos/maidsafe/crust/issues/711/comments","events_url":"https://api.github.com/repos/maidsafe/crust/issues/711/events","html_url":"https://github.com/maidsafe/crust/pull/711","id":156727963,"number":711,"title":"feat/connection_listener: enables timeout when accepting connection","user":{"login":"maqi","id":568777,"avatar_url":"https://avatars.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/maidsafe/crust/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-25T11:35:17Z","updated_at":"2016-05-25T15:38:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/maidsafe/crust/pulls/711","html_url":"https://github.com/maidsafe/crust/pull/711","diff_url":"https://github.com/maidsafe/crust/pull/711.diff","patch_url":"https://github.com/maidsafe/crust/pull/711.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/maidsafe/crust/711)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/maidsafe/crust/issues/comments/221615866","html_url":"https://github.com/maidsafe/crust/pull/711#issuecomment-221615866","issue_url":"https://api.github.com/repos/maidsafe/crust/issues/711","id":221615866,"user":{"login":"ustulation","id":8788153,"avatar_url":"https://avatars.githubusercontent.com/u/8788153?v=3","gravatar_id":"","url":"https://api.github.com/users/ustulation","html_url":"https://github.com/ustulation","followers_url":"https://api.github.com/users/ustulation/followers","following_url":"https://api.github.com/users/ustulation/following{/other_user}","gists_url":"https://api.github.com/users/ustulation/gists{/gist_id}","starred_url":"https://api.github.com/users/ustulation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ustulation/subscriptions","organizations_url":"https://api.github.com/users/ustulation/orgs","repos_url":"https://api.github.com/users/ustulation/repos","events_url":"https://api.github.com/users/ustulation/events{/privacy}","received_events_url":"https://api.github.com/users/ustulation/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T15:38:44Z","updated_at":"2016-05-25T15:38:44Z","body":"\n\n\n\n\n\nReview status: 0 of 4 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/bootstrap_states/bootstrap.rs, line 26 \\[r3\\]](https://reviewable.io:443/reviews/maidsafe/crust/711#-KIcYQgugskvjEtWr0Jo:-KIcYQgugskvjEtWr0Jp:2056887448) ([raw file](https://github.com/maidsafe/crust/blob/0be348b397fa053079323139760092d2d3e0dce4/src/bootstrap_states/bootstrap.rs#L26)):*\n> ```Rust\n> use std::rc::Rc;\n> \n> use connection_listener::BOOTSTRAP_TIMEOUT_MS;\n> ```\n\nhaving bootstrap module depend on connection listener module doesn't make sense. It is better to keep this in service.rs if both depend on this constant\n\n---\n\n*[src/core/state.rs, line 46 \\[r3\\]](https://reviewable.io:443/reviews/maidsafe/crust/711#-KIcYk0NKQtRhZ-s2EFD:-KIcYk0NKQtRhZ-s2EFE:1311172379) ([raw file](https://github.com/maidsafe/crust/blob/0be348b397fa053079323139760092d2d3e0dce4/src/core/state.rs#L46)):*\n> ```Rust\n>                _event_loop: &mut EventLoop<Core>,\n>                _token: Token) {}\n> ```\n\nNa it's better to keep it as what it was previously. Putting Token everywhere will cause us to re-do it in all places should there be a change. state.rs shouldn't care what it is - it depends on core so whatever core mentions about the type should be good enough. \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/maidsafe/crust/711)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ustulation"}}