{"action":"created","comment":{"url":"https://api.github.com/repos/shalurajendran/contiki/pulls/comments/90534463","pull_request_review_id":11054035,"id":90534463,"diff_hunk":"@@ -97,6 +97,9 @@ create_frame(int type, int do_create)\n    * source nor destination address, we have dest PAN ID iff compression is *set*. */\n   params.fcf.panid_compression = 0;\n \n+  /* Set IE Present bit */\n+  params.fcf.ie_list_present = packetbuf_attr(PACKETBUF_ATTR_MAC_METADATA);","path":"core/net/mac/framer-802154.c","position":5,"original_position":5,"commit_id":"7e363f624829ed84055579ad9e4aa4d8d4cc391e","original_commit_id":"225ccf253150030166fa7cf2605f55a5229a4dd5","user":{"login":"yatch","id":1230923,"avatar_url":"https://avatars.githubusercontent.com/u/1230923?v=3","gravatar_id":"","url":"https://api.github.com/users/yatch","html_url":"https://github.com/yatch","followers_url":"https://api.github.com/users/yatch/followers","following_url":"https://api.github.com/users/yatch/following{/other_user}","gists_url":"https://api.github.com/users/yatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatch/subscriptions","organizations_url":"https://api.github.com/users/yatch/orgs","repos_url":"https://api.github.com/users/yatch/repos","events_url":"https://api.github.com/users/yatch/events{/privacy}","received_events_url":"https://api.github.com/users/yatch/received_events","type":"User","site_admin":false},"body":"[off-topic] I've rewritten tsch_packet_create_eb() and tsch_packet_create_eack() with PACKETBUF_ATTR_MAC_METADATA in a different branch. It's ready for PR; but waiting for contiki-os/contiki#1914 to be merged since the test data depends on contiki-os/contiki#1914.","created_at":"2016-12-01T20:50:30Z","updated_at":"2016-12-01T20:50:30Z","html_url":"https://github.com/shalurajendran/contiki/pull/1#discussion_r90534463","pull_request_url":"https://api.github.com/repos/shalurajendran/contiki/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/shalurajendran/contiki/pulls/comments/90534463"},"html":{"href":"https://github.com/shalurajendran/contiki/pull/1#discussion_r90534463"},"pull_request":{"href":"https://api.github.com/repos/shalurajendran/contiki/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/shalurajendran/contiki/pulls/1","id":92999667,"html_url":"https://github.com/shalurajendran/contiki/pull/1","diff_url":"https://github.com/shalurajendran/contiki/pull/1.diff","patch_url":"https://github.com/shalurajendran/contiki/pull/1.patch","issue_url":"https://api.github.com/repos/shalurajendran/contiki/issues/1","number":1,"state":"open","locked":false,"title":"Refactoring 6top Implementation","user":{"login":"yatch","id":1230923,"avatar_url":"https://avatars.githubusercontent.com/u/1230923?v=3","gravatar_id":"","url":"https://api.github.com/users/yatch","html_url":"https://github.com/yatch","followers_url":"https://api.github.com/users/yatch/followers","following_url":"https://api.github.com/users/yatch/following{/other_user}","gists_url":"https://api.github.com/users/yatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatch/subscriptions","organizations_url":"https://api.github.com/users/yatch/orgs","repos_url":"https://api.github.com/users/yatch/repos","events_url":"https://api.github.com/users/yatch/events{/privacy}","received_events_url":"https://api.github.com/users/yatch/received_events","type":"User","site_admin":false},"body":"Overall, this work untangles 6P message manipulation code and the sample schedule function code which reside in a single file, sixtop.c. Two C-files are introduced: sixtop-6p.c and sixtop-sf-simple.c.\r\n\r\nsixtop-6p.c is for 6P message manipulation, building and parsing. sixtop-sf-simple.c is for the sample schedule function which is used by the example application. sixtop.c is now recreated to implement external APIs and to manage protocol states.\r\n\r\nThere are also changes on variable names and constants to follow wordings in draft-ietf-6tisch-6top-protocol. For example, `PAYLOAD_IE_SIXTOP` is renamed to `PAYLOAD_IE_IANA_IETF`. Another example is using \"cell\" instead of \"link\".\r\n\r\nSpeaking of the internet-draft, there are some fixes to comply with the specification. The Metadata field of Add Request and Delete Request is now taken into account. The value for \"Seqnum\" is maintained per neighbor.\r\n\r\nFrom the point of view of an application, its external behaviors are (hopefully) not changed. You'll see almost the same mote output as the original implementation with rpl-tsch-sixtop-z1.csc as shown below. Although, if you disable the filter of mote output, you'll see many differences in log messages.\r\n\r\n![mote-output](https://cloud.githubusercontent.com/assets/1230923/20146293/a6803ae4-a6a3-11e6-9ca6-a1291e1de35e.png)\r\n\r\nYou may notice changes of spacing in core/net/mac/tsch/tsch.c. The intention here is to revert the changes considered to have been introduced accidentally at https://github.com/shalurajendran/contiki/commit/6ac1dce0440a35686086e673d288d1bb9acd71de.","created_at":"2016-11-09T16:56:34Z","updated_at":"2016-12-01T20:50:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc26d3043047f49916308fc21c6c4d0101ad52ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shalurajendran/contiki/pulls/1/commits","review_comments_url":"https://api.github.com/repos/shalurajendran/contiki/pulls/1/comments","review_comment_url":"https://api.github.com/repos/shalurajendran/contiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shalurajendran/contiki/issues/1/comments","statuses_url":"https://api.github.com/repos/shalurajendran/contiki/statuses/7e363f624829ed84055579ad9e4aa4d8d4cc391e","head":{"label":"yatch:pr/sixtop-refactoring","ref":"pr/sixtop-refactoring","sha":"7e363f624829ed84055579ad9e4aa4d8d4cc391e","user":{"login":"yatch","id":1230923,"avatar_url":"https://avatars.githubusercontent.com/u/1230923?v=3","gravatar_id":"","url":"https://api.github.com/users/yatch","html_url":"https://github.com/yatch","followers_url":"https://api.github.com/users/yatch/followers","following_url":"https://api.github.com/users/yatch/following{/other_user}","gists_url":"https://api.github.com/users/yatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatch/subscriptions","organizations_url":"https://api.github.com/users/yatch/orgs","repos_url":"https://api.github.com/users/yatch/repos","events_url":"https://api.github.com/users/yatch/events{/privacy}","received_events_url":"https://api.github.com/users/yatch/received_events","type":"User","site_admin":false},"repo":{"id":46338132,"name":"contiki","full_name":"yatch/contiki","owner":{"login":"yatch","id":1230923,"avatar_url":"https://avatars.githubusercontent.com/u/1230923?v=3","gravatar_id":"","url":"https://api.github.com/users/yatch","html_url":"https://github.com/yatch","followers_url":"https://api.github.com/users/yatch/followers","following_url":"https://api.github.com/users/yatch/following{/other_user}","gists_url":"https://api.github.com/users/yatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatch/subscriptions","organizations_url":"https://api.github.com/users/yatch/orgs","repos_url":"https://api.github.com/users/yatch/repos","events_url":"https://api.github.com/users/yatch/events{/privacy}","received_events_url":"https://api.github.com/users/yatch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yatch/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":true,"url":"https://api.github.com/repos/yatch/contiki","forks_url":"https://api.github.com/repos/yatch/contiki/forks","keys_url":"https://api.github.com/repos/yatch/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yatch/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yatch/contiki/teams","hooks_url":"https://api.github.com/repos/yatch/contiki/hooks","issue_events_url":"https://api.github.com/repos/yatch/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/yatch/contiki/events","assignees_url":"https://api.github.com/repos/yatch/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/yatch/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/yatch/contiki/tags","blobs_url":"https://api.github.com/repos/yatch/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yatch/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yatch/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/yatch/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yatch/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/yatch/contiki/languages","stargazers_url":"https://api.github.com/repos/yatch/contiki/stargazers","contributors_url":"https://api.github.com/repos/yatch/contiki/contributors","subscribers_url":"https://api.github.com/repos/yatch/contiki/subscribers","subscription_url":"https://api.github.com/repos/yatch/contiki/subscription","commits_url":"https://api.github.com/repos/yatch/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/yatch/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/yatch/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/yatch/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/yatch/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/yatch/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yatch/contiki/merges","archive_url":"https://api.github.com/repos/yatch/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yatch/contiki/downloads","issues_url":"https://api.github.com/repos/yatch/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/yatch/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/yatch/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/yatch/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yatch/contiki/labels{/name}","releases_url":"https://api.github.com/repos/yatch/contiki/releases{/id}","deployments_url":"https://api.github.com/repos/yatch/contiki/deployments","created_at":"2015-11-17T09:54:36Z","updated_at":"2016-02-04T13:27:16Z","pushed_at":"2016-12-01T20:39:01Z","git_url":"git://github.com/yatch/contiki.git","ssh_url":"git@github.com:yatch/contiki.git","clone_url":"https://github.com/yatch/contiki.git","svn_url":"https://github.com/yatch/contiki","homepage":"http://www.contiki-os.org/","size":71092,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shalurajendran:contiki-6top","ref":"contiki-6top","sha":"da828dc20e4c11759eaf133fda22ae6364d82031","user":{"login":"shalurajendran","id":5267088,"avatar_url":"https://avatars.githubusercontent.com/u/5267088?v=3","gravatar_id":"","url":"https://api.github.com/users/shalurajendran","html_url":"https://github.com/shalurajendran","followers_url":"https://api.github.com/users/shalurajendran/followers","following_url":"https://api.github.com/users/shalurajendran/following{/other_user}","gists_url":"https://api.github.com/users/shalurajendran/gists{/gist_id}","starred_url":"https://api.github.com/users/shalurajendran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shalurajendran/subscriptions","organizations_url":"https://api.github.com/users/shalurajendran/orgs","repos_url":"https://api.github.com/users/shalurajendran/repos","events_url":"https://api.github.com/users/shalurajendran/events{/privacy}","received_events_url":"https://api.github.com/users/shalurajendran/received_events","type":"User","site_admin":false},"repo":{"id":71533965,"name":"contiki","full_name":"shalurajendran/contiki","owner":{"login":"shalurajendran","id":5267088,"avatar_url":"https://avatars.githubusercontent.com/u/5267088?v=3","gravatar_id":"","url":"https://api.github.com/users/shalurajendran","html_url":"https://github.com/shalurajendran","followers_url":"https://api.github.com/users/shalurajendran/followers","following_url":"https://api.github.com/users/shalurajendran/following{/other_user}","gists_url":"https://api.github.com/users/shalurajendran/gists{/gist_id}","starred_url":"https://api.github.com/users/shalurajendran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shalurajendran/subscriptions","organizations_url":"https://api.github.com/users/shalurajendran/orgs","repos_url":"https://api.github.com/users/shalurajendran/repos","events_url":"https://api.github.com/users/shalurajendran/events{/privacy}","received_events_url":"https://api.github.com/users/shalurajendran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shalurajendran/contiki","description":"The official git repository for Contiki, the open source OS for the Internet of Things","fork":true,"url":"https://api.github.com/repos/shalurajendran/contiki","forks_url":"https://api.github.com/repos/shalurajendran/contiki/forks","keys_url":"https://api.github.com/repos/shalurajendran/contiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shalurajendran/contiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shalurajendran/contiki/teams","hooks_url":"https://api.github.com/repos/shalurajendran/contiki/hooks","issue_events_url":"https://api.github.com/repos/shalurajendran/contiki/issues/events{/number}","events_url":"https://api.github.com/repos/shalurajendran/contiki/events","assignees_url":"https://api.github.com/repos/shalurajendran/contiki/assignees{/user}","branches_url":"https://api.github.com/repos/shalurajendran/contiki/branches{/branch}","tags_url":"https://api.github.com/repos/shalurajendran/contiki/tags","blobs_url":"https://api.github.com/repos/shalurajendran/contiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shalurajendran/contiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shalurajendran/contiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/shalurajendran/contiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shalurajendran/contiki/statuses/{sha}","languages_url":"https://api.github.com/repos/shalurajendran/contiki/languages","stargazers_url":"https://api.github.com/repos/shalurajendran/contiki/stargazers","contributors_url":"https://api.github.com/repos/shalurajendran/contiki/contributors","subscribers_url":"https://api.github.com/repos/shalurajendran/contiki/subscribers","subscription_url":"https://api.github.com/repos/shalurajendran/contiki/subscription","commits_url":"https://api.github.com/repos/shalurajendran/contiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/shalurajendran/contiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/shalurajendran/contiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/shalurajendran/contiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/shalurajendran/contiki/contents/{+path}","compare_url":"https://api.github.com/repos/shalurajendran/contiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shalurajendran/contiki/merges","archive_url":"https://api.github.com/repos/shalurajendran/contiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shalurajendran/contiki/downloads","issues_url":"https://api.github.com/repos/shalurajendran/contiki/issues{/number}","pulls_url":"https://api.github.com/repos/shalurajendran/contiki/pulls{/number}","milestones_url":"https://api.github.com/repos/shalurajendran/contiki/milestones{/number}","notifications_url":"https://api.github.com/repos/shalurajendran/contiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shalurajendran/contiki/labels{/name}","releases_url":"https://api.github.com/repos/shalurajendran/contiki/releases{/id}","deployments_url":"https://api.github.com/repos/shalurajendran/contiki/deployments","created_at":"2016-10-21T05:49:13Z","updated_at":"2016-10-21T05:49:26Z","pushed_at":"2016-12-01T20:39:02Z","git_url":"git://github.com/shalurajendran/contiki.git","ssh_url":"git@github.com:shalurajendran/contiki.git","clone_url":"https://github.com/shalurajendran/contiki.git","svn_url":"https://github.com/shalurajendran/contiki","homepage":"http://www.contiki-os.org/","size":70764,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shalurajendran/contiki/pulls/1"},"html":{"href":"https://github.com/shalurajendran/contiki/pull/1"},"issue":{"href":"https://api.github.com/repos/shalurajendran/contiki/issues/1"},"comments":{"href":"https://api.github.com/repos/shalurajendran/contiki/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/shalurajendran/contiki/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/shalurajendran/contiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shalurajendran/contiki/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/shalurajendran/contiki/statuses/7e363f624829ed84055579ad9e4aa4d8d4cc391e"}}}}
{"actor":{"display_login":"yatch"}}