{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/gate/pulls/comments/63063493","id":63063493,"diff_hunk":"@@ -81,13 +81,35 @@ spring:\n       SORT_PROPERTIES_ALPHABETICALLY: true\n     serialization:\n       ORDER_MAP_ENTRIES_BY_KEYS: true\n-#  oauth2:\n-#      client:\n-#        clientId:\n-#        clientSecret:\n-#        accessTokenUri:\n-#        userAuthorizationUri:\n-#        scope:\n-#          - email\n-#      resource:\n-#        userInfoUri:\n+\n+---\n+\n+spring:\n+  profiles: googleOAuth\n+  oauth2:\n+    client:\n+      # Override these values in your own gate-googleOAuth.yml file","path":"gate-web/config/gate.yml","position":21,"original_position":21,"commit_id":"4be5ca16eb86ec985495e28067dae3d854a253b7","original_commit_id":"4be5ca16eb86ec985495e28067dae3d854a253b7","user":{"login":"cfieber","id":301292,"avatar_url":"https://avatars.githubusercontent.com/u/301292?v=3","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"body":"overrides can be in their spinnaker-local.yml file (probably better guidance since that is what we generally are telling people to edit)","created_at":"2016-05-12T17:37:58Z","updated_at":"2016-05-12T17:37:58Z","html_url":"https://github.com/spinnaker/gate/pull/215#discussion_r63063493","pull_request_url":"https://api.github.com/repos/spinnaker/gate/pulls/215","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/gate/pulls/comments/63063493"},"html":{"href":"https://github.com/spinnaker/gate/pull/215#discussion_r63063493"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/gate/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/gate/pulls/215","id":69873531,"html_url":"https://github.com/spinnaker/gate/pull/215","diff_url":"https://github.com/spinnaker/gate/pull/215.diff","patch_url":"https://github.com/spinnaker/gate/pull/215.patch","issue_url":"https://api.github.com/repos/spinnaker/gate/issues/215","number":215,"state":"open","locked":false,"title":"Adds spring profile templates for Google and Azure OAuth providers.","user":{"login":"ttomsu","id":13141550,"avatar_url":"https://avatars.githubusercontent.com/u/13141550?v=3","gravatar_id":"","url":"https://api.github.com/users/ttomsu","html_url":"https://github.com/ttomsu","followers_url":"https://api.github.com/users/ttomsu/followers","following_url":"https://api.github.com/users/ttomsu/following{/other_user}","gists_url":"https://api.github.com/users/ttomsu/gists{/gist_id}","starred_url":"https://api.github.com/users/ttomsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttomsu/subscriptions","organizations_url":"https://api.github.com/users/ttomsu/orgs","repos_url":"https://api.github.com/users/ttomsu/repos","events_url":"https://api.github.com/users/ttomsu/events{/privacy}","received_events_url":"https://api.github.com/users/ttomsu/received_events","type":"User","site_admin":false},"body":"This PR adds a template with some known values for Google and Azure oauth providers. Users can create `gate-googleOAuth.yml` or `gate-azureOAuth.yml` files in their `~/.spinnaker/` config directories that simply specify the clientID and client secret, like so:\r\n\r\n```\r\nspring:\r\n  oauth2:\r\n    client:\r\n      clientId: my-client-id\r\n      clientSecret: my-client-secret\r\n```\r\nTo pick up this profile at runtime, invoke  \r\n\r\n```\r\n$ ./gradlew -Dspring.profiles.active=\"local,googleOAuth\"\r\n```\r\n\r\n@rguthriemsft @scotmoor @spinnaker/google-reviewers \r\n\r\n\r\n","created_at":"2016-05-12T17:12:21Z","updated_at":"2016-05-12T17:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51c88b2df5ae8535cd750659996d44b8f2ce35a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/gate/pulls/215/commits","review_comments_url":"https://api.github.com/repos/spinnaker/gate/pulls/215/comments","review_comment_url":"https://api.github.com/repos/spinnaker/gate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/gate/issues/215/comments","statuses_url":"https://api.github.com/repos/spinnaker/gate/statuses/4be5ca16eb86ec985495e28067dae3d854a253b7","head":{"label":"ttomsu:google-oauth-profiles","ref":"google-oauth-profiles","sha":"4be5ca16eb86ec985495e28067dae3d854a253b7","user":{"login":"ttomsu","id":13141550,"avatar_url":"https://avatars.githubusercontent.com/u/13141550?v=3","gravatar_id":"","url":"https://api.github.com/users/ttomsu","html_url":"https://github.com/ttomsu","followers_url":"https://api.github.com/users/ttomsu/followers","following_url":"https://api.github.com/users/ttomsu/following{/other_user}","gists_url":"https://api.github.com/users/ttomsu/gists{/gist_id}","starred_url":"https://api.github.com/users/ttomsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttomsu/subscriptions","organizations_url":"https://api.github.com/users/ttomsu/orgs","repos_url":"https://api.github.com/users/ttomsu/repos","events_url":"https://api.github.com/users/ttomsu/events{/privacy}","received_events_url":"https://api.github.com/users/ttomsu/received_events","type":"User","site_admin":false},"repo":{"id":46297152,"name":"gate","full_name":"ttomsu/gate","owner":{"login":"ttomsu","id":13141550,"avatar_url":"https://avatars.githubusercontent.com/u/13141550?v=3","gravatar_id":"","url":"https://api.github.com/users/ttomsu","html_url":"https://github.com/ttomsu","followers_url":"https://api.github.com/users/ttomsu/followers","following_url":"https://api.github.com/users/ttomsu/following{/other_user}","gists_url":"https://api.github.com/users/ttomsu/gists{/gist_id}","starred_url":"https://api.github.com/users/ttomsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttomsu/subscriptions","organizations_url":"https://api.github.com/users/ttomsu/orgs","repos_url":"https://api.github.com/users/ttomsu/repos","events_url":"https://api.github.com/users/ttomsu/events{/privacy}","received_events_url":"https://api.github.com/users/ttomsu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttomsu/gate","description":"Spinnaker API Gateway","fork":true,"url":"https://api.github.com/repos/ttomsu/gate","forks_url":"https://api.github.com/repos/ttomsu/gate/forks","keys_url":"https://api.github.com/repos/ttomsu/gate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttomsu/gate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttomsu/gate/teams","hooks_url":"https://api.github.com/repos/ttomsu/gate/hooks","issue_events_url":"https://api.github.com/repos/ttomsu/gate/issues/events{/number}","events_url":"https://api.github.com/repos/ttomsu/gate/events","assignees_url":"https://api.github.com/repos/ttomsu/gate/assignees{/user}","branches_url":"https://api.github.com/repos/ttomsu/gate/branches{/branch}","tags_url":"https://api.github.com/repos/ttomsu/gate/tags","blobs_url":"https://api.github.com/repos/ttomsu/gate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttomsu/gate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttomsu/gate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttomsu/gate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttomsu/gate/statuses/{sha}","languages_url":"https://api.github.com/repos/ttomsu/gate/languages","stargazers_url":"https://api.github.com/repos/ttomsu/gate/stargazers","contributors_url":"https://api.github.com/repos/ttomsu/gate/contributors","subscribers_url":"https://api.github.com/repos/ttomsu/gate/subscribers","subscription_url":"https://api.github.com/repos/ttomsu/gate/subscription","commits_url":"https://api.github.com/repos/ttomsu/gate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttomsu/gate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttomsu/gate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttomsu/gate/issues/comments{/number}","contents_url":"https://api.github.com/repos/ttomsu/gate/contents/{+path}","compare_url":"https://api.github.com/repos/ttomsu/gate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttomsu/gate/merges","archive_url":"https://api.github.com/repos/ttomsu/gate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttomsu/gate/downloads","issues_url":"https://api.github.com/repos/ttomsu/gate/issues{/number}","pulls_url":"https://api.github.com/repos/ttomsu/gate/pulls{/number}","milestones_url":"https://api.github.com/repos/ttomsu/gate/milestones{/number}","notifications_url":"https://api.github.com/repos/ttomsu/gate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttomsu/gate/labels{/name}","releases_url":"https://api.github.com/repos/ttomsu/gate/releases{/id}","deployments_url":"https://api.github.com/repos/ttomsu/gate/deployments","created_at":"2015-11-16T19:30:47Z","updated_at":"2016-02-02T15:55:14Z","pushed_at":"2016-05-12T17:07:23Z","git_url":"git://github.com/ttomsu/gate.git","ssh_url":"git@github.com:ttomsu/gate.git","clone_url":"https://github.com/ttomsu/gate.git","svn_url":"https://github.com/ttomsu/gate","homepage":null,"size":1133,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:google-oauth","ref":"google-oauth","sha":"754af653a584650cdba99350c6a707b48dd82a13","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":22351349,"name":"gate","full_name":"spinnaker/gate","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/gate","description":"Spinnaker API Gateway","fork":false,"url":"https://api.github.com/repos/spinnaker/gate","forks_url":"https://api.github.com/repos/spinnaker/gate/forks","keys_url":"https://api.github.com/repos/spinnaker/gate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/gate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/gate/teams","hooks_url":"https://api.github.com/repos/spinnaker/gate/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/gate/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/gate/events","assignees_url":"https://api.github.com/repos/spinnaker/gate/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/gate/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/gate/tags","blobs_url":"https://api.github.com/repos/spinnaker/gate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/gate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/gate/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/gate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/gate/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/gate/languages","stargazers_url":"https://api.github.com/repos/spinnaker/gate/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/gate/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/gate/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/gate/subscription","commits_url":"https://api.github.com/repos/spinnaker/gate/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/gate/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/gate/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/gate/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/gate/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/gate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/gate/merges","archive_url":"https://api.github.com/repos/spinnaker/gate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/gate/downloads","issues_url":"https://api.github.com/repos/spinnaker/gate/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/gate/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/gate/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/gate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/gate/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/gate/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/gate/deployments","created_at":"2014-07-28T17:27:56Z","updated_at":"2016-05-03T15:33:50Z","pushed_at":"2016-05-12T17:12:21Z","git_url":"git://github.com/spinnaker/gate.git","ssh_url":"git@github.com:spinnaker/gate.git","clone_url":"https://github.com/spinnaker/gate.git","svn_url":"https://github.com/spinnaker/gate","homepage":null,"size":1776,"stargazers_count":13,"watchers_count":13,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":17,"forks":37,"open_issues":17,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/gate/pulls/215"},"html":{"href":"https://github.com/spinnaker/gate/pull/215"},"issue":{"href":"https://api.github.com/repos/spinnaker/gate/issues/215"},"comments":{"href":"https://api.github.com/repos/spinnaker/gate/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/gate/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/gate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/gate/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/gate/statuses/4be5ca16eb86ec985495e28067dae3d854a253b7"}}}}