{"action":"created","issue":{"url":"https://api.github.com/repos/nasa/openmctweb/issues/651","repository_url":"https://api.github.com/repos/nasa/openmctweb","labels_url":"https://api.github.com/repos/nasa/openmctweb/issues/651/labels{/name}","comments_url":"https://api.github.com/repos/nasa/openmctweb/issues/651/comments","events_url":"https://api.github.com/repos/nasa/openmctweb/issues/651/events","html_url":"https://github.com/nasa/openmctweb/pull/651","id":131507116,"number":651,"title":"[Plots] #638 New plot display options","user":{"login":"akhenry","id":4215777,"avatar_url":"https://avatars.githubusercontent.com/u/4215777?v=3","gravatar_id":"","url":"https://api.github.com/users/akhenry","html_url":"https://github.com/akhenry","followers_url":"https://api.github.com/users/akhenry/followers","following_url":"https://api.github.com/users/akhenry/following{/other_user}","gists_url":"https://api.github.com/users/akhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/akhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhenry/subscriptions","organizations_url":"https://api.github.com/users/akhenry/orgs","repos_url":"https://api.github.com/users/akhenry/repos","events_url":"https://api.github.com/users/akhenry/events{/privacy}","received_events_url":"https://api.github.com/users/akhenry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"larkin","id":226503,"avatar_url":"https://avatars.githubusercontent.com/u/226503?v=3","gravatar_id":"","url":"https://api.github.com/users/larkin","html_url":"https://github.com/larkin","followers_url":"https://api.github.com/users/larkin/followers","following_url":"https://api.github.com/users/larkin/following{/other_user}","gists_url":"https://api.github.com/users/larkin/gists{/gist_id}","starred_url":"https://api.github.com/users/larkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larkin/subscriptions","organizations_url":"https://api.github.com/users/larkin/orgs","repos_url":"https://api.github.com/users/larkin/repos","events_url":"https://api.github.com/users/larkin/events{/privacy}","received_events_url":"https://api.github.com/users/larkin/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nasa/openmctweb/milestones/8","html_url":"https://github.com/nasa/openmctweb/milestones/Ellison","labels_url":"https://api.github.com/repos/nasa/openmctweb/milestones/8/labels","id":1578343,"number":8,"title":"Ellison","description":"","creator":{"login":"akhenry","id":4215777,"avatar_url":"https://avatars.githubusercontent.com/u/4215777?v=3","gravatar_id":"","url":"https://api.github.com/users/akhenry","html_url":"https://github.com/akhenry","followers_url":"https://api.github.com/users/akhenry/followers","following_url":"https://api.github.com/users/akhenry/following{/other_user}","gists_url":"https://api.github.com/users/akhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/akhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhenry/subscriptions","organizations_url":"https://api.github.com/users/akhenry/orgs","repos_url":"https://api.github.com/users/akhenry/repos","events_url":"https://api.github.com/users/akhenry/events{/privacy}","received_events_url":"https://api.github.com/users/akhenry/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":18,"state":"open","created_at":"2016-02-11T19:12:49Z","updated_at":"2016-02-23T20:28:04Z","due_on":"2016-03-04T08:00:00Z","closed_at":null},"comments":14,"created_at":"2016-02-04T23:38:39Z","updated_at":"2016-02-23T23:27:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nasa/openmctweb/pulls/651","html_url":"https://github.com/nasa/openmctweb/pull/651","diff_url":"https://github.com/nasa/openmctweb/pull/651.diff","patch_url":"https://github.com/nasa/openmctweb/pull/651.patch"},"body":"Opening a new Pull Request for the merge into master. Suspect there will be a lot of comments to collect and the other PR is already quite long.\r\n\r\nNote that this relates to issue #638 and has a previous PR associated with it at #645.\r\n\r\n## Note:\r\nThere are some minor style changes that need to be made before this is committed, so ~~I have not included an author's checklist yet. Should not prevent code review from taking place though~~\r\n@charlesh88 If you haven't started on [this](https://github.com/nasa/openmctweb/pull/645#issuecomment-180021486) I could have a crack at it anyway and have you review it as part of this PR?\r\n\r\n## Changes\r\n* Have defined a new attribute of Types called \"regions\". Regions are sections of the browse and edit screens for an object that, while fixed in location, have content that is completely customizable on a per-type basis. Regions are represented in code by a new Region class. Within Regions are RegionParts. A Region can have any number of RegionParts defined. The layout of both Regions and RegionParts are defined by representations. Whether a region part is visible within a region can depend on object state, and is determined by a policy of category region.\r\n\r\n* Defined a new TypeRegionDecorator that defines standard regions for objects to avoid having to add region sections to all type definitions. Only have to explicitly define regions if a type has special requirements, such as the new plot display options.\r\n\r\n* Defined a new EditableRegionPolicy which provides a convenience method for determining whether a region part should be visible in edit/browse mode based on a modes attribute in RegionPart definition.\r\n\r\n* Modified the browse and edit screens to define an Inspector region. Currently this is the only region defined, however I will also defined 'object view' and 'elements' regions. Within the object inspector is the standard properties and location sections.\r\n\r\n* Added a 'plot options' region part. Currently this is enabled on the Telemetry Plot type contained in the PlotOptions bundle (__not__ included by default).\r\n\r\n* Made some modifications to mct-form to support listening for changes. Instead of using two-way data binding, I am listening for changes and triggering a mutation event on the domain object. This is so that there are discrete events that can be listened to from the plot side, rather than depending on Angular's data binding. Happy to discuss other options for this though.\r\n"},"comment":{"url":"https://api.github.com/repos/nasa/openmctweb/issues/comments/187963253","html_url":"https://github.com/nasa/openmctweb/pull/651#issuecomment-187963253","issue_url":"https://api.github.com/repos/nasa/openmctweb/issues/651","id":187963253,"user":{"login":"akhenry","id":4215777,"avatar_url":"https://avatars.githubusercontent.com/u/4215777?v=3","gravatar_id":"","url":"https://api.github.com/users/akhenry","html_url":"https://github.com/akhenry","followers_url":"https://api.github.com/users/akhenry/followers","following_url":"https://api.github.com/users/akhenry/following{/other_user}","gists_url":"https://api.github.com/users/akhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/akhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhenry/subscriptions","organizations_url":"https://api.github.com/users/akhenry/orgs","repos_url":"https://api.github.com/users/akhenry/repos","events_url":"https://api.github.com/users/akhenry/events{/privacy}","received_events_url":"https://api.github.com/users/akhenry/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T23:27:40Z","updated_at":"2016-02-23T23:27:40Z","body":"@larkin fixed the failing tests, all yours"}}