{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/88842662","pull_request_review_id":9402232,"id":88842662,"diff_hunk":"@@ -458,6 +464,12 @@ def run_command(command):\n scheduler_heartbeat_sec = 5\n authenticate = true\n max_threads = 2\n+\n+# Turn off scheduler backfills by setting this to false.\n+# Default behavior is unchanged\n+# Command Line Backfills still work, but the scheduler\n+# will not do backfills if this is false.\n+backfill_by_default = true","path":"airflow/configuration.py","position":8,"original_position":22,"commit_id":"6c87204421b97e8ecc6bc3ff92701e779dcb3c35","original_commit_id":"6c87204421b97e8ecc6bc3ff92701e779dcb3c35","user":{"login":"btallman","id":173950,"avatar_url":"https://avatars.githubusercontent.com/u/173950?v=3","gravatar_id":"","url":"https://api.github.com/users/btallman","html_url":"https://github.com/btallman","followers_url":"https://api.github.com/users/btallman/followers","following_url":"https://api.github.com/users/btallman/following{/other_user}","gists_url":"https://api.github.com/users/btallman/gists{/gist_id}","starred_url":"https://api.github.com/users/btallman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btallman/subscriptions","organizations_url":"https://api.github.com/users/btallman/orgs","repos_url":"https://api.github.com/users/btallman/repos","events_url":"https://api.github.com/users/btallman/events{/privacy}","received_events_url":"https://api.github.com/users/btallman/received_events","type":"User","site_admin":false},"body":"Yes, that is what it looks like to me as well, first default, then test. However, due to the day job, I didn't track that one down.\r\n\r\nI had the same issue with the config.getboolean(), and decided to leave it for now and circle back once our showstoppers where fixed. In addition, I wanted to keep this PR clean and not involve extraneous fixes.","created_at":"2016-11-21T07:48:53Z","updated_at":"2016-11-21T07:48:53Z","html_url":"https://github.com/apache/incubator-airflow/pull/1830#discussion_r88842662","pull_request_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments/88842662"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/1830#discussion_r88842662"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830","id":88534901,"html_url":"https://github.com/apache/incubator-airflow/pull/1830","diff_url":"https://github.com/apache/incubator-airflow/pull/1830.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/1830.patch","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1830","number":1830,"state":"open","locked":false,"title":"[AIRFLOW-558] Add Support for dag.backfill=(True|False) Option","user":{"login":"btallman","id":173950,"avatar_url":"https://avatars.githubusercontent.com/u/173950?v=3","gravatar_id":"","url":"https://api.github.com/users/btallman","html_url":"https://github.com/btallman","followers_url":"https://api.github.com/users/btallman/followers","following_url":"https://api.github.com/users/btallman/following{/other_user}","gists_url":"https://api.github.com/users/btallman/gists{/gist_id}","starred_url":"https://api.github.com/users/btallman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btallman/subscriptions","organizations_url":"https://api.github.com/users/btallman/orgs","repos_url":"https://api.github.com/users/btallman/repos","events_url":"https://api.github.com/users/btallman/events{/privacy}","received_events_url":"https://api.github.com/users/btallman/received_events","type":"User","site_admin":false},"body":"Dear Airflow Maintainers,\n\nPlease accept this PR that addresses the following issues:\n- \\* https://issues.apache.org/jira/browse/AIRFLOW-558 *\n\nAdd Support for dag.backfill=(True|False) Option\n\nAdded a dag.backfill option and modified the scheduler to look at\nthe value when scheduling DagRuns (by moving dag.start_date up to\ndag.previous_schedule), and added a config option scheduler.backfill_by_default (defaults to True)\nthat allows users to set this to False for all dags modifying the existing DAGs\n\nIn addition, we added a test to jobs.py (test_dag_backfill_option)\n","created_at":"2016-10-08T05:43:32Z","updated_at":"2016-11-21T07:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"873cfde4603274f77ab12e1507a8705866dcd3ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1830/comments","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/6c87204421b97e8ecc6bc3ff92701e779dcb3c35","head":{"label":"btallman:NoBackfill_clean_feature","ref":"NoBackfill_clean_feature","sha":"6c87204421b97e8ecc6bc3ff92701e779dcb3c35","user":{"login":"btallman","id":173950,"avatar_url":"https://avatars.githubusercontent.com/u/173950?v=3","gravatar_id":"","url":"https://api.github.com/users/btallman","html_url":"https://github.com/btallman","followers_url":"https://api.github.com/users/btallman/followers","following_url":"https://api.github.com/users/btallman/following{/other_user}","gists_url":"https://api.github.com/users/btallman/gists{/gist_id}","starred_url":"https://api.github.com/users/btallman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btallman/subscriptions","organizations_url":"https://api.github.com/users/btallman/orgs","repos_url":"https://api.github.com/users/btallman/repos","events_url":"https://api.github.com/users/btallman/events{/privacy}","received_events_url":"https://api.github.com/users/btallman/received_events","type":"User","site_admin":false},"repo":{"id":66884999,"name":"incubator-airflow","full_name":"btallman/incubator-airflow","owner":{"login":"btallman","id":173950,"avatar_url":"https://avatars.githubusercontent.com/u/173950?v=3","gravatar_id":"","url":"https://api.github.com/users/btallman","html_url":"https://github.com/btallman","followers_url":"https://api.github.com/users/btallman/followers","following_url":"https://api.github.com/users/btallman/following{/other_user}","gists_url":"https://api.github.com/users/btallman/gists{/gist_id}","starred_url":"https://api.github.com/users/btallman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btallman/subscriptions","organizations_url":"https://api.github.com/users/btallman/orgs","repos_url":"https://api.github.com/users/btallman/repos","events_url":"https://api.github.com/users/btallman/events{/privacy}","received_events_url":"https://api.github.com/users/btallman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/btallman/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/btallman/incubator-airflow","forks_url":"https://api.github.com/repos/btallman/incubator-airflow/forks","keys_url":"https://api.github.com/repos/btallman/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btallman/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btallman/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/btallman/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/btallman/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/btallman/incubator-airflow/events","assignees_url":"https://api.github.com/repos/btallman/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/btallman/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/btallman/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/btallman/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btallman/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btallman/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/btallman/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btallman/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/btallman/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/btallman/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/btallman/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/btallman/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/btallman/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/btallman/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/btallman/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/btallman/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/btallman/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/btallman/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/btallman/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btallman/incubator-airflow/merges","archive_url":"https://api.github.com/repos/btallman/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btallman/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/btallman/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/btallman/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/btallman/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/btallman/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btallman/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/btallman/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/btallman/incubator-airflow/deployments","created_at":"2016-08-29T22:21:39Z","updated_at":"2016-08-29T22:21:41Z","pushed_at":"2016-11-21T07:27:53Z","git_url":"git://github.com/btallman/incubator-airflow.git","ssh_url":"git@github.com:btallman/incubator-airflow.git","clone_url":"https://github.com/btallman/incubator-airflow.git","svn_url":"https://github.com/btallman/incubator-airflow","homepage":"","size":11054,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c6dd4d4578918364da1cd3d5655a8d41a65871b5","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"name":"incubator-airflow","full_name":"apache/incubator-airflow","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-airflow","description":"Apache Airflow (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-airflow","forks_url":"https://api.github.com/repos/apache/incubator-airflow/forks","keys_url":"https://api.github.com/repos/apache/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/apache/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-airflow/events","assignees_url":"https://api.github.com/repos/apache/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/apache/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/apache/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-airflow/merges","archive_url":"https://api.github.com/repos/apache/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/apache/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2016-11-21T07:04:31Z","pushed_at":"2016-11-21T07:27:54Z","git_url":"git://github.com/apache/incubator-airflow.git","ssh_url":"git@github.com:apache/incubator-airflow.git","clone_url":"https://github.com/apache/incubator-airflow.git","svn_url":"https://github.com/apache/incubator-airflow","homepage":"","size":15302,"stargazers_count":3849,"watchers_count":3849,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":940,"mirror_url":null,"open_issues_count":146,"forks":940,"open_issues":146,"watchers":3849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830"},"html":{"href":"https://github.com/apache/incubator-airflow/pull/1830"},"issue":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/1830"},"comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/issues/1830/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-airflow/pulls/1830/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-airflow/statuses/6c87204421b97e8ecc6bc3ff92701e779dcb3c35"}}}}
{"actor":{"display_login":"btallman"}}