{"action":"created","issue":{"url":"https://api.github.com/repos/rollup/rollup/issues/1056","repository_url":"https://api.github.com/repos/rollup/rollup","labels_url":"https://api.github.com/repos/rollup/rollup/issues/1056/labels{/name}","comments_url":"https://api.github.com/repos/rollup/rollup/issues/1056/comments","events_url":"https://api.github.com/repos/rollup/rollup/issues/1056/events","html_url":"https://github.com/rollup/rollup/pull/1056","id":183225449,"number":1056,"title":"Remove sourceMappingURL only in comments","user":{"login":"btd","id":334851,"avatar_url":"https://avatars.githubusercontent.com/u/334851?v=3","gravatar_id":"","url":"https://api.github.com/users/btd","html_url":"https://github.com/btd","followers_url":"https://api.github.com/users/btd/followers","following_url":"https://api.github.com/users/btd/following{/other_user}","gists_url":"https://api.github.com/users/btd/gists{/gist_id}","starred_url":"https://api.github.com/users/btd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btd/subscriptions","organizations_url":"https://api.github.com/users/btd/orgs","repos_url":"https://api.github.com/users/btd/repos","events_url":"https://api.github.com/users/btd/events{/privacy}","received_events_url":"https://api.github.com/users/btd/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-15T18:39:24Z","updated_at":"2016-12-22T08:54:36Z","closed_at":"2016-12-21T15:31:15Z","pull_request":{"url":"https://api.github.com/repos/rollup/rollup/pulls/1056","html_url":"https://github.com/rollup/rollup/pull/1056","diff_url":"https://github.com/rollup/rollup/pull/1056.diff","patch_url":"https://github.com/rollup/rollup/pull/1056.patch"},"body":"I have problem that current code removes `//# sourceMappingURL=....` even from string (because of regexp search). I noticed in code there are 2 places where remove happen - in Module and Bundle classes.\r\n\r\nWith Module idea is very clear - we iterate by comments only and clean sourcemaps. But with Bundle i did not get original idea why it is need, and it is also breaking my usecase (i am inserting SM with plugin.intro string matching this regexp - point there it is a string not comment). Also there is no test for this part of code. \r\n\r\nCould you please point me how should i better rework this part? or i can remove it at all? (we can reparse end bundle to remove comments, but i do not see why plugin could not do anything they want).\r\n\r\nAlso it looks it is more correct to remove comment body but rest //. For example we had `//# sourceMappingURL=...` and rest only `//`. Is it right?\r\n\r\nThanks.\r\n"},"comment":{"url":"https://api.github.com/repos/rollup/rollup/issues/comments/268750435","html_url":"https://github.com/rollup/rollup/pull/1056#issuecomment-268750435","issue_url":"https://api.github.com/repos/rollup/rollup/issues/1056","id":268750435,"user":{"login":"IvanSanchez","id":1125786,"avatar_url":"https://avatars.githubusercontent.com/u/1125786?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanSanchez","html_url":"https://github.com/IvanSanchez","followers_url":"https://api.github.com/users/IvanSanchez/followers","following_url":"https://api.github.com/users/IvanSanchez/following{/other_user}","gists_url":"https://api.github.com/users/IvanSanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanSanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanSanchez/subscriptions","organizations_url":"https://api.github.com/users/IvanSanchez/orgs","repos_url":"https://api.github.com/users/IvanSanchez/repos","events_url":"https://api.github.com/users/IvanSanchez/events{/privacy}","received_events_url":"https://api.github.com/users/IvanSanchez/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T08:54:36Z","updated_at":"2016-12-22T08:54:36Z","body":"I wonder if whitespace should be allowed between the start of the line and the sourcemappingURL comment?"}}
{"actor":{"display_login":"IvanSanchez"}}