{"action":"created","issue":{"url":"https://api.github.com/repos/sqreen/tor-test/issues/2","repository_url":"https://api.github.com/repos/sqreen/tor-test","labels_url":"https://api.github.com/repos/sqreen/tor-test/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/sqreen/tor-test/issues/2/comments","events_url":"https://api.github.com/repos/sqreen/tor-test/issues/2/events","html_url":"https://github.com/sqreen/tor-test/pull/2","id":195301903,"number":2,"title":"Datefeat","user":{"login":"vouill","id":9969161,"avatar_url":"https://avatars.githubusercontent.com/u/9969161?v=3","gravatar_id":"","url":"https://api.github.com/users/vouill","html_url":"https://github.com/vouill","followers_url":"https://api.github.com/users/vouill/followers","following_url":"https://api.github.com/users/vouill/following{/other_user}","gists_url":"https://api.github.com/users/vouill/gists{/gist_id}","starred_url":"https://api.github.com/users/vouill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vouill/subscriptions","organizations_url":"https://api.github.com/users/vouill/orgs","repos_url":"https://api.github.com/users/vouill/repos","events_url":"https://api.github.com/users/vouill/events{/privacy}","received_events_url":"https://api.github.com/users/vouill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-13T16:33:27Z","updated_at":"2016-12-14T09:12:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sqreen/tor-test/pulls/2","html_url":"https://github.com/sqreen/tor-test/pull/2","diff_url":"https://github.com/sqreen/tor-test/pull/2.diff","patch_url":"https://github.com/sqreen/tor-test/pull/2.patch"},"body":"Hello Sqreen,\r\nI was lurking in your repos and found this one.\r\n\r\nUnless i missed something, if a new tor exit node appears, and the server using this lib haven't been restarted, the connections coming from it wont be refused, unless a `force` argument is given.\r\n\r\nI was wondering if it could be a good idea to use the date you send at each API responses to make the library self aware of how long since the last IP store have been updated. \r\nIn this PR i have made  a simple test, if the latest store refresh is 1 month old max.\r\n\r\nSince i am not sure of the validity of this issue, i haven't adapted the test files. If you think its a good idea i can adapt them.\r\n\r\nVouill"},"comment":{"url":"https://api.github.com/repos/sqreen/tor-test/issues/comments/266982057","html_url":"https://github.com/sqreen/tor-test/pull/2#issuecomment-266982057","issue_url":"https://api.github.com/repos/sqreen/tor-test/issues/2","id":266982057,"user":{"login":"vdeturckheim","id":7135896,"avatar_url":"https://avatars.githubusercontent.com/u/7135896?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeturckheim","html_url":"https://github.com/vdeturckheim","followers_url":"https://api.github.com/users/vdeturckheim/followers","following_url":"https://api.github.com/users/vdeturckheim/following{/other_user}","gists_url":"https://api.github.com/users/vdeturckheim/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeturckheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeturckheim/subscriptions","organizations_url":"https://api.github.com/users/vdeturckheim/orgs","repos_url":"https://api.github.com/users/vdeturckheim/repos","events_url":"https://api.github.com/users/vdeturckheim/events{/privacy}","received_events_url":"https://api.github.com/users/vdeturckheim/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T09:12:16Z","updated_at":"2016-12-14T09:12:16Z","body":"@vouill thanks a lot for contributing!\r\nIt looks pretty fair as a change. However, I think it would be better as an optional feature:\r\n* adding a method named for instance `refreshStoreOlderThan` that would set the max age for the cache.\r\n* by default there would be no update due to an old cache\r\n\r\nWhat do you think about that ? :)"}}
{"actor":{"display_login":"vdeturckheim"}}