{"action":"created","comment":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/64627635","id":64627635,"diff_hunk":"@@ -62,6 +62,10 @@ def ensure_browser_open():\n \n     \"\"\"\n     try:\n+        if browser_name:","path":"utils/browser.py","position":13,"original_position":13,"commit_id":"d059761f3f70bd3ee278a9831236b33027b29503","original_commit_id":"d059761f3f70bd3ee278a9831236b33027b29503","user":{"login":"psav","id":5639745,"avatar_url":"https://avatars.githubusercontent.com/u/5639745?v=3","gravatar_id":"","url":"https://api.github.com/users/psav","html_url":"https://github.com/psav","followers_url":"https://api.github.com/users/psav/followers","following_url":"https://api.github.com/users/psav/following{/other_user}","gists_url":"https://api.github.com/users/psav/gists{/gist_id}","starred_url":"https://api.github.com/users/psav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psav/subscriptions","organizations_url":"https://api.github.com/users/psav/orgs","repos_url":"https://api.github.com/users/psav/repos","events_url":"https://api.github.com/users/psav/events{/privacy}","received_events_url":"https://api.github.com/users/psav/received_events","type":"User","site_admin":false},"body":"As this won't have access to the browser_name before as above, we can always read the conf here, just like we do in ```start()```. I guess we can't delegate the quitting to ```start```....that actually is cleaner as start() is already called in this function, but I guess we need to intercept as browser().current_url would still return something even if it was the wrong browser.","created_at":"2016-05-25T18:32:58Z","updated_at":"2016-05-25T18:32:58Z","html_url":"https://github.com/RedHatQE/cfme_tests/pull/2964#discussion_r64627635","pull_request_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964","_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/64627635"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/2964#discussion_r64627635"},"pull_request":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964"}}},"pull_request":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964","id":69745610,"html_url":"https://github.com/RedHatQE/cfme_tests/pull/2964","diff_url":"https://github.com/RedHatQE/cfme_tests/pull/2964.diff","patch_url":"https://github.com/RedHatQE/cfme_tests/pull/2964.patch","issue_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2964","number":2964,"state":"open","locked":false,"title":"[WIP] Parameterize the browser for cfme UI tests.","user":{"login":"amavinag","id":16927814,"avatar_url":"https://avatars.githubusercontent.com/u/16927814?v=3","gravatar_id":"","url":"https://api.github.com/users/amavinag","html_url":"https://github.com/amavinag","followers_url":"https://api.github.com/users/amavinag/followers","following_url":"https://api.github.com/users/amavinag/following{/other_user}","gists_url":"https://api.github.com/users/amavinag/gists{/gist_id}","starred_url":"https://api.github.com/users/amavinag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amavinag/subscriptions","organizations_url":"https://api.github.com/users/amavinag/orgs","repos_url":"https://api.github.com/users/amavinag/repos","events_url":"https://api.github.com/users/amavinag/events{/privacy}","received_events_url":"https://api.github.com/users/amavinag/received_events","type":"User","site_admin":false},"body":"  * parameterize the ui tests, browser paremeters can be\r\n    specified ad test level.\r\n  * updated utils/browser, markers/sauce, test_login for test runs.","created_at":"2016-05-11T21:28:56Z","updated_at":"2016-05-25T18:32:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ca970e33f758d225304e3cc23a2bd67b594d886","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964/commits","review_comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964/comments","review_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2964/comments","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/d059761f3f70bd3ee278a9831236b33027b29503","head":{"label":"amavinag:sauce_ui_changes","ref":"sauce_ui_changes","sha":"d059761f3f70bd3ee278a9831236b33027b29503","user":{"login":"amavinag","id":16927814,"avatar_url":"https://avatars.githubusercontent.com/u/16927814?v=3","gravatar_id":"","url":"https://api.github.com/users/amavinag","html_url":"https://github.com/amavinag","followers_url":"https://api.github.com/users/amavinag/followers","following_url":"https://api.github.com/users/amavinag/following{/other_user}","gists_url":"https://api.github.com/users/amavinag/gists{/gist_id}","starred_url":"https://api.github.com/users/amavinag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amavinag/subscriptions","organizations_url":"https://api.github.com/users/amavinag/orgs","repos_url":"https://api.github.com/users/amavinag/repos","events_url":"https://api.github.com/users/amavinag/events{/privacy}","received_events_url":"https://api.github.com/users/amavinag/received_events","type":"User","site_admin":false},"repo":{"id":50542119,"name":"cfme_tests","full_name":"amavinag/cfme_tests","owner":{"login":"amavinag","id":16927814,"avatar_url":"https://avatars.githubusercontent.com/u/16927814?v=3","gravatar_id":"","url":"https://api.github.com/users/amavinag","html_url":"https://github.com/amavinag","followers_url":"https://api.github.com/users/amavinag/followers","following_url":"https://api.github.com/users/amavinag/following{/other_user}","gists_url":"https://api.github.com/users/amavinag/gists{/gist_id}","starred_url":"https://api.github.com/users/amavinag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amavinag/subscriptions","organizations_url":"https://api.github.com/users/amavinag/orgs","repos_url":"https://api.github.com/users/amavinag/repos","events_url":"https://api.github.com/users/amavinag/events{/privacy}","received_events_url":"https://api.github.com/users/amavinag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amavinag/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/amavinag/cfme_tests","forks_url":"https://api.github.com/repos/amavinag/cfme_tests/forks","keys_url":"https://api.github.com/repos/amavinag/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amavinag/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amavinag/cfme_tests/teams","hooks_url":"https://api.github.com/repos/amavinag/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/amavinag/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/amavinag/cfme_tests/events","assignees_url":"https://api.github.com/repos/amavinag/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/amavinag/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/amavinag/cfme_tests/tags","blobs_url":"https://api.github.com/repos/amavinag/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amavinag/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amavinag/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/amavinag/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amavinag/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/amavinag/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/amavinag/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/amavinag/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/amavinag/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/amavinag/cfme_tests/subscription","commits_url":"https://api.github.com/repos/amavinag/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/amavinag/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/amavinag/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/amavinag/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/amavinag/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/amavinag/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amavinag/cfme_tests/merges","archive_url":"https://api.github.com/repos/amavinag/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amavinag/cfme_tests/downloads","issues_url":"https://api.github.com/repos/amavinag/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/amavinag/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/amavinag/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/amavinag/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amavinag/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/amavinag/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/amavinag/cfme_tests/deployments","created_at":"2016-01-27T22:21:16Z","updated_at":"2016-01-27T22:21:18Z","pushed_at":"2016-05-24T15:45:13Z","git_url":"git://github.com/amavinag/cfme_tests.git","ssh_url":"git@github.com:amavinag/cfme_tests.git","clone_url":"https://github.com/amavinag/cfme_tests.git","svn_url":"https://github.com/amavinag/cfme_tests","homepage":"","size":10148,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHatQE:master","ref":"master","sha":"f3e2cac99e717d447bdb5de523cbf7a46be62234","user":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"cfme_tests","full_name":"RedHatQE/cfme_tests","owner":{"login":"RedHatQE","id":534870,"avatar_url":"https://avatars.githubusercontent.com/u/534870?v=3","gravatar_id":"","url":"https://api.github.com/users/RedHatQE","html_url":"https://github.com/RedHatQE","followers_url":"https://api.github.com/users/RedHatQE/followers","following_url":"https://api.github.com/users/RedHatQE/following{/other_user}","gists_url":"https://api.github.com/users/RedHatQE/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatQE/subscriptions","organizations_url":"https://api.github.com/users/RedHatQE/orgs","repos_url":"https://api.github.com/users/RedHatQE/repos","events_url":"https://api.github.com/users/RedHatQE/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatQE/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":false,"url":"https://api.github.com/repos/RedHatQE/cfme_tests","forks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/forks","keys_url":"https://api.github.com/repos/RedHatQE/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatQE/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatQE/cfme_tests/teams","hooks_url":"https://api.github.com/repos/RedHatQE/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatQE/cfme_tests/events","assignees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatQE/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/tags","blobs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatQE/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/RedHatQE/cfme_tests/subscription","commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatQE/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatQE/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatQE/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatQE/cfme_tests/merges","archive_url":"https://api.github.com/repos/RedHatQE/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatQE/cfme_tests/downloads","issues_url":"https://api.github.com/repos/RedHatQE/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatQE/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatQE/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatQE/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/RedHatQE/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatQE/cfme_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2016-05-24T09:07:05Z","pushed_at":"2016-05-25T16:31:00Z","git_url":"git://github.com/RedHatQE/cfme_tests.git","ssh_url":"git@github.com:RedHatQE/cfme_tests.git","clone_url":"https://github.com/RedHatQE/cfme_tests.git","svn_url":"https://github.com/RedHatQE/cfme_tests","homepage":"","size":14462,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":75,"forks":56,"open_issues":75,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/2964"},"issue":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2964"},"comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/issues/2964/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/2964/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/statuses/d059761f3f70bd3ee278a9831236b33027b29503"}}}}
{"actor":{"display_login":"psav"}}