{"action":"created","issue":{"url":"https://api.github.com/repos/amplab/keystone/issues/232","repository_url":"https://api.github.com/repos/amplab/keystone","labels_url":"https://api.github.com/repos/amplab/keystone/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/amplab/keystone/issues/232/comments","events_url":"https://api.github.com/repos/amplab/keystone/issues/232/events","html_url":"https://github.com/amplab/keystone/pull/232","id":135005339,"number":232,"title":"Replace LLH computation with a while loop","user":{"login":"shivaram","id":143893,"avatar_url":"https://avatars.githubusercontent.com/u/143893?v=3","gravatar_id":"","url":"https://api.github.com/users/shivaram","html_url":"https://github.com/shivaram","followers_url":"https://api.github.com/users/shivaram/followers","following_url":"https://api.github.com/users/shivaram/following{/other_user}","gists_url":"https://api.github.com/users/shivaram/gists{/gist_id}","starred_url":"https://api.github.com/users/shivaram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivaram/subscriptions","organizations_url":"https://api.github.com/users/shivaram/orgs","repos_url":"https://api.github.com/users/shivaram/repos","events_url":"https://api.github.com/users/shivaram/events{/privacy}","received_events_url":"https://api.github.com/users/shivaram/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-19T23:52:40Z","updated_at":"2016-02-20T20:04:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/amplab/keystone/pulls/232","html_url":"https://github.com/amplab/keystone/pull/232","diff_url":"https://github.com/amplab/keystone/pull/232.diff","patch_url":"https://github.com/amplab/keystone/pull/232.patch"},"body":"This PR is an attempt to make the Scala GMM faster. I tried a bunch of changes, but the that was most useful was replacing the log-likelihood computation with a while loop. Some numbers from before vs. after \r\n```\r\nDataset : 1M points with 80 dimensions. OMP_NUM_THREADS is set to 1\r\nTime is in seconds\r\nNum centers, Old time, With this PR time\r\n64, 383.481, 266.444\r\n32, 214.411, 149.455\r\n16, 90.724, 66.057\r\n```\r\n\r\nSo we get around 25-30% improvement in performance from this change.\r\n\r\nFixes #174 \r\n"},"comment":{"url":"https://api.github.com/repos/amplab/keystone/issues/comments/186674945","html_url":"https://github.com/amplab/keystone/pull/232#issuecomment-186674945","issue_url":"https://api.github.com/repos/amplab/keystone/issues/232","id":186674945,"user":{"login":"etrain","id":1326181,"avatar_url":"https://avatars.githubusercontent.com/u/1326181?v=3","gravatar_id":"","url":"https://api.github.com/users/etrain","html_url":"https://github.com/etrain","followers_url":"https://api.github.com/users/etrain/followers","following_url":"https://api.github.com/users/etrain/following{/other_user}","gists_url":"https://api.github.com/users/etrain/gists{/gist_id}","starred_url":"https://api.github.com/users/etrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etrain/subscriptions","organizations_url":"https://api.github.com/users/etrain/orgs","repos_url":"https://api.github.com/users/etrain/repos","events_url":"https://api.github.com/users/etrain/events{/privacy}","received_events_url":"https://api.github.com/users/etrain/received_events","type":"User","site_admin":false},"created_at":"2016-02-20T20:04:23Z","updated_at":"2016-02-20T20:04:23Z","body":"Thanks - LGTM!"}}