{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/55080044","id":55080044,"diff_hunk":"@@ -65,7 +70,17 @@ private static bool EnumerableEquals(IEnumerable<string> left, IEnumerable<strin\n \n         public override int GetHashCode()\n         {\n-            return base.GetHashCode();\n+            return\n+                Hash.Combine(LanguageVersion ?? string.Empty,\n+                Hash.Combine(Platform ?? string.Empty,\n+                Hash.Combine(AllowUnsafe ?? false,\n+                Hash.Combine(WarningsAsErrors ?? false,\n+                Hash.Combine(Optimize ?? false,\n+                Hash.Combine(KeyFile ?? string.Empty,\n+                Hash.Combine(DelaySign ?? false,\n+                Hash.Combine(PublicSign ?? false,\n+                Hash.Combine(EmitEntryPoint ?? false,\n+                Hash.Combine(GenerateXmlDocumentation ?? false, (PreserveCompilationContext ?? false).GetHashCode()))))))))));","path":"src/Microsoft.DotNet.ProjectModel/CommonCompilerOptions.cs","position":41,"original_position":41,"commit_id":"814032cb67e890ee337477413a4ccdc279b16417","original_commit_id":"814032cb67e890ee337477413a4ccdc279b16417","user":{"login":"anurse","id":7574,"avatar_url":"https://avatars.githubusercontent.com/u/7574?v=3","gravatar_id":"","url":"https://api.github.com/users/anurse","html_url":"https://github.com/anurse","followers_url":"https://api.github.com/users/anurse/followers","following_url":"https://api.github.com/users/anurse/following{/other_user}","gists_url":"https://api.github.com/users/anurse/gists{/gist_id}","starred_url":"https://api.github.com/users/anurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anurse/subscriptions","organizations_url":"https://api.github.com/users/anurse/orgs","repos_url":"https://api.github.com/users/anurse/repos","events_url":"https://api.github.com/users/anurse/events{/privacy}","received_events_url":"https://api.github.com/users/anurse/received_events","type":"User","site_admin":false},"body":"![](http://i.imgur.com/RzEVUAz.jpg)","created_at":"2016-03-04T19:53:38Z","updated_at":"2016-03-04T19:53:38Z","html_url":"https://github.com/dotnet/cli/pull/1704#discussion_r55080044","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/1704","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/55080044"},"html":{"href":"https://github.com/dotnet/cli/pull/1704#discussion_r55080044"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/1704"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/1704","id":61752499,"html_url":"https://github.com/dotnet/cli/pull/1704","diff_url":"https://github.com/dotnet/cli/pull/1704.diff","patch_url":"https://github.com/dotnet/cli/pull/1704.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/1704","number":1704,"state":"open","locked":false,"title":"Cleanup equality / hash code implementations","user":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"body":"A number of types in CLI had incorrectly implemented equality.  Typically by using object.GetHashCode for the hash value (reference based hashing) when value equality was desired.  The code today wasn't excercising the hashing semantics of the types hence we hadn't noticed.  Decided to clean it up anyways + add some tests.","created_at":"2016-03-04T18:37:02Z","updated_at":"2016-03-04T19:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a3fe54f1b6fa48d973f572f11fa8de87ee006fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/1704/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/1704/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/1704/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/814032cb67e890ee337477413a4ccdc279b16417","head":{"label":"jaredpar:equality","ref":"equality","sha":"814032cb67e890ee337477413a4ccdc279b16417","user":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"repo":{"id":51620460,"name":"cli","full_name":"jaredpar/cli","owner":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars.githubusercontent.com/u/146967?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaredpar/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/jaredpar/cli","forks_url":"https://api.github.com/repos/jaredpar/cli/forks","keys_url":"https://api.github.com/repos/jaredpar/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaredpar/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaredpar/cli/teams","hooks_url":"https://api.github.com/repos/jaredpar/cli/hooks","issue_events_url":"https://api.github.com/repos/jaredpar/cli/issues/events{/number}","events_url":"https://api.github.com/repos/jaredpar/cli/events","assignees_url":"https://api.github.com/repos/jaredpar/cli/assignees{/user}","branches_url":"https://api.github.com/repos/jaredpar/cli/branches{/branch}","tags_url":"https://api.github.com/repos/jaredpar/cli/tags","blobs_url":"https://api.github.com/repos/jaredpar/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaredpar/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaredpar/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaredpar/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaredpar/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/jaredpar/cli/languages","stargazers_url":"https://api.github.com/repos/jaredpar/cli/stargazers","contributors_url":"https://api.github.com/repos/jaredpar/cli/contributors","subscribers_url":"https://api.github.com/repos/jaredpar/cli/subscribers","subscription_url":"https://api.github.com/repos/jaredpar/cli/subscription","commits_url":"https://api.github.com/repos/jaredpar/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaredpar/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaredpar/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaredpar/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaredpar/cli/contents/{+path}","compare_url":"https://api.github.com/repos/jaredpar/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaredpar/cli/merges","archive_url":"https://api.github.com/repos/jaredpar/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaredpar/cli/downloads","issues_url":"https://api.github.com/repos/jaredpar/cli/issues{/number}","pulls_url":"https://api.github.com/repos/jaredpar/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/jaredpar/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/jaredpar/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaredpar/cli/labels{/name}","releases_url":"https://api.github.com/repos/jaredpar/cli/releases{/id}","deployments_url":"https://api.github.com/repos/jaredpar/cli/deployments","created_at":"2016-02-12T22:22:24Z","updated_at":"2016-02-12T22:22:30Z","pushed_at":"2016-03-04T18:36:47Z","git_url":"git://github.com/jaredpar/cli.git","ssh_url":"git@github.com:jaredpar/cli.git","clone_url":"https://github.com/jaredpar/cli.git","svn_url":"https://github.com/jaredpar/cli","homepage":"http://dotnet.github.io/","size":17854,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"rel/1.0.0"}},"base":{"label":"dotnet:rel/1.0.0","ref":"rel/1.0.0","sha":"3ed93617630575f98e736e42c9401743b754edcd","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2016-03-03T18:41:52Z","pushed_at":"2016-03-04T19:10:44Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"http://dotnet.github.io/","size":19732,"stargazers_count":634,"watchers_count":634,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":455,"forks":119,"open_issues":455,"watchers":634,"default_branch":"rel/1.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/1704"},"html":{"href":"https://github.com/dotnet/cli/pull/1704"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/1704"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/1704/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/1704/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/1704/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/814032cb67e890ee337477413a4ccdc279b16417"}}}}