{"action":"created","comment":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/comments/75063771","id":75063771,"diff_hunk":"@@ -163,47 +185,60 @@ module.exports = registerElement('a-scene', {\n           // TODO: 07/16 Chromium builds break when `requestFullscreen`ing on a canvas\n           // that we are also `requestPresent`ing. Until then, don't fullscreen if headset\n           // connected.\n-          if (!self.isMobile && !checkHeadsetConnected()) { requestFullscreen(self.canvas); }\n+          if (!self.isMobile && !self.checkHeadsetConnected()) {","path":"src/core/scene/a-scene.js","position":81,"original_position":81,"commit_id":"2cd2ad730a5173cfeb232aa0fb59d26b834f1ac2","original_commit_id":"2cd2ad730a5173cfeb232aa0fb59d26b834f1ac2","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"It went over 100 chars, might be hard to read on some terminals.","created_at":"2016-08-17T05:18:58Z","updated_at":"2016-08-17T05:18:58Z","html_url":"https://github.com/aframevr/aframe/pull/1806#discussion_r75063771","pull_request_url":"https://api.github.com/repos/aframevr/aframe/pulls/1806","_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments/75063771"},"html":{"href":"https://github.com/aframevr/aframe/pull/1806#discussion_r75063771"},"pull_request":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1806"}}},"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/1806","id":81570717,"html_url":"https://github.com/aframevr/aframe/pull/1806","diff_url":"https://github.com/aframevr/aframe/pull/1806.diff","patch_url":"https://github.com/aframevr/aframe/pull/1806.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/1806","number":1806,"state":"open","locked":false,"title":"fix embedded scenes on iOS","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"**Description:**\r\n\r\n- The class was being applied to the scene element rather than the canvas element.\r\n- Add unit tests for enter/exit VR also covering the canvas fullscreen styles.\r\n","created_at":"2016-08-17T01:18:14Z","updated_at":"2016-08-17T05:18:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18a278c599c3f782987d0a39d939f875c60e4073","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aframevr/aframe/milestones/2","html_url":"https://github.com/aframevr/aframe/milestones/0.3.0","labels_url":"https://api.github.com/repos/aframevr/aframe/milestones/2/labels","id":1646371,"number":2,"title":"0.3.0","description":"","creator":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":53,"state":"open","created_at":"2016-03-15T18:39:55Z","updated_at":"2016-08-17T04:43:21Z","due_on":"2016-08-12T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/1806/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/1806/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/1806/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/2cd2ad730a5173cfeb232aa0fb59d26b834f1ac2","head":{"label":"ngokevin:fixembeddedmobile","ref":"fixembeddedmobile","sha":"2cd2ad730a5173cfeb232aa0fb59d26b834f1ac2","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"repo":{"id":48299418,"name":"aframe","full_name":"ngokevin/aframe","owner":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngokevin/aframe","description":"Building Blocks for the VR Web","fork":true,"url":"https://api.github.com/repos/ngokevin/aframe","forks_url":"https://api.github.com/repos/ngokevin/aframe/forks","keys_url":"https://api.github.com/repos/ngokevin/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngokevin/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngokevin/aframe/teams","hooks_url":"https://api.github.com/repos/ngokevin/aframe/hooks","issue_events_url":"https://api.github.com/repos/ngokevin/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/ngokevin/aframe/events","assignees_url":"https://api.github.com/repos/ngokevin/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/ngokevin/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/ngokevin/aframe/tags","blobs_url":"https://api.github.com/repos/ngokevin/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngokevin/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngokevin/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngokevin/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngokevin/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/ngokevin/aframe/languages","stargazers_url":"https://api.github.com/repos/ngokevin/aframe/stargazers","contributors_url":"https://api.github.com/repos/ngokevin/aframe/contributors","subscribers_url":"https://api.github.com/repos/ngokevin/aframe/subscribers","subscription_url":"https://api.github.com/repos/ngokevin/aframe/subscription","commits_url":"https://api.github.com/repos/ngokevin/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngokevin/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngokevin/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngokevin/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngokevin/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/ngokevin/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngokevin/aframe/merges","archive_url":"https://api.github.com/repos/ngokevin/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngokevin/aframe/downloads","issues_url":"https://api.github.com/repos/ngokevin/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/ngokevin/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/ngokevin/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/ngokevin/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngokevin/aframe/labels{/name}","releases_url":"https://api.github.com/repos/ngokevin/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/ngokevin/aframe/deployments","created_at":"2015-12-19T22:31:05Z","updated_at":"2016-03-29T22:44:31Z","pushed_at":"2016-08-17T04:32:55Z","git_url":"git://github.com/ngokevin/aframe.git","ssh_url":"git@github.com:ngokevin/aframe.git","clone_url":"https://github.com/ngokevin/aframe.git","svn_url":"https://github.com/ngokevin/aframe","homepage":"https://aframe.io/","size":134645,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"8d6bdff3bc2ea4ff16b00d17c48c0fefffb799c5","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"Building Blocks for the VR Web","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-08-17T04:52:46Z","pushed_at":"2016-08-17T04:32:56Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":140490,"stargazers_count":2797,"watchers_count":2797,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":516,"mirror_url":null,"open_issues_count":192,"forks":516,"open_issues":192,"watchers":2797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1806"},"html":{"href":"https://github.com/aframevr/aframe/pull/1806"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1806"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1806/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1806/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1806/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/2cd2ad730a5173cfeb232aa0fb59d26b834f1ac2"}}}}
{"actor":{"display_login":"ngokevin"}}