{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/73541818","id":73541818,"diff_hunk":"@@ -62,7 +62,7 @@ function ($,_, Marionette) {\n          * Set up the popovers based on if the selector has a description.\n          */\n         setupPopOvers: function($popoverAnchor, id, title, description) {\n-            var selector = \".description[data-title='\" + id + \"']\",\n+            var selector = \".description\",","path":"catalog/admin/module/catalog-admin-module-sources/src/main/webapp/js/view/Utils.js","position":5,"original_position":5,"commit_id":"58eb319c405ad221b119266a91801faf64ae0705","original_commit_id":"58eb319c405ad221b119266a91801faf64ae0705","user":{"login":"gordocanchola","id":14877145,"avatar_url":"https://avatars.githubusercontent.com/u/14877145?v=3","gravatar_id":"","url":"https://api.github.com/users/gordocanchola","html_url":"https://github.com/gordocanchola","followers_url":"https://api.github.com/users/gordocanchola/followers","following_url":"https://api.github.com/users/gordocanchola/following{/other_user}","gists_url":"https://api.github.com/users/gordocanchola/gists{/gist_id}","starred_url":"https://api.github.com/users/gordocanchola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordocanchola/subscriptions","organizations_url":"https://api.github.com/users/gordocanchola/orgs","repos_url":"https://api.github.com/users/gordocanchola/repos","events_url":"https://api.github.com/users/gordocanchola/events{/privacy}","received_events_url":"https://api.github.com/users/gordocanchola/received_events","type":"User","site_admin":false},"body":"I'm not sure why the data-title attribute filter was added. I checked the templates and the description class is only on the anchor tags that contain the question icon. ","created_at":"2016-08-04T15:14:42Z","updated_at":"2016-08-04T15:14:42Z","html_url":"https://github.com/codice/ddf/pull/1083#discussion_r73541818","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/1083","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/73541818"},"html":{"href":"https://github.com/codice/ddf/pull/1083#discussion_r73541818"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/1083"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1083","id":79826526,"html_url":"https://github.com/codice/ddf/pull/1083","diff_url":"https://github.com/codice/ddf/pull/1083.diff","patch_url":"https://github.com/codice/ddf/pull/1083.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/1083","number":1083,"state":"open","locked":false,"title":"DDF-2346: Source Modal does not like single quoted names","user":{"login":"gordocanchola","id":14877145,"avatar_url":"https://avatars.githubusercontent.com/u/14877145?v=3","gravatar_id":"","url":"https://api.github.com/users/gordocanchola","html_url":"https://github.com/gordocanchola","followers_url":"https://api.github.com/users/gordocanchola/followers","following_url":"https://api.github.com/users/gordocanchola/following{/other_user}","gists_url":"https://api.github.com/users/gordocanchola/gists{/gist_id}","starred_url":"https://api.github.com/users/gordocanchola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordocanchola/subscriptions","organizations_url":"https://api.github.com/users/gordocanchola/orgs","repos_url":"https://api.github.com/users/gordocanchola/repos","events_url":"https://api.github.com/users/gordocanchola/events{/privacy}","received_events_url":"https://api.github.com/users/gordocanchola/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nThis PR fixes the issue where the Source modal won't open up if there is a single quote in the source's name.\r\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\r\n@mcalcote @clockard @vinamartin @ryeats @ani6gup @brianfelix @djblue \r\n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\r\n@figliold \r\n@shaundmorris\r\n#### How should this be tested?\r\nStart up DDF with registry. \r\nOpen the DDF Catalog app. \r\nOpen the Node Information tab\r\nOpen the identity node and rename it to something containing a single quote\r\nOpen the Services tab.\r\nAdd a service with at least one binding. Save\r\nOpen the Sources tab.\r\nVerify a source exists for you identity node, you may have to refresh the list.\r\nClick on the source and verify the modal opens up.\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\nDDF-2346\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\nUpdating the popover selector to remove the attribute check for 'data-title'.\r\nAn update was made to the backing library JQuery (or Sizzle) where the data-title attribute value containing a single quote is no longer recognized as an attribute.\r\nSelecting on description class itself will add the popover.","created_at":"2016-08-02T23:32:30Z","updated_at":"2016-08-04T15:14:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6871e5d95e0ee7c3adb7b2d29532c07fdf7b846b","assignee":{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},"assignees":[{"login":"shaundmorris","id":4359166,"avatar_url":"https://avatars.githubusercontent.com/u/4359166?v=3","gravatar_id":"","url":"https://api.github.com/users/shaundmorris","html_url":"https://github.com/shaundmorris","followers_url":"https://api.github.com/users/shaundmorris/followers","following_url":"https://api.github.com/users/shaundmorris/following{/other_user}","gists_url":"https://api.github.com/users/shaundmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/shaundmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaundmorris/subscriptions","organizations_url":"https://api.github.com/users/shaundmorris/orgs","repos_url":"https://api.github.com/users/shaundmorris/repos","events_url":"https://api.github.com/users/shaundmorris/events{/privacy}","received_events_url":"https://api.github.com/users/shaundmorris/received_events","type":"User","site_admin":false},{"login":"figliold","id":4838043,"avatar_url":"https://avatars.githubusercontent.com/u/4838043?v=3","gravatar_id":"","url":"https://api.github.com/users/figliold","html_url":"https://github.com/figliold","followers_url":"https://api.github.com/users/figliold/followers","following_url":"https://api.github.com/users/figliold/following{/other_user}","gists_url":"https://api.github.com/users/figliold/gists{/gist_id}","starred_url":"https://api.github.com/users/figliold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figliold/subscriptions","organizations_url":"https://api.github.com/users/figliold/orgs","repos_url":"https://api.github.com/users/figliold/repos","events_url":"https://api.github.com/users/figliold/events{/privacy}","received_events_url":"https://api.github.com/users/figliold/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/1083/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/1083/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1083/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/58eb319c405ad221b119266a91801faf64ae0705","head":{"label":"gordocanchola:DDF-2346","ref":"DDF-2346","sha":"58eb319c405ad221b119266a91801faf64ae0705","user":{"login":"gordocanchola","id":14877145,"avatar_url":"https://avatars.githubusercontent.com/u/14877145?v=3","gravatar_id":"","url":"https://api.github.com/users/gordocanchola","html_url":"https://github.com/gordocanchola","followers_url":"https://api.github.com/users/gordocanchola/followers","following_url":"https://api.github.com/users/gordocanchola/following{/other_user}","gists_url":"https://api.github.com/users/gordocanchola/gists{/gist_id}","starred_url":"https://api.github.com/users/gordocanchola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordocanchola/subscriptions","organizations_url":"https://api.github.com/users/gordocanchola/orgs","repos_url":"https://api.github.com/users/gordocanchola/repos","events_url":"https://api.github.com/users/gordocanchola/events{/privacy}","received_events_url":"https://api.github.com/users/gordocanchola/received_events","type":"User","site_admin":false},"repo":{"id":43379971,"name":"ddf","full_name":"gordocanchola/ddf","owner":{"login":"gordocanchola","id":14877145,"avatar_url":"https://avatars.githubusercontent.com/u/14877145?v=3","gravatar_id":"","url":"https://api.github.com/users/gordocanchola","html_url":"https://github.com/gordocanchola","followers_url":"https://api.github.com/users/gordocanchola/followers","following_url":"https://api.github.com/users/gordocanchola/following{/other_user}","gists_url":"https://api.github.com/users/gordocanchola/gists{/gist_id}","starred_url":"https://api.github.com/users/gordocanchola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordocanchola/subscriptions","organizations_url":"https://api.github.com/users/gordocanchola/orgs","repos_url":"https://api.github.com/users/gordocanchola/repos","events_url":"https://api.github.com/users/gordocanchola/events{/privacy}","received_events_url":"https://api.github.com/users/gordocanchola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gordocanchola/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/gordocanchola/ddf","forks_url":"https://api.github.com/repos/gordocanchola/ddf/forks","keys_url":"https://api.github.com/repos/gordocanchola/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gordocanchola/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gordocanchola/ddf/teams","hooks_url":"https://api.github.com/repos/gordocanchola/ddf/hooks","issue_events_url":"https://api.github.com/repos/gordocanchola/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/gordocanchola/ddf/events","assignees_url":"https://api.github.com/repos/gordocanchola/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/gordocanchola/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/gordocanchola/ddf/tags","blobs_url":"https://api.github.com/repos/gordocanchola/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gordocanchola/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gordocanchola/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gordocanchola/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gordocanchola/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/gordocanchola/ddf/languages","stargazers_url":"https://api.github.com/repos/gordocanchola/ddf/stargazers","contributors_url":"https://api.github.com/repos/gordocanchola/ddf/contributors","subscribers_url":"https://api.github.com/repos/gordocanchola/ddf/subscribers","subscription_url":"https://api.github.com/repos/gordocanchola/ddf/subscription","commits_url":"https://api.github.com/repos/gordocanchola/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gordocanchola/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gordocanchola/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gordocanchola/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gordocanchola/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/gordocanchola/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gordocanchola/ddf/merges","archive_url":"https://api.github.com/repos/gordocanchola/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gordocanchola/ddf/downloads","issues_url":"https://api.github.com/repos/gordocanchola/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/gordocanchola/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/gordocanchola/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/gordocanchola/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gordocanchola/ddf/labels{/name}","releases_url":"https://api.github.com/repos/gordocanchola/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/gordocanchola/ddf/deployments","created_at":"2015-09-29T16:34:02Z","updated_at":"2016-04-13T22:04:54Z","pushed_at":"2016-08-02T23:28:34Z","git_url":"git://github.com/gordocanchola/ddf.git","ssh_url":"git@github.com:gordocanchola/ddf.git","clone_url":"https://github.com/gordocanchola/ddf.git","svn_url":"https://github.com/gordocanchola/ddf","homepage":"","size":146338,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"711e03837a8273e5d0093e93f3b30d5682665ba5","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-08-03T16:08:03Z","pushed_at":"2016-08-04T15:11:27Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":281415,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":29,"forks":84,"open_issues":29,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/1083"},"html":{"href":"https://github.com/codice/ddf/pull/1083"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/1083"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/1083/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/1083/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/1083/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/58eb319c405ad221b119266a91801faf64ae0705"}}}}
{"actor":{"display_login":"gordocanchola"}}