{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/64979137","id":64979137,"diff_hunk":"@@ -79,15 +42,26 @@\n \ticon_state = \"pulse_pistol\"\r\n \titem_state = \"gun\"\r\n \tcell_type = \"/obj/item/weapon/stock_parts/cell/pulse/pistol\"\r\n+\tcan_charge = 0\r\n \r\n /obj/item/weapon/gun/energy/pulse_rifle/pistol/isHandgun()\r\n \treturn 1\r\n \r\n+/obj/item/weapon/gun/energy/pulse_rifle/destroyer\r\n+\tname = \"pulse destroyer\"\r\n+\tdesc = \"A heavy-duty, pulse-based energy weapon.\"\r\n+\tcell_type = \"/obj/item/weapon/stock_parts/cell/infinite\"\r\n+\tammo_type = list(/obj/item/ammo_casing/energy/laser/pulse)\r\n+\r\n+/obj/item/weapon/gun/energy/pulse/destroyer/attack_self(mob/living/user)\r\n+\tto_chat(user, \"<span class='danger'>[src.name] has three settings, and they are all DESTROY.</span>\")\r","path":"code/modules/projectiles/guns/energy/pulse.dm","position":105,"original_position":105,"commit_id":"0dbfb4658c0c032912beb8de3ce87f5c12abd358","original_commit_id":"0dbfb4658c0c032912beb8de3ce87f5c12abd358","user":{"login":"tigercat2000","id":10103534,"avatar_url":"https://avatars.githubusercontent.com/u/10103534?v=3","gravatar_id":"","url":"https://api.github.com/users/tigercat2000","html_url":"https://github.com/tigercat2000","followers_url":"https://api.github.com/users/tigercat2000/followers","following_url":"https://api.github.com/users/tigercat2000/following{/other_user}","gists_url":"https://api.github.com/users/tigercat2000/gists{/gist_id}","starred_url":"https://api.github.com/users/tigercat2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigercat2000/subscriptions","organizations_url":"https://api.github.com/users/tigercat2000/orgs","repos_url":"https://api.github.com/users/tigercat2000/repos","events_url":"https://api.github.com/users/tigercat2000/events{/privacy}","received_events_url":"https://api.github.com/users/tigercat2000/received_events","type":"User","site_admin":false},"body":":eyes: ","created_at":"2016-05-27T23:55:37Z","updated_at":"2016-05-27T23:55:37Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/4515#discussion_r64979137","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/64979137"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/4515#discussion_r64979137"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515"}}},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515","id":71784039,"html_url":"https://github.com/ParadiseSS13/Paradise/pull/4515","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/4515.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/4515.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4515","number":4515,"state":"open","locked":false,"title":"Major Gun Refactor","user":{"login":"TheDZD","id":8212178,"avatar_url":"https://avatars.githubusercontent.com/u/8212178?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDZD","html_url":"https://github.com/TheDZD","followers_url":"https://api.github.com/users/TheDZD/followers","following_url":"https://api.github.com/users/TheDZD/following{/other_user}","gists_url":"https://api.github.com/users/TheDZD/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDZD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDZD/subscriptions","organizations_url":"https://api.github.com/users/TheDZD/orgs","repos_url":"https://api.github.com/users/TheDZD/repos","events_url":"https://api.github.com/users/TheDZD/events{/privacy}","received_events_url":"https://api.github.com/users/TheDZD/received_events","type":"User","site_admin":false},"body":"I don't know why I'm subjecting myself to this again. PR is largely just going up so I have an easier to look through reference, and so @tigercat2000 can yell at me about where I forgot to change a << into to_chat().\r\n\r\nLargely ports most of the /code/modules/projectiles version from [tgstation](https://github.com/tgstation/tgstation). Also utilizes tgstation/tgstation#16104 and tgstation/tgstation#17735 as references to make sure the temp gun and pixel projectiles actually work properly.\r\n\r\nPR won't be finished for at least another few days to a week or two.\r\n\r\nThings I can think of off the top of my head that I didn't port from TG with this:\r\n- Laser guns with rechargeable magazines (likely will port later)\r\n- Dragnets\r\n\r\n## Things that Still Need to be Done\r\n- [ ] Make the code compile.\r\n- [ ] Make the maps compile.\r\n- [ ] Fix any immediately obvious bugs (such as guns not shooting)\r\n- [ ] Make crossbows and Vox spike launchers work again, preferably in a way that isn't as horrid and easily broken as the old launcher system.\r\n- [ ] Maybe re-implement the pie cannon (nobody ever uses this though, and it's adminbus only)\r\n- [ ] A LOT OF THINGS WITH SPRITES AAAAAAAAAAA\r\n- [ ] Testing.\r\n- [ ] More testing.\r\n- [ ] Seriously this is going to need a lot of testing.\r\n- [x] Break gun code.\r\n- [ ] Fix gun code.\r\n- [x] Have merge conflicts right out of the gates.\r\n - [x] Fix them!\r\n- [ ] Merge conflicts!\r\n - [ ] Fix them!\r\n- [ ] Sprite merge conflicts.\r\n- [ ] Yet more merge conflicts.\r\n\r\n# AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA","created_at":"2016-05-27T23:23:57Z","updated_at":"2016-05-27T23:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"670c53b5e68823ded8d7469e6feba1d0dcb5f7fe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4515/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/0dbfb4658c0c032912beb8de3ce87f5c12abd358","head":{"label":"TheDZD:why-did-i-try-doing-this-again","ref":"why-did-i-try-doing-this-again","sha":"0dbfb4658c0c032912beb8de3ce87f5c12abd358","user":{"login":"TheDZD","id":8212178,"avatar_url":"https://avatars.githubusercontent.com/u/8212178?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDZD","html_url":"https://github.com/TheDZD","followers_url":"https://api.github.com/users/TheDZD/followers","following_url":"https://api.github.com/users/TheDZD/following{/other_user}","gists_url":"https://api.github.com/users/TheDZD/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDZD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDZD/subscriptions","organizations_url":"https://api.github.com/users/TheDZD/orgs","repos_url":"https://api.github.com/users/TheDZD/repos","events_url":"https://api.github.com/users/TheDZD/events{/privacy}","received_events_url":"https://api.github.com/users/TheDZD/received_events","type":"User","site_admin":false},"repo":{"id":27308476,"name":"Paradise","full_name":"TheDZD/Paradise","owner":{"login":"TheDZD","id":8212178,"avatar_url":"https://avatars.githubusercontent.com/u/8212178?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDZD","html_url":"https://github.com/TheDZD","followers_url":"https://api.github.com/users/TheDZD/followers","following_url":"https://api.github.com/users/TheDZD/following{/other_user}","gists_url":"https://api.github.com/users/TheDZD/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDZD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDZD/subscriptions","organizations_url":"https://api.github.com/users/TheDZD/orgs","repos_url":"https://api.github.com/users/TheDZD/repos","events_url":"https://api.github.com/users/TheDZD/events{/privacy}","received_events_url":"https://api.github.com/users/TheDZD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheDZD/Paradise","description":"Paradise Station's GitHub repository. Please use icon_override when making new inhand icons for items, as our item_lefthand and item_righthand .dmi files are full due to a BYOND limitation.","fork":true,"url":"https://api.github.com/repos/TheDZD/Paradise","forks_url":"https://api.github.com/repos/TheDZD/Paradise/forks","keys_url":"https://api.github.com/repos/TheDZD/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheDZD/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheDZD/Paradise/teams","hooks_url":"https://api.github.com/repos/TheDZD/Paradise/hooks","issue_events_url":"https://api.github.com/repos/TheDZD/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/TheDZD/Paradise/events","assignees_url":"https://api.github.com/repos/TheDZD/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/TheDZD/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/TheDZD/Paradise/tags","blobs_url":"https://api.github.com/repos/TheDZD/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheDZD/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheDZD/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheDZD/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheDZD/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/TheDZD/Paradise/languages","stargazers_url":"https://api.github.com/repos/TheDZD/Paradise/stargazers","contributors_url":"https://api.github.com/repos/TheDZD/Paradise/contributors","subscribers_url":"https://api.github.com/repos/TheDZD/Paradise/subscribers","subscription_url":"https://api.github.com/repos/TheDZD/Paradise/subscription","commits_url":"https://api.github.com/repos/TheDZD/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheDZD/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheDZD/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheDZD/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheDZD/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/TheDZD/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheDZD/Paradise/merges","archive_url":"https://api.github.com/repos/TheDZD/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheDZD/Paradise/downloads","issues_url":"https://api.github.com/repos/TheDZD/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/TheDZD/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/TheDZD/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/TheDZD/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheDZD/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/TheDZD/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/TheDZD/Paradise/deployments","created_at":"2014-11-29T16:49:49Z","updated_at":"2016-01-14T03:12:19Z","pushed_at":"2016-05-27T23:35:54Z","git_url":"git://github.com/TheDZD/Paradise.git","ssh_url":"git@github.com:TheDZD/Paradise.git","clone_url":"https://github.com/TheDZD/Paradise.git","svn_url":"https://github.com/TheDZD/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":855169,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"66395dc3644048196538032142397e71ce0641ac","user":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"name":"Paradise","full_name":"ParadiseSS13/Paradise","owner":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2016-05-27T16:35:34Z","pushed_at":"2016-05-27T23:35:55Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":899697,"stargazers_count":59,"watchers_count":59,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":251,"forks":163,"open_issues":251,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/4515"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4515"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/4515/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/4515/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/0dbfb4658c0c032912beb8de3ce87f5c12abd358"}}}}
{"actor":{"display_login":"tigercat2000"}}