{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/comments/92707230","pull_request_review_id":13228361,"id":92707230,"diff_hunk":"@@ -126,66 +121,12 @@ DebugletApi.prototype.registerError = function(message) {\n  * @param {!function(?Error,Object=)} callback\n  * @private\n  */\n-DebugletApi.prototype.register_ = function(errorMessage, callback) {\n+Controller.prototype.register_ = function(errorMessage, callback) {\n   var that = this;\n-\n-  var cwd = process.cwd();\n-  var mainScript = path.relative(cwd, process.argv[1]);\n-\n-  var version = 'google.com/node-' +\n-    (that.onGCP ? 'gcp' : 'standalone') +\n-    '/v' + pjson.version;\n-  var desc = process.title + ' ' + mainScript;\n-  var labels = {\n-    'main script': mainScript,\n-    'process.title': process.title,\n-    'node version': process.versions.node,\n-    'V8 version': process.versions.v8,\n-    'agent.name': pjson.name,\n-    'agent.version': pjson.version,\n-    'projectid': that.project_\n-  };\n-\n-  var serviceName = that.serviceName_;\n-  if (serviceName) {\n-    desc += ' module:' + serviceName;\n-    labels[DEBUGGEE_MODULE_LABEL] = serviceName;\n-  }\n-\n-  var serviceVersion = that.serviceVersion_;\n-  if (serviceVersion) {\n-    desc += ' version:' + serviceVersion;\n-    if (serviceVersion !== 'default') {\n-      labels[DEBUGGEE_MAJOR_VERSION_LABEL] = serviceVersion;\n-    }\n-  }\n-\n-  var descriptor = that.descriptor_;\n-  if (descriptor) {\n-    desc += ' description:' + descriptor;\n-  }\n-\n-  if (process.env.GAE_MINOR_VERSION) {\n-    labels[DEBUGGEE_MINOR_VERSION_LABEL] = process.env.GAE_MINOR_VERSION;\n-  }\n-\n-  var uniquifier = desc + version + that.uid_ + that.sourceContext_ +\n-    JSON.stringify(labels);\n-  uniquifier  = crypto.createHash('sha1').update(uniquifier).digest('hex');\n-\n-  var debuggee = {\n-    project: that.project_,\n-    uniquifier: uniquifier,\n-    description: desc,\n-    agentVersion: version,\n-    labels: labels,\n-    sourceContexts: [that.sourceContext_]\n-  };\n-\n-  if (errorMessage) {\n-    debuggee.status = new StatusMessage(StatusMessage.UNSPECIFIED, errorMessage,\n-                                        true);\n-  }\n+  var debuggee = new Debuggee(\n+      that.project_, that.uid_,","path":"src/controller.js","position":128,"original_position":128,"commit_id":"60612bfb03f2802edb5e31f96b5a8f4242e28c28","original_commit_id":"f6ecc782d69e0019e8352079e1a8389cb56aac03","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"There is more refactoring coming here. I have chosen not to act on any of this just yet.","created_at":"2016-12-15T21:47:12Z","updated_at":"2016-12-15T21:47:12Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/pull/192#discussion_r92707230","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/comments/92707230"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/pull/192#discussion_r92707230"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192","id":98216071,"html_url":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/pull/192","diff_url":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/pull/192.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/pull/192.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/issues/192","number":192,"state":"open","locked":false,"title":"Refactor and rename api classes","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"body":"Various refactorings that are essentially functionally equivalent, but align us better to include a Client Library for the Debug API in the future.","created_at":"2016-12-15T19:36:21Z","updated_at":"2016-12-15T21:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4b72a204745d28f393eab9354ab347261bc1b62","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/issues/192/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/statuses/60612bfb03f2802edb5e31f96b5a8f4242e28c28","head":{"label":"ofrobots:refactorings","ref":"refactorings","sha":"60612bfb03f2802edb5e31f96b5a8f4242e28c28","user":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"repo":{"id":42900553,"name":"cloud-debug-nodejs","full_name":"ofrobots/cloud-debug-nodejs","owner":{"login":"ofrobots","id":79017,"avatar_url":"https://avatars.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ofrobots/cloud-debug-nodejs","description":null,"fork":true,"url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs","forks_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/forks","keys_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/teams","hooks_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/hooks","issue_events_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/events","assignees_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/tags","blobs_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/languages","stargazers_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/stargazers","contributors_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/contributors","subscribers_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/subscribers","subscription_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/subscription","commits_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/merges","archive_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/downloads","issues_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/ofrobots/cloud-debug-nodejs/deployments","created_at":"2015-09-22T00:05:17Z","updated_at":"2016-04-21T17:14:27Z","pushed_at":"2016-12-15T21:43:47Z","git_url":"git://github.com/ofrobots/cloud-debug-nodejs.git","ssh_url":"git@github.com:ofrobots/cloud-debug-nodejs.git","clone_url":"https://github.com/ofrobots/cloud-debug-nodejs.git","svn_url":"https://github.com/ofrobots/cloud-debug-nodejs","homepage":null,"size":1970,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"c5d3d226c9c4aa4767a6c855bc65b95000ea3db9","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":34679272,"name":"cloud-debug-nodejs","full_name":"GoogleCloudPlatform/cloud-debug-nodejs","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs","description":"Node.js library for Stackdriver Debugger: investigate your code’s behavior in production","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/deployments","created_at":"2015-04-27T16:57:45Z","updated_at":"2016-12-14T09:33:47Z","pushed_at":"2016-12-15T21:43:47Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-debug-nodejs.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-debug-nodejs.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs","homepage":"https://cloud.google.com/debugger/","size":1946,"stargazers_count":69,"watchers_count":69,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":1,"forks":20,"open_issues":1,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-debug-nodejs/pull/192"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/issues/192"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-debug-nodejs/statuses/60612bfb03f2802edb5e31f96b5a8f4242e28c28"}}}}
{"actor":{"display_login":"ofrobots"}}