{"action":"created","issue":{"url":"https://api.github.com/repos/redding/dat-worker-pool/issues/48","repository_url":"https://api.github.com/repos/redding/dat-worker-pool","labels_url":"https://api.github.com/repos/redding/dat-worker-pool/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/redding/dat-worker-pool/issues/48/comments","events_url":"https://api.github.com/repos/redding/dat-worker-pool/issues/48/events","html_url":"https://github.com/redding/dat-worker-pool/pull/48","id":158974827,"number":48,"title":"replace SystemTimer with MuchTimeout","user":{"login":"kellyredding","id":82110,"avatar_url":"https://avatars.githubusercontent.com/u/82110?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyredding","html_url":"https://github.com/kellyredding","followers_url":"https://api.github.com/users/kellyredding/followers","following_url":"https://api.github.com/users/kellyredding/following{/other_user}","gists_url":"https://api.github.com/users/kellyredding/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyredding/subscriptions","organizations_url":"https://api.github.com/users/kellyredding/orgs","repos_url":"https://api.github.com/users/kellyredding/repos","events_url":"https://api.github.com/users/kellyredding/events{/privacy}","received_events_url":"https://api.github.com/users/kellyredding/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-07T17:04:17Z","updated_at":"2016-06-07T17:42:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/redding/dat-worker-pool/pulls/48","html_url":"https://github.com/redding/dat-worker-pool/pull/48","diff_url":"https://github.com/redding/dat-worker-pool/pull/48.diff","patch_url":"https://github.com/redding/dat-worker-pool/pull/48.patch"},"body":"This is part of getting this working in modern ruby versions.\r\nSystemTimer isn't compatible.  This switches to using our new\r\nmuch-timeout gem for handling timeouts.\r\n\r\nThere are a couple of minor tweaks related to this change:\r\n\r\n* MuchTimeout has a `just_optional_timeout` method that not only\r\n  takes care of optionally applying the timeout but also removes\r\n  any exception being raised when a timeout occurs.\r\n* The previous shutdown logic attempted to abstract the dwp\r\n  internals in the shutdown error backtraces by accepting a custom\r\n  caller to use as the backtrace.  This proved to be less helpful\r\n  b/c you never get to see where in the worker the shutdown error\r\n  occurred.  This removes all the custom backtrace logic.\r\n* this fixes a test now that timeouts of zero immediately interrupt\r\n  (this wasn't the case with SystemTimer)\r\n\r\n@jcredding ready for review."},"comment":{"url":"https://api.github.com/repos/redding/dat-worker-pool/issues/comments/224357796","html_url":"https://github.com/redding/dat-worker-pool/pull/48#issuecomment-224357796","issue_url":"https://api.github.com/repos/redding/dat-worker-pool/issues/48","id":224357796,"user":{"login":"jcredding","id":85966,"avatar_url":"https://avatars.githubusercontent.com/u/85966?v=3","gravatar_id":"","url":"https://api.github.com/users/jcredding","html_url":"https://github.com/jcredding","followers_url":"https://api.github.com/users/jcredding/followers","following_url":"https://api.github.com/users/jcredding/following{/other_user}","gists_url":"https://api.github.com/users/jcredding/gists{/gist_id}","starred_url":"https://api.github.com/users/jcredding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcredding/subscriptions","organizations_url":"https://api.github.com/users/jcredding/orgs","repos_url":"https://api.github.com/users/jcredding/repos","events_url":"https://api.github.com/users/jcredding/events{/privacy}","received_events_url":"https://api.github.com/users/jcredding/received_events","type":"User","site_admin":false},"created_at":"2016-06-07T17:42:48Z","updated_at":"2016-06-07T17:42:48Z","body":"@kellyredding - Looks good :boom:"}}
{"actor":{"display_login":"jcredding"}}