{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/61079081","id":61079081,"diff_hunk":"@@ -1375,7 +1491,8 @@ util::Status CertChain::IsValidSignatureChain() const {\n     Cert* subject = *it;\n     Cert* issuer = *(it + 1);\n \n-    const StatusOr<bool> status = subject->IsSignedBy(*issuer);\n+    const StatusOr<bool> status =\n+        subject->IsSignedBy(*issuer);","path":"cpp/log/cert.cc","position":152,"original_position":152,"commit_id":"3c5343d9ed66eaeb633c58fd404e959b994ab776","original_commit_id":"3c5343d9ed66eaeb633c58fd404e959b994ab776","user":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"body":"Why the wrap?","created_at":"2016-04-26T12:51:28Z","updated_at":"2016-04-26T12:51:28Z","html_url":"https://github.com/google/certificate-transparency/pull/1146#discussion_r61079081","pull_request_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1146","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments/61079081"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1146#discussion_r61079081"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1146"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency/pulls/1146","id":65593752,"html_url":"https://github.com/google/certificate-transparency/pull/1146","diff_url":"https://github.com/google/certificate-transparency/pull/1146.diff","patch_url":"https://github.com/google/certificate-transparency/pull/1146.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency/issues/1146","number":1146,"state":"open","locked":false,"title":"Add support for DSA signature checking under BoringSSL + tests","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"body":"BoringSSL does not support DSA signatures via x509_verify so this adds extra handling for that case if x509_verify fails with an unsupported algorithm.","created_at":"2016-04-07T08:47:21Z","updated_at":"2016-04-26T12:51:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1944364f606fedde626bec1e166fb851a142c19e","assignee":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1146/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency/pulls/1146/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency/issues/1146/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/3c5343d9ed66eaeb633c58fd404e959b994ab776","head":{"label":"Martin2112:boringdsa","ref":"boringdsa","sha":"3c5343d9ed66eaeb633c58fd404e959b994ab776","user":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"repo":{"id":39995539,"name":"certificate-transparency","full_name":"Martin2112/certificate-transparency","owner":{"login":"Martin2112","id":13366863,"avatar_url":"https://avatars.githubusercontent.com/u/13366863?v=3","gravatar_id":"","url":"https://api.github.com/users/Martin2112","html_url":"https://github.com/Martin2112","followers_url":"https://api.github.com/users/Martin2112/followers","following_url":"https://api.github.com/users/Martin2112/following{/other_user}","gists_url":"https://api.github.com/users/Martin2112/gists{/gist_id}","starred_url":"https://api.github.com/users/Martin2112/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Martin2112/subscriptions","organizations_url":"https://api.github.com/users/Martin2112/orgs","repos_url":"https://api.github.com/users/Martin2112/repos","events_url":"https://api.github.com/users/Martin2112/events{/privacy}","received_events_url":"https://api.github.com/users/Martin2112/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Martin2112/certificate-transparency","description":"Auditing for TLS certificates.","fork":true,"url":"https://api.github.com/repos/Martin2112/certificate-transparency","forks_url":"https://api.github.com/repos/Martin2112/certificate-transparency/forks","keys_url":"https://api.github.com/repos/Martin2112/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Martin2112/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Martin2112/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/Martin2112/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/Martin2112/certificate-transparency/events","assignees_url":"https://api.github.com/repos/Martin2112/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/Martin2112/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/Martin2112/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Martin2112/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/Martin2112/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/Martin2112/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/Martin2112/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/Martin2112/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/Martin2112/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/Martin2112/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/Martin2112/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/Martin2112/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/Martin2112/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/Martin2112/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Martin2112/certificate-transparency/merges","archive_url":"https://api.github.com/repos/Martin2112/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Martin2112/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/Martin2112/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/Martin2112/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/Martin2112/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/Martin2112/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Martin2112/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/Martin2112/certificate-transparency/releases{/id}","deployments_url":"https://api.github.com/repos/Martin2112/certificate-transparency/deployments","created_at":"2015-07-31T08:37:21Z","updated_at":"2015-07-31T08:37:23Z","pushed_at":"2016-04-19T07:34:57Z","git_url":"git://github.com/Martin2112/certificate-transparency.git","ssh_url":"git@github.com:Martin2112/certificate-transparency.git","clone_url":"https://github.com/Martin2112/certificate-transparency.git","svn_url":"https://github.com/Martin2112/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":20097,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"025a5cab06f6a819c455d9fdc9e2a1b6d0982284","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19989605,"name":"certificate-transparency","full_name":"google/certificate-transparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency","description":"Auditing for TLS certificates.","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency","forks_url":"https://api.github.com/repos/google/certificate-transparency/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/certificate-transparency/deployments","created_at":"2014-05-20T17:03:47Z","updated_at":"2016-04-21T22:16:30Z","pushed_at":"2016-04-26T10:29:18Z","git_url":"git://github.com/google/certificate-transparency.git","ssh_url":"git@github.com:google/certificate-transparency.git","clone_url":"https://github.com/google/certificate-transparency.git","svn_url":"https://github.com/google/certificate-transparency","homepage":"http://www.certificate-transparency.org/","size":22152,"stargazers_count":240,"watchers_count":240,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":84,"forks":89,"open_issues":84,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1146"},"html":{"href":"https://github.com/google/certificate-transparency/pull/1146"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1146"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency/issues/1146/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1146/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency/pulls/1146/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency/statuses/3c5343d9ed66eaeb633c58fd404e959b994ab776"}}}}