{"action":"created","issue":{"url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/93","repository_url":"https://api.github.com/repos/napalm-automation/napalm-eos","labels_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/93/comments","events_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/93/events","html_url":"https://github.com/napalm-automation/napalm-eos/pull/93","id":191860472,"number":93,"title":"Fixes various get_bgp_neighbors","user":{"login":"tehhobbit","id":12018134,"avatar_url":"https://avatars.githubusercontent.com/u/12018134?v=3","gravatar_id":"","url":"https://api.github.com/users/tehhobbit","html_url":"https://github.com/tehhobbit","followers_url":"https://api.github.com/users/tehhobbit/followers","following_url":"https://api.github.com/users/tehhobbit/following{/other_user}","gists_url":"https://api.github.com/users/tehhobbit/gists{/gist_id}","starred_url":"https://api.github.com/users/tehhobbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tehhobbit/subscriptions","organizations_url":"https://api.github.com/users/tehhobbit/orgs","repos_url":"https://api.github.com/users/tehhobbit/repos","events_url":"https://api.github.com/users/tehhobbit/events{/privacy}","received_events_url":"https://api.github.com/users/tehhobbit/received_events","type":"User","site_admin":false},"labels":[{"id":444708510,"url":"https://api.github.com/repos/napalm-automation/napalm-eos/labels/enhancement","name":"enhancement","color":"424242","default":true},{"id":438801664,"url":"https://api.github.com/repos/napalm-automation/napalm-eos/labels/internal","name":"internal","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"assignees":[{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/napalm-automation/napalm-eos/milestones/13","html_url":"https://github.com/napalm-automation/napalm-eos/milestones/0.5.0","labels_url":"https://api.github.com/repos/napalm-automation/napalm-eos/milestones/13/labels","id":2144472,"number":13,"title":"0.5.0","description":null,"creator":{"login":"mirceaulinic","id":16694679,"avatar_url":"https://avatars.githubusercontent.com/u/16694679?v=3","gravatar_id":"","url":"https://api.github.com/users/mirceaulinic","html_url":"https://github.com/mirceaulinic","followers_url":"https://api.github.com/users/mirceaulinic/followers","following_url":"https://api.github.com/users/mirceaulinic/following{/other_user}","gists_url":"https://api.github.com/users/mirceaulinic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirceaulinic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirceaulinic/subscriptions","organizations_url":"https://api.github.com/users/mirceaulinic/orgs","repos_url":"https://api.github.com/users/mirceaulinic/repos","events_url":"https://api.github.com/users/mirceaulinic/events{/privacy}","received_events_url":"https://api.github.com/users/mirceaulinic/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2016-11-18T15:58:49Z","updated_at":"2016-11-27T21:39:42Z","due_on":null,"closed_at":null},"comments":34,"created_at":"2016-11-27T13:07:02Z","updated_at":"2016-11-28T12:29:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/napalm-automation/napalm-eos/pulls/93","html_url":"https://github.com/napalm-automation/napalm-eos/pull/93","diff_url":"https://github.com/napalm-automation/napalm-eos/pull/93.diff","patch_url":"https://github.com/napalm-automation/napalm-eos/pull/93.patch"},"body":"<!-- Make sure you have read http://napalm.readthedocs.io/en/latest/contributing/index.html --!>\r\n\r\n- The use of a for loop instead of while caused random data loss\r\n  ( the actual cause of issue #58)<br>\r\n\r\n- Peers that where idle would always have enable=False<br>\r\n\r\n- Uptime was actually the timestamp of when the session started<br>\r\n\r\n\r\n - Use precompiled regex and more generic approach instead of a load of private methods<br>\r\n\r\n<br><br>\r\nThis PR have 2 failing tests that might take some discussion to solve\r\n<br><br>\r\n\r\n1) Issue #58 is actually caused by the use of a for loop and the test data is invalid<br>\r\n2) Since uptime is now calculated and not static, making the moc data wrong. The one way I came up with was mock time.time() in napalm-base, but this might have effects on other drivers so think it warrants some more thinking. <br>"},"comment":{"url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/comments/263259427","html_url":"https://github.com/napalm-automation/napalm-eos/pull/93#issuecomment-263259427","issue_url":"https://api.github.com/repos/napalm-automation/napalm-eos/issues/93","id":263259427,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T12:29:47Z","updated_at":"2016-11-28T12:29:47Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9022042/badge)](https://coveralls.io/builds/9022042)\n\nCoverage decreased (-0.5%) to 79.602% when pulling **a52afe3b222a9bdf93ef94148390071eb61f180b on tehhobbit:bgp_fixes** into **9fe02f1c8761fdc22cda2473aaf9bfbdc6ff1891 on napalm-automation:develop**.\n"}}
{"actor":{"display_login":"coveralls"}}