{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/215","labels_url":"https://api.github.com/repos/kubernetes/dashboard/issues/215/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/215/comments","events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/215/events","html_url":"https://github.com/kubernetes/dashboard/pull/215","id":124738906,"number":215,"title":"Relative time filter","user":{"login":"maciaszczykm","id":2823399,"avatar_url":"https://avatars.githubusercontent.com/u/2823399?v=3","gravatar_id":"","url":"https://api.github.com/users/maciaszczykm","html_url":"https://github.com/maciaszczykm","followers_url":"https://api.github.com/users/maciaszczykm/followers","following_url":"https://api.github.com/users/maciaszczykm/following{/other_user}","gists_url":"https://api.github.com/users/maciaszczykm/gists{/gist_id}","starred_url":"https://api.github.com/users/maciaszczykm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciaszczykm/subscriptions","organizations_url":"https://api.github.com/users/maciaszczykm/orgs","repos_url":"https://api.github.com/users/maciaszczykm/repos","events_url":"https://api.github.com/users/maciaszczykm/events{/privacy}","received_events_url":"https://api.github.com/users/maciaszczykm/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/dashboard/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-01-04T11:06:33Z","updated_at":"2016-01-05T11:43:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/215","html_url":"https://github.com/kubernetes/dashboard/pull/215","diff_url":"https://github.com/kubernetes/dashboard/pull/215.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/215.patch"},"body":"Connected to issue #191.\r\n\r\nI've implemented relative time filter which can be used in multiple views. At this point I've added it to replica set details and replica set list. Filter transforms date to relative date string, which can be seen on mocks. Added tests covering all important date units.\r\n\r\nThere is still one thing to do, but to keep this pull request small I think it will be better to move it to another pull request. The issue is, that at the moment filter uses client side current time and it's invalid in many cases. Date should be taken from server in all cases, that I know. **Please let me know if you have any suggestions how we should solve it**.\r\n\r\n@floreks @bryk Can you review?"},"comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments/168978819","html_url":"https://github.com/kubernetes/dashboard/pull/215#issuecomment-168978819","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/215","id":168978819,"user":{"login":"maciaszczykm","id":2823399,"avatar_url":"https://avatars.githubusercontent.com/u/2823399?v=3","gravatar_id":"","url":"https://api.github.com/users/maciaszczykm","html_url":"https://github.com/maciaszczykm","followers_url":"https://api.github.com/users/maciaszczykm/followers","following_url":"https://api.github.com/users/maciaszczykm/following{/other_user}","gists_url":"https://api.github.com/users/maciaszczykm/gists{/gist_id}","starred_url":"https://api.github.com/users/maciaszczykm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maciaszczykm/subscriptions","organizations_url":"https://api.github.com/users/maciaszczykm/orgs","repos_url":"https://api.github.com/users/maciaszczykm/repos","events_url":"https://api.github.com/users/maciaszczykm/events{/privacy}","received_events_url":"https://api.github.com/users/maciaszczykm/received_events","type":"User","site_admin":false},"created_at":"2016-01-05T11:43:15Z","updated_at":"2016-01-05T11:43:15Z","body":"@bryk @floreks Done, thank you for reviews."}}