{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/89844067","pull_request_review_id":10376533,"id":89844067,"diff_hunk":"@@ -457,7 +457,7 @@ public FilterResult(CompletionItem completionItem, string filterText, bool match\n                 if (filterReason == CompletionFilterReason.BackspaceOrDelete &&\n                     trigger.Kind == CompletionTriggerKind.Deletion)\n                 {\n-                    return item.FilterText.GetCaseInsensitivePrefixLength(filterText) > 0;\n+                    return item.FilterText.GetCaseInsensitivePrefixLength(filterText) >= Math.Min(item.FilterText.Length, filterText.Length);","path":"src/EditorFeatures/Core/Implementation/IntelliSense/Completion/Controller.Session_FilterModel.cs","position":5,"original_position":5,"commit_id":"4796f425295d52685297356346726cac06a09c24","original_commit_id":"4796f425295d52685297356346726cac06a09c24","user":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"body":"My bad--this should just be an equality check.\r\n\r\nWhen you type backspace, the idea is that completion should try to match items where the filter text is a prefix of the item text. In order to actually be a prefix match, all of the filter text needs to be a prefix. This code used to require that only 1 character of the filter text appear in the item text which would cause us to generate bad matches. We actually need the \"case insensitive prefix match\" length to be as long as whichever of those strings was shorter. \r\n\r\nThis fixes https://github.com/dotnet/roslyn/issues/14704","created_at":"2016-11-28T18:15:37Z","updated_at":"2016-11-28T18:15:37Z","html_url":"https://github.com/dotnet/roslyn/pull/15495#discussion_r89844067","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15495","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/89844067"},"html":{"href":"https://github.com/dotnet/roslyn/pull/15495#discussion_r89844067"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15495"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/15495","id":95059422,"html_url":"https://github.com/dotnet/roslyn/pull/15495","diff_url":"https://github.com/dotnet/roslyn/pull/15495.diff","patch_url":"https://github.com/dotnet/roslyn/pull/15495.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/15495","number":15495,"state":"open","locked":false,"title":"Properly compare prefix length","user":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"body":"when triggering completion on backspace.","created_at":"2016-11-23T18:44:36Z","updated_at":"2016-11-28T18:15:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc9a9cda32c47bec79afcf5b5c96a9f5e9a78d9c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15495/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/15495/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/15495/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/4796f425295d52685297356346726cac06a09c24","head":{"label":"rchande:backspacematching","ref":"backspacematching","sha":"4796f425295d52685297356346726cac06a09c24","user":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"repo":{"id":30547830,"name":"roslyn","full_name":"rchande/roslyn","owner":{"login":"rchande","id":3751401,"avatar_url":"https://avatars.githubusercontent.com/u/3751401?v=3","gravatar_id":"","url":"https://api.github.com/users/rchande","html_url":"https://github.com/rchande","followers_url":"https://api.github.com/users/rchande/followers","following_url":"https://api.github.com/users/rchande/following{/other_user}","gists_url":"https://api.github.com/users/rchande/gists{/gist_id}","starred_url":"https://api.github.com/users/rchande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchande/subscriptions","organizations_url":"https://api.github.com/users/rchande/orgs","repos_url":"https://api.github.com/users/rchande/repos","events_url":"https://api.github.com/users/rchande/events{/privacy}","received_events_url":"https://api.github.com/users/rchande/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rchande/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/rchande/roslyn","forks_url":"https://api.github.com/repos/rchande/roslyn/forks","keys_url":"https://api.github.com/repos/rchande/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchande/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchande/roslyn/teams","hooks_url":"https://api.github.com/repos/rchande/roslyn/hooks","issue_events_url":"https://api.github.com/repos/rchande/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/rchande/roslyn/events","assignees_url":"https://api.github.com/repos/rchande/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/rchande/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/rchande/roslyn/tags","blobs_url":"https://api.github.com/repos/rchande/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchande/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchande/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchande/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchande/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/rchande/roslyn/languages","stargazers_url":"https://api.github.com/repos/rchande/roslyn/stargazers","contributors_url":"https://api.github.com/repos/rchande/roslyn/contributors","subscribers_url":"https://api.github.com/repos/rchande/roslyn/subscribers","subscription_url":"https://api.github.com/repos/rchande/roslyn/subscription","commits_url":"https://api.github.com/repos/rchande/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchande/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchande/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchande/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchande/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/rchande/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchande/roslyn/merges","archive_url":"https://api.github.com/repos/rchande/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchande/roslyn/downloads","issues_url":"https://api.github.com/repos/rchande/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/rchande/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/rchande/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/rchande/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchande/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/rchande/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/rchande/roslyn/deployments","created_at":"2015-02-09T17:16:21Z","updated_at":"2015-02-09T17:16:48Z","pushed_at":"2016-11-23T18:44:15Z","git_url":"git://github.com/rchande/roslyn.git","ssh_url":"git@github.com:rchande/roslyn.git","clone_url":"https://github.com/rchande/roslyn.git","svn_url":"https://github.com/rchande/roslyn","homepage":"","size":186524,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1bd839d999d38b23b0bf03713bbb4545ed808cff","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-11-28T16:22:44Z","pushed_at":"2016-11-28T17:56:54Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":357027,"stargazers_count":6619,"watchers_count":6619,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1587,"mirror_url":null,"open_issues_count":3451,"forks":1587,"open_issues":3451,"watchers":6619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15495"},"html":{"href":"https://github.com/dotnet/roslyn/pull/15495"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/15495"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/15495/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15495/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/15495/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/4796f425295d52685297356346726cac06a09c24"}}}}
{"actor":{"display_login":"rchande"}}