{"action":"created","comment":{"url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/comments/65438589","id":65438589,"diff_hunk":"@@ -1084,7 +1084,7 @@ HEADERS      [stream 82] +END_STREAM\n             A push service MAY expire a subscription set at any time which MUST also\r\n             expire all push message subscriptions in the set. If a user agent has an\r\n             outstanding request to a push subscription set (<xref target=\"monitor-set\"/>)\r\n-            this can be signaled by returning a 400-series status code, such as 410 (Gone).\r\n+            this can be signaled by returning a 410 (Gone) status code.\r","path":"draft-ietf-webpush-protocol.xml","position":5,"original_position":5,"commit_id":"9749574d2c557e20828944384dde0ba510b5bb8a","original_commit_id":"9749574d2c557e20828944384dde0ba510b5bb8a","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=3","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"body":"While my wife reminds me I'm on vacation, might i suggest that 504 is a bit\nmore correct for Push Service gives up on delivery before TTL? It's a\nserver error, not a client one (thus the 500 class) and it's a timeout.\n\nOn Wed, Jun 1, 2016 at 12:45 PM, Brian Raymor <notifications@github.com>\nwrote:\n\n> In draft-ietf-webpush-protocol.xml\n> <https://github.com/webpush-wg/webpush-protocol/pull/92#discussion_r65428972>\n> :\n>\n> > @@ -1084,7 +1084,7 @@ HEADERS      [stream 82] +END_STREAM\n> >              A push service MAY expire a subscription set at any time which MUST also\n> >              expire all push message subscriptions in the set. If a user agent has an\n> >              outstanding request to a push subscription set (<xref target=\"monitor-set\"/>)\n> > -            this can be signaled by returning a 400-series status code, such as 410 (Gone).\n> > +            this can be signaled by returning a 410 (Gone) status code.\n>\n> Again, these are different failures. 404 is \"push services gives up on\n> delivery before TTL\" and 410 is for expirations. The subscription set\n> language should match the subscription language for expiration.\n>\n> It's unclear whether you're proposing to simply return 410 for both cases\n> - but that's not reflected in this pull request.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/webpush-wg/webpush-protocol/pull/92/files/9749574d2c557e20828944384dde0ba510b5bb8a#r65428972>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/AACLq8-1yBvTkY2J1pdsYEtPzqmWY4tWks5qHeFKgaJpZM4IrI5F>\n> .\n>\n","created_at":"2016-06-01T20:42:57Z","updated_at":"2016-06-01T20:42:57Z","html_url":"https://github.com/webpush-wg/webpush-protocol/pull/92#discussion_r65438589","pull_request_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92","_links":{"self":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/comments/65438589"},"html":{"href":"https://github.com/webpush-wg/webpush-protocol/pull/92#discussion_r65438589"},"pull_request":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92"}}},"pull_request":{"url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92","id":72115486,"html_url":"https://github.com/webpush-wg/webpush-protocol/pull/92","diff_url":"https://github.com/webpush-wg/webpush-protocol/pull/92.diff","patch_url":"https://github.com/webpush-wg/webpush-protocol/pull/92.patch","issue_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/92","number":92,"state":"open","locked":false,"title":"Require that 410 is used to signal expiration","user":{"login":"martinthomson","id":67641,"avatar_url":"https://avatars.githubusercontent.com/u/67641?v=3","gravatar_id":"","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"body":"As suggested by @beverloo","created_at":"2016-06-01T02:48:30Z","updated_at":"2016-06-01T20:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30d78cfc23127735ccbcab616112032d33915dfa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92/commits","review_comments_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92/comments","review_comment_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/92/comments","statuses_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/statuses/9749574d2c557e20828944384dde0ba510b5bb8a","head":{"label":"webpush-wg:expired_410","ref":"expired_410","sha":"9749574d2c557e20828944384dde0ba510b5bb8a","user":{"login":"webpush-wg","id":8236626,"avatar_url":"https://avatars.githubusercontent.com/u/8236626?v=3","gravatar_id":"","url":"https://api.github.com/users/webpush-wg","html_url":"https://github.com/webpush-wg","followers_url":"https://api.github.com/users/webpush-wg/followers","following_url":"https://api.github.com/users/webpush-wg/following{/other_user}","gists_url":"https://api.github.com/users/webpush-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/webpush-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpush-wg/subscriptions","organizations_url":"https://api.github.com/users/webpush-wg/orgs","repos_url":"https://api.github.com/users/webpush-wg/repos","events_url":"https://api.github.com/users/webpush-wg/events{/privacy}","received_events_url":"https://api.github.com/users/webpush-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":32944358,"name":"webpush-protocol","full_name":"webpush-wg/webpush-protocol","owner":{"login":"webpush-wg","id":8236626,"avatar_url":"https://avatars.githubusercontent.com/u/8236626?v=3","gravatar_id":"","url":"https://api.github.com/users/webpush-wg","html_url":"https://github.com/webpush-wg","followers_url":"https://api.github.com/users/webpush-wg/followers","following_url":"https://api.github.com/users/webpush-wg/following{/other_user}","gists_url":"https://api.github.com/users/webpush-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/webpush-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpush-wg/subscriptions","organizations_url":"https://api.github.com/users/webpush-wg/orgs","repos_url":"https://api.github.com/users/webpush-wg/repos","events_url":"https://api.github.com/users/webpush-wg/events{/privacy}","received_events_url":"https://api.github.com/users/webpush-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpush-wg/webpush-protocol","description":"The web push protocol","fork":false,"url":"https://api.github.com/repos/webpush-wg/webpush-protocol","forks_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/forks","keys_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/teams","hooks_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/hooks","issue_events_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/events","assignees_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/tags","blobs_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/languages","stargazers_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/stargazers","contributors_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/contributors","subscribers_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/subscribers","subscription_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/subscription","commits_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/merges","archive_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/downloads","issues_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/labels{/name}","releases_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/deployments","created_at":"2015-03-26T18:17:43Z","updated_at":"2016-05-05T13:56:55Z","pushed_at":"2016-06-01T11:36:45Z","git_url":"git://github.com/webpush-wg/webpush-protocol.git","ssh_url":"git@github.com:webpush-wg/webpush-protocol.git","clone_url":"https://github.com/webpush-wg/webpush-protocol.git","svn_url":"https://github.com/webpush-wg/webpush-protocol","homepage":null,"size":784,"stargazers_count":11,"watchers_count":11,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":11,"default_branch":"master"}},"base":{"label":"webpush-wg:master","ref":"master","sha":"2b317faa0ab21497550770c1f3f987e60b7ce363","user":{"login":"webpush-wg","id":8236626,"avatar_url":"https://avatars.githubusercontent.com/u/8236626?v=3","gravatar_id":"","url":"https://api.github.com/users/webpush-wg","html_url":"https://github.com/webpush-wg","followers_url":"https://api.github.com/users/webpush-wg/followers","following_url":"https://api.github.com/users/webpush-wg/following{/other_user}","gists_url":"https://api.github.com/users/webpush-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/webpush-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpush-wg/subscriptions","organizations_url":"https://api.github.com/users/webpush-wg/orgs","repos_url":"https://api.github.com/users/webpush-wg/repos","events_url":"https://api.github.com/users/webpush-wg/events{/privacy}","received_events_url":"https://api.github.com/users/webpush-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":32944358,"name":"webpush-protocol","full_name":"webpush-wg/webpush-protocol","owner":{"login":"webpush-wg","id":8236626,"avatar_url":"https://avatars.githubusercontent.com/u/8236626?v=3","gravatar_id":"","url":"https://api.github.com/users/webpush-wg","html_url":"https://github.com/webpush-wg","followers_url":"https://api.github.com/users/webpush-wg/followers","following_url":"https://api.github.com/users/webpush-wg/following{/other_user}","gists_url":"https://api.github.com/users/webpush-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/webpush-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpush-wg/subscriptions","organizations_url":"https://api.github.com/users/webpush-wg/orgs","repos_url":"https://api.github.com/users/webpush-wg/repos","events_url":"https://api.github.com/users/webpush-wg/events{/privacy}","received_events_url":"https://api.github.com/users/webpush-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpush-wg/webpush-protocol","description":"The web push protocol","fork":false,"url":"https://api.github.com/repos/webpush-wg/webpush-protocol","forks_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/forks","keys_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/teams","hooks_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/hooks","issue_events_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/events","assignees_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/tags","blobs_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/languages","stargazers_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/stargazers","contributors_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/contributors","subscribers_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/subscribers","subscription_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/subscription","commits_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/merges","archive_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/downloads","issues_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/labels{/name}","releases_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/webpush-wg/webpush-protocol/deployments","created_at":"2015-03-26T18:17:43Z","updated_at":"2016-05-05T13:56:55Z","pushed_at":"2016-06-01T11:36:45Z","git_url":"git://github.com/webpush-wg/webpush-protocol.git","ssh_url":"git@github.com:webpush-wg/webpush-protocol.git","clone_url":"https://github.com/webpush-wg/webpush-protocol.git","svn_url":"https://github.com/webpush-wg/webpush-protocol","homepage":null,"size":784,"stargazers_count":11,"watchers_count":11,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92"},"html":{"href":"https://github.com/webpush-wg/webpush-protocol/pull/92"},"issue":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/92"},"comments":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/webpush-wg/webpush-protocol/statuses/9749574d2c557e20828944384dde0ba510b5bb8a"}}}}
{"actor":{"display_login":"jrconlin"}}