{"action":"created","issue":{"url":"https://api.github.com/repos/apache/parquet-cpp/issues/36","repository_url":"https://api.github.com/repos/apache/parquet-cpp","labels_url":"https://api.github.com/repos/apache/parquet-cpp/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/apache/parquet-cpp/issues/36/comments","events_url":"https://api.github.com/repos/apache/parquet-cpp/issues/36/events","html_url":"https://github.com/apache/parquet-cpp/pull/36","id":130823694,"number":36,"title":"PARQUET-481: Refactored and expanded reader-test and scanner-test.","user":{"login":"asandryh","id":9371145,"avatar_url":"https://avatars.githubusercontent.com/u/9371145?v=3","gravatar_id":"","url":"https://api.github.com/users/asandryh","html_url":"https://github.com/asandryh","followers_url":"https://api.github.com/users/asandryh/followers","following_url":"https://api.github.com/users/asandryh/following{/other_user}","gists_url":"https://api.github.com/users/asandryh/gists{/gist_id}","starred_url":"https://api.github.com/users/asandryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asandryh/subscriptions","organizations_url":"https://api.github.com/users/asandryh/orgs","repos_url":"https://api.github.com/users/asandryh/repos","events_url":"https://api.github.com/users/asandryh/events{/privacy}","received_events_url":"https://api.github.com/users/asandryh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-02T21:31:15Z","updated_at":"2016-02-02T21:55:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/parquet-cpp/pulls/36","html_url":"https://github.com/apache/parquet-cpp/pull/36","diff_url":"https://github.com/apache/parquet-cpp/pull/36.diff","patch_url":"https://github.com/apache/parquet-cpp/pull/36.patch"},"body":"Changes:\r\n* Moved Scanner tests from reader-test.cc to scanner-test.cc\r\n* Expanded both tests to run on multiple files\r\n* Added ParquetFileReader.JsonPrint() method to print a file contents in JSON format\r\n* Added several parquet files and corresponding json files for testing (these files will be removed once we have write functionality)."},"comment":{"url":"https://api.github.com/repos/apache/parquet-cpp/issues/comments/178847226","html_url":"https://github.com/apache/parquet-cpp/pull/36#issuecomment-178847226","issue_url":"https://api.github.com/repos/apache/parquet-cpp/issues/36","id":178847226,"user":{"login":"asandryh","id":9371145,"avatar_url":"https://avatars.githubusercontent.com/u/9371145?v=3","gravatar_id":"","url":"https://api.github.com/users/asandryh","html_url":"https://github.com/asandryh","followers_url":"https://api.github.com/users/asandryh/followers","following_url":"https://api.github.com/users/asandryh/following{/other_user}","gists_url":"https://api.github.com/users/asandryh/gists{/gist_id}","starred_url":"https://api.github.com/users/asandryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asandryh/subscriptions","organizations_url":"https://api.github.com/users/asandryh/orgs","repos_url":"https://api.github.com/users/asandryh/repos","events_url":"https://api.github.com/users/asandryh/events{/privacy}","received_events_url":"https://api.github.com/users/asandryh/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T21:55:30Z","updated_at":"2016-02-02T21:55:30Z","body":"Both reader and scanner need their corresponding tests. While it's true that the library does not yet have all features implemented, it is not a reason to not have tests for the components that are implemented. The library has many interacting components, and it is important to confirm that we maintain their full integration and can actually read parquet files correctly. As we add support for more features (encodings, compression, etc.), they can be reflected in these tests, too, in addition to the corresponding unit tests for those features.\r\nObviously, once we can write parquet, we'll get rid of the pre-generated files."}}