{"action":"opened","number":538,"pull_request":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/538","id":58505638,"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/538","diff_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/538.diff","patch_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/538.patch","issue_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/538","number":538,"state":"open","locked":false,"title":"Adding path derivation","user":{"login":"runn1ng","id":104945,"avatar_url":"https://avatars.githubusercontent.com/u/104945?v=3","gravatar_id":"","url":"https://api.github.com/users/runn1ng","html_url":"https://github.com/runn1ng","followers_url":"https://api.github.com/users/runn1ng/followers","following_url":"https://api.github.com/users/runn1ng/following{/other_user}","gists_url":"https://api.github.com/users/runn1ng/gists{/gist_id}","starred_url":"https://api.github.com/users/runn1ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runn1ng/subscriptions","organizations_url":"https://api.github.com/users/runn1ng/orgs","repos_url":"https://api.github.com/users/runn1ng/repos","events_url":"https://api.github.com/users/runn1ng/events{/privacy}","received_events_url":"https://api.github.com/users/runn1ng/received_events","type":"User","site_admin":false},"body":"Now this might be a bit controversial, but I found something like that to be really useful.\r\n\r\nWhat will be controversial, I think:\r\n\r\n* the usage of strings as indexes \r\n   * yes, it's not ideal, but adding an apostrophe is a way to easily say \"this is hardened\" and this notation is common, and you cannot do that otherwise\r\n* the usage of descriptions as paths in the tests\r\n   * again, not ideal, but I didn't want to repeat the description as path again if it's already there","created_at":"2016-02-06T01:08:04Z","updated_at":"2016-02-06T01:08:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05a547d7b719c0ca655fc785588927fc1cd9a535","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/538/commits","review_comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/538/comments","review_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/538/comments","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/cd51d9e477ae112c1806e65871909ae896ee4607","head":{"label":"runn1ng:patch-2","ref":"patch-2","sha":"cd51d9e477ae112c1806e65871909ae896ee4607","user":{"login":"runn1ng","id":104945,"avatar_url":"https://avatars.githubusercontent.com/u/104945?v=3","gravatar_id":"","url":"https://api.github.com/users/runn1ng","html_url":"https://github.com/runn1ng","followers_url":"https://api.github.com/users/runn1ng/followers","following_url":"https://api.github.com/users/runn1ng/following{/other_user}","gists_url":"https://api.github.com/users/runn1ng/gists{/gist_id}","starred_url":"https://api.github.com/users/runn1ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runn1ng/subscriptions","organizations_url":"https://api.github.com/users/runn1ng/orgs","repos_url":"https://api.github.com/users/runn1ng/repos","events_url":"https://api.github.com/users/runn1ng/events{/privacy}","received_events_url":"https://api.github.com/users/runn1ng/received_events","type":"User","site_admin":false},"repo":{"id":51124191,"name":"bitcoinjs-lib","full_name":"runn1ng/bitcoinjs-lib","owner":{"login":"runn1ng","id":104945,"avatar_url":"https://avatars.githubusercontent.com/u/104945?v=3","gravatar_id":"","url":"https://api.github.com/users/runn1ng","html_url":"https://github.com/runn1ng","followers_url":"https://api.github.com/users/runn1ng/followers","following_url":"https://api.github.com/users/runn1ng/following{/other_user}","gists_url":"https://api.github.com/users/runn1ng/gists{/gist_id}","starred_url":"https://api.github.com/users/runn1ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runn1ng/subscriptions","organizations_url":"https://api.github.com/users/runn1ng/orgs","repos_url":"https://api.github.com/users/runn1ng/repos","events_url":"https://api.github.com/users/runn1ng/events{/privacy}","received_events_url":"https://api.github.com/users/runn1ng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/runn1ng/bitcoinjs-lib","description":"Bitcoin-related functions implemented in pure JavaScript","fork":true,"url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib","forks_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/releases{/id}","deployments_url":"https://api.github.com/repos/runn1ng/bitcoinjs-lib/deployments","created_at":"2016-02-05T03:41:16Z","updated_at":"2016-02-05T03:41:17Z","pushed_at":"2016-02-06T01:03:48Z","git_url":"git://github.com/runn1ng/bitcoinjs-lib.git","ssh_url":"git@github.com:runn1ng/bitcoinjs-lib.git","clone_url":"https://github.com/runn1ng/bitcoinjs-lib.git","svn_url":"https://github.com/runn1ng/bitcoinjs-lib","homepage":"http://bitcoinjs.org","size":2269,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoinjs:master","ref":"master","sha":"61d08fab949a746f389a3664d7193e62fa68b5b9","user":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1701968,"name":"bitcoinjs-lib","full_name":"bitcoinjs/bitcoinjs-lib","owner":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib","description":"Bitcoin-related functions implemented in pure JavaScript","fork":false,"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib","forks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/deployments","created_at":"2011-05-04T16:03:45Z","updated_at":"2016-02-05T16:08:21Z","pushed_at":"2016-02-06T01:08:04Z","git_url":"git://github.com/bitcoinjs/bitcoinjs-lib.git","ssh_url":"git@github.com:bitcoinjs/bitcoinjs-lib.git","clone_url":"https://github.com/bitcoinjs/bitcoinjs-lib.git","svn_url":"https://github.com/bitcoinjs/bitcoinjs-lib","homepage":"http://bitcoinjs.org","size":2730,"stargazers_count":1011,"watchers_count":1011,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":321,"mirror_url":null,"open_issues_count":21,"forks":321,"open_issues":21,"watchers":1011,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/538"},"html":{"href":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/538"},"issue":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/538"},"comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/cd51d9e477ae112c1806e65871909ae896ee4607"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":30,"deletions":2,"changed_files":3}}