{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/80309298","id":80309298,"diff_hunk":"@@ -0,0 +1,9 @@\n+// Type definitions for defaults 1.0.3\n+// Project: https://github.com/tmpvar/defaults/\n+// Definitions by: Ibtihel CHNAB <https://github.com/IbtihelCHNAB/>\n+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n+\n+declare function defaults(options: Object, defaultOptions: Object): Object;","path":"defaults/defaults.d.ts","position":6,"original_position":6,"commit_id":"752dc70e0c12486671feb41502da45f8173a8013","original_commit_id":"752dc70e0c12486671feb41502da45f8173a8013","user":{"login":"andy-ms","id":19274678,"avatar_url":"https://avatars.githubusercontent.com/u/19274678?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-ms","html_url":"https://github.com/andy-ms","followers_url":"https://api.github.com/users/andy-ms/followers","following_url":"https://api.github.com/users/andy-ms/following{/other_user}","gists_url":"https://api.github.com/users/andy-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-ms/subscriptions","organizations_url":"https://api.github.com/users/andy-ms/orgs","repos_url":"https://api.github.com/users/andy-ms/repos","events_url":"https://api.github.com/users/andy-ms/events{/privacy}","received_events_url":"https://api.github.com/users/andy-ms/received_events","type":"User","site_admin":false},"body":"This could be `declare function defaults<T>(options: any, defaultOptions: T): T`, assuming there is a default for every option. If not, still prefer `any` to `Object`: `declare function defaults(options: any, defaultOptions: any): any;`\r\n\r\nAs a side note, partial types (https://github.com/Microsoft/TypeScript/issues/4889) would make this easier, but they're not available yet.","created_at":"2016-09-23T19:15:52Z","updated_at":"2016-09-23T19:16:11Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/11451#discussion_r80309298","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/80309298"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/11451#discussion_r80309298"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451","id":86557043,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/11451","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/11451.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/11451.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/11451","number":11451,"state":"open","locked":false,"title":"Added definition file for Defaults Js Library","user":{"login":"IbtihelCHNAB","id":10076410,"avatar_url":"https://avatars.githubusercontent.com/u/10076410?v=3","gravatar_id":"","url":"https://api.github.com/users/IbtihelCHNAB","html_url":"https://github.com/IbtihelCHNAB","followers_url":"https://api.github.com/users/IbtihelCHNAB/followers","following_url":"https://api.github.com/users/IbtihelCHNAB/following{/other_user}","gists_url":"https://api.github.com/users/IbtihelCHNAB/gists{/gist_id}","starred_url":"https://api.github.com/users/IbtihelCHNAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IbtihelCHNAB/subscriptions","organizations_url":"https://api.github.com/users/IbtihelCHNAB/orgs","repos_url":"https://api.github.com/users/IbtihelCHNAB/repos","events_url":"https://api.github.com/users/IbtihelCHNAB/events{/privacy}","received_events_url":"https://api.github.com/users/IbtihelCHNAB/received_events","type":"User","site_admin":false},"body":"case 1. Add a new type definition.\r\n- [ ] checked compilation succeeds with `--target es6` and `--noImplicitAny` options.\r\n- [ ] has correct [naming convention](http://definitelytyped.org/guides/contributing.html#naming-the-file)\r\n- [ ] has a [test file](http://definitelytyped.org/guides/contributing.html#tests) with the suffix of  `-tests.ts` or `-tests.tsx`.\r\n\r\ncase 2. Improvement to existing type definition.\r\n- documentation or source code reference which provides context for the suggested changes.  url http://api.jquery.com/html .\r\n  - it has been reviewed by a DefinitelyTyped member.\r\n\r\n","created_at":"2016-09-23T18:13:29Z","updated_at":"2016-09-23T19:16:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7432fc307d7fda18f1ce169309fcb599a786ab26","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/11451/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/752dc70e0c12486671feb41502da45f8173a8013","head":{"label":"IbtihelCHNAB:feature/defaultsJS","ref":"feature/defaultsJS","sha":"752dc70e0c12486671feb41502da45f8173a8013","user":{"login":"IbtihelCHNAB","id":10076410,"avatar_url":"https://avatars.githubusercontent.com/u/10076410?v=3","gravatar_id":"","url":"https://api.github.com/users/IbtihelCHNAB","html_url":"https://github.com/IbtihelCHNAB","followers_url":"https://api.github.com/users/IbtihelCHNAB/followers","following_url":"https://api.github.com/users/IbtihelCHNAB/following{/other_user}","gists_url":"https://api.github.com/users/IbtihelCHNAB/gists{/gist_id}","starred_url":"https://api.github.com/users/IbtihelCHNAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IbtihelCHNAB/subscriptions","organizations_url":"https://api.github.com/users/IbtihelCHNAB/orgs","repos_url":"https://api.github.com/users/IbtihelCHNAB/repos","events_url":"https://api.github.com/users/IbtihelCHNAB/events{/privacy}","received_events_url":"https://api.github.com/users/IbtihelCHNAB/received_events","type":"User","site_admin":false},"repo":{"id":69048818,"name":"DefinitelyTyped","full_name":"IbtihelCHNAB/DefinitelyTyped","owner":{"login":"IbtihelCHNAB","id":10076410,"avatar_url":"https://avatars.githubusercontent.com/u/10076410?v=3","gravatar_id":"","url":"https://api.github.com/users/IbtihelCHNAB","html_url":"https://github.com/IbtihelCHNAB","followers_url":"https://api.github.com/users/IbtihelCHNAB/followers","following_url":"https://api.github.com/users/IbtihelCHNAB/following{/other_user}","gists_url":"https://api.github.com/users/IbtihelCHNAB/gists{/gist_id}","starred_url":"https://api.github.com/users/IbtihelCHNAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IbtihelCHNAB/subscriptions","organizations_url":"https://api.github.com/users/IbtihelCHNAB/orgs","repos_url":"https://api.github.com/users/IbtihelCHNAB/repos","events_url":"https://api.github.com/users/IbtihelCHNAB/events{/privacy}","received_events_url":"https://api.github.com/users/IbtihelCHNAB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IbtihelCHNAB/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped","forks_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/IbtihelCHNAB/DefinitelyTyped/deployments","created_at":"2016-09-23T18:02:04Z","updated_at":"2016-09-23T18:02:13Z","pushed_at":"2016-09-23T18:12:53Z","git_url":"git://github.com/IbtihelCHNAB/DefinitelyTyped.git","ssh_url":"git@github.com:IbtihelCHNAB/DefinitelyTyped.git","clone_url":"https://github.com/IbtihelCHNAB/DefinitelyTyped.git","svn_url":"https://github.com/IbtihelCHNAB/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":126173,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"8eedd1b9f7f009f14435f73c53a88d537c546a02","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2016-09-23T18:00:16Z","pushed_at":"2016-09-23T18:43:16Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":174871,"stargazers_count":8385,"watchers_count":8385,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6414,"mirror_url":null,"open_issues_count":969,"forks":6414,"open_issues":969,"watchers":8385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/11451"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/11451"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/11451/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/11451/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/752dc70e0c12486671feb41502da45f8173a8013"}}}}
{"actor":{"display_login":"andy-ms"}}