{"action":"created","comment":{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments/50791508","id":50791508,"diff_hunk":"@@ -173,13 +174,25 @@ private FilterExpression parseQualifier(Token token) {\n         qualifierName = qualifierName.substring(0, qualifierName.length() - 1).trim();\n \n         QualifierType type = QualifierType.parse(qualifierName).orElse(QualifierType.FALSE);\n-        return parseQualifierContent(type, false);\n+        if (type == QualifierType.SORT) {\n+            //special case for sort","path":"src/main/java/filter/Parser.java","position":14,"original_position":14,"commit_id":"6258a285df68119538310678a7ced7defe56f9bf","original_commit_id":"6258a285df68119538310678a7ced7defe56f9bf","user":{"login":"dariusf","id":4328341,"avatar_url":"https://avatars.githubusercontent.com/u/4328341?v=3","gravatar_id":"","url":"https://api.github.com/users/dariusf","html_url":"https://github.com/dariusf","followers_url":"https://api.github.com/users/dariusf/followers","following_url":"https://api.github.com/users/dariusf/following{/other_user}","gists_url":"https://api.github.com/users/dariusf/gists{/gist_id}","starred_url":"https://api.github.com/users/dariusf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariusf/subscriptions","organizations_url":"https://api.github.com/users/dariusf/orgs","repos_url":"https://api.github.com/users/dariusf/repos","events_url":"https://api.github.com/users/dariusf/events{/privacy}","received_events_url":"https://api.github.com/users/dariusf/received_events","type":"User","site_admin":false},"body":"The original special case was that sorting keys would only parse if preceded by `sort`.\r\n\r\nMore than one sort qualifier is a semantic error, no need to handle that in the parser. Ideally it could be handled somewhere down the line, but before it gets to UpdateController (which handles the logic of updates, and shouldn't be concerned with checking its inputs).\r\n\r\nWe should consider what happens when another qualifier is used with sorting keys though, e.g. `id:~id,repo`. Is this a parse error or a semantic error? Maybe it should be the latter, since we have the distinction now?","created_at":"2016-01-26T03:10:49Z","updated_at":"2016-01-26T03:10:49Z","html_url":"https://github.com/HubTurbo/HubTurbo/pull/1210#discussion_r50791508","pull_request_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210","_links":{"self":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments/50791508"},"html":{"href":"https://github.com/HubTurbo/HubTurbo/pull/1210#discussion_r50791508"},"pull_request":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210"}}},"pull_request":{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210","id":57030720,"html_url":"https://github.com/HubTurbo/HubTurbo/pull/1210","diff_url":"https://github.com/HubTurbo/HubTurbo/pull/1210.diff","patch_url":"https://github.com/HubTurbo/HubTurbo/pull/1210.patch","issue_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1210","number":1210,"state":"open","locked":false,"title":"filter syntax: Support a shorter form of OR #1137","user":{"login":"raisfathin","id":9299240,"avatar_url":"https://avatars.githubusercontent.com/u/9299240?v=3","gravatar_id":"","url":"https://api.github.com/users/raisfathin","html_url":"https://github.com/raisfathin","followers_url":"https://api.github.com/users/raisfathin/followers","following_url":"https://api.github.com/users/raisfathin/following{/other_user}","gists_url":"https://api.github.com/users/raisfathin/gists{/gist_id}","starred_url":"https://api.github.com/users/raisfathin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raisfathin/subscriptions","organizations_url":"https://api.github.com/users/raisfathin/orgs","repos_url":"https://api.github.com/users/raisfathin/repos","events_url":"https://api.github.com/users/raisfathin/events{/privacy}","received_events_url":"https://api.github.com/users/raisfathin/received_events","type":"User","site_admin":false},"body":"Fixes #1137 \r\n\r\nStill has problems in parsing quoted content because the parser currently doesn't parse quoted content exactly as typed by the user as described at #1137. Also depends on #1194.","created_at":"2016-01-25T05:39:59Z","updated_at":"2016-01-26T03:10:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaf030d6b185a91ba80a7e3976d27695ca44eb65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210/commits","review_comments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210/comments","review_comment_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1210/comments","statuses_url":"https://api.github.com/repos/HubTurbo/HubTurbo/statuses/6258a285df68119538310678a7ced7defe56f9bf","head":{"label":"raisfathin:1137-support-shorter-form-of-or","ref":"1137-support-shorter-form-of-or","sha":"6258a285df68119538310678a7ced7defe56f9bf","user":{"login":"raisfathin","id":9299240,"avatar_url":"https://avatars.githubusercontent.com/u/9299240?v=3","gravatar_id":"","url":"https://api.github.com/users/raisfathin","html_url":"https://github.com/raisfathin","followers_url":"https://api.github.com/users/raisfathin/followers","following_url":"https://api.github.com/users/raisfathin/following{/other_user}","gists_url":"https://api.github.com/users/raisfathin/gists{/gist_id}","starred_url":"https://api.github.com/users/raisfathin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raisfathin/subscriptions","organizations_url":"https://api.github.com/users/raisfathin/orgs","repos_url":"https://api.github.com/users/raisfathin/repos","events_url":"https://api.github.com/users/raisfathin/events{/privacy}","received_events_url":"https://api.github.com/users/raisfathin/received_events","type":"User","site_admin":false},"repo":{"id":49590110,"name":"HubTurbo","full_name":"raisfathin/HubTurbo","owner":{"login":"raisfathin","id":9299240,"avatar_url":"https://avatars.githubusercontent.com/u/9299240?v=3","gravatar_id":"","url":"https://api.github.com/users/raisfathin","html_url":"https://github.com/raisfathin","followers_url":"https://api.github.com/users/raisfathin/followers","following_url":"https://api.github.com/users/raisfathin/following{/other_user}","gists_url":"https://api.github.com/users/raisfathin/gists{/gist_id}","starred_url":"https://api.github.com/users/raisfathin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raisfathin/subscriptions","organizations_url":"https://api.github.com/users/raisfathin/orgs","repos_url":"https://api.github.com/users/raisfathin/repos","events_url":"https://api.github.com/users/raisfathin/events{/privacy}","received_events_url":"https://api.github.com/users/raisfathin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raisfathin/HubTurbo","description":"A companion to GitHub for your desktop","fork":true,"url":"https://api.github.com/repos/raisfathin/HubTurbo","forks_url":"https://api.github.com/repos/raisfathin/HubTurbo/forks","keys_url":"https://api.github.com/repos/raisfathin/HubTurbo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raisfathin/HubTurbo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raisfathin/HubTurbo/teams","hooks_url":"https://api.github.com/repos/raisfathin/HubTurbo/hooks","issue_events_url":"https://api.github.com/repos/raisfathin/HubTurbo/issues/events{/number}","events_url":"https://api.github.com/repos/raisfathin/HubTurbo/events","assignees_url":"https://api.github.com/repos/raisfathin/HubTurbo/assignees{/user}","branches_url":"https://api.github.com/repos/raisfathin/HubTurbo/branches{/branch}","tags_url":"https://api.github.com/repos/raisfathin/HubTurbo/tags","blobs_url":"https://api.github.com/repos/raisfathin/HubTurbo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raisfathin/HubTurbo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raisfathin/HubTurbo/git/refs{/sha}","trees_url":"https://api.github.com/repos/raisfathin/HubTurbo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raisfathin/HubTurbo/statuses/{sha}","languages_url":"https://api.github.com/repos/raisfathin/HubTurbo/languages","stargazers_url":"https://api.github.com/repos/raisfathin/HubTurbo/stargazers","contributors_url":"https://api.github.com/repos/raisfathin/HubTurbo/contributors","subscribers_url":"https://api.github.com/repos/raisfathin/HubTurbo/subscribers","subscription_url":"https://api.github.com/repos/raisfathin/HubTurbo/subscription","commits_url":"https://api.github.com/repos/raisfathin/HubTurbo/commits{/sha}","git_commits_url":"https://api.github.com/repos/raisfathin/HubTurbo/git/commits{/sha}","comments_url":"https://api.github.com/repos/raisfathin/HubTurbo/comments{/number}","issue_comment_url":"https://api.github.com/repos/raisfathin/HubTurbo/issues/comments{/number}","contents_url":"https://api.github.com/repos/raisfathin/HubTurbo/contents/{+path}","compare_url":"https://api.github.com/repos/raisfathin/HubTurbo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raisfathin/HubTurbo/merges","archive_url":"https://api.github.com/repos/raisfathin/HubTurbo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raisfathin/HubTurbo/downloads","issues_url":"https://api.github.com/repos/raisfathin/HubTurbo/issues{/number}","pulls_url":"https://api.github.com/repos/raisfathin/HubTurbo/pulls{/number}","milestones_url":"https://api.github.com/repos/raisfathin/HubTurbo/milestones{/number}","notifications_url":"https://api.github.com/repos/raisfathin/HubTurbo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raisfathin/HubTurbo/labels{/name}","releases_url":"https://api.github.com/repos/raisfathin/HubTurbo/releases{/id}","deployments_url":"https://api.github.com/repos/raisfathin/HubTurbo/deployments","created_at":"2016-01-13T17:32:35Z","updated_at":"2016-01-13T17:32:38Z","pushed_at":"2016-01-25T23:04:01Z","git_url":"git://github.com/raisfathin/HubTurbo.git","ssh_url":"git@github.com:raisfathin/HubTurbo.git","clone_url":"https://github.com/raisfathin/HubTurbo.git","svn_url":"https://github.com/raisfathin/HubTurbo","homepage":"http://hubturbo.info","size":132588,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HubTurbo:master","ref":"master","sha":"bffed8b2e9e76e7c8d6a703062d39d92c5af058c","user":{"login":"HubTurbo","id":7955871,"avatar_url":"https://avatars.githubusercontent.com/u/7955871?v=3","gravatar_id":"","url":"https://api.github.com/users/HubTurbo","html_url":"https://github.com/HubTurbo","followers_url":"https://api.github.com/users/HubTurbo/followers","following_url":"https://api.github.com/users/HubTurbo/following{/other_user}","gists_url":"https://api.github.com/users/HubTurbo/gists{/gist_id}","starred_url":"https://api.github.com/users/HubTurbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubTurbo/subscriptions","organizations_url":"https://api.github.com/users/HubTurbo/orgs","repos_url":"https://api.github.com/users/HubTurbo/repos","events_url":"https://api.github.com/users/HubTurbo/events{/privacy}","received_events_url":"https://api.github.com/users/HubTurbo/received_events","type":"Organization","site_admin":false},"repo":{"id":20919534,"name":"HubTurbo","full_name":"HubTurbo/HubTurbo","owner":{"login":"HubTurbo","id":7955871,"avatar_url":"https://avatars.githubusercontent.com/u/7955871?v=3","gravatar_id":"","url":"https://api.github.com/users/HubTurbo","html_url":"https://github.com/HubTurbo","followers_url":"https://api.github.com/users/HubTurbo/followers","following_url":"https://api.github.com/users/HubTurbo/following{/other_user}","gists_url":"https://api.github.com/users/HubTurbo/gists{/gist_id}","starred_url":"https://api.github.com/users/HubTurbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubTurbo/subscriptions","organizations_url":"https://api.github.com/users/HubTurbo/orgs","repos_url":"https://api.github.com/users/HubTurbo/repos","events_url":"https://api.github.com/users/HubTurbo/events{/privacy}","received_events_url":"https://api.github.com/users/HubTurbo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubTurbo/HubTurbo","description":"A companion to GitHub for your desktop","fork":false,"url":"https://api.github.com/repos/HubTurbo/HubTurbo","forks_url":"https://api.github.com/repos/HubTurbo/HubTurbo/forks","keys_url":"https://api.github.com/repos/HubTurbo/HubTurbo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubTurbo/HubTurbo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubTurbo/HubTurbo/teams","hooks_url":"https://api.github.com/repos/HubTurbo/HubTurbo/hooks","issue_events_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/events{/number}","events_url":"https://api.github.com/repos/HubTurbo/HubTurbo/events","assignees_url":"https://api.github.com/repos/HubTurbo/HubTurbo/assignees{/user}","branches_url":"https://api.github.com/repos/HubTurbo/HubTurbo/branches{/branch}","tags_url":"https://api.github.com/repos/HubTurbo/HubTurbo/tags","blobs_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubTurbo/HubTurbo/statuses/{sha}","languages_url":"https://api.github.com/repos/HubTurbo/HubTurbo/languages","stargazers_url":"https://api.github.com/repos/HubTurbo/HubTurbo/stargazers","contributors_url":"https://api.github.com/repos/HubTurbo/HubTurbo/contributors","subscribers_url":"https://api.github.com/repos/HubTurbo/HubTurbo/subscribers","subscription_url":"https://api.github.com/repos/HubTurbo/HubTurbo/subscription","commits_url":"https://api.github.com/repos/HubTurbo/HubTurbo/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubTurbo/HubTurbo/contents/{+path}","compare_url":"https://api.github.com/repos/HubTurbo/HubTurbo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubTurbo/HubTurbo/merges","archive_url":"https://api.github.com/repos/HubTurbo/HubTurbo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubTurbo/HubTurbo/downloads","issues_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues{/number}","pulls_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls{/number}","milestones_url":"https://api.github.com/repos/HubTurbo/HubTurbo/milestones{/number}","notifications_url":"https://api.github.com/repos/HubTurbo/HubTurbo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubTurbo/HubTurbo/labels{/name}","releases_url":"https://api.github.com/repos/HubTurbo/HubTurbo/releases{/id}","deployments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/deployments","created_at":"2014-06-17T10:35:39Z","updated_at":"2016-01-13T06:03:59Z","pushed_at":"2016-01-25T23:04:02Z","git_url":"git://github.com/HubTurbo/HubTurbo.git","ssh_url":"git@github.com:HubTurbo/HubTurbo.git","clone_url":"https://github.com/HubTurbo/HubTurbo.git","svn_url":"https://github.com/HubTurbo/HubTurbo","homepage":"http://hubturbo.info","size":132783,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":146,"forks":22,"open_issues":146,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210"},"html":{"href":"https://github.com/HubTurbo/HubTurbo/pull/1210"},"issue":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1210"},"comments":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1210/comments"},"review_comments":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210/comments"},"review_comment":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1210/commits"},"statuses":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/statuses/6258a285df68119538310678a7ced7defe56f9bf"}}}}