{"action":"closed","number":550,"pull_request":{"url":"https://api.github.com/repos/typhoeus/typhoeus/pulls/550","id":95629057,"html_url":"https://github.com/typhoeus/typhoeus/pull/550","diff_url":"https://github.com/typhoeus/typhoeus/pull/550.diff","patch_url":"https://github.com/typhoeus/typhoeus/pull/550.patch","issue_url":"https://api.github.com/repos/typhoeus/typhoeus/issues/550","number":550,"state":"closed","locked":false,"title":"Faraday adapter should accept Typhoeus options for every request","user":{"login":"soedar","id":571891,"avatar_url":"https://avatars.githubusercontent.com/u/571891?v=3","gravatar_id":"","url":"https://api.github.com/users/soedar","html_url":"https://github.com/soedar","followers_url":"https://api.github.com/users/soedar/followers","following_url":"https://api.github.com/users/soedar/following{/other_user}","gists_url":"https://api.github.com/users/soedar/gists{/gist_id}","starred_url":"https://api.github.com/users/soedar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soedar/subscriptions","organizations_url":"https://api.github.com/users/soedar/orgs","repos_url":"https://api.github.com/users/soedar/repos","events_url":"https://api.github.com/users/soedar/events{/privacy}","received_events_url":"https://api.github.com/users/soedar/received_events","type":"User","site_admin":false},"body":"Fixes #549 \r\n\r\nThis is actually quite similar to #463. I'm not quite sure how Faraday/Typhoeus handles SSL request, and so did not incorporate that PR changes here. \r\n\r\nFor this PR, it _seems_ like Typhoeus SSL's settings specified in the options would be overridden by Faraday's SSL settings in the `configure_ssl` method. If that's the case, we should make this behavior clear explicit, i.e. SSL settings should be configured via Faraday.","created_at":"2016-11-29T05:31:37Z","updated_at":"2016-12-02T12:46:20Z","closed_at":"2016-12-02T12:46:20Z","merged_at":"2016-12-02T12:46:20Z","merge_commit_sha":"7cdda7aa032d756d7b25ac2def9e37f9dfbe07f6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/typhoeus/typhoeus/pulls/550/commits","review_comments_url":"https://api.github.com/repos/typhoeus/typhoeus/pulls/550/comments","review_comment_url":"https://api.github.com/repos/typhoeus/typhoeus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typhoeus/typhoeus/issues/550/comments","statuses_url":"https://api.github.com/repos/typhoeus/typhoeus/statuses/ee47d6348ccfc7aea3d9a45cae0a62f5f2a36e46","head":{"label":"soedar:faraday-pass-options","ref":"faraday-pass-options","sha":"ee47d6348ccfc7aea3d9a45cae0a62f5f2a36e46","user":{"login":"soedar","id":571891,"avatar_url":"https://avatars.githubusercontent.com/u/571891?v=3","gravatar_id":"","url":"https://api.github.com/users/soedar","html_url":"https://github.com/soedar","followers_url":"https://api.github.com/users/soedar/followers","following_url":"https://api.github.com/users/soedar/following{/other_user}","gists_url":"https://api.github.com/users/soedar/gists{/gist_id}","starred_url":"https://api.github.com/users/soedar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soedar/subscriptions","organizations_url":"https://api.github.com/users/soedar/orgs","repos_url":"https://api.github.com/users/soedar/repos","events_url":"https://api.github.com/users/soedar/events{/privacy}","received_events_url":"https://api.github.com/users/soedar/received_events","type":"User","site_admin":false},"repo":{"id":74951421,"name":"typhoeus","full_name":"soedar/typhoeus","owner":{"login":"soedar","id":571891,"avatar_url":"https://avatars.githubusercontent.com/u/571891?v=3","gravatar_id":"","url":"https://api.github.com/users/soedar","html_url":"https://github.com/soedar","followers_url":"https://api.github.com/users/soedar/followers","following_url":"https://api.github.com/users/soedar/following{/other_user}","gists_url":"https://api.github.com/users/soedar/gists{/gist_id}","starred_url":"https://api.github.com/users/soedar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soedar/subscriptions","organizations_url":"https://api.github.com/users/soedar/orgs","repos_url":"https://api.github.com/users/soedar/repos","events_url":"https://api.github.com/users/soedar/events{/privacy}","received_events_url":"https://api.github.com/users/soedar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soedar/typhoeus","description":" Typhoeus wraps libcurl in order to make fast and reliable requests.","fork":true,"url":"https://api.github.com/repos/soedar/typhoeus","forks_url":"https://api.github.com/repos/soedar/typhoeus/forks","keys_url":"https://api.github.com/repos/soedar/typhoeus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soedar/typhoeus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soedar/typhoeus/teams","hooks_url":"https://api.github.com/repos/soedar/typhoeus/hooks","issue_events_url":"https://api.github.com/repos/soedar/typhoeus/issues/events{/number}","events_url":"https://api.github.com/repos/soedar/typhoeus/events","assignees_url":"https://api.github.com/repos/soedar/typhoeus/assignees{/user}","branches_url":"https://api.github.com/repos/soedar/typhoeus/branches{/branch}","tags_url":"https://api.github.com/repos/soedar/typhoeus/tags","blobs_url":"https://api.github.com/repos/soedar/typhoeus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soedar/typhoeus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soedar/typhoeus/git/refs{/sha}","trees_url":"https://api.github.com/repos/soedar/typhoeus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soedar/typhoeus/statuses/{sha}","languages_url":"https://api.github.com/repos/soedar/typhoeus/languages","stargazers_url":"https://api.github.com/repos/soedar/typhoeus/stargazers","contributors_url":"https://api.github.com/repos/soedar/typhoeus/contributors","subscribers_url":"https://api.github.com/repos/soedar/typhoeus/subscribers","subscription_url":"https://api.github.com/repos/soedar/typhoeus/subscription","commits_url":"https://api.github.com/repos/soedar/typhoeus/commits{/sha}","git_commits_url":"https://api.github.com/repos/soedar/typhoeus/git/commits{/sha}","comments_url":"https://api.github.com/repos/soedar/typhoeus/comments{/number}","issue_comment_url":"https://api.github.com/repos/soedar/typhoeus/issues/comments{/number}","contents_url":"https://api.github.com/repos/soedar/typhoeus/contents/{+path}","compare_url":"https://api.github.com/repos/soedar/typhoeus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soedar/typhoeus/merges","archive_url":"https://api.github.com/repos/soedar/typhoeus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soedar/typhoeus/downloads","issues_url":"https://api.github.com/repos/soedar/typhoeus/issues{/number}","pulls_url":"https://api.github.com/repos/soedar/typhoeus/pulls{/number}","milestones_url":"https://api.github.com/repos/soedar/typhoeus/milestones{/number}","notifications_url":"https://api.github.com/repos/soedar/typhoeus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soedar/typhoeus/labels{/name}","releases_url":"https://api.github.com/repos/soedar/typhoeus/releases{/id}","deployments_url":"https://api.github.com/repos/soedar/typhoeus/deployments","created_at":"2016-11-28T08:12:45Z","updated_at":"2016-11-28T08:12:46Z","pushed_at":"2016-11-29T05:20:48Z","git_url":"git://github.com/soedar/typhoeus.git","ssh_url":"git@github.com:soedar/typhoeus.git","clone_url":"https://github.com/soedar/typhoeus.git","svn_url":"https://github.com/soedar/typhoeus","homepage":"http://rubydoc.info/github/typhoeus/typhoeus","size":1391,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typhoeus:master","ref":"master","sha":"237d835ec95b2f9494bcffd498482db0758a1f06","user":{"login":"typhoeus","id":1745513,"avatar_url":"https://avatars.githubusercontent.com/u/1745513?v=3","gravatar_id":"","url":"https://api.github.com/users/typhoeus","html_url":"https://github.com/typhoeus","followers_url":"https://api.github.com/users/typhoeus/followers","following_url":"https://api.github.com/users/typhoeus/following{/other_user}","gists_url":"https://api.github.com/users/typhoeus/gists{/gist_id}","starred_url":"https://api.github.com/users/typhoeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typhoeus/subscriptions","organizations_url":"https://api.github.com/users/typhoeus/orgs","repos_url":"https://api.github.com/users/typhoeus/repos","events_url":"https://api.github.com/users/typhoeus/events{/privacy}","received_events_url":"https://api.github.com/users/typhoeus/received_events","type":"Organization","site_admin":false},"repo":{"id":132108,"name":"typhoeus","full_name":"typhoeus/typhoeus","owner":{"login":"typhoeus","id":1745513,"avatar_url":"https://avatars.githubusercontent.com/u/1745513?v=3","gravatar_id":"","url":"https://api.github.com/users/typhoeus","html_url":"https://github.com/typhoeus","followers_url":"https://api.github.com/users/typhoeus/followers","following_url":"https://api.github.com/users/typhoeus/following{/other_user}","gists_url":"https://api.github.com/users/typhoeus/gists{/gist_id}","starred_url":"https://api.github.com/users/typhoeus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typhoeus/subscriptions","organizations_url":"https://api.github.com/users/typhoeus/orgs","repos_url":"https://api.github.com/users/typhoeus/repos","events_url":"https://api.github.com/users/typhoeus/events{/privacy}","received_events_url":"https://api.github.com/users/typhoeus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/typhoeus/typhoeus","description":" Typhoeus wraps libcurl in order to make fast and reliable requests.","fork":false,"url":"https://api.github.com/repos/typhoeus/typhoeus","forks_url":"https://api.github.com/repos/typhoeus/typhoeus/forks","keys_url":"https://api.github.com/repos/typhoeus/typhoeus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typhoeus/typhoeus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typhoeus/typhoeus/teams","hooks_url":"https://api.github.com/repos/typhoeus/typhoeus/hooks","issue_events_url":"https://api.github.com/repos/typhoeus/typhoeus/issues/events{/number}","events_url":"https://api.github.com/repos/typhoeus/typhoeus/events","assignees_url":"https://api.github.com/repos/typhoeus/typhoeus/assignees{/user}","branches_url":"https://api.github.com/repos/typhoeus/typhoeus/branches{/branch}","tags_url":"https://api.github.com/repos/typhoeus/typhoeus/tags","blobs_url":"https://api.github.com/repos/typhoeus/typhoeus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typhoeus/typhoeus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typhoeus/typhoeus/git/refs{/sha}","trees_url":"https://api.github.com/repos/typhoeus/typhoeus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typhoeus/typhoeus/statuses/{sha}","languages_url":"https://api.github.com/repos/typhoeus/typhoeus/languages","stargazers_url":"https://api.github.com/repos/typhoeus/typhoeus/stargazers","contributors_url":"https://api.github.com/repos/typhoeus/typhoeus/contributors","subscribers_url":"https://api.github.com/repos/typhoeus/typhoeus/subscribers","subscription_url":"https://api.github.com/repos/typhoeus/typhoeus/subscription","commits_url":"https://api.github.com/repos/typhoeus/typhoeus/commits{/sha}","git_commits_url":"https://api.github.com/repos/typhoeus/typhoeus/git/commits{/sha}","comments_url":"https://api.github.com/repos/typhoeus/typhoeus/comments{/number}","issue_comment_url":"https://api.github.com/repos/typhoeus/typhoeus/issues/comments{/number}","contents_url":"https://api.github.com/repos/typhoeus/typhoeus/contents/{+path}","compare_url":"https://api.github.com/repos/typhoeus/typhoeus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typhoeus/typhoeus/merges","archive_url":"https://api.github.com/repos/typhoeus/typhoeus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typhoeus/typhoeus/downloads","issues_url":"https://api.github.com/repos/typhoeus/typhoeus/issues{/number}","pulls_url":"https://api.github.com/repos/typhoeus/typhoeus/pulls{/number}","milestones_url":"https://api.github.com/repos/typhoeus/typhoeus/milestones{/number}","notifications_url":"https://api.github.com/repos/typhoeus/typhoeus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typhoeus/typhoeus/labels{/name}","releases_url":"https://api.github.com/repos/typhoeus/typhoeus/releases{/id}","deployments_url":"https://api.github.com/repos/typhoeus/typhoeus/deployments","created_at":"2009-02-18T23:14:50Z","updated_at":"2016-12-01T11:43:13Z","pushed_at":"2016-12-02T12:46:20Z","git_url":"git://github.com/typhoeus/typhoeus.git","ssh_url":"git@github.com:typhoeus/typhoeus.git","clone_url":"https://github.com/typhoeus/typhoeus.git","svn_url":"https://github.com/typhoeus/typhoeus","homepage":"http://rubydoc.info/github/typhoeus/typhoeus","size":1931,"stargazers_count":2943,"watchers_count":2943,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":61,"forks":331,"open_issues":61,"watchers":2943,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typhoeus/typhoeus/pulls/550"},"html":{"href":"https://github.com/typhoeus/typhoeus/pull/550"},"issue":{"href":"https://api.github.com/repos/typhoeus/typhoeus/issues/550"},"comments":{"href":"https://api.github.com/repos/typhoeus/typhoeus/issues/550/comments"},"review_comments":{"href":"https://api.github.com/repos/typhoeus/typhoeus/pulls/550/comments"},"review_comment":{"href":"https://api.github.com/repos/typhoeus/typhoeus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typhoeus/typhoeus/pulls/550/commits"},"statuses":{"href":"https://api.github.com/repos/typhoeus/typhoeus/statuses/ee47d6348ccfc7aea3d9a45cae0a62f5f2a36e46"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"i0rek","id":38218,"avatar_url":"https://avatars.githubusercontent.com/u/38218?v=3","gravatar_id":"","url":"https://api.github.com/users/i0rek","html_url":"https://github.com/i0rek","followers_url":"https://api.github.com/users/i0rek/followers","following_url":"https://api.github.com/users/i0rek/following{/other_user}","gists_url":"https://api.github.com/users/i0rek/gists{/gist_id}","starred_url":"https://api.github.com/users/i0rek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i0rek/subscriptions","organizations_url":"https://api.github.com/users/i0rek/orgs","repos_url":"https://api.github.com/users/i0rek/repos","events_url":"https://api.github.com/users/i0rek/events{/privacy}","received_events_url":"https://api.github.com/users/i0rek/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":39,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"i0rek"}}