{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/69396950","id":69396950,"diff_hunk":"@@ -0,0 +1,35 @@\n+{ stdenv, fetchurl, static ? true }:\n+\n+with stdenv.lib;\n+\n+stdenv.mkDerivation rec {\n+  name = \"libjpeg-drop-9b\";\n+\n+  srcs = [\n+    (fetchurl {\n+      url = http://www.ijg.org/files/jpegsrc.v9b.tar.gz;\n+      sha256 = \"0lnhpahgdwlrkd41lx6cr90r199f8mc6ydlh7jznj5klvacd63r4\";\n+    })\n+    (fetchurl {\n+      url = http://jpegclub.org/droppatch.v9b.tar.gz;\n+      sha256 = \"022bnvpird7w5pwbfqpq7j7pwja5kp6x9k3sdypcy3g2nwwy2wwk\";\n+    })\n+  ];\n+\n+  postUnpack = ''\n+    rm jpegtran\n+    mv jpegtran.c jpeg-9b/jpegtran.c\n+    mv transupp.c jpeg-9b/transupp.c\n+    mv transupp.h jpeg-9b/transupp.h\n+  '';\n+\n+  configureFlags = optional static \"--enable-static --disable-shared\";","path":"pkgs/development/libraries/libjpeg-drop/default.nix","position":26,"original_position":26,"commit_id":"06595cc2199db56c62d3e9536576ac27f105bced","original_commit_id":"06595cc2199db56c62d3e9536576ac27f105bced","user":{"login":"joachifm","id":41977,"avatar_url":"https://avatars.githubusercontent.com/u/41977?v=3","gravatar_id":"","url":"https://api.github.com/users/joachifm","html_url":"https://github.com/joachifm","followers_url":"https://api.github.com/users/joachifm/followers","following_url":"https://api.github.com/users/joachifm/following{/other_user}","gists_url":"https://api.github.com/users/joachifm/gists{/gist_id}","starred_url":"https://api.github.com/users/joachifm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachifm/subscriptions","organizations_url":"https://api.github.com/users/joachifm/orgs","repos_url":"https://api.github.com/users/joachifm/repos","events_url":"https://api.github.com/users/joachifm/events{/privacy}","received_events_url":"https://api.github.com/users/joachifm/received_events","type":"User","site_admin":false},"body":"An alternative approach is to add a static output.","created_at":"2016-07-03T20:39:23Z","updated_at":"2016-07-03T20:39:23Z","html_url":"https://github.com/NixOS/nixpkgs/pull/16671#discussion_r69396950","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/69396950"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/16671#discussion_r69396950"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671","id":76079169,"html_url":"https://github.com/NixOS/nixpkgs/pull/16671","diff_url":"https://github.com/NixOS/nixpkgs/pull/16671.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/16671.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/16671","number":16671,"state":"open","locked":false,"title":"libjpeg-drop: init at 9b","user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nThese patches supplement _jpegtran_ with the _--drop_ flag that allows dropping (pasting) of blocks from one jpeg to the next without re-compression.\r\n\r\nNote the patches are supplied by the JPEGclub.org who also maintain the Independent JPEG Group's libjpeg itself. See http://jpegclub.org http://www.ijg.org/ http://jpegclub.org/jpegtran/\r\n\r\nNotes on different libjpeg versions and varieties:\r\n* pkgs/development/libraries/libjpeg/default.nix is libjpeg version 8d dating back to 2012.\r\n* pkgs/development/libraries/libjpeg/62.nix is libjpeg version 6n dating back to 2002.\r\n* pkgs/development/libraries/libjpeg-turbo/default.nix is a fork of 8 series libjpeg with ongoing effort on performance (SMID instructions and other improvements) and correctness with respect to the older APIs.\r\n* pkgs/development/libraries/libjpeg-drop/default.nix is a recent libjpeg version 9b dating 2016 with additional experimental drop patches.\r\n\r\n(dates from http://www.ijg.org/files/)\r\n\r\nPractically speaking, most of the linux ecosystem depends on libjpeg-turbo or the 8 series libjpeg APIs. For this package's purposes, the interest is in the _transjpeg_ binary which is why the package is also set to compile statically by default.\r\n\r\nThe issue on 8vs9 series is further discussed in http://www.libjpeg-turbo.org/About/Jpeg-9 .\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [x] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n","created_at":"2016-07-03T02:26:50Z","updated_at":"2016-07-03T20:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a39696dd55ad2434063aad5e0d8f736d33ad2892","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/16671/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/06595cc2199db56c62d3e9536576ac27f105bced","head":{"label":"RamKromberg:init/libjpeg-drop","ref":"init/libjpeg-drop","sha":"06595cc2199db56c62d3e9536576ac27f105bced","user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"repo":{"id":62384289,"name":"nixpkgs","full_name":"RamKromberg/nixpkgs","owner":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RamKromberg/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/RamKromberg/nixpkgs","forks_url":"https://api.github.com/repos/RamKromberg/nixpkgs/forks","keys_url":"https://api.github.com/repos/RamKromberg/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RamKromberg/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RamKromberg/nixpkgs/teams","hooks_url":"https://api.github.com/repos/RamKromberg/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/RamKromberg/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/RamKromberg/nixpkgs/events","assignees_url":"https://api.github.com/repos/RamKromberg/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/RamKromberg/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/RamKromberg/nixpkgs/tags","blobs_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RamKromberg/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/RamKromberg/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/RamKromberg/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/RamKromberg/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/RamKromberg/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/RamKromberg/nixpkgs/subscription","commits_url":"https://api.github.com/repos/RamKromberg/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/RamKromberg/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/RamKromberg/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/RamKromberg/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/RamKromberg/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RamKromberg/nixpkgs/merges","archive_url":"https://api.github.com/repos/RamKromberg/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RamKromberg/nixpkgs/downloads","issues_url":"https://api.github.com/repos/RamKromberg/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/RamKromberg/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/RamKromberg/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/RamKromberg/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RamKromberg/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/RamKromberg/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/RamKromberg/nixpkgs/deployments","created_at":"2016-07-01T10:09:30Z","updated_at":"2016-07-01T10:09:54Z","pushed_at":"2016-07-03T01:57:59Z","git_url":"git://github.com/RamKromberg/nixpkgs.git","ssh_url":"git@github.com:RamKromberg/nixpkgs.git","clone_url":"https://github.com/RamKromberg/nixpkgs.git","svn_url":"https://github.com/RamKromberg/nixpkgs","homepage":null,"size":374653,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"def310df459f649a4ce2df8b7ba19aa8e4d5af58","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-07-03T00:24:59Z","pushed_at":"2016-07-03T20:35:22Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":581233,"stargazers_count":1175,"watchers_count":1175,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1485,"mirror_url":null,"open_issues_count":1520,"forks":1485,"open_issues":1520,"watchers":1175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/16671"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/16671"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/16671/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16671/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/06595cc2199db56c62d3e9536576ac27f105bced"}}}}
{"actor":{"display_login":"joachifm"}}