{"action":"created","comment":{"url":"https://api.github.com/repos/remind101/stacker/pulls/comments/76349697","id":76349697,"diff_hunk":"@@ -98,13 +104,15 @@ class Blueprint(object):\n             template.\n \n     \"\"\"\n-    def __init__(self, name, context, mappings=None):\n+\n+    def __init__(self, name, context, variables=None, mappings=None):","path":"stacker/blueprints/base.py","position":28,"original_position":28,"commit_id":"4b857fe11e237eec267f837732e3cfc3d3451f2a","original_commit_id":"4b857fe11e237eec267f837732e3cfc3d3451f2a","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"body":"this isn't used","created_at":"2016-08-26T00:43:08Z","updated_at":"2016-08-26T00:43:08Z","html_url":"https://github.com/remind101/stacker/pull/194#discussion_r76349697","pull_request_url":"https://api.github.com/repos/remind101/stacker/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/remind101/stacker/pulls/comments/76349697"},"html":{"href":"https://github.com/remind101/stacker/pull/194#discussion_r76349697"},"pull_request":{"href":"https://api.github.com/repos/remind101/stacker/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/remind101/stacker/pulls/194","id":81064319,"html_url":"https://github.com/remind101/stacker/pull/194","diff_url":"https://github.com/remind101/stacker/pull/194.diff","patch_url":"https://github.com/remind101/stacker/pull/194.patch","issue_url":"https://api.github.com/repos/remind101/stacker/issues/194","number":194,"state":"open","locked":false,"title":"Implement new BLUEPRINT_PARAMETERS","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"body":"These will deprecate PARAMETERS and LOCAL_PARAMETERS.\r\n\r\nAdvantages:\r\n- No need to use CF parameters\r\n- Leverage yaml lists and dicts\r\n- Blueprint subclasses can easily add/overwrite parameters\r\n\r\nFixes: https://github.com/remind101/stacker/issues/175\r\n\r\nI added: https://github.com/remind101/stacker_blueprints/pull/24/commits/93db0d2b385f6eb769893de27b756aa5493fe638 to stacker_blueprints as a POC for showing how we can leverage the new `BLUEPRINT_PARAMETERS`","created_at":"2016-08-12T03:45:40Z","updated_at":"2016-08-26T00:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6137940f9f7e9b16e70f6ae40f42b1dbc5e47381","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/remind101/stacker/pulls/194/commits","review_comments_url":"https://api.github.com/repos/remind101/stacker/pulls/194/comments","review_comment_url":"https://api.github.com/repos/remind101/stacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/remind101/stacker/issues/194/comments","statuses_url":"https://api.github.com/repos/remind101/stacker/statuses/4b857fe11e237eec267f837732e3cfc3d3451f2a","head":{"label":"mhahn:blueprint-parameters","ref":"blueprint-parameters","sha":"4b857fe11e237eec267f837732e3cfc3d3451f2a","user":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"repo":{"id":33085705,"name":"stacker","full_name":"mhahn/stacker","owner":{"login":"mhahn","id":704593,"avatar_url":"https://avatars.githubusercontent.com/u/704593?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahn","html_url":"https://github.com/mhahn","followers_url":"https://api.github.com/users/mhahn/followers","following_url":"https://api.github.com/users/mhahn/following{/other_user}","gists_url":"https://api.github.com/users/mhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahn/subscriptions","organizations_url":"https://api.github.com/users/mhahn/orgs","repos_url":"https://api.github.com/users/mhahn/repos","events_url":"https://api.github.com/users/mhahn/events{/privacy}","received_events_url":"https://api.github.com/users/mhahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhahn/stacker","description":"An opinionated AWS CloudFormation Stack builder.","fork":true,"url":"https://api.github.com/repos/mhahn/stacker","forks_url":"https://api.github.com/repos/mhahn/stacker/forks","keys_url":"https://api.github.com/repos/mhahn/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhahn/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhahn/stacker/teams","hooks_url":"https://api.github.com/repos/mhahn/stacker/hooks","issue_events_url":"https://api.github.com/repos/mhahn/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/mhahn/stacker/events","assignees_url":"https://api.github.com/repos/mhahn/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/mhahn/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/mhahn/stacker/tags","blobs_url":"https://api.github.com/repos/mhahn/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhahn/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhahn/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhahn/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhahn/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/mhahn/stacker/languages","stargazers_url":"https://api.github.com/repos/mhahn/stacker/stargazers","contributors_url":"https://api.github.com/repos/mhahn/stacker/contributors","subscribers_url":"https://api.github.com/repos/mhahn/stacker/subscribers","subscription_url":"https://api.github.com/repos/mhahn/stacker/subscription","commits_url":"https://api.github.com/repos/mhahn/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhahn/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhahn/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhahn/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhahn/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/mhahn/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhahn/stacker/merges","archive_url":"https://api.github.com/repos/mhahn/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhahn/stacker/downloads","issues_url":"https://api.github.com/repos/mhahn/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/mhahn/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/mhahn/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/mhahn/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhahn/stacker/labels{/name}","releases_url":"https://api.github.com/repos/mhahn/stacker/releases{/id}","deployments_url":"https://api.github.com/repos/mhahn/stacker/deployments","created_at":"2015-03-29T19:22:00Z","updated_at":"2016-05-23T08:24:28Z","pushed_at":"2016-08-26T00:25:01Z","git_url":"git://github.com/mhahn/stacker.git","ssh_url":"git@github.com:mhahn/stacker.git","clone_url":"https://github.com/mhahn/stacker.git","svn_url":"https://github.com/mhahn/stacker","homepage":null,"size":590,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"remind101:master","ref":"master","sha":"700ec034f2a9ef5711b8c21b5705eb9d5993b091","user":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"repo":{"id":28885080,"name":"stacker","full_name":"remind101/stacker","owner":{"login":"remind101","id":376343,"avatar_url":"https://avatars.githubusercontent.com/u/376343?v=3","gravatar_id":"","url":"https://api.github.com/users/remind101","html_url":"https://github.com/remind101","followers_url":"https://api.github.com/users/remind101/followers","following_url":"https://api.github.com/users/remind101/following{/other_user}","gists_url":"https://api.github.com/users/remind101/gists{/gist_id}","starred_url":"https://api.github.com/users/remind101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remind101/subscriptions","organizations_url":"https://api.github.com/users/remind101/orgs","repos_url":"https://api.github.com/users/remind101/repos","events_url":"https://api.github.com/users/remind101/events{/privacy}","received_events_url":"https://api.github.com/users/remind101/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/remind101/stacker","description":"An opinionated AWS CloudFormation Stack builder.","fork":false,"url":"https://api.github.com/repos/remind101/stacker","forks_url":"https://api.github.com/repos/remind101/stacker/forks","keys_url":"https://api.github.com/repos/remind101/stacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remind101/stacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remind101/stacker/teams","hooks_url":"https://api.github.com/repos/remind101/stacker/hooks","issue_events_url":"https://api.github.com/repos/remind101/stacker/issues/events{/number}","events_url":"https://api.github.com/repos/remind101/stacker/events","assignees_url":"https://api.github.com/repos/remind101/stacker/assignees{/user}","branches_url":"https://api.github.com/repos/remind101/stacker/branches{/branch}","tags_url":"https://api.github.com/repos/remind101/stacker/tags","blobs_url":"https://api.github.com/repos/remind101/stacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remind101/stacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remind101/stacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/remind101/stacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remind101/stacker/statuses/{sha}","languages_url":"https://api.github.com/repos/remind101/stacker/languages","stargazers_url":"https://api.github.com/repos/remind101/stacker/stargazers","contributors_url":"https://api.github.com/repos/remind101/stacker/contributors","subscribers_url":"https://api.github.com/repos/remind101/stacker/subscribers","subscription_url":"https://api.github.com/repos/remind101/stacker/subscription","commits_url":"https://api.github.com/repos/remind101/stacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/remind101/stacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/remind101/stacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/remind101/stacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/remind101/stacker/contents/{+path}","compare_url":"https://api.github.com/repos/remind101/stacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remind101/stacker/merges","archive_url":"https://api.github.com/repos/remind101/stacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remind101/stacker/downloads","issues_url":"https://api.github.com/repos/remind101/stacker/issues{/number}","pulls_url":"https://api.github.com/repos/remind101/stacker/pulls{/number}","milestones_url":"https://api.github.com/repos/remind101/stacker/milestones{/number}","notifications_url":"https://api.github.com/repos/remind101/stacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remind101/stacker/labels{/name}","releases_url":"https://api.github.com/repos/remind101/stacker/releases{/id}","deployments_url":"https://api.github.com/repos/remind101/stacker/deployments","created_at":"2015-01-06T21:46:05Z","updated_at":"2016-08-18T23:46:36Z","pushed_at":"2016-08-26T00:25:03Z","git_url":"git://github.com/remind101/stacker.git","ssh_url":"git@github.com:remind101/stacker.git","clone_url":"https://github.com/remind101/stacker.git","svn_url":"https://github.com/remind101/stacker","homepage":null,"size":682,"stargazers_count":92,"watchers_count":92,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":23,"forks":31,"open_issues":23,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/remind101/stacker/pulls/194"},"html":{"href":"https://github.com/remind101/stacker/pull/194"},"issue":{"href":"https://api.github.com/repos/remind101/stacker/issues/194"},"comments":{"href":"https://api.github.com/repos/remind101/stacker/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/remind101/stacker/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/remind101/stacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/remind101/stacker/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/remind101/stacker/statuses/4b857fe11e237eec267f837732e3cfc3d3451f2a"}}}}
{"actor":{"display_login":"mhahn"}}