{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/comments/71126341","id":71126341,"diff_hunk":"@@ -46,29 +46,29 @@\n public class DockerComposePropertyLoader {\n \n     @lombok.Getter\n-    public String dockerHost;\n+    private final String dockerHost;\n \n     @lombok.Getter\n-    public String dockerComposeCommand;\n+    private final String dockerComposeCommand;\n \n     @lombok.Getter\n-    public String sudoCommand;\n+    private final String sudoCommand;\n \n     @lombok.Getter\n-    public boolean useSudo;\n+    private final boolean useSudo;\n \n-    protected Properties properties;\n+    private final Properties properties;\n \n-    protected String configurationFile = \"config/scriptengines/docker-compose.properties\";\n+    private final static String CONFIGURATION_FILE = \"config/scriptengines/docker-compose.properties\";","path":"src/main/java/jsr223/docker/compose/utils/DockerComposePropertyLoader.java","position":23,"original_position":23,"commit_id":"dab0ec4dbab24c60171d62e7bb452c07e7e7b422","original_commit_id":"dab0ec4dbab24c60171d62e7bb452c07e7e7b422","user":{"login":"sonarqube-activeeon","id":14940028,"avatar_url":"https://avatars.githubusercontent.com/u/14940028?v=3","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) Reorder the modifiers to comply with the Java Language Specification. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AModifiersOrderCheck)\n","created_at":"2016-07-18T10:26:14Z","updated_at":"2016-07-18T10:26:14Z","html_url":"https://github.com/ow2-proactive/scriptengine-docker-compose/pull/21#discussion_r71126341","pull_request_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/comments/71126341"},"html":{"href":"https://github.com/ow2-proactive/scriptengine-docker-compose/pull/21#discussion_r71126341"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21","id":77780682,"html_url":"https://github.com/ow2-proactive/scriptengine-docker-compose/pull/21","diff_url":"https://github.com/ow2-proactive/scriptengine-docker-compose/pull/21.diff","patch_url":"https://github.com/ow2-proactive/scriptengine-docker-compose/pull/21.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/issues/21","number":21,"state":"open","locked":false,"title":"Use docker compose down command for container removal. And minor impr…","user":{"login":"tobwiens","id":6491363,"avatar_url":"https://avatars.githubusercontent.com/u/6491363?v=3","gravatar_id":"","url":"https://api.github.com/users/tobwiens","html_url":"https://github.com/tobwiens","followers_url":"https://api.github.com/users/tobwiens/followers","following_url":"https://api.github.com/users/tobwiens/following{/other_user}","gists_url":"https://api.github.com/users/tobwiens/gists{/gist_id}","starred_url":"https://api.github.com/users/tobwiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobwiens/subscriptions","organizations_url":"https://api.github.com/users/tobwiens/orgs","repos_url":"https://api.github.com/users/tobwiens/repos","events_url":"https://api.github.com/users/tobwiens/events{/privacy}","received_events_url":"https://api.github.com/users/tobwiens/received_events","type":"User","site_admin":false},"body":"…ovements.\r\n\r\nIncrease the script-engine version to 0.2.0.\r\n\r\nThe docker compose stop and docker compose remove command were both too slow. So the ProActive node killed the thread during the removal process.\r\n\r\nThe docker compose down command is now utilised to remove and kill the container within one go, which increases the likelihood of the container actually being removed.\r\n\r\nThe DockerComposeScriptEngineFactory got its own ProcessBuilder service class.\r\n\r\nThe DockerComposeScriptEngineFactory got a standard constructor with which it can be initialized at during the node startup.","created_at":"2016-07-18T09:35:43Z","updated_at":"2016-07-18T10:26:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c639f5c3e01494f93207189b31c02ba7dbc2ce44","assignee":{"login":"tobwiens","id":6491363,"avatar_url":"https://avatars.githubusercontent.com/u/6491363?v=3","gravatar_id":"","url":"https://api.github.com/users/tobwiens","html_url":"https://github.com/tobwiens","followers_url":"https://api.github.com/users/tobwiens/followers","following_url":"https://api.github.com/users/tobwiens/following{/other_user}","gists_url":"https://api.github.com/users/tobwiens/gists{/gist_id}","starred_url":"https://api.github.com/users/tobwiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobwiens/subscriptions","organizations_url":"https://api.github.com/users/tobwiens/orgs","repos_url":"https://api.github.com/users/tobwiens/repos","events_url":"https://api.github.com/users/tobwiens/events{/privacy}","received_events_url":"https://api.github.com/users/tobwiens/received_events","type":"User","site_admin":false},"assignees":[{"login":"tobwiens","id":6491363,"avatar_url":"https://avatars.githubusercontent.com/u/6491363?v=3","gravatar_id":"","url":"https://api.github.com/users/tobwiens","html_url":"https://github.com/tobwiens","followers_url":"https://api.github.com/users/tobwiens/followers","following_url":"https://api.github.com/users/tobwiens/following{/other_user}","gists_url":"https://api.github.com/users/tobwiens/gists{/gist_id}","starred_url":"https://api.github.com/users/tobwiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobwiens/subscriptions","organizations_url":"https://api.github.com/users/tobwiens/orgs","repos_url":"https://api.github.com/users/tobwiens/repos","events_url":"https://api.github.com/users/tobwiens/events{/privacy}","received_events_url":"https://api.github.com/users/tobwiens/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/issues/21/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/statuses/dab0ec4dbab24c60171d62e7bb452c07e7e7b422","head":{"label":"tobwiens:useDockerComposeDownCommand","ref":"useDockerComposeDownCommand","sha":"dab0ec4dbab24c60171d62e7bb452c07e7e7b422","user":{"login":"tobwiens","id":6491363,"avatar_url":"https://avatars.githubusercontent.com/u/6491363?v=3","gravatar_id":"","url":"https://api.github.com/users/tobwiens","html_url":"https://github.com/tobwiens","followers_url":"https://api.github.com/users/tobwiens/followers","following_url":"https://api.github.com/users/tobwiens/following{/other_user}","gists_url":"https://api.github.com/users/tobwiens/gists{/gist_id}","starred_url":"https://api.github.com/users/tobwiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobwiens/subscriptions","organizations_url":"https://api.github.com/users/tobwiens/orgs","repos_url":"https://api.github.com/users/tobwiens/repos","events_url":"https://api.github.com/users/tobwiens/events{/privacy}","received_events_url":"https://api.github.com/users/tobwiens/received_events","type":"User","site_admin":false},"repo":{"id":45464636,"name":"scriptengine-docker-compose","full_name":"tobwiens/scriptengine-docker-compose","owner":{"login":"tobwiens","id":6491363,"avatar_url":"https://avatars.githubusercontent.com/u/6491363?v=3","gravatar_id":"","url":"https://api.github.com/users/tobwiens","html_url":"https://github.com/tobwiens","followers_url":"https://api.github.com/users/tobwiens/followers","following_url":"https://api.github.com/users/tobwiens/following{/other_user}","gists_url":"https://api.github.com/users/tobwiens/gists{/gist_id}","starred_url":"https://api.github.com/users/tobwiens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobwiens/subscriptions","organizations_url":"https://api.github.com/users/tobwiens/orgs","repos_url":"https://api.github.com/users/tobwiens/repos","events_url":"https://api.github.com/users/tobwiens/events{/privacy}","received_events_url":"https://api.github.com/users/tobwiens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobwiens/scriptengine-docker-compose","description":"Execute a docker compose script; invoke the local docker compose client.","fork":true,"url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose","forks_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/forks","keys_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/teams","hooks_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/hooks","issue_events_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/issues/events{/number}","events_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/events","assignees_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/assignees{/user}","branches_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/branches{/branch}","tags_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/tags","blobs_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/statuses/{sha}","languages_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/languages","stargazers_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/stargazers","contributors_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/contributors","subscribers_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/subscribers","subscription_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/subscription","commits_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/contents/{+path}","compare_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/merges","archive_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/downloads","issues_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/issues{/number}","pulls_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/pulls{/number}","milestones_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/milestones{/number}","notifications_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/labels{/name}","releases_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/releases{/id}","deployments_url":"https://api.github.com/repos/tobwiens/scriptengine-docker-compose/deployments","created_at":"2015-11-03T12:21:11Z","updated_at":"2016-07-08T07:16:53Z","pushed_at":"2016-07-18T10:25:22Z","git_url":"git://github.com/tobwiens/scriptengine-docker-compose.git","ssh_url":"git@github.com:tobwiens/scriptengine-docker-compose.git","clone_url":"https://github.com/tobwiens/scriptengine-docker-compose.git","svn_url":"https://github.com/tobwiens/scriptengine-docker-compose","homepage":null,"size":142,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"4c372f95fec2c404e80bafbca194a48498d8287b","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars.githubusercontent.com/u/11553998?v=3","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":34323884,"name":"scriptengine-docker-compose","full_name":"ow2-proactive/scriptengine-docker-compose","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars.githubusercontent.com/u/11553998?v=3","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scriptengine-docker-compose","description":"Execute a docker compose script; invoke the local docker compose client.","fork":false,"url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose","forks_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/deployments","created_at":"2015-04-21T11:50:46Z","updated_at":"2016-01-19T13:23:16Z","pushed_at":"2016-07-18T10:25:23Z","git_url":"git://github.com/ow2-proactive/scriptengine-docker-compose.git","ssh_url":"git@github.com:ow2-proactive/scriptengine-docker-compose.git","clone_url":"https://github.com/ow2-proactive/scriptengine-docker-compose.git","svn_url":"https://github.com/ow2-proactive/scriptengine-docker-compose","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21"},"html":{"href":"https://github.com/ow2-proactive/scriptengine-docker-compose/pull/21"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/issues/21"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scriptengine-docker-compose/statuses/dab0ec4dbab24c60171d62e7bb452c07e7e7b422"}}}}
{"actor":{"display_login":"sonarqube-activeeon"}}