{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/comments/71867195","id":71867195,"diff_hunk":"@@ -0,0 +1,69 @@\n+package org.logstash.dissect.fields;\n+\n+import com.logstash.Event;\n+import org.logstash.dissect.Delimiter;\n+import org.logstash.dissect.ValueResolver;\n+\n+import java.util.Map;\n+\n+public abstract class AbstractField implements Field {","path":"src/main/java/org/logstash/dissect/fields/AbstractField.java","position":9,"original_position":9,"commit_id":"dd9d23332252b78846561d9cba2836148c47c308","original_commit_id":"dd9d23332252b78846561d9cba2836148c47c308","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"For the casual reader, Daniel and I decided to use a IdentityHashMap for the fields to ValueRef map store - this is because it really is an identity lookup.","created_at":"2016-07-22T11:54:54Z","updated_at":"2016-07-22T11:54:54Z","html_url":"https://github.com/logstash-plugins/logstash-filter-dissect/pull/1#discussion_r71867195","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/comments/71867195"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-dissect/pull/1#discussion_r71867195"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1","id":72535508,"html_url":"https://github.com/logstash-plugins/logstash-filter-dissect/pull/1","diff_url":"https://github.com/logstash-plugins/logstash-filter-dissect/pull/1.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-dissect/pull/1.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/1","number":1,"state":"open","locked":false,"title":"Updated java source/tests, jars, ruby source and gradle","user":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"body":"Who is up for a review?\r\n\r\nOne more commit to clean the `Gemfile`\r\n\r\n@talevy - Have a quick look and if you think comments would the code easier to understand - just leave me a comment and I will add some.\r\n\r\n@ph - I put your name on the assignees because I thought you would be interested.\r\n","created_at":"2016-06-03T16:38:54Z","updated_at":"2016-07-22T11:54:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70f9c26f6dc7a4f9659cb3f832f93b27576fd5b3","assignee":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"assignees":[{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},{"login":"talevy","id":388837,"avatar_url":"https://avatars.githubusercontent.com/u/388837?v=3","gravatar_id":"","url":"https://api.github.com/users/talevy","html_url":"https://github.com/talevy","followers_url":"https://api.github.com/users/talevy/followers","following_url":"https://api.github.com/users/talevy/following{/other_user}","gists_url":"https://api.github.com/users/talevy/gists{/gist_id}","starred_url":"https://api.github.com/users/talevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talevy/subscriptions","organizations_url":"https://api.github.com/users/talevy/orgs","repos_url":"https://api.github.com/users/talevy/repos","events_url":"https://api.github.com/users/talevy/events{/privacy}","received_events_url":"https://api.github.com/users/talevy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/1/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/statuses/dd9d23332252b78846561d9cba2836148c47c308","head":{"label":"logstash-plugins:feature/new-plugin","ref":"feature/new-plugin","sha":"dd9d23332252b78846561d9cba2836148c47c308","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":60361447,"name":"logstash-filter-dissect","full_name":"logstash-plugins/logstash-filter-dissect","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-dissect","description":"Dissect filter for Logstash","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/deployments","created_at":"2016-06-03T16:16:58Z","updated_at":"2016-06-03T16:42:08Z","pushed_at":"2016-07-17T06:40:48Z","git_url":"git://github.com/logstash-plugins/logstash-filter-dissect.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-dissect.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-dissect.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-dissect","homepage":"","size":241,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"feature/new-plugin"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"9bc2866f3e2f01ca9ca634fd929a4123d0eb9011","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":60361447,"name":"logstash-filter-dissect","full_name":"logstash-plugins/logstash-filter-dissect","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-dissect","description":"Dissect filter for Logstash","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/deployments","created_at":"2016-06-03T16:16:58Z","updated_at":"2016-06-03T16:42:08Z","pushed_at":"2016-07-17T06:40:48Z","git_url":"git://github.com/logstash-plugins/logstash-filter-dissect.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-dissect.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-dissect.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-dissect","homepage":"","size":241,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"feature/new-plugin"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-dissect/pull/1"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/1"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-dissect/statuses/dd9d23332252b78846561d9cba2836148c47c308"}}}}
{"actor":{"display_login":"guyboertje"}}