{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/gobblin/issues/1065","repository_url":"https://api.github.com/repos/linkedin/gobblin","labels_url":"https://api.github.com/repos/linkedin/gobblin/issues/1065/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/1065/comments","events_url":"https://api.github.com/repos/linkedin/gobblin/issues/1065/events","html_url":"https://github.com/linkedin/gobblin/issues/1065","id":161871826,"number":1065,"title":"WorkUnit and WorkUnitState","user":{"login":"ggthename","id":20106360,"avatar_url":"https://avatars.githubusercontent.com/u/20106360?v=3","gravatar_id":"","url":"https://api.github.com/users/ggthename","html_url":"https://github.com/ggthename","followers_url":"https://api.github.com/users/ggthename/followers","following_url":"https://api.github.com/users/ggthename/following{/other_user}","gists_url":"https://api.github.com/users/ggthename/gists{/gist_id}","starred_url":"https://api.github.com/users/ggthename/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggthename/subscriptions","organizations_url":"https://api.github.com/users/ggthename/orgs","repos_url":"https://api.github.com/users/ggthename/repos","events_url":"https://api.github.com/users/ggthename/events{/privacy}","received_events_url":"https://api.github.com/users/ggthename/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/linkedin/gobblin/labels/BLOCKED","name":"BLOCKED","color":"f9d0c4"},{"url":"https://api.github.com/repos/linkedin/gobblin/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-06-23T08:55:05Z","updated_at":"2016-07-28T17:47:10Z","closed_at":null,"body":"1. According to your Java Doc of WorkUnit class\r\n* @deprecated Properties in {@link SourceState} should not be added to a {@link WorkUnit}. Having each\r\n   * {@link WorkUnit} contain a copy of {@link SourceState} is a waste of memory. Use {@link #create(Extract, WatermarkInterval)}.\r\n\r\n2. So, QueryBasedSource class is creating a WorkUnit this way.\r\n WorkUnit.create(extract)\r\nThere is no information about SourceState.\r\n\r\n3. But, many extractors(including JdbcExtractor, MysqlExtractor and QueryBasedExtractor) are getting properties this way.  \r\n this.workUnit.getProp(\"source.conn.driver\")\r\n\r\n4. It can return null values..\r\nSo, in my opinion We should get properties from WorkUnitState rather than WorkUnit."},"comment":{"url":"https://api.github.com/repos/linkedin/gobblin/issues/comments/235971049","html_url":"https://github.com/linkedin/gobblin/issues/1065#issuecomment-235971049","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/1065","id":235971049,"user":{"login":"tuGithub","id":9965624,"avatar_url":"https://avatars.githubusercontent.com/u/9965624?v=3","gravatar_id":"","url":"https://api.github.com/users/tuGithub","html_url":"https://github.com/tuGithub","followers_url":"https://api.github.com/users/tuGithub/followers","following_url":"https://api.github.com/users/tuGithub/following{/other_user}","gists_url":"https://api.github.com/users/tuGithub/gists{/gist_id}","starred_url":"https://api.github.com/users/tuGithub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuGithub/subscriptions","organizations_url":"https://api.github.com/users/tuGithub/orgs","repos_url":"https://api.github.com/users/tuGithub/repos","events_url":"https://api.github.com/users/tuGithub/events{/privacy}","received_events_url":"https://api.github.com/users/tuGithub/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T17:47:10Z","updated_at":"2016-07-28T17:47:10Z","body":"looking..."}}
{"actor":{"display_login":"tuGithub"}}