{"action":"closed","number":843,"pull_request":{"url":"https://api.github.com/repos/kbase/narrative/pulls/843","id":92704324,"html_url":"https://github.com/kbase/narrative/pull/843","diff_url":"https://github.com/kbase/narrative/pull/843.diff","patch_url":"https://github.com/kbase/narrative/pull/843.patch","issue_url":"https://api.github.com/repos/kbase/narrative/issues/843","number":843,"state":"closed","locked":false,"title":"Rerouted New Narrative button, changed UX for it.","user":{"login":"briehl","id":2152243,"avatar_url":"https://avatars.githubusercontent.com/u/2152243?v=3","gravatar_id":"","url":"https://api.github.com/users/briehl","html_url":"https://github.com/briehl","followers_url":"https://api.github.com/users/briehl/followers","following_url":"https://api.github.com/users/briehl/following{/other_user}","gists_url":"https://api.github.com/users/briehl/gists{/gist_id}","starred_url":"https://api.github.com/users/briehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briehl/subscriptions","organizations_url":"https://api.github.com/users/briehl/orgs","repos_url":"https://api.github.com/users/briehl/repos","events_url":"https://api.github.com/users/briehl/events{/privacy}","received_events_url":"https://api.github.com/users/briehl/received_events","type":"User","site_admin":false},"body":"Now, when clicking the 'New Narrative' button in the Narratives panel, it does this flow:\r\n1. Disable the button.\r\n2. Call the NarrativeService create narrative function.\r\n3. Build a link to the new narrative and put it in place under the button. This is the biggest shift - just popping open a window via JavaScript will get stopped by most browsers' pop-up blockers. And I think we still want it to come up in a new tab/window. So that's the feel for now.\r\n4. Re-enable the New Narrative button when the link is clicked, and dismiss the link, while we're at it.\r\n5. On error - show the error in a slide down alert (in the same spot) and continue to disable the create button while the error is being shown.\r\n\r\nThis also does a little bit of cleanup.","created_at":"2016-11-08T02:27:25Z","updated_at":"2016-11-11T22:27:20Z","closed_at":"2016-11-11T22:27:20Z","merged_at":"2016-11-11T22:27:20Z","merge_commit_sha":"f1920388c996a30be9d299e98690d47e03e25353","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kbase/narrative/pulls/843/commits","review_comments_url":"https://api.github.com/repos/kbase/narrative/pulls/843/comments","review_comment_url":"https://api.github.com/repos/kbase/narrative/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbase/narrative/issues/843/comments","statuses_url":"https://api.github.com/repos/kbase/narrative/statuses/e6aa4268262607f03d5597df44e7938edebaaaf6","head":{"label":"briehl:develop","ref":"develop","sha":"e6aa4268262607f03d5597df44e7938edebaaaf6","user":{"login":"briehl","id":2152243,"avatar_url":"https://avatars.githubusercontent.com/u/2152243?v=3","gravatar_id":"","url":"https://api.github.com/users/briehl","html_url":"https://github.com/briehl","followers_url":"https://api.github.com/users/briehl/followers","following_url":"https://api.github.com/users/briehl/following{/other_user}","gists_url":"https://api.github.com/users/briehl/gists{/gist_id}","starred_url":"https://api.github.com/users/briehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briehl/subscriptions","organizations_url":"https://api.github.com/users/briehl/orgs","repos_url":"https://api.github.com/users/briehl/repos","events_url":"https://api.github.com/users/briehl/events{/privacy}","received_events_url":"https://api.github.com/users/briehl/received_events","type":"User","site_admin":false},"repo":{"id":22262489,"name":"narrative","full_name":"briehl/narrative","owner":{"login":"briehl","id":2152243,"avatar_url":"https://avatars.githubusercontent.com/u/2152243?v=3","gravatar_id":"","url":"https://api.github.com/users/briehl","html_url":"https://github.com/briehl","followers_url":"https://api.github.com/users/briehl/followers","following_url":"https://api.github.com/users/briehl/following{/other_user}","gists_url":"https://api.github.com/users/briehl/gists{/gist_id}","starred_url":"https://api.github.com/users/briehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briehl/subscriptions","organizations_url":"https://api.github.com/users/briehl/orgs","repos_url":"https://api.github.com/users/briehl/repos","events_url":"https://api.github.com/users/briehl/events{/privacy}","received_events_url":"https://api.github.com/users/briehl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briehl/narrative","description":null,"fork":true,"url":"https://api.github.com/repos/briehl/narrative","forks_url":"https://api.github.com/repos/briehl/narrative/forks","keys_url":"https://api.github.com/repos/briehl/narrative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briehl/narrative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briehl/narrative/teams","hooks_url":"https://api.github.com/repos/briehl/narrative/hooks","issue_events_url":"https://api.github.com/repos/briehl/narrative/issues/events{/number}","events_url":"https://api.github.com/repos/briehl/narrative/events","assignees_url":"https://api.github.com/repos/briehl/narrative/assignees{/user}","branches_url":"https://api.github.com/repos/briehl/narrative/branches{/branch}","tags_url":"https://api.github.com/repos/briehl/narrative/tags","blobs_url":"https://api.github.com/repos/briehl/narrative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briehl/narrative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briehl/narrative/git/refs{/sha}","trees_url":"https://api.github.com/repos/briehl/narrative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briehl/narrative/statuses/{sha}","languages_url":"https://api.github.com/repos/briehl/narrative/languages","stargazers_url":"https://api.github.com/repos/briehl/narrative/stargazers","contributors_url":"https://api.github.com/repos/briehl/narrative/contributors","subscribers_url":"https://api.github.com/repos/briehl/narrative/subscribers","subscription_url":"https://api.github.com/repos/briehl/narrative/subscription","commits_url":"https://api.github.com/repos/briehl/narrative/commits{/sha}","git_commits_url":"https://api.github.com/repos/briehl/narrative/git/commits{/sha}","comments_url":"https://api.github.com/repos/briehl/narrative/comments{/number}","issue_comment_url":"https://api.github.com/repos/briehl/narrative/issues/comments{/number}","contents_url":"https://api.github.com/repos/briehl/narrative/contents/{+path}","compare_url":"https://api.github.com/repos/briehl/narrative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briehl/narrative/merges","archive_url":"https://api.github.com/repos/briehl/narrative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briehl/narrative/downloads","issues_url":"https://api.github.com/repos/briehl/narrative/issues{/number}","pulls_url":"https://api.github.com/repos/briehl/narrative/pulls{/number}","milestones_url":"https://api.github.com/repos/briehl/narrative/milestones{/number}","notifications_url":"https://api.github.com/repos/briehl/narrative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briehl/narrative/labels{/name}","releases_url":"https://api.github.com/repos/briehl/narrative/releases{/id}","deployments_url":"https://api.github.com/repos/briehl/narrative/deployments","created_at":"2014-07-25T15:58:23Z","updated_at":"2016-01-27T20:07:08Z","pushed_at":"2016-11-10T23:58:04Z","git_url":"git://github.com/briehl/narrative.git","ssh_url":"git@github.com:briehl/narrative.git","clone_url":"https://github.com/briehl/narrative.git","svn_url":"https://github.com/briehl/narrative","homepage":null,"size":50615,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"kbase:develop","ref":"develop","sha":"9696a6cd3e754363e59b3b424a2d6c2c9cf85859","user":{"login":"kbase","id":1263946,"avatar_url":"https://avatars.githubusercontent.com/u/1263946?v=3","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"repo":{"id":20769520,"name":"narrative","full_name":"kbase/narrative","owner":{"login":"kbase","id":1263946,"avatar_url":"https://avatars.githubusercontent.com/u/1263946?v=3","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kbase/narrative","description":null,"fork":false,"url":"https://api.github.com/repos/kbase/narrative","forks_url":"https://api.github.com/repos/kbase/narrative/forks","keys_url":"https://api.github.com/repos/kbase/narrative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbase/narrative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbase/narrative/teams","hooks_url":"https://api.github.com/repos/kbase/narrative/hooks","issue_events_url":"https://api.github.com/repos/kbase/narrative/issues/events{/number}","events_url":"https://api.github.com/repos/kbase/narrative/events","assignees_url":"https://api.github.com/repos/kbase/narrative/assignees{/user}","branches_url":"https://api.github.com/repos/kbase/narrative/branches{/branch}","tags_url":"https://api.github.com/repos/kbase/narrative/tags","blobs_url":"https://api.github.com/repos/kbase/narrative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbase/narrative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbase/narrative/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbase/narrative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbase/narrative/statuses/{sha}","languages_url":"https://api.github.com/repos/kbase/narrative/languages","stargazers_url":"https://api.github.com/repos/kbase/narrative/stargazers","contributors_url":"https://api.github.com/repos/kbase/narrative/contributors","subscribers_url":"https://api.github.com/repos/kbase/narrative/subscribers","subscription_url":"https://api.github.com/repos/kbase/narrative/subscription","commits_url":"https://api.github.com/repos/kbase/narrative/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbase/narrative/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbase/narrative/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbase/narrative/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbase/narrative/contents/{+path}","compare_url":"https://api.github.com/repos/kbase/narrative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbase/narrative/merges","archive_url":"https://api.github.com/repos/kbase/narrative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbase/narrative/downloads","issues_url":"https://api.github.com/repos/kbase/narrative/issues{/number}","pulls_url":"https://api.github.com/repos/kbase/narrative/pulls{/number}","milestones_url":"https://api.github.com/repos/kbase/narrative/milestones{/number}","notifications_url":"https://api.github.com/repos/kbase/narrative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbase/narrative/labels{/name}","releases_url":"https://api.github.com/repos/kbase/narrative/releases{/id}","deployments_url":"https://api.github.com/repos/kbase/narrative/deployments","created_at":"2014-06-12T14:06:05Z","updated_at":"2016-10-24T19:17:47Z","pushed_at":"2016-11-11T22:27:20Z","git_url":"git://github.com/kbase/narrative.git","ssh_url":"git@github.com:kbase/narrative.git","clone_url":"https://github.com/kbase/narrative.git","svn_url":"https://github.com/kbase/narrative","homepage":null,"size":56668,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":24,"forks":33,"open_issues":24,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kbase/narrative/pulls/843"},"html":{"href":"https://github.com/kbase/narrative/pull/843"},"issue":{"href":"https://api.github.com/repos/kbase/narrative/issues/843"},"comments":{"href":"https://api.github.com/repos/kbase/narrative/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/kbase/narrative/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/kbase/narrative/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbase/narrative/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/kbase/narrative/statuses/e6aa4268262607f03d5597df44e7938edebaaaf6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"briehl","id":2152243,"avatar_url":"https://avatars.githubusercontent.com/u/2152243?v=3","gravatar_id":"","url":"https://api.github.com/users/briehl","html_url":"https://github.com/briehl","followers_url":"https://api.github.com/users/briehl/followers","following_url":"https://api.github.com/users/briehl/following{/other_user}","gists_url":"https://api.github.com/users/briehl/gists{/gist_id}","starred_url":"https://api.github.com/users/briehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briehl/subscriptions","organizations_url":"https://api.github.com/users/briehl/orgs","repos_url":"https://api.github.com/users/briehl/repos","events_url":"https://api.github.com/users/briehl/events{/privacy}","received_events_url":"https://api.github.com/users/briehl/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":4,"additions":198,"deletions":154,"changed_files":5}}
{"actor":{"display_login":"briehl"}}