{"action":"created","comment":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/59270787","id":59270787,"diff_hunk":"@@ -3464,6 +3025,26 @@ THREE.WebGLRenderer = function ( parameters ) {\n \n \t}\n \n+\tthis.allocTextureUnit = allocTextureUnit;\n+\tthis.setTexture2D = setTexture2D;","path":"src/renderers/WebGLRenderer.js","position":682,"original_position":682,"commit_id":"3c354341e14d6ba8e04b6ee2698a6b613453bd70","original_commit_id":"3c354341e14d6ba8e04b6ee2698a6b613453bd70","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"body":"Should be `this.setTexture`?","created_at":"2016-04-11T20:01:06Z","updated_at":"2016-04-11T20:01:06Z","html_url":"https://github.com/mrdoob/three.js/pull/8606#discussion_r59270787","pull_request_url":"https://api.github.com/repos/mrdoob/three.js/pulls/8606","_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/59270787"},"html":{"href":"https://github.com/mrdoob/three.js/pull/8606#discussion_r59270787"},"pull_request":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8606"}}},"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/8606","id":66046833,"html_url":"https://github.com/mrdoob/three.js/pull/8606","diff_url":"https://github.com/mrdoob/three.js/pull/8606.diff","patch_url":"https://github.com/mrdoob/three.js/pull/8606.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/8606","number":8606,"state":"open","locked":false,"title":"Automated uniform.<name>.type.","user":{"login":"tschw","id":3916357,"avatar_url":"https://avatars.githubusercontent.com/u/3916357?v=3","gravatar_id":"","url":"https://api.github.com/users/tschw","html_url":"https://github.com/tschw","followers_url":"https://api.github.com/users/tschw/followers","following_url":"https://api.github.com/users/tschw/following{/other_user}","gists_url":"https://api.github.com/users/tschw/gists{/gist_id}","starred_url":"https://api.github.com/users/tschw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschw/subscriptions","organizations_url":"https://api.github.com/users/tschw/orgs","repos_url":"https://api.github.com/users/tschw/repos","events_url":"https://api.github.com/users/tschw/events{/privacy}","received_events_url":"https://api.github.com/users/tschw/received_events","type":"User","site_admin":false},"body":"Part of a greater proposal discussed in #8552.\r\n\r\n- Also makes dynamic uniforms fit for real-world use. The feature used to be a memory monster and now it's allocation-free.","created_at":"2016-04-11T19:16:56Z","updated_at":"2016-04-11T20:01:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a6801a0cfcfcfe0a00c1c851715de5ead9e57d8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/8606/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/8606/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/8606/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/3c354341e14d6ba8e04b6ee2698a6b613453bd70","head":{"label":"tschw:UniformType","ref":"UniformType","sha":"3c354341e14d6ba8e04b6ee2698a6b613453bd70","user":{"login":"tschw","id":3916357,"avatar_url":"https://avatars.githubusercontent.com/u/3916357?v=3","gravatar_id":"","url":"https://api.github.com/users/tschw","html_url":"https://github.com/tschw","followers_url":"https://api.github.com/users/tschw/followers","following_url":"https://api.github.com/users/tschw/following{/other_user}","gists_url":"https://api.github.com/users/tschw/gists{/gist_id}","starred_url":"https://api.github.com/users/tschw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschw/subscriptions","organizations_url":"https://api.github.com/users/tschw/orgs","repos_url":"https://api.github.com/users/tschw/repos","events_url":"https://api.github.com/users/tschw/events{/privacy}","received_events_url":"https://api.github.com/users/tschw/received_events","type":"User","site_admin":false},"repo":{"id":35382835,"name":"three.js","full_name":"tschw/three.js","owner":{"login":"tschw","id":3916357,"avatar_url":"https://avatars.githubusercontent.com/u/3916357?v=3","gravatar_id":"","url":"https://api.github.com/users/tschw","html_url":"https://github.com/tschw","followers_url":"https://api.github.com/users/tschw/followers","following_url":"https://api.github.com/users/tschw/following{/other_user}","gists_url":"https://api.github.com/users/tschw/gists{/gist_id}","starred_url":"https://api.github.com/users/tschw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschw/subscriptions","organizations_url":"https://api.github.com/users/tschw/orgs","repos_url":"https://api.github.com/users/tschw/repos","events_url":"https://api.github.com/users/tschw/events{/privacy}","received_events_url":"https://api.github.com/users/tschw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tschw/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/tschw/three.js","forks_url":"https://api.github.com/repos/tschw/three.js/forks","keys_url":"https://api.github.com/repos/tschw/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tschw/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tschw/three.js/teams","hooks_url":"https://api.github.com/repos/tschw/three.js/hooks","issue_events_url":"https://api.github.com/repos/tschw/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/tschw/three.js/events","assignees_url":"https://api.github.com/repos/tschw/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/tschw/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/tschw/three.js/tags","blobs_url":"https://api.github.com/repos/tschw/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tschw/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tschw/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/tschw/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tschw/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/tschw/three.js/languages","stargazers_url":"https://api.github.com/repos/tschw/three.js/stargazers","contributors_url":"https://api.github.com/repos/tschw/three.js/contributors","subscribers_url":"https://api.github.com/repos/tschw/three.js/subscribers","subscription_url":"https://api.github.com/repos/tschw/three.js/subscription","commits_url":"https://api.github.com/repos/tschw/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/tschw/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/tschw/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/tschw/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/tschw/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/tschw/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tschw/three.js/merges","archive_url":"https://api.github.com/repos/tschw/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tschw/three.js/downloads","issues_url":"https://api.github.com/repos/tschw/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/tschw/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/tschw/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/tschw/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tschw/three.js/labels{/name}","releases_url":"https://api.github.com/repos/tschw/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/tschw/three.js/deployments","created_at":"2015-05-10T18:30:04Z","updated_at":"2015-05-10T18:30:12Z","pushed_at":"2016-04-11T19:14:17Z","git_url":"git://github.com/tschw/three.js.git","ssh_url":"git@github.com:tschw/three.js.git","clone_url":"https://github.com/tschw/three.js.git","svn_url":"https://github.com/tschw/three.js","homepage":"http://threejs.org/","size":372352,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"400ff2931dc305ebb5a0c7a2435a941359e50db3","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-04-11T18:13:59Z","pushed_at":"2016-04-11T19:16:57Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":575313,"stargazers_count":24297,"watchers_count":24297,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":7933,"mirror_url":null,"open_issues_count":625,"forks":7933,"open_issues":625,"watchers":24297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8606"},"html":{"href":"https://github.com/mrdoob/three.js/pull/8606"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/8606"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/8606/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8606/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8606/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/3c354341e14d6ba8e04b6ee2698a6b613453bd70"}}}}