{"action":"closed","number":64,"pull_request":{"url":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/64","id":64761650,"html_url":"https://github.com/jedie/django-reversion-compare/pull/64","diff_url":"https://github.com/jedie/django-reversion-compare/pull/64.diff","patch_url":"https://github.com/jedie/django-reversion-compare/pull/64.patch","issue_url":"https://api.github.com/repos/jedie/django-reversion-compare/issues/64","number":64,"state":"closed","locked":false,"title":"Check if related model has an integer as pk for ManyToMany fields.","user":{"login":"logaritmisk","id":52036,"avatar_url":"https://avatars.githubusercontent.com/u/52036?v=3","gravatar_id":"","url":"https://api.github.com/users/logaritmisk","html_url":"https://github.com/logaritmisk","followers_url":"https://api.github.com/users/logaritmisk/followers","following_url":"https://api.github.com/users/logaritmisk/following{/other_user}","gists_url":"https://api.github.com/users/logaritmisk/gists{/gist_id}","starred_url":"https://api.github.com/users/logaritmisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logaritmisk/subscriptions","organizations_url":"https://api.github.com/users/logaritmisk/orgs","repos_url":"https://api.github.com/users/logaritmisk/repos","events_url":"https://api.github.com/users/logaritmisk/events{/privacy}","received_events_url":"https://api.github.com/users/logaritmisk/received_events","type":"User","site_admin":false},"body":"I have a model (Station) that uses UUID as pk, and it has an ManyToMany relation to a model (Entity) that uses integers as pk. With current implementation I get an exception because Station.has_int_pk() returns False (as it should), so ids is None when we call `get_many_to_something()`. It should check if the related model has integers as pk, because it's the related model ids when want in our query.\r\n\r\nI guess there should be an else statement where ids is set to `self.value`, if the related model uses string as pk?","created_at":"2016-03-31T09:44:01Z","updated_at":"2016-03-31T09:51:11Z","closed_at":"2016-03-31T09:51:11Z","merged_at":"2016-03-31T09:51:11Z","merge_commit_sha":"335dd4adf31572b0811a3f92b8998b5daec84bba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/64/commits","review_comments_url":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/64/comments","review_comment_url":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jedie/django-reversion-compare/issues/64/comments","statuses_url":"https://api.github.com/repos/jedie/django-reversion-compare/statuses/d4b9b1798432d7aeeecb5eb8b0c7cdb432a676c8","head":{"label":"logaritmisk:master","ref":"master","sha":"d4b9b1798432d7aeeecb5eb8b0c7cdb432a676c8","user":{"login":"logaritmisk","id":52036,"avatar_url":"https://avatars.githubusercontent.com/u/52036?v=3","gravatar_id":"","url":"https://api.github.com/users/logaritmisk","html_url":"https://github.com/logaritmisk","followers_url":"https://api.github.com/users/logaritmisk/followers","following_url":"https://api.github.com/users/logaritmisk/following{/other_user}","gists_url":"https://api.github.com/users/logaritmisk/gists{/gist_id}","starred_url":"https://api.github.com/users/logaritmisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logaritmisk/subscriptions","organizations_url":"https://api.github.com/users/logaritmisk/orgs","repos_url":"https://api.github.com/users/logaritmisk/repos","events_url":"https://api.github.com/users/logaritmisk/events{/privacy}","received_events_url":"https://api.github.com/users/logaritmisk/received_events","type":"User","site_admin":false},"repo":{"id":55136672,"name":"django-reversion-compare","full_name":"logaritmisk/django-reversion-compare","owner":{"login":"logaritmisk","id":52036,"avatar_url":"https://avatars.githubusercontent.com/u/52036?v=3","gravatar_id":"","url":"https://api.github.com/users/logaritmisk","html_url":"https://github.com/logaritmisk","followers_url":"https://api.github.com/users/logaritmisk/followers","following_url":"https://api.github.com/users/logaritmisk/following{/other_user}","gists_url":"https://api.github.com/users/logaritmisk/gists{/gist_id}","starred_url":"https://api.github.com/users/logaritmisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logaritmisk/subscriptions","organizations_url":"https://api.github.com/users/logaritmisk/orgs","repos_url":"https://api.github.com/users/logaritmisk/repos","events_url":"https://api.github.com/users/logaritmisk/events{/privacy}","received_events_url":"https://api.github.com/users/logaritmisk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/logaritmisk/django-reversion-compare","description":"Add compare view to django-reversion for comparing two versions of a reversion model.","fork":true,"url":"https://api.github.com/repos/logaritmisk/django-reversion-compare","forks_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/forks","keys_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/teams","hooks_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/hooks","issue_events_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/issues/events{/number}","events_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/events","assignees_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/assignees{/user}","branches_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/branches{/branch}","tags_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/tags","blobs_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/git/refs{/sha}","trees_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/statuses/{sha}","languages_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/languages","stargazers_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/stargazers","contributors_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/contributors","subscribers_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/subscribers","subscription_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/subscription","commits_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/commits{/sha}","git_commits_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/git/commits{/sha}","comments_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/comments{/number}","issue_comment_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/issues/comments{/number}","contents_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/contents/{+path}","compare_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/merges","archive_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/downloads","issues_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/issues{/number}","pulls_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/pulls{/number}","milestones_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/milestones{/number}","notifications_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/labels{/name}","releases_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/releases{/id}","deployments_url":"https://api.github.com/repos/logaritmisk/django-reversion-compare/deployments","created_at":"2016-03-31T09:13:48Z","updated_at":"2016-03-31T09:13:49Z","pushed_at":"2016-03-31T09:36:00Z","git_url":"git://github.com/logaritmisk/django-reversion-compare.git","ssh_url":"git@github.com:logaritmisk/django-reversion-compare.git","clone_url":"https://github.com/logaritmisk/django-reversion-compare.git","svn_url":"https://github.com/logaritmisk/django-reversion-compare","homepage":"http://pypi.python.org/pypi/django-reversion-compare/","size":1016,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jedie:master","ref":"master","sha":"fe24dbc159fd824a073410c168dafba6a1d416dd","user":{"login":"jedie","id":71315,"avatar_url":"https://avatars.githubusercontent.com/u/71315?v=3","gravatar_id":"","url":"https://api.github.com/users/jedie","html_url":"https://github.com/jedie","followers_url":"https://api.github.com/users/jedie/followers","following_url":"https://api.github.com/users/jedie/following{/other_user}","gists_url":"https://api.github.com/users/jedie/gists{/gist_id}","starred_url":"https://api.github.com/users/jedie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedie/subscriptions","organizations_url":"https://api.github.com/users/jedie/orgs","repos_url":"https://api.github.com/users/jedie/repos","events_url":"https://api.github.com/users/jedie/events{/privacy}","received_events_url":"https://api.github.com/users/jedie/received_events","type":"User","site_admin":false},"repo":{"id":4212163,"name":"django-reversion-compare","full_name":"jedie/django-reversion-compare","owner":{"login":"jedie","id":71315,"avatar_url":"https://avatars.githubusercontent.com/u/71315?v=3","gravatar_id":"","url":"https://api.github.com/users/jedie","html_url":"https://github.com/jedie","followers_url":"https://api.github.com/users/jedie/followers","following_url":"https://api.github.com/users/jedie/following{/other_user}","gists_url":"https://api.github.com/users/jedie/gists{/gist_id}","starred_url":"https://api.github.com/users/jedie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedie/subscriptions","organizations_url":"https://api.github.com/users/jedie/orgs","repos_url":"https://api.github.com/users/jedie/repos","events_url":"https://api.github.com/users/jedie/events{/privacy}","received_events_url":"https://api.github.com/users/jedie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jedie/django-reversion-compare","description":"Add compare view to django-reversion for comparing two versions of a reversion model.","fork":false,"url":"https://api.github.com/repos/jedie/django-reversion-compare","forks_url":"https://api.github.com/repos/jedie/django-reversion-compare/forks","keys_url":"https://api.github.com/repos/jedie/django-reversion-compare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jedie/django-reversion-compare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jedie/django-reversion-compare/teams","hooks_url":"https://api.github.com/repos/jedie/django-reversion-compare/hooks","issue_events_url":"https://api.github.com/repos/jedie/django-reversion-compare/issues/events{/number}","events_url":"https://api.github.com/repos/jedie/django-reversion-compare/events","assignees_url":"https://api.github.com/repos/jedie/django-reversion-compare/assignees{/user}","branches_url":"https://api.github.com/repos/jedie/django-reversion-compare/branches{/branch}","tags_url":"https://api.github.com/repos/jedie/django-reversion-compare/tags","blobs_url":"https://api.github.com/repos/jedie/django-reversion-compare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jedie/django-reversion-compare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jedie/django-reversion-compare/git/refs{/sha}","trees_url":"https://api.github.com/repos/jedie/django-reversion-compare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jedie/django-reversion-compare/statuses/{sha}","languages_url":"https://api.github.com/repos/jedie/django-reversion-compare/languages","stargazers_url":"https://api.github.com/repos/jedie/django-reversion-compare/stargazers","contributors_url":"https://api.github.com/repos/jedie/django-reversion-compare/contributors","subscribers_url":"https://api.github.com/repos/jedie/django-reversion-compare/subscribers","subscription_url":"https://api.github.com/repos/jedie/django-reversion-compare/subscription","commits_url":"https://api.github.com/repos/jedie/django-reversion-compare/commits{/sha}","git_commits_url":"https://api.github.com/repos/jedie/django-reversion-compare/git/commits{/sha}","comments_url":"https://api.github.com/repos/jedie/django-reversion-compare/comments{/number}","issue_comment_url":"https://api.github.com/repos/jedie/django-reversion-compare/issues/comments{/number}","contents_url":"https://api.github.com/repos/jedie/django-reversion-compare/contents/{+path}","compare_url":"https://api.github.com/repos/jedie/django-reversion-compare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jedie/django-reversion-compare/merges","archive_url":"https://api.github.com/repos/jedie/django-reversion-compare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jedie/django-reversion-compare/downloads","issues_url":"https://api.github.com/repos/jedie/django-reversion-compare/issues{/number}","pulls_url":"https://api.github.com/repos/jedie/django-reversion-compare/pulls{/number}","milestones_url":"https://api.github.com/repos/jedie/django-reversion-compare/milestones{/number}","notifications_url":"https://api.github.com/repos/jedie/django-reversion-compare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jedie/django-reversion-compare/labels{/name}","releases_url":"https://api.github.com/repos/jedie/django-reversion-compare/releases{/id}","deployments_url":"https://api.github.com/repos/jedie/django-reversion-compare/deployments","created_at":"2012-05-03T08:50:14Z","updated_at":"2016-03-30T17:16:26Z","pushed_at":"2016-03-31T09:51:11Z","git_url":"git://github.com/jedie/django-reversion-compare.git","ssh_url":"git@github.com:jedie/django-reversion-compare.git","clone_url":"https://github.com/jedie/django-reversion-compare.git","svn_url":"https://github.com/jedie/django-reversion-compare","homepage":"http://pypi.python.org/pypi/django-reversion-compare/","size":1018,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":13,"forks":58,"open_issues":13,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/64"},"html":{"href":"https://github.com/jedie/django-reversion-compare/pull/64"},"issue":{"href":"https://api.github.com/repos/jedie/django-reversion-compare/issues/64"},"comments":{"href":"https://api.github.com/repos/jedie/django-reversion-compare/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jedie/django-reversion-compare/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/jedie/django-reversion-compare/statuses/d4b9b1798432d7aeeecb5eb8b0c7cdb432a676c8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jedie","id":71315,"avatar_url":"https://avatars.githubusercontent.com/u/71315?v=3","gravatar_id":"","url":"https://api.github.com/users/jedie","html_url":"https://github.com/jedie","followers_url":"https://api.github.com/users/jedie/followers","following_url":"https://api.github.com/users/jedie/following{/other_user}","gists_url":"https://api.github.com/users/jedie/gists{/gist_id}","starred_url":"https://api.github.com/users/jedie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedie/subscriptions","organizations_url":"https://api.github.com/users/jedie/orgs","repos_url":"https://api.github.com/users/jedie/repos","events_url":"https://api.github.com/users/jedie/events{/privacy}","received_events_url":"https://api.github.com/users/jedie/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":2,"changed_files":1}}