{"action":"created","issue":{"url":"https://api.github.com/repos/cisco/openh264/issues/2618","repository_url":"https://api.github.com/repos/cisco/openh264","labels_url":"https://api.github.com/repos/cisco/openh264/issues/2618/labels{/name}","comments_url":"https://api.github.com/repos/cisco/openh264/issues/2618/comments","events_url":"https://api.github.com/repos/cisco/openh264/issues/2618/events","html_url":"https://github.com/cisco/openh264/issues/2618","id":194262116,"number":2618,"title":"Serious bug in version 1.6","user":{"login":"zjudongze","id":24449983,"avatar_url":"https://avatars.githubusercontent.com/u/24449983?v=3","gravatar_id":"","url":"https://api.github.com/users/zjudongze","html_url":"https://github.com/zjudongze","followers_url":"https://api.github.com/users/zjudongze/followers","following_url":"https://api.github.com/users/zjudongze/following{/other_user}","gists_url":"https://api.github.com/users/zjudongze/gists{/gist_id}","starred_url":"https://api.github.com/users/zjudongze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjudongze/subscriptions","organizations_url":"https://api.github.com/users/zjudongze/orgs","repos_url":"https://api.github.com/users/zjudongze/repos","events_url":"https://api.github.com/users/zjudongze/events{/privacy}","received_events_url":"https://api.github.com/users/zjudongze/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-08T07:02:12Z","updated_at":"2016-12-09T02:27:00Z","closed_at":null,"body":"Version 1.6 encoder has a serious bug.\r\nUsing following parameters to encode will produce illformed bitstream; when decoding, it will trigger errors in CheckIntra16x16PredMode.\r\n \r\npPtrEnc->GetDefaultParams (&sSvcParam);\r\n sParam.iUsageType = CAMERA_VIDEO_REAL_TIME;\r\n  sParam.fMaxFrameRate  = 30.0f;                // input frame rate\r\n  sParam.iPicWidth      = 1280;                 // width of picture in samples\r\n  sParam.iPicHeight     = 720;                  // height of picture in samples\r\n  sParam.iTargetBitrate = 200000;              // target bitrate desired\r\n  sParam.iMaxBitrate    = UNSPECIFIED_BIT_RATE;\r\n  sParam.iRCMode        = RC_TIMESTAMP_MODE;      //  rc mode control\r\n  sParam.iTemporalLayerNum = 1;    // layer number at temporal level\r\n  sParam.iSpatialLayerNum  = 1;    // layer number at spatial level\r\n  sParam.bEnableDenoise    = 0;    // denoise control\r\n  sParam.bEnableBackgroundDetection = 1; // background detection control\r\n  sParam.bEnableAdaptiveQuant       = 1; // adaptive quantization control\r\n  sParam.bEnableFrameSkip           = 1; // frame skipping\r\n  sParam.bEnableLongTermReference   = 0; // long term reference control\r\n  sParam.iLtrMarkPeriod = 30;\r\n  sParam.uiIntraPeriod  = 0;           // period of Intra frame\r\n  sParam.eSpsPpsIdStrategy = INCREASING_ID;\r\n  sParam.bPrefixNalAddingCtrl = 0;\r\n  sParam.iComplexityMode = MEDIUM_COMPLEXITY;\r\n  sParam.bSimulcastAVC         = true;\r\n  int iIndexLayer = 0;\r\n  sParam.sSpatialLayers[iIndexLayer].uiProfileIdc       = PRO_BASELINE;\r\n  sParam.sSpatialLayers[iIndexLayer].iVideoWidth        = 1280;\r\n  sParam.sSpatialLayers[iIndexLayer].iVideoHeight       = 720;\r\n  sParam.sSpatialLayers[iIndexLayer].fFrameRate         = 30.0f;\r\n  sParam.sSpatialLayers[iIndexLayer].iSpatialBitrate    = 200000;\r\n  sParam.sSpatialLayers[iIndexLayer].iMaxSpatialBitrate    = UNSPECIFIED_BIT_RATE;\r\n  sParam.sSpatialLayers[iIndexLayer].sSliceArgument.uiSliceMode = SM_FIXEDSLCNUM_SLICE;\r\n  sParam.iMultipleThreadIdc = 2;\r\n\r\nThere are three key parameters related to this problem.\r\n1.  sParam.bEnableFrameSkip   must be enabled;\r\n2.   sParam.iMultipleThreadIdc = 2  must be multithreaded\r\n3.   sParam.iTargetBitrate = 200000;       sParam.sSpatialLayers[iIndexLayer].iSpatialBitrate    = 200000; bitrate should be small to enough to trigger frame skip.\r\n\r\n   "},"comment":{"url":"https://api.github.com/repos/cisco/openh264/issues/comments/265916547","html_url":"https://github.com/cisco/openh264/issues/2618#issuecomment-265916547","issue_url":"https://api.github.com/repos/cisco/openh264/issues/2618","id":265916547,"user":{"login":"ruil2","id":6100652,"avatar_url":"https://avatars.githubusercontent.com/u/6100652?v=3","gravatar_id":"","url":"https://api.github.com/users/ruil2","html_url":"https://github.com/ruil2","followers_url":"https://api.github.com/users/ruil2/followers","following_url":"https://api.github.com/users/ruil2/following{/other_user}","gists_url":"https://api.github.com/users/ruil2/gists{/gist_id}","starred_url":"https://api.github.com/users/ruil2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruil2/subscriptions","organizations_url":"https://api.github.com/users/ruil2/orgs","repos_url":"https://api.github.com/users/ruil2/repos","events_url":"https://api.github.com/users/ruil2/events{/privacy}","received_events_url":"https://api.github.com/users/ruil2/received_events","type":"User","site_admin":false},"created_at":"2016-12-09T02:27:00Z","updated_at":"2016-12-09T02:27:00Z","body":"@zjudongze thanks! I will try to reproduce this issue by using these parameters. Is there the same issue in the latest openh264 master code?"}}
{"actor":{"display_login":"ruil2"}}