{"action":"opened","number":66,"pull_request":{"url":"https://api.github.com/repos/prometheus/common/pulls/66","id":93352850,"html_url":"https://github.com/prometheus/common/pull/66","diff_url":"https://github.com/prometheus/common/pull/66.diff","patch_url":"https://github.com/prometheus/common/pull/66.patch","issue_url":"https://api.github.com/repos/prometheus/common/issues/66","number":66,"state":"open","locked":false,"title":"Remove last remaining use of LabelNameRE","user":{"login":"beorn7","id":5609886,"avatar_url":"https://avatars.githubusercontent.com/u/5609886?v=3","gravatar_id":"","url":"https://api.github.com/users/beorn7","html_url":"https://github.com/beorn7","followers_url":"https://api.github.com/users/beorn7/followers","following_url":"https://api.github.com/users/beorn7/following{/other_user}","gists_url":"https://api.github.com/users/beorn7/gists{/gist_id}","starred_url":"https://api.github.com/users/beorn7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beorn7/subscriptions","organizations_url":"https://api.github.com/users/beorn7/orgs","repos_url":"https://api.github.com/users/beorn7/repos","events_url":"https://api.github.com/users/beorn7/events{/privacy}","received_events_url":"https://api.github.com/users/beorn7/received_events","type":"User","site_admin":false},"body":"The IsValid method is much faster.\r\n\r\nSame as MetricNameRE, the regexp is mostly there for documentation\r\nreasons.\r\n\r\nThis commit also clarifies that in the doc comments and encourages\r\nusing the IsValid method (or IsValidMatricName function) for\r\nperformance reasons.\r\n\r\n@grobie @stuartnelson3 ","created_at":"2016-11-11T15:51:09Z","updated_at":"2016-11-11T15:51:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/common/pulls/66/commits","review_comments_url":"https://api.github.com/repos/prometheus/common/pulls/66/comments","review_comment_url":"https://api.github.com/repos/prometheus/common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/common/issues/66/comments","statuses_url":"https://api.github.com/repos/prometheus/common/statuses/8e5d54a99b1dfaf2a5e7b076667257fc1d72a1c3","head":{"label":"prometheus:beorn7/tweaks","ref":"beorn7/tweaks","sha":"8e5d54a99b1dfaf2a5e7b076667257fc1d72a1c3","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":37326770,"name":"common","full_name":"prometheus/common","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/common","description":"Go libraries shared across Prometheus components and libraries.","fork":false,"url":"https://api.github.com/repos/prometheus/common","forks_url":"https://api.github.com/repos/prometheus/common/forks","keys_url":"https://api.github.com/repos/prometheus/common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/common/teams","hooks_url":"https://api.github.com/repos/prometheus/common/hooks","issue_events_url":"https://api.github.com/repos/prometheus/common/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/common/events","assignees_url":"https://api.github.com/repos/prometheus/common/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/common/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/common/tags","blobs_url":"https://api.github.com/repos/prometheus/common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/common/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/common/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/common/languages","stargazers_url":"https://api.github.com/repos/prometheus/common/stargazers","contributors_url":"https://api.github.com/repos/prometheus/common/contributors","subscribers_url":"https://api.github.com/repos/prometheus/common/subscribers","subscription_url":"https://api.github.com/repos/prometheus/common/subscription","commits_url":"https://api.github.com/repos/prometheus/common/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/common/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/common/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/common/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/common/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/common/merges","archive_url":"https://api.github.com/repos/prometheus/common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/common/downloads","issues_url":"https://api.github.com/repos/prometheus/common/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/common/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/common/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/common/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/common/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/common/deployments","created_at":"2015-06-12T14:33:30Z","updated_at":"2016-11-07T16:13:36Z","pushed_at":"2016-11-11T15:51:09Z","git_url":"git://github.com/prometheus/common.git","ssh_url":"git@github.com:prometheus/common.git","clone_url":"https://github.com/prometheus/common.git","svn_url":"https://github.com/prometheus/common","homepage":"","size":231,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":13,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"f36a8da2241e626287bf1adfa7bc2f66bbc6770b","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":37326770,"name":"common","full_name":"prometheus/common","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/common","description":"Go libraries shared across Prometheus components and libraries.","fork":false,"url":"https://api.github.com/repos/prometheus/common","forks_url":"https://api.github.com/repos/prometheus/common/forks","keys_url":"https://api.github.com/repos/prometheus/common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/common/teams","hooks_url":"https://api.github.com/repos/prometheus/common/hooks","issue_events_url":"https://api.github.com/repos/prometheus/common/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/common/events","assignees_url":"https://api.github.com/repos/prometheus/common/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/common/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/common/tags","blobs_url":"https://api.github.com/repos/prometheus/common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/common/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/common/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/common/languages","stargazers_url":"https://api.github.com/repos/prometheus/common/stargazers","contributors_url":"https://api.github.com/repos/prometheus/common/contributors","subscribers_url":"https://api.github.com/repos/prometheus/common/subscribers","subscription_url":"https://api.github.com/repos/prometheus/common/subscription","commits_url":"https://api.github.com/repos/prometheus/common/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/common/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/common/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/common/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/common/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/common/merges","archive_url":"https://api.github.com/repos/prometheus/common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/common/downloads","issues_url":"https://api.github.com/repos/prometheus/common/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/common/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/common/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/common/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/common/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/common/deployments","created_at":"2015-06-12T14:33:30Z","updated_at":"2016-11-07T16:13:36Z","pushed_at":"2016-11-11T15:51:09Z","git_url":"git://github.com/prometheus/common.git","ssh_url":"git@github.com:prometheus/common.git","clone_url":"https://github.com/prometheus/common.git","svn_url":"https://github.com/prometheus/common","homepage":"","size":231,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/common/pulls/66"},"html":{"href":"https://github.com/prometheus/common/pull/66"},"issue":{"href":"https://api.github.com/repos/prometheus/common/issues/66"},"comments":{"href":"https://api.github.com/repos/prometheus/common/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/common/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/common/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/common/statuses/8e5d54a99b1dfaf2a5e7b076667257fc1d72a1c3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"beorn7"}}