{"action":"created","issue":{"url":"https://api.github.com/repos/Sylius/Sylius/issues/6156","repository_url":"https://api.github.com/repos/Sylius/Sylius","labels_url":"https://api.github.com/repos/Sylius/Sylius/issues/6156/labels{/name}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/6156/comments","events_url":"https://api.github.com/repos/Sylius/Sylius/issues/6156/events","html_url":"https://github.com/Sylius/Sylius/pull/6156","id":177782269,"number":6156,"title":"[Admin][Product] Move images from a product variant to a product","user":{"login":"GSadee","id":6140884,"avatar_url":"https://avatars.githubusercontent.com/u/6140884?v=3","gravatar_id":"","url":"https://api.github.com/users/GSadee","html_url":"https://github.com/GSadee","followers_url":"https://api.github.com/users/GSadee/followers","following_url":"https://api.github.com/users/GSadee/following{/other_user}","gists_url":"https://api.github.com/users/GSadee/gists{/gist_id}","starred_url":"https://api.github.com/users/GSadee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GSadee/subscriptions","organizations_url":"https://api.github.com/users/GSadee/orgs","repos_url":"https://api.github.com/users/GSadee/repos","events_url":"https://api.github.com/users/GSadee/events{/privacy}","received_events_url":"https://api.github.com/users/GSadee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-19T13:19:02Z","updated_at":"2016-09-21T19:28:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/6156","html_url":"https://github.com/Sylius/Sylius/pull/6156","diff_url":"https://github.com/Sylius/Sylius/pull/6156.diff","patch_url":"https://github.com/Sylius/Sylius/pull/6156.patch"},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no\r\n| New feature?    | yes\r\n| BC breaks?      | yes\r\n| Related tickets | \r\n| License         | MIT\r\n\r\nIn this PR I also refactored a little bit `Image` and `TaxonImage` classes.\r\n\r\nFor future:\r\n- remove relation from `Image` to its owner (`Taxon` or `Product`)\r\n- combine `ProductImage` and `TaxonImage` into one object (`Image`)"},"comment":{"url":"https://api.github.com/repos/Sylius/Sylius/issues/comments/248717148","html_url":"https://github.com/Sylius/Sylius/pull/6156#issuecomment-248717148","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/6156","id":248717148,"user":{"login":"okwinza","id":108925,"avatar_url":"https://avatars.githubusercontent.com/u/108925?v=3","gravatar_id":"","url":"https://api.github.com/users/okwinza","html_url":"https://github.com/okwinza","followers_url":"https://api.github.com/users/okwinza/followers","following_url":"https://api.github.com/users/okwinza/following{/other_user}","gists_url":"https://api.github.com/users/okwinza/gists{/gist_id}","starred_url":"https://api.github.com/users/okwinza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okwinza/subscriptions","organizations_url":"https://api.github.com/users/okwinza/orgs","repos_url":"https://api.github.com/users/okwinza/repos","events_url":"https://api.github.com/users/okwinza/events{/privacy}","received_events_url":"https://api.github.com/users/okwinza/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T19:28:55Z","updated_at":"2016-09-21T19:28:55Z","body":"IMO moving image relations from variant to product seems fairly questionable as there are many cases in which you want to display an image for one particullar variant. \r\n\r\nI know it is kinda simpler to have images only rely on products but in the real world there should be some kind of connection between ProductVariant and the image. Or at least a way to easily implement it. The chosen approach in this PR only complicates things. \r\n\r\nOn the other hand, the base Image model and stuff look pretty good now."}}
{"actor":{"display_login":"okwinza"}}