{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5826","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5826/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5826/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5826/events","html_url":"https://github.com/NREL/EnergyPlus/pull/5826","id":172507247,"number":5826,"title":"Cleanups from MoreDaylightingSensor work","user":{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/DoNotPublish","name":"DoNotPublish","color":"888888"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4","html_url":"https://github.com/NREL/EnergyPlus/milestones/EnergyPlus%208.6.0","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/4/labels","id":1634827,"number":4,"title":"EnergyPlus 8.6.0","description":"The EnergyPlus 8.6.0 public release at the end of FY16Q4.","creator":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars.githubusercontent.com/u/4991075?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"open_issues":134,"closed_issues":92,"state":"open","created_at":"2016-03-09T17:04:23Z","updated_at":"2016-08-29T13:46:23Z","due_on":"2016-09-30T05:00:00Z","closed_at":null},"comments":3,"created_at":"2016-08-22T17:20:49Z","updated_at":"2016-08-29T14:00:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/5826","html_url":"https://github.com/NREL/EnergyPlus/pull/5826","diff_url":"https://github.com/NREL/EnergyPlus/pull/5826.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/5826.patch"},"body":"Fixed EIO differences. Cleaned up commented code in simulationmanager. Removed unsupported stream support for Delight.in file from EnergyPlusFigure.cc. Removed unused unit test. \r\n\r\nReference issue #5825 \r\n\r\nReference original pull request #5725 \r\n\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n\r\n…. "},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/243132303","html_url":"https://github.com/NREL/EnergyPlus/pull/5826#issuecomment-243132303","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/5826","id":243132303,"user":{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars.githubusercontent.com/u/2582150?v=3","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T14:00:59Z","updated_at":"2016-08-29T14:00:59Z","body":"@Myoldmopar and @mjwitte This is ready to be merged."}}
{"actor":{"display_login":"JasonGlazer"}}