{"action":"created","comment":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/86495144","pull_request_review_id":7151587,"id":86495144,"diff_hunk":"@@ -717,11 +717,11 @@ var ScrollView = cc.Class({\n \n     //private methods\n     _registerEvent: function() {\n-        this.node.on(cc.Node.EventType.TOUCH_START, this._onTouchBegan, this, true);\n-        this.node.on(cc.Node.EventType.TOUCH_MOVE, this._onTouchMoved, this, true);\n-        this.node.on(cc.Node.EventType.TOUCH_END, this._onTouchEnded, this, true);\n-        this.node.on(cc.Node.EventType.TOUCH_CANCEL, this._onTouchCancelled, this, true);\n-        this.node.on(cc.Node.EventType.MOUSE_WHEEL, this._onMouseWheel, this, true);\n+        this.node.on(cc.Node.EventType.TOUCH_START, this._onTouchBegan, this, true, true);\n+        this.node.on(cc.Node.EventType.TOUCH_MOVE, this._onTouchMoved, this, true, true);\n+        this.node.on(cc.Node.EventType.TOUCH_END, this._onTouchEnded, this, true, true);\n+        this.node.on(cc.Node.EventType.TOUCH_CANCEL, this._onTouchCancelled, this, true, true);\n+        this.node.on(cc.Node.EventType.MOUSE_WHEEL, this._onMouseWheel, this, true, true);","path":"cocos2d/core/components/CCScrollView.js","position":22,"original_position":22,"commit_id":"db5c257675029dd46788017c2109d07191a54b7e","original_commit_id":"db5c257675029dd46788017c2109d07191a54b7e","user":{"login":"jareguo","id":1503156,"avatar_url":"https://avatars.githubusercontent.com/u/1503156?v=3","gravatar_id":"","url":"https://api.github.com/users/jareguo","html_url":"https://github.com/jareguo","followers_url":"https://api.github.com/users/jareguo/followers","following_url":"https://api.github.com/users/jareguo/following{/other_user}","gists_url":"https://api.github.com/users/jareguo/gists{/gist_id}","starred_url":"https://api.github.com/users/jareguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jareguo/subscriptions","organizations_url":"https://api.github.com/users/jareguo/orgs","repos_url":"https://api.github.com/users/jareguo/repos","events_url":"https://api.github.com/users/jareguo/events{/privacy}","received_events_url":"https://api.github.com/users/jareguo/received_events","type":"User","site_admin":false},"body":"你这里既然已经注册了 useCapture 的回调了，为什么不能在回调里 stopPropagation，而是要额外增加一个 hack 呢？","created_at":"2016-11-04T06:42:51Z","updated_at":"2016-11-04T06:42:51Z","html_url":"https://github.com/cocos-creator/engine/pull/1263#discussion_r86495144","pull_request_url":"https://api.github.com/repos/cocos-creator/engine/pulls/1263","_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/86495144"},"html":{"href":"https://github.com/cocos-creator/engine/pull/1263#discussion_r86495144"},"pull_request":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1263"}}},"pull_request":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/1263","id":92290213,"html_url":"https://github.com/cocos-creator/engine/pull/1263","diff_url":"https://github.com/cocos-creator/engine/pull/1263.diff","patch_url":"https://github.com/cocos-creator/engine/pull/1263.patch","issue_url":"https://api.github.com/repos/cocos-creator/engine/issues/1263","number":1263,"state":"open","locked":false,"title":"Improve scrollview","user":{"login":"zilongshanren","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/zilongshanren","html_url":"https://github.com/zilongshanren","followers_url":"https://api.github.com/users/zilongshanren/followers","following_url":"https://api.github.com/users/zilongshanren/following{/other_user}","gists_url":"https://api.github.com/users/zilongshanren/gists{/gist_id}","starred_url":"https://api.github.com/users/zilongshanren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zilongshanren/subscriptions","organizations_url":"https://api.github.com/users/zilongshanren/orgs","repos_url":"https://api.github.com/users/zilongshanren/repos","events_url":"https://api.github.com/users/zilongshanren/events{/privacy}","received_events_url":"https://api.github.com/users/zilongshanren/received_events","type":"User","site_admin":false},"body":"Re: https://github.com/cocos-creator/fireball/issues/4593\r\nChanges proposed in this pull request:\r\n * 修复 scrollview 嵌套 scrollview 时，拖到上面的 scrollview 下面的 scrollview 也跟着一起滚动的问题\r\n * 修复 scrollview 添加在 button 等侦听了 bubble 阶段事件的节点上面，事件会从 scrollview 穿透到这些节点上面的问题\r\n * 修复了 getScrollOffset 方向错了的问题\r\n\r\n@cocos-creator/engine-admins\r\n","created_at":"2016-11-04T06:32:31Z","updated_at":"2016-11-04T06:42:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"225e29ce4d634a696f078fd25925d301f5240ab3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos-creator/engine/pulls/1263/commits","review_comments_url":"https://api.github.com/repos/cocos-creator/engine/pulls/1263/comments","review_comment_url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos-creator/engine/issues/1263/comments","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/db5c257675029dd46788017c2109d07191a54b7e","head":{"label":"zilongshanren:improve-scrollview","ref":"improve-scrollview","sha":"db5c257675029dd46788017c2109d07191a54b7e","user":{"login":"zilongshanren","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/zilongshanren","html_url":"https://github.com/zilongshanren","followers_url":"https://api.github.com/users/zilongshanren/followers","following_url":"https://api.github.com/users/zilongshanren/following{/other_user}","gists_url":"https://api.github.com/users/zilongshanren/gists{/gist_id}","starred_url":"https://api.github.com/users/zilongshanren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zilongshanren/subscriptions","organizations_url":"https://api.github.com/users/zilongshanren/orgs","repos_url":"https://api.github.com/users/zilongshanren/repos","events_url":"https://api.github.com/users/zilongshanren/events{/privacy}","received_events_url":"https://api.github.com/users/zilongshanren/received_events","type":"User","site_admin":false},"repo":{"id":54608207,"name":"engine","full_name":"zilongshanren/engine","owner":{"login":"zilongshanren","id":785541,"avatar_url":"https://avatars.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/zilongshanren","html_url":"https://github.com/zilongshanren","followers_url":"https://api.github.com/users/zilongshanren/followers","following_url":"https://api.github.com/users/zilongshanren/following{/other_user}","gists_url":"https://api.github.com/users/zilongshanren/gists{/gist_id}","starred_url":"https://api.github.com/users/zilongshanren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zilongshanren/subscriptions","organizations_url":"https://api.github.com/users/zilongshanren/orgs","repos_url":"https://api.github.com/users/zilongshanren/repos","events_url":"https://api.github.com/users/zilongshanren/events{/privacy}","received_events_url":"https://api.github.com/users/zilongshanren/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zilongshanren/engine","description":"The engine for Cocos Creator","fork":true,"url":"https://api.github.com/repos/zilongshanren/engine","forks_url":"https://api.github.com/repos/zilongshanren/engine/forks","keys_url":"https://api.github.com/repos/zilongshanren/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zilongshanren/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zilongshanren/engine/teams","hooks_url":"https://api.github.com/repos/zilongshanren/engine/hooks","issue_events_url":"https://api.github.com/repos/zilongshanren/engine/issues/events{/number}","events_url":"https://api.github.com/repos/zilongshanren/engine/events","assignees_url":"https://api.github.com/repos/zilongshanren/engine/assignees{/user}","branches_url":"https://api.github.com/repos/zilongshanren/engine/branches{/branch}","tags_url":"https://api.github.com/repos/zilongshanren/engine/tags","blobs_url":"https://api.github.com/repos/zilongshanren/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zilongshanren/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zilongshanren/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/zilongshanren/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zilongshanren/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/zilongshanren/engine/languages","stargazers_url":"https://api.github.com/repos/zilongshanren/engine/stargazers","contributors_url":"https://api.github.com/repos/zilongshanren/engine/contributors","subscribers_url":"https://api.github.com/repos/zilongshanren/engine/subscribers","subscription_url":"https://api.github.com/repos/zilongshanren/engine/subscription","commits_url":"https://api.github.com/repos/zilongshanren/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/zilongshanren/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/zilongshanren/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/zilongshanren/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/zilongshanren/engine/contents/{+path}","compare_url":"https://api.github.com/repos/zilongshanren/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zilongshanren/engine/merges","archive_url":"https://api.github.com/repos/zilongshanren/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zilongshanren/engine/downloads","issues_url":"https://api.github.com/repos/zilongshanren/engine/issues{/number}","pulls_url":"https://api.github.com/repos/zilongshanren/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/zilongshanren/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/zilongshanren/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zilongshanren/engine/labels{/name}","releases_url":"https://api.github.com/repos/zilongshanren/engine/releases{/id}","deployments_url":"https://api.github.com/repos/zilongshanren/engine/deployments","created_at":"2016-03-24T02:22:57Z","updated_at":"2016-03-24T02:23:01Z","pushed_at":"2016-11-04T06:30:24Z","git_url":"git://github.com/zilongshanren/engine.git","ssh_url":"git@github.com:zilongshanren/engine.git","clone_url":"https://github.com/zilongshanren/engine.git","svn_url":"https://github.com/zilongshanren/engine","homepage":"http://www.cocos2d-x.org/creator","size":25570,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cocos-creator:v1.3","ref":"v1.3","sha":"da12cc622cba43dd7ace0ca062514d777acda1ec","user":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars.githubusercontent.com/u/6937061?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"repo":{"id":47440536,"name":"engine","full_name":"cocos-creator/engine","owner":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars.githubusercontent.com/u/6937061?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos-creator/engine","description":"The engine for Cocos Creator","fork":false,"url":"https://api.github.com/repos/cocos-creator/engine","forks_url":"https://api.github.com/repos/cocos-creator/engine/forks","keys_url":"https://api.github.com/repos/cocos-creator/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos-creator/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos-creator/engine/teams","hooks_url":"https://api.github.com/repos/cocos-creator/engine/hooks","issue_events_url":"https://api.github.com/repos/cocos-creator/engine/issues/events{/number}","events_url":"https://api.github.com/repos/cocos-creator/engine/events","assignees_url":"https://api.github.com/repos/cocos-creator/engine/assignees{/user}","branches_url":"https://api.github.com/repos/cocos-creator/engine/branches{/branch}","tags_url":"https://api.github.com/repos/cocos-creator/engine/tags","blobs_url":"https://api.github.com/repos/cocos-creator/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos-creator/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos-creator/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos-creator/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos-creator/engine/languages","stargazers_url":"https://api.github.com/repos/cocos-creator/engine/stargazers","contributors_url":"https://api.github.com/repos/cocos-creator/engine/contributors","subscribers_url":"https://api.github.com/repos/cocos-creator/engine/subscribers","subscription_url":"https://api.github.com/repos/cocos-creator/engine/subscription","commits_url":"https://api.github.com/repos/cocos-creator/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos-creator/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos-creator/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos-creator/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos-creator/engine/contents/{+path}","compare_url":"https://api.github.com/repos/cocos-creator/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos-creator/engine/merges","archive_url":"https://api.github.com/repos/cocos-creator/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos-creator/engine/downloads","issues_url":"https://api.github.com/repos/cocos-creator/engine/issues{/number}","pulls_url":"https://api.github.com/repos/cocos-creator/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos-creator/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos-creator/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos-creator/engine/labels{/name}","releases_url":"https://api.github.com/repos/cocos-creator/engine/releases{/id}","deployments_url":"https://api.github.com/repos/cocos-creator/engine/deployments","created_at":"2015-12-05T03:28:59Z","updated_at":"2016-11-03T06:58:40Z","pushed_at":"2016-11-04T06:32:31Z","git_url":"git://github.com/cocos-creator/engine.git","ssh_url":"git@github.com:cocos-creator/engine.git","clone_url":"https://github.com/cocos-creator/engine.git","svn_url":"https://github.com/cocos-creator/engine","homepage":"http://www.cocos2d-x.org/creator","size":26837,"stargazers_count":134,"watchers_count":134,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":19,"forks":91,"open_issues":19,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1263"},"html":{"href":"https://github.com/cocos-creator/engine/pull/1263"},"issue":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/1263"},"comments":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/1263/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1263/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1263/commits"},"statuses":{"href":"https://api.github.com/repos/cocos-creator/engine/statuses/db5c257675029dd46788017c2109d07191a54b7e"}}}}
{"actor":{"display_login":"jareguo"}}