{"action":"closed","number":815,"pull_request":{"url":"https://api.github.com/repos/deis/controller/pulls/815","id":73605023,"html_url":"https://github.com/deis/controller/pull/815","diff_url":"https://github.com/deis/controller/pull/815.diff","patch_url":"https://github.com/deis/controller/pull/815.patch","issue_url":"https://api.github.com/repos/deis/controller/issues/815","number":815,"state":"closed","locked":false,"title":"ref(scheduler): use observedGeneration instead of resourceVersion for RC readiness","user":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"body":"https://github.com/kubernetes/kubernetes/blob/master/docs/devel/api-conventions.md#metadata explains the resourceVersion and generation pretty well\r\n\r\nresourceVersion is the internal version representation where as generation deals with desired state\r\n\r\nSome resources report the observedGeneration, which is the generation most recently observed by the component responsible for acting upon changes to the desired state of the resource. This can be used, for instance, to ensure that the reported status reflects the most recent desired status.\r\n\r\nThis is also how to determine if Deployments are ready so it's good to match it all up","created_at":"2016-06-13T16:31:06Z","updated_at":"2016-06-13T17:48:41Z","closed_at":"2016-06-13T17:48:41Z","merged_at":"2016-06-13T17:48:41Z","merge_commit_sha":"825e1ba8abc8da88bd59797fc122cefa1a64d82b","assignee":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/deis/controller/milestones/10","html_url":"https://github.com/deis/controller/milestones/v2.1-pre1","labels_url":"https://api.github.com/repos/deis/controller/milestones/10/labels","id":1786078,"number":10,"title":"v2.1-pre1","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":22,"state":"open","created_at":"2016-05-24T21:42:11Z","updated_at":"2016-06-13T17:48:41Z","due_on":"2016-06-22T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/deis/controller/pulls/815/commits","review_comments_url":"https://api.github.com/repos/deis/controller/pulls/815/comments","review_comment_url":"https://api.github.com/repos/deis/controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deis/controller/issues/815/comments","statuses_url":"https://api.github.com/repos/deis/controller/statuses/035eba663be6bffb45dbe5ab2c3c00c526aa152b","head":{"label":"helgi:rc_ready","ref":"rc_ready","sha":"035eba663be6bffb45dbe5ab2c3c00c526aa152b","user":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"repo":{"id":47214840,"name":"controller","full_name":"helgi/controller","owner":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helgi/controller","description":"PaaS workflow controller and client for Deis v2","fork":true,"url":"https://api.github.com/repos/helgi/controller","forks_url":"https://api.github.com/repos/helgi/controller/forks","keys_url":"https://api.github.com/repos/helgi/controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helgi/controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helgi/controller/teams","hooks_url":"https://api.github.com/repos/helgi/controller/hooks","issue_events_url":"https://api.github.com/repos/helgi/controller/issues/events{/number}","events_url":"https://api.github.com/repos/helgi/controller/events","assignees_url":"https://api.github.com/repos/helgi/controller/assignees{/user}","branches_url":"https://api.github.com/repos/helgi/controller/branches{/branch}","tags_url":"https://api.github.com/repos/helgi/controller/tags","blobs_url":"https://api.github.com/repos/helgi/controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helgi/controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helgi/controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/helgi/controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helgi/controller/statuses/{sha}","languages_url":"https://api.github.com/repos/helgi/controller/languages","stargazers_url":"https://api.github.com/repos/helgi/controller/stargazers","contributors_url":"https://api.github.com/repos/helgi/controller/contributors","subscribers_url":"https://api.github.com/repos/helgi/controller/subscribers","subscription_url":"https://api.github.com/repos/helgi/controller/subscription","commits_url":"https://api.github.com/repos/helgi/controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/helgi/controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/helgi/controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/helgi/controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/helgi/controller/contents/{+path}","compare_url":"https://api.github.com/repos/helgi/controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helgi/controller/merges","archive_url":"https://api.github.com/repos/helgi/controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helgi/controller/downloads","issues_url":"https://api.github.com/repos/helgi/controller/issues{/number}","pulls_url":"https://api.github.com/repos/helgi/controller/pulls{/number}","milestones_url":"https://api.github.com/repos/helgi/controller/milestones{/number}","notifications_url":"https://api.github.com/repos/helgi/controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helgi/controller/labels{/name}","releases_url":"https://api.github.com/repos/helgi/controller/releases{/id}","deployments_url":"https://api.github.com/repos/helgi/controller/deployments","created_at":"2015-12-01T20:16:13Z","updated_at":"2016-03-16T17:43:06Z","pushed_at":"2016-06-13T17:18:07Z","git_url":"git://github.com/helgi/controller.git","ssh_url":"git@github.com:helgi/controller.git","clone_url":"https://github.com/helgi/controller.git","svn_url":"https://github.com/helgi/controller","homepage":"http://deis.io","size":15781,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deis:master","ref":"master","sha":"3d901bf00e954678badc489f4ccc188b445719ad","user":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"repo":{"id":45704630,"name":"controller","full_name":"deis/controller","owner":{"login":"deis","id":6117407,"avatar_url":"https://avatars.githubusercontent.com/u/6117407?v=3","gravatar_id":"","url":"https://api.github.com/users/deis","html_url":"https://github.com/deis","followers_url":"https://api.github.com/users/deis/followers","following_url":"https://api.github.com/users/deis/following{/other_user}","gists_url":"https://api.github.com/users/deis/gists{/gist_id}","starred_url":"https://api.github.com/users/deis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis/subscriptions","organizations_url":"https://api.github.com/users/deis/orgs","repos_url":"https://api.github.com/users/deis/repos","events_url":"https://api.github.com/users/deis/events{/privacy}","received_events_url":"https://api.github.com/users/deis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deis/controller","description":"Deis Workflow Controller (API)","fork":false,"url":"https://api.github.com/repos/deis/controller","forks_url":"https://api.github.com/repos/deis/controller/forks","keys_url":"https://api.github.com/repos/deis/controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deis/controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deis/controller/teams","hooks_url":"https://api.github.com/repos/deis/controller/hooks","issue_events_url":"https://api.github.com/repos/deis/controller/issues/events{/number}","events_url":"https://api.github.com/repos/deis/controller/events","assignees_url":"https://api.github.com/repos/deis/controller/assignees{/user}","branches_url":"https://api.github.com/repos/deis/controller/branches{/branch}","tags_url":"https://api.github.com/repos/deis/controller/tags","blobs_url":"https://api.github.com/repos/deis/controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deis/controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deis/controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/deis/controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deis/controller/statuses/{sha}","languages_url":"https://api.github.com/repos/deis/controller/languages","stargazers_url":"https://api.github.com/repos/deis/controller/stargazers","contributors_url":"https://api.github.com/repos/deis/controller/contributors","subscribers_url":"https://api.github.com/repos/deis/controller/subscribers","subscription_url":"https://api.github.com/repos/deis/controller/subscription","commits_url":"https://api.github.com/repos/deis/controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/deis/controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/deis/controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/deis/controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/deis/controller/contents/{+path}","compare_url":"https://api.github.com/repos/deis/controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deis/controller/merges","archive_url":"https://api.github.com/repos/deis/controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deis/controller/downloads","issues_url":"https://api.github.com/repos/deis/controller/issues{/number}","pulls_url":"https://api.github.com/repos/deis/controller/pulls{/number}","milestones_url":"https://api.github.com/repos/deis/controller/milestones{/number}","notifications_url":"https://api.github.com/repos/deis/controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deis/controller/labels{/name}","releases_url":"https://api.github.com/repos/deis/controller/releases{/id}","deployments_url":"https://api.github.com/repos/deis/controller/deployments","created_at":"2015-11-06T20:06:05Z","updated_at":"2016-05-17T09:06:13Z","pushed_at":"2016-06-13T17:48:41Z","git_url":"git://github.com/deis/controller.git","ssh_url":"git@github.com:deis/controller.git","clone_url":"https://github.com/deis/controller.git","svn_url":"https://github.com/deis/controller","homepage":"https://deis.com","size":16852,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":60,"forks":23,"open_issues":60,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deis/controller/pulls/815"},"html":{"href":"https://github.com/deis/controller/pull/815"},"issue":{"href":"https://api.github.com/repos/deis/controller/issues/815"},"comments":{"href":"https://api.github.com/repos/deis/controller/issues/815/comments"},"review_comments":{"href":"https://api.github.com/repos/deis/controller/pulls/815/comments"},"review_comment":{"href":"https://api.github.com/repos/deis/controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deis/controller/pulls/815/commits"},"statuses":{"href":"https://api.github.com/repos/deis/controller/statuses/035eba663be6bffb45dbe5ab2c3c00c526aa152b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"helgi","id":70530,"avatar_url":"https://avatars.githubusercontent.com/u/70530?v=3","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":9,"deletions":17,"changed_files":1}}
{"actor":{"display_login":"helgi"}}