{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/92682194","pull_request_review_id":13202291,"id":92682194,"diff_hunk":"@@ -0,0 +1,30 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Component\\DependencyInjection\\Argument;\n+\n+/**\n+ * Represents a complex argument containg nested values.","path":"src/Symfony/Component/DependencyInjection/Argument/ArgumentInterface.php","position":15,"original_position":15,"commit_id":"e5a231ebd3981975545e2fefa72508d98ab38b43","original_commit_id":"8985dd859046c7005a493a8efc749ab6deb1f3f1","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"body":"typo `containg` => `containing` ","created_at":"2016-12-15T19:29:22Z","updated_at":"2016-12-15T19:29:22Z","html_url":"https://github.com/symfony/symfony/pull/20907#discussion_r92682194","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20907","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/92682194"},"html":{"href":"https://github.com/symfony/symfony/pull/20907#discussion_r92682194"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20907"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20907","id":97799871,"html_url":"https://github.com/symfony/symfony/pull/20907","diff_url":"https://github.com/symfony/symfony/pull/20907.diff","patch_url":"https://github.com/symfony/symfony/pull/20907.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20907","number":20907,"state":"open","locked":false,"title":"[DependencyInjection] Implement lazy collection type using generators","user":{"login":"tgalopin","id":1651494,"avatar_url":"https://avatars.githubusercontent.com/u/1651494?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalopin","html_url":"https://github.com/tgalopin","followers_url":"https://api.github.com/users/tgalopin/followers","following_url":"https://api.github.com/users/tgalopin/following{/other_user}","gists_url":"https://api.github.com/users/tgalopin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalopin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalopin/subscriptions","organizations_url":"https://api.github.com/users/tgalopin/orgs","repos_url":"https://api.github.com/users/tgalopin/repos","events_url":"https://api.github.com/users/tgalopin/events{/privacy}","received_events_url":"https://api.github.com/users/tgalopin/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | -\r\n| Fixed tickets | #20875\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nFollowing the RFC https://github.com/symfony/symfony/issues/20875, this PR aims to implement lazy services collections using generators internally.\r\n\r\nFor now, I suggest to support only XML and PHP definitions. Supporting YAML means adding another convention to the language and this is not the aim of this PR.\r\n\r\n- [x] value object holding the semantic (IteratorArgument)\r\n- [x] iterator dumping\r\n- [x] lazyness awareness in CheckCircularReferencesPass & GraphvizDumper\r\n- [ ] rewindable iterators\r\n- [ ] ContainerBuilder::createService\r\n- [ ] ArgumentInterface handling in compiler passes\r\n- [ ] `*_ON_INVALID_REFERENCE` behavior","created_at":"2016-12-13T17:40:33Z","updated_at":"2016-12-15T19:29:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8c09dceccc1ad81efbc727f3cca64dd75e1c4fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20907/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20907/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20907/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/e5a231ebd3981975545e2fefa72508d98ab38b43","head":{"label":"tgalopin:lazy-collections","ref":"lazy-collections","sha":"e5a231ebd3981975545e2fefa72508d98ab38b43","user":{"login":"tgalopin","id":1651494,"avatar_url":"https://avatars.githubusercontent.com/u/1651494?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalopin","html_url":"https://github.com/tgalopin","followers_url":"https://api.github.com/users/tgalopin/followers","following_url":"https://api.github.com/users/tgalopin/following{/other_user}","gists_url":"https://api.github.com/users/tgalopin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalopin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalopin/subscriptions","organizations_url":"https://api.github.com/users/tgalopin/orgs","repos_url":"https://api.github.com/users/tgalopin/repos","events_url":"https://api.github.com/users/tgalopin/events{/privacy}","received_events_url":"https://api.github.com/users/tgalopin/received_events","type":"User","site_admin":false},"repo":{"id":40324575,"name":"symfony","full_name":"tgalopin/symfony","owner":{"login":"tgalopin","id":1651494,"avatar_url":"https://avatars.githubusercontent.com/u/1651494?v=3","gravatar_id":"","url":"https://api.github.com/users/tgalopin","html_url":"https://github.com/tgalopin","followers_url":"https://api.github.com/users/tgalopin/followers","following_url":"https://api.github.com/users/tgalopin/following{/other_user}","gists_url":"https://api.github.com/users/tgalopin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgalopin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgalopin/subscriptions","organizations_url":"https://api.github.com/users/tgalopin/orgs","repos_url":"https://api.github.com/users/tgalopin/repos","events_url":"https://api.github.com/users/tgalopin/events{/privacy}","received_events_url":"https://api.github.com/users/tgalopin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgalopin/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/tgalopin/symfony","forks_url":"https://api.github.com/repos/tgalopin/symfony/forks","keys_url":"https://api.github.com/repos/tgalopin/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgalopin/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgalopin/symfony/teams","hooks_url":"https://api.github.com/repos/tgalopin/symfony/hooks","issue_events_url":"https://api.github.com/repos/tgalopin/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/tgalopin/symfony/events","assignees_url":"https://api.github.com/repos/tgalopin/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/tgalopin/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/tgalopin/symfony/tags","blobs_url":"https://api.github.com/repos/tgalopin/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgalopin/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgalopin/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgalopin/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgalopin/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/tgalopin/symfony/languages","stargazers_url":"https://api.github.com/repos/tgalopin/symfony/stargazers","contributors_url":"https://api.github.com/repos/tgalopin/symfony/contributors","subscribers_url":"https://api.github.com/repos/tgalopin/symfony/subscribers","subscription_url":"https://api.github.com/repos/tgalopin/symfony/subscription","commits_url":"https://api.github.com/repos/tgalopin/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgalopin/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgalopin/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgalopin/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgalopin/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/tgalopin/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgalopin/symfony/merges","archive_url":"https://api.github.com/repos/tgalopin/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgalopin/symfony/downloads","issues_url":"https://api.github.com/repos/tgalopin/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/tgalopin/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/tgalopin/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/tgalopin/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgalopin/symfony/labels{/name}","releases_url":"https://api.github.com/repos/tgalopin/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/tgalopin/symfony/deployments","created_at":"2015-08-06T20:08:15Z","updated_at":"2016-01-22T16:31:30Z","pushed_at":"2016-12-15T09:47:06Z","git_url":"git://github.com/tgalopin/symfony.git","ssh_url":"git@github.com:tgalopin/symfony.git","clone_url":"https://github.com/tgalopin/symfony.git","svn_url":"https://github.com/tgalopin/symfony","homepage":"symfony.com","size":78072,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"e98c0687451e9bbfb16c7d7f6ba2cf1f322f311b","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-12-15T19:03:08Z","pushed_at":"2016-12-15T19:26:16Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":81209,"stargazers_count":13450,"watchers_count":13450,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5223,"mirror_url":null,"open_issues_count":867,"forks":5223,"open_issues":867,"watchers":13450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20907"},"html":{"href":"https://github.com/symfony/symfony/pull/20907"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20907"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20907/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20907/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20907/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/e5a231ebd3981975545e2fefa72508d98ab38b43"}}}}
{"actor":{"display_login":"chalasr"}}