{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/streams/pulls/comments/79731536","id":79731536,"diff_hunk":"@@ -16,6 +17,17 @@ function TransformStreamCloseReadable(transformStream) {\n     throw new TypeError('Readable side is already closed');\n   }\n \n+  if (transformStream._writableDone === true) {\n+    throw new TypeError('TransformStream is already closing');\n+  }","path":"reference-implementation/lib/transform-stream.js","position":13,"original_position":13,"commit_id":"a715e9ed6754b415330b68639a1c615375cb9d20","original_commit_id":"a715e9ed6754b415330b68639a1c615375cb9d20","user":{"login":"isonmad","id":16495165,"avatar_url":"https://avatars.githubusercontent.com/u/16495165?v=3","gravatar_id":"","url":"https://api.github.com/users/isonmad","html_url":"https://github.com/isonmad","followers_url":"https://api.github.com/users/isonmad/followers","following_url":"https://api.github.com/users/isonmad/following{/other_user}","gists_url":"https://api.github.com/users/isonmad/gists{/gist_id}","starred_url":"https://api.github.com/users/isonmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isonmad/subscriptions","organizations_url":"https://api.github.com/users/isonmad/orgs","repos_url":"https://api.github.com/users/isonmad/repos","events_url":"https://api.github.com/users/isonmad/events{/privacy}","received_events_url":"https://api.github.com/users/isonmad/received_events","type":"User","site_admin":false},"body":"Having two redundant ways to perform the same action seemed dubious (especially if, as in your other comment, the result is potentially contradictory, instead of redundant). It's already an error to call `close()` twice, this seemed roughly analogous to that.","created_at":"2016-09-20T23:02:23Z","updated_at":"2016-09-20T23:02:23Z","html_url":"https://github.com/whatwg/streams/pull/519#discussion_r79731536","pull_request_url":"https://api.github.com/repos/whatwg/streams/pulls/519","_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments/79731536"},"html":{"href":"https://github.com/whatwg/streams/pull/519#discussion_r79731536"},"pull_request":{"href":"https://api.github.com/repos/whatwg/streams/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/streams/pulls/519","id":85653595,"html_url":"https://github.com/whatwg/streams/pull/519","diff_url":"https://github.com/whatwg/streams/pull/519.diff","patch_url":"https://github.com/whatwg/streams/pull/519.patch","issue_url":"https://api.github.com/repos/whatwg/streams/issues/519","number":519,"state":"open","locked":false,"title":"Update TransformStream API & misc. fixups","user":{"login":"isonmad","id":16495165,"avatar_url":"https://avatars.githubusercontent.com/u/16495165?v=3","gravatar_id":"","url":"https://api.github.com/users/isonmad","html_url":"https://github.com/isonmad","followers_url":"https://api.github.com/users/isonmad/followers","following_url":"https://api.github.com/users/isonmad/following{/other_user}","gists_url":"https://api.github.com/users/isonmad/gists{/gist_id}","starred_url":"https://api.github.com/users/isonmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isonmad/subscriptions","organizations_url":"https://api.github.com/users/isonmad/orgs","repos_url":"https://api.github.com/users/isonmad/repos","events_url":"https://api.github.com/users/isonmad/events{/privacy}","received_events_url":"https://api.github.com/users/isonmad/received_events","type":"User","site_admin":false},"body":"First pass at issue #518 to align with the other stream APIs. Ended up also addressing #498, #331, and #185.","created_at":"2016-09-16T23:26:10Z","updated_at":"2016-09-20T23:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ef21b8ac2d5df74b2a7cd740a11a130a235f39f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/streams/pulls/519/commits","review_comments_url":"https://api.github.com/repos/whatwg/streams/pulls/519/comments","review_comment_url":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/streams/issues/519/comments","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/a715e9ed6754b415330b68639a1c615375cb9d20","head":{"label":"isonmad:transform1","ref":"transform1","sha":"a715e9ed6754b415330b68639a1c615375cb9d20","user":{"login":"isonmad","id":16495165,"avatar_url":"https://avatars.githubusercontent.com/u/16495165?v=3","gravatar_id":"","url":"https://api.github.com/users/isonmad","html_url":"https://github.com/isonmad","followers_url":"https://api.github.com/users/isonmad/followers","following_url":"https://api.github.com/users/isonmad/following{/other_user}","gists_url":"https://api.github.com/users/isonmad/gists{/gist_id}","starred_url":"https://api.github.com/users/isonmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isonmad/subscriptions","organizations_url":"https://api.github.com/users/isonmad/orgs","repos_url":"https://api.github.com/users/isonmad/repos","events_url":"https://api.github.com/users/isonmad/events{/privacy}","received_events_url":"https://api.github.com/users/isonmad/received_events","type":"User","site_admin":false},"repo":{"id":68418600,"name":"streams","full_name":"isonmad/streams","owner":{"login":"isonmad","id":16495165,"avatar_url":"https://avatars.githubusercontent.com/u/16495165?v=3","gravatar_id":"","url":"https://api.github.com/users/isonmad","html_url":"https://github.com/isonmad","followers_url":"https://api.github.com/users/isonmad/followers","following_url":"https://api.github.com/users/isonmad/following{/other_user}","gists_url":"https://api.github.com/users/isonmad/gists{/gist_id}","starred_url":"https://api.github.com/users/isonmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isonmad/subscriptions","organizations_url":"https://api.github.com/users/isonmad/orgs","repos_url":"https://api.github.com/users/isonmad/repos","events_url":"https://api.github.com/users/isonmad/events{/privacy}","received_events_url":"https://api.github.com/users/isonmad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isonmad/streams","description":"Streams Standard","fork":true,"url":"https://api.github.com/repos/isonmad/streams","forks_url":"https://api.github.com/repos/isonmad/streams/forks","keys_url":"https://api.github.com/repos/isonmad/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isonmad/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isonmad/streams/teams","hooks_url":"https://api.github.com/repos/isonmad/streams/hooks","issue_events_url":"https://api.github.com/repos/isonmad/streams/issues/events{/number}","events_url":"https://api.github.com/repos/isonmad/streams/events","assignees_url":"https://api.github.com/repos/isonmad/streams/assignees{/user}","branches_url":"https://api.github.com/repos/isonmad/streams/branches{/branch}","tags_url":"https://api.github.com/repos/isonmad/streams/tags","blobs_url":"https://api.github.com/repos/isonmad/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isonmad/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isonmad/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/isonmad/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isonmad/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/isonmad/streams/languages","stargazers_url":"https://api.github.com/repos/isonmad/streams/stargazers","contributors_url":"https://api.github.com/repos/isonmad/streams/contributors","subscribers_url":"https://api.github.com/repos/isonmad/streams/subscribers","subscription_url":"https://api.github.com/repos/isonmad/streams/subscription","commits_url":"https://api.github.com/repos/isonmad/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/isonmad/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/isonmad/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/isonmad/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/isonmad/streams/contents/{+path}","compare_url":"https://api.github.com/repos/isonmad/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isonmad/streams/merges","archive_url":"https://api.github.com/repos/isonmad/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isonmad/streams/downloads","issues_url":"https://api.github.com/repos/isonmad/streams/issues{/number}","pulls_url":"https://api.github.com/repos/isonmad/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/isonmad/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/isonmad/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isonmad/streams/labels{/name}","releases_url":"https://api.github.com/repos/isonmad/streams/releases{/id}","deployments_url":"https://api.github.com/repos/isonmad/streams/deployments","created_at":"2016-09-16T22:28:58Z","updated_at":"2016-09-16T22:29:00Z","pushed_at":"2016-09-19T03:02:33Z","git_url":"git://github.com/isonmad/streams.git","ssh_url":"git@github.com:isonmad/streams.git","clone_url":"https://github.com/isonmad/streams.git","svn_url":"https://github.com/isonmad/streams","homepage":"https://streams.spec.whatwg.org/","size":1845,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"aa5997458d2189e4a2cdb2f1c28097cac69a9c0e","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":13962843,"name":"streams","full_name":"whatwg/streams","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/streams","description":"Streams Standard","fork":false,"url":"https://api.github.com/repos/whatwg/streams","forks_url":"https://api.github.com/repos/whatwg/streams/forks","keys_url":"https://api.github.com/repos/whatwg/streams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/streams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/streams/teams","hooks_url":"https://api.github.com/repos/whatwg/streams/hooks","issue_events_url":"https://api.github.com/repos/whatwg/streams/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/streams/events","assignees_url":"https://api.github.com/repos/whatwg/streams/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/streams/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/streams/tags","blobs_url":"https://api.github.com/repos/whatwg/streams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/streams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/streams/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/streams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/streams/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/streams/languages","stargazers_url":"https://api.github.com/repos/whatwg/streams/stargazers","contributors_url":"https://api.github.com/repos/whatwg/streams/contributors","subscribers_url":"https://api.github.com/repos/whatwg/streams/subscribers","subscription_url":"https://api.github.com/repos/whatwg/streams/subscription","commits_url":"https://api.github.com/repos/whatwg/streams/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/streams/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/streams/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/streams/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/streams/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/streams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/streams/merges","archive_url":"https://api.github.com/repos/whatwg/streams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/streams/downloads","issues_url":"https://api.github.com/repos/whatwg/streams/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/streams/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/streams/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/streams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/streams/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/streams/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/streams/deployments","created_at":"2013-10-29T17:16:58Z","updated_at":"2016-09-20T09:05:11Z","pushed_at":"2016-09-19T03:02:33Z","git_url":"git://github.com/whatwg/streams.git","ssh_url":"git@github.com:whatwg/streams.git","clone_url":"https://github.com/whatwg/streams.git","svn_url":"https://github.com/whatwg/streams","homepage":"https://streams.spec.whatwg.org/","size":2499,"stargazers_count":573,"watchers_count":573,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":53,"forks":53,"open_issues":53,"watchers":573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/streams/pulls/519"},"html":{"href":"https://github.com/whatwg/streams/pull/519"},"issue":{"href":"https://api.github.com/repos/whatwg/streams/issues/519"},"comments":{"href":"https://api.github.com/repos/whatwg/streams/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/streams/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/streams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/streams/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/streams/statuses/a715e9ed6754b415330b68639a1c615375cb9d20"}}}}
{"actor":{"display_login":"isonmad"}}