{"action":"created","issue":{"url":"https://api.github.com/repos/ffrl/tunneldigger/issues/4","repository_url":"https://api.github.com/repos/ffrl/tunneldigger","labels_url":"https://api.github.com/repos/ffrl/tunneldigger/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/ffrl/tunneldigger/issues/4/comments","events_url":"https://api.github.com/repos/ffrl/tunneldigger/issues/4/events","html_url":"https://github.com/ffrl/tunneldigger/pull/4","id":161445581,"number":4,"title":"Fix usage computation for cases where the result is less than 256","user":{"login":"RalfJung","id":330628,"avatar_url":"https://avatars.githubusercontent.com/u/330628?v=3","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-21T14:03:58Z","updated_at":"2016-06-23T17:08:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ffrl/tunneldigger/pulls/4","html_url":"https://github.com/ffrl/tunneldigger/pull/4","diff_url":"https://github.com/ffrl/tunneldigger/pull/4.diff","patch_url":"https://github.com/ffrl/tunneldigger/pull/4.patch"},"body":"The old code would return i.e. '3f' if 1 of 1024 tunnels is used, which would be sent on the wire as '3f00'. The new code returns the correct value '003f'.\r\n\r\nI can't say I entirely understood the way the values flow here (e..g, where data has to be binary, where it is a string, etc.). I tested this patch briefly on one of our gateways, and it had the desired effect -- the clients got the usage information I expected them to get. In particular, I did not even try to understand whether endianess is an issue anywhere here."},"comment":{"url":"https://api.github.com/repos/ffrl/tunneldigger/issues/comments/228116712","html_url":"https://github.com/ffrl/tunneldigger/pull/4#issuecomment-228116712","issue_url":"https://api.github.com/repos/ffrl/tunneldigger/issues/4","id":228116712,"user":{"login":"RalfJung","id":330628,"avatar_url":"https://avatars.githubusercontent.com/u/330628?v=3","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T17:08:01Z","updated_at":"2016-06-23T17:08:01Z","body":"I decided to change the usage to `'ffff'` in case it is too long"}}
{"actor":{"display_login":"RalfJung"}}