{"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/52730277","id":52730277,"diff_hunk":"@@ -365,11 +373,20 @@ private void addUserPressed() {\n \t\t}\n \n \t}\n+\n+\tprivate static final String UNABLE_TO_DELETE_CREDENTIALS = \"Unable to delete credentials stored in secure storage without authenticating to secure storage\";","path":"foundation/plugins/org.jboss.tools.foundation.ui/src/org/jboss/tools/foundation/ui/credentials/internal/CredentialPreferencePage.java","position":27,"original_position":27,"commit_id":"5b1117fe62276633c597fb9a33b592d1176a063f","original_commit_id":"5b1117fe62276633c597fb9a33b592d1176a063f","user":{"login":"robstryker","id":630383,"avatar_url":"https://avatars.githubusercontent.com/u/630383?v=3","gravatar_id":"","url":"https://api.github.com/users/robstryker","html_url":"https://github.com/robstryker","followers_url":"https://api.github.com/users/robstryker/followers","following_url":"https://api.github.com/users/robstryker/following{/other_user}","gists_url":"https://api.github.com/users/robstryker/gists{/gist_id}","starred_url":"https://api.github.com/users/robstryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstryker/subscriptions","organizations_url":"https://api.github.com/users/robstryker/orgs","repos_url":"https://api.github.com/users/robstryker/repos","events_url":"https://api.github.com/users/robstryker/events{/privacy}","received_events_url":"https://api.github.com/users/robstryker/received_events","type":"User","site_admin":false},"body":"Please put this in a proper externalized class...   Specifically  CredentialMessages.java and CredentialMessages.properties. \r\n\r\nOtherwise, great patch. ","created_at":"2016-02-12T11:21:09Z","updated_at":"2016-02-12T11:21:09Z","html_url":"https://github.com/jbosstools/jbosstools-base/pull/484#discussion_r52730277","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments/52730277"},"html":{"href":"https://github.com/jbosstools/jbosstools-base/pull/484#discussion_r52730277"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484","id":58821208,"html_url":"https://github.com/jbosstools/jbosstools-base/pull/484","diff_url":"https://github.com/jbosstools/jbosstools-base/pull/484.diff","patch_url":"https://github.com/jbosstools/jbosstools-base/pull/484.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/484","number":484,"state":"open","locked":false,"title":"JBIDE-21302 Removing user from credentials framework while not authenticated to secure storage should not work","user":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"body":"Call CredentialService.getCredentialModel().saveModel() before removal is done.\r\nThat triggers authentication to secure storage if it has not been done yet.\r\nBy returning boolean in saveModel() equal to false if user failed to authenticate,\r\nwe can abort removing credentials.","created_at":"2016-02-09T22:45:32Z","updated_at":"2016-02-12T11:21:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a4c00e66424ff989f9b9823222b91e259977a2b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/484/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/5b1117fe62276633c597fb9a33b592d1176a063f","head":{"label":"scabanovich:jbide-21302","ref":"jbide-21302","sha":"5b1117fe62276633c597fb9a33b592d1176a063f","user":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"repo":{"id":6444098,"name":"jbosstools-base","full_name":"scabanovich/jbosstools-base","owner":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scabanovich/jbosstools-base","description":"JBoss Tools :: Base { common, runtime, tests, usage }","fork":true,"url":"https://api.github.com/repos/scabanovich/jbosstools-base","forks_url":"https://api.github.com/repos/scabanovich/jbosstools-base/forks","keys_url":"https://api.github.com/repos/scabanovich/jbosstools-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scabanovich/jbosstools-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scabanovich/jbosstools-base/teams","hooks_url":"https://api.github.com/repos/scabanovich/jbosstools-base/hooks","issue_events_url":"https://api.github.com/repos/scabanovich/jbosstools-base/issues/events{/number}","events_url":"https://api.github.com/repos/scabanovich/jbosstools-base/events","assignees_url":"https://api.github.com/repos/scabanovich/jbosstools-base/assignees{/user}","branches_url":"https://api.github.com/repos/scabanovich/jbosstools-base/branches{/branch}","tags_url":"https://api.github.com/repos/scabanovich/jbosstools-base/tags","blobs_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scabanovich/jbosstools-base/statuses/{sha}","languages_url":"https://api.github.com/repos/scabanovich/jbosstools-base/languages","stargazers_url":"https://api.github.com/repos/scabanovich/jbosstools-base/stargazers","contributors_url":"https://api.github.com/repos/scabanovich/jbosstools-base/contributors","subscribers_url":"https://api.github.com/repos/scabanovich/jbosstools-base/subscribers","subscription_url":"https://api.github.com/repos/scabanovich/jbosstools-base/subscription","commits_url":"https://api.github.com/repos/scabanovich/jbosstools-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/scabanovich/jbosstools-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/scabanovich/jbosstools-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/scabanovich/jbosstools-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/scabanovich/jbosstools-base/contents/{+path}","compare_url":"https://api.github.com/repos/scabanovich/jbosstools-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scabanovich/jbosstools-base/merges","archive_url":"https://api.github.com/repos/scabanovich/jbosstools-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scabanovich/jbosstools-base/downloads","issues_url":"https://api.github.com/repos/scabanovich/jbosstools-base/issues{/number}","pulls_url":"https://api.github.com/repos/scabanovich/jbosstools-base/pulls{/number}","milestones_url":"https://api.github.com/repos/scabanovich/jbosstools-base/milestones{/number}","notifications_url":"https://api.github.com/repos/scabanovich/jbosstools-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scabanovich/jbosstools-base/labels{/name}","releases_url":"https://api.github.com/repos/scabanovich/jbosstools-base/releases{/id}","deployments_url":"https://api.github.com/repos/scabanovich/jbosstools-base/deployments","created_at":"2012-10-29T16:56:05Z","updated_at":"2015-05-01T19:56:33Z","pushed_at":"2016-02-11T20:18:21Z","git_url":"git://github.com/scabanovich/jbosstools-base.git","ssh_url":"git@github.com:scabanovich/jbosstools-base.git","clone_url":"https://github.com/scabanovich/jbosstools-base.git","svn_url":"https://github.com/scabanovich/jbosstools-base","homepage":"","size":69873,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:master","ref":"master","sha":"488d1a0f4fb63103868b86ee1ec1936e1e31f88e","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6308266,"name":"jbosstools-base","full_name":"jbosstools/jbosstools-base","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-base","description":"JBoss Tools :: Base { common, foundation, runtime, stacks, tests, usage }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-base","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-base/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-base/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-base/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-base/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-base/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-base/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-base/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-base/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-base/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-base/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-base/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-base/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-base/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-base/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-base/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-base/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-base/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-base/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-base/releases{/id}","deployments_url":"https://api.github.com/repos/jbosstools/jbosstools-base/deployments","created_at":"2012-10-20T11:22:45Z","updated_at":"2016-01-14T20:30:04Z","pushed_at":"2016-02-11T20:19:39Z","git_url":"git://github.com/jbosstools/jbosstools-base.git","ssh_url":"git@github.com:jbosstools/jbosstools-base.git","clone_url":"https://github.com/jbosstools/jbosstools-base.git","svn_url":"https://github.com/jbosstools/jbosstools-base","homepage":"","size":72684,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":13,"forks":48,"open_issues":13,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484"},"html":{"href":"https://github.com/jbosstools/jbosstools-base/pull/484"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/484"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-base/statuses/5b1117fe62276633c597fb9a33b592d1176a063f"}}}}