{"action":"created","issue":{"url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/502","repository_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data","labels_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/502/labels{/name}","comments_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/502/comments","events_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/502/events","html_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/502","id":184349553,"number":502,"title":"Adds wof:coterminous fields to buffered point features in GB","user":{"login":"stepps00","id":18567700,"avatar_url":"https://avatars.githubusercontent.com/u/18567700?v=3","gravatar_id":"","url":"https://api.github.com/users/stepps00","html_url":"https://github.com/stepps00","followers_url":"https://api.github.com/users/stepps00/followers","following_url":"https://api.github.com/users/stepps00/following{/other_user}","gists_url":"https://api.github.com/users/stepps00/gists{/gist_id}","starred_url":"https://api.github.com/users/stepps00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepps00/subscriptions","organizations_url":"https://api.github.com/users/stepps00/orgs","repos_url":"https://api.github.com/users/stepps00/repos","events_url":"https://api.github.com/users/stepps00/events{/privacy}","received_events_url":"https://api.github.com/users/stepps00/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"nvkelso","id":853051,"avatar_url":"https://avatars.githubusercontent.com/u/853051?v=3","gravatar_id":"","url":"https://api.github.com/users/nvkelso","html_url":"https://github.com/nvkelso","followers_url":"https://api.github.com/users/nvkelso/followers","following_url":"https://api.github.com/users/nvkelso/following{/other_user}","gists_url":"https://api.github.com/users/nvkelso/gists{/gist_id}","starred_url":"https://api.github.com/users/nvkelso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvkelso/subscriptions","organizations_url":"https://api.github.com/users/nvkelso/orgs","repos_url":"https://api.github.com/users/nvkelso/repos","events_url":"https://api.github.com/users/nvkelso/events{/privacy}","received_events_url":"https://api.github.com/users/nvkelso/received_events","type":"User","site_admin":false},"assignees":[{"login":"nvkelso","id":853051,"avatar_url":"https://avatars.githubusercontent.com/u/853051?v=3","gravatar_id":"","url":"https://api.github.com/users/nvkelso","html_url":"https://github.com/nvkelso","followers_url":"https://api.github.com/users/nvkelso/followers","following_url":"https://api.github.com/users/nvkelso/following{/other_user}","gists_url":"https://api.github.com/users/nvkelso/gists{/gist_id}","starred_url":"https://api.github.com/users/nvkelso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvkelso/subscriptions","organizations_url":"https://api.github.com/users/nvkelso/orgs","repos_url":"https://api.github.com/users/nvkelso/repos","events_url":"https://api.github.com/users/nvkelso/events{/privacy}","received_events_url":"https://api.github.com/users/nvkelso/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-20T21:50:00Z","updated_at":"2016-10-26T18:33:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/502","html_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/502","diff_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/502.diff","patch_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/502.patch"},"body":"Fixes https://github.com/whosonfirst-data/whosonfirst-data/issues/430.\r\n\r\nThis PR adds `wof:coterminous` fields to buffered point locality features (and their parent records) with an `iso:country` equal to `GB`.\r\n\r\n* A list of locality records with a `\"qs:type\":\"buffered point\"` were gathered by running:\r\n```\r\nfind /usr/local/mapzen/whosonfirst-data/data -type f -exec grep -l \r\n'\"qs:type\":\"buffered point\",' {} + | xargs grep  '\"iso:country\":\"GB\",' > grep.csv\r\n```\r\n* Using this list, a feature collection was created that contained all buffered point features in GB and their parent records. This feature collection projected in QGIS:\r\n\r\n<img width=\"1250\" alt=\"screen shot 2016-10-20 at 1 56 39 pm\" src=\"https://cloud.githubusercontent.com/assets/18567700/19579006/456cc248-96d3-11e6-82be-01ef3e16464e.png\">\r\n\r\n* If the buffered point locality was parented by something than a localadmin, it was not given a `wof:coterminous` property. If the buffered point locality was parented by a large localadmin record (highlighted in the above image) that had a geometry too large to be coterminous with the locality, it was also not given a `wof:coterminous` property.\r\n\r\n* A version of [this script](https://github.com/mapzen/whosonfirst-toolbox/blob/master/scripts/add-field.py) was used to give new `wof:coterminous` properties to the remaining buffered point records and their parent records.\r\n"},"comment":{"url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/comments/256437857","html_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/502#issuecomment-256437857","issue_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/502","id":256437857,"user":{"login":"nvkelso","id":853051,"avatar_url":"https://avatars.githubusercontent.com/u/853051?v=3","gravatar_id":"","url":"https://api.github.com/users/nvkelso","html_url":"https://github.com/nvkelso","followers_url":"https://api.github.com/users/nvkelso/followers","following_url":"https://api.github.com/users/nvkelso/following{/other_user}","gists_url":"https://api.github.com/users/nvkelso/gists{/gist_id}","starred_url":"https://api.github.com/users/nvkelso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvkelso/subscriptions","organizations_url":"https://api.github.com/users/nvkelso/orgs","repos_url":"https://api.github.com/users/nvkelso/repos","events_url":"https://api.github.com/users/nvkelso/events{/privacy}","received_events_url":"https://api.github.com/users/nvkelso/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T18:33:47Z","updated_at":"2016-10-26T18:33:47Z","body":"Add specific script variant to Toolbox with new name (in the comments at the top of that script, say it's based on something else...)"}}
{"actor":{"display_login":"nvkelso"}}