{"action":"created","comment":{"url":"https://api.github.com/repos/parq-app/parq-android/pulls/comments/59150490","id":59150490,"diff_hunk":"@@ -287,8 +301,16 @@ public void onSaveInstanceState(Bundle savedInstanceState) {\n     }\n \n     @Override\n+    public void onActivityResult(int requestCode, int resultCode, Intent data) {\n+        // DO NOT REMOVE -- necessary in order for onActivityResult to be called in fragment.","path":"app/src/main/java/com/mmm/parq/activities/DriverActivity.java","position":78,"original_position":78,"commit_id":"64af7a7a4db8d839ec09ae8ba2b05d0c1bf4edd1","original_commit_id":"64af7a7a4db8d839ec09ae8ba2b05d0c1bf4edd1","user":{"login":"nickcharles","id":6147430,"avatar_url":"https://avatars.githubusercontent.com/u/6147430?v=3","gravatar_id":"","url":"https://api.github.com/users/nickcharles","html_url":"https://github.com/nickcharles","followers_url":"https://api.github.com/users/nickcharles/followers","following_url":"https://api.github.com/users/nickcharles/following{/other_user}","gists_url":"https://api.github.com/users/nickcharles/gists{/gist_id}","starred_url":"https://api.github.com/users/nickcharles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickcharles/subscriptions","organizations_url":"https://api.github.com/users/nickcharles/orgs","repos_url":"https://api.github.com/users/nickcharles/repos","events_url":"https://api.github.com/users/nickcharles/events{/privacy}","received_events_url":"https://api.github.com/users/nickcharles/received_events","type":"User","site_admin":false},"body":"I had a solution for this, I'll probably remember it by the time I get finished doing this code review, just writing something here so I don't forget about it.","created_at":"2016-04-11T03:14:27Z","updated_at":"2016-04-11T03:14:27Z","html_url":"https://github.com/parq-app/parq-android/pull/71#discussion_r59150490","pull_request_url":"https://api.github.com/repos/parq-app/parq-android/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/parq-app/parq-android/pulls/comments/59150490"},"html":{"href":"https://github.com/parq-app/parq-android/pull/71#discussion_r59150490"},"pull_request":{"href":"https://api.github.com/repos/parq-app/parq-android/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/parq-app/parq-android/pulls/71","id":65928108,"html_url":"https://github.com/parq-app/parq-android/pull/71","diff_url":"https://github.com/parq-app/parq-android/pull/71.diff","patch_url":"https://github.com/parq-app/parq-android/pull/71.patch","issue_url":"https://api.github.com/repos/parq-app/parq-android/issues/71","number":71,"state":"open","locked":false,"title":"Implement profile pictures","user":{"login":"kenzshelley","id":3460565,"avatar_url":"https://avatars.githubusercontent.com/u/3460565?v=3","gravatar_id":"","url":"https://api.github.com/users/kenzshelley","html_url":"https://github.com/kenzshelley","followers_url":"https://api.github.com/users/kenzshelley/followers","following_url":"https://api.github.com/users/kenzshelley/following{/other_user}","gists_url":"https://api.github.com/users/kenzshelley/gists{/gist_id}","starred_url":"https://api.github.com/users/kenzshelley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenzshelley/subscriptions","organizations_url":"https://api.github.com/users/kenzshelley/orgs","repos_url":"https://api.github.com/users/kenzshelley/repos","events_url":"https://api.github.com/users/kenzshelley/events{/privacy}","received_events_url":"https://api.github.com/users/kenzshelley/received_events","type":"User","site_admin":false},"body":"<h1> What </h1> \r\n* Displays user facebook profile picture if they auth w/ fb and haven't specified a different photo\r\n* Allows users to upload a picture or take a picture for their prof pic\r\n* Stores user uploaded pics in s3\r\n \r\n<h1> Notes </h1>\r\n* S3Manager util should probably be reused for spot photos\r\n\r\n<h1> Issues </h1>\r\n* can't convince fb to give me a big enough profile pic for the update page\r\n* currently not downsampling at all -- this needs to be fixed in a follow up PR because we occasionally get memory errors due to it\r\n* currently not cropping pictures to be square\r\n\r\ncloses #52 \r\n\r\n@matthewgrossman @nickcharles ","created_at":"2016-04-11T00:08:00Z","updated_at":"2016-04-11T03:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"074bed0b1eab6b3761f61b5397673dd4de0fdbc0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/parq-app/parq-android/pulls/71/commits","review_comments_url":"https://api.github.com/repos/parq-app/parq-android/pulls/71/comments","review_comment_url":"https://api.github.com/repos/parq-app/parq-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parq-app/parq-android/issues/71/comments","statuses_url":"https://api.github.com/repos/parq-app/parq-android/statuses/64af7a7a4db8d839ec09ae8ba2b05d0c1bf4edd1","head":{"label":"parq-app:kenz/prof-pics","ref":"kenz/prof-pics","sha":"64af7a7a4db8d839ec09ae8ba2b05d0c1bf4edd1","user":{"login":"parq-app","id":17327240,"avatar_url":"https://avatars.githubusercontent.com/u/17327240?v=3","gravatar_id":"","url":"https://api.github.com/users/parq-app","html_url":"https://github.com/parq-app","followers_url":"https://api.github.com/users/parq-app/followers","following_url":"https://api.github.com/users/parq-app/following{/other_user}","gists_url":"https://api.github.com/users/parq-app/gists{/gist_id}","starred_url":"https://api.github.com/users/parq-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parq-app/subscriptions","organizations_url":"https://api.github.com/users/parq-app/orgs","repos_url":"https://api.github.com/users/parq-app/repos","events_url":"https://api.github.com/users/parq-app/events{/privacy}","received_events_url":"https://api.github.com/users/parq-app/received_events","type":"Organization","site_admin":false},"repo":{"id":52053281,"name":"parq-android","full_name":"parq-app/parq-android","owner":{"login":"parq-app","id":17327240,"avatar_url":"https://avatars.githubusercontent.com/u/17327240?v=3","gravatar_id":"","url":"https://api.github.com/users/parq-app","html_url":"https://github.com/parq-app","followers_url":"https://api.github.com/users/parq-app/followers","following_url":"https://api.github.com/users/parq-app/following{/other_user}","gists_url":"https://api.github.com/users/parq-app/gists{/gist_id}","starred_url":"https://api.github.com/users/parq-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parq-app/subscriptions","organizations_url":"https://api.github.com/users/parq-app/orgs","repos_url":"https://api.github.com/users/parq-app/repos","events_url":"https://api.github.com/users/parq-app/events{/privacy}","received_events_url":"https://api.github.com/users/parq-app/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/parq-app/parq-android","description":"","fork":false,"url":"https://api.github.com/repos/parq-app/parq-android","forks_url":"https://api.github.com/repos/parq-app/parq-android/forks","keys_url":"https://api.github.com/repos/parq-app/parq-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parq-app/parq-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parq-app/parq-android/teams","hooks_url":"https://api.github.com/repos/parq-app/parq-android/hooks","issue_events_url":"https://api.github.com/repos/parq-app/parq-android/issues/events{/number}","events_url":"https://api.github.com/repos/parq-app/parq-android/events","assignees_url":"https://api.github.com/repos/parq-app/parq-android/assignees{/user}","branches_url":"https://api.github.com/repos/parq-app/parq-android/branches{/branch}","tags_url":"https://api.github.com/repos/parq-app/parq-android/tags","blobs_url":"https://api.github.com/repos/parq-app/parq-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parq-app/parq-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parq-app/parq-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/parq-app/parq-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parq-app/parq-android/statuses/{sha}","languages_url":"https://api.github.com/repos/parq-app/parq-android/languages","stargazers_url":"https://api.github.com/repos/parq-app/parq-android/stargazers","contributors_url":"https://api.github.com/repos/parq-app/parq-android/contributors","subscribers_url":"https://api.github.com/repos/parq-app/parq-android/subscribers","subscription_url":"https://api.github.com/repos/parq-app/parq-android/subscription","commits_url":"https://api.github.com/repos/parq-app/parq-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/parq-app/parq-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/parq-app/parq-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/parq-app/parq-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/parq-app/parq-android/contents/{+path}","compare_url":"https://api.github.com/repos/parq-app/parq-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parq-app/parq-android/merges","archive_url":"https://api.github.com/repos/parq-app/parq-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parq-app/parq-android/downloads","issues_url":"https://api.github.com/repos/parq-app/parq-android/issues{/number}","pulls_url":"https://api.github.com/repos/parq-app/parq-android/pulls{/number}","milestones_url":"https://api.github.com/repos/parq-app/parq-android/milestones{/number}","notifications_url":"https://api.github.com/repos/parq-app/parq-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parq-app/parq-android/labels{/name}","releases_url":"https://api.github.com/repos/parq-app/parq-android/releases{/id}","deployments_url":"https://api.github.com/repos/parq-app/parq-android/deployments","created_at":"2016-02-19T01:50:06Z","updated_at":"2016-02-20T21:07:43Z","pushed_at":"2016-04-11T02:49:33Z","git_url":"git://github.com/parq-app/parq-android.git","ssh_url":"git@github.com:parq-app/parq-android.git","clone_url":"https://github.com/parq-app/parq-android.git","svn_url":"https://github.com/parq-app/parq-android","homepage":null,"size":1070,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"parq-app:master","ref":"master","sha":"fc48a65ef5b6cacebab0e4293a287e7dac817c61","user":{"login":"parq-app","id":17327240,"avatar_url":"https://avatars.githubusercontent.com/u/17327240?v=3","gravatar_id":"","url":"https://api.github.com/users/parq-app","html_url":"https://github.com/parq-app","followers_url":"https://api.github.com/users/parq-app/followers","following_url":"https://api.github.com/users/parq-app/following{/other_user}","gists_url":"https://api.github.com/users/parq-app/gists{/gist_id}","starred_url":"https://api.github.com/users/parq-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parq-app/subscriptions","organizations_url":"https://api.github.com/users/parq-app/orgs","repos_url":"https://api.github.com/users/parq-app/repos","events_url":"https://api.github.com/users/parq-app/events{/privacy}","received_events_url":"https://api.github.com/users/parq-app/received_events","type":"Organization","site_admin":false},"repo":{"id":52053281,"name":"parq-android","full_name":"parq-app/parq-android","owner":{"login":"parq-app","id":17327240,"avatar_url":"https://avatars.githubusercontent.com/u/17327240?v=3","gravatar_id":"","url":"https://api.github.com/users/parq-app","html_url":"https://github.com/parq-app","followers_url":"https://api.github.com/users/parq-app/followers","following_url":"https://api.github.com/users/parq-app/following{/other_user}","gists_url":"https://api.github.com/users/parq-app/gists{/gist_id}","starred_url":"https://api.github.com/users/parq-app/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parq-app/subscriptions","organizations_url":"https://api.github.com/users/parq-app/orgs","repos_url":"https://api.github.com/users/parq-app/repos","events_url":"https://api.github.com/users/parq-app/events{/privacy}","received_events_url":"https://api.github.com/users/parq-app/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/parq-app/parq-android","description":"","fork":false,"url":"https://api.github.com/repos/parq-app/parq-android","forks_url":"https://api.github.com/repos/parq-app/parq-android/forks","keys_url":"https://api.github.com/repos/parq-app/parq-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parq-app/parq-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parq-app/parq-android/teams","hooks_url":"https://api.github.com/repos/parq-app/parq-android/hooks","issue_events_url":"https://api.github.com/repos/parq-app/parq-android/issues/events{/number}","events_url":"https://api.github.com/repos/parq-app/parq-android/events","assignees_url":"https://api.github.com/repos/parq-app/parq-android/assignees{/user}","branches_url":"https://api.github.com/repos/parq-app/parq-android/branches{/branch}","tags_url":"https://api.github.com/repos/parq-app/parq-android/tags","blobs_url":"https://api.github.com/repos/parq-app/parq-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parq-app/parq-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parq-app/parq-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/parq-app/parq-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parq-app/parq-android/statuses/{sha}","languages_url":"https://api.github.com/repos/parq-app/parq-android/languages","stargazers_url":"https://api.github.com/repos/parq-app/parq-android/stargazers","contributors_url":"https://api.github.com/repos/parq-app/parq-android/contributors","subscribers_url":"https://api.github.com/repos/parq-app/parq-android/subscribers","subscription_url":"https://api.github.com/repos/parq-app/parq-android/subscription","commits_url":"https://api.github.com/repos/parq-app/parq-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/parq-app/parq-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/parq-app/parq-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/parq-app/parq-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/parq-app/parq-android/contents/{+path}","compare_url":"https://api.github.com/repos/parq-app/parq-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parq-app/parq-android/merges","archive_url":"https://api.github.com/repos/parq-app/parq-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parq-app/parq-android/downloads","issues_url":"https://api.github.com/repos/parq-app/parq-android/issues{/number}","pulls_url":"https://api.github.com/repos/parq-app/parq-android/pulls{/number}","milestones_url":"https://api.github.com/repos/parq-app/parq-android/milestones{/number}","notifications_url":"https://api.github.com/repos/parq-app/parq-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parq-app/parq-android/labels{/name}","releases_url":"https://api.github.com/repos/parq-app/parq-android/releases{/id}","deployments_url":"https://api.github.com/repos/parq-app/parq-android/deployments","created_at":"2016-02-19T01:50:06Z","updated_at":"2016-02-20T21:07:43Z","pushed_at":"2016-04-11T02:49:33Z","git_url":"git://github.com/parq-app/parq-android.git","ssh_url":"git@github.com:parq-app/parq-android.git","clone_url":"https://github.com/parq-app/parq-android.git","svn_url":"https://github.com/parq-app/parq-android","homepage":null,"size":1070,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parq-app/parq-android/pulls/71"},"html":{"href":"https://github.com/parq-app/parq-android/pull/71"},"issue":{"href":"https://api.github.com/repos/parq-app/parq-android/issues/71"},"comments":{"href":"https://api.github.com/repos/parq-app/parq-android/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/parq-app/parq-android/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/parq-app/parq-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parq-app/parq-android/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/parq-app/parq-android/statuses/64af7a7a4db8d839ec09ae8ba2b05d0c1bf4edd1"}}}}