{"action":"created","issue":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/536","repository_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/536/labels{/name}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/536/comments","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/536/events","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/536","id":169185436,"number":536,"title":"feat(progressbar): add config service to provide default values","user":{"login":"jnizet","id":1608223,"avatar_url":"https://avatars.githubusercontent.com/u/1608223?v=3","gravatar_id":"","url":"https://api.github.com/users/jnizet","html_url":"https://github.com/jnizet","followers_url":"https://api.github.com/users/jnizet/followers","following_url":"https://api.github.com/users/jnizet/following{/other_user}","gists_url":"https://api.github.com/users/jnizet/gists{/gist_id}","starred_url":"https://api.github.com/users/jnizet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnizet/subscriptions","organizations_url":"https://api.github.com/users/jnizet/orgs","repos_url":"https://api.github.com/users/jnizet/repos","events_url":"https://api.github.com/users/jnizet/events{/privacy}","received_events_url":"https://api.github.com/users/jnizet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/7","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/milestones/alpha.3","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones/7/labels","id":1920614,"number":7,"title":"alpha.3","description":"","creator":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":11,"state":"open","created_at":"2016-08-03T12:28:12Z","updated_at":"2016-08-26T13:43:47Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-08-03T17:18:02Z","updated_at":"2016-08-29T11:11:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/536","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/536","diff_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/536.diff","patch_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/536.patch"},"body":"refs #518\r\n\r\nThe first commit keeps the initialization of the inputs in the component as is. \r\nAlso note that I changed the documentation of the animated input in order to indicate what it *will* do once the bootstrap bug is fixed, according to bootstrap's documentation.\r\n\r\nThe second commit changes the infrastructure code to\r\n - generate documentation for public properties of services in addition to methods\r\n - add a component to display the api docs of services in the demo\r\n - get the default value and description of inputs from the matching config service property if not specified in the directive itself\r\n - indicate which properties are initialized with properties of the config service\r\n - use all this in the documentation of NgbProgressbar\r\n"},"comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments/243096096","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/536#issuecomment-243096096","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/536","id":243096096,"user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T11:11:03Z","updated_at":"2016-08-29T11:11:03Z","body":"@jnizet OK, after spending a weekend without looking at any code and having a fresh look here are my thoughts:\r\n* I hear what you are saying about docs duplication not hurting but IMO the current proposal overloads demo page and benefits doesn't justify it. My proposal: let's keep docs on the directive level and for config objects just list: class name, its description and property names.\r\n* I'm not excited about type and default value moved to the config classes - this makes working on directives much harder as now I need to jump between 2 classes to understand what is going on... I'm afraid that I don't have good counter-proposal ATM....\r\n* I'm not sure if having providers on our module level will cover a scenario where users  would like to have a config class specified as a provider on their module level. Did you check that providers specified on my module override providers on an imported module (probably yes, but just to be sure).\r\n\r\nSorry for all those back-and-forth but there are still few wrinkles I would like to see ironed out.... Just let me know if I'm asking for too much so I can take it over... Otherwise we really do appreciate your work on this stuff!   "}}
{"actor":{"display_login":"pkozlowski-opensource"}}