{"action":"created","issue":{"url":"https://api.github.com/repos/frappe/erpnext/issues/6223","repository_url":"https://api.github.com/repos/frappe/erpnext","labels_url":"https://api.github.com/repos/frappe/erpnext/issues/6223/labels{/name}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/6223/comments","events_url":"https://api.github.com/repos/frappe/erpnext/issues/6223/events","html_url":"https://github.com/frappe/erpnext/pull/6223","id":174020840,"number":6223,"title":"Suggested Changes to School","user":{"login":"manqala","id":21128143,"avatar_url":"https://avatars.githubusercontent.com/u/21128143?v=3","gravatar_id":"","url":"https://api.github.com/users/manqala","html_url":"https://github.com/manqala","followers_url":"https://api.github.com/users/manqala/followers","following_url":"https://api.github.com/users/manqala/following{/other_user}","gists_url":"https://api.github.com/users/manqala/gists{/gist_id}","starred_url":"https://api.github.com/users/manqala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manqala/subscriptions","organizations_url":"https://api.github.com/users/manqala/orgs","repos_url":"https://api.github.com/users/manqala/repos","events_url":"https://api.github.com/users/manqala/events{/privacy}","received_events_url":"https://api.github.com/users/manqala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-30T13:36:12Z","updated_at":"2016-09-02T05:34:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/6223","html_url":"https://github.com/frappe/erpnext/pull/6223","diff_url":"https://github.com/frappe/erpnext/pull/6223.diff","patch_url":"https://github.com/frappe/erpnext/pull/6223.patch"},"body":"### Change Log for Implemented Suggestions\r\n\r\n**Academic Year:** \r\nAdd validation to make sure that the start date is before the end date. To be done in controller.\r\n\r\n**Academic Term:** \r\nAdd the following fields:\r\n- Academic Year (done)\r\n- Term Start Date (done)\r\n- Term End Date (done)\r\n\r\nAdd Validation on saving of Academic Term to make sure that duplicate Term Name and Academic Year are not allowed.\r\nAdd validation to make sure that the start of the term is not before the start of the academic year it is linked to and end of term is not after the end of the academic year it is linked to.\r\n\r\n**Student Batch:**\r\n Make sure that the academic term is filtered based on the academic year (filter in client js)\r\n\r\n**Student Group:** \r\nThe following should be defaulted from student_batch.program using add_fetch in .js file:\r\n- Program\r\n- Academic term\r\n- Academic year\r\n\r\n**Student Group Creation Tool:** \r\nLet the Academic Term be filtered based on the Academic Year (add_fetch in client js)\r\n\r\n**Student Applicant:**\r\n Update the Nationality to a Link pointing to Country (done)\r\n\r\n**Program Enrolment:** \r\nLet the Academic Term be filtered based on the Academic Year (filter in client js) Let Fee Structure be filtered based on Academic Term (filter in client js)\r\n\r\n**Assessment:** \r\nCreate a DocType called Grading Structure has the following Fields: (done)\r\n\r\n- Name (Data)\r\n- Description (Data)\r\n- Grade Interval (Table)\r\n- Grade Interval DocType contains the following fields\r\nGrade Code (data)\r\n- - - - From Score (float)\r\n- - - - To Score (float)\r\n- - - - Grade Description (data)\r\n\r\nCreate a Validation in Grading Structure that checks for overlapping intervals  Create an extra read-only field called Grade in the Results table\r\n\r\n**Update Assessment to include Grading Structure**\r\nWhen a result (score) it entered in a line in the Results section of assessment, look-up the appropriate grade from the grading system specified in the assessment and enter it into the read-only field for Grade. If Grading System is left blank in the Assessment, then don’t try to perform any inference of grades\r\n\r\n**Fees:**\r\n Make sure that the academic term is filtered based on the academic year Make sure that the fee structure is filtered based on the academic term\r\n"},"comment":{"url":"https://api.github.com/repos/frappe/erpnext/issues/comments/244287212","html_url":"https://github.com/frappe/erpnext/pull/6223#issuecomment-244287212","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/6223","id":244287212,"user":{"login":"manqala","id":21128143,"avatar_url":"https://avatars.githubusercontent.com/u/21128143?v=3","gravatar_id":"","url":"https://api.github.com/users/manqala","html_url":"https://github.com/manqala","followers_url":"https://api.github.com/users/manqala/followers","following_url":"https://api.github.com/users/manqala/following{/other_user}","gists_url":"https://api.github.com/users/manqala/gists{/gist_id}","starred_url":"https://api.github.com/users/manqala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manqala/subscriptions","organizations_url":"https://api.github.com/users/manqala/orgs","repos_url":"https://api.github.com/users/manqala/repos","events_url":"https://api.github.com/users/manqala/events{/privacy}","received_events_url":"https://api.github.com/users/manqala/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T05:34:20Z","updated_at":"2016-09-02T05:34:20Z","body":"Okay will add some screenshots.\n\nRegards,\ncksgb\n\nOn Sep 2, 2016 4:32 AM, \"Rushabh Mehta\" <notifications@github.com> wrote:\n\n> @manqala <https://github.com/manqala> Looks good.\n>\n> Will be very easy to merge if you can add a few screenshots here.\n>\n> @neilLasrado <https://github.com/neilLasrado> will be also working on a\n> lot of changes in the next couple of months as we are doing an\n> implementation at a local school too.\n>\n> Request both of you to connect and have a quick Skype call to understand!\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/frappe/erpnext/pull/6223#issuecomment-244274708>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AUJjz3W2EU9UfYV4Vji82PlIuLnHzNs3ks5ql5jDgaJpZM4JwiG5>\n> .\n>\n"}}
{"actor":{"display_login":"manqala"}}