{"action":"created","comment":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/comments/75752492","id":75752492,"diff_hunk":"@@ -29,6 +31,14 @@ func MakeInMemorySagaLog() SagaLog {\n \t}\n }\n \n+type SagaLogMemoryConfig struct {","path":"saga/inMemorySagaLog.go","position":13,"original_position":13,"commit_id":"99c5773defe7e140929a62658c896e63f149b979","original_commit_id":"99c5773defe7e140929a62658c896e63f149b979","user":{"login":"CaitieM20","id":3310141,"avatar_url":"https://avatars.githubusercontent.com/u/3310141?v=3","gravatar_id":"","url":"https://api.github.com/users/CaitieM20","html_url":"https://github.com/CaitieM20","followers_url":"https://api.github.com/users/CaitieM20/followers","following_url":"https://api.github.com/users/CaitieM20/following{/other_user}","gists_url":"https://api.github.com/users/CaitieM20/gists{/gist_id}","starred_url":"https://api.github.com/users/CaitieM20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaitieM20/subscriptions","organizations_url":"https://api.github.com/users/CaitieM20/orgs","repos_url":"https://api.github.com/users/CaitieM20/repos","events_url":"https://api.github.com/users/CaitieM20/events{/privacy}","received_events_url":"https://api.github.com/users/CaitieM20/received_events","type":"User","site_admin":false},"body":"why does in memory saga log need a config?","created_at":"2016-08-22T20:30:53Z","updated_at":"2016-08-22T20:30:53Z","html_url":"https://github.com/scootdev/scoot/pull/78#discussion_r75752492","pull_request_url":"https://api.github.com/repos/scootdev/scoot/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments/75752492"},"html":{"href":"https://github.com/scootdev/scoot/pull/78#discussion_r75752492"},"pull_request":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/scootdev/scoot/pulls/78","id":82207411,"html_url":"https://github.com/scootdev/scoot/pull/78","diff_url":"https://github.com/scootdev/scoot/pull/78.diff","patch_url":"https://github.com/scootdev/scoot/pull/78.patch","issue_url":"https://api.github.com/repos/scootdev/scoot/issues/78","number":78,"state":"open","locked":false,"title":"ice: injection & configuration environment","user":{"login":"dbentley","id":159980,"avatar_url":"https://avatars.githubusercontent.com/u/159980?v=3","gravatar_id":"","url":"https://api.github.com/users/dbentley","html_url":"https://github.com/dbentley","followers_url":"https://api.github.com/users/dbentley/followers","following_url":"https://api.github.com/users/dbentley/following{/other_user}","gists_url":"https://api.github.com/users/dbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbentley/subscriptions","organizations_url":"https://api.github.com/users/dbentley/orgs","repos_url":"https://api.github.com/users/dbentley/repos","events_url":"https://api.github.com/users/dbentley/events{/privacy}","received_events_url":"https://api.github.com/users/dbentley/received_events","type":"User","site_admin":false},"body":"ICE extracts the logic in sched/config.go and makes it general so it can work for all our binaries.\r\n\r\nThe central object is an Environment, which binds providers. An Environment can then Eval to create objects. DI, tada!\r\n\r\nBut we want more: we want configuration. So ice also has Options, which lets a program define Variables with multiple Variants. Then Parse takes JSON and creates a Module that can be Installed to the Environment before Eval.\r\n\r\nThis gives us:\r\na) injection\r\nb) configuration\r\nc) extensibility (so it works across all binaries)\r\n\r\nThis works to create the scheduler, but currently doesn't create the associated health checking, which would take extending Eval to create multiple objects in one go, which I can do easily if we think this is a good approach.","created_at":"2016-08-22T15:03:55Z","updated_at":"2016-08-22T20:30:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scootdev/scoot/pulls/78/commits","review_comments_url":"https://api.github.com/repos/scootdev/scoot/pulls/78/comments","review_comment_url":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scootdev/scoot/issues/78/comments","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/99c5773defe7e140929a62658c896e63f149b979","head":{"label":"dbentley:dbentley/ice","ref":"dbentley/ice","sha":"99c5773defe7e140929a62658c896e63f149b979","user":{"login":"dbentley","id":159980,"avatar_url":"https://avatars.githubusercontent.com/u/159980?v=3","gravatar_id":"","url":"https://api.github.com/users/dbentley","html_url":"https://github.com/dbentley","followers_url":"https://api.github.com/users/dbentley/followers","following_url":"https://api.github.com/users/dbentley/following{/other_user}","gists_url":"https://api.github.com/users/dbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbentley/subscriptions","organizations_url":"https://api.github.com/users/dbentley/orgs","repos_url":"https://api.github.com/users/dbentley/repos","events_url":"https://api.github.com/users/dbentley/events{/privacy}","received_events_url":"https://api.github.com/users/dbentley/received_events","type":"User","site_admin":false},"repo":{"id":60234631,"name":"scoot","full_name":"dbentley/scoot","owner":{"login":"dbentley","id":159980,"avatar_url":"https://avatars.githubusercontent.com/u/159980?v=3","gravatar_id":"","url":"https://api.github.com/users/dbentley","html_url":"https://github.com/dbentley","followers_url":"https://api.github.com/users/dbentley/followers","following_url":"https://api.github.com/users/dbentley/following{/other_user}","gists_url":"https://api.github.com/users/dbentley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbentley/subscriptions","organizations_url":"https://api.github.com/users/dbentley/orgs","repos_url":"https://api.github.com/users/dbentley/repos","events_url":"https://api.github.com/users/dbentley/events{/privacy}","received_events_url":"https://api.github.com/users/dbentley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbentley/scoot","description":"","fork":true,"url":"https://api.github.com/repos/dbentley/scoot","forks_url":"https://api.github.com/repos/dbentley/scoot/forks","keys_url":"https://api.github.com/repos/dbentley/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbentley/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbentley/scoot/teams","hooks_url":"https://api.github.com/repos/dbentley/scoot/hooks","issue_events_url":"https://api.github.com/repos/dbentley/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/dbentley/scoot/events","assignees_url":"https://api.github.com/repos/dbentley/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/dbentley/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/dbentley/scoot/tags","blobs_url":"https://api.github.com/repos/dbentley/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbentley/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbentley/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbentley/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbentley/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/dbentley/scoot/languages","stargazers_url":"https://api.github.com/repos/dbentley/scoot/stargazers","contributors_url":"https://api.github.com/repos/dbentley/scoot/contributors","subscribers_url":"https://api.github.com/repos/dbentley/scoot/subscribers","subscription_url":"https://api.github.com/repos/dbentley/scoot/subscription","commits_url":"https://api.github.com/repos/dbentley/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbentley/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbentley/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbentley/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbentley/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/dbentley/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbentley/scoot/merges","archive_url":"https://api.github.com/repos/dbentley/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbentley/scoot/downloads","issues_url":"https://api.github.com/repos/dbentley/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/dbentley/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/dbentley/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/dbentley/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbentley/scoot/labels{/name}","releases_url":"https://api.github.com/repos/dbentley/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/dbentley/scoot/deployments","created_at":"2016-06-02T05:17:53Z","updated_at":"2016-06-02T05:17:54Z","pushed_at":"2016-08-22T18:02:28Z","git_url":"git://github.com/dbentley/scoot.git","ssh_url":"git@github.com:dbentley/scoot.git","clone_url":"https://github.com/dbentley/scoot.git","svn_url":"https://github.com/dbentley/scoot","homepage":null,"size":7172,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"scootdev:master","ref":"master","sha":"2ff21c11780f63b96a43fb73615222194a319866","user":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"repo":{"id":48396966,"name":"scoot","full_name":"scootdev/scoot","owner":{"login":"scootdev","id":16392490,"avatar_url":"https://avatars.githubusercontent.com/u/16392490?v=3","gravatar_id":"","url":"https://api.github.com/users/scootdev","html_url":"https://github.com/scootdev","followers_url":"https://api.github.com/users/scootdev/followers","following_url":"https://api.github.com/users/scootdev/following{/other_user}","gists_url":"https://api.github.com/users/scootdev/gists{/gist_id}","starred_url":"https://api.github.com/users/scootdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scootdev/subscriptions","organizations_url":"https://api.github.com/users/scootdev/orgs","repos_url":"https://api.github.com/users/scootdev/repos","events_url":"https://api.github.com/users/scootdev/events{/privacy}","received_events_url":"https://api.github.com/users/scootdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scootdev/scoot","description":"","fork":false,"url":"https://api.github.com/repos/scootdev/scoot","forks_url":"https://api.github.com/repos/scootdev/scoot/forks","keys_url":"https://api.github.com/repos/scootdev/scoot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scootdev/scoot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scootdev/scoot/teams","hooks_url":"https://api.github.com/repos/scootdev/scoot/hooks","issue_events_url":"https://api.github.com/repos/scootdev/scoot/issues/events{/number}","events_url":"https://api.github.com/repos/scootdev/scoot/events","assignees_url":"https://api.github.com/repos/scootdev/scoot/assignees{/user}","branches_url":"https://api.github.com/repos/scootdev/scoot/branches{/branch}","tags_url":"https://api.github.com/repos/scootdev/scoot/tags","blobs_url":"https://api.github.com/repos/scootdev/scoot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scootdev/scoot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scootdev/scoot/git/refs{/sha}","trees_url":"https://api.github.com/repos/scootdev/scoot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scootdev/scoot/statuses/{sha}","languages_url":"https://api.github.com/repos/scootdev/scoot/languages","stargazers_url":"https://api.github.com/repos/scootdev/scoot/stargazers","contributors_url":"https://api.github.com/repos/scootdev/scoot/contributors","subscribers_url":"https://api.github.com/repos/scootdev/scoot/subscribers","subscription_url":"https://api.github.com/repos/scootdev/scoot/subscription","commits_url":"https://api.github.com/repos/scootdev/scoot/commits{/sha}","git_commits_url":"https://api.github.com/repos/scootdev/scoot/git/commits{/sha}","comments_url":"https://api.github.com/repos/scootdev/scoot/comments{/number}","issue_comment_url":"https://api.github.com/repos/scootdev/scoot/issues/comments{/number}","contents_url":"https://api.github.com/repos/scootdev/scoot/contents/{+path}","compare_url":"https://api.github.com/repos/scootdev/scoot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scootdev/scoot/merges","archive_url":"https://api.github.com/repos/scootdev/scoot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scootdev/scoot/downloads","issues_url":"https://api.github.com/repos/scootdev/scoot/issues{/number}","pulls_url":"https://api.github.com/repos/scootdev/scoot/pulls{/number}","milestones_url":"https://api.github.com/repos/scootdev/scoot/milestones{/number}","notifications_url":"https://api.github.com/repos/scootdev/scoot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scootdev/scoot/labels{/name}","releases_url":"https://api.github.com/repos/scootdev/scoot/releases{/id}","deployments_url":"https://api.github.com/repos/scootdev/scoot/deployments","created_at":"2015-12-21T22:14:54Z","updated_at":"2016-08-09T23:32:59Z","pushed_at":"2016-08-22T19:31:14Z","git_url":"git://github.com/scootdev/scoot.git","ssh_url":"git@github.com:scootdev/scoot.git","clone_url":"https://github.com/scootdev/scoot.git","svn_url":"https://github.com/scootdev/scoot","homepage":null,"size":7252,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/78"},"html":{"href":"https://github.com/scootdev/scoot/pull/78"},"issue":{"href":"https://api.github.com/repos/scootdev/scoot/issues/78"},"comments":{"href":"https://api.github.com/repos/scootdev/scoot/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scootdev/scoot/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/scootdev/scoot/statuses/99c5773defe7e140929a62658c896e63f149b979"}}}}
{"actor":{"display_login":"CaitieM20"}}