{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/intermezzOS/kernel/pulls/28","id":67153721,"html_url":"https://github.com/intermezzOS/kernel/pull/28","diff_url":"https://github.com/intermezzOS/kernel/pull/28.diff","patch_url":"https://github.com/intermezzOS/kernel/pull/28.patch","issue_url":"https://api.github.com/repos/intermezzOS/kernel/issues/28","number":28,"state":"closed","locked":false,"title":"Mark kmain() as never returning","user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"body":"This may help catch the bug you mentioned in https://www.youtube.com/watch?v=iTSx-8qK4Hw where you forgot to include `loop { }`, so `kmain` immediately returned to the boot assembly which continued to `hlt ; This should never happen`.","created_at":"2016-04-20T09:22:39Z","updated_at":"2016-05-08T23:02:08Z","closed_at":"2016-05-08T23:02:08Z","merged_at":"2016-05-08T23:02:08Z","merge_commit_sha":"a6b584d759fe72accf8f592b9f68a1b524dbc6ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/intermezzOS/kernel/pulls/28/commits","review_comments_url":"https://api.github.com/repos/intermezzOS/kernel/pulls/28/comments","review_comment_url":"https://api.github.com/repos/intermezzOS/kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intermezzOS/kernel/issues/28/comments","statuses_url":"https://api.github.com/repos/intermezzOS/kernel/statuses/27ef5cb7d9cb7912f7ff90c5d920e8db7cfa9c80","head":{"label":"SimonSapin:patch-1","ref":"patch-1","sha":"27ef5cb7d9cb7912f7ff90c5d920e8db7cfa9c80","user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"repo":{"id":56673350,"name":"kernel","full_name":"SimonSapin/kernel","owner":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonSapin/kernel","description":"A hobby operating system, in Rust","fork":true,"url":"https://api.github.com/repos/SimonSapin/kernel","forks_url":"https://api.github.com/repos/SimonSapin/kernel/forks","keys_url":"https://api.github.com/repos/SimonSapin/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonSapin/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonSapin/kernel/teams","hooks_url":"https://api.github.com/repos/SimonSapin/kernel/hooks","issue_events_url":"https://api.github.com/repos/SimonSapin/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/SimonSapin/kernel/events","assignees_url":"https://api.github.com/repos/SimonSapin/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/SimonSapin/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/SimonSapin/kernel/tags","blobs_url":"https://api.github.com/repos/SimonSapin/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonSapin/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonSapin/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonSapin/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonSapin/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonSapin/kernel/languages","stargazers_url":"https://api.github.com/repos/SimonSapin/kernel/stargazers","contributors_url":"https://api.github.com/repos/SimonSapin/kernel/contributors","subscribers_url":"https://api.github.com/repos/SimonSapin/kernel/subscribers","subscription_url":"https://api.github.com/repos/SimonSapin/kernel/subscription","commits_url":"https://api.github.com/repos/SimonSapin/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonSapin/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonSapin/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonSapin/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonSapin/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/SimonSapin/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonSapin/kernel/merges","archive_url":"https://api.github.com/repos/SimonSapin/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonSapin/kernel/downloads","issues_url":"https://api.github.com/repos/SimonSapin/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/SimonSapin/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonSapin/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonSapin/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonSapin/kernel/labels{/name}","releases_url":"https://api.github.com/repos/SimonSapin/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/SimonSapin/kernel/deployments","created_at":"2016-04-20T09:19:51Z","updated_at":"2016-04-20T09:19:52Z","pushed_at":"2016-04-20T09:22:28Z","git_url":"git://github.com/SimonSapin/kernel.git","ssh_url":"git@github.com:SimonSapin/kernel.git","clone_url":"https://github.com/SimonSapin/kernel.git","svn_url":"https://github.com/SimonSapin/kernel","homepage":"http://intermezzos.github.io/","size":91,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intermezzOS:master","ref":"master","sha":"d3f457730dc79b1cc70a5a3423e58f199ebc250b","user":{"login":"intermezzOS","id":16422108,"avatar_url":"https://avatars.githubusercontent.com/u/16422108?v=3","gravatar_id":"","url":"https://api.github.com/users/intermezzOS","html_url":"https://github.com/intermezzOS","followers_url":"https://api.github.com/users/intermezzOS/followers","following_url":"https://api.github.com/users/intermezzOS/following{/other_user}","gists_url":"https://api.github.com/users/intermezzOS/gists{/gist_id}","starred_url":"https://api.github.com/users/intermezzOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intermezzOS/subscriptions","organizations_url":"https://api.github.com/users/intermezzOS/orgs","repos_url":"https://api.github.com/users/intermezzOS/repos","events_url":"https://api.github.com/users/intermezzOS/events{/privacy}","received_events_url":"https://api.github.com/users/intermezzOS/received_events","type":"Organization","site_admin":false},"repo":{"id":44892115,"name":"kernel","full_name":"intermezzOS/kernel","owner":{"login":"intermezzOS","id":16422108,"avatar_url":"https://avatars.githubusercontent.com/u/16422108?v=3","gravatar_id":"","url":"https://api.github.com/users/intermezzOS","html_url":"https://github.com/intermezzOS","followers_url":"https://api.github.com/users/intermezzOS/followers","following_url":"https://api.github.com/users/intermezzOS/following{/other_user}","gists_url":"https://api.github.com/users/intermezzOS/gists{/gist_id}","starred_url":"https://api.github.com/users/intermezzOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intermezzOS/subscriptions","organizations_url":"https://api.github.com/users/intermezzOS/orgs","repos_url":"https://api.github.com/users/intermezzOS/repos","events_url":"https://api.github.com/users/intermezzOS/events{/privacy}","received_events_url":"https://api.github.com/users/intermezzOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intermezzOS/kernel","description":"A hobby operating system, in Rust","fork":false,"url":"https://api.github.com/repos/intermezzOS/kernel","forks_url":"https://api.github.com/repos/intermezzOS/kernel/forks","keys_url":"https://api.github.com/repos/intermezzOS/kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intermezzOS/kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intermezzOS/kernel/teams","hooks_url":"https://api.github.com/repos/intermezzOS/kernel/hooks","issue_events_url":"https://api.github.com/repos/intermezzOS/kernel/issues/events{/number}","events_url":"https://api.github.com/repos/intermezzOS/kernel/events","assignees_url":"https://api.github.com/repos/intermezzOS/kernel/assignees{/user}","branches_url":"https://api.github.com/repos/intermezzOS/kernel/branches{/branch}","tags_url":"https://api.github.com/repos/intermezzOS/kernel/tags","blobs_url":"https://api.github.com/repos/intermezzOS/kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intermezzOS/kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intermezzOS/kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/intermezzOS/kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intermezzOS/kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/intermezzOS/kernel/languages","stargazers_url":"https://api.github.com/repos/intermezzOS/kernel/stargazers","contributors_url":"https://api.github.com/repos/intermezzOS/kernel/contributors","subscribers_url":"https://api.github.com/repos/intermezzOS/kernel/subscribers","subscription_url":"https://api.github.com/repos/intermezzOS/kernel/subscription","commits_url":"https://api.github.com/repos/intermezzOS/kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/intermezzOS/kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/intermezzOS/kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/intermezzOS/kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/intermezzOS/kernel/contents/{+path}","compare_url":"https://api.github.com/repos/intermezzOS/kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intermezzOS/kernel/merges","archive_url":"https://api.github.com/repos/intermezzOS/kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intermezzOS/kernel/downloads","issues_url":"https://api.github.com/repos/intermezzOS/kernel/issues{/number}","pulls_url":"https://api.github.com/repos/intermezzOS/kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/intermezzOS/kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/intermezzOS/kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intermezzOS/kernel/labels{/name}","releases_url":"https://api.github.com/repos/intermezzOS/kernel/releases{/id}","deployments_url":"https://api.github.com/repos/intermezzOS/kernel/deployments","created_at":"2015-10-25T01:36:53Z","updated_at":"2016-05-06T22:00:11Z","pushed_at":"2016-05-08T23:02:08Z","git_url":"git://github.com/intermezzOS/kernel.git","ssh_url":"git@github.com:intermezzOS/kernel.git","clone_url":"https://github.com/intermezzOS/kernel.git","svn_url":"https://github.com/intermezzOS/kernel","homepage":"http://intermezzos.github.io/","size":92,"stargazers_count":321,"watchers_count":321,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":10,"forks":23,"open_issues":10,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/28"},"html":{"href":"https://github.com/intermezzOS/kernel/pull/28"},"issue":{"href":"https://api.github.com/repos/intermezzOS/kernel/issues/28"},"comments":{"href":"https://api.github.com/repos/intermezzOS/kernel/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intermezzOS/kernel/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/intermezzOS/kernel/statuses/27ef5cb7d9cb7912f7ff90c5d920e8db7cfa9c80"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}