{"action":"created","comment":{"url":"https://api.github.com/repos/cyclejs/history/pulls/comments/62233650","id":62233650,"diff_hunk":"@@ -45,8 +45,12 @@ class ServerHistory implements History {\n   complete() {\n     this._completeCallback();\n   }\n+\n+  getCurrentLocation() {\n+    return this.currentLocation;\n+  }\n }\n \n-export function createServerHistory(): History {\n-  return new ServerHistory();\n+export function createServerHistory(currentLocation: Location | Pathname): History {\n+  return new ServerHistory(createLocation(currentLocation));","path":"src/serverHistory.ts","position":31,"original_position":31,"commit_id":"439036d806dd084184623dac1022fd1602d13c3c","original_commit_id":"a921ca6d7a1ba5616286f7064cc6c4f28f73ae31","user":{"login":"TylorS","id":6282473,"avatar_url":"https://avatars.githubusercontent.com/u/6282473?v=3","gravatar_id":"","url":"https://api.github.com/users/TylorS","html_url":"https://github.com/TylorS","followers_url":"https://api.github.com/users/TylorS/followers","following_url":"https://api.github.com/users/TylorS/following{/other_user}","gists_url":"https://api.github.com/users/TylorS/gists{/gist_id}","starred_url":"https://api.github.com/users/TylorS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylorS/subscriptions","organizations_url":"https://api.github.com/users/TylorS/orgs","repos_url":"https://api.github.com/users/TylorS/repos","events_url":"https://api.github.com/users/TylorS/events{/privacy}","received_events_url":"https://api.github.com/users/TylorS/received_events","type":"User","site_admin":false},"body":"I think this could actually break applications without this. Currently the application will get passed `undefined` as its first value, where we don't have the same access as below where we can use `drop(1)`/`skip(1)`","created_at":"2016-05-05T18:40:16Z","updated_at":"2016-05-05T18:40:16Z","html_url":"https://github.com/cyclejs/history/pull/24#discussion_r62233650","pull_request_url":"https://api.github.com/repos/cyclejs/history/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/cyclejs/history/pulls/comments/62233650"},"html":{"href":"https://github.com/cyclejs/history/pull/24#discussion_r62233650"},"pull_request":{"href":"https://api.github.com/repos/cyclejs/history/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/cyclejs/history/pulls/24","id":69047787,"html_url":"https://github.com/cyclejs/history/pull/24","diff_url":"https://github.com/cyclejs/history/pull/24.diff","patch_url":"https://github.com/cyclejs/history/pull/24.patch","issue_url":"https://api.github.com/repos/cyclejs/history/issues/24","number":24,"state":"open","locked":false,"title":"feat(History3.0): Adapt to history 3","user":{"login":"michalvankodev","id":2760618,"avatar_url":"https://avatars.githubusercontent.com/u/2760618?v=3","gravatar_id":"","url":"https://api.github.com/users/michalvankodev","html_url":"https://github.com/michalvankodev","followers_url":"https://api.github.com/users/michalvankodev/followers","following_url":"https://api.github.com/users/michalvankodev/following{/other_user}","gists_url":"https://api.github.com/users/michalvankodev/gists{/gist_id}","starred_url":"https://api.github.com/users/michalvankodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalvankodev/subscriptions","organizations_url":"https://api.github.com/users/michalvankodev/orgs","repos_url":"https://api.github.com/users/michalvankodev/repos","events_url":"https://api.github.com/users/michalvankodev/events{/privacy}","received_events_url":"https://api.github.com/users/michalvankodev/received_events","type":"User","site_admin":false},"body":"BREAKING: `createServerHistory()` now takes a Location | Pathname as a\r\nparameter and emits immidiately on sources stream.\r\nBREAKING: `makeHistoryDriver()` requires a history object with\r\n`.getCurrentLocation()` method.\r\nBREAKING: `Location.state` is no longer null if not defined but `undefined` see https://github.com/mjackson/history/blob/master/CHANGES.md","created_at":"2016-05-05T18:25:50Z","updated_at":"2016-05-05T18:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"deacd817a66a37102e2275ba6bcc0bea9f768f4f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cyclejs/history/pulls/24/commits","review_comments_url":"https://api.github.com/repos/cyclejs/history/pulls/24/comments","review_comment_url":"https://api.github.com/repos/cyclejs/history/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyclejs/history/issues/24/comments","statuses_url":"https://api.github.com/repos/cyclejs/history/statuses/439036d806dd084184623dac1022fd1602d13c3c","head":{"label":"michalvankodev:history-4","ref":"history-4","sha":"439036d806dd084184623dac1022fd1602d13c3c","user":{"login":"michalvankodev","id":2760618,"avatar_url":"https://avatars.githubusercontent.com/u/2760618?v=3","gravatar_id":"","url":"https://api.github.com/users/michalvankodev","html_url":"https://github.com/michalvankodev","followers_url":"https://api.github.com/users/michalvankodev/followers","following_url":"https://api.github.com/users/michalvankodev/following{/other_user}","gists_url":"https://api.github.com/users/michalvankodev/gists{/gist_id}","starred_url":"https://api.github.com/users/michalvankodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalvankodev/subscriptions","organizations_url":"https://api.github.com/users/michalvankodev/orgs","repos_url":"https://api.github.com/users/michalvankodev/repos","events_url":"https://api.github.com/users/michalvankodev/events{/privacy}","received_events_url":"https://api.github.com/users/michalvankodev/received_events","type":"User","site_admin":false},"repo":{"id":57161934,"name":"history","full_name":"michalvankodev/history","owner":{"login":"michalvankodev","id":2760618,"avatar_url":"https://avatars.githubusercontent.com/u/2760618?v=3","gravatar_id":"","url":"https://api.github.com/users/michalvankodev","html_url":"https://github.com/michalvankodev","followers_url":"https://api.github.com/users/michalvankodev/followers","following_url":"https://api.github.com/users/michalvankodev/following{/other_user}","gists_url":"https://api.github.com/users/michalvankodev/gists{/gist_id}","starred_url":"https://api.github.com/users/michalvankodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalvankodev/subscriptions","organizations_url":"https://api.github.com/users/michalvankodev/orgs","repos_url":"https://api.github.com/users/michalvankodev/repos","events_url":"https://api.github.com/users/michalvankodev/events{/privacy}","received_events_url":"https://api.github.com/users/michalvankodev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michalvankodev/history","description":"Cycle.js URL Driver based on the rackt/history library.","fork":true,"url":"https://api.github.com/repos/michalvankodev/history","forks_url":"https://api.github.com/repos/michalvankodev/history/forks","keys_url":"https://api.github.com/repos/michalvankodev/history/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michalvankodev/history/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michalvankodev/history/teams","hooks_url":"https://api.github.com/repos/michalvankodev/history/hooks","issue_events_url":"https://api.github.com/repos/michalvankodev/history/issues/events{/number}","events_url":"https://api.github.com/repos/michalvankodev/history/events","assignees_url":"https://api.github.com/repos/michalvankodev/history/assignees{/user}","branches_url":"https://api.github.com/repos/michalvankodev/history/branches{/branch}","tags_url":"https://api.github.com/repos/michalvankodev/history/tags","blobs_url":"https://api.github.com/repos/michalvankodev/history/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michalvankodev/history/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michalvankodev/history/git/refs{/sha}","trees_url":"https://api.github.com/repos/michalvankodev/history/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michalvankodev/history/statuses/{sha}","languages_url":"https://api.github.com/repos/michalvankodev/history/languages","stargazers_url":"https://api.github.com/repos/michalvankodev/history/stargazers","contributors_url":"https://api.github.com/repos/michalvankodev/history/contributors","subscribers_url":"https://api.github.com/repos/michalvankodev/history/subscribers","subscription_url":"https://api.github.com/repos/michalvankodev/history/subscription","commits_url":"https://api.github.com/repos/michalvankodev/history/commits{/sha}","git_commits_url":"https://api.github.com/repos/michalvankodev/history/git/commits{/sha}","comments_url":"https://api.github.com/repos/michalvankodev/history/comments{/number}","issue_comment_url":"https://api.github.com/repos/michalvankodev/history/issues/comments{/number}","contents_url":"https://api.github.com/repos/michalvankodev/history/contents/{+path}","compare_url":"https://api.github.com/repos/michalvankodev/history/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michalvankodev/history/merges","archive_url":"https://api.github.com/repos/michalvankodev/history/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michalvankodev/history/downloads","issues_url":"https://api.github.com/repos/michalvankodev/history/issues{/number}","pulls_url":"https://api.github.com/repos/michalvankodev/history/pulls{/number}","milestones_url":"https://api.github.com/repos/michalvankodev/history/milestones{/number}","notifications_url":"https://api.github.com/repos/michalvankodev/history/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michalvankodev/history/labels{/name}","releases_url":"https://api.github.com/repos/michalvankodev/history/releases{/id}","deployments_url":"https://api.github.com/repos/michalvankodev/history/deployments","created_at":"2016-04-26T21:07:38Z","updated_at":"2016-04-26T21:07:39Z","pushed_at":"2016-05-05T18:35:10Z","git_url":"git://github.com/michalvankodev/history.git","ssh_url":"git@github.com:michalvankodev/history.git","clone_url":"https://github.com/michalvankodev/history.git","svn_url":"https://github.com/michalvankodev/history","homepage":"","size":1002,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyclejs:master","ref":"master","sha":"d3ff3c487ab710f0b6028361b3ad3d4b05709265","user":{"login":"cyclejs","id":12686838,"avatar_url":"https://avatars.githubusercontent.com/u/12686838?v=3","gravatar_id":"","url":"https://api.github.com/users/cyclejs","html_url":"https://github.com/cyclejs","followers_url":"https://api.github.com/users/cyclejs/followers","following_url":"https://api.github.com/users/cyclejs/following{/other_user}","gists_url":"https://api.github.com/users/cyclejs/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclejs/subscriptions","organizations_url":"https://api.github.com/users/cyclejs/orgs","repos_url":"https://api.github.com/users/cyclejs/repos","events_url":"https://api.github.com/users/cyclejs/events{/privacy}","received_events_url":"https://api.github.com/users/cyclejs/received_events","type":"Organization","site_admin":false},"repo":{"id":43073837,"name":"history","full_name":"cyclejs/history","owner":{"login":"cyclejs","id":12686838,"avatar_url":"https://avatars.githubusercontent.com/u/12686838?v=3","gravatar_id":"","url":"https://api.github.com/users/cyclejs","html_url":"https://github.com/cyclejs","followers_url":"https://api.github.com/users/cyclejs/followers","following_url":"https://api.github.com/users/cyclejs/following{/other_user}","gists_url":"https://api.github.com/users/cyclejs/gists{/gist_id}","starred_url":"https://api.github.com/users/cyclejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyclejs/subscriptions","organizations_url":"https://api.github.com/users/cyclejs/orgs","repos_url":"https://api.github.com/users/cyclejs/repos","events_url":"https://api.github.com/users/cyclejs/events{/privacy}","received_events_url":"https://api.github.com/users/cyclejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyclejs/history","description":"Cycle.js URL Driver based on the rackt/history library.","fork":false,"url":"https://api.github.com/repos/cyclejs/history","forks_url":"https://api.github.com/repos/cyclejs/history/forks","keys_url":"https://api.github.com/repos/cyclejs/history/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyclejs/history/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyclejs/history/teams","hooks_url":"https://api.github.com/repos/cyclejs/history/hooks","issue_events_url":"https://api.github.com/repos/cyclejs/history/issues/events{/number}","events_url":"https://api.github.com/repos/cyclejs/history/events","assignees_url":"https://api.github.com/repos/cyclejs/history/assignees{/user}","branches_url":"https://api.github.com/repos/cyclejs/history/branches{/branch}","tags_url":"https://api.github.com/repos/cyclejs/history/tags","blobs_url":"https://api.github.com/repos/cyclejs/history/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyclejs/history/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyclejs/history/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyclejs/history/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyclejs/history/statuses/{sha}","languages_url":"https://api.github.com/repos/cyclejs/history/languages","stargazers_url":"https://api.github.com/repos/cyclejs/history/stargazers","contributors_url":"https://api.github.com/repos/cyclejs/history/contributors","subscribers_url":"https://api.github.com/repos/cyclejs/history/subscribers","subscription_url":"https://api.github.com/repos/cyclejs/history/subscription","commits_url":"https://api.github.com/repos/cyclejs/history/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyclejs/history/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyclejs/history/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyclejs/history/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyclejs/history/contents/{+path}","compare_url":"https://api.github.com/repos/cyclejs/history/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyclejs/history/merges","archive_url":"https://api.github.com/repos/cyclejs/history/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyclejs/history/downloads","issues_url":"https://api.github.com/repos/cyclejs/history/issues{/number}","pulls_url":"https://api.github.com/repos/cyclejs/history/pulls{/number}","milestones_url":"https://api.github.com/repos/cyclejs/history/milestones{/number}","notifications_url":"https://api.github.com/repos/cyclejs/history/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyclejs/history/labels{/name}","releases_url":"https://api.github.com/repos/cyclejs/history/releases{/id}","deployments_url":"https://api.github.com/repos/cyclejs/history/deployments","created_at":"2015-09-24T15:00:36Z","updated_at":"2016-04-28T20:30:55Z","pushed_at":"2016-05-05T18:35:10Z","git_url":"git://github.com/cyclejs/history.git","ssh_url":"git@github.com:cyclejs/history.git","clone_url":"https://github.com/cyclejs/history.git","svn_url":"https://github.com/cyclejs/history","homepage":"","size":1018,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyclejs/history/pulls/24"},"html":{"href":"https://github.com/cyclejs/history/pull/24"},"issue":{"href":"https://api.github.com/repos/cyclejs/history/issues/24"},"comments":{"href":"https://api.github.com/repos/cyclejs/history/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/cyclejs/history/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/cyclejs/history/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyclejs/history/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/cyclejs/history/statuses/439036d806dd084184623dac1022fd1602d13c3c"}}}}