{"action":"opened","number":26,"pull_request":{"url":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/26","id":73029574,"html_url":"https://github.com/yaacov/node-modbus-serial/pull/26","diff_url":"https://github.com/yaacov/node-modbus-serial/pull/26.diff","patch_url":"https://github.com/yaacov/node-modbus-serial/pull/26.patch","issue_url":"https://api.github.com/repos/yaacov/node-modbus-serial/issues/26","number":26,"state":"open","locked":false,"title":"Adding Timeouts for requests ","user":{"login":"meteocontrol","id":11042909,"avatar_url":"https://avatars.githubusercontent.com/u/11042909?v=3","gravatar_id":"","url":"https://api.github.com/users/meteocontrol","html_url":"https://github.com/meteocontrol","followers_url":"https://api.github.com/users/meteocontrol/followers","following_url":"https://api.github.com/users/meteocontrol/following{/other_user}","gists_url":"https://api.github.com/users/meteocontrol/gists{/gist_id}","starred_url":"https://api.github.com/users/meteocontrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteocontrol/subscriptions","organizations_url":"https://api.github.com/users/meteocontrol/orgs","repos_url":"https://api.github.com/users/meteocontrol/repos","events_url":"https://api.github.com/users/meteocontrol/events{/privacy}","received_events_url":"https://api.github.com/users/meteocontrol/received_events","type":"User","site_admin":false},"body":"Hi @yaacov,\r\n\r\nwe added functionality for non answering devices (timeout) and also refactored the tests a little so they don't depend on one and each another. \r\nThe diff on **tests.js** is a mess please look into the file directly.\r\n\r\nNote: Added **sinon** in package.json so **npm install** is needed!\r\n\r\nBest regards\r\n\r\nThomas","created_at":"2016-06-08T11:25:52Z","updated_at":"2016-06-08T11:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/26/commits","review_comments_url":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/26/comments","review_comment_url":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yaacov/node-modbus-serial/issues/26/comments","statuses_url":"https://api.github.com/repos/yaacov/node-modbus-serial/statuses/cd54310ca1b749f4ec3ec4a3c02241a98fea01f7","head":{"label":"meteocontrol:master","ref":"master","sha":"cd54310ca1b749f4ec3ec4a3c02241a98fea01f7","user":{"login":"meteocontrol","id":11042909,"avatar_url":"https://avatars.githubusercontent.com/u/11042909?v=3","gravatar_id":"","url":"https://api.github.com/users/meteocontrol","html_url":"https://github.com/meteocontrol","followers_url":"https://api.github.com/users/meteocontrol/followers","following_url":"https://api.github.com/users/meteocontrol/following{/other_user}","gists_url":"https://api.github.com/users/meteocontrol/gists{/gist_id}","starred_url":"https://api.github.com/users/meteocontrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteocontrol/subscriptions","organizations_url":"https://api.github.com/users/meteocontrol/orgs","repos_url":"https://api.github.com/users/meteocontrol/repos","events_url":"https://api.github.com/users/meteocontrol/events{/privacy}","received_events_url":"https://api.github.com/users/meteocontrol/received_events","type":"User","site_admin":false},"repo":{"id":50098647,"name":"node-modbus-serial","full_name":"meteocontrol/node-modbus-serial","owner":{"login":"meteocontrol","id":11042909,"avatar_url":"https://avatars.githubusercontent.com/u/11042909?v=3","gravatar_id":"","url":"https://api.github.com/users/meteocontrol","html_url":"https://github.com/meteocontrol","followers_url":"https://api.github.com/users/meteocontrol/followers","following_url":"https://api.github.com/users/meteocontrol/following{/other_user}","gists_url":"https://api.github.com/users/meteocontrol/gists{/gist_id}","starred_url":"https://api.github.com/users/meteocontrol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteocontrol/subscriptions","organizations_url":"https://api.github.com/users/meteocontrol/orgs","repos_url":"https://api.github.com/users/meteocontrol/repos","events_url":"https://api.github.com/users/meteocontrol/events{/privacy}","received_events_url":"https://api.github.com/users/meteocontrol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meteocontrol/node-modbus-serial","description":"A pure JavaScript implemetation of MODBUS-RTU (and TCP) for NodeJS","fork":true,"url":"https://api.github.com/repos/meteocontrol/node-modbus-serial","forks_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/forks","keys_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/teams","hooks_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/hooks","issue_events_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/issues/events{/number}","events_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/events","assignees_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/assignees{/user}","branches_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/branches{/branch}","tags_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/tags","blobs_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/statuses/{sha}","languages_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/languages","stargazers_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/stargazers","contributors_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/contributors","subscribers_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/subscribers","subscription_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/subscription","commits_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/contents/{+path}","compare_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/merges","archive_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/downloads","issues_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/issues{/number}","pulls_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/pulls{/number}","milestones_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/milestones{/number}","notifications_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/labels{/name}","releases_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/releases{/id}","deployments_url":"https://api.github.com/repos/meteocontrol/node-modbus-serial/deployments","created_at":"2016-01-21T10:01:44Z","updated_at":"2016-01-21T13:39:45Z","pushed_at":"2016-06-08T11:22:40Z","git_url":"git://github.com/meteocontrol/node-modbus-serial.git","ssh_url":"git@github.com:meteocontrol/node-modbus-serial.git","clone_url":"https://github.com/meteocontrol/node-modbus-serial.git","svn_url":"https://github.com/meteocontrol/node-modbus-serial","homepage":"","size":143,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yaacov:master","ref":"master","sha":"b36b96562d5a08abb3542a43f50347a9a543d46a","user":{"login":"yaacov","id":2181522,"avatar_url":"https://avatars.githubusercontent.com/u/2181522?v=3","gravatar_id":"","url":"https://api.github.com/users/yaacov","html_url":"https://github.com/yaacov","followers_url":"https://api.github.com/users/yaacov/followers","following_url":"https://api.github.com/users/yaacov/following{/other_user}","gists_url":"https://api.github.com/users/yaacov/gists{/gist_id}","starred_url":"https://api.github.com/users/yaacov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaacov/subscriptions","organizations_url":"https://api.github.com/users/yaacov/orgs","repos_url":"https://api.github.com/users/yaacov/repos","events_url":"https://api.github.com/users/yaacov/events{/privacy}","received_events_url":"https://api.github.com/users/yaacov/received_events","type":"User","site_admin":false},"repo":{"id":45757800,"name":"node-modbus-serial","full_name":"yaacov/node-modbus-serial","owner":{"login":"yaacov","id":2181522,"avatar_url":"https://avatars.githubusercontent.com/u/2181522?v=3","gravatar_id":"","url":"https://api.github.com/users/yaacov","html_url":"https://github.com/yaacov","followers_url":"https://api.github.com/users/yaacov/followers","following_url":"https://api.github.com/users/yaacov/following{/other_user}","gists_url":"https://api.github.com/users/yaacov/gists{/gist_id}","starred_url":"https://api.github.com/users/yaacov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaacov/subscriptions","organizations_url":"https://api.github.com/users/yaacov/orgs","repos_url":"https://api.github.com/users/yaacov/repos","events_url":"https://api.github.com/users/yaacov/events{/privacy}","received_events_url":"https://api.github.com/users/yaacov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaacov/node-modbus-serial","description":"A pure JavaScript implemetation of MODBUS-RTU (and TCP) for NodeJS","fork":false,"url":"https://api.github.com/repos/yaacov/node-modbus-serial","forks_url":"https://api.github.com/repos/yaacov/node-modbus-serial/forks","keys_url":"https://api.github.com/repos/yaacov/node-modbus-serial/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaacov/node-modbus-serial/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaacov/node-modbus-serial/teams","hooks_url":"https://api.github.com/repos/yaacov/node-modbus-serial/hooks","issue_events_url":"https://api.github.com/repos/yaacov/node-modbus-serial/issues/events{/number}","events_url":"https://api.github.com/repos/yaacov/node-modbus-serial/events","assignees_url":"https://api.github.com/repos/yaacov/node-modbus-serial/assignees{/user}","branches_url":"https://api.github.com/repos/yaacov/node-modbus-serial/branches{/branch}","tags_url":"https://api.github.com/repos/yaacov/node-modbus-serial/tags","blobs_url":"https://api.github.com/repos/yaacov/node-modbus-serial/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaacov/node-modbus-serial/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaacov/node-modbus-serial/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaacov/node-modbus-serial/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaacov/node-modbus-serial/statuses/{sha}","languages_url":"https://api.github.com/repos/yaacov/node-modbus-serial/languages","stargazers_url":"https://api.github.com/repos/yaacov/node-modbus-serial/stargazers","contributors_url":"https://api.github.com/repos/yaacov/node-modbus-serial/contributors","subscribers_url":"https://api.github.com/repos/yaacov/node-modbus-serial/subscribers","subscription_url":"https://api.github.com/repos/yaacov/node-modbus-serial/subscription","commits_url":"https://api.github.com/repos/yaacov/node-modbus-serial/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaacov/node-modbus-serial/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaacov/node-modbus-serial/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaacov/node-modbus-serial/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaacov/node-modbus-serial/contents/{+path}","compare_url":"https://api.github.com/repos/yaacov/node-modbus-serial/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaacov/node-modbus-serial/merges","archive_url":"https://api.github.com/repos/yaacov/node-modbus-serial/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaacov/node-modbus-serial/downloads","issues_url":"https://api.github.com/repos/yaacov/node-modbus-serial/issues{/number}","pulls_url":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls{/number}","milestones_url":"https://api.github.com/repos/yaacov/node-modbus-serial/milestones{/number}","notifications_url":"https://api.github.com/repos/yaacov/node-modbus-serial/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaacov/node-modbus-serial/labels{/name}","releases_url":"https://api.github.com/repos/yaacov/node-modbus-serial/releases{/id}","deployments_url":"https://api.github.com/repos/yaacov/node-modbus-serial/deployments","created_at":"2015-11-07T22:41:18Z","updated_at":"2016-05-10T05:59:11Z","pushed_at":"2016-06-08T11:25:52Z","git_url":"git://github.com/yaacov/node-modbus-serial.git","ssh_url":"git@github.com:yaacov/node-modbus-serial.git","clone_url":"https://github.com/yaacov/node-modbus-serial.git","svn_url":"https://github.com/yaacov/node-modbus-serial","homepage":"","size":139,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":3,"forks":17,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/26"},"html":{"href":"https://github.com/yaacov/node-modbus-serial/pull/26"},"issue":{"href":"https://api.github.com/repos/yaacov/node-modbus-serial/issues/26"},"comments":{"href":"https://api.github.com/repos/yaacov/node-modbus-serial/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yaacov/node-modbus-serial/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/yaacov/node-modbus-serial/statuses/cd54310ca1b749f4ec3ec4a3c02241a98fea01f7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":5,"additions":378,"deletions":218,"changed_files":7}}
{"actor":{"display_login":"meteocontrol"}}