{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/48745191","id":48745191,"diff_hunk":"@@ -0,0 +1,66 @@\n+function decode (buffer, maxLength, minimal) {\n+  maxLength = maxLength || 4\n+  minimal = minimal === undefined ? true : minimal\n+\n+  var length = buffer.length\n+  if (length === 0) return 0\n+  if (length > maxLength) throw new TypeError('Script number overflow')\n+  if (minimal) {\n+    if ((buffer[length - 1] & 0x7f) === 0) {\n+      if (length <= 1 || (buffer[length - 2] & 0x80) === 0) throw new Error('Non-minimally encoded script number')\n+    }\n+  }\n+\n+  var result\n+\n+  // 40-bit\n+  if (length === 5) {\n+    var a = buffer.readUInt32LE(0)\n+    var b = buffer.readUInt8(4)\n+\n+    if (b & 0x80) return -((b & ~0x80) * 0x100000000 + a)\n+    return b * 0x100000000 + a\n+  }\n+\n+  // 32-bit / 24-bit / 16-bit / 8-bit\n+  for (var i = 0; i < length; ++i) {\n+    result |= buffer[i] << (8 * i)\n+  }\n+\n+  if (buffer[length - 1] & 0x80) return -(result & ~(0x80 << (8 * (length - 1))))","path":"src/script_number.js","position":30,"original_position":30,"commit_id":"302bbe81ba17670b556f0d52c6bfb28112a840ab","original_commit_id":"302bbe81ba17670b556f0d52c6bfb28112a840ab","user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"body":"@fanatid if you have any ideas on how to apply this to the 40-bit case,  then I'll go ahead and generalize the entire thing (yay).\r\n\r\nI can add you as a contributor if you want to push to this branch :+1: ","created_at":"2016-01-04T16:02:32Z","updated_at":"2016-01-04T16:02:32Z","html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/516#discussion_r48745191","pull_request_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments/48745191"},"html":{"href":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/516#discussion_r48745191"},"pull_request":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516","id":54983450,"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/516","diff_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/516.diff","patch_url":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/516.patch","issue_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/516","number":516,"state":"open","locked":false,"title":"script_number: add impl/tests","user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"body":"@jprichardson in working on the spend example for #511 (which I now regret merging without it), I've realised we didn't have a `CScriptNum` equivalent for script numbers encoded in a stack.","created_at":"2016-01-04T15:03:52Z","updated_at":"2016-01-04T16:02:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec2c261879ef24133f4bdd76e93b32f203b524f4","assignee":{"login":"jprichardson","id":150063,"avatar_url":"https://avatars.githubusercontent.com/u/150063?v=3","gravatar_id":"","url":"https://api.github.com/users/jprichardson","html_url":"https://github.com/jprichardson","followers_url":"https://api.github.com/users/jprichardson/followers","following_url":"https://api.github.com/users/jprichardson/following{/other_user}","gists_url":"https://api.github.com/users/jprichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/jprichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprichardson/subscriptions","organizations_url":"https://api.github.com/users/jprichardson/orgs","repos_url":"https://api.github.com/users/jprichardson/repos","events_url":"https://api.github.com/users/jprichardson/events{/privacy}","received_events_url":"https://api.github.com/users/jprichardson/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones/10","html_url":"https://github.com/bitcoinjs/bitcoinjs-lib/milestones/2.2.0","labels_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones/10/labels","id":1449395,"number":10,"title":"2.2.0","description":null,"creator":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2015-12-08T08:18:12Z","updated_at":"2016-01-04T15:03:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516/commits","review_comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516/comments","review_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/516/comments","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/302bbe81ba17670b556f0d52c6bfb28112a840ab","head":{"label":"bitcoinjs:scrnum","ref":"scrnum","sha":"302bbe81ba17670b556f0d52c6bfb28112a840ab","user":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1701968,"name":"bitcoinjs-lib","full_name":"bitcoinjs/bitcoinjs-lib","owner":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib","description":"Bitcoin-related functions implemented in pure JavaScript","fork":false,"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib","forks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/releases{/id}","created_at":"2011-05-04T16:03:45Z","updated_at":"2016-01-03T16:59:45Z","pushed_at":"2016-01-04T15:38:10Z","git_url":"git://github.com/bitcoinjs/bitcoinjs-lib.git","ssh_url":"git@github.com:bitcoinjs/bitcoinjs-lib.git","clone_url":"https://github.com/bitcoinjs/bitcoinjs-lib.git","svn_url":"https://github.com/bitcoinjs/bitcoinjs-lib","homepage":"http://bitcoinjs.org","size":2685,"stargazers_count":979,"watchers_count":979,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":304,"mirror_url":null,"open_issues_count":17,"forks":304,"open_issues":17,"watchers":979,"default_branch":"master"}},"base":{"label":"bitcoinjs:master","ref":"master","sha":"cba7252c9da9815bc216e369e8671654985e7d19","user":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1701968,"name":"bitcoinjs-lib","full_name":"bitcoinjs/bitcoinjs-lib","owner":{"login":"bitcoinjs","id":756696,"avatar_url":"https://avatars.githubusercontent.com/u/756696?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoinjs","html_url":"https://github.com/bitcoinjs","followers_url":"https://api.github.com/users/bitcoinjs/followers","following_url":"https://api.github.com/users/bitcoinjs/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinjs/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinjs/subscriptions","organizations_url":"https://api.github.com/users/bitcoinjs/orgs","repos_url":"https://api.github.com/users/bitcoinjs/repos","events_url":"https://api.github.com/users/bitcoinjs/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinjs/bitcoinjs-lib","description":"Bitcoin-related functions implemented in pure JavaScript","fork":false,"url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib","forks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/forks","keys_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/teams","hooks_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/hooks","issue_events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/events","assignees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/tags","blobs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/languages","stargazers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/stargazers","contributors_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contributors","subscribers_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscribers","subscription_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/subscription","commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/merges","archive_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/downloads","issues_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/releases{/id}","created_at":"2011-05-04T16:03:45Z","updated_at":"2016-01-03T16:59:45Z","pushed_at":"2016-01-04T15:38:10Z","git_url":"git://github.com/bitcoinjs/bitcoinjs-lib.git","ssh_url":"git@github.com:bitcoinjs/bitcoinjs-lib.git","clone_url":"https://github.com/bitcoinjs/bitcoinjs-lib.git","svn_url":"https://github.com/bitcoinjs/bitcoinjs-lib","homepage":"http://bitcoinjs.org","size":2685,"stargazers_count":979,"watchers_count":979,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":304,"mirror_url":null,"open_issues_count":17,"forks":304,"open_issues":17,"watchers":979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516"},"html":{"href":"https://github.com/bitcoinjs/bitcoinjs-lib/pull/516"},"issue":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/516"},"comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinjs/bitcoinjs-lib/statuses/302bbe81ba17670b556f0d52c6bfb28112a840ab"}}}}