{"action":"created","comment":{"url":"https://api.github.com/repos/apache/falcon/pulls/comments/88227498","pull_request_review_id":8805849,"id":88227498,"diff_hunk":"@@ -92,11 +104,21 @@ private static String getWFPath(final Map<String, String> extensionResources,\n         /* Get Lib path */\n         String wfLibPath = store.getExtensionLibPath(name);\n         Entity entity = ExtensionProcessBuilderUtils.createProcessFromTemplate(extensionTemplate,\n-                name, extensionProperties, wfPath, wfLibPath);\n+                name, configProperties, wfPath, wfLibPath);\n         if (entity == null) {\n             throw new FalconException(\"Entity created from the extension template cannot be null\");\n         }\n         LOG.info(\"Extension processing complete\");\n-        return Arrays.asList(entity);\n+        return Collections.singletonList(entity);\n+    }\n+\n+    @Override\n+    public void validateExtension(String extensionName, InputStream extensionConfigStream) throws FalconException {\n+        throw new UnsupportedException(\"Not yet Implemented\");","path":"extensions/src/main/java/org/apache/falcon/extensions/Extension.java","position":76,"original_position":76,"commit_id":"f3d7268e43ada567a87f8cfa02c29b5d3bc2c30f","original_commit_id":"f3d7268e43ada567a87f8cfa02c29b5d3bc2c30f","user":{"login":"pallavi-rao","id":9442234,"avatar_url":"https://avatars.githubusercontent.com/u/9442234?v=3","gravatar_id":"","url":"https://api.github.com/users/pallavi-rao","html_url":"https://github.com/pallavi-rao","followers_url":"https://api.github.com/users/pallavi-rao/followers","following_url":"https://api.github.com/users/pallavi-rao/following{/other_user}","gists_url":"https://api.github.com/users/pallavi-rao/gists{/gist_id}","starred_url":"https://api.github.com/users/pallavi-rao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallavi-rao/subscriptions","organizations_url":"https://api.github.com/users/pallavi-rao/orgs","repos_url":"https://api.github.com/users/pallavi-rao/repos","events_url":"https://api.github.com/users/pallavi-rao/events{/privacy}","received_events_url":"https://api.github.com/users/pallavi-rao/received_events","type":"User","site_admin":false},"body":"Apologies again for not pointing out earlier. Why unsupported? This could invoke org.apache.falcon.extensions.Extension#validateProperties. isn't it?","created_at":"2016-11-16T12:36:15Z","updated_at":"2016-11-16T12:36:20Z","html_url":"https://github.com/apache/falcon/pull/298#discussion_r88227498","pull_request_url":"https://api.github.com/repos/apache/falcon/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments/88227498"},"html":{"href":"https://github.com/apache/falcon/pull/298#discussion_r88227498"},"pull_request":{"href":"https://api.github.com/repos/apache/falcon/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/apache/falcon/pulls/298","id":93718900,"html_url":"https://github.com/apache/falcon/pull/298","diff_url":"https://github.com/apache/falcon/pull/298.diff","patch_url":"https://github.com/apache/falcon/pull/298.patch","issue_url":"https://api.github.com/repos/apache/falcon/issues/298","number":298,"state":"open","locked":false,"title":"FALCON-2183 Extension Builder changes to support new user extensions","user":{"login":"sandeepSamudrala","id":2361058,"avatar_url":"https://avatars.githubusercontent.com/u/2361058?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepSamudrala","html_url":"https://github.com/sandeepSamudrala","followers_url":"https://api.github.com/users/sandeepSamudrala/followers","following_url":"https://api.github.com/users/sandeepSamudrala/following{/other_user}","gists_url":"https://api.github.com/users/sandeepSamudrala/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepSamudrala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepSamudrala/subscriptions","organizations_url":"https://api.github.com/users/sandeepSamudrala/orgs","repos_url":"https://api.github.com/users/sandeepSamudrala/repos","events_url":"https://api.github.com/users/sandeepSamudrala/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepSamudrala/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-15T08:14:30Z","updated_at":"2016-11-16T12:36:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c1a879db02221a6fd706616b8d6663f55dae722","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/falcon/pulls/298/commits","review_comments_url":"https://api.github.com/repos/apache/falcon/pulls/298/comments","review_comment_url":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/falcon/issues/298/comments","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/f3d7268e43ada567a87f8cfa02c29b5d3bc2c30f","head":{"label":"sandeepSamudrala:FALCON-2183","ref":"FALCON-2183","sha":"f3d7268e43ada567a87f8cfa02c29b5d3bc2c30f","user":{"login":"sandeepSamudrala","id":2361058,"avatar_url":"https://avatars.githubusercontent.com/u/2361058?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepSamudrala","html_url":"https://github.com/sandeepSamudrala","followers_url":"https://api.github.com/users/sandeepSamudrala/followers","following_url":"https://api.github.com/users/sandeepSamudrala/following{/other_user}","gists_url":"https://api.github.com/users/sandeepSamudrala/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepSamudrala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepSamudrala/subscriptions","organizations_url":"https://api.github.com/users/sandeepSamudrala/orgs","repos_url":"https://api.github.com/users/sandeepSamudrala/repos","events_url":"https://api.github.com/users/sandeepSamudrala/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepSamudrala/received_events","type":"User","site_admin":false},"repo":{"id":61639597,"name":"falcon","full_name":"sandeepSamudrala/falcon","owner":{"login":"sandeepSamudrala","id":2361058,"avatar_url":"https://avatars.githubusercontent.com/u/2361058?v=3","gravatar_id":"","url":"https://api.github.com/users/sandeepSamudrala","html_url":"https://github.com/sandeepSamudrala","followers_url":"https://api.github.com/users/sandeepSamudrala/followers","following_url":"https://api.github.com/users/sandeepSamudrala/following{/other_user}","gists_url":"https://api.github.com/users/sandeepSamudrala/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepSamudrala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepSamudrala/subscriptions","organizations_url":"https://api.github.com/users/sandeepSamudrala/orgs","repos_url":"https://api.github.com/users/sandeepSamudrala/repos","events_url":"https://api.github.com/users/sandeepSamudrala/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepSamudrala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sandeepSamudrala/falcon","description":"Mirror of Apache Falcon","fork":true,"url":"https://api.github.com/repos/sandeepSamudrala/falcon","forks_url":"https://api.github.com/repos/sandeepSamudrala/falcon/forks","keys_url":"https://api.github.com/repos/sandeepSamudrala/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sandeepSamudrala/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sandeepSamudrala/falcon/teams","hooks_url":"https://api.github.com/repos/sandeepSamudrala/falcon/hooks","issue_events_url":"https://api.github.com/repos/sandeepSamudrala/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/sandeepSamudrala/falcon/events","assignees_url":"https://api.github.com/repos/sandeepSamudrala/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/sandeepSamudrala/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/sandeepSamudrala/falcon/tags","blobs_url":"https://api.github.com/repos/sandeepSamudrala/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sandeepSamudrala/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sandeepSamudrala/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sandeepSamudrala/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sandeepSamudrala/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/sandeepSamudrala/falcon/languages","stargazers_url":"https://api.github.com/repos/sandeepSamudrala/falcon/stargazers","contributors_url":"https://api.github.com/repos/sandeepSamudrala/falcon/contributors","subscribers_url":"https://api.github.com/repos/sandeepSamudrala/falcon/subscribers","subscription_url":"https://api.github.com/repos/sandeepSamudrala/falcon/subscription","commits_url":"https://api.github.com/repos/sandeepSamudrala/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sandeepSamudrala/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sandeepSamudrala/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sandeepSamudrala/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sandeepSamudrala/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/sandeepSamudrala/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sandeepSamudrala/falcon/merges","archive_url":"https://api.github.com/repos/sandeepSamudrala/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sandeepSamudrala/falcon/downloads","issues_url":"https://api.github.com/repos/sandeepSamudrala/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/sandeepSamudrala/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/sandeepSamudrala/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/sandeepSamudrala/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sandeepSamudrala/falcon/labels{/name}","releases_url":"https://api.github.com/repos/sandeepSamudrala/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/sandeepSamudrala/falcon/deployments","created_at":"2016-06-21T14:17:25Z","updated_at":"2016-06-21T14:17:30Z","pushed_at":"2016-11-16T12:00:41Z","git_url":"git://github.com/sandeepSamudrala/falcon.git","ssh_url":"git@github.com:sandeepSamudrala/falcon.git","clone_url":"https://github.com/sandeepSamudrala/falcon.git","svn_url":"https://github.com/sandeepSamudrala/falcon","homepage":null,"size":30658,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c980aa800afdcf38fcdafe004586abb3bafd4732","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":11543457,"name":"falcon","full_name":"apache/falcon","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/falcon","description":"Mirror of Apache Falcon","fork":false,"url":"https://api.github.com/repos/apache/falcon","forks_url":"https://api.github.com/repos/apache/falcon/forks","keys_url":"https://api.github.com/repos/apache/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/falcon/teams","hooks_url":"https://api.github.com/repos/apache/falcon/hooks","issue_events_url":"https://api.github.com/repos/apache/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/apache/falcon/events","assignees_url":"https://api.github.com/repos/apache/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/apache/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/apache/falcon/tags","blobs_url":"https://api.github.com/repos/apache/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/falcon/languages","stargazers_url":"https://api.github.com/repos/apache/falcon/stargazers","contributors_url":"https://api.github.com/repos/apache/falcon/contributors","subscribers_url":"https://api.github.com/repos/apache/falcon/subscribers","subscription_url":"https://api.github.com/repos/apache/falcon/subscription","commits_url":"https://api.github.com/repos/apache/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/apache/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/falcon/merges","archive_url":"https://api.github.com/repos/apache/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/falcon/downloads","issues_url":"https://api.github.com/repos/apache/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/apache/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/falcon/labels{/name}","releases_url":"https://api.github.com/repos/apache/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/apache/falcon/deployments","created_at":"2013-07-20T07:00:14Z","updated_at":"2016-11-10T14:30:33Z","pushed_at":"2016-11-15T12:07:27Z","git_url":"git://github.com/apache/falcon.git","ssh_url":"git@github.com:apache/falcon.git","clone_url":"https://github.com/apache/falcon.git","svn_url":"https://github.com/apache/falcon","homepage":null,"size":33484,"stargazers_count":61,"watchers_count":61,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":"git://git.apache.org/falcon.git","open_issues_count":13,"forks":86,"open_issues":13,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/falcon/pulls/298"},"html":{"href":"https://github.com/apache/falcon/pull/298"},"issue":{"href":"https://api.github.com/repos/apache/falcon/issues/298"},"comments":{"href":"https://api.github.com/repos/apache/falcon/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/falcon/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/falcon/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/apache/falcon/statuses/f3d7268e43ada567a87f8cfa02c29b5d3bc2c30f"}}}}
{"actor":{"display_login":"pallavi-rao"}}