{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/66239743","id":66239743,"diff_hunk":"@@ -72,7 +73,9 @@ func (p *Processor) Process(template *api.Template) field.ErrorList {\n func stripNamespace(obj runtime.Object) {\n \t// Remove namespace from the item\n \tif itemMeta, err := meta.Accessor(obj); err == nil {","path":"pkg/template/template.go","position":null,"original_position":13,"commit_id":"9e096299b57ed0d8fc5a65cf45eb464379ed16c9","original_commit_id":"23c16e37f9248ba8d197f63deb09fb550b76d087","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Actually what's the problem here? We want to strip the namespace so `itemMeta.SetNamespace(\"\")` should be fine to run always, no?","created_at":"2016-06-08T11:40:35Z","updated_at":"2016-06-08T11:40:35Z","html_url":"https://github.com/openshift/origin/pull/8856#discussion_r66239743","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/8856","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/66239743"},"html":{"href":"https://github.com/openshift/origin/pull/8856#discussion_r66239743"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8856","id":69815590,"html_url":"https://github.com/openshift/origin/pull/8856","diff_url":"https://github.com/openshift/origin/pull/8856.diff","patch_url":"https://github.com/openshift/origin/pull/8856.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/8856","number":8856,"state":"open","locked":false,"title":"[WIP] Rebase","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"Kubernetes fork PR: https://github.com/openshift/kubernetes/pull/19\r\nRemaining work for this PR:\r\n\r\n- [x] Fix `Godeps/Godeps.json` (must be generated for **each** UPSTREAM commit)\r\n- [x] If we have https://github.com/kubernetes/kubernetes/pull/23795, we picked up a couple important bugs https://github.com/kubernetes/kubernetes/pull/25671 and https://github.com/kubernetes/kubernetes/pull/25669\r\n- [x] pick https://github.com/kubernetes/kubernetes/pull/21373\r\n- [x] The `update-generated-conversions` script is broken\r\n- [x] Fix compilation\r\n- [x] Fix broken template unit test (`pkg/template`)\r\n- [x] Fix integration: `sa_oauthclient_test.go:165: unexpected error: Missing configuration`\r\n- [x] Fix integration: `storage_versions_test.go:117: batch: expected api version extensions/v1beta1 in etcd, got batch/v1, Kind=Job reading Job`\r\n- [x] Fix E2E tests\r\n- [x] Fix https://github.com/coreos/etcd/issues/5558\r\n- [ ] The `RateLimiter` needs a fuzzer in master config test\r\n\r\nFixes: https://github.com/openshift/origin/issues/4398\r\n\r\nFollow ups / good to know:\r\n\r\n- The new `generic.Decorator{}` now takes the `cacheSize` argument. I hardcoded it to `100` but this should be configurable from the master config (or we should at least have map with resources and set the numbers there, in one place)\r\n- There was `cacheSize` introduced in various places (grep for 'cacheSize'), there should be an issue opened to track them\r\n- The `iptables.NewProxier()` now takes extra `c.ClusterCIDR` argument. This should be configurable as well (current set to empty string which means no off-cluster bridging will be performed) \r\n- Kubernetes is now using https://github.com/docker/engine-api instead of https://github.com/fsouza/go-dockerclient and they of course have incompatible interfaces. I created a simple wrapper for the engine-api client: https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-f2e698c988010fe8fd27effa4c84a80eR41 but we should consider switching to engine-api client as well.\r\n- If we have https://github.com/kubernetes/kubernetes/pull/23795, we picked up a couple important bugs https://github.com/kubernetes/kubernetes/pull/25671 and https://github.com/kubernetes/kubernetes/pull/25669 .\r\n- Follow up with updating `ktestclient.Action` to `core.Action` to reflect upstream changes\r\n- Follow up on migrating go-dockerclient to engine-api (need to disable newapp integration test)\r\n\r\nAs @smarterclayton noted, this rebase might require go-1.6, but I can see this builds fine on 1.5 as well.\r\n\r\nImportant changes that should be reviewed:\r\n\r\n- [x] https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-05523003a782d7b3b61c2608a29dfb39R228 (as the StorageDestination is no more)\r\n- [x] https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-90ac63ed95fc5a187e3347f9cded16cbR84 (and friends... what happened is that kube now use `credentialprovider.LazyAuthConfiguration` which is not compatible with `docker.AuthConfiguration`. I will add some nicer wrapper for these.\r\n- [ ] https://github.com/openshift/origin/pull/8856/commits/06396fd50e7c5dc3ffbb6afae7ee899c89a95b08#diff-adefa6892d6212c6873413c96b805bb3R258 as I don't really know how much important is this method for SDN","created_at":"2016-05-12T10:48:00Z","updated_at":"2016-06-08T11:40:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"777bfb20f4094ac3706a1256ae766dd676244994","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/8856/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/8856/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8856/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/9e096299b57ed0d8fc5a65cf45eb464379ed16c9","head":{"label":"mfojtik:rebase","ref":"rebase","sha":"9e096299b57ed0d8fc5a65cf45eb464379ed16c9","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22954249,"name":"origin","full_name":"mfojtik/origin","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/mfojtik/origin","forks_url":"https://api.github.com/repos/mfojtik/origin/forks","keys_url":"https://api.github.com/repos/mfojtik/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/origin/teams","hooks_url":"https://api.github.com/repos/mfojtik/origin/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/origin/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/origin/events","assignees_url":"https://api.github.com/repos/mfojtik/origin/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/origin/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/origin/tags","blobs_url":"https://api.github.com/repos/mfojtik/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/origin/languages","stargazers_url":"https://api.github.com/repos/mfojtik/origin/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/origin/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/origin/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/origin/subscription","commits_url":"https://api.github.com/repos/mfojtik/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/origin/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/origin/merges","archive_url":"https://api.github.com/repos/mfojtik/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/origin/downloads","issues_url":"https://api.github.com/repos/mfojtik/origin/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/origin/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/origin/releases{/id}","deployments_url":"https://api.github.com/repos/mfojtik/origin/deployments","created_at":"2014-08-14T13:11:47Z","updated_at":"2016-01-12T09:38:06Z","pushed_at":"2016-06-07T19:28:20Z","git_url":"git://github.com/mfojtik/origin.git","ssh_url":"git@github.com:mfojtik/origin.git","clone_url":"https://github.com/mfojtik/origin.git","svn_url":"https://github.com/mfojtik/origin","homepage":"https://openshift.github.io","size":266811,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"f6fd6e9b932e4656274ef7bab7448cc62b185408","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-06-08T10:39:52Z","pushed_at":"2016-06-08T11:29:46Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":508995,"stargazers_count":1349,"watchers_count":1349,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":814,"mirror_url":null,"open_issues_count":1054,"forks":814,"open_issues":1054,"watchers":1349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856"},"html":{"href":"https://github.com/openshift/origin/pull/8856"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/8856"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/8856/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/8856/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/9e096299b57ed0d8fc5a65cf45eb464379ed16c9"}}}}
{"actor":{"display_login":"kargakis"}}