{"action":"created","comment":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments/52294869","id":52294869,"diff_hunk":"@@ -133,10 +132,14 @@ gmf.Themes.prototype.getBgLayers = function() {\n             return this.layerHelper_.createWMTSLayerFromCapabilitites(\n                 item['url'],\n                 item['name']\n-            ).then(goog.bind(callback, this, item));\n+            ).then(goog.bind(callback, this, item)).then(null, function(error) {","path":"contribs/gmf/src/services/themesservice.js","position":26,"original_position":26,"commit_id":"5856b1eac3003404966564b3cdac4ee4daf8cd2f","original_commit_id":"5856b1eac3003404966564b3cdac4ee4daf8cd2f","user":{"login":"fgravin","id":1491924,"avatar_url":"https://avatars.githubusercontent.com/u/1491924?v=3","gravatar_id":"","url":"https://api.github.com/users/fgravin","html_url":"https://github.com/fgravin","followers_url":"https://api.github.com/users/fgravin/followers","following_url":"https://api.github.com/users/fgravin/following{/other_user}","gists_url":"https://api.github.com/users/fgravin/gists{/gist_id}","starred_url":"https://api.github.com/users/fgravin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgravin/subscriptions","organizations_url":"https://api.github.com/users/fgravin/orgs","repos_url":"https://api.github.com/users/fgravin/repos","events_url":"https://api.github.com/users/fgravin/events{/privacy}","received_events_url":"https://api.github.com/users/fgravin/received_events","type":"User","site_admin":false},"body":"use promise `.catch()` method instead.","created_at":"2016-02-09T11:17:42Z","updated_at":"2016-02-09T11:17:42Z","html_url":"https://github.com/camptocamp/ngeo/pull/587#discussion_r52294869","pull_request_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/587","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments/52294869"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/587#discussion_r52294869"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/587"}}},"pull_request":{"url":"https://api.github.com/repos/camptocamp/ngeo/pulls/587","id":58163642,"html_url":"https://github.com/camptocamp/ngeo/pull/587","diff_url":"https://github.com/camptocamp/ngeo/pull/587.diff","patch_url":"https://github.com/camptocamp/ngeo/pull/587.patch","issue_url":"https://api.github.com/repos/camptocamp/ngeo/issues/587","number":587,"state":"closed","locked":false,"title":"Rework ngeo.LayerHelper promise handling","user":{"login":"gberaudo","id":7294662,"avatar_url":"https://avatars.githubusercontent.com/u/7294662?v=3","gravatar_id":"","url":"https://api.github.com/users/gberaudo","html_url":"https://github.com/gberaudo","followers_url":"https://api.github.com/users/gberaudo/followers","following_url":"https://api.github.com/users/gberaudo/following{/other_user}","gists_url":"https://api.github.com/users/gberaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/gberaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberaudo/subscriptions","organizations_url":"https://api.github.com/users/gberaudo/orgs","repos_url":"https://api.github.com/users/gberaudo/repos","events_url":"https://api.github.com/users/gberaudo/events{/privacy}","received_events_url":"https://api.github.com/users/gberaudo/received_events","type":"User","site_admin":false},"body":"Do not use defer.\r\nReject failed promises.","created_at":"2016-02-03T16:37:49Z","updated_at":"2016-02-09T11:17:42Z","closed_at":"2016-02-04T09:31:48Z","merged_at":"2016-02-04T09:31:48Z","merge_commit_sha":"05b1b905d7bb94cefd514aae14b1e05faf33c665","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/587/commits","review_comments_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/587/comments","review_comment_url":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/issues/587/comments","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/5856b1eac3003404966564b3cdac4ee4daf8cd2f","head":{"label":"gberaudo:use_reject","ref":"use_reject","sha":"5856b1eac3003404966564b3cdac4ee4daf8cd2f","user":{"login":"gberaudo","id":7294662,"avatar_url":"https://avatars.githubusercontent.com/u/7294662?v=3","gravatar_id":"","url":"https://api.github.com/users/gberaudo","html_url":"https://github.com/gberaudo","followers_url":"https://api.github.com/users/gberaudo/followers","following_url":"https://api.github.com/users/gberaudo/following{/other_user}","gists_url":"https://api.github.com/users/gberaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/gberaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberaudo/subscriptions","organizations_url":"https://api.github.com/users/gberaudo/orgs","repos_url":"https://api.github.com/users/gberaudo/repos","events_url":"https://api.github.com/users/gberaudo/events{/privacy}","received_events_url":"https://api.github.com/users/gberaudo/received_events","type":"User","site_admin":false},"repo":{"id":31598754,"name":"ngeo","full_name":"gberaudo/ngeo","owner":{"login":"gberaudo","id":7294662,"avatar_url":"https://avatars.githubusercontent.com/u/7294662?v=3","gravatar_id":"","url":"https://api.github.com/users/gberaudo","html_url":"https://github.com/gberaudo","followers_url":"https://api.github.com/users/gberaudo/followers","following_url":"https://api.github.com/users/gberaudo/following{/other_user}","gists_url":"https://api.github.com/users/gberaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/gberaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gberaudo/subscriptions","organizations_url":"https://api.github.com/users/gberaudo/orgs","repos_url":"https://api.github.com/users/gberaudo/repos","events_url":"https://api.github.com/users/gberaudo/events{/privacy}","received_events_url":"https://api.github.com/users/gberaudo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gberaudo/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":true,"url":"https://api.github.com/repos/gberaudo/ngeo","forks_url":"https://api.github.com/repos/gberaudo/ngeo/forks","keys_url":"https://api.github.com/repos/gberaudo/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gberaudo/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gberaudo/ngeo/teams","hooks_url":"https://api.github.com/repos/gberaudo/ngeo/hooks","issue_events_url":"https://api.github.com/repos/gberaudo/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/gberaudo/ngeo/events","assignees_url":"https://api.github.com/repos/gberaudo/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/gberaudo/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/gberaudo/ngeo/tags","blobs_url":"https://api.github.com/repos/gberaudo/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gberaudo/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gberaudo/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gberaudo/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gberaudo/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/gberaudo/ngeo/languages","stargazers_url":"https://api.github.com/repos/gberaudo/ngeo/stargazers","contributors_url":"https://api.github.com/repos/gberaudo/ngeo/contributors","subscribers_url":"https://api.github.com/repos/gberaudo/ngeo/subscribers","subscription_url":"https://api.github.com/repos/gberaudo/ngeo/subscription","commits_url":"https://api.github.com/repos/gberaudo/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gberaudo/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gberaudo/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gberaudo/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gberaudo/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/gberaudo/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gberaudo/ngeo/merges","archive_url":"https://api.github.com/repos/gberaudo/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gberaudo/ngeo/downloads","issues_url":"https://api.github.com/repos/gberaudo/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/gberaudo/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/gberaudo/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/gberaudo/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gberaudo/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/gberaudo/ngeo/releases{/id}","deployments_url":"https://api.github.com/repos/gberaudo/ngeo/deployments","created_at":"2015-03-03T13:06:04Z","updated_at":"2015-03-16T14:29:49Z","pushed_at":"2016-02-04T09:31:52Z","git_url":"git://github.com/gberaudo/ngeo.git","ssh_url":"git@github.com:gberaudo/ngeo.git","clone_url":"https://github.com/gberaudo/ngeo.git","svn_url":"https://github.com/gberaudo/ngeo","homepage":null,"size":3591,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"camptocamp:master","ref":"master","sha":"ae051f3c812ebf93e80b2896a8e8ec6439b75cc2","user":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"repo":{"id":20212761,"name":"ngeo","full_name":"camptocamp/ngeo","owner":{"login":"camptocamp","id":28109,"avatar_url":"https://avatars.githubusercontent.com/u/28109?v=3","gravatar_id":"","url":"https://api.github.com/users/camptocamp","html_url":"https://github.com/camptocamp","followers_url":"https://api.github.com/users/camptocamp/followers","following_url":"https://api.github.com/users/camptocamp/following{/other_user}","gists_url":"https://api.github.com/users/camptocamp/gists{/gist_id}","starred_url":"https://api.github.com/users/camptocamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camptocamp/subscriptions","organizations_url":"https://api.github.com/users/camptocamp/orgs","repos_url":"https://api.github.com/users/camptocamp/repos","events_url":"https://api.github.com/users/camptocamp/events{/privacy}","received_events_url":"https://api.github.com/users/camptocamp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/camptocamp/ngeo","description":"Library combining OpenLayers 3 and AngularJS","fork":false,"url":"https://api.github.com/repos/camptocamp/ngeo","forks_url":"https://api.github.com/repos/camptocamp/ngeo/forks","keys_url":"https://api.github.com/repos/camptocamp/ngeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/camptocamp/ngeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/camptocamp/ngeo/teams","hooks_url":"https://api.github.com/repos/camptocamp/ngeo/hooks","issue_events_url":"https://api.github.com/repos/camptocamp/ngeo/issues/events{/number}","events_url":"https://api.github.com/repos/camptocamp/ngeo/events","assignees_url":"https://api.github.com/repos/camptocamp/ngeo/assignees{/user}","branches_url":"https://api.github.com/repos/camptocamp/ngeo/branches{/branch}","tags_url":"https://api.github.com/repos/camptocamp/ngeo/tags","blobs_url":"https://api.github.com/repos/camptocamp/ngeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/camptocamp/ngeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/camptocamp/ngeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/camptocamp/ngeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/camptocamp/ngeo/statuses/{sha}","languages_url":"https://api.github.com/repos/camptocamp/ngeo/languages","stargazers_url":"https://api.github.com/repos/camptocamp/ngeo/stargazers","contributors_url":"https://api.github.com/repos/camptocamp/ngeo/contributors","subscribers_url":"https://api.github.com/repos/camptocamp/ngeo/subscribers","subscription_url":"https://api.github.com/repos/camptocamp/ngeo/subscription","commits_url":"https://api.github.com/repos/camptocamp/ngeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/camptocamp/ngeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/camptocamp/ngeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/camptocamp/ngeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/camptocamp/ngeo/contents/{+path}","compare_url":"https://api.github.com/repos/camptocamp/ngeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/camptocamp/ngeo/merges","archive_url":"https://api.github.com/repos/camptocamp/ngeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/camptocamp/ngeo/downloads","issues_url":"https://api.github.com/repos/camptocamp/ngeo/issues{/number}","pulls_url":"https://api.github.com/repos/camptocamp/ngeo/pulls{/number}","milestones_url":"https://api.github.com/repos/camptocamp/ngeo/milestones{/number}","notifications_url":"https://api.github.com/repos/camptocamp/ngeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/camptocamp/ngeo/labels{/name}","releases_url":"https://api.github.com/repos/camptocamp/ngeo/releases{/id}","deployments_url":"https://api.github.com/repos/camptocamp/ngeo/deployments","created_at":"2014-05-27T08:34:54Z","updated_at":"2016-02-05T22:18:47Z","pushed_at":"2016-02-09T11:01:52Z","git_url":"git://github.com/camptocamp/ngeo.git","ssh_url":"git@github.com:camptocamp/ngeo.git","clone_url":"https://github.com/camptocamp/ngeo.git","svn_url":"https://github.com/camptocamp/ngeo","homepage":null,"size":49691,"stargazers_count":59,"watchers_count":59,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"open_issues_count":53,"forks":36,"open_issues":53,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/587"},"html":{"href":"https://github.com/camptocamp/ngeo/pull/587"},"issue":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/587"},"comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/issues/587/comments"},"review_comments":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/587/comments"},"review_comment":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/camptocamp/ngeo/pulls/587/commits"},"statuses":{"href":"https://api.github.com/repos/camptocamp/ngeo/statuses/5856b1eac3003404966564b3cdac4ee4daf8cd2f"}}}}