{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/78402602","id":78402602,"diff_hunk":"@@ -0,0 +1,60 @@\n+@import \"../variables/mixins\";\n+@import \"../variables/colors\";\n+@import \"../variables/sizes\";\n+\n+.List {\n+  @include display-flex();\n+  @include flex-direction(column);\n+  font: normal 13px/20px \"Lato\",sans-serif;\n+}\n+.List.List--selections {\n+  margin-bottom: $sMargin-elementInline;\n+  border: 1px solid $cStructure-mainLine;\n+  border-radius: $sCard-borderRadius;\n+  background-color: $cStructure-mainBkg;\n+}\n+.List-row {\n+  @include display-flex();\n+  @include justify-content(space-between, justify);\n+  @include align-items(center);\n+  // Makes sure prev border is overlapped but the is-selected one\n+  position: relative;\n+  margin-top: -2px;\n+  border: 1px solid transparent;\n+  box-sizing: content-box; // to make sure size is consistent w/ borders\n+}\n+.List-row.is-selected {\n+  border: 1px solid $cCard-selectedBorder;\n+  border-radius: $sCard-borderRadius;\n+  background-color: $cCard-selectedFill;\n+}\n+.List-row.List-row.is-disabled {\n+  opacity: 0.4;\n+}\n+.List-row:last-child > .List-rowItem {\n+  // to have same height as the other items, w/o the visible border\n+  border-bottom: 1px solid transparent\n+}\n+.List-rowItem {\n+  @include display-flex();\n+  @include justify-content(space-between, justify);\n+  @include align-items(center);\n+  box-sizing: content-box; // to make sure size is consistent w/ borders\n+  margin-left: $sMargin-element;\n+  margin-right: $sMargin-element;\n+  padding-top: $sMargin-group;\n+  padding-bottom: $sMargin-group;\n+  width: 100%;\n+  border-bottom: 1px solid $cStructure-mainLine;\n+}\n+.List-rowItem.List-rowItem--compact {\n+  padding-top: $sMargin-elementInline;\n+  padding-bottom: $sMargin-elementInline;\n+}\n+.List-rowItem.List-rowItem--withoutSideMargins {\n+  margin-right: 0;\n+  margin-left: 0;\n+}\n+.List-rowItem.List-rowItem--withoutBottomBorder { border-bottom: 0 }\n+.List-rowItem.List-rowItem--withoutBottomPadding { padding-bottom: 0 }","path":"app/assets/stylesheets/editor-3/list.css.scss","position":59,"original_position":59,"commit_id":"b3bacb4487db812f07dd0bdc5ac1a9737e731320","original_commit_id":"b3bacb4487db812f07dd0bdc5ac1a9737e731320","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Declaration should be terminated by a semicolon<br>Property 'padding-bottom' should be placed on separate line from selector","created_at":"2016-09-12T16:09:31Z","updated_at":"2016-09-12T16:09:31Z","html_url":"https://github.com/CartoDB/cartodb/pull/9740#discussion_r78402602","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/78402602"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/9740#discussion_r78402602"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740","id":84898840,"html_url":"https://github.com/CartoDB/cartodb/pull/9740","diff_url":"https://github.com/CartoDB/cartodb/pull/9740.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/9740.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9740","number":9740,"state":"open","locked":false,"title":"add wms tab to add basemaps modals ","user":{"login":"matallo","id":36676,"avatar_url":"https://avatars.githubusercontent.com/u/36676?v=3","gravatar_id":"","url":"https://api.github.com/users/matallo","html_url":"https://github.com/matallo","followers_url":"https://api.github.com/users/matallo/followers","following_url":"https://api.github.com/users/matallo/following{/other_user}","gists_url":"https://api.github.com/users/matallo/gists{/gist_id}","starred_url":"https://api.github.com/users/matallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matallo/subscriptions","organizations_url":"https://api.github.com/users/matallo/orgs","repos_url":"https://api.github.com/users/matallo/repos","events_url":"https://api.github.com/users/matallo/events{/privacy}","received_events_url":"https://api.github.com/users/matallo/received_events","type":"User","site_admin":false},"body":"- feature and tests migrated from old editor, discussed with @xavijam about a better approach but disappointingly won't make the change at this point.\r\n- also I feel uneasy about wms service model in the tests, but had to make it like that in order to make the pass. Struggled for quite some time about this, so any suggestion or discussion willbe welcome.\r\n- tracking events will come in a separate PR https://github.com/CartoDB/cartodb/commit/461448540b4b9673c8de4c099e1b30cc3e622154\r\n\r\nfind a gif with the functionality below\r\n\r\n![wmsbasemaps](https://cloud.githubusercontent.com/assets/36676/18442912/d9dc6ce6-7912-11e6-937c-e7b6387db46c.gif)\r\n\r\n\r\nCR @alonsogarciapablo /cc @xavijam \r\n\r\nps: sorry about the >20 files PR","created_at":"2016-09-12T16:06:07Z","updated_at":"2016-09-12T16:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9aff4fb61aea9c59db788795d77fc32717ea889","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9740/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/b3bacb4487db812f07dd0bdc5ac1a9737e731320","head":{"label":"CartoDB:9198-basemaps-wms","ref":"9198-basemaps-wms","sha":"b3bacb4487db812f07dd0bdc5ac1a9737e731320","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2016-09-12T08:38:43Z","pushed_at":"2016-09-12T16:09:23Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":400252,"stargazers_count":1260,"watchers_count":1260,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":1076,"forks":323,"open_issues":1076,"watchers":1260,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"5846987c7a1c2ca43c1fa3ff818a36c26bd7489e","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2016-09-12T08:38:43Z","pushed_at":"2016-09-12T16:09:23Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":400252,"stargazers_count":1260,"watchers_count":1260,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":1076,"forks":323,"open_issues":1076,"watchers":1260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/9740"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/9740"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/9740/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/9740/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/b3bacb4487db812f07dd0bdc5ac1a9737e731320"}}}}
{"actor":{"display_login":"houndci-bot"}}