{"action":"opened","issue":{"url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6574","repository_url":"https://api.github.com/repos/OrchardCMS/Orchard","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6574/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6574/comments","events_url":"https://api.github.com/repos/OrchardCMS/Orchard/issues/6574/events","html_url":"https://github.com/OrchardCMS/Orchard/issues/6574","id":140181623,"number":6574,"title":"Potential danger of deadlock in DatabaseOutputCacheStorageProvider","user":{"login":"Piedone","id":1976647,"avatar_url":"https://avatars.githubusercontent.com/u/1976647?v=3","gravatar_id":"","url":"https://api.github.com/users/Piedone","html_url":"https://github.com/Piedone","followers_url":"https://api.github.com/users/Piedone/followers","following_url":"https://api.github.com/users/Piedone/following{/other_user}","gists_url":"https://api.github.com/users/Piedone/gists{/gist_id}","starred_url":"https://api.github.com/users/Piedone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Piedone/subscriptions","organizations_url":"https://api.github.com/users/Piedone/orgs","repos_url":"https://api.github.com/users/Piedone/repos","events_url":"https://api.github.com/users/Piedone/events{/privacy}","received_events_url":"https://api.github.com/users/Piedone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-11T13:22:14Z","updated_at":"2016-03-11T13:22:14Z","closed_at":null,"body":"The class uses an interned string as a way of having named locks. This is however prone to complex errors, see: http://stackoverflow.com/questions/6983714/locking-on-an-interned-string\r\n\r\nInstead such locking can be implemented with the service used here: https://github.com/OrchardCMS/Orchard/blob/issue/20740/src/Orchard/Utility/NamedReaderWriterLock.cs Or even better by using `IDistributedLockService`.\r\n\r\nBut on a second though I wonder why there is a need for locking here at all?\r\n\r\nCc @sebastienros as the author."}}