{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/100","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/100/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/100/events","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/issues/100","id":126322120,"number":100,"title":"Don't rely on heavy tests for simple things","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-13T01:59:43Z","updated_at":"2016-01-13T04:06:43Z","closed_at":null,"body":"I don't think that we need rabbit to do normal tests. Ex. the \"integration\" profile is quite heavy as it relies on docker and take a long time to start and is annoying to debug as the console log is cluttered with all sorts of stuff. Moreover, the kind of problems caught are often just minor code issues. These should be caught in a way that run normally.\r\n\r\nFor example, property tests around input spans being received by http endpoint shouldn't in any way need to engage rabbit to assert. Ex. http 400 comes way before any of that matters.\r\n\r\nLong story short, is lets try to keep our normal path tested without heavy dependencies such as rabbit or docker. I'd be surprised if spring-cloud-stream has no in-memory alternative, for example.\r\n\r\nLet's only use docker as a last resort as debugging it makes for a very poor experience in troubleshooting, even if easier and faster than the brewery tests."},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments/171158265","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/issues/100#issuecomment-171158265","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/100","id":171158265,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T04:06:43Z","updated_at":"2016-01-13T04:06:43Z","body":"PS let's remember zipkin-java-server is a boot/mvc app. Even if test runners don't support multiple containers (like arquillian does), it may be possible to just host the query api in a test server. That could lead to a quite fast path for debugging issues like span properties being null and dropped accordingly."}}