{"action":"created","issue":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1530","repository_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1530/labels{/name}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1530/comments","events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1530/events","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1530","id":188882300,"number":1530,"title":"Valid times on map","user":{"login":"marbink","id":5592897,"avatar_url":"https://avatars.githubusercontent.com/u/5592897?v=3","gravatar_id":"","url":"https://api.github.com/users/marbink","html_url":"https://github.com/marbink","followers_url":"https://api.github.com/users/marbink/followers","following_url":"https://api.github.com/users/marbink/following{/other_user}","gists_url":"https://api.github.com/users/marbink/gists{/gist_id}","starred_url":"https://api.github.com/users/marbink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marbink/subscriptions","organizations_url":"https://api.github.com/users/marbink/orgs","repos_url":"https://api.github.com/users/marbink/repos","events_url":"https://api.github.com/users/marbink/events{/privacy}","received_events_url":"https://api.github.com/users/marbink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":90,"created_at":"2016-11-12T01:07:35Z","updated_at":"2016-11-20T08:55:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/1530","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1530","diff_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1530.diff","patch_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1530.patch"},"body":"## Description\r\nAdded algorithm to get monsters disappear time from previous scans results.\r\nOn the frontend inside the popup you will see clearly when the time has been set by prediction, when it has been set by scanner at 15min and when it has been set by server response.\r\n\r\n**[Update - 13nov2016]** When scanner gets a 'safe' time from the server, it will replace any old disappear_time for the same spawnpoint (if any). This should auto-fix prediction after some changes in spawnpoints in the game.\r\n\r\n**Note**: When spawnpoint changes, it may show wrong data for a while. To avoid this, making past data in database not usable by prediction algorithm start once runserver.py with this parameter \"-ctd\" or its extended form \"--clean-timers-data\". After this any new 'safe' data got from the server will be used to predict new times.\r\n\r\n## Motivation and Context\r\nTo give an idea to users when a monster will disappear.\r\n\r\n## How Has This Been Tested?\r\nOn my map with about 100 users. Tested for 5 days it works flawlessy without any crash and timers revealed correct in any case.\r\n\r\n## Screenshots (updated):\r\n![img](https://cloud.githubusercontent.com/assets/5592897/20246458/6a60ff50-a9b7-11e6-9d90-b4e3ef946cff.png)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n<!--  NOTE: In order to check code style locally and avoid having your build rejected by Travis, -->\r\n<!--  run the following commands before you commit: `flake8 .` and `npm run lint`. Fix any -->\r\n<!--  issues they point out. Note also that flake's NOQA is disabled on Travis. -->\r\n- [ ] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n"},"comment":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/comments/261766572","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/1530#issuecomment-261766572","issue_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/1530","id":261766572,"user":{"login":"marbink","id":5592897,"avatar_url":"https://avatars.githubusercontent.com/u/5592897?v=3","gravatar_id":"","url":"https://api.github.com/users/marbink","html_url":"https://github.com/marbink","followers_url":"https://api.github.com/users/marbink/followers","following_url":"https://api.github.com/users/marbink/following{/other_user}","gists_url":"https://api.github.com/users/marbink/gists{/gist_id}","starred_url":"https://api.github.com/users/marbink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marbink/subscriptions","organizations_url":"https://api.github.com/users/marbink/orgs","repos_url":"https://api.github.com/users/marbink/repos","events_url":"https://api.github.com/users/marbink/events{/privacy}","received_events_url":"https://api.github.com/users/marbink/received_events","type":"User","site_admin":false},"created_at":"2016-11-20T08:55:27Z","updated_at":"2016-11-20T08:55:27Z","body":"@weizh888 This is what I wrote some comments ago.\r\n\r\n> Reading the 'safe' label is difficult. It is shown only when the server\r\n> send the real disapper_time. It is < 90 seconds so you have to be lucky\r\n> that the scanner catch it in the last 90seconds of monster life.\r\n\r\nAfter some scans, 'predicted' message will be the most frequent."}}
{"actor":{"display_login":"marbink"}}