{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/76451076","id":76451076,"diff_hunk":"@@ -128,20 +128,23 @@ class ArticleController extends Controller with RendersItemResponse with Logging\n       renderFormat(htmlResponse, jsonResponse, article, Switches.all)\n   }\n \n-  def renderLiveBlog(path: String, page: Option[String] = None) =\n-    Action.async { implicit request =>\n+  def renderLiveBlog(path: String, page: Option[String] = None, format: Option[String] = None) =\n+    if (format.contains(\"email\"))\n+      renderArticle(path)","path":"article/app/controllers/ArticleController.scala","position":8,"original_position":8,"commit_id":"8fa3119e69945b37d77445053d18fdf58f81dab1","original_commit_id":"8fa3119e69945b37d77445053d18fdf58f81dab1","user":{"login":"johnduffell","id":7304387,"avatar_url":"https://avatars.githubusercontent.com/u/7304387?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduffell","html_url":"https://github.com/johnduffell","followers_url":"https://api.github.com/users/johnduffell/followers","following_url":"https://api.github.com/users/johnduffell/following{/other_user}","gists_url":"https://api.github.com/users/johnduffell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduffell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduffell/subscriptions","organizations_url":"https://api.github.com/users/johnduffell/orgs","repos_url":"https://api.github.com/users/johnduffell/repos","events_url":"https://api.github.com/users/johnduffell/events{/privacy}","received_events_url":"https://api.github.com/users/johnduffell/received_events","type":"User","site_admin":false},"body":"if format isn't email, you should throw a 404 ideally, so we don't cache the same content on more than one url","created_at":"2016-08-26T16:54:11Z","updated_at":"2016-08-26T16:54:11Z","html_url":"https://github.com/guardian/frontend/pull/14110#discussion_r76451076","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/14110","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/76451076"},"html":{"href":"https://github.com/guardian/frontend/pull/14110#discussion_r76451076"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14110"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/14110","id":82558713,"html_url":"https://github.com/guardian/frontend/pull/14110","diff_url":"https://github.com/guardian/frontend/pull/14110.diff","patch_url":"https://github.com/guardian/frontend/pull/14110.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/14110","number":14110,"state":"closed","locked":false,"title":"Enable email format for all LiveBlogs, including Minute pages","user":{"login":"katebee","id":8607683,"avatar_url":"https://avatars.githubusercontent.com/u/8607683?v=3","gravatar_id":"","url":"https://api.github.com/users/katebee","html_url":"https://github.com/katebee","followers_url":"https://api.github.com/users/katebee/followers","following_url":"https://api.github.com/users/katebee/following{/other_user}","gists_url":"https://api.github.com/users/katebee/gists{/gist_id}","starred_url":"https://api.github.com/users/katebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katebee/subscriptions","organizations_url":"https://api.github.com/users/katebee/orgs","repos_url":"https://api.github.com/users/katebee/repos","events_url":"https://api.github.com/users/katebee/events{/privacy}","received_events_url":"https://api.github.com/users/katebee/received_events","type":"User","site_admin":false},"body":"Alternate name: 404NoMore\r\n\r\n## What does this change?\r\n\r\n`/email` for all! 🚀 (or at least, all LiveBlogs)\r\n\r\n**Changes some 404 pages to email formatted content**\r\nAffects requests to LiveBlog pages when requested with `/email` appended.\r\nAll articles (including LiveBlogs) can now also have `?format=email` as the query param, which will also return the email format\r\n\r\nThe US Minute currently has an email format: \r\nhttps://www.theguardian.com/us-news/live/2016/aug/23/magical-missing-trump-voters/email\r\n\r\nOther Minute pages do not have one; appending **/email** to the URL results in a 404:\r\nhttps://www.theguardian.com/sport/live/2016/aug/20/the-olympic-games-minute-2016-bolts-triple-treble-triumph\r\n\r\nThis PR makes it possible to receive a rendered email page for all LiveBlogs, based on the template built for the *US Campaign Minute*. (Minute pages are a subset of LiveBlogs, they don't have their own `isMinute` flag)\r\n\r\n## What is the value of this and can you measure success?\r\n\r\n- Able to email any Minute series, without giving the webpage all the *US Campaign Minute* specific stylings\r\n- Editors will be able to create Minute format emails (for scaping by ExactTarget)\r\n- Ever want to email someone the Olympic Games Minute 2016? Now you can\r\n- You can even email a whole LiveBlog, if you like long reads (e.g. this https://www.theguardian.com/world/live/2016/aug/24/italy-terremoto-earthquake-buildings-collapse-amatrice-rome-people-trapped/email)\r\n- `?format=email` will also work: \r\nhttps://www.theguardian.com/world/live/2016/aug/24/italy-terremoto-earthquake-buildings-collapse-amatrice-rome-people-trapped?format=email\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nNope.\r\n\r\n## Screenshots\r\n\r\nThe Euro Minute (left) 🏆  Random football LiveBlog (middle) ⚽  The Olympics Minute (Right)🏅\r\n<img width=\"963\" alt=\"picture 199\" src=\"https://cloud.githubusercontent.com/assets/8607683/17934284/37c3409a-6a0f-11e6-87dc-0909fbc6170a.png\">\r\n\r\n\r\n## Request for comment\r\n\r\n@samdesborough @joelochlann \r\n\r\n","created_at":"2016-08-24T14:59:23Z","updated_at":"2016-08-26T16:54:11Z","closed_at":"2016-08-26T16:50:30Z","merged_at":"2016-08-26T16:50:30Z","merge_commit_sha":"b0dd191b5f0c9a30519150a4fc066ee52d0e48e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/14110/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/14110/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/14110/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/8fa3119e69945b37d77445053d18fdf58f81dab1","head":{"label":"guardian:kw-enable-email-format-for-liveBlogs","ref":"kw-enable-email-format-for-liveBlogs","sha":"8fa3119e69945b37d77445053d18fdf58f81dab1","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-08-26T07:59:03Z","pushed_at":"2016-08-26T16:53:29Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":522915,"stargazers_count":3283,"watchers_count":3283,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":342,"mirror_url":null,"open_issues_count":41,"forks":342,"open_issues":41,"watchers":3283,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"582266872cd83b79dc4dea5386d292db49e7a777","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2016-08-26T07:59:03Z","pushed_at":"2016-08-26T16:53:29Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"http://www.theguardian.com","size":522915,"stargazers_count":3283,"watchers_count":3283,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":342,"mirror_url":null,"open_issues_count":41,"forks":342,"open_issues":41,"watchers":3283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14110"},"html":{"href":"https://github.com/guardian/frontend/pull/14110"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/14110"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/14110/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14110/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/14110/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/8fa3119e69945b37d77445053d18fdf58f81dab1"}}}}
{"actor":{"display_login":"johnduffell"}}