{"action":"created","comment":{"url":"https://api.github.com/repos/artefactual/atom/pulls/comments/88461661","pull_request_review_id":9034035,"id":88461661,"diff_hunk":"@@ -672,18 +672,17 @@ protected function updateNestedSet($connection = null)\n   public function getDescendantsForExport($options = array())\n   {\n     $descendants = array();\n-    $fromClipboard = isset($options['params']['fromClipboard']) ? true : false;\n     $levels = isset($options['levels']) ? $options['levels'] : array();\n     $numLevels = count($levels);\n \n     foreach ($this->getChildren()->orderBy('lft') as $child)\n     {\n       $addCondition = true;\n \n-      // If we're not in a CLI or BG job enviroment, check ACL\n-      if (!is_using_cli() || $fromClipboard)\n+      // If we're not in a CLI enviroment, check ACL\n+      if ('cli' != sfContext::getInstance()->getConfiguration()->getEnvironment())\n       {\n-        $addCondition = QubitAcl::check($child, 'read');\n+        $addCondition = QubitAcl::check($child, 'read', $options);","path":"lib/model/QubitInformationObject.php","position":18,"original_position":18,"commit_id":"b0b3424f749944a0dd35c404974ef46f76685baa","original_commit_id":"b0b3424f749944a0dd35c404974ef46f76685baa","user":{"login":"sevein","id":606459,"avatar_url":"https://avatars.githubusercontent.com/u/606459?v=3","gravatar_id":"","url":"https://api.github.com/users/sevein","html_url":"https://github.com/sevein","followers_url":"https://api.github.com/users/sevein/followers","following_url":"https://api.github.com/users/sevein/following{/other_user}","gists_url":"https://api.github.com/users/sevein/gists{/gist_id}","starred_url":"https://api.github.com/users/sevein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sevein/subscriptions","organizations_url":"https://api.github.com/users/sevein/orgs","repos_url":"https://api.github.com/users/sevein/repos","events_url":"https://api.github.com/users/sevein/events{/privacy}","received_events_url":"https://api.github.com/users/sevein/received_events","type":"User","site_admin":false},"body":"What exactly is in `$options` that you need to pass to `QubitAcl`? `levels`? `public`?","created_at":"2016-11-17T14:25:28Z","updated_at":"2016-11-17T14:25:28Z","html_url":"https://github.com/artefactual/atom/pull/463#discussion_r88461661","pull_request_url":"https://api.github.com/repos/artefactual/atom/pulls/463","_links":{"self":{"href":"https://api.github.com/repos/artefactual/atom/pulls/comments/88461661"},"html":{"href":"https://github.com/artefactual/atom/pull/463#discussion_r88461661"},"pull_request":{"href":"https://api.github.com/repos/artefactual/atom/pulls/463"}}},"pull_request":{"url":"https://api.github.com/repos/artefactual/atom/pulls/463","id":93616930,"html_url":"https://github.com/artefactual/atom/pull/463","diff_url":"https://github.com/artefactual/atom/pull/463.diff","patch_url":"https://github.com/artefactual/atom/pull/463.patch","issue_url":"https://api.github.com/repos/artefactual/atom/issues/463","number":463,"state":"open","locked":false,"title":"Enable ACL checks on export, Refs #10000","user":{"login":"sbreker","id":3812460,"avatar_url":"https://avatars.githubusercontent.com/u/3812460?v=3","gravatar_id":"","url":"https://api.github.com/users/sbreker","html_url":"https://github.com/sbreker","followers_url":"https://api.github.com/users/sbreker/followers","following_url":"https://api.github.com/users/sbreker/following{/other_user}","gists_url":"https://api.github.com/users/sbreker/gists{/gist_id}","starred_url":"https://api.github.com/users/sbreker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbreker/subscriptions","organizations_url":"https://api.github.com/users/sbreker/orgs","repos_url":"https://api.github.com/users/sbreker/repos","events_url":"https://api.github.com/users/sbreker/events{/privacy}","received_events_url":"https://api.github.com/users/sbreker/received_events","type":"User","site_admin":false},"body":"Historically, ACL checks are disabled for CLI tasks. This applied also to\r\nasynchronous background jobs. CSV and XML export background jobs launched\r\nfrom the Clipboard required ACL checks to be run. This change allows a\r\nbackground job to conditionally enable ACL checks.\r\n\r\narBaseJob has two new methods that activate ACL checks when called. This is\r\noptional for each background job so as not to impact existing functionality.\r\nCurrently, the only two background jobs that call these methods to activate\r\nACL checks are arInformationObjectExportJob and arXmlExportJob.","created_at":"2016-11-14T18:04:57Z","updated_at":"2016-11-17T14:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a123db8c645b0d54595f67d11d055da9627ecbf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/artefactual/atom/pulls/463/commits","review_comments_url":"https://api.github.com/repos/artefactual/atom/pulls/463/comments","review_comment_url":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artefactual/atom/issues/463/comments","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/b0b3424f749944a0dd35c404974ef46f76685baa","head":{"label":"artefactual:dev/issue-10000-acl-permission-on-export","ref":"dev/issue-10000-acl-permission-on-export","sha":"b0b3424f749944a0dd35c404974ef46f76685baa","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual/atom/deployments","created_at":"2012-09-06T17:35:28Z","updated_at":"2016-11-02T15:50:57Z","pushed_at":"2016-11-17T09:15:34Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":51376,"stargazers_count":61,"watchers_count":61,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":2,"forks":49,"open_issues":2,"watchers":61,"default_branch":"qa/2.4.x"}},"base":{"label":"artefactual:qa/2.4.x","ref":"qa/2.4.x","sha":"866cc783a0ec6944fedb0a28d262f1677d9db8b8","user":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"repo":{"id":5705943,"name":"atom","full_name":"artefactual/atom","owner":{"login":"artefactual","id":1163545,"avatar_url":"https://avatars.githubusercontent.com/u/1163545?v=3","gravatar_id":"","url":"https://api.github.com/users/artefactual","html_url":"https://github.com/artefactual","followers_url":"https://api.github.com/users/artefactual/followers","following_url":"https://api.github.com/users/artefactual/following{/other_user}","gists_url":"https://api.github.com/users/artefactual/gists{/gist_id}","starred_url":"https://api.github.com/users/artefactual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artefactual/subscriptions","organizations_url":"https://api.github.com/users/artefactual/orgs","repos_url":"https://api.github.com/users/artefactual/repos","events_url":"https://api.github.com/users/artefactual/events{/privacy}","received_events_url":"https://api.github.com/users/artefactual/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artefactual/atom","description":"Open-source, web application for archival description and public access.","fork":false,"url":"https://api.github.com/repos/artefactual/atom","forks_url":"https://api.github.com/repos/artefactual/atom/forks","keys_url":"https://api.github.com/repos/artefactual/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artefactual/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artefactual/atom/teams","hooks_url":"https://api.github.com/repos/artefactual/atom/hooks","issue_events_url":"https://api.github.com/repos/artefactual/atom/issues/events{/number}","events_url":"https://api.github.com/repos/artefactual/atom/events","assignees_url":"https://api.github.com/repos/artefactual/atom/assignees{/user}","branches_url":"https://api.github.com/repos/artefactual/atom/branches{/branch}","tags_url":"https://api.github.com/repos/artefactual/atom/tags","blobs_url":"https://api.github.com/repos/artefactual/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artefactual/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artefactual/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/artefactual/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artefactual/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/artefactual/atom/languages","stargazers_url":"https://api.github.com/repos/artefactual/atom/stargazers","contributors_url":"https://api.github.com/repos/artefactual/atom/contributors","subscribers_url":"https://api.github.com/repos/artefactual/atom/subscribers","subscription_url":"https://api.github.com/repos/artefactual/atom/subscription","commits_url":"https://api.github.com/repos/artefactual/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/artefactual/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/artefactual/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/artefactual/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/artefactual/atom/contents/{+path}","compare_url":"https://api.github.com/repos/artefactual/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artefactual/atom/merges","archive_url":"https://api.github.com/repos/artefactual/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artefactual/atom/downloads","issues_url":"https://api.github.com/repos/artefactual/atom/issues{/number}","pulls_url":"https://api.github.com/repos/artefactual/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/artefactual/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/artefactual/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artefactual/atom/labels{/name}","releases_url":"https://api.github.com/repos/artefactual/atom/releases{/id}","deployments_url":"https://api.github.com/repos/artefactual/atom/deployments","created_at":"2012-09-06T17:35:28Z","updated_at":"2016-11-02T15:50:57Z","pushed_at":"2016-11-17T09:15:34Z","git_url":"git://github.com/artefactual/atom.git","ssh_url":"git@github.com:artefactual/atom.git","clone_url":"https://github.com/artefactual/atom.git","svn_url":"https://github.com/artefactual/atom","homepage":"http://www.accesstomemory.org","size":51376,"stargazers_count":61,"watchers_count":61,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":2,"forks":49,"open_issues":2,"watchers":61,"default_branch":"qa/2.4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/artefactual/atom/pulls/463"},"html":{"href":"https://github.com/artefactual/atom/pull/463"},"issue":{"href":"https://api.github.com/repos/artefactual/atom/issues/463"},"comments":{"href":"https://api.github.com/repos/artefactual/atom/issues/463/comments"},"review_comments":{"href":"https://api.github.com/repos/artefactual/atom/pulls/463/comments"},"review_comment":{"href":"https://api.github.com/repos/artefactual/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artefactual/atom/pulls/463/commits"},"statuses":{"href":"https://api.github.com/repos/artefactual/atom/statuses/b0b3424f749944a0dd35c404974ef46f76685baa"}}}}
{"actor":{"display_login":"sevein"}}