{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/react-dates/pulls/comments/75406038","id":75406038,"diff_hunk":"@@ -190,27 +240,33 @@ export default class DayPicker extends React.Component {\n   }\n \n   adjustDayPickerHeight() {\n-    const $transitionContainer = $(ReactDOM.findDOMNode(this.refs.transitionContainer));\n-    const heights = $transitionContainer.find('.CalendarMonth[data-visible=\"true\"]').get().map(\n-      (month) => this.getMonthHeight($(month))\n-    );\n+    const transitionContainer = ReactDOM.findDOMNode(this.refs.transitionContainer);\n+    const calendarMonths = transitionContainer.querySelectorAll('.CalendarMonth');\n+    const heights = [];\n+\n+    // convert node list to array\n+    Array.prototype.slice.call(calendarMonths).forEach((el) => {","path":"src/components/DayPicker.jsx","position":128,"original_position":128,"commit_id":"a7e4fec13b4f8f864e9cdbad86f940007e231020","original_commit_id":"a7e4fec13b4f8f864e9cdbad86f940007e231020","user":{"login":"ljharb","id":45469,"avatar_url":"https://avatars.githubusercontent.com/u/45469?v=3","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"spreading will compile down to effectively a slice + forEach - forEach.call will just be the forEach (so i'd recommend doing that)","created_at":"2016-08-18T23:15:50Z","updated_at":"2016-08-18T23:15:50Z","html_url":"https://github.com/airbnb/react-dates/pull/16#discussion_r75406038","pull_request_url":"https://api.github.com/repos/airbnb/react-dates/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/airbnb/react-dates/pulls/comments/75406038"},"html":{"href":"https://github.com/airbnb/react-dates/pull/16#discussion_r75406038"},"pull_request":{"href":"https://api.github.com/repos/airbnb/react-dates/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/react-dates/pulls/16","id":81891379,"html_url":"https://github.com/airbnb/react-dates/pull/16","diff_url":"https://github.com/airbnb/react-dates/pull/16.diff","patch_url":"https://github.com/airbnb/react-dates/pull/16.patch","issue_url":"https://api.github.com/repos/airbnb/react-dates/issues/16","number":16,"state":"open","locked":false,"title":"[wip] Remove jQuery as a dependency","user":{"login":"milesj","id":143744,"avatar_url":"https://avatars.githubusercontent.com/u/143744?v=3","gravatar_id":"","url":"https://api.github.com/users/milesj","html_url":"https://github.com/milesj","followers_url":"https://api.github.com/users/milesj/followers","following_url":"https://api.github.com/users/milesj/following{/other_user}","gists_url":"https://api.github.com/users/milesj/gists{/gist_id}","starred_url":"https://api.github.com/users/milesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesj/subscriptions","organizations_url":"https://api.github.com/users/milesj/orgs","repos_url":"https://api.github.com/users/milesj/repos","events_url":"https://api.github.com/users/milesj/events{/privacy}","received_events_url":"https://api.github.com/users/milesj/received_events","type":"User","site_admin":false},"body":"This PR removes jQuery as a dependency and replaces the outer/inner width/height methods with a single function that handles all scenarios. Will need to do further testing in browser and within unit tests to verify the numbers are correct.","created_at":"2016-08-18T21:27:38Z","updated_at":"2016-08-18T23:15:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64e895ff14afdc274e8c5d99c60873fa7b5ba5d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/react-dates/pulls/16/commits","review_comments_url":"https://api.github.com/repos/airbnb/react-dates/pulls/16/comments","review_comment_url":"https://api.github.com/repos/airbnb/react-dates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/react-dates/issues/16/comments","statuses_url":"https://api.github.com/repos/airbnb/react-dates/statuses/a7e4fec13b4f8f864e9cdbad86f940007e231020","head":{"label":"milesj:remove-jquery-dep","ref":"remove-jquery-dep","sha":"a7e4fec13b4f8f864e9cdbad86f940007e231020","user":{"login":"milesj","id":143744,"avatar_url":"https://avatars.githubusercontent.com/u/143744?v=3","gravatar_id":"","url":"https://api.github.com/users/milesj","html_url":"https://github.com/milesj","followers_url":"https://api.github.com/users/milesj/followers","following_url":"https://api.github.com/users/milesj/following{/other_user}","gists_url":"https://api.github.com/users/milesj/gists{/gist_id}","starred_url":"https://api.github.com/users/milesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesj/subscriptions","organizations_url":"https://api.github.com/users/milesj/orgs","repos_url":"https://api.github.com/users/milesj/repos","events_url":"https://api.github.com/users/milesj/events{/privacy}","received_events_url":"https://api.github.com/users/milesj/received_events","type":"User","site_admin":false},"repo":{"id":66031739,"name":"react-dates","full_name":"milesj/react-dates","owner":{"login":"milesj","id":143744,"avatar_url":"https://avatars.githubusercontent.com/u/143744?v=3","gravatar_id":"","url":"https://api.github.com/users/milesj","html_url":"https://github.com/milesj","followers_url":"https://api.github.com/users/milesj/followers","following_url":"https://api.github.com/users/milesj/following{/other_user}","gists_url":"https://api.github.com/users/milesj/gists{/gist_id}","starred_url":"https://api.github.com/users/milesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesj/subscriptions","organizations_url":"https://api.github.com/users/milesj/orgs","repos_url":"https://api.github.com/users/milesj/repos","events_url":"https://api.github.com/users/milesj/events{/privacy}","received_events_url":"https://api.github.com/users/milesj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milesj/react-dates","description":"An accessible, easily internationalizable, mobile-friendly datepicker library for the web","fork":true,"url":"https://api.github.com/repos/milesj/react-dates","forks_url":"https://api.github.com/repos/milesj/react-dates/forks","keys_url":"https://api.github.com/repos/milesj/react-dates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milesj/react-dates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milesj/react-dates/teams","hooks_url":"https://api.github.com/repos/milesj/react-dates/hooks","issue_events_url":"https://api.github.com/repos/milesj/react-dates/issues/events{/number}","events_url":"https://api.github.com/repos/milesj/react-dates/events","assignees_url":"https://api.github.com/repos/milesj/react-dates/assignees{/user}","branches_url":"https://api.github.com/repos/milesj/react-dates/branches{/branch}","tags_url":"https://api.github.com/repos/milesj/react-dates/tags","blobs_url":"https://api.github.com/repos/milesj/react-dates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milesj/react-dates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milesj/react-dates/git/refs{/sha}","trees_url":"https://api.github.com/repos/milesj/react-dates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milesj/react-dates/statuses/{sha}","languages_url":"https://api.github.com/repos/milesj/react-dates/languages","stargazers_url":"https://api.github.com/repos/milesj/react-dates/stargazers","contributors_url":"https://api.github.com/repos/milesj/react-dates/contributors","subscribers_url":"https://api.github.com/repos/milesj/react-dates/subscribers","subscription_url":"https://api.github.com/repos/milesj/react-dates/subscription","commits_url":"https://api.github.com/repos/milesj/react-dates/commits{/sha}","git_commits_url":"https://api.github.com/repos/milesj/react-dates/git/commits{/sha}","comments_url":"https://api.github.com/repos/milesj/react-dates/comments{/number}","issue_comment_url":"https://api.github.com/repos/milesj/react-dates/issues/comments{/number}","contents_url":"https://api.github.com/repos/milesj/react-dates/contents/{+path}","compare_url":"https://api.github.com/repos/milesj/react-dates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milesj/react-dates/merges","archive_url":"https://api.github.com/repos/milesj/react-dates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milesj/react-dates/downloads","issues_url":"https://api.github.com/repos/milesj/react-dates/issues{/number}","pulls_url":"https://api.github.com/repos/milesj/react-dates/pulls{/number}","milestones_url":"https://api.github.com/repos/milesj/react-dates/milestones{/number}","notifications_url":"https://api.github.com/repos/milesj/react-dates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milesj/react-dates/labels{/name}","releases_url":"https://api.github.com/repos/milesj/react-dates/releases{/id}","deployments_url":"https://api.github.com/repos/milesj/react-dates/deployments","created_at":"2016-08-18T21:25:00Z","updated_at":"2016-08-18T21:25:01Z","pushed_at":"2016-08-18T22:58:59Z","git_url":"git://github.com/milesj/react-dates.git","ssh_url":"git@github.com:milesj/react-dates.git","clone_url":"https://github.com/milesj/react-dates.git","svn_url":"https://github.com/milesj/react-dates","homepage":"https://www.npmjs.com/package/react-dates","size":336,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"6ed81350de9e6272e8dcf82b361454783806d5c4","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":58011499,"name":"react-dates","full_name":"airbnb/react-dates","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/react-dates","description":"An accessible, easily internationalizable, mobile-friendly datepicker library for the web","fork":false,"url":"https://api.github.com/repos/airbnb/react-dates","forks_url":"https://api.github.com/repos/airbnb/react-dates/forks","keys_url":"https://api.github.com/repos/airbnb/react-dates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/react-dates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/react-dates/teams","hooks_url":"https://api.github.com/repos/airbnb/react-dates/hooks","issue_events_url":"https://api.github.com/repos/airbnb/react-dates/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/react-dates/events","assignees_url":"https://api.github.com/repos/airbnb/react-dates/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/react-dates/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/react-dates/tags","blobs_url":"https://api.github.com/repos/airbnb/react-dates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/react-dates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/react-dates/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/react-dates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/react-dates/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/react-dates/languages","stargazers_url":"https://api.github.com/repos/airbnb/react-dates/stargazers","contributors_url":"https://api.github.com/repos/airbnb/react-dates/contributors","subscribers_url":"https://api.github.com/repos/airbnb/react-dates/subscribers","subscription_url":"https://api.github.com/repos/airbnb/react-dates/subscription","commits_url":"https://api.github.com/repos/airbnb/react-dates/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/react-dates/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/react-dates/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/react-dates/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/react-dates/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/react-dates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/react-dates/merges","archive_url":"https://api.github.com/repos/airbnb/react-dates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/react-dates/downloads","issues_url":"https://api.github.com/repos/airbnb/react-dates/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/react-dates/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/react-dates/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/react-dates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/react-dates/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/react-dates/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/react-dates/deployments","created_at":"2016-05-04T00:49:45Z","updated_at":"2016-08-18T23:07:03Z","pushed_at":"2016-08-18T22:58:59Z","git_url":"git://github.com/airbnb/react-dates.git","ssh_url":"git@github.com:airbnb/react-dates.git","clone_url":"https://github.com/airbnb/react-dates.git","svn_url":"https://github.com/airbnb/react-dates","homepage":"https://www.npmjs.com/package/react-dates","size":387,"stargazers_count":569,"watchers_count":569,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":8,"forks":21,"open_issues":8,"watchers":569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/react-dates/pulls/16"},"html":{"href":"https://github.com/airbnb/react-dates/pull/16"},"issue":{"href":"https://api.github.com/repos/airbnb/react-dates/issues/16"},"comments":{"href":"https://api.github.com/repos/airbnb/react-dates/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/react-dates/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/react-dates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/react-dates/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/react-dates/statuses/a7e4fec13b4f8f864e9cdbad86f940007e231020"}}}}
{"actor":{"display_login":"ljharb"}}