{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/abhinav/pinch/pulls/2","id":71969047,"html_url":"https://github.com/abhinav/pinch/pull/2","diff_url":"https://github.com/abhinav/pinch/pull/2.diff","patch_url":"https://github.com/abhinav/pinch/pull/2.patch","issue_url":"https://api.github.com/repos/abhinav/pinch/issues/2","number":2,"state":"closed","locked":false,"title":"[RFC] Add support for compact protocol","user":{"login":"bgamari","id":1010174,"avatar_url":"https://avatars.githubusercontent.com/u/1010174?v=3","gravatar_id":"","url":"https://api.github.com/users/bgamari","html_url":"https://github.com/bgamari","followers_url":"https://api.github.com/users/bgamari/followers","following_url":"https://api.github.com/users/bgamari/following{/other_user}","gists_url":"https://api.github.com/users/bgamari/gists{/gist_id}","starred_url":"https://api.github.com/users/bgamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgamari/subscriptions","organizations_url":"https://api.github.com/users/bgamari/orgs","repos_url":"https://api.github.com/users/bgamari/repos","events_url":"https://api.github.com/users/bgamari/events{/privacy}","received_events_url":"https://api.github.com/users/bgamari/received_events","type":"User","site_admin":false},"body":"Thanks for the great library. This is the current state of my ill-fated attempt at adding support for the compact protocol. I say ill-fated because it unfortunately seems impossible to correctly implement this protocol within the confines of the existing interface.\r\n\r\nWhile this patch implements most of the protocol correctly, it unfortunately falls short in handling empty maps and other containers. In this case the compact protocol omits any type information, which means we are unable to provide an unambiguous `TType` for the resulting `Value`. Unfortunately it's really not clear how to fix this while maintaining the nice semantics of the library (e.g. allowing access to a `Value`'s `TType`). In this sense it appears that the compact protocol sacrifices the fully self-describing property that the original binary protocol preserved.\r\n\r\nI can see two ways forward, neither very appealing,\r\n 1. Require that type information is provided during deserialization\r\n 2. Add a `TAny` type, meaning that the type of a term depends upon its value (since we would need to assign an empty list the element type `TAny` whereas a non-empty type would have a proper type.\r\n \r\nPerhaps you have some ideas on how to proceed?","created_at":"2016-05-31T07:24:22Z","updated_at":"2016-06-02T08:54:37Z","closed_at":"2016-06-02T08:54:37Z","merged_at":"2016-06-02T08:54:37Z","merge_commit_sha":"04f7e1c0aa3bc2de1c22625fd47bd7572c285886","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/abhinav/pinch/pulls/2/commits","review_comments_url":"https://api.github.com/repos/abhinav/pinch/pulls/2/comments","review_comment_url":"https://api.github.com/repos/abhinav/pinch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/abhinav/pinch/issues/2/comments","statuses_url":"https://api.github.com/repos/abhinav/pinch/statuses/04f7e1c0aa3bc2de1c22625fd47bd7572c285886","head":{"label":"bgamari:compact","ref":"compact","sha":"04f7e1c0aa3bc2de1c22625fd47bd7572c285886","user":{"login":"bgamari","id":1010174,"avatar_url":"https://avatars.githubusercontent.com/u/1010174?v=3","gravatar_id":"","url":"https://api.github.com/users/bgamari","html_url":"https://github.com/bgamari","followers_url":"https://api.github.com/users/bgamari/followers","following_url":"https://api.github.com/users/bgamari/following{/other_user}","gists_url":"https://api.github.com/users/bgamari/gists{/gist_id}","starred_url":"https://api.github.com/users/bgamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgamari/subscriptions","organizations_url":"https://api.github.com/users/bgamari/orgs","repos_url":"https://api.github.com/users/bgamari/repos","events_url":"https://api.github.com/users/bgamari/events{/privacy}","received_events_url":"https://api.github.com/users/bgamari/received_events","type":"User","site_admin":false},"repo":{"id":60066915,"name":"pinch","full_name":"bgamari/pinch","owner":{"login":"bgamari","id":1010174,"avatar_url":"https://avatars.githubusercontent.com/u/1010174?v=3","gravatar_id":"","url":"https://api.github.com/users/bgamari","html_url":"https://github.com/bgamari","followers_url":"https://api.github.com/users/bgamari/followers","following_url":"https://api.github.com/users/bgamari/following{/other_user}","gists_url":"https://api.github.com/users/bgamari/gists{/gist_id}","starred_url":"https://api.github.com/users/bgamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgamari/subscriptions","organizations_url":"https://api.github.com/users/bgamari/orgs","repos_url":"https://api.github.com/users/bgamari/repos","events_url":"https://api.github.com/users/bgamari/events{/privacy}","received_events_url":"https://api.github.com/users/bgamari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgamari/pinch","description":"A serialization library for Haskell that provides support for Apache Thrift.","fork":true,"url":"https://api.github.com/repos/bgamari/pinch","forks_url":"https://api.github.com/repos/bgamari/pinch/forks","keys_url":"https://api.github.com/repos/bgamari/pinch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgamari/pinch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgamari/pinch/teams","hooks_url":"https://api.github.com/repos/bgamari/pinch/hooks","issue_events_url":"https://api.github.com/repos/bgamari/pinch/issues/events{/number}","events_url":"https://api.github.com/repos/bgamari/pinch/events","assignees_url":"https://api.github.com/repos/bgamari/pinch/assignees{/user}","branches_url":"https://api.github.com/repos/bgamari/pinch/branches{/branch}","tags_url":"https://api.github.com/repos/bgamari/pinch/tags","blobs_url":"https://api.github.com/repos/bgamari/pinch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgamari/pinch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgamari/pinch/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgamari/pinch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgamari/pinch/statuses/{sha}","languages_url":"https://api.github.com/repos/bgamari/pinch/languages","stargazers_url":"https://api.github.com/repos/bgamari/pinch/stargazers","contributors_url":"https://api.github.com/repos/bgamari/pinch/contributors","subscribers_url":"https://api.github.com/repos/bgamari/pinch/subscribers","subscription_url":"https://api.github.com/repos/bgamari/pinch/subscription","commits_url":"https://api.github.com/repos/bgamari/pinch/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgamari/pinch/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgamari/pinch/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgamari/pinch/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgamari/pinch/contents/{+path}","compare_url":"https://api.github.com/repos/bgamari/pinch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgamari/pinch/merges","archive_url":"https://api.github.com/repos/bgamari/pinch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgamari/pinch/downloads","issues_url":"https://api.github.com/repos/bgamari/pinch/issues{/number}","pulls_url":"https://api.github.com/repos/bgamari/pinch/pulls{/number}","milestones_url":"https://api.github.com/repos/bgamari/pinch/milestones{/number}","notifications_url":"https://api.github.com/repos/bgamari/pinch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgamari/pinch/labels{/name}","releases_url":"https://api.github.com/repos/bgamari/pinch/releases{/id}","deployments_url":"https://api.github.com/repos/bgamari/pinch/deployments","created_at":"2016-05-31T07:18:38Z","updated_at":"2016-05-31T07:18:39Z","pushed_at":"2016-06-02T08:15:19Z","git_url":"git://github.com/bgamari/pinch.git","ssh_url":"git@github.com:bgamari/pinch.git","clone_url":"https://github.com/bgamari/pinch.git","svn_url":"https://github.com/bgamari/pinch","homepage":"","size":217,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"abhinav:master","ref":"master","sha":"37cea30e7e47a32c017c51d02175a41ce360f3ec","user":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"repo":{"id":46253002,"name":"pinch","full_name":"abhinav/pinch","owner":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhinav/pinch","description":"A serialization library for Haskell that provides support for Apache Thrift.","fork":false,"url":"https://api.github.com/repos/abhinav/pinch","forks_url":"https://api.github.com/repos/abhinav/pinch/forks","keys_url":"https://api.github.com/repos/abhinav/pinch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinav/pinch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinav/pinch/teams","hooks_url":"https://api.github.com/repos/abhinav/pinch/hooks","issue_events_url":"https://api.github.com/repos/abhinav/pinch/issues/events{/number}","events_url":"https://api.github.com/repos/abhinav/pinch/events","assignees_url":"https://api.github.com/repos/abhinav/pinch/assignees{/user}","branches_url":"https://api.github.com/repos/abhinav/pinch/branches{/branch}","tags_url":"https://api.github.com/repos/abhinav/pinch/tags","blobs_url":"https://api.github.com/repos/abhinav/pinch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinav/pinch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinav/pinch/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinav/pinch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinav/pinch/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinav/pinch/languages","stargazers_url":"https://api.github.com/repos/abhinav/pinch/stargazers","contributors_url":"https://api.github.com/repos/abhinav/pinch/contributors","subscribers_url":"https://api.github.com/repos/abhinav/pinch/subscribers","subscription_url":"https://api.github.com/repos/abhinav/pinch/subscription","commits_url":"https://api.github.com/repos/abhinav/pinch/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinav/pinch/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinav/pinch/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinav/pinch/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinav/pinch/contents/{+path}","compare_url":"https://api.github.com/repos/abhinav/pinch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinav/pinch/merges","archive_url":"https://api.github.com/repos/abhinav/pinch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinav/pinch/downloads","issues_url":"https://api.github.com/repos/abhinav/pinch/issues{/number}","pulls_url":"https://api.github.com/repos/abhinav/pinch/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinav/pinch/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinav/pinch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinav/pinch/labels{/name}","releases_url":"https://api.github.com/repos/abhinav/pinch/releases{/id}","deployments_url":"https://api.github.com/repos/abhinav/pinch/deployments","created_at":"2015-11-16T04:59:54Z","updated_at":"2016-01-23T07:48:51Z","pushed_at":"2016-06-02T08:54:37Z","git_url":"git://github.com/abhinav/pinch.git","ssh_url":"git@github.com:abhinav/pinch.git","clone_url":"https://github.com/abhinav/pinch.git","svn_url":"https://github.com/abhinav/pinch","homepage":"","size":209,"stargazers_count":2,"watchers_count":2,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/abhinav/pinch/pulls/2"},"html":{"href":"https://github.com/abhinav/pinch/pull/2"},"issue":{"href":"https://api.github.com/repos/abhinav/pinch/issues/2"},"comments":{"href":"https://api.github.com/repos/abhinav/pinch/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/abhinav/pinch/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/abhinav/pinch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/abhinav/pinch/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/abhinav/pinch/statuses/04f7e1c0aa3bc2de1c22625fd47bd7572c285886"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"comments":4,"review_comments":8,"commits":8,"additions":826,"deletions":18,"changed_files":13}}
{"actor":{"display_login":"abhinav"}}