{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-object-store/pulls/comments/82512108","pull_request_review_id":3416662,"id":82512108,"diff_hunk":"@@ -89,13 +89,13 @@ ExternalCommitHelper::ExternalCommitHelper(RealmCoordinator& parent)\n     int ret = mkfifo(path.c_str(), 0600);\n     if (ret == -1) {\n         int err = errno;\n-        if (err == ENOTSUP) {\n+        if (err == ENOTSUP || err == EACCES) {\n             // Filesystem doesn't support named pipes, so try putting it in tmp instead\n             // Hash collisions are okay here because they just result in doing\n             // extra work, as opposed to correctness problems\n             std::ostringstream ss;\n \n-            std::string tmp_dir(getenv(\"TMPDIR\"));\n+            std::string tmp_dir = parent.get_temp_dir();","path":"src/impl/android/external_commit_helper.cpp","position":null,"original_position":12,"commit_id":"bcdae7ffadd22a23c0ff907262bc30799bc8a9c2","original_commit_id":"e7b3eac9aa74ec4a3387cd9077d1329cddf92648","user":{"login":"zaki50","id":406660,"avatar_url":"https://avatars.githubusercontent.com/u/406660?v=3","gravatar_id":"","url":"https://api.github.com/users/zaki50","html_url":"https://github.com/zaki50","followers_url":"https://api.github.com/users/zaki50/followers","following_url":"https://api.github.com/users/zaki50/following{/other_user}","gists_url":"https://api.github.com/users/zaki50/gists{/gist_id}","starred_url":"https://api.github.com/users/zaki50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaki50/subscriptions","organizations_url":"https://api.github.com/users/zaki50/orgs","repos_url":"https://api.github.com/users/zaki50/repos","events_url":"https://api.github.com/users/zaki50/events{/privacy}","received_events_url":"https://api.github.com/users/zaki50/received_events","type":"User","site_admin":false},"body":"added a check if the `tmp_dir` is empty.","created_at":"2016-10-09T00:23:31Z","updated_at":"2016-10-09T00:23:31Z","html_url":"https://github.com/realm/realm-object-store/pull/191#discussion_r82512108","pull_request_url":"https://api.github.com/repos/realm/realm-object-store/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/comments/82512108"},"html":{"href":"https://github.com/realm/realm-object-store/pull/191#discussion_r82512108"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-object-store/pulls/191","id":88473360,"html_url":"https://github.com/realm/realm-object-store/pull/191","diff_url":"https://github.com/realm/realm-object-store/pull/191.diff","patch_url":"https://github.com/realm/realm-object-store/pull/191.patch","issue_url":"https://api.github.com/repos/realm/realm-object-store/issues/191","number":191,"state":"open","locked":false,"title":"fix support for the filesystem which does not allow mkfifo","user":{"login":"zaki50","id":406660,"avatar_url":"https://avatars.githubusercontent.com/u/406660?v=3","gravatar_id":"","url":"https://api.github.com/users/zaki50","html_url":"https://github.com/zaki50","followers_url":"https://api.github.com/users/zaki50/followers","following_url":"https://api.github.com/users/zaki50/following{/other_user}","gists_url":"https://api.github.com/users/zaki50/gists{/gist_id}","starred_url":"https://api.github.com/users/zaki50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaki50/subscriptions","organizations_url":"https://api.github.com/users/zaki50/orgs","repos_url":"https://api.github.com/users/zaki50/repos","events_url":"https://api.github.com/users/zaki50/events{/privacy}","received_events_url":"https://api.github.com/users/zaki50/received_events","type":"User","site_admin":false},"body":"fix for realm/realm-java#3140\r\n\r\nreview this please @realm/java @beeender @kneth ","created_at":"2016-10-07T17:00:21Z","updated_at":"2016-10-09T00:23:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71af336d411279573909f47b386762aa895ad521","assignee":{"login":"zaki50","id":406660,"avatar_url":"https://avatars.githubusercontent.com/u/406660?v=3","gravatar_id":"","url":"https://api.github.com/users/zaki50","html_url":"https://github.com/zaki50","followers_url":"https://api.github.com/users/zaki50/followers","following_url":"https://api.github.com/users/zaki50/following{/other_user}","gists_url":"https://api.github.com/users/zaki50/gists{/gist_id}","starred_url":"https://api.github.com/users/zaki50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaki50/subscriptions","organizations_url":"https://api.github.com/users/zaki50/orgs","repos_url":"https://api.github.com/users/zaki50/repos","events_url":"https://api.github.com/users/zaki50/events{/privacy}","received_events_url":"https://api.github.com/users/zaki50/received_events","type":"User","site_admin":false},"assignees":[{"login":"zaki50","id":406660,"avatar_url":"https://avatars.githubusercontent.com/u/406660?v=3","gravatar_id":"","url":"https://api.github.com/users/zaki50","html_url":"https://github.com/zaki50","followers_url":"https://api.github.com/users/zaki50/followers","following_url":"https://api.github.com/users/zaki50/following{/other_user}","gists_url":"https://api.github.com/users/zaki50/gists{/gist_id}","starred_url":"https://api.github.com/users/zaki50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaki50/subscriptions","organizations_url":"https://api.github.com/users/zaki50/orgs","repos_url":"https://api.github.com/users/zaki50/repos","events_url":"https://api.github.com/users/zaki50/events{/privacy}","received_events_url":"https://api.github.com/users/zaki50/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-object-store/pulls/191/commits","review_comments_url":"https://api.github.com/repos/realm/realm-object-store/pulls/191/comments","review_comment_url":"https://api.github.com/repos/realm/realm-object-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-object-store/issues/191/comments","statuses_url":"https://api.github.com/repos/realm/realm-object-store/statuses/bcdae7ffadd22a23c0ff907262bc30799bc8a9c2","head":{"label":"realm:my/mkfifo_tmpdir","ref":"my/mkfifo_tmpdir","sha":"bcdae7ffadd22a23c0ff907262bc30799bc8a9c2","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":36953657,"name":"realm-object-store","full_name":"realm/realm-object-store","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-object-store","description":"Cross-platform abstractions used within Realm products","fork":false,"url":"https://api.github.com/repos/realm/realm-object-store","forks_url":"https://api.github.com/repos/realm/realm-object-store/forks","keys_url":"https://api.github.com/repos/realm/realm-object-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-object-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-object-store/teams","hooks_url":"https://api.github.com/repos/realm/realm-object-store/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-object-store/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-object-store/events","assignees_url":"https://api.github.com/repos/realm/realm-object-store/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-object-store/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-object-store/tags","blobs_url":"https://api.github.com/repos/realm/realm-object-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-object-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-object-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-object-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-object-store/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-object-store/languages","stargazers_url":"https://api.github.com/repos/realm/realm-object-store/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-object-store/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-object-store/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-object-store/subscription","commits_url":"https://api.github.com/repos/realm/realm-object-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-object-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-object-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-object-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-object-store/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-object-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-object-store/merges","archive_url":"https://api.github.com/repos/realm/realm-object-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-object-store/downloads","issues_url":"https://api.github.com/repos/realm/realm-object-store/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-object-store/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-object-store/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-object-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-object-store/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-object-store/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-object-store/deployments","created_at":"2015-06-05T20:21:52Z","updated_at":"2016-10-06T16:49:41Z","pushed_at":"2016-10-09T00:21:59Z","git_url":"git://github.com/realm/realm-object-store.git","ssh_url":"git@github.com:realm/realm-object-store.git","clone_url":"https://github.com/realm/realm-object-store.git","svn_url":"https://github.com/realm/realm-object-store","homepage":"https://realm.io","size":3253,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":19,"forks":5,"open_issues":19,"watchers":40,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"9de56784d088d63f7003f492d949a1e824cdae76","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":36953657,"name":"realm-object-store","full_name":"realm/realm-object-store","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-object-store","description":"Cross-platform abstractions used within Realm products","fork":false,"url":"https://api.github.com/repos/realm/realm-object-store","forks_url":"https://api.github.com/repos/realm/realm-object-store/forks","keys_url":"https://api.github.com/repos/realm/realm-object-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-object-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-object-store/teams","hooks_url":"https://api.github.com/repos/realm/realm-object-store/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-object-store/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-object-store/events","assignees_url":"https://api.github.com/repos/realm/realm-object-store/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-object-store/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-object-store/tags","blobs_url":"https://api.github.com/repos/realm/realm-object-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-object-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-object-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-object-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-object-store/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-object-store/languages","stargazers_url":"https://api.github.com/repos/realm/realm-object-store/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-object-store/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-object-store/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-object-store/subscription","commits_url":"https://api.github.com/repos/realm/realm-object-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-object-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-object-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-object-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-object-store/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-object-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-object-store/merges","archive_url":"https://api.github.com/repos/realm/realm-object-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-object-store/downloads","issues_url":"https://api.github.com/repos/realm/realm-object-store/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-object-store/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-object-store/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-object-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-object-store/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-object-store/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-object-store/deployments","created_at":"2015-06-05T20:21:52Z","updated_at":"2016-10-06T16:49:41Z","pushed_at":"2016-10-09T00:21:59Z","git_url":"git://github.com/realm/realm-object-store.git","ssh_url":"git@github.com:realm/realm-object-store.git","clone_url":"https://github.com/realm/realm-object-store.git","svn_url":"https://github.com/realm/realm-object-store","homepage":"https://realm.io","size":3253,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":19,"forks":5,"open_issues":19,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/191"},"html":{"href":"https://github.com/realm/realm-object-store/pull/191"},"issue":{"href":"https://api.github.com/repos/realm/realm-object-store/issues/191"},"comments":{"href":"https://api.github.com/repos/realm/realm-object-store/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-object-store/statuses/bcdae7ffadd22a23c0ff907262bc30799bc8a9c2"}}}}
{"actor":{"display_login":"zaki50"}}