{"action":"created","comment":{"url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/comments/65538066","id":65538066,"diff_hunk":"@@ -14,14 +14,35 @@\n     a11yCheckCallback: function(results) {\n       var violations = results.violations;\n \n-      for (var i = 0, l = violations.length; i < l; i++) {\n-        Ember.Logger.error('Violation #' + (i + 1), violations[i]);\n-      }\n+      if (violations.length) {\n+        Ember.Logger.error('ACCESSIBILITY VIOLATIONS: ' + violations.length);\n+\n+        for (var i = 0, l = violations.length; i < l; i++) {\n+          var violation = violations[i];\n+          var violationNodeString = axe.ember.nodesToString(violation.nodes);\n \n-      Ember.assert('The page should have no accessibility violations.', !violations.length);\n+          Ember.Logger.warn(violation.impact.toUpperCase() + ': ' + violation.help);\n+          Ember.Logger.info('Offending markup (' + violation.nodes.length + '): ' + violationNodeString);\n+          Ember.Logger.info('Additional info: ' + violation.helpUrl);\n+          Ember.Logger.info('-------------------------------------');\n+        }\n+      }\n+      Ember.assert('The page should have no accessibility violations. Please check the developer console for more details.', !violations.length);\n     },\n \n     /**\n+     * Takes the violations' nodes param and converts it to\n+     * a string that can be displayed with the console error.\n+     * @param {Array} nodes\n+     * @return {String}\n+     */\n+     nodesToString: function(nodes) {\n+       return nodes.map(function(node) {\n+         return node.html;\n+       }).join(', ');","path":"content-for/test-body-footer.html","position":33,"original_position":33,"commit_id":"f15c6f6bb86efa59014b009c10f876c3a0d8d07a","original_commit_id":"f15c6f6bb86efa59014b009c10f876c3a0d8d07a","user":{"login":"aliciasedlock","id":579649,"avatar_url":"https://avatars.githubusercontent.com/u/579649?v=3","gravatar_id":"","url":"https://api.github.com/users/aliciasedlock","html_url":"https://github.com/aliciasedlock","followers_url":"https://api.github.com/users/aliciasedlock/followers","following_url":"https://api.github.com/users/aliciasedlock/following{/other_user}","gists_url":"https://api.github.com/users/aliciasedlock/gists{/gist_id}","starred_url":"https://api.github.com/users/aliciasedlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliciasedlock/subscriptions","organizations_url":"https://api.github.com/users/aliciasedlock/orgs","repos_url":"https://api.github.com/users/aliciasedlock/repos","events_url":"https://api.github.com/users/aliciasedlock/events{/privacy}","received_events_url":"https://api.github.com/users/aliciasedlock/received_events","type":"User","site_admin":false},"body":"Good point. There is potential for it to contain a lot of nodes, so perhaps the intent of having the node list at this level makes it less useful.\n\nI can potentially log how many specific violations of that type are present and instead provide an object or array of the offending elements.\n\n\nOn Jun 2, 2016, 12:30 AM -0400, Nathan Hammond<notifications@github.com>, wrote:\n>  \n> Incontent-for/test-body-footer.html(https://github.com/ember-a11y/ember-a11y-testing/pull/25#discussion_r65482880):\n>  \n> >},>>/**>+   * Takes the violations' nodes param and converts it to>+   * a string that can be displayed with the console error.>+   * @param {Array} nodes>+   * @return {String}>+   */>+   nodesToString: function(nodes) {>+    return nodes.map(function(node) {>+     return node.html;>+    }).join(', ');\n>  \n> What if this string is absurdly long?\n>  \n>  \n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly,view it on GitHub(https://github.com/ember-a11y/ember-a11y-testing/pull/25/files/f15c6f6bb86efa59014b009c10f876c3a0d8d07a#r65482880), ormute the thread(https://github.com/notifications/unsubscribe/AAjYQcgi1ArUeP2C8jfGzrYQVyhy-LiBks5qHlxrgaJpZM4IsIU9).\n>  \n>  \n>  \n\n\n","created_at":"2016-06-02T13:25:35Z","updated_at":"2016-06-02T13:25:35Z","html_url":"https://github.com/ember-a11y/ember-a11y-testing/pull/25#discussion_r65538066","pull_request_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/comments/65538066"},"html":{"href":"https://github.com/ember-a11y/ember-a11y-testing/pull/25#discussion_r65538066"},"pull_request":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25","id":72277880,"html_url":"https://github.com/ember-a11y/ember-a11y-testing/pull/25","diff_url":"https://github.com/ember-a11y/ember-a11y-testing/pull/25.diff","patch_url":"https://github.com/ember-a11y/ember-a11y-testing/pull/25.patch","issue_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/issues/25","number":25,"state":"open","locked":false,"title":"Add more descriptive violation logging","user":{"login":"aliciasedlock","id":579649,"avatar_url":"https://avatars.githubusercontent.com/u/579649?v=3","gravatar_id":"","url":"https://api.github.com/users/aliciasedlock","html_url":"https://github.com/aliciasedlock","followers_url":"https://api.github.com/users/aliciasedlock/followers","following_url":"https://api.github.com/users/aliciasedlock/following{/other_user}","gists_url":"https://api.github.com/users/aliciasedlock/gists{/gist_id}","starred_url":"https://api.github.com/users/aliciasedlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliciasedlock/subscriptions","organizations_url":"https://api.github.com/users/aliciasedlock/orgs","repos_url":"https://api.github.com/users/aliciasedlock/repos","events_url":"https://api.github.com/users/aliciasedlock/events{/privacy}","received_events_url":"https://api.github.com/users/aliciasedlock/received_events","type":"User","site_admin":false},"body":"Original PR from ember-axe: https://github.com/trentmwillis/ember-axe/pull/7\r\n\r\nAs we are about to use this add-on in a new application, the other developer and I thought it would be nice to have more descriptive logging in the console rather than sifting through the `violations` object output.\r\n\r\nThis both updates the default messages that is displayed inside the browser test runner, along with more precise console logging, rather than dumping the entire `violations` object.\r\n\r\n### RFC\r\nIt seems the `default` environment tests hang due to differences in Ember versions. I'm not entirely sure how to go about fixing that. Not sure if it has something to do with the [WIP Ember upgrade](https://github.com/trentmwillis/ember-axe/pull/6) or what the best way to resolve it now would be.\r\n\r\n#### New test runner messaging\r\n<img width=\"1438\" alt=\"screen shot 2016-05-12 at 8 34 10 pm\" src=\"https://cloud.githubusercontent.com/assets/579649/15234958/4b00906c-1885-11e6-8300-8a6efcb2b2bb.png\">\r\n\r\n#### New console level information\r\n<img width=\"546\" alt=\"screen shot 2016-05-13 at 11 02 22 am\" src=\"https://cloud.githubusercontent.com/assets/579649/15252061/3acd60f6-18fa-11e6-881f-4c9e6b46a04a.png\">","created_at":"2016-06-02T01:37:11Z","updated_at":"2016-06-02T13:25:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57f2e15d6a9e4b6ad8620a40152daebdf64f4d37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/issues/25/comments","statuses_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/statuses/f15c6f6bb86efa59014b009c10f876c3a0d8d07a","head":{"label":"aliciasedlock:logging-updates","ref":"logging-updates","sha":"f15c6f6bb86efa59014b009c10f876c3a0d8d07a","user":{"login":"aliciasedlock","id":579649,"avatar_url":"https://avatars.githubusercontent.com/u/579649?v=3","gravatar_id":"","url":"https://api.github.com/users/aliciasedlock","html_url":"https://github.com/aliciasedlock","followers_url":"https://api.github.com/users/aliciasedlock/followers","following_url":"https://api.github.com/users/aliciasedlock/following{/other_user}","gists_url":"https://api.github.com/users/aliciasedlock/gists{/gist_id}","starred_url":"https://api.github.com/users/aliciasedlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliciasedlock/subscriptions","organizations_url":"https://api.github.com/users/aliciasedlock/orgs","repos_url":"https://api.github.com/users/aliciasedlock/repos","events_url":"https://api.github.com/users/aliciasedlock/events{/privacy}","received_events_url":"https://api.github.com/users/aliciasedlock/received_events","type":"User","site_admin":false},"repo":{"id":60222471,"name":"ember-a11y-testing","full_name":"aliciasedlock/ember-a11y-testing","owner":{"login":"aliciasedlock","id":579649,"avatar_url":"https://avatars.githubusercontent.com/u/579649?v=3","gravatar_id":"","url":"https://api.github.com/users/aliciasedlock","html_url":"https://github.com/aliciasedlock","followers_url":"https://api.github.com/users/aliciasedlock/followers","following_url":"https://api.github.com/users/aliciasedlock/following{/other_user}","gists_url":"https://api.github.com/users/aliciasedlock/gists{/gist_id}","starred_url":"https://api.github.com/users/aliciasedlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliciasedlock/subscriptions","organizations_url":"https://api.github.com/users/aliciasedlock/orgs","repos_url":"https://api.github.com/users/aliciasedlock/repos","events_url":"https://api.github.com/users/aliciasedlock/events{/privacy}","received_events_url":"https://api.github.com/users/aliciasedlock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aliciasedlock/ember-a11y-testing","description":"A suite of accessibility tests that can be run within the Ember testing framework","fork":true,"url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing","forks_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/forks","keys_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/teams","hooks_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/hooks","issue_events_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/issues/events{/number}","events_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/events","assignees_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/assignees{/user}","branches_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/branches{/branch}","tags_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/tags","blobs_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/languages","stargazers_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/stargazers","contributors_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/contributors","subscribers_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/subscribers","subscription_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/subscription","commits_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/contents/{+path}","compare_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/merges","archive_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/downloads","issues_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/issues{/number}","pulls_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/labels{/name}","releases_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/releases{/id}","deployments_url":"https://api.github.com/repos/aliciasedlock/ember-a11y-testing/deployments","created_at":"2016-06-02T01:23:53Z","updated_at":"2016-06-02T01:23:54Z","pushed_at":"2016-06-02T01:36:40Z","git_url":"git://github.com/aliciasedlock/ember-a11y-testing.git","ssh_url":"git@github.com:aliciasedlock/ember-a11y-testing.git","clone_url":"https://github.com/aliciasedlock/ember-a11y-testing.git","svn_url":"https://github.com/aliciasedlock/ember-a11y-testing","homepage":"","size":123,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-a11y:master","ref":"master","sha":"ab7638b6de65c4e3b6786f543aeaa2be2f7adee6","user":{"login":"ember-a11y","id":18333534,"avatar_url":"https://avatars.githubusercontent.com/u/18333534?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-a11y","html_url":"https://github.com/ember-a11y","followers_url":"https://api.github.com/users/ember-a11y/followers","following_url":"https://api.github.com/users/ember-a11y/following{/other_user}","gists_url":"https://api.github.com/users/ember-a11y/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-a11y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-a11y/subscriptions","organizations_url":"https://api.github.com/users/ember-a11y/orgs","repos_url":"https://api.github.com/users/ember-a11y/repos","events_url":"https://api.github.com/users/ember-a11y/events{/privacy}","received_events_url":"https://api.github.com/users/ember-a11y/received_events","type":"Organization","site_admin":false},"repo":{"id":33393189,"name":"ember-a11y-testing","full_name":"ember-a11y/ember-a11y-testing","owner":{"login":"ember-a11y","id":18333534,"avatar_url":"https://avatars.githubusercontent.com/u/18333534?v=3","gravatar_id":"","url":"https://api.github.com/users/ember-a11y","html_url":"https://github.com/ember-a11y","followers_url":"https://api.github.com/users/ember-a11y/followers","following_url":"https://api.github.com/users/ember-a11y/following{/other_user}","gists_url":"https://api.github.com/users/ember-a11y/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-a11y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-a11y/subscriptions","organizations_url":"https://api.github.com/users/ember-a11y/orgs","repos_url":"https://api.github.com/users/ember-a11y/repos","events_url":"https://api.github.com/users/ember-a11y/events{/privacy}","received_events_url":"https://api.github.com/users/ember-a11y/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-a11y/ember-a11y-testing","description":"A suite of accessibility tests that can be run within the Ember testing framework","fork":false,"url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing","forks_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/forks","keys_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/teams","hooks_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/hooks","issue_events_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/issues/events{/number}","events_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/events","assignees_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/assignees{/user}","branches_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/branches{/branch}","tags_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/tags","blobs_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/languages","stargazers_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/stargazers","contributors_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/contributors","subscribers_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/subscribers","subscription_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/subscription","commits_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/contents/{+path}","compare_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/merges","archive_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/downloads","issues_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/issues{/number}","pulls_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/labels{/name}","releases_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/releases{/id}","deployments_url":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/deployments","created_at":"2015-04-04T03:39:11Z","updated_at":"2016-05-19T07:46:33Z","pushed_at":"2016-06-02T01:37:12Z","git_url":"git://github.com/ember-a11y/ember-a11y-testing.git","ssh_url":"git@github.com:ember-a11y/ember-a11y-testing.git","clone_url":"https://github.com/ember-a11y/ember-a11y-testing.git","svn_url":"https://github.com/ember-a11y/ember-a11y-testing","homepage":"","size":136,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":5,"forks":10,"open_issues":5,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25"},"html":{"href":"https://github.com/ember-a11y/ember-a11y-testing/pull/25"},"issue":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/issues/25"},"comments":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ember-a11y/ember-a11y-testing/statuses/f15c6f6bb86efa59014b009c10f876c3a0d8d07a"}}}}
{"actor":{"display_login":"aliciasedlock"}}