{"action":"created","comment":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/52464965","id":52464965,"diff_hunk":"@@ -331,7 +331,16 @@ def update(self, force_replot=False):\n             ydata = self.data_function(axes_manager=self.axes_manager).real\n         else:\n             ydata = self.data_function(axes_manager=self.axes_manager).imag\n-        self.line.set_ydata(ydata)\n+\n+        new_axis = self.axes_manager.signal_axes[0].axis","path":"hyperspy/drawing/spectrum.py","position":6,"original_position":6,"commit_id":"379043851070ab525e09a95e0d617da2a88a1dc1","original_commit_id":"379043851070ab525e09a95e0d617da2a88a1dc1","user":{"login":"to266","id":3384140,"avatar_url":"https://avatars.githubusercontent.com/u/3384140?v=3","gravatar_id":"","url":"https://api.github.com/users/to266","html_url":"https://github.com/to266","followers_url":"https://api.github.com/users/to266/followers","following_url":"https://api.github.com/users/to266/following{/other_user}","gists_url":"https://api.github.com/users/to266/gists{/gist_id}","starred_url":"https://api.github.com/users/to266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/to266/subscriptions","organizations_url":"https://api.github.com/users/to266/orgs","repos_url":"https://api.github.com/users/to266/repos","events_url":"https://api.github.com/users/to266/events{/privacy}","received_events_url":"https://api.github.com/users/to266/received_events","type":"User","site_admin":false},"body":"Nevertheless, https://github.com/vidartf/hyperspy/pull/23","created_at":"2016-02-10T14:40:22Z","updated_at":"2016-02-10T14:40:22Z","html_url":"https://github.com/hyperspy/hyperspy/pull/844#discussion_r52464965","pull_request_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844","_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments/52464965"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/844#discussion_r52464965"},"pull_request":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844"}}},"pull_request":{"url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844","id":56852041,"html_url":"https://github.com/hyperspy/hyperspy/pull/844","diff_url":"https://github.com/hyperspy/hyperspy/pull/844.diff","patch_url":"https://github.com/hyperspy/hyperspy/pull/844.patch","issue_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/844","number":844,"state":"open","locked":false,"title":"ROI interactive output","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"body":"Adds interactive output functionality to the ROIs, allowing for the output signal to be continuously updated as the ROI is modified. The default behavior of the function is to add a widget to the source signal representing the ROI, but this can be changed by an argument.\r\n\r\nThis PR is based on #843, but is also dependent on #434, and consequently #424.\r\n\r\nUsage \r\n--------\r\n```python\r\n>>> s = hs.signals.Spectrum(np.arange(20000).reshape(((10, 20, 100))))\r\n>>> s.plot()\r\n>>> roi = hs.roi.RectangularROI(1,3,3,5)\r\n>>> sr = roi.interactive(s)  # Also adds a widget to `s`\r\n>>> ss = hs.interactive(sr.sum, sr.events.data_changed)\r\n>>> ss.plot()\r\n```\r\n\r\nTodo\r\n------\r\n - [x] User guide\r\n - [ ] I suspect the point ROI classes have the same problem that `Line2DROI` had w.r.t. signal class when ROI is applied in signal space.\r\n - [x] Line2DROI currently makes some mistakes when applied to signal space (axes are handled incorrectly).\r\n - [ ] Not all events are disconnected as appropriate.","created_at":"2016-01-22T06:39:45Z","updated_at":"2016-02-10T14:40:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6cd54d42c5d5fd89a75dd6fd6210cc30b6d06dd","assignee":null,"milestone":{"url":"https://api.github.com/repos/hyperspy/hyperspy/milestones/8","html_url":"https://github.com/hyperspy/hyperspy/milestones/0.9","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones/8/labels","id":856137,"number":8,"title":"0.9","description":"","creator":{"login":"francisco-dlp","id":989719,"avatar_url":"https://avatars.githubusercontent.com/u/989719?v=3","gravatar_id":"","url":"https://api.github.com/users/francisco-dlp","html_url":"https://github.com/francisco-dlp","followers_url":"https://api.github.com/users/francisco-dlp/followers","following_url":"https://api.github.com/users/francisco-dlp/following{/other_user}","gists_url":"https://api.github.com/users/francisco-dlp/gists{/gist_id}","starred_url":"https://api.github.com/users/francisco-dlp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francisco-dlp/subscriptions","organizations_url":"https://api.github.com/users/francisco-dlp/orgs","repos_url":"https://api.github.com/users/francisco-dlp/repos","events_url":"https://api.github.com/users/francisco-dlp/events{/privacy}","received_events_url":"https://api.github.com/users/francisco-dlp/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":55,"state":"open","created_at":"2014-11-06T15:54:23Z","updated_at":"2016-02-08T15:43:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844/commits","review_comments_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844/comments","review_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/844/comments","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/379043851070ab525e09a95e0d617da2a88a1dc1","head":{"label":"vidartf:NEW_ROI_interactive","ref":"NEW_ROI_interactive","sha":"379043851070ab525e09a95e0d617da2a88a1dc1","user":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"repo":{"id":17872313,"name":"hyperspy","full_name":"vidartf/hyperspy","owner":{"login":"vidartf","id":510760,"avatar_url":"https://avatars.githubusercontent.com/u/510760?v=3","gravatar_id":"","url":"https://api.github.com/users/vidartf","html_url":"https://github.com/vidartf","followers_url":"https://api.github.com/users/vidartf/followers","following_url":"https://api.github.com/users/vidartf/following{/other_user}","gists_url":"https://api.github.com/users/vidartf/gists{/gist_id}","starred_url":"https://api.github.com/users/vidartf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidartf/subscriptions","organizations_url":"https://api.github.com/users/vidartf/orgs","repos_url":"https://api.github.com/users/vidartf/repos","events_url":"https://api.github.com/users/vidartf/events{/privacy}","received_events_url":"https://api.github.com/users/vidartf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vidartf/hyperspy","description":"Multidimensional data analysis","fork":true,"url":"https://api.github.com/repos/vidartf/hyperspy","forks_url":"https://api.github.com/repos/vidartf/hyperspy/forks","keys_url":"https://api.github.com/repos/vidartf/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vidartf/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vidartf/hyperspy/teams","hooks_url":"https://api.github.com/repos/vidartf/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/vidartf/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/vidartf/hyperspy/events","assignees_url":"https://api.github.com/repos/vidartf/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/vidartf/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/vidartf/hyperspy/tags","blobs_url":"https://api.github.com/repos/vidartf/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vidartf/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vidartf/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/vidartf/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vidartf/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/vidartf/hyperspy/languages","stargazers_url":"https://api.github.com/repos/vidartf/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/vidartf/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/vidartf/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/vidartf/hyperspy/subscription","commits_url":"https://api.github.com/repos/vidartf/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/vidartf/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/vidartf/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/vidartf/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/vidartf/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/vidartf/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vidartf/hyperspy/merges","archive_url":"https://api.github.com/repos/vidartf/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vidartf/hyperspy/downloads","issues_url":"https://api.github.com/repos/vidartf/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/vidartf/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/vidartf/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/vidartf/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vidartf/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/vidartf/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/vidartf/hyperspy/deployments","created_at":"2014-03-18T16:04:56Z","updated_at":"2016-01-11T21:36:35Z","pushed_at":"2016-02-10T14:40:10Z","git_url":"git://github.com/vidartf/hyperspy.git","ssh_url":"git@github.com:vidartf/hyperspy.git","clone_url":"https://github.com/vidartf/hyperspy.git","svn_url":"https://github.com/vidartf/hyperspy","homepage":"http://www.hyperspy.org","size":76261,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperspy:master","ref":"master","sha":"d5334bbc6946b1d6f7d3fdff605428e4ff4f5d67","user":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"repo":{"id":2233998,"name":"hyperspy","full_name":"hyperspy/hyperspy","owner":{"login":"hyperspy","id":989756,"avatar_url":"https://avatars.githubusercontent.com/u/989756?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperspy","html_url":"https://github.com/hyperspy","followers_url":"https://api.github.com/users/hyperspy/followers","following_url":"https://api.github.com/users/hyperspy/following{/other_user}","gists_url":"https://api.github.com/users/hyperspy/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperspy/subscriptions","organizations_url":"https://api.github.com/users/hyperspy/orgs","repos_url":"https://api.github.com/users/hyperspy/repos","events_url":"https://api.github.com/users/hyperspy/events{/privacy}","received_events_url":"https://api.github.com/users/hyperspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperspy/hyperspy","description":"Multidimensional data analysis","fork":false,"url":"https://api.github.com/repos/hyperspy/hyperspy","forks_url":"https://api.github.com/repos/hyperspy/hyperspy/forks","keys_url":"https://api.github.com/repos/hyperspy/hyperspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperspy/hyperspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperspy/hyperspy/teams","hooks_url":"https://api.github.com/repos/hyperspy/hyperspy/hooks","issue_events_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/events{/number}","events_url":"https://api.github.com/repos/hyperspy/hyperspy/events","assignees_url":"https://api.github.com/repos/hyperspy/hyperspy/assignees{/user}","branches_url":"https://api.github.com/repos/hyperspy/hyperspy/branches{/branch}","tags_url":"https://api.github.com/repos/hyperspy/hyperspy/tags","blobs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperspy/hyperspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperspy/hyperspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperspy/hyperspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperspy/hyperspy/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperspy/hyperspy/languages","stargazers_url":"https://api.github.com/repos/hyperspy/hyperspy/stargazers","contributors_url":"https://api.github.com/repos/hyperspy/hyperspy/contributors","subscribers_url":"https://api.github.com/repos/hyperspy/hyperspy/subscribers","subscription_url":"https://api.github.com/repos/hyperspy/hyperspy/subscription","commits_url":"https://api.github.com/repos/hyperspy/hyperspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperspy/hyperspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperspy/hyperspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperspy/hyperspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperspy/hyperspy/contents/{+path}","compare_url":"https://api.github.com/repos/hyperspy/hyperspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperspy/hyperspy/merges","archive_url":"https://api.github.com/repos/hyperspy/hyperspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperspy/hyperspy/downloads","issues_url":"https://api.github.com/repos/hyperspy/hyperspy/issues{/number}","pulls_url":"https://api.github.com/repos/hyperspy/hyperspy/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperspy/hyperspy/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperspy/hyperspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperspy/hyperspy/labels{/name}","releases_url":"https://api.github.com/repos/hyperspy/hyperspy/releases{/id}","deployments_url":"https://api.github.com/repos/hyperspy/hyperspy/deployments","created_at":"2011-08-19T13:14:36Z","updated_at":"2016-02-03T08:59:10Z","pushed_at":"2016-02-10T14:37:42Z","git_url":"git://github.com/hyperspy/hyperspy.git","ssh_url":"git@github.com:hyperspy/hyperspy.git","clone_url":"https://github.com/hyperspy/hyperspy.git","svn_url":"https://github.com/hyperspy/hyperspy","homepage":"http://www.hyperspy.org","size":79696,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":141,"forks":38,"open_issues":141,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844"},"html":{"href":"https://github.com/hyperspy/hyperspy/pull/844"},"issue":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/844"},"comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/issues/844/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperspy/hyperspy/pulls/844/commits"},"statuses":{"href":"https://api.github.com/repos/hyperspy/hyperspy/statuses/379043851070ab525e09a95e0d617da2a88a1dc1"}}}}