{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/square/whorlwind/pulls/2","id":64846910,"html_url":"https://github.com/square/whorlwind/pull/2","diff_url":"https://github.com/square/whorlwind/pull/2.diff","patch_url":"https://github.com/square/whorlwind/pull/2.patch","issue_url":"https://api.github.com/repos/square/whorlwind/issues/2","number":2,"state":"closed","locked":false,"title":"Check if subscriber is still subscribed before calling authenticate.","user":{"login":"danh32","id":447085,"avatar_url":"https://avatars.githubusercontent.com/u/447085?v=3","gravatar_id":"","url":"https://api.github.com/users/danh32","html_url":"https://github.com/danh32","followers_url":"https://api.github.com/users/danh32/followers","following_url":"https://api.github.com/users/danh32/following{/other_user}","gists_url":"https://api.github.com/users/danh32/gists{/gist_id}","starred_url":"https://api.github.com/users/danh32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danh32/subscriptions","organizations_url":"https://api.github.com/users/danh32/orgs","repos_url":"https://api.github.com/users/danh32/repos","events_url":"https://api.github.com/users/danh32/events{/privacy}","received_events_url":"https://api.github.com/users/danh32/received_events","type":"User","site_admin":false},"body":"Currently, if the subscriber unsubscribes immediately, whorlwind will call fingerprintManager.authenticate() with an already cancelled CancellationSignal, and won't receive the appropriate callback to reset the `readerScanning` boolean.\r\n\r\nThis just checks the subscription state before making the authenticate call. Note that it's still possible for the subscriber to unsubscribe after this check and before the call to authenticate, but this is a much smaller window and I haven't been able to trigger this case.","created_at":"2016-03-31T19:42:33Z","updated_at":"2016-04-04T15:21:22Z","closed_at":"2016-04-04T15:21:22Z","merged_at":"2016-04-04T15:21:22Z","merge_commit_sha":"1bda9752935e188936d30227fa581b0fe9e925a1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/whorlwind/pulls/2/commits","review_comments_url":"https://api.github.com/repos/square/whorlwind/pulls/2/comments","review_comment_url":"https://api.github.com/repos/square/whorlwind/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/whorlwind/issues/2/comments","statuses_url":"https://api.github.com/repos/square/whorlwind/statuses/608e3d6ab177f7a7e2003eda51a0cbecfe78e9f3","head":{"label":"danh32:subscriber","ref":"subscriber","sha":"608e3d6ab177f7a7e2003eda51a0cbecfe78e9f3","user":{"login":"danh32","id":447085,"avatar_url":"https://avatars.githubusercontent.com/u/447085?v=3","gravatar_id":"","url":"https://api.github.com/users/danh32","html_url":"https://github.com/danh32","followers_url":"https://api.github.com/users/danh32/followers","following_url":"https://api.github.com/users/danh32/following{/other_user}","gists_url":"https://api.github.com/users/danh32/gists{/gist_id}","starred_url":"https://api.github.com/users/danh32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danh32/subscriptions","organizations_url":"https://api.github.com/users/danh32/orgs","repos_url":"https://api.github.com/users/danh32/repos","events_url":"https://api.github.com/users/danh32/events{/privacy}","received_events_url":"https://api.github.com/users/danh32/received_events","type":"User","site_admin":false},"repo":{"id":55174881,"name":"whorlwind","full_name":"danh32/whorlwind","owner":{"login":"danh32","id":447085,"avatar_url":"https://avatars.githubusercontent.com/u/447085?v=3","gravatar_id":"","url":"https://api.github.com/users/danh32","html_url":"https://github.com/danh32","followers_url":"https://api.github.com/users/danh32/followers","following_url":"https://api.github.com/users/danh32/following{/other_user}","gists_url":"https://api.github.com/users/danh32/gists{/gist_id}","starred_url":"https://api.github.com/users/danh32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danh32/subscriptions","organizations_url":"https://api.github.com/users/danh32/orgs","repos_url":"https://api.github.com/users/danh32/repos","events_url":"https://api.github.com/users/danh32/events{/privacy}","received_events_url":"https://api.github.com/users/danh32/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danh32/whorlwind","description":"Makes fingerprint encryption a breeze.","fork":true,"url":"https://api.github.com/repos/danh32/whorlwind","forks_url":"https://api.github.com/repos/danh32/whorlwind/forks","keys_url":"https://api.github.com/repos/danh32/whorlwind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danh32/whorlwind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danh32/whorlwind/teams","hooks_url":"https://api.github.com/repos/danh32/whorlwind/hooks","issue_events_url":"https://api.github.com/repos/danh32/whorlwind/issues/events{/number}","events_url":"https://api.github.com/repos/danh32/whorlwind/events","assignees_url":"https://api.github.com/repos/danh32/whorlwind/assignees{/user}","branches_url":"https://api.github.com/repos/danh32/whorlwind/branches{/branch}","tags_url":"https://api.github.com/repos/danh32/whorlwind/tags","blobs_url":"https://api.github.com/repos/danh32/whorlwind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danh32/whorlwind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danh32/whorlwind/git/refs{/sha}","trees_url":"https://api.github.com/repos/danh32/whorlwind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danh32/whorlwind/statuses/{sha}","languages_url":"https://api.github.com/repos/danh32/whorlwind/languages","stargazers_url":"https://api.github.com/repos/danh32/whorlwind/stargazers","contributors_url":"https://api.github.com/repos/danh32/whorlwind/contributors","subscribers_url":"https://api.github.com/repos/danh32/whorlwind/subscribers","subscription_url":"https://api.github.com/repos/danh32/whorlwind/subscription","commits_url":"https://api.github.com/repos/danh32/whorlwind/commits{/sha}","git_commits_url":"https://api.github.com/repos/danh32/whorlwind/git/commits{/sha}","comments_url":"https://api.github.com/repos/danh32/whorlwind/comments{/number}","issue_comment_url":"https://api.github.com/repos/danh32/whorlwind/issues/comments{/number}","contents_url":"https://api.github.com/repos/danh32/whorlwind/contents/{+path}","compare_url":"https://api.github.com/repos/danh32/whorlwind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danh32/whorlwind/merges","archive_url":"https://api.github.com/repos/danh32/whorlwind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danh32/whorlwind/downloads","issues_url":"https://api.github.com/repos/danh32/whorlwind/issues{/number}","pulls_url":"https://api.github.com/repos/danh32/whorlwind/pulls{/number}","milestones_url":"https://api.github.com/repos/danh32/whorlwind/milestones{/number}","notifications_url":"https://api.github.com/repos/danh32/whorlwind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danh32/whorlwind/labels{/name}","releases_url":"https://api.github.com/repos/danh32/whorlwind/releases{/id}","deployments_url":"https://api.github.com/repos/danh32/whorlwind/deployments","created_at":"2016-03-31T18:47:54Z","updated_at":"2016-03-31T18:47:55Z","pushed_at":"2016-03-31T22:30:24Z","git_url":"git://github.com/danh32/whorlwind.git","ssh_url":"git@github.com:danh32/whorlwind.git","clone_url":"https://github.com/danh32/whorlwind.git","svn_url":"https://github.com/danh32/whorlwind","homepage":null,"size":132,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"6696fbc2acbb491e0b7e8a9e5113ad75ba090e5e","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":53430304,"name":"whorlwind","full_name":"square/whorlwind","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/whorlwind","description":"Makes fingerprint encryption a breeze.","fork":false,"url":"https://api.github.com/repos/square/whorlwind","forks_url":"https://api.github.com/repos/square/whorlwind/forks","keys_url":"https://api.github.com/repos/square/whorlwind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/whorlwind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/whorlwind/teams","hooks_url":"https://api.github.com/repos/square/whorlwind/hooks","issue_events_url":"https://api.github.com/repos/square/whorlwind/issues/events{/number}","events_url":"https://api.github.com/repos/square/whorlwind/events","assignees_url":"https://api.github.com/repos/square/whorlwind/assignees{/user}","branches_url":"https://api.github.com/repos/square/whorlwind/branches{/branch}","tags_url":"https://api.github.com/repos/square/whorlwind/tags","blobs_url":"https://api.github.com/repos/square/whorlwind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/whorlwind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/whorlwind/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/whorlwind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/whorlwind/statuses/{sha}","languages_url":"https://api.github.com/repos/square/whorlwind/languages","stargazers_url":"https://api.github.com/repos/square/whorlwind/stargazers","contributors_url":"https://api.github.com/repos/square/whorlwind/contributors","subscribers_url":"https://api.github.com/repos/square/whorlwind/subscribers","subscription_url":"https://api.github.com/repos/square/whorlwind/subscription","commits_url":"https://api.github.com/repos/square/whorlwind/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/whorlwind/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/whorlwind/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/whorlwind/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/whorlwind/contents/{+path}","compare_url":"https://api.github.com/repos/square/whorlwind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/whorlwind/merges","archive_url":"https://api.github.com/repos/square/whorlwind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/whorlwind/downloads","issues_url":"https://api.github.com/repos/square/whorlwind/issues{/number}","pulls_url":"https://api.github.com/repos/square/whorlwind/pulls{/number}","milestones_url":"https://api.github.com/repos/square/whorlwind/milestones{/number}","notifications_url":"https://api.github.com/repos/square/whorlwind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/whorlwind/labels{/name}","releases_url":"https://api.github.com/repos/square/whorlwind/releases{/id}","deployments_url":"https://api.github.com/repos/square/whorlwind/deployments","created_at":"2016-03-08T17:09:18Z","updated_at":"2016-04-04T03:59:40Z","pushed_at":"2016-04-04T15:21:22Z","git_url":"git://github.com/square/whorlwind.git","ssh_url":"git@github.com:square/whorlwind.git","clone_url":"https://github.com/square/whorlwind.git","svn_url":"https://github.com/square/whorlwind","homepage":null,"size":129,"stargazers_count":387,"watchers_count":387,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":1,"forks":14,"open_issues":1,"watchers":387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/whorlwind/pulls/2"},"html":{"href":"https://github.com/square/whorlwind/pull/2"},"issue":{"href":"https://api.github.com/repos/square/whorlwind/issues/2"},"comments":{"href":"https://api.github.com/repos/square/whorlwind/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/square/whorlwind/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/square/whorlwind/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/whorlwind/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/square/whorlwind/statuses/608e3d6ab177f7a7e2003eda51a0cbecfe78e9f3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattprecious","id":333672,"avatar_url":"https://avatars.githubusercontent.com/u/333672?v=3","gravatar_id":"","url":"https://api.github.com/users/mattprecious","html_url":"https://github.com/mattprecious","followers_url":"https://api.github.com/users/mattprecious/followers","following_url":"https://api.github.com/users/mattprecious/following{/other_user}","gists_url":"https://api.github.com/users/mattprecious/gists{/gist_id}","starred_url":"https://api.github.com/users/mattprecious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattprecious/subscriptions","organizations_url":"https://api.github.com/users/mattprecious/orgs","repos_url":"https://api.github.com/users/mattprecious/repos","events_url":"https://api.github.com/users/mattprecious/events{/privacy}","received_events_url":"https://api.github.com/users/mattprecious/received_events","type":"User","site_admin":false},"comments":23,"review_comments":2,"commits":3,"additions":43,"deletions":0,"changed_files":2}}