{"action":"closed","number":15002,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15002","id":57014548,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15002","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15002.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15002.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15002","number":15002,"state":"closed","locked":false,"title":"Magazine implementation: weapons added by Chaosvolt","user":{"login":"chaosvolt","id":11582235,"avatar_url":"https://avatars.githubusercontent.com/u/11582235?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosvolt","html_url":"https://github.com/chaosvolt","followers_url":"https://api.github.com/users/chaosvolt/followers","following_url":"https://api.github.com/users/chaosvolt/following{/other_user}","gists_url":"https://api.github.com/users/chaosvolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosvolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosvolt/subscriptions","organizations_url":"https://api.github.com/users/chaosvolt/orgs","repos_url":"https://api.github.com/users/chaosvolt/repos","events_url":"https://api.github.com/users/chaosvolt/events{/privacy}","received_events_url":"https://api.github.com/users/chaosvolt/received_events","type":"User","site_admin":false},"body":"Now that https://github.com/CleverRaven/Cataclysm-DDA/pull/14949 is a thing, went ahead and started expanding on the magazine options, focusing on weapons I've added. It's a start, so far. o3o\r\n\r\n* Adds magazines for the Browning Automatic Rifle. Standard capacity is 20 rounds, and 30-round variants exist as well.\r\n* Magazines added for AK-74 and AN-94. Currently has the standard 30-rounder and the RPK-74 45-round mag. Which will also be useful if we ever add RPKs.\r\n* M60 and M240 given the M13 link, disintegrating belt. DM1 belt also given to the M240 as a reusable alternative.\r\n* Makarov given the classic 8-round mag. 10 and 12-round magazines are made for the newer PMM, so for now there's only PM mags.\r\n* Magazines given to both variants of the Skorpion.\r\n* Thompson given 20, 30, and 50-round magazines. Note the what model the game's Thompson is based off of is vague, and note that M1 and M1A1 Thompsons did not accept drum mags.\r\n* Sten given its standard 32-round mag, along with a craftable magazine in the same vein as the survivor .223 magazine. Reduced capacity as it isn't double-column, but still lower reliability. If we ever have makeshift, magazine-fed 9mm weapons, this might be the logical choice for it.\r\n* Itemgroup patterns established based on PRs adding mags to item groups. Not entirely sure where else they might go, or exact recommended odds.\r\n\r\nM1 Garand left untouched because we don't yet have a way to make a gun automatically unload an en-bloc clip when emptied.\r\n\r\nA couple flags will be unused until https://github.com/CleverRaven/Cataclysm-DDA/pull/14972 is merged, but it isn't a strict prerequisite to this PR.","created_at":"2016-01-24T21:35:29Z","updated_at":"2016-01-29T18:01:51Z","closed_at":"2016-01-29T18:01:51Z","merged_at":null,"merge_commit_sha":"a8ff64fe06feeb7e814d79dbc61076d36fdb98c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15002/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15002/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15002/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/69ff6f7af6c1225662f8c5a50d9a2bed8ee4c3ac","head":{"label":"chaosvolt:chaosvolt-gunazines","ref":"chaosvolt-gunazines","sha":"69ff6f7af6c1225662f8c5a50d9a2bed8ee4c3ac","user":{"login":"chaosvolt","id":11582235,"avatar_url":"https://avatars.githubusercontent.com/u/11582235?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosvolt","html_url":"https://github.com/chaosvolt","followers_url":"https://api.github.com/users/chaosvolt/followers","following_url":"https://api.github.com/users/chaosvolt/following{/other_user}","gists_url":"https://api.github.com/users/chaosvolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosvolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosvolt/subscriptions","organizations_url":"https://api.github.com/users/chaosvolt/orgs","repos_url":"https://api.github.com/users/chaosvolt/repos","events_url":"https://api.github.com/users/chaosvolt/events{/privacy}","received_events_url":"https://api.github.com/users/chaosvolt/received_events","type":"User","site_admin":false},"repo":{"id":32621856,"name":"Cataclysm-DDA","full_name":"chaosvolt/Cataclysm-DDA","owner":{"login":"chaosvolt","id":11582235,"avatar_url":"https://avatars.githubusercontent.com/u/11582235?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosvolt","html_url":"https://github.com/chaosvolt","followers_url":"https://api.github.com/users/chaosvolt/followers","following_url":"https://api.github.com/users/chaosvolt/following{/other_user}","gists_url":"https://api.github.com/users/chaosvolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosvolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosvolt/subscriptions","organizations_url":"https://api.github.com/users/chaosvolt/orgs","repos_url":"https://api.github.com/users/chaosvolt/repos","events_url":"https://api.github.com/users/chaosvolt/events{/privacy}","received_events_url":"https://api.github.com/users/chaosvolt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaosvolt/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA","forks_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/chaosvolt/Cataclysm-DDA/deployments","created_at":"2015-03-21T05:58:31Z","updated_at":"2016-01-11T22:18:36Z","pushed_at":"2016-01-29T03:50:14Z","git_url":"git://github.com/chaosvolt/Cataclysm-DDA.git","ssh_url":"git@github.com:chaosvolt/Cataclysm-DDA.git","clone_url":"https://github.com/chaosvolt/Cataclysm-DDA.git","svn_url":"https://github.com/chaosvolt/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":690429,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"77474188c62673ab186528e80e7d9074bbc5590e","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-01-29T00:40:05Z","pushed_at":"2016-01-29T17:36:11Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":937240,"stargazers_count":859,"watchers_count":859,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":846,"mirror_url":null,"open_issues_count":1267,"forks":846,"open_issues":1267,"watchers":859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15002"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15002"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15002"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15002/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15002/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15002/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/69ff6f7af6c1225662f8c5a50d9a2bed8ee4c3ac"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":30,"review_comments":24,"commits":10,"additions":393,"deletions":33,"changed_files":4}}