{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/8856","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/8856/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/8856/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/8856/events","html_url":"https://github.com/openshift/origin/pull/8856","id":154452702,"number":8856,"title":"Rebase","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":53,"created_at":"2016-05-12T10:48:00Z","updated_at":"2016-06-15T18:20:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/8856","html_url":"https://github.com/openshift/origin/pull/8856","diff_url":"https://github.com/openshift/origin/pull/8856.diff","patch_url":"https://github.com/openshift/origin/pull/8856.patch"},"body":"Kubernetes fork PR: https://github.com/openshift/kubernetes/pull/19\r\nRemaining work for this PR:\r\n\r\n- [x] Fix `Godeps/Godeps.json` (must be generated for **each** UPSTREAM commit)\r\n- [x] If we have https://github.com/kubernetes/kubernetes/pull/23795, we picked up a couple important bugs https://github.com/kubernetes/kubernetes/pull/25671 and https://github.com/kubernetes/kubernetes/pull/25669\r\n- [x] pick https://github.com/kubernetes/kubernetes/pull/21373\r\n- [x] The `update-generated-conversions` script is broken\r\n- [x] Fix compilation\r\n- [x] Fix broken template unit test (`pkg/template`)\r\n- [x] Fix integration: `sa_oauthclient_test.go:165: unexpected error: Missing configuration`\r\n- [x] Fix integration: `storage_versions_test.go:117: batch: expected api version extensions/v1beta1 in etcd, got batch/v1, Kind=Job reading Job`\r\n- [x] Fix E2E tests\r\n- [x] Fix https://github.com/coreos/etcd/issues/5558\r\n- [ ] The `RateLimiter` needs a fuzzer in master config test\r\n\r\nFixes: https://github.com/openshift/origin/issues/4398\r\nFixes: https://github.com/openshift/origin/issues/9314\r\n\r\nFollow ups / good to know:\r\n\r\n- ~~The new `generic.Decorator{}` now takes the `cacheSize` argument. I hardcoded it to `100` but this should be configurable from the master config (or we should at least have map with resources and set the numbers there, in one place)~~ using `genericapiserver.DefaultDeserializationCacheSize`\r\n- The `iptables.NewProxier()` now takes extra `c.ClusterCIDR` argument. This should be configurable as well (current set to empty string which means no off-cluster bridging will be performed) \r\n- Kubernetes is now using https://github.com/docker/engine-api instead of https://github.com/fsouza/go-dockerclient and they of course have incompatible interfaces. I created a simple wrapper for the engine-api client: https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-f2e698c988010fe8fd27effa4c84a80eR41 but we should consider switching to engine-api client as well.\r\n- If we have https://github.com/kubernetes/kubernetes/pull/23795, we picked up a couple important bugs https://github.com/kubernetes/kubernetes/pull/25671 and https://github.com/kubernetes/kubernetes/pull/25669 .\r\n- [x] Follow up with updating `ktestclient.Action` to `core.Action` to reflect upstream changes\r\n- [x] Follow up on migrating go-dockerclient to engine-api (need to disable newapp integration test) - https://github.com/openshift/origin/issues/9320\r\n- [ ] Follow up to update describers to honor ShowEvents setting\r\n- [x] Follow up to remove go-dockerclient wherever it makes sense to use docker/engine-api - https://github.com/openshift/origin/issues/9320\r\n- [x] Follow up to bring the go-dockerclient up to date with tokens (https://github.com/openshift/origin/pull/8856#discussion_r63395988) - https://github.com/openshift/origin/issues/9320\r\n- [x] Follow up to fix DOCKER_HOST workaround on OS X - @csrwng - https://github.com/openshift/origin/issues/9320\r\n- [ ] Follow up to make quota evaluators configurable (https://github.com/openshift/origin/pull/8856#discussion_r63371028)\r\n- [ ] Use shared informers when starting controllers\r\n- [ ] improve genconversion to catch new API packages missing conversions\r\n\r\nAs @smarterclayton noted, this rebase might require go-1.6, but I can see this builds fine on 1.5 as well.\r\n\r\nImportant changes that should be reviewed:\r\n\r\n- [x] https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-05523003a782d7b3b61c2608a29dfb39R228 (as the StorageDestination is no more)\r\n- [x] https://github.com/openshift/origin/pull/8856/commits/7b5a27a88303e5b1ccedd5c840f4628c9736547e#diff-90ac63ed95fc5a187e3347f9cded16cbR84 (and friends... what happened is that kube now use `credentialprovider.LazyAuthConfiguration` which is not compatible with `docker.AuthConfiguration`. I will add some nicer wrapper for these.\r\n- [ ] https://github.com/openshift/origin/pull/8856/commits/06396fd50e7c5dc3ffbb6afae7ee899c89a95b08#diff-adefa6892d6212c6873413c96b805bb3R258 as I don't really know how much important is this method for SDN"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/226275108","html_url":"https://github.com/openshift/origin/pull/8856#issuecomment-226275108","issue_url":"https://api.github.com/repos/openshift/origin/issues/8856","id":226275108,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T18:20:47Z","updated_at":"2016-06-15T18:20:47Z","body":"Evaluated for origin test up to fcbb18abf022c7ac13f9295f769fd4e66a75e3ff"}}
{"actor":{"display_login":"openshift-bot"}}