{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/8270","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/8270/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/8270/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/8270/events","html_url":"https://github.com/grpc/grpc/pull/8270","id":180800376,"number":8270,"title":"Correctly count port indices and siblings.","user":{"login":"daniel-j-born","id":13909816,"avatar_url":"https://avatars.githubusercontent.com/u/13909816?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-born","html_url":"https://github.com/daniel-j-born","followers_url":"https://api.github.com/users/daniel-j-born/followers","following_url":"https://api.github.com/users/daniel-j-born/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-born/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-born/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-born/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-born/orgs","repos_url":"https://api.github.com/users/daniel-j-born/repos","events_url":"https://api.github.com/users/daniel-j-born/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-born/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/grpc/grpc/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"assignees":[{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-10-04T03:53:06Z","updated_at":"2016-10-20T20:31:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/8270","html_url":"https://github.com/grpc/grpc/pull/8270","diff_url":"https://github.com/grpc/grpc/pull/8270.diff","patch_url":"https://github.com/grpc/grpc/pull/8270.patch"},"body":"In the old code, the check for \"port_index != 0\" and \"--port_index\" is a bug: we want to advance to the next non-sibling grpc_tcp_listener* to get the batch for port_index, rather than just the next grpc_tcp_listener*. get_port_index() is the correct way.\r\n\r\nThis was easier to test in PR#7047, because it created many listeners at the same port. The current test coverage isn't great, because the test creates no siblings, but tcp_server_posix_test.c has some coverage.\r\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/255219481","html_url":"https://github.com/grpc/grpc/pull/8270#issuecomment-255219481","issue_url":"https://api.github.com/repos/grpc/grpc/issues/8270","id":255219481,"user":{"login":"y-zeng","id":17460127,"avatar_url":"https://avatars.githubusercontent.com/u/17460127?v=3","gravatar_id":"","url":"https://api.github.com/users/y-zeng","html_url":"https://github.com/y-zeng","followers_url":"https://api.github.com/users/y-zeng/followers","following_url":"https://api.github.com/users/y-zeng/following{/other_user}","gists_url":"https://api.github.com/users/y-zeng/gists{/gist_id}","starred_url":"https://api.github.com/users/y-zeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/y-zeng/subscriptions","organizations_url":"https://api.github.com/users/y-zeng/orgs","repos_url":"https://api.github.com/users/y-zeng/repos","events_url":"https://api.github.com/users/y-zeng/events{/privacy}","received_events_url":"https://api.github.com/users/y-zeng/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T20:31:05Z","updated_at":"2016-10-20T20:31:05Z","body":"Test failures seem unrelated."}}
{"actor":{"display_login":"y-zeng"}}