{"action":"closed","number":980,"pull_request":{"url":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/980","id":81493188,"html_url":"https://github.com/Financial-Times/next-front-page/pull/980","diff_url":"https://github.com/Financial-Times/next-front-page/pull/980.diff","patch_url":"https://github.com/Financial-Times/next-front-page/pull/980.patch","issue_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980","number":980,"state":"closed","locked":false,"title":"Dictate: Life & Arts layout + position by time of week","user":{"login":"andygout","id":10484515,"avatar_url":"https://avatars.githubusercontent.com/u/10484515?v=3","gravatar_id":"","url":"https://api.github.com/users/andygout","html_url":"https://github.com/andygout","followers_url":"https://api.github.com/users/andygout/followers","following_url":"https://api.github.com/users/andygout/following{/other_user}","gists_url":"https://api.github.com/users/andygout/gists{/gist_id}","starred_url":"https://api.github.com/users/andygout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygout/subscriptions","organizations_url":"https://api.github.com/users/andygout/orgs","repos_url":"https://api.github.com/users/andygout/repos","events_url":"https://api.github.com/users/andygout/events{/privacy}","received_events_url":"https://api.github.com/users/andygout/received_events","type":"User","site_admin":false},"body":"cc @andygnewman @ironsidevsquincy \r\n\r\nI have positioned the weekend version of the component above Most Popular purely to indicate that it will need to be in a different position to the mid-week version and that this logic needs to be done at this stage; the actual positions are still TBC.\r\n\r\nI seem to be duplicating files and wonder if better to: extract the code that decides if it is the weekend period and use in [`config/pages.js`](https://github.com/Financial-Times/next-front-page/blob/life-arts-component-time-dependent/config/pages.js#L92-L93) to decide the component's position and again in [`config/sections/index.js`](https://github.com/Financial-Times/next-front-page/blob/life-arts-component-time-dependent/config/sections/index.js#L41), giving that `isWeekendPeriod` value via an extra `opts` argument to dictate in a single [`life-and-arts` section file](https://github.com/Financial-Times/next-front-page/blob/life-arts-component-time-dependent/config/sections/life-and-arts-week.js#L5) which of the two `layoutId`s to apply (although it's possible that the two variants will eventually require differing section attributes and therefore separate files).\r\n\r\nOnce merged: \r\n- [ ] Change flag to on/off (currently has variants).","created_at":"2016-08-16T15:32:27Z","updated_at":"2016-08-17T13:46:01Z","closed_at":"2016-08-17T13:46:01Z","merged_at":"2016-08-17T13:46:01Z","merge_commit_sha":"14842868f4fae92f01a36064016289ee5788f285","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/980/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/980/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980/comments","statuses_url":"https://api.github.com/repos/Financial-Times/next-front-page/statuses/1e08527503e45ccb9e0b1178698cb610614bdff5","head":{"label":"Financial-Times:life-arts-component-time-dependent","ref":"life-arts-component-time-dependent","sha":"1e08527503e45ccb9e0b1178698cb610614bdff5","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":37079565,"name":"next-front-page","full_name":"Financial-Times/next-front-page","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/next-front-page","description":"Next FT front page","fork":false,"url":"https://api.github.com/repos/Financial-Times/next-front-page","forks_url":"https://api.github.com/repos/Financial-Times/next-front-page/forks","keys_url":"https://api.github.com/repos/Financial-Times/next-front-page/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/next-front-page/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/next-front-page/teams","hooks_url":"https://api.github.com/repos/Financial-Times/next-front-page/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/next-front-page/events","assignees_url":"https://api.github.com/repos/Financial-Times/next-front-page/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/next-front-page/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/next-front-page/tags","blobs_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/next-front-page/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/next-front-page/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/next-front-page/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/next-front-page/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/next-front-page/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/next-front-page/subscription","commits_url":"https://api.github.com/repos/Financial-Times/next-front-page/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/next-front-page/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/next-front-page/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/next-front-page/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/next-front-page/merges","archive_url":"https://api.github.com/repos/Financial-Times/next-front-page/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/next-front-page/downloads","issues_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/next-front-page/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/next-front-page/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/next-front-page/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/next-front-page/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/next-front-page/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/next-front-page/deployments","created_at":"2015-06-08T16:43:12Z","updated_at":"2016-08-13T14:13:00Z","pushed_at":"2016-08-17T13:46:01Z","git_url":"git://github.com/Financial-Times/next-front-page.git","ssh_url":"git@github.com:Financial-Times/next-front-page.git","clone_url":"https://github.com/Financial-Times/next-front-page.git","svn_url":"https://github.com/Financial-Times/next-front-page","homepage":"","size":2159,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":40,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"c2f9992b3564bbbe7243a5dba2b94b6f65f16433","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":37079565,"name":"next-front-page","full_name":"Financial-Times/next-front-page","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/next-front-page","description":"Next FT front page","fork":false,"url":"https://api.github.com/repos/Financial-Times/next-front-page","forks_url":"https://api.github.com/repos/Financial-Times/next-front-page/forks","keys_url":"https://api.github.com/repos/Financial-Times/next-front-page/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/next-front-page/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/next-front-page/teams","hooks_url":"https://api.github.com/repos/Financial-Times/next-front-page/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/next-front-page/events","assignees_url":"https://api.github.com/repos/Financial-Times/next-front-page/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/next-front-page/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/next-front-page/tags","blobs_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/next-front-page/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/next-front-page/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/next-front-page/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/next-front-page/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/next-front-page/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/next-front-page/subscription","commits_url":"https://api.github.com/repos/Financial-Times/next-front-page/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/next-front-page/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/next-front-page/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/next-front-page/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/next-front-page/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/next-front-page/merges","archive_url":"https://api.github.com/repos/Financial-Times/next-front-page/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/next-front-page/downloads","issues_url":"https://api.github.com/repos/Financial-Times/next-front-page/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/next-front-page/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/next-front-page/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/next-front-page/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/next-front-page/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/next-front-page/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/next-front-page/deployments","created_at":"2015-06-08T16:43:12Z","updated_at":"2016-08-13T14:13:00Z","pushed_at":"2016-08-17T13:46:01Z","git_url":"git://github.com/Financial-Times/next-front-page.git","ssh_url":"git@github.com:Financial-Times/next-front-page.git","clone_url":"https://github.com/Financial-Times/next-front-page.git","svn_url":"https://github.com/Financial-Times/next-front-page","homepage":"","size":2159,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/980"},"html":{"href":"https://github.com/Financial-Times/next-front-page/pull/980"},"issue":{"href":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980"},"comments":{"href":"https://api.github.com/repos/Financial-Times/next-front-page/issues/980/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/980/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/next-front-page/pulls/980/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/next-front-page/statuses/1e08527503e45ccb9e0b1178698cb610614bdff5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"andygout","id":10484515,"avatar_url":"https://avatars.githubusercontent.com/u/10484515?v=3","gravatar_id":"","url":"https://api.github.com/users/andygout","html_url":"https://github.com/andygout","followers_url":"https://api.github.com/users/andygout/followers","following_url":"https://api.github.com/users/andygout/following{/other_user}","gists_url":"https://api.github.com/users/andygout/gists{/gist_id}","starred_url":"https://api.github.com/users/andygout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygout/subscriptions","organizations_url":"https://api.github.com/users/andygout/orgs","repos_url":"https://api.github.com/users/andygout/repos","events_url":"https://api.github.com/users/andygout/events{/privacy}","received_events_url":"https://api.github.com/users/andygout/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":2,"additions":23,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"andygout"}}