{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-object-store/pulls/comments/92478801","pull_request_review_id":12995371,"id":92478801,"diff_hunk":"@@ -342,10 +391,15 @@ endfunction()\n \n function(clone_and_build_realm_sync branch)\n     set(cmake_files ${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY})\n+    if(REALM_PLATFORM STREQUAL \"Android\")\n+        set(CONFIG_CMD, rm -f src/config.mk && REALM_CORE_PREFIX=${cmake_files}/realm-core/src/realm-core REALM_FORCE_OPENSSL=YES REALM_ENABLE_ENCRYPTION=YES REALM_ENABLE_ASSERTIONS= sh build.sh config && echo \"ENABLE_ENCRYPTION    = yes\" >> src/config.mk)","path":"CMake/RealmCore.cmake","position":null,"original_position":168,"commit_id":"635335ba814e1edca05c001e4f8b6fab1415fcd1","original_commit_id":"539b4d23d31c8ccf95ef2babf9d12929ed39d69b","user":{"login":"bdash","id":54825,"avatar_url":"https://avatars.githubusercontent.com/u/54825?v=3","gravatar_id":"","url":"https://api.github.com/users/bdash","html_url":"https://github.com/bdash","followers_url":"https://api.github.com/users/bdash/followers","following_url":"https://api.github.com/users/bdash/following{/other_user}","gists_url":"https://api.github.com/users/bdash/gists{/gist_id}","starred_url":"https://api.github.com/users/bdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdash/subscriptions","organizations_url":"https://api.github.com/users/bdash/orgs","repos_url":"https://api.github.com/users/bdash/repos","events_url":"https://api.github.com/users/bdash/events{/privacy}","received_events_url":"https://api.github.com/users/bdash/received_events","type":"User","site_admin":false},"body":"I can't see how adding `ENABLE_ENCRYPTION` to `src/config.mk` could possibly be required. No variable of that name is ever referenced in the realm-sync codebase. Whether or not encryption is enabled is determined solely by core's configuration.","created_at":"2016-12-14T20:10:57Z","updated_at":"2016-12-14T20:10:57Z","html_url":"https://github.com/realm/realm-object-store/pull/287#discussion_r92478801","pull_request_url":"https://api.github.com/repos/realm/realm-object-store/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/comments/92478801"},"html":{"href":"https://github.com/realm/realm-object-store/pull/287#discussion_r92478801"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-object-store/pulls/287","id":97129791,"html_url":"https://github.com/realm/realm-object-store/pull/287","diff_url":"https://github.com/realm/realm-object-store/pull/287.diff","patch_url":"https://github.com/realm/realm-object-store/pull/287.patch","issue_url":"https://api.github.com/repos/realm/realm-object-store/issues/287","number":287,"state":"open","locked":false,"title":"Getting ready to merge realm-java into master","user":{"login":"kneth","id":1225363,"avatar_url":"https://avatars.githubusercontent.com/u/1225363?v=3","gravatar_id":"","url":"https://api.github.com/users/kneth","html_url":"https://github.com/kneth","followers_url":"https://api.github.com/users/kneth/followers","following_url":"https://api.github.com/users/kneth/following{/other_user}","gists_url":"https://api.github.com/users/kneth/gists{/gist_id}","starred_url":"https://api.github.com/users/kneth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneth/subscriptions","organizations_url":"https://api.github.com/users/kneth/orgs","repos_url":"https://api.github.com/users/kneth/repos","events_url":"https://api.github.com/users/kneth/events{/privacy}","received_events_url":"https://api.github.com/users/kneth/received_events","type":"User","site_admin":false},"body":"Instead of polluting `realm-java`, I have create a new branch. Almost except one unit test is working. The remaining failing test is cause by how core uses `mkdtemp` (see also https://code.google.com/p/android/issues/detail?id=74497) but I will make a workaround later. There are still a few issue with linking but I can link manually so I will fix that later too.\r\n\r\nPlease give me some feedback on the CMake parts of this PR - and only that.\r\n\r\nDependencies\r\n * https://github.com/realm/realm-core/pull/2355\r\n * https://github.com/realm/realm-sync/pull/1027\r\n\r\n@cmelchior @emanuelez @bdash @radu-tutueanu ","created_at":"2016-12-08T14:18:22Z","updated_at":"2016-12-14T20:10:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c08a32e25db29508489a6c395d87c309074a09f","assignee":{"login":"kneth","id":1225363,"avatar_url":"https://avatars.githubusercontent.com/u/1225363?v=3","gravatar_id":"","url":"https://api.github.com/users/kneth","html_url":"https://github.com/kneth","followers_url":"https://api.github.com/users/kneth/followers","following_url":"https://api.github.com/users/kneth/following{/other_user}","gists_url":"https://api.github.com/users/kneth/gists{/gist_id}","starred_url":"https://api.github.com/users/kneth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneth/subscriptions","organizations_url":"https://api.github.com/users/kneth/orgs","repos_url":"https://api.github.com/users/kneth/repos","events_url":"https://api.github.com/users/kneth/events{/privacy}","received_events_url":"https://api.github.com/users/kneth/received_events","type":"User","site_admin":false},"assignees":[{"login":"kneth","id":1225363,"avatar_url":"https://avatars.githubusercontent.com/u/1225363?v=3","gravatar_id":"","url":"https://api.github.com/users/kneth","html_url":"https://github.com/kneth","followers_url":"https://api.github.com/users/kneth/followers","following_url":"https://api.github.com/users/kneth/following{/other_user}","gists_url":"https://api.github.com/users/kneth/gists{/gist_id}","starred_url":"https://api.github.com/users/kneth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneth/subscriptions","organizations_url":"https://api.github.com/users/kneth/orgs","repos_url":"https://api.github.com/users/kneth/repos","events_url":"https://api.github.com/users/kneth/events{/privacy}","received_events_url":"https://api.github.com/users/kneth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-object-store/pulls/287/commits","review_comments_url":"https://api.github.com/repos/realm/realm-object-store/pulls/287/comments","review_comment_url":"https://api.github.com/repos/realm/realm-object-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-object-store/issues/287/comments","statuses_url":"https://api.github.com/repos/realm/realm-object-store/statuses/635335ba814e1edca05c001e4f8b6fab1415fcd1","head":{"label":"realm:kneth/realm-java","ref":"kneth/realm-java","sha":"635335ba814e1edca05c001e4f8b6fab1415fcd1","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":36953657,"name":"realm-object-store","full_name":"realm/realm-object-store","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-object-store","description":"Cross-platform abstractions used within Realm products","fork":false,"url":"https://api.github.com/repos/realm/realm-object-store","forks_url":"https://api.github.com/repos/realm/realm-object-store/forks","keys_url":"https://api.github.com/repos/realm/realm-object-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-object-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-object-store/teams","hooks_url":"https://api.github.com/repos/realm/realm-object-store/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-object-store/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-object-store/events","assignees_url":"https://api.github.com/repos/realm/realm-object-store/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-object-store/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-object-store/tags","blobs_url":"https://api.github.com/repos/realm/realm-object-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-object-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-object-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-object-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-object-store/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-object-store/languages","stargazers_url":"https://api.github.com/repos/realm/realm-object-store/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-object-store/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-object-store/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-object-store/subscription","commits_url":"https://api.github.com/repos/realm/realm-object-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-object-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-object-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-object-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-object-store/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-object-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-object-store/merges","archive_url":"https://api.github.com/repos/realm/realm-object-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-object-store/downloads","issues_url":"https://api.github.com/repos/realm/realm-object-store/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-object-store/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-object-store/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-object-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-object-store/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-object-store/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-object-store/deployments","created_at":"2015-06-05T20:21:52Z","updated_at":"2016-12-04T18:12:40Z","pushed_at":"2016-12-14T19:37:21Z","git_url":"git://github.com/realm/realm-object-store.git","ssh_url":"git@github.com:realm/realm-object-store.git","clone_url":"https://github.com/realm/realm-object-store.git","svn_url":"https://github.com/realm/realm-object-store","homepage":"https://realm.io","size":1550,"stargazers_count":48,"watchers_count":48,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":30,"forks":6,"open_issues":30,"watchers":48,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"178888ab7581ad262ed483b259784fa453fc5431","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":36953657,"name":"realm-object-store","full_name":"realm/realm-object-store","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-object-store","description":"Cross-platform abstractions used within Realm products","fork":false,"url":"https://api.github.com/repos/realm/realm-object-store","forks_url":"https://api.github.com/repos/realm/realm-object-store/forks","keys_url":"https://api.github.com/repos/realm/realm-object-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-object-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-object-store/teams","hooks_url":"https://api.github.com/repos/realm/realm-object-store/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-object-store/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-object-store/events","assignees_url":"https://api.github.com/repos/realm/realm-object-store/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-object-store/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-object-store/tags","blobs_url":"https://api.github.com/repos/realm/realm-object-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-object-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-object-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-object-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-object-store/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-object-store/languages","stargazers_url":"https://api.github.com/repos/realm/realm-object-store/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-object-store/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-object-store/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-object-store/subscription","commits_url":"https://api.github.com/repos/realm/realm-object-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-object-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-object-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-object-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-object-store/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-object-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-object-store/merges","archive_url":"https://api.github.com/repos/realm/realm-object-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-object-store/downloads","issues_url":"https://api.github.com/repos/realm/realm-object-store/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-object-store/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-object-store/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-object-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-object-store/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-object-store/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-object-store/deployments","created_at":"2015-06-05T20:21:52Z","updated_at":"2016-12-04T18:12:40Z","pushed_at":"2016-12-14T19:37:21Z","git_url":"git://github.com/realm/realm-object-store.git","ssh_url":"git@github.com:realm/realm-object-store.git","clone_url":"https://github.com/realm/realm-object-store.git","svn_url":"https://github.com/realm/realm-object-store","homepage":"https://realm.io","size":1550,"stargazers_count":48,"watchers_count":48,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":30,"forks":6,"open_issues":30,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/287"},"html":{"href":"https://github.com/realm/realm-object-store/pull/287"},"issue":{"href":"https://api.github.com/repos/realm/realm-object-store/issues/287"},"comments":{"href":"https://api.github.com/repos/realm/realm-object-store/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-object-store/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-object-store/statuses/635335ba814e1edca05c001e4f8b6fab1415fcd1"}}}}
{"actor":{"display_login":"bdash"}}