{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/14935","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/14935/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/14935/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/14935/events","html_url":"https://github.com/pandas-dev/pandas/pull/14935","id":196843270,"number":14935,"title":"BUG: Patch rank() uint64 behavior","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"labels":[{"id":31404521,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Dtypes","name":"Dtypes","color":"e102d8","default":false},{"id":47223669,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Numeric","name":"Numeric","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-21T04:25:45Z","updated_at":"2016-12-22T07:31:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/14935","html_url":"https://github.com/pandas-dev/pandas/pull/14935","diff_url":"https://github.com/pandas-dev/pandas/pull/14935.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/14935.patch"},"body":"Adds `uint64` ranking functions to `algos.pyx` to allow for proper ranking with `uint64`.\r\n\r\nAlso introduces partial patch for `factorize()` by adding `uint64` hashtables and vectors for\r\nusage. However, this patch is only partial because the larger bug of non-support for `uint64`\r\nin `Index` has not been fixed (**UPDATE**: tackled in #14937):\r\n~~~python\r\n>>> from pandas import Index, np\r\n>>> Index(np.array([2**63], dtype=np.uint64))\r\nInt64Index([-9223372036854775808], dtype='int64')\r\n~~~\r\n\r\nAlso patches a bug in `UInt64HashTable` from #14915 that had an erroneous null condition that was caught during testing and was hence removed.\r\n\r\nNote there is overlap with #14934 with the implementation of `is_signed_integer_dtype` and `is_unsigned_integer_dtype`.  That PR should be merged before this one."},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/268737041","html_url":"https://github.com/pandas-dev/pandas/pull/14935#issuecomment-268737041","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/14935","id":268737041,"user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"created_at":"2016-12-22T07:31:26Z","updated_at":"2016-12-22T07:31:26Z","body":"@jreback : Addressed all comments, and everything is green and passing. Ready to merge if there are no other concerns."}}
{"actor":{"display_login":"gfyoung"}}