{"action":"created","comment":{"url":"https://api.github.com/repos/chef/omnitruck/pulls/comments/57337185","id":57337185,"diff_hunk":"@@ -289,35 +289,17 @@ To test the download route, the url is:\n \n Similar to the /download endpoint only it pulls data from build_container_list_v1.json.\n \n-# S3 Poller\n+# Poller\n \n-The S3 Poller lists release manifests (generated by `jenkins/release.rb`\n+The Poller lists release manifests (generated by `jenkins/release.rb`","path":"README.md","position":35,"original_position":35,"commit_id":"6917e41a7fed702c09682f49703fd36864cf24ee","original_commit_id":"6917e41a7fed702c09682f49703fd36864cf24ee","user":{"login":"schisamo","id":6164,"avatar_url":"https://avatars.githubusercontent.com/u/6164?v=3","gravatar_id":"","url":"https://api.github.com/users/schisamo","html_url":"https://github.com/schisamo","followers_url":"https://api.github.com/users/schisamo/followers","following_url":"https://api.github.com/users/schisamo/following{/other_user}","gists_url":"https://api.github.com/users/schisamo/gists{/gist_id}","starred_url":"https://api.github.com/users/schisamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schisamo/subscriptions","organizations_url":"https://api.github.com/users/schisamo/orgs","repos_url":"https://api.github.com/users/schisamo/repos","events_url":"https://api.github.com/users/schisamo/events{/privacy}","received_events_url":"https://api.github.com/users/schisamo/received_events","type":"User","site_admin":false},"body":"This sentence is no longer accurate. I believe we need to say something about pulling release data from Bintray.","created_at":"2016-03-24T15:43:04Z","updated_at":"2016-03-24T15:43:04Z","html_url":"https://github.com/chef/omnitruck/pull/168#discussion_r57337185","pull_request_url":"https://api.github.com/repos/chef/omnitruck/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/comments/57337185"},"html":{"href":"https://github.com/chef/omnitruck/pull/168#discussion_r57337185"},"pull_request":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/chef/omnitruck/pulls/168","id":63963422,"html_url":"https://github.com/chef/omnitruck/pull/168","diff_url":"https://github.com/chef/omnitruck/pull/168.diff","patch_url":"https://github.com/chef/omnitruck/pull/168.patch","issue_url":"https://api.github.com/repos/chef/omnitruck/issues/168","number":168,"state":"open","locked":false,"title":"Switch omnitruck's backend from S3 -> bintray","user":{"login":"sersut","id":1695955,"avatar_url":"https://avatars.githubusercontent.com/u/1695955?v=3","gravatar_id":"","url":"https://api.github.com/users/sersut","html_url":"https://github.com/sersut","followers_url":"https://api.github.com/users/sersut/followers","following_url":"https://api.github.com/users/sersut/following{/other_user}","gists_url":"https://api.github.com/users/sersut/gists{/gist_id}","starred_url":"https://api.github.com/users/sersut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sersut/subscriptions","organizations_url":"https://api.github.com/users/sersut/orgs","repos_url":"https://api.github.com/users/sersut/repos","events_url":"https://api.github.com/users/sersut/events{/privacy}","received_events_url":"https://api.github.com/users/sersut/received_events","type":"User","site_admin":false},"body":"**Do not merge. This project is managed with delivery however this is a big PR and I did not want to review this in Delivery.**\r\n\r\nThis PR switches omnitruck's backend from S3 to bintray. A few major changes are:\r\n\r\n- `s3_poller` is renamed to `poller`.\r\n- Removed the caching of individual version manifests. \r\n- Renamed the build manifests to `#{project_name}-manifest.json`\r\n- Removed unused gems / classes.\r\n- `/#{project_name}/platforms` endpoints now return a static list of platform names for all products.\r\n\r\nThe goal of this PR is to simplify omnitruck as much as possible. Along these lines I have got rid of the extra caching layer for individual version manifests. When using bintray there are two ways to handle version manifests:\r\n\r\n1-) Cache them and use `/versions/$version` bintray endpoint to see if they changed. \r\n2-) Do not cache them and use `/versions/$version/files` bintray endpoint to always get the latest info. \r\n\r\nI have benchmarked these two apis and performance wise they were really close. Therefore I removed the extra caching layer since it is not earning us a lot of time when `poller` is running. \r\n\r\nOn the testing side:\r\n- I have modified the data files only with search & replace so that we do not miss the interesting cases we have created for ourselves.\r\n- Added a functional test where we run `poller` to make sure that it can run before deploying any changes to omnitruck.\r\n\r\nThings to do before merge:\r\n- [ ] Update local mixlib-install path in `Gemfile` once its relevant PR is merged.\r\n- [ ] Squash commits and introduce good commit messages.\r\n\r\n","created_at":"2016-03-23T22:29:18Z","updated_at":"2016-03-24T15:43:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e63cb442642e2e4e04e46a94639363fc3771196","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/omnitruck/pulls/168/commits","review_comments_url":"https://api.github.com/repos/chef/omnitruck/pulls/168/comments","review_comment_url":"https://api.github.com/repos/chef/omnitruck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/omnitruck/issues/168/comments","statuses_url":"https://api.github.com/repos/chef/omnitruck/statuses/6917e41a7fed702c09682f49703fd36864cf24ee","head":{"label":"chef:sersut/bintray","ref":"sersut/bintray","sha":"6917e41a7fed702c09682f49703fd36864cf24ee","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4981792,"name":"omnitruck","full_name":"chef/omnitruck","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/omnitruck","description":"Web service to automate the release of Omnibus artifacts","fork":false,"url":"https://api.github.com/repos/chef/omnitruck","forks_url":"https://api.github.com/repos/chef/omnitruck/forks","keys_url":"https://api.github.com/repos/chef/omnitruck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/omnitruck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/omnitruck/teams","hooks_url":"https://api.github.com/repos/chef/omnitruck/hooks","issue_events_url":"https://api.github.com/repos/chef/omnitruck/issues/events{/number}","events_url":"https://api.github.com/repos/chef/omnitruck/events","assignees_url":"https://api.github.com/repos/chef/omnitruck/assignees{/user}","branches_url":"https://api.github.com/repos/chef/omnitruck/branches{/branch}","tags_url":"https://api.github.com/repos/chef/omnitruck/tags","blobs_url":"https://api.github.com/repos/chef/omnitruck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/omnitruck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/omnitruck/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/omnitruck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/omnitruck/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/omnitruck/languages","stargazers_url":"https://api.github.com/repos/chef/omnitruck/stargazers","contributors_url":"https://api.github.com/repos/chef/omnitruck/contributors","subscribers_url":"https://api.github.com/repos/chef/omnitruck/subscribers","subscription_url":"https://api.github.com/repos/chef/omnitruck/subscription","commits_url":"https://api.github.com/repos/chef/omnitruck/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/omnitruck/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/omnitruck/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/omnitruck/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/omnitruck/contents/{+path}","compare_url":"https://api.github.com/repos/chef/omnitruck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/omnitruck/merges","archive_url":"https://api.github.com/repos/chef/omnitruck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/omnitruck/downloads","issues_url":"https://api.github.com/repos/chef/omnitruck/issues{/number}","pulls_url":"https://api.github.com/repos/chef/omnitruck/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/omnitruck/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/omnitruck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/omnitruck/labels{/name}","releases_url":"https://api.github.com/repos/chef/omnitruck/releases{/id}","deployments_url":"https://api.github.com/repos/chef/omnitruck/deployments","created_at":"2012-07-10T23:09:36Z","updated_at":"2016-01-19T21:35:29Z","pushed_at":"2016-03-23T22:29:18Z","git_url":"git://github.com/chef/omnitruck.git","ssh_url":"git@github.com:chef/omnitruck.git","clone_url":"https://github.com/chef/omnitruck.git","svn_url":"https://github.com/chef/omnitruck","homepage":"","size":1325,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":27,"forks":15,"open_issues":27,"watchers":8,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"5fde8583db3958a09f747c113f411fb39bf6014e","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":4981792,"name":"omnitruck","full_name":"chef/omnitruck","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/omnitruck","description":"Web service to automate the release of Omnibus artifacts","fork":false,"url":"https://api.github.com/repos/chef/omnitruck","forks_url":"https://api.github.com/repos/chef/omnitruck/forks","keys_url":"https://api.github.com/repos/chef/omnitruck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/omnitruck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/omnitruck/teams","hooks_url":"https://api.github.com/repos/chef/omnitruck/hooks","issue_events_url":"https://api.github.com/repos/chef/omnitruck/issues/events{/number}","events_url":"https://api.github.com/repos/chef/omnitruck/events","assignees_url":"https://api.github.com/repos/chef/omnitruck/assignees{/user}","branches_url":"https://api.github.com/repos/chef/omnitruck/branches{/branch}","tags_url":"https://api.github.com/repos/chef/omnitruck/tags","blobs_url":"https://api.github.com/repos/chef/omnitruck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/omnitruck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/omnitruck/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/omnitruck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/omnitruck/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/omnitruck/languages","stargazers_url":"https://api.github.com/repos/chef/omnitruck/stargazers","contributors_url":"https://api.github.com/repos/chef/omnitruck/contributors","subscribers_url":"https://api.github.com/repos/chef/omnitruck/subscribers","subscription_url":"https://api.github.com/repos/chef/omnitruck/subscription","commits_url":"https://api.github.com/repos/chef/omnitruck/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/omnitruck/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/omnitruck/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/omnitruck/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/omnitruck/contents/{+path}","compare_url":"https://api.github.com/repos/chef/omnitruck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/omnitruck/merges","archive_url":"https://api.github.com/repos/chef/omnitruck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/omnitruck/downloads","issues_url":"https://api.github.com/repos/chef/omnitruck/issues{/number}","pulls_url":"https://api.github.com/repos/chef/omnitruck/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/omnitruck/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/omnitruck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/omnitruck/labels{/name}","releases_url":"https://api.github.com/repos/chef/omnitruck/releases{/id}","deployments_url":"https://api.github.com/repos/chef/omnitruck/deployments","created_at":"2012-07-10T23:09:36Z","updated_at":"2016-01-19T21:35:29Z","pushed_at":"2016-03-23T22:29:18Z","git_url":"git://github.com/chef/omnitruck.git","ssh_url":"git@github.com:chef/omnitruck.git","clone_url":"https://github.com/chef/omnitruck.git","svn_url":"https://github.com/chef/omnitruck","homepage":"","size":1325,"stargazers_count":8,"watchers_count":8,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":27,"forks":15,"open_issues":27,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/168"},"html":{"href":"https://github.com/chef/omnitruck/pull/168"},"issue":{"href":"https://api.github.com/repos/chef/omnitruck/issues/168"},"comments":{"href":"https://api.github.com/repos/chef/omnitruck/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/omnitruck/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/chef/omnitruck/statuses/6917e41a7fed702c09682f49703fd36864cf24ee"}}}}