{"action":"closed","number":213,"pull_request":{"url":"https://api.github.com/repos/bloomberg/bde/pulls/213","id":67148955,"html_url":"https://github.com/bloomberg/bde/pull/213","diff_url":"https://github.com/bloomberg/bde/pull/213.diff","patch_url":"https://github.com/bloomberg/bde/pull/213.patch","issue_url":"https://api.github.com/repos/bloomberg/bde/issues/213","number":213,"state":"closed","locked":false,"title":"Add format function to bdlfp::DecimalUtil","user":{"login":"EricWF","id":1176427,"avatar_url":"https://avatars.githubusercontent.com/u/1176427?v=3","gravatar_id":"","url":"https://api.github.com/users/EricWF","html_url":"https://github.com/EricWF","followers_url":"https://api.github.com/users/EricWF/followers","following_url":"https://api.github.com/users/EricWF/following{/other_user}","gists_url":"https://api.github.com/users/EricWF/gists{/gist_id}","starred_url":"https://api.github.com/users/EricWF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricWF/subscriptions","organizations_url":"https://api.github.com/users/EricWF/orgs","repos_url":"https://api.github.com/users/EricWF/repos","events_url":"https://api.github.com/users/EricWF/events{/privacy}","received_events_url":"https://api.github.com/users/EricWF/received_events","type":"User","site_admin":false},"body":"This patch adds a 'bdlfp::DecimalUtil::format(DecimalType, bsl::string *out)' functions that produce a string representation of decimal values. They do so without using streams or the locales, so the output is primarily intended for human readers. If I misunderstood this requirement.\r\n\r\nThe implementation of the format functions using 'DecNumber' as the implementation.  Another possibility would be to use the platform specific implementation provided by 'DecimalImpUtil'.\r\n\r\n","created_at":"2016-04-20T08:47:27Z","updated_at":"2016-05-06T04:49:08Z","closed_at":"2016-05-06T04:49:08Z","merged_at":null,"merge_commit_sha":"1140978bdb462f1bf60fe59a9952df1fa9c1282a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bloomberg/bde/pulls/213/commits","review_comments_url":"https://api.github.com/repos/bloomberg/bde/pulls/213/comments","review_comment_url":"https://api.github.com/repos/bloomberg/bde/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bloomberg/bde/issues/213/comments","statuses_url":"https://api.github.com/repos/bloomberg/bde/statuses/e66657c33662dc8c7f6feebb16be77d2658b5690","head":{"label":"EricWF:decimal-format-review","ref":"decimal-format-review","sha":"e66657c33662dc8c7f6feebb16be77d2658b5690","user":{"login":"EricWF","id":1176427,"avatar_url":"https://avatars.githubusercontent.com/u/1176427?v=3","gravatar_id":"","url":"https://api.github.com/users/EricWF","html_url":"https://github.com/EricWF","followers_url":"https://api.github.com/users/EricWF/followers","following_url":"https://api.github.com/users/EricWF/following{/other_user}","gists_url":"https://api.github.com/users/EricWF/gists{/gist_id}","starred_url":"https://api.github.com/users/EricWF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricWF/subscriptions","organizations_url":"https://api.github.com/users/EricWF/orgs","repos_url":"https://api.github.com/users/EricWF/repos","events_url":"https://api.github.com/users/EricWF/events{/privacy}","received_events_url":"https://api.github.com/users/EricWF/received_events","type":"User","site_admin":false},"repo":{"id":54591138,"name":"bde","full_name":"EricWF/bde","owner":{"login":"EricWF","id":1176427,"avatar_url":"https://avatars.githubusercontent.com/u/1176427?v=3","gravatar_id":"","url":"https://api.github.com/users/EricWF","html_url":"https://github.com/EricWF","followers_url":"https://api.github.com/users/EricWF/followers","following_url":"https://api.github.com/users/EricWF/following{/other_user}","gists_url":"https://api.github.com/users/EricWF/gists{/gist_id}","starred_url":"https://api.github.com/users/EricWF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricWF/subscriptions","organizations_url":"https://api.github.com/users/EricWF/orgs","repos_url":"https://api.github.com/users/EricWF/repos","events_url":"https://api.github.com/users/EricWF/events{/privacy}","received_events_url":"https://api.github.com/users/EricWF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EricWF/bde","description":"Basic Development Environment - a set of foundational C++ libraries used at Bloomberg.","fork":true,"url":"https://api.github.com/repos/EricWF/bde","forks_url":"https://api.github.com/repos/EricWF/bde/forks","keys_url":"https://api.github.com/repos/EricWF/bde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EricWF/bde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EricWF/bde/teams","hooks_url":"https://api.github.com/repos/EricWF/bde/hooks","issue_events_url":"https://api.github.com/repos/EricWF/bde/issues/events{/number}","events_url":"https://api.github.com/repos/EricWF/bde/events","assignees_url":"https://api.github.com/repos/EricWF/bde/assignees{/user}","branches_url":"https://api.github.com/repos/EricWF/bde/branches{/branch}","tags_url":"https://api.github.com/repos/EricWF/bde/tags","blobs_url":"https://api.github.com/repos/EricWF/bde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EricWF/bde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EricWF/bde/git/refs{/sha}","trees_url":"https://api.github.com/repos/EricWF/bde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EricWF/bde/statuses/{sha}","languages_url":"https://api.github.com/repos/EricWF/bde/languages","stargazers_url":"https://api.github.com/repos/EricWF/bde/stargazers","contributors_url":"https://api.github.com/repos/EricWF/bde/contributors","subscribers_url":"https://api.github.com/repos/EricWF/bde/subscribers","subscription_url":"https://api.github.com/repos/EricWF/bde/subscription","commits_url":"https://api.github.com/repos/EricWF/bde/commits{/sha}","git_commits_url":"https://api.github.com/repos/EricWF/bde/git/commits{/sha}","comments_url":"https://api.github.com/repos/EricWF/bde/comments{/number}","issue_comment_url":"https://api.github.com/repos/EricWF/bde/issues/comments{/number}","contents_url":"https://api.github.com/repos/EricWF/bde/contents/{+path}","compare_url":"https://api.github.com/repos/EricWF/bde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EricWF/bde/merges","archive_url":"https://api.github.com/repos/EricWF/bde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EricWF/bde/downloads","issues_url":"https://api.github.com/repos/EricWF/bde/issues{/number}","pulls_url":"https://api.github.com/repos/EricWF/bde/pulls{/number}","milestones_url":"https://api.github.com/repos/EricWF/bde/milestones{/number}","notifications_url":"https://api.github.com/repos/EricWF/bde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EricWF/bde/labels{/name}","releases_url":"https://api.github.com/repos/EricWF/bde/releases{/id}","deployments_url":"https://api.github.com/repos/EricWF/bde/deployments","created_at":"2016-03-23T20:32:24Z","updated_at":"2016-03-23T20:32:35Z","pushed_at":"2016-04-26T21:12:51Z","git_url":"git://github.com/EricWF/bde.git","ssh_url":"git@github.com:EricWF/bde.git","clone_url":"https://github.com/EricWF/bde.git","svn_url":"https://github.com/EricWF/bde","homepage":"http://bloomberglabs.com/bde","size":78806,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bloomberg:master","ref":"master","sha":"3034ca5c535754fff46430c61bd2476dff90fa79","user":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"repo":{"id":6619178,"name":"bde","full_name":"bloomberg/bde","owner":{"login":"bloomberg","id":1416818,"avatar_url":"https://avatars.githubusercontent.com/u/1416818?v=3","gravatar_id":"","url":"https://api.github.com/users/bloomberg","html_url":"https://github.com/bloomberg","followers_url":"https://api.github.com/users/bloomberg/followers","following_url":"https://api.github.com/users/bloomberg/following{/other_user}","gists_url":"https://api.github.com/users/bloomberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bloomberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bloomberg/subscriptions","organizations_url":"https://api.github.com/users/bloomberg/orgs","repos_url":"https://api.github.com/users/bloomberg/repos","events_url":"https://api.github.com/users/bloomberg/events{/privacy}","received_events_url":"https://api.github.com/users/bloomberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bloomberg/bde","description":"Basic Development Environment - a set of foundational C++ libraries used at Bloomberg.","fork":false,"url":"https://api.github.com/repos/bloomberg/bde","forks_url":"https://api.github.com/repos/bloomberg/bde/forks","keys_url":"https://api.github.com/repos/bloomberg/bde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bloomberg/bde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bloomberg/bde/teams","hooks_url":"https://api.github.com/repos/bloomberg/bde/hooks","issue_events_url":"https://api.github.com/repos/bloomberg/bde/issues/events{/number}","events_url":"https://api.github.com/repos/bloomberg/bde/events","assignees_url":"https://api.github.com/repos/bloomberg/bde/assignees{/user}","branches_url":"https://api.github.com/repos/bloomberg/bde/branches{/branch}","tags_url":"https://api.github.com/repos/bloomberg/bde/tags","blobs_url":"https://api.github.com/repos/bloomberg/bde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bloomberg/bde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bloomberg/bde/git/refs{/sha}","trees_url":"https://api.github.com/repos/bloomberg/bde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bloomberg/bde/statuses/{sha}","languages_url":"https://api.github.com/repos/bloomberg/bde/languages","stargazers_url":"https://api.github.com/repos/bloomberg/bde/stargazers","contributors_url":"https://api.github.com/repos/bloomberg/bde/contributors","subscribers_url":"https://api.github.com/repos/bloomberg/bde/subscribers","subscription_url":"https://api.github.com/repos/bloomberg/bde/subscription","commits_url":"https://api.github.com/repos/bloomberg/bde/commits{/sha}","git_commits_url":"https://api.github.com/repos/bloomberg/bde/git/commits{/sha}","comments_url":"https://api.github.com/repos/bloomberg/bde/comments{/number}","issue_comment_url":"https://api.github.com/repos/bloomberg/bde/issues/comments{/number}","contents_url":"https://api.github.com/repos/bloomberg/bde/contents/{+path}","compare_url":"https://api.github.com/repos/bloomberg/bde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bloomberg/bde/merges","archive_url":"https://api.github.com/repos/bloomberg/bde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bloomberg/bde/downloads","issues_url":"https://api.github.com/repos/bloomberg/bde/issues{/number}","pulls_url":"https://api.github.com/repos/bloomberg/bde/pulls{/number}","milestones_url":"https://api.github.com/repos/bloomberg/bde/milestones{/number}","notifications_url":"https://api.github.com/repos/bloomberg/bde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bloomberg/bde/labels{/name}","releases_url":"https://api.github.com/repos/bloomberg/bde/releases{/id}","deployments_url":"https://api.github.com/repos/bloomberg/bde/deployments","created_at":"2012-11-09T20:00:30Z","updated_at":"2016-04-27T19:47:58Z","pushed_at":"2016-05-06T04:36:11Z","git_url":"git://github.com/bloomberg/bde.git","ssh_url":"git@github.com:bloomberg/bde.git","clone_url":"https://github.com/bloomberg/bde.git","svn_url":"https://github.com/bloomberg/bde","homepage":"http://bloomberglabs.com/bde","size":95085,"stargazers_count":545,"watchers_count":545,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":120,"mirror_url":null,"open_issues_count":4,"forks":120,"open_issues":4,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bloomberg/bde/pulls/213"},"html":{"href":"https://github.com/bloomberg/bde/pull/213"},"issue":{"href":"https://api.github.com/repos/bloomberg/bde/issues/213"},"comments":{"href":"https://api.github.com/repos/bloomberg/bde/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/bloomberg/bde/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/bloomberg/bde/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bloomberg/bde/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/bloomberg/bde/statuses/e66657c33662dc8c7f6feebb16be77d2658b5690"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":6,"review_comments":2,"commits":2,"additions":299,"deletions":0,"changed_files":3}}