{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/13128","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13128/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13128/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13128/events","html_url":"https://github.com/joomla/joomla-cms/pull/13128","id":194307675,"number":13128,"title":"Make sql update index drop/add work with db schema checker","user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-12-08T11:06:24Z","updated_at":"2016-12-08T20:55:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13128","html_url":"https://github.com/joomla/joomla-cms/pull/13128","diff_url":"https://github.com/joomla/joomla-cms/pull/13128.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13128.patch"},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/13122.\r\n\r\n### Summary of Changes\r\n\r\nMakes index drop/add conformant with db schema checker, ie, in one row.\r\n\r\n### Testing Instructions\r\n\r\n- Apply patch\r\n- Run manuaaly the update query in your db system\r\n-  Check if you have a non unique idx_image index in `#__languages` table\r\n\r\n![image](https://cloud.githubusercontent.com/assets/9630530/21007772/41dd1cde-bd36-11e6-8eb9-255fe05805f8.png)\r\n\r\n- Go to Extensions database and check all is fine\r\n\r\nNeeds to be tested in all 3 supported db systems: mysql, postgresql, sqlazure\r\n\r\nNote: Only tested in mysql.\r\n\r\n### Documentation Changes Required\r\n\r\nNone."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/265852755","html_url":"https://github.com/joomla/joomla-cms/pull/13128#issuecomment-265852755","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13128","id":265852755,"user":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T20:55:21Z","updated_at":"2016-12-08T20:55:21Z","body":"> It's a poor implementation because it relies on change deltas to work and cannot work with a primary source\r\n\r\nYes , i see, that is indeed a good explanation why it is poor\r\n\r\nbut checking the change deltas, is all that is needed in vast majority of the cases that a user will need to fix the DB schema"}}
{"actor":{"display_login":"ggppdk"}}