{"action":"opened","issue":{"url":"https://api.github.com/repos/ModCoderPack/MCPBot-Issues/issues/315","repository_url":"https://api.github.com/repos/ModCoderPack/MCPBot-Issues","labels_url":"https://api.github.com/repos/ModCoderPack/MCPBot-Issues/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/ModCoderPack/MCPBot-Issues/issues/315/comments","events_url":"https://api.github.com/repos/ModCoderPack/MCPBot-Issues/issues/315/events","html_url":"https://github.com/ModCoderPack/MCPBot-Issues/issues/315","id":193930664,"number":315,"title":"FontRendererObj.splitStringWidth, and semirelated drawSplitString, listFormattedStringToWidth, and wrapFormattedStringToWidth","user":{"login":"Pokechu22","id":8334194,"avatar_url":"https://avatars.githubusercontent.com/u/8334194?v=3","gravatar_id":"","url":"https://api.github.com/users/Pokechu22","html_url":"https://github.com/Pokechu22","followers_url":"https://api.github.com/users/Pokechu22/followers","following_url":"https://api.github.com/users/Pokechu22/following{/other_user}","gists_url":"https://api.github.com/users/Pokechu22/gists{/gist_id}","starred_url":"https://api.github.com/users/Pokechu22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pokechu22/subscriptions","organizations_url":"https://api.github.com/users/Pokechu22/orgs","repos_url":"https://api.github.com/users/Pokechu22/repos","events_url":"https://api.github.com/users/Pokechu22/events{/privacy}","received_events_url":"https://api.github.com/users/Pokechu22/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-07T01:06:32Z","updated_at":"2016-12-07T01:06:32Z","closed_at":null,"body":"I've got two major points with these methods:\r\n\r\n* `splitStringWidth` is an **incorrect** name.  That method returns the _height_ of the string, not the width (looking at its code makes this obvious).  I propose naming it `getWordWrappedHeight` instead.\r\n* `drawSplitString`, `listFormattedStringToWidth`, and `wrapFormattedStringToWidth` all are awkward.  The names work, but aren't particularly elegant.  I propose naming them `drawWordWrappedString`, `getWordWrappedLines` and `wordWrapString` instead (but these names aren't necessarily perfect).  However, since `drawSplitString` and `listFormattedStringToWidth` are public, this _may_ break mods (`wrapFormattedStringToWidth` isn't public so I don't see renaming it causing any problems).\r\n\r\nI'm currently working on cleaning up the documentation relating to `FontRenderer`, and I'll be able to write nicer comments if the names are better (I can still write the comments now, but it's not ideal if the names don't make sense).  "}}
{"actor":{"display_login":"Pokechu22"}}