{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3617","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3617/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3617/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3617/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3617","id":132752966,"number":3617,"title":"JitArm64: Merge FP functions.","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-10T16:41:07Z","updated_at":"2016-02-12T16:22:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3617","html_url":"https://github.com/dolphin-emu/dolphin/pull/3617","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3617.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3617.patch"},"body":"This PR tries to merge some floating point instruction generators to share some common code.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3617)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/183394502","html_url":"https://github.com/dolphin-emu/dolphin/pull/3617#issuecomment-183394502","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3617","id":183394502,"user":{"login":"BhaaLseN","id":826052,"avatar_url":"https://avatars.githubusercontent.com/u/826052?v=3","gravatar_id":"","url":"https://api.github.com/users/BhaaLseN","html_url":"https://github.com/BhaaLseN","followers_url":"https://api.github.com/users/BhaaLseN/followers","following_url":"https://api.github.com/users/BhaaLseN/following{/other_user}","gists_url":"https://api.github.com/users/BhaaLseN/gists{/gist_id}","starred_url":"https://api.github.com/users/BhaaLseN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BhaaLseN/subscriptions","organizations_url":"https://api.github.com/users/BhaaLseN/orgs","repos_url":"https://api.github.com/users/BhaaLseN/repos","events_url":"https://api.github.com/users/BhaaLseN/events{/privacy}","received_events_url":"https://api.github.com/users/BhaaLseN/received_events","type":"User","site_admin":false},"created_at":"2016-02-12T16:22:17Z","updated_at":"2016-02-12T16:22:17Z","body":"\n\n\n\nReviewed 3 of 4 files at r2, 1 of 1 files at r3.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[Source/Core/Core/PowerPC/JitArm64/JitArm64_Paired.cpp, line 103 \\[r3\\]](https://reviewable.io:443/reviews/dolphin-emu/dolphin/3617#-KALHG06f_CQmDyIGqUv:-KALHG07LAyTuOSC8X85:2036815685) ([raw file](https://github.com/dolphin-emu/dolphin/blob/3abe99e9dee358d167beb229d4213d4302bb117b/Source/Core/Core/PowerPC/JitArm64/JitArm64_Paired.cpp#L103)):*\nIs there any chance of this being hit with other, not handled values of `op5` (does a `default` case make sense here)?\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/dolphin-emu/dolphin/3617)*\n<!-- Sent from Reviewable.io -->\n"}}