{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/787","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/787/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/787/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/787/events","html_url":"https://github.com/trilinos/Trilinos/pull/787","id":187807173,"number":787,"title":"CMake mods for smarter Netcdf, HDF5, PNetcdf, and CGNS TPL config","user":{"login":"gsjaardema","id":897294,"avatar_url":"https://avatars.githubusercontent.com/u/897294?v=3","gravatar_id":"","url":"https://api.github.com/users/gsjaardema","html_url":"https://github.com/gsjaardema","followers_url":"https://api.github.com/users/gsjaardema/followers","following_url":"https://api.github.com/users/gsjaardema/following{/other_user}","gists_url":"https://api.github.com/users/gsjaardema/gists{/gist_id}","starred_url":"https://api.github.com/users/gsjaardema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsjaardema/subscriptions","organizations_url":"https://api.github.com/users/gsjaardema/orgs","repos_url":"https://api.github.com/users/gsjaardema/repos","events_url":"https://api.github.com/users/gsjaardema/events{/privacy}","received_events_url":"https://api.github.com/users/gsjaardema/received_events","type":"User","site_admin":false},"labels":[{"id":318642986,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2016-11-07T19:39:57Z","updated_at":"2016-11-09T14:45:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/787","html_url":"https://github.com/trilinos/Trilinos/pull/787","diff_url":"https://github.com/trilinos/Trilinos/pull/787.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/787.patch"},"body":"The changes in this pull request make it much easier to configure the NetCDF, PNetCDF, CGNS, and HDF5 dependencies for use with Exodus and Ioss libraries.  The dependency of NetCDF on PNetCDF and/or HDF5 and the dependency of CGNS on HDF5 are automatically determined.\r\n\r\nAdditional Checks include:\r\n\r\n- Whether HDF5 and NetCDF and CGNS are compiled with parallel enabled is also checked.\r\n- If the NetCDF and PNetCDF libraries have the recommended settings for NC_MAX_DIMS and NC_MAX_VARS applied\r\n- If the CGNS library was compiled with the correct PREFIX setting\r\n\r\nThese changes are similar to what is being used by other projects at LANL and INL and are also being used in the standalone SEACAS build.\r\n\r\n * Add FindTPL????.cmake and Find????.cmake from seacas standalone\r\n   repo. ???? = Netcdf, HDF5, CGNS, and PNetCDF.\r\n * Standardize on _ROOT instead of _DIR; issue warning if _DIR specified, but continue\r\n * Remove use of FindTPLHDF5.cmake in common_tpls and use the one in cmake/TPLs instead.\r\n * Reorder netcdf, hdf5, pnetcdf, cgns, exodus, and nemesis libraries to be in correct\r\n   dependency order"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/259430948","html_url":"https://github.com/trilinos/Trilinos/pull/787#issuecomment-259430948","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/787","id":259430948,"user":{"login":"gsjaardema","id":897294,"avatar_url":"https://avatars.githubusercontent.com/u/897294?v=3","gravatar_id":"","url":"https://api.github.com/users/gsjaardema","html_url":"https://github.com/gsjaardema","followers_url":"https://api.github.com/users/gsjaardema/followers","following_url":"https://api.github.com/users/gsjaardema/following{/other_user}","gists_url":"https://api.github.com/users/gsjaardema/gists{/gist_id}","starred_url":"https://api.github.com/users/gsjaardema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsjaardema/subscriptions","organizations_url":"https://api.github.com/users/gsjaardema/orgs","repos_url":"https://api.github.com/users/gsjaardema/repos","events_url":"https://api.github.com/users/gsjaardema/events{/privacy}","received_events_url":"https://api.github.com/users/gsjaardema/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T14:45:51Z","updated_at":"2016-11-09T14:45:51Z","body":"@bartlettroscoe I would prefer not making these changes seacas-only; I think there are other packages currently using NetCDF and therefore HDF5 and PNetCDF and there may be more in the future.  \r\n\r\nI would be fine with moving the files out of tribits/core/utils and into common_tpls though.\r\n\r\nNote that the only exodus-specific configuration is the check for `NC_MAX_VARS` and `NC_MAX_DIMS`; the other configuration checks are generic to all users of NetCDF."}}
{"actor":{"display_login":"gsjaardema"}}