{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/75432508","id":75432508,"diff_hunk":"@@ -544,6 +551,26 @@ public void deleteFeedbackSessionsForCourses(List<String> courseIds) {\n     }\n     \n     @SuppressWarnings(\"unchecked\")\n+    private List<FeedbackSession> getFeedbackSessionEntitiesNeedingClosingEmail() {\n+        Query q = getPm().newQuery(FeedbackSession.class);\n+        q.declareParameters(\"boolean sentParam, boolean enableParam, Enum notTypeParam\");\n+        q.setFilter(\"sentClosingEmail == sentParam && isClosingEmailEnabled == enableParam \"\n+                    + \"&& feedbackSessionType != notTypeParam\");\n+        \n+        return (List<FeedbackSession>) q.execute(false, true, FeedbackSessionType.PRIVATE);\n+    }\n+    \n+    @SuppressWarnings(\"unchecked\")\n+    private List<FeedbackSession> getFeedbackSessionEntitiesNeedingClosedEmail() {\n+        Query q = getPm().newQuery(FeedbackSession.class);\n+        q.declareParameters(\"boolean sentParam, boolean enableParam, Enum notTypeParam\");\n+        q.setFilter(\"sentClosedEmail == sentParam && isClosedEmailEnabled == enableParam \"\n+                    + \"&& feedbackSessionType != notTypeParam\");","path":"src/main/java/teammates/storage/api/FeedbackSessionsDb.java","position":null,"original_position":110,"commit_id":"f924d744e7d13fa0aadfed5348edc965d328c760","original_commit_id":"49975b72b475e56ecf7467f1859244e41d931e75","user":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"body":"It's already done the foolproof way. If not, then something is also wrong with how we manage the opening and published emails.","created_at":"2016-08-19T06:22:50Z","updated_at":"2016-08-19T06:22:50Z","html_url":"https://github.com/TEAMMATES/teammates/pull/6001#discussion_r75432508","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/75432508"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/6001#discussion_r75432508"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001","id":81807812,"html_url":"https://github.com/TEAMMATES/teammates/pull/6001","diff_url":"https://github.com/TEAMMATES/teammates/pull/6001.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/6001.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6001","number":6001,"state":"open","locked":false,"title":"Timeouts in session closing and closed reminders #5999","user":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"body":"Fixes #5999 \r\n\r\nStill running some tests (in particular for checking backward-compatibility), but feel free to review what's already here.","created_at":"2016-08-18T12:34:22Z","updated_at":"2016-08-19T06:22:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc11176a063ba9ef333b314e339cc66fcb73a945","assignee":{"login":"chowyb","id":7546744,"avatar_url":"https://avatars.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"chowyb","id":7546744,"avatar_url":"https://avatars.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/TEAMMATES/teammates/milestones/222","html_url":"https://github.com/TEAMMATES/teammates/milestones/V5.87.01","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones/222/labels","id":1949648,"number":222,"title":"V5.87.01","description":"","creator":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2016-08-18T15:09:53Z","updated_at":"2016-08-18T15:10:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/6001/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/f924d744e7d13fa0aadfed5348edc965d328c760","head":{"label":"TEAMMATES:5999-timeout-closing-email-reminder","ref":"5999-timeout-closing-email-reminder","sha":"f924d744e7d13fa0aadfed5348edc965d328c760","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2016-08-18T09:45:12Z","pushed_at":"2016-08-19T06:04:40Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"http://teammatesv4.appspot.com/","size":196130,"stargazers_count":112,"watchers_count":112,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":303,"mirror_url":null,"open_issues_count":489,"forks":303,"open_issues":489,"watchers":112,"default_branch":"master"}},"base":{"label":"TEAMMATES:release","ref":"release","sha":"6d3ed477981b8f02c0616041c6c85c2c3935f4f8","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2016-08-18T09:45:12Z","pushed_at":"2016-08-19T06:04:40Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"http://teammatesv4.appspot.com/","size":196130,"stargazers_count":112,"watchers_count":112,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":303,"mirror_url":null,"open_issues_count":489,"forks":303,"open_issues":489,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/6001"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/6001"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/6001/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/6001/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/f924d744e7d13fa0aadfed5348edc965d328c760"}}}}
{"actor":{"display_login":"wkurniawan07"}}