{"push_id":1060280899,"size":29,"distinct_size":5,"ref":"refs/heads/mb-use-parent-link-in-breadcrumb","head":"e02933b8a982b87b87bde928c657592a36d0e305","before":"f62ffae2c4a74639ee8f0804b2760e33f24a2a62","commits":[{"sha":"89a0e703c97d2895dbbebfa1c65afca731049d6f","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Data migration to destroy un-attached `AttachmentData` objects\n\nDue to an issue fixed in https://github.com/alphagov/whitehall/pull/2536\nsome `AttachmentData` objects have been orphaned when their `Attachment`\nhas been marked deleted. This data migration destroys them.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/89a0e703c97d2895dbbebfa1c65afca731049d6f"},{"sha":"ae3940a9f51aa342c06c3880140ed0dbf22bf696","author":{"email":"8ecd27f67d289ad506a1f0c5d9185077c5cc07ac@digital.cabinet-office.gov.uk","name":"Theodor Vararu"},"message":"Publish intents for StatisticsAnnouncement.\n\nThis adds additional callbacks when creating, updating, or deleting\na `StatisticsAnnouncement` to send `publish_intents` to the publishing\nAPI.\n\nThis is necessary to set the cache expiration correctly for the\npublication of the statistics themselves.\n\nThis functionality is only exposed on the `v1` `publishing_api`.\nUltimately, this will happen internally, within the `publishing_api`, so\nusing the `v1` endpoint seems like a reasonable temporary solution.\n\nRelevant Trello ticket:\nhttps://trello.com/c/zMdu3dHe/343-use-publish-intents-on-statistics-announcements-medium","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/ae3940a9f51aa342c06c3880140ed0dbf22bf696"},{"sha":"87b7e169097e15e2eddc6689c00d1d68d0f7926b","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Delete `publish-intent` on `cancel`\n\nWhen a `StatisticsAnnouncement` is cancelled delete any publish intent\nfor that base path","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/87b7e169097e15e2eddc6689c00d1d68d0f7926b"},{"sha":"902270904d8f9db11dbdedbab47f62c87bb68185","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Remove `PolicyGroup` from `HtmlAttachment` factory\n\nUpdate the `HtmlAttachment` factory to more correctly represent a 'real\nworld' `HtmlAttachment`. `PolicyGroup` objects cannot have attached\n`HtmlAttachments`.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/902270904d8f9db11dbdedbab47f62c87bb68185"},{"sha":"0ad2085c91fad992c2fcbfd20f3fa1c8556816f2","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Add `HtmlAttachment` presenter\n\nThis is required to allow transmission of the `HtmlAttachment` to the\nPublishing API. This commit also adds support to\n`PublishingApiPresenters.presenter_for`","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/0ad2085c91fad992c2fcbfd20f3fa1c8556816f2"},{"sha":"e53403581b4ab9dafc12075ef655793aa2ac5bc8","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Add specific `Edition`/`Publication` factories for unpublishing\n\nThis is required to properly test `PublishingApiPusher` the variations\nof redirect, alternative url etc","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/e53403581b4ab9dafc12075ef655793aa2ac5bc8"},{"sha":"dce2c18d263ee7d56efabd67d065a1efb221a84d","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"`PublishingApiPusher` also handles `HtmlAttachment`\n\n`Edition` events now update/create/redirect any associated\n`HtmlAttachment` content with the Publishing API.\n\nBy hooking up the transmission of attachments to the `Edition` events we\nare hoping to avoid the attachment having to know too much about the\n`Edition` state.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/dce2c18d263ee7d56efabd67d065a1efb221a84d"},{"sha":"6db073d751184dc3c2091006c97430474a7fe01d","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Stub V1 `publish-intent` API endpoint\n\nRequired for dependent features to pass since adding `publish-intent`\nsupport to `StatisticsAnnouncement`","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/6db073d751184dc3c2091006c97430474a7fe01d"},{"sha":"c8789f564e0f5e0165ae026a7773abba8a2d6f71","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Merge pull request #2538 from alphagov/publish-intents-statistic-announcements\n\nPublish intents for StatisticsAnnouncement.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/c8789f564e0f5e0165ae026a7773abba8a2d6f71"},{"sha":"a0f55cab6668ff0822f2634b1a61c5e19c692da2","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Add rake task to update `StatisticsAnnouncement` publish intent\n\nThis rake task is required to send a `publish_intent` to the\nPublishingAPI for any existing `StatisticsAnnouncement` with a release\ndate in the future. It is a follow up commit to\nhttps://github.com/alphagov/whitehall/pull/2538","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/a0f55cab6668ff0822f2634b1a61c5e19c692da2"},{"sha":"df853c1b52c3f154d0e5f737cbe2c0b7b98746e3","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Explain current biography logic to users\n\nThe current process for creating or editing people is confusing. We\nhave some logic that shows a truncated biography for any person without\na current role. If you’re creating a new person, they have no role –\nwhen you enter your full biography and check it on the live site, it’s\nnot clear why the whole thing isn’t showing.\n\nThis is a simple change to try and explain that. The decision to do the\ntruncation should be re-assessed.\n\nZendesk ticket: https://govuk.zendesk.com/agent/tickets/1298476\nOriginal PR to add truncation:\nhttps://github.com/alphagov/whitehall/pull/2058","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/df853c1b52c3f154d0e5f737cbe2c0b7b98746e3"},{"sha":"bf58b4b2f0ea77b8cee82864d365c15c986eb0d2","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Add missing unit test\n\n`html_attachment_govspeak_headers_html` was untested.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/bf58b4b2f0ea77b8cee82864d365c15c986eb0d2"},{"sha":"abf518dc7a3d096dc68e833621052244f3c43820","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Add helper to `GovspeakRenderer`\n\nThis commit adds the `html_attachment_govspeak_headers_html` helper to\nthe delegated helpers exposed within `GovspeakRenderer`. This will allow\nit to be used within `GovspeakContentWorker` and ultimately within\n`GovspeakContent` allowing it to be filled synchronously.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/abf518dc7a3d096dc68e833621052244f3c43820"},{"sha":"7ce2b2c4ca18a5403c32c0c971e98e3114cd88b9","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Use `GovspeakRenderer` in `GovspeakContentWorker`\n\nThe previous functionality was mostly duplicating the functionality of\n`GovspeakRenderer` and was also not threadsafe as fixed in\nhttps://github.com/alphagov/whitehall/pull/2540","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/7ce2b2c4ca18a5403c32c0c971e98e3114cd88b9"},{"sha":"6dbdf4172d61c30024aa4b6bcd3a23d40d68b52f","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Merge pull request #2546 from alphagov/add-publish-intents-task\n\nAdd rake task to update `StatisticsAnnouncement` publish intent","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/6dbdf4172d61c30024aa4b6bcd3a23d40d68b52f"},{"sha":"a55ce3e5e9eb436da6c1e4721203fececf19d3e5","author":{"email":"12ca95a439b13b609744183b9d2f79ca5b64ed8f@users.noreply.github.com","name":"Paul Hayes"},"message":"Merge pull request #2547 from alphagov/tweak-bio-copy\n\nExplain current biography logic to users","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/a55ce3e5e9eb436da6c1e4721203fececf19d3e5"},{"sha":"fc2ccf32e0ed461d65be3087264e5964b725803d","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Merge pull request #2544 from alphagov/use-govspeak-renderer-in-worker\n\nUse `GovspeakRenderer` in `GovspeakContentWorker`","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/fc2ccf32e0ed461d65be3087264e5964b725803d"},{"sha":"451a077304450ccd47c42f542fdb50207744c349","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Refactor `GovspeakContent` and `GovspeakContentWorker`\n\nThis commit moves all of the govspeak -> html rendering logic into the\n`GovspeakContent` class. This will allow it to be called elsewhere e.g. when\nthe `HtmlAttachment` is being presented for the Publishing API. When\nthat is done we may be able to get rid of the `GovspeakContentWorker`\naltogether which I'll do in a further PR if possible.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/451a077304450ccd47c42f542fdb50207744c349"},{"sha":"13386f3f78851d3aa101de85393b48bc17f740b6","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Merge pull request #2537 from alphagov/destroy_attachment_data_objects_that_are_no_longer_attached\n\nData migration to destroy un-attached `AttachmentData` objects","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/13386f3f78851d3aa101de85393b48bc17f740b6"},{"sha":"48753242c6dea069e8220def0cc2dcb26fce7c79","author":{"email":"5ca27e75aea3e5e83a04c6cfa5f1b63d358cd03d@three-tier.com","name":"Graham Pengelly"},"message":"Exclude `cancelled?` and `unpublished?`\n\nRunning this task previously was causing a lot of `500` responses from\nthe publishing stack due to the way `404` responses returned by the\n`publish_intents` endpoint on Content Store are handled on their way back\nthrough the stack. This change stops `unpublished?` and `cancelled?`\n`StatisticsAnnouncement` being sent. These states cause a delete publish\nintent call to be made resulting in the error when it isn't found on the\ncontent store.","distinct":false,"url":"https://api.github.com/repos/alphagov/whitehall/commits/48753242c6dea069e8220def0cc2dcb26fce7c79"}]}