{"action":"created","issue":{"url":"https://api.github.com/repos/autotest/autotest-docker/issues/659","repository_url":"https://api.github.com/repos/autotest/autotest-docker","labels_url":"https://api.github.com/repos/autotest/autotest-docker/issues/659/labels{/name}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/issues/659/comments","events_url":"https://api.github.com/repos/autotest/autotest-docker/issues/659/events","html_url":"https://github.com/autotest/autotest-docker/pull/659","id":188057965,"number":659,"title":"Prefetch centos, to fix failing build test","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-08T17:45:56Z","updated_at":"2016-11-08T19:01:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/659","html_url":"https://github.com/autotest/autotest-docker/pull/659","diff_url":"https://github.com/autotest/autotest-docker/pull/659.diff","patch_url":"https://github.com/autotest/autotest-docker/pull/659.patch"},"body":"build/https_file and build/rm_false tests are failing\r\nbecause their Dockerfiles pull in centos, so img_count()\r\nfinds two new post-run images instead of one.\r\n\r\nThis patch solves it, but not ideally. It's duplication on top\r\nof more duplication. A better solution might piggyback off\r\npreserve_fqins but that too is fragile. Submitting as a\r\ncompromise to get tests passing.\r\n\r\nSigned-off-by: Ed Santiago <santiago@redhat.com>"},"comment":{"url":"https://api.github.com/repos/autotest/autotest-docker/issues/comments/259227313","html_url":"https://github.com/autotest/autotest-docker/pull/659#issuecomment-259227313","issue_url":"https://api.github.com/repos/autotest/autotest-docker/issues/659","id":259227313,"user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars.githubusercontent.com/u/1183438?v=3","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T19:01:28Z","updated_at":"2016-11-08T19:01:28Z","body":" >even worse duplication\r\n\r\nGood thing you never saw this test _before_ the command-pattern was deployed.  These were ALL basically hard-coded in python instead of config values :frowning_face: \r\n\r\n> Possibly, but see above for potential duplication.\r\n\r\nWhat if we just add this to ``[docker_cli/build]``:\r\n\r\n```ini\r\ndocker_repo_name = centos\r\ndocker_repo_tag = 7\r\ndocker_registry_host = docker.io\r\ndocker_registry_user = stackbrew\r\n```\r\n\r\nHmmm, meh, not much/any better that your solution.  I think I like your fix better.\r\n\r\nOnly thing it's possibly missing is a comment about why the centos value is there.  Something like \"helps some build sub-subtests image counting\""}}
{"actor":{"display_login":"cevich"}}