{"action":"created","comment":{"url":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/comments/57648222","id":57648222,"diff_hunk":"@@ -4,4 +4,5 @@ def execute(macro, args):\n   key = args.split()[0]\n   if key.startswith('http://www.youtube.com/watch?v='):\n     key = key[len('http://www.youtube.com/watch?v='):]\n-  return macro.formatter.rawHTML('<object width=\"480\" height=\"295\"><param name=\"movie\" value=\"http://www.youtube.com/v/%(key)s&hl=en_US&fs=1&hd=1\"></param><param name=\"allowFullScreen\" value=\"true\"></param><param name=\"allowscriptaccess\" value=\"always\"></param><embed src=\"http://www.youtube.com/v/%(key)s&hl=en_US&fs=1&hd=1\" type=\"application/x-shockwave-flash\" allowscriptaccess=\"always\" allowfullscreen=\"true\" width=\"480\" height=\"295\"></embed></object>'%locals())\n+  key = key.replace('&', '?', 1) # query params must start with ?\n+  return macro.formatter.rawHTML('<center><iframe type=\"text/html\" width=\"480\" height=\"270\" src=\"http://www.youtube.com/embed/%(key)s\" frameborder=\"0\" allowfullscreen /></center>'%locals())","path":"macro/Youtube.py","position":6,"original_position":6,"commit_id":"98abaf6de7c3e62a5b9c812baaef7fb62c3b2df1","original_commit_id":"98abaf6de7c3e62a5b9c812baaef7fb62c3b2df1","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"Maybe try: `allowfullscreen=\"true\"`","created_at":"2016-03-28T23:00:46Z","updated_at":"2016-03-28T23:00:46Z","html_url":"https://github.com/ros-infrastructure/roswiki/pull/160#discussion_r57648222","pull_request_url":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/comments/57648222"},"html":{"href":"https://github.com/ros-infrastructure/roswiki/pull/160#discussion_r57648222"},"pull_request":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160","id":64354879,"html_url":"https://github.com/ros-infrastructure/roswiki/pull/160","diff_url":"https://github.com/ros-infrastructure/roswiki/pull/160.diff","patch_url":"https://github.com/ros-infrastructure/roswiki/pull/160.patch","issue_url":"https://api.github.com/repos/ros-infrastructure/roswiki/issues/160","number":160,"state":"closed","locked":false,"title":"use new google embedded API for youtube","user":{"login":"hrnr","id":1316311,"avatar_url":"https://avatars.githubusercontent.com/u/1316311?v=3","gravatar_id":"","url":"https://api.github.com/users/hrnr","html_url":"https://github.com/hrnr","followers_url":"https://api.github.com/users/hrnr/followers","following_url":"https://api.github.com/users/hrnr/following{/other_user}","gists_url":"https://api.github.com/users/hrnr/gists{/gist_id}","starred_url":"https://api.github.com/users/hrnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrnr/subscriptions","organizations_url":"https://api.github.com/users/hrnr/orgs","repos_url":"https://api.github.com/users/hrnr/repos","events_url":"https://api.github.com/users/hrnr/events{/privacy}","received_events_url":"https://api.github.com/users/hrnr/received_events","type":"User","site_admin":false},"body":"this allows to use HTML5 instead of flash.\r\n\r\nCiting google:\r\n\r\n> Deprecation Notice\r\n> YouTube `<object>` embeds were deprecated on January 27, 2015. Please migrate your applications to use `<iframe>` embeds, which can intelligently use whichever embedded player – HTML (`<video>`) or Flash (`<object>`) – the client supports.\r\n\r\nand\r\n\r\n> Best practice: IFrame embeds are the recommended method for embedding a YouTube player because the IFrame will select the appropriate player based on the client's capabilities and available YouTube file formats.\r\n\r\nI have added `<center>` to follow the same formatting as Vimeo videos. Minimal size is based on google recomendation.\r\n\r\n> Note: Embedded players must have a viewport that is at least 200px by 200px. If the player displays controls, it must be large enough to fully display the controls without shrinking the viewport below the minimum size. We recommend 16:9 players be at least 480 pixels wide and 270 pixels tall.\r\n\r\nReference:\r\nhttps://developers.google.com/youtube/player_parameters\r\n\r\nEDIT: fix style","created_at":"2016-03-28T18:29:10Z","updated_at":"2016-03-28T23:00:46Z","closed_at":"2016-03-28T22:19:42Z","merged_at":"2016-03-28T22:19:42Z","merge_commit_sha":"546bfb7f9d770ed6bfd8a76b8d884f89c68edb1d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160/commits","review_comments_url":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160/comments","review_comment_url":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-infrastructure/roswiki/issues/160/comments","statuses_url":"https://api.github.com/repos/ros-infrastructure/roswiki/statuses/98abaf6de7c3e62a5b9c812baaef7fb62c3b2df1","head":{"label":"hrnr:master","ref":"master","sha":"98abaf6de7c3e62a5b9c812baaef7fb62c3b2df1","user":{"login":"hrnr","id":1316311,"avatar_url":"https://avatars.githubusercontent.com/u/1316311?v=3","gravatar_id":"","url":"https://api.github.com/users/hrnr","html_url":"https://github.com/hrnr","followers_url":"https://api.github.com/users/hrnr/followers","following_url":"https://api.github.com/users/hrnr/following{/other_user}","gists_url":"https://api.github.com/users/hrnr/gists{/gist_id}","starred_url":"https://api.github.com/users/hrnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrnr/subscriptions","organizations_url":"https://api.github.com/users/hrnr/orgs","repos_url":"https://api.github.com/users/hrnr/repos","events_url":"https://api.github.com/users/hrnr/events{/privacy}","received_events_url":"https://api.github.com/users/hrnr/received_events","type":"User","site_admin":false},"repo":{"id":54912965,"name":"roswiki","full_name":"hrnr/roswiki","owner":{"login":"hrnr","id":1316311,"avatar_url":"https://avatars.githubusercontent.com/u/1316311?v=3","gravatar_id":"","url":"https://api.github.com/users/hrnr","html_url":"https://github.com/hrnr","followers_url":"https://api.github.com/users/hrnr/followers","following_url":"https://api.github.com/users/hrnr/following{/other_user}","gists_url":"https://api.github.com/users/hrnr/gists{/gist_id}","starred_url":"https://api.github.com/users/hrnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrnr/subscriptions","organizations_url":"https://api.github.com/users/hrnr/orgs","repos_url":"https://api.github.com/users/hrnr/repos","events_url":"https://api.github.com/users/hrnr/events{/privacy}","received_events_url":"https://api.github.com/users/hrnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrnr/roswiki","description":"Plugins and configurations for wiki.ros.org","fork":true,"url":"https://api.github.com/repos/hrnr/roswiki","forks_url":"https://api.github.com/repos/hrnr/roswiki/forks","keys_url":"https://api.github.com/repos/hrnr/roswiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrnr/roswiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrnr/roswiki/teams","hooks_url":"https://api.github.com/repos/hrnr/roswiki/hooks","issue_events_url":"https://api.github.com/repos/hrnr/roswiki/issues/events{/number}","events_url":"https://api.github.com/repos/hrnr/roswiki/events","assignees_url":"https://api.github.com/repos/hrnr/roswiki/assignees{/user}","branches_url":"https://api.github.com/repos/hrnr/roswiki/branches{/branch}","tags_url":"https://api.github.com/repos/hrnr/roswiki/tags","blobs_url":"https://api.github.com/repos/hrnr/roswiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrnr/roswiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrnr/roswiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrnr/roswiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrnr/roswiki/statuses/{sha}","languages_url":"https://api.github.com/repos/hrnr/roswiki/languages","stargazers_url":"https://api.github.com/repos/hrnr/roswiki/stargazers","contributors_url":"https://api.github.com/repos/hrnr/roswiki/contributors","subscribers_url":"https://api.github.com/repos/hrnr/roswiki/subscribers","subscription_url":"https://api.github.com/repos/hrnr/roswiki/subscription","commits_url":"https://api.github.com/repos/hrnr/roswiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrnr/roswiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrnr/roswiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrnr/roswiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrnr/roswiki/contents/{+path}","compare_url":"https://api.github.com/repos/hrnr/roswiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrnr/roswiki/merges","archive_url":"https://api.github.com/repos/hrnr/roswiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrnr/roswiki/downloads","issues_url":"https://api.github.com/repos/hrnr/roswiki/issues{/number}","pulls_url":"https://api.github.com/repos/hrnr/roswiki/pulls{/number}","milestones_url":"https://api.github.com/repos/hrnr/roswiki/milestones{/number}","notifications_url":"https://api.github.com/repos/hrnr/roswiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrnr/roswiki/labels{/name}","releases_url":"https://api.github.com/repos/hrnr/roswiki/releases{/id}","deployments_url":"https://api.github.com/repos/hrnr/roswiki/deployments","created_at":"2016-03-28T18:12:10Z","updated_at":"2016-03-28T18:12:11Z","pushed_at":"2016-03-28T22:04:30Z","git_url":"git://github.com/hrnr/roswiki.git","ssh_url":"git@github.com:hrnr/roswiki.git","clone_url":"https://github.com/hrnr/roswiki.git","svn_url":"https://github.com/hrnr/roswiki","homepage":"wiki.ros.org","size":4978,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ros-infrastructure:master","ref":"master","sha":"71d724ea795af95ecbd2be1a1f2540ae109f4636","user":{"login":"ros-infrastructure","id":2328632,"avatar_url":"https://avatars.githubusercontent.com/u/2328632?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-infrastructure","html_url":"https://github.com/ros-infrastructure","followers_url":"https://api.github.com/users/ros-infrastructure/followers","following_url":"https://api.github.com/users/ros-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/ros-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/ros-infrastructure/orgs","repos_url":"https://api.github.com/users/ros-infrastructure/repos","events_url":"https://api.github.com/users/ros-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/ros-infrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":7431261,"name":"roswiki","full_name":"ros-infrastructure/roswiki","owner":{"login":"ros-infrastructure","id":2328632,"avatar_url":"https://avatars.githubusercontent.com/u/2328632?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-infrastructure","html_url":"https://github.com/ros-infrastructure","followers_url":"https://api.github.com/users/ros-infrastructure/followers","following_url":"https://api.github.com/users/ros-infrastructure/following{/other_user}","gists_url":"https://api.github.com/users/ros-infrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-infrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-infrastructure/subscriptions","organizations_url":"https://api.github.com/users/ros-infrastructure/orgs","repos_url":"https://api.github.com/users/ros-infrastructure/repos","events_url":"https://api.github.com/users/ros-infrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/ros-infrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-infrastructure/roswiki","description":"Plugins and configurations for wiki.ros.org","fork":false,"url":"https://api.github.com/repos/ros-infrastructure/roswiki","forks_url":"https://api.github.com/repos/ros-infrastructure/roswiki/forks","keys_url":"https://api.github.com/repos/ros-infrastructure/roswiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-infrastructure/roswiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-infrastructure/roswiki/teams","hooks_url":"https://api.github.com/repos/ros-infrastructure/roswiki/hooks","issue_events_url":"https://api.github.com/repos/ros-infrastructure/roswiki/issues/events{/number}","events_url":"https://api.github.com/repos/ros-infrastructure/roswiki/events","assignees_url":"https://api.github.com/repos/ros-infrastructure/roswiki/assignees{/user}","branches_url":"https://api.github.com/repos/ros-infrastructure/roswiki/branches{/branch}","tags_url":"https://api.github.com/repos/ros-infrastructure/roswiki/tags","blobs_url":"https://api.github.com/repos/ros-infrastructure/roswiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-infrastructure/roswiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-infrastructure/roswiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-infrastructure/roswiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-infrastructure/roswiki/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-infrastructure/roswiki/languages","stargazers_url":"https://api.github.com/repos/ros-infrastructure/roswiki/stargazers","contributors_url":"https://api.github.com/repos/ros-infrastructure/roswiki/contributors","subscribers_url":"https://api.github.com/repos/ros-infrastructure/roswiki/subscribers","subscription_url":"https://api.github.com/repos/ros-infrastructure/roswiki/subscription","commits_url":"https://api.github.com/repos/ros-infrastructure/roswiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-infrastructure/roswiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-infrastructure/roswiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-infrastructure/roswiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-infrastructure/roswiki/contents/{+path}","compare_url":"https://api.github.com/repos/ros-infrastructure/roswiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-infrastructure/roswiki/merges","archive_url":"https://api.github.com/repos/ros-infrastructure/roswiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-infrastructure/roswiki/downloads","issues_url":"https://api.github.com/repos/ros-infrastructure/roswiki/issues{/number}","pulls_url":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-infrastructure/roswiki/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-infrastructure/roswiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-infrastructure/roswiki/labels{/name}","releases_url":"https://api.github.com/repos/ros-infrastructure/roswiki/releases{/id}","deployments_url":"https://api.github.com/repos/ros-infrastructure/roswiki/deployments","created_at":"2013-01-03T22:16:29Z","updated_at":"2016-01-14T17:16:57Z","pushed_at":"2016-03-28T22:19:42Z","git_url":"git://github.com/ros-infrastructure/roswiki.git","ssh_url":"git@github.com:ros-infrastructure/roswiki.git","clone_url":"https://github.com/ros-infrastructure/roswiki.git","svn_url":"https://github.com/ros-infrastructure/roswiki","homepage":"wiki.ros.org","size":5148,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":28,"forks":9,"open_issues":28,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160"},"html":{"href":"https://github.com/ros-infrastructure/roswiki/pull/160"},"issue":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/issues/160"},"comments":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/ros-infrastructure/roswiki/statuses/98abaf6de7c3e62a5b9c812baaef7fb62c3b2df1"}}}}