{"action":"created","issue":{"url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/issues/81","repository_url":"https://api.github.com/repos/asrob-uc3m/robotDevastation","labels_url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/issues/81/comments","events_url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/issues/81/events","html_url":"https://github.com/asrob-uc3m/robotDevastation/issues/81","id":191733315,"number":81,"title":"SDL window is unresponsive to usual closing events other than pressing \"Esc\"","user":{"login":"PeterBowman","id":9977198,"avatar_url":"https://avatars.githubusercontent.com/u/9977198?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterBowman","html_url":"https://github.com/PeterBowman","followers_url":"https://api.github.com/users/PeterBowman/followers","following_url":"https://api.github.com/users/PeterBowman/following{/other_user}","gists_url":"https://api.github.com/users/PeterBowman/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterBowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterBowman/subscriptions","organizations_url":"https://api.github.com/users/PeterBowman/orgs","repos_url":"https://api.github.com/users/PeterBowman/repos","events_url":"https://api.github.com/users/PeterBowman/events{/privacy}","received_events_url":"https://api.github.com/users/PeterBowman/received_events","type":"User","site_admin":false},"labels":[{"id":78648445,"url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/labels/bug","name":"bug","color":"fc2929","default":true},{"id":78648449,"url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"PeterBowman","id":9977198,"avatar_url":"https://avatars.githubusercontent.com/u/9977198?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterBowman","html_url":"https://github.com/PeterBowman","followers_url":"https://api.github.com/users/PeterBowman/followers","following_url":"https://api.github.com/users/PeterBowman/following{/other_user}","gists_url":"https://api.github.com/users/PeterBowman/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterBowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterBowman/subscriptions","organizations_url":"https://api.github.com/users/PeterBowman/orgs","repos_url":"https://api.github.com/users/PeterBowman/repos","events_url":"https://api.github.com/users/PeterBowman/events{/privacy}","received_events_url":"https://api.github.com/users/PeterBowman/received_events","type":"User","site_admin":false},"assignees":[{"login":"PeterBowman","id":9977198,"avatar_url":"https://avatars.githubusercontent.com/u/9977198?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterBowman","html_url":"https://github.com/PeterBowman","followers_url":"https://api.github.com/users/PeterBowman/followers","following_url":"https://api.github.com/users/PeterBowman/following{/other_user}","gists_url":"https://api.github.com/users/PeterBowman/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterBowman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterBowman/subscriptions","organizations_url":"https://api.github.com/users/PeterBowman/orgs","repos_url":"https://api.github.com/users/PeterBowman/repos","events_url":"https://api.github.com/users/PeterBowman/events{/privacy}","received_events_url":"https://api.github.com/users/PeterBowman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-25T16:14:51Z","updated_at":"2016-11-27T13:07:46Z","closed_at":null,"body":"https://github.com/asrob-uc3m/robotDevastation/issues/70#issuecomment-262845721\r\n> For some reason I'm unable to close the window, not even by right-clicking on the Unity tile and selecting Quit. Does it work for you?\r\n\r\nhttps://github.com/asrob-uc3m/robotDevastation/issues/70#issuecomment-262985229\r\n> I cannot close the window either, I can only finish the program by pressing the ESC key. It might just be that SDL2 requires us to bind the event to some function (...)"},"comment":{"url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/issues/comments/263121298","html_url":"https://github.com/asrob-uc3m/robotDevastation/issues/81#issuecomment-263121298","issue_url":"https://api.github.com/repos/asrob-uc3m/robotDevastation/issues/81","id":263121298,"user":{"login":"David-Estevez","id":1451819,"avatar_url":"https://avatars.githubusercontent.com/u/1451819?v=3","gravatar_id":"","url":"https://api.github.com/users/David-Estevez","html_url":"https://github.com/David-Estevez","followers_url":"https://api.github.com/users/David-Estevez/followers","following_url":"https://api.github.com/users/David-Estevez/following{/other_user}","gists_url":"https://api.github.com/users/David-Estevez/gists{/gist_id}","starred_url":"https://api.github.com/users/David-Estevez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/David-Estevez/subscriptions","organizations_url":"https://api.github.com/users/David-Estevez/orgs","repos_url":"https://api.github.com/users/David-Estevez/repos","events_url":"https://api.github.com/users/David-Estevez/events{/privacy}","received_events_url":"https://api.github.com/users/David-Estevez/received_events","type":"User","site_admin":false},"created_at":"2016-11-27T13:07:46Z","updated_at":"2016-11-27T13:07:46Z","body":"One of my main concerns is that with these changes the encapsulation is broken in RdEventListener.\r\n\r\nCould it be possible to create a simple class RdWindowEvent such as this?\r\n\r\n```cpp\r\nclass RdWindowEvent \r\n{\r\n    public:\r\n        virtual int getEvent() = 0;\r\n        static const int WINDOW_CLOSED;\r\n}\r\n```\r\n\r\nThen, the SDLWindowEvent could be created inheriting from that class:\r\n\r\n```cpp\r\nclass SDLWindowEvent : public RdWindowEvent\r\n{\r\n    public:\r\n        SDLWindowEvent(const SDL_WindowEvent & windowEvent);\r\n        virtual int getEvent();\r\n}\r\n```\r\n\r\nAnd the encapsulation of the RdInputEventListener could be maintained:\r\n```cpp\r\nvirtual bool onWindowEvent( RdWindowEvent windowEvent ) = 0;\r\n```\r\nWhat do you think about this?"}}
{"actor":{"display_login":"David-Estevez"}}