{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/comments/63932470","id":63932470,"diff_hunk":"@@ -58,6 +75,13 @@ func runInstall(cmd *cobra.Command, args []string) error {\n \treturn nil\n }\n \n+func vals() ([]byte, error) {\n+\tif installValues == \"\" {\n+\t\treturn []byte{}, nil\n+\t}\n+\treturn ioutil.ReadFile(installValues)","path":"cmd/helm/install.go","position":55,"original_position":55,"commit_id":"d4bcbd6efba0af375c2ef1d3e5ada190e8719c1e","original_commit_id":"8c822cf1d9ceb0dd887bfed2df7470d85f63d45e","user":{"login":"fibonacci1729","id":7605165,"avatar_url":"https://avatars.githubusercontent.com/u/7605165?v=3","gravatar_id":"","url":"https://api.github.com/users/fibonacci1729","html_url":"https://github.com/fibonacci1729","followers_url":"https://api.github.com/users/fibonacci1729/followers","following_url":"https://api.github.com/users/fibonacci1729/following{/other_user}","gists_url":"https://api.github.com/users/fibonacci1729/gists{/gist_id}","starred_url":"https://api.github.com/users/fibonacci1729/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fibonacci1729/subscriptions","organizations_url":"https://api.github.com/users/fibonacci1729/orgs","repos_url":"https://api.github.com/users/fibonacci1729/repos","events_url":"https://api.github.com/users/fibonacci1729/events{/privacy}","received_events_url":"https://api.github.com/users/fibonacci1729/received_events","type":"User","site_admin":false},"body":"does this assume an absolute path? if so, should probably note in installValues description, e.g.  \"absolute path to a values TOML file\"","created_at":"2016-05-19T18:40:11Z","updated_at":"2016-05-19T18:40:11Z","html_url":"https://github.com/kubernetes/helm/pull/723#discussion_r63932470","pull_request_url":"https://api.github.com/repos/kubernetes/helm/pulls/723","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/comments/63932470"},"html":{"href":"https://github.com/kubernetes/helm/pull/723#discussion_r63932470"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/723","id":70589634,"html_url":"https://github.com/kubernetes/helm/pull/723","diff_url":"https://github.com/kubernetes/helm/pull/723.diff","patch_url":"https://github.com/kubernetes/helm/pull/723.patch","issue_url":"https://api.github.com/repos/kubernetes/helm/issues/723","number":723,"state":"open","locked":false,"title":"feat(helm): allow overriding values","user":{"login":"technosophos","id":89193,"avatar_url":"https://avatars.githubusercontent.com/u/89193?v=3","gravatar_id":"","url":"https://api.github.com/users/technosophos","html_url":"https://github.com/technosophos","followers_url":"https://api.github.com/users/technosophos/followers","following_url":"https://api.github.com/users/technosophos/following{/other_user}","gists_url":"https://api.github.com/users/technosophos/gists{/gist_id}","starred_url":"https://api.github.com/users/technosophos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technosophos/subscriptions","organizations_url":"https://api.github.com/users/technosophos/orgs","repos_url":"https://api.github.com/users/technosophos/repos","events_url":"https://api.github.com/users/technosophos/events{/privacy}","received_events_url":"https://api.github.com/users/technosophos/received_events","type":"User","site_admin":false},"body":"This supports the `-f` flag for overriding values with a specified\r\nTOML file.","created_at":"2016-05-18T19:59:49Z","updated_at":"2016-05-19T18:40:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"233b085b5e0c1599a03bb7feb2c1a320e7daf7e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/helm/pulls/723/commits","review_comments_url":"https://api.github.com/repos/kubernetes/helm/pulls/723/comments","review_comment_url":"https://api.github.com/repos/kubernetes/helm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/helm/issues/723/comments","statuses_url":"https://api.github.com/repos/kubernetes/helm/statuses/d4bcbd6efba0af375c2ef1d3e5ada190e8719c1e","head":{"label":"technosophos:feat/values-in-install","ref":"feat/values-in-install","sha":"d4bcbd6efba0af375c2ef1d3e5ada190e8719c1e","user":{"login":"technosophos","id":89193,"avatar_url":"https://avatars.githubusercontent.com/u/89193?v=3","gravatar_id":"","url":"https://api.github.com/users/technosophos","html_url":"https://github.com/technosophos","followers_url":"https://api.github.com/users/technosophos/followers","following_url":"https://api.github.com/users/technosophos/following{/other_user}","gists_url":"https://api.github.com/users/technosophos/gists{/gist_id}","starred_url":"https://api.github.com/users/technosophos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technosophos/subscriptions","organizations_url":"https://api.github.com/users/technosophos/orgs","repos_url":"https://api.github.com/users/technosophos/repos","events_url":"https://api.github.com/users/technosophos/events{/privacy}","received_events_url":"https://api.github.com/users/technosophos/received_events","type":"User","site_admin":false},"repo":{"id":49222838,"name":"k8s-helm","full_name":"technosophos/k8s-helm","owner":{"login":"technosophos","id":89193,"avatar_url":"https://avatars.githubusercontent.com/u/89193?v=3","gravatar_id":"","url":"https://api.github.com/users/technosophos","html_url":"https://github.com/technosophos","followers_url":"https://api.github.com/users/technosophos/followers","following_url":"https://api.github.com/users/technosophos/following{/other_user}","gists_url":"https://api.github.com/users/technosophos/gists{/gist_id}","starred_url":"https://api.github.com/users/technosophos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technosophos/subscriptions","organizations_url":"https://api.github.com/users/technosophos/orgs","repos_url":"https://api.github.com/users/technosophos/repos","events_url":"https://api.github.com/users/technosophos/events{/privacy}","received_events_url":"https://api.github.com/users/technosophos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/technosophos/k8s-helm","description":"Deployment Manager on Kubernetes","fork":true,"url":"https://api.github.com/repos/technosophos/k8s-helm","forks_url":"https://api.github.com/repos/technosophos/k8s-helm/forks","keys_url":"https://api.github.com/repos/technosophos/k8s-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/technosophos/k8s-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/technosophos/k8s-helm/teams","hooks_url":"https://api.github.com/repos/technosophos/k8s-helm/hooks","issue_events_url":"https://api.github.com/repos/technosophos/k8s-helm/issues/events{/number}","events_url":"https://api.github.com/repos/technosophos/k8s-helm/events","assignees_url":"https://api.github.com/repos/technosophos/k8s-helm/assignees{/user}","branches_url":"https://api.github.com/repos/technosophos/k8s-helm/branches{/branch}","tags_url":"https://api.github.com/repos/technosophos/k8s-helm/tags","blobs_url":"https://api.github.com/repos/technosophos/k8s-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/technosophos/k8s-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/technosophos/k8s-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/technosophos/k8s-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/technosophos/k8s-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/technosophos/k8s-helm/languages","stargazers_url":"https://api.github.com/repos/technosophos/k8s-helm/stargazers","contributors_url":"https://api.github.com/repos/technosophos/k8s-helm/contributors","subscribers_url":"https://api.github.com/repos/technosophos/k8s-helm/subscribers","subscription_url":"https://api.github.com/repos/technosophos/k8s-helm/subscription","commits_url":"https://api.github.com/repos/technosophos/k8s-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/technosophos/k8s-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/technosophos/k8s-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/technosophos/k8s-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/technosophos/k8s-helm/contents/{+path}","compare_url":"https://api.github.com/repos/technosophos/k8s-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/technosophos/k8s-helm/merges","archive_url":"https://api.github.com/repos/technosophos/k8s-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/technosophos/k8s-helm/downloads","issues_url":"https://api.github.com/repos/technosophos/k8s-helm/issues{/number}","pulls_url":"https://api.github.com/repos/technosophos/k8s-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/technosophos/k8s-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/technosophos/k8s-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/technosophos/k8s-helm/labels{/name}","releases_url":"https://api.github.com/repos/technosophos/k8s-helm/releases{/id}","deployments_url":"https://api.github.com/repos/technosophos/k8s-helm/deployments","created_at":"2016-01-07T18:35:57Z","updated_at":"2016-04-28T15:38:28Z","pushed_at":"2016-05-18T23:15:14Z","git_url":"git://github.com/technosophos/k8s-helm.git","ssh_url":"git@github.com:technosophos/k8s-helm.git","clone_url":"https://github.com/technosophos/k8s-helm.git","svn_url":"https://github.com/technosophos/k8s-helm","homepage":null,"size":1774,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"dde6bb37dd51a3f07ef4da4a9381dde9b6319884","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":43723161,"name":"helm","full_name":"kubernetes/helm","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/helm","description":"The Kubernetes Package Manager","fork":false,"url":"https://api.github.com/repos/kubernetes/helm","forks_url":"https://api.github.com/repos/kubernetes/helm/forks","keys_url":"https://api.github.com/repos/kubernetes/helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/helm/teams","hooks_url":"https://api.github.com/repos/kubernetes/helm/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/helm/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/helm/events","assignees_url":"https://api.github.com/repos/kubernetes/helm/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/helm/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/helm/tags","blobs_url":"https://api.github.com/repos/kubernetes/helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/helm/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/helm/languages","stargazers_url":"https://api.github.com/repos/kubernetes/helm/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/helm/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/helm/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/helm/subscription","commits_url":"https://api.github.com/repos/kubernetes/helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/helm/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/helm/merges","archive_url":"https://api.github.com/repos/kubernetes/helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/helm/downloads","issues_url":"https://api.github.com/repos/kubernetes/helm/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/helm/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/helm/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/helm/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/helm/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/helm/deployments","created_at":"2015-10-06T01:07:32Z","updated_at":"2016-05-19T09:21:12Z","pushed_at":"2016-05-19T17:51:58Z","git_url":"git://github.com/kubernetes/helm.git","ssh_url":"git@github.com:kubernetes/helm.git","clone_url":"https://github.com/kubernetes/helm.git","svn_url":"https://github.com/kubernetes/helm","homepage":"","size":7122,"stargazers_count":173,"watchers_count":173,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":41,"forks":50,"open_issues":41,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/723"},"html":{"href":"https://github.com/kubernetes/helm/pull/723"},"issue":{"href":"https://api.github.com/repos/kubernetes/helm/issues/723"},"comments":{"href":"https://api.github.com/repos/kubernetes/helm/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/helm/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/helm/statuses/d4bcbd6efba0af375c2ef1d3e5ada190e8719c1e"}}}}