{"action":"created","comment":{"url":"https://api.github.com/repos/urfave/cli/pulls/comments/88785897","pull_request_review_id":9351086,"id":88785897,"diff_hunk":"@@ -78,6 +80,11 @@ func loadDataFrom(filePath string) ([]byte, error) {\n \t\t\treturn nil, fmt.Errorf(\"Cannot read from file: '%s' because it does not exist.\", filePath)\n \t\t}\n \t\treturn ioutil.ReadFile(filePath)\n+\t} else if runtime.GOOS == \"windows\" && strings.Contains(u.String(), \"\\\\\") {","path":"altsrc/yaml_file_loader.go","position":13,"original_position":13,"commit_id":"9f357f76252fcd4446dbdd981dabd52b40c87481","original_commit_id":"9f357f76252fcd4446dbdd981dabd52b40c87481","user":{"login":"jszwedko","id":316880,"avatar_url":"https://avatars.githubusercontent.com/u/316880?v=3","gravatar_id":"","url":"https://api.github.com/users/jszwedko","html_url":"https://github.com/jszwedko","followers_url":"https://api.github.com/users/jszwedko/followers","following_url":"https://api.github.com/users/jszwedko/following{/other_user}","gists_url":"https://api.github.com/users/jszwedko/gists{/gist_id}","starred_url":"https://api.github.com/users/jszwedko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jszwedko/subscriptions","organizations_url":"https://api.github.com/users/jszwedko/orgs","repos_url":"https://api.github.com/users/jszwedko/repos","events_url":"https://api.github.com/users/jszwedko/events{/privacy}","received_events_url":"https://api.github.com/users/jszwedko/received_events","type":"User","site_admin":false},"body":"Aha, interesting, do you mind leaving a comment to that effect? That isn't immediately obvious looking at this code.","created_at":"2016-11-19T19:22:25Z","updated_at":"2016-11-19T19:22:25Z","html_url":"https://github.com/urfave/cli/pull/566#discussion_r88785897","pull_request_url":"https://api.github.com/repos/urfave/cli/pulls/566","_links":{"self":{"href":"https://api.github.com/repos/urfave/cli/pulls/comments/88785897"},"html":{"href":"https://github.com/urfave/cli/pull/566#discussion_r88785897"},"pull_request":{"href":"https://api.github.com/repos/urfave/cli/pulls/566"}}},"pull_request":{"url":"https://api.github.com/repos/urfave/cli/pulls/566","id":94196259,"html_url":"https://github.com/urfave/cli/pull/566","diff_url":"https://github.com/urfave/cli/pull/566.diff","patch_url":"https://github.com/urfave/cli/pull/566.patch","issue_url":"https://api.github.com/repos/urfave/cli/issues/566","number":566,"state":"open","locked":false,"title":"allow to load YAML configuration files on Windows","user":{"login":"fernandezvara","id":358493,"avatar_url":"https://avatars.githubusercontent.com/u/358493?v=3","gravatar_id":"","url":"https://api.github.com/users/fernandezvara","html_url":"https://github.com/fernandezvara","followers_url":"https://api.github.com/users/fernandezvara/followers","following_url":"https://api.github.com/users/fernandezvara/following{/other_user}","gists_url":"https://api.github.com/users/fernandezvara/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandezvara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandezvara/subscriptions","organizations_url":"https://api.github.com/users/fernandezvara/orgs","repos_url":"https://api.github.com/users/fernandezvara/repos","events_url":"https://api.github.com/users/fernandezvara/events{/privacy}","received_events_url":"https://api.github.com/users/fernandezvara/received_events","type":"User","site_admin":false},"body":"The function `loadDataFrom` does not take care of Windows users since any of the conditions met and it returns an error.\r\n\r\nThe change looks for the runtime where it's running and then if the filePath contains a `\\`.","created_at":"2016-11-17T16:03:20Z","updated_at":"2016-11-19T19:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e94c0350c5d28d7eb4c55d2b5540637db80bf7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/urfave/cli/pulls/566/commits","review_comments_url":"https://api.github.com/repos/urfave/cli/pulls/566/comments","review_comment_url":"https://api.github.com/repos/urfave/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urfave/cli/issues/566/comments","statuses_url":"https://api.github.com/repos/urfave/cli/statuses/9f357f76252fcd4446dbdd981dabd52b40c87481","head":{"label":"fernandezvara:v1","ref":"v1","sha":"9f357f76252fcd4446dbdd981dabd52b40c87481","user":{"login":"fernandezvara","id":358493,"avatar_url":"https://avatars.githubusercontent.com/u/358493?v=3","gravatar_id":"","url":"https://api.github.com/users/fernandezvara","html_url":"https://github.com/fernandezvara","followers_url":"https://api.github.com/users/fernandezvara/followers","following_url":"https://api.github.com/users/fernandezvara/following{/other_user}","gists_url":"https://api.github.com/users/fernandezvara/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandezvara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandezvara/subscriptions","organizations_url":"https://api.github.com/users/fernandezvara/orgs","repos_url":"https://api.github.com/users/fernandezvara/repos","events_url":"https://api.github.com/users/fernandezvara/events{/privacy}","received_events_url":"https://api.github.com/users/fernandezvara/received_events","type":"User","site_admin":false},"repo":{"id":74039277,"name":"cli","full_name":"fernandezvara/cli","owner":{"login":"fernandezvara","id":358493,"avatar_url":"https://avatars.githubusercontent.com/u/358493?v=3","gravatar_id":"","url":"https://api.github.com/users/fernandezvara","html_url":"https://github.com/fernandezvara","followers_url":"https://api.github.com/users/fernandezvara/followers","following_url":"https://api.github.com/users/fernandezvara/following{/other_user}","gists_url":"https://api.github.com/users/fernandezvara/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandezvara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandezvara/subscriptions","organizations_url":"https://api.github.com/users/fernandezvara/orgs","repos_url":"https://api.github.com/users/fernandezvara/repos","events_url":"https://api.github.com/users/fernandezvara/events{/privacy}","received_events_url":"https://api.github.com/users/fernandezvara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fernandezvara/cli","description":"A simple, fast, and fun package for building command line apps in Go","fork":true,"url":"https://api.github.com/repos/fernandezvara/cli","forks_url":"https://api.github.com/repos/fernandezvara/cli/forks","keys_url":"https://api.github.com/repos/fernandezvara/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fernandezvara/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fernandezvara/cli/teams","hooks_url":"https://api.github.com/repos/fernandezvara/cli/hooks","issue_events_url":"https://api.github.com/repos/fernandezvara/cli/issues/events{/number}","events_url":"https://api.github.com/repos/fernandezvara/cli/events","assignees_url":"https://api.github.com/repos/fernandezvara/cli/assignees{/user}","branches_url":"https://api.github.com/repos/fernandezvara/cli/branches{/branch}","tags_url":"https://api.github.com/repos/fernandezvara/cli/tags","blobs_url":"https://api.github.com/repos/fernandezvara/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fernandezvara/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fernandezvara/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/fernandezvara/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fernandezvara/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/fernandezvara/cli/languages","stargazers_url":"https://api.github.com/repos/fernandezvara/cli/stargazers","contributors_url":"https://api.github.com/repos/fernandezvara/cli/contributors","subscribers_url":"https://api.github.com/repos/fernandezvara/cli/subscribers","subscription_url":"https://api.github.com/repos/fernandezvara/cli/subscription","commits_url":"https://api.github.com/repos/fernandezvara/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/fernandezvara/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/fernandezvara/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/fernandezvara/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/fernandezvara/cli/contents/{+path}","compare_url":"https://api.github.com/repos/fernandezvara/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fernandezvara/cli/merges","archive_url":"https://api.github.com/repos/fernandezvara/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fernandezvara/cli/downloads","issues_url":"https://api.github.com/repos/fernandezvara/cli/issues{/number}","pulls_url":"https://api.github.com/repos/fernandezvara/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/fernandezvara/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/fernandezvara/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fernandezvara/cli/labels{/name}","releases_url":"https://api.github.com/repos/fernandezvara/cli/releases{/id}","deployments_url":"https://api.github.com/repos/fernandezvara/cli/deployments","created_at":"2016-11-17T15:17:56Z","updated_at":"2016-11-17T15:17:57Z","pushed_at":"2016-11-17T16:08:01Z","git_url":"git://github.com/fernandezvara/cli.git","ssh_url":"git@github.com:fernandezvara/cli.git","clone_url":"https://github.com/fernandezvara/cli.git","svn_url":"https://github.com/fernandezvara/cli","homepage":"","size":1001,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urfave:v1","ref":"v1","sha":"33bb4c121333cd8eb7d8cc8d74474f4ec156f371","user":{"login":"urfave","id":19274464,"avatar_url":"https://avatars.githubusercontent.com/u/19274464?v=3","gravatar_id":"","url":"https://api.github.com/users/urfave","html_url":"https://github.com/urfave","followers_url":"https://api.github.com/users/urfave/followers","following_url":"https://api.github.com/users/urfave/following{/other_user}","gists_url":"https://api.github.com/users/urfave/gists{/gist_id}","starred_url":"https://api.github.com/users/urfave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfave/subscriptions","organizations_url":"https://api.github.com/users/urfave/orgs","repos_url":"https://api.github.com/users/urfave/repos","events_url":"https://api.github.com/users/urfave/events{/privacy}","received_events_url":"https://api.github.com/users/urfave/received_events","type":"Organization","site_admin":false},"repo":{"id":11393110,"name":"cli","full_name":"urfave/cli","owner":{"login":"urfave","id":19274464,"avatar_url":"https://avatars.githubusercontent.com/u/19274464?v=3","gravatar_id":"","url":"https://api.github.com/users/urfave","html_url":"https://github.com/urfave","followers_url":"https://api.github.com/users/urfave/followers","following_url":"https://api.github.com/users/urfave/following{/other_user}","gists_url":"https://api.github.com/users/urfave/gists{/gist_id}","starred_url":"https://api.github.com/users/urfave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfave/subscriptions","organizations_url":"https://api.github.com/users/urfave/orgs","repos_url":"https://api.github.com/users/urfave/repos","events_url":"https://api.github.com/users/urfave/events{/privacy}","received_events_url":"https://api.github.com/users/urfave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urfave/cli","description":"A simple, fast, and fun package for building command line apps in Go","fork":false,"url":"https://api.github.com/repos/urfave/cli","forks_url":"https://api.github.com/repos/urfave/cli/forks","keys_url":"https://api.github.com/repos/urfave/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urfave/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urfave/cli/teams","hooks_url":"https://api.github.com/repos/urfave/cli/hooks","issue_events_url":"https://api.github.com/repos/urfave/cli/issues/events{/number}","events_url":"https://api.github.com/repos/urfave/cli/events","assignees_url":"https://api.github.com/repos/urfave/cli/assignees{/user}","branches_url":"https://api.github.com/repos/urfave/cli/branches{/branch}","tags_url":"https://api.github.com/repos/urfave/cli/tags","blobs_url":"https://api.github.com/repos/urfave/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urfave/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urfave/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/urfave/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urfave/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/urfave/cli/languages","stargazers_url":"https://api.github.com/repos/urfave/cli/stargazers","contributors_url":"https://api.github.com/repos/urfave/cli/contributors","subscribers_url":"https://api.github.com/repos/urfave/cli/subscribers","subscription_url":"https://api.github.com/repos/urfave/cli/subscription","commits_url":"https://api.github.com/repos/urfave/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/urfave/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/urfave/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/urfave/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/urfave/cli/contents/{+path}","compare_url":"https://api.github.com/repos/urfave/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urfave/cli/merges","archive_url":"https://api.github.com/repos/urfave/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urfave/cli/downloads","issues_url":"https://api.github.com/repos/urfave/cli/issues{/number}","pulls_url":"https://api.github.com/repos/urfave/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/urfave/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/urfave/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urfave/cli/labels{/name}","releases_url":"https://api.github.com/repos/urfave/cli/releases{/id}","deployments_url":"https://api.github.com/repos/urfave/cli/deployments","created_at":"2013-07-13T19:32:06Z","updated_at":"2016-11-19T18:01:32Z","pushed_at":"2016-11-19T19:05:29Z","git_url":"git://github.com/urfave/cli.git","ssh_url":"git@github.com:urfave/cli.git","clone_url":"https://github.com/urfave/cli.git","svn_url":"https://github.com/urfave/cli","homepage":"","size":2810,"stargazers_count":4941,"watchers_count":4941,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":496,"mirror_url":null,"open_issues_count":43,"forks":496,"open_issues":43,"watchers":4941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urfave/cli/pulls/566"},"html":{"href":"https://github.com/urfave/cli/pull/566"},"issue":{"href":"https://api.github.com/repos/urfave/cli/issues/566"},"comments":{"href":"https://api.github.com/repos/urfave/cli/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/urfave/cli/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/urfave/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urfave/cli/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/urfave/cli/statuses/9f357f76252fcd4446dbdd981dabd52b40c87481"}}}}
{"actor":{"display_login":"jszwedko"}}