{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/10215","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/10215/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/10215/comments","events_url":"https://api.github.com/repos/servo/servo/issues/10215/events","html_url":"https://github.com/servo/servo/pull/10215","id":143760362,"number":10215,"title":"WebGL: Finish, Flush, DetachShader, GenerateMipmap","user":{"login":"ConnorGBrewster","id":9086315,"avatar_url":"https://avatars.githubusercontent.com/u/9086315?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnorGBrewster","html_url":"https://github.com/ConnorGBrewster","followers_url":"https://api.github.com/users/ConnorGBrewster/followers","following_url":"https://api.github.com/users/ConnorGBrewster/following{/other_user}","gists_url":"https://api.github.com/users/ConnorGBrewster/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorGBrewster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorGBrewster/subscriptions","organizations_url":"https://api.github.com/users/ConnorGBrewster/orgs","repos_url":"https://api.github.com/users/ConnorGBrewster/repos","events_url":"https://api.github.com/users/ConnorGBrewster/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorGBrewster/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-answer","name":"S-awaiting-answer","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"},{"url":"https://api.github.com/repos/servo/servo/labels/S-blocked-on-external","name":"S-blocked-on-external","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"milestone":null,"comments":22,"created_at":"2016-03-26T23:54:16Z","updated_at":"2016-04-02T16:49:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/10215","html_url":"https://github.com/servo/servo/pull/10215","diff_url":"https://github.com/servo/servo/pull/10215.diff","patch_url":"https://github.com/servo/servo/pull/10215.patch"},"body":"Implements #10212 and #10213\r\n\r\nr? @emilio\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/10215)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/204756351","html_url":"https://github.com/servo/servo/pull/10215#issuecomment-204756351","issue_url":"https://api.github.com/repos/servo/servo/issues/10215","id":204756351,"user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"created_at":"2016-04-02T16:49:14Z","updated_at":"2016-04-02T16:49:14Z","body":"\n\n\n\nReview status: 6 of 10 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[components/script/dom/webgltexture.rs, line 288 \\[r13\\]](https://reviewable.io:443/reviews/servo/servo/10215#-KELu3mfGVkEZDchic7n:-KEMrOezsd8n3x0Dh-Pu:1356658486) ([raw file](https://github.com/servo/servo/blob/08c596c396b9350c23d7ad578b7ebe52104716c6/components/script/dom/webgltexture.rs#L288)):*\nAhh I see, maybe using an extra block could avoid that, but anyway, this is a sligh optimisation, so there's no problem :)\n\n---\n\n*[tests/html/test_webgl_texture_mipmaps.html, line 36 \\[r13\\]](https://reviewable.io:443/reviews/servo/servo/10215#-KELwwBhP0aMhSGyMq9v:-KEMrnL-jxefc89oGAwO:1588863563) ([raw file](https://github.com/servo/servo/blob/08c596c396b9350c23d7ad578b7ebe52104716c6/tests/html/test_webgl_texture_mipmaps.html#L36)):*\nGotcha, missed that.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/servo/servo/10215)*\n<!-- Sent from Reviewable.io -->\n"}}