{"action":"created","comment":{"url":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/comments/89056629","pull_request_review_id":9607251,"id":89056629,"diff_hunk":"@@ -31,19 +31,39 @@ const closeArgsToError = (code, signal) => {\n   return null\n }\n \n+const concatBuffer = (buffer) => {\n+  if (buffer.length) {\n+    return\n+  } else if (typeof buffer[0] === 'string') {\n+    result = buffer.join('')\n+  } else if (buffer[0] instanceof Buffer) {\n+    result = Buffer.concat(buffer)\n+  } else {\n+    // throw new Error('Unexpected buffer type')\n+    return","path":"src/index.js","position":13,"original_position":13,"commit_id":"0b6c269e2d039025022a2ada19fbf7572f75cfc0","original_commit_id":"0b6c269e2d039025022a2ada19fbf7572f75cfc0","user":{"login":"laggingreflex","id":2523987,"avatar_url":"https://avatars.githubusercontent.com/u/2523987?v=3","gravatar_id":"","url":"https://api.github.com/users/laggingreflex","html_url":"https://github.com/laggingreflex","followers_url":"https://api.github.com/users/laggingreflex/followers","following_url":"https://api.github.com/users/laggingreflex/following{/other_user}","gists_url":"https://api.github.com/users/laggingreflex/gists{/gist_id}","starred_url":"https://api.github.com/users/laggingreflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laggingreflex/subscriptions","organizations_url":"https://api.github.com/users/laggingreflex/orgs","repos_url":"https://api.github.com/users/laggingreflex/repos","events_url":"https://api.github.com/users/laggingreflex/events{/privacy}","received_events_url":"https://api.github.com/users/laggingreflex/received_events","type":"User","site_admin":false},"body":"This case probably shouldn't occur but I'm not sure whether to throw error or just return?","created_at":"2016-11-22T07:39:55Z","updated_at":"2016-11-22T07:39:55Z","html_url":"https://github.com/zentrick/cross-spawn-promise/pull/41#discussion_r89056629","pull_request_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/comments/89056629"},"html":{"href":"https://github.com/zentrick/cross-spawn-promise/pull/41#discussion_r89056629"},"pull_request":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41","id":94543916,"html_url":"https://github.com/zentrick/cross-spawn-promise/pull/41","diff_url":"https://github.com/zentrick/cross-spawn-promise/pull/41.diff","patch_url":"https://github.com/zentrick/cross-spawn-promise/pull/41.patch","issue_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/issues/41","number":41,"state":"open","locked":false,"title":"support {encoding: 'utf8'}","user":{"login":"laggingreflex","id":2523987,"avatar_url":"https://avatars.githubusercontent.com/u/2523987?v=3","gravatar_id":"","url":"https://api.github.com/users/laggingreflex","html_url":"https://github.com/laggingreflex","followers_url":"https://api.github.com/users/laggingreflex/followers","following_url":"https://api.github.com/users/laggingreflex/following{/other_user}","gists_url":"https://api.github.com/users/laggingreflex/gists{/gist_id}","starred_url":"https://api.github.com/users/laggingreflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laggingreflex/subscriptions","organizations_url":"https://api.github.com/users/laggingreflex/orgs","repos_url":"https://api.github.com/users/laggingreflex/repos","events_url":"https://api.github.com/users/laggingreflex/events{/privacy}","received_events_url":"https://api.github.com/users/laggingreflex/received_events","type":"User","site_admin":false},"body":"If `{encoding: 'utf8'}` is passed in options, it converts `stdout` and `stderr` toString\r\n\r\nfixes #40","created_at":"2016-11-21T01:57:40Z","updated_at":"2016-11-22T07:39:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39c1e89bed2ce2ba6b9b696a04732958b32d544e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41/commits","review_comments_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41/comments","review_comment_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/issues/41/comments","statuses_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/statuses/0b6c269e2d039025022a2ada19fbf7572f75cfc0","head":{"label":"laggingreflex:utf-encoding","ref":"utf-encoding","sha":"0b6c269e2d039025022a2ada19fbf7572f75cfc0","user":{"login":"laggingreflex","id":2523987,"avatar_url":"https://avatars.githubusercontent.com/u/2523987?v=3","gravatar_id":"","url":"https://api.github.com/users/laggingreflex","html_url":"https://github.com/laggingreflex","followers_url":"https://api.github.com/users/laggingreflex/followers","following_url":"https://api.github.com/users/laggingreflex/following{/other_user}","gists_url":"https://api.github.com/users/laggingreflex/gists{/gist_id}","starred_url":"https://api.github.com/users/laggingreflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laggingreflex/subscriptions","organizations_url":"https://api.github.com/users/laggingreflex/orgs","repos_url":"https://api.github.com/users/laggingreflex/repos","events_url":"https://api.github.com/users/laggingreflex/events{/privacy}","received_events_url":"https://api.github.com/users/laggingreflex/received_events","type":"User","site_admin":false},"repo":{"id":74294976,"name":"cross-spawn-promise","full_name":"laggingreflex/cross-spawn-promise","owner":{"login":"laggingreflex","id":2523987,"avatar_url":"https://avatars.githubusercontent.com/u/2523987?v=3","gravatar_id":"","url":"https://api.github.com/users/laggingreflex","html_url":"https://github.com/laggingreflex","followers_url":"https://api.github.com/users/laggingreflex/followers","following_url":"https://api.github.com/users/laggingreflex/following{/other_user}","gists_url":"https://api.github.com/users/laggingreflex/gists{/gist_id}","starred_url":"https://api.github.com/users/laggingreflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laggingreflex/subscriptions","organizations_url":"https://api.github.com/users/laggingreflex/orgs","repos_url":"https://api.github.com/users/laggingreflex/repos","events_url":"https://api.github.com/users/laggingreflex/events{/privacy}","received_events_url":"https://api.github.com/users/laggingreflex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laggingreflex/cross-spawn-promise","description":"Promisified cross-spawn.","fork":true,"url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise","forks_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/forks","keys_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/teams","hooks_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/hooks","issue_events_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/issues/events{/number}","events_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/events","assignees_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/assignees{/user}","branches_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/branches{/branch}","tags_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/tags","blobs_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/git/refs{/sha}","trees_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/statuses/{sha}","languages_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/languages","stargazers_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/stargazers","contributors_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/contributors","subscribers_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/subscribers","subscription_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/subscription","commits_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/commits{/sha}","git_commits_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/git/commits{/sha}","comments_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/comments{/number}","issue_comment_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/issues/comments{/number}","contents_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/contents/{+path}","compare_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/merges","archive_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/downloads","issues_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/issues{/number}","pulls_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/pulls{/number}","milestones_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/milestones{/number}","notifications_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/labels{/name}","releases_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/releases{/id}","deployments_url":"https://api.github.com/repos/laggingreflex/cross-spawn-promise/deployments","created_at":"2016-11-20T18:45:35Z","updated_at":"2016-11-20T18:45:36Z","pushed_at":"2016-11-22T07:37:50Z","git_url":"git://github.com/laggingreflex/cross-spawn-promise.git","ssh_url":"git@github.com:laggingreflex/cross-spawn-promise.git","clone_url":"https://github.com/laggingreflex/cross-spawn-promise.git","svn_url":"https://github.com/laggingreflex/cross-spawn-promise","homepage":"","size":27,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zentrick:master","ref":"master","sha":"012a2abcf10c43d9aaf4821de152886af2f7aaf7","user":{"login":"zentrick","id":6871090,"avatar_url":"https://avatars.githubusercontent.com/u/6871090?v=3","gravatar_id":"","url":"https://api.github.com/users/zentrick","html_url":"https://github.com/zentrick","followers_url":"https://api.github.com/users/zentrick/followers","following_url":"https://api.github.com/users/zentrick/following{/other_user}","gists_url":"https://api.github.com/users/zentrick/gists{/gist_id}","starred_url":"https://api.github.com/users/zentrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentrick/subscriptions","organizations_url":"https://api.github.com/users/zentrick/orgs","repos_url":"https://api.github.com/users/zentrick/repos","events_url":"https://api.github.com/users/zentrick/events{/privacy}","received_events_url":"https://api.github.com/users/zentrick/received_events","type":"Organization","site_admin":false},"repo":{"id":52973730,"name":"cross-spawn-promise","full_name":"zentrick/cross-spawn-promise","owner":{"login":"zentrick","id":6871090,"avatar_url":"https://avatars.githubusercontent.com/u/6871090?v=3","gravatar_id":"","url":"https://api.github.com/users/zentrick","html_url":"https://github.com/zentrick","followers_url":"https://api.github.com/users/zentrick/followers","following_url":"https://api.github.com/users/zentrick/following{/other_user}","gists_url":"https://api.github.com/users/zentrick/gists{/gist_id}","starred_url":"https://api.github.com/users/zentrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zentrick/subscriptions","organizations_url":"https://api.github.com/users/zentrick/orgs","repos_url":"https://api.github.com/users/zentrick/repos","events_url":"https://api.github.com/users/zentrick/events{/privacy}","received_events_url":"https://api.github.com/users/zentrick/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zentrick/cross-spawn-promise","description":"Promisified cross-spawn.","fork":false,"url":"https://api.github.com/repos/zentrick/cross-spawn-promise","forks_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/forks","keys_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/teams","hooks_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/hooks","issue_events_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/issues/events{/number}","events_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/events","assignees_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/assignees{/user}","branches_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/branches{/branch}","tags_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/tags","blobs_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/git/refs{/sha}","trees_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/statuses/{sha}","languages_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/languages","stargazers_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/stargazers","contributors_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/contributors","subscribers_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/subscribers","subscription_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/subscription","commits_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/commits{/sha}","git_commits_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/git/commits{/sha}","comments_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/comments{/number}","issue_comment_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/issues/comments{/number}","contents_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/contents/{+path}","compare_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/merges","archive_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/downloads","issues_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/issues{/number}","pulls_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls{/number}","milestones_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/milestones{/number}","notifications_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/labels{/name}","releases_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/releases{/id}","deployments_url":"https://api.github.com/repos/zentrick/cross-spawn-promise/deployments","created_at":"2016-03-02T15:28:32Z","updated_at":"2016-11-06T00:28:03Z","pushed_at":"2016-11-22T07:37:50Z","git_url":"git://github.com/zentrick/cross-spawn-promise.git","ssh_url":"git@github.com:zentrick/cross-spawn-promise.git","clone_url":"https://github.com/zentrick/cross-spawn-promise.git","svn_url":"https://github.com/zentrick/cross-spawn-promise","homepage":"","size":43,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41"},"html":{"href":"https://github.com/zentrick/cross-spawn-promise/pull/41"},"issue":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/issues/41"},"comments":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/zentrick/cross-spawn-promise/statuses/0b6c269e2d039025022a2ada19fbf7572f75cfc0"}}}}
{"actor":{"display_login":"laggingreflex"}}