{"action":"created","comment":{"url":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/comments/65428554","id":65428554,"diff_hunk":"@@ -513,10 +513,19 @@ typedef struct {\n \tif( deFileNameLength > 0 )\r\n \t\tchar     deFileName[ deFileNameLength ];\r\n \tlocal int len = deExtraFieldLength;\r\n+\r\n \twhile (len > 0)\r\n \t{\r\n-\t\tEXTRAFIELD deExtraField;\r\n-\t\tlen -= deExtraField.efDataSize + 4;\r\n+        Printf(\"at --> %d\\n\", FTell());\r","path":"Templates/ZIPTemplateAdv.bt","position":null,"original_position":9,"commit_id":"bfc50f473860bf239915fa087645b7d864574fcb","original_commit_id":"a3f41caa6726d4da37191afe64cf288c8d7e2515","user":{"login":"strazzere","id":623686,"avatar_url":"https://avatars.githubusercontent.com/u/623686?v=3","gravatar_id":"","url":"https://api.github.com/users/strazzere","html_url":"https://github.com/strazzere","followers_url":"https://api.github.com/users/strazzere/followers","following_url":"https://api.github.com/users/strazzere/following{/other_user}","gists_url":"https://api.github.com/users/strazzere/gists{/gist_id}","starred_url":"https://api.github.com/users/strazzere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strazzere/subscriptions","organizations_url":"https://api.github.com/users/strazzere/orgs","repos_url":"https://api.github.com/users/strazzere/repos","events_url":"https://api.github.com/users/strazzere/events{/privacy}","received_events_url":"https://api.github.com/users/strazzere/received_events","type":"User","site_admin":false},"body":"Can we remove this (debug?) statement?","created_at":"2016-06-01T19:42:43Z","updated_at":"2016-06-01T19:42:43Z","html_url":"https://github.com/strazzere/010Editor-stuff/pull/12#discussion_r65428554","pull_request_url":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/comments/65428554"},"html":{"href":"https://github.com/strazzere/010Editor-stuff/pull/12#discussion_r65428554"},"pull_request":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12","id":71894684,"html_url":"https://github.com/strazzere/010Editor-stuff/pull/12","diff_url":"https://github.com/strazzere/010Editor-stuff/pull/12.diff","patch_url":"https://github.com/strazzere/010Editor-stuff/pull/12.patch","issue_url":"https://api.github.com/repos/strazzere/010Editor-stuff/issues/12","number":12,"state":"open","locked":false,"title":"Short Data Descriptors","user":{"login":"reox","id":431045,"avatar_url":"https://avatars.githubusercontent.com/u/431045?v=3","gravatar_id":"","url":"https://api.github.com/users/reox","html_url":"https://github.com/reox","followers_url":"https://api.github.com/users/reox/followers","following_url":"https://api.github.com/users/reox/following{/other_user}","gists_url":"https://api.github.com/users/reox/gists{/gist_id}","starred_url":"https://api.github.com/users/reox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reox/subscriptions","organizations_url":"https://api.github.com/users/reox/orgs","repos_url":"https://api.github.com/users/reox/repos","events_url":"https://api.github.com/users/reox/events{/privacy}","received_events_url":"https://api.github.com/users/reox/received_events","type":"User","site_admin":false},"body":"Hi!\r\nAs I found out, it is possible that data descriptors do not have a signature. See https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT \r\n\r\n> 4.3.9.3 Although not originally assigned a signature, the value \r\n> 0x08074b50 has commonly been adopted as a signature value \r\n> for the data descriptor record.  Implementers should be \r\n> aware that ZIP files may be encountered with or without this \r\n> signature marking data descriptors and SHOULD account for\r\n> either case when reading ZIP files to ensure compatibility.\r\n\r\nI added an extra check for that and the template works now with files that have this signature not set.","created_at":"2016-05-30T12:25:19Z","updated_at":"2016-06-01T19:42:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65a27727babde4f5ac9c663ba16587d3a7ebe87b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12/commits","review_comments_url":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12/comments","review_comment_url":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strazzere/010Editor-stuff/issues/12/comments","statuses_url":"https://api.github.com/repos/strazzere/010Editor-stuff/statuses/bfc50f473860bf239915fa087645b7d864574fcb","head":{"label":"reox:master","ref":"master","sha":"bfc50f473860bf239915fa087645b7d864574fcb","user":{"login":"reox","id":431045,"avatar_url":"https://avatars.githubusercontent.com/u/431045?v=3","gravatar_id":"","url":"https://api.github.com/users/reox","html_url":"https://github.com/reox","followers_url":"https://api.github.com/users/reox/followers","following_url":"https://api.github.com/users/reox/following{/other_user}","gists_url":"https://api.github.com/users/reox/gists{/gist_id}","starred_url":"https://api.github.com/users/reox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reox/subscriptions","organizations_url":"https://api.github.com/users/reox/orgs","repos_url":"https://api.github.com/users/reox/repos","events_url":"https://api.github.com/users/reox/events{/privacy}","received_events_url":"https://api.github.com/users/reox/received_events","type":"User","site_admin":false},"repo":{"id":42644635,"name":"010Editor-stuff","full_name":"reox/010Editor-stuff","owner":{"login":"reox","id":431045,"avatar_url":"https://avatars.githubusercontent.com/u/431045?v=3","gravatar_id":"","url":"https://api.github.com/users/reox","html_url":"https://github.com/reox","followers_url":"https://api.github.com/users/reox/followers","following_url":"https://api.github.com/users/reox/following{/other_user}","gists_url":"https://api.github.com/users/reox/gists{/gist_id}","starred_url":"https://api.github.com/users/reox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reox/subscriptions","organizations_url":"https://api.github.com/users/reox/orgs","repos_url":"https://api.github.com/users/reox/repos","events_url":"https://api.github.com/users/reox/events{/privacy}","received_events_url":"https://api.github.com/users/reox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reox/010Editor-stuff","description":"A collection of 010 Editor specific stuff","fork":true,"url":"https://api.github.com/repos/reox/010Editor-stuff","forks_url":"https://api.github.com/repos/reox/010Editor-stuff/forks","keys_url":"https://api.github.com/repos/reox/010Editor-stuff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reox/010Editor-stuff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reox/010Editor-stuff/teams","hooks_url":"https://api.github.com/repos/reox/010Editor-stuff/hooks","issue_events_url":"https://api.github.com/repos/reox/010Editor-stuff/issues/events{/number}","events_url":"https://api.github.com/repos/reox/010Editor-stuff/events","assignees_url":"https://api.github.com/repos/reox/010Editor-stuff/assignees{/user}","branches_url":"https://api.github.com/repos/reox/010Editor-stuff/branches{/branch}","tags_url":"https://api.github.com/repos/reox/010Editor-stuff/tags","blobs_url":"https://api.github.com/repos/reox/010Editor-stuff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reox/010Editor-stuff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reox/010Editor-stuff/git/refs{/sha}","trees_url":"https://api.github.com/repos/reox/010Editor-stuff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reox/010Editor-stuff/statuses/{sha}","languages_url":"https://api.github.com/repos/reox/010Editor-stuff/languages","stargazers_url":"https://api.github.com/repos/reox/010Editor-stuff/stargazers","contributors_url":"https://api.github.com/repos/reox/010Editor-stuff/contributors","subscribers_url":"https://api.github.com/repos/reox/010Editor-stuff/subscribers","subscription_url":"https://api.github.com/repos/reox/010Editor-stuff/subscription","commits_url":"https://api.github.com/repos/reox/010Editor-stuff/commits{/sha}","git_commits_url":"https://api.github.com/repos/reox/010Editor-stuff/git/commits{/sha}","comments_url":"https://api.github.com/repos/reox/010Editor-stuff/comments{/number}","issue_comment_url":"https://api.github.com/repos/reox/010Editor-stuff/issues/comments{/number}","contents_url":"https://api.github.com/repos/reox/010Editor-stuff/contents/{+path}","compare_url":"https://api.github.com/repos/reox/010Editor-stuff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reox/010Editor-stuff/merges","archive_url":"https://api.github.com/repos/reox/010Editor-stuff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reox/010Editor-stuff/downloads","issues_url":"https://api.github.com/repos/reox/010Editor-stuff/issues{/number}","pulls_url":"https://api.github.com/repos/reox/010Editor-stuff/pulls{/number}","milestones_url":"https://api.github.com/repos/reox/010Editor-stuff/milestones{/number}","notifications_url":"https://api.github.com/repos/reox/010Editor-stuff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reox/010Editor-stuff/labels{/name}","releases_url":"https://api.github.com/repos/reox/010Editor-stuff/releases{/id}","deployments_url":"https://api.github.com/repos/reox/010Editor-stuff/deployments","created_at":"2015-09-17T08:31:04Z","updated_at":"2016-05-30T12:21:14Z","pushed_at":"2016-05-30T12:21:13Z","git_url":"git://github.com/reox/010Editor-stuff.git","ssh_url":"git@github.com:reox/010Editor-stuff.git","clone_url":"https://github.com/reox/010Editor-stuff.git","svn_url":"https://github.com/reox/010Editor-stuff","homepage":null,"size":160,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strazzere:master","ref":"master","sha":"e80c730bd9d8366f2b1ae1a2e02362ab7b54c40c","user":{"login":"strazzere","id":623686,"avatar_url":"https://avatars.githubusercontent.com/u/623686?v=3","gravatar_id":"","url":"https://api.github.com/users/strazzere","html_url":"https://github.com/strazzere","followers_url":"https://api.github.com/users/strazzere/followers","following_url":"https://api.github.com/users/strazzere/following{/other_user}","gists_url":"https://api.github.com/users/strazzere/gists{/gist_id}","starred_url":"https://api.github.com/users/strazzere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strazzere/subscriptions","organizations_url":"https://api.github.com/users/strazzere/orgs","repos_url":"https://api.github.com/users/strazzere/repos","events_url":"https://api.github.com/users/strazzere/events{/privacy}","received_events_url":"https://api.github.com/users/strazzere/received_events","type":"User","site_admin":false},"repo":{"id":6097877,"name":"010Editor-stuff","full_name":"strazzere/010Editor-stuff","owner":{"login":"strazzere","id":623686,"avatar_url":"https://avatars.githubusercontent.com/u/623686?v=3","gravatar_id":"","url":"https://api.github.com/users/strazzere","html_url":"https://github.com/strazzere","followers_url":"https://api.github.com/users/strazzere/followers","following_url":"https://api.github.com/users/strazzere/following{/other_user}","gists_url":"https://api.github.com/users/strazzere/gists{/gist_id}","starred_url":"https://api.github.com/users/strazzere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strazzere/subscriptions","organizations_url":"https://api.github.com/users/strazzere/orgs","repos_url":"https://api.github.com/users/strazzere/repos","events_url":"https://api.github.com/users/strazzere/events{/privacy}","received_events_url":"https://api.github.com/users/strazzere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/strazzere/010Editor-stuff","description":"A collection of 010 Editor specific stuff","fork":false,"url":"https://api.github.com/repos/strazzere/010Editor-stuff","forks_url":"https://api.github.com/repos/strazzere/010Editor-stuff/forks","keys_url":"https://api.github.com/repos/strazzere/010Editor-stuff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strazzere/010Editor-stuff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strazzere/010Editor-stuff/teams","hooks_url":"https://api.github.com/repos/strazzere/010Editor-stuff/hooks","issue_events_url":"https://api.github.com/repos/strazzere/010Editor-stuff/issues/events{/number}","events_url":"https://api.github.com/repos/strazzere/010Editor-stuff/events","assignees_url":"https://api.github.com/repos/strazzere/010Editor-stuff/assignees{/user}","branches_url":"https://api.github.com/repos/strazzere/010Editor-stuff/branches{/branch}","tags_url":"https://api.github.com/repos/strazzere/010Editor-stuff/tags","blobs_url":"https://api.github.com/repos/strazzere/010Editor-stuff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strazzere/010Editor-stuff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strazzere/010Editor-stuff/git/refs{/sha}","trees_url":"https://api.github.com/repos/strazzere/010Editor-stuff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strazzere/010Editor-stuff/statuses/{sha}","languages_url":"https://api.github.com/repos/strazzere/010Editor-stuff/languages","stargazers_url":"https://api.github.com/repos/strazzere/010Editor-stuff/stargazers","contributors_url":"https://api.github.com/repos/strazzere/010Editor-stuff/contributors","subscribers_url":"https://api.github.com/repos/strazzere/010Editor-stuff/subscribers","subscription_url":"https://api.github.com/repos/strazzere/010Editor-stuff/subscription","commits_url":"https://api.github.com/repos/strazzere/010Editor-stuff/commits{/sha}","git_commits_url":"https://api.github.com/repos/strazzere/010Editor-stuff/git/commits{/sha}","comments_url":"https://api.github.com/repos/strazzere/010Editor-stuff/comments{/number}","issue_comment_url":"https://api.github.com/repos/strazzere/010Editor-stuff/issues/comments{/number}","contents_url":"https://api.github.com/repos/strazzere/010Editor-stuff/contents/{+path}","compare_url":"https://api.github.com/repos/strazzere/010Editor-stuff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strazzere/010Editor-stuff/merges","archive_url":"https://api.github.com/repos/strazzere/010Editor-stuff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strazzere/010Editor-stuff/downloads","issues_url":"https://api.github.com/repos/strazzere/010Editor-stuff/issues{/number}","pulls_url":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls{/number}","milestones_url":"https://api.github.com/repos/strazzere/010Editor-stuff/milestones{/number}","notifications_url":"https://api.github.com/repos/strazzere/010Editor-stuff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strazzere/010Editor-stuff/labels{/name}","releases_url":"https://api.github.com/repos/strazzere/010Editor-stuff/releases{/id}","deployments_url":"https://api.github.com/repos/strazzere/010Editor-stuff/deployments","created_at":"2012-10-05T23:03:43Z","updated_at":"2016-05-31T02:35:26Z","pushed_at":"2016-05-30T12:25:20Z","git_url":"git://github.com/strazzere/010Editor-stuff.git","ssh_url":"git@github.com:strazzere/010Editor-stuff.git","clone_url":"https://github.com/strazzere/010Editor-stuff.git","svn_url":"https://github.com/strazzere/010Editor-stuff","homepage":null,"size":237,"stargazers_count":128,"watchers_count":128,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":3,"forks":71,"open_issues":3,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12"},"html":{"href":"https://github.com/strazzere/010Editor-stuff/pull/12"},"issue":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/issues/12"},"comments":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/strazzere/010Editor-stuff/statuses/bfc50f473860bf239915fa087645b7d864574fcb"}}}}
{"actor":{"display_login":"strazzere"}}