{"action":"closed","number":71,"pull_request":{"url":"https://api.github.com/repos/nkbt/react-collapse/pulls/71","id":80451582,"html_url":"https://github.com/nkbt/react-collapse/pull/71","diff_url":"https://github.com/nkbt/react-collapse/pull/71.diff","patch_url":"https://github.com/nkbt/react-collapse/pull/71.patch","issue_url":"https://api.github.com/repos/nkbt/react-collapse/issues/71","number":71,"state":"closed","locked":false,"title":"[WIP] Rewrite","user":{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false},"body":"Well... hmmm... full rewrite\r\n\r\n- [x] ~~get rid of defaultStyle~~ actually need it for react-motion\r\n- [x] measure height before collapsing\r\n- [x] get rid of fixed height case \r\n- [x] fix examples to behave correctly\r\n- [x] get rid of `keepCollapsedContent` option, always keep instead\r\n- [x] Fixes #40, Re-render nested components\r\n- [x] Fixes #51, Animation finished callback\r\n- [ ] Fixes #59, instantly collapses if rerendered during collapse\r\n- [ ] Fixes #66, Unnecessary unmount with keepCollapsedContent\r\n- [x] Fixes #53, Move react-height back to dependencies","created_at":"2016-08-08T13:33:45Z","updated_at":"2016-08-11T11:09:46Z","closed_at":"2016-08-11T11:09:46Z","merged_at":null,"merge_commit_sha":"d8ee9ec91fd46674424facb870c83f5a88a02e09","assignee":{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false},"assignees":[{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nkbt/react-collapse/pulls/71/commits","review_comments_url":"https://api.github.com/repos/nkbt/react-collapse/pulls/71/comments","review_comment_url":"https://api.github.com/repos/nkbt/react-collapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nkbt/react-collapse/issues/71/comments","statuses_url":"https://api.github.com/repos/nkbt/react-collapse/statuses/103e6f1cd667559a8949dec7aeb262eb48221f9b","head":{"label":"nkbt:40-measure-height-before-collapse","ref":"40-measure-height-before-collapse","sha":"103e6f1cd667559a8949dec7aeb262eb48221f9b","user":{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false},"repo":{"id":44314962,"name":"react-collapse","full_name":"nkbt/react-collapse","owner":{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkbt/react-collapse","description":"Component-wrapper for collapse animation with react-motion for elements with variable (and dynamic) height","fork":false,"url":"https://api.github.com/repos/nkbt/react-collapse","forks_url":"https://api.github.com/repos/nkbt/react-collapse/forks","keys_url":"https://api.github.com/repos/nkbt/react-collapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkbt/react-collapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkbt/react-collapse/teams","hooks_url":"https://api.github.com/repos/nkbt/react-collapse/hooks","issue_events_url":"https://api.github.com/repos/nkbt/react-collapse/issues/events{/number}","events_url":"https://api.github.com/repos/nkbt/react-collapse/events","assignees_url":"https://api.github.com/repos/nkbt/react-collapse/assignees{/user}","branches_url":"https://api.github.com/repos/nkbt/react-collapse/branches{/branch}","tags_url":"https://api.github.com/repos/nkbt/react-collapse/tags","blobs_url":"https://api.github.com/repos/nkbt/react-collapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkbt/react-collapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkbt/react-collapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkbt/react-collapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkbt/react-collapse/statuses/{sha}","languages_url":"https://api.github.com/repos/nkbt/react-collapse/languages","stargazers_url":"https://api.github.com/repos/nkbt/react-collapse/stargazers","contributors_url":"https://api.github.com/repos/nkbt/react-collapse/contributors","subscribers_url":"https://api.github.com/repos/nkbt/react-collapse/subscribers","subscription_url":"https://api.github.com/repos/nkbt/react-collapse/subscription","commits_url":"https://api.github.com/repos/nkbt/react-collapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkbt/react-collapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkbt/react-collapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkbt/react-collapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkbt/react-collapse/contents/{+path}","compare_url":"https://api.github.com/repos/nkbt/react-collapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkbt/react-collapse/merges","archive_url":"https://api.github.com/repos/nkbt/react-collapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkbt/react-collapse/downloads","issues_url":"https://api.github.com/repos/nkbt/react-collapse/issues{/number}","pulls_url":"https://api.github.com/repos/nkbt/react-collapse/pulls{/number}","milestones_url":"https://api.github.com/repos/nkbt/react-collapse/milestones{/number}","notifications_url":"https://api.github.com/repos/nkbt/react-collapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkbt/react-collapse/labels{/name}","releases_url":"https://api.github.com/repos/nkbt/react-collapse/releases{/id}","deployments_url":"https://api.github.com/repos/nkbt/react-collapse/deployments","created_at":"2015-10-15T12:10:12Z","updated_at":"2016-08-11T08:46:57Z","pushed_at":"2016-08-11T11:07:52Z","git_url":"git://github.com/nkbt/react-collapse.git","ssh_url":"git@github.com:nkbt/react-collapse.git","clone_url":"https://github.com/nkbt/react-collapse.git","svn_url":"https://github.com/nkbt/react-collapse","homepage":null,"size":3167,"stargazers_count":240,"watchers_count":240,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":17,"forks":31,"open_issues":17,"watchers":240,"default_branch":"master"}},"base":{"label":"nkbt:master","ref":"master","sha":"c52888bc2443a4f38f8a2625c0c65bc3cecf622d","user":{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false},"repo":{"id":44314962,"name":"react-collapse","full_name":"nkbt/react-collapse","owner":{"login":"nkbt","id":175264,"avatar_url":"https://avatars.githubusercontent.com/u/175264?v=3","gravatar_id":"","url":"https://api.github.com/users/nkbt","html_url":"https://github.com/nkbt","followers_url":"https://api.github.com/users/nkbt/followers","following_url":"https://api.github.com/users/nkbt/following{/other_user}","gists_url":"https://api.github.com/users/nkbt/gists{/gist_id}","starred_url":"https://api.github.com/users/nkbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkbt/subscriptions","organizations_url":"https://api.github.com/users/nkbt/orgs","repos_url":"https://api.github.com/users/nkbt/repos","events_url":"https://api.github.com/users/nkbt/events{/privacy}","received_events_url":"https://api.github.com/users/nkbt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkbt/react-collapse","description":"Component-wrapper for collapse animation with react-motion for elements with variable (and dynamic) height","fork":false,"url":"https://api.github.com/repos/nkbt/react-collapse","forks_url":"https://api.github.com/repos/nkbt/react-collapse/forks","keys_url":"https://api.github.com/repos/nkbt/react-collapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkbt/react-collapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkbt/react-collapse/teams","hooks_url":"https://api.github.com/repos/nkbt/react-collapse/hooks","issue_events_url":"https://api.github.com/repos/nkbt/react-collapse/issues/events{/number}","events_url":"https://api.github.com/repos/nkbt/react-collapse/events","assignees_url":"https://api.github.com/repos/nkbt/react-collapse/assignees{/user}","branches_url":"https://api.github.com/repos/nkbt/react-collapse/branches{/branch}","tags_url":"https://api.github.com/repos/nkbt/react-collapse/tags","blobs_url":"https://api.github.com/repos/nkbt/react-collapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkbt/react-collapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkbt/react-collapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkbt/react-collapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkbt/react-collapse/statuses/{sha}","languages_url":"https://api.github.com/repos/nkbt/react-collapse/languages","stargazers_url":"https://api.github.com/repos/nkbt/react-collapse/stargazers","contributors_url":"https://api.github.com/repos/nkbt/react-collapse/contributors","subscribers_url":"https://api.github.com/repos/nkbt/react-collapse/subscribers","subscription_url":"https://api.github.com/repos/nkbt/react-collapse/subscription","commits_url":"https://api.github.com/repos/nkbt/react-collapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkbt/react-collapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkbt/react-collapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkbt/react-collapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkbt/react-collapse/contents/{+path}","compare_url":"https://api.github.com/repos/nkbt/react-collapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkbt/react-collapse/merges","archive_url":"https://api.github.com/repos/nkbt/react-collapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkbt/react-collapse/downloads","issues_url":"https://api.github.com/repos/nkbt/react-collapse/issues{/number}","pulls_url":"https://api.github.com/repos/nkbt/react-collapse/pulls{/number}","milestones_url":"https://api.github.com/repos/nkbt/react-collapse/milestones{/number}","notifications_url":"https://api.github.com/repos/nkbt/react-collapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkbt/react-collapse/labels{/name}","releases_url":"https://api.github.com/repos/nkbt/react-collapse/releases{/id}","deployments_url":"https://api.github.com/repos/nkbt/react-collapse/deployments","created_at":"2015-10-15T12:10:12Z","updated_at":"2016-08-11T08:46:57Z","pushed_at":"2016-08-11T11:07:52Z","git_url":"git://github.com/nkbt/react-collapse.git","ssh_url":"git@github.com:nkbt/react-collapse.git","clone_url":"https://github.com/nkbt/react-collapse.git","svn_url":"https://github.com/nkbt/react-collapse","homepage":null,"size":3167,"stargazers_count":240,"watchers_count":240,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":17,"forks":31,"open_issues":17,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nkbt/react-collapse/pulls/71"},"html":{"href":"https://github.com/nkbt/react-collapse/pull/71"},"issue":{"href":"https://api.github.com/repos/nkbt/react-collapse/issues/71"},"comments":{"href":"https://api.github.com/repos/nkbt/react-collapse/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/nkbt/react-collapse/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/nkbt/react-collapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nkbt/react-collapse/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/nkbt/react-collapse/statuses/103e6f1cd667559a8949dec7aeb262eb48221f9b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":3,"additions":287,"deletions":515,"changed_files":18}}
{"actor":{"display_login":"nkbt"}}