{"action":"closed","number":172,"pull_request":{"url":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/172","id":99388522,"html_url":"https://github.com/wpilibsuite/ntcore/pull/172","diff_url":"https://github.com/wpilibsuite/ntcore/pull/172.diff","patch_url":"https://github.com/wpilibsuite/ntcore/pull/172.patch","issue_url":"https://api.github.com/repos/wpilibsuite/ntcore/issues/172","number":172,"state":"closed","locked":false,"title":"Fixes TCPAcceptor able to use an empty string","user":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"body":"@PeterJohnson this only changes the acceptor, since I don't think\r\nTCPConnector needs to be able to support an empty string.","created_at":"2016-12-26T20:00:23Z","updated_at":"2016-12-26T20:27:09Z","closed_at":"2016-12-26T20:27:09Z","merged_at":"2016-12-26T20:27:09Z","merge_commit_sha":"6ad9f45d9a89cb425bd52e99726ff420ae5e587f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/172/commits","review_comments_url":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/172/comments","review_comment_url":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wpilibsuite/ntcore/issues/172/comments","statuses_url":"https://api.github.com/repos/wpilibsuite/ntcore/statuses/0f16d61d016911d8eb4c466754dd28a15f9290ef","head":{"label":"ThadHouse:emptyStringFix","ref":"emptyStringFix","sha":"0f16d61d016911d8eb4c466754dd28a15f9290ef","user":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"repo":{"id":41039686,"name":"ntcore","full_name":"ThadHouse/ntcore","owner":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThadHouse/ntcore","description":"NetworkTables Core Library","fork":true,"url":"https://api.github.com/repos/ThadHouse/ntcore","forks_url":"https://api.github.com/repos/ThadHouse/ntcore/forks","keys_url":"https://api.github.com/repos/ThadHouse/ntcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThadHouse/ntcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThadHouse/ntcore/teams","hooks_url":"https://api.github.com/repos/ThadHouse/ntcore/hooks","issue_events_url":"https://api.github.com/repos/ThadHouse/ntcore/issues/events{/number}","events_url":"https://api.github.com/repos/ThadHouse/ntcore/events","assignees_url":"https://api.github.com/repos/ThadHouse/ntcore/assignees{/user}","branches_url":"https://api.github.com/repos/ThadHouse/ntcore/branches{/branch}","tags_url":"https://api.github.com/repos/ThadHouse/ntcore/tags","blobs_url":"https://api.github.com/repos/ThadHouse/ntcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThadHouse/ntcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThadHouse/ntcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThadHouse/ntcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThadHouse/ntcore/statuses/{sha}","languages_url":"https://api.github.com/repos/ThadHouse/ntcore/languages","stargazers_url":"https://api.github.com/repos/ThadHouse/ntcore/stargazers","contributors_url":"https://api.github.com/repos/ThadHouse/ntcore/contributors","subscribers_url":"https://api.github.com/repos/ThadHouse/ntcore/subscribers","subscription_url":"https://api.github.com/repos/ThadHouse/ntcore/subscription","commits_url":"https://api.github.com/repos/ThadHouse/ntcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThadHouse/ntcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThadHouse/ntcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThadHouse/ntcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThadHouse/ntcore/contents/{+path}","compare_url":"https://api.github.com/repos/ThadHouse/ntcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThadHouse/ntcore/merges","archive_url":"https://api.github.com/repos/ThadHouse/ntcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThadHouse/ntcore/downloads","issues_url":"https://api.github.com/repos/ThadHouse/ntcore/issues{/number}","pulls_url":"https://api.github.com/repos/ThadHouse/ntcore/pulls{/number}","milestones_url":"https://api.github.com/repos/ThadHouse/ntcore/milestones{/number}","notifications_url":"https://api.github.com/repos/ThadHouse/ntcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThadHouse/ntcore/labels{/name}","releases_url":"https://api.github.com/repos/ThadHouse/ntcore/releases{/id}","deployments_url":"https://api.github.com/repos/ThadHouse/ntcore/deployments","created_at":"2015-08-19T14:35:09Z","updated_at":"2016-01-15T06:10:09Z","pushed_at":"2016-12-26T20:00:22Z","git_url":"git://github.com/ThadHouse/ntcore.git","ssh_url":"git@github.com:ThadHouse/ntcore.git","clone_url":"https://github.com/ThadHouse/ntcore.git","svn_url":"https://github.com/ThadHouse/ntcore","homepage":null,"size":1610,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wpilibsuite:master","ref":"master","sha":"ed9e83722913c782b49da1c2b6ab533824c80b44","user":{"login":"wpilibsuite","id":19267233,"avatar_url":"https://avatars.githubusercontent.com/u/19267233?v=3","gravatar_id":"","url":"https://api.github.com/users/wpilibsuite","html_url":"https://github.com/wpilibsuite","followers_url":"https://api.github.com/users/wpilibsuite/followers","following_url":"https://api.github.com/users/wpilibsuite/following{/other_user}","gists_url":"https://api.github.com/users/wpilibsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/wpilibsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpilibsuite/subscriptions","organizations_url":"https://api.github.com/users/wpilibsuite/orgs","repos_url":"https://api.github.com/users/wpilibsuite/repos","events_url":"https://api.github.com/users/wpilibsuite/events{/privacy}","received_events_url":"https://api.github.com/users/wpilibsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":39292316,"name":"ntcore","full_name":"wpilibsuite/ntcore","owner":{"login":"wpilibsuite","id":19267233,"avatar_url":"https://avatars.githubusercontent.com/u/19267233?v=3","gravatar_id":"","url":"https://api.github.com/users/wpilibsuite","html_url":"https://github.com/wpilibsuite","followers_url":"https://api.github.com/users/wpilibsuite/followers","following_url":"https://api.github.com/users/wpilibsuite/following{/other_user}","gists_url":"https://api.github.com/users/wpilibsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/wpilibsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpilibsuite/subscriptions","organizations_url":"https://api.github.com/users/wpilibsuite/orgs","repos_url":"https://api.github.com/users/wpilibsuite/repos","events_url":"https://api.github.com/users/wpilibsuite/events{/privacy}","received_events_url":"https://api.github.com/users/wpilibsuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wpilibsuite/ntcore","description":"NetworkTables Core Library","fork":false,"url":"https://api.github.com/repos/wpilibsuite/ntcore","forks_url":"https://api.github.com/repos/wpilibsuite/ntcore/forks","keys_url":"https://api.github.com/repos/wpilibsuite/ntcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wpilibsuite/ntcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wpilibsuite/ntcore/teams","hooks_url":"https://api.github.com/repos/wpilibsuite/ntcore/hooks","issue_events_url":"https://api.github.com/repos/wpilibsuite/ntcore/issues/events{/number}","events_url":"https://api.github.com/repos/wpilibsuite/ntcore/events","assignees_url":"https://api.github.com/repos/wpilibsuite/ntcore/assignees{/user}","branches_url":"https://api.github.com/repos/wpilibsuite/ntcore/branches{/branch}","tags_url":"https://api.github.com/repos/wpilibsuite/ntcore/tags","blobs_url":"https://api.github.com/repos/wpilibsuite/ntcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wpilibsuite/ntcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wpilibsuite/ntcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/wpilibsuite/ntcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wpilibsuite/ntcore/statuses/{sha}","languages_url":"https://api.github.com/repos/wpilibsuite/ntcore/languages","stargazers_url":"https://api.github.com/repos/wpilibsuite/ntcore/stargazers","contributors_url":"https://api.github.com/repos/wpilibsuite/ntcore/contributors","subscribers_url":"https://api.github.com/repos/wpilibsuite/ntcore/subscribers","subscription_url":"https://api.github.com/repos/wpilibsuite/ntcore/subscription","commits_url":"https://api.github.com/repos/wpilibsuite/ntcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/wpilibsuite/ntcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/wpilibsuite/ntcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/wpilibsuite/ntcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/wpilibsuite/ntcore/contents/{+path}","compare_url":"https://api.github.com/repos/wpilibsuite/ntcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wpilibsuite/ntcore/merges","archive_url":"https://api.github.com/repos/wpilibsuite/ntcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wpilibsuite/ntcore/downloads","issues_url":"https://api.github.com/repos/wpilibsuite/ntcore/issues{/number}","pulls_url":"https://api.github.com/repos/wpilibsuite/ntcore/pulls{/number}","milestones_url":"https://api.github.com/repos/wpilibsuite/ntcore/milestones{/number}","notifications_url":"https://api.github.com/repos/wpilibsuite/ntcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wpilibsuite/ntcore/labels{/name}","releases_url":"https://api.github.com/repos/wpilibsuite/ntcore/releases{/id}","deployments_url":"https://api.github.com/repos/wpilibsuite/ntcore/deployments","created_at":"2015-07-18T08:45:42Z","updated_at":"2016-12-26T19:03:26Z","pushed_at":"2016-12-26T20:27:09Z","git_url":"git://github.com/wpilibsuite/ntcore.git","ssh_url":"git@github.com:wpilibsuite/ntcore.git","clone_url":"https://github.com/wpilibsuite/ntcore.git","svn_url":"https://github.com/wpilibsuite/ntcore","homepage":null,"size":1610,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":15,"forks":18,"open_issues":15,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/172"},"html":{"href":"https://github.com/wpilibsuite/ntcore/pull/172"},"issue":{"href":"https://api.github.com/repos/wpilibsuite/ntcore/issues/172"},"comments":{"href":"https://api.github.com/repos/wpilibsuite/ntcore/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wpilibsuite/ntcore/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/wpilibsuite/ntcore/statuses/0f16d61d016911d8eb4c466754dd28a15f9290ef"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PeterJohnson","id":297126,"avatar_url":"https://avatars.githubusercontent.com/u/297126?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterJohnson","html_url":"https://github.com/PeterJohnson","followers_url":"https://api.github.com/users/PeterJohnson/followers","following_url":"https://api.github.com/users/PeterJohnson/following{/other_user}","gists_url":"https://api.github.com/users/PeterJohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterJohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterJohnson/subscriptions","organizations_url":"https://api.github.com/users/PeterJohnson/orgs","repos_url":"https://api.github.com/users/PeterJohnson/repos","events_url":"https://api.github.com/users/PeterJohnson/events{/privacy}","received_events_url":"https://api.github.com/users/PeterJohnson/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"PeterJohnson"}}