{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/65819807","id":65819807,"diff_hunk":"@@ -0,0 +1,35 @@\n+/*!\n+  Copyright (C) 2016 Google Inc., authors, and contributors <see AUTHORS file>\n+  Licensed under http://www.apache.org/licenses/LICENSE-2.0 <see LICENSE file>\n+  Created By: ivan@reciprocitylabs.com\n+  Maintained By: ivan@reciprocitylabs.com\n+*/\n+\n+describe('CanJS extensions', function () {\n+  'use strict';\n+\n+  describe('using camelCaseToDashCase', function () {\n+    var method;\n+\n+    beforeEach(function () {\n+      method = can.camelCaseToDashCase;\n+    });\n+\n+    it('should return dash case from camel case', function () {\n+      expect(method('helloWorld')).toBe('hello-world');\n+      expect(method('helloWorldHiThere')).toBe('hello-world-hi-there');\n+    });\n+    it('should return same value for one word', function () {\n+      expect(method('hello')).toBe('hello');\n+      expect(method('Hello')).toBe('hello');\n+    });\n+    it('should return same value for dash case', function () {\n+      expect(method('hello-world')).toBe('hello-world');\n+      expect(method('hello-world-hi-there')).toBe('hello-world-hi-there');\n+    });","path":"src/ggrc/assets/javascripts/plugins/tests/canjs_extensions_spec.js","position":29,"original_position":29,"commit_id":"8b016643537d78a6f40707e689697bd8a69a229a","original_commit_id":"8b016643537d78a6f40707e689697bd8a69a229a","user":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"body":"Please add non trivial tests too, since I'm not sure this works as it should for ```javascript\r\ncamelCaseToDashCase(\"MyNumber4AndNumber5\")\r\n\"my-number4and-number5\"","created_at":"2016-06-05T15:58:15Z","updated_at":"2016-06-05T15:58:15Z","html_url":"https://github.com/google/ggrc-core/pull/3946#discussion_r65819807","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/3946","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/65819807"},"html":{"href":"https://github.com/google/ggrc-core/pull/3946#discussion_r65819807"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3946"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/3946","id":72608453,"html_url":"https://github.com/google/ggrc-core/pull/3946","diff_url":"https://github.com/google/ggrc-core/pull/3946.diff","patch_url":"https://github.com/google/ggrc-core/pull/3946.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/3946","number":3946,"state":"open","locked":false,"title":"QUICK-FIX GGRC Component casts default types","user":{"login":"hyperNURb","id":59742,"avatar_url":"https://avatars.githubusercontent.com/u/59742?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperNURb","html_url":"https://github.com/hyperNURb","followers_url":"https://api.github.com/users/hyperNURb/followers","following_url":"https://api.github.com/users/hyperNURb/following{/other_user}","gists_url":"https://api.github.com/users/hyperNURb/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperNURb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperNURb/subscriptions","organizations_url":"https://api.github.com/users/hyperNURb/orgs","repos_url":"https://api.github.com/users/hyperNURb/repos","events_url":"https://api.github.com/users/hyperNURb/events{/privacy}","received_events_url":"https://api.github.com/users/hyperNURb/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-04T17:50:35Z","updated_at":"2016-06-05T15:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71e218c3478cfd7a9e1378074681af7248e90acc","assignee":null,"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/16","html_url":"https://github.com/google/ggrc-core/milestones/0.9.6-Plum%20Jelly","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/16/labels","id":1058061,"number":16,"title":"0.9.6-Plum Jelly","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":463,"state":"open","created_at":"2015-04-08T11:38:13Z","updated_at":"2016-06-05T14:34:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/3946/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/3946/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/3946/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/8b016643537d78a6f40707e689697bd8a69a229a","head":{"label":"hyperNURb:quickfix/component-defaults","ref":"quickfix/component-defaults","sha":"8b016643537d78a6f40707e689697bd8a69a229a","user":{"login":"hyperNURb","id":59742,"avatar_url":"https://avatars.githubusercontent.com/u/59742?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperNURb","html_url":"https://github.com/hyperNURb","followers_url":"https://api.github.com/users/hyperNURb/followers","following_url":"https://api.github.com/users/hyperNURb/following{/other_user}","gists_url":"https://api.github.com/users/hyperNURb/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperNURb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperNURb/subscriptions","organizations_url":"https://api.github.com/users/hyperNURb/orgs","repos_url":"https://api.github.com/users/hyperNURb/repos","events_url":"https://api.github.com/users/hyperNURb/events{/privacy}","received_events_url":"https://api.github.com/users/hyperNURb/received_events","type":"User","site_admin":false},"repo":{"id":34402765,"name":"ggrc-core","full_name":"hyperNURb/ggrc-core","owner":{"login":"hyperNURb","id":59742,"avatar_url":"https://avatars.githubusercontent.com/u/59742?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperNURb","html_url":"https://github.com/hyperNURb","followers_url":"https://api.github.com/users/hyperNURb/followers","following_url":"https://api.github.com/users/hyperNURb/following{/other_user}","gists_url":"https://api.github.com/users/hyperNURb/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperNURb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperNURb/subscriptions","organizations_url":"https://api.github.com/users/hyperNURb/orgs","repos_url":"https://api.github.com/users/hyperNURb/repos","events_url":"https://api.github.com/users/hyperNURb/events{/privacy}","received_events_url":"https://api.github.com/users/hyperNURb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hyperNURb/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/hyperNURb/ggrc-core","forks_url":"https://api.github.com/repos/hyperNURb/ggrc-core/forks","keys_url":"https://api.github.com/repos/hyperNURb/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperNURb/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperNURb/ggrc-core/teams","hooks_url":"https://api.github.com/repos/hyperNURb/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/hyperNURb/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/hyperNURb/ggrc-core/events","assignees_url":"https://api.github.com/repos/hyperNURb/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/hyperNURb/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/hyperNURb/ggrc-core/tags","blobs_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperNURb/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperNURb/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/hyperNURb/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/hyperNURb/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/hyperNURb/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/hyperNURb/ggrc-core/subscription","commits_url":"https://api.github.com/repos/hyperNURb/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperNURb/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperNURb/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperNURb/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperNURb/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/hyperNURb/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperNURb/ggrc-core/merges","archive_url":"https://api.github.com/repos/hyperNURb/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperNURb/ggrc-core/downloads","issues_url":"https://api.github.com/repos/hyperNURb/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/hyperNURb/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperNURb/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperNURb/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperNURb/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/hyperNURb/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/hyperNURb/ggrc-core/deployments","created_at":"2015-04-22T16:45:05Z","updated_at":"2015-09-25T08:31:35Z","pushed_at":"2016-06-05T14:46:59Z","git_url":"git://github.com/hyperNURb/ggrc-core.git","ssh_url":"git@github.com:hyperNURb/ggrc-core.git","clone_url":"https://github.com/hyperNURb/ggrc-core.git","svn_url":"https://github.com/hyperNURb/ggrc-core","homepage":null,"size":52341,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"4d5aa06b679a94959d14533c006042eed6cbe219","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2016-05-31T14:44:01Z","pushed_at":"2016-06-05T14:47:00Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":61141,"stargazers_count":95,"watchers_count":95,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":28,"forks":75,"open_issues":28,"watchers":95,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3946"},"html":{"href":"https://github.com/google/ggrc-core/pull/3946"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3946"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3946/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3946/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3946/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/8b016643537d78a6f40707e689697bd8a69a229a"}}}}
{"actor":{"display_login":"zidarsk8"}}