{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/comments/69119947","id":69119947,"diff_hunk":"@@ -300,7 +300,7 @@ public boolean refresh() {\n                 LOGGER.log(Level.INFO, \"Cannot dynamically load optional plugins because {0} is already installed\",\n                         existing.getShortName());\n                 cannotDynamicLoad = true;\n-            } else if (YesNoMaybe.NO == wrapper.supportsDynamicLoad()) {\n+            } else if (existing == null && YesNoMaybe.NO == wrapper.supportsDynamicLoad()) {","path":"src/main/java/org/jenkinsci/modules/optpluginhelper/PluginHelper.java","position":5,"original_position":5,"commit_id":"6cb1cf6eda36b587c5bdf4c89ca892e14e3660d1","original_commit_id":"6cb1cf6eda36b587c5bdf4c89ca892e14e3660d1","user":{"login":"stephenc","id":209336,"avatar_url":"https://avatars.githubusercontent.com/u/209336?v=3","gravatar_id":"","url":"https://api.github.com/users/stephenc","html_url":"https://github.com/stephenc","followers_url":"https://api.github.com/users/stephenc/followers","following_url":"https://api.github.com/users/stephenc/following{/other_user}","gists_url":"https://api.github.com/users/stephenc/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenc/subscriptions","organizations_url":"https://api.github.com/users/stephenc/orgs","repos_url":"https://api.github.com/users/stephenc/repos","events_url":"https://api.github.com/users/stephenc/events{/privacy}","received_events_url":"https://api.github.com/users/stephenc/received_events","type":"User","site_admin":false},"body":"Nope this does not fix the issue you think it fixes. It only masks the issue","created_at":"2016-06-30T12:05:34Z","updated_at":"2016-06-30T12:05:34Z","html_url":"https://github.com/jenkinsci/optional-plugin-helper-module/pull/2#discussion_r69119947","pull_request_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/comments/69119947"},"html":{"href":"https://github.com/jenkinsci/optional-plugin-helper-module/pull/2#discussion_r69119947"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2","id":75804461,"html_url":"https://github.com/jenkinsci/optional-plugin-helper-module/pull/2","diff_url":"https://github.com/jenkinsci/optional-plugin-helper-module/pull/2.diff","patch_url":"https://github.com/jenkinsci/optional-plugin-helper-module/pull/2.patch","issue_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/issues/2","number":2,"state":"open","locked":false,"title":"[FIXED JENKINS-36351] Only cannotDynamicLoad when the plugin does not exist","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"body":"If I understand correctly the code disabled plugins are considered installable:\r\nhttps://github.com/jenkinsci/optional-plugin-helper-module/blob/2994c72c377d05eab48793e94dbbdcdf238ae79f/src/main/java/org/jenkinsci/modules/optpluginhelper/PluginHelper.java#L297-L308\r\nSpecifically, the line of code below should also check that the plugin does not exist\r\nhttps://github.com/jenkinsci/optional-plugin-helper-module/blob/2994c72c377d05eab48793e94dbbdcdf238ae79f/src/main/java/org/jenkinsci/modules/optpluginhelper/PluginHelper.java#L303\r\n\r\n@reviewbybees CC @stephenc ","created_at":"2016-06-30T11:41:06Z","updated_at":"2016-06-30T12:05:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c4577f0ad03ad394e802ba197d5d8941c30b2f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/issues/2/comments","statuses_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/statuses/6cb1cf6eda36b587c5bdf4c89ca892e14e3660d1","head":{"label":"fbelzunc:JENKINS-36351-v2","ref":"JENKINS-36351-v2","sha":"6cb1cf6eda36b587c5bdf4c89ca892e14e3660d1","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"repo":{"id":52529926,"name":"optional-plugin-helper-module","full_name":"fbelzunc/optional-plugin-helper-module","owner":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbelzunc/optional-plugin-helper-module","description":"","fork":true,"url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module","forks_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/forks","keys_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/teams","hooks_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/hooks","issue_events_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/issues/events{/number}","events_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/events","assignees_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/assignees{/user}","branches_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/branches{/branch}","tags_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/tags","blobs_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/statuses/{sha}","languages_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/languages","stargazers_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/stargazers","contributors_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/contributors","subscribers_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/subscribers","subscription_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/subscription","commits_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/contents/{+path}","compare_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/merges","archive_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/downloads","issues_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/issues{/number}","pulls_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/pulls{/number}","milestones_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/milestones{/number}","notifications_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/labels{/name}","releases_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/releases{/id}","deployments_url":"https://api.github.com/repos/fbelzunc/optional-plugin-helper-module/deployments","created_at":"2016-02-25T14:15:02Z","updated_at":"2016-02-25T14:15:03Z","pushed_at":"2016-06-30T11:39:32Z","git_url":"git://github.com/fbelzunc/optional-plugin-helper-module.git","ssh_url":"git@github.com:fbelzunc/optional-plugin-helper-module.git","clone_url":"https://github.com/fbelzunc/optional-plugin-helper-module.git","svn_url":"https://github.com/fbelzunc/optional-plugin-helper-module","homepage":"","size":18,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"2994c72c377d05eab48793e94dbbdcdf238ae79f","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":35943354,"name":"optional-plugin-helper-module","full_name":"jenkinsci/optional-plugin-helper-module","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/optional-plugin-helper-module","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module","forks_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/forks","keys_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/teams","hooks_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/events","assignees_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/tags","blobs_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/subscription","commits_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/merges","archive_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/downloads","issues_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/deployments","created_at":"2015-05-20T11:15:18Z","updated_at":"2016-02-28T19:34:04Z","pushed_at":"2016-06-30T11:41:06Z","git_url":"git://github.com/jenkinsci/optional-plugin-helper-module.git","ssh_url":"git@github.com:jenkinsci/optional-plugin-helper-module.git","clone_url":"https://github.com/jenkinsci/optional-plugin-helper-module.git","svn_url":"https://github.com/jenkinsci/optional-plugin-helper-module","homepage":"","size":21,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2"},"html":{"href":"https://github.com/jenkinsci/optional-plugin-helper-module/pull/2"},"issue":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/issues/2"},"comments":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/optional-plugin-helper-module/statuses/6cb1cf6eda36b587c5bdf4c89ca892e14e3660d1"}}}}
{"actor":{"display_login":"stephenc"}}