{"action":"created","issue":{"url":"https://api.github.com/repos/BBC-News/alephant-preview/issues/17","repository_url":"https://api.github.com/repos/BBC-News/alephant-preview","labels_url":"https://api.github.com/repos/BBC-News/alephant-preview/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/BBC-News/alephant-preview/issues/17/comments","events_url":"https://api.github.com/repos/BBC-News/alephant-preview/issues/17/events","html_url":"https://github.com/BBC-News/alephant-preview/pull/17","id":159265152,"number":17,"title":"Add content type headers and sequence ids to previewer","user":{"login":"samfrench","id":743433,"avatar_url":"https://avatars.githubusercontent.com/u/743433?v=3","gravatar_id":"","url":"https://api.github.com/users/samfrench","html_url":"https://github.com/samfrench","followers_url":"https://api.github.com/users/samfrench/followers","following_url":"https://api.github.com/users/samfrench/following{/other_user}","gists_url":"https://api.github.com/users/samfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/samfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samfrench/subscriptions","organizations_url":"https://api.github.com/users/samfrench/orgs","repos_url":"https://api.github.com/users/samfrench/repos","events_url":"https://api.github.com/users/samfrench/events{/privacy}","received_events_url":"https://api.github.com/users/samfrench/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ettomatic","id":3269,"avatar_url":"https://avatars.githubusercontent.com/u/3269?v=3","gravatar_id":"","url":"https://api.github.com/users/ettomatic","html_url":"https://github.com/ettomatic","followers_url":"https://api.github.com/users/ettomatic/followers","following_url":"https://api.github.com/users/ettomatic/following{/other_user}","gists_url":"https://api.github.com/users/ettomatic/gists{/gist_id}","starred_url":"https://api.github.com/users/ettomatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ettomatic/subscriptions","organizations_url":"https://api.github.com/users/ettomatic/orgs","repos_url":"https://api.github.com/users/ettomatic/repos","events_url":"https://api.github.com/users/ettomatic/events{/privacy}","received_events_url":"https://api.github.com/users/ettomatic/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-08T20:38:11Z","updated_at":"2016-06-08T20:40:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/BBC-News/alephant-preview/pulls/17","html_url":"https://github.com/BBC-News/alephant-preview/pull/17","diff_url":"https://github.com/BBC-News/alephant-preview/pull/17.diff","patch_url":"https://github.com/BBC-News/alephant-preview/pull/17.patch"},"body":"Adding the sequence id header, so we can poll components locally. We added this to the broker recently, and need the previewer to behave the same way.\r\n\r\nI also added a header for the JSON content type. The html type seems to be returned by default.\r\n\r\nI also updated the specs to check our headers, as they were lacking in that area.\r\n\r\nhttps://jira.dev.bbc.co.uk/browse/CONNPOL-3537"},"comment":{"url":"https://api.github.com/repos/BBC-News/alephant-preview/issues/comments/224720438","html_url":"https://github.com/BBC-News/alephant-preview/pull/17#issuecomment-224720438","issue_url":"https://api.github.com/repos/BBC-News/alephant-preview/issues/17","id":224720438,"user":{"login":"samfrench","id":743433,"avatar_url":"https://avatars.githubusercontent.com/u/743433?v=3","gravatar_id":"","url":"https://api.github.com/users/samfrench","html_url":"https://github.com/samfrench","followers_url":"https://api.github.com/users/samfrench/followers","following_url":"https://api.github.com/users/samfrench/following{/other_user}","gists_url":"https://api.github.com/users/samfrench/gists{/gist_id}","starred_url":"https://api.github.com/users/samfrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samfrench/subscriptions","organizations_url":"https://api.github.com/users/samfrench/orgs","repos_url":"https://api.github.com/users/samfrench/repos","events_url":"https://api.github.com/users/samfrench/events{/privacy}","received_events_url":"https://api.github.com/users/samfrench/received_events","type":"User","site_admin":false},"created_at":"2016-06-08T20:40:26Z","updated_at":"2016-06-08T20:40:26Z","body":"@dazoakley, this might be a good one for you to review with @ettomatic.\r\n\r\nI had to add all the headers in this, whereas I probably don't need to check the \"XSS\" and \"Frame\" headers, as we don't use them that I know of. I wanted to check certain headers are in the array, but couldn't easily work out how to check some and not all.\r\n\r\nI also stubbed out the Time method, to get the sequence number returned. I'm not sure if the way I did it is the best. I also do this in several places, as the scope at the top of the specs wasn't allowed..."}}
{"actor":{"display_login":"samfrench"}}