{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/issues/5","repository_url":"https://api.github.com/repos/jenkinsci/run-selector-plugin","labels_url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/issues/5/comments","events_url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/issues/5/events","html_url":"https://github.com/jenkinsci/run-selector-plugin/pull/5","id":164674774,"number":5,"title":"[JENKINS-36532] General refactor","user":{"login":"alexsomai","id":5720977,"avatar_url":"https://avatars.githubusercontent.com/u/5720977?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsomai","html_url":"https://github.com/alexsomai","followers_url":"https://api.github.com/users/alexsomai/followers","following_url":"https://api.github.com/users/alexsomai/following{/other_user}","gists_url":"https://api.github.com/users/alexsomai/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsomai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsomai/subscriptions","organizations_url":"https://api.github.com/users/alexsomai/orgs","repos_url":"https://api.github.com/users/alexsomai/repos","events_url":"https://api.github.com/users/alexsomai/events{/privacy}","received_events_url":"https://api.github.com/users/alexsomai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/labels/needs-review","name":"needs-review","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-07-09T16:39:15Z","updated_at":"2016-07-11T00:05:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/pulls/5","html_url":"https://github.com/jenkinsci/run-selector-plugin/pull/5","diff_url":"https://github.com/jenkinsci/run-selector-plugin/pull/5.diff","patch_url":"https://github.com/jenkinsci/run-selector-plugin/pull/5.patch"},"body":"Related to issue [[JENKINS-36532]](https://issues.jenkins-ci.org/browse/JENKINS-36532)\r\n\r\nSummary of this pull request:\r\n- [X] Include the changes suggested in #1 \r\n- [X] Use *DataBoundSetter* where makes sense, to minimize the output of *Snippet Generator* code\r\n- [X] Rename public exposed method API to `select(run, context)`\r\n- [x] The parameters that are mandatory in the `RunSelectorContext` should be set in the constructor. Only optional parameters, like `verbose` should have setters \r\n\r\nCC @ikedam @oleg-nenashev @martinda"},"comment":{"url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/issues/comments/231619083","html_url":"https://github.com/jenkinsci/run-selector-plugin/pull/5#issuecomment-231619083","issue_url":"https://api.github.com/repos/jenkinsci/run-selector-plugin/issues/5","id":231619083,"user":{"login":"ikedam","id":3115961,"avatar_url":"https://avatars.githubusercontent.com/u/3115961?v=3","gravatar_id":"","url":"https://api.github.com/users/ikedam","html_url":"https://github.com/ikedam","followers_url":"https://api.github.com/users/ikedam/followers","following_url":"https://api.github.com/users/ikedam/following{/other_user}","gists_url":"https://api.github.com/users/ikedam/gists{/gist_id}","starred_url":"https://api.github.com/users/ikedam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikedam/subscriptions","organizations_url":"https://api.github.com/users/ikedam/orgs","repos_url":"https://api.github.com/users/ikedam/repos","events_url":"https://api.github.com/users/ikedam/events{/privacy}","received_events_url":"https://api.github.com/users/ikedam/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T00:05:04Z","updated_at":"2016-07-11T00:05:04Z","body":"> I don't understand well why to remove this feature. People are not using it?\r\n\r\n* The variable expression feature was introduced for pipilenes (aka. workflow): https://issues.jenkins-ci.org/browse/JENKINS-30357\r\n    * The variable name feature remains for the backward compatibility.\r\n* The varable expression feature can be alternate for the variable name feature.\r\n* These two features can be conflicted.\r\n    * VAR1=VAR2, VAR2=blahblahblah, and ${VAR1} will be expanded to blahblahblah.\r\n* Confusing if there're two ways for same configurations.\r\n* More tests are needed.\r\n* `ParameterizedBuildFilter` supports only variable expressions.\r\n\r\nAnd I think you can remove this feature.\r\n\r\nOn the other hand, you can continue to support this feature.\r\nThe variable expression feature is introduced recently, and many users of copyartifact may still use variable names.\r\n\r\n> But I'm not sure what changes I should make. \r\n\r\nThe way you wrote is right."}}
{"actor":{"display_login":"ikedam"}}