{"action":"created","issue":{"url":"https://api.github.com/repos/monero-project/bitmonero/issues/983","repository_url":"https://api.github.com/repos/monero-project/bitmonero","labels_url":"https://api.github.com/repos/monero-project/bitmonero/issues/983/labels{/name}","comments_url":"https://api.github.com/repos/monero-project/bitmonero/issues/983/comments","events_url":"https://api.github.com/repos/monero-project/bitmonero/issues/983/events","html_url":"https://github.com/monero-project/bitmonero/issues/983","id":172844427,"number":983,"title":"Could NOT find GTest (missing:  GTEST_LIBRARY GTEST_MAIN_LIBRARY) ","user":{"login":"NanoAkron","id":6762681,"avatar_url":"https://avatars.githubusercontent.com/u/6762681?v=3","gravatar_id":"","url":"https://api.github.com/users/NanoAkron","html_url":"https://github.com/NanoAkron","followers_url":"https://api.github.com/users/NanoAkron/followers","following_url":"https://api.github.com/users/NanoAkron/following{/other_user}","gists_url":"https://api.github.com/users/NanoAkron/gists{/gist_id}","starred_url":"https://api.github.com/users/NanoAkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanoAkron/subscriptions","organizations_url":"https://api.github.com/users/NanoAkron/orgs","repos_url":"https://api.github.com/users/NanoAkron/repos","events_url":"https://api.github.com/users/NanoAkron/events{/privacy}","received_events_url":"https://api.github.com/users/NanoAkron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-24T01:24:36Z","updated_at":"2016-08-25T02:25:11Z","closed_at":null,"body":"Looks like this is another dependency on Ubuntu 16.04:\r\n\r\nlibgtest-dev\r\n\r\nAnd actually this is more complicated than it first seems because:\r\n1. It doesn't come compiled\r\n2. It doesn't actually work even if compiled\r\n\r\nSo I've tried compiling googletest from their git repo with no success yet...still getting failures on 'make test' for googletest itself (version 1.7.0)\r\n\r\nCould I request future versions also include the test suite?"},"comment":{"url":"https://api.github.com/repos/monero-project/bitmonero/issues/comments/242264510","html_url":"https://github.com/monero-project/bitmonero/issues/983#issuecomment-242264510","issue_url":"https://api.github.com/repos/monero-project/bitmonero/issues/983","id":242264510,"user":{"login":"radfish","id":17036903,"avatar_url":"https://avatars.githubusercontent.com/u/17036903?v=3","gravatar_id":"","url":"https://api.github.com/users/radfish","html_url":"https://github.com/radfish","followers_url":"https://api.github.com/users/radfish/followers","following_url":"https://api.github.com/users/radfish/following{/other_user}","gists_url":"https://api.github.com/users/radfish/gists{/gist_id}","starred_url":"https://api.github.com/users/radfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radfish/subscriptions","organizations_url":"https://api.github.com/users/radfish/orgs","repos_url":"https://api.github.com/users/radfish/repos","events_url":"https://api.github.com/users/radfish/events{/privacy}","received_events_url":"https://api.github.com/users/radfish/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T02:25:11Z","updated_at":"2016-08-25T02:25:11Z","body":"First a note: gtest is included in the source tree as a vendored dependency, so bitmonerod will build fine without gtest installed on the system. But agreed that it should also build with gtest installed on system, if one is found. I think there are two problems with that currently\r\n1. #980 -- a bug in cmake script\r\n2. no package on Ubuntu with built gtest (judging from your report; on Arch gest pkg does include libgtest.so) -- do you know why? there must be some reason.\r\n\r\nSidenote: since cmake does build the tests with in-tree gtest successfully, you could compare that working build of gest with your standalone build of gtest."}}
{"actor":{"display_login":"radfish"}}