{"action":"created","comment":{"url":"https://api.github.com/repos/fastlane/spaceship/pulls/comments/54490360","id":54490360,"diff_hunk":"@@ -121,7 +121,7 @@ def find(device_id, mac: false)\n         # @return (Device) Find a device based on the UDID of the device. nil if no device was found.\n         def find_by_udid(device_udid, mac: false)\n           all(mac: mac).find do |device|\n-            device.udid == device_udid\n+            device.udid.downcase == device_udid.downcase","path":"lib/spaceship/portal/device.rb","position":5,"original_position":5,"commit_id":"45bda379dcf06240611fd73f6630e78a5ed1ee41","original_commit_id":"8748e3255a523991e309e8965c3961cabef6bb12","user":{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false},"body":"using `casecmp` returns `0` instead of `false` which leads some extra code to be written. this is nicer IMO. and `rubocop` doesn't mind it.","created_at":"2016-02-29T22:29:35Z","updated_at":"2016-02-29T22:29:35Z","html_url":"https://github.com/fastlane/spaceship/pull/266#discussion_r54490360","pull_request_url":"https://api.github.com/repos/fastlane/spaceship/pulls/266","_links":{"self":{"href":"https://api.github.com/repos/fastlane/spaceship/pulls/comments/54490360"},"html":{"href":"https://github.com/fastlane/spaceship/pull/266#discussion_r54490360"},"pull_request":{"href":"https://api.github.com/repos/fastlane/spaceship/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/fastlane/spaceship/pulls/266","id":61153924,"html_url":"https://github.com/fastlane/spaceship/pull/266","diff_url":"https://github.com/fastlane/spaceship/pull/266.diff","patch_url":"https://github.com/fastlane/spaceship/pull/266.patch","issue_url":"https://api.github.com/repos/fastlane/spaceship/issues/266","number":266,"state":"open","locked":false,"title":"Fix `find_by_udid` to be case insensitive","user":{"login":"ohwutup","id":2587018,"avatar_url":"https://avatars.githubusercontent.com/u/2587018?v=3","gravatar_id":"","url":"https://api.github.com/users/ohwutup","html_url":"https://github.com/ohwutup","followers_url":"https://api.github.com/users/ohwutup/followers","following_url":"https://api.github.com/users/ohwutup/following{/other_user}","gists_url":"https://api.github.com/users/ohwutup/gists{/gist_id}","starred_url":"https://api.github.com/users/ohwutup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohwutup/subscriptions","organizations_url":"https://api.github.com/users/ohwutup/orgs","repos_url":"https://api.github.com/users/ohwutup/repos","events_url":"https://api.github.com/users/ohwutup/events{/privacy}","received_events_url":"https://api.github.com/users/ohwutup/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-29T22:05:44Z","updated_at":"2016-02-29T22:29:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"487f4fbcd40d9e08546a87247bf1486b56d9908d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/spaceship/pulls/266/commits","review_comments_url":"https://api.github.com/repos/fastlane/spaceship/pulls/266/comments","review_comment_url":"https://api.github.com/repos/fastlane/spaceship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/spaceship/issues/266/comments","statuses_url":"https://api.github.com/repos/fastlane/spaceship/statuses/45bda379dcf06240611fd73f6630e78a5ed1ee41","head":{"label":"fastlane:downcase","ref":"downcase","sha":"45bda379dcf06240611fd73f6630e78a5ed1ee41","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":33789738,"name":"spaceship","full_name":"fastlane/spaceship","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/spaceship","description":"Ruby library to access the Apple Dev Center and iTunes Connect","fork":false,"url":"https://api.github.com/repos/fastlane/spaceship","forks_url":"https://api.github.com/repos/fastlane/spaceship/forks","keys_url":"https://api.github.com/repos/fastlane/spaceship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/spaceship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/spaceship/teams","hooks_url":"https://api.github.com/repos/fastlane/spaceship/hooks","issue_events_url":"https://api.github.com/repos/fastlane/spaceship/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/spaceship/events","assignees_url":"https://api.github.com/repos/fastlane/spaceship/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/spaceship/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/spaceship/tags","blobs_url":"https://api.github.com/repos/fastlane/spaceship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/spaceship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/spaceship/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/spaceship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/spaceship/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/spaceship/languages","stargazers_url":"https://api.github.com/repos/fastlane/spaceship/stargazers","contributors_url":"https://api.github.com/repos/fastlane/spaceship/contributors","subscribers_url":"https://api.github.com/repos/fastlane/spaceship/subscribers","subscription_url":"https://api.github.com/repos/fastlane/spaceship/subscription","commits_url":"https://api.github.com/repos/fastlane/spaceship/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/spaceship/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/spaceship/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/spaceship/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/spaceship/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/spaceship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/spaceship/merges","archive_url":"https://api.github.com/repos/fastlane/spaceship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/spaceship/downloads","issues_url":"https://api.github.com/repos/fastlane/spaceship/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/spaceship/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/spaceship/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/spaceship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/spaceship/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/spaceship/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/spaceship/deployments","created_at":"2015-04-11T19:44:23Z","updated_at":"2016-02-28T08:26:31Z","pushed_at":"2016-02-29T22:24:22Z","git_url":"git://github.com/fastlane/spaceship.git","ssh_url":"git@github.com:fastlane/spaceship.git","clone_url":"https://github.com/fastlane/spaceship.git","svn_url":"https://github.com/fastlane/spaceship","homepage":"https://spaceship.airforce","size":2191,"stargazers_count":694,"watchers_count":694,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":67,"forks":100,"open_issues":67,"watchers":694,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"8a0aafe2cb16fe9d36d1270029e96695ed84a467","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":33789738,"name":"spaceship","full_name":"fastlane/spaceship","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/spaceship","description":"Ruby library to access the Apple Dev Center and iTunes Connect","fork":false,"url":"https://api.github.com/repos/fastlane/spaceship","forks_url":"https://api.github.com/repos/fastlane/spaceship/forks","keys_url":"https://api.github.com/repos/fastlane/spaceship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/spaceship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/spaceship/teams","hooks_url":"https://api.github.com/repos/fastlane/spaceship/hooks","issue_events_url":"https://api.github.com/repos/fastlane/spaceship/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/spaceship/events","assignees_url":"https://api.github.com/repos/fastlane/spaceship/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/spaceship/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/spaceship/tags","blobs_url":"https://api.github.com/repos/fastlane/spaceship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/spaceship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/spaceship/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/spaceship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/spaceship/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/spaceship/languages","stargazers_url":"https://api.github.com/repos/fastlane/spaceship/stargazers","contributors_url":"https://api.github.com/repos/fastlane/spaceship/contributors","subscribers_url":"https://api.github.com/repos/fastlane/spaceship/subscribers","subscription_url":"https://api.github.com/repos/fastlane/spaceship/subscription","commits_url":"https://api.github.com/repos/fastlane/spaceship/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/spaceship/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/spaceship/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/spaceship/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/spaceship/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/spaceship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/spaceship/merges","archive_url":"https://api.github.com/repos/fastlane/spaceship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/spaceship/downloads","issues_url":"https://api.github.com/repos/fastlane/spaceship/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/spaceship/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/spaceship/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/spaceship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/spaceship/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/spaceship/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/spaceship/deployments","created_at":"2015-04-11T19:44:23Z","updated_at":"2016-02-28T08:26:31Z","pushed_at":"2016-02-29T22:24:22Z","git_url":"git://github.com/fastlane/spaceship.git","ssh_url":"git@github.com:fastlane/spaceship.git","clone_url":"https://github.com/fastlane/spaceship.git","svn_url":"https://github.com/fastlane/spaceship","homepage":"https://spaceship.airforce","size":2191,"stargazers_count":694,"watchers_count":694,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"open_issues_count":67,"forks":100,"open_issues":67,"watchers":694,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/spaceship/pulls/266"},"html":{"href":"https://github.com/fastlane/spaceship/pull/266"},"issue":{"href":"https://api.github.com/repos/fastlane/spaceship/issues/266"},"comments":{"href":"https://api.github.com/repos/fastlane/spaceship/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/spaceship/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/spaceship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/spaceship/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/spaceship/statuses/45bda379dcf06240611fd73f6630e78a5ed1ee41"}}}}