{"action":"created","comment":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/79821185","id":79821185,"diff_hunk":"@@ -428,17 +429,19 @@ def _full_package_set(grp):\n \n     @staticmethod\n     def _pkgs_of_type(group, pkg_types, exclude):\n-        def pkgs_update(pkgs, group):\n-            pkgs.update(pkg.name for pkg in group\n+        def pkgs_update(pkgs, group, substitutions):\n+            pkgs.update('.'.join([pkg.name, substitutions['basearch']])\n+                        if pkg.basearchonly else pkg.name for pkg in group\n                         if pkg.name not in exclude)\n \n+        substitutions = dnf.conf.substitutions.Substitutions()","path":"dnf/comps.py","position":19,"original_position":19,"commit_id":"7c6854e0349d118b536725a43547000a6ee3a9ef","original_commit_id":"5c9f0fc8eb56724371339b8548b2d885885d4586","user":{"login":"mluscon","id":1122010,"avatar_url":"https://avatars.githubusercontent.com/u/1122010?v=3","gravatar_id":"","url":"https://api.github.com/users/mluscon","html_url":"https://github.com/mluscon","followers_url":"https://api.github.com/users/mluscon/followers","following_url":"https://api.github.com/users/mluscon/following{/other_user}","gists_url":"https://api.github.com/users/mluscon/gists{/gist_id}","starred_url":"https://api.github.com/users/mluscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluscon/subscriptions","organizations_url":"https://api.github.com/users/mluscon/orgs","repos_url":"https://api.github.com/users/mluscon/repos","events_url":"https://api.github.com/users/mluscon/events{/privacy}","received_events_url":"https://api.github.com/users/mluscon/received_events","type":"User","site_admin":false},"body":"This won't work if an api user changes the default values (https://dnf.readthedocs.io/en/latest/api_conf.html#dnf.conf.Conf.substitutions). ","created_at":"2016-09-21T12:28:41Z","updated_at":"2016-09-21T12:29:05Z","html_url":"https://github.com/rpm-software-management/dnf/pull/558#discussion_r79821185","pull_request_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558","_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments/79821185"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/558#discussion_r79821185"},"pull_request":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558","id":80237692,"html_url":"https://github.com/rpm-software-management/dnf/pull/558","diff_url":"https://github.com/rpm-software-management/dnf/pull/558.diff","patch_url":"https://github.com/rpm-software-management/dnf/pull/558.patch","issue_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/558","number":558,"state":"open","locked":false,"title":"Honor `basearchonly` from comps file","user":{"login":"j-mracek","id":12737303,"avatar_url":"https://avatars.githubusercontent.com/u/12737303?v=3","gravatar_id":"","url":"https://api.github.com/users/j-mracek","html_url":"https://github.com/j-mracek","followers_url":"https://api.github.com/users/j-mracek/followers","following_url":"https://api.github.com/users/j-mracek/following{/other_user}","gists_url":"https://api.github.com/users/j-mracek/gists{/gist_id}","starred_url":"https://api.github.com/users/j-mracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-mracek/subscriptions","organizations_url":"https://api.github.com/users/j-mracek/orgs","repos_url":"https://api.github.com/users/j-mracek/repos","events_url":"https://api.github.com/users/j-mracek/events{/privacy}","received_events_url":"https://api.github.com/users/j-mracek/received_events","type":"User","site_admin":false},"body":"This is compatible issue with yum.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1337731","created_at":"2016-08-05T12:47:52Z","updated_at":"2016-09-21T12:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55581f4d7409643785358083459df1fb81ea9bf6","assignee":{"login":"mluscon","id":1122010,"avatar_url":"https://avatars.githubusercontent.com/u/1122010?v=3","gravatar_id":"","url":"https://api.github.com/users/mluscon","html_url":"https://github.com/mluscon","followers_url":"https://api.github.com/users/mluscon/followers","following_url":"https://api.github.com/users/mluscon/following{/other_user}","gists_url":"https://api.github.com/users/mluscon/gists{/gist_id}","starred_url":"https://api.github.com/users/mluscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluscon/subscriptions","organizations_url":"https://api.github.com/users/mluscon/orgs","repos_url":"https://api.github.com/users/mluscon/repos","events_url":"https://api.github.com/users/mluscon/events{/privacy}","received_events_url":"https://api.github.com/users/mluscon/received_events","type":"User","site_admin":false},"assignees":[{"login":"mluscon","id":1122010,"avatar_url":"https://avatars.githubusercontent.com/u/1122010?v=3","gravatar_id":"","url":"https://api.github.com/users/mluscon","html_url":"https://github.com/mluscon","followers_url":"https://api.github.com/users/mluscon/followers","following_url":"https://api.github.com/users/mluscon/following{/other_user}","gists_url":"https://api.github.com/users/mluscon/gists{/gist_id}","starred_url":"https://api.github.com/users/mluscon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluscon/subscriptions","organizations_url":"https://api.github.com/users/mluscon/orgs","repos_url":"https://api.github.com/users/mluscon/repos","events_url":"https://api.github.com/users/mluscon/events{/privacy}","received_events_url":"https://api.github.com/users/mluscon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558/commits","review_comments_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558/comments","review_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/558/comments","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/7c6854e0349d118b536725a43547000a6ee3a9ef","head":{"label":"j-mracek:basesearch","ref":"basesearch","sha":"7c6854e0349d118b536725a43547000a6ee3a9ef","user":{"login":"j-mracek","id":12737303,"avatar_url":"https://avatars.githubusercontent.com/u/12737303?v=3","gravatar_id":"","url":"https://api.github.com/users/j-mracek","html_url":"https://github.com/j-mracek","followers_url":"https://api.github.com/users/j-mracek/followers","following_url":"https://api.github.com/users/j-mracek/following{/other_user}","gists_url":"https://api.github.com/users/j-mracek/gists{/gist_id}","starred_url":"https://api.github.com/users/j-mracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-mracek/subscriptions","organizations_url":"https://api.github.com/users/j-mracek/orgs","repos_url":"https://api.github.com/users/j-mracek/repos","events_url":"https://api.github.com/users/j-mracek/events{/privacy}","received_events_url":"https://api.github.com/users/j-mracek/received_events","type":"User","site_admin":false},"repo":{"id":42112476,"name":"dnf","full_name":"j-mracek/dnf","owner":{"login":"j-mracek","id":12737303,"avatar_url":"https://avatars.githubusercontent.com/u/12737303?v=3","gravatar_id":"","url":"https://api.github.com/users/j-mracek","html_url":"https://github.com/j-mracek","followers_url":"https://api.github.com/users/j-mracek/followers","following_url":"https://api.github.com/users/j-mracek/following{/other_user}","gists_url":"https://api.github.com/users/j-mracek/gists{/gist_id}","starred_url":"https://api.github.com/users/j-mracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-mracek/subscriptions","organizations_url":"https://api.github.com/users/j-mracek/orgs","repos_url":"https://api.github.com/users/j-mracek/repos","events_url":"https://api.github.com/users/j-mracek/events{/privacy}","received_events_url":"https://api.github.com/users/j-mracek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j-mracek/dnf","description":"dnf is a package manager based on yum and libsolv","fork":true,"url":"https://api.github.com/repos/j-mracek/dnf","forks_url":"https://api.github.com/repos/j-mracek/dnf/forks","keys_url":"https://api.github.com/repos/j-mracek/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j-mracek/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j-mracek/dnf/teams","hooks_url":"https://api.github.com/repos/j-mracek/dnf/hooks","issue_events_url":"https://api.github.com/repos/j-mracek/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/j-mracek/dnf/events","assignees_url":"https://api.github.com/repos/j-mracek/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/j-mracek/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/j-mracek/dnf/tags","blobs_url":"https://api.github.com/repos/j-mracek/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j-mracek/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j-mracek/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/j-mracek/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j-mracek/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/j-mracek/dnf/languages","stargazers_url":"https://api.github.com/repos/j-mracek/dnf/stargazers","contributors_url":"https://api.github.com/repos/j-mracek/dnf/contributors","subscribers_url":"https://api.github.com/repos/j-mracek/dnf/subscribers","subscription_url":"https://api.github.com/repos/j-mracek/dnf/subscription","commits_url":"https://api.github.com/repos/j-mracek/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/j-mracek/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/j-mracek/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/j-mracek/dnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/j-mracek/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/j-mracek/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j-mracek/dnf/merges","archive_url":"https://api.github.com/repos/j-mracek/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j-mracek/dnf/downloads","issues_url":"https://api.github.com/repos/j-mracek/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/j-mracek/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/j-mracek/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/j-mracek/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j-mracek/dnf/labels{/name}","releases_url":"https://api.github.com/repos/j-mracek/dnf/releases{/id}","deployments_url":"https://api.github.com/repos/j-mracek/dnf/deployments","created_at":"2015-09-08T13:03:38Z","updated_at":"2016-02-26T11:22:06Z","pushed_at":"2016-09-21T11:55:10Z","git_url":"git://github.com/j-mracek/dnf.git","ssh_url":"git@github.com:j-mracek/dnf.git","clone_url":"https://github.com/j-mracek/dnf.git","svn_url":"https://github.com/j-mracek/dnf","homepage":"","size":37999,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"rpm-software-management:master","ref":"master","sha":"79b8f3c485ed2347be454e330b786421aef4388c","user":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"repo":{"id":3671909,"name":"dnf","full_name":"rpm-software-management/dnf","owner":{"login":"rpm-software-management","id":8504469,"avatar_url":"https://avatars.githubusercontent.com/u/8504469?v=3","gravatar_id":"","url":"https://api.github.com/users/rpm-software-management","html_url":"https://github.com/rpm-software-management","followers_url":"https://api.github.com/users/rpm-software-management/followers","following_url":"https://api.github.com/users/rpm-software-management/following{/other_user}","gists_url":"https://api.github.com/users/rpm-software-management/gists{/gist_id}","starred_url":"https://api.github.com/users/rpm-software-management/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpm-software-management/subscriptions","organizations_url":"https://api.github.com/users/rpm-software-management/orgs","repos_url":"https://api.github.com/users/rpm-software-management/repos","events_url":"https://api.github.com/users/rpm-software-management/events{/privacy}","received_events_url":"https://api.github.com/users/rpm-software-management/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpm-software-management/dnf","description":"dnf is a package manager based on yum and libsolv","fork":false,"url":"https://api.github.com/repos/rpm-software-management/dnf","forks_url":"https://api.github.com/repos/rpm-software-management/dnf/forks","keys_url":"https://api.github.com/repos/rpm-software-management/dnf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpm-software-management/dnf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpm-software-management/dnf/teams","hooks_url":"https://api.github.com/repos/rpm-software-management/dnf/hooks","issue_events_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/events{/number}","events_url":"https://api.github.com/repos/rpm-software-management/dnf/events","assignees_url":"https://api.github.com/repos/rpm-software-management/dnf/assignees{/user}","branches_url":"https://api.github.com/repos/rpm-software-management/dnf/branches{/branch}","tags_url":"https://api.github.com/repos/rpm-software-management/dnf/tags","blobs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpm-software-management/dnf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpm-software-management/dnf/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpm-software-management/dnf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpm-software-management/dnf/statuses/{sha}","languages_url":"https://api.github.com/repos/rpm-software-management/dnf/languages","stargazers_url":"https://api.github.com/repos/rpm-software-management/dnf/stargazers","contributors_url":"https://api.github.com/repos/rpm-software-management/dnf/contributors","subscribers_url":"https://api.github.com/repos/rpm-software-management/dnf/subscribers","subscription_url":"https://api.github.com/repos/rpm-software-management/dnf/subscription","commits_url":"https://api.github.com/repos/rpm-software-management/dnf/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpm-software-management/dnf/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpm-software-management/dnf/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpm-software-management/dnf/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpm-software-management/dnf/contents/{+path}","compare_url":"https://api.github.com/repos/rpm-software-management/dnf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpm-software-management/dnf/merges","archive_url":"https://api.github.com/repos/rpm-software-management/dnf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpm-software-management/dnf/downloads","issues_url":"https://api.github.com/repos/rpm-software-management/dnf/issues{/number}","pulls_url":"https://api.github.com/repos/rpm-software-management/dnf/pulls{/number}","milestones_url":"https://api.github.com/repos/rpm-software-management/dnf/milestones{/number}","notifications_url":"https://api.github.com/repos/rpm-software-management/dnf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpm-software-management/dnf/labels{/name}","releases_url":"https://api.github.com/repos/rpm-software-management/dnf/releases{/id}","deployments_url":"https://api.github.com/repos/rpm-software-management/dnf/deployments","created_at":"2012-03-09T15:31:09Z","updated_at":"2016-09-20T19:47:41Z","pushed_at":"2016-09-21T12:28:57Z","git_url":"git://github.com/rpm-software-management/dnf.git","ssh_url":"git@github.com:rpm-software-management/dnf.git","clone_url":"https://github.com/rpm-software-management/dnf.git","svn_url":"https://github.com/rpm-software-management/dnf","homepage":"","size":42126,"stargazers_count":335,"watchers_count":335,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":129,"mirror_url":null,"open_issues_count":16,"forks":129,"open_issues":16,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558"},"html":{"href":"https://github.com/rpm-software-management/dnf/pull/558"},"issue":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/558"},"comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpm-software-management/dnf/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/rpm-software-management/dnf/statuses/7c6854e0349d118b536725a43547000a6ee3a9ef"}}}}
{"actor":{"display_login":"mluscon"}}