{"action":"created","issue":{"url":"https://api.github.com/repos/vhbb/cmssw/issues/393","repository_url":"https://api.github.com/repos/vhbb/cmssw","labels_url":"https://api.github.com/repos/vhbb/cmssw/issues/393/labels{/name}","comments_url":"https://api.github.com/repos/vhbb/cmssw/issues/393/comments","events_url":"https://api.github.com/repos/vhbb/cmssw/issues/393/events","html_url":"https://github.com/vhbb/cmssw/issues/393","id":137631441,"number":393,"title":"A philosophical issue on Jet_corr","user":{"login":"bianchini","id":5062712,"avatar_url":"https://avatars.githubusercontent.com/u/5062712?v=3","gravatar_id":"","url":"https://api.github.com/users/bianchini","html_url":"https://github.com/bianchini","followers_url":"https://api.github.com/users/bianchini/followers","following_url":"https://api.github.com/users/bianchini/following{/other_user}","gists_url":"https://api.github.com/users/bianchini/gists{/gist_id}","starred_url":"https://api.github.com/users/bianchini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bianchini/subscriptions","organizations_url":"https://api.github.com/users/bianchini/orgs","repos_url":"https://api.github.com/users/bianchini/repos","events_url":"https://api.github.com/users/bianchini/events{/privacy}","received_events_url":"https://api.github.com/users/bianchini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-01T17:01:40Z","updated_at":"2016-03-01T18:03:52Z","closed_at":null,"body":"My current understanding is (mixing heppy and vhbb names):\r\n\r\nJet_rawPt = j.rawFactor() * Jet_pt\r\n[https://github.com/vhbb/cmssw/blob/vhbbHeppy76X/PhysicsTools/Heppy/python/analyzers/objects/JetAnalyzer.py#L440]\r\n\r\nJet_pt = Jet_rawPt * Jet_corr * Jet_corr_JER\r\n\r\nhence:\r\nJet_corr = 1 /  j.rawFactor() / Jet_corr_JER\r\n\r\nCan you confirm?\r\n\r\nThen, from https://github.com/vhbb/cmssw/blob/vhbbHeppy76X/VHbbAnalysis/Heppy/python/JetRegression.py#L70 I see that what is called \"Jet_corr\" in the BDT training is actually filled with j.rawFactor(), but evaluated with 1/j.rawFactor()/Jet_corr_JER..\r\n\r\n@cvernier, @degrutto : maybe it's just me slow at the end of the day, but can you double check?\r\n"},"comment":{"url":"https://api.github.com/repos/vhbb/cmssw/issues/comments/190835421","html_url":"https://github.com/vhbb/cmssw/issues/393#issuecomment-190835421","issue_url":"https://api.github.com/repos/vhbb/cmssw/issues/393","id":190835421,"user":{"login":"degrutto","id":5023459,"avatar_url":"https://avatars.githubusercontent.com/u/5023459?v=3","gravatar_id":"","url":"https://api.github.com/users/degrutto","html_url":"https://github.com/degrutto","followers_url":"https://api.github.com/users/degrutto/followers","following_url":"https://api.github.com/users/degrutto/following{/other_user}","gists_url":"https://api.github.com/users/degrutto/gists{/gist_id}","starred_url":"https://api.github.com/users/degrutto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degrutto/subscriptions","organizations_url":"https://api.github.com/users/degrutto/orgs","repos_url":"https://api.github.com/users/degrutto/repos","events_url":"https://api.github.com/users/degrutto/events{/privacy}","received_events_url":"https://api.github.com/users/degrutto/received_events","type":"User","site_admin":false},"created_at":"2016-03-01T18:03:52Z","updated_at":"2016-03-01T18:03:52Z","body":"btw I am lookig at V20, ttbar sample\r\n\r\nTFile *_file0 = TFile::Open(\"/afs/cern.ch/user/d/degrutto/eos/cms/store/group/phys_higgs/hbb/ntuples/V20/user/arizzi/VHBBHeppyV20/TT_TuneCUETP8M1_13TeV-amcatnlo-pythia8/VHBB_HEPPY_V20_TT_TuneCUETP8M1_13TeV-amcatnlo-Py8__fall15MAv2-pu25ns15v1_76r2as_v12-v1/160209_171214/0000/tree_185.root\")\r\n\r\nIt seems for pt_reg_JER up and down is not working ....\r\n\r\ntree>Scan(\"Jet_pt:Jet_rawPt:Jet_pt_reg:Jet_pt_reg_corrJECDown:Jet_pt_reg_corrJECUp:Jet_pt_reg_corrJERDown:Jet_pt_reg_corrJERUp\")***********************************************************************************************************\r\n*    Row   * Instance *    Jet_pt * Jet_rawPt * Jet_pt_re * Jet_pt_re * Jet_pt_re * Jet_pt_re * Jet_pt_re *\r\n***********************************************************************************************************\r\n*        0 *        0 * 89.004646 * 84.189796 * 99.159065 * 97.201408 * 99.159065 * 99.159065 * 99.159065 *\r\n*        0 *        1 * 69.226524 * 65.142646 * 76.216239 * 70.479888 * 76.216239 * 76.216239 * 76.216239 *\r\n*        0 *        2 * 64.546798 * 60.819320 * 66.319244 * 66.098068 * 66.784019 * 66.319244 * 66.319244 *\r\n*        0 *        3 * 38.137394 * 33.105632 * 42.105236 * 41.232669 * 42.225109 * 42.105236 * 42.105236 *\r\n*        0 *        4 * 34.861076 * 32.458133 * 37.019676 * 35.596744 * 37.788185 * 37.019676 * 37.019676 *\r\n*        0 *        5 * 34.606121 * 31.620266 * 37.758926 * 35.767631 * 39.306823 * 37.014621 * 38.538311 *\r\n*        0 *        6 * 21.295307 * 17.644607 * 30.533784 * 30.533784 * 30.670822 * 30.533784 * 30.533784 *\r\n*        1 *        0 * 89.203117 * 86.533798 * 88.759758 * 88.759758 * 90.265502 * 88.759758 * 88.759758 *\r\n*        1 *        1 * 88.464683 * 85.513298 * 91.131874 * 88.802078 * 91.131874 * 91.131874 * 91.131874 *\r\n*        1 *        2 * 34.510501 * 33.320945 * 38.429451 * 36.507549 * 39.108078 * 38.429451 * 38.429451 *\r\n"}}