{"action":"closed","issue":{"url":"https://api.github.com/repos/airdcpp/airgit/issues/8","repository_url":"https://api.github.com/repos/airdcpp/airgit","labels_url":"https://api.github.com/repos/airdcpp/airgit/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/airdcpp/airgit/issues/8/comments","events_url":"https://api.github.com/repos/airdcpp/airgit/issues/8/events","html_url":"https://github.com/airdcpp/airgit/issues/8","id":165289083,"number":8,"title":"Return value of Wizard*::OnSetActive()","user":{"login":"Caraul","id":6199620,"avatar_url":"https://avatars.githubusercontent.com/u/6199620?v=3","gravatar_id":"","url":"https://api.github.com/users/Caraul","html_url":"https://github.com/Caraul","followers_url":"https://api.github.com/users/Caraul/followers","following_url":"https://api.github.com/users/Caraul/following{/other_user}","gists_url":"https://api.github.com/users/Caraul/gists{/gist_id}","starred_url":"https://api.github.com/users/Caraul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caraul/subscriptions","organizations_url":"https://api.github.com/users/Caraul/orgs","repos_url":"https://api.github.com/users/Caraul/repos","events_url":"https://api.github.com/users/Caraul/events{/privacy}","received_events_url":"https://api.github.com/users/Caraul/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-13T10:32:45Z","updated_at":"2016-07-13T14:05:51Z","closed_at":"2016-07-13T14:05:51Z","body":"Hello,\r\n\r\ncurrently all Return value of Wizard*::OnSetActive() returns 0. From the other side PSN_SETACTIVE is processed as lResult = pT->OnSetActive() ? 0 : -1 and requires \"zero to accept the activation, or -1 to activate the next or the previous page\". Base implementation simply returns TRUE. I've met problems running hand-built AirDC and solved them replacing 0 with TRUE.\r\nSimilar issue is with SetupWizard::OnWizardFinish() - it returns FALSE but is processed as lResult = !pT->OnWizardFinish() inverting value. PSN_WIZFINISH requires \"FALSE to allow the wizard to finish\" so OnWizardFinish should return TRUE.\r\nI use MS VC 2015 Update 3.\r\n\r\nbest regards,\r\nAlexander Alexeev"}}
{"actor":{"display_login":"Caraul"}}