{"action":"closed","number":155,"pull_request":{"url":"https://api.github.com/repos/rrag/react-stockcharts/pulls/155","id":89522931,"html_url":"https://github.com/rrag/react-stockcharts/pull/155","diff_url":"https://github.com/rrag/react-stockcharts/pull/155.diff","patch_url":"https://github.com/rrag/react-stockcharts/pull/155.patch","issue_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/155","number":155,"state":"closed","locked":false,"title":"HoverTooltip followed by a yAccessor","user":{"login":"cesardeazevedo","id":5366959,"avatar_url":"https://avatars.githubusercontent.com/u/5366959?v=3","gravatar_id":"","url":"https://api.github.com/users/cesardeazevedo","html_url":"https://github.com/cesardeazevedo","followers_url":"https://api.github.com/users/cesardeazevedo/followers","following_url":"https://api.github.com/users/cesardeazevedo/following{/other_user}","gists_url":"https://api.github.com/users/cesardeazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/cesardeazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesardeazevedo/subscriptions","organizations_url":"https://api.github.com/users/cesardeazevedo/orgs","repos_url":"https://api.github.com/users/cesardeazevedo/repos","events_url":"https://api.github.com/users/cesardeazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/cesardeazevedo/received_events","type":"User","site_admin":false},"body":"This allows us to set HoverTooltip to follows a yAccessor instead of the mouse point, 2 new props were added on HoverTooltip, `chartId` and `yAccessor`, since the HoverTooltip is out of the Chart itself, i didn't had a way to get which chart to access yScale function, so i had add the `chartId` prop to refers it, and the `yAccessor` prop itself, if both props were not provided, it fallback to the mouse point default behavior, we could also add a specific property to it, i would like to hear a feedback from you.\r\n\r\nhere's some examples\r\n\r\nFollows by mouse.\r\n\r\n![chart-mouse](https://cloud.githubusercontent.com/assets/5366959/19416964/a114132e-937e-11e6-8a19-95de7e7bf01e.gif)\r\n\r\nFollows by a yAccessor, e.g.: `ema50.accessor()`\r\n\r\n![chart-yaccessor](https://cloud.githubusercontent.com/assets/5366959/19416971/bd7ab22a-937e-11e6-9842-bdc371cb7a53.gif)\r\n\r\nAlso, both svg and canvas works, and the padding limits works as well.","created_at":"2016-10-16T11:12:28Z","updated_at":"2016-10-20T14:15:30Z","closed_at":"2016-10-20T14:15:30Z","merged_at":"2016-10-20T14:15:30Z","merge_commit_sha":"98635178ee366e6161c1f2c5ebe67046fc5ff337","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rrag/react-stockcharts/pulls/155/commits","review_comments_url":"https://api.github.com/repos/rrag/react-stockcharts/pulls/155/comments","review_comment_url":"https://api.github.com/repos/rrag/react-stockcharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/155/comments","statuses_url":"https://api.github.com/repos/rrag/react-stockcharts/statuses/d6bea7e06f1cbf57a97ae1534f32000ef2e8ee88","head":{"label":"cesardeazevedo:master","ref":"master","sha":"d6bea7e06f1cbf57a97ae1534f32000ef2e8ee88","user":{"login":"cesardeazevedo","id":5366959,"avatar_url":"https://avatars.githubusercontent.com/u/5366959?v=3","gravatar_id":"","url":"https://api.github.com/users/cesardeazevedo","html_url":"https://github.com/cesardeazevedo","followers_url":"https://api.github.com/users/cesardeazevedo/followers","following_url":"https://api.github.com/users/cesardeazevedo/following{/other_user}","gists_url":"https://api.github.com/users/cesardeazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/cesardeazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesardeazevedo/subscriptions","organizations_url":"https://api.github.com/users/cesardeazevedo/orgs","repos_url":"https://api.github.com/users/cesardeazevedo/repos","events_url":"https://api.github.com/users/cesardeazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/cesardeazevedo/received_events","type":"User","site_admin":false},"repo":{"id":59286651,"name":"react-stockcharts","full_name":"cesardeazevedo/react-stockcharts","owner":{"login":"cesardeazevedo","id":5366959,"avatar_url":"https://avatars.githubusercontent.com/u/5366959?v=3","gravatar_id":"","url":"https://api.github.com/users/cesardeazevedo","html_url":"https://github.com/cesardeazevedo","followers_url":"https://api.github.com/users/cesardeazevedo/followers","following_url":"https://api.github.com/users/cesardeazevedo/following{/other_user}","gists_url":"https://api.github.com/users/cesardeazevedo/gists{/gist_id}","starred_url":"https://api.github.com/users/cesardeazevedo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesardeazevedo/subscriptions","organizations_url":"https://api.github.com/users/cesardeazevedo/orgs","repos_url":"https://api.github.com/users/cesardeazevedo/repos","events_url":"https://api.github.com/users/cesardeazevedo/events{/privacy}","received_events_url":"https://api.github.com/users/cesardeazevedo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cesardeazevedo/react-stockcharts","description":"Highly customizable stock charts with ReactJS and d3","fork":true,"url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts","forks_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/forks","keys_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/teams","hooks_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/hooks","issue_events_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/issues/events{/number}","events_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/events","assignees_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/assignees{/user}","branches_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/branches{/branch}","tags_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/tags","blobs_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/languages","stargazers_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/stargazers","contributors_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/contributors","subscribers_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/subscribers","subscription_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/subscription","commits_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/contents/{+path}","compare_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/merges","archive_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/downloads","issues_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/issues{/number}","pulls_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/labels{/name}","releases_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/releases{/id}","deployments_url":"https://api.github.com/repos/cesardeazevedo/react-stockcharts/deployments","created_at":"2016-05-20T10:40:14Z","updated_at":"2016-05-20T10:40:16Z","pushed_at":"2016-10-16T10:53:24Z","git_url":"git://github.com/cesardeazevedo/react-stockcharts.git","ssh_url":"git@github.com:cesardeazevedo/react-stockcharts.git","clone_url":"https://github.com/cesardeazevedo/react-stockcharts.git","svn_url":"https://github.com/cesardeazevedo/react-stockcharts","homepage":"http://rrag.github.io/react-stockcharts","size":7099,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rrag:master","ref":"master","sha":"d021a486ddb01c1eb81f0120e0dd15c8cfa57eda","user":{"login":"rrag","id":10691183,"avatar_url":"https://avatars.githubusercontent.com/u/10691183?v=3","gravatar_id":"","url":"https://api.github.com/users/rrag","html_url":"https://github.com/rrag","followers_url":"https://api.github.com/users/rrag/followers","following_url":"https://api.github.com/users/rrag/following{/other_user}","gists_url":"https://api.github.com/users/rrag/gists{/gist_id}","starred_url":"https://api.github.com/users/rrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrag/subscriptions","organizations_url":"https://api.github.com/users/rrag/orgs","repos_url":"https://api.github.com/users/rrag/repos","events_url":"https://api.github.com/users/rrag/events{/privacy}","received_events_url":"https://api.github.com/users/rrag/received_events","type":"User","site_admin":false},"repo":{"id":31165640,"name":"react-stockcharts","full_name":"rrag/react-stockcharts","owner":{"login":"rrag","id":10691183,"avatar_url":"https://avatars.githubusercontent.com/u/10691183?v=3","gravatar_id":"","url":"https://api.github.com/users/rrag","html_url":"https://github.com/rrag","followers_url":"https://api.github.com/users/rrag/followers","following_url":"https://api.github.com/users/rrag/following{/other_user}","gists_url":"https://api.github.com/users/rrag/gists{/gist_id}","starred_url":"https://api.github.com/users/rrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrag/subscriptions","organizations_url":"https://api.github.com/users/rrag/orgs","repos_url":"https://api.github.com/users/rrag/repos","events_url":"https://api.github.com/users/rrag/events{/privacy}","received_events_url":"https://api.github.com/users/rrag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rrag/react-stockcharts","description":"Highly customizable stock charts with ReactJS and d3","fork":false,"url":"https://api.github.com/repos/rrag/react-stockcharts","forks_url":"https://api.github.com/repos/rrag/react-stockcharts/forks","keys_url":"https://api.github.com/repos/rrag/react-stockcharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rrag/react-stockcharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rrag/react-stockcharts/teams","hooks_url":"https://api.github.com/repos/rrag/react-stockcharts/hooks","issue_events_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/events{/number}","events_url":"https://api.github.com/repos/rrag/react-stockcharts/events","assignees_url":"https://api.github.com/repos/rrag/react-stockcharts/assignees{/user}","branches_url":"https://api.github.com/repos/rrag/react-stockcharts/branches{/branch}","tags_url":"https://api.github.com/repos/rrag/react-stockcharts/tags","blobs_url":"https://api.github.com/repos/rrag/react-stockcharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rrag/react-stockcharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rrag/react-stockcharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/rrag/react-stockcharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rrag/react-stockcharts/statuses/{sha}","languages_url":"https://api.github.com/repos/rrag/react-stockcharts/languages","stargazers_url":"https://api.github.com/repos/rrag/react-stockcharts/stargazers","contributors_url":"https://api.github.com/repos/rrag/react-stockcharts/contributors","subscribers_url":"https://api.github.com/repos/rrag/react-stockcharts/subscribers","subscription_url":"https://api.github.com/repos/rrag/react-stockcharts/subscription","commits_url":"https://api.github.com/repos/rrag/react-stockcharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/rrag/react-stockcharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/rrag/react-stockcharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/rrag/react-stockcharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/rrag/react-stockcharts/contents/{+path}","compare_url":"https://api.github.com/repos/rrag/react-stockcharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rrag/react-stockcharts/merges","archive_url":"https://api.github.com/repos/rrag/react-stockcharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rrag/react-stockcharts/downloads","issues_url":"https://api.github.com/repos/rrag/react-stockcharts/issues{/number}","pulls_url":"https://api.github.com/repos/rrag/react-stockcharts/pulls{/number}","milestones_url":"https://api.github.com/repos/rrag/react-stockcharts/milestones{/number}","notifications_url":"https://api.github.com/repos/rrag/react-stockcharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rrag/react-stockcharts/labels{/name}","releases_url":"https://api.github.com/repos/rrag/react-stockcharts/releases{/id}","deployments_url":"https://api.github.com/repos/rrag/react-stockcharts/deployments","created_at":"2015-02-22T14:34:39Z","updated_at":"2016-10-19T09:58:24Z","pushed_at":"2016-10-20T14:15:30Z","git_url":"git://github.com/rrag/react-stockcharts.git","ssh_url":"git@github.com:rrag/react-stockcharts.git","clone_url":"https://github.com/rrag/react-stockcharts.git","svn_url":"https://github.com/rrag/react-stockcharts","homepage":"http://rrag.github.io/react-stockcharts","size":7303,"stargazers_count":442,"watchers_count":442,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":10,"forks":124,"open_issues":10,"watchers":442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rrag/react-stockcharts/pulls/155"},"html":{"href":"https://github.com/rrag/react-stockcharts/pull/155"},"issue":{"href":"https://api.github.com/repos/rrag/react-stockcharts/issues/155"},"comments":{"href":"https://api.github.com/repos/rrag/react-stockcharts/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/rrag/react-stockcharts/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/rrag/react-stockcharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rrag/react-stockcharts/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/rrag/react-stockcharts/statuses/d6bea7e06f1cbf57a97ae1534f32000ef2e8ee88"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rrag","id":10691183,"avatar_url":"https://avatars.githubusercontent.com/u/10691183?v=3","gravatar_id":"","url":"https://api.github.com/users/rrag","html_url":"https://github.com/rrag","followers_url":"https://api.github.com/users/rrag/followers","following_url":"https://api.github.com/users/rrag/following{/other_user}","gists_url":"https://api.github.com/users/rrag/gists{/gist_id}","starred_url":"https://api.github.com/users/rrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrag/subscriptions","organizations_url":"https://api.github.com/users/rrag/orgs","repos_url":"https://api.github.com/users/rrag/repos","events_url":"https://api.github.com/users/rrag/events{/privacy}","received_events_url":"https://api.github.com/users/rrag/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":34,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"rrag"}}