{"action":"created","comment":{"url":"https://api.github.com/repos/torch/torch7/pulls/comments/80407707","id":80407707,"diff_hunk":"@@ -459,8 +460,8 @@ static size_t THMemoryFile_writeLong(THFile *self, long *data, size_t n)\n     {\n       int i, big_endian = !THDiskFile_isLittleEndianCPU();\n       size_t nByte = 8*n;\n-      long *storage = (long *)(mfself->storage->data + mfself->position);\n       THMemoryFile_grow(mfself, mfself->position+nByte);\n+      int32_t *storage = (int32_t *)(mfself->storage->data + mfself->position);","path":"lib/TH/THMemoryFile.c","position":47,"original_position":47,"commit_id":"3a89ab24b28470d23702bd04674d9906d07f5ca7","original_commit_id":"3a89ab24b28470d23702bd04674d9906d07f5ca7","user":{"login":"BTNC","id":15757197,"avatar_url":"https://avatars.githubusercontent.com/u/15757197?v=3","gravatar_id":"","url":"https://api.github.com/users/BTNC","html_url":"https://github.com/BTNC","followers_url":"https://api.github.com/users/BTNC/followers","following_url":"https://api.github.com/users/BTNC/following{/other_user}","gists_url":"https://api.github.com/users/BTNC/gists{/gist_id}","starred_url":"https://api.github.com/users/BTNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTNC/subscriptions","organizations_url":"https://api.github.com/users/BTNC/orgs","repos_url":"https://api.github.com/users/BTNC/repos","events_url":"https://api.github.com/users/BTNC/events{/privacy}","received_events_url":"https://api.github.com/users/BTNC/received_events","type":"User","site_admin":false},"body":"It should be int32_t. The reason is same with last comment.","created_at":"2016-09-26T04:49:05Z","updated_at":"2016-09-26T04:49:05Z","html_url":"https://github.com/torch/torch7/pull/774#discussion_r80407707","pull_request_url":"https://api.github.com/repos/torch/torch7/pulls/774","_links":{"self":{"href":"https://api.github.com/repos/torch/torch7/pulls/comments/80407707"},"html":{"href":"https://github.com/torch/torch7/pull/774#discussion_r80407707"},"pull_request":{"href":"https://api.github.com/repos/torch/torch7/pulls/774"}}},"pull_request":{"url":"https://api.github.com/repos/torch/torch7/pulls/774","id":86675558,"html_url":"https://github.com/torch/torch7/pull/774","diff_url":"https://github.com/torch/torch7/pull/774.diff","patch_url":"https://github.com/torch/torch7/pull/774.patch","issue_url":"https://api.github.com/repos/torch/torch7/issues/774","number":774,"state":"open","locked":false,"title":"bug fix for read/writeLong in THMemoryFile and 2 test files change for windows","user":{"login":"BTNC","id":15757197,"avatar_url":"https://avatars.githubusercontent.com/u/15757197?v=3","gravatar_id":"","url":"https://api.github.com/users/BTNC","html_url":"https://github.com/BTNC","followers_url":"https://api.github.com/users/BTNC/followers","following_url":"https://api.github.com/users/BTNC/following{/other_user}","gists_url":"https://api.github.com/users/BTNC/gists{/gist_id}","starred_url":"https://api.github.com/users/BTNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTNC/subscriptions","organizations_url":"https://api.github.com/users/BTNC/orgs","repos_url":"https://api.github.com/users/BTNC/repos","events_url":"https://api.github.com/users/BTNC/events{/privacy}","received_events_url":"https://api.github.com/users/BTNC/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nThere is a bug in THMemoryFile read/writelong for following cases:\r\n(1) sizeof(long) is 8 while longSize is set to 4;\r\n(2) sizeof(long) is 4 while longSize is set to 8;\r\n\r\nThis change comes along with 2 test files change for windows.\r\n\r\nThanks,","created_at":"2016-09-26T03:10:12Z","updated_at":"2016-09-26T04:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e7b15708145413091200d8d27d5a45bd3bc69e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/torch/torch7/pulls/774/commits","review_comments_url":"https://api.github.com/repos/torch/torch7/pulls/774/comments","review_comment_url":"https://api.github.com/repos/torch/torch7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/torch/torch7/issues/774/comments","statuses_url":"https://api.github.com/repos/torch/torch7/statuses/3a89ab24b28470d23702bd04674d9906d07f5ca7","head":{"label":"BTNC:master","ref":"master","sha":"3a89ab24b28470d23702bd04674d9906d07f5ca7","user":{"login":"BTNC","id":15757197,"avatar_url":"https://avatars.githubusercontent.com/u/15757197?v=3","gravatar_id":"","url":"https://api.github.com/users/BTNC","html_url":"https://github.com/BTNC","followers_url":"https://api.github.com/users/BTNC/followers","following_url":"https://api.github.com/users/BTNC/following{/other_user}","gists_url":"https://api.github.com/users/BTNC/gists{/gist_id}","starred_url":"https://api.github.com/users/BTNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTNC/subscriptions","organizations_url":"https://api.github.com/users/BTNC/orgs","repos_url":"https://api.github.com/users/BTNC/repos","events_url":"https://api.github.com/users/BTNC/events{/privacy}","received_events_url":"https://api.github.com/users/BTNC/received_events","type":"User","site_admin":false},"repo":{"id":68526168,"name":"torch7","full_name":"BTNC/torch7","owner":{"login":"BTNC","id":15757197,"avatar_url":"https://avatars.githubusercontent.com/u/15757197?v=3","gravatar_id":"","url":"https://api.github.com/users/BTNC","html_url":"https://github.com/BTNC","followers_url":"https://api.github.com/users/BTNC/followers","following_url":"https://api.github.com/users/BTNC/following{/other_user}","gists_url":"https://api.github.com/users/BTNC/gists{/gist_id}","starred_url":"https://api.github.com/users/BTNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BTNC/subscriptions","organizations_url":"https://api.github.com/users/BTNC/orgs","repos_url":"https://api.github.com/users/BTNC/repos","events_url":"https://api.github.com/users/BTNC/events{/privacy}","received_events_url":"https://api.github.com/users/BTNC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BTNC/torch7","description":"http://torch.ch","fork":true,"url":"https://api.github.com/repos/BTNC/torch7","forks_url":"https://api.github.com/repos/BTNC/torch7/forks","keys_url":"https://api.github.com/repos/BTNC/torch7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BTNC/torch7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BTNC/torch7/teams","hooks_url":"https://api.github.com/repos/BTNC/torch7/hooks","issue_events_url":"https://api.github.com/repos/BTNC/torch7/issues/events{/number}","events_url":"https://api.github.com/repos/BTNC/torch7/events","assignees_url":"https://api.github.com/repos/BTNC/torch7/assignees{/user}","branches_url":"https://api.github.com/repos/BTNC/torch7/branches{/branch}","tags_url":"https://api.github.com/repos/BTNC/torch7/tags","blobs_url":"https://api.github.com/repos/BTNC/torch7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BTNC/torch7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BTNC/torch7/git/refs{/sha}","trees_url":"https://api.github.com/repos/BTNC/torch7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BTNC/torch7/statuses/{sha}","languages_url":"https://api.github.com/repos/BTNC/torch7/languages","stargazers_url":"https://api.github.com/repos/BTNC/torch7/stargazers","contributors_url":"https://api.github.com/repos/BTNC/torch7/contributors","subscribers_url":"https://api.github.com/repos/BTNC/torch7/subscribers","subscription_url":"https://api.github.com/repos/BTNC/torch7/subscription","commits_url":"https://api.github.com/repos/BTNC/torch7/commits{/sha}","git_commits_url":"https://api.github.com/repos/BTNC/torch7/git/commits{/sha}","comments_url":"https://api.github.com/repos/BTNC/torch7/comments{/number}","issue_comment_url":"https://api.github.com/repos/BTNC/torch7/issues/comments{/number}","contents_url":"https://api.github.com/repos/BTNC/torch7/contents/{+path}","compare_url":"https://api.github.com/repos/BTNC/torch7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BTNC/torch7/merges","archive_url":"https://api.github.com/repos/BTNC/torch7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BTNC/torch7/downloads","issues_url":"https://api.github.com/repos/BTNC/torch7/issues{/number}","pulls_url":"https://api.github.com/repos/BTNC/torch7/pulls{/number}","milestones_url":"https://api.github.com/repos/BTNC/torch7/milestones{/number}","notifications_url":"https://api.github.com/repos/BTNC/torch7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BTNC/torch7/labels{/name}","releases_url":"https://api.github.com/repos/BTNC/torch7/releases{/id}","deployments_url":"https://api.github.com/repos/BTNC/torch7/deployments","created_at":"2016-09-18T14:22:17Z","updated_at":"2016-09-18T14:22:19Z","pushed_at":"2016-09-26T02:54:45Z","git_url":"git://github.com/BTNC/torch7.git","ssh_url":"git@github.com:BTNC/torch7.git","clone_url":"https://github.com/BTNC/torch7.git","svn_url":"https://github.com/BTNC/torch7","homepage":"","size":1888,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"torch:master","ref":"master","sha":"337002110f869b66abd2ca59bfb794dba9ed072f","user":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"repo":{"id":13677187,"name":"torch7","full_name":"torch/torch7","owner":{"login":"torch","id":4978924,"avatar_url":"https://avatars.githubusercontent.com/u/4978924?v=3","gravatar_id":"","url":"https://api.github.com/users/torch","html_url":"https://github.com/torch","followers_url":"https://api.github.com/users/torch/followers","following_url":"https://api.github.com/users/torch/following{/other_user}","gists_url":"https://api.github.com/users/torch/gists{/gist_id}","starred_url":"https://api.github.com/users/torch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torch/subscriptions","organizations_url":"https://api.github.com/users/torch/orgs","repos_url":"https://api.github.com/users/torch/repos","events_url":"https://api.github.com/users/torch/events{/privacy}","received_events_url":"https://api.github.com/users/torch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/torch/torch7","description":"http://torch.ch","fork":false,"url":"https://api.github.com/repos/torch/torch7","forks_url":"https://api.github.com/repos/torch/torch7/forks","keys_url":"https://api.github.com/repos/torch/torch7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torch/torch7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torch/torch7/teams","hooks_url":"https://api.github.com/repos/torch/torch7/hooks","issue_events_url":"https://api.github.com/repos/torch/torch7/issues/events{/number}","events_url":"https://api.github.com/repos/torch/torch7/events","assignees_url":"https://api.github.com/repos/torch/torch7/assignees{/user}","branches_url":"https://api.github.com/repos/torch/torch7/branches{/branch}","tags_url":"https://api.github.com/repos/torch/torch7/tags","blobs_url":"https://api.github.com/repos/torch/torch7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torch/torch7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torch/torch7/git/refs{/sha}","trees_url":"https://api.github.com/repos/torch/torch7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torch/torch7/statuses/{sha}","languages_url":"https://api.github.com/repos/torch/torch7/languages","stargazers_url":"https://api.github.com/repos/torch/torch7/stargazers","contributors_url":"https://api.github.com/repos/torch/torch7/contributors","subscribers_url":"https://api.github.com/repos/torch/torch7/subscribers","subscription_url":"https://api.github.com/repos/torch/torch7/subscription","commits_url":"https://api.github.com/repos/torch/torch7/commits{/sha}","git_commits_url":"https://api.github.com/repos/torch/torch7/git/commits{/sha}","comments_url":"https://api.github.com/repos/torch/torch7/comments{/number}","issue_comment_url":"https://api.github.com/repos/torch/torch7/issues/comments{/number}","contents_url":"https://api.github.com/repos/torch/torch7/contents/{+path}","compare_url":"https://api.github.com/repos/torch/torch7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torch/torch7/merges","archive_url":"https://api.github.com/repos/torch/torch7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torch/torch7/downloads","issues_url":"https://api.github.com/repos/torch/torch7/issues{/number}","pulls_url":"https://api.github.com/repos/torch/torch7/pulls{/number}","milestones_url":"https://api.github.com/repos/torch/torch7/milestones{/number}","notifications_url":"https://api.github.com/repos/torch/torch7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torch/torch7/labels{/name}","releases_url":"https://api.github.com/repos/torch/torch7/releases{/id}","deployments_url":"https://api.github.com/repos/torch/torch7/deployments","created_at":"2013-10-18T12:13:58Z","updated_at":"2016-09-25T22:46:29Z","pushed_at":"2016-09-26T03:10:12Z","git_url":"git://github.com/torch/torch7.git","ssh_url":"git@github.com:torch/torch7.git","clone_url":"https://github.com/torch/torch7.git","svn_url":"https://github.com/torch/torch7","homepage":"","size":2747,"stargazers_count":5473,"watchers_count":5473,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1583,"mirror_url":null,"open_issues_count":85,"forks":1583,"open_issues":85,"watchers":5473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/torch/torch7/pulls/774"},"html":{"href":"https://github.com/torch/torch7/pull/774"},"issue":{"href":"https://api.github.com/repos/torch/torch7/issues/774"},"comments":{"href":"https://api.github.com/repos/torch/torch7/issues/774/comments"},"review_comments":{"href":"https://api.github.com/repos/torch/torch7/pulls/774/comments"},"review_comment":{"href":"https://api.github.com/repos/torch/torch7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/torch/torch7/pulls/774/commits"},"statuses":{"href":"https://api.github.com/repos/torch/torch7/statuses/3a89ab24b28470d23702bd04674d9906d07f5ca7"}}}}
{"actor":{"display_login":"BTNC"}}