{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/59109001","id":59109001,"diff_hunk":"@@ -2358,13 +2358,13 @@ void set_completion(colnr_T startcol, list_T *list)\n   int save_w_wrow = curwin->w_wrow;\n \n   compl_curr_match = compl_first_match;\n-  if (compl_no_insert) {\n+  if (compl_no_insert || compl_no_select) {\n     ins_complete(K_DOWN, false);\n-  } else {\n-    ins_complete(Ctrl_N, false);\n     if (compl_no_select) {\n-      ins_complete(Ctrl_P, false);\n+      ins_complete(K_UP, false);","path":"src/nvim/edit.c","position":11,"original_position":11,"commit_id":"fa409bc7b0f51e3ce178dcd716e4d7bf33312406","original_commit_id":"fa409bc7b0f51e3ce178dcd716e4d7bf33312406","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"If `compl_no_select`, it does:\r\n\r\n    ins_complete(K_DOWN, false);\r\n    ins_complete(K_UP, false);\r\n\r\nWhat is the purpose of this?","created_at":"2016-04-09T02:45:37Z","updated_at":"2016-04-09T02:45:37Z","html_url":"https://github.com/neovim/neovim/pull/4509#discussion_r59109001","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/4509","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/59109001"},"html":{"href":"https://github.com/neovim/neovim/pull/4509#discussion_r59109001"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4509"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/4509","id":64777550,"html_url":"https://github.com/neovim/neovim/pull/4509","diff_url":"https://github.com/neovim/neovim/pull/4509.diff","patch_url":"https://github.com/neovim/neovim/pull/4509.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/4509","number":4509,"state":"open","locked":false,"title":"Fix set modified problem in complete() if set completeopt=noselect","user":{"login":"Shougo","id":41495,"avatar_url":"https://avatars.githubusercontent.com/u/41495?v=3","gravatar_id":"","url":"https://api.github.com/users/Shougo","html_url":"https://github.com/Shougo","followers_url":"https://api.github.com/users/Shougo/followers","following_url":"https://api.github.com/users/Shougo/following{/other_user}","gists_url":"https://api.github.com/users/Shougo/gists{/gist_id}","starred_url":"https://api.github.com/users/Shougo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shougo/subscriptions","organizations_url":"https://api.github.com/users/Shougo/orgs","repos_url":"https://api.github.com/users/Shougo/repos","events_url":"https://api.github.com/users/Shougo/events{/privacy}","received_events_url":"https://api.github.com/users/Shougo/received_events","type":"User","site_admin":false},"body":"It fixes https://github.com/Shougo/deoplete.nvim/issues/232 problem.\r\n\r\n@nhooyr : Ping","created_at":"2016-03-31T11:54:16Z","updated_at":"2016-04-09T02:45:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc8c65ecbd6700641531441bff28e845a26d0e41","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/4509/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/4509/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/4509/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/fa409bc7b0f51e3ce178dcd716e4d7bf33312406","head":{"label":"Shougo:complete","ref":"complete","sha":"fa409bc7b0f51e3ce178dcd716e4d7bf33312406","user":{"login":"Shougo","id":41495,"avatar_url":"https://avatars.githubusercontent.com/u/41495?v=3","gravatar_id":"","url":"https://api.github.com/users/Shougo","html_url":"https://github.com/Shougo","followers_url":"https://api.github.com/users/Shougo/followers","following_url":"https://api.github.com/users/Shougo/following{/other_user}","gists_url":"https://api.github.com/users/Shougo/gists{/gist_id}","starred_url":"https://api.github.com/users/Shougo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shougo/subscriptions","organizations_url":"https://api.github.com/users/Shougo/orgs","repos_url":"https://api.github.com/users/Shougo/repos","events_url":"https://api.github.com/users/Shougo/events{/privacy}","received_events_url":"https://api.github.com/users/Shougo/received_events","type":"User","site_admin":false},"repo":{"id":23832980,"name":"neovim","full_name":"Shougo/neovim","owner":{"login":"Shougo","id":41495,"avatar_url":"https://avatars.githubusercontent.com/u/41495?v=3","gravatar_id":"","url":"https://api.github.com/users/Shougo","html_url":"https://github.com/Shougo","followers_url":"https://api.github.com/users/Shougo/followers","following_url":"https://api.github.com/users/Shougo/following{/other_user}","gists_url":"https://api.github.com/users/Shougo/gists{/gist_id}","starred_url":"https://api.github.com/users/Shougo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shougo/subscriptions","organizations_url":"https://api.github.com/users/Shougo/orgs","repos_url":"https://api.github.com/users/Shougo/repos","events_url":"https://api.github.com/users/Shougo/events{/privacy}","received_events_url":"https://api.github.com/users/Shougo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Shougo/neovim","description":"vim for the 21st century","fork":true,"url":"https://api.github.com/repos/Shougo/neovim","forks_url":"https://api.github.com/repos/Shougo/neovim/forks","keys_url":"https://api.github.com/repos/Shougo/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shougo/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shougo/neovim/teams","hooks_url":"https://api.github.com/repos/Shougo/neovim/hooks","issue_events_url":"https://api.github.com/repos/Shougo/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/Shougo/neovim/events","assignees_url":"https://api.github.com/repos/Shougo/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/Shougo/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/Shougo/neovim/tags","blobs_url":"https://api.github.com/repos/Shougo/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shougo/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shougo/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shougo/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shougo/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/Shougo/neovim/languages","stargazers_url":"https://api.github.com/repos/Shougo/neovim/stargazers","contributors_url":"https://api.github.com/repos/Shougo/neovim/contributors","subscribers_url":"https://api.github.com/repos/Shougo/neovim/subscribers","subscription_url":"https://api.github.com/repos/Shougo/neovim/subscription","commits_url":"https://api.github.com/repos/Shougo/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shougo/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shougo/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shougo/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shougo/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/Shougo/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shougo/neovim/merges","archive_url":"https://api.github.com/repos/Shougo/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shougo/neovim/downloads","issues_url":"https://api.github.com/repos/Shougo/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/Shougo/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/Shougo/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/Shougo/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shougo/neovim/labels{/name}","releases_url":"https://api.github.com/repos/Shougo/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/Shougo/neovim/deployments","created_at":"2014-09-09T12:43:00Z","updated_at":"2016-01-13T22:41:43Z","pushed_at":"2016-04-04T14:11:20Z","git_url":"git://github.com/Shougo/neovim.git","ssh_url":"git@github.com:Shougo/neovim.git","clone_url":"https://github.com/Shougo/neovim.git","svn_url":"https://github.com/Shougo/neovim","homepage":"http://neovim.org/","size":40943,"stargazers_count":5,"watchers_count":5,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"47d44e00a2cf8083c57996531c8fa85f52a982d0","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and agility. Consider helping sustain Neovim development! ","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2016-04-09T00:30:18Z","pushed_at":"2016-04-09T01:53:39Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":65284,"stargazers_count":18095,"watchers_count":18095,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1281,"mirror_url":null,"open_issues_count":672,"forks":1281,"open_issues":672,"watchers":18095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4509"},"html":{"href":"https://github.com/neovim/neovim/pull/4509"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/4509"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/4509/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4509/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/4509/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/fa409bc7b0f51e3ce178dcd716e4d7bf33312406"}}}}