{"action":"created","comment":{"url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/comments/71504623","id":71504623,"diff_hunk":"@@ -380,14 +363,16 @@ class PageElement extends BaseElement {\n     this.setAttribute('_compiled', '');\n   }\n \n-  _registerExtraElement(element) {\n-    let extra = util.findChild(this, '.page__extra');\n-    if (!extra) {\n-      extra = util.create('.page__extra', {zIndex: 10001});\n-      this.appendChild(extra);\n+  _elementShouldBeMoved(el) {\n+    if (el.className.match(/\\bpage__/)) {","path":"core/src/elements/ons-page.js","position":53,"original_position":53,"commit_id":"27e72047696569a96c20a0504b911796b85cd3ab","original_commit_id":"27e72047696569a96c20a0504b911796b85cd3ab","user":{"login":"argelius","id":6549462,"avatar_url":"https://avatars.githubusercontent.com/u/6549462?v=3","gravatar_id":"","url":"https://api.github.com/users/argelius","html_url":"https://github.com/argelius","followers_url":"https://api.github.com/users/argelius/followers","following_url":"https://api.github.com/users/argelius/following{/other_user}","gists_url":"https://api.github.com/users/argelius/gists{/gist_id}","starred_url":"https://api.github.com/users/argelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/argelius/subscriptions","organizations_url":"https://api.github.com/users/argelius/orgs","repos_url":"https://api.github.com/users/argelius/repos","events_url":"https://api.github.com/users/argelius/events{/privacy}","received_events_url":"https://api.github.com/users/argelius/received_events","type":"User","site_admin":false},"body":"Maybe you can use `/\\bpage__content/.test(...)` instead since we are not using the match for anything.","created_at":"2016-07-20T10:59:50Z","updated_at":"2016-07-20T10:59:50Z","html_url":"https://github.com/OnsenUI/OnsenUI/pull/1516#discussion_r71504623","pull_request_url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516","_links":{"self":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/comments/71504623"},"html":{"href":"https://github.com/OnsenUI/OnsenUI/pull/1516#discussion_r71504623"},"pull_request":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516"}}},"pull_request":{"url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516","id":78125741,"html_url":"https://github.com/OnsenUI/OnsenUI/pull/1516","diff_url":"https://github.com/OnsenUI/OnsenUI/pull/1516.diff","patch_url":"https://github.com/OnsenUI/OnsenUI/pull/1516.patch","issue_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/1516","number":1516,"state":"open","locked":false,"title":"Page content movement simplification","user":{"login":"IliaSky","id":2514449,"avatar_url":"https://avatars.githubusercontent.com/u/2514449?v=3","gravatar_id":"","url":"https://api.github.com/users/IliaSky","html_url":"https://github.com/IliaSky","followers_url":"https://api.github.com/users/IliaSky/followers","following_url":"https://api.github.com/users/IliaSky/following{/other_user}","gists_url":"https://api.github.com/users/IliaSky/gists{/gist_id}","starred_url":"https://api.github.com/users/IliaSky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IliaSky/subscriptions","organizations_url":"https://api.github.com/users/IliaSky/orgs","repos_url":"https://api.github.com/users/IliaSky/repos","events_url":"https://api.github.com/users/IliaSky/events{/privacy}","received_events_url":"https://api.github.com/users/IliaSky/received_events","type":"User","site_admin":false},"body":"Now only moves elements a single time only if it is necessary instead of moving them multiple times in both directions until one comes out on top.\r\n\r\nAlso fixes #1511.","created_at":"2016-07-20T10:47:39Z","updated_at":"2016-07-20T10:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93776d6e76ef843a833ca89d52ea90bb80e8698e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516/commits","review_comments_url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516/comments","review_comment_url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/1516/comments","statuses_url":"https://api.github.com/repos/OnsenUI/OnsenUI/statuses/27e72047696569a96c20a0504b911796b85cd3ab","head":{"label":"OnsenUI:page-content-movement","ref":"page-content-movement","sha":"27e72047696569a96c20a0504b911796b85cd3ab","user":{"login":"OnsenUI","id":5972822,"avatar_url":"https://avatars.githubusercontent.com/u/5972822?v=3","gravatar_id":"","url":"https://api.github.com/users/OnsenUI","html_url":"https://github.com/OnsenUI","followers_url":"https://api.github.com/users/OnsenUI/followers","following_url":"https://api.github.com/users/OnsenUI/following{/other_user}","gists_url":"https://api.github.com/users/OnsenUI/gists{/gist_id}","starred_url":"https://api.github.com/users/OnsenUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OnsenUI/subscriptions","organizations_url":"https://api.github.com/users/OnsenUI/orgs","repos_url":"https://api.github.com/users/OnsenUI/repos","events_url":"https://api.github.com/users/OnsenUI/events{/privacy}","received_events_url":"https://api.github.com/users/OnsenUI/received_events","type":"Organization","site_admin":false},"repo":{"id":12755139,"name":"OnsenUI","full_name":"OnsenUI/OnsenUI","owner":{"login":"OnsenUI","id":5972822,"avatar_url":"https://avatars.githubusercontent.com/u/5972822?v=3","gravatar_id":"","url":"https://api.github.com/users/OnsenUI","html_url":"https://github.com/OnsenUI","followers_url":"https://api.github.com/users/OnsenUI/followers","following_url":"https://api.github.com/users/OnsenUI/following{/other_user}","gists_url":"https://api.github.com/users/OnsenUI/gists{/gist_id}","starred_url":"https://api.github.com/users/OnsenUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OnsenUI/subscriptions","organizations_url":"https://api.github.com/users/OnsenUI/orgs","repos_url":"https://api.github.com/users/OnsenUI/repos","events_url":"https://api.github.com/users/OnsenUI/events{/privacy}","received_events_url":"https://api.github.com/users/OnsenUI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OnsenUI/OnsenUI","description":"Hybrid Mobile App UI Framework for iOS and Material Design with Angular and React Components","fork":false,"url":"https://api.github.com/repos/OnsenUI/OnsenUI","forks_url":"https://api.github.com/repos/OnsenUI/OnsenUI/forks","keys_url":"https://api.github.com/repos/OnsenUI/OnsenUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OnsenUI/OnsenUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OnsenUI/OnsenUI/teams","hooks_url":"https://api.github.com/repos/OnsenUI/OnsenUI/hooks","issue_events_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/events{/number}","events_url":"https://api.github.com/repos/OnsenUI/OnsenUI/events","assignees_url":"https://api.github.com/repos/OnsenUI/OnsenUI/assignees{/user}","branches_url":"https://api.github.com/repos/OnsenUI/OnsenUI/branches{/branch}","tags_url":"https://api.github.com/repos/OnsenUI/OnsenUI/tags","blobs_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OnsenUI/OnsenUI/statuses/{sha}","languages_url":"https://api.github.com/repos/OnsenUI/OnsenUI/languages","stargazers_url":"https://api.github.com/repos/OnsenUI/OnsenUI/stargazers","contributors_url":"https://api.github.com/repos/OnsenUI/OnsenUI/contributors","subscribers_url":"https://api.github.com/repos/OnsenUI/OnsenUI/subscribers","subscription_url":"https://api.github.com/repos/OnsenUI/OnsenUI/subscription","commits_url":"https://api.github.com/repos/OnsenUI/OnsenUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/OnsenUI/OnsenUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/OnsenUI/OnsenUI/contents/{+path}","compare_url":"https://api.github.com/repos/OnsenUI/OnsenUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OnsenUI/OnsenUI/merges","archive_url":"https://api.github.com/repos/OnsenUI/OnsenUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OnsenUI/OnsenUI/downloads","issues_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues{/number}","pulls_url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls{/number}","milestones_url":"https://api.github.com/repos/OnsenUI/OnsenUI/milestones{/number}","notifications_url":"https://api.github.com/repos/OnsenUI/OnsenUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OnsenUI/OnsenUI/labels{/name}","releases_url":"https://api.github.com/repos/OnsenUI/OnsenUI/releases{/id}","deployments_url":"https://api.github.com/repos/OnsenUI/OnsenUI/deployments","created_at":"2013-09-11T11:52:41Z","updated_at":"2016-07-20T08:28:24Z","pushed_at":"2016-07-20T10:50:58Z","git_url":"git://github.com/OnsenUI/OnsenUI.git","ssh_url":"git@github.com:OnsenUI/OnsenUI.git","clone_url":"https://github.com/OnsenUI/OnsenUI.git","svn_url":"https://github.com/OnsenUI/OnsenUI","homepage":"https://onsen.io/","size":207724,"stargazers_count":3102,"watchers_count":3102,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":447,"mirror_url":null,"open_issues_count":182,"forks":447,"open_issues":182,"watchers":3102,"default_branch":"master"}},"base":{"label":"OnsenUI:master","ref":"master","sha":"6c4af27282c7f900c7455f6b89d16037098ca1d5","user":{"login":"OnsenUI","id":5972822,"avatar_url":"https://avatars.githubusercontent.com/u/5972822?v=3","gravatar_id":"","url":"https://api.github.com/users/OnsenUI","html_url":"https://github.com/OnsenUI","followers_url":"https://api.github.com/users/OnsenUI/followers","following_url":"https://api.github.com/users/OnsenUI/following{/other_user}","gists_url":"https://api.github.com/users/OnsenUI/gists{/gist_id}","starred_url":"https://api.github.com/users/OnsenUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OnsenUI/subscriptions","organizations_url":"https://api.github.com/users/OnsenUI/orgs","repos_url":"https://api.github.com/users/OnsenUI/repos","events_url":"https://api.github.com/users/OnsenUI/events{/privacy}","received_events_url":"https://api.github.com/users/OnsenUI/received_events","type":"Organization","site_admin":false},"repo":{"id":12755139,"name":"OnsenUI","full_name":"OnsenUI/OnsenUI","owner":{"login":"OnsenUI","id":5972822,"avatar_url":"https://avatars.githubusercontent.com/u/5972822?v=3","gravatar_id":"","url":"https://api.github.com/users/OnsenUI","html_url":"https://github.com/OnsenUI","followers_url":"https://api.github.com/users/OnsenUI/followers","following_url":"https://api.github.com/users/OnsenUI/following{/other_user}","gists_url":"https://api.github.com/users/OnsenUI/gists{/gist_id}","starred_url":"https://api.github.com/users/OnsenUI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OnsenUI/subscriptions","organizations_url":"https://api.github.com/users/OnsenUI/orgs","repos_url":"https://api.github.com/users/OnsenUI/repos","events_url":"https://api.github.com/users/OnsenUI/events{/privacy}","received_events_url":"https://api.github.com/users/OnsenUI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OnsenUI/OnsenUI","description":"Hybrid Mobile App UI Framework for iOS and Material Design with Angular and React Components","fork":false,"url":"https://api.github.com/repos/OnsenUI/OnsenUI","forks_url":"https://api.github.com/repos/OnsenUI/OnsenUI/forks","keys_url":"https://api.github.com/repos/OnsenUI/OnsenUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OnsenUI/OnsenUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OnsenUI/OnsenUI/teams","hooks_url":"https://api.github.com/repos/OnsenUI/OnsenUI/hooks","issue_events_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/events{/number}","events_url":"https://api.github.com/repos/OnsenUI/OnsenUI/events","assignees_url":"https://api.github.com/repos/OnsenUI/OnsenUI/assignees{/user}","branches_url":"https://api.github.com/repos/OnsenUI/OnsenUI/branches{/branch}","tags_url":"https://api.github.com/repos/OnsenUI/OnsenUI/tags","blobs_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OnsenUI/OnsenUI/statuses/{sha}","languages_url":"https://api.github.com/repos/OnsenUI/OnsenUI/languages","stargazers_url":"https://api.github.com/repos/OnsenUI/OnsenUI/stargazers","contributors_url":"https://api.github.com/repos/OnsenUI/OnsenUI/contributors","subscribers_url":"https://api.github.com/repos/OnsenUI/OnsenUI/subscribers","subscription_url":"https://api.github.com/repos/OnsenUI/OnsenUI/subscription","commits_url":"https://api.github.com/repos/OnsenUI/OnsenUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/OnsenUI/OnsenUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/OnsenUI/OnsenUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/OnsenUI/OnsenUI/contents/{+path}","compare_url":"https://api.github.com/repos/OnsenUI/OnsenUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OnsenUI/OnsenUI/merges","archive_url":"https://api.github.com/repos/OnsenUI/OnsenUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OnsenUI/OnsenUI/downloads","issues_url":"https://api.github.com/repos/OnsenUI/OnsenUI/issues{/number}","pulls_url":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls{/number}","milestones_url":"https://api.github.com/repos/OnsenUI/OnsenUI/milestones{/number}","notifications_url":"https://api.github.com/repos/OnsenUI/OnsenUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OnsenUI/OnsenUI/labels{/name}","releases_url":"https://api.github.com/repos/OnsenUI/OnsenUI/releases{/id}","deployments_url":"https://api.github.com/repos/OnsenUI/OnsenUI/deployments","created_at":"2013-09-11T11:52:41Z","updated_at":"2016-07-20T08:28:24Z","pushed_at":"2016-07-20T10:50:58Z","git_url":"git://github.com/OnsenUI/OnsenUI.git","ssh_url":"git@github.com:OnsenUI/OnsenUI.git","clone_url":"https://github.com/OnsenUI/OnsenUI.git","svn_url":"https://github.com/OnsenUI/OnsenUI","homepage":"https://onsen.io/","size":207724,"stargazers_count":3102,"watchers_count":3102,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":447,"mirror_url":null,"open_issues_count":182,"forks":447,"open_issues":182,"watchers":3102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516"},"html":{"href":"https://github.com/OnsenUI/OnsenUI/pull/1516"},"issue":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/1516"},"comments":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/issues/1516/comments"},"review_comments":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516/comments"},"review_comment":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/pulls/1516/commits"},"statuses":{"href":"https://api.github.com/repos/OnsenUI/OnsenUI/statuses/27e72047696569a96c20a0504b911796b85cd3ab"}}}}
{"actor":{"display_login":"argelius"}}