{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/81019514","pull_request_review_id":2031366,"id":81019514,"diff_hunk":"@@ -240,6 +242,9 @@ if(CLR_CMAKE_PLATFORM_XPLAT)\n         # -Wno-return-type # switch unreachable code\n         # -Wno-switch # switch values not handled\n \n+    add_compile_options(-fexceptions)\n+    add_compile_options(-fstack-protector-all)","path":"CMakeLists.txt","position":14,"original_position":14,"commit_id":"e49fbdd649ae0aad2d28e90d0a018a950d02238a","original_commit_id":"e49fbdd649ae0aad2d28e90d0a018a950d02238a","user":{"login":"curtisman","id":12101885,"avatar_url":"https://avatars.githubusercontent.com/u/12101885?v=3","gravatar_id":"","url":"https://api.github.com/users/curtisman","html_url":"https://github.com/curtisman","followers_url":"https://api.github.com/users/curtisman/followers","following_url":"https://api.github.com/users/curtisman/following{/other_user}","gists_url":"https://api.github.com/users/curtisman/gists{/gist_id}","starred_url":"https://api.github.com/users/curtisman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curtisman/subscriptions","organizations_url":"https://api.github.com/users/curtisman/orgs","repos_url":"https://api.github.com/users/curtisman/repos","events_url":"https://api.github.com/users/curtisman/events{/privacy}","received_events_url":"https://api.github.com/users/curtisman/received_events","type":"User","site_admin":false},"body":"Do we really want all? or should -fstack-protector sufficient?\r\nWhat's the perf impact with -fstack-protector-all?","created_at":"2016-09-28T21:17:37Z","updated_at":"2016-09-28T21:22:20Z","html_url":"https://github.com/Microsoft/ChakraCore/pull/1652#discussion_r81019514","pull_request_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments/81019514"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1652#discussion_r81019514"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652","id":87045954,"html_url":"https://github.com/Microsoft/ChakraCore/pull/1652","diff_url":"https://github.com/Microsoft/ChakraCore/pull/1652.diff","patch_url":"https://github.com/Microsoft/ChakraCore/pull/1652.patch","issue_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1652","number":1652,"state":"open","locked":false,"title":"cross-platform: Improve compiler options","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"body":"- make PAL specific flags project wide (i.e. fstack-protector-all)\r\n- force Wc++11-narrowing (similar to VC++)\r\n- disable warning reporting from system headers -wsystem-headers [node-chakracore issue]\r\n- set -gdwarf-4 instead of gdwarf-3 as it is the currently supported version on GCC targets\r\n- set -gdwarf-4 only for debug builds","created_at":"2016-09-28T02:41:11Z","updated_at":"2016-09-28T21:22:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de98de968c9e7ebf73dc05cf1d6424e4ba793778","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1652/comments","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/e49fbdd649ae0aad2d28e90d0a018a950d02238a","head":{"label":"obastemur:cl_fix","ref":"cl_fix","sha":"e49fbdd649ae0aad2d28e90d0a018a950d02238a","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"repo":{"id":61668748,"name":"ChakraCore","full_name":"obastemur/ChakraCore","owner":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars.githubusercontent.com/u/4390745?v=3","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obastemur/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":true,"url":"https://api.github.com/repos/obastemur/ChakraCore","forks_url":"https://api.github.com/repos/obastemur/ChakraCore/forks","keys_url":"https://api.github.com/repos/obastemur/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obastemur/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obastemur/ChakraCore/teams","hooks_url":"https://api.github.com/repos/obastemur/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/obastemur/ChakraCore/events","assignees_url":"https://api.github.com/repos/obastemur/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/obastemur/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/obastemur/ChakraCore/tags","blobs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obastemur/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obastemur/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/obastemur/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obastemur/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/obastemur/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/obastemur/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/obastemur/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/obastemur/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/obastemur/ChakraCore/subscription","commits_url":"https://api.github.com/repos/obastemur/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/obastemur/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/obastemur/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/obastemur/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/obastemur/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/obastemur/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obastemur/ChakraCore/merges","archive_url":"https://api.github.com/repos/obastemur/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obastemur/ChakraCore/downloads","issues_url":"https://api.github.com/repos/obastemur/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/obastemur/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/obastemur/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/obastemur/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obastemur/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/obastemur/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/obastemur/ChakraCore/deployments","created_at":"2016-06-21T21:35:20Z","updated_at":"2016-06-21T21:35:44Z","pushed_at":"2016-09-28T15:51:28Z","git_url":"git://github.com/obastemur/ChakraCore.git","ssh_url":"git@github.com:obastemur/ChakraCore.git","clone_url":"https://github.com/obastemur/ChakraCore.git","svn_url":"https://github.com/obastemur/ChakraCore","homepage":null,"size":40944,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"75e8911a2968e731e265f1c57d420421ed409f56","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":49086513,"name":"ChakraCore","full_name":"Microsoft/ChakraCore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ChakraCore","description":"ChakraCore is the core part of the Chakra Javascript engine that powers Microsoft Edge","fork":false,"url":"https://api.github.com/repos/Microsoft/ChakraCore","forks_url":"https://api.github.com/repos/Microsoft/ChakraCore/forks","keys_url":"https://api.github.com/repos/Microsoft/ChakraCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ChakraCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ChakraCore/teams","hooks_url":"https://api.github.com/repos/Microsoft/ChakraCore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ChakraCore/events","assignees_url":"https://api.github.com/repos/Microsoft/ChakraCore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ChakraCore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/tags","blobs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ChakraCore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ChakraCore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ChakraCore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ChakraCore/subscription","commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ChakraCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ChakraCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ChakraCore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ChakraCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ChakraCore/merges","archive_url":"https://api.github.com/repos/Microsoft/ChakraCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ChakraCore/downloads","issues_url":"https://api.github.com/repos/Microsoft/ChakraCore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ChakraCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ChakraCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ChakraCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ChakraCore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ChakraCore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ChakraCore/deployments","created_at":"2016-01-05T19:05:31Z","updated_at":"2016-09-28T21:20:54Z","pushed_at":"2016-09-28T21:01:17Z","git_url":"git://github.com/Microsoft/ChakraCore.git","ssh_url":"git@github.com:Microsoft/ChakraCore.git","clone_url":"https://github.com/Microsoft/ChakraCore.git","svn_url":"https://github.com/Microsoft/ChakraCore","homepage":null,"size":51897,"stargazers_count":5671,"watchers_count":5671,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":633,"mirror_url":null,"open_issues_count":167,"forks":633,"open_issues":167,"watchers":5671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652"},"html":{"href":"https://github.com/Microsoft/ChakraCore/pull/1652"},"issue":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1652"},"comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/issues/1652/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/pulls/1652/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ChakraCore/statuses/e49fbdd649ae0aad2d28e90d0a018a950d02238a"}}}}
{"actor":{"display_login":"curtisman"}}