{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/87026149","pull_request_review_id":7641658,"id":87026149,"diff_hunk":"@@ -104,9 +103,8 @@ namespace PMacc\n                     {\n                         this->stream = static_cast<StreamTask*>(task)->getEventStream();\n                         this->setTaskType(ITask::TASK_CUDA);\n-                        this->cudaEvent=static_cast<StreamTask*>(task)->getCudaEvent();\n-                        this->hasCudaEvent=true;\n-\n+                        this->cudaEvent=static_cast<StreamTask*>(task)->getCudaEventHandle();","path":"src/libPMacc/include/eventSystem/tasks/TaskLogicalAnd.hpp","position":7,"original_position":19,"commit_id":"79486e8386c860ec1f7f921fbe542af3713e8786","original_commit_id":"79486e8386c860ec1f7f921fbe542af3713e8786","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"`=` spaces here + following line","created_at":"2016-11-08T16:25:37Z","updated_at":"2016-11-08T16:26:36Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1631#discussion_r87026149","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/87026149"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1631#discussion_r87026149"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631","id":92784136,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1631","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1631.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1631.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1631","number":1631,"state":"open","locked":false,"title":"dynamic EventPool for cuda events","user":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"body":"close #1189\r\n\r\n- remove `EventPool` from task manager\r\n- add `EventPool` as singleton to `Environment<>`\r\n- `StreamTask`\r\n  - rename `getCudaEvent()` to `getCudaEventHandle()`\r\n  - rename `setCudaEvent()` to `setCudaEventHandle()`\r\n- `TaskLogicalAnd`: rename attribute `hasCudaEvent` to `hasCudaEventHandle`\r\n- `EventStream`: `waitOn()` is using the new `CudaEventHandle`\r\n- full refactor `EventPool`: dynamic number of used cuda events\r\n- rename `CudaEvent` to `CudaEventHandle`\r\n- add `CudaEvent` (wrapper for a native cuda event)\r\n\r\nThe bug in #1189 is closed with a new feature of the event pool. The event pool now allocates as much cuda events as needed.","created_at":"2016-11-08T14:09:00Z","updated_at":"2016-11-08T16:26:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d2b692a1204005232e938ac3960cb077c06a023","assignee":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"assignees":[{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/milestones/0.2.0:%20Open%20Beta","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"0.2.0: Open Beta","description":"Tasks to complete until the release of our open beta (version 0.2.0)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":94,"closed_issues":1335,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2016-11-08T15:26:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1631/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/79486e8386c860ec1f7f921fbe542af3713e8786","head":{"label":"psychocoderHPC:topic-dynamicEventPool","ref":"topic-dynamicEventPool","sha":"79486e8386c860ec1f7f921fbe542af3713e8786","user":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"repo":{"id":12103789,"name":"picongpu","full_name":"psychocoderHPC/picongpu","owner":{"login":"psychocoderHPC","id":4037125,"avatar_url":"https://avatars.githubusercontent.com/u/4037125?v=3","gravatar_id":"","url":"https://api.github.com/users/psychocoderHPC","html_url":"https://github.com/psychocoderHPC","followers_url":"https://api.github.com/users/psychocoderHPC/followers","following_url":"https://api.github.com/users/psychocoderHPC/following{/other_user}","gists_url":"https://api.github.com/users/psychocoderHPC/gists{/gist_id}","starred_url":"https://api.github.com/users/psychocoderHPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychocoderHPC/subscriptions","organizations_url":"https://api.github.com/users/psychocoderHPC/orgs","repos_url":"https://api.github.com/users/psychocoderHPC/repos","events_url":"https://api.github.com/users/psychocoderHPC/events{/privacy}","received_events_url":"https://api.github.com/users/psychocoderHPC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psychocoderHPC/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/psychocoderHPC/picongpu","forks_url":"https://api.github.com/repos/psychocoderHPC/picongpu/forks","keys_url":"https://api.github.com/repos/psychocoderHPC/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychocoderHPC/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychocoderHPC/picongpu/teams","hooks_url":"https://api.github.com/repos/psychocoderHPC/picongpu/hooks","issue_events_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/psychocoderHPC/picongpu/events","assignees_url":"https://api.github.com/repos/psychocoderHPC/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/psychocoderHPC/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/psychocoderHPC/picongpu/tags","blobs_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychocoderHPC/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/psychocoderHPC/picongpu/languages","stargazers_url":"https://api.github.com/repos/psychocoderHPC/picongpu/stargazers","contributors_url":"https://api.github.com/repos/psychocoderHPC/picongpu/contributors","subscribers_url":"https://api.github.com/repos/psychocoderHPC/picongpu/subscribers","subscription_url":"https://api.github.com/repos/psychocoderHPC/picongpu/subscription","commits_url":"https://api.github.com/repos/psychocoderHPC/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychocoderHPC/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychocoderHPC/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/psychocoderHPC/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/psychocoderHPC/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychocoderHPC/picongpu/merges","archive_url":"https://api.github.com/repos/psychocoderHPC/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychocoderHPC/picongpu/downloads","issues_url":"https://api.github.com/repos/psychocoderHPC/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/psychocoderHPC/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/psychocoderHPC/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/psychocoderHPC/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychocoderHPC/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/psychocoderHPC/picongpu/releases{/id}","deployments_url":"https://api.github.com/repos/psychocoderHPC/picongpu/deployments","created_at":"2013-08-14T08:23:46Z","updated_at":"2015-10-14T10:57:17Z","pushed_at":"2016-11-08T13:11:37Z","git_url":"git://github.com/psychocoderHPC/picongpu.git","ssh_url":"git@github.com:psychocoderHPC/picongpu.git","clone_url":"https://github.com/psychocoderHPC/picongpu.git","svn_url":"https://github.com/psychocoderHPC/picongpu","homepage":"http://picongpu.hzdr.de","size":60992,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"dev"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"9eeb299cc14ccfa0b31b764a0d60f39bd9bd4dac","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","deployments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/deployments","created_at":"2013-07-30T12:28:20Z","updated_at":"2016-11-08T08:47:44Z","pushed_at":"2016-11-08T15:04:16Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":13363,"stargazers_count":189,"watchers_count":189,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":248,"forks":94,"open_issues":248,"watchers":189,"default_branch":"release-0.1.2"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/1631"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1631"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/1631/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/1631/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/79486e8386c860ec1f7f921fbe542af3713e8786"}}}}
{"actor":{"display_login":"ax3l"}}