{"action":"created","comment":{"url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/comments/62459067","id":62459067,"diff_hunk":"@@ -0,0 +1,45 @@\n+# -*- coding: utf-8 -*-\n+from __future__ import absolute_import\n+from __future__ import division\n+from __future__ import print_function\n+from __future__ import unicode_literals\n+\n+import json\n+from .. import exceptions\n+from .. import utilities\n+from . import base\n+\n+\n+# Module API\n+\n+class ArrayType(base.JTSType):\n+\n+    # Public\n+\n+    name = 'array'\n+    null_values = utilities.NULL_VALUES\n+    supported_constraints = [\n+        'required',\n+        'pattern',\n+        'enum',\n+        'minLength',\n+        'maxLength',\n+    ]\n+    # ---\n+    python_type = list","path":"jsontableschema/types/array.py","position":29,"original_position":29,"commit_id":"36c9b5ed46faed8ff1ed5c5b795ff2d064d97b44","original_commit_id":"36c9b5ed46faed8ff1ed5c5b795ff2d064d97b44","user":{"login":"pwalsh","id":791678,"avatar_url":"https://avatars.githubusercontent.com/u/791678?v=3","gravatar_id":"","url":"https://api.github.com/users/pwalsh","html_url":"https://github.com/pwalsh","followers_url":"https://api.github.com/users/pwalsh/followers","following_url":"https://api.github.com/users/pwalsh/following{/other_user}","gists_url":"https://api.github.com/users/pwalsh/gists{/gist_id}","starred_url":"https://api.github.com/users/pwalsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwalsh/subscriptions","organizations_url":"https://api.github.com/users/pwalsh/orgs","repos_url":"https://api.github.com/users/pwalsh/repos","events_url":"https://api.github.com/users/pwalsh/events{/privacy}","received_events_url":"https://api.github.com/users/pwalsh/received_events","type":"User","site_admin":false},"body":"Is this change to `python_type` definitely backwards compatible?","created_at":"2016-05-09T07:38:53Z","updated_at":"2016-05-09T07:38:53Z","html_url":"https://github.com/frictionlessdata/jsontableschema-py/pull/61#discussion_r62459067","pull_request_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/comments/62459067"},"html":{"href":"https://github.com/frictionlessdata/jsontableschema-py/pull/61#discussion_r62459067"},"pull_request":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61","id":69277114,"html_url":"https://github.com/frictionlessdata/jsontableschema-py/pull/61","diff_url":"https://github.com/frictionlessdata/jsontableschema-py/pull/61.diff","patch_url":"https://github.com/frictionlessdata/jsontableschema-py/pull/61.patch","issue_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/61","number":61,"state":"open","locked":false,"title":"Feature/types improvement","user":{"login":"roll","id":557395,"avatar_url":"https://avatars.githubusercontent.com/u/557395?v=3","gravatar_id":"","url":"https://api.github.com/users/roll","html_url":"https://github.com/roll","followers_url":"https://api.github.com/users/roll/followers","following_url":"https://api.github.com/users/roll/following{/other_user}","gists_url":"https://api.github.com/users/roll/gists{/gist_id}","starred_url":"https://api.github.com/users/roll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roll/subscriptions","organizations_url":"https://api.github.com/users/roll/orgs","repos_url":"https://api.github.com/users/roll/repos","events_url":"https://api.github.com/users/roll/events{/privacy}","received_events_url":"https://api.github.com/users/roll/received_events","type":"User","site_admin":false},"body":"This PR addresses these issues:\r\n- #59\r\n- #57  \r\n- #50 \r\n\r\nTo achieve the goal some work on code simplification and decoupling have been done: \r\n- types code moved to file by type approach\r\n- constraints simplified and moved to file by constraint approach\r\n- part of JSTType logic was re-written to simplify understanding of type system data flow\r\n\r\nAlso types business logic and tests' style/naming/file length/not pytest are not in a great shape somewhere but for this chunk of changes don't sleep on any regression was more important. So this parts have not been changed as much as possible.\r\n\r\nI suppose the codebase in some places should be improved further in the next iterations.\r\n\r\nPS.\r\nAll `testsuite-py` tests pass with this version of `jsontableschema`. ","created_at":"2016-05-08T19:31:14Z","updated_at":"2016-05-09T07:38:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"833e7e159164ba259c540954b89433e0db960e93","assignee":{"login":"pwalsh","id":791678,"avatar_url":"https://avatars.githubusercontent.com/u/791678?v=3","gravatar_id":"","url":"https://api.github.com/users/pwalsh","html_url":"https://github.com/pwalsh","followers_url":"https://api.github.com/users/pwalsh/followers","following_url":"https://api.github.com/users/pwalsh/following{/other_user}","gists_url":"https://api.github.com/users/pwalsh/gists{/gist_id}","starred_url":"https://api.github.com/users/pwalsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwalsh/subscriptions","organizations_url":"https://api.github.com/users/pwalsh/orgs","repos_url":"https://api.github.com/users/pwalsh/repos","events_url":"https://api.github.com/users/pwalsh/events{/privacy}","received_events_url":"https://api.github.com/users/pwalsh/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/milestones/9","html_url":"https://github.com/frictionlessdata/jsontableschema-py/milestones/0.6.1","labels_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/milestones/9/labels","id":1678226,"number":9,"title":"0.6.1","description":"","creator":{"login":"roll","id":557395,"avatar_url":"https://avatars.githubusercontent.com/u/557395?v=3","gravatar_id":"","url":"https://api.github.com/users/roll","html_url":"https://github.com/roll","followers_url":"https://api.github.com/users/roll/followers","following_url":"https://api.github.com/users/roll/following{/other_user}","gists_url":"https://api.github.com/users/roll/gists{/gist_id}","starred_url":"https://api.github.com/users/roll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roll/subscriptions","organizations_url":"https://api.github.com/users/roll/orgs","repos_url":"https://api.github.com/users/roll/repos","events_url":"https://api.github.com/users/roll/events{/privacy}","received_events_url":"https://api.github.com/users/roll/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2016-04-01T15:11:32Z","updated_at":"2016-05-08T19:31:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61/commits","review_comments_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61/comments","review_comment_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/61/comments","statuses_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/statuses/36c9b5ed46faed8ff1ed5c5b795ff2d064d97b44","head":{"label":"frictionlessdata:feature/types-improvement","ref":"feature/types-improvement","sha":"36c9b5ed46faed8ff1ed5c5b795ff2d064d97b44","user":{"login":"frictionlessdata","id":5912125,"avatar_url":"https://avatars.githubusercontent.com/u/5912125?v=3","gravatar_id":"","url":"https://api.github.com/users/frictionlessdata","html_url":"https://github.com/frictionlessdata","followers_url":"https://api.github.com/users/frictionlessdata/followers","following_url":"https://api.github.com/users/frictionlessdata/following{/other_user}","gists_url":"https://api.github.com/users/frictionlessdata/gists{/gist_id}","starred_url":"https://api.github.com/users/frictionlessdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frictionlessdata/subscriptions","organizations_url":"https://api.github.com/users/frictionlessdata/orgs","repos_url":"https://api.github.com/users/frictionlessdata/repos","events_url":"https://api.github.com/users/frictionlessdata/events{/privacy}","received_events_url":"https://api.github.com/users/frictionlessdata/received_events","type":"Organization","site_admin":false},"repo":{"id":30863890,"name":"jsontableschema-py","full_name":"frictionlessdata/jsontableschema-py","owner":{"login":"frictionlessdata","id":5912125,"avatar_url":"https://avatars.githubusercontent.com/u/5912125?v=3","gravatar_id":"","url":"https://api.github.com/users/frictionlessdata","html_url":"https://github.com/frictionlessdata","followers_url":"https://api.github.com/users/frictionlessdata/followers","following_url":"https://api.github.com/users/frictionlessdata/following{/other_user}","gists_url":"https://api.github.com/users/frictionlessdata/gists{/gist_id}","starred_url":"https://api.github.com/users/frictionlessdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frictionlessdata/subscriptions","organizations_url":"https://api.github.com/users/frictionlessdata/orgs","repos_url":"https://api.github.com/users/frictionlessdata/repos","events_url":"https://api.github.com/users/frictionlessdata/events{/privacy}","received_events_url":"https://api.github.com/users/frictionlessdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frictionlessdata/jsontableschema-py","description":"A Python library for working with JSON Table Schema.","fork":false,"url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py","forks_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/forks","keys_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/teams","hooks_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/hooks","issue_events_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/events{/number}","events_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/events","assignees_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/assignees{/user}","branches_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/branches{/branch}","tags_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/tags","blobs_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/statuses/{sha}","languages_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/languages","stargazers_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/stargazers","contributors_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/contributors","subscribers_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/subscribers","subscription_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/subscription","commits_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/contents/{+path}","compare_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/merges","archive_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/downloads","issues_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues{/number}","pulls_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls{/number}","milestones_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/milestones{/number}","notifications_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/labels{/name}","releases_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/releases{/id}","deployments_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/deployments","created_at":"2015-02-16T10:44:10Z","updated_at":"2016-05-06T19:12:22Z","pushed_at":"2016-05-08T19:31:14Z","git_url":"git://github.com/frictionlessdata/jsontableschema-py.git","ssh_url":"git@github.com:frictionlessdata/jsontableschema-py.git","clone_url":"https://github.com/frictionlessdata/jsontableschema-py.git","svn_url":"https://github.com/frictionlessdata/jsontableschema-py","homepage":"","size":206,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":9,"default_branch":"master"}},"base":{"label":"frictionlessdata:master","ref":"master","sha":"f686b04e89f9d462c8b39a8e35ea47ec21af8b41","user":{"login":"frictionlessdata","id":5912125,"avatar_url":"https://avatars.githubusercontent.com/u/5912125?v=3","gravatar_id":"","url":"https://api.github.com/users/frictionlessdata","html_url":"https://github.com/frictionlessdata","followers_url":"https://api.github.com/users/frictionlessdata/followers","following_url":"https://api.github.com/users/frictionlessdata/following{/other_user}","gists_url":"https://api.github.com/users/frictionlessdata/gists{/gist_id}","starred_url":"https://api.github.com/users/frictionlessdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frictionlessdata/subscriptions","organizations_url":"https://api.github.com/users/frictionlessdata/orgs","repos_url":"https://api.github.com/users/frictionlessdata/repos","events_url":"https://api.github.com/users/frictionlessdata/events{/privacy}","received_events_url":"https://api.github.com/users/frictionlessdata/received_events","type":"Organization","site_admin":false},"repo":{"id":30863890,"name":"jsontableschema-py","full_name":"frictionlessdata/jsontableschema-py","owner":{"login":"frictionlessdata","id":5912125,"avatar_url":"https://avatars.githubusercontent.com/u/5912125?v=3","gravatar_id":"","url":"https://api.github.com/users/frictionlessdata","html_url":"https://github.com/frictionlessdata","followers_url":"https://api.github.com/users/frictionlessdata/followers","following_url":"https://api.github.com/users/frictionlessdata/following{/other_user}","gists_url":"https://api.github.com/users/frictionlessdata/gists{/gist_id}","starred_url":"https://api.github.com/users/frictionlessdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frictionlessdata/subscriptions","organizations_url":"https://api.github.com/users/frictionlessdata/orgs","repos_url":"https://api.github.com/users/frictionlessdata/repos","events_url":"https://api.github.com/users/frictionlessdata/events{/privacy}","received_events_url":"https://api.github.com/users/frictionlessdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frictionlessdata/jsontableschema-py","description":"A Python library for working with JSON Table Schema.","fork":false,"url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py","forks_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/forks","keys_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/teams","hooks_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/hooks","issue_events_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/events{/number}","events_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/events","assignees_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/assignees{/user}","branches_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/branches{/branch}","tags_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/tags","blobs_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/statuses/{sha}","languages_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/languages","stargazers_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/stargazers","contributors_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/contributors","subscribers_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/subscribers","subscription_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/subscription","commits_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/contents/{+path}","compare_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/merges","archive_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/downloads","issues_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues{/number}","pulls_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls{/number}","milestones_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/milestones{/number}","notifications_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/labels{/name}","releases_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/releases{/id}","deployments_url":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/deployments","created_at":"2015-02-16T10:44:10Z","updated_at":"2016-05-06T19:12:22Z","pushed_at":"2016-05-08T19:31:14Z","git_url":"git://github.com/frictionlessdata/jsontableschema-py.git","ssh_url":"git@github.com:frictionlessdata/jsontableschema-py.git","clone_url":"https://github.com/frictionlessdata/jsontableschema-py.git","svn_url":"https://github.com/frictionlessdata/jsontableschema-py","homepage":"","size":206,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61"},"html":{"href":"https://github.com/frictionlessdata/jsontableschema-py/pull/61"},"issue":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/61"},"comments":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/frictionlessdata/jsontableschema-py/statuses/36c9b5ed46faed8ff1ed5c5b795ff2d064d97b44"}}}}