{"action":"created","issue":{"url":"https://api.github.com/repos/astruyk/Ares/issues/216","repository_url":"https://api.github.com/repos/astruyk/Ares","labels_url":"https://api.github.com/repos/astruyk/Ares/issues/216/labels{/name}","comments_url":"https://api.github.com/repos/astruyk/Ares/issues/216/comments","events_url":"https://api.github.com/repos/astruyk/Ares/issues/216/events","html_url":"https://github.com/astruyk/Ares/pull/216","id":151839675,"number":216,"title":"Added modules for transfering groups to the server","user":{"login":"sthorshaug","id":2493540,"avatar_url":"https://avatars.githubusercontent.com/u/2493540?v=3","gravatar_id":"","url":"https://api.github.com/users/sthorshaug","html_url":"https://github.com/sthorshaug","followers_url":"https://api.github.com/users/sthorshaug/followers","following_url":"https://api.github.com/users/sthorshaug/following{/other_user}","gists_url":"https://api.github.com/users/sthorshaug/gists{/gist_id}","starred_url":"https://api.github.com/users/sthorshaug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sthorshaug/subscriptions","organizations_url":"https://api.github.com/users/sthorshaug/orgs","repos_url":"https://api.github.com/users/sthorshaug/repos","events_url":"https://api.github.com/users/sthorshaug/events{/privacy}","received_events_url":"https://api.github.com/users/sthorshaug/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-29T10:47:06Z","updated_at":"2016-04-29T18:46:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astruyk/Ares/pulls/216","html_url":"https://github.com/astruyk/Ares/pull/216","diff_url":"https://github.com/astruyk/Ares/pull/216.diff","patch_url":"https://github.com/astruyk/Ares/pull/216.patch"},"body":"One module transfers a single group.\r\nThe other module transfers all groups.\r\nRelates to issue #159 "},"comment":{"url":"https://api.github.com/repos/astruyk/Ares/issues/comments/215845475","html_url":"https://github.com/astruyk/Ares/pull/216#issuecomment-215845475","issue_url":"https://api.github.com/repos/astruyk/Ares/issues/216","id":215845475,"user":{"login":"astruyk","id":5864922,"avatar_url":"https://avatars.githubusercontent.com/u/5864922?v=3","gravatar_id":"","url":"https://api.github.com/users/astruyk","html_url":"https://github.com/astruyk","followers_url":"https://api.github.com/users/astruyk/followers","following_url":"https://api.github.com/users/astruyk/following{/other_user}","gists_url":"https://api.github.com/users/astruyk/gists{/gist_id}","starred_url":"https://api.github.com/users/astruyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astruyk/subscriptions","organizations_url":"https://api.github.com/users/astruyk/orgs","repos_url":"https://api.github.com/users/astruyk/repos","events_url":"https://api.github.com/users/astruyk/events{/privacy}","received_events_url":"https://api.github.com/users/astruyk/received_events","type":"User","site_admin":false},"created_at":"2016-04-29T18:46:00Z","updated_at":"2016-04-29T18:46:00Z","body":"Looks pretty awesome. The only thing I would suggest is maybe using a single module and deciding which units to attempt to move to the server based on where the module was dropped. So, for example if the user drops the module in empty space assume they want all units moved but if they drop it on a unit assume they want that units group moved.\r\n\r\nThis keeps the number of modules lower (so less things to sort through each time you want to find a module you're interested in). \r\n\r\nAlso a couple of small code-style comments:\r\n\r\nBy convention the names for functions and global variables have capitals after the underscore (so `Ares_ChangeOwnerToServerFunction` or `Ares_ChangeOwnerToServerCodeBlock` instead of `Ares_changeOwnerToServerFunction`.\r\n\r\nAll the other code uses spaces between 'if' and opening parenthesis. For example,`if (...)` instead of  `if(...)`\r\n\r\nLastly all the '{''s belong on their own lines (except in the case of foreach):\r\n\r\n    if (...)\r\n    {\r\n    <tab>// ...\r\n    }\r\n\r\nis preferred over\r\n\r\n    if (...) {\r\n    <tab>// ...\r\n    }\r\n\r\nhttps://github.com/astruyk/Ares/blob/master/src/addons/ares_zeusExtensions/scripts/Equipment_RemoveWeaponOptics.sqf has some examples of the various code blocks indentation."}}