{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/77920294","id":77920294,"diff_hunk":"@@ -98,6 +121,80 @@ export function installVideo(win) {\n     isVideoSupported_() {\n       return !!this.video_.play;\n     }\n+\n+    /**\n+     * VideoInterface Implementation\n+     * {@see ../src/video-interface.VideoInterface}\n+     */\n+\n+    /**\n+     * @return {boolean}\n+     */\n+    supportsPlatform() {\n+      return this.isVideoSupported_();\n+    }\n+\n+    /**\n+     * @return {boolean}\n+     */\n+    hasAutoplay() {\n+      return this.element.hasAttribute('autoplay');","path":"builtins/amp-video.js","position":null,"original_position":85,"commit_id":"cfb4f2919429231f9fddf2b9a025381b0ff9e503","original_commit_id":"5e55b6681c220ac6c11372aa688dc175547184a0","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars.githubusercontent.com/u/2099009?v=3","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"yep, now `autoplay` and `controls` are expected attributed and no longer part of the JS interface (but documented same way the events are in the `video-interface.js`)","created_at":"2016-09-07T23:03:05Z","updated_at":"2016-09-07T23:03:05Z","html_url":"https://github.com/ampproject/amphtml/pull/4786#discussion_r77920294","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4786","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/77920294"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4786#discussion_r77920294"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4786"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4786","id":83374325,"html_url":"https://github.com/ampproject/amphtml/pull/4786","diff_url":"https://github.com/ampproject/amphtml/pull/4786.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4786.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4786","number":4786,"state":"open","locked":false,"title":"WIP - Video: common video API skeleton and muted autoplay for <amp-video>","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars.githubusercontent.com/u/2099009?v=3","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"Partial for: https://github.com/ampproject/amphtml/issues/4154 and https://github.com/ampproject/amphtml/issues/4113\r\n\r\nFirst PR for the common video API which also brings muted autoplay to `<amp-video>` in supported platforms.\r\n\r\nDemo: http://goo.gl/SiocMT  - Visit in desktop or Chrome Dev (53) in Android\r\n\r\nPlease note:\r\n- I am writing tests, but wanted to get the review started. \r\n- UX may change, I meeting with UX folks to make/validate some decisions around autoplay behaviour\r\n- I do not believe this needs an experiment flag. Only affects `<amp-video>` with autoplay attribute which would not have worked in most platforms anyway.\r\n","created_at":"2016-08-31T01:22:28Z","updated_at":"2016-09-07T23:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c29fb7bb32f0d080edabaf081aa4738d9f0ff43","assignee":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"assignees":[{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4786/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4786/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4786/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/cfb4f2919429231f9fddf2b9a025381b0ff9e503","head":{"label":"aghassemi:video-1","ref":"video-1","sha":"cfb4f2919429231f9fddf2b9a025381b0ff9e503","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars.githubusercontent.com/u/2099009?v=3","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"repo":{"id":62757350,"name":"amphtml","full_name":"aghassemi/amphtml","owner":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars.githubusercontent.com/u/2099009?v=3","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aghassemi/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/aghassemi/amphtml","forks_url":"https://api.github.com/repos/aghassemi/amphtml/forks","keys_url":"https://api.github.com/repos/aghassemi/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aghassemi/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aghassemi/amphtml/teams","hooks_url":"https://api.github.com/repos/aghassemi/amphtml/hooks","issue_events_url":"https://api.github.com/repos/aghassemi/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/aghassemi/amphtml/events","assignees_url":"https://api.github.com/repos/aghassemi/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/aghassemi/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/aghassemi/amphtml/tags","blobs_url":"https://api.github.com/repos/aghassemi/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aghassemi/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aghassemi/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/aghassemi/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aghassemi/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/aghassemi/amphtml/languages","stargazers_url":"https://api.github.com/repos/aghassemi/amphtml/stargazers","contributors_url":"https://api.github.com/repos/aghassemi/amphtml/contributors","subscribers_url":"https://api.github.com/repos/aghassemi/amphtml/subscribers","subscription_url":"https://api.github.com/repos/aghassemi/amphtml/subscription","commits_url":"https://api.github.com/repos/aghassemi/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/aghassemi/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/aghassemi/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/aghassemi/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/aghassemi/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/aghassemi/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aghassemi/amphtml/merges","archive_url":"https://api.github.com/repos/aghassemi/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aghassemi/amphtml/downloads","issues_url":"https://api.github.com/repos/aghassemi/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/aghassemi/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/aghassemi/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/aghassemi/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aghassemi/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/aghassemi/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/aghassemi/amphtml/deployments","created_at":"2016-07-06T22:26:50Z","updated_at":"2016-07-06T22:26:54Z","pushed_at":"2016-09-07T22:54:27Z","git_url":"git://github.com/aghassemi/amphtml.git","ssh_url":"git@github.com:aghassemi/amphtml.git","clone_url":"https://github.com/aghassemi/amphtml.git","svn_url":"https://github.com/aghassemi/amphtml","homepage":"https://ampproject.org","size":143805,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"f2054aa4100ccffafa3eb74f7e32ef49fc62883b","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-09-07T21:17:26Z","pushed_at":"2016-09-07T23:02:50Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":187700,"stargazers_count":8405,"watchers_count":8405,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1230,"mirror_url":null,"open_issues_count":705,"forks":1230,"open_issues":705,"watchers":8405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4786"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4786"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4786"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4786/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4786/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4786/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/cfb4f2919429231f9fddf2b9a025381b0ff9e503"}}}}
{"actor":{"display_login":"aghassemi"}}