{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/85452763","pull_request_review_id":6169116,"id":85452763,"diff_hunk":"@@ -0,0 +1,194 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!--\n+    Licensed to the Apache Software Foundation (ASF) under one or more\n+    contributor license agreements.  See the NOTICE file distributed with\n+    this work for additional information regarding copyright ownership.\n+    The ASF licenses this file to You under the Apache License, Version 2.0\n+    (the \"License\"); you may not use this file except in compliance with\n+    the License.  You may obtain a copy of the License at\n+\n+       http://www.apache.org/licenses/LICENSE-2.0\n+\n+    Unless required by applicable law or agreed to in writing, software\n+    distributed under the License is distributed on an \"AS IS\" BASIS,\n+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+    See the License for the specific language governing permissions and\n+    limitations under the License.\n+-->\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+\n+  <modelVersion>4.0.0</modelVersion>\n+\n+  <parent>\n+    <groupId>org.apache.beam</groupId>\n+    <artifactId>beam-sdks-java-extensions-parent</artifactId>\n+    <version>0.4.0-incubating-SNAPSHOT</version>\n+    <relativePath>../pom.xml</relativePath>\n+  </parent>\n+\n+  <artifactId>beam-sdks-java-extensions-sorter</artifactId>\n+  <name>Apache Beam :: SDKs :: Java :: Extensions :: Sorter</name>\n+\n+  <build>\n+    <plugins>\n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-compiler-plugin</artifactId>\n+      </plugin>\n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-surefire-plugin</artifactId>\n+        <configuration>\n+          <systemPropertyVariables>\n+            <beamUseDummyRunner>false</beamUseDummyRunner>\n+          </systemPropertyVariables>\n+        </configuration>\n+      </plugin>\n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-checkstyle-plugin</artifactId>\n+      </plugin>\n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-source-plugin</artifactId>\n+      </plugin>\n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-jar-plugin</artifactId>\n+      </plugin>\n+\n+      <plugin>\n+        <groupId>org.apache.maven.plugins</groupId>\n+        <artifactId>maven-shade-plugin</artifactId>\n+        <version>2.4.1</version>\n+        <executions>\n+          <!-- In the first phase, we pick dependencies and relocate them. -->\n+          <execution>\n+            <id>bundle-and-repackage</id>\n+            <phase>package</phase>\n+            <goals>\n+              <goal>shade</goal>\n+            </goals>\n+            <configuration>\n+              <shadeTestJar>true</shadeTestJar>\n+              <artifactSet>\n+                <includes>\n+                  <include>org.apache.hadoop:hadoop-client</include>\n+                </includes>\n+              </artifactSet>\n+              <filters>\n+                <filter>\n+                  <artifact>*:*</artifact>\n+                  <excludes>\n+                    <exclude>META-INF/*.SF</exclude>\n+                    <exclude>META-INF/*.DSA</exclude>\n+                    <exclude>META-INF/*.RSA</exclude>\n+                  </excludes>\n+                </filter>\n+              </filters>\n+              <relocations>\n+                <relocation>\n+                  <pattern>org.apache.hadoop</pattern>\n+                  <shadedPattern>org.apache.beam.repackaged.org.apache.hadoop</shadedPattern>\n+                </relocation>\n+              </relocations>\n+            </configuration>\n+          </execution>\n+\n+          <!-- In the second phase, we pick remaining dependencies and bundle\n+               them without repackaging. -->\n+          <execution>\n+            <id>bundle-rest-without-repackaging</id>\n+            <phase>package</phase>\n+            <goals>\n+              <goal>shade</goal>\n+            </goals>\n+            <configuration>\n+              <shadeTestJar>true</shadeTestJar>\n+              <finalName>${project.artifactId}-bundled-${project.version}</finalName>\n+              <artifactSet>\n+                <excludes>\n+                  <exclude>org.apache.hadoop:hadoop-client</exclude>\n+                </excludes>\n+              </artifactSet>\n+              <filters>\n+                <filter>\n+                  <artifact>*:*</artifact>\n+                  <excludes>\n+                    <exclude>META-INF/*.SF</exclude>\n+                    <exclude>META-INF/*.DSA</exclude>\n+                    <exclude>META-INF/*.RSA</exclude>\n+                  </excludes>\n+                </filter>\n+              </filters>\n+            </configuration>\n+          </execution>\n+        </executions>\n+      </plugin>\n+\n+\n+    </plugins>\n+  </build>\n+\n+  <dependencies>\n+    <dependency>\n+      <groupId>org.apache.beam</groupId>\n+      <artifactId>beam-sdks-java-core</artifactId>\n+    </dependency>\n+\n+    <dependency>\n+      <groupId>org.apache.hadoop</groupId>\n+      <artifactId>hadoop-client</artifactId>\n+      <version>2.7.1</version>\n+      <scope>provided</scope>\n+    </dependency>\n+    \n+    <dependency>\n+      <groupId>org.apache.hadoop</groupId>\n+      <artifactId>hadoop-mapreduce-client-core</artifactId>\n+      <version>2.7.1</version>\n+      <scope>provided</scope>\n+    </dependency>\n+    \n+    <dependency>\n+      <groupId>org.apache.hadoop</groupId>\n+      <artifactId>hadoop-common</artifactId>\n+      <version>2.7.1</version>\n+      <scope>provided</scope>\n+    </dependency>\n+    \n+    <dependency>\n+      <groupId>com.google.guava</groupId>\n+      <artifactId>guava</artifactId>\n+      <version>19.0</version>","path":"sdks/java/extensions/sorter/pom.xml","position":163,"original_position":163,"commit_id":"0addd4c7138211cdfb9056101c8e13325ad3de58","original_commit_id":"0addd4c7138211cdfb9056101c8e13325ad3de58","user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars.githubusercontent.com/u/526415?v=3","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"body":"drop 19.0 line. This should be automatically picked up from the root pom.xml file's dependency management.","created_at":"2016-10-28T00:07:46Z","updated_at":"2016-10-28T00:07:46Z","html_url":"https://github.com/apache/incubator-beam/pull/1199#discussion_r85452763","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1199","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/85452763"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1199#discussion_r85452763"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1199"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1199","id":91104360,"html_url":"https://github.com/apache/incubator-beam/pull/1199","diff_url":"https://github.com/apache/incubator-beam/pull/1199.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1199.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1199","number":1199,"state":"open","locked":false,"title":"[BEAM-840] Add Java SDK extension to support non-distributed sorting","user":{"login":"mizitch","id":16655282,"avatar_url":"https://avatars.githubusercontent.com/u/16655282?v=3","gravatar_id":"","url":"https://api.github.com/users/mizitch","html_url":"https://github.com/mizitch","followers_url":"https://api.github.com/users/mizitch/followers","following_url":"https://api.github.com/users/mizitch/following{/other_user}","gists_url":"https://api.github.com/users/mizitch/gists{/gist_id}","starred_url":"https://api.github.com/users/mizitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizitch/subscriptions","organizations_url":"https://api.github.com/users/mizitch/orgs","repos_url":"https://api.github.com/users/mizitch/repos","events_url":"https://api.github.com/users/mizitch/events{/privacy}","received_events_url":"https://api.github.com/users/mizitch/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [x] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). (covered by Google's existing agreement with Apache)\r\n\r\n---\r\n\r\nAdd an extension that provides a PTransform which performs local(non-distributed) sorting. It will sort in memory until the buffer is full, then flush to disk and use external sorting.\r\n\r\nConsumes a PCollection of KVs from primary key to iterable of secondary key and value KVs and sorts the iterables. Would probably be called after a GroupByKey. Uses coders to convert secondary keys and values into byte arrays and does a lexicographical comparison on the secondary keys.\r\n\r\nUses Hadoop as an external sorting library.\r\n\r\nHi @dhalperi can you please take a look?\r\n\r\nhttps://issues.apache.org/jira/browse/BEAM-840","created_at":"2016-10-26T22:54:03Z","updated_at":"2016-10-28T00:27:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81faa011672693344c9b8ffed61e3574ae4ee632","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1199/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1199/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1199/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/0addd4c7138211cdfb9056101c8e13325ad3de58","head":{"label":"mizitch:sorter-extension","ref":"sorter-extension","sha":"0addd4c7138211cdfb9056101c8e13325ad3de58","user":{"login":"mizitch","id":16655282,"avatar_url":"https://avatars.githubusercontent.com/u/16655282?v=3","gravatar_id":"","url":"https://api.github.com/users/mizitch","html_url":"https://github.com/mizitch","followers_url":"https://api.github.com/users/mizitch/followers","following_url":"https://api.github.com/users/mizitch/following{/other_user}","gists_url":"https://api.github.com/users/mizitch/gists{/gist_id}","starred_url":"https://api.github.com/users/mizitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizitch/subscriptions","organizations_url":"https://api.github.com/users/mizitch/orgs","repos_url":"https://api.github.com/users/mizitch/repos","events_url":"https://api.github.com/users/mizitch/events{/privacy}","received_events_url":"https://api.github.com/users/mizitch/received_events","type":"User","site_admin":false},"repo":{"id":71498342,"name":"incubator-beam","full_name":"mizitch/incubator-beam","owner":{"login":"mizitch","id":16655282,"avatar_url":"https://avatars.githubusercontent.com/u/16655282?v=3","gravatar_id":"","url":"https://api.github.com/users/mizitch","html_url":"https://github.com/mizitch","followers_url":"https://api.github.com/users/mizitch/followers","following_url":"https://api.github.com/users/mizitch/following{/other_user}","gists_url":"https://api.github.com/users/mizitch/gists{/gist_id}","starred_url":"https://api.github.com/users/mizitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mizitch/subscriptions","organizations_url":"https://api.github.com/users/mizitch/orgs","repos_url":"https://api.github.com/users/mizitch/repos","events_url":"https://api.github.com/users/mizitch/events{/privacy}","received_events_url":"https://api.github.com/users/mizitch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mizitch/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/mizitch/incubator-beam","forks_url":"https://api.github.com/repos/mizitch/incubator-beam/forks","keys_url":"https://api.github.com/repos/mizitch/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mizitch/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mizitch/incubator-beam/teams","hooks_url":"https://api.github.com/repos/mizitch/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/mizitch/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/mizitch/incubator-beam/events","assignees_url":"https://api.github.com/repos/mizitch/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/mizitch/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/mizitch/incubator-beam/tags","blobs_url":"https://api.github.com/repos/mizitch/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mizitch/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mizitch/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/mizitch/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mizitch/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/mizitch/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/mizitch/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/mizitch/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/mizitch/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/mizitch/incubator-beam/subscription","commits_url":"https://api.github.com/repos/mizitch/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/mizitch/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/mizitch/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/mizitch/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/mizitch/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/mizitch/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mizitch/incubator-beam/merges","archive_url":"https://api.github.com/repos/mizitch/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mizitch/incubator-beam/downloads","issues_url":"https://api.github.com/repos/mizitch/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/mizitch/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/mizitch/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/mizitch/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mizitch/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/mizitch/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/mizitch/incubator-beam/deployments","created_at":"2016-10-20T19:44:47Z","updated_at":"2016-10-20T19:44:52Z","pushed_at":"2016-10-27T20:12:50Z","git_url":"git://github.com/mizitch/incubator-beam.git","ssh_url":"git@github.com:mizitch/incubator-beam.git","clone_url":"https://github.com/mizitch/incubator-beam.git","svn_url":"https://github.com/mizitch/incubator-beam","homepage":null,"size":22490,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"eba099f564dba3dfbba30ae3533496b9e14f57a7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-10-27T19:06:26Z","pushed_at":"2016-10-27T23:28:51Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":33212,"stargazers_count":405,"watchers_count":405,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":54,"forks":252,"open_issues":54,"watchers":405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1199"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1199"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1199"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1199/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1199/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1199/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/0addd4c7138211cdfb9056101c8e13325ad3de58"}}}}
{"actor":{"display_login":"dhalperi"}}