{"action":"created","issue":{"url":"https://api.github.com/repos/edx/ux-pattern-library/issues/324","repository_url":"https://api.github.com/repos/edx/ux-pattern-library","labels_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/324/labels{/name}","comments_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/324/comments","events_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/324/events","html_url":"https://github.com/edx/ux-pattern-library/pull/324","id":152663705,"number":324,"title":"Clean up the gulp tasks for documentation","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-02T22:50:40Z","updated_at":"2016-05-03T20:15:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/ux-pattern-library/pulls/324","html_url":"https://github.com/edx/ux-pattern-library/pull/324","diff_url":"https://github.com/edx/ux-pattern-library/pull/324.diff","patch_url":"https://github.com/edx/ux-pattern-library/pull/324.patch"},"body":"## Description\r\n\r\nhttps://openedx.atlassian.net/browse/FEDX-148\r\n\r\nThis change adopts a number of the lessons learned from creating the UI Toolkit documentation:\r\n - move all the Jekyll content beneath the pldoc directory\r\n - gitignore the public directories so that they don't get committed\r\n - introduce a new gulp doc-publish task to simplify updating GitHub Pages\r\n - changed preview so that it opens the S3 URL that it builds\r\n\r\nHere's an updated preview site just to verify that things are still working:\r\n\r\nhttp://ux-test.edx.org/andya/improve-github-pages-integration/ \r\n\r\n## Reviewers\r\n\r\n - [ ] @bjacobel \r\n - [ ] @AlasdairSwan \r\n"},"comment":{"url":"https://api.github.com/repos/edx/ux-pattern-library/issues/comments/216651418","html_url":"https://github.com/edx/ux-pattern-library/pull/324#issuecomment-216651418","issue_url":"https://api.github.com/repos/edx/ux-pattern-library/issues/324","id":216651418,"user":{"login":"bjacobel","id":407639,"avatar_url":"https://avatars.githubusercontent.com/u/407639?v=3","gravatar_id":"","url":"https://api.github.com/users/bjacobel","html_url":"https://github.com/bjacobel","followers_url":"https://api.github.com/users/bjacobel/followers","following_url":"https://api.github.com/users/bjacobel/following{/other_user}","gists_url":"https://api.github.com/users/bjacobel/gists{/gist_id}","starred_url":"https://api.github.com/users/bjacobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjacobel/subscriptions","organizations_url":"https://api.github.com/users/bjacobel/orgs","repos_url":"https://api.github.com/users/bjacobel/repos","events_url":"https://api.github.com/users/bjacobel/events{/privacy}","received_events_url":"https://api.github.com/users/bjacobel/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T20:15:09Z","updated_at":"2016-05-03T20:15:09Z","body":"Getting the following error running locally:\r\n\r\n```\r\n$ > node_modules/.bin/gulp\r\n[16:13:34] Using gulpfile ~/code/ux-pattern-library/gulpfile.js\r\n[16:13:34] Starting 'default'...\r\n[16:13:34] Starting 'build-development'...\r\n[16:13:34] Starting 'clean'...\r\n[16:13:34] Finished 'clean' after 7.84 ms\r\n[16:13:34] Starting 'fonts'...\r\n[16:13:34] Finished 'fonts' after 124 ms\r\n[16:13:34] Starting 'images'...\r\n[16:13:34] 'images' errored after 1.53 ms\r\n[16:13:34] Error: Invalid output folder\r\n    at Gulp.dest (/Users/bjacobel/code/ux-pattern-library/node_modules/vinyl-fs/lib/dest/index.js:15:11)\r\n    at Gulp.<anonymous> (/Users/bjacobel/code/ux-pattern-library/gulp/tasks/images.js:17:20)\r\n    at module.exports (/Users/bjacobel/code/ux-pattern-library/node_modules/orchestrator/lib/runTask.js:34:7)\r\n    at Gulp.Orchestrator._runTask (/Users/bjacobel/code/ux-pattern-library/node_modules/orchestrator/index.js:273:3)\r\n    at Gulp.Orchestrator._runStep (/Users/bjacobel/code/ux-pattern-library/node_modules/orchestrator/index.js:214:10)\r\n    at Gulp.Orchestrator.start (/Users/bjacobel/code/ux-pattern-library/node_modules/orchestrator/index.js:134:8)\r\n    at runNextSet (/Users/bjacobel/code/ux-pattern-library/node_modules/run-sequence/index.js:88:16)\r\n    at Gulp.onTaskEnd (/Users/bjacobel/code/ux-pattern-library/node_modules/run-sequence/index.js:77:5)\r\n    at emitOne (events.js:95:20)\r\n    at Gulp.emit (events.js:182:7)\r\n[16:13:34] 'default' errored after 137 ms\r\n[16:13:34] Error in plugin 'run-sequence'\r\nMessage:\r\n    An error occured in task 'images'.\r\n[16:13:34] 'build-development' errored after 137 ms\r\n[16:13:34] Error in plugin 'run-sequence'\r\nMessage:\r\n    An error occured in task 'default'.\r\n[16:13:34] 'build-development' errored after 137 ms\r\n[16:13:34] Error in plugin 'run-sequence'\r\nMessage:\r\n    An error occured in task 'images'.\r\n```\r\n\r\nThe references to `'images'` would initially make me thing this was introduced in #325, but this does not occur on master.\r\n\r\n(Node 5.9.1)"}}