{"action":"created","comment":{"url":"https://api.github.com/repos/Linuxbrew/brew/pulls/comments/62070469","id":62070469,"diff_hunk":"@@ -39,7 +39,8 @@ def test_dependency_tags\n \n   def test_requirement_creation\n     @d.add :x11\n-    assert_instance_of X11Requirement, find_requirement(X11Requirement)\n+    req = OS.mac? ? X11Requirement : XorgRequirement\n+    assert_instance_of req, find_requirement(req)","path":"Library/Homebrew/test/test_dependency_collector.rb","position":6,"original_position":6,"commit_id":"e56103a1320982a3019ca6f06a3c85b9cd3e58bb","original_commit_id":"e56103a1320982a3019ca6f06a3c85b9cd3e58bb","user":{"login":"sjackman","id":291551,"avatar_url":"https://avatars.githubusercontent.com/u/291551?v=3","gravatar_id":"","url":"https://api.github.com/users/sjackman","html_url":"https://github.com/sjackman","followers_url":"https://api.github.com/users/sjackman/followers","following_url":"https://api.github.com/users/sjackman/following{/other_user}","gists_url":"https://api.github.com/users/sjackman/gists{/gist_id}","starred_url":"https://api.github.com/users/sjackman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjackman/subscriptions","organizations_url":"https://api.github.com/users/sjackman/orgs","repos_url":"https://api.github.com/users/sjackman/repos","events_url":"https://api.github.com/users/sjackman/events{/privacy}","received_events_url":"https://api.github.com/users/sjackman/received_events","type":"User","site_admin":false},"body":"Should these all be either `find_requirement(:x11)` or `find_requirement(\"x11\")`? (I haven't checked.)","created_at":"2016-05-04T16:27:56Z","updated_at":"2016-05-04T16:27:56Z","html_url":"https://github.com/Linuxbrew/brew/pull/10#discussion_r62070469","pull_request_url":"https://api.github.com/repos/Linuxbrew/brew/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Linuxbrew/brew/pulls/comments/62070469"},"html":{"href":"https://github.com/Linuxbrew/brew/pull/10#discussion_r62070469"},"pull_request":{"href":"https://api.github.com/repos/Linuxbrew/brew/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Linuxbrew/brew/pulls/10","id":68627093,"html_url":"https://github.com/Linuxbrew/brew/pull/10","diff_url":"https://github.com/Linuxbrew/brew/pull/10.diff","patch_url":"https://github.com/Linuxbrew/brew/pull/10.patch","issue_url":"https://api.github.com/repos/Linuxbrew/brew/issues/10","number":10,"state":"open","locked":false,"title":"core: Create an X.Org requirement.","user":{"login":"rwhogg","id":2373856,"avatar_url":"https://avatars.githubusercontent.com/u/2373856?v=3","gravatar_id":"","url":"https://api.github.com/users/rwhogg","html_url":"https://github.com/rwhogg","followers_url":"https://api.github.com/users/rwhogg/followers","following_url":"https://api.github.com/users/rwhogg/following{/other_user}","gists_url":"https://api.github.com/users/rwhogg/gists{/gist_id}","starred_url":"https://api.github.com/users/rwhogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwhogg/subscriptions","organizations_url":"https://api.github.com/users/rwhogg/orgs","repos_url":"https://api.github.com/users/rwhogg/repos","events_url":"https://api.github.com/users/rwhogg/events{/privacy}","received_events_url":"https://api.github.com/users/rwhogg/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Linuxbrew/brew/blob/master/.github/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Linuxbrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully ran `brew tests` with your changes locally?\r\n\r\nThe existing X11 requirement only works for OS X, and works in concert\r\nwith XQuartz. For Linux, we want to install upstream X.Org instead.","created_at":"2016-05-02T21:47:34Z","updated_at":"2016-05-04T16:27:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a24ecad67dce644e933b9ead403a1405f14711ba","assignee":{"login":"rwhogg","id":2373856,"avatar_url":"https://avatars.githubusercontent.com/u/2373856?v=3","gravatar_id":"","url":"https://api.github.com/users/rwhogg","html_url":"https://github.com/rwhogg","followers_url":"https://api.github.com/users/rwhogg/followers","following_url":"https://api.github.com/users/rwhogg/following{/other_user}","gists_url":"https://api.github.com/users/rwhogg/gists{/gist_id}","starred_url":"https://api.github.com/users/rwhogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwhogg/subscriptions","organizations_url":"https://api.github.com/users/rwhogg/orgs","repos_url":"https://api.github.com/users/rwhogg/repos","events_url":"https://api.github.com/users/rwhogg/events{/privacy}","received_events_url":"https://api.github.com/users/rwhogg/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Linuxbrew/brew/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Linuxbrew/brew/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Linuxbrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linuxbrew/brew/issues/10/comments","statuses_url":"https://api.github.com/repos/Linuxbrew/brew/statuses/e56103a1320982a3019ca6f06a3c85b9cd3e58bb","head":{"label":"rwhogg:xorg-requirement","ref":"xorg-requirement","sha":"e56103a1320982a3019ca6f06a3c85b9cd3e58bb","user":{"login":"rwhogg","id":2373856,"avatar_url":"https://avatars.githubusercontent.com/u/2373856?v=3","gravatar_id":"","url":"https://api.github.com/users/rwhogg","html_url":"https://github.com/rwhogg","followers_url":"https://api.github.com/users/rwhogg/followers","following_url":"https://api.github.com/users/rwhogg/following{/other_user}","gists_url":"https://api.github.com/users/rwhogg/gists{/gist_id}","starred_url":"https://api.github.com/users/rwhogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwhogg/subscriptions","organizations_url":"https://api.github.com/users/rwhogg/orgs","repos_url":"https://api.github.com/users/rwhogg/repos","events_url":"https://api.github.com/users/rwhogg/events{/privacy}","received_events_url":"https://api.github.com/users/rwhogg/received_events","type":"User","site_admin":false},"repo":{"id":57923323,"name":"brew","full_name":"rwhogg/brew","owner":{"login":"rwhogg","id":2373856,"avatar_url":"https://avatars.githubusercontent.com/u/2373856?v=3","gravatar_id":"","url":"https://api.github.com/users/rwhogg","html_url":"https://github.com/rwhogg","followers_url":"https://api.github.com/users/rwhogg/followers","following_url":"https://api.github.com/users/rwhogg/following{/other_user}","gists_url":"https://api.github.com/users/rwhogg/gists{/gist_id}","starred_url":"https://api.github.com/users/rwhogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwhogg/subscriptions","organizations_url":"https://api.github.com/users/rwhogg/orgs","repos_url":"https://api.github.com/users/rwhogg/repos","events_url":"https://api.github.com/users/rwhogg/events{/privacy}","received_events_url":"https://api.github.com/users/rwhogg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwhogg/brew","description":":beer::penguin: The Homebrew package manager for Linux","fork":true,"url":"https://api.github.com/repos/rwhogg/brew","forks_url":"https://api.github.com/repos/rwhogg/brew/forks","keys_url":"https://api.github.com/repos/rwhogg/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwhogg/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwhogg/brew/teams","hooks_url":"https://api.github.com/repos/rwhogg/brew/hooks","issue_events_url":"https://api.github.com/repos/rwhogg/brew/issues/events{/number}","events_url":"https://api.github.com/repos/rwhogg/brew/events","assignees_url":"https://api.github.com/repos/rwhogg/brew/assignees{/user}","branches_url":"https://api.github.com/repos/rwhogg/brew/branches{/branch}","tags_url":"https://api.github.com/repos/rwhogg/brew/tags","blobs_url":"https://api.github.com/repos/rwhogg/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwhogg/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwhogg/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwhogg/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwhogg/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/rwhogg/brew/languages","stargazers_url":"https://api.github.com/repos/rwhogg/brew/stargazers","contributors_url":"https://api.github.com/repos/rwhogg/brew/contributors","subscribers_url":"https://api.github.com/repos/rwhogg/brew/subscribers","subscription_url":"https://api.github.com/repos/rwhogg/brew/subscription","commits_url":"https://api.github.com/repos/rwhogg/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwhogg/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwhogg/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwhogg/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwhogg/brew/contents/{+path}","compare_url":"https://api.github.com/repos/rwhogg/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwhogg/brew/merges","archive_url":"https://api.github.com/repos/rwhogg/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwhogg/brew/downloads","issues_url":"https://api.github.com/repos/rwhogg/brew/issues{/number}","pulls_url":"https://api.github.com/repos/rwhogg/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/rwhogg/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/rwhogg/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwhogg/brew/labels{/name}","releases_url":"https://api.github.com/repos/rwhogg/brew/releases{/id}","deployments_url":"https://api.github.com/repos/rwhogg/brew/deployments","created_at":"2016-05-02T21:43:43Z","updated_at":"2016-05-02T21:43:45Z","pushed_at":"2016-05-04T12:11:18Z","git_url":"git://github.com/rwhogg/brew.git","ssh_url":"git@github.com:rwhogg/brew.git","clone_url":"https://github.com/rwhogg/brew.git","svn_url":"https://github.com/rwhogg/brew","homepage":"http://linuxbrew.sh","size":12529,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linuxbrew:master","ref":"master","sha":"46e76f930755399cfb2064532b5ce27bf90d48c9","user":{"login":"Linuxbrew","id":10321259,"avatar_url":"https://avatars.githubusercontent.com/u/10321259?v=3","gravatar_id":"","url":"https://api.github.com/users/Linuxbrew","html_url":"https://github.com/Linuxbrew","followers_url":"https://api.github.com/users/Linuxbrew/followers","following_url":"https://api.github.com/users/Linuxbrew/following{/other_user}","gists_url":"https://api.github.com/users/Linuxbrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Linuxbrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linuxbrew/subscriptions","organizations_url":"https://api.github.com/users/Linuxbrew/orgs","repos_url":"https://api.github.com/users/Linuxbrew/repos","events_url":"https://api.github.com/users/Linuxbrew/events{/privacy}","received_events_url":"https://api.github.com/users/Linuxbrew/received_events","type":"Organization","site_admin":false},"repo":{"id":56941978,"name":"brew","full_name":"Linuxbrew/brew","owner":{"login":"Linuxbrew","id":10321259,"avatar_url":"https://avatars.githubusercontent.com/u/10321259?v=3","gravatar_id":"","url":"https://api.github.com/users/Linuxbrew","html_url":"https://github.com/Linuxbrew","followers_url":"https://api.github.com/users/Linuxbrew/followers","following_url":"https://api.github.com/users/Linuxbrew/following{/other_user}","gists_url":"https://api.github.com/users/Linuxbrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Linuxbrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linuxbrew/subscriptions","organizations_url":"https://api.github.com/users/Linuxbrew/orgs","repos_url":"https://api.github.com/users/Linuxbrew/repos","events_url":"https://api.github.com/users/Linuxbrew/events{/privacy}","received_events_url":"https://api.github.com/users/Linuxbrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linuxbrew/brew","description":":beer::penguin: The Homebrew package manager for Linux","fork":true,"url":"https://api.github.com/repos/Linuxbrew/brew","forks_url":"https://api.github.com/repos/Linuxbrew/brew/forks","keys_url":"https://api.github.com/repos/Linuxbrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linuxbrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linuxbrew/brew/teams","hooks_url":"https://api.github.com/repos/Linuxbrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Linuxbrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Linuxbrew/brew/events","assignees_url":"https://api.github.com/repos/Linuxbrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Linuxbrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Linuxbrew/brew/tags","blobs_url":"https://api.github.com/repos/Linuxbrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linuxbrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linuxbrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linuxbrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linuxbrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Linuxbrew/brew/languages","stargazers_url":"https://api.github.com/repos/Linuxbrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Linuxbrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Linuxbrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Linuxbrew/brew/subscription","commits_url":"https://api.github.com/repos/Linuxbrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linuxbrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linuxbrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linuxbrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linuxbrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Linuxbrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linuxbrew/brew/merges","archive_url":"https://api.github.com/repos/Linuxbrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linuxbrew/brew/downloads","issues_url":"https://api.github.com/repos/Linuxbrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Linuxbrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Linuxbrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Linuxbrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linuxbrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Linuxbrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Linuxbrew/brew/deployments","created_at":"2016-04-23T21:38:42Z","updated_at":"2016-05-04T01:54:42Z","pushed_at":"2016-05-04T12:12:43Z","git_url":"git://github.com/Linuxbrew/brew.git","ssh_url":"git@github.com:Linuxbrew/brew.git","clone_url":"https://github.com/Linuxbrew/brew.git","svn_url":"https://github.com/Linuxbrew/brew","homepage":"http://linuxbrew.sh","size":12508,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":13,"forks":4,"open_issues":13,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linuxbrew/brew/pulls/10"},"html":{"href":"https://github.com/Linuxbrew/brew/pull/10"},"issue":{"href":"https://api.github.com/repos/Linuxbrew/brew/issues/10"},"comments":{"href":"https://api.github.com/repos/Linuxbrew/brew/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Linuxbrew/brew/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Linuxbrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linuxbrew/brew/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Linuxbrew/brew/statuses/e56103a1320982a3019ca6f06a3c85b9cd3e58bb"}}}}