{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung-AG/kraken/pulls/comments/54508968","id":54508968,"diff_hunk":"@@ -15,7 +15,9 @@ source \"${my_dir}/utils.sh\"\n src_cluster_dir=\"/kraken_data/${KRAKEN_CLUSTER_NAME}\"\n containerfiles=(\n   kraken_data:${src_cluster_dir}/ssh_config\n-  kraken_data:${src_cluster_dir}/ansible.inventory\n+  kraken_data:${src_cluster_dir}/hosts\n+  kraken_data:${src_cluster_dir}/group_vars/cluster\n+  kraken_data:${src_cluster_dir}/hosts","path":"bin/kraken-connect.sh","position":7,"original_position":7,"commit_id":"1ddc8c96f680db71bf2c9966925c030cf78f9cfd","original_commit_id":"1ddc8c96f680db71bf2c9966925c030cf78f9cfd","user":{"login":"spiffxp","id":49258,"avatar_url":"https://avatars.githubusercontent.com/u/49258?v=3","gravatar_id":"","url":"https://api.github.com/users/spiffxp","html_url":"https://github.com/spiffxp","followers_url":"https://api.github.com/users/spiffxp/followers","following_url":"https://api.github.com/users/spiffxp/following{/other_user}","gists_url":"https://api.github.com/users/spiffxp/gists{/gist_id}","starred_url":"https://api.github.com/users/spiffxp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiffxp/subscriptions","organizations_url":"https://api.github.com/users/spiffxp/orgs","repos_url":"https://api.github.com/users/spiffxp/repos","events_url":"https://api.github.com/users/spiffxp/events{/privacy}","received_events_url":"https://api.github.com/users/spiffxp/received_events","type":"User","site_admin":false},"body":"dupe `/hosts` line","created_at":"2016-03-01T01:15:43Z","updated_at":"2016-03-01T01:15:43Z","html_url":"https://github.com/Samsung-AG/kraken/pull/248#discussion_r54508968","pull_request_url":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248","_links":{"self":{"href":"https://api.github.com/repos/Samsung-AG/kraken/pulls/comments/54508968"},"html":{"href":"https://github.com/Samsung-AG/kraken/pull/248#discussion_r54508968"},"pull_request":{"href":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248","id":61167057,"html_url":"https://github.com/Samsung-AG/kraken/pull/248","diff_url":"https://github.com/Samsung-AG/kraken/pull/248.diff","patch_url":"https://github.com/Samsung-AG/kraken/pull/248.patch","issue_url":"https://api.github.com/repos/Samsung-AG/kraken/issues/248","number":248,"state":"open","locked":false,"title":"Refactor kubernetes Ansible role","user":{"login":"maratoid","id":273764,"avatar_url":"https://avatars.githubusercontent.com/u/273764?v=3","gravatar_id":"","url":"https://api.github.com/users/maratoid","html_url":"https://github.com/maratoid","followers_url":"https://api.github.com/users/maratoid/followers","following_url":"https://api.github.com/users/maratoid/following{/other_user}","gists_url":"https://api.github.com/users/maratoid/gists{/gist_id}","starred_url":"https://api.github.com/users/maratoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maratoid/subscriptions","organizations_url":"https://api.github.com/users/maratoid/orgs","repos_url":"https://api.github.com/users/maratoid/repos","events_url":"https://api.github.com/users/maratoid/events{/privacy}","received_events_url":"https://api.github.com/users/maratoid/received_events","type":"User","site_admin":false},"body":"1) It breaks up the kubernetes ansible role into several smaller roles with dependencies through meta/main.yaml\r\n2) Gets rid of the many bash scripts ran as systemd services, and converts those into ansible tasks\r\n3) removes variables from ansible inventory, putting them instead into group_vars files\r\n4) removes sed-based post-processing of values in kraken-services yamls, in favor of using jinja2\r\n\r\nThis will most likely not pass the Jenkins muster, as it requires https://github.com/Samsung-AG/kraken-services/pull/77 to be merged first","created_at":"2016-02-29T23:45:05Z","updated_at":"2016-03-01T01:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87b778889af5f28089be3995552a57d946a92320","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248/commits","review_comments_url":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248/comments","review_comment_url":"https://api.github.com/repos/Samsung-AG/kraken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung-AG/kraken/issues/248/comments","statuses_url":"https://api.github.com/repos/Samsung-AG/kraken/statuses/1ddc8c96f680db71bf2c9966925c030cf78f9cfd","head":{"label":"maratoid:ansible_refactor","ref":"ansible_refactor","sha":"1ddc8c96f680db71bf2c9966925c030cf78f9cfd","user":{"login":"maratoid","id":273764,"avatar_url":"https://avatars.githubusercontent.com/u/273764?v=3","gravatar_id":"","url":"https://api.github.com/users/maratoid","html_url":"https://github.com/maratoid","followers_url":"https://api.github.com/users/maratoid/followers","following_url":"https://api.github.com/users/maratoid/following{/other_user}","gists_url":"https://api.github.com/users/maratoid/gists{/gist_id}","starred_url":"https://api.github.com/users/maratoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maratoid/subscriptions","organizations_url":"https://api.github.com/users/maratoid/orgs","repos_url":"https://api.github.com/users/maratoid/repos","events_url":"https://api.github.com/users/maratoid/events{/privacy}","received_events_url":"https://api.github.com/users/maratoid/received_events","type":"User","site_admin":false},"repo":{"id":51405665,"name":"kraken","full_name":"maratoid/kraken","owner":{"login":"maratoid","id":273764,"avatar_url":"https://avatars.githubusercontent.com/u/273764?v=3","gravatar_id":"","url":"https://api.github.com/users/maratoid","html_url":"https://github.com/maratoid","followers_url":"https://api.github.com/users/maratoid/followers","following_url":"https://api.github.com/users/maratoid/following{/other_user}","gists_url":"https://api.github.com/users/maratoid/gists{/gist_id}","starred_url":"https://api.github.com/users/maratoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maratoid/subscriptions","organizations_url":"https://api.github.com/users/maratoid/orgs","repos_url":"https://api.github.com/users/maratoid/repos","events_url":"https://api.github.com/users/maratoid/events{/privacy}","received_events_url":"https://api.github.com/users/maratoid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maratoid/kraken","description":"Deploy a Kubernetes cluster using Terraform and Ansible on top of CoreOS.","fork":true,"url":"https://api.github.com/repos/maratoid/kraken","forks_url":"https://api.github.com/repos/maratoid/kraken/forks","keys_url":"https://api.github.com/repos/maratoid/kraken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maratoid/kraken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maratoid/kraken/teams","hooks_url":"https://api.github.com/repos/maratoid/kraken/hooks","issue_events_url":"https://api.github.com/repos/maratoid/kraken/issues/events{/number}","events_url":"https://api.github.com/repos/maratoid/kraken/events","assignees_url":"https://api.github.com/repos/maratoid/kraken/assignees{/user}","branches_url":"https://api.github.com/repos/maratoid/kraken/branches{/branch}","tags_url":"https://api.github.com/repos/maratoid/kraken/tags","blobs_url":"https://api.github.com/repos/maratoid/kraken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maratoid/kraken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maratoid/kraken/git/refs{/sha}","trees_url":"https://api.github.com/repos/maratoid/kraken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maratoid/kraken/statuses/{sha}","languages_url":"https://api.github.com/repos/maratoid/kraken/languages","stargazers_url":"https://api.github.com/repos/maratoid/kraken/stargazers","contributors_url":"https://api.github.com/repos/maratoid/kraken/contributors","subscribers_url":"https://api.github.com/repos/maratoid/kraken/subscribers","subscription_url":"https://api.github.com/repos/maratoid/kraken/subscription","commits_url":"https://api.github.com/repos/maratoid/kraken/commits{/sha}","git_commits_url":"https://api.github.com/repos/maratoid/kraken/git/commits{/sha}","comments_url":"https://api.github.com/repos/maratoid/kraken/comments{/number}","issue_comment_url":"https://api.github.com/repos/maratoid/kraken/issues/comments{/number}","contents_url":"https://api.github.com/repos/maratoid/kraken/contents/{+path}","compare_url":"https://api.github.com/repos/maratoid/kraken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maratoid/kraken/merges","archive_url":"https://api.github.com/repos/maratoid/kraken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maratoid/kraken/downloads","issues_url":"https://api.github.com/repos/maratoid/kraken/issues{/number}","pulls_url":"https://api.github.com/repos/maratoid/kraken/pulls{/number}","milestones_url":"https://api.github.com/repos/maratoid/kraken/milestones{/number}","notifications_url":"https://api.github.com/repos/maratoid/kraken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maratoid/kraken/labels{/name}","releases_url":"https://api.github.com/repos/maratoid/kraken/releases{/id}","deployments_url":"https://api.github.com/repos/maratoid/kraken/deployments","created_at":"2016-02-09T22:37:00Z","updated_at":"2016-02-09T22:37:01Z","pushed_at":"2016-03-01T00:53:44Z","git_url":"git://github.com/maratoid/kraken.git","ssh_url":"git@github.com:maratoid/kraken.git","clone_url":"https://github.com/maratoid/kraken.git","svn_url":"https://github.com/maratoid/kraken","homepage":"","size":1383,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung-AG:master","ref":"master","sha":"be7719b615ef66e744ef4dc2c68ec51604a322e2","user":{"login":"Samsung-AG","id":11511065,"avatar_url":"https://avatars.githubusercontent.com/u/11511065?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung-AG","html_url":"https://github.com/Samsung-AG","followers_url":"https://api.github.com/users/Samsung-AG/followers","following_url":"https://api.github.com/users/Samsung-AG/following{/other_user}","gists_url":"https://api.github.com/users/Samsung-AG/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung-AG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung-AG/subscriptions","organizations_url":"https://api.github.com/users/Samsung-AG/orgs","repos_url":"https://api.github.com/users/Samsung-AG/repos","events_url":"https://api.github.com/users/Samsung-AG/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung-AG/received_events","type":"Organization","site_admin":false},"repo":{"id":32483484,"name":"kraken","full_name":"Samsung-AG/kraken","owner":{"login":"Samsung-AG","id":11511065,"avatar_url":"https://avatars.githubusercontent.com/u/11511065?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung-AG","html_url":"https://github.com/Samsung-AG","followers_url":"https://api.github.com/users/Samsung-AG/followers","following_url":"https://api.github.com/users/Samsung-AG/following{/other_user}","gists_url":"https://api.github.com/users/Samsung-AG/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung-AG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung-AG/subscriptions","organizations_url":"https://api.github.com/users/Samsung-AG/orgs","repos_url":"https://api.github.com/users/Samsung-AG/repos","events_url":"https://api.github.com/users/Samsung-AG/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung-AG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung-AG/kraken","description":"Deploy a Kubernetes cluster using Terraform and Ansible on top of CoreOS.","fork":false,"url":"https://api.github.com/repos/Samsung-AG/kraken","forks_url":"https://api.github.com/repos/Samsung-AG/kraken/forks","keys_url":"https://api.github.com/repos/Samsung-AG/kraken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung-AG/kraken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung-AG/kraken/teams","hooks_url":"https://api.github.com/repos/Samsung-AG/kraken/hooks","issue_events_url":"https://api.github.com/repos/Samsung-AG/kraken/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung-AG/kraken/events","assignees_url":"https://api.github.com/repos/Samsung-AG/kraken/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung-AG/kraken/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung-AG/kraken/tags","blobs_url":"https://api.github.com/repos/Samsung-AG/kraken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung-AG/kraken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung-AG/kraken/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung-AG/kraken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung-AG/kraken/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung-AG/kraken/languages","stargazers_url":"https://api.github.com/repos/Samsung-AG/kraken/stargazers","contributors_url":"https://api.github.com/repos/Samsung-AG/kraken/contributors","subscribers_url":"https://api.github.com/repos/Samsung-AG/kraken/subscribers","subscription_url":"https://api.github.com/repos/Samsung-AG/kraken/subscription","commits_url":"https://api.github.com/repos/Samsung-AG/kraken/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung-AG/kraken/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung-AG/kraken/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung-AG/kraken/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung-AG/kraken/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung-AG/kraken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung-AG/kraken/merges","archive_url":"https://api.github.com/repos/Samsung-AG/kraken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung-AG/kraken/downloads","issues_url":"https://api.github.com/repos/Samsung-AG/kraken/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung-AG/kraken/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung-AG/kraken/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung-AG/kraken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung-AG/kraken/labels{/name}","releases_url":"https://api.github.com/repos/Samsung-AG/kraken/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung-AG/kraken/deployments","created_at":"2015-03-18T20:47:13Z","updated_at":"2016-02-27T23:46:09Z","pushed_at":"2016-03-01T00:53:44Z","git_url":"git://github.com/Samsung-AG/kraken.git","ssh_url":"git@github.com:Samsung-AG/kraken.git","clone_url":"https://github.com/Samsung-AG/kraken.git","svn_url":"https://github.com/Samsung-AG/kraken","homepage":"","size":1406,"stargazers_count":29,"watchers_count":29,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248"},"html":{"href":"https://github.com/Samsung-AG/kraken/pull/248"},"issue":{"href":"https://api.github.com/repos/Samsung-AG/kraken/issues/248"},"comments":{"href":"https://api.github.com/repos/Samsung-AG/kraken/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung-AG/kraken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung-AG/kraken/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung-AG/kraken/statuses/1ddc8c96f680db71bf2c9966925c030cf78f9cfd"}}}}