{"action":"created","issue":{"url":"https://api.github.com/repos/ReactJSTraining/history/issues/307","repository_url":"https://api.github.com/repos/ReactJSTraining/history","labels_url":"https://api.github.com/repos/ReactJSTraining/history/issues/307/labels{/name}","comments_url":"https://api.github.com/repos/ReactJSTraining/history/issues/307/comments","events_url":"https://api.github.com/repos/ReactJSTraining/history/issues/307/events","html_url":"https://github.com/ReactJSTraining/history/pull/307","id":158899545,"number":307,"title":"Browserify production build is not optimized by default","user":{"login":"ThibWeb","id":877585,"avatar_url":"https://avatars.githubusercontent.com/u/877585?v=3","gravatar_id":"","url":"https://api.github.com/users/ThibWeb","html_url":"https://github.com/ThibWeb","followers_url":"https://api.github.com/users/ThibWeb/followers","following_url":"https://api.github.com/users/ThibWeb/following{/other_user}","gists_url":"https://api.github.com/users/ThibWeb/gists{/gist_id}","starred_url":"https://api.github.com/users/ThibWeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThibWeb/subscriptions","organizations_url":"https://api.github.com/users/ThibWeb/orgs","repos_url":"https://api.github.com/users/ThibWeb/repos","events_url":"https://api.github.com/users/ThibWeb/events{/privacy}","received_events_url":"https://api.github.com/users/ThibWeb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-07T11:25:49Z","updated_at":"2016-06-15T04:04:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ReactJSTraining/history/pulls/307","html_url":"https://github.com/ReactJSTraining/history/pull/307","diff_url":"https://github.com/ReactJSTraining/history/pull/307.diff","patch_url":"https://github.com/ReactJSTraining/history/pull/307.patch"},"body":"> TL;DR; Like `react`, use `loose-envify` dependency / browserify transform to prevent browserify users from shipping development code in production.\r\n(Warning: big file) L248 of https://github.com/ThibWeb/react-router-browserify-build/blob/master/bundle.js#L248.\r\n\r\nThis is exact same PR as https://github.com/reactjs/react-router/pull/3503, more info over there.\r\n\r\nOther projects (react, redux, react-redux, and now react-router) have this configuration to make browserify users' lives easier. Another complementary solution would be to have a [\"looks like you are using development code in production\" warning](https://github.com/facebook/react/blob/ba9b985406ff56c2dea192b119328b6096895097/src/renderers/dom/ReactDOM.js#L93) (is there a module for that?).\r\n\r\nI don't feel like going to every single project that has development aids to propose this change, but for react-router / history I think those have enough usage that it makes sense to follow React and approach it this way."},"comment":{"url":"https://api.github.com/repos/ReactJSTraining/history/issues/comments/226082709","html_url":"https://github.com/ReactJSTraining/history/pull/307#issuecomment-226082709","issue_url":"https://api.github.com/repos/ReactJSTraining/history/issues/307","id":226082709,"user":{"login":"mjackson","id":92839,"avatar_url":"https://avatars.githubusercontent.com/u/92839?v=3","gravatar_id":"","url":"https://api.github.com/users/mjackson","html_url":"https://github.com/mjackson","followers_url":"https://api.github.com/users/mjackson/followers","following_url":"https://api.github.com/users/mjackson/following{/other_user}","gists_url":"https://api.github.com/users/mjackson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjackson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjackson/subscriptions","organizations_url":"https://api.github.com/users/mjackson/orgs","repos_url":"https://api.github.com/users/mjackson/repos","events_url":"https://api.github.com/users/mjackson/events{/privacy}","received_events_url":"https://api.github.com/users/mjackson/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T04:04:24Z","updated_at":"2016-06-15T04:04:24Z","body":"Ah, browserify... *sigh*"}}
{"actor":{"display_login":"mjackson"}}