{"action":"created","issue":{"url":"https://api.github.com/repos/getquill/quill/issues/607","repository_url":"https://api.github.com/repos/getquill/quill","labels_url":"https://api.github.com/repos/getquill/quill/issues/607/labels{/name}","comments_url":"https://api.github.com/repos/getquill/quill/issues/607/comments","events_url":"https://api.github.com/repos/getquill/quill/issues/607/events","html_url":"https://github.com/getquill/quill/issues/607","id":186147062,"number":607,"title":"FinaglePostgresEncoders isn't usefully extensible","user":{"login":"tekacs","id":63247,"avatar_url":"https://avatars.githubusercontent.com/u/63247?v=3","gravatar_id":"","url":"https://api.github.com/users/tekacs","html_url":"https://github.com/tekacs","followers_url":"https://api.github.com/users/tekacs/followers","following_url":"https://api.github.com/users/tekacs/following{/other_user}","gists_url":"https://api.github.com/users/tekacs/gists{/gist_id}","starred_url":"https://api.github.com/users/tekacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekacs/subscriptions","organizations_url":"https://api.github.com/users/tekacs/orgs","repos_url":"https://api.github.com/users/tekacs/repos","events_url":"https://api.github.com/users/tekacs/events{/privacy}","received_events_url":"https://api.github.com/users/tekacs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-30T16:43:40Z","updated_at":"2016-10-31T02:09:17Z","closed_at":null,"body":"**Version**: 1.0.0\n**Module**: quill-finagle-postgres\n**Database**: postgres\n\nFor some reason, the `encoder[T]` and `encoder[T, U]` helper functions in `FinaglePostgresEncoders` are `protected`.\n\nThis would be merely frustrating/awkward, but for the fact that the (public) `implicit def optionEncoder` provided for `Option[T]` only accepts encoders of type `ValueEncoderEncoder[T]`, which is the accompanying, also `protected` encoder to the aforementioned helpers.\n\nThe solution as I see it (and if that's accepted, I can PR if necessary) is to make both `encoder` signatures and `ValueEncoderEncoder` public.\n\nTo clarify, `optionEncoder` and custom encoding in general _should_ require a `ValueEncoder` to have been provided by the user (and the interface to doing so is super convenient & simple). It's not useful however for it to accept a protected wrapper type.\n\nThis change also brings these classes in line with the other drivers, which provide public `encoder` helper methods and wrapper types.\n\n@getquill/maintainers\n"},"comment":{"url":"https://api.github.com/repos/getquill/quill/issues/comments/257199553","html_url":"https://github.com/getquill/quill/issues/607#issuecomment-257199553","issue_url":"https://api.github.com/repos/getquill/quill/issues/607","id":257199553,"user":{"login":"tekacs","id":63247,"avatar_url":"https://avatars.githubusercontent.com/u/63247?v=3","gravatar_id":"","url":"https://api.github.com/users/tekacs","html_url":"https://github.com/tekacs","followers_url":"https://api.github.com/users/tekacs/followers","following_url":"https://api.github.com/users/tekacs/following{/other_user}","gists_url":"https://api.github.com/users/tekacs/gists{/gist_id}","starred_url":"https://api.github.com/users/tekacs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tekacs/subscriptions","organizations_url":"https://api.github.com/users/tekacs/orgs","repos_url":"https://api.github.com/users/tekacs/repos","events_url":"https://api.github.com/users/tekacs/events{/privacy}","received_events_url":"https://api.github.com/users/tekacs/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T02:09:17Z","updated_at":"2016-10-31T02:09:17Z","body":"@jilen Yup that's exactly what I do, but it shouldn't be necessary. There's no good reason for encoder to be protected."}}
{"actor":{"display_login":"tekacs"}}