{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/58930461","id":58930461,"diff_hunk":"@@ -0,0 +1,43 @@\n+#!/usr/bin/env python","path":"tools/check-imports.py","position":1,"original_position":1,"commit_id":"68035330d235bf78fd337e43f5f08285a5e9e6db","original_commit_id":"68035330d235bf78fd337e43f5f08285a5e9e6db","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Can you use two-space indent in this file?","created_at":"2016-04-07T19:28:34Z","updated_at":"2016-04-07T19:28:34Z","html_url":"https://github.com/nodejs/node/pull/6105#discussion_r58930461","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/6105","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/58930461"},"html":{"href":"https://github.com/nodejs/node/pull/6105#discussion_r58930461"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/6105"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6105","id":65684654,"html_url":"https://github.com/nodejs/node/pull/6105","diff_url":"https://github.com/nodejs/node/pull/6105.diff","patch_url":"https://github.com/nodejs/node/pull/6105.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/6105","number":6105,"state":"open","locked":false,"title":"src,tools: rewrite check-imports and fix linter errors","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n\r\n- [x] tests and code linting passes\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nsrc, tools\r\n\r\n##### Description of change\r\n\r\n**Commit 1**\r\n\r\nAs it is, check-install.sh does not show more helpful error messages,\r\nand supporting various shells could be a problem. This patch rewrites\r\nthe same in Python.\r\n\r\n**Commit 2**\r\n\r\nThis patch simply enables check-imports.py in the linting process\r\n\r\n**Commit 3**\r\n\r\nFix all the linter errors\r\n\r\n---\r\n\r\ncc @bnoordhuis \r\n\r\nCI Run: https://ci.nodejs.org/job/node-test-pull-request/2210/","created_at":"2016-04-07T19:21:48Z","updated_at":"2016-04-07T19:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eab22568247ebe5297dc593ba6f8c3936f20a012","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/6105/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/6105/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6105/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/68035330d235bf78fd337e43f5f08285a5e9e6db","head":{"label":"thefourtheye:fix-imports","ref":"fix-imports","sha":"68035330d235bf78fd337e43f5f08285a5e9e6db","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"repo":{"id":35113605,"name":"io.js","full_name":"thefourtheye/io.js","owner":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thefourtheye/io.js","description":"A friendly fork of Node.js with an open governance model","fork":true,"url":"https://api.github.com/repos/thefourtheye/io.js","forks_url":"https://api.github.com/repos/thefourtheye/io.js/forks","keys_url":"https://api.github.com/repos/thefourtheye/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefourtheye/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefourtheye/io.js/teams","hooks_url":"https://api.github.com/repos/thefourtheye/io.js/hooks","issue_events_url":"https://api.github.com/repos/thefourtheye/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/thefourtheye/io.js/events","assignees_url":"https://api.github.com/repos/thefourtheye/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/thefourtheye/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/thefourtheye/io.js/tags","blobs_url":"https://api.github.com/repos/thefourtheye/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefourtheye/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefourtheye/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefourtheye/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefourtheye/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/thefourtheye/io.js/languages","stargazers_url":"https://api.github.com/repos/thefourtheye/io.js/stargazers","contributors_url":"https://api.github.com/repos/thefourtheye/io.js/contributors","subscribers_url":"https://api.github.com/repos/thefourtheye/io.js/subscribers","subscription_url":"https://api.github.com/repos/thefourtheye/io.js/subscription","commits_url":"https://api.github.com/repos/thefourtheye/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefourtheye/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefourtheye/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefourtheye/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefourtheye/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/thefourtheye/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefourtheye/io.js/merges","archive_url":"https://api.github.com/repos/thefourtheye/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefourtheye/io.js/downloads","issues_url":"https://api.github.com/repos/thefourtheye/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/thefourtheye/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/thefourtheye/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/thefourtheye/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefourtheye/io.js/labels{/name}","releases_url":"https://api.github.com/repos/thefourtheye/io.js/releases{/id}","deployments_url":"https://api.github.com/repos/thefourtheye/io.js/deployments","created_at":"2015-05-05T17:20:53Z","updated_at":"2015-05-05T17:20:56Z","pushed_at":"2016-04-07T19:18:24Z","git_url":"git://github.com/thefourtheye/io.js.git","ssh_url":"git@github.com:thefourtheye/io.js.git","clone_url":"https://github.com/thefourtheye/io.js.git","svn_url":"https://github.com/thefourtheye/io.js","homepage":"https://iojs.org","size":179713,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"937ac3760a85888047c6acde9b15320643fa1324","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-04-07T18:46:05Z","pushed_at":"2016-04-07T19:21:48Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":231688,"stargazers_count":21815,"watchers_count":21815,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2924,"mirror_url":null,"open_issues_count":693,"forks":2924,"open_issues":693,"watchers":21815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/6105"},"html":{"href":"https://github.com/nodejs/node/pull/6105"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/6105"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/6105/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/6105/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/6105/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/68035330d235bf78fd337e43f5f08285a5e9e6db"}}}}