{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/72906385","id":72906385,"diff_hunk":"@@ -91,106 +77,132 @@ stdenv.mkDerivation {\n \n   prefixKey = \"-prefix \";\n \n-  # -no-eglfs, -no-directfb, -no-linuxfb and -no-kms because of the current minimalist mesa\n-  # TODO Remove obsolete and useless flags once the build will be totally mastered\n   configureFlags = ''\n-    -verbose\n-    -confirm-license\n-    -opensource\n-\n     -release\n-    -shared\n     ${lib.optionalString developerBuild \"-developer-build\"}\n+    -opensource\n+    -confirm-license\n+    -shared\n     -largefile\n     -accessibility\n-    -rpath\n-    -optimized-qmake\n-    -strip\n-    -reduce-relocations\n-    -system-proxies\n+\n+    -no-sql-db2\n+    -no-sql-ibase\n+    ${lib.optionalString (null != mysql) \"-plugin-sql-mysql\"}\n+    ${lib.optionalString (null == mysql) \"-no-sql-mysql\"}\n+    -no-sql-oci\n+    -no-sql-odbc\n+    -no-sql-sqlite2\n+    ${lib.optionalString (null != postgresql) \"-plugin-sql-psql\"}\n+    ${lib.optionalString (null == postgresql) \"-no-sql-psql\"}\n+    -no-sql-tds\n+\n+    -system-sqlite\n+    -qml-debug\n     -pkg-config\n \n+    -system-zlib\n+    ${lib.optionalString stdenv.isDarwin \"-I${zlib.out}/include/ -L${zlib.out}/lib\"}\n+    -no-mtdev\n+    -system-libpng\n+    ${lib.optionalString stdenv.isDarwin \"-I${libpng.dev}/include/ -L${libpng.out}/lib\"}\n+    -system-libjpeg\n+    ${lib.optionalString stdenv.isDarwin \"-I${libjpeg.dev}/include/ -L${libjpeg.out}/lib\"}\n+    -system-doubleconversion\n+    ${lib.optionalString stdenv.isDarwin \"-I${double_conversion.out}/include/ -L${double_conversion.out}/lib\"}\n+    ${lib.optionalString stdenv.isLinux \"-system-freetype\"}\n+    ${lib.optionalString stdenv.isDarwin \"-no-freetype\"}\n+    -system-harfbuzz\n+    ${lib.optionalString stdenv.isDarwin \"-I${harfbuzz.dev}/include/ -I${harfbuzz.out}/include/\"}\n+    ${lib.optionalString stdenv.isDarwin \"-L${harfbuzz.out}/lib\"}\n+    ${lib.optionalString stdenv.isLinux \"-openssl-linked\"}\n+    ${lib.optionalString stdenv.isDarwin \"-no-openssl\"}\n+    -no-libproxy\n+    -system-pcre\n+    ${lib.optionalString stdenv.isDarwin \"-I${pcre16.dev}/include/ -L${pcre16.out}/lib\"}\n+    -system-xcb\n+    ${lib.optionalString stdenv.isDarwin \"-no-xkbcommon-x11\"}\n+    ${lib.optionalString stdenv.isDarwin \"-no-xkbcommon-evdev\"}\n+    -${lib.optionalString stdenv.isDarwin \"no-\"}glib\n+    ${lib.optionalString stdenv.isDarwin \"-no-pulseaudio\"}\n+    ${lib.optionalString stdenv.isDarwin \"-no-alsa\"}\n+    -${lib.optionalString stdenv.isDarwin \"no-\"}gtk\n+\n+    -make libs\n+    -make tools\n+    -${lib.optionalString (buildExamples == false) \"no\"}make examples\n+    -${lib.optionalString (buildTests == false) \"no\"}make tests\n+\n     -gui\n     -widgets\n-    -opengl desktop\n-    -qml-debug\n+    -rpath\n+    -verbose\n+    -silent\n     -nis\n+    -${lib.optionalString (cups == null) \"no-\"}cups\n     -iconv\n+    ${lib.optionalString stdenv.isDarwin \"-no-evdev\"}\n+    -no-tslib\n     -icu\n+    ${lib.optionalString stdenv.isDarwin \"-I${icu.dev}/include/ -L${icu.out}/lib\"}\n+    -${lib.optionalString stdenv.isDarwin \"no-\"}fontconfig\n+    -strip\n     -pch\n-    -glib\n-    -xcb\n-    -qpa xcb\n-    -${lib.optionalString (cups == null) \"no-\"}cups\n-\n+    -dbus-linked\n+    ${lib.optionalString stdenv.isLinux \"-reduce-relocations\"}\n+    ${lib.optionalString stdenv.isDarwin \"-no-use-gold-linker\"}\n+    -${lib.optionalString stdenv.isDarwin \"no-\"}xcb\n     -no-eglfs\n+    -no-kms\n+    -no-gbm\n     -no-directfb\n     -no-linuxfb\n-    -no-kms\n-\n-    ${lib.optionalString (!system-x86_64) \"-no-sse2\"}","path":"pkgs/development/libraries/qt-5/5.7/qtbase/default.nix","position":219,"original_position":219,"commit_id":"640a808dae6e13a555c2a5adbfaccd0b47759f13","original_commit_id":"640a808dae6e13a555c2a5adbfaccd0b47759f13","user":{"login":"ttuegel","id":563054,"avatar_url":"https://avatars.githubusercontent.com/u/563054?v=3","gravatar_id":"","url":"https://api.github.com/users/ttuegel","html_url":"https://github.com/ttuegel","followers_url":"https://api.github.com/users/ttuegel/followers","following_url":"https://api.github.com/users/ttuegel/following{/other_user}","gists_url":"https://api.github.com/users/ttuegel/gists{/gist_id}","starred_url":"https://api.github.com/users/ttuegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttuegel/subscriptions","organizations_url":"https://api.github.com/users/ttuegel/orgs","repos_url":"https://api.github.com/users/ttuegel/repos","events_url":"https://api.github.com/users/ttuegel/events{/privacy}","received_events_url":"https://api.github.com/users/ttuegel/received_events","type":"User","site_admin":false},"body":"IIUC, in the absence of these flags, Qt will try to detect these features based on the host CPU. That makes builds non-deterministic and it can actually result in binary incompatibility!","created_at":"2016-07-31T15:49:47Z","updated_at":"2016-07-31T15:49:47Z","html_url":"https://github.com/NixOS/nixpkgs/pull/17328#discussion_r72906385","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/72906385"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/17328#discussion_r72906385"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328","id":79132840,"html_url":"https://github.com/NixOS/nixpkgs/pull/17328","diff_url":"https://github.com/NixOS/nixpkgs/pull/17328.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/17328.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17328","number":17328,"state":"open","locked":false,"title":"[WIP] qt57: add darwin support + add new modules","user":{"login":"adolfogc","id":1250775,"avatar_url":"https://avatars.githubusercontent.com/u/1250775?v=3","gravatar_id":"","url":"https://api.github.com/users/adolfogc","html_url":"https://github.com/adolfogc","followers_url":"https://api.github.com/users/adolfogc/followers","following_url":"https://api.github.com/users/adolfogc/following{/other_user}","gists_url":"https://api.github.com/users/adolfogc/gists{/gist_id}","starred_url":"https://api.github.com/users/adolfogc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adolfogc/subscriptions","organizations_url":"https://api.github.com/users/adolfogc/orgs","repos_url":"https://api.github.com/users/adolfogc/repos","events_url":"https://api.github.com/users/adolfogc/events{/privacy}","received_events_url":"https://api.github.com/users/adolfogc/received_events","type":"User","site_admin":false},"body":"###### Main changes\r\n\r\n- Add support for Mac OS X (currently only Qt4 version 4.8 is available on darwin).\r\n- Add new Qt modules: QtMacExtras, QtQuickControls2, QtSCXML, QtSerialBus.\r\n- Other minor changes.\r\n\r\n###### TO-DO\r\n\r\n- [ ] Figure out why the Travis build failed for Xcode.\r\n- ~~[ ] Add _qtstyleplugins_ as a library separate from Qt5.~~\r\n\r\n###### Things done\r\n\r\n- [X] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [X] OS X\r\n   - [X] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n","created_at":"2016-07-28T03:39:19Z","updated_at":"2016-07-31T15:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04b04c49d5f5ef2f6f1089c6375f63554f8be9cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17328/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/640a808dae6e13a555c2a5adbfaccd0b47759f13","head":{"label":"adolfogc:qt57-darwin","ref":"qt57-darwin","sha":"640a808dae6e13a555c2a5adbfaccd0b47759f13","user":{"login":"adolfogc","id":1250775,"avatar_url":"https://avatars.githubusercontent.com/u/1250775?v=3","gravatar_id":"","url":"https://api.github.com/users/adolfogc","html_url":"https://github.com/adolfogc","followers_url":"https://api.github.com/users/adolfogc/followers","following_url":"https://api.github.com/users/adolfogc/following{/other_user}","gists_url":"https://api.github.com/users/adolfogc/gists{/gist_id}","starred_url":"https://api.github.com/users/adolfogc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adolfogc/subscriptions","organizations_url":"https://api.github.com/users/adolfogc/orgs","repos_url":"https://api.github.com/users/adolfogc/repos","events_url":"https://api.github.com/users/adolfogc/events{/privacy}","received_events_url":"https://api.github.com/users/adolfogc/received_events","type":"User","site_admin":false},"repo":{"id":63121238,"name":"nixpkgs","full_name":"adolfogc/nixpkgs","owner":{"login":"adolfogc","id":1250775,"avatar_url":"https://avatars.githubusercontent.com/u/1250775?v=3","gravatar_id":"","url":"https://api.github.com/users/adolfogc","html_url":"https://github.com/adolfogc","followers_url":"https://api.github.com/users/adolfogc/followers","following_url":"https://api.github.com/users/adolfogc/following{/other_user}","gists_url":"https://api.github.com/users/adolfogc/gists{/gist_id}","starred_url":"https://api.github.com/users/adolfogc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adolfogc/subscriptions","organizations_url":"https://api.github.com/users/adolfogc/orgs","repos_url":"https://api.github.com/users/adolfogc/repos","events_url":"https://api.github.com/users/adolfogc/events{/privacy}","received_events_url":"https://api.github.com/users/adolfogc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adolfogc/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/adolfogc/nixpkgs","forks_url":"https://api.github.com/repos/adolfogc/nixpkgs/forks","keys_url":"https://api.github.com/repos/adolfogc/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adolfogc/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adolfogc/nixpkgs/teams","hooks_url":"https://api.github.com/repos/adolfogc/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/adolfogc/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/adolfogc/nixpkgs/events","assignees_url":"https://api.github.com/repos/adolfogc/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/adolfogc/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/adolfogc/nixpkgs/tags","blobs_url":"https://api.github.com/repos/adolfogc/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adolfogc/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adolfogc/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/adolfogc/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adolfogc/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/adolfogc/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/adolfogc/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/adolfogc/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/adolfogc/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/adolfogc/nixpkgs/subscription","commits_url":"https://api.github.com/repos/adolfogc/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/adolfogc/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/adolfogc/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/adolfogc/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/adolfogc/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/adolfogc/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adolfogc/nixpkgs/merges","archive_url":"https://api.github.com/repos/adolfogc/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adolfogc/nixpkgs/downloads","issues_url":"https://api.github.com/repos/adolfogc/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/adolfogc/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/adolfogc/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/adolfogc/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adolfogc/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/adolfogc/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/adolfogc/nixpkgs/deployments","created_at":"2016-07-12T02:54:05Z","updated_at":"2016-07-12T02:54:30Z","pushed_at":"2016-07-31T15:33:25Z","git_url":"git://github.com/adolfogc/nixpkgs.git","ssh_url":"git@github.com:adolfogc/nixpkgs.git","clone_url":"https://github.com/adolfogc/nixpkgs.git","svn_url":"https://github.com/adolfogc/nixpkgs","homepage":null,"size":378939,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"ac98cc4d94aa8956866acd1776676df66d9fe8e9","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-07-30T09:31:05Z","pushed_at":"2016-07-31T15:33:26Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":594024,"stargazers_count":1222,"watchers_count":1222,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1523,"mirror_url":null,"open_issues_count":1467,"forks":1523,"open_issues":1467,"watchers":1222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/17328"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/17328"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/17328/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17328/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/640a808dae6e13a555c2a5adbfaccd0b47759f13"}}}}
{"actor":{"display_login":"ttuegel"}}