{"action":"created","comment":{"url":"https://api.github.com/repos/krb5/krb5/pulls/comments/79458818","id":79458818,"diff_hunk":"@@ -443,4 +443,36 @@ krb5_c_random_make_octets(krb5_context context, krb5_data *outdata)\n     return 0;\n }\n \n+#ifdef _WIN32\n+#define BUFLEN 1024\n+#else\n+#define BUFLEN 64\n+#endif","path":"src/lib/crypto/krb/prng_fortuna.c","position":17,"original_position":17,"commit_id":"29f83640bf3a66eb6afda7132172ffaebf0c9d2d","original_commit_id":"29f83640bf3a66eb6afda7132172ffaebf0c9d2d","user":{"login":"greghudson","id":1131421,"avatar_url":"https://avatars.githubusercontent.com/u/1131421?v=3","gravatar_id":"","url":"https://api.github.com/users/greghudson","html_url":"https://github.com/greghudson","followers_url":"https://api.github.com/users/greghudson/followers","following_url":"https://api.github.com/users/greghudson/following{/other_user}","gists_url":"https://api.github.com/users/greghudson/gists{/gist_id}","starred_url":"https://api.github.com/users/greghudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greghudson/subscriptions","organizations_url":"https://api.github.com/users/greghudson/orgs","repos_url":"https://api.github.com/users/greghudson/repos","events_url":"https://api.github.com/users/greghudson/events{/privacy}","received_events_url":"https://api.github.com/users/greghudson/received_events","type":"User","site_admin":false},"body":"I see how this preserves the old behavior, but I don't like it.  I will talk through the changes with other team members tomorrow and see if we want to change this behavior (e.g. using a 64-byte buffer on Windows) or if maybe there's a simpler design.","created_at":"2016-09-19T18:35:10Z","updated_at":"2016-09-19T18:35:10Z","html_url":"https://github.com/krb5/krb5/pull/538#discussion_r79458818","pull_request_url":"https://api.github.com/repos/krb5/krb5/pulls/538","_links":{"self":{"href":"https://api.github.com/repos/krb5/krb5/pulls/comments/79458818"},"html":{"href":"https://github.com/krb5/krb5/pull/538#discussion_r79458818"},"pull_request":{"href":"https://api.github.com/repos/krb5/krb5/pulls/538"}}},"pull_request":{"url":"https://api.github.com/repos/krb5/krb5/pulls/538","id":84932445,"html_url":"https://github.com/krb5/krb5/pull/538","diff_url":"https://github.com/krb5/krb5/pull/538.diff","patch_url":"https://github.com/krb5/krb5/pull/538.patch","issue_url":"https://api.github.com/repos/krb5/krb5/issues/538","number":538,"state":"open","locked":false,"title":"Add getrandom() support","user":{"login":"frozencemetery","id":468294,"avatar_url":"https://avatars.githubusercontent.com/u/468294?v=3","gravatar_id":"","url":"https://api.github.com/users/frozencemetery","html_url":"https://github.com/frozencemetery","followers_url":"https://api.github.com/users/frozencemetery/followers","following_url":"https://api.github.com/users/frozencemetery/following{/other_user}","gists_url":"https://api.github.com/users/frozencemetery/gists{/gist_id}","starred_url":"https://api.github.com/users/frozencemetery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozencemetery/subscriptions","organizations_url":"https://api.github.com/users/frozencemetery/orgs","repos_url":"https://api.github.com/users/frozencemetery/repos","events_url":"https://api.github.com/users/frozencemetery/events{/privacy}","received_events_url":"https://api.github.com/users/frozencemetery/received_events","type":"User","site_admin":false},"body":"- First commit eliminates a codepath where we can Ouroboros urandom.\r\n- Second commit adds support for getrandom() to both OS and Fortuna PRNGs.\r\n\r\nOne thing I did not do here (but could) is move the urandom socket reuse code from prng_os.c to prng.c so that Fortuna could take advantage of it.  I don't know how much of an advantage this will be in practice.  (Reuse of the /dev/random socket seems over-aggressive.)\r\n\r\nI plan to backport this to 1.14, but as it adds features it is probably inappropriate for upstream 1.14-next.","created_at":"2016-09-12T19:47:49Z","updated_at":"2016-09-19T18:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a44fd37f6cf6a52b8c860e3e1947bab9cfa480e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/krb5/krb5/pulls/538/commits","review_comments_url":"https://api.github.com/repos/krb5/krb5/pulls/538/comments","review_comment_url":"https://api.github.com/repos/krb5/krb5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krb5/krb5/issues/538/comments","statuses_url":"https://api.github.com/repos/krb5/krb5/statuses/29f83640bf3a66eb6afda7132172ffaebf0c9d2d","head":{"label":"frozencemetery:modernize_random","ref":"modernize_random","sha":"29f83640bf3a66eb6afda7132172ffaebf0c9d2d","user":{"login":"frozencemetery","id":468294,"avatar_url":"https://avatars.githubusercontent.com/u/468294?v=3","gravatar_id":"","url":"https://api.github.com/users/frozencemetery","html_url":"https://github.com/frozencemetery","followers_url":"https://api.github.com/users/frozencemetery/followers","following_url":"https://api.github.com/users/frozencemetery/following{/other_user}","gists_url":"https://api.github.com/users/frozencemetery/gists{/gist_id}","starred_url":"https://api.github.com/users/frozencemetery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozencemetery/subscriptions","organizations_url":"https://api.github.com/users/frozencemetery/orgs","repos_url":"https://api.github.com/users/frozencemetery/repos","events_url":"https://api.github.com/users/frozencemetery/events{/privacy}","received_events_url":"https://api.github.com/users/frozencemetery/received_events","type":"User","site_admin":false},"repo":{"id":11589718,"name":"krb5","full_name":"frozencemetery/krb5","owner":{"login":"frozencemetery","id":468294,"avatar_url":"https://avatars.githubusercontent.com/u/468294?v=3","gravatar_id":"","url":"https://api.github.com/users/frozencemetery","html_url":"https://github.com/frozencemetery","followers_url":"https://api.github.com/users/frozencemetery/followers","following_url":"https://api.github.com/users/frozencemetery/following{/other_user}","gists_url":"https://api.github.com/users/frozencemetery/gists{/gist_id}","starred_url":"https://api.github.com/users/frozencemetery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozencemetery/subscriptions","organizations_url":"https://api.github.com/users/frozencemetery/orgs","repos_url":"https://api.github.com/users/frozencemetery/repos","events_url":"https://api.github.com/users/frozencemetery/events{/privacy}","received_events_url":"https://api.github.com/users/frozencemetery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frozencemetery/krb5","description":"This fork contains some packaging convenience branches as well as my own dev work","fork":true,"url":"https://api.github.com/repos/frozencemetery/krb5","forks_url":"https://api.github.com/repos/frozencemetery/krb5/forks","keys_url":"https://api.github.com/repos/frozencemetery/krb5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frozencemetery/krb5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frozencemetery/krb5/teams","hooks_url":"https://api.github.com/repos/frozencemetery/krb5/hooks","issue_events_url":"https://api.github.com/repos/frozencemetery/krb5/issues/events{/number}","events_url":"https://api.github.com/repos/frozencemetery/krb5/events","assignees_url":"https://api.github.com/repos/frozencemetery/krb5/assignees{/user}","branches_url":"https://api.github.com/repos/frozencemetery/krb5/branches{/branch}","tags_url":"https://api.github.com/repos/frozencemetery/krb5/tags","blobs_url":"https://api.github.com/repos/frozencemetery/krb5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frozencemetery/krb5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frozencemetery/krb5/git/refs{/sha}","trees_url":"https://api.github.com/repos/frozencemetery/krb5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frozencemetery/krb5/statuses/{sha}","languages_url":"https://api.github.com/repos/frozencemetery/krb5/languages","stargazers_url":"https://api.github.com/repos/frozencemetery/krb5/stargazers","contributors_url":"https://api.github.com/repos/frozencemetery/krb5/contributors","subscribers_url":"https://api.github.com/repos/frozencemetery/krb5/subscribers","subscription_url":"https://api.github.com/repos/frozencemetery/krb5/subscription","commits_url":"https://api.github.com/repos/frozencemetery/krb5/commits{/sha}","git_commits_url":"https://api.github.com/repos/frozencemetery/krb5/git/commits{/sha}","comments_url":"https://api.github.com/repos/frozencemetery/krb5/comments{/number}","issue_comment_url":"https://api.github.com/repos/frozencemetery/krb5/issues/comments{/number}","contents_url":"https://api.github.com/repos/frozencemetery/krb5/contents/{+path}","compare_url":"https://api.github.com/repos/frozencemetery/krb5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frozencemetery/krb5/merges","archive_url":"https://api.github.com/repos/frozencemetery/krb5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frozencemetery/krb5/downloads","issues_url":"https://api.github.com/repos/frozencemetery/krb5/issues{/number}","pulls_url":"https://api.github.com/repos/frozencemetery/krb5/pulls{/number}","milestones_url":"https://api.github.com/repos/frozencemetery/krb5/milestones{/number}","notifications_url":"https://api.github.com/repos/frozencemetery/krb5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frozencemetery/krb5/labels{/name}","releases_url":"https://api.github.com/repos/frozencemetery/krb5/releases{/id}","deployments_url":"https://api.github.com/repos/frozencemetery/krb5/deployments","created_at":"2013-07-22T19:02:54Z","updated_at":"2016-08-23T20:10:20Z","pushed_at":"2016-09-16T19:32:00Z","git_url":"git://github.com/frozencemetery/krb5.git","ssh_url":"git@github.com:frozencemetery/krb5.git","clone_url":"https://github.com/frozencemetery/krb5.git","svn_url":"https://github.com/frozencemetery/krb5","homepage":"","size":74596,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"krb5:master","ref":"master","sha":"9c18f6c93b602ec69ca2640e27ab2ccbb7f45a3c","user":{"login":"krb5","id":523797,"avatar_url":"https://avatars.githubusercontent.com/u/523797?v=3","gravatar_id":"","url":"https://api.github.com/users/krb5","html_url":"https://github.com/krb5","followers_url":"https://api.github.com/users/krb5/followers","following_url":"https://api.github.com/users/krb5/following{/other_user}","gists_url":"https://api.github.com/users/krb5/gists{/gist_id}","starred_url":"https://api.github.com/users/krb5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krb5/subscriptions","organizations_url":"https://api.github.com/users/krb5/orgs","repos_url":"https://api.github.com/users/krb5/repos","events_url":"https://api.github.com/users/krb5/events{/privacy}","received_events_url":"https://api.github.com/users/krb5/received_events","type":"Organization","site_admin":false},"repo":{"id":4307702,"name":"krb5","full_name":"krb5/krb5","owner":{"login":"krb5","id":523797,"avatar_url":"https://avatars.githubusercontent.com/u/523797?v=3","gravatar_id":"","url":"https://api.github.com/users/krb5","html_url":"https://github.com/krb5","followers_url":"https://api.github.com/users/krb5/followers","following_url":"https://api.github.com/users/krb5/following{/other_user}","gists_url":"https://api.github.com/users/krb5/gists{/gist_id}","starred_url":"https://api.github.com/users/krb5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krb5/subscriptions","organizations_url":"https://api.github.com/users/krb5/orgs","repos_url":"https://api.github.com/users/krb5/repos","events_url":"https://api.github.com/users/krb5/events{/privacy}","received_events_url":"https://api.github.com/users/krb5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krb5/krb5","description":"mirror of MIT krb5 repository","fork":false,"url":"https://api.github.com/repos/krb5/krb5","forks_url":"https://api.github.com/repos/krb5/krb5/forks","keys_url":"https://api.github.com/repos/krb5/krb5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krb5/krb5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krb5/krb5/teams","hooks_url":"https://api.github.com/repos/krb5/krb5/hooks","issue_events_url":"https://api.github.com/repos/krb5/krb5/issues/events{/number}","events_url":"https://api.github.com/repos/krb5/krb5/events","assignees_url":"https://api.github.com/repos/krb5/krb5/assignees{/user}","branches_url":"https://api.github.com/repos/krb5/krb5/branches{/branch}","tags_url":"https://api.github.com/repos/krb5/krb5/tags","blobs_url":"https://api.github.com/repos/krb5/krb5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krb5/krb5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krb5/krb5/git/refs{/sha}","trees_url":"https://api.github.com/repos/krb5/krb5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krb5/krb5/statuses/{sha}","languages_url":"https://api.github.com/repos/krb5/krb5/languages","stargazers_url":"https://api.github.com/repos/krb5/krb5/stargazers","contributors_url":"https://api.github.com/repos/krb5/krb5/contributors","subscribers_url":"https://api.github.com/repos/krb5/krb5/subscribers","subscription_url":"https://api.github.com/repos/krb5/krb5/subscription","commits_url":"https://api.github.com/repos/krb5/krb5/commits{/sha}","git_commits_url":"https://api.github.com/repos/krb5/krb5/git/commits{/sha}","comments_url":"https://api.github.com/repos/krb5/krb5/comments{/number}","issue_comment_url":"https://api.github.com/repos/krb5/krb5/issues/comments{/number}","contents_url":"https://api.github.com/repos/krb5/krb5/contents/{+path}","compare_url":"https://api.github.com/repos/krb5/krb5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krb5/krb5/merges","archive_url":"https://api.github.com/repos/krb5/krb5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krb5/krb5/downloads","issues_url":"https://api.github.com/repos/krb5/krb5/issues{/number}","pulls_url":"https://api.github.com/repos/krb5/krb5/pulls{/number}","milestones_url":"https://api.github.com/repos/krb5/krb5/milestones{/number}","notifications_url":"https://api.github.com/repos/krb5/krb5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krb5/krb5/labels{/name}","releases_url":"https://api.github.com/repos/krb5/krb5/releases{/id}","deployments_url":"https://api.github.com/repos/krb5/krb5/deployments","created_at":"2012-05-12T16:01:32Z","updated_at":"2016-09-04T19:07:29Z","pushed_at":"2016-09-19T16:31:16Z","git_url":"git://github.com/krb5/krb5.git","ssh_url":"git@github.com:krb5/krb5.git","clone_url":"https://github.com/krb5/krb5.git","svn_url":"https://github.com/krb5/krb5","homepage":null,"size":79985,"stargazers_count":109,"watchers_count":109,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":14,"forks":124,"open_issues":14,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krb5/krb5/pulls/538"},"html":{"href":"https://github.com/krb5/krb5/pull/538"},"issue":{"href":"https://api.github.com/repos/krb5/krb5/issues/538"},"comments":{"href":"https://api.github.com/repos/krb5/krb5/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/krb5/krb5/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/krb5/krb5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krb5/krb5/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/krb5/krb5/statuses/29f83640bf3a66eb6afda7132172ffaebf0c9d2d"}}}}
{"actor":{"display_login":"greghudson"}}