{"action":"closed","number":95,"pull_request":{"url":"https://api.github.com/repos/sofa-framework/sofa/pulls/95","id":97019768,"html_url":"https://github.com/sofa-framework/sofa/pull/95","diff_url":"https://github.com/sofa-framework/sofa/pull/95.diff","patch_url":"https://github.com/sofa-framework/sofa/pull/95.patch","issue_url":"https://api.github.com/repos/sofa-framework/sofa/issues/95","number":95,"state":"closed","locked":false,"title":"Remove testmessagehandler","user":{"login":"damienmarchal","id":12644882,"avatar_url":"https://avatars.githubusercontent.com/u/12644882?v=3","gravatar_id":"","url":"https://api.github.com/users/damienmarchal","html_url":"https://github.com/damienmarchal","followers_url":"https://api.github.com/users/damienmarchal/followers","following_url":"https://api.github.com/users/damienmarchal/following{/other_user}","gists_url":"https://api.github.com/users/damienmarchal/gists{/gist_id}","starred_url":"https://api.github.com/users/damienmarchal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienmarchal/subscriptions","organizations_url":"https://api.github.com/users/damienmarchal/orgs","repos_url":"https://api.github.com/users/damienmarchal/repos","events_url":"https://api.github.com/users/damienmarchal/events{/privacy}","received_events_url":"https://api.github.com/users/damienmarchal/received_events","type":"User","site_admin":false},"body":"This PR is a proposal to remove the TestMessageHandler as it was discussed during the today's meeting (connected to this https://github.com/sofa-framework/sofa/issues/94). \r\n\r\nThe thing was that the TestMessageHandler class is more or less included in the behavior of the ExpectMessage & MessageAsTestFailure so it make sense to remove it.\r\n\r\nPlease tell me if some scenario of yours cannot be handled nicely with the ExpectMessage & MessageAsTestFailure so that I can update their API.\r\n\r\nThe handlers needed by the ExpectMessage & MessageAsTestFailure are now installed by default. \r\n\r\nThe tests using the TestMessageHandler class have been fixed to use the ExpectMessage&MessageAsTestFailure. \r\n\r\nA bug in LoggingMessageHandler.h has also been corrected.  ","created_at":"2016-12-07T22:21:43Z","updated_at":"2016-12-07T22:25:33Z","closed_at":"2016-12-07T22:25:33Z","merged_at":null,"merge_commit_sha":"e5c87b92f3574a12583fa32906aea81d828c18ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/95/commits","review_comments_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/95/comments","review_comment_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/issues/95/comments","statuses_url":"https://api.github.com/repos/sofa-framework/sofa/statuses/3eac2949930fae998cae606f13b6fdf45ac4a023","head":{"label":"SofaDefrost:remove_testmessagehandler","ref":"remove_testmessagehandler","sha":"3eac2949930fae998cae606f13b6fdf45ac4a023","user":{"login":"SofaDefrost","id":23094510,"avatar_url":"https://avatars.githubusercontent.com/u/23094510?v=3","gravatar_id":"","url":"https://api.github.com/users/SofaDefrost","html_url":"https://github.com/SofaDefrost","followers_url":"https://api.github.com/users/SofaDefrost/followers","following_url":"https://api.github.com/users/SofaDefrost/following{/other_user}","gists_url":"https://api.github.com/users/SofaDefrost/gists{/gist_id}","starred_url":"https://api.github.com/users/SofaDefrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofaDefrost/subscriptions","organizations_url":"https://api.github.com/users/SofaDefrost/orgs","repos_url":"https://api.github.com/users/SofaDefrost/repos","events_url":"https://api.github.com/users/SofaDefrost/events{/privacy}","received_events_url":"https://api.github.com/users/SofaDefrost/received_events","type":"Organization","site_admin":false},"repo":{"id":72085159,"name":"sofa","full_name":"SofaDefrost/sofa","owner":{"login":"SofaDefrost","id":23094510,"avatar_url":"https://avatars.githubusercontent.com/u/23094510?v=3","gravatar_id":"","url":"https://api.github.com/users/SofaDefrost","html_url":"https://github.com/SofaDefrost","followers_url":"https://api.github.com/users/SofaDefrost/followers","following_url":"https://api.github.com/users/SofaDefrost/following{/other_user}","gists_url":"https://api.github.com/users/SofaDefrost/gists{/gist_id}","starred_url":"https://api.github.com/users/SofaDefrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SofaDefrost/subscriptions","organizations_url":"https://api.github.com/users/SofaDefrost/orgs","repos_url":"https://api.github.com/users/SofaDefrost/repos","events_url":"https://api.github.com/users/SofaDefrost/events{/privacy}","received_events_url":"https://api.github.com/users/SofaDefrost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SofaDefrost/sofa","description":"SOFA, open source framework for multi-physics simulation.","fork":true,"url":"https://api.github.com/repos/SofaDefrost/sofa","forks_url":"https://api.github.com/repos/SofaDefrost/sofa/forks","keys_url":"https://api.github.com/repos/SofaDefrost/sofa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SofaDefrost/sofa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SofaDefrost/sofa/teams","hooks_url":"https://api.github.com/repos/SofaDefrost/sofa/hooks","issue_events_url":"https://api.github.com/repos/SofaDefrost/sofa/issues/events{/number}","events_url":"https://api.github.com/repos/SofaDefrost/sofa/events","assignees_url":"https://api.github.com/repos/SofaDefrost/sofa/assignees{/user}","branches_url":"https://api.github.com/repos/SofaDefrost/sofa/branches{/branch}","tags_url":"https://api.github.com/repos/SofaDefrost/sofa/tags","blobs_url":"https://api.github.com/repos/SofaDefrost/sofa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SofaDefrost/sofa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SofaDefrost/sofa/git/refs{/sha}","trees_url":"https://api.github.com/repos/SofaDefrost/sofa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SofaDefrost/sofa/statuses/{sha}","languages_url":"https://api.github.com/repos/SofaDefrost/sofa/languages","stargazers_url":"https://api.github.com/repos/SofaDefrost/sofa/stargazers","contributors_url":"https://api.github.com/repos/SofaDefrost/sofa/contributors","subscribers_url":"https://api.github.com/repos/SofaDefrost/sofa/subscribers","subscription_url":"https://api.github.com/repos/SofaDefrost/sofa/subscription","commits_url":"https://api.github.com/repos/SofaDefrost/sofa/commits{/sha}","git_commits_url":"https://api.github.com/repos/SofaDefrost/sofa/git/commits{/sha}","comments_url":"https://api.github.com/repos/SofaDefrost/sofa/comments{/number}","issue_comment_url":"https://api.github.com/repos/SofaDefrost/sofa/issues/comments{/number}","contents_url":"https://api.github.com/repos/SofaDefrost/sofa/contents/{+path}","compare_url":"https://api.github.com/repos/SofaDefrost/sofa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SofaDefrost/sofa/merges","archive_url":"https://api.github.com/repos/SofaDefrost/sofa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SofaDefrost/sofa/downloads","issues_url":"https://api.github.com/repos/SofaDefrost/sofa/issues{/number}","pulls_url":"https://api.github.com/repos/SofaDefrost/sofa/pulls{/number}","milestones_url":"https://api.github.com/repos/SofaDefrost/sofa/milestones{/number}","notifications_url":"https://api.github.com/repos/SofaDefrost/sofa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SofaDefrost/sofa/labels{/name}","releases_url":"https://api.github.com/repos/SofaDefrost/sofa/releases{/id}","deployments_url":"https://api.github.com/repos/SofaDefrost/sofa/deployments","created_at":"2016-10-27T08:01:49Z","updated_at":"2016-10-27T08:02:18Z","pushed_at":"2016-12-07T22:14:11Z","git_url":"git://github.com/SofaDefrost/sofa.git","ssh_url":"git@github.com:SofaDefrost/sofa.git","clone_url":"https://github.com/SofaDefrost/sofa.git","svn_url":"https://github.com/SofaDefrost/sofa","homepage":"https://www.sofa-framework.org","size":282588,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sofa-framework:master","ref":"master","sha":"a7ea7baed63bbcc30622d111d3237975a540839e","user":{"login":"sofa-framework","id":11028508,"avatar_url":"https://avatars.githubusercontent.com/u/11028508?v=3","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":60089478,"name":"sofa","full_name":"sofa-framework/sofa","owner":{"login":"sofa-framework","id":11028508,"avatar_url":"https://avatars.githubusercontent.com/u/11028508?v=3","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sofa-framework/sofa","description":"Real-time multi-physics simulation with an emphasis on medical simulation.","fork":false,"url":"https://api.github.com/repos/sofa-framework/sofa","forks_url":"https://api.github.com/repos/sofa-framework/sofa/forks","keys_url":"https://api.github.com/repos/sofa-framework/sofa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sofa-framework/sofa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sofa-framework/sofa/teams","hooks_url":"https://api.github.com/repos/sofa-framework/sofa/hooks","issue_events_url":"https://api.github.com/repos/sofa-framework/sofa/issues/events{/number}","events_url":"https://api.github.com/repos/sofa-framework/sofa/events","assignees_url":"https://api.github.com/repos/sofa-framework/sofa/assignees{/user}","branches_url":"https://api.github.com/repos/sofa-framework/sofa/branches{/branch}","tags_url":"https://api.github.com/repos/sofa-framework/sofa/tags","blobs_url":"https://api.github.com/repos/sofa-framework/sofa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sofa-framework/sofa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sofa-framework/sofa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sofa-framework/sofa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sofa-framework/sofa/statuses/{sha}","languages_url":"https://api.github.com/repos/sofa-framework/sofa/languages","stargazers_url":"https://api.github.com/repos/sofa-framework/sofa/stargazers","contributors_url":"https://api.github.com/repos/sofa-framework/sofa/contributors","subscribers_url":"https://api.github.com/repos/sofa-framework/sofa/subscribers","subscription_url":"https://api.github.com/repos/sofa-framework/sofa/subscription","commits_url":"https://api.github.com/repos/sofa-framework/sofa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sofa-framework/sofa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sofa-framework/sofa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sofa-framework/sofa/contents/{+path}","compare_url":"https://api.github.com/repos/sofa-framework/sofa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sofa-framework/sofa/merges","archive_url":"https://api.github.com/repos/sofa-framework/sofa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sofa-framework/sofa/downloads","issues_url":"https://api.github.com/repos/sofa-framework/sofa/issues{/number}","pulls_url":"https://api.github.com/repos/sofa-framework/sofa/pulls{/number}","milestones_url":"https://api.github.com/repos/sofa-framework/sofa/milestones{/number}","notifications_url":"https://api.github.com/repos/sofa-framework/sofa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sofa-framework/sofa/labels{/name}","releases_url":"https://api.github.com/repos/sofa-framework/sofa/releases{/id}","deployments_url":"https://api.github.com/repos/sofa-framework/sofa/deployments","created_at":"2016-05-31T12:57:59Z","updated_at":"2016-11-28T23:56:48Z","pushed_at":"2016-12-07T22:21:43Z","git_url":"git://github.com/sofa-framework/sofa.git","ssh_url":"git@github.com:sofa-framework/sofa.git","clone_url":"https://github.com/sofa-framework/sofa.git","svn_url":"https://github.com/sofa-framework/sofa","homepage":"https://www.sofa-framework.org","size":306127,"stargazers_count":36,"watchers_count":36,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":43,"forks":33,"open_issues":43,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/95"},"html":{"href":"https://github.com/sofa-framework/sofa/pull/95"},"issue":{"href":"https://api.github.com/repos/sofa-framework/sofa/issues/95"},"comments":{"href":"https://api.github.com/repos/sofa-framework/sofa/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/sofa-framework/sofa/statuses/3eac2949930fae998cae606f13b6fdf45ac4a023"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":28,"additions":965,"deletions":83,"changed_files":16}}
{"actor":{"display_login":"damienmarchal"}}