{"action":"opened","number":9501,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9501","id":75593277,"html_url":"https://github.com/ManageIQ/manageiq/pull/9501","diff_url":"https://github.com/ManageIQ/manageiq/pull/9501.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9501.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9501","number":9501,"state":"open","locked":false,"title":"Toolbar i18n","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"body":"Purpose or Intent:\r\n-----------------\r\nFind a way to do proper i18n on interpolated strings in toolbar buttons.\r\n\r\nProblem:\r\n--------\r\nCurrently i18n does not work for toolbar strings with interpolation. The strings contain interpolation of controller variables that is expanded via `eval` the result is passed through gettext. The interpolations include calls to `ui_lookup`. As result, these produce correct result only for English and only by accident.\r\n\r\nHowto fix it:\r\n-------------\r\n1. Collect the correct strings for the catalog. According to the i18n gudelines.\r\n1. The translation needs to be done at render time with the proper locale set.\r\n1. The controller variables and `ui_lookup*` calls need to be evaluated with the proper locale in the proper context.\r\n\r\nTODO:\r\n-----\r\n1. convert all toolbars -- might be better with separate PRs\r\n1. remove `eval` calls\r\n1. update catalogs","created_at":"2016-06-29T06:12:40Z","updated_at":"2016-06-29T06:12:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaf19238114f7c6f185030664c4400712a32cd63","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9501/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9501/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9501/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/686c253dd833e83b418e0444bd2d316773051015","head":{"label":"martinpovolny:toolbar_i18n","ref":"toolbar_i18n","sha":"686c253dd833e83b418e0444bd2d316773051015","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"repo":{"id":20877847,"name":"manageiq","full_name":"martinpovolny/manageiq","owner":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinpovolny/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/martinpovolny/manageiq","forks_url":"https://api.github.com/repos/martinpovolny/manageiq/forks","keys_url":"https://api.github.com/repos/martinpovolny/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinpovolny/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinpovolny/manageiq/teams","hooks_url":"https://api.github.com/repos/martinpovolny/manageiq/hooks","issue_events_url":"https://api.github.com/repos/martinpovolny/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/martinpovolny/manageiq/events","assignees_url":"https://api.github.com/repos/martinpovolny/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/martinpovolny/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/martinpovolny/manageiq/tags","blobs_url":"https://api.github.com/repos/martinpovolny/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinpovolny/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinpovolny/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinpovolny/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinpovolny/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/martinpovolny/manageiq/languages","stargazers_url":"https://api.github.com/repos/martinpovolny/manageiq/stargazers","contributors_url":"https://api.github.com/repos/martinpovolny/manageiq/contributors","subscribers_url":"https://api.github.com/repos/martinpovolny/manageiq/subscribers","subscription_url":"https://api.github.com/repos/martinpovolny/manageiq/subscription","commits_url":"https://api.github.com/repos/martinpovolny/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinpovolny/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinpovolny/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinpovolny/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinpovolny/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/martinpovolny/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinpovolny/manageiq/merges","archive_url":"https://api.github.com/repos/martinpovolny/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinpovolny/manageiq/downloads","issues_url":"https://api.github.com/repos/martinpovolny/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/martinpovolny/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/martinpovolny/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/martinpovolny/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinpovolny/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/martinpovolny/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/martinpovolny/manageiq/deployments","created_at":"2014-06-16T08:30:21Z","updated_at":"2016-01-21T14:43:22Z","pushed_at":"2016-06-29T06:03:50Z","git_url":"git://github.com/martinpovolny/manageiq.git","ssh_url":"git@github.com:martinpovolny/manageiq.git","clone_url":"https://github.com/martinpovolny/manageiq.git","svn_url":"https://github.com/martinpovolny/manageiq","homepage":null,"size":148021,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"49dd81ff365f853afd612c905c7301dd5811b6e0","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-06-27T06:06:21Z","pushed_at":"2016-06-29T06:12:41Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":173020,"stargazers_count":287,"watchers_count":287,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":315,"mirror_url":null,"open_issues_count":727,"forks":315,"open_issues":727,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9501"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9501"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9501"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9501/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9501/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9501/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/686c253dd833e83b418e0444bd2d316773051015"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":24,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"martinpovolny"}}