{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/92221679","pull_request_review_id":12733122,"id":92221679,"diff_hunk":"@@ -3189,23 +3180,22 @@ public function doLogout() {\n \t * @todo Only rarely do all these fields need to be set!\n \t */\n \tpublic function saveSettings() {\n-\t\tglobal $wgAuth;\n \t\t$this->load();\n-\t\tif ( wfReadOnly() ) { return; }\n-\t\tif ( 0 == $this->mId ) { return; }\n+\t\tif ( wfReadOnly() ) {\n+\t\t\treturn;\n+\t\t}\n+\t\tif ( 0 == $this->mId ) {\n+\t\t\treturn;\n+\t\t}\n \n \t\t$this->mTouched = self::newTouchedTimestamp();\n-\t\tif ( !$wgAuth->allowSetLocalPassword() ) {\n-\t\t\t$this->mPassword = '';\n-\t\t}\n \n \t\twfRunHooks( 'BeforeUserSaveSettings', array( $this ) );\n \n \t\t$dbw = wfGetDB( DB_MASTER );\n \t\t$dbw->update( 'user',\n \t\t\tarray( /* SET */\n \t\t\t\t'user_name' => $this->mName,\n-\t\t\t\t'user_password' => $this->mPassword,\n \t\t\t\t'user_newpassword' => $this->mNewpassword,","path":"includes/User.php","position":414,"original_position":414,"commit_id":"19f9a721b1d03484c528a6e147db421a1955d5b3","original_commit_id":"19f9a721b1d03484c528a6e147db421a1955d5b3","user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"body":"![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) Define a constant instead of duplicating this literal \"user_newpassword\" 3 times. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=php%3AS1192)\n","created_at":"2016-12-13T17:29:13Z","updated_at":"2016-12-13T17:29:13Z","html_url":"https://github.com/Wikia/app/pull/11783#discussion_r92221679","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/11783","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/92221679"},"html":{"href":"https://github.com/Wikia/app/pull/11783#discussion_r92221679"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/11783"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/11783","id":92325519,"html_url":"https://github.com/Wikia/app/pull/11783","diff_url":"https://github.com/Wikia/app/pull/11783.diff","patch_url":"https://github.com/Wikia/app/pull/11783.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/11783","number":11783,"state":"open","locked":false,"title":"PLATFORM-2540 implementing new hashing via helios","user":{"login":"pgrabowski-wikia","id":20514390,"avatar_url":"https://avatars.githubusercontent.com/u/20514390?v=3","gravatar_id":"","url":"https://api.github.com/users/pgrabowski-wikia","html_url":"https://github.com/pgrabowski-wikia","followers_url":"https://api.github.com/users/pgrabowski-wikia/followers","following_url":"https://api.github.com/users/pgrabowski-wikia/following{/other_user}","gists_url":"https://api.github.com/users/pgrabowski-wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/pgrabowski-wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgrabowski-wikia/subscriptions","organizations_url":"https://api.github.com/users/pgrabowski-wikia/orgs","repos_url":"https://api.github.com/users/pgrabowski-wikia/repos","events_url":"https://api.github.com/users/pgrabowski-wikia/events{/privacy}","received_events_url":"https://api.github.com/users/pgrabowski-wikia/received_events","type":"User","site_admin":false},"body":"https://wikia-inc.atlassian.net/browse/PLATFORM-2540","created_at":"2016-11-04T11:43:54Z","updated_at":"2016-12-13T17:29:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fd6a8c5a6fd4c064132ed5f7845b2d6c8ccde0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/11783/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/11783/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/11783/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/19f9a721b1d03484c528a6e147db421a1955d5b3","head":{"label":"Wikia:PLATFORM-2540","ref":"PLATFORM-2540","sha":"19f9a721b1d03484c528a6e147db421a1955d5b3","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-12-03T22:51:32Z","pushed_at":"2016-12-13T17:28:30Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":720814,"stargazers_count":107,"watchers_count":107,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":113,"forks":85,"open_issues":113,"watchers":107,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"4f486ed93eda756a6b637f0519edf2937248935d","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2016-12-03T22:51:32Z","pushed_at":"2016-12-13T17:28:30Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":720814,"stargazers_count":107,"watchers_count":107,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":113,"forks":85,"open_issues":113,"watchers":107,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/11783"},"html":{"href":"https://github.com/Wikia/app/pull/11783"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/11783"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/11783/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/11783/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/11783/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/19f9a721b1d03484c528a6e147db421a1955d5b3"}}}}
{"actor":{"display_login":"WikiaTech"}}