{"action":"created","issue":{"url":"https://api.github.com/repos/oracle/node-oracledb/issues/321","repository_url":"https://api.github.com/repos/oracle/node-oracledb","labels_url":"https://api.github.com/repos/oracle/node-oracledb/issues/321/labels{/name}","comments_url":"https://api.github.com/repos/oracle/node-oracledb/issues/321/comments","events_url":"https://api.github.com/repos/oracle/node-oracledb/issues/321/events","html_url":"https://github.com/oracle/node-oracledb/pull/321","id":126156833,"number":321,"title":"Support for streaming results for queries via new option (stream=true)","user":{"login":"sagiegurari","id":8112599,"avatar_url":"https://avatars.githubusercontent.com/u/8112599?v=3","gravatar_id":"","url":"https://api.github.com/users/sagiegurari","html_url":"https://github.com/sagiegurari","followers_url":"https://api.github.com/users/sagiegurari/followers","following_url":"https://api.github.com/users/sagiegurari/following{/other_user}","gists_url":"https://api.github.com/users/sagiegurari/gists{/gist_id}","starred_url":"https://api.github.com/users/sagiegurari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagiegurari/subscriptions","organizations_url":"https://api.github.com/users/sagiegurari/orgs","repos_url":"https://api.github.com/users/sagiegurari/repos","events_url":"https://api.github.com/users/sagiegurari/events{/privacy}","received_events_url":"https://api.github.com/users/sagiegurari/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":75,"created_at":"2016-01-12T11:18:42Z","updated_at":"2016-03-09T06:20:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/oracle/node-oracledb/pulls/321","html_url":"https://github.com/oracle/node-oracledb/pull/321","diff_url":"https://github.com/oracle/node-oracledb/pull/321.diff","patch_url":"https://github.com/oracle/node-oracledb/pull/321.patch"},"body":"This pull requests provides ability to stream query results but also provides 2 more additional items:\r\n1. ability to extend the connection object via javascript. most nodejs developers won't want to develop in C++ i believe and with this change now they can contribute to the oracledb library via js.\r\nThis could help a lot to this project and should provide a lot more contributions.\r\n2. editorconfig file since the standards in this project is a bit different than most js projects."},"comment":{"url":"https://api.github.com/repos/oracle/node-oracledb/issues/comments/194134015","html_url":"https://github.com/oracle/node-oracledb/pull/321#issuecomment-194134015","issue_url":"https://api.github.com/repos/oracle/node-oracledb/issues/321","id":194134015,"user":{"login":"sagiegurari","id":8112599,"avatar_url":"https://avatars.githubusercontent.com/u/8112599?v=3","gravatar_id":"","url":"https://api.github.com/users/sagiegurari","html_url":"https://github.com/sagiegurari","followers_url":"https://api.github.com/users/sagiegurari/followers","following_url":"https://api.github.com/users/sagiegurari/following{/other_user}","gists_url":"https://api.github.com/users/sagiegurari/gists{/gist_id}","starred_url":"https://api.github.com/users/sagiegurari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagiegurari/subscriptions","organizations_url":"https://api.github.com/users/sagiegurari/orgs","repos_url":"https://api.github.com/users/sagiegurari/repos","events_url":"https://api.github.com/users/sagiegurari/events{/privacy}","received_events_url":"https://api.github.com/users/sagiegurari/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T06:20:02Z","updated_at":"2016-03-09T06:20:02Z","body":"Thanks, I am going to test it, just a bit busy lately, but logically it should not work.\r\n\r\nAs for the execute with flag or new function, I don't have a strong opinion about that, I preferred 1 smart execute function (like in simple-oracledb connection.query) but since it is not my project, I'll let you, chris and others decide."}}