{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/4072","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/4072/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4072/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/4072/events","html_url":"https://github.com/ampproject/amphtml/pull/4072","id":165636162,"number":4072,"title":"Added element-level overrides for variables for amp-analytics","user":{"login":"rajkumarsrk","id":691176,"avatar_url":"https://avatars.githubusercontent.com/u/691176?v=3","gravatar_id":"","url":"https://api.github.com/users/rajkumarsrk","html_url":"https://github.com/rajkumarsrk","followers_url":"https://api.github.com/users/rajkumarsrk/followers","following_url":"https://api.github.com/users/rajkumarsrk/following{/other_user}","gists_url":"https://api.github.com/users/rajkumarsrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rajkumarsrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajkumarsrk/subscriptions","organizations_url":"https://api.github.com/users/rajkumarsrk/orgs","repos_url":"https://api.github.com/users/rajkumarsrk/repos","events_url":"https://api.github.com/users/rajkumarsrk/events{/privacy}","received_events_url":"https://api.github.com/users/rajkumarsrk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ampproject/amphtml/labels/LGTM","name":"LGTM","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false},"assignees":[{"login":"avimehta","id":179359,"avatar_url":"https://avatars.githubusercontent.com/u/179359?v=3","gravatar_id":"","url":"https://api.github.com/users/avimehta","html_url":"https://github.com/avimehta","followers_url":"https://api.github.com/users/avimehta/followers","following_url":"https://api.github.com/users/avimehta/following{/other_user}","gists_url":"https://api.github.com/users/avimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/avimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avimehta/subscriptions","organizations_url":"https://api.github.com/users/avimehta/orgs","repos_url":"https://api.github.com/users/avimehta/repos","events_url":"https://api.github.com/users/avimehta/events{/privacy}","received_events_url":"https://api.github.com/users/avimehta/received_events","type":"User","site_admin":false}],"milestone":null,"comments":29,"created_at":"2016-07-14T19:11:53Z","updated_at":"2016-08-16T13:31:07Z","closed_at":"2016-08-08T21:20:58Z","pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4072","html_url":"https://github.com/ampproject/amphtml/pull/4072","diff_url":"https://github.com/ampproject/amphtml/pull/4072.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4072.patch"},"body":"Adding element level overrides for amp-analytics variable based on the discussion that we had\r\nhttps://github.com/ampproject/amphtml/issues/1298#issuecomment-226036199.\r\nPlease review it and let me know your feedback\r\n\r\n@avimehta @cramforce Could you suggest best place where I can update the documentation for this.\r\nI was thinking to add it here\r\nhttps://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/amp-analytics.md#vars. But will wait for you inputs\r\n"},"comment":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/comments/240101900","html_url":"https://github.com/ampproject/amphtml/pull/4072#issuecomment-240101900","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4072","id":240101900,"user":{"login":"rudygalfi","id":3888212,"avatar_url":"https://avatars.githubusercontent.com/u/3888212?v=3","gravatar_id":"","url":"https://api.github.com/users/rudygalfi","html_url":"https://github.com/rudygalfi","followers_url":"https://api.github.com/users/rudygalfi/followers","following_url":"https://api.github.com/users/rudygalfi/following{/other_user}","gists_url":"https://api.github.com/users/rudygalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/rudygalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudygalfi/subscriptions","organizations_url":"https://api.github.com/users/rudygalfi/orgs","repos_url":"https://api.github.com/users/rudygalfi/repos","events_url":"https://api.github.com/users/rudygalfi/events{/privacy}","received_events_url":"https://api.github.com/users/rudygalfi/received_events","type":"User","site_admin":false},"created_at":"2016-08-16T13:31:07Z","updated_at":"2016-08-16T13:31:07Z","body":"@rajkumarsrk I believe this made it into last week's canary build. That means it should be in production by this Friday the 19th.\r\n\r\nYou can target's AMP's canary build if you want to try it out. Opt into the dev channel (first option) on this page: https://cdn.ampproject.org/experiments.html."}}
{"actor":{"display_login":"rudygalfi"}}