{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/16","id":88351723,"html_url":"https://github.com/catheraaine/risk-legacy/pull/16","diff_url":"https://github.com/catheraaine/risk-legacy/pull/16.diff","patch_url":"https://github.com/catheraaine/risk-legacy/pull/16.patch","issue_url":"https://api.github.com/repos/catheraaine/risk-legacy/issues/16","number":16,"state":"closed","locked":false,"title":"A little bit of refactoring (#2, #3)","user":{"login":"MoonlightOwl","id":7950282,"avatar_url":"https://avatars.githubusercontent.com/u/7950282?v=3","gravatar_id":"","url":"https://api.github.com/users/MoonlightOwl","html_url":"https://github.com/MoonlightOwl","followers_url":"https://api.github.com/users/MoonlightOwl/followers","following_url":"https://api.github.com/users/MoonlightOwl/following{/other_user}","gists_url":"https://api.github.com/users/MoonlightOwl/gists{/gist_id}","starred_url":"https://api.github.com/users/MoonlightOwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoonlightOwl/subscriptions","organizations_url":"https://api.github.com/users/MoonlightOwl/orgs","repos_url":"https://api.github.com/users/MoonlightOwl/repos","events_url":"https://api.github.com/users/MoonlightOwl/events{/privacy}","received_events_url":"https://api.github.com/users/MoonlightOwl/received_events","type":"User","site_admin":false},"body":"Here I tried to improve, shorten and structure the code.\r\n\r\n1) Added `.gitignore` file. It excludes project files of IDE's like WebStorm (just in case), a `ref/` directory (for files that can be useful while developing, but doesn't need to appear in Git), and OS-specific files.\r\n2) Moved `*.css` files to `css/` dir.\r\n3) Improved \"page reloading\" code. =)\r\n4) Moved SVG code to separate file. I think it can be done better, however... need to think about it.\r\n5) Labels need to be linked with `for` to an `id` property, not `name`\r\n6) \"Dried\" a bit `contry-name.js`. Now it is a bit more readable, and less errors prone\r\n=)","created_at":"2016-10-06T22:20:21Z","updated_at":"2016-10-07T20:02:58Z","closed_at":"2016-10-07T20:02:58Z","merged_at":"2016-10-07T20:02:58Z","merge_commit_sha":"7a440351f2e72afda8c423a19ef7801c7ca3caa6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/16/commits","review_comments_url":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/16/comments","review_comment_url":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/catheraaine/risk-legacy/issues/16/comments","statuses_url":"https://api.github.com/repos/catheraaine/risk-legacy/statuses/660cb52af418a899002b7abbea3c4770e309f027","head":{"label":"MoonlightOwl:master","ref":"master","sha":"660cb52af418a899002b7abbea3c4770e309f027","user":{"login":"MoonlightOwl","id":7950282,"avatar_url":"https://avatars.githubusercontent.com/u/7950282?v=3","gravatar_id":"","url":"https://api.github.com/users/MoonlightOwl","html_url":"https://github.com/MoonlightOwl","followers_url":"https://api.github.com/users/MoonlightOwl/followers","following_url":"https://api.github.com/users/MoonlightOwl/following{/other_user}","gists_url":"https://api.github.com/users/MoonlightOwl/gists{/gist_id}","starred_url":"https://api.github.com/users/MoonlightOwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoonlightOwl/subscriptions","organizations_url":"https://api.github.com/users/MoonlightOwl/orgs","repos_url":"https://api.github.com/users/MoonlightOwl/repos","events_url":"https://api.github.com/users/MoonlightOwl/events{/privacy}","received_events_url":"https://api.github.com/users/MoonlightOwl/received_events","type":"User","site_admin":false},"repo":{"id":70196959,"name":"risk-legacy","full_name":"MoonlightOwl/risk-legacy","owner":{"login":"MoonlightOwl","id":7950282,"avatar_url":"https://avatars.githubusercontent.com/u/7950282?v=3","gravatar_id":"","url":"https://api.github.com/users/MoonlightOwl","html_url":"https://github.com/MoonlightOwl","followers_url":"https://api.github.com/users/MoonlightOwl/followers","following_url":"https://api.github.com/users/MoonlightOwl/following{/other_user}","gists_url":"https://api.github.com/users/MoonlightOwl/gists{/gist_id}","starred_url":"https://api.github.com/users/MoonlightOwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoonlightOwl/subscriptions","organizations_url":"https://api.github.com/users/MoonlightOwl/orgs","repos_url":"https://api.github.com/users/MoonlightOwl/repos","events_url":"https://api.github.com/users/MoonlightOwl/events{/privacy}","received_events_url":"https://api.github.com/users/MoonlightOwl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MoonlightOwl/risk-legacy","description":"A user interface for playing Risk Legacy remotely. ","fork":true,"url":"https://api.github.com/repos/MoonlightOwl/risk-legacy","forks_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/forks","keys_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/teams","hooks_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/hooks","issue_events_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/events","assignees_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/tags","blobs_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/languages","stargazers_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/stargazers","contributors_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/contributors","subscribers_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/subscribers","subscription_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/subscription","commits_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/merges","archive_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/downloads","issues_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/labels{/name}","releases_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/releases{/id}","deployments_url":"https://api.github.com/repos/MoonlightOwl/risk-legacy/deployments","created_at":"2016-10-06T22:05:13Z","updated_at":"2016-10-06T22:05:14Z","pushed_at":"2016-10-06T22:12:20Z","git_url":"git://github.com/MoonlightOwl/risk-legacy.git","ssh_url":"git@github.com:MoonlightOwl/risk-legacy.git","clone_url":"https://github.com/MoonlightOwl/risk-legacy.git","svn_url":"https://github.com/MoonlightOwl/risk-legacy","homepage":null,"size":2287,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"catheraaine:master","ref":"master","sha":"480ccd2b9b9a6157f4aaa4bb33eb10953726e4be","user":{"login":"catheraaine","id":7475148,"avatar_url":"https://avatars.githubusercontent.com/u/7475148?v=3","gravatar_id":"","url":"https://api.github.com/users/catheraaine","html_url":"https://github.com/catheraaine","followers_url":"https://api.github.com/users/catheraaine/followers","following_url":"https://api.github.com/users/catheraaine/following{/other_user}","gists_url":"https://api.github.com/users/catheraaine/gists{/gist_id}","starred_url":"https://api.github.com/users/catheraaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catheraaine/subscriptions","organizations_url":"https://api.github.com/users/catheraaine/orgs","repos_url":"https://api.github.com/users/catheraaine/repos","events_url":"https://api.github.com/users/catheraaine/events{/privacy}","received_events_url":"https://api.github.com/users/catheraaine/received_events","type":"User","site_admin":false},"repo":{"id":54049799,"name":"risk-legacy","full_name":"catheraaine/risk-legacy","owner":{"login":"catheraaine","id":7475148,"avatar_url":"https://avatars.githubusercontent.com/u/7475148?v=3","gravatar_id":"","url":"https://api.github.com/users/catheraaine","html_url":"https://github.com/catheraaine","followers_url":"https://api.github.com/users/catheraaine/followers","following_url":"https://api.github.com/users/catheraaine/following{/other_user}","gists_url":"https://api.github.com/users/catheraaine/gists{/gist_id}","starred_url":"https://api.github.com/users/catheraaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catheraaine/subscriptions","organizations_url":"https://api.github.com/users/catheraaine/orgs","repos_url":"https://api.github.com/users/catheraaine/repos","events_url":"https://api.github.com/users/catheraaine/events{/privacy}","received_events_url":"https://api.github.com/users/catheraaine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/catheraaine/risk-legacy","description":"A user interface for playing Risk Legacy remotely. ","fork":false,"url":"https://api.github.com/repos/catheraaine/risk-legacy","forks_url":"https://api.github.com/repos/catheraaine/risk-legacy/forks","keys_url":"https://api.github.com/repos/catheraaine/risk-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catheraaine/risk-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catheraaine/risk-legacy/teams","hooks_url":"https://api.github.com/repos/catheraaine/risk-legacy/hooks","issue_events_url":"https://api.github.com/repos/catheraaine/risk-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/catheraaine/risk-legacy/events","assignees_url":"https://api.github.com/repos/catheraaine/risk-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/catheraaine/risk-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/catheraaine/risk-legacy/tags","blobs_url":"https://api.github.com/repos/catheraaine/risk-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catheraaine/risk-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catheraaine/risk-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/catheraaine/risk-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catheraaine/risk-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/catheraaine/risk-legacy/languages","stargazers_url":"https://api.github.com/repos/catheraaine/risk-legacy/stargazers","contributors_url":"https://api.github.com/repos/catheraaine/risk-legacy/contributors","subscribers_url":"https://api.github.com/repos/catheraaine/risk-legacy/subscribers","subscription_url":"https://api.github.com/repos/catheraaine/risk-legacy/subscription","commits_url":"https://api.github.com/repos/catheraaine/risk-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/catheraaine/risk-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/catheraaine/risk-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/catheraaine/risk-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/catheraaine/risk-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/catheraaine/risk-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catheraaine/risk-legacy/merges","archive_url":"https://api.github.com/repos/catheraaine/risk-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catheraaine/risk-legacy/downloads","issues_url":"https://api.github.com/repos/catheraaine/risk-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/catheraaine/risk-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/catheraaine/risk-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/catheraaine/risk-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catheraaine/risk-legacy/labels{/name}","releases_url":"https://api.github.com/repos/catheraaine/risk-legacy/releases{/id}","deployments_url":"https://api.github.com/repos/catheraaine/risk-legacy/deployments","created_at":"2016-03-16T16:46:53Z","updated_at":"2016-10-07T02:44:58Z","pushed_at":"2016-10-07T20:02:58Z","git_url":"git://github.com/catheraaine/risk-legacy.git","ssh_url":"git@github.com:catheraaine/risk-legacy.git","clone_url":"https://github.com/catheraaine/risk-legacy.git","svn_url":"https://github.com/catheraaine/risk-legacy","homepage":null,"size":2295,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":13,"forks":5,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/16"},"html":{"href":"https://github.com/catheraaine/risk-legacy/pull/16"},"issue":{"href":"https://api.github.com/repos/catheraaine/risk-legacy/issues/16"},"comments":{"href":"https://api.github.com/repos/catheraaine/risk-legacy/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/catheraaine/risk-legacy/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/catheraaine/risk-legacy/statuses/660cb52af418a899002b7abbea3c4770e309f027"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"catheraaine","id":7475148,"avatar_url":"https://avatars.githubusercontent.com/u/7475148?v=3","gravatar_id":"","url":"https://api.github.com/users/catheraaine","html_url":"https://github.com/catheraaine","followers_url":"https://api.github.com/users/catheraaine/followers","following_url":"https://api.github.com/users/catheraaine/following{/other_user}","gists_url":"https://api.github.com/users/catheraaine/gists{/gist_id}","starred_url":"https://api.github.com/users/catheraaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catheraaine/subscriptions","organizations_url":"https://api.github.com/users/catheraaine/orgs","repos_url":"https://api.github.com/users/catheraaine/repos","events_url":"https://api.github.com/users/catheraaine/events{/privacy}","received_events_url":"https://api.github.com/users/catheraaine/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":749,"deletions":1864,"changed_files":13}}
{"actor":{"display_login":"catheraaine"}}