{"action":"created","comment":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/comments/86624918","pull_request_review_id":7277414,"id":86624918,"diff_hunk":"@@ -1594,11 +1594,17 @@ zfs_prop_set_list(zfs_handle_t *zhp, nvlist_t *props)\n \t\tassert(cl_idx < nvl_len);\n \t\t/*\n \t\t * We don't want to unmount & remount the dataset when changing\n-\t\t * its canmount property to 'on' or 'noauto'.  We only use\n-\t\t * the changelist logic to unmount when setting canmount=off.\n+\t\t * its canmount property.  We only use the changelist logic to\n+\t\t * unmount when setting canmount=off for a mounted filesystem\n+\t\t * or when setting canmount=on for an unmounted filesystem.","path":"usr/src/lib/libzfs/common/libzfs_dataset.c","position":8,"original_position":8,"commit_id":"a10f218a49a7a47107041421d77e77f7491bbd6f","original_commit_id":"a10f218a49a7a47107041421d77e77f7491bbd6f","user":{"login":"ahrens","id":799124,"avatar_url":"https://avatars.githubusercontent.com/u/799124?v=3","gravatar_id":"","url":"https://api.github.com/users/ahrens","html_url":"https://github.com/ahrens","followers_url":"https://api.github.com/users/ahrens/followers","following_url":"https://api.github.com/users/ahrens/following{/other_user}","gists_url":"https://api.github.com/users/ahrens/gists{/gist_id}","starred_url":"https://api.github.com/users/ahrens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahrens/subscriptions","organizations_url":"https://api.github.com/users/ahrens/orgs","repos_url":"https://api.github.com/users/ahrens/repos","events_url":"https://api.github.com/users/ahrens/events{/privacy}","received_events_url":"https://api.github.com/users/ahrens/received_events","type":"User","site_admin":false},"body":"`zfs set canmount=on` should not attempt to mount anything.","created_at":"2016-11-04T20:18:17Z","updated_at":"2016-11-04T20:18:21Z","html_url":"https://github.com/openzfs/openzfs/pull/218#discussion_r86624918","pull_request_url":"https://api.github.com/repos/openzfs/openzfs/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/comments/86624918"},"html":{"href":"https://github.com/openzfs/openzfs/pull/218#discussion_r86624918"},"pull_request":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/openzfs/openzfs/pulls/218","id":92158602,"html_url":"https://github.com/openzfs/openzfs/pull/218","diff_url":"https://github.com/openzfs/openzfs/pull/218.diff","patch_url":"https://github.com/openzfs/openzfs/pull/218.patch","issue_url":"https://api.github.com/repos/openzfs/openzfs/issues/218","number":218,"state":"open","locked":false,"title":"6428 set canmount=off on unmounted filesystem tries to unmount children","user":{"login":"avg-I","id":1499700,"avatar_url":"https://avatars.githubusercontent.com/u/1499700?v=3","gravatar_id":"","url":"https://api.github.com/users/avg-I","html_url":"https://github.com/avg-I","followers_url":"https://api.github.com/users/avg-I/followers","following_url":"https://api.github.com/users/avg-I/following{/other_user}","gists_url":"https://api.github.com/users/avg-I/gists{/gist_id}","starred_url":"https://api.github.com/users/avg-I/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avg-I/subscriptions","organizations_url":"https://api.github.com/users/avg-I/orgs","repos_url":"https://api.github.com/users/avg-I/repos","events_url":"https://api.github.com/users/avg-I/events{/privacy}","received_events_url":"https://api.github.com/users/avg-I/received_events","type":"User","site_admin":false},"body":"This change is in FreeBSD already:\r\n- https://svnweb.freebsd.org/base?view=revision&revision=297521\r\n- https://svnweb.freebsd.org/base?view=revision&revision=304520","created_at":"2016-11-03T13:59:24Z","updated_at":"2016-11-04T20:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c1ea2b6b4332c1bd59d73379e2fb9c5b2d5f1ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzfs/openzfs/pulls/218/commits","review_comments_url":"https://api.github.com/repos/openzfs/openzfs/pulls/218/comments","review_comment_url":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzfs/openzfs/issues/218/comments","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/a10f218a49a7a47107041421d77e77f7491bbd6f","head":{"label":"avg-I:6428-zfs-set-canmount-off","ref":"6428-zfs-set-canmount-off","sha":"a10f218a49a7a47107041421d77e77f7491bbd6f","user":{"login":"avg-I","id":1499700,"avatar_url":"https://avatars.githubusercontent.com/u/1499700?v=3","gravatar_id":"","url":"https://api.github.com/users/avg-I","html_url":"https://github.com/avg-I","followers_url":"https://api.github.com/users/avg-I/followers","following_url":"https://api.github.com/users/avg-I/following{/other_user}","gists_url":"https://api.github.com/users/avg-I/gists{/gist_id}","starred_url":"https://api.github.com/users/avg-I/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avg-I/subscriptions","organizations_url":"https://api.github.com/users/avg-I/orgs","repos_url":"https://api.github.com/users/avg-I/repos","events_url":"https://api.github.com/users/avg-I/events{/privacy}","received_events_url":"https://api.github.com/users/avg-I/received_events","type":"User","site_admin":false},"repo":{"id":44811180,"name":"openzfs","full_name":"avg-I/openzfs","owner":{"login":"avg-I","id":1499700,"avatar_url":"https://avatars.githubusercontent.com/u/1499700?v=3","gravatar_id":"","url":"https://api.github.com/users/avg-I","html_url":"https://github.com/avg-I","followers_url":"https://api.github.com/users/avg-I/followers","following_url":"https://api.github.com/users/avg-I/following{/other_user}","gists_url":"https://api.github.com/users/avg-I/gists{/gist_id}","starred_url":"https://api.github.com/users/avg-I/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avg-I/subscriptions","organizations_url":"https://api.github.com/users/avg-I/orgs","repos_url":"https://api.github.com/users/avg-I/repos","events_url":"https://api.github.com/users/avg-I/events{/privacy}","received_events_url":"https://api.github.com/users/avg-I/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/avg-I/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/avg-I/openzfs","forks_url":"https://api.github.com/repos/avg-I/openzfs/forks","keys_url":"https://api.github.com/repos/avg-I/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avg-I/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avg-I/openzfs/teams","hooks_url":"https://api.github.com/repos/avg-I/openzfs/hooks","issue_events_url":"https://api.github.com/repos/avg-I/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/avg-I/openzfs/events","assignees_url":"https://api.github.com/repos/avg-I/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/avg-I/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/avg-I/openzfs/tags","blobs_url":"https://api.github.com/repos/avg-I/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avg-I/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avg-I/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/avg-I/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avg-I/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/avg-I/openzfs/languages","stargazers_url":"https://api.github.com/repos/avg-I/openzfs/stargazers","contributors_url":"https://api.github.com/repos/avg-I/openzfs/contributors","subscribers_url":"https://api.github.com/repos/avg-I/openzfs/subscribers","subscription_url":"https://api.github.com/repos/avg-I/openzfs/subscription","commits_url":"https://api.github.com/repos/avg-I/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/avg-I/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/avg-I/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/avg-I/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/avg-I/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/avg-I/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avg-I/openzfs/merges","archive_url":"https://api.github.com/repos/avg-I/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avg-I/openzfs/downloads","issues_url":"https://api.github.com/repos/avg-I/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/avg-I/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/avg-I/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/avg-I/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avg-I/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/avg-I/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/avg-I/openzfs/deployments","created_at":"2015-10-23T12:15:46Z","updated_at":"2016-11-03T13:17:32Z","pushed_at":"2016-11-03T14:13:00Z","git_url":"git://github.com/avg-I/openzfs.git","ssh_url":"git@github.com:avg-I/openzfs.git","clone_url":"https://github.com/avg-I/openzfs.git","svn_url":"https://github.com/avg-I/openzfs","homepage":"http://open-zfs.org","size":258927,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzfs:master","ref":"master","sha":"52afa0329a315c4930510f9be08ab622384a0e85","user":{"login":"openzfs","id":4510897,"avatar_url":"https://avatars.githubusercontent.com/u/4510897?v=3","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"repo":{"id":44220580,"name":"openzfs","full_name":"openzfs/openzfs","owner":{"login":"openzfs","id":4510897,"avatar_url":"https://avatars.githubusercontent.com/u/4510897?v=3","gravatar_id":"","url":"https://api.github.com/users/openzfs","html_url":"https://github.com/openzfs","followers_url":"https://api.github.com/users/openzfs/followers","following_url":"https://api.github.com/users/openzfs/following{/other_user}","gists_url":"https://api.github.com/users/openzfs/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfs/subscriptions","organizations_url":"https://api.github.com/users/openzfs/orgs","repos_url":"https://api.github.com/users/openzfs/repos","events_url":"https://api.github.com/users/openzfs/events{/privacy}","received_events_url":"https://api.github.com/users/openzfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzfs/openzfs","description":"OpenZFS is a storage platform that encompasses the functionality of traditional filesystems and volume managers, delivering enterprise reliability, modern functionality, and consistent performance in an easy to administer package on several operating system platforms.","fork":true,"url":"https://api.github.com/repos/openzfs/openzfs","forks_url":"https://api.github.com/repos/openzfs/openzfs/forks","keys_url":"https://api.github.com/repos/openzfs/openzfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzfs/openzfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzfs/openzfs/teams","hooks_url":"https://api.github.com/repos/openzfs/openzfs/hooks","issue_events_url":"https://api.github.com/repos/openzfs/openzfs/issues/events{/number}","events_url":"https://api.github.com/repos/openzfs/openzfs/events","assignees_url":"https://api.github.com/repos/openzfs/openzfs/assignees{/user}","branches_url":"https://api.github.com/repos/openzfs/openzfs/branches{/branch}","tags_url":"https://api.github.com/repos/openzfs/openzfs/tags","blobs_url":"https://api.github.com/repos/openzfs/openzfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzfs/openzfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzfs/openzfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzfs/openzfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzfs/openzfs/statuses/{sha}","languages_url":"https://api.github.com/repos/openzfs/openzfs/languages","stargazers_url":"https://api.github.com/repos/openzfs/openzfs/stargazers","contributors_url":"https://api.github.com/repos/openzfs/openzfs/contributors","subscribers_url":"https://api.github.com/repos/openzfs/openzfs/subscribers","subscription_url":"https://api.github.com/repos/openzfs/openzfs/subscription","commits_url":"https://api.github.com/repos/openzfs/openzfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzfs/openzfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzfs/openzfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzfs/openzfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzfs/openzfs/contents/{+path}","compare_url":"https://api.github.com/repos/openzfs/openzfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzfs/openzfs/merges","archive_url":"https://api.github.com/repos/openzfs/openzfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzfs/openzfs/downloads","issues_url":"https://api.github.com/repos/openzfs/openzfs/issues{/number}","pulls_url":"https://api.github.com/repos/openzfs/openzfs/pulls{/number}","milestones_url":"https://api.github.com/repos/openzfs/openzfs/milestones{/number}","notifications_url":"https://api.github.com/repos/openzfs/openzfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzfs/openzfs/labels{/name}","releases_url":"https://api.github.com/repos/openzfs/openzfs/releases{/id}","deployments_url":"https://api.github.com/repos/openzfs/openzfs/deployments","created_at":"2015-10-14T03:03:50Z","updated_at":"2016-11-03T20:56:09Z","pushed_at":"2016-11-03T22:27:29Z","git_url":"git://github.com/openzfs/openzfs.git","ssh_url":"git@github.com:openzfs/openzfs.git","clone_url":"https://github.com/openzfs/openzfs.git","svn_url":"https://github.com/openzfs/openzfs","homepage":"http://open-zfs.org","size":260817,"stargazers_count":101,"watchers_count":101,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":47,"forks":35,"open_issues":47,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/218"},"html":{"href":"https://github.com/openzfs/openzfs/pull/218"},"issue":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/218"},"comments":{"href":"https://api.github.com/repos/openzfs/openzfs/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzfs/openzfs/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/openzfs/openzfs/statuses/a10f218a49a7a47107041421d77e77f7491bbd6f"}}}}
{"actor":{"display_login":"ahrens"}}