{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/83085882","pull_request_review_id":3950103,"id":83085882,"diff_hunk":"@@ -0,0 +1,64 @@\n+\"\"\"\n+URLs for student app\n+\"\"\"\n+\n+from django.conf import settings\n+from django.conf.urls import patterns, url\n+\n+from student.views import LogoutView\n+\n+urlpatterns = (\n+    'student.views',\n+\n+    url(r'^logout$', LogoutView.as_view(), name='logout'),\n+\n+    # TODO: standardize login\n+\n+    # login endpoint used by cms.\n+    url(r'^login_post$', 'login_user', name='login_post'),\n+    # login endpoints used by lms.\n+    url(r'^login_ajax$', 'login_user', name=\"login\"),\n+    url(r'^login_ajax/(?P<error>[^/]*)$', 'login_user'),\n+\n+    url(r'^email_confirm/(?P<key>[^/]*)$', 'confirm_email_change'),\n+\n+    url(r'^create_account$', 'create_account', name='create_account'),\n+    url(r'^activate/(?P<key>[^/]*)$', 'activate_account', name=\"activate\"),\n+\n+    url(r'^accounts/disable_account_ajax$', 'disable_account_ajax', name=\"disable_account_ajax\"),\n+    url(r'^accounts/manage_user_standing', 'manage_user_standing', name='manage_user_standing'),\n+\n+    url(r'^change_setting$', 'change_setting', name='change_setting'),\n+    url(r'^change_email_settings$', 'change_email_settings', name='change_email_settings'),\n+)\n+\n+# enable automatic login\n+if settings.FEATURES.get('AUTOMATIC_AUTH_FOR_TESTING'):\n+    urlpatterns += (\n+        url(r'^auto_auth$', 'auto_auth'),\n+    )\n+\n+urlpatterns = patterns(*urlpatterns)\n+\n+# password reset mixes student.views with django views","path":"common/djangoapps/student/urls.py","position":43,"original_position":43,"commit_id":"fea03e466c43b6f8c2fd97d5b1c2feecf910945e","original_commit_id":"fea03e466c43b6f8c2fd97d5b1c2feecf910945e","user":{"login":"cpennington","id":30236,"avatar_url":"https://avatars.githubusercontent.com/u/30236?v=3","gravatar_id":"","url":"https://api.github.com/users/cpennington","html_url":"https://github.com/cpennington","followers_url":"https://api.github.com/users/cpennington/followers","following_url":"https://api.github.com/users/cpennington/following{/other_user}","gists_url":"https://api.github.com/users/cpennington/gists{/gist_id}","starred_url":"https://api.github.com/users/cpennington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpennington/subscriptions","organizations_url":"https://api.github.com/users/cpennington/orgs","repos_url":"https://api.github.com/users/cpennington/repos","events_url":"https://api.github.com/users/cpennington/events{/privacy}","received_events_url":"https://api.github.com/users/cpennington/received_events","type":"User","site_admin":false},"body":"Ah, yes, that makes more sense. Ideally, I think you'd cluster all of the views that use the `student.views` prefix, and call `patterns` on them inline, and also group the `django.contrib.auth` views in a separate group with a prefix, rather than the current method which updates the `urlpatterns` variable multiple times.","created_at":"2016-10-12T19:58:36Z","updated_at":"2016-10-12T19:59:19Z","html_url":"https://github.com/edx/edx-platform/pull/13672#discussion_r83085882","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13672","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/83085882"},"html":{"href":"https://github.com/edx/edx-platform/pull/13672#discussion_r83085882"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13672"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13672","id":88298000,"html_url":"https://github.com/edx/edx-platform/pull/13672","diff_url":"https://github.com/edx/edx-platform/pull/13672.diff","patch_url":"https://github.com/edx/edx-platform/pull/13672.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13672","number":13672,"state":"closed","locked":false,"title":"Move student.views to student/urls.py","user":{"login":"robrap","id":14576445,"avatar_url":"https://avatars.githubusercontent.com/u/14576445?v=3","gravatar_id":"","url":"https://api.github.com/users/robrap","html_url":"https://github.com/robrap","followers_url":"https://api.github.com/users/robrap/followers","following_url":"https://api.github.com/users/robrap/following{/other_user}","gists_url":"https://api.github.com/users/robrap/gists{/gist_id}","starred_url":"https://api.github.com/users/robrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robrap/subscriptions","organizations_url":"https://api.github.com/users/robrap/orgs","repos_url":"https://api.github.com/users/robrap/repos","events_url":"https://api.github.com/users/robrap/events{/privacy}","received_events_url":"https://api.github.com/users/robrap/received_events","type":"User","site_admin":false},"body":"Move student.views urls to a student/urls.py.\r\n\r\nSandbox:\r\n- [X] https://robrap-urls.sandbox.edx.org\r\n\r\nPre-Merge:\r\n- [x] Squash and rebase","created_at":"2016-10-06T16:36:46Z","updated_at":"2016-10-12T19:59:19Z","closed_at":"2016-10-12T12:47:53Z","merged_at":"2016-10-12T12:47:53Z","merge_commit_sha":"3f7503336ed5e6911e584bb967e96a8ec3347685","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/edx/edx-platform/milestones/1","html_url":"https://github.com/edx/edx-platform/milestones/clean_platform","labels_url":"https://api.github.com/repos/edx/edx-platform/milestones/1/labels","id":2052881,"number":1,"title":"clean_platform","description":null,"creator":{"login":"nasthagiri","id":6772826,"avatar_url":"https://avatars.githubusercontent.com/u/6772826?v=3","gravatar_id":"","url":"https://api.github.com/users/nasthagiri","html_url":"https://github.com/nasthagiri","followers_url":"https://api.github.com/users/nasthagiri/followers","following_url":"https://api.github.com/users/nasthagiri/following{/other_user}","gists_url":"https://api.github.com/users/nasthagiri/gists{/gist_id}","starred_url":"https://api.github.com/users/nasthagiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasthagiri/subscriptions","organizations_url":"https://api.github.com/users/nasthagiri/orgs","repos_url":"https://api.github.com/users/nasthagiri/repos","events_url":"https://api.github.com/users/nasthagiri/events{/privacy}","received_events_url":"https://api.github.com/users/nasthagiri/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":23,"state":"open","created_at":"2016-10-06T16:45:08Z","updated_at":"2016-10-12T12:47:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13672/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13672/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13672/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/fea03e466c43b6f8c2fd97d5b1c2feecf910945e","head":{"label":"edx:robrap/urls","ref":"robrap/urls","sha":"fea03e466c43b6f8c2fd97d5b1c2feecf910945e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-10-11T20:47:55Z","pushed_at":"2016-10-12T19:52:47Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":839539,"stargazers_count":2818,"watchers_count":2818,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1687,"mirror_url":null,"open_issues_count":160,"forks":1687,"open_issues":160,"watchers":2818,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"05440f750221645d9a418cfcdf0b1722a43a5972","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-10-11T20:47:55Z","pushed_at":"2016-10-12T19:52:47Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":839539,"stargazers_count":2818,"watchers_count":2818,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1687,"mirror_url":null,"open_issues_count":160,"forks":1687,"open_issues":160,"watchers":2818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13672"},"html":{"href":"https://github.com/edx/edx-platform/pull/13672"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13672"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13672/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13672/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13672/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/fea03e466c43b6f8c2fd97d5b1c2feecf910945e"}}}}
{"actor":{"display_login":"cpennington"}}