{"action":"created","issue":{"url":"https://api.github.com/repos/sunpy/sunpy/issues/1692","repository_url":"https://api.github.com/repos/sunpy/sunpy","labels_url":"https://api.github.com/repos/sunpy/sunpy/issues/1692/labels{/name}","comments_url":"https://api.github.com/repos/sunpy/sunpy/issues/1692/comments","events_url":"https://api.github.com/repos/sunpy/sunpy/issues/1692/events","html_url":"https://github.com/sunpy/sunpy/pull/1692","id":137833368,"number":1692,"title":"[unidown] #1626 Possible logic error in GOESClient.","user":{"login":"sudk1896","id":6025419,"avatar_url":"https://avatars.githubusercontent.com/u/6025419?v=3","gravatar_id":"","url":"https://api.github.com/users/sudk1896","html_url":"https://github.com/sudk1896","followers_url":"https://api.github.com/users/sudk1896/followers","following_url":"https://api.github.com/users/sudk1896/following{/other_user}","gists_url":"https://api.github.com/users/sudk1896/gists{/gist_id}","starred_url":"https://api.github.com/users/sudk1896/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudk1896/subscriptions","organizations_url":"https://api.github.com/users/sudk1896/orgs","repos_url":"https://api.github.com/users/sudk1896/repos","events_url":"https://api.github.com/users/sudk1896/events{/privacy}","received_events_url":"https://api.github.com/users/sudk1896/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-03-02T10:22:23Z","updated_at":"2016-03-02T14:28:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sunpy/sunpy/pulls/1692","html_url":"https://github.com/sunpy/sunpy/pull/1692","diff_url":"https://github.com/sunpy/sunpy/pull/1692.diff","patch_url":"https://github.com/sunpy/sunpy/pull/1692.patch"},"body":"Well , I found that for a particular timerange, GOESClient wasn't returning the intended fits file.\r\n```python\r\nfrom sunpy.time.timerange import TimeRange\r\nfrom sunpy.net.vso.attrs import Time, Instrument\r\nfrom sunpy.net.dataretriever.client import QueryResponse\r\nimport sunpy.net.dataretriever.sources.goes as goes\r\n\r\nLCClient = goes.GOESClient()\r\nqr = LCClient.query(Time('2012/10/4','2012/10/6'),Instrument('goes'))\r\nres = LCClient.get(qr)\r\ndl = res.wait()\r\nprint(len(qr)) #Length of query results\r\nprint(len(dl)) #no. of downloaded files.\r\n```\r\nWell, sometimes a particular **timerange** and **not a particular date**  might have multiple GOES satellite numbers, Think of a timerange which is spread over two different satellite numbers( see _get_goes_sat_num ) the earlier implementation didn't account for that. My implementation does that. I might be wrong here. This would need some testing as well. **Basically, the earlier logic was any given timerange by a user would belong to only one GOES sat number.** That might no be the case if we select a small timerange spread over the end of one satellite and beginning of the other. Correct me if I'm wrong."},"comment":{"url":"https://api.github.com/repos/sunpy/sunpy/issues/comments/191259149","html_url":"https://github.com/sunpy/sunpy/pull/1692#issuecomment-191259149","issue_url":"https://api.github.com/repos/sunpy/sunpy/issues/1692","id":191259149,"user":{"login":"Cadair","id":1391051,"avatar_url":"https://avatars.githubusercontent.com/u/1391051?v=3","gravatar_id":"","url":"https://api.github.com/users/Cadair","html_url":"https://github.com/Cadair","followers_url":"https://api.github.com/users/Cadair/followers","following_url":"https://api.github.com/users/Cadair/following{/other_user}","gists_url":"https://api.github.com/users/Cadair/gists{/gist_id}","starred_url":"https://api.github.com/users/Cadair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cadair/subscriptions","organizations_url":"https://api.github.com/users/Cadair/orgs","repos_url":"https://api.github.com/users/Cadair/repos","events_url":"https://api.github.com/users/Cadair/events{/privacy}","received_events_url":"https://api.github.com/users/Cadair/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T14:28:16Z","updated_at":"2016-03-02T14:28:16Z","body":"@sudk1896 probably easiest to move it back to the correct folder with `git mv goes.py sunpy/net/dataretriever/sources`"}}