{"action":"created","comment":{"url":"https://api.github.com/repos/falconry/falcon/pulls/comments/65792499","id":65792499,"diff_hunk":"@@ -0,0 +1,25 @@\n+from falcon import Request, Response\n+import falcon.testing as testing\n+\n+\n+class TestSlots(testing.TestBase):\n+\n+    def test_slots_request(self):\n+        env = testing.create_environ()\n+        req = Request(env)\n+        raised = False\n+        try:\n+            req.doesnt = 'exist'\n+        except AttributeError:\n+            raised = True\n+        self.assertFalse(raised, 'Unable to add to __slots__ dynamically')\n+\n+    def test_slots_response(self):\n+        resp = Response()\n+        resp.doesnt = 'exist'\n+        raised = False\n+        try:\n+            resp.doesnt = 'exist'\n+        except AttributeError:\n+            raised = True","path":"tests/test_slots.py","position":24,"original_position":24,"commit_id":"9438c56334a34cb040eb3f8fc6d649c2c33dfff3","original_commit_id":"9438c56334a34cb040eb3f8fc6d649c2c33dfff3","user":{"login":"kgriffs","id":719939,"avatar_url":"https://avatars.githubusercontent.com/u/719939?v=3","gravatar_id":"","url":"https://api.github.com/users/kgriffs","html_url":"https://github.com/kgriffs","followers_url":"https://api.github.com/users/kgriffs/followers","following_url":"https://api.github.com/users/kgriffs/following{/other_user}","gists_url":"https://api.github.com/users/kgriffs/gists{/gist_id}","starred_url":"https://api.github.com/users/kgriffs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgriffs/subscriptions","organizations_url":"https://api.github.com/users/kgriffs/orgs","repos_url":"https://api.github.com/users/kgriffs/repos","events_url":"https://api.github.com/users/kgriffs/events{/privacy}","received_events_url":"https://api.github.com/users/kgriffs/received_events","type":"User","site_admin":false},"body":"What do you think about just calling `self.fail()` here instead of using the `raised` variable?","created_at":"2016-06-04T00:16:13Z","updated_at":"2016-06-04T00:16:13Z","html_url":"https://github.com/falconry/falcon/pull/818#discussion_r65792499","pull_request_url":"https://api.github.com/repos/falconry/falcon/pulls/818","_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments/65792499"},"html":{"href":"https://github.com/falconry/falcon/pull/818#discussion_r65792499"},"pull_request":{"href":"https://api.github.com/repos/falconry/falcon/pulls/818"}}},"pull_request":{"url":"https://api.github.com/repos/falconry/falcon/pulls/818","id":72561998,"html_url":"https://github.com/falconry/falcon/pull/818","diff_url":"https://github.com/falconry/falcon/pull/818.diff","patch_url":"https://github.com/falconry/falcon/pull/818.patch","issue_url":"https://api.github.com/repos/falconry/falcon/issues/818","number":818,"state":"open","locked":false,"title":"feat(request,response): add __dict__ to __slots__","user":{"login":"SkiftCreative","id":89895,"avatar_url":"https://avatars.githubusercontent.com/u/89895?v=3","gravatar_id":"","url":"https://api.github.com/users/SkiftCreative","html_url":"https://github.com/SkiftCreative","followers_url":"https://api.github.com/users/SkiftCreative/followers","following_url":"https://api.github.com/users/SkiftCreative/following{/other_user}","gists_url":"https://api.github.com/users/SkiftCreative/gists{/gist_id}","starred_url":"https://api.github.com/users/SkiftCreative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkiftCreative/subscriptions","organizations_url":"https://api.github.com/users/SkiftCreative/orgs","repos_url":"https://api.github.com/users/SkiftCreative/repos","events_url":"https://api.github.com/users/SkiftCreative/events{/privacy}","received_events_url":"https://api.github.com/users/SkiftCreative/received_events","type":"User","site_admin":false},"body":"adds `__dict__` to the `__slots__` methods to the Request and Response classes\r\nto make it more extensible via subclassing and adding custom attributes. I have\r\nalso added tests to make sure adding custom attributes do not break and raise\r\nan `AttributeError`.\r\n\r\nfixes #785","created_at":"2016-06-03T20:01:51Z","updated_at":"2016-06-04T00:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f72328ddc37dc5bf7586059cb3f781c36d92e3f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/falconry/falcon/pulls/818/commits","review_comments_url":"https://api.github.com/repos/falconry/falcon/pulls/818/comments","review_comment_url":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/falconry/falcon/issues/818/comments","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/9438c56334a34cb040eb3f8fc6d649c2c33dfff3","head":{"label":"SkiftCreative:slots_with_dict","ref":"slots_with_dict","sha":"9438c56334a34cb040eb3f8fc6d649c2c33dfff3","user":{"login":"SkiftCreative","id":89895,"avatar_url":"https://avatars.githubusercontent.com/u/89895?v=3","gravatar_id":"","url":"https://api.github.com/users/SkiftCreative","html_url":"https://github.com/SkiftCreative","followers_url":"https://api.github.com/users/SkiftCreative/followers","following_url":"https://api.github.com/users/SkiftCreative/following{/other_user}","gists_url":"https://api.github.com/users/SkiftCreative/gists{/gist_id}","starred_url":"https://api.github.com/users/SkiftCreative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkiftCreative/subscriptions","organizations_url":"https://api.github.com/users/SkiftCreative/orgs","repos_url":"https://api.github.com/users/SkiftCreative/repos","events_url":"https://api.github.com/users/SkiftCreative/events{/privacy}","received_events_url":"https://api.github.com/users/SkiftCreative/received_events","type":"User","site_admin":false},"repo":{"id":60363795,"name":"falcon","full_name":"SkiftCreative/falcon","owner":{"login":"SkiftCreative","id":89895,"avatar_url":"https://avatars.githubusercontent.com/u/89895?v=3","gravatar_id":"","url":"https://api.github.com/users/SkiftCreative","html_url":"https://github.com/SkiftCreative","followers_url":"https://api.github.com/users/SkiftCreative/followers","following_url":"https://api.github.com/users/SkiftCreative/following{/other_user}","gists_url":"https://api.github.com/users/SkiftCreative/gists{/gist_id}","starred_url":"https://api.github.com/users/SkiftCreative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkiftCreative/subscriptions","organizations_url":"https://api.github.com/users/SkiftCreative/orgs","repos_url":"https://api.github.com/users/SkiftCreative/repos","events_url":"https://api.github.com/users/SkiftCreative/events{/privacy}","received_events_url":"https://api.github.com/users/SkiftCreative/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SkiftCreative/falcon","description":"Falcon is a low-level, high-performance Python framework for building HTTP APIs, app backends, and higher-level frameworks.","fork":true,"url":"https://api.github.com/repos/SkiftCreative/falcon","forks_url":"https://api.github.com/repos/SkiftCreative/falcon/forks","keys_url":"https://api.github.com/repos/SkiftCreative/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkiftCreative/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkiftCreative/falcon/teams","hooks_url":"https://api.github.com/repos/SkiftCreative/falcon/hooks","issue_events_url":"https://api.github.com/repos/SkiftCreative/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/SkiftCreative/falcon/events","assignees_url":"https://api.github.com/repos/SkiftCreative/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/SkiftCreative/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/SkiftCreative/falcon/tags","blobs_url":"https://api.github.com/repos/SkiftCreative/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkiftCreative/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkiftCreative/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkiftCreative/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkiftCreative/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/SkiftCreative/falcon/languages","stargazers_url":"https://api.github.com/repos/SkiftCreative/falcon/stargazers","contributors_url":"https://api.github.com/repos/SkiftCreative/falcon/contributors","subscribers_url":"https://api.github.com/repos/SkiftCreative/falcon/subscribers","subscription_url":"https://api.github.com/repos/SkiftCreative/falcon/subscription","commits_url":"https://api.github.com/repos/SkiftCreative/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkiftCreative/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkiftCreative/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkiftCreative/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkiftCreative/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/SkiftCreative/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkiftCreative/falcon/merges","archive_url":"https://api.github.com/repos/SkiftCreative/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkiftCreative/falcon/downloads","issues_url":"https://api.github.com/repos/SkiftCreative/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/SkiftCreative/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/SkiftCreative/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/SkiftCreative/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkiftCreative/falcon/labels{/name}","releases_url":"https://api.github.com/repos/SkiftCreative/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/SkiftCreative/falcon/deployments","created_at":"2016-06-03T16:57:10Z","updated_at":"2016-06-03T16:57:11Z","pushed_at":"2016-06-03T20:00:13Z","git_url":"git://github.com/SkiftCreative/falcon.git","ssh_url":"git@github.com:SkiftCreative/falcon.git","clone_url":"https://github.com/SkiftCreative/falcon.git","svn_url":"https://github.com/SkiftCreative/falcon","homepage":"https://falcon.readthedocs.org/en/stable/","size":26147,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"falconry:master","ref":"master","sha":"4d26f428be7a0eadbc456a0cd4cf79ffeac50d7a","user":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"repo":{"id":7040500,"name":"falcon","full_name":"falconry/falcon","owner":{"login":"falconry","id":11353642,"avatar_url":"https://avatars.githubusercontent.com/u/11353642?v=3","gravatar_id":"","url":"https://api.github.com/users/falconry","html_url":"https://github.com/falconry","followers_url":"https://api.github.com/users/falconry/followers","following_url":"https://api.github.com/users/falconry/following{/other_user}","gists_url":"https://api.github.com/users/falconry/gists{/gist_id}","starred_url":"https://api.github.com/users/falconry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falconry/subscriptions","organizations_url":"https://api.github.com/users/falconry/orgs","repos_url":"https://api.github.com/users/falconry/repos","events_url":"https://api.github.com/users/falconry/events{/privacy}","received_events_url":"https://api.github.com/users/falconry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/falconry/falcon","description":"Falcon is a low-level, high-performance Python framework for building HTTP APIs, app backends, and higher-level frameworks.","fork":false,"url":"https://api.github.com/repos/falconry/falcon","forks_url":"https://api.github.com/repos/falconry/falcon/forks","keys_url":"https://api.github.com/repos/falconry/falcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/falconry/falcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/falconry/falcon/teams","hooks_url":"https://api.github.com/repos/falconry/falcon/hooks","issue_events_url":"https://api.github.com/repos/falconry/falcon/issues/events{/number}","events_url":"https://api.github.com/repos/falconry/falcon/events","assignees_url":"https://api.github.com/repos/falconry/falcon/assignees{/user}","branches_url":"https://api.github.com/repos/falconry/falcon/branches{/branch}","tags_url":"https://api.github.com/repos/falconry/falcon/tags","blobs_url":"https://api.github.com/repos/falconry/falcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/falconry/falcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/falconry/falcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/falconry/falcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/falconry/falcon/statuses/{sha}","languages_url":"https://api.github.com/repos/falconry/falcon/languages","stargazers_url":"https://api.github.com/repos/falconry/falcon/stargazers","contributors_url":"https://api.github.com/repos/falconry/falcon/contributors","subscribers_url":"https://api.github.com/repos/falconry/falcon/subscribers","subscription_url":"https://api.github.com/repos/falconry/falcon/subscription","commits_url":"https://api.github.com/repos/falconry/falcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/falconry/falcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/falconry/falcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/falconry/falcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/falconry/falcon/contents/{+path}","compare_url":"https://api.github.com/repos/falconry/falcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/falconry/falcon/merges","archive_url":"https://api.github.com/repos/falconry/falcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/falconry/falcon/downloads","issues_url":"https://api.github.com/repos/falconry/falcon/issues{/number}","pulls_url":"https://api.github.com/repos/falconry/falcon/pulls{/number}","milestones_url":"https://api.github.com/repos/falconry/falcon/milestones{/number}","notifications_url":"https://api.github.com/repos/falconry/falcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/falconry/falcon/labels{/name}","releases_url":"https://api.github.com/repos/falconry/falcon/releases{/id}","deployments_url":"https://api.github.com/repos/falconry/falcon/deployments","created_at":"2012-12-06T18:17:51Z","updated_at":"2016-06-03T23:47:23Z","pushed_at":"2016-06-03T20:01:51Z","git_url":"git://github.com/falconry/falcon.git","ssh_url":"git@github.com:falconry/falcon.git","clone_url":"https://github.com/falconry/falcon.git","svn_url":"https://github.com/falconry/falcon","homepage":"https://falcon.readthedocs.org/en/stable/","size":26968,"stargazers_count":2924,"watchers_count":2924,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":337,"mirror_url":null,"open_issues_count":158,"forks":337,"open_issues":158,"watchers":2924,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/falconry/falcon/pulls/818"},"html":{"href":"https://github.com/falconry/falcon/pull/818"},"issue":{"href":"https://api.github.com/repos/falconry/falcon/issues/818"},"comments":{"href":"https://api.github.com/repos/falconry/falcon/issues/818/comments"},"review_comments":{"href":"https://api.github.com/repos/falconry/falcon/pulls/818/comments"},"review_comment":{"href":"https://api.github.com/repos/falconry/falcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/falconry/falcon/pulls/818/commits"},"statuses":{"href":"https://api.github.com/repos/falconry/falcon/statuses/9438c56334a34cb040eb3f8fc6d649c2c33dfff3"}}}}
{"actor":{"display_login":"kgriffs"}}