{"action":"closed","number":1338,"pull_request":{"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1338","id":62821920,"html_url":"https://github.com/ZeroK-RTS/Zero-K/pull/1338","diff_url":"https://github.com/ZeroK-RTS/Zero-K/pull/1338.diff","patch_url":"https://github.com/ZeroK-RTS/Zero-K/pull/1338.patch","issue_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1338","number":1338,"state":"closed","locked":false,"title":"Gadget version of wading wakes.","user":{"login":"Anarchid","id":3822768,"avatar_url":"https://avatars.githubusercontent.com/u/3822768?v=3","gravatar_id":"","url":"https://api.github.com/users/Anarchid","html_url":"https://github.com/Anarchid","followers_url":"https://api.github.com/users/Anarchid/followers","following_url":"https://api.github.com/users/Anarchid/following{/other_user}","gists_url":"https://api.github.com/users/Anarchid/gists{/gist_id}","starred_url":"https://api.github.com/users/Anarchid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anarchid/subscriptions","organizations_url":"https://api.github.com/users/Anarchid/orgs","repos_url":"https://api.github.com/users/Anarchid/repos","events_url":"https://api.github.com/users/Anarchid/events{/privacy}","received_events_url":"https://api.github.com/users/Anarchid/received_events","type":"User","site_admin":false},"body":"This reimplements the wading wakes proposal as a gadget, which should be much cleaner and less error-prone. Wade-admissible units are autodetected. Wakes are spawned every seventh frame for every fourth unit, so each unit currently generates ~one wake per second.\r\n\r\nThe part i dislike about this is relying on piece zero (which is nevertheless guaranteed to be present and likely to be the unit's core). Units could specify which of their pieces should emit wakes, but really i hope to see engine 102 include a way to SpawnCEG wakes without having to go down to EmtiSFX level. \r\n\r\nThe staggering behaviour could be made dynamic so fewer units spawn wakes per cycle.\r\n\r\nThis replaces and supercedes #1103.\r\n\r\nEyecandy:\r\n\r\n![workspace 1_060](https://cloud.githubusercontent.com/assets/3822768/13760811/b6e0f658-ea3d-11e5-8bb5-af1e1152991f.png)\r\n![workspace 1_058](https://cloud.githubusercontent.com/assets/3822768/13760820/bc05abba-ea3d-11e5-9c4c-5d601cd4a640.png)","created_at":"2016-03-14T21:39:35Z","updated_at":"2016-03-15T06:44:42Z","closed_at":"2016-03-15T06:44:42Z","merged_at":null,"merge_commit_sha":"c708ad383be6b2e260c9b74655475e99b3d68a1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1338/commits","review_comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1338/comments","review_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1338/comments","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/a297c51919bea924e3358f6f81d3c9fbabaa2c2b","head":{"label":"Anarchid:wade-gadget","ref":"wade-gadget","sha":"a297c51919bea924e3358f6f81d3c9fbabaa2c2b","user":{"login":"Anarchid","id":3822768,"avatar_url":"https://avatars.githubusercontent.com/u/3822768?v=3","gravatar_id":"","url":"https://api.github.com/users/Anarchid","html_url":"https://github.com/Anarchid","followers_url":"https://api.github.com/users/Anarchid/followers","following_url":"https://api.github.com/users/Anarchid/following{/other_user}","gists_url":"https://api.github.com/users/Anarchid/gists{/gist_id}","starred_url":"https://api.github.com/users/Anarchid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anarchid/subscriptions","organizations_url":"https://api.github.com/users/Anarchid/orgs","repos_url":"https://api.github.com/users/Anarchid/repos","events_url":"https://api.github.com/users/Anarchid/events{/privacy}","received_events_url":"https://api.github.com/users/Anarchid/received_events","type":"User","site_admin":false},"repo":{"id":20897510,"name":"Zero-K","full_name":"Anarchid/Zero-K","owner":{"login":"Anarchid","id":3822768,"avatar_url":"https://avatars.githubusercontent.com/u/3822768?v=3","gravatar_id":"","url":"https://api.github.com/users/Anarchid","html_url":"https://github.com/Anarchid","followers_url":"https://api.github.com/users/Anarchid/followers","following_url":"https://api.github.com/users/Anarchid/following{/other_user}","gists_url":"https://api.github.com/users/Anarchid/gists{/gist_id}","starred_url":"https://api.github.com/users/Anarchid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anarchid/subscriptions","organizations_url":"https://api.github.com/users/Anarchid/orgs","repos_url":"https://api.github.com/users/Anarchid/repos","events_url":"https://api.github.com/users/Anarchid/events{/privacy}","received_events_url":"https://api.github.com/users/Anarchid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Anarchid/Zero-K","description":"Open source RTS game running on the Spring engine","fork":true,"url":"https://api.github.com/repos/Anarchid/Zero-K","forks_url":"https://api.github.com/repos/Anarchid/Zero-K/forks","keys_url":"https://api.github.com/repos/Anarchid/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Anarchid/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Anarchid/Zero-K/teams","hooks_url":"https://api.github.com/repos/Anarchid/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/Anarchid/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/Anarchid/Zero-K/events","assignees_url":"https://api.github.com/repos/Anarchid/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/Anarchid/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/Anarchid/Zero-K/tags","blobs_url":"https://api.github.com/repos/Anarchid/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Anarchid/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Anarchid/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/Anarchid/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Anarchid/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/Anarchid/Zero-K/languages","stargazers_url":"https://api.github.com/repos/Anarchid/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/Anarchid/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/Anarchid/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/Anarchid/Zero-K/subscription","commits_url":"https://api.github.com/repos/Anarchid/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/Anarchid/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/Anarchid/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/Anarchid/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/Anarchid/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/Anarchid/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Anarchid/Zero-K/merges","archive_url":"https://api.github.com/repos/Anarchid/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Anarchid/Zero-K/downloads","issues_url":"https://api.github.com/repos/Anarchid/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/Anarchid/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/Anarchid/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/Anarchid/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Anarchid/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/Anarchid/Zero-K/releases{/id}","deployments_url":"https://api.github.com/repos/Anarchid/Zero-K/deployments","created_at":"2014-06-16T19:21:36Z","updated_at":"2016-02-10T18:57:03Z","pushed_at":"2016-03-15T06:44:42Z","git_url":"git://github.com/Anarchid/Zero-K.git","ssh_url":"git@github.com:Anarchid/Zero-K.git","clone_url":"https://github.com/Anarchid/Zero-K.git","svn_url":"https://github.com/Anarchid/Zero-K","homepage":null,"size":424611,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ZeroK-RTS:master","ref":"master","sha":"82d6d2e2a4359c4eed4bb3f85638fb095cb898e4","user":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars.githubusercontent.com/u/5145185?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"repo":{"id":11837082,"name":"Zero-K","full_name":"ZeroK-RTS/Zero-K","owner":{"login":"ZeroK-RTS","id":5145185,"avatar_url":"https://avatars.githubusercontent.com/u/5145185?v=3","gravatar_id":"","url":"https://api.github.com/users/ZeroK-RTS","html_url":"https://github.com/ZeroK-RTS","followers_url":"https://api.github.com/users/ZeroK-RTS/followers","following_url":"https://api.github.com/users/ZeroK-RTS/following{/other_user}","gists_url":"https://api.github.com/users/ZeroK-RTS/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroK-RTS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroK-RTS/subscriptions","organizations_url":"https://api.github.com/users/ZeroK-RTS/orgs","repos_url":"https://api.github.com/users/ZeroK-RTS/repos","events_url":"https://api.github.com/users/ZeroK-RTS/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroK-RTS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZeroK-RTS/Zero-K","description":"Open source RTS game running on the Spring engine","fork":false,"url":"https://api.github.com/repos/ZeroK-RTS/Zero-K","forks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/forks","keys_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/teams","hooks_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/hooks","issue_events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/events","assignees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/tags","blobs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/languages","stargazers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/stargazers","contributors_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contributors","subscribers_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscribers","subscription_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/subscription","commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/merges","archive_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/downloads","issues_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/labels{/name}","releases_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/releases{/id}","deployments_url":"https://api.github.com/repos/ZeroK-RTS/Zero-K/deployments","created_at":"2013-08-02T06:57:00Z","updated_at":"2016-03-12T19:34:34Z","pushed_at":"2016-03-14T21:39:35Z","git_url":"git://github.com/ZeroK-RTS/Zero-K.git","ssh_url":"git@github.com:ZeroK-RTS/Zero-K.git","clone_url":"https://github.com/ZeroK-RTS/Zero-K.git","svn_url":"https://github.com/ZeroK-RTS/Zero-K","homepage":null,"size":430667,"stargazers_count":62,"watchers_count":62,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":116,"forks":46,"open_issues":116,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1338"},"html":{"href":"https://github.com/ZeroK-RTS/Zero-K/pull/1338"},"issue":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1338"},"comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/issues/1338/comments"},"review_comments":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1338/comments"},"review_comment":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/pulls/1338/commits"},"statuses":{"href":"https://api.github.com/repos/ZeroK-RTS/Zero-K/statuses/a297c51919bea924e3358f6f81d3c9fbabaa2c2b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":83,"deletions":0,"changed_files":1}}