{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/56746986","id":56746986,"diff_hunk":"@@ -129,7 +129,7 @@ void PlayerInfo::updateCurrentPlayingDeck() {\n         }\n \n         double xfl, xfr;\n-        EngineXfader::getXfadeGains(m_pCOxfader->get(), 1.0, 0.0, false, false,\n+        EngineXfader::getXfadeGains(m_pCOxfader->get(), 1.0, 0.0, MIXXX_XFADER_ADDITIVE, false,","path":"src/mixer/playerinfo.cpp","position":5,"original_position":5,"commit_id":"f97ff2422360e24a8b57f7d2160a6a1da4a4b10c","original_commit_id":"f97ff2422360e24a8b57f7d2160a6a1da4a4b10c","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars.githubusercontent.com/u/1777442?v=3","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"This is bug, bt at least this patch does not change the situation. \r\n\r\nMixxx treats the deck with the highest volume as current track. \r\nIf you enable hamster style for the crossfader, the result is wrong. \r\n\r\nA corner case here is this: A deck is playing at center orientation and two decks ar playing in crossfader center position. With the current implementation all decks have the equal volume and the lowest index is picked. \r\nThe trouth is, that the center deck has the highest volume so this should be picked, but is this the current? \r\nIMHO yes. \r\nSo for fixing this bug, we need call it with all options like here: \r\nhttps://github.com/potocpav/mixxx/blob/const-power-crossfader/src/engine/enginemaster.cpp#L402\r\nThe access them we need new ControlObjectSlave obejcts. \r\n\r\nYou can fix this issue if you like or place a TODO.\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2016-03-19T09:50:05Z","updated_at":"2016-03-19T09:50:05Z","html_url":"https://github.com/mixxxdj/mixxx/pull/906#discussion_r56746986","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/56746986"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/906#discussion_r56746986"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906","id":63334070,"html_url":"https://github.com/mixxxdj/mixxx/pull/906","diff_url":"https://github.com/mixxxdj/mixxx/pull/906.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/906.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/906","number":906,"state":"open","locked":false,"title":"Constant power crossfader","user":{"login":"potocpav","id":4094619,"avatar_url":"https://avatars.githubusercontent.com/u/4094619?v=3","gravatar_id":"","url":"https://api.github.com/users/potocpav","html_url":"https://github.com/potocpav","followers_url":"https://api.github.com/users/potocpav/followers","following_url":"https://api.github.com/users/potocpav/following{/other_user}","gists_url":"https://api.github.com/users/potocpav/gists{/gist_id}","starred_url":"https://api.github.com/users/potocpav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potocpav/subscriptions","organizations_url":"https://api.github.com/users/potocpav/orgs","repos_url":"https://api.github.com/users/potocpav/repos","events_url":"https://api.github.com/users/potocpav/events{/privacy}","received_events_url":"https://api.github.com/users/potocpav/received_events","type":"User","site_admin":false},"body":"Add a new Constant power crossfader (which is constant power for uncorrelated signals, a²+b²=1 for gains a,b). The crossfader previously known as Constant power is renamed to Linear. At least for my music, this new crossfader gives more constant-powery crossfades than either of the previously available ones.","created_at":"2016-03-18T06:44:40Z","updated_at":"2016-03-19T09:50:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2b7a9ea805a1d37893823b809a63b66fc13f832","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/906/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/f97ff2422360e24a8b57f7d2160a6a1da4a4b10c","head":{"label":"potocpav:const-power-crossfader","ref":"const-power-crossfader","sha":"f97ff2422360e24a8b57f7d2160a6a1da4a4b10c","user":{"login":"potocpav","id":4094619,"avatar_url":"https://avatars.githubusercontent.com/u/4094619?v=3","gravatar_id":"","url":"https://api.github.com/users/potocpav","html_url":"https://github.com/potocpav","followers_url":"https://api.github.com/users/potocpav/followers","following_url":"https://api.github.com/users/potocpav/following{/other_user}","gists_url":"https://api.github.com/users/potocpav/gists{/gist_id}","starred_url":"https://api.github.com/users/potocpav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potocpav/subscriptions","organizations_url":"https://api.github.com/users/potocpav/orgs","repos_url":"https://api.github.com/users/potocpav/repos","events_url":"https://api.github.com/users/potocpav/events{/privacy}","received_events_url":"https://api.github.com/users/potocpav/received_events","type":"User","site_admin":false},"repo":{"id":54179054,"name":"mixxx","full_name":"potocpav/mixxx","owner":{"login":"potocpav","id":4094619,"avatar_url":"https://avatars.githubusercontent.com/u/4094619?v=3","gravatar_id":"","url":"https://api.github.com/users/potocpav","html_url":"https://github.com/potocpav","followers_url":"https://api.github.com/users/potocpav/followers","following_url":"https://api.github.com/users/potocpav/following{/other_user}","gists_url":"https://api.github.com/users/potocpav/gists{/gist_id}","starred_url":"https://api.github.com/users/potocpav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potocpav/subscriptions","organizations_url":"https://api.github.com/users/potocpav/orgs","repos_url":"https://api.github.com/users/potocpav/repos","events_url":"https://api.github.com/users/potocpav/events{/privacy}","received_events_url":"https://api.github.com/users/potocpav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/potocpav/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/potocpav/mixxx","forks_url":"https://api.github.com/repos/potocpav/mixxx/forks","keys_url":"https://api.github.com/repos/potocpav/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/potocpav/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/potocpav/mixxx/teams","hooks_url":"https://api.github.com/repos/potocpav/mixxx/hooks","issue_events_url":"https://api.github.com/repos/potocpav/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/potocpav/mixxx/events","assignees_url":"https://api.github.com/repos/potocpav/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/potocpav/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/potocpav/mixxx/tags","blobs_url":"https://api.github.com/repos/potocpav/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/potocpav/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/potocpav/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/potocpav/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/potocpav/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/potocpav/mixxx/languages","stargazers_url":"https://api.github.com/repos/potocpav/mixxx/stargazers","contributors_url":"https://api.github.com/repos/potocpav/mixxx/contributors","subscribers_url":"https://api.github.com/repos/potocpav/mixxx/subscribers","subscription_url":"https://api.github.com/repos/potocpav/mixxx/subscription","commits_url":"https://api.github.com/repos/potocpav/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/potocpav/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/potocpav/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/potocpav/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/potocpav/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/potocpav/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/potocpav/mixxx/merges","archive_url":"https://api.github.com/repos/potocpav/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/potocpav/mixxx/downloads","issues_url":"https://api.github.com/repos/potocpav/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/potocpav/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/potocpav/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/potocpav/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/potocpav/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/potocpav/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/potocpav/mixxx/deployments","created_at":"2016-03-18T06:26:02Z","updated_at":"2016-03-18T06:26:16Z","pushed_at":"2016-03-19T00:10:36Z","git_url":"git://github.com/potocpav/mixxx.git","ssh_url":"git@github.com:potocpav/mixxx.git","clone_url":"https://github.com/potocpav/mixxx.git","svn_url":"https://github.com/potocpav/mixxx","homepage":"http://mixxx.org","size":252149,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"94e9c0c93d985119ffb6403d774882c02c4ce6a4","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-03-19T01:08:31Z","pushed_at":"2016-03-19T07:02:55Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":267663,"stargazers_count":477,"watchers_count":477,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":313,"mirror_url":null,"open_issues_count":61,"forks":313,"open_issues":61,"watchers":477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/906"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/906"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/f97ff2422360e24a8b57f7d2160a6a1da4a4b10c"}}}}