{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/88770063","pull_request_review_id":9337114,"id":88770063,"diff_hunk":"@@ -459,9 +486,33 @@ public PropertyJacksonDeserializer() {\n \n         @Override\n         public Property createObject(final Map<String, Object> propData) {\n-            return new DetachedProperty(\n-                    (String) propData.get(GraphSONTokens.KEY),\n-                    propData.get(GraphSONTokens.VALUE));\n+            final Object element = propData.get(GraphSONTokens.ELEMENT);\n+            return element instanceof Element ? // graphson-non-embedded is treated differently, but since this is a hard coded embedding...\n+                    new DetachedProperty<>((String) propData.get(GraphSONTokens.KEY), propData.get(GraphSONTokens.VALUE), (Element) element) :\n+                    new DetachedProperty<>((String) propData.get(GraphSONTokens.KEY), propData.get(GraphSONTokens.VALUE));\n+        }\n+    }\n+\n+    static class VertexPropertyJacksonDeserializer extends AbstractObjectDeserializer<VertexProperty> {\n+\n+        protected VertexPropertyJacksonDeserializer() {\n+            super(VertexProperty.class);\n+        }\n+\n+        @Override\n+        public VertexProperty createObject(final Map<String, Object> propData) {\n+            return propData.containsKey(GraphSONTokens.VERTEX) ?\n+                    new DetachedVertexProperty<>(\n+                            propData.get(GraphSONTokens.ID),\n+                            (String) propData.get(GraphSONTokens.LABEL),\n+                            propData.get(GraphSONTokens.VALUE), (Map<String, Object>) propData.get(GraphSONTokens.PROPERTIES),\n+                            new DetachedVertex(propData.get(GraphSONTokens.VERTEX), Vertex.DEFAULT_LABEL, null)) :","path":"gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONSerializersV2d0.java","position":198,"original_position":198,"commit_id":"31cdb4bf6cfb02e56cce35e536d85c6c13b03e97","original_commit_id":"31cdb4bf6cfb02e56cce35e536d85c6c13b03e97","user":{"login":"newkek","id":3471564,"avatar_url":"https://avatars.githubusercontent.com/u/3471564?v=3","gravatar_id":"","url":"https://api.github.com/users/newkek","html_url":"https://github.com/newkek","followers_url":"https://api.github.com/users/newkek/followers","following_url":"https://api.github.com/users/newkek/following{/other_user}","gists_url":"https://api.github.com/users/newkek/gists{/gist_id}","starred_url":"https://api.github.com/users/newkek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newkek/subscriptions","organizations_url":"https://api.github.com/users/newkek/orgs","repos_url":"https://api.github.com/users/newkek/repos","events_url":"https://api.github.com/users/newkek/events{/privacy}","received_events_url":"https://api.github.com/users/newkek/received_events","type":"User","site_admin":false},"body":"Supposing it's a Vertex with VertexProperties that is deserialized (and not only a VertexProperty on its own), will this really make the VertexProperty link to the right parent Vertex? It looks like this will create another one. However, I've recently found a nice way to make a deserializer sort of \"context aware\" in order to, when a Vertex deserializer deserializes its own VertexProperties, it can give to the VertexProperty deserializers the Vertex object that's \"above\" them - the VertexProperty's parent. I haven't had time to propose a fix here in TP but I intended to do so soon if you guys are interested ","created_at":"2016-11-19T02:29:36Z","updated_at":"2016-11-19T02:29:36Z","html_url":"https://github.com/apache/tinkerpop/pull/499#discussion_r88770063","pull_request_url":"https://api.github.com/repos/apache/tinkerpop/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/88770063"},"html":{"href":"https://github.com/apache/tinkerpop/pull/499#discussion_r88770063"},"pull_request":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/499","id":94363889,"html_url":"https://github.com/apache/tinkerpop/pull/499","diff_url":"https://github.com/apache/tinkerpop/pull/499.diff","patch_url":"https://github.com/apache/tinkerpop/pull/499.patch","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/499","number":499,"state":"open","locked":false,"title":"TINKERPOP-1520: Difference between 'has' step generated graphson2.0 in java and python glv implementation","user":{"login":"okram","id":148925,"avatar_url":"https://avatars.githubusercontent.com/u/148925?v=3","gravatar_id":"","url":"https://api.github.com/users/okram","html_url":"https://github.com/okram","followers_url":"https://api.github.com/users/okram/followers","following_url":"https://api.github.com/users/okram/following{/other_user}","gists_url":"https://api.github.com/users/okram/gists{/gist_id}","starred_url":"https://api.github.com/users/okram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okram/subscriptions","organizations_url":"https://api.github.com/users/okram/orgs","repos_url":"https://api.github.com/users/okram/repos","events_url":"https://api.github.com/users/okram/events{/privacy}","received_events_url":"https://api.github.com/users/okram/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/TINKERPOP-1520\r\nhttps://issues.apache.org/jira/browse/TINKERPOP-1454\r\n\r\nThis branch has done alot around testing and GraphSON.\r\n\r\n* We now verify that all translators create Traversals with bytecode identical to the original translated bytecode. (tested against all traversals in ProcessSuite)\r\n* We now verify that Gremlin-Python's GraphSON Bytecode representation is identical to Gremlin-Java's. (tested against all traversals in ProcessSuite)\r\n* We now verify that GraphTraversal is in one-to-one correspondence with Bytecode. That is, has(\"name\") -> [has,name]. (bad ass reflection technique used here)\r\n* There was a GraphSON 2.0 issue with Edge properties. Changed to the same format a VertexProperties. Smaller footprint and only necessary information.\r\n* Added VertexID (\"vertex\"-field) to VertexProperty in GraphSON 2.0 -- how else will you attach?\r\n* Added Element (\"element\"-field) to Property in GraphSON 2.0 -- how else will you attach?\r\n* Added TraversalStrategy classes to GryoMapper as we (@spmallette !!! shame on you) simply dropped `withStrategies()` instructions in Gryo Bytecode serialization.\r\n* TranslationStrategy is now smart to remove itself from the Bytecode. No longer do the Translators have to be wary of this (lots of code deleted).\r\n* We now verify that Gryo created bytecode is identical to source bytecode.\r\n\r\n...need I go on?\r\n\r\nVOTE +1","created_at":"2016-11-18T13:43:56Z","updated_at":"2016-11-19T02:29:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b1f17a339f69d23588059380055bfdf3415374b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/tinkerpop/pulls/499/commits","review_comments_url":"https://api.github.com/repos/apache/tinkerpop/pulls/499/comments","review_comment_url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/499/comments","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/31cdb4bf6cfb02e56cce35e536d85c6c13b03e97","head":{"label":"apache:TINKERPOP-1520","ref":"TINKERPOP-1520","sha":"31cdb4bf6cfb02e56cce35e536d85c6c13b03e97","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2016-11-18T05:58:45Z","pushed_at":"2016-11-18T20:31:46Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":133468,"stargazers_count":280,"watchers_count":280,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":"git://git.apache.org/incubator-tinkerpop.git","open_issues_count":16,"forks":166,"open_issues":16,"watchers":280,"default_branch":"master"}},"base":{"label":"apache:tp32","ref":"tp32","sha":"35364c8592969f786f3dccecc862c76d56a20fce","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2016-11-18T05:58:45Z","pushed_at":"2016-11-18T20:31:46Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":133468,"stargazers_count":280,"watchers_count":280,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":"git://git.apache.org/incubator-tinkerpop.git","open_issues_count":16,"forks":166,"open_issues":16,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/499"},"html":{"href":"https://github.com/apache/tinkerpop/pull/499"},"issue":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/499"},"comments":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tinkerpop/statuses/31cdb4bf6cfb02e56cce35e536d85c6c13b03e97"}}}}
{"actor":{"display_login":"newkek"}}