{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-testing/hermione/pulls/comments/87594481","pull_request_review_id":8202872,"id":87594481,"diff_hunk":"@@ -104,100 +79,106 @@ describe('config options', () => {\n                 ignoreLeaks: true\n             };\n \n-            const readConfig = mkConfig_({mochaOpts});\n-            ConfigReader.prototype.read.returns(readConfig);\n-\n-            const parsedConfig = Config.create({}).parse();\n-\n+            const parsedConfig = parseConfig_({mochaOpts});\n             assert.deepEqual(parsedConfig.mochaOpts, mochaOpts);\n         });\n     });\n \n     ['prepareBrowser', 'prepareEnvironment'].forEach((option) => {\n         describe(`${option}`, () => {\n             it(`should throw error if ${option} is not a null or function`, () => {\n-                const readConfig = mkConfig_(_.set({}, option, {}));\n-                ConfigReader.prototype.read.returns(readConfig);\n-\n-                const config = Config.create({});\n-\n-                assert.throws(() => config.parse(), Error, `\"${option}\" should be null or function`);\n+                assert.throws(() => parseConfig_(_.set({}, option, {})), Error, `\"${option}\" should be null or function`);\n             });\n \n             it(`should set default ${option} option if it does not set in config file`, () => {\n-                ConfigReader.prototype.read.returns(mkConfig_());\n-\n-                const parsedConfig = Config.create({}).parse();\n-\n+                const parsedConfig = parseConfig_();\n                 assert.equal(parsedConfig[option], defaults[option]);\n             });\n \n             it(`should override ${option} option`, () => {\n-                const func = () => {};\n-                const readConfig = mkConfig_(_.set({}, option, func));\n-\n-                ConfigReader.prototype.read.returns(readConfig);\n-\n-                const parsedConfig = Config.create({}).parse();\n-\n-                assert.deepEqual(parsedConfig[option], func);\n+                const stub = sandbox.stub();\n+                const parsedConfig = parseConfig_(_.set({}, option, stub));\n+                assert.deepEqual(parsedConfig[option], stub);","path":"test/lib/config/options.js","position":159,"original_position":159,"commit_id":"beca1b50d97df604e9cc21638f53d89c212553a6","original_commit_id":"beca1b50d97df604e9cc21638f53d89c212553a6","user":{"login":"sipayRT","id":1658415,"avatar_url":"https://avatars.githubusercontent.com/u/1658415?v=3","gravatar_id":"","url":"https://api.github.com/users/sipayRT","html_url":"https://github.com/sipayRT","followers_url":"https://api.github.com/users/sipayRT/followers","following_url":"https://api.github.com/users/sipayRT/following{/other_user}","gists_url":"https://api.github.com/users/sipayRT/gists{/gist_id}","starred_url":"https://api.github.com/users/sipayRT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipayRT/subscriptions","organizations_url":"https://api.github.com/users/sipayRT/orgs","repos_url":"https://api.github.com/users/sipayRT/repos","events_url":"https://api.github.com/users/sipayRT/events{/privacy}","received_events_url":"https://api.github.com/users/sipayRT/received_events","type":"User","site_admin":false},"body":"а нафига тебе прям стаб прокидывать? почему не подошла пустая функция?","created_at":"2016-11-11T14:21:31Z","updated_at":"2016-11-11T14:21:31Z","html_url":"https://github.com/gemini-testing/hermione/pull/83#discussion_r87594481","pull_request_url":"https://api.github.com/repos/gemini-testing/hermione/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/hermione/pulls/comments/87594481"},"html":{"href":"https://github.com/gemini-testing/hermione/pull/83#discussion_r87594481"},"pull_request":{"href":"https://api.github.com/repos/gemini-testing/hermione/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-testing/hermione/pulls/83","id":92971382,"html_url":"https://github.com/gemini-testing/hermione/pull/83","diff_url":"https://github.com/gemini-testing/hermione/pull/83.diff","patch_url":"https://github.com/gemini-testing/hermione/pull/83.patch","issue_url":"https://api.github.com/repos/gemini-testing/hermione/issues/83","number":83,"state":"open","locked":false,"title":"Programmatic api","user":{"login":"seth2810","id":845078,"avatar_url":"https://avatars.githubusercontent.com/u/845078?v=3","gravatar_id":"","url":"https://api.github.com/users/seth2810","html_url":"https://github.com/seth2810","followers_url":"https://api.github.com/users/seth2810/followers","following_url":"https://api.github.com/users/seth2810/following{/other_user}","gists_url":"https://api.github.com/users/seth2810/gists{/gist_id}","starred_url":"https://api.github.com/users/seth2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seth2810/subscriptions","organizations_url":"https://api.github.com/users/seth2810/orgs","repos_url":"https://api.github.com/users/seth2810/repos","events_url":"https://api.github.com/users/seth2810/events{/privacy}","received_events_url":"https://api.github.com/users/seth2810/received_events","type":"User","site_admin":false},"body":"Currently reading of hermione configuration file ocurred outside of constructor in command line interface like as well as validation of empty browser objects. This leads to additional efforts if you want to create and run hermione through api. Also I add similar [ability to pass primitive values for plugins through cli/env](https://github.com/gemini-testing/gemini/pull/661) that recently added in gemini.","created_at":"2016-11-09T14:21:23Z","updated_at":"2016-11-11T14:21:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a96dfdd0fd534a41291d4a497521823912b0e884","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-testing/hermione/pulls/83/commits","review_comments_url":"https://api.github.com/repos/gemini-testing/hermione/pulls/83/comments","review_comment_url":"https://api.github.com/repos/gemini-testing/hermione/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-testing/hermione/issues/83/comments","statuses_url":"https://api.github.com/repos/gemini-testing/hermione/statuses/beca1b50d97df604e9cc21638f53d89c212553a6","head":{"label":"gemini-testing:programmatic-api","ref":"programmatic-api","sha":"beca1b50d97df604e9cc21638f53d89c212553a6","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":51917537,"name":"hermione","full_name":"gemini-testing/hermione","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/hermione","description":"Browser test runner based on mocha and wdio","fork":false,"url":"https://api.github.com/repos/gemini-testing/hermione","forks_url":"https://api.github.com/repos/gemini-testing/hermione/forks","keys_url":"https://api.github.com/repos/gemini-testing/hermione/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/hermione/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/hermione/teams","hooks_url":"https://api.github.com/repos/gemini-testing/hermione/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/hermione/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/hermione/events","assignees_url":"https://api.github.com/repos/gemini-testing/hermione/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/hermione/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/hermione/tags","blobs_url":"https://api.github.com/repos/gemini-testing/hermione/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/hermione/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/hermione/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/hermione/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/hermione/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/hermione/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/hermione/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/hermione/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/hermione/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/hermione/subscription","commits_url":"https://api.github.com/repos/gemini-testing/hermione/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/hermione/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/hermione/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/hermione/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/hermione/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/hermione/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/hermione/merges","archive_url":"https://api.github.com/repos/gemini-testing/hermione/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/hermione/downloads","issues_url":"https://api.github.com/repos/gemini-testing/hermione/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/hermione/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/hermione/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/hermione/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/hermione/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/hermione/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/hermione/deployments","created_at":"2016-02-17T11:26:05Z","updated_at":"2016-11-10T17:58:37Z","pushed_at":"2016-11-11T11:26:44Z","git_url":"git://github.com/gemini-testing/hermione.git","ssh_url":"git@github.com:gemini-testing/hermione.git","clone_url":"https://github.com/gemini-testing/hermione.git","svn_url":"https://github.com/gemini-testing/hermione","homepage":null,"size":579,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":35,"default_branch":"master"}},"base":{"label":"gemini-testing:master","ref":"master","sha":"f25ee9538e99c6ab149dd7b4f3d04e7413d7970e","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":51917537,"name":"hermione","full_name":"gemini-testing/hermione","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/hermione","description":"Browser test runner based on mocha and wdio","fork":false,"url":"https://api.github.com/repos/gemini-testing/hermione","forks_url":"https://api.github.com/repos/gemini-testing/hermione/forks","keys_url":"https://api.github.com/repos/gemini-testing/hermione/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/hermione/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/hermione/teams","hooks_url":"https://api.github.com/repos/gemini-testing/hermione/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/hermione/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/hermione/events","assignees_url":"https://api.github.com/repos/gemini-testing/hermione/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/hermione/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/hermione/tags","blobs_url":"https://api.github.com/repos/gemini-testing/hermione/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/hermione/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/hermione/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/hermione/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/hermione/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/hermione/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/hermione/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/hermione/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/hermione/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/hermione/subscription","commits_url":"https://api.github.com/repos/gemini-testing/hermione/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/hermione/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/hermione/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/hermione/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/hermione/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/hermione/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/hermione/merges","archive_url":"https://api.github.com/repos/gemini-testing/hermione/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/hermione/downloads","issues_url":"https://api.github.com/repos/gemini-testing/hermione/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/hermione/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/hermione/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/hermione/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/hermione/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/hermione/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/hermione/deployments","created_at":"2016-02-17T11:26:05Z","updated_at":"2016-11-10T17:58:37Z","pushed_at":"2016-11-11T11:26:44Z","git_url":"git://github.com/gemini-testing/hermione.git","ssh_url":"git@github.com:gemini-testing/hermione.git","clone_url":"https://github.com/gemini-testing/hermione.git","svn_url":"https://github.com/gemini-testing/hermione","homepage":null,"size":579,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":9,"forks":5,"open_issues":9,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/hermione/pulls/83"},"html":{"href":"https://github.com/gemini-testing/hermione/pull/83"},"issue":{"href":"https://api.github.com/repos/gemini-testing/hermione/issues/83"},"comments":{"href":"https://api.github.com/repos/gemini-testing/hermione/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-testing/hermione/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-testing/hermione/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-testing/hermione/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-testing/hermione/statuses/beca1b50d97df604e9cc21638f53d89c212553a6"}}}}
{"actor":{"display_login":"sipayRT"}}