{"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/64805058","id":64805058,"diff_hunk":"@@ -672,21 +698,33 @@ -(CGFloat)contentWidthForWidth:(CGFloat)value\n }\n \n #pragma mark WebView Delegate\n-\n - (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)request navigationType:(UIWebViewNavigationType)navigationType\n {\n \tNSURL * newUrl = [request URL];\n-\n-\tif ([self.proxy _hasListeners:@\"beforeload\"])\n-\t{\n-\t\tNSDictionary *event = newUrl == nil ? nil : [NSDictionary dictionaryWithObjectsAndKeys:[newUrl absoluteString], @\"url\", NUMINT(navigationType), @\"navigationType\", nil];\n-\t\t[self.proxy fireEvent:@\"beforeload\" withObject:event];\n-\t}\n-\n-\tif (navigationType != UIWebViewNavigationTypeOther) {\n-\t\tRELEASE_TO_NIL(lastValidLoad);\n-\t}\n-\n+    \n+    if ([self.proxy _hasListeners:@\"beforeload\"])\n+    {\n+        NSDictionary *event = newUrl == nil ? nil : [NSDictionary dictionaryWithObjectsAndKeys:[newUrl absoluteString], @\"url\", NUMINT(navigationType), @\"navigationType\", nil];\n+        [self.proxy fireEvent:@\"beforeload\" withObject:event];\n+    }\n+    \n+    if (navigationType != UIWebViewNavigationTypeOther) {\n+        RELEASE_TO_NIL(lastValidLoad);\n+    }\n+    \n+    if (blacklistedURLs) {\n+        for (NSString*check in blacklistedURLs)\n+        {\n+            if ([[newUrl absoluteString] rangeOfString:check options:NSCaseInsensitiveSearch].location != NSNotFound) {\n+                if([self.proxy _hasListeners:@\"onStopBlacklistedUrl\"]) {\n+                    NSDictionary* evt = [NSDictionary dictionaryWithObjectsAndKeys:[TiUtils stringValue:request], @\"url\", @\"Webview did not load blacklisted url.\", @\"messsage\", nil];","path":"iphone/Classes/TiUIWebView.m","position":84,"original_position":84,"commit_id":"eed9451378c0ab016c24883e88a1c48fbb8351f4","original_commit_id":"eed9451378c0ab016c24883e88a1c48fbb8351f4","user":{"login":"hansemannn","id":10667698,"avatar_url":"https://avatars.githubusercontent.com/u/10667698?v=3","gravatar_id":"","url":"https://api.github.com/users/hansemannn","html_url":"https://github.com/hansemannn","followers_url":"https://api.github.com/users/hansemannn/followers","following_url":"https://api.github.com/users/hansemannn/following{/other_user}","gists_url":"https://api.github.com/users/hansemannn/gists{/gist_id}","starred_url":"https://api.github.com/users/hansemannn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansemannn/subscriptions","organizations_url":"https://api.github.com/users/hansemannn/orgs","repos_url":"https://api.github.com/users/hansemannn/repos","events_url":"https://api.github.com/users/hansemannn/events{/privacy}","received_events_url":"https://api.github.com/users/hansemannn/received_events","type":"User","site_admin":false},"body":"Check it again:\r\n```objc\r\nNSDictionary* evt = [NSDictionary dictionaryWithObjectsAndKeys:[TiUtils stringValue:request], @\"url\", @\"Webview did not load blacklisted url.\", @\"messsage\", nil];\r\n```\r\n\r\nuses the variable `request` which is no `NSURL` (which should also be received correctly).","created_at":"2016-05-26T19:22:48Z","updated_at":"2016-05-26T19:22:48Z","html_url":"https://github.com/appcelerator/titanium_mobile/pull/8019#discussion_r64805058","pull_request_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/64805058"},"html":{"href":"https://github.com/appcelerator/titanium_mobile/pull/8019#discussion_r64805058"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019","id":71433370,"html_url":"https://github.com/appcelerator/titanium_mobile/pull/8019","diff_url":"https://github.com/appcelerator/titanium_mobile/pull/8019.diff","patch_url":"https://github.com/appcelerator/titanium_mobile/pull/8019.patch","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/8019","number":8019,"state":"open","locked":false,"title":"[TIMOB-23327] iOS:  Introducing onStopBlackListUrl and blacklistFirstLoad property","user":{"login":"AngelkPetkov","id":14097072,"avatar_url":"https://avatars.githubusercontent.com/u/14097072?v=3","gravatar_id":"","url":"https://api.github.com/users/AngelkPetkov","html_url":"https://github.com/AngelkPetkov","followers_url":"https://api.github.com/users/AngelkPetkov/followers","following_url":"https://api.github.com/users/AngelkPetkov/following{/other_user}","gists_url":"https://api.github.com/users/AngelkPetkov/gists{/gist_id}","starred_url":"https://api.github.com/users/AngelkPetkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngelkPetkov/subscriptions","organizations_url":"https://api.github.com/users/AngelkPetkov/orgs","repos_url":"https://api.github.com/users/AngelkPetkov/repos","events_url":"https://api.github.com/users/AngelkPetkov/events{/privacy}","received_events_url":"https://api.github.com/users/AngelkPetkov/received_events","type":"User","site_admin":false},"body":"[JIRA](https://jira.appcelerator.org/browse/TIMOB-23327?filter=-1)","created_at":"2016-05-25T17:41:56Z","updated_at":"2016-05-26T19:22:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6aaa56fe67292de92670dd1d65b11ea9bb992e2","assignee":{"login":"hansemannn","id":10667698,"avatar_url":"https://avatars.githubusercontent.com/u/10667698?v=3","gravatar_id":"","url":"https://api.github.com/users/hansemannn","html_url":"https://github.com/hansemannn","followers_url":"https://api.github.com/users/hansemannn/followers","following_url":"https://api.github.com/users/hansemannn/following{/other_user}","gists_url":"https://api.github.com/users/hansemannn/gists{/gist_id}","starred_url":"https://api.github.com/users/hansemannn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hansemannn/subscriptions","organizations_url":"https://api.github.com/users/hansemannn/orgs","repos_url":"https://api.github.com/users/hansemannn/repos","events_url":"https://api.github.com/users/hansemannn/events{/privacy}","received_events_url":"https://api.github.com/users/hansemannn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019/commits","review_comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019/comments","review_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/8019/comments","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile/statuses/eed9451378c0ab016c24883e88a1c48fbb8351f4","head":{"label":"AngelkPetkov:TIMOB-23327","ref":"TIMOB-23327","sha":"eed9451378c0ab016c24883e88a1c48fbb8351f4","user":{"login":"AngelkPetkov","id":14097072,"avatar_url":"https://avatars.githubusercontent.com/u/14097072?v=3","gravatar_id":"","url":"https://api.github.com/users/AngelkPetkov","html_url":"https://github.com/AngelkPetkov","followers_url":"https://api.github.com/users/AngelkPetkov/followers","following_url":"https://api.github.com/users/AngelkPetkov/following{/other_user}","gists_url":"https://api.github.com/users/AngelkPetkov/gists{/gist_id}","starred_url":"https://api.github.com/users/AngelkPetkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngelkPetkov/subscriptions","organizations_url":"https://api.github.com/users/AngelkPetkov/orgs","repos_url":"https://api.github.com/users/AngelkPetkov/repos","events_url":"https://api.github.com/users/AngelkPetkov/events{/privacy}","received_events_url":"https://api.github.com/users/AngelkPetkov/received_events","type":"User","site_admin":false},"repo":{"id":42147776,"name":"titanium_mobile","full_name":"AngelkPetkov/titanium_mobile","owner":{"login":"AngelkPetkov","id":14097072,"avatar_url":"https://avatars.githubusercontent.com/u/14097072?v=3","gravatar_id":"","url":"https://api.github.com/users/AngelkPetkov","html_url":"https://github.com/AngelkPetkov","followers_url":"https://api.github.com/users/AngelkPetkov/followers","following_url":"https://api.github.com/users/AngelkPetkov/following{/other_user}","gists_url":"https://api.github.com/users/AngelkPetkov/gists{/gist_id}","starred_url":"https://api.github.com/users/AngelkPetkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngelkPetkov/subscriptions","organizations_url":"https://api.github.com/users/AngelkPetkov/orgs","repos_url":"https://api.github.com/users/AngelkPetkov/repos","events_url":"https://api.github.com/users/AngelkPetkov/events{/privacy}","received_events_url":"https://api.github.com/users/AngelkPetkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AngelkPetkov/titanium_mobile","description":"Appcelerator Titanium Mobile","fork":true,"url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile","forks_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/forks","keys_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/teams","hooks_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/hooks","issue_events_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/issues/events{/number}","events_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/events","assignees_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/assignees{/user}","branches_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/branches{/branch}","tags_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/tags","blobs_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/languages","stargazers_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/stargazers","contributors_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/contributors","subscribers_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/subscribers","subscription_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/subscription","commits_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/contents/{+path}","compare_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/merges","archive_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/downloads","issues_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/issues{/number}","pulls_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/labels{/name}","releases_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/releases{/id}","deployments_url":"https://api.github.com/repos/AngelkPetkov/titanium_mobile/deployments","created_at":"2015-09-09T01:05:07Z","updated_at":"2016-02-17T17:47:46Z","pushed_at":"2016-05-26T19:11:14Z","git_url":"git://github.com/AngelkPetkov/titanium_mobile.git","ssh_url":"git@github.com:AngelkPetkov/titanium_mobile.git","clone_url":"https://github.com/AngelkPetkov/titanium_mobile.git","svn_url":"https://github.com/AngelkPetkov/titanium_mobile","homepage":"http://www.appcelerator.com","size":1015040,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"2a1d6d3c649c07897a74f1fb846079c1d86c9ab8","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":228094,"name":"titanium_mobile","full_name":"appcelerator/titanium_mobile","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/titanium_mobile","description":"Appcelerator Titanium Mobile","fork":false,"url":"https://api.github.com/repos/appcelerator/titanium_mobile","forks_url":"https://api.github.com/repos/appcelerator/titanium_mobile/forks","keys_url":"https://api.github.com/repos/appcelerator/titanium_mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/titanium_mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/titanium_mobile/teams","hooks_url":"https://api.github.com/repos/appcelerator/titanium_mobile/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile/events","assignees_url":"https://api.github.com/repos/appcelerator/titanium_mobile/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/titanium_mobile/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile/tags","blobs_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/titanium_mobile/languages","stargazers_url":"https://api.github.com/repos/appcelerator/titanium_mobile/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/titanium_mobile/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/titanium_mobile/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/titanium_mobile/subscription","commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/titanium_mobile/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/titanium_mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/titanium_mobile/merges","archive_url":"https://api.github.com/repos/appcelerator/titanium_mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/titanium_mobile/downloads","issues_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/titanium_mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/titanium_mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/titanium_mobile/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/deployments","created_at":"2009-06-15T22:54:37Z","updated_at":"2016-05-24T08:34:39Z","pushed_at":"2016-05-26T19:11:15Z","git_url":"git://github.com/appcelerator/titanium_mobile.git","ssh_url":"git@github.com:appcelerator/titanium_mobile.git","clone_url":"https://github.com/appcelerator/titanium_mobile.git","svn_url":"https://github.com/appcelerator/titanium_mobile","homepage":"http://www.appcelerator.com","size":1122531,"stargazers_count":2081,"watchers_count":2081,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1103,"mirror_url":null,"open_issues_count":28,"forks":1103,"open_issues":28,"watchers":2081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019"},"html":{"href":"https://github.com/appcelerator/titanium_mobile/pull/8019"},"issue":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/8019"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/8019/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/8019/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/statuses/eed9451378c0ab016c24883e88a1c48fbb8351f4"}}}}
{"actor":{"display_login":"hansemannn"}}