{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan/pulls/comments/68784480","id":68784480,"diff_hunk":"@@ -47,30 +47,40 @@\n include (SeqAnUsabilityAnalyzer)\n include (CheckCXXCompilerFlag)\n \n+set (COMPILER_CLANG FALSE)\n+set (COMPILER_GNU FALSE)\n+set (COMPILER_INTEL FALSE)\n+set (COMPILER_WINTEL FALSE)\n+set (COMPILER_MSVC FALSE)\n+set (STDLIB_VS ${MSVC})\n+\n+if (CMAKE_CXX_COMPILER_ID MATCHES \"Clang\")\n+  set (COMPILER_CLANG TRUE)\n+elseif (CMAKE_CXX_COMPILER_ID MATCHES \"Intel\" AND STDLIB_VS)\n+  set (COMPILER_WINTEL TRUE)\n+elseif (CMAKE_CXX_COMPILER_ID MATCHES \"Intel\")\n+  set (COMPILER_INTEL TRUE)\n+elseif (CMAKE_CXX_COMPILER_ID MATCHES \"GNU\")\n+  set (COMPILER_GNU TRUE)\n+elseif (CMAKE_CXX_COMPILER_ID MATCHES \"MSVC\")\n+  set (COMPILER_MSVC TRUE)\n+endif ()\n+\n # ---------------------------------------------------------------------------\n # Enable /bigobj flag on Windows.\n # ---------------------------------------------------------------------------\n \n # We need the /bigobj switch on windows (for 64 bit builds only actually).\n # Set target system to be Windows Vista and later.\n-if (MSVC)\n-  add_definitions (/bigobj /D_WIN32_WINNT=0x0600 /DWINVER=0x0600)\n-elseif (MINGW)\n-  add_definitions (-D_WIN32_WINNT=0x0600 -DWINVER=0x0600)\n-endif (MSVC)\n-\n-# ---------------------------------------------------------------------------\n-# Set architecture for MinGW.\n-#\n-# If we do not set i586 as the architecture for MinGW then generating atomic\n-# expressions will fail.\n-# ---------------------------------------------------------------------------\n+if (COMPILER_MSVC OR COMPILER_WINTEL)\n+    # Set /bigobj for COMPILER_MSVC and COMPILER_WINTEL, but COMPILER_CLANG on\n+    # windows (clang/c2 3.7) can not handle it.\n+    add_definitions (/bigobj)\n+endif()\n \n-if (MINGW)\n-\tif (\"${CMAKE_SIZEOF_VOID_P}\" EQUAL \"4\")\n-\t    set (CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -march=i586\")\n-\tendif (\"${CMAKE_SIZEOF_VOID_P}\" EQUAL \"4\")\n-endif (MINGW)\n+if (STDLIB_VS)\n+    add_definitions (-D_WIN32_WINNT=0x0600 -DWINVER=0x0600)","path":"util/cmake/SeqAnBuildSystem.cmake","position":53,"original_position":53,"commit_id":"ac1d0b495f95a24eab981b443c6a636048e6d08c","original_commit_id":"ac1d0b495f95a24eab981b443c6a636048e6d08c","user":{"login":"h-2","id":2996863,"avatar_url":"https://avatars.githubusercontent.com/u/2996863?v=3","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"body":"Whats this stuff? [I know it was there before, but why?]","created_at":"2016-06-28T15:48:24Z","updated_at":"2016-06-28T15:48:24Z","html_url":"https://github.com/seqan/seqan/pull/1767#discussion_r68784480","pull_request_url":"https://api.github.com/repos/seqan/seqan/pulls/1767","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan/pulls/comments/68784480"},"html":{"href":"https://github.com/seqan/seqan/pull/1767#discussion_r68784480"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1767"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan/pulls/1767","id":75493131,"html_url":"https://github.com/seqan/seqan/pull/1767","diff_url":"https://github.com/seqan/seqan/pull/1767.diff","patch_url":"https://github.com/seqan/seqan/pull/1767.patch","issue_url":"https://api.github.com/repos/seqan/seqan/issues/1767","number":1767,"state":"open","locked":false,"title":"Support intel and clang on windows","user":{"login":"marehr","id":103778,"avatar_url":"https://avatars.githubusercontent.com/u/103778?v=3","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"body":"Fixes\r\n* #1730,\r\n* #1274 \r\n  - add support for windows/icc and \r\n* #1385 \r\n  - adapt the platform detection to accommodate for MSCV and CLANG being defined\r\n  - test and fix broken stuff","created_at":"2016-06-28T15:01:17Z","updated_at":"2016-06-28T15:48:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda29fc735ec003038722bff9fdb16052eaebf97","assignee":{"login":"h-2","id":2996863,"avatar_url":"https://avatars.githubusercontent.com/u/2996863?v=3","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"assignees":[{"login":"h-2","id":2996863,"avatar_url":"https://avatars.githubusercontent.com/u/2996863?v=3","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/seqan/seqan/milestones/8","html_url":"https://github.com/seqan/seqan/milestones/Release%202.2.0","labels_url":"https://api.github.com/repos/seqan/seqan/milestones/8/labels","id":1522535,"number":8,"title":"Release 2.2.0","description":"","creator":{"login":"h-2","id":2996863,"avatar_url":"https://avatars.githubusercontent.com/u/2996863?v=3","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":109,"state":"open","created_at":"2016-01-20T14:26:09Z","updated_at":"2016-06-28T15:01:17Z","due_on":"2016-06-29T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/seqan/seqan/pulls/1767/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan/pulls/1767/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan/issues/1767/comments","statuses_url":"https://api.github.com/repos/seqan/seqan/statuses/ac1d0b495f95a24eab981b443c6a636048e6d08c","head":{"label":"marehr:support_intel_clang_windows","ref":"support_intel_clang_windows","sha":"ac1d0b495f95a24eab981b443c6a636048e6d08c","user":{"login":"marehr","id":103778,"avatar_url":"https://avatars.githubusercontent.com/u/103778?v=3","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"repo":{"id":42984291,"name":"seqan","full_name":"marehr/seqan","owner":{"login":"marehr","id":103778,"avatar_url":"https://avatars.githubusercontent.com/u/103778?v=3","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marehr/seqan","description":"SeqAn's official repository.","fork":true,"url":"https://api.github.com/repos/marehr/seqan","forks_url":"https://api.github.com/repos/marehr/seqan/forks","keys_url":"https://api.github.com/repos/marehr/seqan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marehr/seqan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marehr/seqan/teams","hooks_url":"https://api.github.com/repos/marehr/seqan/hooks","issue_events_url":"https://api.github.com/repos/marehr/seqan/issues/events{/number}","events_url":"https://api.github.com/repos/marehr/seqan/events","assignees_url":"https://api.github.com/repos/marehr/seqan/assignees{/user}","branches_url":"https://api.github.com/repos/marehr/seqan/branches{/branch}","tags_url":"https://api.github.com/repos/marehr/seqan/tags","blobs_url":"https://api.github.com/repos/marehr/seqan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marehr/seqan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marehr/seqan/git/refs{/sha}","trees_url":"https://api.github.com/repos/marehr/seqan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marehr/seqan/statuses/{sha}","languages_url":"https://api.github.com/repos/marehr/seqan/languages","stargazers_url":"https://api.github.com/repos/marehr/seqan/stargazers","contributors_url":"https://api.github.com/repos/marehr/seqan/contributors","subscribers_url":"https://api.github.com/repos/marehr/seqan/subscribers","subscription_url":"https://api.github.com/repos/marehr/seqan/subscription","commits_url":"https://api.github.com/repos/marehr/seqan/commits{/sha}","git_commits_url":"https://api.github.com/repos/marehr/seqan/git/commits{/sha}","comments_url":"https://api.github.com/repos/marehr/seqan/comments{/number}","issue_comment_url":"https://api.github.com/repos/marehr/seqan/issues/comments{/number}","contents_url":"https://api.github.com/repos/marehr/seqan/contents/{+path}","compare_url":"https://api.github.com/repos/marehr/seqan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marehr/seqan/merges","archive_url":"https://api.github.com/repos/marehr/seqan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marehr/seqan/downloads","issues_url":"https://api.github.com/repos/marehr/seqan/issues{/number}","pulls_url":"https://api.github.com/repos/marehr/seqan/pulls{/number}","milestones_url":"https://api.github.com/repos/marehr/seqan/milestones{/number}","notifications_url":"https://api.github.com/repos/marehr/seqan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marehr/seqan/labels{/name}","releases_url":"https://api.github.com/repos/marehr/seqan/releases{/id}","deployments_url":"https://api.github.com/repos/marehr/seqan/deployments","created_at":"2015-09-23T07:05:58Z","updated_at":"2016-02-15T16:15:06Z","pushed_at":"2016-06-28T14:47:45Z","git_url":"git://github.com/marehr/seqan.git","ssh_url":"git@github.com:marehr/seqan.git","clone_url":"https://github.com/marehr/seqan.git","svn_url":"https://github.com/marehr/seqan","homepage":"www.seqan.de","size":148318,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"seqan:develop","ref":"develop","sha":"d020b252cbccfbb4f98d3277e3047f9f42b67f87","user":{"login":"seqan","id":1752144,"avatar_url":"https://avatars.githubusercontent.com/u/1752144?v=3","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":6383869,"name":"seqan","full_name":"seqan/seqan","owner":{"login":"seqan","id":1752144,"avatar_url":"https://avatars.githubusercontent.com/u/1752144?v=3","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seqan/seqan","description":"SeqAn's official repository.","fork":false,"url":"https://api.github.com/repos/seqan/seqan","forks_url":"https://api.github.com/repos/seqan/seqan/forks","keys_url":"https://api.github.com/repos/seqan/seqan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan/teams","hooks_url":"https://api.github.com/repos/seqan/seqan/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan/events","assignees_url":"https://api.github.com/repos/seqan/seqan/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan/tags","blobs_url":"https://api.github.com/repos/seqan/seqan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan/subscription","commits_url":"https://api.github.com/repos/seqan/seqan/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan/merges","archive_url":"https://api.github.com/repos/seqan/seqan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan/downloads","issues_url":"https://api.github.com/repos/seqan/seqan/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan/deployments","created_at":"2012-10-25T08:02:15Z","updated_at":"2016-06-25T17:20:30Z","pushed_at":"2016-06-28T15:01:17Z","git_url":"git://github.com/seqan/seqan.git","ssh_url":"git@github.com:seqan/seqan.git","clone_url":"https://github.com/seqan/seqan.git","svn_url":"https://github.com/seqan/seqan","homepage":"www.seqan.de","size":157143,"stargazers_count":148,"watchers_count":148,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":151,"forks":76,"open_issues":151,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1767"},"html":{"href":"https://github.com/seqan/seqan/pull/1767"},"issue":{"href":"https://api.github.com/repos/seqan/seqan/issues/1767"},"comments":{"href":"https://api.github.com/repos/seqan/seqan/issues/1767/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1767/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan/pulls/1767/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan/statuses/ac1d0b495f95a24eab981b443c6a636048e6d08c"}}}}
{"actor":{"display_login":"h-2"}}