{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/72730205","id":72730205,"diff_hunk":"@@ -189,7 +187,7 @@ static bool ClientAllowed(const CNetAddr& netaddr)\n {\n     if (!netaddr.IsValid())\n         return false;\n-    BOOST_FOREACH (const CSubNet& subnet, rpc_allow_subnets)\n+    for(const CSubNet& subnet : rpc_allow_subnets)","path":"src/httpserver.cpp","position":93,"original_position":93,"commit_id":"7e87033447149e54d9b5ab2f90ad3a7ed094d784","original_commit_id":"7e87033447149e54d9b5ab2f90ad3a7ed094d784","user":{"login":"dcousens","id":413395,"avatar_url":"https://avatars.githubusercontent.com/u/413395?v=3","gravatar_id":"","url":"https://api.github.com/users/dcousens","html_url":"https://github.com/dcousens","followers_url":"https://api.github.com/users/dcousens/followers","following_url":"https://api.github.com/users/dcousens/following{/other_user}","gists_url":"https://api.github.com/users/dcousens/gists{/gist_id}","starred_url":"https://api.github.com/users/dcousens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcousens/subscriptions","organizations_url":"https://api.github.com/users/dcousens/orgs","repos_url":"https://api.github.com/users/dcousens/repos","events_url":"https://api.github.com/users/dcousens/events{/privacy}","received_events_url":"https://api.github.com/users/dcousens/received_events","type":"User","site_admin":false},"body":"nit: `s/for(/for (/` for consistency","created_at":"2016-07-29T01:19:06Z","updated_at":"2016-07-29T01:19:06Z","html_url":"https://github.com/bitcoin/bitcoin/pull/8421#discussion_r72730205","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/72730205"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8421#discussion_r72730205"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421","id":79284265,"html_url":"https://github.com/bitcoin/bitcoin/pull/8421","diff_url":"https://github.com/bitcoin/bitcoin/pull/8421.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8421.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8421","number":8421,"state":"open","locked":false,"title":"httpserver: drop boost (#8023 dependency)","user":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"body":"This is a prerequisite for #8023. The httpserver depends on boost::thread::try_join_for, which has no equivalent in std::thread. Rather than going to the effort of porting try_join_for to our interruptible thread wrapper, it's simpler and more efficient to not rely on it in the first place.\r\n\r\n755aa05174e06effd758eeb78c5af9fb465e9611 replaces the try_join_for with a future which is set when the callable function finishes. The flow is otherwise the same. I tested that this works as intended by inserting sleeps to force the event_base_loopbreak.\r\n\r\nd3773ca9aeb0d2f12dc0c5a0726778050c8cb455 Fixes an incompatibility between boost and std threads. This was likely to be an issue in the future with boost anyway.\r\n\r\nLastly, with the incompatibilities removed, just go ahead and switch to std::thread since there's need for interruption here.","created_at":"2016-07-28T23:14:40Z","updated_at":"2016-07-29T01:19:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec32845a36142625d3ce0dcee65780321bed8ed4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8421/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/7e87033447149e54d9b5ab2f90ad3a7ed094d784","head":{"label":"theuni:http-thread","ref":"http-thread","sha":"7e87033447149e54d9b5ab2f90ad3a7ed094d784","user":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"repo":{"id":10302141,"name":"bitcoin","full_name":"theuni/bitcoin","owner":{"login":"theuni","id":417043,"avatar_url":"https://avatars.githubusercontent.com/u/417043?v=3","gravatar_id":"","url":"https://api.github.com/users/theuni","html_url":"https://github.com/theuni","followers_url":"https://api.github.com/users/theuni/followers","following_url":"https://api.github.com/users/theuni/following{/other_user}","gists_url":"https://api.github.com/users/theuni/gists{/gist_id}","starred_url":"https://api.github.com/users/theuni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theuni/subscriptions","organizations_url":"https://api.github.com/users/theuni/orgs","repos_url":"https://api.github.com/users/theuni/repos","events_url":"https://api.github.com/users/theuni/events{/privacy}","received_events_url":"https://api.github.com/users/theuni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theuni/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/theuni/bitcoin","forks_url":"https://api.github.com/repos/theuni/bitcoin/forks","keys_url":"https://api.github.com/repos/theuni/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theuni/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theuni/bitcoin/teams","hooks_url":"https://api.github.com/repos/theuni/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/theuni/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/theuni/bitcoin/events","assignees_url":"https://api.github.com/repos/theuni/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/theuni/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/theuni/bitcoin/tags","blobs_url":"https://api.github.com/repos/theuni/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theuni/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theuni/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/theuni/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theuni/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/theuni/bitcoin/languages","stargazers_url":"https://api.github.com/repos/theuni/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/theuni/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/theuni/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/theuni/bitcoin/subscription","commits_url":"https://api.github.com/repos/theuni/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/theuni/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/theuni/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/theuni/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/theuni/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/theuni/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theuni/bitcoin/merges","archive_url":"https://api.github.com/repos/theuni/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theuni/bitcoin/downloads","issues_url":"https://api.github.com/repos/theuni/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/theuni/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/theuni/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/theuni/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theuni/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/theuni/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/theuni/bitcoin/deployments","created_at":"2013-05-26T18:55:06Z","updated_at":"2016-05-04T03:36:21Z","pushed_at":"2016-07-29T00:25:31Z","git_url":"git://github.com/theuni/bitcoin.git","ssh_url":"git@github.com:theuni/bitcoin.git","clone_url":"https://github.com/theuni/bitcoin.git","svn_url":"https://github.com/theuni/bitcoin","homepage":"http://www.bitcoin.org","size":72986,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":3,"default_branch":"trivial-next"}},"base":{"label":"bitcoin:master","ref":"master","sha":"ad087638ee4864d6244ec9381ff764bfa6ee5086","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2016-07-29T00:30:59Z","pushed_at":"2016-07-28T23:19:28Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":137545,"stargazers_count":9585,"watchers_count":9585,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6399,"mirror_url":null,"open_issues_count":496,"forks":6399,"open_issues":496,"watchers":9585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/8421"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8421"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/8421/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8421/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/7e87033447149e54d9b5ab2f90ad3a7ed094d784"}}}}
{"actor":{"display_login":"dcousens"}}