{"action":"created","issue":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/3527","repository_url":"https://api.github.com/repos/syncthing/syncthing","labels_url":"https://api.github.com/repos/syncthing/syncthing/issues/3527/labels{/name}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/3527/comments","events_url":"https://api.github.com/repos/syncthing/syncthing/issues/3527/events","html_url":"https://github.com/syncthing/syncthing/pull/3527","id":172243297,"number":3527,"title":"lib/model, lib/scanner: Efficient inserts/deletes in the middle of the file","user":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":44,"created_at":"2016-08-20T00:31:05Z","updated_at":"2016-11-07T16:21:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/3527","html_url":"https://github.com/syncthing/syncthing/pull/3527","diff_url":"https://github.com/syncthing/syncthing/pull/3527.diff","patch_url":"https://github.com/syncthing/syncthing/pull/3527.patch"},"body":"### Purpose\n\nReview with &w=1\nUses a weak rolling hash to identify shifted blocks.\nPotentially a DoS surface, by forcing us to hash the file `size_of_file` times with SHA256 since the weak hash can collide fairly easily?\n\nYet there are other ways to do a similar thing I guess, such as providing blocks with the incorrect hash to start with, but that is somewhat limited by the network speed.\n\nAlso probably needs some tests, as I haven't checked if it actually works.\n"},"comment":{"url":"https://api.github.com/repos/syncthing/syncthing/issues/comments/258882373","html_url":"https://github.com/syncthing/syncthing/pull/3527#issuecomment-258882373","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/3527","id":258882373,"user":{"login":"calmh","id":125426,"avatar_url":"https://avatars.githubusercontent.com/u/125426?v=3","gravatar_id":"","url":"https://api.github.com/users/calmh","html_url":"https://github.com/calmh","followers_url":"https://api.github.com/users/calmh/followers","following_url":"https://api.github.com/users/calmh/following{/other_user}","gists_url":"https://api.github.com/users/calmh/gists{/gist_id}","starred_url":"https://api.github.com/users/calmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmh/subscriptions","organizations_url":"https://api.github.com/users/calmh/orgs","repos_url":"https://api.github.com/users/calmh/repos","events_url":"https://api.github.com/users/calmh/events{/privacy}","received_events_url":"https://api.github.com/users/calmh/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T16:21:10Z","updated_at":"2016-11-07T16:21:10Z","body":"OK LGTM except I very much dislike adding another megabyte of binary crap to the repo just for testing. It should be enough with like a kilobyte of data?"}}
{"actor":{"display_login":"calmh"}}