{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/90760753","pull_request_review_id":11280195,"id":90760753,"diff_hunk":"@@ -1498,9 +1498,9 @@ public function buildInstanceAndButtons() {\n \n     $this->assign('instanceForm', $this->_instanceForm);\n \n-    // CRM-16274 Determine if user has 'edit all contacts' or equivalent\n-    $permission = CRM_Core_Permission::getPermission();\n-    if ($permission == CRM_Core_Permission::EDIT &&\n+    // CRM-19330 - check that the user has Edit All Groups permissions.\n+    $permission = CRM_Core_Permission::check(CRM_Core_Permission::EDIT_GROUPS);\n+    if ($permission  &&","path":"CRM/Report/Form.php","position":9,"original_position":9,"commit_id":"9578eb6760dd8bc1b21e9b10e9a540dbcfdd7bd4","original_commit_id":"9578eb6760dd8bc1b21e9b10e9a540dbcfdd7bd4","user":{"login":"spalmstr","id":10037367,"avatar_url":"https://avatars.githubusercontent.com/u/10037367?v=3","gravatar_id":"","url":"https://api.github.com/users/spalmstr","html_url":"https://github.com/spalmstr","followers_url":"https://api.github.com/users/spalmstr/followers","following_url":"https://api.github.com/users/spalmstr/following{/other_user}","gists_url":"https://api.github.com/users/spalmstr/gists{/gist_id}","starred_url":"https://api.github.com/users/spalmstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalmstr/subscriptions","organizations_url":"https://api.github.com/users/spalmstr/orgs","repos_url":"https://api.github.com/users/spalmstr/repos","events_url":"https://api.github.com/users/spalmstr/events{/privacy}","received_events_url":"https://api.github.com/users/spalmstr/received_events","type":"User","site_admin":false},"body":"I may have misunderstood the meaning of Edit All Groups.","created_at":"2016-12-03T16:59:41Z","updated_at":"2016-12-03T16:59:42Z","html_url":"https://github.com/civicrm/civicrm-core/pull/9202#discussion_r90760753","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/90760753"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/9202#discussion_r90760753"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202","id":88644007,"html_url":"https://github.com/civicrm/civicrm-core/pull/9202","diff_url":"https://github.com/civicrm/civicrm-core/pull/9202.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/9202.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9202","number":9202,"state":"open","locked":false,"title":"CRM-19330 Add Contacts to Group appears and Action do nothing for non-privileged users.","user":{"login":"spalmstr","id":10037367,"avatar_url":"https://avatars.githubusercontent.com/u/10037367?v=3","gravatar_id":"","url":"https://api.github.com/users/spalmstr","html_url":"https://github.com/spalmstr","followers_url":"https://api.github.com/users/spalmstr/followers","following_url":"https://api.github.com/users/spalmstr/following{/other_user}","gists_url":"https://api.github.com/users/spalmstr/gists{/gist_id}","starred_url":"https://api.github.com/users/spalmstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalmstr/subscriptions","organizations_url":"https://api.github.com/users/spalmstr/orgs","repos_url":"https://api.github.com/users/spalmstr/repos","events_url":"https://api.github.com/users/spalmstr/events{/privacy}","received_events_url":"https://api.github.com/users/spalmstr/received_events","type":"User","site_admin":false},"body":"Add Contacts to Group appears and Action do nothing for non-privileged\nusers.\n\n---\n- [CRM-19330: Add Contacts to Group appears and Action do nothing for non-privileged users under Joomla](https://issues.civicrm.org/jira/browse/CRM-19330)\n","created_at":"2016-10-10T11:02:57Z","updated_at":"2016-12-03T16:59:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c39404c701c7e68f154d808ade72a31a1ac5b73d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/9202/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/9578eb6760dd8bc1b21e9b10e9a540dbcfdd7bd4","head":{"label":"spalmstr:CRM-19330","ref":"CRM-19330","sha":"9578eb6760dd8bc1b21e9b10e9a540dbcfdd7bd4","user":{"login":"spalmstr","id":10037367,"avatar_url":"https://avatars.githubusercontent.com/u/10037367?v=3","gravatar_id":"","url":"https://api.github.com/users/spalmstr","html_url":"https://github.com/spalmstr","followers_url":"https://api.github.com/users/spalmstr/followers","following_url":"https://api.github.com/users/spalmstr/following{/other_user}","gists_url":"https://api.github.com/users/spalmstr/gists{/gist_id}","starred_url":"https://api.github.com/users/spalmstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalmstr/subscriptions","organizations_url":"https://api.github.com/users/spalmstr/orgs","repos_url":"https://api.github.com/users/spalmstr/repos","events_url":"https://api.github.com/users/spalmstr/events{/privacy}","received_events_url":"https://api.github.com/users/spalmstr/received_events","type":"User","site_admin":false},"repo":{"id":70273415,"name":"civicrm-core","full_name":"spalmstr/civicrm-core","owner":{"login":"spalmstr","id":10037367,"avatar_url":"https://avatars.githubusercontent.com/u/10037367?v=3","gravatar_id":"","url":"https://api.github.com/users/spalmstr","html_url":"https://github.com/spalmstr","followers_url":"https://api.github.com/users/spalmstr/followers","following_url":"https://api.github.com/users/spalmstr/following{/other_user}","gists_url":"https://api.github.com/users/spalmstr/gists{/gist_id}","starred_url":"https://api.github.com/users/spalmstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalmstr/subscriptions","organizations_url":"https://api.github.com/users/spalmstr/orgs","repos_url":"https://api.github.com/users/spalmstr/repos","events_url":"https://api.github.com/users/spalmstr/events{/privacy}","received_events_url":"https://api.github.com/users/spalmstr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spalmstr/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/spalmstr/civicrm-core","forks_url":"https://api.github.com/repos/spalmstr/civicrm-core/forks","keys_url":"https://api.github.com/repos/spalmstr/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spalmstr/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spalmstr/civicrm-core/teams","hooks_url":"https://api.github.com/repos/spalmstr/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/spalmstr/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/spalmstr/civicrm-core/events","assignees_url":"https://api.github.com/repos/spalmstr/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/spalmstr/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/spalmstr/civicrm-core/tags","blobs_url":"https://api.github.com/repos/spalmstr/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spalmstr/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spalmstr/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/spalmstr/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spalmstr/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/spalmstr/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/spalmstr/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/spalmstr/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/spalmstr/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/spalmstr/civicrm-core/subscription","commits_url":"https://api.github.com/repos/spalmstr/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/spalmstr/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/spalmstr/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/spalmstr/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/spalmstr/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/spalmstr/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spalmstr/civicrm-core/merges","archive_url":"https://api.github.com/repos/spalmstr/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spalmstr/civicrm-core/downloads","issues_url":"https://api.github.com/repos/spalmstr/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/spalmstr/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/spalmstr/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/spalmstr/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spalmstr/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/spalmstr/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/spalmstr/civicrm-core/deployments","created_at":"2016-10-07T18:40:28Z","updated_at":"2016-10-07T18:40:42Z","pushed_at":"2016-11-16T14:01:26Z","git_url":"git://github.com/spalmstr/civicrm-core.git","ssh_url":"git@github.com:spalmstr/civicrm-core.git","clone_url":"https://github.com/spalmstr/civicrm-core.git","svn_url":"https://github.com/spalmstr/civicrm-core","homepage":null,"size":132040,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"5a929c12f4c449877c51a49207a029dffffb8a38","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2016-11-13T19:22:12Z","pushed_at":"2016-12-03T05:17:19Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":173505,"stargazers_count":174,"watchers_count":174,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":504,"mirror_url":null,"open_issues_count":121,"forks":504,"open_issues":121,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/9202"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/9202"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/9202/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/9202/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/9578eb6760dd8bc1b21e9b10e9a540dbcfdd7bd4"}}}}
{"actor":{"display_login":"spalmstr"}}