{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/82256637","pull_request_review_id":3177145,"id":82256637,"diff_hunk":"@@ -0,0 +1,298 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.beam.runners.direct;\n+\n+import com.google.auto.value.AutoValue;\n+import com.google.common.base.Objects;\n+import com.google.common.collect.ImmutableList;\n+import java.util.ArrayList;\n+import java.util.Arrays;\n+import java.util.Map;\n+import java.util.Map.Entry;\n+import java.util.Set;\n+import java.util.concurrent.ConcurrentHashMap;\n+import java.util.concurrent.ConcurrentMap;\n+import java.util.concurrent.ExecutorService;\n+import java.util.concurrent.Executors;\n+import java.util.concurrent.atomic.AtomicReference;\n+import org.apache.beam.runners.direct.DirectRunner.CommittedBundle;\n+import org.apache.beam.sdk.metrics.DistributionData;\n+import org.apache.beam.sdk.metrics.DistributionResult;\n+import org.apache.beam.sdk.metrics.MetricKey;\n+import org.apache.beam.sdk.metrics.MetricName;\n+import org.apache.beam.sdk.metrics.MetricNameFilter;\n+import org.apache.beam.sdk.metrics.MetricQueryResults;\n+import org.apache.beam.sdk.metrics.MetricResult;\n+import org.apache.beam.sdk.metrics.MetricResults;\n+import org.apache.beam.sdk.metrics.MetricUpdates;\n+import org.apache.beam.sdk.metrics.MetricUpdates.MetricUpdate;\n+import org.apache.beam.sdk.metrics.MetricsFilter;\n+import org.apache.beam.sdk.metrics.MetricsMap;\n+\n+/**\n+ * Implementation of {@link MetricResults} for the Direct Runner.\n+ */\n+class DirectMetrics extends MetricResults {\n+\n+  private static final ExecutorService COUNTER_COMMITTER = Executors.newCachedThreadPool();","path":"runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectMetrics.java","position":52,"original_position":52,"commit_id":"d9680a2714c65b88e877c5a7b7b348aa6b7e24b4","original_commit_id":"d9680a2714c65b88e877c5a7b7b348aa6b7e24b4","user":{"login":"tgroh","id":429866,"avatar_url":"https://avatars.githubusercontent.com/u/429866?v=3","gravatar_id":"","url":"https://api.github.com/users/tgroh","html_url":"https://github.com/tgroh","followers_url":"https://api.github.com/users/tgroh/followers","following_url":"https://api.github.com/users/tgroh/following{/other_user}","gists_url":"https://api.github.com/users/tgroh/gists{/gist_id}","starred_url":"https://api.github.com/users/tgroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgroh/subscriptions","organizations_url":"https://api.github.com/users/tgroh/orgs","repos_url":"https://api.github.com/users/tgroh/repos","events_url":"https://api.github.com/users/tgroh/events{/privacy}","received_events_url":"https://api.github.com/users/tgroh/received_events","type":"User","site_admin":false},"body":"We should probably have some shared ThreadPool provided by the runner for internal maintenance.\r\n\r\nFiled https://issues.apache.org/jira/browse/BEAM-723. Please add a comment linking to that JIRA.","created_at":"2016-10-06T18:44:03Z","updated_at":"2016-10-06T18:57:43Z","html_url":"https://github.com/apache/incubator-beam/pull/1024#discussion_r82256637","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1024","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/82256637"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1024#discussion_r82256637"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1024"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/1024","id":87224195,"html_url":"https://github.com/apache/incubator-beam/pull/1024","diff_url":"https://github.com/apache/incubator-beam/pull/1024.diff","patch_url":"https://github.com/apache/incubator-beam/pull/1024.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/1024","number":1024,"state":"open","locked":false,"title":"[BEAM-147] Prototype of Metrics API for Java DirectRunner","user":{"login":"bjchambers","id":35960,"avatar_url":"https://avatars.githubusercontent.com/u/35960?v=3","gravatar_id":"","url":"https://api.github.com/users/bjchambers","html_url":"https://github.com/bjchambers","followers_url":"https://api.github.com/users/bjchambers/followers","following_url":"https://api.github.com/users/bjchambers/following{/other_user}","gists_url":"https://api.github.com/users/bjchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/bjchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjchambers/subscriptions","organizations_url":"https://api.github.com/users/bjchambers/orgs","repos_url":"https://api.github.com/users/bjchambers/repos","events_url":"https://api.github.com/users/bjchambers/events{/privacy}","received_events_url":"https://api.github.com/users/bjchambers/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [*] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [*] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [*] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [*] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n","created_at":"2016-09-29T00:03:33Z","updated_at":"2016-10-06T18:57:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0bf97586aa48b5b49e0924a093c3f78307b772f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/1024/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/d9680a2714c65b88e877c5a7b7b348aa6b7e24b4","head":{"label":"bjchambers:metrics","ref":"metrics","sha":"d9680a2714c65b88e877c5a7b7b348aa6b7e24b4","user":{"login":"bjchambers","id":35960,"avatar_url":"https://avatars.githubusercontent.com/u/35960?v=3","gravatar_id":"","url":"https://api.github.com/users/bjchambers","html_url":"https://github.com/bjchambers","followers_url":"https://api.github.com/users/bjchambers/followers","following_url":"https://api.github.com/users/bjchambers/following{/other_user}","gists_url":"https://api.github.com/users/bjchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/bjchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjchambers/subscriptions","organizations_url":"https://api.github.com/users/bjchambers/orgs","repos_url":"https://api.github.com/users/bjchambers/repos","events_url":"https://api.github.com/users/bjchambers/events{/privacy}","received_events_url":"https://api.github.com/users/bjchambers/received_events","type":"User","site_admin":false},"repo":{"id":53010511,"name":"incubator-beam","full_name":"bjchambers/incubator-beam","owner":{"login":"bjchambers","id":35960,"avatar_url":"https://avatars.githubusercontent.com/u/35960?v=3","gravatar_id":"","url":"https://api.github.com/users/bjchambers","html_url":"https://github.com/bjchambers","followers_url":"https://api.github.com/users/bjchambers/followers","following_url":"https://api.github.com/users/bjchambers/following{/other_user}","gists_url":"https://api.github.com/users/bjchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/bjchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjchambers/subscriptions","organizations_url":"https://api.github.com/users/bjchambers/orgs","repos_url":"https://api.github.com/users/bjchambers/repos","events_url":"https://api.github.com/users/bjchambers/events{/privacy}","received_events_url":"https://api.github.com/users/bjchambers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjchambers/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/bjchambers/incubator-beam","forks_url":"https://api.github.com/repos/bjchambers/incubator-beam/forks","keys_url":"https://api.github.com/repos/bjchambers/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjchambers/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjchambers/incubator-beam/teams","hooks_url":"https://api.github.com/repos/bjchambers/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/bjchambers/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/bjchambers/incubator-beam/events","assignees_url":"https://api.github.com/repos/bjchambers/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/bjchambers/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/bjchambers/incubator-beam/tags","blobs_url":"https://api.github.com/repos/bjchambers/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjchambers/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjchambers/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjchambers/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjchambers/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/bjchambers/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/bjchambers/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/bjchambers/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/bjchambers/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/bjchambers/incubator-beam/subscription","commits_url":"https://api.github.com/repos/bjchambers/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjchambers/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjchambers/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjchambers/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjchambers/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/bjchambers/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjchambers/incubator-beam/merges","archive_url":"https://api.github.com/repos/bjchambers/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjchambers/incubator-beam/downloads","issues_url":"https://api.github.com/repos/bjchambers/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/bjchambers/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/bjchambers/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/bjchambers/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjchambers/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/bjchambers/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/bjchambers/incubator-beam/deployments","created_at":"2016-03-03T01:35:27Z","updated_at":"2016-03-03T01:35:29Z","pushed_at":"2016-10-06T18:02:31Z","git_url":"git://github.com/bjchambers/incubator-beam.git","ssh_url":"git@github.com:bjchambers/incubator-beam.git","clone_url":"https://github.com/bjchambers/incubator-beam.git","svn_url":"https://github.com/bjchambers/incubator-beam","homepage":null,"size":18545,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"087dcef1efc6b7765e203f8aebfd3caf8c4a77de","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-10-06T18:50:58Z","pushed_at":"2016-10-06T18:27:40Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":29352,"stargazers_count":377,"watchers_count":377,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":240,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":55,"forks":240,"open_issues":55,"watchers":377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1024"},"html":{"href":"https://github.com/apache/incubator-beam/pull/1024"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1024"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/d9680a2714c65b88e877c5a7b7b348aa6b7e24b4"}}}}
{"actor":{"display_login":"tgroh"}}