{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-app-android/issues/876","repository_url":"https://api.github.com/repos/edx/edx-app-android","labels_url":"https://api.github.com/repos/edx/edx-app-android/issues/876/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-app-android/issues/876/comments","events_url":"https://api.github.com/repos/edx/edx-app-android/issues/876/events","html_url":"https://github.com/edx/edx-app-android/pull/876","id":188216610,"number":876,"title":"Remove error notifications from NavigationFragment","user":{"login":"1zaman","id":4244109,"avatar_url":"https://avatars.githubusercontent.com/u/4244109?v=3","gravatar_id":"","url":"https://api.github.com/users/1zaman","html_url":"https://github.com/1zaman","followers_url":"https://api.github.com/users/1zaman/followers","following_url":"https://api.github.com/users/1zaman/following{/other_user}","gists_url":"https://api.github.com/users/1zaman/gists{/gist_id}","starred_url":"https://api.github.com/users/1zaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1zaman/subscriptions","organizations_url":"https://api.github.com/users/1zaman/orgs","repos_url":"https://api.github.com/users/1zaman/repos","events_url":"https://api.github.com/users/1zaman/events{/privacy}","received_events_url":"https://api.github.com/users/1zaman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-09T10:46:44Z","updated_at":"2016-11-10T13:44:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-app-android/pulls/876","html_url":"https://github.com/edx/edx-app-android/pull/876","diff_url":"https://github.com/edx/edx-app-android/pull/876.diff","patch_url":"https://github.com/edx/edx-app-android/pull/876.patch"},"body":"### Description\r\n\r\n[MA-2967][]\r\n\r\nSince the navigation drawer usually isn't being displayed, it doesn’t make sense to have it show error notifications to the user. Even when the drawer is open and on display, there's no appropriate area to show a data loading error that’s associated with it. Therefore, this pull request removes the Snackbar error notification logic from calls made by `NavigationFragment`.\r\n\r\nNote that the drawer was also added automatically to many Activities where it wasn’t even used, and was always blocked from opening, and where cases showing an error was completely inappropriate. This was because the default layout of the `BaseSingleFragmentActivity` included the drawer’s layout, and subclasses that didn’t support it (which were the majority) blocked it on a case-by-case basis.\r\n\r\n### Reviewers\r\n\r\nIf you've been tagged for review, please \"Start a review\" with the GitHub GUI.\r\n\r\n- Code review: @miankhalid, @BenjiLee\r\n\r\n[MA-2967]: https://openedx.atlassian.net/browse/MA-2967"},"comment":{"url":"https://api.github.com/repos/edx/edx-app-android/issues/comments/259693049","html_url":"https://github.com/edx/edx-app-android/pull/876#issuecomment-259693049","issue_url":"https://api.github.com/repos/edx/edx-app-android/issues/876","id":259693049,"user":{"login":"1zaman","id":4244109,"avatar_url":"https://avatars.githubusercontent.com/u/4244109?v=3","gravatar_id":"","url":"https://api.github.com/users/1zaman","html_url":"https://github.com/1zaman","followers_url":"https://api.github.com/users/1zaman/followers","following_url":"https://api.github.com/users/1zaman/following{/other_user}","gists_url":"https://api.github.com/users/1zaman/gists{/gist_id}","starred_url":"https://api.github.com/users/1zaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1zaman/subscriptions","organizations_url":"https://api.github.com/users/1zaman/orgs","repos_url":"https://api.github.com/users/1zaman/repos","events_url":"https://api.github.com/users/1zaman/events{/privacy}","received_events_url":"https://api.github.com/users/1zaman/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T13:44:21Z","updated_at":"2016-11-10T13:44:21Z","body":"> It quite easy to reproduce, just tap on report for a comment and before the response arrives tap on report of another comment.\r\n\r\nI managed to reproduce the issue by following these instructions, thanks! It seems that any report action would cause any previous ongoing report calls to be cancelled, and since OkHttp throws an `IOException` in the case of cancellation, this was being interpreted and displayed as a network error. I have fixed the former issue in commit 4f655319065a846f5c29a2935d3325f3a1bfd838 (and opened [`MA-3004`] for a more proper and global fix), and the latter in commit 8d69d2206d90178fe8a2ba9d1b592ae550fef07b.\r\n\r\n[`MA-3004`]: https://openedx.atlassian.net/browse/MA-3004"}}
{"actor":{"display_login":"1zaman"}}