{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/9201","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/9201/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/9201/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/9201/events","html_url":"https://github.com/highfidelity/hifi/pull/9201","id":195368983,"number":9201,"title":"Fix local light shading tiling issue ","user":{"login":"samcake","id":2230265,"avatar_url":"https://avatars.githubusercontent.com/u/2230265?v=3","gravatar_id":"","url":"https://api.github.com/users/samcake","html_url":"https://github.com/samcake","followers_url":"https://api.github.com/users/samcake/followers","following_url":"https://api.github.com/users/samcake/following{/other_user}","gists_url":"https://api.github.com/users/samcake/gists{/gist_id}","starred_url":"https://api.github.com/users/samcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcake/subscriptions","organizations_url":"https://api.github.com/users/samcake/orgs","repos_url":"https://api.github.com/users/samcake/repos","events_url":"https://api.github.com/users/samcake/events{/privacy}","received_events_url":"https://api.github.com/users/samcake/received_events","type":"User","site_admin":false},"labels":[{"id":11332862,"url":"https://api.github.com/repos/highfidelity/hifi/labels/bug","name":"bug","color":"fc2929","default":true},{"id":313595519,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-12-13T21:08:42Z","updated_at":"2016-12-13T23:53:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/9201","html_url":"https://github.com/highfidelity/hifi/pull/9201","diff_url":"https://github.com/highfidelity/hifi/pull/9201.diff","patch_url":"https://github.com/highfidelity/hifi/pull/9201.patch"},"body":"This PR fixes a bug with the light clustering when the light origin is behind the camera. THe light wouldn't get clustered correctly missing the cluster on the edge of the sphere volume.\r\n\r\nA range of clusters along the X and Y axis was wrong in the case the origin of the light clustered was behind the camera. This is was a simplification in the function \"frustumGrid_eyeToClusterPos( vec3 eyePos )\" when the eyePos had a z value out of the valid range. THis is now fixed.\r\n\r\n### Test Plan:\r\nTo help visualize the problem, you can run the script \"developer/utilities/render/lightClustering.js\"\r\nEnable the \"Draw Content\" which will represent a full color for each light volume.\r\nIn RC29 in Welcome standing just in front of the portal, looking on the wall behind, you quickly see these missing tiles in the shading of the light volume at the edge.\r\n<img width=\"1202\" alt=\"capture light clustering problem\" src=\"https://cloud.githubusercontent.com/assets/2230265/21159224/40c50d9a-c135-11e6-8b36-705a41ee7bc3.PNG\">\r\nIN this build, the problem is gone.\r\nI tested in dev-welcome because of the change of protocol for the current master branch compared to RC29\r\n<img width=\"1222\" alt=\"capture light clustering problem fixed\" src=\"https://cloud.githubusercontent.com/assets/2230265/21159228/435dece8-c135-11e6-9119-ad62d15a005d.PNG\">\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/266899773","html_url":"https://github.com/highfidelity/hifi/pull/9201#issuecomment-266899773","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/9201","id":266899773,"user":{"login":"hifi-gustavo","id":4554450,"avatar_url":"https://avatars.githubusercontent.com/u/4554450?v=3","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T23:53:02Z","updated_at":"2016-12-13T23:53:02Z","body":"Build console output for commit: 0b221abfb2e3f23f2674262656eac3194b002372 available at: https://gist.github.com/da3653d7f1782112b1d21bde9b28a7c9<br/><br/>Installers available for download at: <br/>Windows: http://cachefly.highfidelity.com/HighFidelity-Beta-PR9201-0b221ab.exe<br/>OS X: http://cachefly.highfidelity.com/HighFidelity-Beta-PR9201-0b221ab.dmg"}}
{"actor":{"display_login":"hifi-gustavo"}}