{"action":"created","comment":{"url":"https://api.github.com/repos/rdkit/rdkit/pulls/comments/51845433","id":51845433,"diff_hunk":"@@ -376,7 +378,7 @@ fmcs_mol2s_transition(PG_FUNCTION_ARGS) {\n     }\n     if(PG_ARGISNULL(0) && !PG_ARGISNULL(1)) { // first call\n ///elog(WARNING, \"fmcs_mol2s_transition() called first time\");\n-        CROMol mol = PG_GETARG_DATUM(1);\n+        CROMol mol = (CROMol)PG_GETARG_DATUM(1);","path":"Code/PgSQL/rdkit/mol_op.c","position":225,"original_position":225,"commit_id":"3272bcdd7a298f956d2063da82a9c67770962ae3","original_commit_id":"3272bcdd7a298f956d2063da82a9c67770962ae3","user":{"login":"greglandrum","id":540511,"avatar_url":"https://avatars.githubusercontent.com/u/540511?v=3","gravatar_id":"","url":"https://api.github.com/users/greglandrum","html_url":"https://github.com/greglandrum","followers_url":"https://api.github.com/users/greglandrum/followers","following_url":"https://api.github.com/users/greglandrum/following{/other_user}","gists_url":"https://api.github.com/users/greglandrum/gists{/gist_id}","starred_url":"https://api.github.com/users/greglandrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglandrum/subscriptions","organizations_url":"https://api.github.com/users/greglandrum/orgs","repos_url":"https://api.github.com/users/greglandrum/repos","events_url":"https://api.github.com/users/greglandrum/events{/privacy}","received_events_url":"https://api.github.com/users/greglandrum/received_events","type":"User","site_admin":false},"body":"We've been trying to move away from C-style casts in the code. Please use `static_cast` For these.","created_at":"2016-02-04T09:10:08Z","updated_at":"2016-02-04T09:10:08Z","html_url":"https://github.com/rdkit/rdkit/pull/752#discussion_r51845433","pull_request_url":"https://api.github.com/repos/rdkit/rdkit/pulls/752","_links":{"self":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/comments/51845433"},"html":{"href":"https://github.com/rdkit/rdkit/pull/752#discussion_r51845433"},"pull_request":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/752"}}},"pull_request":{"url":"https://api.github.com/repos/rdkit/rdkit/pulls/752","id":57789568,"html_url":"https://github.com/rdkit/rdkit/pull/752","diff_url":"https://github.com/rdkit/rdkit/pull/752.diff","patch_url":"https://github.com/rdkit/rdkit/pull/752.patch","issue_url":"https://api.github.com/repos/rdkit/rdkit/issues/752","number":752,"state":"open","locked":false,"title":"Bug fixes + PostgreSQL CMake integration","user":{"login":"ptosco","id":5244385,"avatar_url":"https://avatars.githubusercontent.com/u/5244385?v=3","gravatar_id":"","url":"https://api.github.com/users/ptosco","html_url":"https://github.com/ptosco","followers_url":"https://api.github.com/users/ptosco/followers","following_url":"https://api.github.com/users/ptosco/following{/other_user}","gists_url":"https://api.github.com/users/ptosco/gists{/gist_id}","starred_url":"https://api.github.com/users/ptosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptosco/subscriptions","organizations_url":"https://api.github.com/users/ptosco/orgs","repos_url":"https://api.github.com/users/ptosco/repos","events_url":"https://api.github.com/users/ptosco/events{/privacy}","received_events_url":"https://api.github.com/users/ptosco/received_events","type":"User","site_admin":false},"body":"I have submitted a pull request which incorporates a few bug fixes for Windows (check in particular the fix to the failing testAvalonLib1 in test3(); I have changed the getNumOnBits() comparison such that it does not fail anymore, but this might well mask some underlying problem).\r\n\r\nThe pull request contains the integration of the RDKit PostgreSQL cartridge build within CMake; the cartridge is built setting RDK_BUILD_PGSQL to ON and is tested within the standard ctest. I have succesfully tested building the cartridge on CentOS 7 64-bit (PostgreSQL 9.2) and on Windows 7 32-bit (PostgreSQL 9.5). I still need to carry out tests on OS X, on older PostgreSQL versions and Windows 7 64-bit, and to improve the documentation. To run ctest on the cartridge the current user must have privileges to create a database. On Windows you may need to set PGPASSWORD to the PostgreSQL password of the current user or use some other authentication method. Please get back to me if you can't get it to work.\r\n\r\nPlease ignore the quick fix that I did on DataStructs/BitOps.cpp: it is NOT the definitive one that I promised yesterday, but I just did it to be able to build on Windows 32-bit while I was working on other things. I am going to address that properly and test it thoroughly in a forthcoming pull request.","created_at":"2016-02-01T02:08:13Z","updated_at":"2016-02-04T09:10:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7710639392e3894f23ce7e7dc10dfd00116db9a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rdkit/rdkit/pulls/752/commits","review_comments_url":"https://api.github.com/repos/rdkit/rdkit/pulls/752/comments","review_comment_url":"https://api.github.com/repos/rdkit/rdkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rdkit/rdkit/issues/752/comments","statuses_url":"https://api.github.com/repos/rdkit/rdkit/statuses/3272bcdd7a298f956d2063da82a9c67770962ae3","head":{"label":"ptosco:master","ref":"master","sha":"3272bcdd7a298f956d2063da82a9c67770962ae3","user":{"login":"ptosco","id":5244385,"avatar_url":"https://avatars.githubusercontent.com/u/5244385?v=3","gravatar_id":"","url":"https://api.github.com/users/ptosco","html_url":"https://github.com/ptosco","followers_url":"https://api.github.com/users/ptosco/followers","following_url":"https://api.github.com/users/ptosco/following{/other_user}","gists_url":"https://api.github.com/users/ptosco/gists{/gist_id}","starred_url":"https://api.github.com/users/ptosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptosco/subscriptions","organizations_url":"https://api.github.com/users/ptosco/orgs","repos_url":"https://api.github.com/users/ptosco/repos","events_url":"https://api.github.com/users/ptosco/events{/privacy}","received_events_url":"https://api.github.com/users/ptosco/received_events","type":"User","site_admin":false},"repo":{"id":49782968,"name":"rdkit","full_name":"ptosco/rdkit","owner":{"login":"ptosco","id":5244385,"avatar_url":"https://avatars.githubusercontent.com/u/5244385?v=3","gravatar_id":"","url":"https://api.github.com/users/ptosco","html_url":"https://github.com/ptosco","followers_url":"https://api.github.com/users/ptosco/followers","following_url":"https://api.github.com/users/ptosco/following{/other_user}","gists_url":"https://api.github.com/users/ptosco/gists{/gist_id}","starred_url":"https://api.github.com/users/ptosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptosco/subscriptions","organizations_url":"https://api.github.com/users/ptosco/orgs","repos_url":"https://api.github.com/users/ptosco/repos","events_url":"https://api.github.com/users/ptosco/events{/privacy}","received_events_url":"https://api.github.com/users/ptosco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ptosco/rdkit","description":"The official sources for the RDKit library","fork":true,"url":"https://api.github.com/repos/ptosco/rdkit","forks_url":"https://api.github.com/repos/ptosco/rdkit/forks","keys_url":"https://api.github.com/repos/ptosco/rdkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptosco/rdkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptosco/rdkit/teams","hooks_url":"https://api.github.com/repos/ptosco/rdkit/hooks","issue_events_url":"https://api.github.com/repos/ptosco/rdkit/issues/events{/number}","events_url":"https://api.github.com/repos/ptosco/rdkit/events","assignees_url":"https://api.github.com/repos/ptosco/rdkit/assignees{/user}","branches_url":"https://api.github.com/repos/ptosco/rdkit/branches{/branch}","tags_url":"https://api.github.com/repos/ptosco/rdkit/tags","blobs_url":"https://api.github.com/repos/ptosco/rdkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptosco/rdkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptosco/rdkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptosco/rdkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptosco/rdkit/statuses/{sha}","languages_url":"https://api.github.com/repos/ptosco/rdkit/languages","stargazers_url":"https://api.github.com/repos/ptosco/rdkit/stargazers","contributors_url":"https://api.github.com/repos/ptosco/rdkit/contributors","subscribers_url":"https://api.github.com/repos/ptosco/rdkit/subscribers","subscription_url":"https://api.github.com/repos/ptosco/rdkit/subscription","commits_url":"https://api.github.com/repos/ptosco/rdkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptosco/rdkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptosco/rdkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptosco/rdkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptosco/rdkit/contents/{+path}","compare_url":"https://api.github.com/repos/ptosco/rdkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptosco/rdkit/merges","archive_url":"https://api.github.com/repos/ptosco/rdkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptosco/rdkit/downloads","issues_url":"https://api.github.com/repos/ptosco/rdkit/issues{/number}","pulls_url":"https://api.github.com/repos/ptosco/rdkit/pulls{/number}","milestones_url":"https://api.github.com/repos/ptosco/rdkit/milestones{/number}","notifications_url":"https://api.github.com/repos/ptosco/rdkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptosco/rdkit/labels{/name}","releases_url":"https://api.github.com/repos/ptosco/rdkit/releases{/id}","deployments_url":"https://api.github.com/repos/ptosco/rdkit/deployments","created_at":"2016-01-16T17:18:22Z","updated_at":"2016-01-16T17:18:34Z","pushed_at":"2016-02-04T08:44:22Z","git_url":"git://github.com/ptosco/rdkit.git","ssh_url":"git@github.com:ptosco/rdkit.git","clone_url":"https://github.com/ptosco/rdkit.git","svn_url":"https://github.com/ptosco/rdkit","homepage":"","size":74005,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rdkit:master","ref":"master","sha":"b2508a8e2b85c3166adba23398a090d4ae22b0aa","user":{"login":"rdkit","id":2018047,"avatar_url":"https://avatars.githubusercontent.com/u/2018047?v=3","gravatar_id":"","url":"https://api.github.com/users/rdkit","html_url":"https://github.com/rdkit","followers_url":"https://api.github.com/users/rdkit/followers","following_url":"https://api.github.com/users/rdkit/following{/other_user}","gists_url":"https://api.github.com/users/rdkit/gists{/gist_id}","starred_url":"https://api.github.com/users/rdkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdkit/subscriptions","organizations_url":"https://api.github.com/users/rdkit/orgs","repos_url":"https://api.github.com/users/rdkit/repos","events_url":"https://api.github.com/users/rdkit/events{/privacy}","received_events_url":"https://api.github.com/users/rdkit/received_events","type":"Organization","site_admin":false},"repo":{"id":10009991,"name":"rdkit","full_name":"rdkit/rdkit","owner":{"login":"rdkit","id":2018047,"avatar_url":"https://avatars.githubusercontent.com/u/2018047?v=3","gravatar_id":"","url":"https://api.github.com/users/rdkit","html_url":"https://github.com/rdkit","followers_url":"https://api.github.com/users/rdkit/followers","following_url":"https://api.github.com/users/rdkit/following{/other_user}","gists_url":"https://api.github.com/users/rdkit/gists{/gist_id}","starred_url":"https://api.github.com/users/rdkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdkit/subscriptions","organizations_url":"https://api.github.com/users/rdkit/orgs","repos_url":"https://api.github.com/users/rdkit/repos","events_url":"https://api.github.com/users/rdkit/events{/privacy}","received_events_url":"https://api.github.com/users/rdkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rdkit/rdkit","description":"The official sources for the RDKit library","fork":false,"url":"https://api.github.com/repos/rdkit/rdkit","forks_url":"https://api.github.com/repos/rdkit/rdkit/forks","keys_url":"https://api.github.com/repos/rdkit/rdkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdkit/rdkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdkit/rdkit/teams","hooks_url":"https://api.github.com/repos/rdkit/rdkit/hooks","issue_events_url":"https://api.github.com/repos/rdkit/rdkit/issues/events{/number}","events_url":"https://api.github.com/repos/rdkit/rdkit/events","assignees_url":"https://api.github.com/repos/rdkit/rdkit/assignees{/user}","branches_url":"https://api.github.com/repos/rdkit/rdkit/branches{/branch}","tags_url":"https://api.github.com/repos/rdkit/rdkit/tags","blobs_url":"https://api.github.com/repos/rdkit/rdkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdkit/rdkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdkit/rdkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdkit/rdkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdkit/rdkit/statuses/{sha}","languages_url":"https://api.github.com/repos/rdkit/rdkit/languages","stargazers_url":"https://api.github.com/repos/rdkit/rdkit/stargazers","contributors_url":"https://api.github.com/repos/rdkit/rdkit/contributors","subscribers_url":"https://api.github.com/repos/rdkit/rdkit/subscribers","subscription_url":"https://api.github.com/repos/rdkit/rdkit/subscription","commits_url":"https://api.github.com/repos/rdkit/rdkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdkit/rdkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdkit/rdkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdkit/rdkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdkit/rdkit/contents/{+path}","compare_url":"https://api.github.com/repos/rdkit/rdkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdkit/rdkit/merges","archive_url":"https://api.github.com/repos/rdkit/rdkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdkit/rdkit/downloads","issues_url":"https://api.github.com/repos/rdkit/rdkit/issues{/number}","pulls_url":"https://api.github.com/repos/rdkit/rdkit/pulls{/number}","milestones_url":"https://api.github.com/repos/rdkit/rdkit/milestones{/number}","notifications_url":"https://api.github.com/repos/rdkit/rdkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdkit/rdkit/labels{/name}","releases_url":"https://api.github.com/repos/rdkit/rdkit/releases{/id}","deployments_url":"https://api.github.com/repos/rdkit/rdkit/deployments","created_at":"2013-05-12T06:19:15Z","updated_at":"2016-02-04T07:12:04Z","pushed_at":"2016-02-04T08:44:23Z","git_url":"git://github.com/rdkit/rdkit.git","ssh_url":"git@github.com:rdkit/rdkit.git","clone_url":"https://github.com/rdkit/rdkit.git","svn_url":"https://github.com/rdkit/rdkit","homepage":"","size":76155,"stargazers_count":126,"watchers_count":126,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"open_issues_count":140,"forks":92,"open_issues":140,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/752"},"html":{"href":"https://github.com/rdkit/rdkit/pull/752"},"issue":{"href":"https://api.github.com/repos/rdkit/rdkit/issues/752"},"comments":{"href":"https://api.github.com/repos/rdkit/rdkit/issues/752/comments"},"review_comments":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/752/comments"},"review_comment":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/752/commits"},"statuses":{"href":"https://api.github.com/repos/rdkit/rdkit/statuses/3272bcdd7a298f956d2063da82a9c67770962ae3"}}}}