{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/9382","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9382/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9382/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9382/events","html_url":"https://github.com/joomla/joomla-cms/pull/9382","id":140341523,"number":9382,"title":"Redis cache storage: set expiration time to match the configured cache lifetime","user":{"login":"creativeprogramming","id":954291,"avatar_url":"https://avatars.githubusercontent.com/u/954291?v=3","gravatar_id":"","url":"https://api.github.com/users/creativeprogramming","html_url":"https://github.com/creativeprogramming","followers_url":"https://api.github.com/users/creativeprogramming/followers","following_url":"https://api.github.com/users/creativeprogramming/following{/other_user}","gists_url":"https://api.github.com/users/creativeprogramming/gists{/gist_id}","starred_url":"https://api.github.com/users/creativeprogramming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creativeprogramming/subscriptions","organizations_url":"https://api.github.com/users/creativeprogramming/orgs","repos_url":"https://api.github.com/users/creativeprogramming/repos","events_url":"https://api.github.com/users/creativeprogramming/events{/privacy}","received_events_url":"https://api.github.com/users/creativeprogramming/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-12T03:14:04Z","updated_at":"2016-03-15T00:26:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/9382","html_url":"https://github.com/joomla/joomla-cms/pull/9382","diff_url":"https://github.com/joomla/joomla-cms/pull/9382.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/9382.patch"},"body":"Probably it was just a typo/versioning issue, as the rest of code to get the lifetime from the configuration and to convert it in seconds was already in the method: but the setex call was hardcorded to expire in 1h (3600s).\r\n\r\nRegards"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/196585035","html_url":"https://github.com/joomla/joomla-cms/pull/9382#issuecomment-196585035","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/9382","id":196585035,"user":{"login":"andrepereiradasilva","id":9630530,"avatar_url":"https://avatars.githubusercontent.com/u/9630530?v=3","gravatar_id":"","url":"https://api.github.com/users/andrepereiradasilva","html_url":"https://github.com/andrepereiradasilva","followers_url":"https://api.github.com/users/andrepereiradasilva/followers","following_url":"https://api.github.com/users/andrepereiradasilva/following{/other_user}","gists_url":"https://api.github.com/users/andrepereiradasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/andrepereiradasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrepereiradasilva/subscriptions","organizations_url":"https://api.github.com/users/andrepereiradasilva/orgs","repos_url":"https://api.github.com/users/andrepereiradasilva/repos","events_url":"https://api.github.com/users/andrepereiradasilva/events{/privacy}","received_events_url":"https://api.github.com/users/andrepereiradasilva/received_events","type":"User","site_admin":false},"created_at":"2016-03-15T00:26:42Z","updated_at":"2016-03-15T00:26:42Z","body":"not expert in redis, but IMHO even if problems exist, i think it should still respect the lifetime defined by the user in the control panel, in other words, it shouldn't be hardcoded.\r\n\r\n> Anyway i think also the logic above to get the lifetime from conf needs a little review: maybe you can get rid of the if block and of the ->get() as $this->_lifetime it's already set in the parent class constructor, and other cache storages are relying just on that (except memcache.php that is doing like this one). \r\n\r\ni think so too.\r\n\r\n> Anyway in the parent class there isn't any ->get() defaulting to 15mins, and maybe it should be.\r\n\r\nin parent class is set to 0 i think. Since the installer set it to 15 by default i think it should be 15 too.\r\nSee https://github.com/joomla/joomla-cms/blob/staging/installation/model/configuration.php#L119"}}