{"action":"created","issue":{"url":"https://api.github.com/repos/ncjones/editorconfig-eclipse/issues/38","repository_url":"https://api.github.com/repos/ncjones/editorconfig-eclipse","labels_url":"https://api.github.com/repos/ncjones/editorconfig-eclipse/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/ncjones/editorconfig-eclipse/issues/38/comments","events_url":"https://api.github.com/repos/ncjones/editorconfig-eclipse/issues/38/events","html_url":"https://github.com/ncjones/editorconfig-eclipse/pull/38","id":157528942,"number":38,"title":"Initialize .editorconfig editor to support syntax coloring.","user":{"login":"angelozerr","id":1932211,"avatar_url":"https://avatars.githubusercontent.com/u/1932211?v=3","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-30T16:11:28Z","updated_at":"2016-06-06T22:15:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ncjones/editorconfig-eclipse/pulls/38","html_url":"https://github.com/ncjones/editorconfig-eclipse/pull/38","diff_url":"https://github.com/ncjones/editorconfig-eclipse/pull/38.diff","patch_url":"https://github.com/ncjones/editorconfig-eclipse/pull/38.patch"},"body":"This (big) PR provides\r\n\r\n * a custom EditorConfigEditor which support syntax coloring: \r\n\r\n![editorconfigsyntaxcolorizing](https://cloud.githubusercontent.com/assets/1932211/15654063/57d94f3a-2691-11e6-815e-7e009cd94c81.png)\r\n\r\n\r\n * the syntax coloring can be customized with preferences:\r\n\r\n![editorconfigsyntaxcoloringpreferences](https://cloud.githubusercontent.com/assets/1932211/15654094/a195eb56-2691-11e6-81c2-79860fdf60ae.png)\r\n\r\n * the editor supports dark theme too:\r\n\r\n![editorconfigsyntaxcoloringdark](https://cloud.githubusercontent.com/assets/1932211/15654123/ce5937b0-2691-11e6-8b9f-b436974b1465.png)\r\n\r\nI'm waiting for that you accept this PR to improve again with other features (completion, validation, folding, bracket, etc)"},"comment":{"url":"https://api.github.com/repos/ncjones/editorconfig-eclipse/issues/comments/224105394","html_url":"https://github.com/ncjones/editorconfig-eclipse/pull/38#issuecomment-224105394","issue_url":"https://api.github.com/repos/ncjones/editorconfig-eclipse/issues/38","id":224105394,"user":{"login":"angelozerr","id":1932211,"avatar_url":"https://avatars.githubusercontent.com/u/1932211?v=3","gravatar_id":"","url":"https://api.github.com/users/angelozerr","html_url":"https://github.com/angelozerr","followers_url":"https://api.github.com/users/angelozerr/followers","following_url":"https://api.github.com/users/angelozerr/following{/other_user}","gists_url":"https://api.github.com/users/angelozerr/gists{/gist_id}","starred_url":"https://api.github.com/users/angelozerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angelozerr/subscriptions","organizations_url":"https://api.github.com/users/angelozerr/orgs","repos_url":"https://api.github.com/users/angelozerr/repos","events_url":"https://api.github.com/users/angelozerr/events{/privacy}","received_events_url":"https://api.github.com/users/angelozerr/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T22:15:24Z","updated_at":"2016-06-06T22:15:24Z","body":"> you don't need to assign copyright to me for your own work\r\n\r\nAre you sure with that? When I receive contributions from MyEclipse, RedHat contributions for tern.java, angularjs-eclipse, they keep the header with my name and add their name. \r\n\r\n> rename the package \"org.eclipse.editorconfig.internal.ui\" to \"org.eclipse.editorconfig.ui.internal\" so that it unambiguously indicates the project it belongs to.\r\n\r\nAll eclipse packages are like this. Ex : \r\n\r\n * org.eclipse.core.internal.resources.File\r\n * org.eclipse.core.resources.IFile\r\n\r\n> there's no test automation. Do you have any ideas how to automate tests this?\r\n\r\nNever done and never seen tests for editor. Sorry -("}}
{"actor":{"display_login":"angelozerr"}}