{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/76607399","id":76607399,"diff_hunk":"@@ -942,11 +1013,34 @@ def make_node(self, x, maxout, gz):\n         assert x.ndim == 4\n         assert maxout.ndim == 4\n         assert gz.ndim == 4\n-\n-        return Apply(self, [x, maxout, gz], [x.type()])\n+        if stride is None:\n+            stride = ws\n+        if isinstance(pad, (tuple, list)):\n+            pad = tuple(pad)\n+            if pad != (0, 0) and not self.ignore_border:\n+                raise NotImplementedError(\n+                    'padding works only with ignore_border=True')\n+            if isinstance(ws, (tuple, list)):\n+                ws = tuple(ws)\n+                if pad[0] >= ws[0] or pad[1] >= ws[1]:\n+                    raise NotImplementedError(\n+                        'padding_h and padding_w must be smaller than strides')\n+        ws = tensor.as_tensor_variable(ws)\n+        stride = tensor.as_tensor_variable(stride)\n+        pad = tensor.as_tensor_variable(pad)\n+        assert ws.ndim == 1\n+        assert stride.ndim == 1\n+        assert pad.ndim == 1\n+        if not ws.dtype.startswith('int'):\n+            raise TypeError('Pool downsample parameters must be ints.')\n+        if not stride.dtype.startswith('int'):\n+            raise TypeError('Stride parameters must be ints.')\n+        if not pad.dtype.startswith('int'):\n+            raise TypeError('Padding parameters must be ints.')\n+        return Apply(self, [x, maxout, gz, ws, stride, pad], [x.type()])\n \n     def perform(self, node, inp, out):\n-        x, maxout, ggx = inp\n+        x, maxout, ggx, ws, stride, pad = inp","path":"theano/tensor/signal/pool.py","position":845,"original_position":845,"commit_id":"1ad6fae74b89e177b1b5296b28f3d80640f9d728","original_commit_id":"1ad6fae74b89e177b1b5296b28f3d80640f9d728","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"assert shape and in c code.","created_at":"2016-08-29T13:35:11Z","updated_at":"2016-08-29T13:35:11Z","html_url":"https://github.com/Theano/Theano/pull/4756#discussion_r76607399","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4756","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/76607399"},"html":{"href":"https://github.com/Theano/Theano/pull/4756#discussion_r76607399"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4756"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4756","id":77852249,"html_url":"https://github.com/Theano/Theano/pull/4756","diff_url":"https://github.com/Theano/Theano/pull/4756.diff","patch_url":"https://github.com/Theano/Theano/pull/4756.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4756","number":4756,"state":"open","locked":false,"title":"Theano variable arguments for pooling 2","user":{"login":"Thrandis","id":10479248,"avatar_url":"https://avatars.githubusercontent.com/u/10479248?v=3","gravatar_id":"","url":"https://api.github.com/users/Thrandis","html_url":"https://github.com/Thrandis","followers_url":"https://api.github.com/users/Thrandis/followers","following_url":"https://api.github.com/users/Thrandis/following{/other_user}","gists_url":"https://api.github.com/users/Thrandis/gists{/gist_id}","starred_url":"https://api.github.com/users/Thrandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thrandis/subscriptions","organizations_url":"https://api.github.com/users/Thrandis/orgs","repos_url":"https://api.github.com/users/Thrandis/repos","events_url":"https://api.github.com/users/Thrandis/events{/privacy}","received_events_url":"https://api.github.com/users/Thrandis/received_events","type":"User","site_admin":false},"body":"Fixes #3349\r\n\r\nPrevious merge failed, so restart PR here!\r\n#### TODO:\r\n- [x] Test GPU (2 backends)\r\n\r\nAdapt interface in the whole lib:\r\n- [x] tensor\r\n- [x] gpuarray\r\n- [x] sanbox/cuda\r\n- [x] other\r\n","created_at":"2016-07-18T18:10:17Z","updated_at":"2016-08-29T13:35:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e12e826c51de5e7aa492583a0d98564321267d7d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4756/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4756/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4756/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/1ad6fae74b89e177b1b5296b28f3d80640f9d728","head":{"label":"Thrandis:ccw2","ref":"ccw2","sha":"1ad6fae74b89e177b1b5296b28f3d80640f9d728","user":{"login":"Thrandis","id":10479248,"avatar_url":"https://avatars.githubusercontent.com/u/10479248?v=3","gravatar_id":"","url":"https://api.github.com/users/Thrandis","html_url":"https://github.com/Thrandis","followers_url":"https://api.github.com/users/Thrandis/followers","following_url":"https://api.github.com/users/Thrandis/following{/other_user}","gists_url":"https://api.github.com/users/Thrandis/gists{/gist_id}","starred_url":"https://api.github.com/users/Thrandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thrandis/subscriptions","organizations_url":"https://api.github.com/users/Thrandis/orgs","repos_url":"https://api.github.com/users/Thrandis/repos","events_url":"https://api.github.com/users/Thrandis/events{/privacy}","received_events_url":"https://api.github.com/users/Thrandis/received_events","type":"User","site_admin":false},"repo":{"id":34398490,"name":"Theano","full_name":"Thrandis/Theano","owner":{"login":"Thrandis","id":10479248,"avatar_url":"https://avatars.githubusercontent.com/u/10479248?v=3","gravatar_id":"","url":"https://api.github.com/users/Thrandis","html_url":"https://github.com/Thrandis","followers_url":"https://api.github.com/users/Thrandis/followers","following_url":"https://api.github.com/users/Thrandis/following{/other_user}","gists_url":"https://api.github.com/users/Thrandis/gists{/gist_id}","starred_url":"https://api.github.com/users/Thrandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thrandis/subscriptions","organizations_url":"https://api.github.com/users/Thrandis/orgs","repos_url":"https://api.github.com/users/Thrandis/repos","events_url":"https://api.github.com/users/Thrandis/events{/privacy}","received_events_url":"https://api.github.com/users/Thrandis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thrandis/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/Thrandis/Theano","forks_url":"https://api.github.com/repos/Thrandis/Theano/forks","keys_url":"https://api.github.com/repos/Thrandis/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thrandis/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thrandis/Theano/teams","hooks_url":"https://api.github.com/repos/Thrandis/Theano/hooks","issue_events_url":"https://api.github.com/repos/Thrandis/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Thrandis/Theano/events","assignees_url":"https://api.github.com/repos/Thrandis/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Thrandis/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Thrandis/Theano/tags","blobs_url":"https://api.github.com/repos/Thrandis/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thrandis/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thrandis/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thrandis/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thrandis/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Thrandis/Theano/languages","stargazers_url":"https://api.github.com/repos/Thrandis/Theano/stargazers","contributors_url":"https://api.github.com/repos/Thrandis/Theano/contributors","subscribers_url":"https://api.github.com/repos/Thrandis/Theano/subscribers","subscription_url":"https://api.github.com/repos/Thrandis/Theano/subscription","commits_url":"https://api.github.com/repos/Thrandis/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thrandis/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thrandis/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thrandis/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thrandis/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Thrandis/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thrandis/Theano/merges","archive_url":"https://api.github.com/repos/Thrandis/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thrandis/Theano/downloads","issues_url":"https://api.github.com/repos/Thrandis/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Thrandis/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Thrandis/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Thrandis/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thrandis/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Thrandis/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Thrandis/Theano/deployments","created_at":"2015-04-22T15:24:01Z","updated_at":"2016-06-01T15:41:41Z","pushed_at":"2016-08-18T21:04:15Z","git_url":"git://github.com/Thrandis/Theano.git","ssh_url":"git@github.com:Thrandis/Theano.git","clone_url":"https://github.com/Thrandis/Theano.git","svn_url":"https://github.com/Thrandis/Theano","homepage":"http://www.deeplearning.net/software/theano","size":56984,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"f70948abc41e81a2ab31976cfbeee6ade31c5add","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-08-29T12:35:34Z","pushed_at":"2016-08-29T13:00:17Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":76102,"stargazers_count":4410,"watchers_count":4410,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1581,"mirror_url":null,"open_issues_count":744,"forks":1581,"open_issues":744,"watchers":4410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4756"},"html":{"href":"https://github.com/Theano/Theano/pull/4756"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4756"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4756/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4756/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4756/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/1ad6fae74b89e177b1b5296b28f3d80640f9d728"}}}}
{"actor":{"display_login":"nouiz"}}