{"action":"created","issue":{"url":"https://api.github.com/repos/cesium-ml/cesium/issues/195","repository_url":"https://api.github.com/repos/cesium-ml/cesium","labels_url":"https://api.github.com/repos/cesium-ml/cesium/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/cesium-ml/cesium/issues/195/comments","events_url":"https://api.github.com/repos/cesium-ml/cesium/issues/195/events","html_url":"https://github.com/cesium-ml/cesium/pull/195","id":181543937,"number":195,"title":"Raise more detailed exception when encountering invalid feature values","user":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-06T22:43:54Z","updated_at":"2016-10-06T23:10:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cesium-ml/cesium/pulls/195","html_url":"https://github.com/cesium-ml/cesium/pull/195","diff_url":"https://github.com/cesium-ml/cesium/pull/195.diff","patch_url":"https://github.com/cesium-ml/cesium/pull/195.patch"},"body":"Fixes #92. Combined with cesium-ml/cesium_web#109 this should also make debugging failures on the frontend easier."},"comment":{"url":"https://api.github.com/repos/cesium-ml/cesium/issues/comments/252113775","html_url":"https://github.com/cesium-ml/cesium/pull/195#issuecomment-252113775","issue_url":"https://api.github.com/repos/cesium-ml/cesium/issues/195","id":252113775,"user":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T23:10:54Z","updated_at":"2016-10-06T23:10:54Z","body":"Huh?\n\nOn Thu, Oct 6, 2016 at 4:08 PM Stefan van der Walt <notifications@github.com>\nwrote:\n\n> *@stefanv* commented on this pull request.\n> ------------------------------\n>\n> In cesium/tests/test_build_model.py\n> <https://github.com/cesium-ml/cesium/pull/195#pullrequestreview-3222270>:\n>\n> > +    assert isinstance(model, RandomForestClassifier)\n> +\n> +\n> +def test_invalid_feature_values():\n> +    \"\"\"Test proper exception handling for invalid feature values\"\"\"\n> +    fset = sample_featureset(10, 1, ['x_valid', 'x_inf', 'x_nan'], ['class1', 'class2'])\n> +    fset.x_inf.values[0, 0] = np.inf\n> +    fset.x_nan.values[0, 0] = np.nan\n> +    model = build_model.MODELS_TYPE_DICT['RandomForestClassifier']()\n> +    try:\n> +        model = build_model.build_model_from_featureset(fset, model)\n> +    except ValueError as e:\n> +        assert 'x_valid' not in str(e)\n> +        assert 'x_inf' in str(e)\n> +        assert 'x_nan' in str(e)\n> +\n>\n> Else?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/cesium-ml/cesium/pull/195#pullrequestreview-3222270>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AA3J5_wOXF5yk0E1pxNlxSoSyAwzoMcvks5qxX9UgaJpZM4KQfsr>\n> .\n>\n"}}
{"actor":{"display_login":"bnaul"}}