{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments/57930590","id":57930590,"diff_hunk":"@@ -291,6 +296,22 @@ def make_subsubtest_config(self, all_configs, parent_config,\n         self.config = self.make_config(all_configs, parent_config,\n                                        self.config_section)\n \n+    def require_docker_version(self, wanted):","path":"dockertest/subtest.py","position":16,"original_position":16,"commit_id":"499b610ad427f2fcd5d6a507a9ccc763ab97363e","original_commit_id":"499b610ad427f2fcd5d6a507a9ccc763ab97363e","user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars.githubusercontent.com/u/1183438?v=3","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"body":"Thought: since it's just that one config option, probably no harm in just adding a parameter for it.","created_at":"2016-03-30T17:38:35Z","updated_at":"2016-03-30T17:38:35Z","html_url":"https://github.com/autotest/autotest-docker/pull/584#discussion_r57930590","pull_request_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/584","_links":{"self":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments/57930590"},"html":{"href":"https://github.com/autotest/autotest-docker/pull/584#discussion_r57930590"},"pull_request":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/584"}}},"pull_request":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/584","id":64547845,"html_url":"https://github.com/autotest/autotest-docker/pull/584","diff_url":"https://github.com/autotest/autotest-docker/pull/584.diff","patch_url":"https://github.com/autotest/autotest-docker/pull/584.patch","issue_url":"https://api.github.com/repos/autotest/autotest-docker/issues/584","number":584,"state":"open","locked":false,"title":"Refactor: new subtest.require_docker_version()","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"body":"Raises DockerTestNAError if currently-installed docker\r\nversion is less than a specified requirement.\r\n\r\nAlso: removed obsolete version checks and code from rmi\r\n\r\nSigned-off-by: Ed Santiago <santiago@redhat.com>","created_at":"2016-03-29T22:59:16Z","updated_at":"2016-03-30T17:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb66482aba59d72e1ef1ff793cdfcd2bf6048d72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/584/commits","review_comments_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/584/comments","review_comment_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/issues/584/comments","statuses_url":"https://api.github.com/repos/autotest/autotest-docker/statuses/499b610ad427f2fcd5d6a507a9ccc763ab97363e","head":{"label":"edsantiago:require_version","ref":"require_version","sha":"499b610ad427f2fcd5d6a507a9ccc763ab97363e","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"repo":{"id":51094257,"name":"autotest-docker","full_name":"edsantiago/autotest-docker","owner":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars.githubusercontent.com/u/265639?v=3","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edsantiago/autotest-docker","description":"Autotest client test containing functional & integration subtests for the Docker project","fork":true,"url":"https://api.github.com/repos/edsantiago/autotest-docker","forks_url":"https://api.github.com/repos/edsantiago/autotest-docker/forks","keys_url":"https://api.github.com/repos/edsantiago/autotest-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edsantiago/autotest-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edsantiago/autotest-docker/teams","hooks_url":"https://api.github.com/repos/edsantiago/autotest-docker/hooks","issue_events_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues/events{/number}","events_url":"https://api.github.com/repos/edsantiago/autotest-docker/events","assignees_url":"https://api.github.com/repos/edsantiago/autotest-docker/assignees{/user}","branches_url":"https://api.github.com/repos/edsantiago/autotest-docker/branches{/branch}","tags_url":"https://api.github.com/repos/edsantiago/autotest-docker/tags","blobs_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edsantiago/autotest-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/edsantiago/autotest-docker/languages","stargazers_url":"https://api.github.com/repos/edsantiago/autotest-docker/stargazers","contributors_url":"https://api.github.com/repos/edsantiago/autotest-docker/contributors","subscribers_url":"https://api.github.com/repos/edsantiago/autotest-docker/subscribers","subscription_url":"https://api.github.com/repos/edsantiago/autotest-docker/subscription","commits_url":"https://api.github.com/repos/edsantiago/autotest-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/edsantiago/autotest-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/edsantiago/autotest-docker/contents/{+path}","compare_url":"https://api.github.com/repos/edsantiago/autotest-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edsantiago/autotest-docker/merges","archive_url":"https://api.github.com/repos/edsantiago/autotest-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edsantiago/autotest-docker/downloads","issues_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues{/number}","pulls_url":"https://api.github.com/repos/edsantiago/autotest-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/edsantiago/autotest-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/edsantiago/autotest-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edsantiago/autotest-docker/labels{/name}","releases_url":"https://api.github.com/repos/edsantiago/autotest-docker/releases{/id}","deployments_url":"https://api.github.com/repos/edsantiago/autotest-docker/deployments","created_at":"2016-02-04T17:56:14Z","updated_at":"2016-02-04T17:56:15Z","pushed_at":"2016-03-30T15:57:51Z","git_url":"git://github.com/edsantiago/autotest-docker.git","ssh_url":"git@github.com:edsantiago/autotest-docker.git","clone_url":"https://github.com/edsantiago/autotest-docker.git","svn_url":"https://github.com/edsantiago/autotest-docker","homepage":null,"size":2025,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"d498f62b441b315c8ff6ff42196b18fe0c739fdc","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":17869790,"name":"autotest-docker","full_name":"autotest/autotest-docker","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/autotest-docker","description":"Autotest client test containing functional & integration subtests for the Docker project","fork":false,"url":"https://api.github.com/repos/autotest/autotest-docker","forks_url":"https://api.github.com/repos/autotest/autotest-docker/forks","keys_url":"https://api.github.com/repos/autotest/autotest-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/autotest-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/autotest-docker/teams","hooks_url":"https://api.github.com/repos/autotest/autotest-docker/hooks","issue_events_url":"https://api.github.com/repos/autotest/autotest-docker/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/autotest-docker/events","assignees_url":"https://api.github.com/repos/autotest/autotest-docker/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/autotest-docker/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/autotest-docker/tags","blobs_url":"https://api.github.com/repos/autotest/autotest-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/autotest-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/autotest-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/autotest-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/autotest-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/autotest-docker/languages","stargazers_url":"https://api.github.com/repos/autotest/autotest-docker/stargazers","contributors_url":"https://api.github.com/repos/autotest/autotest-docker/contributors","subscribers_url":"https://api.github.com/repos/autotest/autotest-docker/subscribers","subscription_url":"https://api.github.com/repos/autotest/autotest-docker/subscription","commits_url":"https://api.github.com/repos/autotest/autotest-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/autotest-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/autotest-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/autotest-docker/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/autotest-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/autotest-docker/merges","archive_url":"https://api.github.com/repos/autotest/autotest-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/autotest-docker/downloads","issues_url":"https://api.github.com/repos/autotest/autotest-docker/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/autotest-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/autotest-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/autotest-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/autotest-docker/labels{/name}","releases_url":"https://api.github.com/repos/autotest/autotest-docker/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/autotest-docker/deployments","created_at":"2014-03-18T14:53:27Z","updated_at":"2016-01-21T21:48:31Z","pushed_at":"2016-03-30T17:32:40Z","git_url":"git://github.com/autotest/autotest-docker.git","ssh_url":"git@github.com:autotest/autotest-docker.git","clone_url":"https://github.com/autotest/autotest-docker.git","svn_url":"https://github.com/autotest/autotest-docker","homepage":null,"size":2522,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":57,"forks":21,"open_issues":57,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/584"},"html":{"href":"https://github.com/autotest/autotest-docker/pull/584"},"issue":{"href":"https://api.github.com/repos/autotest/autotest-docker/issues/584"},"comments":{"href":"https://api.github.com/repos/autotest/autotest-docker/issues/584/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/584/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/584/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/autotest-docker/statuses/499b610ad427f2fcd5d6a507a9ccc763ab97363e"}}}}