{"action":"created","issue":{"url":"https://api.github.com/repos/18F/s3-resource-simple/issues/9","repository_url":"https://api.github.com/repos/18F/s3-resource-simple","labels_url":"https://api.github.com/repos/18F/s3-resource-simple/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/18F/s3-resource-simple/issues/9/comments","events_url":"https://api.github.com/repos/18F/s3-resource-simple/issues/9/events","html_url":"https://github.com/18F/s3-resource-simple/pull/9","id":171857918,"number":9,"title":"Support AWS IAM Roles.","user":{"login":"asceresini","id":797347,"avatar_url":"https://avatars.githubusercontent.com/u/797347?v=3","gravatar_id":"","url":"https://api.github.com/users/asceresini","html_url":"https://github.com/asceresini","followers_url":"https://api.github.com/users/asceresini/followers","following_url":"https://api.github.com/users/asceresini/following{/other_user}","gists_url":"https://api.github.com/users/asceresini/gists{/gist_id}","starred_url":"https://api.github.com/users/asceresini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asceresini/subscriptions","organizations_url":"https://api.github.com/users/asceresini/orgs","repos_url":"https://api.github.com/users/asceresini/repos","events_url":"https://api.github.com/users/asceresini/events{/privacy}","received_events_url":"https://api.github.com/users/asceresini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-08-18T09:32:33Z","updated_at":"2016-09-01T01:10:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/s3-resource-simple/pulls/9","html_url":"https://github.com/18F/s3-resource-simple/pull/9","diff_url":"https://github.com/18F/s3-resource-simple/pull/9.diff","patch_url":"https://github.com/18F/s3-resource-simple/pull/9.patch"},"body":"Only define credential environment variables when values have been passed through. Assigning them to empty values enacts the AWS credential precedence rules and the Role will never be utilised through metadata.\r\n\r\nAddresses #8 \r\n\r\n## Testing\r\n\r\nWith regards to testing, open to ideas to test the absence of credentials on a docker image that would mimic a role and access to AWS metadata which you don't have access to in local development.\r\n\r\nI have tested this running in Concourse and as stated, if the credential environment variables are not set, then it will gain access through keys retrieved from the metadata service."},"comment":{"url":"https://api.github.com/repos/18F/s3-resource-simple/issues/comments/243948212","html_url":"https://github.com/18F/s3-resource-simple/pull/9#issuecomment-243948212","issue_url":"https://api.github.com/repos/18F/s3-resource-simple/issues/9","id":243948212,"user":{"login":"asceresini","id":797347,"avatar_url":"https://avatars.githubusercontent.com/u/797347?v=3","gravatar_id":"","url":"https://api.github.com/users/asceresini","html_url":"https://github.com/asceresini","followers_url":"https://api.github.com/users/asceresini/followers","following_url":"https://api.github.com/users/asceresini/following{/other_user}","gists_url":"https://api.github.com/users/asceresini/gists{/gist_id}","starred_url":"https://api.github.com/users/asceresini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asceresini/subscriptions","organizations_url":"https://api.github.com/users/asceresini/orgs","repos_url":"https://api.github.com/users/asceresini/repos","events_url":"https://api.github.com/users/asceresini/events{/privacy}","received_events_url":"https://api.github.com/users/asceresini/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T01:10:35Z","updated_at":"2016-09-01T01:10:35Z","body":"Any updates on this? Thanks!"}}
{"actor":{"display_login":"asceresini"}}