{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/91878671","pull_request_review_id":12387260,"id":91878671,"diff_hunk":"@@ -370,6 +372,49 @@ def test_pairwise_distances_argmin_min():\n     np.testing.assert_almost_equal(dist_orig_val, dist_chunked_val, decimal=7)\n \n \n+def check_invalid_block_size_generator(generator):\n+    for i in generator:\n+        return i\n+\n+\n+def test_pairwise_distances_blockwise_invalid_block_size():\n+    rng = np.random.RandomState(0)\n+    X = rng.random_sample((400, 4))","path":"sklearn/metrics/tests/test_pairwise.py","position":27,"original_position":27,"commit_id":"f46efae23e62220147339d77c238d3e8e60c955d","original_commit_id":"f46efae23e62220147339d77c238d3e8e60c955d","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"this might as well be empty or zeros","created_at":"2016-12-12T03:27:00Z","updated_at":"2016-12-12T03:27:00Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/7979#discussion_r91878671","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/91878671"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7979#discussion_r91878671"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979","id":96491290,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/7979","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/7979.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/7979.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7979","number":7979,"state":"open","locked":false,"title":"[MRG] ENH: Added block_size parameter for lesser memory consumption","user":{"login":"dalmia","id":13185699,"avatar_url":"https://avatars.githubusercontent.com/u/13185699?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmia","html_url":"https://github.com/dalmia","followers_url":"https://api.github.com/users/dalmia/followers","following_url":"https://api.github.com/users/dalmia/following{/other_user}","gists_url":"https://api.github.com/users/dalmia/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmia/subscriptions","organizations_url":"https://api.github.com/users/dalmia/orgs","repos_url":"https://api.github.com/users/dalmia/repos","events_url":"https://api.github.com/users/dalmia/events{/privacy}","received_events_url":"https://api.github.com/users/dalmia/received_events","type":"User","site_admin":false},"body":"#### Reference Issue\r\nFixes #7287\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nThis intends to add a function `pairwise_distances_blockwise` with an additional block_size parameter to avoid storing all the O(n^2) pairs' distances. This would then be used by `neighbors`, `silhouette_score` and `pairwise_distances_argmin_min`.\r\n\r\n#### Any other comments?\r\nI have chosen to implement it as a function as it seemed more cleaner to me. However, this can be changed according to what suits better. Currently, I have just added a template with a few modifications in the docstrings as per my understanding of the issue. This needs a lot more change. Not ready for review yet.\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n","created_at":"2016-12-05T09:06:39Z","updated_at":"2016-12-12T03:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6914045dd1e480fd1ebf617a1a70bd9eaa96998a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7979/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f46efae23e62220147339d77c238d3e8e60c955d","head":{"label":"dalmia:7287","ref":"7287","sha":"f46efae23e62220147339d77c238d3e8e60c955d","user":{"login":"dalmia","id":13185699,"avatar_url":"https://avatars.githubusercontent.com/u/13185699?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmia","html_url":"https://github.com/dalmia","followers_url":"https://api.github.com/users/dalmia/followers","following_url":"https://api.github.com/users/dalmia/following{/other_user}","gists_url":"https://api.github.com/users/dalmia/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmia/subscriptions","organizations_url":"https://api.github.com/users/dalmia/orgs","repos_url":"https://api.github.com/users/dalmia/repos","events_url":"https://api.github.com/users/dalmia/events{/privacy}","received_events_url":"https://api.github.com/users/dalmia/received_events","type":"User","site_admin":false},"repo":{"id":69615534,"name":"scikit-learn","full_name":"dalmia/scikit-learn","owner":{"login":"dalmia","id":13185699,"avatar_url":"https://avatars.githubusercontent.com/u/13185699?v=3","gravatar_id":"","url":"https://api.github.com/users/dalmia","html_url":"https://github.com/dalmia","followers_url":"https://api.github.com/users/dalmia/followers","following_url":"https://api.github.com/users/dalmia/following{/other_user}","gists_url":"https://api.github.com/users/dalmia/gists{/gist_id}","starred_url":"https://api.github.com/users/dalmia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalmia/subscriptions","organizations_url":"https://api.github.com/users/dalmia/orgs","repos_url":"https://api.github.com/users/dalmia/repos","events_url":"https://api.github.com/users/dalmia/events{/privacy}","received_events_url":"https://api.github.com/users/dalmia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dalmia/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/dalmia/scikit-learn","forks_url":"https://api.github.com/repos/dalmia/scikit-learn/forks","keys_url":"https://api.github.com/repos/dalmia/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalmia/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalmia/scikit-learn/teams","hooks_url":"https://api.github.com/repos/dalmia/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/dalmia/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/dalmia/scikit-learn/events","assignees_url":"https://api.github.com/repos/dalmia/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/dalmia/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/dalmia/scikit-learn/tags","blobs_url":"https://api.github.com/repos/dalmia/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalmia/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalmia/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalmia/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalmia/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/dalmia/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/dalmia/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/dalmia/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/dalmia/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/dalmia/scikit-learn/subscription","commits_url":"https://api.github.com/repos/dalmia/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalmia/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalmia/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalmia/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalmia/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/dalmia/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalmia/scikit-learn/merges","archive_url":"https://api.github.com/repos/dalmia/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalmia/scikit-learn/downloads","issues_url":"https://api.github.com/repos/dalmia/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/dalmia/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/dalmia/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/dalmia/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalmia/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/dalmia/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/dalmia/scikit-learn/deployments","created_at":"2016-09-29T23:18:34Z","updated_at":"2016-09-29T23:18:42Z","pushed_at":"2016-12-10T09:26:48Z","git_url":"git://github.com/dalmia/scikit-learn.git","ssh_url":"git@github.com:dalmia/scikit-learn.git","clone_url":"https://github.com/dalmia/scikit-learn.git","svn_url":"https://github.com/dalmia/scikit-learn","homepage":"http://scikit-learn.org","size":77585,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"b6941847d6f224446917ba52b4467cfbf082fcd8","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-12-12T02:55:14Z","pushed_at":"2016-12-11T21:39:31Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":130192,"stargazers_count":15258,"watchers_count":15258,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8580,"mirror_url":null,"open_issues_count":1160,"forks":8580,"open_issues":1160,"watchers":15258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/7979"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7979"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/7979/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/7979/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f46efae23e62220147339d77c238d3e8e60c955d"}}}}
{"actor":{"display_login":"jnothman"}}