{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/cube_browser/pulls/comments/66209412","id":66209412,"diff_hunk":"@@ -539,26 +539,35 @@ def __init__(self, plots):\n \n         self._slider_by_name = {}\n         self._name_by_slider_id = {}\n+        if self._axis_by_name:\n+            name_len = max([len(name) for name in self._axis_by_name])\n+        children = []\n         for axis in self._axis_by_name.values():\n             if hasattr(axis, 'coord') and axis.coord.units.is_time_reference():\n-                opts = [(axis.coord.units.num2date(axis.coord.points[i]), i)\n-                        for i in range(axis.size)]\n+                pairs = [(axis.coord.units.num2date(axis.coord.points[i]), i)\n+                         for i in range(axis.size)]\n             elif hasattr(axis, 'coord'):\n-                opts = [(axis.coord.points[i], i) for i in range(axis.size)]\n+                pairs = [(axis.coord.points[i], i) for i in range(axis.size)]\n             else:\n-                opts = [(i, i) for i in range(axis.size)]\n-            options = OrderedDict(opts)\n-            slider = ipywidgets.SelectionSlider(description=axis.name,\n-                                                options=options)\n+                pairs = [(i, i) for i in range(axis.size)]\n+            options = OrderedDict(pairs)\n+            slider = ipywidgets.SelectionSlider(options=options)\n             slider.observe(self.on_change, names='value')\n             self._slider_by_name[axis.name] = slider\n             self._name_by_slider_id[id(slider)] = axis.name\n+            # Explicitly control the slider label in order to avoid\n+            # fix width widget description label wrapping issues.\n+            # XXX: Adjust px/em scale-factor dynamically based on font-size.\n+            scale_factor = .65","path":"lib/cube_browser/__init__.py","position":30,"original_position":30,"commit_id":"9b5fe33d87e3f5729d47d74768fab825397aeab3","original_commit_id":"9b5fe33d87e3f5729d47d74768fab825397aeab3","user":{"login":"dkillick","id":3473068,"avatar_url":"https://avatars.githubusercontent.com/u/3473068?v=3","gravatar_id":"","url":"https://api.github.com/users/dkillick","html_url":"https://github.com/dkillick","followers_url":"https://api.github.com/users/dkillick/followers","following_url":"https://api.github.com/users/dkillick/following{/other_user}","gists_url":"https://api.github.com/users/dkillick/gists{/gist_id}","starred_url":"https://api.github.com/users/dkillick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkillick/subscriptions","organizations_url":"https://api.github.com/users/dkillick/orgs","repos_url":"https://api.github.com/users/dkillick/repos","events_url":"https://api.github.com/users/dkillick/events{/privacy}","received_events_url":"https://api.github.com/users/dkillick/received_events","type":"User","site_admin":false},"body":"@bjlittle no, just naming it does not make it less magic :wink: As this is a px to em conversion factor, it assumedly means you, in the loosest sense, have defined the pixel width of 1em in the CSS somewhere. Any chance you can hook into that?? Otherwise the comment above does help, even if it doesn't give the reason for the value!","created_at":"2016-06-08T08:09:12Z","updated_at":"2016-06-08T08:09:12Z","html_url":"https://github.com/SciTools/cube_browser/pull/94#discussion_r66209412","pull_request_url":"https://api.github.com/repos/SciTools/cube_browser/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/SciTools/cube_browser/pulls/comments/66209412"},"html":{"href":"https://github.com/SciTools/cube_browser/pull/94#discussion_r66209412"},"pull_request":{"href":"https://api.github.com/repos/SciTools/cube_browser/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/cube_browser/pulls/94","id":72869820,"html_url":"https://github.com/SciTools/cube_browser/pull/94","diff_url":"https://github.com/SciTools/cube_browser/pull/94.diff","patch_url":"https://github.com/SciTools/cube_browser/pull/94.patch","issue_url":"https://api.github.com/repos/SciTools/cube_browser/issues/94","number":94,"state":"open","locked":false,"title":"Fix slider description label wrapping.","user":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"body":"@marqh \r\n\r\nCloses #89","created_at":"2016-06-07T12:56:49Z","updated_at":"2016-06-08T08:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d024ce9297daacd3c66d2a453ec05a0e3f7d7e7","assignee":{"login":"marqh","id":1557321,"avatar_url":"https://avatars.githubusercontent.com/u/1557321?v=3","gravatar_id":"","url":"https://api.github.com/users/marqh","html_url":"https://github.com/marqh","followers_url":"https://api.github.com/users/marqh/followers","following_url":"https://api.github.com/users/marqh/following{/other_user}","gists_url":"https://api.github.com/users/marqh/gists{/gist_id}","starred_url":"https://api.github.com/users/marqh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marqh/subscriptions","organizations_url":"https://api.github.com/users/marqh/orgs","repos_url":"https://api.github.com/users/marqh/repos","events_url":"https://api.github.com/users/marqh/events{/privacy}","received_events_url":"https://api.github.com/users/marqh/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/cube_browser/pulls/94/commits","review_comments_url":"https://api.github.com/repos/SciTools/cube_browser/pulls/94/comments","review_comment_url":"https://api.github.com/repos/SciTools/cube_browser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/cube_browser/issues/94/comments","statuses_url":"https://api.github.com/repos/SciTools/cube_browser/statuses/9b5fe33d87e3f5729d47d74768fab825397aeab3","head":{"label":"bjlittle:slider-labels","ref":"slider-labels","sha":"9b5fe33d87e3f5729d47d74768fab825397aeab3","user":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"repo":{"id":56608681,"name":"cube_browser","full_name":"bjlittle/cube_browser","owner":{"login":"bjlittle","id":2051656,"avatar_url":"https://avatars.githubusercontent.com/u/2051656?v=3","gravatar_id":"","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjlittle/cube_browser","description":"Interactive browsing of Iris cubes ","fork":true,"url":"https://api.github.com/repos/bjlittle/cube_browser","forks_url":"https://api.github.com/repos/bjlittle/cube_browser/forks","keys_url":"https://api.github.com/repos/bjlittle/cube_browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjlittle/cube_browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjlittle/cube_browser/teams","hooks_url":"https://api.github.com/repos/bjlittle/cube_browser/hooks","issue_events_url":"https://api.github.com/repos/bjlittle/cube_browser/issues/events{/number}","events_url":"https://api.github.com/repos/bjlittle/cube_browser/events","assignees_url":"https://api.github.com/repos/bjlittle/cube_browser/assignees{/user}","branches_url":"https://api.github.com/repos/bjlittle/cube_browser/branches{/branch}","tags_url":"https://api.github.com/repos/bjlittle/cube_browser/tags","blobs_url":"https://api.github.com/repos/bjlittle/cube_browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjlittle/cube_browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjlittle/cube_browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjlittle/cube_browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjlittle/cube_browser/statuses/{sha}","languages_url":"https://api.github.com/repos/bjlittle/cube_browser/languages","stargazers_url":"https://api.github.com/repos/bjlittle/cube_browser/stargazers","contributors_url":"https://api.github.com/repos/bjlittle/cube_browser/contributors","subscribers_url":"https://api.github.com/repos/bjlittle/cube_browser/subscribers","subscription_url":"https://api.github.com/repos/bjlittle/cube_browser/subscription","commits_url":"https://api.github.com/repos/bjlittle/cube_browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjlittle/cube_browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjlittle/cube_browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjlittle/cube_browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjlittle/cube_browser/contents/{+path}","compare_url":"https://api.github.com/repos/bjlittle/cube_browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjlittle/cube_browser/merges","archive_url":"https://api.github.com/repos/bjlittle/cube_browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjlittle/cube_browser/downloads","issues_url":"https://api.github.com/repos/bjlittle/cube_browser/issues{/number}","pulls_url":"https://api.github.com/repos/bjlittle/cube_browser/pulls{/number}","milestones_url":"https://api.github.com/repos/bjlittle/cube_browser/milestones{/number}","notifications_url":"https://api.github.com/repos/bjlittle/cube_browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjlittle/cube_browser/labels{/name}","releases_url":"https://api.github.com/repos/bjlittle/cube_browser/releases{/id}","deployments_url":"https://api.github.com/repos/bjlittle/cube_browser/deployments","created_at":"2016-04-19T15:25:58Z","updated_at":"2016-04-19T15:23:49Z","pushed_at":"2016-06-08T07:43:18Z","git_url":"git://github.com/bjlittle/cube_browser.git","ssh_url":"git@github.com:bjlittle/cube_browser.git","clone_url":"https://github.com/bjlittle/cube_browser.git","svn_url":"https://github.com/bjlittle/cube_browser","homepage":null,"size":1097,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"f53be19af71056e1288b1eacec47fc05ed7f5d87","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":56608489,"name":"cube_browser","full_name":"SciTools/cube_browser","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/cube_browser","description":"Interactive browsing of Iris cubes ","fork":false,"url":"https://api.github.com/repos/SciTools/cube_browser","forks_url":"https://api.github.com/repos/SciTools/cube_browser/forks","keys_url":"https://api.github.com/repos/SciTools/cube_browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/cube_browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/cube_browser/teams","hooks_url":"https://api.github.com/repos/SciTools/cube_browser/hooks","issue_events_url":"https://api.github.com/repos/SciTools/cube_browser/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/cube_browser/events","assignees_url":"https://api.github.com/repos/SciTools/cube_browser/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/cube_browser/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/cube_browser/tags","blobs_url":"https://api.github.com/repos/SciTools/cube_browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/cube_browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/cube_browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/cube_browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/cube_browser/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/cube_browser/languages","stargazers_url":"https://api.github.com/repos/SciTools/cube_browser/stargazers","contributors_url":"https://api.github.com/repos/SciTools/cube_browser/contributors","subscribers_url":"https://api.github.com/repos/SciTools/cube_browser/subscribers","subscription_url":"https://api.github.com/repos/SciTools/cube_browser/subscription","commits_url":"https://api.github.com/repos/SciTools/cube_browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/cube_browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/cube_browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/cube_browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/cube_browser/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/cube_browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/cube_browser/merges","archive_url":"https://api.github.com/repos/SciTools/cube_browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/cube_browser/downloads","issues_url":"https://api.github.com/repos/SciTools/cube_browser/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/cube_browser/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/cube_browser/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/cube_browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/cube_browser/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/cube_browser/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/cube_browser/deployments","created_at":"2016-04-19T15:23:49Z","updated_at":"2016-06-02T23:13:23Z","pushed_at":"2016-06-08T07:43:18Z","git_url":"git://github.com/SciTools/cube_browser.git","ssh_url":"git@github.com:SciTools/cube_browser.git","clone_url":"https://github.com/SciTools/cube_browser.git","svn_url":"https://github.com/SciTools/cube_browser","homepage":null,"size":1227,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":19,"forks":7,"open_issues":19,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/cube_browser/pulls/94"},"html":{"href":"https://github.com/SciTools/cube_browser/pull/94"},"issue":{"href":"https://api.github.com/repos/SciTools/cube_browser/issues/94"},"comments":{"href":"https://api.github.com/repos/SciTools/cube_browser/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/cube_browser/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/cube_browser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/cube_browser/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/cube_browser/statuses/9b5fe33d87e3f5729d47d74768fab825397aeab3"}}}}
{"actor":{"display_login":"dkillick"}}