{"action":"created","issue":{"url":"https://api.github.com/repos/eventflow/EventFlow/issues/279","repository_url":"https://api.github.com/repos/eventflow/EventFlow","labels_url":"https://api.github.com/repos/eventflow/EventFlow/issues/279/labels{/name}","comments_url":"https://api.github.com/repos/eventflow/EventFlow/issues/279/comments","events_url":"https://api.github.com/repos/eventflow/EventFlow/issues/279/events","html_url":"https://github.com/eventflow/EventFlow/issues/279","id":192937436,"number":279,"title":"Aggregate snapshot with Entities","user":{"login":"minhhungit","id":2279508,"avatar_url":"https://avatars.githubusercontent.com/u/2279508?v=3","gravatar_id":"","url":"https://api.github.com/users/minhhungit","html_url":"https://github.com/minhhungit","followers_url":"https://api.github.com/users/minhhungit/followers","following_url":"https://api.github.com/users/minhhungit/following{/other_user}","gists_url":"https://api.github.com/users/minhhungit/gists{/gist_id}","starred_url":"https://api.github.com/users/minhhungit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minhhungit/subscriptions","organizations_url":"https://api.github.com/users/minhhungit/orgs","repos_url":"https://api.github.com/users/minhhungit/repos","events_url":"https://api.github.com/users/minhhungit/events{/privacy}","received_events_url":"https://api.github.com/users/minhhungit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T19:20:52Z","updated_at":"2016-12-01T21:23:16Z","closed_at":null,"body":"My **SupplierAggregate** have a **`List<SupplierContact>`** and a **Name**\r\nI added **15** `supplierContact` to that supplier\r\nI also create snapshot for that supplier with SnapshotEveryFewVersionsStrategy = 10\r\nWhen I load aggregate, I just have **5** latest supplier contact, it counted from latest snapshot point\r\nI think it should be **15**\r\nI think this will make some mistakes when we need to compute List<SupplierContact>**\r\nIs this a bug or my mistake ?"},"comment":{"url":"https://api.github.com/repos/eventflow/EventFlow/issues/comments/264299322","html_url":"https://github.com/eventflow/EventFlow/issues/279#issuecomment-264299322","issue_url":"https://api.github.com/repos/eventflow/EventFlow/issues/279","id":264299322,"user":{"login":"minhhungit","id":2279508,"avatar_url":"https://avatars.githubusercontent.com/u/2279508?v=3","gravatar_id":"","url":"https://api.github.com/users/minhhungit","html_url":"https://github.com/minhhungit","followers_url":"https://api.github.com/users/minhhungit/followers","following_url":"https://api.github.com/users/minhhungit/following{/other_user}","gists_url":"https://api.github.com/users/minhhungit/gists{/gist_id}","starred_url":"https://api.github.com/users/minhhungit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minhhungit/subscriptions","organizations_url":"https://api.github.com/users/minhhungit/orgs","repos_url":"https://api.github.com/users/minhhungit/repos","events_url":"https://api.github.com/users/minhhungit/events{/privacy}","received_events_url":"https://api.github.com/users/minhhungit/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T21:23:16Z","updated_at":"2016-12-01T21:23:16Z","body":"I think I found a problem\r\nI must register event in aggregate constructor:\r\n```\r\npublic SupplierRoot(SupplierId id) : base(id,  SnapshotEveryFewVersionsStrategy.With(SnapshotEveryVersion))\r\n{\r\n       Register<SupplierLocationWasAddedEvent>(e => _supplierLocations.Add(e.SupplierLocation));\r\n}\r\n```\r\nand use readOnlyCollection\r\n\r\n> public IReadOnlyCollection<SupplierLocation> SupplierLocations => _supplierLocations;\r\n\r\n**Document site didn't include this info**"}}
{"actor":{"display_login":"minhhungit"}}