{"action":"created","issue":{"url":"https://api.github.com/repos/HBM/md-components/issues/213","repository_url":"https://api.github.com/repos/HBM/md-components","labels_url":"https://api.github.com/repos/HBM/md-components/issues/213/labels{/name}","comments_url":"https://api.github.com/repos/HBM/md-components/issues/213/comments","events_url":"https://api.github.com/repos/HBM/md-components/issues/213/events","html_url":"https://github.com/HBM/md-components/pull/213","id":194365999,"number":213,"title":"navigation: allow nesting of multiple levels","user":{"login":"zemirco","id":1132354,"avatar_url":"https://avatars.githubusercontent.com/u/1132354?v=3","gravatar_id":"","url":"https://api.github.com/users/zemirco","html_url":"https://github.com/zemirco","followers_url":"https://api.github.com/users/zemirco/followers","following_url":"https://api.github.com/users/zemirco/following{/other_user}","gists_url":"https://api.github.com/users/zemirco/gists{/gist_id}","starred_url":"https://api.github.com/users/zemirco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zemirco/subscriptions","organizations_url":"https://api.github.com/users/zemirco/orgs","repos_url":"https://api.github.com/users/zemirco/repos","events_url":"https://api.github.com/users/zemirco/events{/privacy}","received_events_url":"https://api.github.com/users/zemirco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-08T15:32:55Z","updated_at":"2016-12-08T15:39:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HBM/md-components/pulls/213","html_url":"https://github.com/HBM/md-components/pull/213","diff_url":"https://github.com/HBM/md-components/pull/213.diff","patch_url":"https://github.com/HBM/md-components/pull/213.patch"},"body":"With this change the user is able to use as many levels as it wants.\r\n\r\nThe problem with the current implementation is we're losing the animation effect where sub menus grow and shrink. Having only one level makes it easy to animate because we can simply count the number of items in the sub menu, multiply this number with the height of each item and we have the height of each sub menu.\r\n\r\nHaving multiple levels makes this `height` animation much harder. We don't know the height of a sub menu inside a sub menu. Therefore we cannot set the height upfront. However I think this issue should not stop us from adding this change to the navigation component. If we really want the animation back where sub menus slide in and out we have to find a solution at some point in the future."},"comment":{"url":"https://api.github.com/repos/HBM/md-components/issues/comments/265770775","html_url":"https://github.com/HBM/md-components/pull/213#issuecomment-265770775","issue_url":"https://api.github.com/repos/HBM/md-components/issues/213","id":265770775,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-12-08T15:39:11Z","updated_at":"2016-12-08T15:39:11Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9189499/badge)](https://coveralls.io/builds/9189499)\n\nCoverage increased (+0.2%) to 94.083% when pulling **4f2a187a7f54e47efe118d84980db1c5ee2ba222 on navigation-levels** into **bd4aafbd8b7895e0b2dbb808d50c072c6811c4e5 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}