{"action":"created","comment":{"url":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/comments/67822883","id":67822883,"diff_hunk":"@@ -2,28 +2,52 @@\n @import \"../../../core/style/theme-functions\";\n \n md-sidenav-layout[fullscreen] {\n-  top: 58px;\n+  top: 50px;\n+\n+  md-sidenav {\n+    min-width: 200px;\n+    max-width: 250px;\n+  }\n \n-  md-sidenav { min-width: 200px; max-width: 250px; }\n \n   md-list-item {\n-    display: block; padding: 0; height: 40px;\n+    display: block;\n+    padding: 0;\n     text-align: left;\n \n-    h3, p { margin: 0; }\n+    h3, p {\n+      margin: 0;\n+    }\n     p {\n-      transform: translate3d(0, -200%, 0); opacity: 0; transition: all 200ms linear;\n-      font-size: rem(1.2); line-height: 1; color: md-color($md-foreground, secondary-text);\n+      transform: translate3d(0, -100%, 0);\n+      opacity: 0;\n+      transition: all 200ms linear;\n+      font-size: rem(1.2);\n+      line-height: 1;\n+      text-transform: initial;\n+      color: md-color($md-foreground, secondary-text);\n     }\n \n     &.router-link-active,\n     &:hover {\n       background-color: transparent;\n       color: md-color($md-primary, 300);\n \n-      p { opacity: 1; transform: translate3d(0, -80%, 0); }\n+      p {\n+        opacity: 1;\n+        transform: translate3d(0, -30%, 0);\n+      }\n+    }\n+    &.router-link-active h3 {\n+      font-weight: bold;\n     }\n-    &.router-link-active h3 { font-weight: bold; }\n \n   }\n }\n+\n+.app-content {\n+  margin-left: auto;\n+  margin-right: auto;\n+  width: 800px;","path":"src/app/hm-admin/content/content.component.scss","position":58,"original_position":58,"commit_id":"a595f7a0910698cd2a6572135dfe5a9ab7b91f0f","original_commit_id":"a595f7a0910698cd2a6572135dfe5a9ab7b91f0f","user":{"login":"gorghoa","id":662768,"avatar_url":"https://avatars.githubusercontent.com/u/662768?v=3","gravatar_id":"","url":"https://api.github.com/users/gorghoa","html_url":"https://github.com/gorghoa","followers_url":"https://api.github.com/users/gorghoa/followers","following_url":"https://api.github.com/users/gorghoa/following{/other_user}","gists_url":"https://api.github.com/users/gorghoa/gists{/gist_id}","starred_url":"https://api.github.com/users/gorghoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorghoa/subscriptions","organizations_url":"https://api.github.com/users/gorghoa/orgs","repos_url":"https://api.github.com/users/gorghoa/repos","events_url":"https://api.github.com/users/gorghoa/events{/privacy}","received_events_url":"https://api.github.com/users/gorghoa/received_events","type":"User","site_admin":false},"body":"to infinity and beyooooond !!!!\r\n\r\nJokes aside, I may miss something, but why not the contrary?\r\n\r\n```\r\nwidth: 95%;\r\nmax-width: 800px;\r\n```\r\n\r\nSince, the max you don’t want to go over is in fact 800px, not 95%. ","created_at":"2016-06-21T07:56:12Z","updated_at":"2016-06-21T07:56:12Z","html_url":"https://github.com/coopTilleuls/hm-admin/pull/43#discussion_r67822883","pull_request_url":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/comments/67822883"},"html":{"href":"https://github.com/coopTilleuls/hm-admin/pull/43#discussion_r67822883"},"pull_request":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43","id":74520060,"html_url":"https://github.com/coopTilleuls/hm-admin/pull/43","diff_url":"https://github.com/coopTilleuls/hm-admin/pull/43.diff","patch_url":"https://github.com/coopTilleuls/hm-admin/pull/43.patch","issue_url":"https://api.github.com/repos/coopTilleuls/hm-admin/issues/43","number":43,"state":"open","locked":false,"title":"feat: add List component","user":{"login":"Gregcop1","id":1257968,"avatar_url":"https://avatars.githubusercontent.com/u/1257968?v=3","gravatar_id":"","url":"https://api.github.com/users/Gregcop1","html_url":"https://github.com/Gregcop1","followers_url":"https://api.github.com/users/Gregcop1/followers","following_url":"https://api.github.com/users/Gregcop1/following{/other_user}","gists_url":"https://api.github.com/users/Gregcop1/gists{/gist_id}","starred_url":"https://api.github.com/users/Gregcop1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gregcop1/subscriptions","organizations_url":"https://api.github.com/users/Gregcop1/orgs","repos_url":"https://api.github.com/users/Gregcop1/repos","events_url":"https://api.github.com/users/Gregcop1/events{/privacy}","received_events_url":"https://api.github.com/users/Gregcop1/received_events","type":"User","site_admin":false},"body":"Changes proposed in this pull request:\r\n- List component\r\n- Add Api Service (+mock) for getCollection method\r\n- Add Schema service mock\r\n- Add Core definition service mock\r\n- Add feature that allow to call configuration via a sting: get('Person.List.displayProperties');\r\n- Revamp pagedCollection to be an observable that can be chained\r\n\r\n\r\nMake sure those checkboxes are checked if you want to be reviewed\r\n\r\n- [x] Your branch should be mergeable on current master\r\n- [x] Tests should pass\r\n- [x] Linter should pass\r\n- [x] Code coverage should stay higher than 90%\r\n- [x] Squash your commits to one commit and follow those recommendations about [writing good commit message](https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#-git-commit-guidelines)\r\n\r\nFix #30","created_at":"2016-06-20T21:53:40Z","updated_at":"2016-06-21T07:56:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"621727925bdc07caa3d54591fb44edc4788ca9c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43/commits","review_comments_url":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43/comments","review_comment_url":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coopTilleuls/hm-admin/issues/43/comments","statuses_url":"https://api.github.com/repos/coopTilleuls/hm-admin/statuses/a595f7a0910698cd2a6572135dfe5a9ab7b91f0f","head":{"label":"Gregcop1:feature/list-view-30","ref":"feature/list-view-30","sha":"a595f7a0910698cd2a6572135dfe5a9ab7b91f0f","user":{"login":"Gregcop1","id":1257968,"avatar_url":"https://avatars.githubusercontent.com/u/1257968?v=3","gravatar_id":"","url":"https://api.github.com/users/Gregcop1","html_url":"https://github.com/Gregcop1","followers_url":"https://api.github.com/users/Gregcop1/followers","following_url":"https://api.github.com/users/Gregcop1/following{/other_user}","gists_url":"https://api.github.com/users/Gregcop1/gists{/gist_id}","starred_url":"https://api.github.com/users/Gregcop1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gregcop1/subscriptions","organizations_url":"https://api.github.com/users/Gregcop1/orgs","repos_url":"https://api.github.com/users/Gregcop1/repos","events_url":"https://api.github.com/users/Gregcop1/events{/privacy}","received_events_url":"https://api.github.com/users/Gregcop1/received_events","type":"User","site_admin":false},"repo":{"id":58650953,"name":"hm-admin","full_name":"Gregcop1/hm-admin","owner":{"login":"Gregcop1","id":1257968,"avatar_url":"https://avatars.githubusercontent.com/u/1257968?v=3","gravatar_id":"","url":"https://api.github.com/users/Gregcop1","html_url":"https://github.com/Gregcop1","followers_url":"https://api.github.com/users/Gregcop1/followers","following_url":"https://api.github.com/users/Gregcop1/following{/other_user}","gists_url":"https://api.github.com/users/Gregcop1/gists{/gist_id}","starred_url":"https://api.github.com/users/Gregcop1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gregcop1/subscriptions","organizations_url":"https://api.github.com/users/Gregcop1/orgs","repos_url":"https://api.github.com/users/Gregcop1/repos","events_url":"https://api.github.com/users/Gregcop1/events{/privacy}","received_events_url":"https://api.github.com/users/Gregcop1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Gregcop1/hm-admin","description":"hm-admin is an angular2 component which help you to build backoffice automatically for an hypermedia API","fork":true,"url":"https://api.github.com/repos/Gregcop1/hm-admin","forks_url":"https://api.github.com/repos/Gregcop1/hm-admin/forks","keys_url":"https://api.github.com/repos/Gregcop1/hm-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gregcop1/hm-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gregcop1/hm-admin/teams","hooks_url":"https://api.github.com/repos/Gregcop1/hm-admin/hooks","issue_events_url":"https://api.github.com/repos/Gregcop1/hm-admin/issues/events{/number}","events_url":"https://api.github.com/repos/Gregcop1/hm-admin/events","assignees_url":"https://api.github.com/repos/Gregcop1/hm-admin/assignees{/user}","branches_url":"https://api.github.com/repos/Gregcop1/hm-admin/branches{/branch}","tags_url":"https://api.github.com/repos/Gregcop1/hm-admin/tags","blobs_url":"https://api.github.com/repos/Gregcop1/hm-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gregcop1/hm-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gregcop1/hm-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gregcop1/hm-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gregcop1/hm-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/Gregcop1/hm-admin/languages","stargazers_url":"https://api.github.com/repos/Gregcop1/hm-admin/stargazers","contributors_url":"https://api.github.com/repos/Gregcop1/hm-admin/contributors","subscribers_url":"https://api.github.com/repos/Gregcop1/hm-admin/subscribers","subscription_url":"https://api.github.com/repos/Gregcop1/hm-admin/subscription","commits_url":"https://api.github.com/repos/Gregcop1/hm-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gregcop1/hm-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gregcop1/hm-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gregcop1/hm-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gregcop1/hm-admin/contents/{+path}","compare_url":"https://api.github.com/repos/Gregcop1/hm-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gregcop1/hm-admin/merges","archive_url":"https://api.github.com/repos/Gregcop1/hm-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gregcop1/hm-admin/downloads","issues_url":"https://api.github.com/repos/Gregcop1/hm-admin/issues{/number}","pulls_url":"https://api.github.com/repos/Gregcop1/hm-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/Gregcop1/hm-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/Gregcop1/hm-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gregcop1/hm-admin/labels{/name}","releases_url":"https://api.github.com/repos/Gregcop1/hm-admin/releases{/id}","deployments_url":"https://api.github.com/repos/Gregcop1/hm-admin/deployments","created_at":"2016-05-12T14:54:04Z","updated_at":"2016-05-12T12:27:11Z","pushed_at":"2016-06-20T22:57:24Z","git_url":"git://github.com/Gregcop1/hm-admin.git","ssh_url":"git@github.com:Gregcop1/hm-admin.git","clone_url":"https://github.com/Gregcop1/hm-admin.git","svn_url":"https://github.com/Gregcop1/hm-admin","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coopTilleuls:feature/list-view-30","ref":"feature/list-view-30","sha":"262f85c9e0273f22c8d6901595c4f1f82609157d","user":{"login":"coopTilleuls","id":1161198,"avatar_url":"https://avatars.githubusercontent.com/u/1161198?v=3","gravatar_id":"","url":"https://api.github.com/users/coopTilleuls","html_url":"https://github.com/coopTilleuls","followers_url":"https://api.github.com/users/coopTilleuls/followers","following_url":"https://api.github.com/users/coopTilleuls/following{/other_user}","gists_url":"https://api.github.com/users/coopTilleuls/gists{/gist_id}","starred_url":"https://api.github.com/users/coopTilleuls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coopTilleuls/subscriptions","organizations_url":"https://api.github.com/users/coopTilleuls/orgs","repos_url":"https://api.github.com/users/coopTilleuls/repos","events_url":"https://api.github.com/users/coopTilleuls/events{/privacy}","received_events_url":"https://api.github.com/users/coopTilleuls/received_events","type":"Organization","site_admin":false},"repo":{"id":58639376,"name":"hm-admin","full_name":"coopTilleuls/hm-admin","owner":{"login":"coopTilleuls","id":1161198,"avatar_url":"https://avatars.githubusercontent.com/u/1161198?v=3","gravatar_id":"","url":"https://api.github.com/users/coopTilleuls","html_url":"https://github.com/coopTilleuls","followers_url":"https://api.github.com/users/coopTilleuls/followers","following_url":"https://api.github.com/users/coopTilleuls/following{/other_user}","gists_url":"https://api.github.com/users/coopTilleuls/gists{/gist_id}","starred_url":"https://api.github.com/users/coopTilleuls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coopTilleuls/subscriptions","organizations_url":"https://api.github.com/users/coopTilleuls/orgs","repos_url":"https://api.github.com/users/coopTilleuls/repos","events_url":"https://api.github.com/users/coopTilleuls/events{/privacy}","received_events_url":"https://api.github.com/users/coopTilleuls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coopTilleuls/hm-admin","description":"hm-admin is an angular2 component which help you to build backoffice automatically for an hypermedia API","fork":false,"url":"https://api.github.com/repos/coopTilleuls/hm-admin","forks_url":"https://api.github.com/repos/coopTilleuls/hm-admin/forks","keys_url":"https://api.github.com/repos/coopTilleuls/hm-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coopTilleuls/hm-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coopTilleuls/hm-admin/teams","hooks_url":"https://api.github.com/repos/coopTilleuls/hm-admin/hooks","issue_events_url":"https://api.github.com/repos/coopTilleuls/hm-admin/issues/events{/number}","events_url":"https://api.github.com/repos/coopTilleuls/hm-admin/events","assignees_url":"https://api.github.com/repos/coopTilleuls/hm-admin/assignees{/user}","branches_url":"https://api.github.com/repos/coopTilleuls/hm-admin/branches{/branch}","tags_url":"https://api.github.com/repos/coopTilleuls/hm-admin/tags","blobs_url":"https://api.github.com/repos/coopTilleuls/hm-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coopTilleuls/hm-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coopTilleuls/hm-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/coopTilleuls/hm-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coopTilleuls/hm-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/coopTilleuls/hm-admin/languages","stargazers_url":"https://api.github.com/repos/coopTilleuls/hm-admin/stargazers","contributors_url":"https://api.github.com/repos/coopTilleuls/hm-admin/contributors","subscribers_url":"https://api.github.com/repos/coopTilleuls/hm-admin/subscribers","subscription_url":"https://api.github.com/repos/coopTilleuls/hm-admin/subscription","commits_url":"https://api.github.com/repos/coopTilleuls/hm-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/coopTilleuls/hm-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/coopTilleuls/hm-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/coopTilleuls/hm-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/coopTilleuls/hm-admin/contents/{+path}","compare_url":"https://api.github.com/repos/coopTilleuls/hm-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coopTilleuls/hm-admin/merges","archive_url":"https://api.github.com/repos/coopTilleuls/hm-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coopTilleuls/hm-admin/downloads","issues_url":"https://api.github.com/repos/coopTilleuls/hm-admin/issues{/number}","pulls_url":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/coopTilleuls/hm-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/coopTilleuls/hm-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coopTilleuls/hm-admin/labels{/name}","releases_url":"https://api.github.com/repos/coopTilleuls/hm-admin/releases{/id}","deployments_url":"https://api.github.com/repos/coopTilleuls/hm-admin/deployments","created_at":"2016-05-12T12:27:11Z","updated_at":"2016-06-08T19:55:28Z","pushed_at":"2016-06-20T22:57:24Z","git_url":"git://github.com/coopTilleuls/hm-admin.git","ssh_url":"git@github.com:coopTilleuls/hm-admin.git","clone_url":"https://github.com/coopTilleuls/hm-admin.git","svn_url":"https://github.com/coopTilleuls/hm-admin","homepage":null,"size":99,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43"},"html":{"href":"https://github.com/coopTilleuls/hm-admin/pull/43"},"issue":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/issues/43"},"comments":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/coopTilleuls/hm-admin/statuses/a595f7a0910698cd2a6572135dfe5a9ab7b91f0f"}}}}
{"actor":{"display_login":"gorghoa"}}