{"action":"created","comment":{"url":"https://api.github.com/repos/tmr232/Sark/pulls/comments/58043368","id":58043368,"diff_hunk":"@@ -131,4 +131,9 @@ def get_string(ea):\n     if not string:\n         raise exceptions.SarkNoString(\"No string at 0x{:08X}\".format(ea))\n \n-    return string\n\\ No newline at end of file\n+    return string\n+\n+\n+def make_string(ea, len=0):\n+    return idaapi.make_ascii_string(ea, len, GetLongPrm(INF_STRTYPE))","path":"sark/data.py","position":10,"original_position":10,"commit_id":"7f7ae712ebee44a27f14372c7863b28c7f11c494","original_commit_id":"7f7ae712ebee44a27f14372c7863b28c7f11c494","user":{"login":"tmr232","id":1386239,"avatar_url":"https://avatars.githubusercontent.com/u/1386239?v=3","gravatar_id":"","url":"https://api.github.com/users/tmr232","html_url":"https://github.com/tmr232","followers_url":"https://api.github.com/users/tmr232/followers","following_url":"https://api.github.com/users/tmr232/following{/other_user}","gists_url":"https://api.github.com/users/tmr232/gists{/gist_id}","starred_url":"https://api.github.com/users/tmr232/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmr232/subscriptions","organizations_url":"https://api.github.com/users/tmr232/orgs","repos_url":"https://api.github.com/users/tmr232/repos","events_url":"https://api.github.com/users/tmr232/events{/privacy}","received_events_url":"https://api.github.com/users/tmr232/received_events","type":"User","site_admin":false},"body":"Same issue here - we should allow the creation of all string types.","created_at":"2016-03-31T12:17:20Z","updated_at":"2016-03-31T12:17:20Z","html_url":"https://github.com/tmr232/Sark/pull/35#discussion_r58043368","pull_request_url":"https://api.github.com/repos/tmr232/Sark/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/tmr232/Sark/pulls/comments/58043368"},"html":{"href":"https://github.com/tmr232/Sark/pull/35#discussion_r58043368"},"pull_request":{"href":"https://api.github.com/repos/tmr232/Sark/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/tmr232/Sark/pulls/35","id":64775897,"html_url":"https://github.com/tmr232/Sark/pull/35","diff_url":"https://github.com/tmr232/Sark/pull/35.diff","patch_url":"https://github.com/tmr232/Sark/pull/35.patch","issue_url":"https://api.github.com/repos/tmr232/Sark/issues/35","number":35,"state":"open","locked":false,"title":"added: is_string() and make_string()","user":{"login":"ronyrus","id":1329734,"avatar_url":"https://avatars.githubusercontent.com/u/1329734?v=3","gravatar_id":"","url":"https://api.github.com/users/ronyrus","html_url":"https://github.com/ronyrus","followers_url":"https://api.github.com/users/ronyrus/followers","following_url":"https://api.github.com/users/ronyrus/following{/other_user}","gists_url":"https://api.github.com/users/ronyrus/gists{/gist_id}","starred_url":"https://api.github.com/users/ronyrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronyrus/subscriptions","organizations_url":"https://api.github.com/users/ronyrus/orgs","repos_url":"https://api.github.com/users/ronyrus/repos","events_url":"https://api.github.com/users/ronyrus/events{/privacy}","received_events_url":"https://api.github.com/users/ronyrus/received_events","type":"User","site_admin":false},"body":"ASCII strings","created_at":"2016-03-31T11:39:51Z","updated_at":"2016-03-31T12:17:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4b6d30e69bd075ca91f71f6d8f746758e4b08e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tmr232/Sark/pulls/35/commits","review_comments_url":"https://api.github.com/repos/tmr232/Sark/pulls/35/comments","review_comment_url":"https://api.github.com/repos/tmr232/Sark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tmr232/Sark/issues/35/comments","statuses_url":"https://api.github.com/repos/tmr232/Sark/statuses/7f7ae712ebee44a27f14372c7863b28c7f11c494","head":{"label":"ronyrus:strings_handling","ref":"strings_handling","sha":"7f7ae712ebee44a27f14372c7863b28c7f11c494","user":{"login":"ronyrus","id":1329734,"avatar_url":"https://avatars.githubusercontent.com/u/1329734?v=3","gravatar_id":"","url":"https://api.github.com/users/ronyrus","html_url":"https://github.com/ronyrus","followers_url":"https://api.github.com/users/ronyrus/followers","following_url":"https://api.github.com/users/ronyrus/following{/other_user}","gists_url":"https://api.github.com/users/ronyrus/gists{/gist_id}","starred_url":"https://api.github.com/users/ronyrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronyrus/subscriptions","organizations_url":"https://api.github.com/users/ronyrus/orgs","repos_url":"https://api.github.com/users/ronyrus/repos","events_url":"https://api.github.com/users/ronyrus/events{/privacy}","received_events_url":"https://api.github.com/users/ronyrus/received_events","type":"User","site_admin":false},"repo":{"id":45103542,"name":"Sark","full_name":"ronyrus/Sark","owner":{"login":"ronyrus","id":1329734,"avatar_url":"https://avatars.githubusercontent.com/u/1329734?v=3","gravatar_id":"","url":"https://api.github.com/users/ronyrus","html_url":"https://github.com/ronyrus","followers_url":"https://api.github.com/users/ronyrus/followers","following_url":"https://api.github.com/users/ronyrus/following{/other_user}","gists_url":"https://api.github.com/users/ronyrus/gists{/gist_id}","starred_url":"https://api.github.com/users/ronyrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronyrus/subscriptions","organizations_url":"https://api.github.com/users/ronyrus/orgs","repos_url":"https://api.github.com/users/ronyrus/repos","events_url":"https://api.github.com/users/ronyrus/events{/privacy}","received_events_url":"https://api.github.com/users/ronyrus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ronyrus/Sark","description":"IDAPython Made Easy","fork":true,"url":"https://api.github.com/repos/ronyrus/Sark","forks_url":"https://api.github.com/repos/ronyrus/Sark/forks","keys_url":"https://api.github.com/repos/ronyrus/Sark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ronyrus/Sark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ronyrus/Sark/teams","hooks_url":"https://api.github.com/repos/ronyrus/Sark/hooks","issue_events_url":"https://api.github.com/repos/ronyrus/Sark/issues/events{/number}","events_url":"https://api.github.com/repos/ronyrus/Sark/events","assignees_url":"https://api.github.com/repos/ronyrus/Sark/assignees{/user}","branches_url":"https://api.github.com/repos/ronyrus/Sark/branches{/branch}","tags_url":"https://api.github.com/repos/ronyrus/Sark/tags","blobs_url":"https://api.github.com/repos/ronyrus/Sark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ronyrus/Sark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ronyrus/Sark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ronyrus/Sark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ronyrus/Sark/statuses/{sha}","languages_url":"https://api.github.com/repos/ronyrus/Sark/languages","stargazers_url":"https://api.github.com/repos/ronyrus/Sark/stargazers","contributors_url":"https://api.github.com/repos/ronyrus/Sark/contributors","subscribers_url":"https://api.github.com/repos/ronyrus/Sark/subscribers","subscription_url":"https://api.github.com/repos/ronyrus/Sark/subscription","commits_url":"https://api.github.com/repos/ronyrus/Sark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ronyrus/Sark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ronyrus/Sark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ronyrus/Sark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ronyrus/Sark/contents/{+path}","compare_url":"https://api.github.com/repos/ronyrus/Sark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ronyrus/Sark/merges","archive_url":"https://api.github.com/repos/ronyrus/Sark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ronyrus/Sark/downloads","issues_url":"https://api.github.com/repos/ronyrus/Sark/issues{/number}","pulls_url":"https://api.github.com/repos/ronyrus/Sark/pulls{/number}","milestones_url":"https://api.github.com/repos/ronyrus/Sark/milestones{/number}","notifications_url":"https://api.github.com/repos/ronyrus/Sark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ronyrus/Sark/labels{/name}","releases_url":"https://api.github.com/repos/ronyrus/Sark/releases{/id}","deployments_url":"https://api.github.com/repos/ronyrus/Sark/deployments","created_at":"2015-10-28T09:59:29Z","updated_at":"2016-02-21T12:32:03Z","pushed_at":"2016-03-31T11:54:23Z","git_url":"git://github.com/ronyrus/Sark.git","ssh_url":"git@github.com:ronyrus/Sark.git","clone_url":"https://github.com/ronyrus/Sark.git","svn_url":"https://github.com/ronyrus/Sark","homepage":"http://sark.readthedocs.org","size":2228,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tmr232:master","ref":"master","sha":"f4ce6d2eac9feece23455102e5ce08c567c1d0db","user":{"login":"tmr232","id":1386239,"avatar_url":"https://avatars.githubusercontent.com/u/1386239?v=3","gravatar_id":"","url":"https://api.github.com/users/tmr232","html_url":"https://github.com/tmr232","followers_url":"https://api.github.com/users/tmr232/followers","following_url":"https://api.github.com/users/tmr232/following{/other_user}","gists_url":"https://api.github.com/users/tmr232/gists{/gist_id}","starred_url":"https://api.github.com/users/tmr232/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmr232/subscriptions","organizations_url":"https://api.github.com/users/tmr232/orgs","repos_url":"https://api.github.com/users/tmr232/repos","events_url":"https://api.github.com/users/tmr232/events{/privacy}","received_events_url":"https://api.github.com/users/tmr232/received_events","type":"User","site_admin":false},"repo":{"id":29462715,"name":"Sark","full_name":"tmr232/Sark","owner":{"login":"tmr232","id":1386239,"avatar_url":"https://avatars.githubusercontent.com/u/1386239?v=3","gravatar_id":"","url":"https://api.github.com/users/tmr232","html_url":"https://github.com/tmr232","followers_url":"https://api.github.com/users/tmr232/followers","following_url":"https://api.github.com/users/tmr232/following{/other_user}","gists_url":"https://api.github.com/users/tmr232/gists{/gist_id}","starred_url":"https://api.github.com/users/tmr232/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmr232/subscriptions","organizations_url":"https://api.github.com/users/tmr232/orgs","repos_url":"https://api.github.com/users/tmr232/repos","events_url":"https://api.github.com/users/tmr232/events{/privacy}","received_events_url":"https://api.github.com/users/tmr232/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmr232/Sark","description":"IDAPython Made Easy","fork":false,"url":"https://api.github.com/repos/tmr232/Sark","forks_url":"https://api.github.com/repos/tmr232/Sark/forks","keys_url":"https://api.github.com/repos/tmr232/Sark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmr232/Sark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmr232/Sark/teams","hooks_url":"https://api.github.com/repos/tmr232/Sark/hooks","issue_events_url":"https://api.github.com/repos/tmr232/Sark/issues/events{/number}","events_url":"https://api.github.com/repos/tmr232/Sark/events","assignees_url":"https://api.github.com/repos/tmr232/Sark/assignees{/user}","branches_url":"https://api.github.com/repos/tmr232/Sark/branches{/branch}","tags_url":"https://api.github.com/repos/tmr232/Sark/tags","blobs_url":"https://api.github.com/repos/tmr232/Sark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmr232/Sark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmr232/Sark/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmr232/Sark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmr232/Sark/statuses/{sha}","languages_url":"https://api.github.com/repos/tmr232/Sark/languages","stargazers_url":"https://api.github.com/repos/tmr232/Sark/stargazers","contributors_url":"https://api.github.com/repos/tmr232/Sark/contributors","subscribers_url":"https://api.github.com/repos/tmr232/Sark/subscribers","subscription_url":"https://api.github.com/repos/tmr232/Sark/subscription","commits_url":"https://api.github.com/repos/tmr232/Sark/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmr232/Sark/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmr232/Sark/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmr232/Sark/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmr232/Sark/contents/{+path}","compare_url":"https://api.github.com/repos/tmr232/Sark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmr232/Sark/merges","archive_url":"https://api.github.com/repos/tmr232/Sark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmr232/Sark/downloads","issues_url":"https://api.github.com/repos/tmr232/Sark/issues{/number}","pulls_url":"https://api.github.com/repos/tmr232/Sark/pulls{/number}","milestones_url":"https://api.github.com/repos/tmr232/Sark/milestones{/number}","notifications_url":"https://api.github.com/repos/tmr232/Sark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmr232/Sark/labels{/name}","releases_url":"https://api.github.com/repos/tmr232/Sark/releases{/id}","deployments_url":"https://api.github.com/repos/tmr232/Sark/deployments","created_at":"2015-01-19T09:13:48Z","updated_at":"2016-03-22T12:59:56Z","pushed_at":"2016-03-31T11:54:41Z","git_url":"git://github.com/tmr232/Sark.git","ssh_url":"git@github.com:tmr232/Sark.git","clone_url":"https://github.com/tmr232/Sark.git","svn_url":"https://github.com/tmr232/Sark","homepage":"http://sark.readthedocs.org","size":2388,"stargazers_count":94,"watchers_count":94,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":10,"forks":21,"open_issues":10,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tmr232/Sark/pulls/35"},"html":{"href":"https://github.com/tmr232/Sark/pull/35"},"issue":{"href":"https://api.github.com/repos/tmr232/Sark/issues/35"},"comments":{"href":"https://api.github.com/repos/tmr232/Sark/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/tmr232/Sark/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/tmr232/Sark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tmr232/Sark/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/tmr232/Sark/statuses/7f7ae712ebee44a27f14372c7863b28c7f11c494"}}}}