{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/88439515","pull_request_review_id":9012021,"id":88439515,"diff_hunk":"@@ -538,6 +535,10 @@ func (er *expressionRewriter) unaryOpToExpression(v *ast.UnaryOperationExpr) {\n \t\ter.err = errors.Errorf(\"Unknown Unary Op %T\", v.Op)\n \t\treturn\n \t}\n+\tif getRowLen(er.ctxStack[stkLen-1]) != 1 {\n+\t\ter.err = ErrOneColumn\n+\t\treturn\n+\t}","path":"plan/expression_rewriter.go","position":70,"original_position":70,"commit_id":"ae395ea11bda06cca7fb26845269c9e06f37f3ed","original_commit_id":"ae395ea11bda06cca7fb26845269c9e06f37f3ed","user":{"login":"hanfei1991","id":20884546,"avatar_url":"https://avatars.githubusercontent.com/u/20884546?v=3","gravatar_id":"","url":"https://api.github.com/users/hanfei1991","html_url":"https://github.com/hanfei1991","followers_url":"https://api.github.com/users/hanfei1991/followers","following_url":"https://api.github.com/users/hanfei1991/following{/other_user}","gists_url":"https://api.github.com/users/hanfei1991/gists{/gist_id}","starred_url":"https://api.github.com/users/hanfei1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanfei1991/subscriptions","organizations_url":"https://api.github.com/users/hanfei1991/orgs","repos_url":"https://api.github.com/users/hanfei1991/repos","events_url":"https://api.github.com/users/hanfei1991/events{/privacy}","received_events_url":"https://api.github.com/users/hanfei1991/received_events","type":"User","site_admin":false},"body":"because + (1,2) will be treated as  (1,2) instead of reporting error.","created_at":"2016-11-17T12:08:42Z","updated_at":"2016-11-17T12:08:42Z","html_url":"https://github.com/pingcap/tidb/pull/2013#discussion_r88439515","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/2013","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/88439515"},"html":{"href":"https://github.com/pingcap/tidb/pull/2013#discussion_r88439515"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2013"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/2013","id":93775821,"html_url":"https://github.com/pingcap/tidb/pull/2013","diff_url":"https://github.com/pingcap/tidb/pull/2013.diff","patch_url":"https://github.com/pingcap/tidb/pull/2013.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/2013","number":2013,"state":"open","locked":false,"title":"plan: remove old validator logic","user":{"login":"hanfei1991","id":20884546,"avatar_url":"https://avatars.githubusercontent.com/u/20884546?v=3","gravatar_id":"","url":"https://api.github.com/users/hanfei1991","html_url":"https://github.com/hanfei1991","followers_url":"https://api.github.com/users/hanfei1991/followers","following_url":"https://api.github.com/users/hanfei1991/following{/other_user}","gists_url":"https://api.github.com/users/hanfei1991/gists{/gist_id}","starred_url":"https://api.github.com/users/hanfei1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanfei1991/subscriptions","organizations_url":"https://api.github.com/users/hanfei1991/orgs","repos_url":"https://api.github.com/users/hanfei1991/repos","events_url":"https://api.github.com/users/hanfei1991/events{/privacy}","received_events_url":"https://api.github.com/users/hanfei1991/received_events","type":"User","site_admin":false},"body":"clean useless code. The validating has been done in rewriter function.\r\n@shenli @coocood @zimulala @XuHuaiyu @tiancaiamao @winoros  PTAL","created_at":"2016-11-15T14:31:56Z","updated_at":"2016-11-17T12:08:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f566bcc91dfd37a1ee256daa7dac01895dcb566","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/2013/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/2013/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/2013/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/ae395ea11bda06cca7fb26845269c9e06f37f3ed","head":{"label":"pingcap:hanfei/validate","ref":"hanfei/validate","sha":"ae395ea11bda06cca7fb26845269c9e06f37f3ed","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2016-11-17T11:40:24Z","pushed_at":"2016-11-17T11:57:46Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":27688,"stargazers_count":5228,"watchers_count":5228,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":674,"mirror_url":null,"open_issues_count":137,"forks":674,"open_issues":137,"watchers":5228,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"fdb74960a44852e8553553906500eadf1d2e820f","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2016-11-17T11:40:24Z","pushed_at":"2016-11-17T11:57:46Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":27688,"stargazers_count":5228,"watchers_count":5228,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":674,"mirror_url":null,"open_issues_count":137,"forks":674,"open_issues":137,"watchers":5228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2013"},"html":{"href":"https://github.com/pingcap/tidb/pull/2013"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/2013"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/2013/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2013/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/2013/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/ae395ea11bda06cca7fb26845269c9e06f37f3ed"}}}}
{"actor":{"display_login":"hanfei1991"}}