{"action":"created","issue":{"url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit/issues/169","repository_url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit","labels_url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit/issues/169/labels{/name}","comments_url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit/issues/169/comments","events_url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit/issues/169/events","html_url":"https://github.com/AusDTO/gov-au-ui-kit/pull/169","id":165707896,"number":169,"title":"Accordions","user":{"login":"klepas","id":52766,"avatar_url":"https://avatars.githubusercontent.com/u/52766?v=3","gravatar_id":"","url":"https://api.github.com/users/klepas","html_url":"https://github.com/klepas","followers_url":"https://api.github.com/users/klepas/followers","following_url":"https://api.github.com/users/klepas/following{/other_user}","gists_url":"https://api.github.com/users/klepas/gists{/gist_id}","starred_url":"https://api.github.com/users/klepas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klepas/subscriptions","organizations_url":"https://api.github.com/users/klepas/orgs","repos_url":"https://api.github.com/users/klepas/repos","events_url":"https://api.github.com/users/klepas/events{/privacy}","received_events_url":"https://api.github.com/users/klepas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-15T04:12:23Z","updated_at":"2016-07-19T01:41:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit/pulls/169","html_url":"https://github.com/AusDTO/gov-au-ui-kit/pull/169","diff_url":"https://github.com/AusDTO/gov-au-ui-kit/pull/169.diff","patch_url":"https://github.com/AusDTO/gov-au-ui-kit/pull/169.patch"},"body":"## Description\r\n\r\nThis adds accordions via `<detail>` and `<summary>` with support to use divs. It’s mostly complete, but needs a few more things…\r\n\r\nThis branch also holds a number of other items not really related to the accordions (sorry :S), including:\r\n\r\n- adds `$lighter-aqua`\r\n- fixes/re-aligns left padding/margin for generic content `li` (was changed in the last sprint and was out of alignment with quotes, def. lists, callouts, etc. \r\n- separates styling for `img` into it’s own partial\r\n- adds responsive video support for `embed`, `object`, and `iframe`\r\n- adds styling for `kbd` elements, inc. documentation (within the typography partial — needs reordering though)\r\n- changes the background colour for `blockquote` from `$lighter-grey` to `$non-white`\r\n\r\n## Additional information\r\n\r\nThings left to do:\r\n\r\n- check over ARIA roles\r\n- sprinkle with some JS love add/remove the `open` attribute\r\n- some more testing\r\n- check over `:focus` and `:hover` styling\r\n- test a group of the accordions together, and how they interact (open/close of multiple items)\r\n- consider using definition lists over divs?\r\n- documentation and usage guidelines\r\n\r\nThe current example of the accordion lives inside `examples/index.html`.\r\n\r\nPlease review and discuss to complete! ^_^"},"comment":{"url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit/issues/comments/233507975","html_url":"https://github.com/AusDTO/gov-au-ui-kit/pull/169#issuecomment-233507975","issue_url":"https://api.github.com/repos/AusDTO/gov-au-ui-kit/issues/169","id":233507975,"user":{"login":"klepas","id":52766,"avatar_url":"https://avatars.githubusercontent.com/u/52766?v=3","gravatar_id":"","url":"https://api.github.com/users/klepas","html_url":"https://github.com/klepas","followers_url":"https://api.github.com/users/klepas/followers","following_url":"https://api.github.com/users/klepas/following{/other_user}","gists_url":"https://api.github.com/users/klepas/gists{/gist_id}","starred_url":"https://api.github.com/users/klepas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klepas/subscriptions","organizations_url":"https://api.github.com/users/klepas/orgs","repos_url":"https://api.github.com/users/klepas/repos","events_url":"https://api.github.com/users/klepas/events{/privacy}","received_events_url":"https://api.github.com/users/klepas/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T01:41:47Z","updated_at":"2016-07-19T01:41:47Z","body":"Possibly nagging question: prospects for including expand/collapse all toggle links at the top of a series of accordions? :S"}}
{"actor":{"display_login":"klepas"}}