{"action":"created","issue":{"url":"https://api.github.com/repos/MailOnline/videojs-vast-vpaid/issues/107","labels_url":"https://api.github.com/repos/MailOnline/videojs-vast-vpaid/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/MailOnline/videojs-vast-vpaid/issues/107/comments","events_url":"https://api.github.com/repos/MailOnline/videojs-vast-vpaid/issues/107/events","html_url":"https://github.com/MailOnline/videojs-vast-vpaid/pull/107","id":125076441,"number":107,"title":"Add support for videojs 5.x","user":{"login":"wmcmurray","id":3208106,"avatar_url":"https://avatars.githubusercontent.com/u/3208106?v=3","gravatar_id":"","url":"https://api.github.com/users/wmcmurray","html_url":"https://github.com/wmcmurray","followers_url":"https://api.github.com/users/wmcmurray/followers","following_url":"https://api.github.com/users/wmcmurray/following{/other_user}","gists_url":"https://api.github.com/users/wmcmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/wmcmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmcmurray/subscriptions","organizations_url":"https://api.github.com/users/wmcmurray/orgs","repos_url":"https://api.github.com/users/wmcmurray/repos","events_url":"https://api.github.com/users/wmcmurray/events{/privacy}","received_events_url":"https://api.github.com/users/wmcmurray/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-01-05T23:28:20Z","updated_at":"2016-01-16T07:34:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MailOnline/videojs-vast-vpaid/pulls/107","html_url":"https://github.com/MailOnline/videojs-vast-vpaid/pull/107","diff_url":"https://github.com/MailOnline/videojs-vast-vpaid/pull/107.diff","patch_url":"https://github.com/MailOnline/videojs-vast-vpaid/pull/107.patch"},"body":"**NOTE:** I copied the relevant changes from this pull request https://github.com/MailOnline/videojs-vast-vpaid/pull/86 and I fixed what wasn't working. I did this because I needed a working version ASAP for my colleagues.\r\n\r\nI also did this pull request on top of my other pull request (https://github.com/MailOnline/videojs-vast-vpaid/pull/105) because I needed those changes applied.\r\n\r\n...So, **it works**, but I've seen some **strange stuff** that (I believe) are not related to this plugin :\r\n- The player's `timeupdate` event is not triggered on flash ads, which cause the remaining time to stay stuck at `-0:46` in the demo page (it's the duration of the video that will play after the ad).\r\n- The full screen button is not aligned right because when there is no timeline, the button seems to take it's place (which is different from the UI of the 4.x version).\r\n- There is also a double \"skip ad\" button in on of the sample ads of the demo, but that was there before :)\r\n\r\nI hope you'll merge this soon, thanks !\r\n\r\nWill fix issue https://github.com/MailOnline/videojs-vast-vpaid/issues/74"},"comment":{"url":"https://api.github.com/repos/MailOnline/videojs-vast-vpaid/issues/comments/172169700","html_url":"https://github.com/MailOnline/videojs-vast-vpaid/pull/107#issuecomment-172169700","issue_url":"https://api.github.com/repos/MailOnline/videojs-vast-vpaid/issues/107","id":172169700,"user":{"login":"whatvn","id":846452,"avatar_url":"https://avatars.githubusercontent.com/u/846452?v=3","gravatar_id":"","url":"https://api.github.com/users/whatvn","html_url":"https://github.com/whatvn","followers_url":"https://api.github.com/users/whatvn/followers","following_url":"https://api.github.com/users/whatvn/following{/other_user}","gists_url":"https://api.github.com/users/whatvn/gists{/gist_id}","starred_url":"https://api.github.com/users/whatvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatvn/subscriptions","organizations_url":"https://api.github.com/users/whatvn/orgs","repos_url":"https://api.github.com/users/whatvn/repos","events_url":"https://api.github.com/users/whatvn/events{/privacy}","received_events_url":"https://api.github.com/users/whatvn/received_events","type":"User","site_admin":false},"created_at":"2016-01-16T07:34:54Z","updated_at":"2016-01-16T07:34:54Z","body":"@wmcmurray did you test this fix with mobile browser like Safari on Iphone and Chrome on Android/Iphone. I cannot make it work on mobile browser, although there's no errorr at all, the plugin initialized and then freeze, video playback cannot start too. \r\n"}}