{"action":"created","comment":{"url":"https://api.github.com/repos/datastax/cstar_perf/pulls/comments/62884448","id":62884448,"diff_hunk":"@@ -461,7 +461,7 @@ def destroy(leave_data=False, kill_delay=0):\n         if config.get('hints_directory'):\n             fab.run('rm -rf {hints_directory}/*'.format(hints_directory=config.get('hints_directory')))\n         _clean_up_cdc_directories()\n-    fab.run('rm -rf {log_dir}'.format(log_dir=config['log_dir']))\n+        fab.run('rm -rf {log_dir}/*'.format(log_dir=config['log_dir']))","path":"tool/cstar_perf/tool/fab_common.py","position":5,"original_position":5,"commit_id":"ec1c75f99d28e851b8c644831b6c701929acffb4","original_commit_id":"ec1c75f99d28e851b8c644831b6c701929acffb4","user":{"login":"nastra","id":271029,"avatar_url":"https://avatars.githubusercontent.com/u/271029?v=3","gravatar_id":"","url":"https://api.github.com/users/nastra","html_url":"https://github.com/nastra","followers_url":"https://api.github.com/users/nastra/followers","following_url":"https://api.github.com/users/nastra/following{/other_user}","gists_url":"https://api.github.com/users/nastra/gists{/gist_id}","starred_url":"https://api.github.com/users/nastra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nastra/subscriptions","organizations_url":"https://api.github.com/users/nastra/orgs","repos_url":"https://api.github.com/users/nastra/repos","events_url":"https://api.github.com/users/nastra/events{/privacy}","received_events_url":"https://api.github.com/users/nastra/received_events","type":"User","site_admin":false},"body":"`leave_data` actually indicates only leaving the data dirs, not the log files. The log files will anyway be preserved at some other point. I would probably correct the indentation here to how it was before.\r\n\r\nOption 2 would be to rename `leave_data` to `leave_data_and_logs`","created_at":"2016-05-11T16:52:14Z","updated_at":"2016-05-11T16:52:14Z","html_url":"https://github.com/datastax/cstar_perf/pull/201#discussion_r62884448","pull_request_url":"https://api.github.com/repos/datastax/cstar_perf/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/datastax/cstar_perf/pulls/comments/62884448"},"html":{"href":"https://github.com/datastax/cstar_perf/pull/201#discussion_r62884448"},"pull_request":{"href":"https://api.github.com/repos/datastax/cstar_perf/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/datastax/cstar_perf/pulls/201","id":69588101,"html_url":"https://github.com/datastax/cstar_perf/pull/201","diff_url":"https://github.com/datastax/cstar_perf/pull/201.diff","patch_url":"https://github.com/datastax/cstar_perf/pull/201.patch","issue_url":"https://api.github.com/repos/datastax/cstar_perf/issues/201","number":201,"state":"open","locked":false,"title":"CSTAR-535: Remove old data as root user","user":{"login":"csplinter","id":5075869,"avatar_url":"https://avatars.githubusercontent.com/u/5075869?v=3","gravatar_id":"","url":"https://api.github.com/users/csplinter","html_url":"https://github.com/csplinter","followers_url":"https://api.github.com/users/csplinter/followers","following_url":"https://api.github.com/users/csplinter/following{/other_user}","gists_url":"https://api.github.com/users/csplinter/gists{/gist_id}","starred_url":"https://api.github.com/users/csplinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csplinter/subscriptions","organizations_url":"https://api.github.com/users/csplinter/orgs","repos_url":"https://api.github.com/users/csplinter/repos","events_url":"https://api.github.com/users/csplinter/events{/privacy}","received_events_url":"https://api.github.com/users/csplinter/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-10T22:25:06Z","updated_at":"2016-05-11T16:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"900d9b9df81ea0686e4953f5c4ad1e4e6d1afefd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/datastax/cstar_perf/pulls/201/commits","review_comments_url":"https://api.github.com/repos/datastax/cstar_perf/pulls/201/comments","review_comment_url":"https://api.github.com/repos/datastax/cstar_perf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datastax/cstar_perf/issues/201/comments","statuses_url":"https://api.github.com/repos/datastax/cstar_perf/statuses/ec1c75f99d28e851b8c644831b6c701929acffb4","head":{"label":"datastax:CS_CERT_535","ref":"CS_CERT_535","sha":"ec1c75f99d28e851b8c644831b6c701929acffb4","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":21586660,"name":"cstar_perf","full_name":"datastax/cstar_perf","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/cstar_perf","description":"Apache Cassandra performance testing platform","fork":false,"url":"https://api.github.com/repos/datastax/cstar_perf","forks_url":"https://api.github.com/repos/datastax/cstar_perf/forks","keys_url":"https://api.github.com/repos/datastax/cstar_perf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/cstar_perf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/cstar_perf/teams","hooks_url":"https://api.github.com/repos/datastax/cstar_perf/hooks","issue_events_url":"https://api.github.com/repos/datastax/cstar_perf/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/cstar_perf/events","assignees_url":"https://api.github.com/repos/datastax/cstar_perf/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/cstar_perf/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/cstar_perf/tags","blobs_url":"https://api.github.com/repos/datastax/cstar_perf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/cstar_perf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/cstar_perf/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/cstar_perf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/cstar_perf/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/cstar_perf/languages","stargazers_url":"https://api.github.com/repos/datastax/cstar_perf/stargazers","contributors_url":"https://api.github.com/repos/datastax/cstar_perf/contributors","subscribers_url":"https://api.github.com/repos/datastax/cstar_perf/subscribers","subscription_url":"https://api.github.com/repos/datastax/cstar_perf/subscription","commits_url":"https://api.github.com/repos/datastax/cstar_perf/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/cstar_perf/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/cstar_perf/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/cstar_perf/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/cstar_perf/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/cstar_perf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/cstar_perf/merges","archive_url":"https://api.github.com/repos/datastax/cstar_perf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/cstar_perf/downloads","issues_url":"https://api.github.com/repos/datastax/cstar_perf/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/cstar_perf/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/cstar_perf/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/cstar_perf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/cstar_perf/labels{/name}","releases_url":"https://api.github.com/repos/datastax/cstar_perf/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/cstar_perf/deployments","created_at":"2014-07-07T21:02:34Z","updated_at":"2016-04-20T07:59:38Z","pushed_at":"2016-05-11T16:43:25Z","git_url":"git://github.com/datastax/cstar_perf.git","ssh_url":"git@github.com:datastax/cstar_perf.git","clone_url":"https://github.com/datastax/cstar_perf.git","svn_url":"https://github.com/datastax/cstar_perf","homepage":"","size":1957,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":70,"forks":19,"open_issues":70,"watchers":47,"default_branch":"master"}},"base":{"label":"datastax:master","ref":"master","sha":"da90b396d8cd91a3a1080618e2ca338124980c40","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":21586660,"name":"cstar_perf","full_name":"datastax/cstar_perf","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars.githubusercontent.com/u/573369?v=3","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/cstar_perf","description":"Apache Cassandra performance testing platform","fork":false,"url":"https://api.github.com/repos/datastax/cstar_perf","forks_url":"https://api.github.com/repos/datastax/cstar_perf/forks","keys_url":"https://api.github.com/repos/datastax/cstar_perf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/cstar_perf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/cstar_perf/teams","hooks_url":"https://api.github.com/repos/datastax/cstar_perf/hooks","issue_events_url":"https://api.github.com/repos/datastax/cstar_perf/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/cstar_perf/events","assignees_url":"https://api.github.com/repos/datastax/cstar_perf/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/cstar_perf/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/cstar_perf/tags","blobs_url":"https://api.github.com/repos/datastax/cstar_perf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/cstar_perf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/cstar_perf/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/cstar_perf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/cstar_perf/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/cstar_perf/languages","stargazers_url":"https://api.github.com/repos/datastax/cstar_perf/stargazers","contributors_url":"https://api.github.com/repos/datastax/cstar_perf/contributors","subscribers_url":"https://api.github.com/repos/datastax/cstar_perf/subscribers","subscription_url":"https://api.github.com/repos/datastax/cstar_perf/subscription","commits_url":"https://api.github.com/repos/datastax/cstar_perf/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/cstar_perf/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/cstar_perf/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/cstar_perf/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/cstar_perf/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/cstar_perf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/cstar_perf/merges","archive_url":"https://api.github.com/repos/datastax/cstar_perf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/cstar_perf/downloads","issues_url":"https://api.github.com/repos/datastax/cstar_perf/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/cstar_perf/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/cstar_perf/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/cstar_perf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/cstar_perf/labels{/name}","releases_url":"https://api.github.com/repos/datastax/cstar_perf/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/cstar_perf/deployments","created_at":"2014-07-07T21:02:34Z","updated_at":"2016-04-20T07:59:38Z","pushed_at":"2016-05-11T16:43:25Z","git_url":"git://github.com/datastax/cstar_perf.git","ssh_url":"git@github.com:datastax/cstar_perf.git","clone_url":"https://github.com/datastax/cstar_perf.git","svn_url":"https://github.com/datastax/cstar_perf","homepage":"","size":1957,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":70,"forks":19,"open_issues":70,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datastax/cstar_perf/pulls/201"},"html":{"href":"https://github.com/datastax/cstar_perf/pull/201"},"issue":{"href":"https://api.github.com/repos/datastax/cstar_perf/issues/201"},"comments":{"href":"https://api.github.com/repos/datastax/cstar_perf/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/datastax/cstar_perf/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/datastax/cstar_perf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datastax/cstar_perf/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/datastax/cstar_perf/statuses/ec1c75f99d28e851b8c644831b6c701929acffb4"}}}}