{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3729","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3729/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3729/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3729/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/3729","id":156559743,"number":3729,"title":"Fix for pip stripping \"-e\" from command when local source is not VCS (#3426)","user":{"login":"kenwmitchell","id":570610,"avatar_url":"https://avatars.githubusercontent.com/u/570610?v=3","gravatar_id":"","url":"https://api.github.com/users/kenwmitchell","html_url":"https://github.com/kenwmitchell","followers_url":"https://api.github.com/users/kenwmitchell/followers","following_url":"https://api.github.com/users/kenwmitchell/following{/other_user}","gists_url":"https://api.github.com/users/kenwmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenwmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenwmitchell/subscriptions","organizations_url":"https://api.github.com/users/kenwmitchell/orgs","repos_url":"https://api.github.com/users/kenwmitchell/repos","events_url":"https://api.github.com/users/kenwmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/kenwmitchell/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/bugfix_pull_request","name":"bugfix_pull_request","color":"ded270"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/community_review","name":"community_review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-24T17:04:27Z","updated_at":"2016-05-24T21:25:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/3729","html_url":"https://github.com/ansible/ansible-modules-core/pull/3729","diff_url":"https://github.com/ansible/ansible-modules-core/pull/3729.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/3729.patch"},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\npip\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.2.0 (devel f9c4fdab40) last updated 2016/05/24 08:04:39 (GMT -500)\r\n  lib/ansible/modules/core: (issue_3426 5e6dca9428) last updated 2016/05/24 11:51:38 (GMT -500)\r\n  lib/ansible/modules/extras: (detached HEAD 148a0ddabf) last updated 2016/05/24 08:03:33 (GMT -500)\r\n  config file =\r\n  configured module search path = Default w/o overrides\r\n\r\n```\r\n\r\n##### SUMMARY\r\nCode checked that `name` contained a VCS extension, AND that `editable: yes`. If one\r\nwas false, then the \"-e\" argument was not applied. I think (and believe this was the\r\noriginal author's intent based on comments) that \"-e\" should be applied if either case\r\nwas true. This commit changes the boolean check from *AND* to *OR*.\r\n\r\n_Before_\r\n```\r\nok: [localhost] => {\"changed\": false, \"cmd\": \"/bin/pip install .\", \"invocation\": {\"module_args\": {\"chdir\": \"/var/tmp/mock-2.0.0\", \"editable\": true, \"executable\": null, \"extra_args\": null, \"name\": \".\", \"requirements\": null, \"state\": \"present\", \"umask\": null, \"use_mirrors\": true, \"version\": null, \"virtualenv\": null, \"virtualenv_command\": \"virtualenv\", \"virtualenv_python\": null, \"virtualenv_site_packages\": false}, \"module_name\": \"pip\"}, \"name\": \".\", \"requirements\": null, \"state\": \"present\", \"stderr\": \"\", \"stdout\": \"Processing /var/tmp/mock-2.0.0\\n  Requirement already satisfied (use --upgrade to upgrade): mock==2.0.0 from file:///var/tmp/mock-2.0.0 in /var/tmp/mock-2.0.0\\nRequirement already satisfied (use --upgrade to upgrade): pbr>=0.11 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\\nRequirement already satisfied (use --upgrade to upgrade): six>=1.9 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\\nRequirement already satisfied (use --upgrade to upgrade): funcsigs>=1 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\\n\", \"stdout_lines\": [\"Processing /var/tmp/mock-2.0.0\", \"  Requirement already satisfied (use --upgrade to upgrade): mock==2.0.0 from file:///var/tmp/mock-2.0.0 in /var/tmp/mock-2.0.0\", \"Requirement already satisfied (use --upgrade to upgrade): pbr>=0.11 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\", \"Requirement already satisfied (use --upgrade to upgrade): six>=1.9 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\", \"Requirement already satisfied (use --upgrade to upgrade): funcsigs>=1 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\"], \"version\": null, \"virtualenv\": null}\r\n...\r\n>>> import mock\r\nTraceback (most recent call last):\r\n  File \"<stdin>\", line 1, in <module>\r\nImportError: No module named mock\r\n>>>\r\n\r\n```\r\n\r\n_After_\r\n```\r\nchanged: [localhost] => {\"changed\": true, \"cmd\": \"/bin/pip install -e .\", \"invocation\": {\"module_args\": {\"chdir\": \"/var/tmp/mock-2.0.0\", \"editable\": true, \"executable\": null, \"extra_args\": null, \"name\": \".\", \"requirements\": null, \"state\": \"present\", \"umask\": null, \"use_mirrors\": true, \"version\": null, \"virtualenv\": null, \"virtualenv_command\": \"virtualenv\", \"virtualenv_python\": null, \"virtualenv_site_packages\": false}, \"module_name\": \"pip\"}, \"name\": \".\", \"requirements\": null, \"state\": \"present\", \"stderr\": \"\", \"stdout\": \"Obtaining file:///var/tmp/mock-2.0.0\\nRequirement already satisfied (use --upgrade to upgrade): pbr>=0.11 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\\nRequirement already satisfied (use --upgrade to upgrade): six>=1.9 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\\nRequirement already satisfied (use --upgrade to upgrade): funcsigs>=1 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\\nInstalling collected packages: mock\\n  Running setup.py develop for mock\\nSuccessfully installed mock-2.0.0\\n\", \"stdout_lines\": [\"Obtaining file:///var/tmp/mock-2.0.0\", \"Requirement already satisfied (use --upgrade to upgrade): pbr>=0.11 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\", \"Requirement already satisfied (use --upgrade to upgrade): six>=1.9 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\", \"Requirement already satisfied (use --upgrade to upgrade): funcsigs>=1 in /usr/lib/python2.7/site-packages (from mock==2.0.0)\", \"Installing collected packages: mock\", \"  Running setup.py develop for mock\", \"Successfully installed mock-2.0.0\"], \"version\": null, \"virtualenv\": null}\r\n...\r\n>>> import mock\r\n>>>\r\n```"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/221406170","html_url":"https://github.com/ansible/ansible-modules-core/pull/3729#issuecomment-221406170","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/3729","id":221406170,"user":{"login":"gregdek","id":252125,"avatar_url":"https://avatars.githubusercontent.com/u/252125?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdek","html_url":"https://github.com/gregdek","followers_url":"https://api.github.com/users/gregdek/followers","following_url":"https://api.github.com/users/gregdek/following{/other_user}","gists_url":"https://api.github.com/users/gregdek/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdek/subscriptions","organizations_url":"https://api.github.com/users/gregdek/orgs","repos_url":"https://api.github.com/users/gregdek/repos","events_url":"https://api.github.com/users/gregdek/events{/privacy}","received_events_url":"https://api.github.com/users/gregdek/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T21:25:13Z","updated_at":"2016-05-24T21:25:13Z","body":"Thanks @kenwmitchell. To the current maintainers, @mattupstate please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.\n\n[This message brought to you by your friendly Ansibull-bot.]"}}
{"actor":{"display_login":"gregdek"}}