{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/25242","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/25242/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/25242/comments","events_url":"https://api.github.com/repos/rails/rails/issues/25242/events","html_url":"https://github.com/rails/rails/pull/25242","id":158055116,"number":25242,"title":"Hashing in AR wthout array allocation and updating corresponding documentation to reference the class","user":{"login":"brocktimus","id":2103728,"avatar_url":"https://avatars.githubusercontent.com/u/2103728?v=3","gravatar_id":"","url":"https://api.github.com/users/brocktimus","html_url":"https://github.com/brocktimus","followers_url":"https://api.github.com/users/brocktimus/followers","following_url":"https://api.github.com/users/brocktimus/following{/other_user}","gists_url":"https://api.github.com/users/brocktimus/gists{/gist_id}","starred_url":"https://api.github.com/users/brocktimus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brocktimus/subscriptions","organizations_url":"https://api.github.com/users/brocktimus/orgs","repos_url":"https://api.github.com/users/brocktimus/repos","events_url":"https://api.github.com/users/brocktimus/events{/privacy}","received_events_url":"https://api.github.com/users/brocktimus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rails/rails/labels/activerecord","name":"activerecord","color":"0b02e1"}],"state":"closed","locked":false,"assignee":{"login":"sgrif","id":1529387,"avatar_url":"https://avatars.githubusercontent.com/u/1529387?v=3","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false},"assignees":[{"login":"sgrif","id":1529387,"avatar_url":"https://avatars.githubusercontent.com/u/1529387?v=3","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-06-02T04:02:41Z","updated_at":"2016-09-27T20:12:04Z","closed_at":"2016-09-26T23:58:37Z","pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/25242","html_url":"https://github.com/rails/rails/pull/25242","diff_url":"https://github.com/rails/rails/pull/25242.diff","patch_url":"https://github.com/rails/rails/pull/25242.patch"},"body":"### Summary\r\n\r\nI noticed the comment in c8be4574 by @sgrif mentioning array allocation he didn't like. I'd read elsewhere that multiple hashes could just be combined with xor. Also updating documentation to reference that we're also hashing in the class.\r\n\r\n### Other Information\r\n\r\nOnly addressing because of comments in the prior commit. I'm obviously not going to hunt around trying to shave an object allocation from random methods. Probably more useful for the documentation side of the commit more than anything else.\r\n\r\nDoes this need a change log since previous change didn't have one?"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/249983762","html_url":"https://github.com/rails/rails/pull/25242#issuecomment-249983762","issue_url":"https://api.github.com/repos/rails/rails/issues/25242","id":249983762,"user":{"login":"sgrif","id":1529387,"avatar_url":"https://avatars.githubusercontent.com/u/1529387?v=3","gravatar_id":"","url":"https://api.github.com/users/sgrif","html_url":"https://github.com/sgrif","followers_url":"https://api.github.com/users/sgrif/followers","following_url":"https://api.github.com/users/sgrif/following{/other_user}","gists_url":"https://api.github.com/users/sgrif/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrif/subscriptions","organizations_url":"https://api.github.com/users/sgrif/orgs","repos_url":"https://api.github.com/users/sgrif/repos","events_url":"https://api.github.com/users/sgrif/events{/privacy}","received_events_url":"https://api.github.com/users/sgrif/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T20:12:04Z","updated_at":"2016-09-27T20:12:04Z","body":"The documentation is still generally correct. I don't think we need to document the specific implementation of it. The externally visible behavior hasn't changed."}}
{"actor":{"display_login":"sgrif"}}