{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/67969626","id":67969626,"diff_hunk":"@@ -174,7 +178,20 @@ void ControllerManager::updateControllerList() {\n \n     locker.relock();\n     if (newDeviceList != m_controllers) {\n+        // Check for keyboard controller\n+        KeyboardController* pKeyboardController;\n+        foreach (Controller* pController, newDeviceList) {\n+            pKeyboardController = qobject_cast<KeyboardController*>(pController);","path":"src/controllers/controllermanager.cpp","position":null,"original_position":43,"commit_id":"2384846c8b459a86be69b5702dfae2ff51018119","original_commit_id":"aa2b72a3d57e43c42b8b47fb136d3c405342ab52","user":{"login":"Tomasito665","id":12563382,"avatar_url":"https://avatars.githubusercontent.com/u/12563382?v=3","gravatar_id":"","url":"https://api.github.com/users/Tomasito665","html_url":"https://github.com/Tomasito665","followers_url":"https://api.github.com/users/Tomasito665/followers","following_url":"https://api.github.com/users/Tomasito665/following{/other_user}","gists_url":"https://api.github.com/users/Tomasito665/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomasito665/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomasito665/subscriptions","organizations_url":"https://api.github.com/users/Tomasito665/orgs","repos_url":"https://api.github.com/users/Tomasito665/repos","events_url":"https://api.github.com/users/Tomasito665/events{/privacy}","received_events_url":"https://api.github.com/users/Tomasito665/received_events","type":"User","site_admin":false},"body":"I removed `KeyboardEnumerator`. `KeyboardController` is now created and deleted directly in `ControllerManager`. This avoids this nasty loop and casting.","created_at":"2016-06-21T23:14:13Z","updated_at":"2016-06-21T23:14:13Z","html_url":"https://github.com/mixxxdj/mixxx/pull/966#discussion_r67969626","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/67969626"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/966#discussion_r67969626"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966","id":74539640,"html_url":"https://github.com/mixxxdj/mixxx/pull/966","diff_url":"https://github.com/mixxxdj/mixxx/pull/966.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/966.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/966","number":966,"state":"open","locked":false,"title":"[WIP] KeyboardController","user":{"login":"Tomasito665","id":12563382,"avatar_url":"https://avatars.githubusercontent.com/u/12563382?v=3","gravatar_id":"","url":"https://api.github.com/users/Tomasito665","html_url":"https://github.com/Tomasito665","followers_url":"https://api.github.com/users/Tomasito665/followers","following_url":"https://api.github.com/users/Tomasito665/following{/other_user}","gists_url":"https://api.github.com/users/Tomasito665/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomasito665/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomasito665/subscriptions","organizations_url":"https://api.github.com/users/Tomasito665/orgs","repos_url":"https://api.github.com/users/Tomasito665/repos","events_url":"https://api.github.com/users/Tomasito665/events{/privacy}","received_events_url":"https://api.github.com/users/Tomasito665/received_events","type":"User","site_admin":false},"body":"This summer I am taking up the keyboard mapping GUI. The keymapping GUI will be accessed by going to preferences -> controllers -> keyboard. But of course, in order to be listed under controllers, the keyboard has to be a legit controller itself. That controller is called `KeyboardController`.\r\n\r\nSee [this blog](https://gsoc-mixxx-keymappinggui.blogspot.com/) for more info.\r\n\r\nIt's not entirely finished yet though, TODOs:\r\n- Write tests\r\n- Implement some cleverness to automatically choose which keyboard layout to load","created_at":"2016-06-21T01:39:37Z","updated_at":"2016-06-21T23:14:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57db84a454de1b5688c4699f35f1f9326541766f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/966/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/2384846c8b459a86be69b5702dfae2ff51018119","head":{"label":"Tomasito665:develop","ref":"develop","sha":"2384846c8b459a86be69b5702dfae2ff51018119","user":{"login":"Tomasito665","id":12563382,"avatar_url":"https://avatars.githubusercontent.com/u/12563382?v=3","gravatar_id":"","url":"https://api.github.com/users/Tomasito665","html_url":"https://github.com/Tomasito665","followers_url":"https://api.github.com/users/Tomasito665/followers","following_url":"https://api.github.com/users/Tomasito665/following{/other_user}","gists_url":"https://api.github.com/users/Tomasito665/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomasito665/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomasito665/subscriptions","organizations_url":"https://api.github.com/users/Tomasito665/orgs","repos_url":"https://api.github.com/users/Tomasito665/repos","events_url":"https://api.github.com/users/Tomasito665/events{/privacy}","received_events_url":"https://api.github.com/users/Tomasito665/received_events","type":"User","site_admin":false},"repo":{"id":58553490,"name":"mixxx","full_name":"Tomasito665/mixxx","owner":{"login":"Tomasito665","id":12563382,"avatar_url":"https://avatars.githubusercontent.com/u/12563382?v=3","gravatar_id":"","url":"https://api.github.com/users/Tomasito665","html_url":"https://github.com/Tomasito665","followers_url":"https://api.github.com/users/Tomasito665/followers","following_url":"https://api.github.com/users/Tomasito665/following{/other_user}","gists_url":"https://api.github.com/users/Tomasito665/gists{/gist_id}","starred_url":"https://api.github.com/users/Tomasito665/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tomasito665/subscriptions","organizations_url":"https://api.github.com/users/Tomasito665/orgs","repos_url":"https://api.github.com/users/Tomasito665/repos","events_url":"https://api.github.com/users/Tomasito665/events{/privacy}","received_events_url":"https://api.github.com/users/Tomasito665/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tomasito665/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/Tomasito665/mixxx","forks_url":"https://api.github.com/repos/Tomasito665/mixxx/forks","keys_url":"https://api.github.com/repos/Tomasito665/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tomasito665/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tomasito665/mixxx/teams","hooks_url":"https://api.github.com/repos/Tomasito665/mixxx/hooks","issue_events_url":"https://api.github.com/repos/Tomasito665/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/Tomasito665/mixxx/events","assignees_url":"https://api.github.com/repos/Tomasito665/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/Tomasito665/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/Tomasito665/mixxx/tags","blobs_url":"https://api.github.com/repos/Tomasito665/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tomasito665/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tomasito665/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tomasito665/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tomasito665/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/Tomasito665/mixxx/languages","stargazers_url":"https://api.github.com/repos/Tomasito665/mixxx/stargazers","contributors_url":"https://api.github.com/repos/Tomasito665/mixxx/contributors","subscribers_url":"https://api.github.com/repos/Tomasito665/mixxx/subscribers","subscription_url":"https://api.github.com/repos/Tomasito665/mixxx/subscription","commits_url":"https://api.github.com/repos/Tomasito665/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tomasito665/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tomasito665/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tomasito665/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tomasito665/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/Tomasito665/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tomasito665/mixxx/merges","archive_url":"https://api.github.com/repos/Tomasito665/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tomasito665/mixxx/downloads","issues_url":"https://api.github.com/repos/Tomasito665/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/Tomasito665/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/Tomasito665/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/Tomasito665/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tomasito665/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/Tomasito665/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/Tomasito665/mixxx/deployments","created_at":"2016-05-11T14:44:42Z","updated_at":"2016-05-11T14:44:57Z","pushed_at":"2016-06-21T23:04:39Z","git_url":"git://github.com/Tomasito665/mixxx.git","ssh_url":"git@github.com:Tomasito665/mixxx.git","clone_url":"https://github.com/Tomasito665/mixxx.git","svn_url":"https://github.com/Tomasito665/mixxx","homepage":"http://mixxx.org","size":259263,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"967772365a8ad6ce68149461fae76b28fc6f06af","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars.githubusercontent.com/u/1743769?v=3","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2016-06-18T19:08:28Z","pushed_at":"2016-06-21T23:04:39Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":274772,"stargazers_count":541,"watchers_count":541,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":62,"forks":333,"open_issues":62,"watchers":541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/966"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/966"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/966/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/966/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/2384846c8b459a86be69b5702dfae2ff51018119"}}}}
{"actor":{"display_login":"Tomasito665"}}