{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments/62855482","id":62855482,"diff_hunk":"@@ -0,0 +1,4 @@\n+%visuallyhidden {\n+  position: absolute;\n+  left: -9999em;","path":"toolkit/scss/shared_placeholders/_visuallyhidden.scss","position":3,"original_position":3,"commit_id":"fcd9a07a47a94dec1175fe62d8f3b86a8fc51974","original_commit_id":"fcd9a07a47a94dec1175fe62d8f3b86a8fc51974","user":{"login":"tombye","id":87140,"avatar_url":"https://avatars.githubusercontent.com/u/87140?v=3","gravatar_id":"","url":"https://api.github.com/users/tombye","html_url":"https://github.com/tombye","followers_url":"https://api.github.com/users/tombye/followers","following_url":"https://api.github.com/users/tombye/following{/other_user}","gists_url":"https://api.github.com/users/tombye/gists{/gist_id}","starred_url":"https://api.github.com/users/tombye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombye/subscriptions","organizations_url":"https://api.github.com/users/tombye/orgs","repos_url":"https://api.github.com/users/tombye/repos","events_url":"https://api.github.com/users/tombye/events{/privacy}","received_events_url":"https://api.github.com/users/tombye/received_events","type":"User","site_admin":false},"body":"The reason is to hide the content visually while keeping it available to users who don't use visuals to navigate the page. Here's an article explaining the technique: http://webaim.org/techniques/css/invisiblecontent/\r\n\r\nwww.gov.uk have styles for all the different use-cases around how to control the display of elements with CSS:\r\n\r\nhttps://github.com/alphagov/govuk_template/blob/86106bfb332ff5c0346b92310a4117daeb2d8c8d/source/assets/stylesheets/_accessibility.scss\r\n\r\nFrom memory, the only reason we position from the left is because standard page-flow is left-to-right but it's not a big problem if we decided to choose a different one instead.\r\n\r\nFinally (!) the reason `em`s are used for the unit are because they scale with the text and 9999 `em`s are going to be a lot of pixels (at least 16 x 9999).","created_at":"2016-05-11T14:14:55Z","updated_at":"2016-05-11T14:14:55Z","html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/259#discussion_r62855482","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments/62855482"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/259#discussion_r62855482"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259","id":69547410,"html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/259","diff_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/259.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/259.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/259","number":259,"state":"open","locked":false,"title":"[#118094925] Remove duplicated question titles on one-page-per-question pages","user":{"login":"pcraig3","id":2454380,"avatar_url":"https://avatars.githubusercontent.com/u/2454380?v=3","gravatar_id":"","url":"https://api.github.com/users/pcraig3","html_url":"https://github.com/pcraig3","followers_url":"https://api.github.com/users/pcraig3/followers","following_url":"https://api.github.com/users/pcraig3/following{/other_user}","gists_url":"https://api.github.com/users/pcraig3/gists{/gist_id}","starred_url":"https://api.github.com/users/pcraig3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcraig3/subscriptions","organizations_url":"https://api.github.com/users/pcraig3/orgs","repos_url":"https://api.github.com/users/pcraig3/repos","events_url":"https://api.github.com/users/pcraig3/events{/privacy}","received_events_url":"https://api.github.com/users/pcraig3/received_events","type":"User","site_admin":false},"body":"Doesn't look like much, but this brings in the important stuff from the [_single-question-page.scss](https://github.com/alphagov/digitalmarketplace-supplier-frontend/blob/master/app/assets/scss/_single-question-page.scss) rules that were before now stored exclusively in the supplier app.\r\n\r\nAdds some more spacing between `.question-advice` and `.hint` text because the hint is more closely bound to the input field or some nonsense that ralph talks about sometimes. \r\n\r\nLook at the [side-by-side](http://stackoverflow.com/questions/24319505/how-can-one-display-images-side-by-side-in-a-github-readme-md) images down below and be amazed.\r\n\r\n[>> Story on Pivotal](https://www.pivotaltracker.com/story/show/118094925)\r\n\r\n***\r\n\r\n### Screenshots\r\n\r\nBefore before            |  Now\r\n:-------------------------:|:-------------------------:\r\n![screen shot 2016-05-10 at 18 06 45](https://cloud.githubusercontent.com/assets/2454380/15155833/2293cf86-16dc-11e6-8c22-d39c56cf8389.png)  |  ![screen shot 2016-05-10 at 18 07 01](https://cloud.githubusercontent.com/assets/2454380/15155836/24feb7cc-16dc-11e6-8d9e-79aeee8572a8.png)\r\n\r\nBefore (multiquestion)            |  Now (multiquestion: note the hint text is a bit lower)\r\n:-------------------------:|:-------------------------:\r\n![screen shot 2016-05-10 at 18 17 17](https://cloud.githubusercontent.com/assets/2454380/15155880/5e75fcd6-16dc-11e6-8f8d-018cb70bb8c4.png) | ![screen shot 2016-05-10 at 18 17 43](https://cloud.githubusercontent.com/assets/2454380/15155887/66583874-16dc-11e6-8302-7294e810f44d.png)","created_at":"2016-05-10T17:40:28Z","updated_at":"2016-05-11T14:14:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f649ad1da19cbc0350c436b88b398cee7a6790fc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/259/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/fcd9a07a47a94dec1175fe62d8f3b86a8fc51974","head":{"label":"alphagov:pc_take_out_twin_titles","ref":"pc_take_out_twin_titles","sha":"fcd9a07a47a94dec1175fe62d8f3b86a8fc51974","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":28664922,"name":"digitalmarketplace-frontend-toolkit","full_name":"alphagov/digitalmarketplace-frontend-toolkit","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","description":"Front end toolkit for the Digital Marketplace","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/deployments","created_at":"2014-12-31T11:56:55Z","updated_at":"2016-01-30T02:08:43Z","pushed_at":"2016-05-11T09:23:05Z","git_url":"git://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-frontend-toolkit.git","clone_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","svn_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","homepage":"http://alphagov.github.io/digitalmarketplace-frontend-toolkit/","size":2347,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"d7f2fb5254e869929a3fff3892903211aa5bf9b3","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":28664922,"name":"digitalmarketplace-frontend-toolkit","full_name":"alphagov/digitalmarketplace-frontend-toolkit","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","description":"Front end toolkit for the Digital Marketplace","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/deployments","created_at":"2014-12-31T11:56:55Z","updated_at":"2016-01-30T02:08:43Z","pushed_at":"2016-05-11T09:23:05Z","git_url":"git://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-frontend-toolkit.git","clone_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit.git","svn_url":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit","homepage":"http://alphagov.github.io/digitalmarketplace-frontend-toolkit/","size":2347,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-frontend-toolkit/pull/259"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/259"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-frontend-toolkit/statuses/fcd9a07a47a94dec1175fe62d8f3b86a8fc51974"}}}}