{"action":"closed","number":135,"pull_request":{"url":"https://api.github.com/repos/taskrabbit/makara/pulls/135","id":87016071,"html_url":"https://github.com/taskrabbit/makara/pull/135","diff_url":"https://github.com/taskrabbit/makara/pull/135.diff","patch_url":"https://github.com/taskrabbit/makara/pull/135.patch","issue_url":"https://api.github.com/repos/taskrabbit/makara/issues/135","number":135,"state":"closed","locked":false,"title":"Make makara error base class that inherits active record error class","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"We noticed that Makara was raising exceptions that inherit from StandardError.  We thought it might be a better pattern for Makara to have its own error class that each error inherits from, and then for Makara's base error to inherit from an ActiveRecord error.  I chose the lowest level one assuming it is minimally acceptable.\r\n\r\nNow code that was\r\n\r\n```ruby\r\nrescue StandardError => e\r\n  if e.class.name =~ /^Makara::/\r\n```\r\n\r\ncan be\r\n\r\n```ruby\r\nrescue Makara::Errors::MakaraError\r\n```","created_at":"2016-09-27T21:30:57Z","updated_at":"2016-10-15T23:26:58Z","closed_at":"2016-10-15T23:26:58Z","merged_at":"2016-10-15T23:26:58Z","merge_commit_sha":"b3e7b7ca350d98b7ce199facf15c38a75445057f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskrabbit/makara/pulls/135/commits","review_comments_url":"https://api.github.com/repos/taskrabbit/makara/pulls/135/comments","review_comment_url":"https://api.github.com/repos/taskrabbit/makara/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskrabbit/makara/issues/135/comments","statuses_url":"https://api.github.com/repos/taskrabbit/makara/statuses/a08a38b9b45e9b54a2f087cfcf3f891d0b3b9c02","head":{"label":"bf4:active_record_friendly_exceptions","ref":"active_record_friendly_exceptions","sha":"a08a38b9b45e9b54a2f087cfcf3f891d0b3b9c02","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"repo":{"id":43378121,"name":"makara","full_name":"bf4/makara","owner":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bf4/makara","description":"A Read-Write Proxy for Connections; Also provides an ActiveRecord adapter.","fork":true,"url":"https://api.github.com/repos/bf4/makara","forks_url":"https://api.github.com/repos/bf4/makara/forks","keys_url":"https://api.github.com/repos/bf4/makara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bf4/makara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bf4/makara/teams","hooks_url":"https://api.github.com/repos/bf4/makara/hooks","issue_events_url":"https://api.github.com/repos/bf4/makara/issues/events{/number}","events_url":"https://api.github.com/repos/bf4/makara/events","assignees_url":"https://api.github.com/repos/bf4/makara/assignees{/user}","branches_url":"https://api.github.com/repos/bf4/makara/branches{/branch}","tags_url":"https://api.github.com/repos/bf4/makara/tags","blobs_url":"https://api.github.com/repos/bf4/makara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bf4/makara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bf4/makara/git/refs{/sha}","trees_url":"https://api.github.com/repos/bf4/makara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bf4/makara/statuses/{sha}","languages_url":"https://api.github.com/repos/bf4/makara/languages","stargazers_url":"https://api.github.com/repos/bf4/makara/stargazers","contributors_url":"https://api.github.com/repos/bf4/makara/contributors","subscribers_url":"https://api.github.com/repos/bf4/makara/subscribers","subscription_url":"https://api.github.com/repos/bf4/makara/subscription","commits_url":"https://api.github.com/repos/bf4/makara/commits{/sha}","git_commits_url":"https://api.github.com/repos/bf4/makara/git/commits{/sha}","comments_url":"https://api.github.com/repos/bf4/makara/comments{/number}","issue_comment_url":"https://api.github.com/repos/bf4/makara/issues/comments{/number}","contents_url":"https://api.github.com/repos/bf4/makara/contents/{+path}","compare_url":"https://api.github.com/repos/bf4/makara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bf4/makara/merges","archive_url":"https://api.github.com/repos/bf4/makara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bf4/makara/downloads","issues_url":"https://api.github.com/repos/bf4/makara/issues{/number}","pulls_url":"https://api.github.com/repos/bf4/makara/pulls{/number}","milestones_url":"https://api.github.com/repos/bf4/makara/milestones{/number}","notifications_url":"https://api.github.com/repos/bf4/makara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bf4/makara/labels{/name}","releases_url":"https://api.github.com/repos/bf4/makara/releases{/id}","deployments_url":"https://api.github.com/repos/bf4/makara/deployments","created_at":"2015-09-29T15:59:44Z","updated_at":"2015-09-29T15:59:45Z","pushed_at":"2016-09-27T21:40:17Z","git_url":"git://github.com/bf4/makara.git","ssh_url":"git@github.com:bf4/makara.git","clone_url":"https://github.com/bf4/makara.git","svn_url":"https://github.com/bf4/makara","homepage":"http://tech.taskrabbit.com/","size":443,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"taskrabbit:master","ref":"master","sha":"0127ff478843e18da98f66e258d9fd0dd40a8aa6","user":{"login":"taskrabbit","id":666590,"avatar_url":"https://avatars.githubusercontent.com/u/666590?v=3","gravatar_id":"","url":"https://api.github.com/users/taskrabbit","html_url":"https://github.com/taskrabbit","followers_url":"https://api.github.com/users/taskrabbit/followers","following_url":"https://api.github.com/users/taskrabbit/following{/other_user}","gists_url":"https://api.github.com/users/taskrabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/taskrabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskrabbit/subscriptions","organizations_url":"https://api.github.com/users/taskrabbit/orgs","repos_url":"https://api.github.com/users/taskrabbit/repos","events_url":"https://api.github.com/users/taskrabbit/events{/privacy}","received_events_url":"https://api.github.com/users/taskrabbit/received_events","type":"Organization","site_admin":false},"repo":{"id":5708822,"name":"makara","full_name":"taskrabbit/makara","owner":{"login":"taskrabbit","id":666590,"avatar_url":"https://avatars.githubusercontent.com/u/666590?v=3","gravatar_id":"","url":"https://api.github.com/users/taskrabbit","html_url":"https://github.com/taskrabbit","followers_url":"https://api.github.com/users/taskrabbit/followers","following_url":"https://api.github.com/users/taskrabbit/following{/other_user}","gists_url":"https://api.github.com/users/taskrabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/taskrabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskrabbit/subscriptions","organizations_url":"https://api.github.com/users/taskrabbit/orgs","repos_url":"https://api.github.com/users/taskrabbit/repos","events_url":"https://api.github.com/users/taskrabbit/events{/privacy}","received_events_url":"https://api.github.com/users/taskrabbit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskrabbit/makara","description":"A Read-Write Proxy for Connections; Also provides an ActiveRecord adapter.","fork":false,"url":"https://api.github.com/repos/taskrabbit/makara","forks_url":"https://api.github.com/repos/taskrabbit/makara/forks","keys_url":"https://api.github.com/repos/taskrabbit/makara/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskrabbit/makara/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskrabbit/makara/teams","hooks_url":"https://api.github.com/repos/taskrabbit/makara/hooks","issue_events_url":"https://api.github.com/repos/taskrabbit/makara/issues/events{/number}","events_url":"https://api.github.com/repos/taskrabbit/makara/events","assignees_url":"https://api.github.com/repos/taskrabbit/makara/assignees{/user}","branches_url":"https://api.github.com/repos/taskrabbit/makara/branches{/branch}","tags_url":"https://api.github.com/repos/taskrabbit/makara/tags","blobs_url":"https://api.github.com/repos/taskrabbit/makara/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskrabbit/makara/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskrabbit/makara/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskrabbit/makara/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskrabbit/makara/statuses/{sha}","languages_url":"https://api.github.com/repos/taskrabbit/makara/languages","stargazers_url":"https://api.github.com/repos/taskrabbit/makara/stargazers","contributors_url":"https://api.github.com/repos/taskrabbit/makara/contributors","subscribers_url":"https://api.github.com/repos/taskrabbit/makara/subscribers","subscription_url":"https://api.github.com/repos/taskrabbit/makara/subscription","commits_url":"https://api.github.com/repos/taskrabbit/makara/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskrabbit/makara/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskrabbit/makara/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskrabbit/makara/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskrabbit/makara/contents/{+path}","compare_url":"https://api.github.com/repos/taskrabbit/makara/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskrabbit/makara/merges","archive_url":"https://api.github.com/repos/taskrabbit/makara/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskrabbit/makara/downloads","issues_url":"https://api.github.com/repos/taskrabbit/makara/issues{/number}","pulls_url":"https://api.github.com/repos/taskrabbit/makara/pulls{/number}","milestones_url":"https://api.github.com/repos/taskrabbit/makara/milestones{/number}","notifications_url":"https://api.github.com/repos/taskrabbit/makara/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskrabbit/makara/labels{/name}","releases_url":"https://api.github.com/repos/taskrabbit/makara/releases{/id}","deployments_url":"https://api.github.com/repos/taskrabbit/makara/deployments","created_at":"2012-09-06T21:33:08Z","updated_at":"2016-10-13T12:23:08Z","pushed_at":"2016-10-15T23:26:58Z","git_url":"git://github.com/taskrabbit/makara.git","ssh_url":"git@github.com:taskrabbit/makara.git","clone_url":"https://github.com/taskrabbit/makara.git","svn_url":"https://github.com/taskrabbit/makara","homepage":"http://tech.taskrabbit.com/","size":706,"stargazers_count":361,"watchers_count":361,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":14,"forks":76,"open_issues":14,"watchers":361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskrabbit/makara/pulls/135"},"html":{"href":"https://github.com/taskrabbit/makara/pull/135"},"issue":{"href":"https://api.github.com/repos/taskrabbit/makara/issues/135"},"comments":{"href":"https://api.github.com/repos/taskrabbit/makara/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/taskrabbit/makara/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/taskrabbit/makara/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskrabbit/makara/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/taskrabbit/makara/statuses/a08a38b9b45e9b54a2f087cfcf3f891d0b3b9c02"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bleonard","id":36106,"avatar_url":"https://avatars.githubusercontent.com/u/36106?v=3","gravatar_id":"","url":"https://api.github.com/users/bleonard","html_url":"https://github.com/bleonard","followers_url":"https://api.github.com/users/bleonard/followers","following_url":"https://api.github.com/users/bleonard/following{/other_user}","gists_url":"https://api.github.com/users/bleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/bleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleonard/subscriptions","organizations_url":"https://api.github.com/users/bleonard/orgs","repos_url":"https://api.github.com/users/bleonard/repos","events_url":"https://api.github.com/users/bleonard/events{/privacy}","received_events_url":"https://api.github.com/users/bleonard/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":12,"deletions":4,"changed_files":6}}
{"actor":{"display_login":"bleonard"}}