{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/68857241","id":68857241,"diff_hunk":"@@ -16,6 +16,8 @@ OPTIONS:\n                    The default is \"Core\".\n   -y <yumconf>     The path to the yum config to install packages from. The\n                    default is /etc/yum.conf for Centos/RHEL and /etc/dnf/dnf.conf for Fedora\n+  -f <filename>    The filename of the output tarfile\n+  -c               If specified, the tarfile will be bzip2 compressed","path":"contrib/mkimage-yum.sh","position":5,"original_position":5,"commit_id":"fa303c4d0b3012599f2a1ba7b30b516cfbdce073","original_commit_id":"fa303c4d0b3012599f2a1ba7b30b516cfbdce073","user":{"login":"tianon","id":161631,"avatar_url":"https://avatars.githubusercontent.com/u/161631?v=3","gravatar_id":"","url":"https://api.github.com/users/tianon","html_url":"https://github.com/tianon","followers_url":"https://api.github.com/users/tianon/followers","following_url":"https://api.github.com/users/tianon/following{/other_user}","gists_url":"https://api.github.com/users/tianon/gists{/gist_id}","starred_url":"https://api.github.com/users/tianon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianon/subscriptions","organizations_url":"https://api.github.com/users/tianon/orgs","repos_url":"https://api.github.com/users/tianon/repos","events_url":"https://api.github.com/users/tianon/events{/privacy}","received_events_url":"https://api.github.com/users/tianon/received_events","type":"User","site_admin":false},"body":"Why hard-coded for `bzip2`?\r\n\r\n(see the approach in `mkimage.sh` for an alternate implementation https://github.com/docker/docker/blob/57977fb1273337db0e5da46faf4068c4073aa0bb/contrib/mkimage.sh#L25-L46)","created_at":"2016-06-28T22:40:18Z","updated_at":"2016-06-28T22:40:18Z","html_url":"https://github.com/docker/docker/pull/23815#discussion_r68857241","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/23815","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/68857241"},"html":{"href":"https://github.com/docker/docker/pull/23815#discussion_r68857241"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/23815"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/23815","id":74606322,"html_url":"https://github.com/docker/docker/pull/23815","diff_url":"https://github.com/docker/docker/pull/23815.diff","patch_url":"https://github.com/docker/docker/pull/23815.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/23815","number":23815,"state":"open","locked":false,"title":"Added the functionality to create an image for Docker, without having…","user":{"login":"Cybertinus","id":479328,"avatar_url":"https://avatars.githubusercontent.com/u/479328?v=3","gravatar_id":"","url":"https://api.github.com/users/Cybertinus","html_url":"https://github.com/Cybertinus","followers_url":"https://api.github.com/users/Cybertinus/followers","following_url":"https://api.github.com/users/Cybertinus/following{/other_user}","gists_url":"https://api.github.com/users/Cybertinus/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybertinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybertinus/subscriptions","organizations_url":"https://api.github.com/users/Cybertinus/orgs","repos_url":"https://api.github.com/users/Cybertinus/repos","events_url":"https://api.github.com/users/Cybertinus/events{/privacy}","received_events_url":"https://api.github.com/users/Cybertinus/received_events","type":"User","site_admin":false},"body":"**- What I did**\r\nAdded the functionality to the mkimage-yum.sh script to create an image of an CentOS or other RHEL based system without having docker installed on that system. You can then simply copy the resulting .tar or .tar.bz2 file to a machine that has docker on it and just run an docker import directly on the .tar file.\r\n\r\n**- How I did it**\r\nAdded 2 options to the shell script and processed the options in the script later on. I added the options in such a way that if you don't specify them, the original behavior is kept. Thus having Docker installed is a must then.\r\n\r\n**- How to verify it**\r\nCreate an .tar of .tar.bz2 file on a RHEL-based machine, without having Docker installed on it, copy the resulting .tar or .tar.bz2 to a machine with docker on it and run an docker import on the .tar file.\r\n\r\n**- Description for the changelog**\r\nMade it possible to create an RHEL-based image on a RHEL-based system without having Docker installed.\r\n\r\nv1.11.2 Docker installed","created_at":"2016-06-21T12:55:44Z","updated_at":"2016-06-28T22:40:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d44490d13a437283a4d39735ab3d9747cc1ec3d1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/23815/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/23815/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/23815/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/fa303c4d0b3012599f2a1ba7b30b516cfbdce073","head":{"label":"Cybertinus:master","ref":"master","sha":"fa303c4d0b3012599f2a1ba7b30b516cfbdce073","user":{"login":"Cybertinus","id":479328,"avatar_url":"https://avatars.githubusercontent.com/u/479328?v=3","gravatar_id":"","url":"https://api.github.com/users/Cybertinus","html_url":"https://github.com/Cybertinus","followers_url":"https://api.github.com/users/Cybertinus/followers","following_url":"https://api.github.com/users/Cybertinus/following{/other_user}","gists_url":"https://api.github.com/users/Cybertinus/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybertinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybertinus/subscriptions","organizations_url":"https://api.github.com/users/Cybertinus/orgs","repos_url":"https://api.github.com/users/Cybertinus/repos","events_url":"https://api.github.com/users/Cybertinus/events{/privacy}","received_events_url":"https://api.github.com/users/Cybertinus/received_events","type":"User","site_admin":false},"repo":{"id":61632647,"name":"docker","full_name":"Cybertinus/docker","owner":{"login":"Cybertinus","id":479328,"avatar_url":"https://avatars.githubusercontent.com/u/479328?v=3","gravatar_id":"","url":"https://api.github.com/users/Cybertinus","html_url":"https://github.com/Cybertinus","followers_url":"https://api.github.com/users/Cybertinus/followers","following_url":"https://api.github.com/users/Cybertinus/following{/other_user}","gists_url":"https://api.github.com/users/Cybertinus/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybertinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybertinus/subscriptions","organizations_url":"https://api.github.com/users/Cybertinus/orgs","repos_url":"https://api.github.com/users/Cybertinus/repos","events_url":"https://api.github.com/users/Cybertinus/events{/privacy}","received_events_url":"https://api.github.com/users/Cybertinus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Cybertinus/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/Cybertinus/docker","forks_url":"https://api.github.com/repos/Cybertinus/docker/forks","keys_url":"https://api.github.com/repos/Cybertinus/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cybertinus/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cybertinus/docker/teams","hooks_url":"https://api.github.com/repos/Cybertinus/docker/hooks","issue_events_url":"https://api.github.com/repos/Cybertinus/docker/issues/events{/number}","events_url":"https://api.github.com/repos/Cybertinus/docker/events","assignees_url":"https://api.github.com/repos/Cybertinus/docker/assignees{/user}","branches_url":"https://api.github.com/repos/Cybertinus/docker/branches{/branch}","tags_url":"https://api.github.com/repos/Cybertinus/docker/tags","blobs_url":"https://api.github.com/repos/Cybertinus/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cybertinus/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cybertinus/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cybertinus/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cybertinus/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/Cybertinus/docker/languages","stargazers_url":"https://api.github.com/repos/Cybertinus/docker/stargazers","contributors_url":"https://api.github.com/repos/Cybertinus/docker/contributors","subscribers_url":"https://api.github.com/repos/Cybertinus/docker/subscribers","subscription_url":"https://api.github.com/repos/Cybertinus/docker/subscription","commits_url":"https://api.github.com/repos/Cybertinus/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cybertinus/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cybertinus/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cybertinus/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cybertinus/docker/contents/{+path}","compare_url":"https://api.github.com/repos/Cybertinus/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cybertinus/docker/merges","archive_url":"https://api.github.com/repos/Cybertinus/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cybertinus/docker/downloads","issues_url":"https://api.github.com/repos/Cybertinus/docker/issues{/number}","pulls_url":"https://api.github.com/repos/Cybertinus/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/Cybertinus/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/Cybertinus/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cybertinus/docker/labels{/name}","releases_url":"https://api.github.com/repos/Cybertinus/docker/releases{/id}","deployments_url":"https://api.github.com/repos/Cybertinus/docker/deployments","created_at":"2016-06-21T12:36:07Z","updated_at":"2016-06-21T12:36:21Z","pushed_at":"2016-06-21T13:01:16Z","git_url":"git://github.com/Cybertinus/docker.git","ssh_url":"git@github.com:Cybertinus/docker.git","clone_url":"https://github.com/Cybertinus/docker.git","svn_url":"https://github.com/Cybertinus/docker","homepage":"http://www.docker.com","size":97330,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"96e3f3e2d040c0b5120efd5bee994b13d44f8087","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-06-28T22:00:50Z","pushed_at":"2016-06-28T22:39:48Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":203181,"stargazers_count":32493,"watchers_count":32493,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9363,"mirror_url":null,"open_issues_count":1827,"forks":9363,"open_issues":1827,"watchers":32493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/23815"},"html":{"href":"https://github.com/docker/docker/pull/23815"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/23815"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/23815/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/23815/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/23815/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/fa303c4d0b3012599f2a1ba7b30b516cfbdce073"}}}}
{"actor":{"display_login":"tianon"}}