{"action":"closed","number":16667,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/16667","id":59347594,"html_url":"https://github.com/elastic/elasticsearch/pull/16667","diff_url":"https://github.com/elastic/elasticsearch/pull/16667.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/16667.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/16667","number":16667,"state":"closed","locked":false,"title":"Fix elasticsearch-plugin script on cygwin environment","user":{"login":"jorgediaz-lr","id":6472845,"avatar_url":"https://avatars.githubusercontent.com/u/6472845?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgediaz-lr","html_url":"https://github.com/jorgediaz-lr","followers_url":"https://api.github.com/users/jorgediaz-lr/followers","following_url":"https://api.github.com/users/jorgediaz-lr/following{/other_user}","gists_url":"https://api.github.com/users/jorgediaz-lr/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgediaz-lr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgediaz-lr/subscriptions","organizations_url":"https://api.github.com/users/jorgediaz-lr/orgs","repos_url":"https://api.github.com/users/jorgediaz-lr/repos","events_url":"https://api.github.com/users/jorgediaz-lr/events{/privacy}","received_events_url":"https://api.github.com/users/jorgediaz-lr/received_events","type":"User","site_admin":false},"body":"More information, see: https://github.com/elastic/elasticsearch/issues/16666\r\n\r\nI have applied same solution than *elasticsearch* script, see: https://github.com/elastic/elasticsearch/blob/master/distribution/src/main/resources/bin/elasticsearch#L121-L127 but it is neccesary to apply to ES_HOME and CONF_DIR variables.\r\n\r\nIt is also necessary to escape JAVA variable as we can use spaces at Java path:\r\nhttps://github.com/jorgediaz-lr/elasticsearch/blob/16666_fix_plugin_script_on_cygwin/distribution/src/main/resources/bin/elasticsearch-plugin#L122\r\n\r\nCloses #16666","created_at":"2016-02-15T10:52:01Z","updated_at":"2016-02-29T19:59:06Z","closed_at":"2016-02-29T19:59:06Z","merged_at":null,"merge_commit_sha":"cf19de74526ec4c56f3cc1254cb3393f0a9ff1db","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/16667/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/16667/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/16667/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/6d381c51644cc12f52fe73bca57c3b3a06aaa39c","head":{"label":"jorgediaz-lr:16666_fix_plugin_script_on_cygwin","ref":"16666_fix_plugin_script_on_cygwin","sha":"6d381c51644cc12f52fe73bca57c3b3a06aaa39c","user":{"login":"jorgediaz-lr","id":6472845,"avatar_url":"https://avatars.githubusercontent.com/u/6472845?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgediaz-lr","html_url":"https://github.com/jorgediaz-lr","followers_url":"https://api.github.com/users/jorgediaz-lr/followers","following_url":"https://api.github.com/users/jorgediaz-lr/following{/other_user}","gists_url":"https://api.github.com/users/jorgediaz-lr/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgediaz-lr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgediaz-lr/subscriptions","organizations_url":"https://api.github.com/users/jorgediaz-lr/orgs","repos_url":"https://api.github.com/users/jorgediaz-lr/repos","events_url":"https://api.github.com/users/jorgediaz-lr/events{/privacy}","received_events_url":"https://api.github.com/users/jorgediaz-lr/received_events","type":"User","site_admin":false},"repo":{"id":50504121,"name":"elasticsearch","full_name":"jorgediaz-lr/elasticsearch","owner":{"login":"jorgediaz-lr","id":6472845,"avatar_url":"https://avatars.githubusercontent.com/u/6472845?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgediaz-lr","html_url":"https://github.com/jorgediaz-lr","followers_url":"https://api.github.com/users/jorgediaz-lr/followers","following_url":"https://api.github.com/users/jorgediaz-lr/following{/other_user}","gists_url":"https://api.github.com/users/jorgediaz-lr/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgediaz-lr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgediaz-lr/subscriptions","organizations_url":"https://api.github.com/users/jorgediaz-lr/orgs","repos_url":"https://api.github.com/users/jorgediaz-lr/repos","events_url":"https://api.github.com/users/jorgediaz-lr/events{/privacy}","received_events_url":"https://api.github.com/users/jorgediaz-lr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jorgediaz-lr/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch","forks_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/forks","keys_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/teams","hooks_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/events","assignees_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/tags","blobs_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/subscription","commits_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/merges","archive_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/downloads","issues_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/jorgediaz-lr/elasticsearch/deployments","created_at":"2016-01-27T11:53:32Z","updated_at":"2016-01-27T11:53:54Z","pushed_at":"2016-02-15T10:50:00Z","git_url":"git://github.com/jorgediaz-lr/elasticsearch.git","ssh_url":"git@github.com:jorgediaz-lr/elasticsearch.git","clone_url":"https://github.com/jorgediaz-lr/elasticsearch.git","svn_url":"https://github.com/jorgediaz-lr/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":198448,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"11ce624343f994efc22da7599a36131f4b0bbf08","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2016-02-29T19:13:28Z","pushed_at":"2016-02-29T19:58:08Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":294612,"stargazers_count":15843,"watchers_count":15843,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5077,"mirror_url":null,"open_issues_count":1139,"forks":5077,"open_issues":1139,"watchers":15843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/16667"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/16667"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/16667"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/16667/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/16667/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/16667/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/6d381c51644cc12f52fe73bca57c3b3a06aaa39c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":10,"review_comments":0,"commits":1,"additions":10,"deletions":1,"changed_files":1}}