{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1148","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1148/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1148/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1148/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1148","id":195913204,"number":1148,"title":"Logger object understands all attributes supported by the stdlib Logger","user":{"login":"dazuma","id":8911,"avatar_url":"https://avatars.githubusercontent.com/u/8911?v=3","gravatar_id":"","url":"https://api.github.com/users/dazuma","html_url":"https://github.com/dazuma","followers_url":"https://api.github.com/users/dazuma/followers","following_url":"https://api.github.com/users/dazuma/following{/other_user}","gists_url":"https://api.github.com/users/dazuma/gists{/gist_id}","starred_url":"https://api.github.com/users/dazuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dazuma/subscriptions","organizations_url":"https://api.github.com/users/dazuma/orgs","repos_url":"https://api.github.com/users/dazuma/repos","events_url":"https://api.github.com/users/dazuma/events{/privacy}","received_events_url":"https://api.github.com/users/dazuma/received_events","type":"User","site_admin":false},"labels":[{"id":166382179,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-15T20:53:25Z","updated_at":"2016-12-15T21:26:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/pulls/1148","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1148","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1148.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1148.patch"},"body":"Currently, methods that are defined by `attr_reader` and `attr_accessor` in the standard Ruby `Logger` class, are missing from `Google::Cloud::Logging::Logger`. In some cases, these attributes are meaningless (e.g. the `formatter` attribute) while in other cases they represent missing functionality (e.g. currently there is a setter for `sev_threshold` but the getter is missing.)\r\n\r\nThe missing methods caused a few use cases to break when external code assumed that the logger conforms fully to the standard API. For example, if this logger is used as the Rails logger, `rails server` would crash in development mode because the Rails server script assumes the Rails logger has a formatter.\r\n\r\nThis PR restores all missing attribute-driven methods in the logger class. It also provides tests for attributes, and fixes some minitest warnings."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/comments/267448897","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-ruby/pull/1148#issuecomment-267448897","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-ruby/issues/1148","id":267448897,"user":{"login":"quartzmo","id":205445,"avatar_url":"https://avatars.githubusercontent.com/u/205445?v=3","gravatar_id":"","url":"https://api.github.com/users/quartzmo","html_url":"https://github.com/quartzmo","followers_url":"https://api.github.com/users/quartzmo/followers","following_url":"https://api.github.com/users/quartzmo/following{/other_user}","gists_url":"https://api.github.com/users/quartzmo/gists{/gist_id}","starred_url":"https://api.github.com/users/quartzmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quartzmo/subscriptions","organizations_url":"https://api.github.com/users/quartzmo/orgs","repos_url":"https://api.github.com/users/quartzmo/repos","events_url":"https://api.github.com/users/quartzmo/events{/privacy}","received_events_url":"https://api.github.com/users/quartzmo/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T21:26:56Z","updated_at":"2016-12-15T21:26:56Z","body":"It looks like this PR has the std lib [`Logger`](http://ruby-doc.org/stdlib-2.3.0/libdoc/logger/rdoc/Logger.html) attributes covered, but what about adding missing instance methods such as [`<<`](http://ruby-doc.org/stdlib-2.3.0/libdoc/logger/rdoc/Logger.html#method-i-3C-3C) and [`close`](http://ruby-doc.org/stdlib-2.3.0/libdoc/logger/rdoc/Logger.html#method-i-close)?"}}
{"actor":{"display_login":"quartzmo"}}