{"action":"created","issue":{"url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter/issues/7","repository_url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter","labels_url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter/issues/7/comments","events_url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter/issues/7/events","html_url":"https://github.com/CM3Duser/Blender-CM3D2-Converter/pull/7","id":130722480,"number":7,"title":"collection 内の key 存在チェック時に _.keys() を使用しない。","user":{"login":"Milly","id":22977,"avatar_url":"https://avatars.githubusercontent.com/u/22977?v=3","gravatar_id":"","url":"https://api.github.com/users/Milly","html_url":"https://github.com/Milly","followers_url":"https://api.github.com/users/Milly/followers","following_url":"https://api.github.com/users/Milly/following{/other_user}","gists_url":"https://api.github.com/users/Milly/gists{/gist_id}","starred_url":"https://api.github.com/users/Milly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Milly/subscriptions","organizations_url":"https://api.github.com/users/Milly/orgs","repos_url":"https://api.github.com/users/Milly/repos","events_url":"https://api.github.com/users/Milly/events{/privacy}","received_events_url":"https://api.github.com/users/Milly/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-02T15:46:41Z","updated_at":"2016-02-02T16:04:55Z","closed_at":"2016-02-02T16:04:48Z","pull_request":{"url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter/pulls/7","html_url":"https://github.com/CM3Duser/Blender-CM3D2-Converter/pull/7","diff_url":"https://github.com/CM3Duser/Blender-CM3D2-Converter/pull/7.diff","patch_url":"https://github.com/CM3Duser/Blender-CM3D2-Converter/pull/7.patch"},"body":"`dict` 内の key チェックや、Blender の `bpy_prop_collection` type 内の要素名チェック時に `_.keys()` を利用しない。\r\n上記は `key in dict` や `name in collection` で存在確認が可能です。\r\n`_.keys()` を経由すると一度 `list` を生成するため遅くなります。"},"comment":{"url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter/issues/comments/178655359","html_url":"https://github.com/CM3Duser/Blender-CM3D2-Converter/pull/7#issuecomment-178655359","issue_url":"https://api.github.com/repos/CM3Duser/Blender-CM3D2-Converter/issues/7","id":178655359,"user":{"login":"CM3Duser","id":13675957,"avatar_url":"https://avatars.githubusercontent.com/u/13675957?v=3","gravatar_id":"","url":"https://api.github.com/users/CM3Duser","html_url":"https://github.com/CM3Duser","followers_url":"https://api.github.com/users/CM3Duser/followers","following_url":"https://api.github.com/users/CM3Duser/following{/other_user}","gists_url":"https://api.github.com/users/CM3Duser/gists{/gist_id}","starred_url":"https://api.github.com/users/CM3Duser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CM3Duser/subscriptions","organizations_url":"https://api.github.com/users/CM3Duser/orgs","repos_url":"https://api.github.com/users/CM3Duser/repos","events_url":"https://api.github.com/users/CM3Duser/events{/privacy}","received_events_url":"https://api.github.com/users/CM3Duser/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T16:04:55Z","updated_at":"2016-02-02T16:04:55Z","body":"大規模な修正ありがとうございます、Mergeさせて頂きます。\r\nListと同じように確認すれば良かったのですね。"}}