{"action":"created","issue":{"url":"https://api.github.com/repos/ClusterLabs/libqb/issues/156","labels_url":"https://api.github.com/repos/ClusterLabs/libqb/issues/156/labels{/name}","comments_url":"https://api.github.com/repos/ClusterLabs/libqb/issues/156/comments","events_url":"https://api.github.com/repos/ClusterLabs/libqb/issues/156/events","html_url":"https://github.com/ClusterLabs/libqb/issues/156","id":76637532,"number":156,"title":"Typo in ipc_setup.c.","user":{"login":"fskale","id":12457151,"avatar_url":"https://avatars.githubusercontent.com/u/12457151?v=3","gravatar_id":"","url":"https://api.github.com/users/fskale","html_url":"https://github.com/fskale","followers_url":"https://api.github.com/users/fskale/followers","following_url":"https://api.github.com/users/fskale/following{/other_user}","gists_url":"https://api.github.com/users/fskale/gists{/gist_id}","starred_url":"https://api.github.com/users/fskale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fskale/subscriptions","organizations_url":"https://api.github.com/users/fskale/orgs","repos_url":"https://api.github.com/users/fskale/repos","events_url":"https://api.github.com/users/fskale/events{/privacy}","received_events_url":"https://api.github.com/users/fskale/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-15T07:49:28Z","updated_at":"2016-01-07T15:47:23Z","closed_at":"2016-01-07T15:47:23Z","body":"Hi,\r\nonly wanted to inform you, that there's a typo in function ipc_setup.c.\r\nupg was no defined, but data ;-)\r\nSo, since i'm on solaris it will hit the bug.\r\nHere's the patch:\r\n```\r\n--- lib/ipc_setup.c\tFri May 15 07:38:56 2015\r\n+++ lib/ipc_setup.c\tFri May 15 07:39:59 2015\r\n@@ -628,9 +628,9 @@\r\n\r\n \t\tif (getpeerucred(data->sock, &uc) == 0) {\r\n \t\t\tres = 0;\r\n-\t\t\tugp.uid = ucred_geteuid(uc);\r\n-\t\t\tugp.gid = ucred_getegid(uc);\r\n-\t\t\tugp.pid = ucred_getpid(uc);\r\n+\t\t\tdata->ugp.uid = ucred_geteuid(uc);\r\n+\t\t\tdata->ugp.gid = ucred_getegid(uc);\r\n+\t\t\tdata->ugp.pid = ucred_getpid(uc);\r\n \t\t\tucred_free(uc);\r\n \t\t} else {\r\n \t\t\tres = -errno;\r\n@@ -645,7 +645,7 @@\r\n \t\t * TODO get the peer's pid.\r\n \t\t * c->pid = ?;\r\n \t\t */\r\n-\t\tif (getpeereid(data->sock, &ugp.uid, &ugp.gid) == 0) {\r\n+\t\tif (getpeereid(data->sock, &data->ugp.uid, &data->ugp.gid) == 0) {\r\n \t\t\tres = 0;\r\n \t\t} else {\r\n \t\t\tres = -errno;\r\n```\r\n\r\nRgds.\r\n\r\nFranz\r\n"},"comment":{"url":"https://api.github.com/repos/ClusterLabs/libqb/issues/comments/169702011","html_url":"https://github.com/ClusterLabs/libqb/issues/156#issuecomment-169702011","issue_url":"https://api.github.com/repos/ClusterLabs/libqb/issues/156","id":169702011,"user":{"login":"chrissie-c","id":3415721,"avatar_url":"https://avatars.githubusercontent.com/u/3415721?v=3","gravatar_id":"","url":"https://api.github.com/users/chrissie-c","html_url":"https://github.com/chrissie-c","followers_url":"https://api.github.com/users/chrissie-c/followers","following_url":"https://api.github.com/users/chrissie-c/following{/other_user}","gists_url":"https://api.github.com/users/chrissie-c/gists{/gist_id}","starred_url":"https://api.github.com/users/chrissie-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrissie-c/subscriptions","organizations_url":"https://api.github.com/users/chrissie-c/orgs","repos_url":"https://api.github.com/users/chrissie-c/repos","events_url":"https://api.github.com/users/chrissie-c/events{/privacy}","received_events_url":"https://api.github.com/users/chrissie-c/received_events","type":"User","site_admin":false},"created_at":"2016-01-07T15:47:23Z","updated_at":"2016-01-07T15:47:23Z","body":"Closing this because the patch has been pulled."}}