{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/comments/57179139","id":57179139,"diff_hunk":"@@ -42,14 +42,39 @@ public void testAustouristsInterceptTimeTrend() throws Exception {\n         double statistics = augmentedDickeyFullerTest.statistics();\n         double pValue = augmentedDickeyFullerTest.pValue();\n \n-        System.out.println(AugmentedDickeyFullerTest.Type.InterceptTimeTrend.name() + \"=\" + statistics + \", pValue=\"\n-                + pValue);\n-\n         Assert.assertEquals(-7.4083, statistics, 0.001);\n         Assert.assertTrue(pValue <= 0.01);\n     }\n \n     @Test\n+    public void testAustourists4Lags() throws IOException {\n+        ModelData rModel = ModelReader.read(\"austourists\");\n+        double[] x = Utils.toArray(rModel.getData());\n+\n+        AugmentedDickeyFullerTest augmentedDickeyFullerTest = new AugmentedDickeyFullerTest(x, 4,\n+                AugmentedDickeyFullerTest.Type.InterceptTimeTrend);\n+        double statistics = augmentedDickeyFullerTest.statistics();\n+        double pValue = augmentedDickeyFullerTest.pValue();\n+\n+        Assert.assertEquals(-1.8381, statistics, 0.001);\n+        Assert.assertEquals(0.6388, pValue, 0.05);\n+    }\n+\n+    @Test\n+    public void testAustourists4LagsInterceptNoTimeTrend() throws IOException {\n+        ModelData rModel = ModelReader.read(\"austourists\");\n+        double[] x = Utils.toArray(rModel.getData());\n+\n+        AugmentedDickeyFullerTest augmentedDickeyFullerTest = new AugmentedDickeyFullerTest(x, 4,\n+                AugmentedDickeyFullerTest.Type.InterceptNoTimeTrend);\n+        double statistics = augmentedDickeyFullerTest.statistics();\n+        double pValue = augmentedDickeyFullerTest.pValue();\n+\n+        Assert.assertEquals(-0.0625, statistics, 0.001);\n+        Assert.assertEquals(0.9451, pValue, 0.02);","path":"hawkular-datamining-forecast/src/test/java/org/hawkular/datamining/forecast/AugmentedDickeyFullerTestTest.java","position":36,"original_position":36,"commit_id":"15fb871dd9c3b457daa8b7b074ccb450b34d09ff","original_commit_id":"15fb871dd9c3b457daa8b7b074ccb450b34d09ff","user":{"login":"Jiri-Kremser","id":535866,"avatar_url":"https://avatars.githubusercontent.com/u/535866?v=3","gravatar_id":"","url":"https://api.github.com/users/Jiri-Kremser","html_url":"https://github.com/Jiri-Kremser","followers_url":"https://api.github.com/users/Jiri-Kremser/followers","following_url":"https://api.github.com/users/Jiri-Kremser/following{/other_user}","gists_url":"https://api.github.com/users/Jiri-Kremser/gists{/gist_id}","starred_url":"https://api.github.com/users/Jiri-Kremser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jiri-Kremser/subscriptions","organizations_url":"https://api.github.com/users/Jiri-Kremser/orgs","repos_url":"https://api.github.com/users/Jiri-Kremser/repos","events_url":"https://api.github.com/users/Jiri-Kremser/events{/privacy}","received_events_url":"https://api.github.com/users/Jiri-Kremser/received_events","type":"User","site_admin":false},"body":"?, the first param in `Assert.assertEquals` should be the message, shouldn't it? Perhaps, use more comments.","created_at":"2016-03-23T15:26:33Z","updated_at":"2016-03-23T15:26:33Z","html_url":"https://github.com/hawkular/hawkular-datamining/pull/56#discussion_r57179139","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/comments/57179139"},"html":{"href":"https://github.com/hawkular/hawkular-datamining/pull/56#discussion_r57179139"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56","id":63886913,"html_url":"https://github.com/hawkular/hawkular-datamining/pull/56","diff_url":"https://github.com/hawkular/hawkular-datamining/pull/56.diff","patch_url":"https://github.com/hawkular/hawkular-datamining/pull/56.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-datamining/issues/56","number":56,"state":"open","locked":false,"title":"adf test support more lags","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"body":"Augmented Dickey-Fuller statistics configurable to use more lags.\r\n\r\n@Jiri-Kremser could you please review? ","created_at":"2016-03-23T14:06:47Z","updated_at":"2016-03-23T15:26:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15a8118111d57fb33526d193fc030cf4c2aa7906","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-datamining/issues/56/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-datamining/statuses/15fb871dd9c3b457daa8b7b074ccb450b34d09ff","head":{"label":"pavolloffay:adftest-support-more-lags","ref":"adftest-support-more-lags","sha":"15fb871dd9c3b457daa8b7b074ccb450b34d09ff","user":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"repo":{"id":44054814,"name":"hawkular-datamining","full_name":"pavolloffay/hawkular-datamining","owner":{"login":"pavolloffay","id":5618424,"avatar_url":"https://avatars.githubusercontent.com/u/5618424?v=3","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavolloffay/hawkular-datamining","description":"Alert prediction based on time series data","fork":true,"url":"https://api.github.com/repos/pavolloffay/hawkular-datamining","forks_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/forks","keys_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/teams","hooks_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/hooks","issue_events_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/issues/events{/number}","events_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/events","assignees_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/assignees{/user}","branches_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/branches{/branch}","tags_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/tags","blobs_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/statuses/{sha}","languages_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/languages","stargazers_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/stargazers","contributors_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/contributors","subscribers_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/subscribers","subscription_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/subscription","commits_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/contents/{+path}","compare_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/merges","archive_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/downloads","issues_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/issues{/number}","pulls_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/pulls{/number}","milestones_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/milestones{/number}","notifications_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/labels{/name}","releases_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/releases{/id}","deployments_url":"https://api.github.com/repos/pavolloffay/hawkular-datamining/deployments","created_at":"2015-10-11T14:14:48Z","updated_at":"2016-01-15T11:06:32Z","pushed_at":"2016-03-23T14:05:08Z","git_url":"git://github.com/pavolloffay/hawkular-datamining.git","ssh_url":"git@github.com:pavolloffay/hawkular-datamining.git","clone_url":"https://github.com/pavolloffay/hawkular-datamining.git","svn_url":"https://github.com/pavolloffay/hawkular-datamining","homepage":"","size":2320,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"53119da848678998beacc4727f45bda83e6d0db5","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":34382546,"name":"hawkular-datamining","full_name":"hawkular/hawkular-datamining","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-datamining","description":"Alert prediction based on time series data","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-datamining","forks_url":"https://api.github.com/repos/hawkular/hawkular-datamining/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-datamining/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-datamining/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-datamining/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-datamining/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-datamining/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-datamining/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-datamining/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-datamining/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-datamining/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-datamining/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-datamining/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-datamining/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-datamining/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-datamining/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-datamining/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-datamining/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-datamining/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-datamining/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-datamining/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-datamining/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-datamining/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-datamining/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-datamining/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-datamining/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-datamining/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-datamining/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-datamining/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-datamining/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-datamining/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-datamining/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-datamining/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-datamining/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-datamining/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-datamining/deployments","created_at":"2015-04-22T09:52:30Z","updated_at":"2016-01-11T11:54:35Z","pushed_at":"2016-03-23T14:30:30Z","git_url":"git://github.com/hawkular/hawkular-datamining.git","ssh_url":"git@github.com:hawkular/hawkular-datamining.git","clone_url":"https://github.com/hawkular/hawkular-datamining.git","svn_url":"https://github.com/hawkular/hawkular-datamining","homepage":"","size":2652,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56"},"html":{"href":"https://github.com/hawkular/hawkular-datamining/pull/56"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/issues/56"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-datamining/statuses/15fb871dd9c3b457daa8b7b074ccb450b34d09ff"}}}}