{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/9220","repository_url":"https://api.github.com/repos/CartoDB/cartodb","labels_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9220/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9220/comments","events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9220/events","html_url":"https://github.com/CartoDB/cartodb/pull/9220","id":168833951,"number":9220,"title":"9157 persist notifications","user":{"login":"javitonino","id":7569673,"avatar_url":"https://avatars.githubusercontent.com/u/7569673?v=3","gravatar_id":"","url":"https://api.github.com/users/javitonino","html_url":"https://github.com/javitonino","followers_url":"https://api.github.com/users/javitonino/followers","following_url":"https://api.github.com/users/javitonino/following{/other_user}","gists_url":"https://api.github.com/users/javitonino/gists{/gist_id}","starred_url":"https://api.github.com/users/javitonino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javitonino/subscriptions","organizations_url":"https://api.github.com/users/javitonino/orgs","repos_url":"https://api.github.com/users/javitonino/repos","events_url":"https://api.github.com/users/javitonino/events{/privacy}","received_events_url":"https://api.github.com/users/javitonino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-02T09:02:19Z","updated_at":"2016-08-02T09:11:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/9220","html_url":"https://github.com/CartoDB/cartodb/pull/9220","diff_url":"https://github.com/CartoDB/cartodb/pull/9220.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/9220.patch"},"body":"Closes #9157"},"comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments/236848483","html_url":"https://github.com/CartoDB/cartodb/pull/9220#issuecomment-236848483","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/9220","id":236848483,"user":{"login":"javitonino","id":7569673,"avatar_url":"https://avatars.githubusercontent.com/u/7569673?v=3","gravatar_id":"","url":"https://api.github.com/users/javitonino","html_url":"https://github.com/javitonino","followers_url":"https://api.github.com/users/javitonino/followers","following_url":"https://api.github.com/users/javitonino/following{/other_user}","gists_url":"https://api.github.com/users/javitonino/gists{/gist_id}","starred_url":"https://api.github.com/users/javitonino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javitonino/subscriptions","organizations_url":"https://api.github.com/users/javitonino/orgs","repos_url":"https://api.github.com/users/javitonino/repos","events_url":"https://api.github.com/users/javitonino/events{/privacy}","received_events_url":"https://api.github.com/users/javitonino/received_events","type":"User","site_admin":false},"created_at":"2016-08-02T09:11:57Z","updated_at":"2016-08-02T09:11:57Z","body":"This is an early version, just wanted @juanignaciosl to take a look. Following the approach we discussed (categories as top level JSON keys) I found a couple of points where the code felt a bit weird:\r\n - I don't like having to run `replace` on the hash, instead of using assignment. I'm doing it so it updates the model directly, without having to add a setter.\r\n - `notifications.notifications_for` but that can easily be solved by a helper in the user model (which would allow to remove the `alias_method_chain` magic).\r\n\r\nThis is not too bad right now, but I am not convinced this is the right approach, maybe we should just add a surrogate id key, a category column, and do this like a more traditional rails model, which is overkill but would play nicer with the framework. Opinion?"}}
{"actor":{"display_login":"javitonino"}}