{"action":"closed","issue":{"url":"https://api.github.com/repos/ampproject/amphtml/issues/5477","repository_url":"https://api.github.com/repos/ampproject/amphtml","labels_url":"https://api.github.com/repos/ampproject/amphtml/issues/5477/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/5477/comments","events_url":"https://api.github.com/repos/ampproject/amphtml/issues/5477/events","html_url":"https://github.com/ampproject/amphtml/issues/5477","id":181806879,"number":5477,"title":"amp-sidebar mask issue","user":{"login":"Arun1048576","id":6386948,"avatar_url":"https://avatars.githubusercontent.com/u/6386948?v=3","gravatar_id":"","url":"https://api.github.com/users/Arun1048576","html_url":"https://github.com/Arun1048576","followers_url":"https://api.github.com/users/Arun1048576/followers","following_url":"https://api.github.com/users/Arun1048576/following{/other_user}","gists_url":"https://api.github.com/users/Arun1048576/gists{/gist_id}","starred_url":"https://api.github.com/users/Arun1048576/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arun1048576/subscriptions","organizations_url":"https://api.github.com/users/Arun1048576/orgs","repos_url":"https://api.github.com/users/Arun1048576/repos","events_url":"https://api.github.com/users/Arun1048576/events{/privacy}","received_events_url":"https://api.github.com/users/Arun1048576/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"camelburrito","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/camelburrito","html_url":"https://github.com/camelburrito","followers_url":"https://api.github.com/users/camelburrito/followers","following_url":"https://api.github.com/users/camelburrito/following{/other_user}","gists_url":"https://api.github.com/users/camelburrito/gists{/gist_id}","starred_url":"https://api.github.com/users/camelburrito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camelburrito/subscriptions","organizations_url":"https://api.github.com/users/camelburrito/orgs","repos_url":"https://api.github.com/users/camelburrito/repos","events_url":"https://api.github.com/users/camelburrito/events{/privacy}","received_events_url":"https://api.github.com/users/camelburrito/received_events","type":"User","site_admin":false},"assignees":[{"login":"camelburrito","id":1037311,"avatar_url":"https://avatars.githubusercontent.com/u/1037311?v=3","gravatar_id":"","url":"https://api.github.com/users/camelburrito","html_url":"https://github.com/camelburrito","followers_url":"https://api.github.com/users/camelburrito/followers","following_url":"https://api.github.com/users/camelburrito/following{/other_user}","gists_url":"https://api.github.com/users/camelburrito/gists{/gist_id}","starred_url":"https://api.github.com/users/camelburrito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camelburrito/subscriptions","organizations_url":"https://api.github.com/users/camelburrito/orgs","repos_url":"https://api.github.com/users/camelburrito/repos","events_url":"https://api.github.com/users/camelburrito/events{/privacy}","received_events_url":"https://api.github.com/users/camelburrito/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-08T05:49:30Z","updated_at":"2016-10-08T06:48:01Z","closed_at":"2016-10-08T06:48:01Z","body":"Please walk through the following steps for reporting an issue about AMP:\r\n\r\namp-sidebar has an issue. The amp-mask does not seem to get displayed when the sidebar opens. In the example given on ampbyexample.com, it seems amp-sidebar works fine when the code comes from the service worker, and on hard reload it doesn't. I think the service worker has cached a previous version of amp-sidebar and in the new version some code is missing. \r\n\r\n## How do we reproduce the issue?\r\n1. Goto https://ampbyexample.com/components/amp-sidebar/\r\n2. Do a hard reload so that amp-sidebar comes from CDN.\r\n<img width=\"1279\" alt=\"screen shot 2016-10-08 at 11 10 47 am\" src=\"https://cloud.githubusercontent.com/assets/6386948/19210692/f1b4b668-8d47-11e6-9aaf-3d18318a78ea.png\">\r\nAs we can see the code of amp-sidebar-0.1.js does not have the code to give amp-mask the display block property. Now the sidebar does not close on clicking outside.\r\n\r\n3. Now try again and let the code now come from service worker\r\n<img width=\"1276\" alt=\"screen shot 2016-10-08 at 11 13 55 am\" src=\"https://cloud.githubusercontent.com/assets/6386948/19210704/568babbe-8d48-11e6-953b-5fcba9617a14.png\">\r\nAs we can see the code which comes from service worker is different from the one from CDN and now the sidebar closes on clicking outside.\r\n"}}
{"actor":{"display_login":"camelburrito"}}