{"action":"created","comment":{"url":"https://api.github.com/repos/monixio/monix-sample/pulls/comments/62479532","id":62479532,"diff_hunk":"@@ -78,14 +87,14 @@ final class BackPressuredWebSocketClient private (url: String)\n         scheduler.reportFailure(ex)\n         // retry connection in a couple of secs\n         self.delaySubscription(3.seconds)\n-          .onSubscribe(subscriber)\n+          .subscribe(subscriber)","path":"client/src/main/scala/client/BackPressuredWebSocketClient.scala","position":127,"original_position":127,"commit_id":"3de55ecd2d13ad0cecc8d421bf16f6de78f829eb","original_commit_id":"3de55ecd2d13ad0cecc8d421bf16f6de78f829eb","user":{"login":"alexandru","id":11753,"avatar_url":"https://avatars.githubusercontent.com/u/11753?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandru","html_url":"https://github.com/alexandru","followers_url":"https://api.github.com/users/alexandru/followers","following_url":"https://api.github.com/users/alexandru/following{/other_user}","gists_url":"https://api.github.com/users/alexandru/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru/subscriptions","organizations_url":"https://api.github.com/users/alexandru/orgs","repos_url":"https://api.github.com/users/alexandru/repos","events_url":"https://api.github.com/users/alexandru/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru/received_events","type":"User","site_admin":false},"body":"Here we should call `unsafeSubscribeFn` because we know what we are doing (i.e. our stuff is protected from errors with try/catch, we do know how to apply back-pressure, etc). Plain users are the ones that are supposed to call `subscribe`, as it wraps `Subscriber` implementations into a `SafeSubscriber` that does error handling and applies back-pressure on `onComplete` and `onError`.","created_at":"2016-05-09T10:42:08Z","updated_at":"2016-05-09T10:42:08Z","html_url":"https://github.com/monixio/monix-sample/pull/1#discussion_r62479532","pull_request_url":"https://api.github.com/repos/monixio/monix-sample/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/monixio/monix-sample/pulls/comments/62479532"},"html":{"href":"https://github.com/monixio/monix-sample/pull/1#discussion_r62479532"},"pull_request":{"href":"https://api.github.com/repos/monixio/monix-sample/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/monixio/monix-sample/pulls/1","id":68662024,"html_url":"https://github.com/monixio/monix-sample/pull/1","diff_url":"https://github.com/monixio/monix-sample/pull/1.diff","patch_url":"https://github.com/monixio/monix-sample/pull/1.patch","issue_url":"https://api.github.com/repos/monixio/monix-sample/issues/1","number":1,"state":"open","locked":false,"title":"Feature/demo2x","user":{"login":"mihaisoloi","id":515923,"avatar_url":"https://avatars.githubusercontent.com/u/515923?v=3","gravatar_id":"","url":"https://api.github.com/users/mihaisoloi","html_url":"https://github.com/mihaisoloi","followers_url":"https://api.github.com/users/mihaisoloi/followers","following_url":"https://api.github.com/users/mihaisoloi/following{/other_user}","gists_url":"https://api.github.com/users/mihaisoloi/gists{/gist_id}","starred_url":"https://api.github.com/users/mihaisoloi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihaisoloi/subscriptions","organizations_url":"https://api.github.com/users/mihaisoloi/orgs","repos_url":"https://api.github.com/users/mihaisoloi/repos","events_url":"https://api.github.com/users/mihaisoloi/events{/privacy}","received_events_url":"https://api.github.com/users/mihaisoloi/received_events","type":"User","site_admin":false},"body":"the IntegrationSpec doesn't work on master either","created_at":"2016-05-03T06:16:53Z","updated_at":"2016-05-09T10:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc593b42f392569ecd54c2415d5f5c99e396ce09","assignee":{"login":"alexandru","id":11753,"avatar_url":"https://avatars.githubusercontent.com/u/11753?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandru","html_url":"https://github.com/alexandru","followers_url":"https://api.github.com/users/alexandru/followers","following_url":"https://api.github.com/users/alexandru/following{/other_user}","gists_url":"https://api.github.com/users/alexandru/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru/subscriptions","organizations_url":"https://api.github.com/users/alexandru/orgs","repos_url":"https://api.github.com/users/alexandru/repos","events_url":"https://api.github.com/users/alexandru/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/monixio/monix-sample/pulls/1/commits","review_comments_url":"https://api.github.com/repos/monixio/monix-sample/pulls/1/comments","review_comment_url":"https://api.github.com/repos/monixio/monix-sample/pulls/comments{/number}","comments_url":"https://api.github.com/repos/monixio/monix-sample/issues/1/comments","statuses_url":"https://api.github.com/repos/monixio/monix-sample/statuses/3de55ecd2d13ad0cecc8d421bf16f6de78f829eb","head":{"label":"monixio:feature/demo2x","ref":"feature/demo2x","sha":"3de55ecd2d13ad0cecc8d421bf16f6de78f829eb","user":{"login":"monixio","id":16490874,"avatar_url":"https://avatars.githubusercontent.com/u/16490874?v=3","gravatar_id":"","url":"https://api.github.com/users/monixio","html_url":"https://github.com/monixio","followers_url":"https://api.github.com/users/monixio/followers","following_url":"https://api.github.com/users/monixio/following{/other_user}","gists_url":"https://api.github.com/users/monixio/gists{/gist_id}","starred_url":"https://api.github.com/users/monixio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monixio/subscriptions","organizations_url":"https://api.github.com/users/monixio/orgs","repos_url":"https://api.github.com/users/monixio/repos","events_url":"https://api.github.com/users/monixio/events{/privacy}","received_events_url":"https://api.github.com/users/monixio/received_events","type":"Organization","site_admin":false},"repo":{"id":41586299,"name":"monix-sample","full_name":"monixio/monix-sample","owner":{"login":"monixio","id":16490874,"avatar_url":"https://avatars.githubusercontent.com/u/16490874?v=3","gravatar_id":"","url":"https://api.github.com/users/monixio","html_url":"https://github.com/monixio","followers_url":"https://api.github.com/users/monixio/followers","following_url":"https://api.github.com/users/monixio/following{/other_user}","gists_url":"https://api.github.com/users/monixio/gists{/gist_id}","starred_url":"https://api.github.com/users/monixio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monixio/subscriptions","organizations_url":"https://api.github.com/users/monixio/orgs","repos_url":"https://api.github.com/users/monixio/repos","events_url":"https://api.github.com/users/monixio/events{/privacy}","received_events_url":"https://api.github.com/users/monixio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/monixio/monix-sample","description":"A project exemplifying client / server communications with Monifu","fork":false,"url":"https://api.github.com/repos/monixio/monix-sample","forks_url":"https://api.github.com/repos/monixio/monix-sample/forks","keys_url":"https://api.github.com/repos/monixio/monix-sample/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monixio/monix-sample/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monixio/monix-sample/teams","hooks_url":"https://api.github.com/repos/monixio/monix-sample/hooks","issue_events_url":"https://api.github.com/repos/monixio/monix-sample/issues/events{/number}","events_url":"https://api.github.com/repos/monixio/monix-sample/events","assignees_url":"https://api.github.com/repos/monixio/monix-sample/assignees{/user}","branches_url":"https://api.github.com/repos/monixio/monix-sample/branches{/branch}","tags_url":"https://api.github.com/repos/monixio/monix-sample/tags","blobs_url":"https://api.github.com/repos/monixio/monix-sample/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monixio/monix-sample/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monixio/monix-sample/git/refs{/sha}","trees_url":"https://api.github.com/repos/monixio/monix-sample/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monixio/monix-sample/statuses/{sha}","languages_url":"https://api.github.com/repos/monixio/monix-sample/languages","stargazers_url":"https://api.github.com/repos/monixio/monix-sample/stargazers","contributors_url":"https://api.github.com/repos/monixio/monix-sample/contributors","subscribers_url":"https://api.github.com/repos/monixio/monix-sample/subscribers","subscription_url":"https://api.github.com/repos/monixio/monix-sample/subscription","commits_url":"https://api.github.com/repos/monixio/monix-sample/commits{/sha}","git_commits_url":"https://api.github.com/repos/monixio/monix-sample/git/commits{/sha}","comments_url":"https://api.github.com/repos/monixio/monix-sample/comments{/number}","issue_comment_url":"https://api.github.com/repos/monixio/monix-sample/issues/comments{/number}","contents_url":"https://api.github.com/repos/monixio/monix-sample/contents/{+path}","compare_url":"https://api.github.com/repos/monixio/monix-sample/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monixio/monix-sample/merges","archive_url":"https://api.github.com/repos/monixio/monix-sample/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monixio/monix-sample/downloads","issues_url":"https://api.github.com/repos/monixio/monix-sample/issues{/number}","pulls_url":"https://api.github.com/repos/monixio/monix-sample/pulls{/number}","milestones_url":"https://api.github.com/repos/monixio/monix-sample/milestones{/number}","notifications_url":"https://api.github.com/repos/monixio/monix-sample/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monixio/monix-sample/labels{/name}","releases_url":"https://api.github.com/repos/monixio/monix-sample/releases{/id}","deployments_url":"https://api.github.com/repos/monixio/monix-sample/deployments","created_at":"2015-08-29T08:27:32Z","updated_at":"2016-05-08T23:15:18Z","pushed_at":"2016-05-03T06:16:53Z","git_url":"git://github.com/monixio/monix-sample.git","ssh_url":"git@github.com:monixio/monix-sample.git","clone_url":"https://github.com/monixio/monix-sample.git","svn_url":"https://github.com/monixio/monix-sample","homepage":"","size":56,"stargazers_count":37,"watchers_count":37,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":37,"default_branch":"master"}},"base":{"label":"monixio:master","ref":"master","sha":"aedbe8706808048ca7cf3424cea823cf2c8317e0","user":{"login":"monixio","id":16490874,"avatar_url":"https://avatars.githubusercontent.com/u/16490874?v=3","gravatar_id":"","url":"https://api.github.com/users/monixio","html_url":"https://github.com/monixio","followers_url":"https://api.github.com/users/monixio/followers","following_url":"https://api.github.com/users/monixio/following{/other_user}","gists_url":"https://api.github.com/users/monixio/gists{/gist_id}","starred_url":"https://api.github.com/users/monixio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monixio/subscriptions","organizations_url":"https://api.github.com/users/monixio/orgs","repos_url":"https://api.github.com/users/monixio/repos","events_url":"https://api.github.com/users/monixio/events{/privacy}","received_events_url":"https://api.github.com/users/monixio/received_events","type":"Organization","site_admin":false},"repo":{"id":41586299,"name":"monix-sample","full_name":"monixio/monix-sample","owner":{"login":"monixio","id":16490874,"avatar_url":"https://avatars.githubusercontent.com/u/16490874?v=3","gravatar_id":"","url":"https://api.github.com/users/monixio","html_url":"https://github.com/monixio","followers_url":"https://api.github.com/users/monixio/followers","following_url":"https://api.github.com/users/monixio/following{/other_user}","gists_url":"https://api.github.com/users/monixio/gists{/gist_id}","starred_url":"https://api.github.com/users/monixio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monixio/subscriptions","organizations_url":"https://api.github.com/users/monixio/orgs","repos_url":"https://api.github.com/users/monixio/repos","events_url":"https://api.github.com/users/monixio/events{/privacy}","received_events_url":"https://api.github.com/users/monixio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/monixio/monix-sample","description":"A project exemplifying client / server communications with Monifu","fork":false,"url":"https://api.github.com/repos/monixio/monix-sample","forks_url":"https://api.github.com/repos/monixio/monix-sample/forks","keys_url":"https://api.github.com/repos/monixio/monix-sample/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monixio/monix-sample/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monixio/monix-sample/teams","hooks_url":"https://api.github.com/repos/monixio/monix-sample/hooks","issue_events_url":"https://api.github.com/repos/monixio/monix-sample/issues/events{/number}","events_url":"https://api.github.com/repos/monixio/monix-sample/events","assignees_url":"https://api.github.com/repos/monixio/monix-sample/assignees{/user}","branches_url":"https://api.github.com/repos/monixio/monix-sample/branches{/branch}","tags_url":"https://api.github.com/repos/monixio/monix-sample/tags","blobs_url":"https://api.github.com/repos/monixio/monix-sample/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monixio/monix-sample/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monixio/monix-sample/git/refs{/sha}","trees_url":"https://api.github.com/repos/monixio/monix-sample/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monixio/monix-sample/statuses/{sha}","languages_url":"https://api.github.com/repos/monixio/monix-sample/languages","stargazers_url":"https://api.github.com/repos/monixio/monix-sample/stargazers","contributors_url":"https://api.github.com/repos/monixio/monix-sample/contributors","subscribers_url":"https://api.github.com/repos/monixio/monix-sample/subscribers","subscription_url":"https://api.github.com/repos/monixio/monix-sample/subscription","commits_url":"https://api.github.com/repos/monixio/monix-sample/commits{/sha}","git_commits_url":"https://api.github.com/repos/monixio/monix-sample/git/commits{/sha}","comments_url":"https://api.github.com/repos/monixio/monix-sample/comments{/number}","issue_comment_url":"https://api.github.com/repos/monixio/monix-sample/issues/comments{/number}","contents_url":"https://api.github.com/repos/monixio/monix-sample/contents/{+path}","compare_url":"https://api.github.com/repos/monixio/monix-sample/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monixio/monix-sample/merges","archive_url":"https://api.github.com/repos/monixio/monix-sample/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monixio/monix-sample/downloads","issues_url":"https://api.github.com/repos/monixio/monix-sample/issues{/number}","pulls_url":"https://api.github.com/repos/monixio/monix-sample/pulls{/number}","milestones_url":"https://api.github.com/repos/monixio/monix-sample/milestones{/number}","notifications_url":"https://api.github.com/repos/monixio/monix-sample/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monixio/monix-sample/labels{/name}","releases_url":"https://api.github.com/repos/monixio/monix-sample/releases{/id}","deployments_url":"https://api.github.com/repos/monixio/monix-sample/deployments","created_at":"2015-08-29T08:27:32Z","updated_at":"2016-05-08T23:15:18Z","pushed_at":"2016-05-03T06:16:53Z","git_url":"git://github.com/monixio/monix-sample.git","ssh_url":"git@github.com:monixio/monix-sample.git","clone_url":"https://github.com/monixio/monix-sample.git","svn_url":"https://github.com/monixio/monix-sample","homepage":"","size":56,"stargazers_count":37,"watchers_count":37,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/monixio/monix-sample/pulls/1"},"html":{"href":"https://github.com/monixio/monix-sample/pull/1"},"issue":{"href":"https://api.github.com/repos/monixio/monix-sample/issues/1"},"comments":{"href":"https://api.github.com/repos/monixio/monix-sample/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/monixio/monix-sample/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/monixio/monix-sample/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/monixio/monix-sample/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/monixio/monix-sample/statuses/3de55ecd2d13ad0cecc8d421bf16f6de78f829eb"}}}}