{"comment":{"url":"https://api.github.com/repos/h2oai/sparkling-water/comments/19164132","html_url":"https://github.com/h2oai/sparkling-water/commit/cd3673c5b15a9e9f487d56044c30437acb9f5f51#commitcomment-19164132","id":19164132,"user":{"login":"jakubhava","id":4374603,"avatar_url":"https://avatars.githubusercontent.com/u/4374603?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubhava","html_url":"https://github.com/jakubhava","followers_url":"https://api.github.com/users/jakubhava/followers","following_url":"https://api.github.com/users/jakubhava/following{/other_user}","gists_url":"https://api.github.com/users/jakubhava/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubhava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubhava/subscriptions","organizations_url":"https://api.github.com/users/jakubhava/orgs","repos_url":"https://api.github.com/users/jakubhava/repos","events_url":"https://api.github.com/users/jakubhava/events{/privacy}","received_events_url":"https://api.github.com/users/jakubhava/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"cd3673c5b15a9e9f487d56044c30437acb9f5f51","created_at":"2016-09-25T16:36:51Z","updated_at":"2016-09-25T16:36:51Z","body":"Sorry that the change is so big, I realised that some time ago and won't do it like this next time.\r\n\r\nIt should not be hard to integrate or I also think that there should not be big problems with integrating it with @vpatryshev changes. This was also why I was trying to keep some API you were working on the same as was in master. I have looked on your PR with type handling and it should easy to integrate, I will just generalise ReadConvertorContext a bit as I wrote at one of the comments in that PR. So we can integrate your PR first and then I can integrate this branch on top of that \r\n\r\nRegarding tests. I haven't created tests for this functionality because I changed the current tests to be able to tests both external and internal backends and thought it's enough. But I definitely welcome suggestions what I should improve and generally improving QA as @mmalohlava said this one is a good thing!\r\n"}}
{"actor":{"display_login":"jakubhava"}}