{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/50231126","id":50231126,"diff_hunk":"@@ -30,4 +30,8 @@\n         </whitelist>\n     </filter>\n \n+    <php>\n+        <ini name=\"precision\" value=\"8\"/>\n+    </php>\n+","path":"phpunit.xml.dist","position":16,"original_position":16,"commit_id":"3b7f81ab51bb4e1d556c71bb7c678564b07635ef","original_commit_id":"7cdda68cecfb0c57c3143c3f20f5461c77978091","user":{"login":"mikemeier","id":776406,"avatar_url":"https://avatars.githubusercontent.com/u/776406?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemeier","html_url":"https://github.com/mikemeier","followers_url":"https://api.github.com/users/mikemeier/followers","following_url":"https://api.github.com/users/mikemeier/following{/other_user}","gists_url":"https://api.github.com/users/mikemeier/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemeier/subscriptions","organizations_url":"https://api.github.com/users/mikemeier/orgs","repos_url":"https://api.github.com/users/mikemeier/repos","events_url":"https://api.github.com/users/mikemeier/events{/privacy}","received_events_url":"https://api.github.com/users/mikemeier/received_events","type":"User","site_admin":false},"body":"There are a lot more of them @OskarStark (8 to be precise). And you cant rewrite them correctly. If your php.ini uses precision 200, you will get other results than with precision 5. So the correct way in my opinion is to write your tests with the knowledge of the php.ini precision (thats what I did with the xml change). If you're not comfortable with precision \"8\" we could also use \"100\" and then round the values before comparing in the unit test.","created_at":"2016-01-20T09:28:17Z","updated_at":"2016-01-20T09:28:17Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2562#discussion_r50231126","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/50231126"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/2562#discussion_r50231126"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562","id":24295687,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2562","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2562.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/2562.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2562","number":2562,"state":"open","locked":false,"title":"Add FormBuilderIteratorTest and provide php-ini setting for precision","user":{"login":"mikemeier","id":776406,"avatar_url":"https://avatars.githubusercontent.com/u/776406?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemeier","html_url":"https://github.com/mikemeier","followers_url":"https://api.github.com/users/mikemeier/followers","following_url":"https://api.github.com/users/mikemeier/following{/other_user}","gists_url":"https://api.github.com/users/mikemeier/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemeier/subscriptions","organizations_url":"https://api.github.com/users/mikemeier/orgs","repos_url":"https://api.github.com/users/mikemeier/repos","events_url":"https://api.github.com/users/mikemeier/events{/privacy}","received_events_url":"https://api.github.com/users/mikemeier/received_events","type":"User","site_admin":false},"body":"* Add phpunit to composer.json\r\n* Test-Template-Files from sonata are generated with a php.ini precision setting of 8, so lets run php also with this predefined setting\r\n* FormBuilder of Symfony can be extended (for example: https://github.com/egeloen/ivory-ordered-form/blob/master/src/Builder/OrderedFormBuilder.php) and this will break sonata admin FormBuilderIterator because the private property \"children\" is not available","created_at":"2014-11-12T14:31:07Z","updated_at":"2016-01-20T09:28:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fd5f3e1fdf0ab2b03438a9592bce72909ed1f91","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2562/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/3b7f81ab51bb4e1d556c71bb7c678564b07635ef","head":{"label":"mikemeier:master","ref":"master","sha":"3b7f81ab51bb4e1d556c71bb7c678564b07635ef","user":{"login":"mikemeier","id":776406,"avatar_url":"https://avatars.githubusercontent.com/u/776406?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemeier","html_url":"https://github.com/mikemeier","followers_url":"https://api.github.com/users/mikemeier/followers","following_url":"https://api.github.com/users/mikemeier/following{/other_user}","gists_url":"https://api.github.com/users/mikemeier/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemeier/subscriptions","organizations_url":"https://api.github.com/users/mikemeier/orgs","repos_url":"https://api.github.com/users/mikemeier/repos","events_url":"https://api.github.com/users/mikemeier/events{/privacy}","received_events_url":"https://api.github.com/users/mikemeier/received_events","type":"User","site_admin":false},"repo":{"id":26537155,"name":"SonataAdminBundle","full_name":"mikemeier/SonataAdminBundle","owner":{"login":"mikemeier","id":776406,"avatar_url":"https://avatars.githubusercontent.com/u/776406?v=3","gravatar_id":"","url":"https://api.github.com/users/mikemeier","html_url":"https://github.com/mikemeier","followers_url":"https://api.github.com/users/mikemeier/followers","following_url":"https://api.github.com/users/mikemeier/following{/other_user}","gists_url":"https://api.github.com/users/mikemeier/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemeier/subscriptions","organizations_url":"https://api.github.com/users/mikemeier/orgs","repos_url":"https://api.github.com/users/mikemeier/repos","events_url":"https://api.github.com/users/mikemeier/events{/privacy}","received_events_url":"https://api.github.com/users/mikemeier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikemeier/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/mikemeier/SonataAdminBundle","forks_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/mikemeier/SonataAdminBundle/releases{/id}","created_at":"2014-11-12T13:29:30Z","updated_at":"2016-01-12T08:40:13Z","pushed_at":"2016-01-20T09:10:38Z","git_url":"git://github.com/mikemeier/SonataAdminBundle.git","ssh_url":"git@github.com:mikemeier/SonataAdminBundle.git","clone_url":"https://github.com/mikemeier/SonataAdminBundle.git","svn_url":"https://github.com/mikemeier/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":16671,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sonata-project:master","ref":"master","sha":"f2d7c508cf49435792ae8ab78ab5a2534412d99e","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-01-19T05:27:16Z","pushed_at":"2016-01-20T09:10:38Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":19446,"stargazers_count":1301,"watchers_count":1301,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":925,"mirror_url":null,"open_issues_count":577,"forks":925,"open_issues":577,"watchers":1301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/2562"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2562"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/2562/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/2562/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/3b7f81ab51bb4e1d556c71bb7c678564b07635ef"}}}}