{"action":"created","issue":{"url":"https://api.github.com/repos/milg0/onvif-java-lib/issues/7","repository_url":"https://api.github.com/repos/milg0/onvif-java-lib","labels_url":"https://api.github.com/repos/milg0/onvif-java-lib/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/milg0/onvif-java-lib/issues/7/comments","events_url":"https://api.github.com/repos/milg0/onvif-java-lib/issues/7/events","html_url":"https://github.com/milg0/onvif-java-lib/pull/7","id":136228969,"number":7,"title":"Project mavenization","user":{"login":"fpompermaier","id":3776037,"avatar_url":"https://avatars.githubusercontent.com/u/3776037?v=3","gravatar_id":"","url":"https://api.github.com/users/fpompermaier","html_url":"https://github.com/fpompermaier","followers_url":"https://api.github.com/users/fpompermaier/followers","following_url":"https://api.github.com/users/fpompermaier/following{/other_user}","gists_url":"https://api.github.com/users/fpompermaier/gists{/gist_id}","starred_url":"https://api.github.com/users/fpompermaier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpompermaier/subscriptions","organizations_url":"https://api.github.com/users/fpompermaier/orgs","repos_url":"https://api.github.com/users/fpompermaier/repos","events_url":"https://api.github.com/users/fpompermaier/events{/privacy}","received_events_url":"https://api.github.com/users/fpompermaier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-24T23:56:56Z","updated_at":"2016-02-25T11:27:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/milg0/onvif-java-lib/pulls/7","html_url":"https://github.com/milg0/onvif-java-lib/pull/7","diff_url":"https://github.com/milg0/onvif-java-lib/pull/7.diff","patch_url":"https://github.com/milg0/onvif-java-lib/pull/7.patch"},"body":"Here it is :+1: "},"comment":{"url":"https://api.github.com/repos/milg0/onvif-java-lib/issues/comments/188740372","html_url":"https://github.com/milg0/onvif-java-lib/pull/7#issuecomment-188740372","issue_url":"https://api.github.com/repos/milg0/onvif-java-lib/issues/7","id":188740372,"user":{"login":"milg0","id":389114,"avatar_url":"https://avatars.githubusercontent.com/u/389114?v=3","gravatar_id":"","url":"https://api.github.com/users/milg0","html_url":"https://github.com/milg0","followers_url":"https://api.github.com/users/milg0/followers","following_url":"https://api.github.com/users/milg0/following{/other_user}","gists_url":"https://api.github.com/users/milg0/gists{/gist_id}","starred_url":"https://api.github.com/users/milg0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milg0/subscriptions","organizations_url":"https://api.github.com/users/milg0/orgs","repos_url":"https://api.github.com/users/milg0/repos","events_url":"https://api.github.com/users/milg0/events{/privacy}","received_events_url":"https://api.github.com/users/milg0/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T11:27:23Z","updated_at":"2016-02-25T11:27:23Z","body":"Too many changes to overview and your code is not usable (it works with your local paths, e.g. wsdlLocation = \"file:/home/flavio/workspace_bosc/onvif/onvif-ws-client/src/main/cxf/ver10/device/wsdl/devicemgmt.wsdl\").\r\n\r\nThe code is without any documentation and not maintainable. It replaces my complete code, so it's not compatible to old code.\r\n\r\nAnd I must admit, I don't understand your use of the wsdl files.\r\n\r\nYour WS Discovery does use the ip address 239.255.255.250, where does that ip come from? You have also set a default configuration for the user \"admin\", not every device with an admin-user does work with your password. You are not supporting any error handeling.\r\n\r\nYour code makes the code more complicated for newbies, not easier.\r\n\r\nSupporting maven is a good idea and there are also reasons for a more flexible code. But the code must be working, readable and maintainable. I don't even see a reason for you to send a pull request, you just kept two classes and you did change one of these a lot."}}