{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8055","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8055/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8055/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8055/events","html_url":"https://github.com/nodejs/node/pull/8055","id":170497323,"number":8055,"title":"tls: copy the Buffer object before using","user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/tls","name":"tls","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-10T19:22:22Z","updated_at":"2016-08-11T17:53:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8055","html_url":"https://github.com/nodejs/node/pull/8055","diff_url":"https://github.com/nodejs/node/pull/8055.diff","patch_url":"https://github.com/nodejs/node/pull/8055.patch"},"body":"##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ntls\r\n\r\n##### Description of change\r\n\r\n`convertNPNProtocols` uses the `protocols` buffer object as it is, and\r\nif it is modified outside of core, it might have an impact. This patch\r\nmakes a copy of the buffer object, before using it.\r\n\r\n---\r\n\r\ncc @nodejs/crypto "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/239238558","html_url":"https://github.com/nodejs/node/pull/8055#issuecomment-239238558","issue_url":"https://api.github.com/repos/nodejs/node/issues/8055","id":239238558,"user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T17:53:53Z","updated_at":"2016-08-11T17:53:53Z","body":"Oh, you might want to update the commit log to also mention convertALPNProtocols()."}}
{"actor":{"display_login":"bnoordhuis"}}