{"action":"opened","number":732,"pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/732","id":77291169,"html_url":"https://github.com/jitsi/jitsi-meet/pull/732","diff_url":"https://github.com/jitsi/jitsi-meet/pull/732.diff","patch_url":"https://github.com/jitsi/jitsi-meet/pull/732.patch","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/732","number":732,"state":"open","locked":false,"title":"Fix keybord shortcut help for non qwerty keyboard (use H instead of ?)","user":{"login":"champtar","id":3536755,"avatar_url":"https://avatars.githubusercontent.com/u/3536755?v=3","gravatar_id":"","url":"https://api.github.com/users/champtar","html_url":"https://github.com/champtar","followers_url":"https://api.github.com/users/champtar/followers","following_url":"https://api.github.com/users/champtar/following{/other_user}","gists_url":"https://api.github.com/users/champtar/gists{/gist_id}","starred_url":"https://api.github.com/users/champtar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/champtar/subscriptions","organizations_url":"https://api.github.com/users/champtar/orgs","repos_url":"https://api.github.com/users/champtar/repos","events_url":"https://api.github.com/users/champtar/events{/privacy}","received_events_url":"https://api.github.com/users/champtar/received_events","type":"User","site_admin":false},"body":"KeyboardEvent is a mess.\r\n\r\nKeyboardEvent.which gives you, in theory, a decimal representation of the key pressed.\r\n\"r\" or \"R\" gives you 82, which is \"R\", you can look at KeyboardEvent.shiftKey,\r\nbut you don't have access to capslock...\r\n\r\nMaybe you want to use numbers, but of course NumPad will not give you the same than\r\n\"normal\" numbers ...\r\n\r\nNow if you use something else than letter, for exemple \"?\",\r\non a QWERTY keyboard \"/\" and \"?\" gives you 191,\r\non a AZERTY keyboard \",\" and \"?\" gives you 188, so we have to stick to letters.\r\n\r\nThis was for keydown and keyup events, keypressed event return the real char\r\n(lower \"a\", \"/\", \"?\", ...) but it fails in some cases\r\n\r\nThe only non broken property is KeyboardEvent.key,\r\nbut it's only supported since Chrome 51, Opera 38, and not supported by Safari\r\nhttps://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key\r\n\r\nA good reference & test:\r\nhttp://unixpapa.com/js/testkey.html\r\nhttp://unixpapa.com/js/key.html\r\n\r\nSigned-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>","created_at":"2016-07-13T13:44:55Z","updated_at":"2016-07-13T13:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/732/commits","review_comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/732/comments","review_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/732/comments","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/32af39238e889bc842d75ee2301559af4aa7e3c8","head":{"label":"champtar:shortcut-help","ref":"shortcut-help","sha":"32af39238e889bc842d75ee2301559af4aa7e3c8","user":{"login":"champtar","id":3536755,"avatar_url":"https://avatars.githubusercontent.com/u/3536755?v=3","gravatar_id":"","url":"https://api.github.com/users/champtar","html_url":"https://github.com/champtar","followers_url":"https://api.github.com/users/champtar/followers","following_url":"https://api.github.com/users/champtar/following{/other_user}","gists_url":"https://api.github.com/users/champtar/gists{/gist_id}","starred_url":"https://api.github.com/users/champtar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/champtar/subscriptions","organizations_url":"https://api.github.com/users/champtar/orgs","repos_url":"https://api.github.com/users/champtar/repos","events_url":"https://api.github.com/users/champtar/events{/privacy}","received_events_url":"https://api.github.com/users/champtar/received_events","type":"User","site_admin":false},"repo":{"id":50513845,"name":"jitsi-meet","full_name":"champtar/jitsi-meet","owner":{"login":"champtar","id":3536755,"avatar_url":"https://avatars.githubusercontent.com/u/3536755?v=3","gravatar_id":"","url":"https://api.github.com/users/champtar","html_url":"https://github.com/champtar","followers_url":"https://api.github.com/users/champtar/followers","following_url":"https://api.github.com/users/champtar/following{/other_user}","gists_url":"https://api.github.com/users/champtar/gists{/gist_id}","starred_url":"https://api.github.com/users/champtar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/champtar/subscriptions","organizations_url":"https://api.github.com/users/champtar/orgs","repos_url":"https://api.github.com/users/champtar/repos","events_url":"https://api.github.com/users/champtar/events{/privacy}","received_events_url":"https://api.github.com/users/champtar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/champtar/jitsi-meet","description":"Jitsi Videobridge meets WebRTC","fork":true,"url":"https://api.github.com/repos/champtar/jitsi-meet","forks_url":"https://api.github.com/repos/champtar/jitsi-meet/forks","keys_url":"https://api.github.com/repos/champtar/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/champtar/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/champtar/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/champtar/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/champtar/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/champtar/jitsi-meet/events","assignees_url":"https://api.github.com/repos/champtar/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/champtar/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/champtar/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/champtar/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/champtar/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/champtar/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/champtar/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/champtar/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/champtar/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/champtar/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/champtar/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/champtar/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/champtar/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/champtar/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/champtar/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/champtar/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/champtar/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/champtar/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/champtar/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/champtar/jitsi-meet/merges","archive_url":"https://api.github.com/repos/champtar/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/champtar/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/champtar/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/champtar/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/champtar/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/champtar/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/champtar/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/champtar/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/champtar/jitsi-meet/deployments","created_at":"2016-01-27T14:43:27Z","updated_at":"2016-01-27T14:43:29Z","pushed_at":"2016-07-13T13:44:07Z","git_url":"git://github.com/champtar/jitsi-meet.git","ssh_url":"git@github.com:champtar/jitsi-meet.git","clone_url":"https://github.com/champtar/jitsi-meet.git","svn_url":"https://github.com/champtar/jitsi-meet","homepage":"https://jitsi.org/Projects/JitsiMeet","size":19124,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"3ed1532f253cba872a78efe34a8750e60b41bb71","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Videobridge meets WebRTC","fork":true,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet/deployments","created_at":"2013-12-16T12:51:09Z","updated_at":"2016-07-13T04:39:07Z","pushed_at":"2016-07-13T11:05:45Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/Projects/JitsiMeet","size":21951,"stargazers_count":621,"watchers_count":621,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":160,"forks":275,"open_issues":160,"watchers":621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/732"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/732"},"issue":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/732"},"comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/732/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/732/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/732/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/32af39238e889bc842d75ee2301559af4aa7e3c8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"champtar"}}