{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/70144463","id":70144463,"diff_hunk":"@@ -54,3 +54,10 @@ type CgroupManager interface {\n \t// Update cgroup configuration.\n \tUpdate(*CgroupConfig) error\n }\n+\n+// QOSContainersInfo hold the names of containers per qos\n+type QOSContainersInfo struct {","path":"pkg/kubelet/cm/types.go","position":6,"original_position":6,"commit_id":"8134b9de63922520d329b09348c13f5cc110507e","original_commit_id":"8134b9de63922520d329b09348c13f5cc110507e","user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"body":"@vishh - we should think about returning summary stats per qos tier in kubelet summary api","created_at":"2016-07-08T21:34:33Z","updated_at":"2016-07-08T21:34:33Z","html_url":"https://github.com/kubernetes/kubernetes/pull/27853#discussion_r70144463","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/70144463"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27853#discussion_r70144463"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853","id":74761537,"html_url":"https://github.com/kubernetes/kubernetes/pull/27853","diff_url":"https://github.com/kubernetes/kubernetes/pull/27853.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27853.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27853","number":27853,"state":"open","locked":false,"title":"[Kubelet] Improving QOS in kubelet by introducing QoS level Cgroups - `--cgroup-per-qos`","user":{"login":"dubstack","id":6484332,"avatar_url":"https://avatars.githubusercontent.com/u/6484332?v=3","gravatar_id":"","url":"https://api.github.com/users/dubstack","html_url":"https://github.com/dubstack","followers_url":"https://api.github.com/users/dubstack/followers","following_url":"https://api.github.com/users/dubstack/following{/other_user}","gists_url":"https://api.github.com/users/dubstack/gists{/gist_id}","starred_url":"https://api.github.com/users/dubstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubstack/subscriptions","organizations_url":"https://api.github.com/users/dubstack/orgs","repos_url":"https://api.github.com/users/dubstack/repos","events_url":"https://api.github.com/users/dubstack/events{/privacy}","received_events_url":"https://api.github.com/users/dubstack/received_events","type":"User","site_admin":false},"body":"This PR is tied to this upstream issue #27204 \r\nPlease note that only the last commit is unique to this PR. The first two commits are from previous PR's.\r\n\r\nIt introduces a new flag in the Kubelet which can be used to specify if the user wants to use the QoS cgroup hierarchy. \r\n\r\ncc @kubernetes/sig-node","created_at":"2016-06-22T10:42:31Z","updated_at":"2016-07-08T21:34:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"192c4c03f52e19f26b92c3a38f105fd2487aec71","assignee":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"assignees":[{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27853/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8134b9de63922520d329b09348c13f5cc110507e","head":{"label":"dubstack:dubstack-inject-qos-creation2","ref":"dubstack-inject-qos-creation2","sha":"8134b9de63922520d329b09348c13f5cc110507e","user":{"login":"dubstack","id":6484332,"avatar_url":"https://avatars.githubusercontent.com/u/6484332?v=3","gravatar_id":"","url":"https://api.github.com/users/dubstack","html_url":"https://github.com/dubstack","followers_url":"https://api.github.com/users/dubstack/followers","following_url":"https://api.github.com/users/dubstack/following{/other_user}","gists_url":"https://api.github.com/users/dubstack/gists{/gist_id}","starred_url":"https://api.github.com/users/dubstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubstack/subscriptions","organizations_url":"https://api.github.com/users/dubstack/orgs","repos_url":"https://api.github.com/users/dubstack/repos","events_url":"https://api.github.com/users/dubstack/events{/privacy}","received_events_url":"https://api.github.com/users/dubstack/received_events","type":"User","site_admin":false},"repo":{"id":57923446,"name":"kubernetes","full_name":"dubstack/kubernetes","owner":{"login":"dubstack","id":6484332,"avatar_url":"https://avatars.githubusercontent.com/u/6484332?v=3","gravatar_id":"","url":"https://api.github.com/users/dubstack","html_url":"https://github.com/dubstack","followers_url":"https://api.github.com/users/dubstack/followers","following_url":"https://api.github.com/users/dubstack/following{/other_user}","gists_url":"https://api.github.com/users/dubstack/gists{/gist_id}","starred_url":"https://api.github.com/users/dubstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubstack/subscriptions","organizations_url":"https://api.github.com/users/dubstack/orgs","repos_url":"https://api.github.com/users/dubstack/repos","events_url":"https://api.github.com/users/dubstack/events{/privacy}","received_events_url":"https://api.github.com/users/dubstack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dubstack/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/dubstack/kubernetes","forks_url":"https://api.github.com/repos/dubstack/kubernetes/forks","keys_url":"https://api.github.com/repos/dubstack/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dubstack/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dubstack/kubernetes/teams","hooks_url":"https://api.github.com/repos/dubstack/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dubstack/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dubstack/kubernetes/events","assignees_url":"https://api.github.com/repos/dubstack/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dubstack/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dubstack/kubernetes/tags","blobs_url":"https://api.github.com/repos/dubstack/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dubstack/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dubstack/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dubstack/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dubstack/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dubstack/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dubstack/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dubstack/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dubstack/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dubstack/kubernetes/subscription","commits_url":"https://api.github.com/repos/dubstack/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dubstack/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dubstack/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dubstack/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dubstack/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dubstack/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dubstack/kubernetes/merges","archive_url":"https://api.github.com/repos/dubstack/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dubstack/kubernetes/downloads","issues_url":"https://api.github.com/repos/dubstack/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dubstack/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dubstack/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dubstack/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dubstack/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dubstack/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dubstack/kubernetes/deployments","created_at":"2016-05-02T21:46:26Z","updated_at":"2016-05-02T21:46:41Z","pushed_at":"2016-07-08T20:52:51Z","git_url":"git://github.com/dubstack/kubernetes.git","ssh_url":"git@github.com:dubstack/kubernetes.git","clone_url":"https://github.com/dubstack/kubernetes.git","svn_url":"https://github.com/dubstack/kubernetes","homepage":"http://kubernetes.io","size":278668,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f83f21f399e41aad78676e9b8e511e918778a6c0","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-08T21:08:19Z","pushed_at":"2016-07-08T21:28:01Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":489050,"stargazers_count":15392,"watchers_count":15392,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4823,"mirror_url":null,"open_issues_count":3891,"forks":4823,"open_issues":3891,"watchers":15392,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/27853"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27853"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/27853/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27853/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8134b9de63922520d329b09348c13f5cc110507e"}}}}
{"actor":{"display_login":"derekwaynecarr"}}