{"action":"created","issue":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/955","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/955/labels{/name}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/955/comments","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/955/events","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/955","id":127936626,"number":955,"title":"add -o StrictHostKeyChecking no","user":{"login":"MalloZup","id":10886597,"avatar_url":"https://avatars.githubusercontent.com/u/10886597?v=3","gravatar_id":"","url":"https://api.github.com/users/MalloZup","html_url":"https://github.com/MalloZup","followers_url":"https://api.github.com/users/MalloZup/followers","following_url":"https://api.github.com/users/MalloZup/following{/other_user}","gists_url":"https://api.github.com/users/MalloZup/gists{/gist_id}","starred_url":"https://api.github.com/users/MalloZup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalloZup/subscriptions","organizations_url":"https://api.github.com/users/MalloZup/orgs","repos_url":"https://api.github.com/users/MalloZup/repos","events_url":"https://api.github.com/users/MalloZup/events{/privacy}","received_events_url":"https://api.github.com/users/MalloZup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2016-01-21T14:33:23Z","updated_at":"2016-01-24T07:53:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/955","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/955","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/955.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/955.patch"},"body":"since in previous test sshd connect already to ssh, we use this flags of ssh  to avoid typing yes, and make the test more stable.\r\n\r\nreplace wait_idle with,  wait_still_screen();  because wait_idle is no safer for the test.\r\n\r\nsince in the actually status of test, we type 2 times passwd: one time \"yes\", and 2nd the real pwd.\r\n\r\nIn future, it will be more sure to test with a rsa key. this taks was already tracked on tickets opensuse. \r\n\r\nCommit tested with SLE, reviewed on Opensuse (not tested, but same behaviour)\r\n"},"comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments/174265663","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/955#issuecomment-174265663","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/955","id":174265663,"user":{"login":"okurz","id":1693432,"avatar_url":"https://avatars.githubusercontent.com/u/1693432?v=3","gravatar_id":"","url":"https://api.github.com/users/okurz","html_url":"https://github.com/okurz","followers_url":"https://api.github.com/users/okurz/followers","following_url":"https://api.github.com/users/okurz/following{/other_user}","gists_url":"https://api.github.com/users/okurz/gists{/gist_id}","starred_url":"https://api.github.com/users/okurz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okurz/subscriptions","organizations_url":"https://api.github.com/users/okurz/orgs","repos_url":"https://api.github.com/users/okurz/repos","events_url":"https://api.github.com/users/okurz/events{/privacy}","received_events_url":"https://api.github.com/users/okurz/received_events","type":"User","site_admin":false},"created_at":"2016-01-24T07:53:18Z","updated_at":"2016-01-24T07:53:18Z","body":"I will give you a full example of how the git commit message could look like:\r\n```\r\nMake ssh X-forward password typing robust\r\n\r\nMake sure there is a process establishing a loopback ssh connection\r\nbefore typing the password avoiding wait_idle or any race condition.\r\n\r\nAlso add flag \"StrictHostKeyChecking\" to avoid the accept dialog\r\nfor the key which would only appear if the key was not accepted\r\nin before by other tests, e.g. the console tests testing sshd when\r\navailable.\r\n\r\nFixes https://progress.opensuse.org/issues/5346\r\n```\r\n\r\nAs you are at it: Can you replace the sleeps? I consider a sleep\r\nalso broken when it is assumed some condition has changed\r\nafterwards. Either it is not necessary at all or we should rather\r\nuse one of \"wait_serial\", \"wait_screen_change\", \"assert_screen\", \"check_screen\"."}}