{"action":"created","issue":{"url":"https://api.github.com/repos/matthiasbeyer/imag/issues/384","repository_url":"https://api.github.com/repos/matthiasbeyer/imag","labels_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/384/labels{/name}","comments_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/384/comments","events_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/384/events","html_url":"https://github.com/matthiasbeyer/imag/pull/384","id":152665006,"number":384,"title":"fixed some clippy warnings","user":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/matthiasbeyer/imag/labels/kind/enhancement","name":"kind/enhancement","color":"eb6420"},{"url":"https://api.github.com/repos/matthiasbeyer/imag/labels/kind/infrastructure","name":"kind/infrastructure","color":"eb6420"},{"url":"https://api.github.com/repos/matthiasbeyer/imag/labels/kind/refactor","name":"kind/refactor","color":"eb6420"},{"url":"https://api.github.com/repos/matthiasbeyer/imag/labels/meta/ready","name":"meta/ready","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2016-05-02T23:00:34Z","updated_at":"2016-05-05T10:08:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matthiasbeyer/imag/pulls/384","html_url":"https://github.com/matthiasbeyer/imag/pull/384","diff_url":"https://github.com/matthiasbeyer/imag/pull/384.diff","patch_url":"https://github.com/matthiasbeyer/imag/pull/384.patch"},"body":"Those are mostly style nits, but some things may even improve performance (like use of the `Entry` API or `Cow<'a, str>` instead of copying `String`s around)."},"comment":{"url":"https://api.github.com/repos/matthiasbeyer/imag/issues/comments/217117549","html_url":"https://github.com/matthiasbeyer/imag/pull/384#issuecomment-217117549","issue_url":"https://api.github.com/repos/matthiasbeyer/imag/issues/384","id":217117549,"user":{"login":"matthiasbeyer","id":427866,"avatar_url":"https://avatars.githubusercontent.com/u/427866?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiasbeyer","html_url":"https://github.com/matthiasbeyer","followers_url":"https://api.github.com/users/matthiasbeyer/followers","following_url":"https://api.github.com/users/matthiasbeyer/following{/other_user}","gists_url":"https://api.github.com/users/matthiasbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiasbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiasbeyer/subscriptions","organizations_url":"https://api.github.com/users/matthiasbeyer/orgs","repos_url":"https://api.github.com/users/matthiasbeyer/repos","events_url":"https://api.github.com/users/matthiasbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/matthiasbeyer/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T10:08:46Z","updated_at":"2016-05-05T10:08:46Z","body":"The point in rebasing is that you should never rewrite history where other people based work on. So generally: Don't rewrite history. For pull requests it is perfectly fine, and always if the maintainer of the project you request the pull to asks you to rewrite it."}}