{"action":"created","issue":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/484","repository_url":"https://api.github.com/repos/broadinstitute/rawls","labels_url":"https://api.github.com/repos/broadinstitute/rawls/issues/484/labels{/name}","comments_url":"https://api.github.com/repos/broadinstitute/rawls/issues/484/comments","events_url":"https://api.github.com/repos/broadinstitute/rawls/issues/484/events","html_url":"https://github.com/broadinstitute/rawls/pull/484","id":167445299,"number":484,"title":"GAWB-737: Stop using TEXT column type where possible","user":{"login":"MatthewBemis","id":7257391,"avatar_url":"https://avatars.githubusercontent.com/u/7257391?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewBemis","html_url":"https://github.com/MatthewBemis","followers_url":"https://api.github.com/users/MatthewBemis/followers","following_url":"https://api.github.com/users/MatthewBemis/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBemis/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBemis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBemis/subscriptions","organizations_url":"https://api.github.com/users/MatthewBemis/orgs","repos_url":"https://api.github.com/users/MatthewBemis/repos","events_url":"https://api.github.com/users/MatthewBemis/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBemis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-25T19:25:25Z","updated_at":"2016-07-25T19:25:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/broadinstitute/rawls/pulls/484","html_url":"https://github.com/broadinstitute/rawls/pull/484","diff_url":"https://github.com/broadinstitute/rawls/pull/484.diff","patch_url":"https://github.com/broadinstitute/rawls/pull/484.patch"},"body":"\r\n- [ ] **Submitter**: Rebase to develop. DO NOT SQUASH\r\n- [ ] **Submitter**: Make sure Swagger is updated if API changes\r\n- [ ] **Submitter**: Make sure documentation for code is complete\r\n- [ ] **Submitter**: Make sure liquibase is updated if appropriate\r\n- [ ] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs\r\n- [ ] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Add description or comments on the PR explaining the hows/whys (if not obvious)\r\n- [ ] **Submitter**: If PR includes new or changed db queries, include the explain plans in the description\r\n- [ ] Tell ![](http://i.imgur.com/9dLzbPd.png) that the PR exists if he wants to look at it **(apply requires_doge label)**\r\n- [ ] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n- [ ] **LR**: Initial review by LR and others.\r\n- [ ] Comment / review / update cycle:\r\n  * Rest of team may comments on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter updates documentation as needed\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH. **Reassign to LR** for further feedback\r\n- [ ] ![](http://i.imgur.com/9dLzbPd.png) sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Squash commits, rebase if necessary\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Merge to develop \r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: Check configuration files in Jenkins in case they need changes\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev environment still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via hipchat and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/broadinstitute/rawls/issues/comments/235057459","html_url":"https://github.com/broadinstitute/rawls/pull/484#issuecomment-235057459","issue_url":"https://api.github.com/repos/broadinstitute/rawls/issues/484","id":235057459,"user":{"login":"MatthewBemis","id":7257391,"avatar_url":"https://avatars.githubusercontent.com/u/7257391?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewBemis","html_url":"https://github.com/MatthewBemis","followers_url":"https://api.github.com/users/MatthewBemis/followers","following_url":"https://api.github.com/users/MatthewBemis/following{/other_user}","gists_url":"https://api.github.com/users/MatthewBemis/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewBemis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewBemis/subscriptions","organizations_url":"https://api.github.com/users/MatthewBemis/orgs","repos_url":"https://api.github.com/users/MatthewBemis/repos","events_url":"https://api.github.com/users/MatthewBemis/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewBemis/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T19:25:33Z","updated_at":"2016-07-25T19:25:33Z","body":"table_name|column_name|data_type|character_maximum_length|comments\r\n|--:|---|---|---|---|\r\nMETHOD_CONFIG_INPUT|VALUE|text|65535|reduced to varchar(254)|\r\nSUBMISSION_VALIDATION|ERROR_TEXT|text|65535|unchanged|\r\nMETHOD_CONFIG|METHOD_NAMESPACE|text|65535|reduced to varchar(254)|\r\nWORKFLOW|EXTERNAL_ID|text|65535|reduced to varchar(64) to match length of UUID text|\r\nMETHOD_CONFIG_OUTPUT|VALUE|text|65535|reduced to varchar(254)|\r\nSUBMISSION_ATTRIBUTE|value_string|text|65535|unchanged|\r\nWORKFLOW_MESSAGE|MESSAGE|text|65535|unchanged|\r\nSUBMISSION_VALIDATION|INPUT_NAME|text|65535|reduced to varchar(254)|\r\nMETHOD_CONFIG|METHOD_NAME|text|65535|reduced to varchar(254)|\r\nMETHOD_CONFIG_PREREQ|VALUE|text|65535|unchanged (table is unused)|\r\nWORKSPACE|created_by|text|65535|reduced to varchar(254) to match USER.SUBJECT_ID|\r\nENTITY_ATTRIBUTE|value_string|text|65535|unchanged|\r\nWORKSPACE|bucket_name|text|65535|reduced to varchar(128) to fit max bucket name length|\r\nENTITY|all_attribute_values|text|65535|unchanged|\r\nWORKSPACE_ATTRIBUTE|value_string|text|65535|unchanged|\r\nBILLING_PROJECT|CROMWELL_BUCKET_URL|text|65535|reduced to varchar(128) to fit max bucket name length|\r\nWORKFLOW_ERROR|ERROR_TEXT|text|65535|unchanged|\r\nMETHOD_CONFIG|ROOT_ENTITY_TYPE|text|65535||"}}
{"actor":{"display_login":"MatthewBemis"}}