{"action":"created","issue":{"url":"https://api.github.com/repos/ranger/ranger/issues/613","repository_url":"https://api.github.com/repos/ranger/ranger","labels_url":"https://api.github.com/repos/ranger/ranger/issues/613/labels{/name}","comments_url":"https://api.github.com/repos/ranger/ranger/issues/613/comments","events_url":"https://api.github.com/repos/ranger/ranger/issues/613/events","html_url":"https://github.com/ranger/ranger/issues/613","id":162878290,"number":613,"title":"Open terminal with additional options","user":{"login":"abrodkin","id":1618098,"avatar_url":"https://avatars.githubusercontent.com/u/1618098?v=3","gravatar_id":"","url":"https://api.github.com/users/abrodkin","html_url":"https://github.com/abrodkin","followers_url":"https://api.github.com/users/abrodkin/followers","following_url":"https://api.github.com/users/abrodkin/following{/other_user}","gists_url":"https://api.github.com/users/abrodkin/gists{/gist_id}","starred_url":"https://api.github.com/users/abrodkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrodkin/subscriptions","organizations_url":"https://api.github.com/users/abrodkin/orgs","repos_url":"https://api.github.com/users/abrodkin/repos","events_url":"https://api.github.com/users/abrodkin/events{/privacy}","received_events_url":"https://api.github.com/users/abrodkin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-06-29T09:19:14Z","updated_at":"2016-06-30T06:25:43Z","closed_at":null,"body":"I'd like to open new terminal from ranger (for example with command like ```:terminal```) but not in a separate window as it happens now but in a new tab (let's assume I use terminal that supports tabs like gnome-terminal, roxterm etc).\r\n\r\nFor example in case of roxterm it's possible to execute it like ```roxterm --tab``` and new tab will appear instead of new window.\r\n\r\nI tried to set TERMCMD to ```roxterm --tab```  but then ```xterm``` gets executed at all (I think that's because ```roxterm --tab``` could not be found in PATH by ```get_executables()```).\r\n\r\nAny thoughts on how that might be achieved?"},"comment":{"url":"https://api.github.com/repos/ranger/ranger/issues/comments/229570849","html_url":"https://github.com/ranger/ranger/issues/613#issuecomment-229570849","issue_url":"https://api.github.com/repos/ranger/ranger/issues/613","id":229570849,"user":{"login":"abrodkin","id":1618098,"avatar_url":"https://avatars.githubusercontent.com/u/1618098?v=3","gravatar_id":"","url":"https://api.github.com/users/abrodkin","html_url":"https://github.com/abrodkin","followers_url":"https://api.github.com/users/abrodkin/followers","following_url":"https://api.github.com/users/abrodkin/following{/other_user}","gists_url":"https://api.github.com/users/abrodkin/gists{/gist_id}","starred_url":"https://api.github.com/users/abrodkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrodkin/subscriptions","organizations_url":"https://api.github.com/users/abrodkin/orgs","repos_url":"https://api.github.com/users/abrodkin/repos","events_url":"https://api.github.com/users/abrodkin/events{/privacy}","received_events_url":"https://api.github.com/users/abrodkin/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T06:25:43Z","updated_at":"2016-06-30T06:25:43Z","body":"Hm, probably I'm doing something wrong.\r\nI cloned your ```vifon/open_terminal_with_options``` branch locally, see:\r\n```\r\ngit status \r\nOn branch open_terminal_with_options\r\nYour branch is up-to-date with 'vifon/open_terminal_with_options'.\r\nnothing to commit, working directory clean\r\n\r\ngit log --oneline -n 5\r\n58251ee Refactor and improve the TERMCMD handling\r\na9a75dd Merge branch 'import' of https://github.com/stepshal/ranger\r\ne11d698 Merge branch 'misspellings' of https://github.com/stepshal/ranger\r\n2390570 Fix misspellings\r\nfbdb5b4 Put imports on separate lines.\r\n```\r\n\r\nNow I set TERMCMD and run ```./ranger.py```\r\n```\r\nexport TERMCMD=\"roxterm --tab\"\r\n./ranger.py\r\n```\r\n\r\nBut for me behavior is the same as it used to be. If ```TERMCMD=\"roxterm --tab\"``` then ```xterm``` get started on ```:terminal``` command. If ```TERMCMD=roxterm``` then roxterm in a separate window appers.\r\n\r\nWhat looks strange to me I tried to add logging in get_term() or put a breakpoint in pdb in the same function but to no avail.\r\n\r\nTo make sure I'm not running something else I removed ranger installed in my distro but still behavior is the same.\r\n\r\nPlease pardon this noise but I'm very new to Python and probably I'm bumping into some obvious thing."}}
{"actor":{"display_login":"abrodkin"}}