{"push_id":1010304915,"size":1,"distinct_size":1,"ref":"refs/heads/apiserver-upgrade-in-progress","head":"d9316d28fb138ae226a23773ccb770bf937173a3","before":"3968058e68ec279f78dbd1e293c3620cfc13b782","commits":[{"sha":"d9316d28fb138ae226a23773ccb770bf937173a3","author":{"email":"bfcdf3e6ca6cef45543bfbb57509c92aec9a39fb@cheney.net","name":"Dave Cheney"},"message":"Angry rant time!\n\nUpgradeInProgressError used to be defined in apiserver/admin.go and used\nin apiserver/upgrading_root.go. __BUT__, the logic that turns errors\ninto rpc messages is inside apiserver/common/error.go. This creates a\npotential import loop as apiserver already imports common, so common\ncannot import apiserver to get a type.\n\nSo, to ~~solve~~ workaround this clusterfuck, we move\nUpgradeInProgressError to apiserver/params, which everyone imports and\nsolve the import loop.\n\nThis is _SHIT_. apiserver and apiserver/common are clearly the same\npackage, thay cannot function without each other and have been\nbifurcated for reasons that no longer make sense.\n\nOnce this PR is landed, I will merge the two packages and then we can\ndefine, and use UpgradeInProgressError in _one_ place, and then we can\nalso unexport it because things should not be checking for it explicitly\non that apiserver side of the blood/brain RPC layer.","distinct":true,"url":"https://api.github.com/repos/davecheney/juju/commits/d9316d28fb138ae226a23773ccb770bf937173a3"}]}