{"action":"created","issue":{"url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/18","repository_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl","labels_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/18/comments","events_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/18/events","html_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/18","id":177608323,"number":18,"title":"pooled vcat","user":{"login":"gustafsson","id":184952,"avatar_url":"https://avatars.githubusercontent.com/u/184952?v=3","gravatar_id":"","url":"https://api.github.com/users/gustafsson","html_url":"https://github.com/gustafsson","followers_url":"https://api.github.com/users/gustafsson/followers","following_url":"https://api.github.com/users/gustafsson/following{/other_user}","gists_url":"https://api.github.com/users/gustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/gustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustafsson/subscriptions","organizations_url":"https://api.github.com/users/gustafsson/orgs","repos_url":"https://api.github.com/users/gustafsson/repos","events_url":"https://api.github.com/users/gustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/gustafsson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-09-17T20:55:32Z","updated_at":"2016-09-26T11:14:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/pulls/18","html_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/18","diff_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/18.diff","patch_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/18.patch"},"body":"This PR introduces three features:\r\n\r\n1. vcat compares the unique elements in the pools only once instead of comparing each new inserted element to the accumulated pool. This is more efficient for large arrays with small pools. The translation between the individual pools and the total pool is then an O(1) operation.\r\n2. vcat on compact arrays may overflow. Here I'm always expanding the reftype to `DefaultRefType`. I figure you'd prefer to keep compact arrays if possible but I don't know how to do that without introducing type instability.\r\n3. For ordered levels vcat preserves the order based on the first argument. If the other arguments are ordered and doesn't comply, or if they have levels not included in the order defined by the first argument; then the returned array won't have ordered levels and a warning is shown that the ordering is dropped.\r\n\r\nRelated to https://github.com/JuliaStats/DataArrays.jl/pull/213"},"comment":{"url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/comments/249542791","html_url":"https://github.com/nalimilan/CategoricalArrays.jl/pull/18#issuecomment-249542791","issue_url":"https://api.github.com/repos/nalimilan/CategoricalArrays.jl/issues/18","id":249542791,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T11:14:45Z","updated_at":"2016-09-26T11:14:45Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8048328/badge)](https://coveralls.io/builds/8048328)\n\nCoverage increased (+0.8%) to 84.68% when pulling **c73959a1c102e0ffbeb6d0427d7f92a332499ad4 on gustafsson:pooledvcat** into **b176bb45f0f9017d8845d5d6bd7e850978ab6b3a on nalimilan:master**.\n"}}
{"actor":{"display_login":"coveralls"}}