{"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/49429610","id":49429610,"diff_hunk":"@@ -218,7 +231,27 @@ define([\n     this.$el.removeClass(this.config.visibleClassName);\n     this.closeButton.addClass(this.config.closedClassName);\n     this._setListeners(false);\n+    if (this._previousFocusElement) {\n+      this._previousFocusElement.focus();  \n+    }\n   };\n \n+  /*\n+  * Handle the tab event on the last and first focusable element -\n+  * a tab loop is created until the user dismisses the dialog (accessibility recommendation).\n+   */\n+  NewsletterSticky.prototype._handleLastElementTab = function(e) {\n+    if (e.which === TAB_KEY && !e.shiftKey) {\n+      e.preventDefault();\n+      this._firstFocusElement.focus();\n+    }\n+  }\n+  NewsletterSticky.prototype._handleFirstElementTab = function(e) {\n+    if (e.which === TAB_KEY && e.shiftKey) {","path":"app/assets/javascripts/components/NewsletterSticky.js","position":71,"original_position":71,"commit_id":"5baf0bd4ca2ef17ae1fae78b1c2170567fbc9522","original_commit_id":"5baf0bd4ca2ef17ae1fae78b1c2170567fbc9522","user":{"login":"mconnell","id":32398,"avatar_url":"https://avatars.githubusercontent.com/u/32398?v=3","gravatar_id":"","url":"https://api.github.com/users/mconnell","html_url":"https://github.com/mconnell","followers_url":"https://api.github.com/users/mconnell/followers","following_url":"https://api.github.com/users/mconnell/following{/other_user}","gists_url":"https://api.github.com/users/mconnell/gists{/gist_id}","starred_url":"https://api.github.com/users/mconnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mconnell/subscriptions","organizations_url":"https://api.github.com/users/mconnell/orgs","repos_url":"https://api.github.com/users/mconnell/repos","events_url":"https://api.github.com/users/mconnell/events{/privacy}","received_events_url":"https://api.github.com/users/mconnell/received_events","type":"User","site_admin":false},"body":"#TodayILearned There's a shiftKey function on Event. ","created_at":"2016-01-12T09:13:59Z","updated_at":"2016-01-12T09:13:59Z","html_url":"https://github.com/moneyadviceservice/frontend/pull/1345#discussion_r49429610","pull_request_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/49429610"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/1345#discussion_r49429610"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345","id":54998901,"html_url":"https://github.com/moneyadviceservice/frontend/pull/1345","diff_url":"https://github.com/moneyadviceservice/frontend/pull/1345.diff","patch_url":"https://github.com/moneyadviceservice/frontend/pull/1345.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1345","number":1345,"state":"open","locked":false,"title":"#6793 Accessibility updates to the sticky footer","user":{"login":"slaywell","id":14920201,"avatar_url":"https://avatars.githubusercontent.com/u/14920201?v=3","gravatar_id":"","url":"https://api.github.com/users/slaywell","html_url":"https://github.com/slaywell","followers_url":"https://api.github.com/users/slaywell/followers","following_url":"https://api.github.com/users/slaywell/following{/other_user}","gists_url":"https://api.github.com/users/slaywell/gists{/gist_id}","starred_url":"https://api.github.com/users/slaywell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slaywell/subscriptions","organizations_url":"https://api.github.com/users/slaywell/orgs","repos_url":"https://api.github.com/users/slaywell/repos","events_url":"https://api.github.com/users/slaywell/events{/privacy}","received_events_url":"https://api.github.com/users/slaywell/received_events","type":"User","site_admin":false},"body":"Addressing the following accessibility recommendations (see TP ticket for details) \r\n\r\n* Adding aria roles for dialog and labelledby\r\n* Setting keyboard focus when it loads\r\n* Creating a closed tab loop for the fields within it\r\n* Returning keyboard focus to the page when it is closed","created_at":"2016-01-04T17:18:45Z","updated_at":"2016-01-12T09:13:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b27fa345c53c26853b580494a141d96e5e5e48a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1345/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/5baf0bd4ca2ef17ae1fae78b1c2170567fbc9522","head":{"label":"moneyadviceservice:6793-footer-accessibility","ref":"6793-footer-accessibility","sha":"5baf0bd4ca2ef17ae1fae78b1c2170567fbc9522","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2015-09-25T09:51:52Z","pushed_at":"2016-01-11T16:21:57Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":25620,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":19,"forks":6,"open_issues":19,"watchers":5,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"0875a774728a00c6ca543493665c2de2f3154f71","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2015-09-25T09:51:52Z","pushed_at":"2016-01-11T16:21:57Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":25620,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":19,"forks":6,"open_issues":19,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/1345"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1345"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1345/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1345/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/5baf0bd4ca2ef17ae1fae78b1c2170567fbc9522"}}}}