{"action":"closed","number":246,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-security/pulls/246","id":53985683,"html_url":"https://github.com/spring-projects/spring-security/pull/246","diff_url":"https://github.com/spring-projects/spring-security/pull/246.diff","patch_url":"https://github.com/spring-projects/spring-security/pull/246.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-security/issues/246","number":246,"state":"closed","locked":false,"title":"AD-bind-principal: New abstraction for ActiveDirectory LDAP auth","user":{"login":"Turbots","id":1653600,"avatar_url":"https://avatars.githubusercontent.com/u/1653600?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbots","html_url":"https://github.com/Turbots","followers_url":"https://api.github.com/users/Turbots/followers","following_url":"https://api.github.com/users/Turbots/following{/other_user}","gists_url":"https://api.github.com/users/Turbots/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbots/subscriptions","organizations_url":"https://api.github.com/users/Turbots/orgs","repos_url":"https://api.github.com/users/Turbots/repos","events_url":"https://api.github.com/users/Turbots/events{/privacy}","received_events_url":"https://api.github.com/users/Turbots/received_events","type":"User","site_admin":false},"body":"Most use cases don't require another implementation than the standard\r\nway of binding and searching for a user in Active Directory.\r\n\r\nHowever, sometimes there is a different implementation needed\r\nfor creating the principal string for **binding a user** and the principal\r\nstring for **searching a user**.\r\n\r\nThe new abstract class basically contains the same methods\r\nas the old final class and **contains two abstract methods**\r\nfor creating a *bindPrincipal* and *searchPrincipal* string, respectively.\r\n\r\nThe new abstract class allows for users to create a **different**\r\nimplementation according to their needs, **based on the given\r\nauthentication token** (or a subclass of the authentication token).","created_at":"2015-12-17T14:55:10Z","updated_at":"2016-09-19T18:43:09Z","closed_at":"2016-09-19T18:43:09Z","merged_at":null,"merge_commit_sha":"a2e457e4c4ed57c8ece3a61991b81c6b8e933bc5","assignee":{"login":"jgrandja","id":10884212,"avatar_url":"https://avatars.githubusercontent.com/u/10884212?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrandja","html_url":"https://github.com/jgrandja","followers_url":"https://api.github.com/users/jgrandja/followers","following_url":"https://api.github.com/users/jgrandja/following{/other_user}","gists_url":"https://api.github.com/users/jgrandja/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrandja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrandja/subscriptions","organizations_url":"https://api.github.com/users/jgrandja/orgs","repos_url":"https://api.github.com/users/jgrandja/repos","events_url":"https://api.github.com/users/jgrandja/events{/privacy}","received_events_url":"https://api.github.com/users/jgrandja/received_events","type":"User","site_admin":false},"assignees":[{"login":"jgrandja","id":10884212,"avatar_url":"https://avatars.githubusercontent.com/u/10884212?v=3","gravatar_id":"","url":"https://api.github.com/users/jgrandja","html_url":"https://github.com/jgrandja","followers_url":"https://api.github.com/users/jgrandja/followers","following_url":"https://api.github.com/users/jgrandja/following{/other_user}","gists_url":"https://api.github.com/users/jgrandja/gists{/gist_id}","starred_url":"https://api.github.com/users/jgrandja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgrandja/subscriptions","organizations_url":"https://api.github.com/users/jgrandja/orgs","repos_url":"https://api.github.com/users/jgrandja/repos","events_url":"https://api.github.com/users/jgrandja/events{/privacy}","received_events_url":"https://api.github.com/users/jgrandja/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-security/milestones/86","html_url":"https://github.com/spring-projects/spring-security/milestones/4.2.0%20M1","labels_url":"https://api.github.com/repos/spring-projects/spring-security/milestones/86/labels","id":1713972,"number":86,"title":"4.2.0 M1","description":"","creator":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":47,"state":"open","created_at":"2016-04-18T14:48:35Z","updated_at":"2016-09-19T18:43:09Z","due_on":"2016-09-20T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/246/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/246/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/issues/246/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-security/statuses/7a9d59f64f7500f5c98bf1249da7b1fbe1251e27","head":{"label":"Turbots:AD-bind-principal","ref":"AD-bind-principal","sha":"7a9d59f64f7500f5c98bf1249da7b1fbe1251e27","user":{"login":"Turbots","id":1653600,"avatar_url":"https://avatars.githubusercontent.com/u/1653600?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbots","html_url":"https://github.com/Turbots","followers_url":"https://api.github.com/users/Turbots/followers","following_url":"https://api.github.com/users/Turbots/following{/other_user}","gists_url":"https://api.github.com/users/Turbots/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbots/subscriptions","organizations_url":"https://api.github.com/users/Turbots/orgs","repos_url":"https://api.github.com/users/Turbots/repos","events_url":"https://api.github.com/users/Turbots/events{/privacy}","received_events_url":"https://api.github.com/users/Turbots/received_events","type":"User","site_admin":false},"repo":{"id":48174978,"name":"spring-security","full_name":"Turbots/spring-security","owner":{"login":"Turbots","id":1653600,"avatar_url":"https://avatars.githubusercontent.com/u/1653600?v=3","gravatar_id":"","url":"https://api.github.com/users/Turbots","html_url":"https://github.com/Turbots","followers_url":"https://api.github.com/users/Turbots/followers","following_url":"https://api.github.com/users/Turbots/following{/other_user}","gists_url":"https://api.github.com/users/Turbots/gists{/gist_id}","starred_url":"https://api.github.com/users/Turbots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turbots/subscriptions","organizations_url":"https://api.github.com/users/Turbots/orgs","repos_url":"https://api.github.com/users/Turbots/repos","events_url":"https://api.github.com/users/Turbots/events{/privacy}","received_events_url":"https://api.github.com/users/Turbots/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Turbots/spring-security","description":"","fork":true,"url":"https://api.github.com/repos/Turbots/spring-security","forks_url":"https://api.github.com/repos/Turbots/spring-security/forks","keys_url":"https://api.github.com/repos/Turbots/spring-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Turbots/spring-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Turbots/spring-security/teams","hooks_url":"https://api.github.com/repos/Turbots/spring-security/hooks","issue_events_url":"https://api.github.com/repos/Turbots/spring-security/issues/events{/number}","events_url":"https://api.github.com/repos/Turbots/spring-security/events","assignees_url":"https://api.github.com/repos/Turbots/spring-security/assignees{/user}","branches_url":"https://api.github.com/repos/Turbots/spring-security/branches{/branch}","tags_url":"https://api.github.com/repos/Turbots/spring-security/tags","blobs_url":"https://api.github.com/repos/Turbots/spring-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Turbots/spring-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Turbots/spring-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/Turbots/spring-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Turbots/spring-security/statuses/{sha}","languages_url":"https://api.github.com/repos/Turbots/spring-security/languages","stargazers_url":"https://api.github.com/repos/Turbots/spring-security/stargazers","contributors_url":"https://api.github.com/repos/Turbots/spring-security/contributors","subscribers_url":"https://api.github.com/repos/Turbots/spring-security/subscribers","subscription_url":"https://api.github.com/repos/Turbots/spring-security/subscription","commits_url":"https://api.github.com/repos/Turbots/spring-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/Turbots/spring-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/Turbots/spring-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/Turbots/spring-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/Turbots/spring-security/contents/{+path}","compare_url":"https://api.github.com/repos/Turbots/spring-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Turbots/spring-security/merges","archive_url":"https://api.github.com/repos/Turbots/spring-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Turbots/spring-security/downloads","issues_url":"https://api.github.com/repos/Turbots/spring-security/issues{/number}","pulls_url":"https://api.github.com/repos/Turbots/spring-security/pulls{/number}","milestones_url":"https://api.github.com/repos/Turbots/spring-security/milestones{/number}","notifications_url":"https://api.github.com/repos/Turbots/spring-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Turbots/spring-security/labels{/name}","releases_url":"https://api.github.com/repos/Turbots/spring-security/releases{/id}","deployments_url":"https://api.github.com/repos/Turbots/spring-security/deployments","created_at":"2015-12-17T13:08:53Z","updated_at":"2015-12-17T13:08:59Z","pushed_at":"2015-12-17T14:54:39Z","git_url":"git://github.com/Turbots/spring-security.git","ssh_url":"git@github.com:Turbots/spring-security.git","clone_url":"https://github.com/Turbots/spring-security.git","svn_url":"https://github.com/Turbots/spring-security","homepage":"http://spring.io/spring-security","size":22058,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"519c15efb3941a47a90a3d6bca26ad9d281c5c24","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":3148979,"name":"spring-security","full_name":"spring-projects/spring-security","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-security","description":"Spring Security","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-security","forks_url":"https://api.github.com/repos/spring-projects/spring-security/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-security/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-security/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-security/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-security/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-security/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-security/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-security/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-security/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-security/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-security/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-security/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-security/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-security/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-security/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-security/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-security/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-security/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-security/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-security/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-security/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-security/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-security/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-security/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-security/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-security/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-security/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-security/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-security/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-security/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-security/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-security/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-security/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-security/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-security/deployments","created_at":"2012-01-10T21:50:57Z","updated_at":"2016-09-19T09:26:42Z","pushed_at":"2016-09-19T18:12:09Z","git_url":"git://github.com/spring-projects/spring-security.git","ssh_url":"git@github.com:spring-projects/spring-security.git","clone_url":"https://github.com/spring-projects/spring-security.git","svn_url":"https://github.com/spring-projects/spring-security","homepage":"http://spring.io/spring-security","size":30616,"stargazers_count":1303,"watchers_count":1303,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1611,"mirror_url":null,"open_issues_count":550,"forks":1611,"open_issues":550,"watchers":1303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/246"},"html":{"href":"https://github.com/spring-projects/spring-security/pull/246"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-security/issues/246"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-security/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-security/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-security/statuses/7a9d59f64f7500f5c98bf1249da7b1fbe1251e27"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":427,"deletions":370,"changed_files":2}}
{"actor":{"display_login":"jgrandja"}}