{"action":"created","comment":{"url":"https://api.github.com/repos/labrad/scalabrad/pulls/comments/73235111","id":73235111,"diff_hunk":"@@ -215,38 +228,57 @@ extends LocalServer with Logging {\n       data.convertTo(pattern)\n     }\n \n-    @Setting(id=30,\n-             name=\"set\",\n-             doc=\"Set the content of the given key in the current directory to the given data\")\n+    @Setting(id = 30,\n+             name = \"set\",\n+             doc = \"\"\"Set the given key in the current directory to the given value.\"\"\")\n     def setValue(key: String, value: Data): Unit = {\n       require(key.nonEmpty, \"Cannot create a key with empty name\")\n       store.setValue(curDir, key, value)\n     }\n \n-    @Setting(id=40,\n-             name=\"del\",\n-             doc=\"Delete the given key from the current directory\")\n+    @Setting(id = 40,\n+             name = \"del\",\n+             doc = \"\"\"Delete the given key from the current directory.\"\"\")\n     def delete(key: String): Unit = {\n       store.delete(curDir, key)\n     }\n \n-    @Setting(id=50,\n-             name=\"Notify on Change\",\n-             doc=\"Requests notifications if the contents of the current directory change\")\n+    @Setting(id = 50,\n+             name = \"Notify on Change\",\n+             doc = \"\"\"Requests notifications if the contents of the current directory change.\n+                 |\n+                 |Called with message id and a flag indicating whether notifications should be\n+                 |enabled or disabled. Notification messages will be sent to the given id in the\n+                 |context used when calling this setting. The message will be of the form\n+                 |(name, isDir, addOrChange), where name is the name of an item in the current\n+                 |directory, isDir is a boolean indicating whether the item is a directory (true) or\n+                 |key (false), and addOrChange is a boolean indicating whether the item was added or\n+                 |changed (true), or was deleted (false).\"\"\")\n     def notifyOnChange(r: RequestContext, id: Long, enable: Boolean): Unit = {\n       changeListener = if (enable) Some((r.source, id)) else None\n     }\n \n-    @Setting(id=55,\n-             name=\"Stream Changes\",\n-             doc=\"Requests notifications of all changes made in any directory\")\n+    @Setting(id = 55,\n+             name = \"Stream Changes\",\n+             doc = \"\"\"Requests notifications of all changes made in any directory.\n+                 |","path":"src/main/scala/org/labrad/registry/Registry.scala","position":136,"original_position":124,"commit_id":"aeba26ec6bc53ce53c6bdf94d36cb2b527d77641","original_commit_id":"0019f1aa3187091772d520d0d6bbd39ccc64fbc3","user":{"login":"ejeffrey","id":1690140,"avatar_url":"https://avatars.githubusercontent.com/u/1690140?v=3","gravatar_id":"","url":"https://api.github.com/users/ejeffrey","html_url":"https://github.com/ejeffrey","followers_url":"https://api.github.com/users/ejeffrey/followers","following_url":"https://api.github.com/users/ejeffrey/following{/other_user}","gists_url":"https://api.github.com/users/ejeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/ejeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejeffrey/subscriptions","organizations_url":"https://api.github.com/users/ejeffrey/orgs","repos_url":"https://api.github.com/users/ejeffrey/repos","events_url":"https://api.github.com/users/ejeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/ejeffrey/received_events","type":"User","site_admin":false},"body":"Yeah, all changes underneath the current path would be more useful, and could easily replicate the current behavior just by sitting in the root directory.","created_at":"2016-08-02T20:53:00Z","updated_at":"2016-08-02T20:53:00Z","html_url":"https://github.com/labrad/scalabrad/pull/66#discussion_r73235111","pull_request_url":"https://api.github.com/repos/labrad/scalabrad/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad/pulls/comments/73235111"},"html":{"href":"https://github.com/labrad/scalabrad/pull/66#discussion_r73235111"},"pull_request":{"href":"https://api.github.com/repos/labrad/scalabrad/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/labrad/scalabrad/pulls/66","id":79792449,"html_url":"https://github.com/labrad/scalabrad/pull/66","diff_url":"https://github.com/labrad/scalabrad/pull/66.diff","patch_url":"https://github.com/labrad/scalabrad/pull/66.patch","issue_url":"https://api.github.com/repos/labrad/scalabrad/issues/66","number":66,"state":"open","locked":false,"title":"Improve docstrings for manager, registry and auth server settings","user":{"login":"maffoo","id":129268,"avatar_url":"https://avatars.githubusercontent.com/u/129268?v=3","gravatar_id":"","url":"https://api.github.com/users/maffoo","html_url":"https://github.com/maffoo","followers_url":"https://api.github.com/users/maffoo/followers","following_url":"https://api.github.com/users/maffoo/following{/other_user}","gists_url":"https://api.github.com/users/maffoo/gists{/gist_id}","starred_url":"https://api.github.com/users/maffoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maffoo/subscriptions","organizations_url":"https://api.github.com/users/maffoo/orgs","repos_url":"https://api.github.com/users/maffoo/repos","events_url":"https://api.github.com/users/maffoo/events{/privacy}","received_events_url":"https://api.github.com/users/maffoo/received_events","type":"User","site_admin":false},"body":"@ejeffrey ","created_at":"2016-08-02T19:18:09Z","updated_at":"2016-08-02T20:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a3780f5173daa24d0eae70881dc72592dc37310","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/labrad/scalabrad/pulls/66/commits","review_comments_url":"https://api.github.com/repos/labrad/scalabrad/pulls/66/comments","review_comment_url":"https://api.github.com/repos/labrad/scalabrad/pulls/comments{/number}","comments_url":"https://api.github.com/repos/labrad/scalabrad/issues/66/comments","statuses_url":"https://api.github.com/repos/labrad/scalabrad/statuses/aeba26ec6bc53ce53c6bdf94d36cb2b527d77641","head":{"label":"labrad:u/maffoo/docstrings","ref":"u/maffoo/docstrings","sha":"aeba26ec6bc53ce53c6bdf94d36cb2b527d77641","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":2261953,"name":"scalabrad","full_name":"labrad/scalabrad","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad","description":"scala interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad","forks_url":"https://api.github.com/repos/labrad/scalabrad/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad/releases{/id}","deployments_url":"https://api.github.com/repos/labrad/scalabrad/deployments","created_at":"2011-08-24T14:08:56Z","updated_at":"2015-06-27T19:42:16Z","pushed_at":"2016-08-02T20:47:54Z","git_url":"git://github.com/labrad/scalabrad.git","ssh_url":"git@github.com:labrad/scalabrad.git","clone_url":"https://github.com/labrad/scalabrad.git","svn_url":"https://github.com/labrad/scalabrad","homepage":"","size":13178,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"labrad:master","ref":"master","sha":"ec9b7ef3acc3b184321ddd27982d68c092df5bd8","user":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"repo":{"id":2261953,"name":"scalabrad","full_name":"labrad/scalabrad","owner":{"login":"labrad","id":7157139,"avatar_url":"https://avatars.githubusercontent.com/u/7157139?v=3","gravatar_id":"","url":"https://api.github.com/users/labrad","html_url":"https://github.com/labrad","followers_url":"https://api.github.com/users/labrad/followers","following_url":"https://api.github.com/users/labrad/following{/other_user}","gists_url":"https://api.github.com/users/labrad/gists{/gist_id}","starred_url":"https://api.github.com/users/labrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/labrad/subscriptions","organizations_url":"https://api.github.com/users/labrad/orgs","repos_url":"https://api.github.com/users/labrad/repos","events_url":"https://api.github.com/users/labrad/events{/privacy}","received_events_url":"https://api.github.com/users/labrad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/labrad/scalabrad","description":"scala interface for labrad","fork":false,"url":"https://api.github.com/repos/labrad/scalabrad","forks_url":"https://api.github.com/repos/labrad/scalabrad/forks","keys_url":"https://api.github.com/repos/labrad/scalabrad/keys{/key_id}","collaborators_url":"https://api.github.com/repos/labrad/scalabrad/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/labrad/scalabrad/teams","hooks_url":"https://api.github.com/repos/labrad/scalabrad/hooks","issue_events_url":"https://api.github.com/repos/labrad/scalabrad/issues/events{/number}","events_url":"https://api.github.com/repos/labrad/scalabrad/events","assignees_url":"https://api.github.com/repos/labrad/scalabrad/assignees{/user}","branches_url":"https://api.github.com/repos/labrad/scalabrad/branches{/branch}","tags_url":"https://api.github.com/repos/labrad/scalabrad/tags","blobs_url":"https://api.github.com/repos/labrad/scalabrad/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/labrad/scalabrad/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/labrad/scalabrad/git/refs{/sha}","trees_url":"https://api.github.com/repos/labrad/scalabrad/git/trees{/sha}","statuses_url":"https://api.github.com/repos/labrad/scalabrad/statuses/{sha}","languages_url":"https://api.github.com/repos/labrad/scalabrad/languages","stargazers_url":"https://api.github.com/repos/labrad/scalabrad/stargazers","contributors_url":"https://api.github.com/repos/labrad/scalabrad/contributors","subscribers_url":"https://api.github.com/repos/labrad/scalabrad/subscribers","subscription_url":"https://api.github.com/repos/labrad/scalabrad/subscription","commits_url":"https://api.github.com/repos/labrad/scalabrad/commits{/sha}","git_commits_url":"https://api.github.com/repos/labrad/scalabrad/git/commits{/sha}","comments_url":"https://api.github.com/repos/labrad/scalabrad/comments{/number}","issue_comment_url":"https://api.github.com/repos/labrad/scalabrad/issues/comments{/number}","contents_url":"https://api.github.com/repos/labrad/scalabrad/contents/{+path}","compare_url":"https://api.github.com/repos/labrad/scalabrad/compare/{base}...{head}","merges_url":"https://api.github.com/repos/labrad/scalabrad/merges","archive_url":"https://api.github.com/repos/labrad/scalabrad/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/labrad/scalabrad/downloads","issues_url":"https://api.github.com/repos/labrad/scalabrad/issues{/number}","pulls_url":"https://api.github.com/repos/labrad/scalabrad/pulls{/number}","milestones_url":"https://api.github.com/repos/labrad/scalabrad/milestones{/number}","notifications_url":"https://api.github.com/repos/labrad/scalabrad/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/labrad/scalabrad/labels{/name}","releases_url":"https://api.github.com/repos/labrad/scalabrad/releases{/id}","deployments_url":"https://api.github.com/repos/labrad/scalabrad/deployments","created_at":"2011-08-24T14:08:56Z","updated_at":"2015-06-27T19:42:16Z","pushed_at":"2016-08-02T20:47:54Z","git_url":"git://github.com/labrad/scalabrad.git","ssh_url":"git@github.com:labrad/scalabrad.git","clone_url":"https://github.com/labrad/scalabrad.git","svn_url":"https://github.com/labrad/scalabrad","homepage":"","size":13178,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/labrad/scalabrad/pulls/66"},"html":{"href":"https://github.com/labrad/scalabrad/pull/66"},"issue":{"href":"https://api.github.com/repos/labrad/scalabrad/issues/66"},"comments":{"href":"https://api.github.com/repos/labrad/scalabrad/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/labrad/scalabrad/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/labrad/scalabrad/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/labrad/scalabrad/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/labrad/scalabrad/statuses/aeba26ec6bc53ce53c6bdf94d36cb2b527d77641"}}}}
{"actor":{"display_login":"ejeffrey"}}