{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/540","repository_url":"https://api.github.com/repos/Microsoft/vscode-mssql","labels_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/540/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/540/comments","events_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/540/events","html_url":"https://github.com/Microsoft/vscode-mssql/pull/540","id":195929268,"number":540,"title":"Fix persisting connection even when file is renamed ","user":{"login":"Raymondd","id":3318689,"avatar_url":"https://avatars.githubusercontent.com/u/3318689?v=3","gravatar_id":"","url":"https://api.github.com/users/Raymondd","html_url":"https://github.com/Raymondd","followers_url":"https://api.github.com/users/Raymondd/followers","following_url":"https://api.github.com/users/Raymondd/following{/other_user}","gists_url":"https://api.github.com/users/Raymondd/gists{/gist_id}","starred_url":"https://api.github.com/users/Raymondd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raymondd/subscriptions","organizations_url":"https://api.github.com/users/Raymondd/orgs","repos_url":"https://api.github.com/users/Raymondd/repos","events_url":"https://api.github.com/users/Raymondd/events{/privacy}","received_events_url":"https://api.github.com/users/Raymondd/received_events","type":"User","site_admin":false},"labels":[{"id":398555916,"url":"https://api.github.com/repos/Microsoft/vscode-mssql/labels/bug","name":"bug","color":"ee0701","default":true},{"id":482970112,"url":"https://api.github.com/repos/Microsoft/vscode-mssql/labels/cla-not-required","name":"cla-not-required","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"Raymondd","id":3318689,"avatar_url":"https://avatars.githubusercontent.com/u/3318689?v=3","gravatar_id":"","url":"https://api.github.com/users/Raymondd","html_url":"https://github.com/Raymondd","followers_url":"https://api.github.com/users/Raymondd/followers","following_url":"https://api.github.com/users/Raymondd/following{/other_user}","gists_url":"https://api.github.com/users/Raymondd/gists{/gist_id}","starred_url":"https://api.github.com/users/Raymondd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raymondd/subscriptions","organizations_url":"https://api.github.com/users/Raymondd/orgs","repos_url":"https://api.github.com/users/Raymondd/repos","events_url":"https://api.github.com/users/Raymondd/events{/privacy}","received_events_url":"https://api.github.com/users/Raymondd/received_events","type":"User","site_admin":false},"assignees":[{"login":"Raymondd","id":3318689,"avatar_url":"https://avatars.githubusercontent.com/u/3318689?v=3","gravatar_id":"","url":"https://api.github.com/users/Raymondd","html_url":"https://github.com/Raymondd","followers_url":"https://api.github.com/users/Raymondd/followers","following_url":"https://api.github.com/users/Raymondd/following{/other_user}","gists_url":"https://api.github.com/users/Raymondd/gists{/gist_id}","starred_url":"https://api.github.com/users/Raymondd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raymondd/subscriptions","organizations_url":"https://api.github.com/users/Raymondd/orgs","repos_url":"https://api.github.com/users/Raymondd/repos","events_url":"https://api.github.com/users/Raymondd/events{/privacy}","received_events_url":"https://api.github.com/users/Raymondd/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode-mssql/milestones/3","html_url":"https://github.com/Microsoft/vscode-mssql/milestone/3","labels_url":"https://api.github.com/repos/Microsoft/vscode-mssql/milestones/3/labels","id":2150264,"number":3,"title":"MSSQL Preview Release 3","description":"3rd release of the MSSQL extension. ","creator":{"login":"kevcunnane","id":10819925,"avatar_url":"https://avatars.githubusercontent.com/u/10819925?v=3","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":4,"state":"open","created_at":"2016-11-22T00:14:04Z","updated_at":"2016-12-15T23:07:43Z","due_on":"2017-01-30T00:00:00Z","closed_at":null},"comments":4,"created_at":"2016-12-15T22:09:14Z","updated_at":"2016-12-16T17:35:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-mssql/pulls/540","html_url":"https://github.com/Microsoft/vscode-mssql/pull/540","diff_url":"https://github.com/Microsoft/vscode-mssql/pull/540.diff","patch_url":"https://github.com/Microsoft/vscode-mssql/pull/540.patch"},"body":"Fixes #502  I added a rename file detection function based off of the untitled file detection function. I also reworked the onDidCloseTextDocument function to take care of a small bug where is wasn't properly closing some files normally. I will be adding unit tests in another PR for this file which expands beyond these changes, since some other functions (onDidOpenTextDocument, onDidCloseTextDocument, and onDidSaveTextDocument) weren't being covered fully. "},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/comments/267650454","html_url":"https://github.com/Microsoft/vscode-mssql/pull/540#issuecomment-267650454","issue_url":"https://api.github.com/repos/Microsoft/vscode-mssql/issues/540","id":267650454,"user":{"login":"llali","id":17187348,"avatar_url":"https://avatars.githubusercontent.com/u/17187348?v=3","gravatar_id":"","url":"https://api.github.com/users/llali","html_url":"https://github.com/llali","followers_url":"https://api.github.com/users/llali/followers","following_url":"https://api.github.com/users/llali/following{/other_user}","gists_url":"https://api.github.com/users/llali/gists{/gist_id}","starred_url":"https://api.github.com/users/llali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llali/subscriptions","organizations_url":"https://api.github.com/users/llali/orgs","repos_url":"https://api.github.com/users/llali/repos","events_url":"https://api.github.com/users/llali/events{/privacy}","received_events_url":"https://api.github.com/users/llali/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T17:35:53Z","updated_at":"2016-12-16T17:35:53Z","body":"I know you want to add test in another PR but the coverage decreasing in this PR. Is there any way you add tests here?"}}
{"actor":{"display_login":"llali"}}