{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/2038","repository_url":"https://api.github.com/repos/philc/vimium","labels_url":"https://api.github.com/repos/philc/vimium/issues/2038/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/2038/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/2038/events","html_url":"https://github.com/philc/vimium/issues/2038","id":138690806,"number":2038,"title":"Help dialog/Vomnibar focus issue","user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-05T15:28:26Z","updated_at":"2016-03-05T16:41:33Z","closed_at":null,"body":"Try this in `master`:\r\n\r\n- `?`, `o`, `Esc`, `Esc`, `j`\r\n\r\nThe problem is that the focus is ending up in the help dialog.\r\n\r\n@mrmr1993.  I'm stuck as to how to fix this.  See [this comment](https://github.com/philc/vimium/pull/2037#issue-138689677) and [here](https://github.com/smblott-github/vimium/commit/864b72756840b2d99bf437e55d3bb959dcfd59c2#diff-464a415c972610524ac9c8c9fb8ff040R85).\r\n\r\nEdit: `git bisect` tracks down this commit: bfe91c609ef9886cfeb5d45bfa1557a9d00faeb2.  But it looks harmless?"},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/192683891","html_url":"https://github.com/philc/vimium/issues/2038#issuecomment-192683891","issue_url":"https://api.github.com/repos/philc/vimium/issues/2038","id":192683891,"user":{"login":"mrmr1993","id":1847343,"avatar_url":"https://avatars.githubusercontent.com/u/1847343?v=3","gravatar_id":"","url":"https://api.github.com/users/mrmr1993","html_url":"https://github.com/mrmr1993","followers_url":"https://api.github.com/users/mrmr1993/followers","following_url":"https://api.github.com/users/mrmr1993/following{/other_user}","gists_url":"https://api.github.com/users/mrmr1993/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmr1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmr1993/subscriptions","organizations_url":"https://api.github.com/users/mrmr1993/orgs","repos_url":"https://api.github.com/users/mrmr1993/repos","events_url":"https://api.github.com/users/mrmr1993/events{/privacy}","received_events_url":"https://api.github.com/users/mrmr1993/received_events","type":"User","site_admin":false},"created_at":"2016-03-05T16:41:33Z","updated_at":"2016-03-05T16:41:33Z","body":"Seems [this comment](https://github.com/philc/vimium/commit/71d33fdeaa5c081de5041a6a0909d452e1564633#diff-464a415c972610524ac9c8c9fb8ff040R67) was a lie.\r\n\r\nAdd an `else if sourceFrameId == frameId` branch in `refocusSourceFrame` that refocuses the current frame and that should do it. (Also shouldn't need to check `@showing`, and should just `return unless sourceFrameId?` at the top of the function.)"}}