{"action":"created","issue":{"url":"https://api.github.com/repos/pydata/pandas-datareader/issues/255","repository_url":"https://api.github.com/repos/pydata/pandas-datareader","labels_url":"https://api.github.com/repos/pydata/pandas-datareader/issues/255/labels{/name}","comments_url":"https://api.github.com/repos/pydata/pandas-datareader/issues/255/comments","events_url":"https://api.github.com/repos/pydata/pandas-datareader/issues/255/events","html_url":"https://github.com/pydata/pandas-datareader/pull/255","id":187751674,"number":255,"title":"Add OANDA Rest Historical Instrument Reader","user":{"login":"davidandreoletti","id":1195702,"avatar_url":"https://avatars.githubusercontent.com/u/1195702?v=3","gravatar_id":"","url":"https://api.github.com/users/davidandreoletti","html_url":"https://github.com/davidandreoletti","followers_url":"https://api.github.com/users/davidandreoletti/followers","following_url":"https://api.github.com/users/davidandreoletti/following{/other_user}","gists_url":"https://api.github.com/users/davidandreoletti/gists{/gist_id}","starred_url":"https://api.github.com/users/davidandreoletti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidandreoletti/subscriptions","organizations_url":"https://api.github.com/users/davidandreoletti/orgs","repos_url":"https://api.github.com/users/davidandreoletti/repos","events_url":"https://api.github.com/users/davidandreoletti/events{/privacy}","received_events_url":"https://api.github.com/users/davidandreoletti/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-07T16:05:05Z","updated_at":"2016-11-07T17:00:51Z","closed_at":"2016-11-07T16:12:51Z","pull_request":{"url":"https://api.github.com/repos/pydata/pandas-datareader/pulls/255","html_url":"https://github.com/pydata/pandas-datareader/pull/255","diff_url":"https://github.com/pydata/pandas-datareader/pull/255.diff","patch_url":"https://github.com/pydata/pandas-datareader/pull/255.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/pydata/pandas-datareader/issues/comments/258894409","html_url":"https://github.com/pydata/pandas-datareader/pull/255#issuecomment-258894409","issue_url":"https://api.github.com/repos/pydata/pandas-datareader/issues/255","id":258894409,"user":{"login":"femtotrader","id":5049737,"avatar_url":"https://avatars.githubusercontent.com/u/5049737?v=3","gravatar_id":"","url":"https://api.github.com/users/femtotrader","html_url":"https://github.com/femtotrader","followers_url":"https://api.github.com/users/femtotrader/followers","following_url":"https://api.github.com/users/femtotrader/following{/other_user}","gists_url":"https://api.github.com/users/femtotrader/gists{/gist_id}","starred_url":"https://api.github.com/users/femtotrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femtotrader/subscriptions","organizations_url":"https://api.github.com/users/femtotrader/orgs","repos_url":"https://api.github.com/users/femtotrader/repos","events_url":"https://api.github.com/users/femtotrader/events{/privacy}","received_events_url":"https://api.github.com/users/femtotrader/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T17:00:51Z","updated_at":"2016-11-07T17:00:51Z","body":"Thanks @davidandreoletti \r\n\r\nBut you could simply give this PR a title starting with WIP and still push there.\r\n\r\nIn order to provide a better user API experience `granularity` could be a Pandas offset shortcut string (like '5Min', '5H' ... in `resample` function ).\r\n\r\nAnd it could be convert to a string compatible with Oanda API.\r\n\r\nWe could have a parameter named `freq` for `DataReader` function (it's role is quite similar to `pandas.date_range` parameter)\r\n\r\nSee https://github.com/pydata/pandas-datareader/pull/199\r\n\r\nI'd convert `freq` (string) to Pandas DateOffset\r\nhttp://stackoverflow.com/questions/27368265/convert-freq-string-to-dateoffset-in-pandas\r\n\r\nand have a dict to convert Pandas DateOffset to Oanda granularity string.\r\n\r\nAsk me if you don't understand what I mean (because I'm not english native speaker) so I may miss something."}}
{"actor":{"display_login":"femtotrader"}}