{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/53961686","id":53961686,"diff_hunk":"@@ -41,14 +43,22 @@ def no_syslogsettings\n \n   def test_syslogsettings_create\n     syslog_setting = Cisco::SyslogSettings.new('default')\n-    assert_includes(Cisco::SyslogSettings.syslogsettings, 'default')\n-    assert_equal(Cisco::SyslogSettings.syslogsettings['default'],\n-                 syslog_setting)\n-\n-    syslog_setting.timestamp = 'milliseconds'\n-    assert_equal(Cisco::SyslogSettings.syslogsettings['default'].timestamp,\n-                 'milliseconds')\n-    assert_equal(syslog_setting.timestamp,\n-                 'milliseconds')\n+\n+    if platform == :ios_xr\n+      assert_nil(syslog_setting.timestamp)\n+      assert_raises(Cisco::UnsupportedError) do\n+        syslog_setting.timestamp = 'milliseconds'\n+      end\n+    else\n+      assert_includes(Cisco::SyslogSettings.syslogsettings, 'default')\n+      assert_equal(Cisco::SyslogSettings.syslogsettings['default'],\n+                   syslog_setting)\n+\n+      syslog_setting.timestamp = 'milliseconds'\n+      assert_equal(Cisco::SyslogSettings.syslogsettings['default'].timestamp,\n+                   'milliseconds')\n+      assert_equal(syslog_setting.timestamp,\n+                   'milliseconds')","path":"tests/test_syslog_settings.rb","position":43,"original_position":43,"commit_id":"3a69d36ad3fa0ed833368e02729feb166eaeca31","original_commit_id":"3a69d36ad3fa0ed833368e02729feb166eaeca31","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"body":"I know this was in the original code but... the assert_equal args are swapped. Should be `assert_equal(expected, actual)`. Please fix that. :+1:  everything else.","created_at":"2016-02-24T16:09:04Z","updated_at":"2016-02-24T16:09:04Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/241#discussion_r53961686","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/53961686"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/241#discussion_r53961686"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241","id":60511618,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/241","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/241.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/241.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/241","number":241,"state":"open","locked":false,"title":"Added code to exclude syslog_setting for IOS XR","user":{"login":"jonnytpuppet","id":10402750,"avatar_url":"https://avatars.githubusercontent.com/u/10402750?v=3","gravatar_id":"","url":"https://api.github.com/users/jonnytpuppet","html_url":"https://github.com/jonnytpuppet","followers_url":"https://api.github.com/users/jonnytpuppet/followers","following_url":"https://api.github.com/users/jonnytpuppet/following{/other_user}","gists_url":"https://api.github.com/users/jonnytpuppet/gists{/gist_id}","starred_url":"https://api.github.com/users/jonnytpuppet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonnytpuppet/subscriptions","organizations_url":"https://api.github.com/users/jonnytpuppet/orgs","repos_url":"https://api.github.com/users/jonnytpuppet/repos","events_url":"https://api.github.com/users/jonnytpuppet/events{/privacy}","received_events_url":"https://api.github.com/users/jonnytpuppet/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-24T13:52:45Z","updated_at":"2016-02-24T16:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdb527d2f36fc41201914cef7b6914dcc192e359","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/241/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/3a69d36ad3fa0ed833368e02729feb166eaeca31","head":{"label":"jonnytpuppet:exr_syslog_setting","ref":"exr_syslog_setting","sha":"3a69d36ad3fa0ed833368e02729feb166eaeca31","user":{"login":"jonnytpuppet","id":10402750,"avatar_url":"https://avatars.githubusercontent.com/u/10402750?v=3","gravatar_id":"","url":"https://api.github.com/users/jonnytpuppet","html_url":"https://github.com/jonnytpuppet","followers_url":"https://api.github.com/users/jonnytpuppet/followers","following_url":"https://api.github.com/users/jonnytpuppet/following{/other_user}","gists_url":"https://api.github.com/users/jonnytpuppet/gists{/gist_id}","starred_url":"https://api.github.com/users/jonnytpuppet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonnytpuppet/subscriptions","organizations_url":"https://api.github.com/users/jonnytpuppet/orgs","repos_url":"https://api.github.com/users/jonnytpuppet/repos","events_url":"https://api.github.com/users/jonnytpuppet/events{/privacy}","received_events_url":"https://api.github.com/users/jonnytpuppet/received_events","type":"User","site_admin":false},"repo":{"id":43317227,"name":"cisco-network-node-utils","full_name":"jonnytpuppet/cisco-network-node-utils","owner":{"login":"jonnytpuppet","id":10402750,"avatar_url":"https://avatars.githubusercontent.com/u/10402750?v=3","gravatar_id":"","url":"https://api.github.com/users/jonnytpuppet","html_url":"https://github.com/jonnytpuppet","followers_url":"https://api.github.com/users/jonnytpuppet/followers","following_url":"https://api.github.com/users/jonnytpuppet/following{/other_user}","gists_url":"https://api.github.com/users/jonnytpuppet/gists{/gist_id}","starred_url":"https://api.github.com/users/jonnytpuppet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonnytpuppet/subscriptions","organizations_url":"https://api.github.com/users/jonnytpuppet/orgs","repos_url":"https://api.github.com/users/jonnytpuppet/repos","events_url":"https://api.github.com/users/jonnytpuppet/events{/privacy}","received_events_url":"https://api.github.com/users/jonnytpuppet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonnytpuppet/cisco-network-node-utils","description":"","fork":true,"url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils","forks_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/jonnytpuppet/cisco-network-node-utils/deployments","created_at":"2015-09-28T17:57:08Z","updated_at":"2015-09-28T17:57:09Z","pushed_at":"2016-02-24T14:34:45Z","git_url":"git://github.com/jonnytpuppet/cisco-network-node-utils.git","ssh_url":"git@github.com:jonnytpuppet/cisco-network-node-utils.git","clone_url":"https://github.com/jonnytpuppet/cisco-network-node-utils.git","svn_url":"https://github.com/jonnytpuppet/cisco-network-node-utils","homepage":null,"size":2624,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"45aaab929f179ee7a06563ab57957e0622467345","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/deployments","created_at":"2015-07-23T12:07:39Z","updated_at":"2016-02-01T19:00:12Z","pushed_at":"2016-02-24T14:34:45Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":3776,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":5,"forks":34,"open_issues":5,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/241"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/241"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/3a69d36ad3fa0ed833368e02729feb166eaeca31"}}}}