{"action":"created","comment":{"url":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments/92402878","pull_request_review_id":12916691,"id":92402878,"diff_hunk":"@@ -114,8 +114,9 @@ def prepare(self):\n         if isinstance(self.engine.aggregator, ResultsProvider):\n             self.engine.aggregator.add_listener(self)\n \n-        self.disabled = self.settings.get(\"disable\", False)\n-        if self.disabled:\n+        disable = str(self.settings.get('disable', 'auto')).lower()\n+        if (disable == 'true') or ((disable == 'auto') and (not is_tty())):","path":"bzt/modules/console.py","position":16,"original_position":16,"commit_id":"8ff8d329b9446ceaeda608e8a21b21c58ea6d2e4","original_commit_id":"8ff8d329b9446ceaeda608e8a21b21c58ea6d2e4","user":{"login":"greyfenrir","id":12038809,"avatar_url":"https://avatars.githubusercontent.com/u/12038809?v=3","gravatar_id":"","url":"https://api.github.com/users/greyfenrir","html_url":"https://github.com/greyfenrir","followers_url":"https://api.github.com/users/greyfenrir/followers","following_url":"https://api.github.com/users/greyfenrir/following{/other_user}","gists_url":"https://api.github.com/users/greyfenrir/gists{/gist_id}","starred_url":"https://api.github.com/users/greyfenrir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyfenrir/subscriptions","organizations_url":"https://api.github.com/users/greyfenrir/orgs","repos_url":"https://api.github.com/users/greyfenrir/repos","events_url":"https://api.github.com/users/greyfenrir/events{/privacy}","received_events_url":"https://api.github.com/users/greyfenrir/received_events","type":"User","site_admin":false},"body":"I can't agree with this. So console will be disabled if disable='auto' and stdout is tty. Yes, we can add '==True' at the end of this line... but I don't like it too much. At my opinion saving different types in one variable isn't good practice.","created_at":"2016-12-14T14:28:15Z","updated_at":"2016-12-14T14:28:15Z","html_url":"https://github.com/Blazemeter/taurus/pull/439#discussion_r92402878","pull_request_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/439","_links":{"self":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments/92402878"},"html":{"href":"https://github.com/Blazemeter/taurus/pull/439#discussion_r92402878"},"pull_request":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/439"}}},"pull_request":{"url":"https://api.github.com/repos/Blazemeter/taurus/pulls/439","id":97943271,"html_url":"https://github.com/Blazemeter/taurus/pull/439","diff_url":"https://github.com/Blazemeter/taurus/pull/439.diff","patch_url":"https://github.com/Blazemeter/taurus/pull/439.patch","issue_url":"https://api.github.com/repos/Blazemeter/taurus/issues/439","number":439,"state":"open","locked":false,"title":"Feat/console/tty","user":{"login":"greyfenrir","id":12038809,"avatar_url":"https://avatars.githubusercontent.com/u/12038809?v=3","gravatar_id":"","url":"https://api.github.com/users/greyfenrir","html_url":"https://github.com/greyfenrir","followers_url":"https://api.github.com/users/greyfenrir/followers","following_url":"https://api.github.com/users/greyfenrir/following{/other_user}","gists_url":"https://api.github.com/users/greyfenrir/gists{/gist_id}","starred_url":"https://api.github.com/users/greyfenrir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greyfenrir/subscriptions","organizations_url":"https://api.github.com/users/greyfenrir/orgs","repos_url":"https://api.github.com/users/greyfenrir/repos","events_url":"https://api.github.com/users/greyfenrir/events{/privacy}","received_events_url":"https://api.github.com/users/greyfenrir/received_events","type":"User","site_admin":false},"body":"Disable console if stdout isn't a tty ","created_at":"2016-12-14T12:31:01Z","updated_at":"2016-12-14T14:28:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a673fc577914fbedb33c854d21b47ff71eee1030","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/439/commits","review_comments_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/439/comments","review_comment_url":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/issues/439/comments","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/8ff8d329b9446ceaeda608e8a21b21c58ea6d2e4","head":{"label":"Blazemeter:feat/console/tty","ref":"feat/console/tty","sha":"8ff8d329b9446ceaeda608e8a21b21c58ea6d2e4","user":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"repo":{"id":30940272,"name":"taurus","full_name":"Blazemeter/taurus","owner":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blazemeter/taurus","description":"Automation-friendly framework for Continuous Testing by","fork":false,"url":"https://api.github.com/repos/Blazemeter/taurus","forks_url":"https://api.github.com/repos/Blazemeter/taurus/forks","keys_url":"https://api.github.com/repos/Blazemeter/taurus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blazemeter/taurus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blazemeter/taurus/teams","hooks_url":"https://api.github.com/repos/Blazemeter/taurus/hooks","issue_events_url":"https://api.github.com/repos/Blazemeter/taurus/issues/events{/number}","events_url":"https://api.github.com/repos/Blazemeter/taurus/events","assignees_url":"https://api.github.com/repos/Blazemeter/taurus/assignees{/user}","branches_url":"https://api.github.com/repos/Blazemeter/taurus/branches{/branch}","tags_url":"https://api.github.com/repos/Blazemeter/taurus/tags","blobs_url":"https://api.github.com/repos/Blazemeter/taurus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blazemeter/taurus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blazemeter/taurus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blazemeter/taurus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/{sha}","languages_url":"https://api.github.com/repos/Blazemeter/taurus/languages","stargazers_url":"https://api.github.com/repos/Blazemeter/taurus/stargazers","contributors_url":"https://api.github.com/repos/Blazemeter/taurus/contributors","subscribers_url":"https://api.github.com/repos/Blazemeter/taurus/subscribers","subscription_url":"https://api.github.com/repos/Blazemeter/taurus/subscription","commits_url":"https://api.github.com/repos/Blazemeter/taurus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blazemeter/taurus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blazemeter/taurus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blazemeter/taurus/contents/{+path}","compare_url":"https://api.github.com/repos/Blazemeter/taurus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blazemeter/taurus/merges","archive_url":"https://api.github.com/repos/Blazemeter/taurus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blazemeter/taurus/downloads","issues_url":"https://api.github.com/repos/Blazemeter/taurus/issues{/number}","pulls_url":"https://api.github.com/repos/Blazemeter/taurus/pulls{/number}","milestones_url":"https://api.github.com/repos/Blazemeter/taurus/milestones{/number}","notifications_url":"https://api.github.com/repos/Blazemeter/taurus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blazemeter/taurus/labels{/name}","releases_url":"https://api.github.com/repos/Blazemeter/taurus/releases{/id}","deployments_url":"https://api.github.com/repos/Blazemeter/taurus/deployments","created_at":"2015-02-17T22:05:08Z","updated_at":"2016-12-12T10:28:32Z","pushed_at":"2016-12-14T14:12:56Z","git_url":"git://github.com/Blazemeter/taurus.git","ssh_url":"git@github.com:Blazemeter/taurus.git","clone_url":"https://github.com/Blazemeter/taurus.git","svn_url":"https://github.com/Blazemeter/taurus","homepage":"http://gettaurus.org","size":7794,"stargazers_count":284,"watchers_count":284,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":4,"forks":62,"open_issues":4,"watchers":284,"default_branch":"master"}},"base":{"label":"Blazemeter:master","ref":"master","sha":"a2c21093166cd7b5f5dafa5fdcedb4fe20954ed9","user":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"repo":{"id":30940272,"name":"taurus","full_name":"Blazemeter/taurus","owner":{"login":"Blazemeter","id":1841717,"avatar_url":"https://avatars.githubusercontent.com/u/1841717?v=3","gravatar_id":"","url":"https://api.github.com/users/Blazemeter","html_url":"https://github.com/Blazemeter","followers_url":"https://api.github.com/users/Blazemeter/followers","following_url":"https://api.github.com/users/Blazemeter/following{/other_user}","gists_url":"https://api.github.com/users/Blazemeter/gists{/gist_id}","starred_url":"https://api.github.com/users/Blazemeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blazemeter/subscriptions","organizations_url":"https://api.github.com/users/Blazemeter/orgs","repos_url":"https://api.github.com/users/Blazemeter/repos","events_url":"https://api.github.com/users/Blazemeter/events{/privacy}","received_events_url":"https://api.github.com/users/Blazemeter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blazemeter/taurus","description":"Automation-friendly framework for Continuous Testing by","fork":false,"url":"https://api.github.com/repos/Blazemeter/taurus","forks_url":"https://api.github.com/repos/Blazemeter/taurus/forks","keys_url":"https://api.github.com/repos/Blazemeter/taurus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blazemeter/taurus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blazemeter/taurus/teams","hooks_url":"https://api.github.com/repos/Blazemeter/taurus/hooks","issue_events_url":"https://api.github.com/repos/Blazemeter/taurus/issues/events{/number}","events_url":"https://api.github.com/repos/Blazemeter/taurus/events","assignees_url":"https://api.github.com/repos/Blazemeter/taurus/assignees{/user}","branches_url":"https://api.github.com/repos/Blazemeter/taurus/branches{/branch}","tags_url":"https://api.github.com/repos/Blazemeter/taurus/tags","blobs_url":"https://api.github.com/repos/Blazemeter/taurus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blazemeter/taurus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blazemeter/taurus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blazemeter/taurus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blazemeter/taurus/statuses/{sha}","languages_url":"https://api.github.com/repos/Blazemeter/taurus/languages","stargazers_url":"https://api.github.com/repos/Blazemeter/taurus/stargazers","contributors_url":"https://api.github.com/repos/Blazemeter/taurus/contributors","subscribers_url":"https://api.github.com/repos/Blazemeter/taurus/subscribers","subscription_url":"https://api.github.com/repos/Blazemeter/taurus/subscription","commits_url":"https://api.github.com/repos/Blazemeter/taurus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blazemeter/taurus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blazemeter/taurus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blazemeter/taurus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blazemeter/taurus/contents/{+path}","compare_url":"https://api.github.com/repos/Blazemeter/taurus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blazemeter/taurus/merges","archive_url":"https://api.github.com/repos/Blazemeter/taurus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blazemeter/taurus/downloads","issues_url":"https://api.github.com/repos/Blazemeter/taurus/issues{/number}","pulls_url":"https://api.github.com/repos/Blazemeter/taurus/pulls{/number}","milestones_url":"https://api.github.com/repos/Blazemeter/taurus/milestones{/number}","notifications_url":"https://api.github.com/repos/Blazemeter/taurus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blazemeter/taurus/labels{/name}","releases_url":"https://api.github.com/repos/Blazemeter/taurus/releases{/id}","deployments_url":"https://api.github.com/repos/Blazemeter/taurus/deployments","created_at":"2015-02-17T22:05:08Z","updated_at":"2016-12-12T10:28:32Z","pushed_at":"2016-12-14T14:12:56Z","git_url":"git://github.com/Blazemeter/taurus.git","ssh_url":"git@github.com:Blazemeter/taurus.git","clone_url":"https://github.com/Blazemeter/taurus.git","svn_url":"https://github.com/Blazemeter/taurus","homepage":"http://gettaurus.org","size":7794,"stargazers_count":284,"watchers_count":284,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":4,"forks":62,"open_issues":4,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/439"},"html":{"href":"https://github.com/Blazemeter/taurus/pull/439"},"issue":{"href":"https://api.github.com/repos/Blazemeter/taurus/issues/439"},"comments":{"href":"https://api.github.com/repos/Blazemeter/taurus/issues/439/comments"},"review_comments":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/439/comments"},"review_comment":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Blazemeter/taurus/pulls/439/commits"},"statuses":{"href":"https://api.github.com/repos/Blazemeter/taurus/statuses/8ff8d329b9446ceaeda608e8a21b21c58ea6d2e4"}}}}
{"actor":{"display_login":"greyfenrir"}}