{"action":"created","issue":{"url":"https://api.github.com/repos/cbaja/MyTwitterRedux/issues/1","repository_url":"https://api.github.com/repos/cbaja/MyTwitterRedux","labels_url":"https://api.github.com/repos/cbaja/MyTwitterRedux/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/cbaja/MyTwitterRedux/issues/1/comments","events_url":"https://api.github.com/repos/cbaja/MyTwitterRedux/issues/1/events","html_url":"https://github.com/cbaja/MyTwitterRedux/issues/1","id":137112409,"number":1,"title":"[Android Bootcamp] Project 4 - Review my app (My Twitter Redux)","user":{"login":"cbaja","id":11256198,"avatar_url":"https://avatars.githubusercontent.com/u/11256198?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaja","html_url":"https://github.com/cbaja","followers_url":"https://api.github.com/users/cbaja/followers","following_url":"https://api.github.com/users/cbaja/following{/other_user}","gists_url":"https://api.github.com/users/cbaja/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaja/subscriptions","organizations_url":"https://api.github.com/users/cbaja/orgs","repos_url":"https://api.github.com/users/cbaja/repos","events_url":"https://api.github.com/users/cbaja/events{/privacy}","received_events_url":"https://api.github.com/users/cbaja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-28T23:49:07Z","updated_at":"2016-02-29T07:19:36Z","closed_at":null,"body":"My app is complete, please review. /cc @codepathreview @codepath\r\n\r\n\r\nCarly"},"comment":{"url":"https://api.github.com/repos/cbaja/MyTwitterRedux/issues/comments/190072933","html_url":"https://github.com/cbaja/MyTwitterRedux/issues/1#issuecomment-190072933","issue_url":"https://api.github.com/repos/cbaja/MyTwitterRedux/issues/1","id":190072933,"user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T07:19:36Z","updated_at":"2016-02-29T07:19:36Z","body":"Nice work overall. A few notes after checking out the code:\r\n\r\n* Good to see you properly communicated the user to the user timeline fragment from the profile activity.\r\n* Glad to see you properly hooked up each of the different timelines to infinitely paginate.\r\n* Correctly and appropriately used `OnClickListeners` on the user's profile image to navigate to their profile view\r\n* Nice efforts on making the app look twitter branded\r\n* Nice to see you played around with styling the sliding tab strip\r\n* Nice to see you have progress bars displayed during background tasks\r\n* For a future exercise, challenge yourself to move even more of the logic into the base Fragment class and out of the extension timeline fragments. For example, the scroll listener could be set in the base class and then the \"onLoadMore\" could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.\r\n* Consider adding local persistence of tweets by using ActiveAndroid in the `Tweet` and `User`. See the [persistence guide](http://guides.codepath.com/android/Persisting-Data-to-the-Device#object-relational-mappers) and this [other guide](http://guides.codepath.com/android/ActiveAndroid-Guide) for more details.\r\n\r\nHere's a detailed [Project 4 Feedback Guide here](http://courses.codepath.com/snippets/intro_to_android/project_4_feedback) which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission. \r\n\r\nThis week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.\r\n\r\nFollowing the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that. "}}