{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode/issues/79","repository_url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode","labels_url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode/issues/79/comments","events_url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode/issues/79/events","html_url":"https://github.com/JuliaEditorSupport/julia-vscode/pull/79","id":190292221,"number":79,"title":"remove JuliaParser dependency","user":{"login":"ZacLN","id":5861046,"avatar_url":"https://avatars.githubusercontent.com/u/5861046?v=3","gravatar_id":"","url":"https://api.github.com/users/ZacLN","html_url":"https://github.com/ZacLN","followers_url":"https://api.github.com/users/ZacLN/followers","following_url":"https://api.github.com/users/ZacLN/following{/other_user}","gists_url":"https://api.github.com/users/ZacLN/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacLN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacLN/subscriptions","organizations_url":"https://api.github.com/users/ZacLN/orgs","repos_url":"https://api.github.com/users/ZacLN/repos","events_url":"https://api.github.com/users/ZacLN/events{/privacy}","received_events_url":"https://api.github.com/users/ZacLN/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-18T11:01:38Z","updated_at":"2016-11-18T17:00:21Z","closed_at":"2016-11-18T16:04:39Z","pull_request":{"url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode/pulls/79","html_url":"https://github.com/JuliaEditorSupport/julia-vscode/pull/79","diff_url":"https://github.com/JuliaEditorSupport/julia-vscode/pull/79.diff","patch_url":"https://github.com/JuliaEditorSupport/julia-vscode/pull/79.patch"},"body":"I started to have a look at forking JuliaParser to have it store state and line/column info at intermediate stages of parsing and think it can be done but for now we may as well strip these dependencies?\r\n\r\nI've also fixed `get_word` to handle cases such as `321sin(x)`."},"comment":{"url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode/issues/comments/261583666","html_url":"https://github.com/JuliaEditorSupport/julia-vscode/pull/79#issuecomment-261583666","issue_url":"https://api.github.com/repos/JuliaEditorSupport/julia-vscode/issues/79","id":261583666,"user":{"login":"ZacLN","id":5861046,"avatar_url":"https://avatars.githubusercontent.com/u/5861046?v=3","gravatar_id":"","url":"https://api.github.com/users/ZacLN","html_url":"https://github.com/ZacLN","followers_url":"https://api.github.com/users/ZacLN/followers","following_url":"https://api.github.com/users/ZacLN/following{/other_user}","gists_url":"https://api.github.com/users/ZacLN/gists{/gist_id}","starred_url":"https://api.github.com/users/ZacLN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZacLN/subscriptions","organizations_url":"https://api.github.com/users/ZacLN/orgs","repos_url":"https://api.github.com/users/ZacLN/repos","events_url":"https://api.github.com/users/ZacLN/events{/privacy}","received_events_url":"https://api.github.com/users/ZacLN/received_events","type":"User","site_admin":false},"created_at":"2016-11-18T17:00:21Z","updated_at":"2016-11-18T17:00:21Z","body":"I'll have a read up on the Roslyn framework sometime over the weekend. From my quick summary look, JuliaParser already has a structure that we can work with without creating a whole new `Expr` type holding location specific information. I think we can get what we want just by extending the `ParserState`type and finding the points in parsing that we are interested in, e.g.: on hitting this [this](https://github.com/JuliaLang/JuliaParser.jl/blob/master/src/parser.jl#L962) we capture all  [declarations](https://github.com/JuliaLang/JuliaParser.jl/blob/master/src/parser.jl#L363), etc. until that expression closes.\r\n\r\n...but it seems to be quite complicated\r\n\r\n"}}
{"actor":{"display_login":"ZacLN"}}