{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/90917036","pull_request_review_id":11430558,"id":90917036,"diff_hunk":"@@ -874,3 +881,23 @@ def check_for_collisions(parts):\n         # And add our files to the list\n         parts_files[part.name] = {'files': part_files,\n                                   'installdir': part.installdir}\n+\n+\n+def _combine_filesets(fileset_1, fileset_2):\n+    \"\"\"Combine filesets if the first is an explicit or implicit wildcard.\"\"\"\n+\n+    to_combine = False\n+    # combine if fileset_1 has a wildcard\n+    # XXX: should this only be a single wildcard and possibly excludes?\n+    if '*' in fileset_1:\n+        to_combine = True\n+        fileset_1.remove('*')\n+\n+    # combine if fileset_1 is only excludes\n+    if set([x[0] for x in fileset_1]) == set('-'):","path":"snapcraft/internal/pluginhandler.py","position":57,"original_position":31,"commit_id":"09884884ccd16285756d195e548809f887b90ef7","original_commit_id":"8dafe33868cd6be669ae99a2ad95430768214260","user":{"login":"josepht","id":646088,"avatar_url":"https://avatars.githubusercontent.com/u/646088?v=3","gravatar_id":"","url":"https://api.github.com/users/josepht","html_url":"https://github.com/josepht","followers_url":"https://api.github.com/users/josepht/followers","following_url":"https://api.github.com/users/josepht/following{/other_user}","gists_url":"https://api.github.com/users/josepht/gists{/gist_id}","starred_url":"https://api.github.com/users/josepht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josepht/subscriptions","organizations_url":"https://api.github.com/users/josepht/orgs","repos_url":"https://api.github.com/users/josepht/repos","events_url":"https://api.github.com/users/josepht/events{/privacy}","received_events_url":"https://api.github.com/users/josepht/received_events","type":"User","site_admin":false},"body":"Does that create a set()? ","created_at":"2016-12-05T17:44:26Z","updated_at":"2016-12-05T17:44:26Z","html_url":"https://github.com/snapcore/snapcraft/pull/920#discussion_r90917036","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/920","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/90917036"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/920#discussion_r90917036"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/920"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/920","id":94443552,"html_url":"https://github.com/snapcore/snapcraft/pull/920","diff_url":"https://github.com/snapcore/snapcraft/pull/920.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/920.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/920","number":920,"state":"open","locked":false,"title":"pluginhandler: ensure staged files are included in the prime step.","user":{"login":"josepht","id":646088,"avatar_url":"https://avatars.githubusercontent.com/u/646088?v=3","gravatar_id":"","url":"https://api.github.com/users/josepht","html_url":"https://github.com/josepht","followers_url":"https://api.github.com/users/josepht/followers","following_url":"https://api.github.com/users/josepht/following{/other_user}","gists_url":"https://api.github.com/users/josepht/gists{/gist_id}","starred_url":"https://api.github.com/users/josepht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josepht/subscriptions","organizations_url":"https://api.github.com/users/josepht/orgs","repos_url":"https://api.github.com/users/josepht/repos","events_url":"https://api.github.com/users/josepht/events{/privacy}","received_events_url":"https://api.github.com/users/josepht/received_events","type":"User","site_admin":false},"body":"If the 'prime' fileset is made up of '*/' or only includes '-XXX'\r\nentries combine the 'stage' fileset as well.\r\n\r\nLP:#1623279\r\nLP:#1605164","created_at":"2016-11-18T21:53:15Z","updated_at":"2016-12-05T17:44:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41400a4604ad983754ef9f9f7e0093cdb0898d1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/920/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/920/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/920/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/09884884ccd16285756d195e548809f887b90ef7","head":{"label":"josepht:bugs/1623279","ref":"bugs/1623279","sha":"09884884ccd16285756d195e548809f887b90ef7","user":{"login":"josepht","id":646088,"avatar_url":"https://avatars.githubusercontent.com/u/646088?v=3","gravatar_id":"","url":"https://api.github.com/users/josepht","html_url":"https://github.com/josepht","followers_url":"https://api.github.com/users/josepht/followers","following_url":"https://api.github.com/users/josepht/following{/other_user}","gists_url":"https://api.github.com/users/josepht/gists{/gist_id}","starred_url":"https://api.github.com/users/josepht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josepht/subscriptions","organizations_url":"https://api.github.com/users/josepht/orgs","repos_url":"https://api.github.com/users/josepht/repos","events_url":"https://api.github.com/users/josepht/events{/privacy}","received_events_url":"https://api.github.com/users/josepht/received_events","type":"User","site_admin":false},"repo":{"id":54208156,"name":"snapcraft","full_name":"josepht/snapcraft","owner":{"login":"josepht","id":646088,"avatar_url":"https://avatars.githubusercontent.com/u/646088?v=3","gravatar_id":"","url":"https://api.github.com/users/josepht","html_url":"https://github.com/josepht","followers_url":"https://api.github.com/users/josepht/followers","following_url":"https://api.github.com/users/josepht/following{/other_user}","gists_url":"https://api.github.com/users/josepht/gists{/gist_id}","starred_url":"https://api.github.com/users/josepht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josepht/subscriptions","organizations_url":"https://api.github.com/users/josepht/orgs","repos_url":"https://api.github.com/users/josepht/repos","events_url":"https://api.github.com/users/josepht/events{/privacy}","received_events_url":"https://api.github.com/users/josepht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josepht/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/josepht/snapcraft","forks_url":"https://api.github.com/repos/josepht/snapcraft/forks","keys_url":"https://api.github.com/repos/josepht/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josepht/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josepht/snapcraft/teams","hooks_url":"https://api.github.com/repos/josepht/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/josepht/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/josepht/snapcraft/events","assignees_url":"https://api.github.com/repos/josepht/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/josepht/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/josepht/snapcraft/tags","blobs_url":"https://api.github.com/repos/josepht/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josepht/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josepht/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/josepht/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josepht/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/josepht/snapcraft/languages","stargazers_url":"https://api.github.com/repos/josepht/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/josepht/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/josepht/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/josepht/snapcraft/subscription","commits_url":"https://api.github.com/repos/josepht/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/josepht/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/josepht/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/josepht/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/josepht/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/josepht/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josepht/snapcraft/merges","archive_url":"https://api.github.com/repos/josepht/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josepht/snapcraft/downloads","issues_url":"https://api.github.com/repos/josepht/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/josepht/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/josepht/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/josepht/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josepht/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/josepht/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/josepht/snapcraft/deployments","created_at":"2016-03-18T14:39:09Z","updated_at":"2016-03-18T14:39:10Z","pushed_at":"2016-12-05T17:22:41Z","git_url":"git://github.com/josepht/snapcraft.git","ssh_url":"git@github.com:josepht/snapcraft.git","clone_url":"https://github.com/josepht/snapcraft.git","svn_url":"https://github.com/josepht/snapcraft","homepage":null,"size":5658,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"b423455e2e4f90c9d14f29b509ec80dfe294b9c8","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2016-12-05T15:01:55Z","pushed_at":"2016-12-05T17:22:41Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":null,"size":8556,"stargazers_count":242,"watchers_count":242,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":140,"mirror_url":null,"open_issues_count":21,"forks":140,"open_issues":21,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/920"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/920"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/920"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/09884884ccd16285756d195e548809f887b90ef7"}}}}
{"actor":{"display_login":"josepht"}}