{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15257","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15257/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15257/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15257/events","html_url":"https://github.com/mantidproject/mantid/pull/15257","id":132908547,"number":15257,"title":"Use workspace clone method in algorithms","user":{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars.githubusercontent.com/u/12912489?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"tom-perkins","id":15363125,"avatar_url":"https://avatars.githubusercontent.com/u/15363125?v=3","gravatar_id":"","url":"https://api.github.com/users/tom-perkins","html_url":"https://github.com/tom-perkins","followers_url":"https://api.github.com/users/tom-perkins/followers","following_url":"https://api.github.com/users/tom-perkins/following{/other_user}","gists_url":"https://api.github.com/users/tom-perkins/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-perkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-perkins/subscriptions","organizations_url":"https://api.github.com/users/tom-perkins/orgs","repos_url":"https://api.github.com/users/tom-perkins/repos","events_url":"https://api.github.com/users/tom-perkins/events{/privacy}","received_events_url":"https://api.github.com/users/tom-perkins/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":561,"closed_issues":127,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-02-18T13:47:56Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":1,"created_at":"2016-02-11T07:36:03Z","updated_at":"2016-02-18T14:15:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15257","html_url":"https://github.com/mantidproject/mantid/pull/15257","diff_url":"https://github.com/mantidproject/mantid/pull/15257.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15257.patch"},"body":"Closes #15248.\r\n\r\nCode review:\r\nBasically this is a simple change: We replace three existing statements by a call to `Workspace::clone()`. As a consequence we can also get rid of some `dynamic_casts`, so the diff may be a bit harder to understand at some points.\r\nNote that the `clone()` call will be simplified by #12949.\r\n\r\nTesting:\r\nNo new tests were added, since there is no new functionality. In principle our existing system tests should cover this.\r\nOne idea for testing manually: Apply algorithm to an event workspace, and see if both in-place (input == output) and not-in-place still work as expected.\r\n\r\nNo release notes."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/185740387","html_url":"https://github.com/mantidproject/mantid/pull/15257#issuecomment-185740387","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15257","id":185740387,"user":{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars.githubusercontent.com/u/12912489?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T14:15:41Z","updated_at":"2016-02-18T14:15:41Z","body":"@tom-perkins I pushed a small about with your suggested changes."}}