{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/change/strict-rate-limiter/pulls/1","id":62320750,"html_url":"https://github.com/change/strict-rate-limiter/pull/1","diff_url":"https://github.com/change/strict-rate-limiter/pull/1.diff","patch_url":"https://github.com/change/strict-rate-limiter/pull/1.patch","issue_url":"https://api.github.com/repos/change/strict-rate-limiter/issues/1","number":1,"state":"open","locked":false,"title":"Use ioredis rather than node_redis","user":{"login":"quaelin","id":253337,"avatar_url":"https://avatars.githubusercontent.com/u/253337?v=3","gravatar_id":"","url":"https://api.github.com/users/quaelin","html_url":"https://github.com/quaelin","followers_url":"https://api.github.com/users/quaelin/followers","following_url":"https://api.github.com/users/quaelin/following{/other_user}","gists_url":"https://api.github.com/users/quaelin/gists{/gist_id}","starred_url":"https://api.github.com/users/quaelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quaelin/subscriptions","organizations_url":"https://api.github.com/users/quaelin/orgs","repos_url":"https://api.github.com/users/quaelin/repos","events_url":"https://api.github.com/users/quaelin/events{/privacy}","received_events_url":"https://api.github.com/users/quaelin/received_events","type":"User","site_admin":false},"body":"It turns out the strict-rate-limiter module we're using with Zuul doesn't support ioredis out-of-the-box due to a difference in how the `.exec()` callback works, as describe here:\r\nhttps://github.com/luin/ioredis/wiki/Migrating-from-node_redis\r\n\r\nI'm hacking it to use ioredis so that we have sentinel support.","created_at":"2016-03-10T00:30:21Z","updated_at":"2016-03-10T00:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/change/strict-rate-limiter/pulls/1/commits","review_comments_url":"https://api.github.com/repos/change/strict-rate-limiter/pulls/1/comments","review_comment_url":"https://api.github.com/repos/change/strict-rate-limiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/change/strict-rate-limiter/issues/1/comments","statuses_url":"https://api.github.com/repos/change/strict-rate-limiter/statuses/7b9d299ae7917a5666565c4d7be80efcd6f0825b","head":{"label":"change:cc-support-ioredis","ref":"cc-support-ioredis","sha":"7b9d299ae7917a5666565c4d7be80efcd6f0825b","user":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"repo":{"id":53541590,"name":"strict-rate-limiter","full_name":"change/strict-rate-limiter","owner":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/change/strict-rate-limiter","description":"Rate limiter backed by redis with strict concurrency rules for scalable applications","fork":true,"url":"https://api.github.com/repos/change/strict-rate-limiter","forks_url":"https://api.github.com/repos/change/strict-rate-limiter/forks","keys_url":"https://api.github.com/repos/change/strict-rate-limiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/change/strict-rate-limiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/change/strict-rate-limiter/teams","hooks_url":"https://api.github.com/repos/change/strict-rate-limiter/hooks","issue_events_url":"https://api.github.com/repos/change/strict-rate-limiter/issues/events{/number}","events_url":"https://api.github.com/repos/change/strict-rate-limiter/events","assignees_url":"https://api.github.com/repos/change/strict-rate-limiter/assignees{/user}","branches_url":"https://api.github.com/repos/change/strict-rate-limiter/branches{/branch}","tags_url":"https://api.github.com/repos/change/strict-rate-limiter/tags","blobs_url":"https://api.github.com/repos/change/strict-rate-limiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/change/strict-rate-limiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/change/strict-rate-limiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/change/strict-rate-limiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/change/strict-rate-limiter/statuses/{sha}","languages_url":"https://api.github.com/repos/change/strict-rate-limiter/languages","stargazers_url":"https://api.github.com/repos/change/strict-rate-limiter/stargazers","contributors_url":"https://api.github.com/repos/change/strict-rate-limiter/contributors","subscribers_url":"https://api.github.com/repos/change/strict-rate-limiter/subscribers","subscription_url":"https://api.github.com/repos/change/strict-rate-limiter/subscription","commits_url":"https://api.github.com/repos/change/strict-rate-limiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/change/strict-rate-limiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/change/strict-rate-limiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/change/strict-rate-limiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/change/strict-rate-limiter/contents/{+path}","compare_url":"https://api.github.com/repos/change/strict-rate-limiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/change/strict-rate-limiter/merges","archive_url":"https://api.github.com/repos/change/strict-rate-limiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/change/strict-rate-limiter/downloads","issues_url":"https://api.github.com/repos/change/strict-rate-limiter/issues{/number}","pulls_url":"https://api.github.com/repos/change/strict-rate-limiter/pulls{/number}","milestones_url":"https://api.github.com/repos/change/strict-rate-limiter/milestones{/number}","notifications_url":"https://api.github.com/repos/change/strict-rate-limiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/change/strict-rate-limiter/labels{/name}","releases_url":"https://api.github.com/repos/change/strict-rate-limiter/releases{/id}","deployments_url":"https://api.github.com/repos/change/strict-rate-limiter/deployments","created_at":"2016-03-10T00:15:19Z","updated_at":"2016-03-10T00:15:20Z","pushed_at":"2016-03-10T00:30:21Z","git_url":"git://github.com/change/strict-rate-limiter.git","ssh_url":"git@github.com:change/strict-rate-limiter.git","clone_url":"https://github.com/change/strict-rate-limiter.git","svn_url":"https://github.com/change/strict-rate-limiter","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"change:master","ref":"master","sha":"52797300c8bcfdc881d027e09fb56b74014db3f7","user":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"repo":{"id":53541590,"name":"strict-rate-limiter","full_name":"change/strict-rate-limiter","owner":{"login":"change","id":121582,"avatar_url":"https://avatars.githubusercontent.com/u/121582?v=3","gravatar_id":"","url":"https://api.github.com/users/change","html_url":"https://github.com/change","followers_url":"https://api.github.com/users/change/followers","following_url":"https://api.github.com/users/change/following{/other_user}","gists_url":"https://api.github.com/users/change/gists{/gist_id}","starred_url":"https://api.github.com/users/change/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/change/subscriptions","organizations_url":"https://api.github.com/users/change/orgs","repos_url":"https://api.github.com/users/change/repos","events_url":"https://api.github.com/users/change/events{/privacy}","received_events_url":"https://api.github.com/users/change/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/change/strict-rate-limiter","description":"Rate limiter backed by redis with strict concurrency rules for scalable applications","fork":true,"url":"https://api.github.com/repos/change/strict-rate-limiter","forks_url":"https://api.github.com/repos/change/strict-rate-limiter/forks","keys_url":"https://api.github.com/repos/change/strict-rate-limiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/change/strict-rate-limiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/change/strict-rate-limiter/teams","hooks_url":"https://api.github.com/repos/change/strict-rate-limiter/hooks","issue_events_url":"https://api.github.com/repos/change/strict-rate-limiter/issues/events{/number}","events_url":"https://api.github.com/repos/change/strict-rate-limiter/events","assignees_url":"https://api.github.com/repos/change/strict-rate-limiter/assignees{/user}","branches_url":"https://api.github.com/repos/change/strict-rate-limiter/branches{/branch}","tags_url":"https://api.github.com/repos/change/strict-rate-limiter/tags","blobs_url":"https://api.github.com/repos/change/strict-rate-limiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/change/strict-rate-limiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/change/strict-rate-limiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/change/strict-rate-limiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/change/strict-rate-limiter/statuses/{sha}","languages_url":"https://api.github.com/repos/change/strict-rate-limiter/languages","stargazers_url":"https://api.github.com/repos/change/strict-rate-limiter/stargazers","contributors_url":"https://api.github.com/repos/change/strict-rate-limiter/contributors","subscribers_url":"https://api.github.com/repos/change/strict-rate-limiter/subscribers","subscription_url":"https://api.github.com/repos/change/strict-rate-limiter/subscription","commits_url":"https://api.github.com/repos/change/strict-rate-limiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/change/strict-rate-limiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/change/strict-rate-limiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/change/strict-rate-limiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/change/strict-rate-limiter/contents/{+path}","compare_url":"https://api.github.com/repos/change/strict-rate-limiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/change/strict-rate-limiter/merges","archive_url":"https://api.github.com/repos/change/strict-rate-limiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/change/strict-rate-limiter/downloads","issues_url":"https://api.github.com/repos/change/strict-rate-limiter/issues{/number}","pulls_url":"https://api.github.com/repos/change/strict-rate-limiter/pulls{/number}","milestones_url":"https://api.github.com/repos/change/strict-rate-limiter/milestones{/number}","notifications_url":"https://api.github.com/repos/change/strict-rate-limiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/change/strict-rate-limiter/labels{/name}","releases_url":"https://api.github.com/repos/change/strict-rate-limiter/releases{/id}","deployments_url":"https://api.github.com/repos/change/strict-rate-limiter/deployments","created_at":"2016-03-10T00:15:19Z","updated_at":"2016-03-10T00:15:20Z","pushed_at":"2016-03-10T00:30:21Z","git_url":"git://github.com/change/strict-rate-limiter.git","ssh_url":"git@github.com:change/strict-rate-limiter.git","clone_url":"https://github.com/change/strict-rate-limiter.git","svn_url":"https://github.com/change/strict-rate-limiter","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/change/strict-rate-limiter/pulls/1"},"html":{"href":"https://github.com/change/strict-rate-limiter/pull/1"},"issue":{"href":"https://api.github.com/repos/change/strict-rate-limiter/issues/1"},"comments":{"href":"https://api.github.com/repos/change/strict-rate-limiter/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/change/strict-rate-limiter/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/change/strict-rate-limiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/change/strict-rate-limiter/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/change/strict-rate-limiter/statuses/7b9d299ae7917a5666565c4d7be80efcd6f0825b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":8,"changed_files":3}}