{"action":"created","issue":{"url":"https://api.github.com/repos/Katello/hammer-cli-katello/issues/393","repository_url":"https://api.github.com/repos/Katello/hammer-cli-katello","labels_url":"https://api.github.com/repos/Katello/hammer-cli-katello/issues/393/labels{/name}","comments_url":"https://api.github.com/repos/Katello/hammer-cli-katello/issues/393/comments","events_url":"https://api.github.com/repos/Katello/hammer-cli-katello/issues/393/events","html_url":"https://github.com/Katello/hammer-cli-katello/pull/393","id":154105479,"number":393,"title":"Fixes #14994 - Add simplecov with 91% minimum","user":{"login":"akofink","id":761923,"avatar_url":"https://avatars.githubusercontent.com/u/761923?v=3","gravatar_id":"","url":"https://api.github.com/users/akofink","html_url":"https://github.com/akofink","followers_url":"https://api.github.com/users/akofink/followers","following_url":"https://api.github.com/users/akofink/following{/other_user}","gists_url":"https://api.github.com/users/akofink/gists{/gist_id}","starred_url":"https://api.github.com/users/akofink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akofink/subscriptions","organizations_url":"https://api.github.com/users/akofink/orgs","repos_url":"https://api.github.com/users/akofink/repos","events_url":"https://api.github.com/users/akofink/events{/privacy}","received_events_url":"https://api.github.com/users/akofink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-10T20:59:39Z","updated_at":"2016-05-11T15:17:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Katello/hammer-cli-katello/pulls/393","html_url":"https://github.com/Katello/hammer-cli-katello/pull/393","diff_url":"https://github.com/Katello/hammer-cli-katello/pull/393.diff","patch_url":"https://github.com/Katello/hammer-cli-katello/pull/393.patch"},"body":"Request for comments.\r\n\r\nSimplecov is [even more popular](https://www.ruby-toolbox.com/categories/code_metrics) in the Ruby community than Rubocop in the category of code metrics.\r\n\r\nWhen you run your tests,  you will see the coverage summary print on one line of text. For more details, you can view a file-by-file summary that is generated in HTML at coverage/index.html. I've used simplecov in the past and been very happy with it.\r\n\r\nThe current coverage is 91.55%. I encourage people to raise the minimum defined in the test_helper as the coverage increases."},"comment":{"url":"https://api.github.com/repos/Katello/hammer-cli-katello/issues/comments/218491657","html_url":"https://github.com/Katello/hammer-cli-katello/pull/393#issuecomment-218491657","issue_url":"https://api.github.com/repos/Katello/hammer-cli-katello/issues/393","id":218491657,"user":{"login":"akofink","id":761923,"avatar_url":"https://avatars.githubusercontent.com/u/761923?v=3","gravatar_id":"","url":"https://api.github.com/users/akofink","html_url":"https://github.com/akofink","followers_url":"https://api.github.com/users/akofink/followers","following_url":"https://api.github.com/users/akofink/following{/other_user}","gists_url":"https://api.github.com/users/akofink/gists{/gist_id}","starred_url":"https://api.github.com/users/akofink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akofink/subscriptions","organizations_url":"https://api.github.com/users/akofink/orgs","repos_url":"https://api.github.com/users/akofink/repos","events_url":"https://api.github.com/users/akofink/events{/privacy}","received_events_url":"https://api.github.com/users/akofink/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T15:17:10Z","updated_at":"2016-05-11T15:17:10Z","body":"For this project, there is no noticeable execution time difference, and I've never had a problem with coverage increasing execution time in the past for large projects with slow tests.\r\n\r\nUsing simplecov's `track_files` option, now coverage is about 53%, which sounds much more reasonable."}}