{"action":"closed","number":49,"pull_request":{"url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/49","id":66722029,"html_url":"https://github.com/Keck-DataReductionPipelines/MosfireDRP/pull/49","diff_url":"https://github.com/Keck-DataReductionPipelines/MosfireDRP/pull/49.diff","patch_url":"https://github.com/Keck-DataReductionPipelines/MosfireDRP/pull/49.patch","issue_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/issues/49","number":49,"state":"closed","locked":false,"title":"Replacing pyRAF","user":{"login":"joshwalawender","id":4873464,"avatar_url":"https://avatars.githubusercontent.com/u/4873464?v=3","gravatar_id":"","url":"https://api.github.com/users/joshwalawender","html_url":"https://github.com/joshwalawender","followers_url":"https://api.github.com/users/joshwalawender/followers","following_url":"https://api.github.com/users/joshwalawender/following{/other_user}","gists_url":"https://api.github.com/users/joshwalawender/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwalawender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwalawender/subscriptions","organizations_url":"https://api.github.com/users/joshwalawender/orgs","repos_url":"https://api.github.com/users/joshwalawender/repos","events_url":"https://api.github.com/users/joshwalawender/events{/privacy}","received_events_url":"https://api.github.com/users/joshwalawender/received_events","type":"User","site_admin":false},"body":"I've replaced the functionality in IO.imcombine and IO.imarith with equivalent functionality using either numpy or ccdproc.  \r\n\r\nThe pyRAF based functions are still in the code as imarith_iraf() and imcombine_iraf() alongside the new imarith_noiraf() and imcombine_noiraf().  To allow use of either, the IO.imarith() function just calls imarith_noiraf() and similarly for IO.imcombine().\r\n\r\nI've also continued replacing pyfits with astropy.io.fits whoever I found it.\r\n\r\nFor the moment, the imcombine code does not handle any reject options other than \"none\", so \"minmax\", \"sigclip\", etc. will raise NotImplementedErrors. Propagating all this through just takes some bookkeeping, but I wanted to get comments and some testing in first before tackling this.  I don't have much experience with the MOSFIRE DRP, so my testing has been limited, but I did run this through successfully on one observation and compared it with a pyRAF based reduction and they came out identical.","created_at":"2016-04-16T00:40:58Z","updated_at":"2016-04-20T00:41:20Z","closed_at":"2016-04-20T00:41:20Z","merged_at":null,"merge_commit_sha":"693db8cc9f538b55a03b278808f6c0530721b9d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/49/commits","review_comments_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/49/comments","review_comment_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/issues/49/comments","statuses_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/statuses/bd2c707a95a7e54a82a46e9fabfcb291d5579188","head":{"label":"joshwalawender:imcombine","ref":"imcombine","sha":"bd2c707a95a7e54a82a46e9fabfcb291d5579188","user":{"login":"joshwalawender","id":4873464,"avatar_url":"https://avatars.githubusercontent.com/u/4873464?v=3","gravatar_id":"","url":"https://api.github.com/users/joshwalawender","html_url":"https://github.com/joshwalawender","followers_url":"https://api.github.com/users/joshwalawender/followers","following_url":"https://api.github.com/users/joshwalawender/following{/other_user}","gists_url":"https://api.github.com/users/joshwalawender/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwalawender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwalawender/subscriptions","organizations_url":"https://api.github.com/users/joshwalawender/orgs","repos_url":"https://api.github.com/users/joshwalawender/repos","events_url":"https://api.github.com/users/joshwalawender/events{/privacy}","received_events_url":"https://api.github.com/users/joshwalawender/received_events","type":"User","site_admin":false},"repo":{"id":56114536,"name":"MosfireDRP","full_name":"joshwalawender/MosfireDRP","owner":{"login":"joshwalawender","id":4873464,"avatar_url":"https://avatars.githubusercontent.com/u/4873464?v=3","gravatar_id":"","url":"https://api.github.com/users/joshwalawender","html_url":"https://github.com/joshwalawender","followers_url":"https://api.github.com/users/joshwalawender/followers","following_url":"https://api.github.com/users/joshwalawender/following{/other_user}","gists_url":"https://api.github.com/users/joshwalawender/gists{/gist_id}","starred_url":"https://api.github.com/users/joshwalawender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshwalawender/subscriptions","organizations_url":"https://api.github.com/users/joshwalawender/orgs","repos_url":"https://api.github.com/users/joshwalawender/repos","events_url":"https://api.github.com/users/joshwalawender/events{/privacy}","received_events_url":"https://api.github.com/users/joshwalawender/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshwalawender/MosfireDRP","description":"","fork":true,"url":"https://api.github.com/repos/joshwalawender/MosfireDRP","forks_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/forks","keys_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/teams","hooks_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/hooks","issue_events_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/issues/events{/number}","events_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/events","assignees_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/assignees{/user}","branches_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/branches{/branch}","tags_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/tags","blobs_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/statuses/{sha}","languages_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/languages","stargazers_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/stargazers","contributors_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/contributors","subscribers_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/subscribers","subscription_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/subscription","commits_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/contents/{+path}","compare_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/merges","archive_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/downloads","issues_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/issues{/number}","pulls_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/pulls{/number}","milestones_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/milestones{/number}","notifications_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/labels{/name}","releases_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/releases{/id}","deployments_url":"https://api.github.com/repos/joshwalawender/MosfireDRP/deployments","created_at":"2016-04-13T02:33:24Z","updated_at":"2016-04-13T02:33:24Z","pushed_at":"2016-04-16T00:24:11Z","git_url":"git://github.com/joshwalawender/MosfireDRP.git","ssh_url":"git@github.com:joshwalawender/MosfireDRP.git","clone_url":"https://github.com/joshwalawender/MosfireDRP.git","svn_url":"https://github.com/joshwalawender/MosfireDRP","homepage":"http://keck-datareductionpipelines.github.io/MosfireDRP","size":4666,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Keck-DataReductionPipelines:master","ref":"master","sha":"80cc7953b9051c4ca781fadcc74510bac9a492be","user":{"login":"Keck-DataReductionPipelines","id":9344298,"avatar_url":"https://avatars.githubusercontent.com/u/9344298?v=3","gravatar_id":"","url":"https://api.github.com/users/Keck-DataReductionPipelines","html_url":"https://github.com/Keck-DataReductionPipelines","followers_url":"https://api.github.com/users/Keck-DataReductionPipelines/followers","following_url":"https://api.github.com/users/Keck-DataReductionPipelines/following{/other_user}","gists_url":"https://api.github.com/users/Keck-DataReductionPipelines/gists{/gist_id}","starred_url":"https://api.github.com/users/Keck-DataReductionPipelines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keck-DataReductionPipelines/subscriptions","organizations_url":"https://api.github.com/users/Keck-DataReductionPipelines/orgs","repos_url":"https://api.github.com/users/Keck-DataReductionPipelines/repos","events_url":"https://api.github.com/users/Keck-DataReductionPipelines/events{/privacy}","received_events_url":"https://api.github.com/users/Keck-DataReductionPipelines/received_events","type":"Organization","site_admin":false},"repo":{"id":25554170,"name":"MosfireDRP","full_name":"Keck-DataReductionPipelines/MosfireDRP","owner":{"login":"Keck-DataReductionPipelines","id":9344298,"avatar_url":"https://avatars.githubusercontent.com/u/9344298?v=3","gravatar_id":"","url":"https://api.github.com/users/Keck-DataReductionPipelines","html_url":"https://github.com/Keck-DataReductionPipelines","followers_url":"https://api.github.com/users/Keck-DataReductionPipelines/followers","following_url":"https://api.github.com/users/Keck-DataReductionPipelines/following{/other_user}","gists_url":"https://api.github.com/users/Keck-DataReductionPipelines/gists{/gist_id}","starred_url":"https://api.github.com/users/Keck-DataReductionPipelines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keck-DataReductionPipelines/subscriptions","organizations_url":"https://api.github.com/users/Keck-DataReductionPipelines/orgs","repos_url":"https://api.github.com/users/Keck-DataReductionPipelines/repos","events_url":"https://api.github.com/users/Keck-DataReductionPipelines/events{/privacy}","received_events_url":"https://api.github.com/users/Keck-DataReductionPipelines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Keck-DataReductionPipelines/MosfireDRP","description":"","fork":false,"url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP","forks_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/forks","keys_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/teams","hooks_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/hooks","issue_events_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/issues/events{/number}","events_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/events","assignees_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/assignees{/user}","branches_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/branches{/branch}","tags_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/tags","blobs_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/statuses/{sha}","languages_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/languages","stargazers_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/stargazers","contributors_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/contributors","subscribers_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/subscribers","subscription_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/subscription","commits_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/contents/{+path}","compare_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/merges","archive_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/downloads","issues_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/issues{/number}","pulls_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls{/number}","milestones_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/milestones{/number}","notifications_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/labels{/name}","releases_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/releases{/id}","deployments_url":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/deployments","created_at":"2014-10-22T00:57:54Z","updated_at":"2016-02-04T21:06:46Z","pushed_at":"2016-04-20T00:39:44Z","git_url":"git://github.com/Keck-DataReductionPipelines/MosfireDRP.git","ssh_url":"git@github.com:Keck-DataReductionPipelines/MosfireDRP.git","clone_url":"https://github.com/Keck-DataReductionPipelines/MosfireDRP.git","svn_url":"https://github.com/Keck-DataReductionPipelines/MosfireDRP","homepage":"http://keck-datareductionpipelines.github.io/MosfireDRP","size":4743,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/49"},"html":{"href":"https://github.com/Keck-DataReductionPipelines/MosfireDRP/pull/49"},"issue":{"href":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/issues/49"},"comments":{"href":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/Keck-DataReductionPipelines/MosfireDRP/statuses/bd2c707a95a7e54a82a46e9fabfcb291d5579188"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"commits":9,"additions":137,"deletions":4,"changed_files":3}}