{"action":"created","comment":{"url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/comments/59162188","id":59162188,"diff_hunk":"@@ -29,24 +29,27 @@ const ScrollableTabView = React.createClass({\n     renderTabBar: PropTypes.any,\n     style: View.propTypes.style,\n     contentProps: PropTypes.object,\n+    gap: PropTypes.number,\n   },\n \n   getDefaultProps() {\n+    console.log('HELP', this.props)","path":"index.js","position":8,"original_position":8,"commit_id":"31ef041abcf0a39946498165db499649886093bb","original_commit_id":"31ef041abcf0a39946498165db499649886093bb","user":{"login":"skv-headless","id":1488195,"avatar_url":"https://avatars.githubusercontent.com/u/1488195?v=3","gravatar_id":"","url":"https://api.github.com/users/skv-headless","html_url":"https://github.com/skv-headless","followers_url":"https://api.github.com/users/skv-headless/followers","following_url":"https://api.github.com/users/skv-headless/following{/other_user}","gists_url":"https://api.github.com/users/skv-headless/gists{/gist_id}","starred_url":"https://api.github.com/users/skv-headless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skv-headless/subscriptions","organizations_url":"https://api.github.com/users/skv-headless/orgs","repos_url":"https://api.github.com/users/skv-headless/repos","events_url":"https://api.github.com/users/skv-headless/events{/privacy}","received_events_url":"https://api.github.com/users/skv-headless/received_events","type":"User","site_admin":false},"body":"I think it is unnecessary.","created_at":"2016-04-11T07:16:31Z","updated_at":"2016-04-11T07:16:31Z","html_url":"https://github.com/brentvatne/react-native-scrollable-tab-view/pull/231#discussion_r59162188","pull_request_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/comments/59162188"},"html":{"href":"https://github.com/brentvatne/react-native-scrollable-tab-view/pull/231#discussion_r59162188"},"pull_request":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231","id":65805241,"html_url":"https://github.com/brentvatne/react-native-scrollable-tab-view/pull/231","diff_url":"https://github.com/brentvatne/react-native-scrollable-tab-view/pull/231.diff","patch_url":"https://github.com/brentvatne/react-native-scrollable-tab-view/pull/231.patch","issue_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/issues/231","number":231,"state":"open","locked":false,"title":"support for gaps between pages via \"gap\" property","user":{"login":"faceyspacey","id":154732,"avatar_url":"https://avatars.githubusercontent.com/u/154732?v=3","gravatar_id":"","url":"https://api.github.com/users/faceyspacey","html_url":"https://github.com/faceyspacey","followers_url":"https://api.github.com/users/faceyspacey/followers","following_url":"https://api.github.com/users/faceyspacey/following{/other_user}","gists_url":"https://api.github.com/users/faceyspacey/gists{/gist_id}","starred_url":"https://api.github.com/users/faceyspacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceyspacey/subscriptions","organizations_url":"https://api.github.com/users/faceyspacey/orgs","repos_url":"https://api.github.com/users/faceyspacey/repos","events_url":"https://api.github.com/users/faceyspacey/events{/privacy}","received_events_url":"https://api.github.com/users/faceyspacey/received_events","type":"User","site_admin":false},"body":"This allows for easily emulating the gaps between pages, as seen in the Hotel Tonight app:\r\n\r\nhttps://www.youtube.com/watch?v=UPi4PwhJ70E\r\n\r\nTo use it specify it as a prop:\r\n\r\n`<ScrollableTabView gap={250} ...`\r\n\r\nThe way it works is 2 fold:\r\n\r\nA) it adds 4 additional properties to ScrollView if `gap > 0`:\r\n```\r\nsnapToInterval: this.state.containerWidth,\r\nsnapToAlignment: \"start\",\r\npagingEnabled: false,\r\ndecelerationRate: 0,\r\n```\r\n\r\nB) `this.state.containerWidth` is no longer the set to the width of the screen, but the screen + the gap. Then in one important place we subtract the gap: the `containerWidth` prop passed to the tabBar, which doesn't need to know about the true container width, just the size of the tabBar. \r\n\r\n\r\nFINAL NOTE: this is currently only tested for iOS. Some of the \"snapping\" props only work on iOS. ","created_at":"2016-04-08T15:38:53Z","updated_at":"2016-04-11T07:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f971e3919fec2ef91f2f45dcd916652c0a654d31","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231/commits","review_comments_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231/comments","review_comment_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/issues/231/comments","statuses_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/statuses/31ef041abcf0a39946498165db499649886093bb","head":{"label":"faceyspacey:patch-2","ref":"patch-2","sha":"31ef041abcf0a39946498165db499649886093bb","user":{"login":"faceyspacey","id":154732,"avatar_url":"https://avatars.githubusercontent.com/u/154732?v=3","gravatar_id":"","url":"https://api.github.com/users/faceyspacey","html_url":"https://github.com/faceyspacey","followers_url":"https://api.github.com/users/faceyspacey/followers","following_url":"https://api.github.com/users/faceyspacey/following{/other_user}","gists_url":"https://api.github.com/users/faceyspacey/gists{/gist_id}","starred_url":"https://api.github.com/users/faceyspacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceyspacey/subscriptions","organizations_url":"https://api.github.com/users/faceyspacey/orgs","repos_url":"https://api.github.com/users/faceyspacey/repos","events_url":"https://api.github.com/users/faceyspacey/events{/privacy}","received_events_url":"https://api.github.com/users/faceyspacey/received_events","type":"User","site_admin":false},"repo":{"id":52858889,"name":"react-native-scrollable-tab-view","full_name":"faceyspacey/react-native-scrollable-tab-view","owner":{"login":"faceyspacey","id":154732,"avatar_url":"https://avatars.githubusercontent.com/u/154732?v=3","gravatar_id":"","url":"https://api.github.com/users/faceyspacey","html_url":"https://github.com/faceyspacey","followers_url":"https://api.github.com/users/faceyspacey/followers","following_url":"https://api.github.com/users/faceyspacey/following{/other_user}","gists_url":"https://api.github.com/users/faceyspacey/gists{/gist_id}","starred_url":"https://api.github.com/users/faceyspacey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faceyspacey/subscriptions","organizations_url":"https://api.github.com/users/faceyspacey/orgs","repos_url":"https://api.github.com/users/faceyspacey/repos","events_url":"https://api.github.com/users/faceyspacey/events{/privacy}","received_events_url":"https://api.github.com/users/faceyspacey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faceyspacey/react-native-scrollable-tab-view","description":"Tabbed navigation that you can swipe between, each tab can have  its own ScrollView and maintain its own scroll position between swipes. Pleasantly animated. Customizable tab bar","fork":true,"url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view","forks_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/forks","keys_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/teams","hooks_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/hooks","issue_events_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/issues/events{/number}","events_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/events","assignees_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/assignees{/user}","branches_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/branches{/branch}","tags_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/tags","blobs_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/statuses/{sha}","languages_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/languages","stargazers_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/stargazers","contributors_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/contributors","subscribers_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/subscribers","subscription_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/subscription","commits_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/contents/{+path}","compare_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/merges","archive_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/downloads","issues_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/issues{/number}","pulls_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/pulls{/number}","milestones_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/milestones{/number}","notifications_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/labels{/name}","releases_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/releases{/id}","deployments_url":"https://api.github.com/repos/faceyspacey/react-native-scrollable-tab-view/deployments","created_at":"2016-03-01T07:56:40Z","updated_at":"2016-03-01T07:56:41Z","pushed_at":"2016-04-08T15:36:12Z","git_url":"git://github.com/faceyspacey/react-native-scrollable-tab-view.git","ssh_url":"git@github.com:faceyspacey/react-native-scrollable-tab-view.git","clone_url":"https://github.com/faceyspacey/react-native-scrollable-tab-view.git","svn_url":"https://github.com/faceyspacey/react-native-scrollable-tab-view","homepage":"https://www.npmjs.com/package/react-native-scrollable-tab-view","size":5357,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brentvatne:master","ref":"master","sha":"cef74189017176233b8d2bd516414eeb809583cc","user":{"login":"brentvatne","id":90494,"avatar_url":"https://avatars.githubusercontent.com/u/90494?v=3","gravatar_id":"","url":"https://api.github.com/users/brentvatne","html_url":"https://github.com/brentvatne","followers_url":"https://api.github.com/users/brentvatne/followers","following_url":"https://api.github.com/users/brentvatne/following{/other_user}","gists_url":"https://api.github.com/users/brentvatne/gists{/gist_id}","starred_url":"https://api.github.com/users/brentvatne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentvatne/subscriptions","organizations_url":"https://api.github.com/users/brentvatne/orgs","repos_url":"https://api.github.com/users/brentvatne/repos","events_url":"https://api.github.com/users/brentvatne/events{/privacy}","received_events_url":"https://api.github.com/users/brentvatne/received_events","type":"User","site_admin":false},"repo":{"id":37240232,"name":"react-native-scrollable-tab-view","full_name":"brentvatne/react-native-scrollable-tab-view","owner":{"login":"brentvatne","id":90494,"avatar_url":"https://avatars.githubusercontent.com/u/90494?v=3","gravatar_id":"","url":"https://api.github.com/users/brentvatne","html_url":"https://github.com/brentvatne","followers_url":"https://api.github.com/users/brentvatne/followers","following_url":"https://api.github.com/users/brentvatne/following{/other_user}","gists_url":"https://api.github.com/users/brentvatne/gists{/gist_id}","starred_url":"https://api.github.com/users/brentvatne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentvatne/subscriptions","organizations_url":"https://api.github.com/users/brentvatne/orgs","repos_url":"https://api.github.com/users/brentvatne/repos","events_url":"https://api.github.com/users/brentvatne/events{/privacy}","received_events_url":"https://api.github.com/users/brentvatne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brentvatne/react-native-scrollable-tab-view","description":"Tabbed navigation that you can swipe between, each tab can have  its own ScrollView and maintain its own scroll position between swipes. Pleasantly animated. Customizable tab bar","fork":false,"url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view","forks_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/forks","keys_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/teams","hooks_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/hooks","issue_events_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/issues/events{/number}","events_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/events","assignees_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/assignees{/user}","branches_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/branches{/branch}","tags_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/tags","blobs_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/statuses/{sha}","languages_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/languages","stargazers_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/stargazers","contributors_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/contributors","subscribers_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/subscribers","subscription_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/subscription","commits_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/contents/{+path}","compare_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/merges","archive_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/downloads","issues_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/issues{/number}","pulls_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls{/number}","milestones_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/milestones{/number}","notifications_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/labels{/name}","releases_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/releases{/id}","deployments_url":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/deployments","created_at":"2015-06-11T05:01:07Z","updated_at":"2016-04-11T07:12:30Z","pushed_at":"2016-04-10T10:39:01Z","git_url":"git://github.com/brentvatne/react-native-scrollable-tab-view.git","ssh_url":"git@github.com:brentvatne/react-native-scrollable-tab-view.git","clone_url":"https://github.com/brentvatne/react-native-scrollable-tab-view.git","svn_url":"https://github.com/brentvatne/react-native-scrollable-tab-view","homepage":"https://www.npmjs.com/package/react-native-scrollable-tab-view","size":6631,"stargazers_count":1020,"watchers_count":1020,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"open_issues_count":47,"forks":241,"open_issues":47,"watchers":1020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231"},"html":{"href":"https://github.com/brentvatne/react-native-scrollable-tab-view/pull/231"},"issue":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/issues/231"},"comments":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/brentvatne/react-native-scrollable-tab-view/statuses/31ef041abcf0a39946498165db499649886093bb"}}}}