{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2372","repository_url":"https://api.github.com/repos/ansible/ansible-modules-core","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2372/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2372/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2372/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/2372","id":113711819,"number":2372,"title":"Improves command warnings for commands which require special arguments","user":{"login":"kustodian","id":1949229,"avatar_url":"https://avatars.githubusercontent.com/u/1949229?v=3","gravatar_id":"","url":"https://api.github.com/users/kustodian","html_url":"https://github.com/kustodian","followers_url":"https://api.github.com/users/kustodian/followers","following_url":"https://api.github.com/users/kustodian/following{/other_user}","gists_url":"https://api.github.com/users/kustodian/gists{/gist_id}","starred_url":"https://api.github.com/users/kustodian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kustodian/subscriptions","organizations_url":"https://api.github.com/users/kustodian/orgs","repos_url":"https://api.github.com/users/kustodian/repos","events_url":"https://api.github.com/users/kustodian/events{/privacy}","received_events_url":"https://api.github.com/users/kustodian/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/feature_pull_request","name":"feature_pull_request","color":"009800"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/needs_revision","name":"needs_revision","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/milestones/1","html_url":"https://github.com/ansible/ansible-modules-core/milestones/2.1.0","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/milestones/1/labels","id":996115,"number":1,"title":"2.1.0","description":"","creator":{"login":"bcoca","id":836171,"avatar_url":"https://avatars.githubusercontent.com/u/836171?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoca","html_url":"https://github.com/bcoca","followers_url":"https://api.github.com/users/bcoca/followers","following_url":"https://api.github.com/users/bcoca/following{/other_user}","gists_url":"https://api.github.com/users/bcoca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoca/subscriptions","organizations_url":"https://api.github.com/users/bcoca/orgs","repos_url":"https://api.github.com/users/bcoca/repos","events_url":"https://api.github.com/users/bcoca/events{/privacy}","received_events_url":"https://api.github.com/users/bcoca/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":97,"state":"open","created_at":"2015-02-26T01:01:13Z","updated_at":"2016-04-27T15:16:29Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-10-27T23:34:51Z","updated_at":"2016-05-01T09:33:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/2372","html_url":"https://github.com/ansible/ansible-modules-core/pull/2372","diff_url":"https://github.com/ansible/ansible-modules-core/pull/2372.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/2372.patch"},"body":"This pull request improves how Ansible warns about specific commands. For commands like `service nginx restart`, or `systemctl restart nginx` it will only print a warning if those commands are called with arguments which are supported by the service module (`start`, `stop`, `restarted` or `reloaded`), for any other argument a warning wont be printed.\r\n\r\nI tried to make it as generic as possible, so just editing the `commands_with_args` correctly should work for any future command.\r\n\r\nIt also fixes #2266"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/216030730","html_url":"https://github.com/ansible/ansible-modules-core/pull/2372#issuecomment-216030730","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/2372","id":216030730,"user":{"login":"gregdek","id":252125,"avatar_url":"https://avatars.githubusercontent.com/u/252125?v=3","gravatar_id":"","url":"https://api.github.com/users/gregdek","html_url":"https://github.com/gregdek","followers_url":"https://api.github.com/users/gregdek/followers","following_url":"https://api.github.com/users/gregdek/following{/other_user}","gists_url":"https://api.github.com/users/gregdek/gists{/gist_id}","starred_url":"https://api.github.com/users/gregdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregdek/subscriptions","organizations_url":"https://api.github.com/users/gregdek/orgs","repos_url":"https://api.github.com/users/gregdek/repos","events_url":"https://api.github.com/users/gregdek/events{/privacy}","received_events_url":"https://api.github.com/users/gregdek/received_events","type":"User","site_admin":false},"created_at":"2016-05-01T09:33:09Z","updated_at":"2016-05-01T09:33:09Z","body":"Thanks @kustodian for this PR. Unfortunately, it is not mergeable in its current state due to merge conflicts. Please rebase your PR. When you are done, please comment with text 'ready_for_review' and we will put this PR back into review.\n\n[This message brought to you by your friendly Ansibull-bot.]"}}