{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/52143630","id":52143630,"diff_hunk":"@@ -0,0 +1,151 @@\n+/*\n+Copyright 2015 The Kubernetes Authors All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package schedulercache\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"k8s.io/kubernetes/pkg/api\"\n+\tclientcache \"k8s.io/kubernetes/pkg/client/cache\"\n+\t\"k8s.io/kubernetes/plugin/pkg/scheduler/algorithm/priorities/priorityutil\"\n+)\n+\n+var emptyResource = Resource{}\n+\n+// NodeInfo is node level aggregated information.\n+type NodeInfo struct {\n+\t// Total requested resource of all pods (including assumed ones) on this node\n+\trequestedResource *Resource\n+\tpods              []*api.Pod\n+\tnonzeroRequest    *Resource\n+}\n+\n+// Resource is a collection of compute resource\n+type Resource struct {\n+\tMilliCPU int64\n+\tMemory   int64\n+}\n+\n+// NewNodeInfo returns a ready to use empty NodeInfo object.\n+// If any pods are given in arguments, their information will be aggregated in\n+// the returned object.\n+func NewNodeInfo(pods ...*api.Pod) *NodeInfo {\n+\tni := &NodeInfo{\n+\t\trequestedResource: &Resource{},\n+\t\tnonzeroRequest:    &Resource{},\n+\t}\n+\tfor _, pod := range pods {\n+\t\tni.addPod(pod)\n+\t}\n+\treturn ni\n+}\n+\n+// Pods return all pods scheduled (including assumed to be) on this node","path":"plugin/pkg/scheduler/schedulercache/node_info.go","position":57,"original_position":57,"commit_id":"8770b4772e942c2b4e8519c796b5f84bcd25e196","original_commit_id":"8770b4772e942c2b4e8519c796b5f84bcd25e196","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"nit: \".\" at the end of comment.","created_at":"2016-02-08T08:52:45Z","updated_at":"2016-02-08T08:52:45Z","html_url":"https://github.com/kubernetes/kubernetes/pull/20669#discussion_r52143630","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/52143630"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20669#discussion_r52143630"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669","id":58351414,"html_url":"https://github.com/kubernetes/kubernetes/pull/20669","diff_url":"https://github.com/kubernetes/kubernetes/pull/20669.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/20669.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20669","number":20669,"state":"open","locked":false,"title":"Scheduler Optimization","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"body":"ref #18831 \r\n\r\nWe at CoreOS are trying to contribute our improvement work to upstream. We took @davidopp 's advice to maintain the optimization in our fork.\r\n\r\nThe work has been through internal review and testing. I would like to get it to upstream at the moment for open review. \r\n\r\nLet me know if anyone have thoughts and comments.","created_at":"2016-02-04T21:25:02Z","updated_at":"2016-02-08T08:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ac50f8a85af8221e74e38d998f25a89c627f6af","assignee":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/20669/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8770b4772e942c2b4e8519c796b5f84bcd25e196","head":{"label":"hongchaodeng:sched","ref":"sched","sha":"8770b4772e942c2b4e8519c796b5f84bcd25e196","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"repo":{"id":45423343,"name":"kubernetes","full_name":"hongchaodeng/kubernetes","owner":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hongchaodeng/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/hongchaodeng/kubernetes","forks_url":"https://api.github.com/repos/hongchaodeng/kubernetes/forks","keys_url":"https://api.github.com/repos/hongchaodeng/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hongchaodeng/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hongchaodeng/kubernetes/teams","hooks_url":"https://api.github.com/repos/hongchaodeng/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hongchaodeng/kubernetes/events","assignees_url":"https://api.github.com/repos/hongchaodeng/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hongchaodeng/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hongchaodeng/kubernetes/tags","blobs_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hongchaodeng/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hongchaodeng/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hongchaodeng/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hongchaodeng/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hongchaodeng/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hongchaodeng/kubernetes/subscription","commits_url":"https://api.github.com/repos/hongchaodeng/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hongchaodeng/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hongchaodeng/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hongchaodeng/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hongchaodeng/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hongchaodeng/kubernetes/merges","archive_url":"https://api.github.com/repos/hongchaodeng/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hongchaodeng/kubernetes/downloads","issues_url":"https://api.github.com/repos/hongchaodeng/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hongchaodeng/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hongchaodeng/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hongchaodeng/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hongchaodeng/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hongchaodeng/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hongchaodeng/kubernetes/deployments","created_at":"2015-11-02T21:30:01Z","updated_at":"2016-01-13T18:34:57Z","pushed_at":"2016-02-06T21:25:41Z","git_url":"git://github.com/hongchaodeng/kubernetes.git","ssh_url":"git@github.com:hongchaodeng/kubernetes.git","clone_url":"https://github.com/hongchaodeng/kubernetes.git","svn_url":"https://github.com/hongchaodeng/kubernetes","homepage":"http://kubernetes.io","size":159663,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"87fbfdc953dc4379af8a2ba71ee4c7d65354d921","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-08T04:22:58Z","pushed_at":"2016-02-08T08:40:50Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":319230,"stargazers_count":12563,"watchers_count":12563,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3573,"mirror_url":null,"open_issues_count":2807,"forks":3573,"open_issues":2807,"watchers":12563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/20669"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20669"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/20669/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/20669/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8770b4772e942c2b4e8519c796b5f84bcd25e196"}}}}