{"action":"closed","number":2567,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2567","id":70065222,"html_url":"https://github.com/ethereum/go-ethereum/pull/2567","diff_url":"https://github.com/ethereum/go-ethereum/pull/2567.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/2567.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2567","number":2567,"state":"closed","locked":false,"title":"cmd/geth: fix console history exclusion","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"body":"Calls to 'personal' API should be excluded from console history because\r\nthey can be called with an account passphrase as argument. The check for\r\nsuch calls was inverted and didn't work.","created_at":"2016-05-13T22:07:59Z","updated_at":"2016-05-17T10:04:58Z","closed_at":"2016-05-17T10:04:58Z","merged_at":"2016-05-17T10:04:58Z","merge_commit_sha":"adc1b503957e572c4ec30533de3ec28ec6feea13","assignee":null,"milestone":{"url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/33","html_url":"https://github.com/ethereum/go-ethereum/milestones/1.4.5","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones/33/labels","id":1763069,"number":33,"title":"1.4.5","description":"","creator":{"login":"obscuren","id":6264126,"avatar_url":"https://avatars.githubusercontent.com/u/6264126?v=3","gravatar_id":"","url":"https://api.github.com/users/obscuren","html_url":"https://github.com/obscuren","followers_url":"https://api.github.com/users/obscuren/followers","following_url":"https://api.github.com/users/obscuren/following{/other_user}","gists_url":"https://api.github.com/users/obscuren/gists{/gist_id}","starred_url":"https://api.github.com/users/obscuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obscuren/subscriptions","organizations_url":"https://api.github.com/users/obscuren/orgs","repos_url":"https://api.github.com/users/obscuren/repos","events_url":"https://api.github.com/users/obscuren/events{/privacy}","received_events_url":"https://api.github.com/users/obscuren/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2016-05-12T18:51:42Z","updated_at":"2016-05-17T10:04:58Z","due_on":"2016-05-16T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2567/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2567/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/2567/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/86da6feb40fd366c75236d87fa306576c51ed2a8","head":{"label":"fjl:console-history-exclude","ref":"console-history-exclude","sha":"86da6feb40fd366c75236d87fa306576c51ed2a8","user":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"repo":{"id":24951427,"name":"go-ethereum","full_name":"fjl/go-ethereum","owner":{"login":"fjl","id":6915,"avatar_url":"https://avatars.githubusercontent.com/u/6915?v=3","gravatar_id":"","url":"https://api.github.com/users/fjl","html_url":"https://github.com/fjl","followers_url":"https://api.github.com/users/fjl/followers","following_url":"https://api.github.com/users/fjl/following{/other_user}","gists_url":"https://api.github.com/users/fjl/gists{/gist_id}","starred_url":"https://api.github.com/users/fjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjl/subscriptions","organizations_url":"https://api.github.com/users/fjl/orgs","repos_url":"https://api.github.com/users/fjl/repos","events_url":"https://api.github.com/users/fjl/events{/privacy}","received_events_url":"https://api.github.com/users/fjl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fjl/go-ethereum","description":"Work fork of go-ethereum.","fork":true,"url":"https://api.github.com/repos/fjl/go-ethereum","forks_url":"https://api.github.com/repos/fjl/go-ethereum/forks","keys_url":"https://api.github.com/repos/fjl/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fjl/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fjl/go-ethereum/teams","hooks_url":"https://api.github.com/repos/fjl/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/fjl/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/fjl/go-ethereum/events","assignees_url":"https://api.github.com/repos/fjl/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/fjl/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/fjl/go-ethereum/tags","blobs_url":"https://api.github.com/repos/fjl/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fjl/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fjl/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/fjl/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fjl/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/fjl/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/fjl/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/fjl/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/fjl/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/fjl/go-ethereum/subscription","commits_url":"https://api.github.com/repos/fjl/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/fjl/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/fjl/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/fjl/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/fjl/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/fjl/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fjl/go-ethereum/merges","archive_url":"https://api.github.com/repos/fjl/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fjl/go-ethereum/downloads","issues_url":"https://api.github.com/repos/fjl/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/fjl/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/fjl/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/fjl/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fjl/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/fjl/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/fjl/go-ethereum/deployments","created_at":"2014-10-08T17:12:04Z","updated_at":"2015-05-29T23:48:03Z","pushed_at":"2016-05-15T13:08:21Z","git_url":"git://github.com/fjl/go-ethereum.git","ssh_url":"git@github.com:fjl/go-ethereum.git","clone_url":"https://github.com/fjl/go-ethereum.git","svn_url":"https://github.com/fjl/go-ethereum","homepage":"","size":55794,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"fe532a98f9f32bb81ef0d8d013cf44327830d11e","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official golang implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2016-05-17T09:48:47Z","pushed_at":"2016-05-17T10:04:58Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"http://ethereum.github.io/go-ethereum/","size":160853,"stargazers_count":1473,"watchers_count":1473,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":469,"mirror_url":null,"open_issues_count":219,"forks":469,"open_issues":219,"watchers":1473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2567"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/2567"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/2567"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/2567/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2567/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/2567/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/86da6feb40fd366c75236d87fa306576c51ed2a8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"obscuren","id":6264126,"avatar_url":"https://avatars.githubusercontent.com/u/6264126?v=3","gravatar_id":"","url":"https://api.github.com/users/obscuren","html_url":"https://github.com/obscuren","followers_url":"https://api.github.com/users/obscuren/followers","following_url":"https://api.github.com/users/obscuren/following{/other_user}","gists_url":"https://api.github.com/users/obscuren/gists{/gist_id}","starred_url":"https://api.github.com/users/obscuren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obscuren/subscriptions","organizations_url":"https://api.github.com/users/obscuren/orgs","repos_url":"https://api.github.com/users/obscuren/repos","events_url":"https://api.github.com/users/obscuren/events{/privacy}","received_events_url":"https://api.github.com/users/obscuren/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":3,"deletions":6,"changed_files":1}}