{"action":"created","comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/comments/68242024","id":68242024,"diff_hunk":"@@ -254,7 +254,14 @@ private XMLObject unmarshall(String samlString) throws PassiveSTSException {\n             NodeList nodeList = element.getElementsByTagNameNS(\"http://docs.oasis-open.org/ws-sx/ws-trust/200512\",\n                     \"RequestedSecurityToken\");\n             if (nodeList == null || nodeList.getLength() == 0) {\n-                throw new PassiveSTSException(\"Security Token is not found in the Response\");\n+                nodeList = element.getElementsByTagNameNS(\"http://schemas.xmlsoap.org/ws/2005/02/trust\",\n+                        \"RequestedSecurityToken\");\n+\n+                if(nodeList == null || nodeList.getLength() == 0) {\n+                    throw new PassiveSTSException(\"Security Token is not found in the Response\");\n+                }\n+\n+                log.debug(\"Qualifying 'http://schemas.xmlsoap.org/ws/2005/02/trust' as the Request Security Token Response\");","path":"components/org.wso2.carbon.identity.application.authenticator.passive.sts/src/main/java/org/wso2/carbon/identity/application/authenticator/passive/sts/manager/PassiveSTSManager.java","position":12,"original_position":12,"commit_id":"98bbad114b129bbec02dcfbd5213b4f41b428d49","original_commit_id":"98bbad114b129bbec02dcfbd5213b4f41b428d49","user":{"login":"godwinamila","id":8766778,"avatar_url":"https://avatars.githubusercontent.com/u/8766778?v=3","gravatar_id":"","url":"https://api.github.com/users/godwinamila","html_url":"https://github.com/godwinamila","followers_url":"https://api.github.com/users/godwinamila/followers","following_url":"https://api.github.com/users/godwinamila/following{/other_user}","gists_url":"https://api.github.com/users/godwinamila/gists{/gist_id}","starred_url":"https://api.github.com/users/godwinamila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godwinamila/subscriptions","organizations_url":"https://api.github.com/users/godwinamila/orgs","repos_url":"https://api.github.com/users/godwinamila/repos","events_url":"https://api.github.com/users/godwinamila/events{/privacy}","received_events_url":"https://api.github.com/users/godwinamila/received_events","type":"User","site_admin":false},"body":"check isDebugEnabled when use debug logs.","created_at":"2016-06-23T14:15:37Z","updated_at":"2016-06-23T14:15:37Z","html_url":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts/pull/10#discussion_r68242024","pull_request_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/comments/68242024"},"html":{"href":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts/pull/10#discussion_r68242024"},"pull_request":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10","id":74941805,"html_url":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts/pull/10","diff_url":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts/pull/10.diff","patch_url":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts/pull/10.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/issues/10","number":10,"state":"open","locked":false,"title":"Fixing https://wso2.org/jira/browse/IDENTITY-4722","user":{"login":"Vishanth","id":3367407,"avatar_url":"https://avatars.githubusercontent.com/u/3367407?v=3","gravatar_id":"","url":"https://api.github.com/users/Vishanth","html_url":"https://github.com/Vishanth","followers_url":"https://api.github.com/users/Vishanth/followers","following_url":"https://api.github.com/users/Vishanth/following{/other_user}","gists_url":"https://api.github.com/users/Vishanth/gists{/gist_id}","starred_url":"https://api.github.com/users/Vishanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vishanth/subscriptions","organizations_url":"https://api.github.com/users/Vishanth/orgs","repos_url":"https://api.github.com/users/Vishanth/repos","events_url":"https://api.github.com/users/Vishanth/events{/privacy}","received_events_url":"https://api.github.com/users/Vishanth/received_events","type":"User","site_admin":false},"body":"Fixing the issue RequestSecurityToken Response is not qualified for \"http://schemas.xmlsoap.org/ws/2005/02/trust\"","created_at":"2016-06-23T11:55:49Z","updated_at":"2016-06-23T14:15:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2fa9729a248a460686abb14dfdb601362925676","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/issues/10/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/statuses/98bbad114b129bbec02dcfbd5213b4f41b428d49","head":{"label":"Vishanth:master","ref":"master","sha":"98bbad114b129bbec02dcfbd5213b4f41b428d49","user":{"login":"Vishanth","id":3367407,"avatar_url":"https://avatars.githubusercontent.com/u/3367407?v=3","gravatar_id":"","url":"https://api.github.com/users/Vishanth","html_url":"https://github.com/Vishanth","followers_url":"https://api.github.com/users/Vishanth/followers","following_url":"https://api.github.com/users/Vishanth/following{/other_user}","gists_url":"https://api.github.com/users/Vishanth/gists{/gist_id}","starred_url":"https://api.github.com/users/Vishanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vishanth/subscriptions","organizations_url":"https://api.github.com/users/Vishanth/orgs","repos_url":"https://api.github.com/users/Vishanth/repos","events_url":"https://api.github.com/users/Vishanth/events{/privacy}","received_events_url":"https://api.github.com/users/Vishanth/received_events","type":"User","site_admin":false},"repo":{"id":61800953,"name":"identity-outbound-auth-passive-sts","full_name":"Vishanth/identity-outbound-auth-passive-sts","owner":{"login":"Vishanth","id":3367407,"avatar_url":"https://avatars.githubusercontent.com/u/3367407?v=3","gravatar_id":"","url":"https://api.github.com/users/Vishanth","html_url":"https://github.com/Vishanth","followers_url":"https://api.github.com/users/Vishanth/followers","following_url":"https://api.github.com/users/Vishanth/following{/other_user}","gists_url":"https://api.github.com/users/Vishanth/gists{/gist_id}","starred_url":"https://api.github.com/users/Vishanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vishanth/subscriptions","organizations_url":"https://api.github.com/users/Vishanth/orgs","repos_url":"https://api.github.com/users/Vishanth/repos","events_url":"https://api.github.com/users/Vishanth/events{/privacy}","received_events_url":"https://api.github.com/users/Vishanth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vishanth/identity-outbound-auth-passive-sts","description":"","fork":true,"url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts","forks_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/forks","keys_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/teams","hooks_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/hooks","issue_events_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/issues/events{/number}","events_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/events","assignees_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/assignees{/user}","branches_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/branches{/branch}","tags_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/tags","blobs_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/statuses/{sha}","languages_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/languages","stargazers_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/stargazers","contributors_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/contributors","subscribers_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/subscribers","subscription_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/subscription","commits_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/contents/{+path}","compare_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/merges","archive_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/downloads","issues_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/issues{/number}","pulls_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/pulls{/number}","milestones_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/milestones{/number}","notifications_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/labels{/name}","releases_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/releases{/id}","deployments_url":"https://api.github.com/repos/Vishanth/identity-outbound-auth-passive-sts/deployments","created_at":"2016-06-23T11:44:48Z","updated_at":"2016-06-23T11:44:50Z","pushed_at":"2016-06-23T11:54:48Z","git_url":"git://github.com/Vishanth/identity-outbound-auth-passive-sts.git","ssh_url":"git@github.com:Vishanth/identity-outbound-auth-passive-sts.git","clone_url":"https://github.com/Vishanth/identity-outbound-auth-passive-sts.git","svn_url":"https://github.com/Vishanth/identity-outbound-auth-passive-sts","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:master","ref":"master","sha":"d87faa5bd70426c6ce93da5b47889be1421585ea","user":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":52718255,"name":"identity-outbound-auth-passive-sts","full_name":"wso2-extensions/identity-outbound-auth-passive-sts","owner":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars.githubusercontent.com/u/17171218?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts","description":"","fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts","forks_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/deployments","created_at":"2016-02-28T11:40:49Z","updated_at":"2016-03-03T05:54:57Z","pushed_at":"2016-06-23T11:55:49Z","git_url":"git://github.com/wso2-extensions/identity-outbound-auth-passive-sts.git","ssh_url":"git@github.com:wso2-extensions/identity-outbound-auth-passive-sts.git","clone_url":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts.git","svn_url":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10"},"html":{"href":"https://github.com/wso2-extensions/identity-outbound-auth-passive-sts/pull/10"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/issues/10"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-outbound-auth-passive-sts/statuses/98bbad114b129bbec02dcfbd5213b4f41b428d49"}}}}
{"actor":{"display_login":"godwinamila"}}