{"push_id":1272195855,"size":26,"distinct_size":0,"ref":"refs/heads/master","head":"a8f0e72ddc83c14ac1e7a3a63feee4ccaf296a04","before":"368c7a8fa49f1eca13d1b218c876bc2e3ba5ddd0","commits":[{"sha":"0e521b90e1283673462ea7b493b8ca07dd26404a","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"SceneProcessorTest : Expose inability to promote filter inputs.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/0e521b90e1283673462ea7b493b8ca07dd26404a"},{"sha":"26cbd3d2d4c05a687a28ddd75e88162e32a787c4","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"FilterSwitchTest : Expose bug from issue #1814.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/26cbd3d2d4c05a687a28ddd75e88162e32a787c4"},{"sha":"f9f58b18be8ab2bcf617415ed02fd2188994446a","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"GafferScene : Add FilterPlug.\n\nTo date, we've been using a plain old IntPlug to provide the output of a Filter node and the input to a FilteredSceneProcessor. But this alone was insufficient to provide the guarantee that only Filter outputs could be connected to a FilteredSceneProcessor input. We used FilteredSceneProcessor::acceptsInput() to add constraints in an attempt to enforce this, but these have their problems as witnessed by #1814 and `SceneProcessorTest.testDeriveAndUseExternalFilters`.\n\nThe FilterPlug is intended to provide a stronger mechanism for making the guarantees we need. By using a dedicated plug type, we ensure that the plug semantics are preserved when undergoing promotion, and nodes can rely on the plug type rather than a custom `acceptsInput()` method which will become more flawed as other means of duplicating/promoting plugs appear in the future.\n\nThis is a pattern that has repeated itself every single time we've used a less strongly typed plug along with a custom `Node::acceptsInput()` implementation, rather than use a custom plug type from the outset. We've already made an analogous transition from Plug to TaskPlug in GafferDispatch, and shortly will be adding a ShaderPlug for use as the input to a ShaderAssignment. The rationale for the original implementations was to reduce the proliferation of many specialist plug types, but it seems clear at this point that the general rule should be that a custom plug type should be preferred to `Node::acceptsInput` overloads.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/f9f58b18be8ab2bcf617415ed02fd2188994446a"},{"sha":"823d16ae8a27fe2696b62cdc85ce0eae795c66b3","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"NumericPlug : Make `setFrom()` compatible with subclassing.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/823d16ae8a27fe2696b62cdc85ce0eae795c66b3"},{"sha":"343090e32ce1f9fcbc3dac5964837f519dc7aff6","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Filter/FilterProcessor/FilteredSceneProcessor : Use FilterPlug.\n\nThis allows us to remove the problematic `Node::acceptsInput()` overload logic. A couple of test cases needed tweaking to accommodate the slightly modified logic, but the failure cases were not representative of current practice.\n\nFixes #1814.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/343090e32ce1f9fcbc3dac5964837f519dc7aff6"},{"sha":"cb9e9136a3294cd95c13a50ec87f729123d00824","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"ArrayPlug : Support IntPlug->FilterPlug transition.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/cb9e9136a3294cd95c13a50ec87f729123d00824"},{"sha":"5819db9aca9d3c454ac9e729c78ec55c8b47e494","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Remove unused BlockedConnection.h includes.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/5819db9aca9d3c454ac9e729c78ec55c8b47e494"},{"sha":"349a1b4a58dfbdae38bd1ddd61b031567966261d","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Arnold ParameterHandler : Support gaffer.plugType metadata.\n\nCurrently only implemented for RGBA parameters, where you can now optionally represent them as Color3fPlugs in Gaffer. Rewrote the plug creation for RGB and RGBA parameters to allow the reuse of suitable plugs in the same way as we do for `OSLShader::loadShader()`, making some progress towards adding a `keepExistingValues` argument to `ArnoldShader::loadShader()`.\n\nThe main use of this is to use a metadata file to cause ray_switch and bump shaders to have Color3f inputs compatible with the outputs from most regular shaders. This is something of a stopgap measure until we can improve the UI to support RGB->RGBA connections well.\n\nRequires ImageEngine/cortex#514 to be useful, but doesn't have a hard dependency.\n\nBreaking Changes :\n\n- Added an argument to GafferArnold::ParameterAlgo::setupPlug().","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/349a1b4a58dfbdae38bd1ddd61b031567966261d"},{"sha":"9e434806defeda768864f4740c89a52ca2980e54","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"GafferArnold : Use new read/write UniverseBlock arguments.\n\nThis means we now emit an error when a second arnold render is attempted in the same process, rather than fail in bizarre ways.\n\nRequires ImageEngine/cortex/#514","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/9e434806defeda768864f4740c89a52ca2980e54"},{"sha":"2ae408b13fd478d9fda8a44bc5b874886e61eb97","author":{"name":"Andrew Kaufman","email":"ec979013f75148976dab5141b25077cde0e96c6b@gmail.com"},"message":"Merge pull request #1817 from johnhaddon/arnoldShaderMetadata\n\nArnold ParameterHandler : Support gaffer.plugType metadata.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/2ae408b13fd478d9fda8a44bc5b874886e61eb97"},{"sha":"8630b7180b36ed71b658fbb57f9933ba7baf4abf","author":{"name":"Andrew Kaufman","email":"ec979013f75148976dab5141b25077cde0e96c6b@gmail.com"},"message":"Merge pull request #1816 from johnhaddon/removeBlockedConnectionIncludes\n\nRemove unused BlockedConnection.h includes.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/8630b7180b36ed71b658fbb57f9933ba7baf4abf"},{"sha":"c92aa248b622eaaef39ca744c9ec367191d7e3b8","author":{"name":"Andrew Kaufman","email":"ec979013f75148976dab5141b25077cde0e96c6b@gmail.com"},"message":"Merge pull request #1815 from johnhaddon/filterInputs\n\nFilterPlug","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/c92aa248b622eaaef39ca744c9ec367191d7e3b8"},{"sha":"60856bbe2f9f4a4b9c7d88cb2f47d2bda739024e","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Arnold ShaderAlgo : Support SplineData parameters.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/60856bbe2f9f4a4b9c7d88cb2f47d2bda739024e"},{"sha":"653fa7d83df833a6237f7098a1d0462a1f3d2297","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"OSL : Move OSL_SHADER_PATHS setup to wrapper.\n\nWe want to use OSL shaders from modules other than GafferOSL, so it is not sufficient to set up the paths in the init for that module.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/653fa7d83df833a6237f7098a1d0462a1f3d2297"},{"sha":"32a318594fdf0e8a52ba22c9f32d4531c7f46be7","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Arnold : Support OSL shaders.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/32a318594fdf0e8a52ba22c9f32d4531c7f46be7"},{"sha":"214b1c701da5ad10f3e192713fe99de70100071a","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"OSLShader : Allow input connections from ArnoldShaders.\n\nThis is necessary because Arnold allows native shaders to be mixed and matched with OSL shaders freely.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/214b1c701da5ad10f3e192713fe99de70100071a"},{"sha":"5572a7ec76d7f84734975a34fd0523e8ffa3bf71","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Dispatcher : Fix performance for complex graphs.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/5572a7ec76d7f84734975a34fd0523e8ffa3bf71"},{"sha":"0076e5fa6fbfc9e860284e848525c92c978da013","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"LocalDispatcher : Fix performance for complex graphs.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/0076e5fa6fbfc9e860284e848525c92c978da013"},{"sha":"38b76c2c87963cc9ce2ee5b8ca86e9de8da1f74e","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"LocalDispatcher : Fix performance of `Job.kill()`.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/38b76c2c87963cc9ce2ee5b8ca86e9de8da1f74e"},{"sha":"887a5096f62e6c5348f815f8136c3a39ee3832bc","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"LocalDispatcher : Fix Job `description()/statistics()` performance.","distinct":false,"url":"https://api.github.com/repos/HughMacdonald/gaffer/commits/887a5096f62e6c5348f815f8136c3a39ee3832bc"}]}
{"actor":{"display_login":"HughMacdonald"}}