{"action":"created","comment":{"url":"https://api.github.com/repos/predix/acs/pulls/comments/73975049","id":73975049,"diff_hunk":"@@ -203,17 +204,27 @@ private PolicyEvaluationResult evalPolicySet(final PolicySet policySet, final St\n             }\n             result = new PolicyEvaluationResult(effect, new ArrayList<>(subjectAttributes),\n                     new ArrayList<>(resourceAttributes), resolvedResourceUris);\n+        } catch (AttributeTraversalException ae) {\n+            result = setIndeterminateMessage(policySet, subjectIdentifier, resourceURI, ae.getMessage());\n         } catch (Throwable e) {\n-            StringBuilder builder = new StringBuilder();\n-            builder.append(\"Exception occured while evaluating the policy set. Policy Set ID:\")\n-                    .append(policySet.getName()).append(\" subject:\").append(subjectIdentifier)\n-                    .append(\", Resource URI: \").append(resourceURI);\n-            LOGGER.error(builder.toString(), e);\n-            result = new PolicyEvaluationResult(Effect.INDETERMINATE);\n+            result = setIndeterminateMessage(policySet, subjectIdentifier, resourceURI, null);","path":"service/src/main/java/com/ge/predix/acs/service/policy/evaluation/PolicyEvaluationServiceImpl.java","position":21,"original_position":21,"commit_id":"15bfe30e078e41a22ea8fc19477967e0851501df","original_commit_id":"15bfe30e078e41a22ea8fc19477967e0851501df","user":{"login":"sanjeevchopra","id":2023837,"avatar_url":"https://avatars.githubusercontent.com/u/2023837?v=3","gravatar_id":"","url":"https://api.github.com/users/sanjeevchopra","html_url":"https://github.com/sanjeevchopra","followers_url":"https://api.github.com/users/sanjeevchopra/followers","following_url":"https://api.github.com/users/sanjeevchopra/following{/other_user}","gists_url":"https://api.github.com/users/sanjeevchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/sanjeevchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanjeevchopra/subscriptions","organizations_url":"https://api.github.com/users/sanjeevchopra/orgs","repos_url":"https://api.github.com/users/sanjeevchopra/repos","events_url":"https://api.github.com/users/sanjeevchopra/events{/privacy}","received_events_url":"https://api.github.com/users/sanjeevchopra/received_events","type":"User","site_admin":false},"body":"after this change, any unexpected exceptions will not be logged.  lets discuss.","created_at":"2016-08-08T23:30:45Z","updated_at":"2016-08-08T23:30:45Z","html_url":"https://github.com/predix/acs/pull/24#discussion_r73975049","pull_request_url":"https://api.github.com/repos/predix/acs/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/predix/acs/pulls/comments/73975049"},"html":{"href":"https://github.com/predix/acs/pull/24#discussion_r73975049"},"pull_request":{"href":"https://api.github.com/repos/predix/acs/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/predix/acs/pulls/24","id":79949554,"html_url":"https://github.com/predix/acs/pull/24","diff_url":"https://github.com/predix/acs/pull/24.diff","patch_url":"https://github.com/predix/acs/pull/24.patch","issue_url":"https://api.github.com/repos/predix/acs/issues/24","number":24,"state":"open","locked":false,"title":"US9933:  Add message property to PolicyEvaluationResult and return a valid error when traversal limit exceeded","user":{"login":"bsekar","id":20427292,"avatar_url":"https://avatars.githubusercontent.com/u/20427292?v=3","gravatar_id":"","url":"https://api.github.com/users/bsekar","html_url":"https://github.com/bsekar","followers_url":"https://api.github.com/users/bsekar/followers","following_url":"https://api.github.com/users/bsekar/following{/other_user}","gists_url":"https://api.github.com/users/bsekar/gists{/gist_id}","starred_url":"https://api.github.com/users/bsekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsekar/subscriptions","organizations_url":"https://api.github.com/users/bsekar/orgs","repos_url":"https://api.github.com/users/bsekar/repos","events_url":"https://api.github.com/users/bsekar/events{/privacy}","received_events_url":"https://api.github.com/users/bsekar/received_events","type":"User","site_admin":false},"body":"US9933: Add message property to PolicyEvaluationResult and return a valid error when traversal limit exceeded\r\n\r\n- Added test assertion for the expected message when traversal limit is exceeded\r\n- Added test case with subject attribute exceeding limit. Also, added travelsal limit to error message\r\n- Reset Traversal limit at the end of the test\r\n\r\nSigned-off-by: Matias Altman <matias.altman@ge.com>","created_at":"2016-08-03T17:52:22Z","updated_at":"2016-08-08T23:30:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c89c173184f5fecbcdd35e3648f31b0863b656c0","assignee":{"login":"bhuvan-rk","id":16086695,"avatar_url":"https://avatars.githubusercontent.com/u/16086695?v=3","gravatar_id":"","url":"https://api.github.com/users/bhuvan-rk","html_url":"https://github.com/bhuvan-rk","followers_url":"https://api.github.com/users/bhuvan-rk/followers","following_url":"https://api.github.com/users/bhuvan-rk/following{/other_user}","gists_url":"https://api.github.com/users/bhuvan-rk/gists{/gist_id}","starred_url":"https://api.github.com/users/bhuvan-rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhuvan-rk/subscriptions","organizations_url":"https://api.github.com/users/bhuvan-rk/orgs","repos_url":"https://api.github.com/users/bhuvan-rk/repos","events_url":"https://api.github.com/users/bhuvan-rk/events{/privacy}","received_events_url":"https://api.github.com/users/bhuvan-rk/received_events","type":"User","site_admin":false},"assignees":[{"login":"bhuvan-rk","id":16086695,"avatar_url":"https://avatars.githubusercontent.com/u/16086695?v=3","gravatar_id":"","url":"https://api.github.com/users/bhuvan-rk","html_url":"https://github.com/bhuvan-rk","followers_url":"https://api.github.com/users/bhuvan-rk/followers","following_url":"https://api.github.com/users/bhuvan-rk/following{/other_user}","gists_url":"https://api.github.com/users/bhuvan-rk/gists{/gist_id}","starred_url":"https://api.github.com/users/bhuvan-rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhuvan-rk/subscriptions","organizations_url":"https://api.github.com/users/bhuvan-rk/orgs","repos_url":"https://api.github.com/users/bhuvan-rk/repos","events_url":"https://api.github.com/users/bhuvan-rk/events{/privacy}","received_events_url":"https://api.github.com/users/bhuvan-rk/received_events","type":"User","site_admin":false},{"login":"irinaepshteyn","id":16615931,"avatar_url":"https://avatars.githubusercontent.com/u/16615931?v=3","gravatar_id":"","url":"https://api.github.com/users/irinaepshteyn","html_url":"https://github.com/irinaepshteyn","followers_url":"https://api.github.com/users/irinaepshteyn/followers","following_url":"https://api.github.com/users/irinaepshteyn/following{/other_user}","gists_url":"https://api.github.com/users/irinaepshteyn/gists{/gist_id}","starred_url":"https://api.github.com/users/irinaepshteyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irinaepshteyn/subscriptions","organizations_url":"https://api.github.com/users/irinaepshteyn/orgs","repos_url":"https://api.github.com/users/irinaepshteyn/repos","events_url":"https://api.github.com/users/irinaepshteyn/events{/privacy}","received_events_url":"https://api.github.com/users/irinaepshteyn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/predix/acs/pulls/24/commits","review_comments_url":"https://api.github.com/repos/predix/acs/pulls/24/comments","review_comment_url":"https://api.github.com/repos/predix/acs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/predix/acs/issues/24/comments","statuses_url":"https://api.github.com/repos/predix/acs/statuses/15bfe30e078e41a22ea8fc19477967e0851501df","head":{"label":"predix:us9933","ref":"us9933","sha":"15bfe30e078e41a22ea8fc19477967e0851501df","user":{"login":"predix","id":11392808,"avatar_url":"https://avatars.githubusercontent.com/u/11392808?v=3","gravatar_id":"","url":"https://api.github.com/users/predix","html_url":"https://github.com/predix","followers_url":"https://api.github.com/users/predix/followers","following_url":"https://api.github.com/users/predix/following{/other_user}","gists_url":"https://api.github.com/users/predix/gists{/gist_id}","starred_url":"https://api.github.com/users/predix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/predix/subscriptions","organizations_url":"https://api.github.com/users/predix/orgs","repos_url":"https://api.github.com/users/predix/repos","events_url":"https://api.github.com/users/predix/events{/privacy}","received_events_url":"https://api.github.com/users/predix/received_events","type":"Organization","site_admin":false},"repo":{"id":53367115,"name":"acs","full_name":"predix/acs","owner":{"login":"predix","id":11392808,"avatar_url":"https://avatars.githubusercontent.com/u/11392808?v=3","gravatar_id":"","url":"https://api.github.com/users/predix","html_url":"https://github.com/predix","followers_url":"https://api.github.com/users/predix/followers","following_url":"https://api.github.com/users/predix/following{/other_user}","gists_url":"https://api.github.com/users/predix/gists{/gist_id}","starred_url":"https://api.github.com/users/predix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/predix/subscriptions","organizations_url":"https://api.github.com/users/predix/orgs","repos_url":"https://api.github.com/users/predix/repos","events_url":"https://api.github.com/users/predix/events{/privacy}","received_events_url":"https://api.github.com/users/predix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/predix/acs","description":"Access Control Service","fork":false,"url":"https://api.github.com/repos/predix/acs","forks_url":"https://api.github.com/repos/predix/acs/forks","keys_url":"https://api.github.com/repos/predix/acs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/predix/acs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/predix/acs/teams","hooks_url":"https://api.github.com/repos/predix/acs/hooks","issue_events_url":"https://api.github.com/repos/predix/acs/issues/events{/number}","events_url":"https://api.github.com/repos/predix/acs/events","assignees_url":"https://api.github.com/repos/predix/acs/assignees{/user}","branches_url":"https://api.github.com/repos/predix/acs/branches{/branch}","tags_url":"https://api.github.com/repos/predix/acs/tags","blobs_url":"https://api.github.com/repos/predix/acs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/predix/acs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/predix/acs/git/refs{/sha}","trees_url":"https://api.github.com/repos/predix/acs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/predix/acs/statuses/{sha}","languages_url":"https://api.github.com/repos/predix/acs/languages","stargazers_url":"https://api.github.com/repos/predix/acs/stargazers","contributors_url":"https://api.github.com/repos/predix/acs/contributors","subscribers_url":"https://api.github.com/repos/predix/acs/subscribers","subscription_url":"https://api.github.com/repos/predix/acs/subscription","commits_url":"https://api.github.com/repos/predix/acs/commits{/sha}","git_commits_url":"https://api.github.com/repos/predix/acs/git/commits{/sha}","comments_url":"https://api.github.com/repos/predix/acs/comments{/number}","issue_comment_url":"https://api.github.com/repos/predix/acs/issues/comments{/number}","contents_url":"https://api.github.com/repos/predix/acs/contents/{+path}","compare_url":"https://api.github.com/repos/predix/acs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/predix/acs/merges","archive_url":"https://api.github.com/repos/predix/acs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/predix/acs/downloads","issues_url":"https://api.github.com/repos/predix/acs/issues{/number}","pulls_url":"https://api.github.com/repos/predix/acs/pulls{/number}","milestones_url":"https://api.github.com/repos/predix/acs/milestones{/number}","notifications_url":"https://api.github.com/repos/predix/acs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/predix/acs/labels{/name}","releases_url":"https://api.github.com/repos/predix/acs/releases{/id}","deployments_url":"https://api.github.com/repos/predix/acs/deployments","created_at":"2016-03-07T23:38:15Z","updated_at":"2016-08-04T20:03:11Z","pushed_at":"2016-08-08T23:14:41Z","git_url":"git://github.com/predix/acs.git","ssh_url":"git@github.com:predix/acs.git","clone_url":"https://github.com/predix/acs.git","svn_url":"https://github.com/predix/acs","homepage":null,"size":541,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"develop"}},"base":{"label":"predix:develop","ref":"develop","sha":"a72a550762e66e7d75df10cb3a7593da80a591b3","user":{"login":"predix","id":11392808,"avatar_url":"https://avatars.githubusercontent.com/u/11392808?v=3","gravatar_id":"","url":"https://api.github.com/users/predix","html_url":"https://github.com/predix","followers_url":"https://api.github.com/users/predix/followers","following_url":"https://api.github.com/users/predix/following{/other_user}","gists_url":"https://api.github.com/users/predix/gists{/gist_id}","starred_url":"https://api.github.com/users/predix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/predix/subscriptions","organizations_url":"https://api.github.com/users/predix/orgs","repos_url":"https://api.github.com/users/predix/repos","events_url":"https://api.github.com/users/predix/events{/privacy}","received_events_url":"https://api.github.com/users/predix/received_events","type":"Organization","site_admin":false},"repo":{"id":53367115,"name":"acs","full_name":"predix/acs","owner":{"login":"predix","id":11392808,"avatar_url":"https://avatars.githubusercontent.com/u/11392808?v=3","gravatar_id":"","url":"https://api.github.com/users/predix","html_url":"https://github.com/predix","followers_url":"https://api.github.com/users/predix/followers","following_url":"https://api.github.com/users/predix/following{/other_user}","gists_url":"https://api.github.com/users/predix/gists{/gist_id}","starred_url":"https://api.github.com/users/predix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/predix/subscriptions","organizations_url":"https://api.github.com/users/predix/orgs","repos_url":"https://api.github.com/users/predix/repos","events_url":"https://api.github.com/users/predix/events{/privacy}","received_events_url":"https://api.github.com/users/predix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/predix/acs","description":"Access Control Service","fork":false,"url":"https://api.github.com/repos/predix/acs","forks_url":"https://api.github.com/repos/predix/acs/forks","keys_url":"https://api.github.com/repos/predix/acs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/predix/acs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/predix/acs/teams","hooks_url":"https://api.github.com/repos/predix/acs/hooks","issue_events_url":"https://api.github.com/repos/predix/acs/issues/events{/number}","events_url":"https://api.github.com/repos/predix/acs/events","assignees_url":"https://api.github.com/repos/predix/acs/assignees{/user}","branches_url":"https://api.github.com/repos/predix/acs/branches{/branch}","tags_url":"https://api.github.com/repos/predix/acs/tags","blobs_url":"https://api.github.com/repos/predix/acs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/predix/acs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/predix/acs/git/refs{/sha}","trees_url":"https://api.github.com/repos/predix/acs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/predix/acs/statuses/{sha}","languages_url":"https://api.github.com/repos/predix/acs/languages","stargazers_url":"https://api.github.com/repos/predix/acs/stargazers","contributors_url":"https://api.github.com/repos/predix/acs/contributors","subscribers_url":"https://api.github.com/repos/predix/acs/subscribers","subscription_url":"https://api.github.com/repos/predix/acs/subscription","commits_url":"https://api.github.com/repos/predix/acs/commits{/sha}","git_commits_url":"https://api.github.com/repos/predix/acs/git/commits{/sha}","comments_url":"https://api.github.com/repos/predix/acs/comments{/number}","issue_comment_url":"https://api.github.com/repos/predix/acs/issues/comments{/number}","contents_url":"https://api.github.com/repos/predix/acs/contents/{+path}","compare_url":"https://api.github.com/repos/predix/acs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/predix/acs/merges","archive_url":"https://api.github.com/repos/predix/acs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/predix/acs/downloads","issues_url":"https://api.github.com/repos/predix/acs/issues{/number}","pulls_url":"https://api.github.com/repos/predix/acs/pulls{/number}","milestones_url":"https://api.github.com/repos/predix/acs/milestones{/number}","notifications_url":"https://api.github.com/repos/predix/acs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/predix/acs/labels{/name}","releases_url":"https://api.github.com/repos/predix/acs/releases{/id}","deployments_url":"https://api.github.com/repos/predix/acs/deployments","created_at":"2016-03-07T23:38:15Z","updated_at":"2016-08-04T20:03:11Z","pushed_at":"2016-08-08T23:14:41Z","git_url":"git://github.com/predix/acs.git","ssh_url":"git@github.com:predix/acs.git","clone_url":"https://github.com/predix/acs.git","svn_url":"https://github.com/predix/acs","homepage":null,"size":541,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/predix/acs/pulls/24"},"html":{"href":"https://github.com/predix/acs/pull/24"},"issue":{"href":"https://api.github.com/repos/predix/acs/issues/24"},"comments":{"href":"https://api.github.com/repos/predix/acs/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/predix/acs/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/predix/acs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/predix/acs/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/predix/acs/statuses/15bfe30e078e41a22ea8fc19477967e0851501df"}}}}
{"actor":{"display_login":"sanjeevchopra"}}