{"action":"closed","issue":{"url":"https://api.github.com/repos/lasso-js/lasso/issues/185","repository_url":"https://api.github.com/repos/lasso-js/lasso","labels_url":"https://api.github.com/repos/lasso-js/lasso/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/lasso-js/lasso/issues/185/comments","events_url":"https://api.github.com/repos/lasso-js/lasso/issues/185/events","html_url":"https://github.com/lasso-js/lasso/issues/185","id":198047262,"number":185,"title":"DependencyRegistry has an undefined stream when using `mask-define` for AMD dependencies","user":{"login":"CestDiego","id":3291619,"avatar_url":"https://avatars.githubusercontent.com/u/3291619?v=3","gravatar_id":"","url":"https://api.github.com/users/CestDiego","html_url":"https://github.com/CestDiego","followers_url":"https://api.github.com/users/CestDiego/followers","following_url":"https://api.github.com/users/CestDiego/following{/other_user}","gists_url":"https://api.github.com/users/CestDiego/gists{/gist_id}","starred_url":"https://api.github.com/users/CestDiego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CestDiego/subscriptions","organizations_url":"https://api.github.com/users/CestDiego/orgs","repos_url":"https://api.github.com/users/CestDiego/repos","events_url":"https://api.github.com/users/CestDiego/events{/privacy}","received_events_url":"https://api.github.com/users/CestDiego/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-29T18:15:14Z","updated_at":"2016-12-29T18:23:56Z","closed_at":"2016-12-29T18:23:56Z","body":"I have this in my browser.json, according to docs this is the way to do it.\r\n```\r\n {\r\n            \"path\": \"../../../node_modules/clipboard/dist/clipboard.js\",\r\n            \"mask-define\": true\r\n}\r\n```\r\nWhen running tests though, I stumble across this: \r\n```\r\n/Users/user/path/to/project-name/node_modules/lasso/lib/dependencies/DependencyRegistry.js:629\r\n                    .on('data', function(data) {\r\n```\r\n\r\nIt looks that stream is undefined here: https://github.com/lasso-js/lasso/blob/e760f877230a2a4f27d6664ba4ce9e67c26355b7/lib/dependencies/DependencyRegistry.js#L628\r\n\r\nand this function is the one that doesn't give back a stream when `mask-define` is used: https://github.com/lasso-js/lasso/blob/e760f877230a2a4f27d6664ba4ce9e67c26355b7/lib/dependencies/dependency-resource.js#L57-L66"}}
{"actor":{"display_login":"patrick-steele-idem"}}