{"action":"created","comment":{"url":"https://api.github.com/repos/18F/e-manifest/pulls/comments/56892054","id":56892054,"diff_hunk":"@@ -0,0 +1,22 @@\n+class ManifestTokenJsonConverter","path":"app/services/manifest_token_json_converter.rb","position":1,"original_position":1,"commit_id":"a9e60c72305d672befae98eae5f5631cf4b331de","original_commit_id":"a9e60c72305d672befae98eae5f5631cf4b331de","user":{"login":"brandocalrissian","id":1403376,"avatar_url":"https://avatars.githubusercontent.com/u/1403376?v=3","gravatar_id":"","url":"https://api.github.com/users/brandocalrissian","html_url":"https://github.com/brandocalrissian","followers_url":"https://api.github.com/users/brandocalrissian/followers","following_url":"https://api.github.com/users/brandocalrissian/following{/other_user}","gists_url":"https://api.github.com/users/brandocalrissian/gists{/gist_id}","starred_url":"https://api.github.com/users/brandocalrissian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandocalrissian/subscriptions","organizations_url":"https://api.github.com/users/brandocalrissian/orgs","repos_url":"https://api.github.com/users/brandocalrissian/repos","events_url":"https://api.github.com/users/brandocalrissian/events{/privacy}","received_events_url":"https://api.github.com/users/brandocalrissian/received_events","type":"User","site_admin":false},"body":"There was some common code essentially copied in a couple of controllers-- it didn't make sense to pull the occasionally used function up to a superclass one-controller-base-class-to-rule-them-all, so it was extracted. It doesn't need to be in the \"services\" directory and can move to the controllers directory.","created_at":"2016-03-21T20:35:51Z","updated_at":"2016-03-21T20:35:51Z","html_url":"https://github.com/18F/e-manifest/pull/177#discussion_r56892054","pull_request_url":"https://api.github.com/repos/18F/e-manifest/pulls/177","_links":{"self":{"href":"https://api.github.com/repos/18F/e-manifest/pulls/comments/56892054"},"html":{"href":"https://github.com/18F/e-manifest/pull/177#discussion_r56892054"},"pull_request":{"href":"https://api.github.com/repos/18F/e-manifest/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/18F/e-manifest/pulls/177","id":63124971,"html_url":"https://github.com/18F/e-manifest/pull/177","diff_url":"https://github.com/18F/e-manifest/pull/177.diff","patch_url":"https://github.com/18F/e-manifest/pull/177.patch","issue_url":"https://api.github.com/repos/18F/e-manifest/issues/177","number":177,"state":"open","locked":false,"title":"New API endpoint for submitting the manifest for CROMERR signing.","user":{"login":"brandocalrissian","id":1403376,"avatar_url":"https://avatars.githubusercontent.com/u/1403376?v=3","gravatar_id":"","url":"https://api.github.com/users/brandocalrissian","html_url":"https://github.com/brandocalrissian","followers_url":"https://api.github.com/users/brandocalrissian/followers","following_url":"https://api.github.com/users/brandocalrissian/following{/other_user}","gists_url":"https://api.github.com/users/brandocalrissian/gists{/gist_id}","starred_url":"https://api.github.com/users/brandocalrissian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandocalrissian/subscriptions","organizations_url":"https://api.github.com/users/brandocalrissian/orgs","repos_url":"https://api.github.com/users/brandocalrissian/repos","events_url":"https://api.github.com/users/brandocalrissian/events{/privacy}","received_events_url":"https://api.github.com/users/brandocalrissian/received_events","type":"User","site_admin":false},"body":"Does not sign. Only TSDF users are allowed to use the API (same as signing rules).\r\n\r\nCould use some more tests.\r\n\r\nDoes not include the bits that talk to the CDX services to perform the actual submission-- that's a different commit-- it takes the data to the front door of that request process.\r\n\r\nRe-added the emacs autosave files to the .gitignore lost in the rails translation.\r\n\r\nThis is for https://trello.com/c/jHHqRC18.","created_at":"2016-03-16T19:49:35Z","updated_at":"2016-03-21T20:35:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a812dc532714c110f53634a0dc8e3c488a557216","assignee":{"login":"brandocalrissian","id":1403376,"avatar_url":"https://avatars.githubusercontent.com/u/1403376?v=3","gravatar_id":"","url":"https://api.github.com/users/brandocalrissian","html_url":"https://github.com/brandocalrissian","followers_url":"https://api.github.com/users/brandocalrissian/followers","following_url":"https://api.github.com/users/brandocalrissian/following{/other_user}","gists_url":"https://api.github.com/users/brandocalrissian/gists{/gist_id}","starred_url":"https://api.github.com/users/brandocalrissian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandocalrissian/subscriptions","organizations_url":"https://api.github.com/users/brandocalrissian/orgs","repos_url":"https://api.github.com/users/brandocalrissian/repos","events_url":"https://api.github.com/users/brandocalrissian/events{/privacy}","received_events_url":"https://api.github.com/users/brandocalrissian/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/18F/e-manifest/pulls/177/commits","review_comments_url":"https://api.github.com/repos/18F/e-manifest/pulls/177/comments","review_comment_url":"https://api.github.com/repos/18F/e-manifest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/e-manifest/issues/177/comments","statuses_url":"https://api.github.com/repos/18F/e-manifest/statuses/a9e60c72305d672befae98eae5f5631cf4b331de","head":{"label":"18F:bk_submit_manifest_to_cromerr_api","ref":"bk_submit_manifest_to_cromerr_api","sha":"a9e60c72305d672befae98eae5f5631cf4b331de","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":38887537,"name":"e-manifest","full_name":"18F/e-manifest","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/e-manifest","description":"The EPA e-Manifest project","fork":false,"url":"https://api.github.com/repos/18F/e-manifest","forks_url":"https://api.github.com/repos/18F/e-manifest/forks","keys_url":"https://api.github.com/repos/18F/e-manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/e-manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/e-manifest/teams","hooks_url":"https://api.github.com/repos/18F/e-manifest/hooks","issue_events_url":"https://api.github.com/repos/18F/e-manifest/issues/events{/number}","events_url":"https://api.github.com/repos/18F/e-manifest/events","assignees_url":"https://api.github.com/repos/18F/e-manifest/assignees{/user}","branches_url":"https://api.github.com/repos/18F/e-manifest/branches{/branch}","tags_url":"https://api.github.com/repos/18F/e-manifest/tags","blobs_url":"https://api.github.com/repos/18F/e-manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/e-manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/e-manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/e-manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/e-manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/e-manifest/languages","stargazers_url":"https://api.github.com/repos/18F/e-manifest/stargazers","contributors_url":"https://api.github.com/repos/18F/e-manifest/contributors","subscribers_url":"https://api.github.com/repos/18F/e-manifest/subscribers","subscription_url":"https://api.github.com/repos/18F/e-manifest/subscription","commits_url":"https://api.github.com/repos/18F/e-manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/e-manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/e-manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/e-manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/e-manifest/contents/{+path}","compare_url":"https://api.github.com/repos/18F/e-manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/e-manifest/merges","archive_url":"https://api.github.com/repos/18F/e-manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/e-manifest/downloads","issues_url":"https://api.github.com/repos/18F/e-manifest/issues{/number}","pulls_url":"https://api.github.com/repos/18F/e-manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/e-manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/e-manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/e-manifest/labels{/name}","releases_url":"https://api.github.com/repos/18F/e-manifest/releases{/id}","deployments_url":"https://api.github.com/repos/18F/e-manifest/deployments","created_at":"2015-07-10T15:26:47Z","updated_at":"2016-02-09T23:28:58Z","pushed_at":"2016-03-21T16:45:26Z","git_url":"git://github.com/18F/e-manifest.git","ssh_url":"git@github.com:18F/e-manifest.git","clone_url":"https://github.com/18F/e-manifest.git","svn_url":"https://github.com/18F/e-manifest","homepage":"","size":7197,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":6,"default_branch":"master"}},"base":{"label":"18F:master","ref":"master","sha":"c228765c596b5ac319158bba85e1e8701a94eb9e","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":38887537,"name":"e-manifest","full_name":"18F/e-manifest","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars.githubusercontent.com/u/6233994?v=3","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/e-manifest","description":"The EPA e-Manifest project","fork":false,"url":"https://api.github.com/repos/18F/e-manifest","forks_url":"https://api.github.com/repos/18F/e-manifest/forks","keys_url":"https://api.github.com/repos/18F/e-manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/e-manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/e-manifest/teams","hooks_url":"https://api.github.com/repos/18F/e-manifest/hooks","issue_events_url":"https://api.github.com/repos/18F/e-manifest/issues/events{/number}","events_url":"https://api.github.com/repos/18F/e-manifest/events","assignees_url":"https://api.github.com/repos/18F/e-manifest/assignees{/user}","branches_url":"https://api.github.com/repos/18F/e-manifest/branches{/branch}","tags_url":"https://api.github.com/repos/18F/e-manifest/tags","blobs_url":"https://api.github.com/repos/18F/e-manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/e-manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/e-manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/e-manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/e-manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/e-manifest/languages","stargazers_url":"https://api.github.com/repos/18F/e-manifest/stargazers","contributors_url":"https://api.github.com/repos/18F/e-manifest/contributors","subscribers_url":"https://api.github.com/repos/18F/e-manifest/subscribers","subscription_url":"https://api.github.com/repos/18F/e-manifest/subscription","commits_url":"https://api.github.com/repos/18F/e-manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/e-manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/e-manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/e-manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/e-manifest/contents/{+path}","compare_url":"https://api.github.com/repos/18F/e-manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/e-manifest/merges","archive_url":"https://api.github.com/repos/18F/e-manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/e-manifest/downloads","issues_url":"https://api.github.com/repos/18F/e-manifest/issues{/number}","pulls_url":"https://api.github.com/repos/18F/e-manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/e-manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/e-manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/e-manifest/labels{/name}","releases_url":"https://api.github.com/repos/18F/e-manifest/releases{/id}","deployments_url":"https://api.github.com/repos/18F/e-manifest/deployments","created_at":"2015-07-10T15:26:47Z","updated_at":"2016-02-09T23:28:58Z","pushed_at":"2016-03-21T16:45:26Z","git_url":"git://github.com/18F/e-manifest.git","ssh_url":"git@github.com:18F/e-manifest.git","clone_url":"https://github.com/18F/e-manifest.git","svn_url":"https://github.com/18F/e-manifest","homepage":"","size":7197,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/e-manifest/pulls/177"},"html":{"href":"https://github.com/18F/e-manifest/pull/177"},"issue":{"href":"https://api.github.com/repos/18F/e-manifest/issues/177"},"comments":{"href":"https://api.github.com/repos/18F/e-manifest/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/e-manifest/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/e-manifest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/e-manifest/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/18F/e-manifest/statuses/a9e60c72305d672befae98eae5f5631cf4b331de"}}}}