{"push_id":1136723066,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"e0143f3205ebbf07aa479b89d8ba8aab426496b2","before":"fdf4101fb17d8f45487a9ba6ba248e8edf245cf6","commits":[{"sha":"22b18ba988c72b6802421ae2e96237a716ae436e","author":{"name":"Owen Leonard","email":"49b694e103543696a2f066bc69b1b85179a169fc@myacpl.org"},"message":"Bug 16437 - Automatic item modifications by age needs prettying\n\nThis patch makes layout and behavior changes to the automatic item\nmodifications by age interface, bringing some aspects of it closer into\nconformance with established interface patterns.\n\n- The intial view is now a standard table of information about existing\n  rules, or a message dialog saying there are no rules.\n- If there are no rules, a toolbar button reads \"Add rules.\"\n- If there are existing rules, the toolbar button reads \"Edit rules.\"\n  - Clicking the button leads to the rules edit interface, which now has\n    a floating toolbar with \"Add rule,\" \"Save,\" and \"Cancel\" buttons.\n  - Clicking the \"Add rule\" button displays a blank rule block.\n    - If you are adding a rule to existing rules, the new block is\n      appended at the bottom, and the page scrolls to the new rule.\n    - As you add or remove rule blocks, the legend containing the rule\n      count updates so that the numbers are sequential.\n    - In each rule block, \"age\" and \"substitutions\" are now required.\n      The age field is now validated to require a number.\n    - The add/remove condition/substitution links now have more\n      descriptive text labels.\n    - The control to remove a rule is now a link in the <legend> element\n      associated with each rule.\n- Most JavaScript for this page is now in a separate file.\n- Breadcrumbs are updated to be a little more specific.\n\nTo test, apply the patch and clear your browser cache if necessary.\n\n- Go to Tools -> Automatic item modifications by age.\n- Test adding and removing rules.\n- Test removing all rules.\n- Test adding and removing conditions and substitutions within rules.\n- Test submitting the form without filling in required fields.\n\nFollowed test plan, works as expected.\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher <brendan@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/22b18ba988c72b6802421ae2e96237a716ae436e"},{"sha":"e0143f3205ebbf07aa479b89d8ba8aab426496b2","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16437 - (follow-up) Automatic item modifications by age needs prettying\n\nDo not move the scrollbar to the top when removing a 'block' to a new\nrule.\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\n\nSigned-off-by: Brendan Gallagher <brendan@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/Koha-Community/Koha/commits/e0143f3205ebbf07aa479b89d8ba8aab426496b2"}]}
{"actor":{"display_login":"gmcharlt"}}