{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/84770609","pull_request_review_id":5527133,"id":84770609,"diff_hunk":"@@ -263,6 +264,34 @@ void OnChildrenCollectionChanged(object sender, NotifyCollectionChangedEventArgs\n \t\t\tUpdateIgnoreContainerAreas();\n \t\t}\n \n+\t\tvoid TeardownPage(Page page, int i)","path":"Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs","position":60,"original_position":60,"commit_id":"d7dee2bcbe697d48220b38fbede682f77625077a","original_commit_id":"d7dee2bcbe697d48220b38fbede682f77625077a","user":{"login":"hartez","id":538025,"avatar_url":"https://avatars.githubusercontent.com/u/538025?v=3","gravatar_id":"","url":"https://api.github.com/users/hartez","html_url":"https://github.com/hartez","followers_url":"https://api.github.com/users/hartez/followers","following_url":"https://api.github.com/users/hartez/following{/other_user}","gists_url":"https://api.github.com/users/hartez/gists{/gist_id}","starred_url":"https://api.github.com/users/hartez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartez/subscriptions","organizations_url":"https://api.github.com/users/hartez/orgs","repos_url":"https://api.github.com/users/hartez/repos","events_url":"https://api.github.com/users/hartez/events{/privacy}","received_events_url":"https://api.github.com/users/hartez/received_events","type":"User","site_admin":false},"body":"Can we drop the `int i` parameter here? It doesn't seem to be used.","created_at":"2016-10-24T20:00:46Z","updated_at":"2016-10-24T20:00:46Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/327#discussion_r84770609","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/84770609"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/327#discussion_r84770609"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327","id":83021732,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/327","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/327.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/327.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/327","number":327,"state":"open","locked":false,"title":"Fixed tab not updating when page title is changed","user":{"login":"jimmgarrido","id":4087358,"avatar_url":"https://avatars.githubusercontent.com/u/4087358?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmgarrido","html_url":"https://github.com/jimmgarrido","followers_url":"https://api.github.com/users/jimmgarrido/followers","following_url":"https://api.github.com/users/jimmgarrido/following{/other_user}","gists_url":"https://api.github.com/users/jimmgarrido/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmgarrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmgarrido/subscriptions","organizations_url":"https://api.github.com/users/jimmgarrido/orgs","repos_url":"https://api.github.com/users/jimmgarrido/repos","events_url":"https://api.github.com/users/jimmgarrido/events{/privacy}","received_events_url":"https://api.github.com/users/jimmgarrido/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nWith AppCompat, changing the Title of a TabbedPage child Page would no longer update its tab text. This fixes that by wiring up to each child page's PropertyChanged event using the same mechanism as in the iOS TabbedRenderer in order to respond to the change. This also sets up the ability to respond to other child page property changes later if needed.\r\n\r\n### Bugs Fixed ###\r\n\r\n- https://bugzilla.xamarin.com/show_bug.cgi?id=43734\r\n\r\n### API Changes ###\r\n\r\nNone\r\n\r\n### Behavioral Changes ###\r\n\r\n\r\n### PR Checklist ###\r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n\r\n","created_at":"2016-08-28T17:33:42Z","updated_at":"2016-10-24T20:01:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f34af8c41caebf16744a42e6ee3b68066ca4b78a","assignee":{"login":"hartez","id":538025,"avatar_url":"https://avatars.githubusercontent.com/u/538025?v=3","gravatar_id":"","url":"https://api.github.com/users/hartez","html_url":"https://github.com/hartez","followers_url":"https://api.github.com/users/hartez/followers","following_url":"https://api.github.com/users/hartez/following{/other_user}","gists_url":"https://api.github.com/users/hartez/gists{/gist_id}","starred_url":"https://api.github.com/users/hartez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartez/subscriptions","organizations_url":"https://api.github.com/users/hartez/orgs","repos_url":"https://api.github.com/users/hartez/repos","events_url":"https://api.github.com/users/hartez/events{/privacy}","received_events_url":"https://api.github.com/users/hartez/received_events","type":"User","site_admin":false},"assignees":[{"login":"hartez","id":538025,"avatar_url":"https://avatars.githubusercontent.com/u/538025?v=3","gravatar_id":"","url":"https://api.github.com/users/hartez","html_url":"https://github.com/hartez","followers_url":"https://api.github.com/users/hartez/followers","following_url":"https://api.github.com/users/hartez/following{/other_user}","gists_url":"https://api.github.com/users/hartez/gists{/gist_id}","starred_url":"https://api.github.com/users/hartez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hartez/subscriptions","organizations_url":"https://api.github.com/users/hartez/orgs","repos_url":"https://api.github.com/users/hartez/repos","events_url":"https://api.github.com/users/hartez/events{/privacy}","received_events_url":"https://api.github.com/users/hartez/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/327/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/d7dee2bcbe697d48220b38fbede682f77625077a","head":{"label":"jimmgarrido:fix-bugzilla43734","ref":"fix-bugzilla43734","sha":"d7dee2bcbe697d48220b38fbede682f77625077a","user":{"login":"jimmgarrido","id":4087358,"avatar_url":"https://avatars.githubusercontent.com/u/4087358?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmgarrido","html_url":"https://github.com/jimmgarrido","followers_url":"https://api.github.com/users/jimmgarrido/followers","following_url":"https://api.github.com/users/jimmgarrido/following{/other_user}","gists_url":"https://api.github.com/users/jimmgarrido/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmgarrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmgarrido/subscriptions","organizations_url":"https://api.github.com/users/jimmgarrido/orgs","repos_url":"https://api.github.com/users/jimmgarrido/repos","events_url":"https://api.github.com/users/jimmgarrido/events{/privacy}","received_events_url":"https://api.github.com/users/jimmgarrido/received_events","type":"User","site_admin":false},"repo":{"id":65420169,"name":"Xamarin.Forms","full_name":"jimmgarrido/Xamarin.Forms","owner":{"login":"jimmgarrido","id":4087358,"avatar_url":"https://avatars.githubusercontent.com/u/4087358?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmgarrido","html_url":"https://github.com/jimmgarrido","followers_url":"https://api.github.com/users/jimmgarrido/followers","following_url":"https://api.github.com/users/jimmgarrido/following{/other_user}","gists_url":"https://api.github.com/users/jimmgarrido/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmgarrido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmgarrido/subscriptions","organizations_url":"https://api.github.com/users/jimmgarrido/orgs","repos_url":"https://api.github.com/users/jimmgarrido/repos","events_url":"https://api.github.com/users/jimmgarrido/events{/privacy}","received_events_url":"https://api.github.com/users/jimmgarrido/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmgarrido/Xamarin.Forms","description":"Xamarin.Forms official home","fork":true,"url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms","forks_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/jimmgarrido/Xamarin.Forms/deployments","created_at":"2016-08-10T22:18:52Z","updated_at":"2016-08-10T22:18:56Z","pushed_at":"2016-10-20T22:36:42Z","git_url":"git://github.com/jimmgarrido/Xamarin.Forms.git","ssh_url":"git@github.com:jimmgarrido/Xamarin.Forms.git","clone_url":"https://github.com/jimmgarrido/Xamarin.Forms.git","svn_url":"https://github.com/jimmgarrido/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":14490,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"5b85aafcd671f5e8745cf52339c20378f91cb748","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2016-10-24T17:21:48Z","pushed_at":"2016-10-24T17:21:30Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":27991,"stargazers_count":941,"watchers_count":941,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":323,"mirror_url":null,"open_issues_count":58,"forks":323,"open_issues":58,"watchers":941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/327"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/327"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/d7dee2bcbe697d48220b38fbede682f77625077a"}}}}
{"actor":{"display_login":"hartez"}}