{"action":"created","issue":{"url":"https://api.github.com/repos/ramda/ramda/issues/1928","repository_url":"https://api.github.com/repos/ramda/ramda","labels_url":"https://api.github.com/repos/ramda/ramda/issues/1928/labels{/name}","comments_url":"https://api.github.com/repos/ramda/ramda/issues/1928/comments","events_url":"https://api.github.com/repos/ramda/ramda/issues/1928/events","html_url":"https://github.com/ramda/ramda/pull/1928","id":181378654,"number":1928,"title":"add commonjs entrypoint for nodejs environment","user":{"login":"iamstarkov","id":559321,"avatar_url":"https://avatars.githubusercontent.com/u/559321?v=3","gravatar_id":"","url":"https://api.github.com/users/iamstarkov","html_url":"https://github.com/iamstarkov","followers_url":"https://api.github.com/users/iamstarkov/followers","following_url":"https://api.github.com/users/iamstarkov/following{/other_user}","gists_url":"https://api.github.com/users/iamstarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/iamstarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamstarkov/subscriptions","organizations_url":"https://api.github.com/users/iamstarkov/orgs","repos_url":"https://api.github.com/users/iamstarkov/repos","events_url":"https://api.github.com/users/iamstarkov/events{/privacy}","received_events_url":"https://api.github.com/users/iamstarkov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-06T10:28:31Z","updated_at":"2016-10-06T17:01:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ramda/ramda/pulls/1928","html_url":"https://github.com/ramda/ramda/pull/1928","diff_url":"https://github.com/ramda/ramda/pull/1928.diff","patch_url":"https://github.com/ramda/ramda/pull/1928.patch"},"body":"i discussed it in gitter and got green light to try out this approach.\r\n\r\nSo basically there is no need to bundle all the files into one for nodejs environment, so we can export natively supported one entry point which requires all internal files.\r\n\r\nOne instant benefit is clearer stack traces:\r\n\r\n```\r\n➜  projects node\r\n> const old = require('./ramda-old');\r\nundefined\r\n> const R = require('./ramda');\r\nundefined\r\n> old.pipe()\r\nError: pipe requires at least one argument\r\n    at Object.pipe (/Users/vlasta/projects/ramda-old/dist/ramda.js:7421:19)\r\n    at …\r\n> R.pipe()\r\nError: pipe requires at least one argument\r\n    at Object.pipe (/Users/vlasta/projects/ramda/src/pipe.js:32:11)\r\n    at …\r\n> \r\n```\r\n\r\nI didnt touch anything else: neither testing, nor building processes.\r\n\r\nThis pr has aslo benefit of possible smaller builds for smart bundlers (without hacks relying on frozen file system structure).\r\n\r\nPros:\r\n* clear stacktraces\r\n* smaller builds\r\n* room for improvements in developer experience (faster tests, simpler build, windows friendly setup, etc)\r\n\r\nNo cons."},"comment":{"url":"https://api.github.com/repos/ramda/ramda/issues/comments/252025104","html_url":"https://github.com/ramda/ramda/pull/1928#issuecomment-252025104","issue_url":"https://api.github.com/repos/ramda/ramda/issues/1928","id":252025104,"user":{"login":"buzzdecafe","id":716260,"avatar_url":"https://avatars.githubusercontent.com/u/716260?v=3","gravatar_id":"","url":"https://api.github.com/users/buzzdecafe","html_url":"https://github.com/buzzdecafe","followers_url":"https://api.github.com/users/buzzdecafe/followers","following_url":"https://api.github.com/users/buzzdecafe/following{/other_user}","gists_url":"https://api.github.com/users/buzzdecafe/gists{/gist_id}","starred_url":"https://api.github.com/users/buzzdecafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buzzdecafe/subscriptions","organizations_url":"https://api.github.com/users/buzzdecafe/orgs","repos_url":"https://api.github.com/users/buzzdecafe/repos","events_url":"https://api.github.com/users/buzzdecafe/events{/privacy}","received_events_url":"https://api.github.com/users/buzzdecafe/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T17:01:11Z","updated_at":"2016-10-06T17:01:11Z","body":"> 1. new function is added => relevant tests needed =>require it from .. => if its undefined add function to the list. So your tests will work => list of function will always be up to date.\r\n\r\neither way -- at release time or at add/remove time -- we need an automated process to update index.js. Agreed? The point is I do not want to manually manage this file."}}
{"actor":{"display_login":"buzzdecafe"}}