{"action":"created","issue":{"url":"https://api.github.com/repos/neos/neos-development-collection/issues/512","repository_url":"https://api.github.com/repos/neos/neos-development-collection","labels_url":"https://api.github.com/repos/neos/neos-development-collection/issues/512/labels{/name}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/issues/512/comments","events_url":"https://api.github.com/repos/neos/neos-development-collection/issues/512/events","html_url":"https://github.com/neos/neos-development-collection/pull/512","id":154060061,"number":512,"title":"BUGFIX: Publishable Node Context considers dimension fallbacks","user":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars.githubusercontent.com/u/324408?v=3","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/neos/neos-development-collection/labels/I:%20WIP","name":"I: WIP","color":"eb6420"},{"url":"https://api.github.com/repos/neos/neos-development-collection/labels/P:%20Content%20Repository","name":"P: Content Repository","color":"0052cc"},{"url":"https://api.github.com/repos/neos/neos-development-collection/labels/T:%20PHP","name":"T: PHP","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-10T17:16:33Z","updated_at":"2016-05-11T05:06:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/512","html_url":"https://github.com/neos/neos-development-collection/pull/512","diff_url":"https://github.com/neos/neos-development-collection/pull/512.diff","patch_url":"https://github.com/neos/neos-development-collection/pull/512.patch"},"body":"The Context created for Nodes in a workspace in the ``PublishingService``\r\nwas derived from the ``NodeData`` entities dimension values, which should only\r\nbe the target values of the context but (wrongly) doesn't consider fallbacks\r\nconfigured in presets.\r\n\r\nTo solve this a new method in the PresetSource allows to find best matching\r\npresets based on target values for dimensions. Those are then used to\r\nget a ``Context`` with fallback rules for dimensions, avoiding errors with\r\nmissing nodes in the root path as these might only exist within a ``Context``\r\nthat considers fallback rules.\r\n\r\nThe ``ContentDimensionPresetSourceInterface`` is not declared public ``@api``\r\nso the change is not marked breaking."},"comment":{"url":"https://api.github.com/repos/neos/neos-development-collection/issues/comments/218362844","html_url":"https://github.com/neos/neos-development-collection/pull/512#issuecomment-218362844","issue_url":"https://api.github.com/repos/neos/neos-development-collection/issues/512","id":218362844,"user":{"login":"aertmann","id":903567,"avatar_url":"https://avatars.githubusercontent.com/u/903567?v=3","gravatar_id":"","url":"https://api.github.com/users/aertmann","html_url":"https://github.com/aertmann","followers_url":"https://api.github.com/users/aertmann/followers","following_url":"https://api.github.com/users/aertmann/following{/other_user}","gists_url":"https://api.github.com/users/aertmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aertmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aertmann/subscriptions","organizations_url":"https://api.github.com/users/aertmann/orgs","repos_url":"https://api.github.com/users/aertmann/repos","events_url":"https://api.github.com/users/aertmann/events{/privacy}","received_events_url":"https://api.github.com/users/aertmann/received_events","type":"User","site_admin":false},"created_at":"2016-05-11T05:06:26Z","updated_at":"2016-05-11T05:06:26Z","body":"add WIP since tests are broken and no new tests to prove the case have been added yet"}}