{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/82700978","pull_request_review_id":3590307,"id":82700978,"diff_hunk":"@@ -27,11 +27,8 @@\n # TODO: Add support for a C++11 enabled installation that filters out the\n # TODO: \"C++11-Disabled\" flag (but only if the spec compiler supports C++11).\n \n-# TODO: Add support for parallel installation that uses MPI.\n-\n-# TODO: Create installation options for NetCDF that support larger page size\n-# TODO: suggested by Exodus (see the repository \"README\" file).\n-\n+# TODO: Use variant forwarding to forward the 'mpi' variant to the direct\n+# TODO: dependencies 'hdf5' and 'netcdf'.\n ","path":"var/spack/repos/builtin/packages/exodusii/package.py","position":11,"original_position":11,"commit_id":"af767127c767a9cf1a1d09a97646f2d6047f1d71","original_commit_id":"af767127c767a9cf1a1d09a97646f2d6047f1d71","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"There needs to be 2 blank lines here. That is what is causing the flake8 tests to fail.","created_at":"2016-10-10T23:22:41Z","updated_at":"2016-10-10T23:22:47Z","html_url":"https://github.com/LLNL/spack/pull/1504#discussion_r82700978","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/1504","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/82700978"},"html":{"href":"https://github.com/LLNL/spack/pull/1504#discussion_r82700978"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1504"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/1504","id":81045820,"html_url":"https://github.com/LLNL/spack/pull/1504","diff_url":"https://github.com/LLNL/spack/pull/1504.diff","patch_url":"https://github.com/LLNL/spack/pull/1504.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/1504","number":1504,"state":"open","locked":false,"title":"Update Package : ExodusII","user":{"login":"xjrc","id":17277866,"avatar_url":"https://avatars.githubusercontent.com/u/17277866?v=3","gravatar_id":"","url":"https://api.github.com/users/xjrc","html_url":"https://github.com/xjrc","followers_url":"https://api.github.com/users/xjrc/followers","following_url":"https://api.github.com/users/xjrc/following{/other_user}","gists_url":"https://api.github.com/users/xjrc/gists{/gist_id}","starred_url":"https://api.github.com/users/xjrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjrc/subscriptions","organizations_url":"https://api.github.com/users/xjrc/orgs","repos_url":"https://api.github.com/users/xjrc/repos","events_url":"https://api.github.com/users/xjrc/events{/privacy}","received_events_url":"https://api.github.com/users/xjrc/received_events","type":"User","site_admin":false},"body":"The changes in this pull request make the following improvements to the `exodusii` package:\r\n\r\n- Update the package version to a more recent and stable version of `exodusii`.\r\n- Improve the patching process for the package so that it utilizes more reliable and portable methods.\r\n- Add the `+mpi` variant, which allows the package to be built with support for parallel processing.\r\n- Add the `maxdims=int` and `maxvars=int` variants to the `netcdf` package, which helps the `exodusii` package better take advantage of this dependency (see [this document](https://github.com/gsjaardema/seacas/blob/8f94fe2e6cf1ae43249e4f0ef0ffb2223f7ea692/NetCDF-Mapping.md) for more information).\r\n\r\nPlease let me know if there are any problems with these updates and I'll fix them as soon as I can!","created_at":"2016-08-11T23:05:32Z","updated_at":"2016-10-10T23:22:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f9fc74c706d2bfccc2c16ea44ab5eeff741b3db","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/1504/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/1504/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/1504/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/af767127c767a9cf1a1d09a97646f2d6047f1d71","head":{"label":"xjrc:packages/exodusii","ref":"packages/exodusii","sha":"af767127c767a9cf1a1d09a97646f2d6047f1d71","user":{"login":"xjrc","id":17277866,"avatar_url":"https://avatars.githubusercontent.com/u/17277866?v=3","gravatar_id":"","url":"https://api.github.com/users/xjrc","html_url":"https://github.com/xjrc","followers_url":"https://api.github.com/users/xjrc/followers","following_url":"https://api.github.com/users/xjrc/following{/other_user}","gists_url":"https://api.github.com/users/xjrc/gists{/gist_id}","starred_url":"https://api.github.com/users/xjrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjrc/subscriptions","organizations_url":"https://api.github.com/users/xjrc/orgs","repos_url":"https://api.github.com/users/xjrc/repos","events_url":"https://api.github.com/users/xjrc/events{/privacy}","received_events_url":"https://api.github.com/users/xjrc/received_events","type":"User","site_admin":false},"repo":{"id":51858380,"name":"spack","full_name":"xjrc/spack","owner":{"login":"xjrc","id":17277866,"avatar_url":"https://avatars.githubusercontent.com/u/17277866?v=3","gravatar_id":"","url":"https://api.github.com/users/xjrc","html_url":"https://github.com/xjrc","followers_url":"https://api.github.com/users/xjrc/followers","following_url":"https://api.github.com/users/xjrc/following{/other_user}","gists_url":"https://api.github.com/users/xjrc/gists{/gist_id}","starred_url":"https://api.github.com/users/xjrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjrc/subscriptions","organizations_url":"https://api.github.com/users/xjrc/orgs","repos_url":"https://api.github.com/users/xjrc/repos","events_url":"https://api.github.com/users/xjrc/events{/privacy}","received_events_url":"https://api.github.com/users/xjrc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xjrc/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/xjrc/spack","forks_url":"https://api.github.com/repos/xjrc/spack/forks","keys_url":"https://api.github.com/repos/xjrc/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xjrc/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xjrc/spack/teams","hooks_url":"https://api.github.com/repos/xjrc/spack/hooks","issue_events_url":"https://api.github.com/repos/xjrc/spack/issues/events{/number}","events_url":"https://api.github.com/repos/xjrc/spack/events","assignees_url":"https://api.github.com/repos/xjrc/spack/assignees{/user}","branches_url":"https://api.github.com/repos/xjrc/spack/branches{/branch}","tags_url":"https://api.github.com/repos/xjrc/spack/tags","blobs_url":"https://api.github.com/repos/xjrc/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xjrc/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xjrc/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/xjrc/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xjrc/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/xjrc/spack/languages","stargazers_url":"https://api.github.com/repos/xjrc/spack/stargazers","contributors_url":"https://api.github.com/repos/xjrc/spack/contributors","subscribers_url":"https://api.github.com/repos/xjrc/spack/subscribers","subscription_url":"https://api.github.com/repos/xjrc/spack/subscription","commits_url":"https://api.github.com/repos/xjrc/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/xjrc/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/xjrc/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/xjrc/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/xjrc/spack/contents/{+path}","compare_url":"https://api.github.com/repos/xjrc/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xjrc/spack/merges","archive_url":"https://api.github.com/repos/xjrc/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xjrc/spack/downloads","issues_url":"https://api.github.com/repos/xjrc/spack/issues{/number}","pulls_url":"https://api.github.com/repos/xjrc/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/xjrc/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/xjrc/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xjrc/spack/labels{/name}","releases_url":"https://api.github.com/repos/xjrc/spack/releases{/id}","deployments_url":"https://api.github.com/repos/xjrc/spack/deployments","created_at":"2016-02-16T18:29:54Z","updated_at":"2016-02-16T18:29:55Z","pushed_at":"2016-10-10T21:37:11Z","git_url":"git://github.com/xjrc/spack.git","ssh_url":"git@github.com:xjrc/spack.git","clone_url":"https://github.com/xjrc/spack.git","svn_url":"https://github.com/xjrc/spack","homepage":"http://llnl.github.io/spack","size":11125,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"c2ca8693e9c706fac7709e06ec40e04bd8d2efa1","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-10-10T10:06:44Z","pushed_at":"2016-10-10T22:41:01Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":20261,"stargazers_count":163,"watchers_count":163,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":144,"mirror_url":null,"open_issues_count":361,"forks":144,"open_issues":361,"watchers":163,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1504"},"html":{"href":"https://github.com/LLNL/spack/pull/1504"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/1504"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/1504/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1504/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1504/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/af767127c767a9cf1a1d09a97646f2d6047f1d71"}}}}
{"actor":{"display_login":"adamjstewart"}}