{"action":"created","issue":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5840","repository_url":"https://api.github.com/repos/silverstripe/silverstripe-framework","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5840/labels{/name}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5840/comments","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5840/events","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5840","id":167292178,"number":5840,"title":"FIX: Remap obsolete ClassName values.","user":{"login":"sminnee","id":59968,"avatar_url":"https://avatars.githubusercontent.com/u/59968?v=3","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-25T06:37:45Z","updated_at":"2016-07-25T20:14:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/5840","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5840","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/5840.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/5840.patch"},"body":"With the namespacing work, there are a number of classname values that\r\nneed to be updated in existing databases.\r\n\r\nThis change to DatabaseAdmin carries out the remapping as part of\r\ndev/build."},"comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/235070582","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/5840#issuecomment-235070582","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/5840","id":235070582,"user":{"login":"sminnee","id":59968,"avatar_url":"https://avatars.githubusercontent.com/u/59968?v=3","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T20:14:47Z","updated_at":"2016-07-25T20:14:47Z","body":"ClassName (and Enum) dev/build calls preserve existing values in order to\nprevent data loss.\n\nIt does need a 2nd dev build to write the obsolete key out of the database\nschema, though. During an upgrade I think that's inevitable, but perhaps\nrequireField should be called after the rewrite to sort this out in a\nsingle run?\nOn Tue, 26 Jul 2016 at 3:51 AM, Daniel Hensby <notifications@github.com>\nwrote:\n\n> As you've written this for your won need, I'll assume I'm wrong, but\n> asking anyway:\n>\n> Doesn't this happen too late? Won't the DB table have been built with an\n> enum for the ClassName which won't contain the old class, therefore\n> meaning no records will contain the old ClassName and thus this won't\n> really do anything?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/silverstripe/silverstripe-framework/pull/5840#issuecomment-234995190>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AADqQAyxBIFhmhPXEliNXheGtnIIE7M1ks5qZNuUgaJpZM4JT0_p>\n> .\n>\n-- \nSam Minnée\nCEO\nSilverStripe Limited\n"}}
{"actor":{"display_login":"sminnee"}}