{"action":"closed","number":915,"pull_request":{"url":"https://api.github.com/repos/dpkp/kafka-python/pulls/915","id":98606071,"html_url":"https://github.com/dpkp/kafka-python/pull/915","diff_url":"https://github.com/dpkp/kafka-python/pull/915.diff","patch_url":"https://github.com/dpkp/kafka-python/pull/915.patch","issue_url":"https://api.github.com/repos/dpkp/kafka-python/issues/915","number":915,"state":"closed","locked":false,"title":"Always request metadata when set empty topics list for KafkaClient","user":{"login":"laz2","id":800356,"avatar_url":"https://avatars.githubusercontent.com/u/800356?v=3","gravatar_id":"","url":"https://api.github.com/users/laz2","html_url":"https://github.com/laz2","followers_url":"https://api.github.com/users/laz2/followers","following_url":"https://api.github.com/users/laz2/following{/other_user}","gists_url":"https://api.github.com/users/laz2/gists{/gist_id}","starred_url":"https://api.github.com/users/laz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laz2/subscriptions","organizations_url":"https://api.github.com/users/laz2/orgs","repos_url":"https://api.github.com/users/laz2/repos","events_url":"https://api.github.com/users/laz2/events{/privacy}","received_events_url":"https://api.github.com/users/laz2/received_events","type":"User","site_admin":false},"body":"KafkaConsumer can not resubscribe to new pattern without this fix because setting empty topics list always does not request metadata.\r\n\r\nDoes KafkaClient.set_topics need additional kwarg for request metadata?\r\n\r\nPS. KafkaConsumer.unsubcribe calls set_topics with empty list. Is this problem?","created_at":"2016-12-19T17:25:42Z","updated_at":"2016-12-27T23:36:58Z","closed_at":"2016-12-27T23:36:58Z","merged_at":"2016-12-27T23:36:58Z","merge_commit_sha":"4acb7f443464542d08753163d47c16b6b4a5a4a5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/915/commits","review_comments_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/915/comments","review_comment_url":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dpkp/kafka-python/issues/915/comments","statuses_url":"https://api.github.com/repos/dpkp/kafka-python/statuses/3ec8a8c12ae03148b284fe2ea76e0ca922336589","head":{"label":"laz2:fix-set-empty-topics","ref":"fix-set-empty-topics","sha":"3ec8a8c12ae03148b284fe2ea76e0ca922336589","user":{"login":"laz2","id":800356,"avatar_url":"https://avatars.githubusercontent.com/u/800356?v=3","gravatar_id":"","url":"https://api.github.com/users/laz2","html_url":"https://github.com/laz2","followers_url":"https://api.github.com/users/laz2/followers","following_url":"https://api.github.com/users/laz2/following{/other_user}","gists_url":"https://api.github.com/users/laz2/gists{/gist_id}","starred_url":"https://api.github.com/users/laz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laz2/subscriptions","organizations_url":"https://api.github.com/users/laz2/orgs","repos_url":"https://api.github.com/users/laz2/repos","events_url":"https://api.github.com/users/laz2/events{/privacy}","received_events_url":"https://api.github.com/users/laz2/received_events","type":"User","site_admin":false},"repo":{"id":73548592,"name":"kafka-python","full_name":"laz2/kafka-python","owner":{"login":"laz2","id":800356,"avatar_url":"https://avatars.githubusercontent.com/u/800356?v=3","gravatar_id":"","url":"https://api.github.com/users/laz2","html_url":"https://github.com/laz2","followers_url":"https://api.github.com/users/laz2/followers","following_url":"https://api.github.com/users/laz2/following{/other_user}","gists_url":"https://api.github.com/users/laz2/gists{/gist_id}","starred_url":"https://api.github.com/users/laz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laz2/subscriptions","organizations_url":"https://api.github.com/users/laz2/orgs","repos_url":"https://api.github.com/users/laz2/repos","events_url":"https://api.github.com/users/laz2/events{/privacy}","received_events_url":"https://api.github.com/users/laz2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laz2/kafka-python","description":"Python client for Apache Kafka","fork":true,"url":"https://api.github.com/repos/laz2/kafka-python","forks_url":"https://api.github.com/repos/laz2/kafka-python/forks","keys_url":"https://api.github.com/repos/laz2/kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laz2/kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laz2/kafka-python/teams","hooks_url":"https://api.github.com/repos/laz2/kafka-python/hooks","issue_events_url":"https://api.github.com/repos/laz2/kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/laz2/kafka-python/events","assignees_url":"https://api.github.com/repos/laz2/kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/laz2/kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/laz2/kafka-python/tags","blobs_url":"https://api.github.com/repos/laz2/kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laz2/kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laz2/kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/laz2/kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laz2/kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/laz2/kafka-python/languages","stargazers_url":"https://api.github.com/repos/laz2/kafka-python/stargazers","contributors_url":"https://api.github.com/repos/laz2/kafka-python/contributors","subscribers_url":"https://api.github.com/repos/laz2/kafka-python/subscribers","subscription_url":"https://api.github.com/repos/laz2/kafka-python/subscription","commits_url":"https://api.github.com/repos/laz2/kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/laz2/kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/laz2/kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/laz2/kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/laz2/kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/laz2/kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laz2/kafka-python/merges","archive_url":"https://api.github.com/repos/laz2/kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laz2/kafka-python/downloads","issues_url":"https://api.github.com/repos/laz2/kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/laz2/kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/laz2/kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/laz2/kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laz2/kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/laz2/kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/laz2/kafka-python/deployments","created_at":"2016-11-12T11:25:53Z","updated_at":"2016-11-12T11:25:55Z","pushed_at":"2016-12-19T19:17:34Z","git_url":"git://github.com/laz2/kafka-python.git","ssh_url":"git@github.com:laz2/kafka-python.git","clone_url":"https://github.com/laz2/kafka-python.git","svn_url":"https://github.com/laz2/kafka-python","homepage":"http://kafka-python.readthedocs.io/","size":2571,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dpkp:master","ref":"master","sha":"e8283958e42047a31bc914fe53b2060fa5e4481b","user":{"login":"dpkp","id":843444,"avatar_url":"https://avatars.githubusercontent.com/u/843444?v=3","gravatar_id":"","url":"https://api.github.com/users/dpkp","html_url":"https://github.com/dpkp","followers_url":"https://api.github.com/users/dpkp/followers","following_url":"https://api.github.com/users/dpkp/following{/other_user}","gists_url":"https://api.github.com/users/dpkp/gists{/gist_id}","starred_url":"https://api.github.com/users/dpkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpkp/subscriptions","organizations_url":"https://api.github.com/users/dpkp/orgs","repos_url":"https://api.github.com/users/dpkp/repos","events_url":"https://api.github.com/users/dpkp/events{/privacy}","received_events_url":"https://api.github.com/users/dpkp/received_events","type":"User","site_admin":false},"repo":{"id":5934517,"name":"kafka-python","full_name":"dpkp/kafka-python","owner":{"login":"dpkp","id":843444,"avatar_url":"https://avatars.githubusercontent.com/u/843444?v=3","gravatar_id":"","url":"https://api.github.com/users/dpkp","html_url":"https://github.com/dpkp","followers_url":"https://api.github.com/users/dpkp/followers","following_url":"https://api.github.com/users/dpkp/following{/other_user}","gists_url":"https://api.github.com/users/dpkp/gists{/gist_id}","starred_url":"https://api.github.com/users/dpkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpkp/subscriptions","organizations_url":"https://api.github.com/users/dpkp/orgs","repos_url":"https://api.github.com/users/dpkp/repos","events_url":"https://api.github.com/users/dpkp/events{/privacy}","received_events_url":"https://api.github.com/users/dpkp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpkp/kafka-python","description":"Python client for Apache Kafka","fork":false,"url":"https://api.github.com/repos/dpkp/kafka-python","forks_url":"https://api.github.com/repos/dpkp/kafka-python/forks","keys_url":"https://api.github.com/repos/dpkp/kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpkp/kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpkp/kafka-python/teams","hooks_url":"https://api.github.com/repos/dpkp/kafka-python/hooks","issue_events_url":"https://api.github.com/repos/dpkp/kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/dpkp/kafka-python/events","assignees_url":"https://api.github.com/repos/dpkp/kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/dpkp/kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/dpkp/kafka-python/tags","blobs_url":"https://api.github.com/repos/dpkp/kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpkp/kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpkp/kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpkp/kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpkp/kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dpkp/kafka-python/languages","stargazers_url":"https://api.github.com/repos/dpkp/kafka-python/stargazers","contributors_url":"https://api.github.com/repos/dpkp/kafka-python/contributors","subscribers_url":"https://api.github.com/repos/dpkp/kafka-python/subscribers","subscription_url":"https://api.github.com/repos/dpkp/kafka-python/subscription","commits_url":"https://api.github.com/repos/dpkp/kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpkp/kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpkp/kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpkp/kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpkp/kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/dpkp/kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpkp/kafka-python/merges","archive_url":"https://api.github.com/repos/dpkp/kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpkp/kafka-python/downloads","issues_url":"https://api.github.com/repos/dpkp/kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/dpkp/kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dpkp/kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dpkp/kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpkp/kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/dpkp/kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/dpkp/kafka-python/deployments","created_at":"2012-09-24T13:00:26Z","updated_at":"2016-12-27T14:18:58Z","pushed_at":"2016-12-27T23:36:58Z","git_url":"git://github.com/dpkp/kafka-python.git","ssh_url":"git@github.com:dpkp/kafka-python.git","clone_url":"https://github.com/dpkp/kafka-python.git","svn_url":"https://github.com/dpkp/kafka-python","homepage":"http://kafka-python.readthedocs.io/","size":2634,"stargazers_count":1179,"watchers_count":1179,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":489,"mirror_url":null,"open_issues_count":79,"forks":489,"open_issues":79,"watchers":1179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/915"},"html":{"href":"https://github.com/dpkp/kafka-python/pull/915"},"issue":{"href":"https://api.github.com/repos/dpkp/kafka-python/issues/915"},"comments":{"href":"https://api.github.com/repos/dpkp/kafka-python/issues/915/comments"},"review_comments":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/915/comments"},"review_comment":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dpkp/kafka-python/pulls/915/commits"},"statuses":{"href":"https://api.github.com/repos/dpkp/kafka-python/statuses/3ec8a8c12ae03148b284fe2ea76e0ca922336589"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dpkp","id":843444,"avatar_url":"https://avatars.githubusercontent.com/u/843444?v=3","gravatar_id":"","url":"https://api.github.com/users/dpkp","html_url":"https://github.com/dpkp","followers_url":"https://api.github.com/users/dpkp/followers","following_url":"https://api.github.com/users/dpkp/following{/other_user}","gists_url":"https://api.github.com/users/dpkp/gists{/gist_id}","starred_url":"https://api.github.com/users/dpkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpkp/subscriptions","organizations_url":"https://api.github.com/users/dpkp/orgs","repos_url":"https://api.github.com/users/dpkp/repos","events_url":"https://api.github.com/users/dpkp/events{/privacy}","received_events_url":"https://api.github.com/users/dpkp/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":27,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"dpkp"}}