{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/66819318","id":66819318,"diff_hunk":"@@ -157,92 +159,122 @@ class EpochsVectorizer(TransformerMixin):\n \n     Attributes\n     ----------\n-    n_channels : int\n+    n_channels_ : int\n         The number of channels.\n-    n_times : int\n-        The number of time points.\n+    n_epochs_ : int\n+        The number of data samples.","path":"mne/decoding/transformer.py","position":28,"original_position":28,"commit_id":"6bc2e2e0e8273b164b6a3a39289c2ad8393e506a","original_commit_id":"6bc2e2e0e8273b164b6a3a39289c2ad8393e506a","user":{"login":"kaichogami","id":6412770,"avatar_url":"https://avatars.githubusercontent.com/u/6412770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaichogami","html_url":"https://github.com/kaichogami","followers_url":"https://api.github.com/users/kaichogami/followers","following_url":"https://api.github.com/users/kaichogami/following{/other_user}","gists_url":"https://api.github.com/users/kaichogami/gists{/gist_id}","starred_url":"https://api.github.com/users/kaichogami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaichogami/subscriptions","organizations_url":"https://api.github.com/users/kaichogami/orgs","repos_url":"https://api.github.com/users/kaichogami/repos","events_url":"https://api.github.com/users/kaichogami/events{/privacy}","received_events_url":"https://api.github.com/users/kaichogami/received_events","type":"User","site_admin":false},"body":"Alright, got it. Although the number of channels in every dataset has to be the same. Is that correct?","created_at":"2016-06-13T16:03:23Z","updated_at":"2016-06-13T16:03:24Z","html_url":"https://github.com/mne-tools/mne-python/pull/3245#discussion_r66819318","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/66819318"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3245#discussion_r66819318"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245","id":70969158,"html_url":"https://github.com/mne-tools/mne-python/pull/3245","diff_url":"https://github.com/mne-tools/mne-python/pull/3245.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3245.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3245","number":3245,"state":"open","locked":false,"title":"[WIP] EpochVectorizer changed to accept epochs","user":{"login":"kaichogami","id":6412770,"avatar_url":"https://avatars.githubusercontent.com/u/6412770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaichogami","html_url":"https://github.com/kaichogami","followers_url":"https://api.github.com/users/kaichogami/followers","following_url":"https://api.github.com/users/kaichogami/following{/other_user}","gists_url":"https://api.github.com/users/kaichogami/gists{/gist_id}","starred_url":"https://api.github.com/users/kaichogami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaichogami/subscriptions","organizations_url":"https://api.github.com/users/kaichogami/orgs","repos_url":"https://api.github.com/users/kaichogami/repos","events_url":"https://api.github.com/users/kaichogami/events{/privacy}","received_events_url":"https://api.github.com/users/kaichogami/received_events","type":"User","site_admin":false},"body":"Hello\r\nAfter discussion with @kingjr @dengemann we came into the conclusion of new API for decoding and dropped `Vectorizer`(see #3212). Following it closely with `scikit-learn` each transformer will work with 2-D data. Data from complex objects would be extracted by a new `Vectorizer` class.\r\n```\r\ne = EpochsVectorizer()\r\nX, y = e.fit_transform(epochs)\r\nclf = make_pipeline(Covariance(info = epochs.info), LogisticRegression())\r\nclf.fit(X[train], y[train])\r\npred = clf.predict(X[test])\r\n```\r\nThe `info`, being a mne step could change in the pipeline of transformers. Passing the updated `info` requires thinking.\r\nFor getting community feedback, I have changed `EpochsVectorizer`. Please let us know what are your views on our proposed change!\r\nThank you\r\n","created_at":"2016-05-22T06:22:16Z","updated_at":"2016-06-13T16:03:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"578c9b37832fe40fce5d6a8ed73a65432297bebd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3245/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/6bc2e2e0e8273b164b6a3a39289c2ad8393e506a","head":{"label":"kaichogami:basic_pipeline","ref":"basic_pipeline","sha":"6bc2e2e0e8273b164b6a3a39289c2ad8393e506a","user":{"login":"kaichogami","id":6412770,"avatar_url":"https://avatars.githubusercontent.com/u/6412770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaichogami","html_url":"https://github.com/kaichogami","followers_url":"https://api.github.com/users/kaichogami/followers","following_url":"https://api.github.com/users/kaichogami/following{/other_user}","gists_url":"https://api.github.com/users/kaichogami/gists{/gist_id}","starred_url":"https://api.github.com/users/kaichogami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaichogami/subscriptions","organizations_url":"https://api.github.com/users/kaichogami/orgs","repos_url":"https://api.github.com/users/kaichogami/repos","events_url":"https://api.github.com/users/kaichogami/events{/privacy}","received_events_url":"https://api.github.com/users/kaichogami/received_events","type":"User","site_admin":false},"repo":{"id":52144716,"name":"mne-python","full_name":"kaichogami/mne-python","owner":{"login":"kaichogami","id":6412770,"avatar_url":"https://avatars.githubusercontent.com/u/6412770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaichogami","html_url":"https://github.com/kaichogami","followers_url":"https://api.github.com/users/kaichogami/followers","following_url":"https://api.github.com/users/kaichogami/following{/other_user}","gists_url":"https://api.github.com/users/kaichogami/gists{/gist_id}","starred_url":"https://api.github.com/users/kaichogami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaichogami/subscriptions","organizations_url":"https://api.github.com/users/kaichogami/orgs","repos_url":"https://api.github.com/users/kaichogami/repos","events_url":"https://api.github.com/users/kaichogami/events{/privacy}","received_events_url":"https://api.github.com/users/kaichogami/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaichogami/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/kaichogami/mne-python","forks_url":"https://api.github.com/repos/kaichogami/mne-python/forks","keys_url":"https://api.github.com/repos/kaichogami/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaichogami/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaichogami/mne-python/teams","hooks_url":"https://api.github.com/repos/kaichogami/mne-python/hooks","issue_events_url":"https://api.github.com/repos/kaichogami/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/kaichogami/mne-python/events","assignees_url":"https://api.github.com/repos/kaichogami/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/kaichogami/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/kaichogami/mne-python/tags","blobs_url":"https://api.github.com/repos/kaichogami/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaichogami/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaichogami/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaichogami/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaichogami/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/kaichogami/mne-python/languages","stargazers_url":"https://api.github.com/repos/kaichogami/mne-python/stargazers","contributors_url":"https://api.github.com/repos/kaichogami/mne-python/contributors","subscribers_url":"https://api.github.com/repos/kaichogami/mne-python/subscribers","subscription_url":"https://api.github.com/repos/kaichogami/mne-python/subscription","commits_url":"https://api.github.com/repos/kaichogami/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaichogami/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaichogami/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaichogami/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaichogami/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/kaichogami/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaichogami/mne-python/merges","archive_url":"https://api.github.com/repos/kaichogami/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaichogami/mne-python/downloads","issues_url":"https://api.github.com/repos/kaichogami/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/kaichogami/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/kaichogami/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/kaichogami/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaichogami/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/kaichogami/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/kaichogami/mne-python/deployments","created_at":"2016-02-20T08:49:13Z","updated_at":"2016-02-20T08:49:17Z","pushed_at":"2016-06-13T04:53:54Z","git_url":"git://github.com/kaichogami/mne-python.git","ssh_url":"git@github.com:kaichogami/mne-python.git","clone_url":"https://github.com/kaichogami/mne-python.git","svn_url":"https://github.com/kaichogami/mne-python","homepage":"http://martinos.org/mne/","size":86420,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"e5cbb9050fd97255a52ec487fde30b899c0587d6","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2016-06-02T20:51:39Z","pushed_at":"2016-06-13T15:59:14Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":178515,"stargazers_count":203,"watchers_count":203,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":193,"mirror_url":null,"open_issues_count":201,"forks":193,"open_issues":201,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3245"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3245"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3245/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3245/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/6bc2e2e0e8273b164b6a3a39289c2ad8393e506a"}}}}
{"actor":{"display_login":"kaichogami"}}