{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/63502600","id":63502600,"diff_hunk":"@@ -50,14 +51,18 @@ class NodeListText extends Text {\n \t}\n \n \t/**\n-\t * Custom toJSON method to solve child-parent circular dependencies.\n+\t * Custom toJSON method to solve child-parent circular dependencies when serializing NodeListText to JSON string.\n \t *\n \t * @returns {Object} Clone of this object with the parent property replaced with its name.\n \t */\n \ttoJSON() {\n \t\tconst json = clone( this );\n \n-\t\tjson.parent = json.parent ? this.parent.name : null;\n+\t\t// Due to circular references we need to remove parent reference.\n+\t\tjson.parent = this.parent ? this.parent.name : null;","path":"src/treemodel/nodelist.js","position":22,"original_position":22,"commit_id":"af806795e7e917d3758d21a7f01dc401fc1708ff","original_commit_id":"af806795e7e917d3758d21a7f01dc401fc1708ff","user":{"login":"Reinmar","id":156149,"avatar_url":"https://avatars.githubusercontent.com/u/156149?v=3","gravatar_id":"","url":"https://api.github.com/users/Reinmar","html_url":"https://github.com/Reinmar","followers_url":"https://api.github.com/users/Reinmar/followers","following_url":"https://api.github.com/users/Reinmar/following{/other_user}","gists_url":"https://api.github.com/users/Reinmar/gists{/gist_id}","starred_url":"https://api.github.com/users/Reinmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reinmar/subscriptions","organizations_url":"https://api.github.com/users/Reinmar/orgs","repos_url":"https://api.github.com/users/Reinmar/repos","events_url":"https://api.github.com/users/Reinmar/events{/privacy}","received_events_url":"https://api.github.com/users/Reinmar/received_events","type":"User","site_admin":false},"body":"Do we need parent at all? I guess @scofalik has been using it for debugging. But now we have different tools, so it's unnecessary here.","created_at":"2016-05-17T10:57:56Z","updated_at":"2016-05-17T10:57:56Z","html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/418#discussion_r63502600","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments/63502600"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/418#discussion_r63502600"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418"}}},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418","id":70209497,"html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/418","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/418.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/418.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/418","number":418,"state":"open","locked":false,"title":"T/396 TreeModel serialization / deseralization.","user":{"login":"jodator","id":247363,"avatar_url":"https://avatars.githubusercontent.com/u/247363?v=3","gravatar_id":"","url":"https://api.github.com/users/jodator","html_url":"https://github.com/jodator","followers_url":"https://api.github.com/users/jodator/followers","following_url":"https://api.github.com/users/jodator/following{/other_user}","gists_url":"https://api.github.com/users/jodator/gists{/gist_id}","starred_url":"https://api.github.com/users/jodator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodator/subscriptions","organizations_url":"https://api.github.com/users/jodator/orgs","repos_url":"https://api.github.com/users/jodator/repos","events_url":"https://api.github.com/users/jodator/events{/privacy}","received_events_url":"https://api.github.com/users/jodator/received_events","type":"User","site_admin":false},"body":"This PR introduces converting TreeModel deltas to JSON and from JSON objects defined in #396.","created_at":"2016-05-16T15:02:59Z","updated_at":"2016-05-17T10:57:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43dec55a42e673f10b4151d69d242e8a674c7200","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/418/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/af806795e7e917d3758d21a7f01dc401fc1708ff","head":{"label":"ckeditor:t/396","ref":"t/396","sha":"af806795e7e917d3758d21a7f01dc401fc1708ff","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 Editing Engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2016-05-11T09:41:59Z","pushed_at":"2016-05-17T10:16:28Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"","size":2778,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":82,"forks":16,"open_issues":82,"watchers":26,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"9865a30bcb6e0ef4a6a97bf8fcee42d867eabbad","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 Editing Engine.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2016-05-11T09:41:59Z","pushed_at":"2016-05-17T10:16:28Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"","size":2778,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":82,"forks":16,"open_issues":82,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/418"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/418"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/af806795e7e917d3758d21a7f01dc401fc1708ff"}}}}