{"action":"opened","issue":{"url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/1133","repository_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core","labels_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/1133/labels{/name}","comments_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/1133/comments","events_url":"https://api.github.com/repos/couchbase/couchbase-lite-java-core/issues/1133/events","html_url":"https://github.com/couchbase/couchbase-lite-java-core/issues/1133","id":142184439,"number":1133,"title":"Racing on condition in ReplicationInternal.setError()","user":{"login":"pasin","id":801454,"avatar_url":"https://avatars.githubusercontent.com/u/801454?v=3","gravatar_id":"","url":"https://api.github.com/users/pasin","html_url":"https://github.com/pasin","followers_url":"https://api.github.com/users/pasin/followers","following_url":"https://api.github.com/users/pasin/following{/other_user}","gists_url":"https://api.github.com/users/pasin/gists{/gist_id}","starred_url":"https://api.github.com/users/pasin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasin/subscriptions","organizations_url":"https://api.github.com/users/pasin/orgs","repos_url":"https://api.github.com/users/pasin/repos","events_url":"https://api.github.com/users/pasin/events{/privacy}","received_events_url":"https://api.github.com/users/pasin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-03-20T17:34:45Z","updated_at":"2016-03-20T17:34:45Z","closed_at":null,"body":"ReplicationInternal.setError() will be called from multiple threads of RemoteRequest Workers so there is a possibility of racing condition over `self.error` variable and could cause the retry logic to fail to retry.\r\n\r\nThis could result to unpredictable behaviors. At least, there could be some pending failed revisions to push to the remote server."}}