{"action":"created","issue":{"url":"https://api.github.com/repos/xetorthio/jedis/issues/1281","repository_url":"https://api.github.com/repos/xetorthio/jedis","labels_url":"https://api.github.com/repos/xetorthio/jedis/issues/1281/labels{/name}","comments_url":"https://api.github.com/repos/xetorthio/jedis/issues/1281/comments","events_url":"https://api.github.com/repos/xetorthio/jedis/issues/1281/events","html_url":"https://github.com/xetorthio/jedis/pull/1281","id":154488880,"number":1281,"title":"Implement fix in JedisPubSub to support PING/PONG during subscription.","user":{"login":"Anisotrop","id":13450862,"avatar_url":"https://avatars.githubusercontent.com/u/13450862?v=3","gravatar_id":"","url":"https://api.github.com/users/Anisotrop","html_url":"https://github.com/Anisotrop","followers_url":"https://api.github.com/users/Anisotrop/followers","following_url":"https://api.github.com/users/Anisotrop/following{/other_user}","gists_url":"https://api.github.com/users/Anisotrop/gists{/gist_id}","starred_url":"https://api.github.com/users/Anisotrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anisotrop/subscriptions","organizations_url":"https://api.github.com/users/Anisotrop/orgs","repos_url":"https://api.github.com/users/Anisotrop/repos","events_url":"https://api.github.com/users/Anisotrop/events{/privacy}","received_events_url":"https://api.github.com/users/Anisotrop/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xetorthio/jedis/labels/WAIT%20FOR%20MORE%20REVIEWS","name":"WAIT FOR MORE REVIEWS","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/xetorthio/jedis/milestones/25","html_url":"https://github.com/xetorthio/jedis/milestones/2.8.2","labels_url":"https://api.github.com/repos/xetorthio/jedis/milestones/25/labels","id":1644560,"number":25,"title":"2.8.2","description":"","creator":{"login":"marcosnils","id":1578458,"avatar_url":"https://avatars.githubusercontent.com/u/1578458?v=3","gravatar_id":"","url":"https://api.github.com/users/marcosnils","html_url":"https://github.com/marcosnils","followers_url":"https://api.github.com/users/marcosnils/followers","following_url":"https://api.github.com/users/marcosnils/following{/other_user}","gists_url":"https://api.github.com/users/marcosnils/gists{/gist_id}","starred_url":"https://api.github.com/users/marcosnils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcosnils/subscriptions","organizations_url":"https://api.github.com/users/marcosnils/orgs","repos_url":"https://api.github.com/users/marcosnils/repos","events_url":"https://api.github.com/users/marcosnils/events{/privacy}","received_events_url":"https://api.github.com/users/marcosnils/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":3,"state":"open","created_at":"2016-03-15T01:07:51Z","updated_at":"2016-05-12T22:53:12Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-05-12T13:56:52Z","updated_at":"2016-05-13T14:52:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xetorthio/jedis/pulls/1281","html_url":"https://github.com/xetorthio/jedis/pull/1281","diff_url":"https://github.com/xetorthio/jedis/pull/1281.diff","patch_url":"https://github.com/xetorthio/jedis/pull/1281.patch"},"body":"Had to change pom.xml in order to pass the javadoc generation.\r\n\r\n[...]\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] BUILD SUCCESS\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] Total time: 01:35 min\r\n[INFO] Finished at: 2016-05-12T16:39:27+03:00\r\n[INFO] Final Memory: 24M/60M\r\n[INFO] ------------------------------------------------------------------------\r\nmake stop\r\n[...]"},"comment":{"url":"https://api.github.com/repos/xetorthio/jedis/issues/comments/219066327","html_url":"https://github.com/xetorthio/jedis/pull/1281#issuecomment-219066327","issue_url":"https://api.github.com/repos/xetorthio/jedis/issues/1281","id":219066327,"user":{"login":"HeartSaVioR","id":1317309,"avatar_url":"https://avatars.githubusercontent.com/u/1317309?v=3","gravatar_id":"","url":"https://api.github.com/users/HeartSaVioR","html_url":"https://github.com/HeartSaVioR","followers_url":"https://api.github.com/users/HeartSaVioR/followers","following_url":"https://api.github.com/users/HeartSaVioR/following{/other_user}","gists_url":"https://api.github.com/users/HeartSaVioR/gists{/gist_id}","starred_url":"https://api.github.com/users/HeartSaVioR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeartSaVioR/subscriptions","organizations_url":"https://api.github.com/users/HeartSaVioR/orgs","repos_url":"https://api.github.com/users/HeartSaVioR/repos","events_url":"https://api.github.com/users/HeartSaVioR/events{/privacy}","received_events_url":"https://api.github.com/users/HeartSaVioR/received_events","type":"User","site_admin":false},"created_at":"2016-05-13T14:52:31Z","updated_at":"2016-05-13T14:52:31Z","body":"LGTM, too. Thanks for the contribution.\r\nBtw, I think it would be better when JedisPubSub automatically does PING-PONG internally, but it should be done with separate issue."}}