{"action":"closed","issue":{"url":"https://api.github.com/repos/girder/girder/issues/1652","repository_url":"https://api.github.com/repos/girder/girder","labels_url":"https://api.github.com/repos/girder/girder/issues/1652/labels{/name}","comments_url":"https://api.github.com/repos/girder/girder/issues/1652/comments","events_url":"https://api.github.com/repos/girder/girder/issues/1652/events","html_url":"https://github.com/girder/girder/issues/1652","id":184997996,"number":1652,"title":"use different strategy to create common Webpack chunk","user":{"login":"sebastienbarre","id":329967,"avatar_url":"https://avatars.githubusercontent.com/u/329967?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienbarre","html_url":"https://github.com/sebastienbarre","followers_url":"https://api.github.com/users/sebastienbarre/followers","following_url":"https://api.github.com/users/sebastienbarre/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbarre/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbarre/subscriptions","organizations_url":"https://api.github.com/users/sebastienbarre/orgs","repos_url":"https://api.github.com/users/sebastienbarre/repos","events_url":"https://api.github.com/users/sebastienbarre/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbarre/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"sebastienbarre","id":329967,"avatar_url":"https://avatars.githubusercontent.com/u/329967?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienbarre","html_url":"https://github.com/sebastienbarre","followers_url":"https://api.github.com/users/sebastienbarre/followers","following_url":"https://api.github.com/users/sebastienbarre/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbarre/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbarre/subscriptions","organizations_url":"https://api.github.com/users/sebastienbarre/orgs","repos_url":"https://api.github.com/users/sebastienbarre/repos","events_url":"https://api.github.com/users/sebastienbarre/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbarre/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebastienbarre","id":329967,"avatar_url":"https://avatars.githubusercontent.com/u/329967?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienbarre","html_url":"https://github.com/sebastienbarre","followers_url":"https://api.github.com/users/sebastienbarre/followers","following_url":"https://api.github.com/users/sebastienbarre/following{/other_user}","gists_url":"https://api.github.com/users/sebastienbarre/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienbarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienbarre/subscriptions","organizations_url":"https://api.github.com/users/sebastienbarre/orgs","repos_url":"https://api.github.com/users/sebastienbarre/repos","events_url":"https://api.github.com/users/sebastienbarre/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienbarre/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-10-25T01:44:30Z","updated_at":"2016-11-07T16:14:56Z","closed_at":"2016-11-07T16:14:56Z","body":"Creating an issue (for myself mostly) to revisit the Webpack strategy used to create the common Webpack chunk. This was mentioned in the original #1476 Webpack PR (copied below). This is as yet to be investigated, but it seems to have adverse affect on CI, as exposed by @jbeezley in DigitalSlideArchive/large_image#111:\n- There still appears to be too much duplicated code going in `girder.main.min.js` and each `plugin.min.js`; this needs to be investigated and fixed by myself (Seb; consider [robertknight/webpack-bundle-size-analyzer](https://github.com/robertknight/webpack-bundle-size-analyzer)), also consider the `DllPlugin`, which would increase performance as well ([Webpack Plugins we been keepin on the DLL](https://medium.com/@soederpop/webpack-plugins-been-we-been-keepin-on-the-dll-cdfdd6cb8cd7), [Optimizing Webpack for Faster React Builds](http://engineering.invisionapp.com/post/optimizing-webpack/), [Optimizing Webpack build times and improving caching with DLL bundles](https://robertknight.github.io/posts/webpack-dll-plugins/), [webpack/examples/dll](https://github.com/webpack/webpack/tree/master/examples/dll)). Also check [trivago/parallel-webpack: Builds multi-config webpack projects in parallel](https://github.com/trivago/parallel-webpack)\n"}}
{"actor":{"display_login":"zachmullen"}}