{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/tofino/pulls/comments/78148119","id":78148119,"diff_hunk":"@@ -3,10 +3,9 @@\n \n import colors from 'colors/safe';\n import fs from 'fs-promise';\n+import path from 'path';\n \n-import { BROWSER_FRONTENDS_PATH } from './utils/const';\n-import { makeDevConfig as dev, makeProdConfig as prod } from './config/webpack.base';\n-import { getBuildConfig } from './utils';\n+import { BUILD_WEBPACK_CONFIS_PATH, BROWSER_FRONTENDS_PATH } from './utils/const';","path":"build/task-build-browser.js","position":9,"original_position":9,"commit_id":"a110018a63ecf469f3bf01cfa33723dbfca9c21d","original_commit_id":"a110018a63ecf469f3bf01cfa33723dbfca9c21d","user":{"login":"jsantell","id":641267,"avatar_url":"https://avatars.githubusercontent.com/u/641267?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantell","html_url":"https://github.com/jsantell","followers_url":"https://api.github.com/users/jsantell/followers","following_url":"https://api.github.com/users/jsantell/following{/other_user}","gists_url":"https://api.github.com/users/jsantell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantell/subscriptions","organizations_url":"https://api.github.com/users/jsantell/orgs","repos_url":"https://api.github.com/users/jsantell/repos","events_url":"https://api.github.com/users/jsantell/events{/privacy}","received_events_url":"https://api.github.com/users/jsantell/received_events","type":"User","site_admin":false},"body":"I think `BUILD_WEBPACK_CONFIS_PATH` is a typo","created_at":"2016-09-09T08:54:10Z","updated_at":"2016-09-09T08:54:10Z","html_url":"https://github.com/mozilla/tofino/pull/1064#discussion_r78148119","pull_request_url":"https://api.github.com/repos/mozilla/tofino/pulls/1064","_links":{"self":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/comments/78148119"},"html":{"href":"https://github.com/mozilla/tofino/pull/1064#discussion_r78148119"},"pull_request":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1064"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/tofino/pulls/1064","id":84614444,"html_url":"https://github.com/mozilla/tofino/pull/1064","diff_url":"https://github.com/mozilla/tofino/pull/1064.diff","patch_url":"https://github.com/mozilla/tofino/pull/1064.patch","issue_url":"https://api.github.com/repos/mozilla/tofino/issues/1064","number":1064,"state":"open","locked":false,"title":"Fix the build system to avoid having dangling IO streams which prevent the main process from closing","user":{"login":"victorporof","id":248899,"avatar_url":"https://avatars.githubusercontent.com/u/248899?v=3","gravatar_id":"","url":"https://api.github.com/users/victorporof","html_url":"https://github.com/victorporof","followers_url":"https://api.github.com/users/victorporof/followers","following_url":"https://api.github.com/users/victorporof/following{/other_user}","gists_url":"https://api.github.com/users/victorporof/gists{/gist_id}","starred_url":"https://api.github.com/users/victorporof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorporof/subscriptions","organizations_url":"https://api.github.com/users/victorporof/orgs","repos_url":"https://api.github.com/users/victorporof/repos","events_url":"https://api.github.com/users/victorporof/events{/privacy}","received_events_url":"https://api.github.com/users/victorporof/received_events","type":"User","site_admin":false},"body":"This should fix the test suite stalling in the frontend-rewrite-related PRs.\r\n\r\nPlease see individual commits.","created_at":"2016-09-09T08:47:07Z","updated_at":"2016-09-09T08:54:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b61a6c00e8c409c5d0dc1387fae71b9c4fe388a6","assignee":{"login":"jsantell","id":641267,"avatar_url":"https://avatars.githubusercontent.com/u/641267?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantell","html_url":"https://github.com/jsantell","followers_url":"https://api.github.com/users/jsantell/followers","following_url":"https://api.github.com/users/jsantell/following{/other_user}","gists_url":"https://api.github.com/users/jsantell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantell/subscriptions","organizations_url":"https://api.github.com/users/jsantell/orgs","repos_url":"https://api.github.com/users/jsantell/repos","events_url":"https://api.github.com/users/jsantell/events{/privacy}","received_events_url":"https://api.github.com/users/jsantell/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsantell","id":641267,"avatar_url":"https://avatars.githubusercontent.com/u/641267?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantell","html_url":"https://github.com/jsantell","followers_url":"https://api.github.com/users/jsantell/followers","following_url":"https://api.github.com/users/jsantell/following{/other_user}","gists_url":"https://api.github.com/users/jsantell/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantell/subscriptions","organizations_url":"https://api.github.com/users/jsantell/orgs","repos_url":"https://api.github.com/users/jsantell/repos","events_url":"https://api.github.com/users/jsantell/events{/privacy}","received_events_url":"https://api.github.com/users/jsantell/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/tofino/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/mozilla/tofino/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/mozilla/tofino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/tofino/issues/1064/comments","statuses_url":"https://api.github.com/repos/mozilla/tofino/statuses/a110018a63ecf469f3bf01cfa33723dbfca9c21d","head":{"label":"victorporof:fix-tests","ref":"fix-tests","sha":"a110018a63ecf469f3bf01cfa33723dbfca9c21d","user":{"login":"victorporof","id":248899,"avatar_url":"https://avatars.githubusercontent.com/u/248899?v=3","gravatar_id":"","url":"https://api.github.com/users/victorporof","html_url":"https://github.com/victorporof","followers_url":"https://api.github.com/users/victorporof/followers","following_url":"https://api.github.com/users/victorporof/following{/other_user}","gists_url":"https://api.github.com/users/victorporof/gists{/gist_id}","starred_url":"https://api.github.com/users/victorporof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorporof/subscriptions","organizations_url":"https://api.github.com/users/victorporof/orgs","repos_url":"https://api.github.com/users/victorporof/repos","events_url":"https://api.github.com/users/victorporof/events{/privacy}","received_events_url":"https://api.github.com/users/victorporof/received_events","type":"User","site_admin":false},"repo":{"id":56032341,"name":"tofino","full_name":"victorporof/tofino","owner":{"login":"victorporof","id":248899,"avatar_url":"https://avatars.githubusercontent.com/u/248899?v=3","gravatar_id":"","url":"https://api.github.com/users/victorporof","html_url":"https://github.com/victorporof","followers_url":"https://api.github.com/users/victorporof/followers","following_url":"https://api.github.com/users/victorporof/following{/other_user}","gists_url":"https://api.github.com/users/victorporof/gists{/gist_id}","starred_url":"https://api.github.com/users/victorporof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorporof/subscriptions","organizations_url":"https://api.github.com/users/victorporof/orgs","repos_url":"https://api.github.com/users/victorporof/repos","events_url":"https://api.github.com/users/victorporof/events{/privacy}","received_events_url":"https://api.github.com/users/victorporof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victorporof/tofino","description":"Project Tofino is a browser interaction experiment.","fork":true,"url":"https://api.github.com/repos/victorporof/tofino","forks_url":"https://api.github.com/repos/victorporof/tofino/forks","keys_url":"https://api.github.com/repos/victorporof/tofino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victorporof/tofino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victorporof/tofino/teams","hooks_url":"https://api.github.com/repos/victorporof/tofino/hooks","issue_events_url":"https://api.github.com/repos/victorporof/tofino/issues/events{/number}","events_url":"https://api.github.com/repos/victorporof/tofino/events","assignees_url":"https://api.github.com/repos/victorporof/tofino/assignees{/user}","branches_url":"https://api.github.com/repos/victorporof/tofino/branches{/branch}","tags_url":"https://api.github.com/repos/victorporof/tofino/tags","blobs_url":"https://api.github.com/repos/victorporof/tofino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victorporof/tofino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victorporof/tofino/git/refs{/sha}","trees_url":"https://api.github.com/repos/victorporof/tofino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victorporof/tofino/statuses/{sha}","languages_url":"https://api.github.com/repos/victorporof/tofino/languages","stargazers_url":"https://api.github.com/repos/victorporof/tofino/stargazers","contributors_url":"https://api.github.com/repos/victorporof/tofino/contributors","subscribers_url":"https://api.github.com/repos/victorporof/tofino/subscribers","subscription_url":"https://api.github.com/repos/victorporof/tofino/subscription","commits_url":"https://api.github.com/repos/victorporof/tofino/commits{/sha}","git_commits_url":"https://api.github.com/repos/victorporof/tofino/git/commits{/sha}","comments_url":"https://api.github.com/repos/victorporof/tofino/comments{/number}","issue_comment_url":"https://api.github.com/repos/victorporof/tofino/issues/comments{/number}","contents_url":"https://api.github.com/repos/victorporof/tofino/contents/{+path}","compare_url":"https://api.github.com/repos/victorporof/tofino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victorporof/tofino/merges","archive_url":"https://api.github.com/repos/victorporof/tofino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victorporof/tofino/downloads","issues_url":"https://api.github.com/repos/victorporof/tofino/issues{/number}","pulls_url":"https://api.github.com/repos/victorporof/tofino/pulls{/number}","milestones_url":"https://api.github.com/repos/victorporof/tofino/milestones{/number}","notifications_url":"https://api.github.com/repos/victorporof/tofino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victorporof/tofino/labels{/name}","releases_url":"https://api.github.com/repos/victorporof/tofino/releases{/id}","deployments_url":"https://api.github.com/repos/victorporof/tofino/deployments","created_at":"2016-04-12T04:57:51Z","updated_at":"2016-06-03T13:00:36Z","pushed_at":"2016-09-09T08:44:17Z","git_url":"git://github.com/victorporof/tofino.git","ssh_url":"git@github.com:victorporof/tofino.git","clone_url":"https://github.com/victorporof/tofino.git","svn_url":"https://github.com/victorporof/tofino","homepage":"https://medium.com/project-tofino","size":4064,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"590ed9d2561dd3406a75e846ce9b71b9b2cf9504","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":55401807,"name":"tofino","full_name":"mozilla/tofino","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/tofino","description":"Project Tofino is a browser interaction experiment.","fork":false,"url":"https://api.github.com/repos/mozilla/tofino","forks_url":"https://api.github.com/repos/mozilla/tofino/forks","keys_url":"https://api.github.com/repos/mozilla/tofino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/tofino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/tofino/teams","hooks_url":"https://api.github.com/repos/mozilla/tofino/hooks","issue_events_url":"https://api.github.com/repos/mozilla/tofino/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/tofino/events","assignees_url":"https://api.github.com/repos/mozilla/tofino/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/tofino/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/tofino/tags","blobs_url":"https://api.github.com/repos/mozilla/tofino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/tofino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/tofino/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/tofino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/tofino/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/tofino/languages","stargazers_url":"https://api.github.com/repos/mozilla/tofino/stargazers","contributors_url":"https://api.github.com/repos/mozilla/tofino/contributors","subscribers_url":"https://api.github.com/repos/mozilla/tofino/subscribers","subscription_url":"https://api.github.com/repos/mozilla/tofino/subscription","commits_url":"https://api.github.com/repos/mozilla/tofino/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/tofino/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/tofino/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/tofino/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/tofino/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/tofino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/tofino/merges","archive_url":"https://api.github.com/repos/mozilla/tofino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/tofino/downloads","issues_url":"https://api.github.com/repos/mozilla/tofino/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/tofino/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/tofino/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/tofino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/tofino/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/tofino/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/tofino/deployments","created_at":"2016-04-04T10:13:26Z","updated_at":"2016-09-06T23:48:58Z","pushed_at":"2016-09-09T08:47:07Z","git_url":"git://github.com/mozilla/tofino.git","ssh_url":"git@github.com:mozilla/tofino.git","clone_url":"https://github.com/mozilla/tofino.git","svn_url":"https://github.com/mozilla/tofino","homepage":"https://mozilla.github.io/tofino","size":5632,"stargazers_count":519,"watchers_count":519,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":104,"forks":55,"open_issues":104,"watchers":519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1064"},"html":{"href":"https://github.com/mozilla/tofino/pull/1064"},"issue":{"href":"https://api.github.com/repos/mozilla/tofino/issues/1064"},"comments":{"href":"https://api.github.com/repos/mozilla/tofino/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/tofino/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/tofino/statuses/a110018a63ecf469f3bf01cfa33723dbfca9c21d"}}}}
{"actor":{"display_login":"jsantell"}}