{"action":"created","issue":{"url":"https://api.github.com/repos/curl/curl/issues/946","repository_url":"https://api.github.com/repos/curl/curl","labels_url":"https://api.github.com/repos/curl/curl/issues/946/labels{/name}","comments_url":"https://api.github.com/repos/curl/curl/issues/946/comments","events_url":"https://api.github.com/repos/curl/curl/issues/946/events","html_url":"https://github.com/curl/curl/pull/946","id":169791527,"number":946,"title":"Windows Build: OpenSSL 1.1 and ZLIB","user":{"login":"rodwiddowson","id":249743,"avatar_url":"https://avatars.githubusercontent.com/u/249743?v=3","gravatar_id":"","url":"https://api.github.com/users/rodwiddowson","html_url":"https://github.com/rodwiddowson","followers_url":"https://api.github.com/users/rodwiddowson/followers","following_url":"https://api.github.com/users/rodwiddowson/following{/other_user}","gists_url":"https://api.github.com/users/rodwiddowson/gists{/gist_id}","starred_url":"https://api.github.com/users/rodwiddowson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodwiddowson/subscriptions","organizations_url":"https://api.github.com/users/rodwiddowson/orgs","repos_url":"https://api.github.com/users/rodwiddowson/repos","events_url":"https://api.github.com/users/rodwiddowson/events{/privacy}","received_events_url":"https://api.github.com/users/rodwiddowson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/curl/curl/labels/build","name":"build","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-07T11:12:11Z","updated_at":"2016-08-08T14:17:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/curl/curl/pulls/946","html_url":"https://github.com/curl/curl/pull/946","diff_url":"https://github.com/curl/curl/pull/946.diff","patch_url":"https://github.com/curl/curl/pull/946.patch"},"body":"The Shibboleth project ships our own windows build of our complete dependency stack.  This include cURL and OpenSSL and zlib.\r\n\r\nThis is a reasonably complicated affair (particularly for OpenSSL) since our paradigm is \r\n* to have a completely built tree (out32, out64, out32.dbg and so on) and build from that\r\n* to take more control over the names of the libs and DLLs since many projects have historically played fast and loose with the ABI contract (and once bitten twice shy).\r\n\r\nSee for instance the [OpenSSL build](https://wiki.shibboleth.net/confluence/display/OpenSAML/OpenSSL) notes. This has down stream impact on our [cURL build](https://wiki.shibboleth.net/confluence/display/OpenSAML/libcurl)\r\n\r\nIn preparing to move to OpenSSL 1.1 it appears that the cURL nmake based windows build is slightly behind the curve with respect to the new locations and names.  The first commit in this stream fixes this in a backwards compatible manner, while also making it easy for use to significantly simplify our build of cURL.\r\n\r\nThe second patch is not motivated by any change in the dependencies, but allows us to simplify our curl build significantly to the level that we can do the build with no edits to the generated make files (yay!).\r\n\r\nThis has been tested against VC10."},"comment":{"url":"https://api.github.com/repos/curl/curl/issues/comments/238251421","html_url":"https://github.com/curl/curl/pull/946#issuecomment-238251421","issue_url":"https://api.github.com/repos/curl/curl/issues/946","id":238251421,"user":{"login":"rodwiddowson","id":249743,"avatar_url":"https://avatars.githubusercontent.com/u/249743?v=3","gravatar_id":"","url":"https://api.github.com/users/rodwiddowson","html_url":"https://github.com/rodwiddowson","followers_url":"https://api.github.com/users/rodwiddowson/followers","following_url":"https://api.github.com/users/rodwiddowson/following{/other_user}","gists_url":"https://api.github.com/users/rodwiddowson/gists{/gist_id}","starred_url":"https://api.github.com/users/rodwiddowson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodwiddowson/subscriptions","organizations_url":"https://api.github.com/users/rodwiddowson/orgs","repos_url":"https://api.github.com/users/rodwiddowson/repos","events_url":"https://api.github.com/users/rodwiddowson/events{/privacy}","received_events_url":"https://api.github.com/users/rodwiddowson/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T14:17:01Z","updated_at":"2016-08-08T14:17:01Z","body":"> Yes, it would be more helpful if you could look at switching your build to use the winbuild setup. \n\nOnto it.\n\n> And feel free to try out OpenSSL 1.1 too, I believe we build and work fine with it.\n\nIt was a huge comfort that you were ahead of me when I started down that road.  Should I close the pull request and do a new one?\n\nR\n\n"}}
{"actor":{"display_login":"rodwiddowson"}}