{"action":"created","issue":{"url":"https://api.github.com/repos/openmrs/openmrs-module-radiology/issues/333","repository_url":"https://api.github.com/repos/openmrs/openmrs-module-radiology","labels_url":"https://api.github.com/repos/openmrs/openmrs-module-radiology/issues/333/labels{/name}","comments_url":"https://api.github.com/repos/openmrs/openmrs-module-radiology/issues/333/comments","events_url":"https://api.github.com/repos/openmrs/openmrs-module-radiology/issues/333/events","html_url":"https://github.com/openmrs/openmrs-module-radiology/pull/333","id":163604231,"number":333,"title":"Can now import templates into the system. ","user":{"login":"ivange94","id":11330494,"avatar_url":"https://avatars.githubusercontent.com/u/11330494?v=3","gravatar_id":"","url":"https://api.github.com/users/ivange94","html_url":"https://github.com/ivange94","followers_url":"https://api.github.com/users/ivange94/followers","following_url":"https://api.github.com/users/ivange94/following{/other_user}","gists_url":"https://api.github.com/users/ivange94/gists{/gist_id}","starred_url":"https://api.github.com/users/ivange94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivange94/subscriptions","organizations_url":"https://api.github.com/users/ivange94/orgs","repos_url":"https://api.github.com/users/ivange94/repos","events_url":"https://api.github.com/users/ivange94/events{/privacy}","received_events_url":"https://api.github.com/users/ivange94/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-04T05:17:20Z","updated_at":"2016-07-05T09:10:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-module-radiology/pulls/333","html_url":"https://github.com/openmrs/openmrs-module-radiology/pull/333","diff_url":"https://github.com/openmrs/openmrs-module-radiology/pull/333.diff","patch_url":"https://github.com/openmrs/openmrs-module-radiology/pull/333.patch"},"body":"<!--- Provide PR Title above as: 'RAD-JiraIssueNumber JiraIssueTitle' -->\r\nCan now import templates into the system.\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThis pull request holds work done here, https://github.com/openmrs/openmrs-module-radiology/pull/304 . And all comments resolved.\r\n\r\nadded a parser to parse mrrt template file. Added a unit test and a real life mrrt template for testing\r\n\r\nimplemented templates tab with popup\r\n\r\nremoved some duplicate codes in messages.properties that entered due to cherry-picking a commit from another branch\r\n\r\nadded View Radiology Report Templates privilege which is used in radiologyReportTemplatesTab.jsp\r\n\r\ndeleted a duplicate file\r\n\r\nresolved @teleivo's comment which include, implementing getMrrtReportTemplateByUuid() and deleting MrrtReportTemplateException.java\r\n\r\nadded unit test covering getMrrtReportTemplateByUuid()\r\n\r\nAdded MrrtReportTemplateResource.java\r\n\r\ncan now import templates from ui\r\n\r\nattemted to resolve @telivos comment, but still facing a null pointer exception. the problem is with the way i configured my MrrtReportTemplateFileParser bean inside moduleApplicationContext.xml\r\n\r\nadded a service method to get all templates by title and also implemented a search handler for templates\r\n\r\ndeleted unnecessary parse(String) method\r\n\r\nused Criteria in HibernateDAO\r\n\r\nmade DefaultMrrtReportTemplateParser package private\r\n\r\nmade local variables final\r\n\r\nreengineered MrrtReportTemplate to extend BaseOpenmrsData and also renamed MrrtReportTemplateServiceTest to MrrtReportTemplateComponentTest to conform to other service tests\r\n\r\nchanged superclass of MrrtReportTemplateResource\r\n\r\nrenamed resource properties\r\n\r\nresource was returning no description in default representation mode. Fixed it\r\n\r\nuse REST in template tab\r\n\r\nfixed problem with find button not firing in radiologyReportTemplatesTab\r\n\r\nmoved BaseOpenmrsData properties to the end of the database\r\n\r\nadded a GP for templates folder\r\n\r\nrenamed button id on templates tab page\r\n\r\nstarted implementing validator but am still have a null pointer exception\r\n\r\ndid some code clean ups, adding unit tests, started with implementation of validator, removed code in controller that was importing templates and will put inside an import method in the MrrtReportTemplateService\r\n\r\nimplemented importReportTemplate method\r\n\r\nimplemented small part of validation. File validation\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue\r\nfirst -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to\r\nreproduce -->\r\n<!--- Please link to the issue here: -->\r\nsee https://issues.openmrs.org/browse/RAD-272\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that\r\napply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to\r\nhelp! -->\r\n- [x] My pull request only contains one single commit.\r\n- [x] My pull request is based on the latest master branch\r\n  `git pull --rebase upstream master`.\r\n- [x] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n- [x] My code follows the code style of this project.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-module-radiology/issues/comments/230426435","html_url":"https://github.com/openmrs/openmrs-module-radiology/pull/333#issuecomment-230426435","issue_url":"https://api.github.com/repos/openmrs/openmrs-module-radiology/issues/333","id":230426435,"user":{"login":"teleivo","id":4661144,"avatar_url":"https://avatars.githubusercontent.com/u/4661144?v=3","gravatar_id":"","url":"https://api.github.com/users/teleivo","html_url":"https://github.com/teleivo","followers_url":"https://api.github.com/users/teleivo/followers","following_url":"https://api.github.com/users/teleivo/following{/other_user}","gists_url":"https://api.github.com/users/teleivo/gists{/gist_id}","starred_url":"https://api.github.com/users/teleivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleivo/subscriptions","organizations_url":"https://api.github.com/users/teleivo/orgs","repos_url":"https://api.github.com/users/teleivo/repos","events_url":"https://api.github.com/users/teleivo/events{/privacy}","received_events_url":"https://api.github.com/users/teleivo/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T09:10:46Z","updated_at":"2016-07-05T09:10:46Z","body":"@ivange94 several issues:\r\n\r\n* why is coverage so low?\r\n* I can import an MrrtTemplate so I can see it in the template list (so an item in the db is created). however the file on the filesystem is empty."}}
{"actor":{"display_login":"teleivo"}}