{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/83415469","pull_request_review_id":4261764,"id":83415469,"diff_hunk":"@@ -11,14 +11,18 @@\n \n namespace Symfony\\Bundle\\FrameworkBundle\\DependencyInjection\\Compiler;\n \n+@trigger_error(sprintf('%s is deprecated as of 3.2 and will be removed in 4.0. Use Symfony\\Component\\Console\\DependencyInjection\\AddConsoleCommandPass instead.', AddConsoleCommandPass::class), E_USER_DEPRECATED);\n+\n use Symfony\\Component\\DependencyInjection\\Compiler\\CompilerPassInterface;\n use Symfony\\Component\\DependencyInjection\\ContainerBuilder;\n use Symfony\\Component\\DependencyInjection\\Exception\\InvalidArgumentException;\n \n /**\n- * AddConsoleCommandPass.\n+ * Registers console commands.\n  *\n  * @author Grégoire Pineau <lyrixx@lyrixx.info>\n+ *\n+ * @deprecated since version 3.2, to be removed in 4.0. Use Symfony\\Component\\Console\\DependencyInjection\\AddConsoleCommandPass instead.\n  */\n class AddConsoleCommandPass implements CompilerPassInterface","path":"src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php","position":18,"original_position":18,"commit_id":"014c9eb82b49931e3bf46131b819a923ad4b45b4","original_commit_id":"014c9eb82b49931e3bf46131b819a923ad4b45b4","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"Wouldn't it be better to let this class extend the new compiler pass instead of having to maintain the same code twice?","created_at":"2016-10-14T12:54:18Z","updated_at":"2016-10-14T12:54:18Z","html_url":"https://github.com/symfony/symfony/pull/19443#discussion_r83415469","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/19443","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/83415469"},"html":{"href":"https://github.com/symfony/symfony/pull/19443#discussion_r83415469"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19443"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/19443","id":78984437,"html_url":"https://github.com/symfony/symfony/pull/19443","diff_url":"https://github.com/symfony/symfony/pull/19443.diff","patch_url":"https://github.com/symfony/symfony/pull/19443.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/19443","number":19443,"state":"open","locked":false,"title":"[Console] Move AddConsoleCommandPass from FrameworkBundle to Console.","user":{"login":"bcremer","id":55820,"avatar_url":"https://avatars.githubusercontent.com/u/55820?v=3","gravatar_id":"","url":"https://api.github.com/users/bcremer","html_url":"https://github.com/bcremer","followers_url":"https://api.github.com/users/bcremer/followers","following_url":"https://api.github.com/users/bcremer/following{/other_user}","gists_url":"https://api.github.com/users/bcremer/gists{/gist_id}","starred_url":"https://api.github.com/users/bcremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcremer/subscriptions","organizations_url":"https://api.github.com/users/bcremer/orgs","repos_url":"https://api.github.com/users/bcremer/repos","events_url":"https://api.github.com/users/bcremer/events{/privacy}","received_events_url":"https://api.github.com/users/bcremer/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | yes\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | #19440\r\n| License       | MIT\r\n| Doc PR        | -","created_at":"2016-07-27T08:30:39Z","updated_at":"2016-10-14T12:54:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0a72eb9e597a360bb5bc87d30232ac727677ace","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/19443/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/19443/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/19443/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/014c9eb82b49931e3bf46131b819a923ad4b45b4","head":{"label":"bcremer:move-AddConsoleCommandPass","ref":"move-AddConsoleCommandPass","sha":"014c9eb82b49931e3bf46131b819a923ad4b45b4","user":{"login":"bcremer","id":55820,"avatar_url":"https://avatars.githubusercontent.com/u/55820?v=3","gravatar_id":"","url":"https://api.github.com/users/bcremer","html_url":"https://github.com/bcremer","followers_url":"https://api.github.com/users/bcremer/followers","following_url":"https://api.github.com/users/bcremer/following{/other_user}","gists_url":"https://api.github.com/users/bcremer/gists{/gist_id}","starred_url":"https://api.github.com/users/bcremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcremer/subscriptions","organizations_url":"https://api.github.com/users/bcremer/orgs","repos_url":"https://api.github.com/users/bcremer/repos","events_url":"https://api.github.com/users/bcremer/events{/privacy}","received_events_url":"https://api.github.com/users/bcremer/received_events","type":"User","site_admin":false},"repo":{"id":3095727,"name":"symfony","full_name":"bcremer/symfony","owner":{"login":"bcremer","id":55820,"avatar_url":"https://avatars.githubusercontent.com/u/55820?v=3","gravatar_id":"","url":"https://api.github.com/users/bcremer","html_url":"https://github.com/bcremer","followers_url":"https://api.github.com/users/bcremer/followers","following_url":"https://api.github.com/users/bcremer/following{/other_user}","gists_url":"https://api.github.com/users/bcremer/gists{/gist_id}","starred_url":"https://api.github.com/users/bcremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcremer/subscriptions","organizations_url":"https://api.github.com/users/bcremer/orgs","repos_url":"https://api.github.com/users/bcremer/repos","events_url":"https://api.github.com/users/bcremer/events{/privacy}","received_events_url":"https://api.github.com/users/bcremer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcremer/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/bcremer/symfony","forks_url":"https://api.github.com/repos/bcremer/symfony/forks","keys_url":"https://api.github.com/repos/bcremer/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcremer/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcremer/symfony/teams","hooks_url":"https://api.github.com/repos/bcremer/symfony/hooks","issue_events_url":"https://api.github.com/repos/bcremer/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/bcremer/symfony/events","assignees_url":"https://api.github.com/repos/bcremer/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/bcremer/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/bcremer/symfony/tags","blobs_url":"https://api.github.com/repos/bcremer/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcremer/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcremer/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcremer/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcremer/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/bcremer/symfony/languages","stargazers_url":"https://api.github.com/repos/bcremer/symfony/stargazers","contributors_url":"https://api.github.com/repos/bcremer/symfony/contributors","subscribers_url":"https://api.github.com/repos/bcremer/symfony/subscribers","subscription_url":"https://api.github.com/repos/bcremer/symfony/subscription","commits_url":"https://api.github.com/repos/bcremer/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcremer/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcremer/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcremer/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcremer/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/bcremer/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcremer/symfony/merges","archive_url":"https://api.github.com/repos/bcremer/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcremer/symfony/downloads","issues_url":"https://api.github.com/repos/bcremer/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/bcremer/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/bcremer/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/bcremer/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcremer/symfony/labels{/name}","releases_url":"https://api.github.com/repos/bcremer/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/bcremer/symfony/deployments","created_at":"2012-01-03T17:09:19Z","updated_at":"2013-01-05T18:20:26Z","pushed_at":"2016-09-15T06:04:32Z","git_url":"git://github.com/bcremer/symfony.git","ssh_url":"git@github.com:bcremer/symfony.git","clone_url":"https://github.com/bcremer/symfony.git","svn_url":"https://github.com/bcremer/symfony","homepage":"symfony.com","size":72517,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"835176c932839fa7185dda4449d08babb6a038b9","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-10-14T12:25:21Z","pushed_at":"2016-10-14T11:13:59Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":138021,"stargazers_count":13104,"watchers_count":13104,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5078,"mirror_url":null,"open_issues_count":747,"forks":5078,"open_issues":747,"watchers":13104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19443"},"html":{"href":"https://github.com/symfony/symfony/pull/19443"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/19443"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/19443/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19443/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/19443/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/014c9eb82b49931e3bf46131b819a923ad4b45b4"}}}}
{"actor":{"display_login":"xabbuh"}}