{"action":"closed","issue":{"url":"https://api.github.com/repos/zmap/zdns/issues/53","repository_url":"https://api.github.com/repos/zmap/zdns","labels_url":"https://api.github.com/repos/zmap/zdns/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/zmap/zdns/issues/53/comments","events_url":"https://api.github.com/repos/zmap/zdns/issues/53/events","html_url":"https://github.com/zmap/zdns/issues/53","id":172315505,"number":53,"title":"PTR module causes zDNS to exit if given bad IP address","user":{"login":"brandonpoc","id":584097,"avatar_url":"https://avatars.githubusercontent.com/u/584097?v=3","gravatar_id":"","url":"https://api.github.com/users/brandonpoc","html_url":"https://github.com/brandonpoc","followers_url":"https://api.github.com/users/brandonpoc/followers","following_url":"https://api.github.com/users/brandonpoc/following{/other_user}","gists_url":"https://api.github.com/users/brandonpoc/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonpoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonpoc/subscriptions","organizations_url":"https://api.github.com/users/brandonpoc/orgs","repos_url":"https://api.github.com/users/brandonpoc/repos","events_url":"https://api.github.com/users/brandonpoc/events{/privacy}","received_events_url":"https://api.github.com/users/brandonpoc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-21T10:52:31Z","updated_at":"2016-08-21T17:47:10Z","closed_at":"2016-08-21T17:47:10Z","body":"This logic, shown below, in the PTR module (modules/ptr/ptr.go) causes zdns to actually exit. I have zdns operating as part of an automated daily run that looks up millions of domains A records, and the PTR of those results, and I found that this was quite literally killing my processing efforts. I'd imagine most other users don't want this to exit if given a bad IP either. Wouldn't the proper, expected result be an error message such as {name: \"bad IP address\", status: \"invalid ip error\"} or something in JSON instead of it exiting? Considering that zdns can process gigantic files with great speed, having the program exit entirely because of a bad IP address is unwarranted.\r\n\r\nCode is below:\r\n\r\n        nameServer := s.Factory.Factory.RandomNameServer()\r\n        name, err := dns.ReverseAddr(name)\r\n        if err != nil {\r\n                log.Fatal(\"Invalid IP address received:\", name)\r\n        }\r\n"}}
{"actor":{"display_login":"zakird"}}