{"action":"created","comment":{"url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/comments/94192710","pull_request_review_id":14723702,"id":94192710,"diff_hunk":"@@ -0,0 +1,35 @@\n+syntax = \"proto3\";\n+\n+package holms.types.reporting.input_params;\n+option csharp_namespace = \"HOLMS.Types.Reporting.ReportParams\";\n+option go_package = \"reporting/input_params\";\n+\n+import \"google/protobuf/timestamp.proto\";\n+import \"primitive/pb_inclusive_opsdate_range.proto\";\n+import \"primitive/pb_local_date.proto\";\n+\n+enum InHouseGuestReportSorting {\n+\tBY_GUEST_NAME = 0;\n+\tBY_ROOM_NUMBER = 1;\n+}\n+\n+message FrontDeskCalendarDateReportManifest {\n+\tgoogle.protobuf.Timestamp date = 1;","path":"proto/reporting/input_params/front_desk_report_manifests.proto","position":17,"original_position":17,"commit_id":"e51e811ff6d842c691c92001856adc0cc383b2bc","original_commit_id":"e51e811ff6d842c691c92001856adc0cc383b2bc","user":{"login":"eldavido","id":253822,"avatar_url":"https://avatars.githubusercontent.com/u/253822?v=3","gravatar_id":"","url":"https://api.github.com/users/eldavido","html_url":"https://github.com/eldavido","followers_url":"https://api.github.com/users/eldavido/followers","following_url":"https://api.github.com/users/eldavido/following{/other_user}","gists_url":"https://api.github.com/users/eldavido/gists{/gist_id}","starred_url":"https://api.github.com/users/eldavido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldavido/subscriptions","organizations_url":"https://api.github.com/users/eldavido/orgs","repos_url":"https://api.github.com/users/eldavido/repos","events_url":"https://api.github.com/users/eldavido/events{/privacy}","received_events_url":"https://api.github.com/users/eldavido/received_events","type":"User","site_admin":false},"body":"Two small changes here:\r\n- These should have a nullable property filter (null means no filter, show all properties)\r\n- You can get rid of all dates on these. I discussed this extensively with Chuck and Carmen, and they said they never generate front-desk reports for dates other than today. ","created_at":"2016-12-29T23:55:18Z","updated_at":"2016-12-30T00:00:09Z","html_url":"https://github.com/shortbar/holms.platformclient.net/pull/53#discussion_r94192710","pull_request_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/comments/94192710"},"html":{"href":"https://github.com/shortbar/holms.platformclient.net/pull/53#discussion_r94192710"},"pull_request":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53","id":99708617,"html_url":"https://github.com/shortbar/holms.platformclient.net/pull/53","diff_url":"https://github.com/shortbar/holms.platformclient.net/pull/53.diff","patch_url":"https://github.com/shortbar/holms.platformclient.net/pull/53.patch","issue_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/53","number":53,"state":"open","locked":false,"title":"[#13612473] Creates batch reporting manifest pattern","user":{"login":"pcsouza","id":2154087,"avatar_url":"https://avatars.githubusercontent.com/u/2154087?v=3","gravatar_id":"","url":"https://api.github.com/users/pcsouza","html_url":"https://github.com/pcsouza","followers_url":"https://api.github.com/users/pcsouza/followers","following_url":"https://api.github.com/users/pcsouza/following{/other_user}","gists_url":"https://api.github.com/users/pcsouza/gists{/gist_id}","starred_url":"https://api.github.com/users/pcsouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcsouza/subscriptions","organizations_url":"https://api.github.com/users/pcsouza/orgs","repos_url":"https://api.github.com/users/pcsouza/repos","events_url":"https://api.github.com/users/pcsouza/events{/privacy}","received_events_url":"https://api.github.com/users/pcsouza/received_events","type":"User","site_admin":false},"body":"Reports are compiled into a single batch document by the server, which\r\nrecieves a manifest of the batch and its parameters from the client. This\r\nis designed to be easily modified in most cases without causing breaking\r\nchanges.\r\n\r\nThis is a first draft of the interface. There's a lot of surface area to\r\nthese reports and some reports may jump to different manifests as I work\r\non incorporating them into the batch printing mechanism.","created_at":"2016-12-29T23:17:50Z","updated_at":"2016-12-30T00:00:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b34f9bc28ff944185143e599272bc00100cb119","assignee":{"login":"eldavido","id":253822,"avatar_url":"https://avatars.githubusercontent.com/u/253822?v=3","gravatar_id":"","url":"https://api.github.com/users/eldavido","html_url":"https://github.com/eldavido","followers_url":"https://api.github.com/users/eldavido/followers","following_url":"https://api.github.com/users/eldavido/following{/other_user}","gists_url":"https://api.github.com/users/eldavido/gists{/gist_id}","starred_url":"https://api.github.com/users/eldavido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldavido/subscriptions","organizations_url":"https://api.github.com/users/eldavido/orgs","repos_url":"https://api.github.com/users/eldavido/repos","events_url":"https://api.github.com/users/eldavido/events{/privacy}","received_events_url":"https://api.github.com/users/eldavido/received_events","type":"User","site_admin":false},"assignees":[{"login":"eldavido","id":253822,"avatar_url":"https://avatars.githubusercontent.com/u/253822?v=3","gravatar_id":"","url":"https://api.github.com/users/eldavido","html_url":"https://github.com/eldavido","followers_url":"https://api.github.com/users/eldavido/followers","following_url":"https://api.github.com/users/eldavido/following{/other_user}","gists_url":"https://api.github.com/users/eldavido/gists{/gist_id}","starred_url":"https://api.github.com/users/eldavido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldavido/subscriptions","organizations_url":"https://api.github.com/users/eldavido/orgs","repos_url":"https://api.github.com/users/eldavido/repos","events_url":"https://api.github.com/users/eldavido/events{/privacy}","received_events_url":"https://api.github.com/users/eldavido/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53/commits","review_comments_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53/comments","review_comment_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/53/comments","statuses_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/statuses/e51e811ff6d842c691c92001856adc0cc383b2bc","head":{"label":"shortbar:feature/#136124473-reports-manifests","ref":"feature/#136124473-reports-manifests","sha":"e51e811ff6d842c691c92001856adc0cc383b2bc","user":{"login":"shortbar","id":3478452,"avatar_url":"https://avatars.githubusercontent.com/u/3478452?v=3","gravatar_id":"","url":"https://api.github.com/users/shortbar","html_url":"https://github.com/shortbar","followers_url":"https://api.github.com/users/shortbar/followers","following_url":"https://api.github.com/users/shortbar/following{/other_user}","gists_url":"https://api.github.com/users/shortbar/gists{/gist_id}","starred_url":"https://api.github.com/users/shortbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shortbar/subscriptions","organizations_url":"https://api.github.com/users/shortbar/orgs","repos_url":"https://api.github.com/users/shortbar/repos","events_url":"https://api.github.com/users/shortbar/events{/privacy}","received_events_url":"https://api.github.com/users/shortbar/received_events","type":"Organization","site_admin":false},"repo":{"id":72143319,"name":"holms.platformclient.net","full_name":"shortbar/holms.platformclient.net","owner":{"login":"shortbar","id":3478452,"avatar_url":"https://avatars.githubusercontent.com/u/3478452?v=3","gravatar_id":"","url":"https://api.github.com/users/shortbar","html_url":"https://github.com/shortbar","followers_url":"https://api.github.com/users/shortbar/followers","following_url":"https://api.github.com/users/shortbar/following{/other_user}","gists_url":"https://api.github.com/users/shortbar/gists{/gist_id}","starred_url":"https://api.github.com/users/shortbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shortbar/subscriptions","organizations_url":"https://api.github.com/users/shortbar/orgs","repos_url":"https://api.github.com/users/shortbar/repos","events_url":"https://api.github.com/users/shortbar/events{/privacy}","received_events_url":"https://api.github.com/users/shortbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shortbar/holms.platformclient.net","description":".NET Client for HOLMS Hotel Management System","fork":false,"url":"https://api.github.com/repos/shortbar/holms.platformclient.net","forks_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/forks","keys_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/teams","hooks_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/hooks","issue_events_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/events{/number}","events_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/events","assignees_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/assignees{/user}","branches_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/branches{/branch}","tags_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/tags","blobs_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/statuses/{sha}","languages_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/languages","stargazers_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/stargazers","contributors_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/contributors","subscribers_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/subscribers","subscription_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/subscription","commits_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/contents/{+path}","compare_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/merges","archive_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/downloads","issues_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues{/number}","pulls_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls{/number}","milestones_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/milestones{/number}","notifications_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/labels{/name}","releases_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/releases{/id}","deployments_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/deployments","created_at":"2016-10-27T19:57:08Z","updated_at":"2016-10-27T20:00:05Z","pushed_at":"2016-12-29T23:17:50Z","git_url":"git://github.com/shortbar/holms.platformclient.net.git","ssh_url":"git@github.com:shortbar/holms.platformclient.net.git","clone_url":"https://github.com/shortbar/holms.platformclient.net.git","svn_url":"https://github.com/shortbar/holms.platformclient.net","homepage":null,"size":896,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"shortbar:master","ref":"master","sha":"cf2affcc484e4a3911ea48b32eac4f3df66c18e3","user":{"login":"shortbar","id":3478452,"avatar_url":"https://avatars.githubusercontent.com/u/3478452?v=3","gravatar_id":"","url":"https://api.github.com/users/shortbar","html_url":"https://github.com/shortbar","followers_url":"https://api.github.com/users/shortbar/followers","following_url":"https://api.github.com/users/shortbar/following{/other_user}","gists_url":"https://api.github.com/users/shortbar/gists{/gist_id}","starred_url":"https://api.github.com/users/shortbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shortbar/subscriptions","organizations_url":"https://api.github.com/users/shortbar/orgs","repos_url":"https://api.github.com/users/shortbar/repos","events_url":"https://api.github.com/users/shortbar/events{/privacy}","received_events_url":"https://api.github.com/users/shortbar/received_events","type":"Organization","site_admin":false},"repo":{"id":72143319,"name":"holms.platformclient.net","full_name":"shortbar/holms.platformclient.net","owner":{"login":"shortbar","id":3478452,"avatar_url":"https://avatars.githubusercontent.com/u/3478452?v=3","gravatar_id":"","url":"https://api.github.com/users/shortbar","html_url":"https://github.com/shortbar","followers_url":"https://api.github.com/users/shortbar/followers","following_url":"https://api.github.com/users/shortbar/following{/other_user}","gists_url":"https://api.github.com/users/shortbar/gists{/gist_id}","starred_url":"https://api.github.com/users/shortbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shortbar/subscriptions","organizations_url":"https://api.github.com/users/shortbar/orgs","repos_url":"https://api.github.com/users/shortbar/repos","events_url":"https://api.github.com/users/shortbar/events{/privacy}","received_events_url":"https://api.github.com/users/shortbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shortbar/holms.platformclient.net","description":".NET Client for HOLMS Hotel Management System","fork":false,"url":"https://api.github.com/repos/shortbar/holms.platformclient.net","forks_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/forks","keys_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/teams","hooks_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/hooks","issue_events_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/events{/number}","events_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/events","assignees_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/assignees{/user}","branches_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/branches{/branch}","tags_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/tags","blobs_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/statuses/{sha}","languages_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/languages","stargazers_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/stargazers","contributors_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/contributors","subscribers_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/subscribers","subscription_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/subscription","commits_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/contents/{+path}","compare_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/merges","archive_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/downloads","issues_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues{/number}","pulls_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls{/number}","milestones_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/milestones{/number}","notifications_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/labels{/name}","releases_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/releases{/id}","deployments_url":"https://api.github.com/repos/shortbar/holms.platformclient.net/deployments","created_at":"2016-10-27T19:57:08Z","updated_at":"2016-10-27T20:00:05Z","pushed_at":"2016-12-29T23:17:50Z","git_url":"git://github.com/shortbar/holms.platformclient.net.git","ssh_url":"git@github.com:shortbar/holms.platformclient.net.git","clone_url":"https://github.com/shortbar/holms.platformclient.net.git","svn_url":"https://github.com/shortbar/holms.platformclient.net","homepage":null,"size":896,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53"},"html":{"href":"https://github.com/shortbar/holms.platformclient.net/pull/53"},"issue":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/53"},"comments":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/shortbar/holms.platformclient.net/statuses/e51e811ff6d842c691c92001856adc0cc383b2bc"}}}}
{"actor":{"display_login":"eldavido"}}