{"action":"created","issue":{"url":"https://api.github.com/repos/mytharcher/hookagent/issues/6","repository_url":"https://api.github.com/repos/mytharcher/hookagent","labels_url":"https://api.github.com/repos/mytharcher/hookagent/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/mytharcher/hookagent/issues/6/comments","events_url":"https://api.github.com/repos/mytharcher/hookagent/issues/6/events","html_url":"https://github.com/mytharcher/hookagent/pull/6","id":187764964,"number":6,"title":"A couple fixes and addons ","user":{"login":"nodekra","id":22597133,"avatar_url":"https://avatars.githubusercontent.com/u/22597133?v=3","gravatar_id":"","url":"https://api.github.com/users/nodekra","html_url":"https://github.com/nodekra","followers_url":"https://api.github.com/users/nodekra/followers","following_url":"https://api.github.com/users/nodekra/following{/other_user}","gists_url":"https://api.github.com/users/nodekra/gists{/gist_id}","starred_url":"https://api.github.com/users/nodekra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodekra/subscriptions","organizations_url":"https://api.github.com/users/nodekra/orgs","repos_url":"https://api.github.com/users/nodekra/repos","events_url":"https://api.github.com/users/nodekra/events{/privacy}","received_events_url":"https://api.github.com/users/nodekra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-07T16:51:50Z","updated_at":"2016-11-08T09:34:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mytharcher/hookagent/pulls/6","html_url":"https://github.com/mytharcher/hookagent/pull/6","diff_url":"https://github.com/mytharcher/hookagent/pull/6.diff","patch_url":"https://github.com/mytharcher/hookagent/pull/6.patch"},"body":"1.  child_process.execFile  bin/deploy.sh as root if \"sudo:true\" and invoke it by itself with \"sudo -H\"\r\n2.  added \"group\" option, so execFile or sudo will run with $user:$group, instead of  $user:root\r\n3.  pass $path and $branch to user task script for better deploy automation: \"start to run shell script: sh $task $path $branch\"\r\n4.  moved log to /var/log dir"},"comment":{"url":"https://api.github.com/repos/mytharcher/hookagent/issues/comments/259088775","html_url":"https://github.com/mytharcher/hookagent/pull/6#issuecomment-259088775","issue_url":"https://api.github.com/repos/mytharcher/hookagent/issues/6","id":259088775,"user":{"login":"mytharcher","id":525658,"avatar_url":"https://avatars.githubusercontent.com/u/525658?v=3","gravatar_id":"","url":"https://api.github.com/users/mytharcher","html_url":"https://github.com/mytharcher","followers_url":"https://api.github.com/users/mytharcher/followers","following_url":"https://api.github.com/users/mytharcher/following{/other_user}","gists_url":"https://api.github.com/users/mytharcher/gists{/gist_id}","starred_url":"https://api.github.com/users/mytharcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mytharcher/subscriptions","organizations_url":"https://api.github.com/users/mytharcher/orgs","repos_url":"https://api.github.com/users/mytharcher/repos","events_url":"https://api.github.com/users/mytharcher/events{/privacy}","received_events_url":"https://api.github.com/users/mytharcher/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T09:34:25Z","updated_at":"2016-11-08T09:34:25Z","body":"Thanks so much for improving this tool. There are some suggestion and question on this PR:\r\n\r\n1. Not to change the indent when you just want to modify the logic. Or it will be hard to review the diff.\r\n2. The feature of user task script I planned to deprecate it. Because by using the `.git/hooks/post-merge` script in any repository will be a better practice (noticed in #5 ).\r\n3. I am not sure what scenario will you use the `extraArg`?\r\n\r\nThe feature about root user and group options looks great, I will merge this PR after your fixes.\r\n\r\nCheers"}}
{"actor":{"display_login":"mytharcher"}}