{"action":"created","issue":{"url":"https://api.github.com/repos/freenet/fred/issues/495","repository_url":"https://api.github.com/repos/freenet/fred","labels_url":"https://api.github.com/repos/freenet/fred/issues/495/labels{/name}","comments_url":"https://api.github.com/repos/freenet/fred/issues/495/comments","events_url":"https://api.github.com/repos/freenet/fred/issues/495/events","html_url":"https://github.com/freenet/fred/pull/495","id":129949961,"number":495,"title":"Fix binary blob downloading through FCP (was broken in 1468)","user":{"login":"Sadao-","id":1183540,"avatar_url":"https://avatars.githubusercontent.com/u/1183540?v=3","gravatar_id":"","url":"https://api.github.com/users/Sadao-","html_url":"https://github.com/Sadao-","followers_url":"https://api.github.com/users/Sadao-/followers","following_url":"https://api.github.com/users/Sadao-/following{/other_user}","gists_url":"https://api.github.com/users/Sadao-/gists{/gist_id}","starred_url":"https://api.github.com/users/Sadao-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sadao-/subscriptions","organizations_url":"https://api.github.com/users/Sadao-/orgs","repos_url":"https://api.github.com/users/Sadao-/repos","events_url":"https://api.github.com/users/Sadao-/events{/privacy}","received_events_url":"https://api.github.com/users/Sadao-/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/freenet/fred/labels/bugfix","name":"bugfix","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-01-30T06:40:30Z","updated_at":"2016-04-10T16:57:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/freenet/fred/pulls/495","html_url":"https://github.com/freenet/fred/pull/495","diff_url":"https://github.com/freenet/fred/pull/495.diff","patch_url":"https://github.com/freenet/fred/pull/495.patch"},"body":"1) In the ReturnType=disk mode the DataLength field of the DataFound FCP message was always set to 0.\r\n2) In the ReturnType=direct mode the request was stalled at the very beginning due to NPE:\r\n\r\njava.lang.NullPointerException\r\n    at freenet.client.async.BinaryBlobWriter.getOutputStream(BinaryBlobWriter.java:74)\r\n    at freenet.client.async.BinaryBlobWriter.addKey(BinaryBlobWriter.java:96)\r\n    at freenet.client.async.ClientGetter.addKeyToBinaryBlob(ClientGetter.java:764)\r\n    at freenet.client.async.SingleFileFetcher.onSuccess(SingleFileFetcher.java:193)\r\n    ...\r\n\r\nThe patch was tested."},"comment":{"url":"https://api.github.com/repos/freenet/fred/issues/comments/208015332","html_url":"https://github.com/freenet/fred/pull/495#issuecomment-208015332","issue_url":"https://api.github.com/repos/freenet/fred/issues/495","id":208015332,"user":{"login":"toad","id":77427,"avatar_url":"https://avatars.githubusercontent.com/u/77427?v=3","gravatar_id":"","url":"https://api.github.com/users/toad","html_url":"https://github.com/toad","followers_url":"https://api.github.com/users/toad/followers","following_url":"https://api.github.com/users/toad/following{/other_user}","gists_url":"https://api.github.com/users/toad/gists{/gist_id}","starred_url":"https://api.github.com/users/toad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toad/subscriptions","organizations_url":"https://api.github.com/users/toad/orgs","repos_url":"https://api.github.com/users/toad/repos","events_url":"https://api.github.com/users/toad/events{/privacy}","received_events_url":"https://api.github.com/users/toad/received_events","type":"User","site_admin":false},"created_at":"2016-04-10T16:57:49Z","updated_at":"2016-04-10T16:57:49Z","body":"Sorry for muddying the waters. Sadao's original patch is the correct way to solve this IMHO. We have to store the binary blob bucket, so we can't create it in makeGetter()."}}