{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/72869839","id":72869839,"diff_hunk":"@@ -29,6 +29,9 @@ export class Timer {\n    * @param {!Window} win\n    */\n   constructor(win) {\n+    if (!win || !win.setTimeout) {\n+      throw new Error('Fuck you');","path":"src/timer.js","position":5,"original_position":5,"commit_id":"179784e421e1a7bbcca049329129fb37dda6858b","original_commit_id":"179784e421e1a7bbcca049329129fb37dda6858b","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"The tests are really starting to get on my nerves.","created_at":"2016-07-29T22:28:04Z","updated_at":"2016-07-29T22:28:04Z","html_url":"https://github.com/ampproject/amphtml/pull/4261#discussion_r72869839","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4261","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/72869839"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4261#discussion_r72869839"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4261"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4261","id":79280429,"html_url":"https://github.com/ampproject/amphtml/pull/4261","diff_url":"https://github.com/ampproject/amphtml/pull/4261.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4261.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4261","number":4261,"state":"open","locked":false,"title":"Remove side effect exports","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"It seems Closure compiler [can't DCE](https://gist.github.com/jridgewell/27d81109b9d9c066751bc630b619c8b4#file-sw-js) (notice `timer`, `platform`, and `log` are still in the compiled code -- We [expect](https://gist.github.com/jridgewell/27d81109b9d9c066751bc630b619c8b4#file-expected-unminified-js) them to be gone since they're never called) exports that are a side-effect. Side effects exports are the result of some function call, either a `CallExpression` (normal function call) or a `NewExpression` (creating a new instance of a \"class\" function).\r\n\r\nThis is breaking the SW especially, since there are references to the `window` variable, which is undeclared inside the SW environment. \r\n\r\nSo, let's change these side-effects into runtime side-effects (vs static compile-time side-effects). That way, closure can [properly DCE](https://gist.github.com/jridgewell/27d81109b9d9c066751bc630b619c8b4#file-result-dev-for-js).\r\n\r\nTODO:\r\n-------\r\n\r\n@erwinmombay is nice enough to look into updating our `dev.assert()` optimization to work with the new `dev().assert()` syntax. After that, I'll be able to post size diffs.","created_at":"2016-07-28T22:37:13Z","updated_at":"2016-07-29T22:28:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65d4bead7383f9b7c44e274f570c37b901bfd39b","assignee":{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"dvoytenko","id":726049,"avatar_url":"https://avatars.githubusercontent.com/u/726049?v=3","gravatar_id":"","url":"https://api.github.com/users/dvoytenko","html_url":"https://github.com/dvoytenko","followers_url":"https://api.github.com/users/dvoytenko/followers","following_url":"https://api.github.com/users/dvoytenko/following{/other_user}","gists_url":"https://api.github.com/users/dvoytenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dvoytenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvoytenko/subscriptions","organizations_url":"https://api.github.com/users/dvoytenko/orgs","repos_url":"https://api.github.com/users/dvoytenko/repos","events_url":"https://api.github.com/users/dvoytenko/events{/privacy}","received_events_url":"https://api.github.com/users/dvoytenko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4261/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4261/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4261/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/179784e421e1a7bbcca049329129fb37dda6858b","head":{"label":"jridgewell:side-effect-dce","ref":"side-effect-dce","sha":"179784e421e1a7bbcca049329129fb37dda6858b","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":48198933,"name":"amphtml","full_name":"jridgewell/amphtml","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/jridgewell/amphtml","forks_url":"https://api.github.com/repos/jridgewell/amphtml/forks","keys_url":"https://api.github.com/repos/jridgewell/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/amphtml/teams","hooks_url":"https://api.github.com/repos/jridgewell/amphtml/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/amphtml/events","assignees_url":"https://api.github.com/repos/jridgewell/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/amphtml/tags","blobs_url":"https://api.github.com/repos/jridgewell/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/amphtml/languages","stargazers_url":"https://api.github.com/repos/jridgewell/amphtml/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/amphtml/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/amphtml/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/amphtml/subscription","commits_url":"https://api.github.com/repos/jridgewell/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/amphtml/merges","archive_url":"https://api.github.com/repos/jridgewell/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/amphtml/downloads","issues_url":"https://api.github.com/repos/jridgewell/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/jridgewell/amphtml/deployments","created_at":"2015-12-17T21:21:35Z","updated_at":"2016-05-04T19:44:23Z","pushed_at":"2016-07-29T22:02:42Z","git_url":"git://github.com/jridgewell/amphtml.git","ssh_url":"git@github.com:jridgewell/amphtml.git","clone_url":"https://github.com/jridgewell/amphtml.git","svn_url":"https://github.com/jridgewell/amphtml","homepage":"http://justin.ridgewell.name/amphtml/","size":129741,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"b082f3afa0a54971fb82c1dd0f9055cd8187e94a","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-07-29T20:41:00Z","pushed_at":"2016-07-29T22:26:44Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":138340,"stargazers_count":7994,"watchers_count":7994,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1147,"mirror_url":null,"open_issues_count":630,"forks":1147,"open_issues":630,"watchers":7994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4261"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4261"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4261"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4261/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4261/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4261/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/179784e421e1a7bbcca049329129fb37dda6858b"}}}}
{"actor":{"display_login":"jridgewell"}}