{"action":"created","comment":{"url":"https://api.github.com/repos/sasa1977/con_cache/pulls/comments/77208427","id":77208427,"diff_hunk":"@@ -184,6 +184,24 @@ defmodule ConCacheTest do\n     end)\n   end\n \n+  test \"get_or_store on bag\" do\n+    with_cache([ets_options: [:bag]],fn(cache) ->\n+      assert ConCache.get_or_store(cache, :a, fn() -> 1 end) == 1","path":"test/con_cache_test.exs","position":137,"original_position":6,"commit_id":"cef352a25168e39ad59a7311dc0f61985e4946ed","original_commit_id":"39ad5636d43a9afbb58d945e7d51f4bd83b6b13c","user":{"login":"sasa1977","id":202498,"avatar_url":"https://avatars.githubusercontent.com/u/202498?v=3","gravatar_id":"","url":"https://api.github.com/users/sasa1977","html_url":"https://github.com/sasa1977","followers_url":"https://api.github.com/users/sasa1977/followers","following_url":"https://api.github.com/users/sasa1977/following{/other_user}","gists_url":"https://api.github.com/users/sasa1977/gists{/gist_id}","starred_url":"https://api.github.com/users/sasa1977/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasa1977/subscriptions","organizations_url":"https://api.github.com/users/sasa1977/orgs","repos_url":"https://api.github.com/users/sasa1977/repos","events_url":"https://api.github.com/users/sasa1977/events{/privacy}","received_events_url":"https://api.github.com/users/sasa1977/received_events","type":"User","site_admin":false},"body":"Sounds good to me 👍  Once you disable `get_or_store`, we can merge this PR.\r\n\r\nSince you opened a request for bags, I'm assuming you have some use case in mind, so perhaps that can serve as an example of how should these disabled functions behave. In any case, feel free to open issues, and we'll discuss further.\r\n\r\nThanks!","created_at":"2016-09-01T16:32:38Z","updated_at":"2016-09-01T16:32:38Z","html_url":"https://github.com/sasa1977/con_cache/pull/26#discussion_r77208427","pull_request_url":"https://api.github.com/repos/sasa1977/con_cache/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/sasa1977/con_cache/pulls/comments/77208427"},"html":{"href":"https://github.com/sasa1977/con_cache/pull/26#discussion_r77208427"},"pull_request":{"href":"https://api.github.com/repos/sasa1977/con_cache/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/sasa1977/con_cache/pulls/26","id":83015817,"html_url":"https://github.com/sasa1977/con_cache/pull/26","diff_url":"https://github.com/sasa1977/con_cache/pull/26.diff","patch_url":"https://github.com/sasa1977/con_cache/pull/26.patch","issue_url":"https://api.github.com/repos/sasa1977/con_cache/issues/26","number":26,"state":"open","locked":false,"title":"Support bag and duplicate bag","user":{"login":"fcevado","id":9992984,"avatar_url":"https://avatars.githubusercontent.com/u/9992984?v=3","gravatar_id":"","url":"https://api.github.com/users/fcevado","html_url":"https://github.com/fcevado","followers_url":"https://api.github.com/users/fcevado/followers","following_url":"https://api.github.com/users/fcevado/following{/other_user}","gists_url":"https://api.github.com/users/fcevado/gists{/gist_id}","starred_url":"https://api.github.com/users/fcevado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcevado/subscriptions","organizations_url":"https://api.github.com/users/fcevado/orgs","repos_url":"https://api.github.com/users/fcevado/repos","events_url":"https://api.github.com/users/fcevado/events{/privacy}","received_events_url":"https://api.github.com/users/fcevado/received_events","type":"User","site_admin":false},"body":"issue #25 ","created_at":"2016-08-28T13:25:19Z","updated_at":"2016-09-01T16:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e51f22f76698bc18d1017acb32ca067d6f25f8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sasa1977/con_cache/pulls/26/commits","review_comments_url":"https://api.github.com/repos/sasa1977/con_cache/pulls/26/comments","review_comment_url":"https://api.github.com/repos/sasa1977/con_cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sasa1977/con_cache/issues/26/comments","statuses_url":"https://api.github.com/repos/sasa1977/con_cache/statuses/cef352a25168e39ad59a7311dc0f61985e4946ed","head":{"label":"fcevado:support_bag_and_duplicate_bag","ref":"support_bag_and_duplicate_bag","sha":"cef352a25168e39ad59a7311dc0f61985e4946ed","user":{"login":"fcevado","id":9992984,"avatar_url":"https://avatars.githubusercontent.com/u/9992984?v=3","gravatar_id":"","url":"https://api.github.com/users/fcevado","html_url":"https://github.com/fcevado","followers_url":"https://api.github.com/users/fcevado/followers","following_url":"https://api.github.com/users/fcevado/following{/other_user}","gists_url":"https://api.github.com/users/fcevado/gists{/gist_id}","starred_url":"https://api.github.com/users/fcevado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcevado/subscriptions","organizations_url":"https://api.github.com/users/fcevado/orgs","repos_url":"https://api.github.com/users/fcevado/repos","events_url":"https://api.github.com/users/fcevado/events{/privacy}","received_events_url":"https://api.github.com/users/fcevado/received_events","type":"User","site_admin":false},"repo":{"id":66744216,"name":"con_cache","full_name":"fcevado/con_cache","owner":{"login":"fcevado","id":9992984,"avatar_url":"https://avatars.githubusercontent.com/u/9992984?v=3","gravatar_id":"","url":"https://api.github.com/users/fcevado","html_url":"https://github.com/fcevado","followers_url":"https://api.github.com/users/fcevado/followers","following_url":"https://api.github.com/users/fcevado/following{/other_user}","gists_url":"https://api.github.com/users/fcevado/gists{/gist_id}","starred_url":"https://api.github.com/users/fcevado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcevado/subscriptions","organizations_url":"https://api.github.com/users/fcevado/orgs","repos_url":"https://api.github.com/users/fcevado/repos","events_url":"https://api.github.com/users/fcevado/events{/privacy}","received_events_url":"https://api.github.com/users/fcevado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fcevado/con_cache","description":"ets based key/value cache with row level isolated writes and ttl support","fork":true,"url":"https://api.github.com/repos/fcevado/con_cache","forks_url":"https://api.github.com/repos/fcevado/con_cache/forks","keys_url":"https://api.github.com/repos/fcevado/con_cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcevado/con_cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcevado/con_cache/teams","hooks_url":"https://api.github.com/repos/fcevado/con_cache/hooks","issue_events_url":"https://api.github.com/repos/fcevado/con_cache/issues/events{/number}","events_url":"https://api.github.com/repos/fcevado/con_cache/events","assignees_url":"https://api.github.com/repos/fcevado/con_cache/assignees{/user}","branches_url":"https://api.github.com/repos/fcevado/con_cache/branches{/branch}","tags_url":"https://api.github.com/repos/fcevado/con_cache/tags","blobs_url":"https://api.github.com/repos/fcevado/con_cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcevado/con_cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcevado/con_cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcevado/con_cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcevado/con_cache/statuses/{sha}","languages_url":"https://api.github.com/repos/fcevado/con_cache/languages","stargazers_url":"https://api.github.com/repos/fcevado/con_cache/stargazers","contributors_url":"https://api.github.com/repos/fcevado/con_cache/contributors","subscribers_url":"https://api.github.com/repos/fcevado/con_cache/subscribers","subscription_url":"https://api.github.com/repos/fcevado/con_cache/subscription","commits_url":"https://api.github.com/repos/fcevado/con_cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcevado/con_cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcevado/con_cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcevado/con_cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcevado/con_cache/contents/{+path}","compare_url":"https://api.github.com/repos/fcevado/con_cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcevado/con_cache/merges","archive_url":"https://api.github.com/repos/fcevado/con_cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcevado/con_cache/downloads","issues_url":"https://api.github.com/repos/fcevado/con_cache/issues{/number}","pulls_url":"https://api.github.com/repos/fcevado/con_cache/pulls{/number}","milestones_url":"https://api.github.com/repos/fcevado/con_cache/milestones{/number}","notifications_url":"https://api.github.com/repos/fcevado/con_cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcevado/con_cache/labels{/name}","releases_url":"https://api.github.com/repos/fcevado/con_cache/releases{/id}","deployments_url":"https://api.github.com/repos/fcevado/con_cache/deployments","created_at":"2016-08-28T01:52:46Z","updated_at":"2016-08-28T01:52:49Z","pushed_at":"2016-08-31T02:52:25Z","git_url":"git://github.com/fcevado/con_cache.git","ssh_url":"git@github.com:fcevado/con_cache.git","clone_url":"https://github.com/fcevado/con_cache.git","svn_url":"https://github.com/fcevado/con_cache","homepage":null,"size":191,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sasa1977:master","ref":"master","sha":"e946e8896ffd9fdd4d574bffc91964822f85b69b","user":{"login":"sasa1977","id":202498,"avatar_url":"https://avatars.githubusercontent.com/u/202498?v=3","gravatar_id":"","url":"https://api.github.com/users/sasa1977","html_url":"https://github.com/sasa1977","followers_url":"https://api.github.com/users/sasa1977/followers","following_url":"https://api.github.com/users/sasa1977/following{/other_user}","gists_url":"https://api.github.com/users/sasa1977/gists{/gist_id}","starred_url":"https://api.github.com/users/sasa1977/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasa1977/subscriptions","organizations_url":"https://api.github.com/users/sasa1977/orgs","repos_url":"https://api.github.com/users/sasa1977/repos","events_url":"https://api.github.com/users/sasa1977/events{/privacy}","received_events_url":"https://api.github.com/users/sasa1977/received_events","type":"User","site_admin":false},"repo":{"id":9097144,"name":"con_cache","full_name":"sasa1977/con_cache","owner":{"login":"sasa1977","id":202498,"avatar_url":"https://avatars.githubusercontent.com/u/202498?v=3","gravatar_id":"","url":"https://api.github.com/users/sasa1977","html_url":"https://github.com/sasa1977","followers_url":"https://api.github.com/users/sasa1977/followers","following_url":"https://api.github.com/users/sasa1977/following{/other_user}","gists_url":"https://api.github.com/users/sasa1977/gists{/gist_id}","starred_url":"https://api.github.com/users/sasa1977/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sasa1977/subscriptions","organizations_url":"https://api.github.com/users/sasa1977/orgs","repos_url":"https://api.github.com/users/sasa1977/repos","events_url":"https://api.github.com/users/sasa1977/events{/privacy}","received_events_url":"https://api.github.com/users/sasa1977/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sasa1977/con_cache","description":"ets based key/value cache with row level isolated writes and ttl support","fork":false,"url":"https://api.github.com/repos/sasa1977/con_cache","forks_url":"https://api.github.com/repos/sasa1977/con_cache/forks","keys_url":"https://api.github.com/repos/sasa1977/con_cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sasa1977/con_cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sasa1977/con_cache/teams","hooks_url":"https://api.github.com/repos/sasa1977/con_cache/hooks","issue_events_url":"https://api.github.com/repos/sasa1977/con_cache/issues/events{/number}","events_url":"https://api.github.com/repos/sasa1977/con_cache/events","assignees_url":"https://api.github.com/repos/sasa1977/con_cache/assignees{/user}","branches_url":"https://api.github.com/repos/sasa1977/con_cache/branches{/branch}","tags_url":"https://api.github.com/repos/sasa1977/con_cache/tags","blobs_url":"https://api.github.com/repos/sasa1977/con_cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sasa1977/con_cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sasa1977/con_cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/sasa1977/con_cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sasa1977/con_cache/statuses/{sha}","languages_url":"https://api.github.com/repos/sasa1977/con_cache/languages","stargazers_url":"https://api.github.com/repos/sasa1977/con_cache/stargazers","contributors_url":"https://api.github.com/repos/sasa1977/con_cache/contributors","subscribers_url":"https://api.github.com/repos/sasa1977/con_cache/subscribers","subscription_url":"https://api.github.com/repos/sasa1977/con_cache/subscription","commits_url":"https://api.github.com/repos/sasa1977/con_cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/sasa1977/con_cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/sasa1977/con_cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/sasa1977/con_cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/sasa1977/con_cache/contents/{+path}","compare_url":"https://api.github.com/repos/sasa1977/con_cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sasa1977/con_cache/merges","archive_url":"https://api.github.com/repos/sasa1977/con_cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sasa1977/con_cache/downloads","issues_url":"https://api.github.com/repos/sasa1977/con_cache/issues{/number}","pulls_url":"https://api.github.com/repos/sasa1977/con_cache/pulls{/number}","milestones_url":"https://api.github.com/repos/sasa1977/con_cache/milestones{/number}","notifications_url":"https://api.github.com/repos/sasa1977/con_cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sasa1977/con_cache/labels{/name}","releases_url":"https://api.github.com/repos/sasa1977/con_cache/releases{/id}","deployments_url":"https://api.github.com/repos/sasa1977/con_cache/deployments","created_at":"2013-03-29T11:21:29Z","updated_at":"2016-08-30T21:08:14Z","pushed_at":"2016-08-31T02:52:25Z","git_url":"git://github.com/sasa1977/con_cache.git","ssh_url":"git@github.com:sasa1977/con_cache.git","clone_url":"https://github.com/sasa1977/con_cache.git","svn_url":"https://github.com/sasa1977/con_cache","homepage":null,"size":185,"stargazers_count":136,"watchers_count":136,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":4,"forks":21,"open_issues":4,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sasa1977/con_cache/pulls/26"},"html":{"href":"https://github.com/sasa1977/con_cache/pull/26"},"issue":{"href":"https://api.github.com/repos/sasa1977/con_cache/issues/26"},"comments":{"href":"https://api.github.com/repos/sasa1977/con_cache/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/sasa1977/con_cache/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/sasa1977/con_cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sasa1977/con_cache/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/sasa1977/con_cache/statuses/cef352a25168e39ad59a7311dc0f61985e4946ed"}}}}
{"actor":{"display_login":"sasa1977"}}