{"action":"closed","number":4672,"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/4672","id":67276522,"html_url":"https://github.com/radare/radare2/pull/4672","diff_url":"https://github.com/radare/radare2/pull/4672.diff","patch_url":"https://github.com/radare/radare2/pull/4672.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/4672","number":4672,"state":"closed","locked":false,"title":"z80_cr asm: fix 'ed' opcode range resulted in overflow","user":{"login":"kolen","id":24191,"avatar_url":"https://avatars.githubusercontent.com/u/24191?v=3","gravatar_id":"","url":"https://api.github.com/users/kolen","html_url":"https://github.com/kolen","followers_url":"https://api.github.com/users/kolen/followers","following_url":"https://api.github.com/users/kolen/following{/other_user}","gists_url":"https://api.github.com/users/kolen/gists{/gist_id}","starred_url":"https://api.github.com/users/kolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolen/subscriptions","organizations_url":"https://api.github.com/users/kolen/orgs","repos_url":"https://api.github.com/users/kolen/repos","events_url":"https://api.github.com/users/kolen/events{/privacy}","received_events_url":"https://api.github.com/users/kolen/received_events","type":"User","site_admin":false},"body":"Parsing ``0xed`` prefixed opcode in range ``0x3a`` to ``0x3f`` results in overflow while looking up ``ed[]`` array (from ``libr/asm/arch/z80_cr/z80_tab.h``). This range belongs to unknown opcodes (``0x3b`` in ``ed[]``).\r\n\r\nThis range should be:\r\n```\r\n40 41 .. 4a 4b\r\n   maps to\r\n00 01 .. 0a 0b\r\n```\r\nWas:\r\n```\r\n3a 3b 3c 3d 3e 3f 40 41 .. 4a 4b\r\n            maps to\r\nfa fb fc fd fe ff 00 01 .. 0a 0b\r\n```\r\n\r\nThis probably not causes segfault (unless built with something like address sanitizer) so I didn't create tests for it, tests will probably not detect this bug.","created_at":"2016-04-20T23:47:30Z","updated_at":"2016-04-21T13:34:04Z","closed_at":"2016-04-21T13:34:03Z","merged_at":null,"merge_commit_sha":"d14b51964e48eb852ebaecaa5dca430eed187463","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/4672/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/4672/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/4672/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/481262e4b36ade921d6812f21143de968d97db12","head":{"label":"kolen:fix-z80-asm-ed-overflow","ref":"fix-z80-asm-ed-overflow","sha":"481262e4b36ade921d6812f21143de968d97db12","user":{"login":"kolen","id":24191,"avatar_url":"https://avatars.githubusercontent.com/u/24191?v=3","gravatar_id":"","url":"https://api.github.com/users/kolen","html_url":"https://github.com/kolen","followers_url":"https://api.github.com/users/kolen/followers","following_url":"https://api.github.com/users/kolen/following{/other_user}","gists_url":"https://api.github.com/users/kolen/gists{/gist_id}","starred_url":"https://api.github.com/users/kolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolen/subscriptions","organizations_url":"https://api.github.com/users/kolen/orgs","repos_url":"https://api.github.com/users/kolen/repos","events_url":"https://api.github.com/users/kolen/events{/privacy}","received_events_url":"https://api.github.com/users/kolen/received_events","type":"User","site_admin":false},"repo":{"id":55321374,"name":"radare2","full_name":"kolen/radare2","owner":{"login":"kolen","id":24191,"avatar_url":"https://avatars.githubusercontent.com/u/24191?v=3","gravatar_id":"","url":"https://api.github.com/users/kolen","html_url":"https://github.com/kolen","followers_url":"https://api.github.com/users/kolen/followers","following_url":"https://api.github.com/users/kolen/following{/other_user}","gists_url":"https://api.github.com/users/kolen/gists{/gist_id}","starred_url":"https://api.github.com/users/kolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kolen/subscriptions","organizations_url":"https://api.github.com/users/kolen/orgs","repos_url":"https://api.github.com/users/kolen/repos","events_url":"https://api.github.com/users/kolen/events{/privacy}","received_events_url":"https://api.github.com/users/kolen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kolen/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/kolen/radare2","forks_url":"https://api.github.com/repos/kolen/radare2/forks","keys_url":"https://api.github.com/repos/kolen/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kolen/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kolen/radare2/teams","hooks_url":"https://api.github.com/repos/kolen/radare2/hooks","issue_events_url":"https://api.github.com/repos/kolen/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/kolen/radare2/events","assignees_url":"https://api.github.com/repos/kolen/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/kolen/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/kolen/radare2/tags","blobs_url":"https://api.github.com/repos/kolen/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kolen/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kolen/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kolen/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kolen/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/kolen/radare2/languages","stargazers_url":"https://api.github.com/repos/kolen/radare2/stargazers","contributors_url":"https://api.github.com/repos/kolen/radare2/contributors","subscribers_url":"https://api.github.com/repos/kolen/radare2/subscribers","subscription_url":"https://api.github.com/repos/kolen/radare2/subscription","commits_url":"https://api.github.com/repos/kolen/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kolen/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kolen/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kolen/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kolen/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/kolen/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kolen/radare2/merges","archive_url":"https://api.github.com/repos/kolen/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kolen/radare2/downloads","issues_url":"https://api.github.com/repos/kolen/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/kolen/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/kolen/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/kolen/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kolen/radare2/labels{/name}","releases_url":"https://api.github.com/repos/kolen/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/kolen/radare2/deployments","created_at":"2016-04-02T23:44:30Z","updated_at":"2016-04-02T23:44:46Z","pushed_at":"2016-04-20T23:40:28Z","git_url":"git://github.com/kolen/radare2.git","ssh_url":"git@github.com:kolen/radare2.git","clone_url":"https://github.com/kolen/radare2.git","svn_url":"https://github.com/kolen/radare2","homepage":"http://www.radare.org/","size":57007,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"1ac0d47652eb727a41b55c9722ec92918fe66a77","user":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2016-04-21T13:07:02Z","pushed_at":"2016-04-21T13:33:33Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":73519,"stargazers_count":2530,"watchers_count":2530,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":564,"mirror_url":null,"open_issues_count":699,"forks":564,"open_issues":699,"watchers":2530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/4672"},"html":{"href":"https://github.com/radare/radare2/pull/4672"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/4672"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/4672/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/4672/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/4672/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/481262e4b36ade921d6812f21143de968d97db12"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}