{"action":"created","comment":{"url":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/comments/79645226","id":79645226,"diff_hunk":"@@ -0,0 +1,123 @@\n+# this is an example of the Uber API\n+# as a demonstration of an API spec in YAML\n+swagger: '2.0'\n+info:\n+  title: GraphHopper Geocoding API\n+  description: GraphHopper Geocoding API\n+  version: \"1.0.0\"\n+# the domain of the service\n+host: graphhopper.com\n+# array of all schemes that your API supports\n+schemes:\n+  - https\n+# will be prefixed to all paths\n+basePath: /api/1\n+produces:\n+  - application/json\n+securityDefinitions:\n+  api_key:\n+    type: apiKey\n+    name: key\n+    in: query\n+paths:\n+  /geocode:\n+    get:\n+      summary: Execute a Geocoding request\n+      description: |\n+        This endpoint provides forward and reverse geocoding\n+      parameters:\n+        - name: q\n+          in: query\n+          description: If you do forward geocoding, then this would be a textual description of the adress you are looking for. If you do reverse geocoding this would be in lat,lon.\n+          required: false\n+          type: string\n+        - name: locale\n+          in: query\n+          required: false\n+          type: string\n+        - name: limit\n+          in: query\n+          required: false\n+          type: integer\n+          format: int32\n+        - name: debug","path":"geocoding_swagger.yaml","position":null,"original_position":43,"commit_id":"7e7755389fcae149c48d98e14821ee0030df258e","original_commit_id":"5f6ffb6ebc3f49e876cee463979c881975af44a0","user":{"login":"karussell","id":129644,"avatar_url":"https://avatars.githubusercontent.com/u/129644?v=3","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"body":"As the outcome is not really accessible to the client I would remove it?","created_at":"2016-09-20T15:52:39Z","updated_at":"2016-09-20T15:52:39Z","html_url":"https://github.com/graphhopper/directions-api-java-client/pull/20#discussion_r79645226","pull_request_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/comments/79645226"},"html":{"href":"https://github.com/graphhopper/directions-api-java-client/pull/20#discussion_r79645226"},"pull_request":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20","id":84488892,"html_url":"https://github.com/graphhopper/directions-api-java-client/pull/20","diff_url":"https://github.com/graphhopper/directions-api-java-client/pull/20.diff","patch_url":"https://github.com/graphhopper/directions-api-java-client/pull/20.patch","issue_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/issues/20","number":20,"state":"open","locked":false,"title":"Add Geocoding to the Client","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars.githubusercontent.com/u/1553525?v=3","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nso I just started to add GeoCoding to the client. Right now I am not sure how to proceed.\r\n\r\nI added the GHGEntry and GHGResponse, which are basically copied from the [graphhopper-geocoder-converter](https://github.com/boldtrn/graphhopper-geocoder-converter/tree/master/src/main/java/com/graphhopper/converter/api). In the converter we use Jackson to convert Json to JavaObjects, but in the client right now we don't use jackson.\r\n\r\nSo right now I am thinking if I should add Jackson as dependency or if I should do the parsing by hand? \r\n\r\nAdding dependencies is not really nice, but on the other hand, this would make the code more maintainable and we could maybe add the geocoder-converter as dependency and don't need to copy the classes? \r\n\r\nWhat do you think is the better way to do this?\r\n\r\nBTW: Code quality is pretty bad right now, I just created the PR to discuss the various options.","created_at":"2016-09-08T14:31:42Z","updated_at":"2016-09-20T15:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f97c11f759df1d1640a14485dca15dec32c5e45","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20/commits","review_comments_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20/comments","review_comment_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/issues/20/comments","statuses_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/statuses/7e7755389fcae149c48d98e14821ee0030df258e","head":{"label":"boldtrn:feature_geocoding","ref":"feature_geocoding","sha":"7e7755389fcae149c48d98e14821ee0030df258e","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars.githubusercontent.com/u/1553525?v=3","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"repo":{"id":66755149,"name":"directions-api-java-client","full_name":"boldtrn/directions-api-java-client","owner":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars.githubusercontent.com/u/1553525?v=3","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boldtrn/directions-api-java-client","description":"Java and Android client for the GraphHopper Directions API","fork":true,"url":"https://api.github.com/repos/boldtrn/directions-api-java-client","forks_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/forks","keys_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/teams","hooks_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/hooks","issue_events_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/events","assignees_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/tags","blobs_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/languages","stargazers_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/stargazers","contributors_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/contributors","subscribers_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/subscribers","subscription_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/subscription","commits_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/merges","archive_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/downloads","issues_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/labels{/name}","releases_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/boldtrn/directions-api-java-client/deployments","created_at":"2016-08-28T07:19:05Z","updated_at":"2016-08-28T07:19:06Z","pushed_at":"2016-09-20T13:31:38Z","git_url":"git://github.com/boldtrn/directions-api-java-client.git","ssh_url":"git@github.com:boldtrn/directions-api-java-client.git","clone_url":"https://github.com/boldtrn/directions-api-java-client.git","svn_url":"https://github.com/boldtrn/directions-api-java-client","homepage":"https://graphhopper.com/#directions-api","size":435,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphhopper:master","ref":"master","sha":"e0d5fc1dbf8f5eba45dd364648b0bdcd17a5352c","user":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars.githubusercontent.com/u/2264498?v=3","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"repo":{"id":30657069,"name":"directions-api-java-client","full_name":"graphhopper/directions-api-java-client","owner":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars.githubusercontent.com/u/2264498?v=3","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphhopper/directions-api-java-client","description":"Java and Android client for the GraphHopper Directions API","fork":false,"url":"https://api.github.com/repos/graphhopper/directions-api-java-client","forks_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/forks","keys_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/teams","hooks_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/hooks","issue_events_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/issues/events{/number}","events_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/events","assignees_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/assignees{/user}","branches_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/branches{/branch}","tags_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/tags","blobs_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/languages","stargazers_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/stargazers","contributors_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/contributors","subscribers_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/subscribers","subscription_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/subscription","commits_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/contents/{+path}","compare_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/merges","archive_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/downloads","issues_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/issues{/number}","pulls_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/labels{/name}","releases_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/releases{/id}","deployments_url":"https://api.github.com/repos/graphhopper/directions-api-java-client/deployments","created_at":"2015-02-11T16:23:21Z","updated_at":"2016-08-10T20:14:02Z","pushed_at":"2016-09-20T13:31:38Z","git_url":"git://github.com/graphhopper/directions-api-java-client.git","ssh_url":"git@github.com:graphhopper/directions-api-java-client.git","clone_url":"https://github.com/graphhopper/directions-api-java-client.git","svn_url":"https://github.com/graphhopper/directions-api-java-client","homepage":"https://graphhopper.com/#directions-api","size":385,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":3,"forks":10,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20"},"html":{"href":"https://github.com/graphhopper/directions-api-java-client/pull/20"},"issue":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/issues/20"},"comments":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/graphhopper/directions-api-java-client/statuses/7e7755389fcae149c48d98e14821ee0030df258e"}}}}
{"actor":{"display_login":"karussell"}}