{"action":"created","issue":{"url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/889","labels_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/889/labels{/name}","comments_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/889/comments","events_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/889/events","html_url":"https://github.com/RS485/LogisticsPipes/issues/889","id":124526385,"number":889,"title":"OpenGL 1281 Error when rendering fluids with no block","user":{"login":"diamondq","id":2138184,"avatar_url":"https://avatars.githubusercontent.com/u/2138184?v=3","gravatar_id":"","url":"https://api.github.com/users/diamondq","html_url":"https://github.com/diamondq","followers_url":"https://api.github.com/users/diamondq/followers","following_url":"https://api.github.com/users/diamondq/following{/other_user}","gists_url":"https://api.github.com/users/diamondq/gists{/gist_id}","starred_url":"https://api.github.com/users/diamondq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diamondq/subscriptions","organizations_url":"https://api.github.com/users/diamondq/orgs","repos_url":"https://api.github.com/users/diamondq/repos","events_url":"https://api.github.com/users/diamondq/events{/privacy}","received_events_url":"https://api.github.com/users/diamondq/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/RS485/LogisticsPipes/labels/Accepted","name":"Accepted","color":"00a00a"},{"url":"https://api.github.com/repos/RS485/LogisticsPipes/labels/Bug","name":"Bug","color":"f00f00"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-01-01T02:01:14Z","updated_at":"2016-01-06T11:41:44Z","closed_at":null,"body":"Occurs in v0.9.3.70 on the stable-bc7 branch:\r\n\r\nThe code in LogisticsRenderPipe does a null check and bails if there is no \"base block\" associated with a liquid.\r\n\r\nhttps://github.com/RS485/LogisticsPipes/blob/stable-bc7/common/logisticspipes/renderer/LogisticsRenderPipe.java#L601\r\n\r\nUnfortunately, a number of mods (Mekanism is a prime example), don't provide a block for some of their liquids. While I agree that these mods should be fixed as well, the null check exiting the initialization of the DisplayFluidList, causes the display list to not be properly set up, and then when it attempts to render a liquid (in renderFluids) it calls the glCallList with a undefined display list, and you get a 1281 error.\r\n\r\nMy suggestion would be to put the null check in earlier, and if the fluid.getBlock() returns null, then leave the RenderInfo.baseBlock pointing to the default value of sand (at least it's something to draw). This should allow the DisplayFluidList to be built with some display list values, and a later call to render them will work.\r\n\r\nOtherwise, depending on your environment, it can lock up the client thread completely, and it effectively creates a dead zone that causes any client to hang if they enter the render distance of a LogisticsPipe transferring such a liquid (I originally found it attempting to transfer Brine from an Mekanism Solar Evaporation Tower).\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/comments/169305265","html_url":"https://github.com/RS485/LogisticsPipes/issues/889#issuecomment-169305265","issue_url":"https://api.github.com/repos/RS485/LogisticsPipes/issues/889","id":169305265,"user":{"login":"hron84","id":88636,"avatar_url":"https://avatars.githubusercontent.com/u/88636?v=3","gravatar_id":"","url":"https://api.github.com/users/hron84","html_url":"https://github.com/hron84","followers_url":"https://api.github.com/users/hron84/followers","following_url":"https://api.github.com/users/hron84/following{/other_user}","gists_url":"https://api.github.com/users/hron84/gists{/gist_id}","starred_url":"https://api.github.com/users/hron84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hron84/subscriptions","organizations_url":"https://api.github.com/users/hron84/orgs","repos_url":"https://api.github.com/users/hron84/repos","events_url":"https://api.github.com/users/hron84/events{/privacy}","received_events_url":"https://api.github.com/users/hron84/received_events","type":"User","site_admin":false},"created_at":"2016-01-06T11:41:44Z","updated_at":"2016-01-06T11:41:44Z","body":"I don't think so, but if you move to other solution that does not trigger the error, it will be stop appearing. Maybe after a reload. I know this is not optimal, but these error messages should be pop up. But I think developers would be happy if you send an another issue with feature request to rate limit these messages."}}