{"action":"created","comment":{"url":"https://api.github.com/repos/boto/botocore/pulls/comments/65788283","id":65788283,"diff_hunk":"@@ -265,7 +314,21 @@ def _get_response_handler(self, model, params, **kwargs):\n     def _assert_expected_params(self, model, params, **kwargs):\n         self._assert_expected_call_order(model, params)\n         expected_params = self._queue[0]['expected_params']\n-        if expected_params is not None and params != expected_params:\n+        if expected_params is None:\n+            return\n+\n+        # Validate the parameters are equal\n+        for param, value in expected_params.items():\n+            if value is ANY:\n+                continue\n+            elif expected_params[param] != params[param]:","path":"botocore/stub.py","position":82,"original_position":82,"commit_id":"cc4cf54be13a97093231bbf3deb30d235c3eabc7","original_commit_id":"cc4cf54be13a97093231bbf3deb30d235c3eabc7","user":{"login":"kyleknap","id":4605355,"avatar_url":"https://avatars.githubusercontent.com/u/4605355?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"body":"I feel like there may be key errors here if the expected param is missing from the actual params.","created_at":"2016-06-03T23:09:22Z","updated_at":"2016-06-03T23:09:22Z","html_url":"https://github.com/boto/botocore/pull/939#discussion_r65788283","pull_request_url":"https://api.github.com/repos/boto/botocore/pulls/939","_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments/65788283"},"html":{"href":"https://github.com/boto/botocore/pull/939#discussion_r65788283"},"pull_request":{"href":"https://api.github.com/repos/boto/botocore/pulls/939"}}},"pull_request":{"url":"https://api.github.com/repos/boto/botocore/pulls/939","id":72553526,"html_url":"https://github.com/boto/botocore/pull/939","diff_url":"https://github.com/boto/botocore/pull/939.diff","patch_url":"https://github.com/boto/botocore/pull/939.patch","issue_url":"https://api.github.com/repos/boto/botocore/issues/939","number":939,"state":"open","locked":false,"title":"Allow paramters to be ignored in Stubber validation","user":{"login":"JordonPhillips","id":2643092,"avatar_url":"https://avatars.githubusercontent.com/u/2643092?v=3","gravatar_id":"","url":"https://api.github.com/users/JordonPhillips","html_url":"https://github.com/JordonPhillips","followers_url":"https://api.github.com/users/JordonPhillips/followers","following_url":"https://api.github.com/users/JordonPhillips/following{/other_user}","gists_url":"https://api.github.com/users/JordonPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/JordonPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordonPhillips/subscriptions","organizations_url":"https://api.github.com/users/JordonPhillips/orgs","repos_url":"https://api.github.com/users/JordonPhillips/repos","events_url":"https://api.github.com/users/JordonPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/JordonPhillips/received_events","type":"User","site_admin":false},"body":"This allows users to specify stub.ANY for expected parameters if\r\nthey don't care about a specific parameter's value.\r\n\r\nResolves #931\r\n\r\ncc @kyleknap  @jamesls","created_at":"2016-06-03T18:57:03Z","updated_at":"2016-06-03T23:09:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a9a6694c3a8556df55eae56540bc1588430614d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boto/botocore/pulls/939/commits","review_comments_url":"https://api.github.com/repos/boto/botocore/pulls/939/comments","review_comment_url":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boto/botocore/issues/939/comments","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/cc4cf54be13a97093231bbf3deb30d235c3eabc7","head":{"label":"JordonPhillips:stub-any","ref":"stub-any","sha":"cc4cf54be13a97093231bbf3deb30d235c3eabc7","user":{"login":"JordonPhillips","id":2643092,"avatar_url":"https://avatars.githubusercontent.com/u/2643092?v=3","gravatar_id":"","url":"https://api.github.com/users/JordonPhillips","html_url":"https://github.com/JordonPhillips","followers_url":"https://api.github.com/users/JordonPhillips/followers","following_url":"https://api.github.com/users/JordonPhillips/following{/other_user}","gists_url":"https://api.github.com/users/JordonPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/JordonPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordonPhillips/subscriptions","organizations_url":"https://api.github.com/users/JordonPhillips/orgs","repos_url":"https://api.github.com/users/JordonPhillips/repos","events_url":"https://api.github.com/users/JordonPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/JordonPhillips/received_events","type":"User","site_admin":false},"repo":{"id":41875883,"name":"botocore","full_name":"JordonPhillips/botocore","owner":{"login":"JordonPhillips","id":2643092,"avatar_url":"https://avatars.githubusercontent.com/u/2643092?v=3","gravatar_id":"","url":"https://api.github.com/users/JordonPhillips","html_url":"https://github.com/JordonPhillips","followers_url":"https://api.github.com/users/JordonPhillips/followers","following_url":"https://api.github.com/users/JordonPhillips/following{/other_user}","gists_url":"https://api.github.com/users/JordonPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/JordonPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordonPhillips/subscriptions","organizations_url":"https://api.github.com/users/JordonPhillips/orgs","repos_url":"https://api.github.com/users/JordonPhillips/repos","events_url":"https://api.github.com/users/JordonPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/JordonPhillips/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JordonPhillips/botocore","description":"The low-level, core functionality of boto 3.","fork":true,"url":"https://api.github.com/repos/JordonPhillips/botocore","forks_url":"https://api.github.com/repos/JordonPhillips/botocore/forks","keys_url":"https://api.github.com/repos/JordonPhillips/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JordonPhillips/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JordonPhillips/botocore/teams","hooks_url":"https://api.github.com/repos/JordonPhillips/botocore/hooks","issue_events_url":"https://api.github.com/repos/JordonPhillips/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/JordonPhillips/botocore/events","assignees_url":"https://api.github.com/repos/JordonPhillips/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/JordonPhillips/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/JordonPhillips/botocore/tags","blobs_url":"https://api.github.com/repos/JordonPhillips/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JordonPhillips/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JordonPhillips/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/JordonPhillips/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JordonPhillips/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/JordonPhillips/botocore/languages","stargazers_url":"https://api.github.com/repos/JordonPhillips/botocore/stargazers","contributors_url":"https://api.github.com/repos/JordonPhillips/botocore/contributors","subscribers_url":"https://api.github.com/repos/JordonPhillips/botocore/subscribers","subscription_url":"https://api.github.com/repos/JordonPhillips/botocore/subscription","commits_url":"https://api.github.com/repos/JordonPhillips/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/JordonPhillips/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/JordonPhillips/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/JordonPhillips/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/JordonPhillips/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/JordonPhillips/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JordonPhillips/botocore/merges","archive_url":"https://api.github.com/repos/JordonPhillips/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JordonPhillips/botocore/downloads","issues_url":"https://api.github.com/repos/JordonPhillips/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/JordonPhillips/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/JordonPhillips/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/JordonPhillips/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JordonPhillips/botocore/labels{/name}","releases_url":"https://api.github.com/repos/JordonPhillips/botocore/releases{/id}","deployments_url":"https://api.github.com/repos/JordonPhillips/botocore/deployments","created_at":"2015-09-03T18:13:17Z","updated_at":"2016-01-11T18:57:53Z","pushed_at":"2016-06-03T20:59:49Z","git_url":"git://github.com/JordonPhillips/botocore.git","ssh_url":"git@github.com:JordonPhillips/botocore.git","clone_url":"https://github.com/JordonPhillips/botocore.git","svn_url":"https://github.com/JordonPhillips/botocore","homepage":null,"size":21460,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"b7fd74217ab819a962012b17ee240b57fe903b58","user":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":6670942,"name":"botocore","full_name":"boto/botocore","owner":{"login":"boto","id":327752,"avatar_url":"https://avatars.githubusercontent.com/u/327752?v=3","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/botocore","description":"The low-level, core functionality of boto 3.","fork":false,"url":"https://api.github.com/repos/boto/botocore","forks_url":"https://api.github.com/repos/boto/botocore/forks","keys_url":"https://api.github.com/repos/boto/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/botocore/teams","hooks_url":"https://api.github.com/repos/boto/botocore/hooks","issue_events_url":"https://api.github.com/repos/boto/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/boto/botocore/events","assignees_url":"https://api.github.com/repos/boto/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/boto/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/boto/botocore/tags","blobs_url":"https://api.github.com/repos/boto/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/botocore/languages","stargazers_url":"https://api.github.com/repos/boto/botocore/stargazers","contributors_url":"https://api.github.com/repos/boto/botocore/contributors","subscribers_url":"https://api.github.com/repos/boto/botocore/subscribers","subscription_url":"https://api.github.com/repos/boto/botocore/subscription","commits_url":"https://api.github.com/repos/boto/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/boto/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/boto/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/botocore/merges","archive_url":"https://api.github.com/repos/boto/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/botocore/downloads","issues_url":"https://api.github.com/repos/boto/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/boto/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/botocore/labels{/name}","releases_url":"https://api.github.com/repos/boto/botocore/releases{/id}","deployments_url":"https://api.github.com/repos/boto/botocore/deployments","created_at":"2012-11-13T13:25:36Z","updated_at":"2016-06-03T09:57:44Z","pushed_at":"2016-06-03T21:00:51Z","git_url":"git://github.com/boto/botocore.git","ssh_url":"git@github.com:boto/botocore.git","clone_url":"https://github.com/boto/botocore.git","svn_url":"https://github.com/boto/botocore","homepage":null,"size":23273,"stargazers_count":256,"watchers_count":256,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":47,"forks":165,"open_issues":47,"watchers":256,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/939"},"html":{"href":"https://github.com/boto/botocore/pull/939"},"issue":{"href":"https://api.github.com/repos/boto/botocore/issues/939"},"comments":{"href":"https://api.github.com/repos/boto/botocore/issues/939/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/botocore/pulls/939/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boto/botocore/pulls/939/commits"},"statuses":{"href":"https://api.github.com/repos/boto/botocore/statuses/cc4cf54be13a97093231bbf3deb30d235c3eabc7"}}}}
{"actor":{"display_login":"kyleknap"}}