{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/64668684","id":64668684,"diff_hunk":"@@ -92,6 +92,13 @@\n   private volatile boolean responseComplete = false;\n   // marked as true if force close is required because close() was called.\n   private volatile boolean forceClose = false;\n+  // the ResponseStatus that will be sent (or has been sent) as a part of the response.\n+  private volatile ResponseStatus responseStatus = ResponseStatus.Ok;\n+  // the response metadata that was actually sent.\n+  private volatile HttpResponse finalResponseMetadata = null;","path":"ambry-rest/src/main/java/com.github.ambry.rest/NettyResponseChannel.java","position":7,"original_position":7,"commit_id":"31c029966650113795bdb89cd546184be4704320","original_commit_id":"8b51731213af07cd680331417645f275f9fa3fea","user":{"login":"xiahome","id":8271368,"avatar_url":"https://avatars.githubusercontent.com/u/8271368?v=3","gravatar_id":"","url":"https://api.github.com/users/xiahome","html_url":"https://github.com/xiahome","followers_url":"https://api.github.com/users/xiahome/followers","following_url":"https://api.github.com/users/xiahome/following{/other_user}","gists_url":"https://api.github.com/users/xiahome/gists{/gist_id}","starred_url":"https://api.github.com/users/xiahome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiahome/subscriptions","organizations_url":"https://api.github.com/users/xiahome/orgs","repos_url":"https://api.github.com/users/xiahome/repos","events_url":"https://api.github.com/users/xiahome/events{/privacy}","received_events_url":"https://api.github.com/users/xiahome/received_events","type":"User","site_admin":false},"body":"I see, then `volatile` should be the right one to go.","created_at":"2016-05-25T23:08:46Z","updated_at":"2016-05-25T23:08:46Z","html_url":"https://github.com/linkedin/ambry/pull/319#discussion_r64668684","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/319","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/64668684"},"html":{"href":"https://github.com/linkedin/ambry/pull/319#discussion_r64668684"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/319"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/319","id":70805023,"html_url":"https://github.com/linkedin/ambry/pull/319","diff_url":"https://github.com/linkedin/ambry/pull/319.diff","patch_url":"https://github.com/linkedin/ambry/pull/319.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/319","number":319,"state":"open","locked":false,"title":"Adding getStatus() and getHeader() APIs in RestResponseChannel","user":{"login":"vgkholla","id":288834,"avatar_url":"https://avatars.githubusercontent.com/u/288834?v=3","gravatar_id":"","url":"https://api.github.com/users/vgkholla","html_url":"https://github.com/vgkholla","followers_url":"https://api.github.com/users/vgkholla/followers","following_url":"https://api.github.com/users/vgkholla/following{/other_user}","gists_url":"https://api.github.com/users/vgkholla/gists{/gist_id}","starred_url":"https://api.github.com/users/vgkholla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgkholla/subscriptions","organizations_url":"https://api.github.com/users/vgkholla/orgs","repos_url":"https://api.github.com/users/vgkholla/repos","events_url":"https://api.github.com/users/vgkholla/events{/privacy}","received_events_url":"https://api.github.com/users/vgkholla/received_events","type":"User","site_admin":false},"body":"The `RestResponseChannel` is passed around as a piece of data and can help avoid repeated code by simply exposing the headers that have been set. Components that pass a `RestResponseChannel` around can then start communicating by the presence, absence and value of headers.\r\n\r\nThis change also adds and refines some tests in `NettyResponseChannel`.\r\n\r\n**Primary reviewers: Casey, Ming**\r\n**Expected time to review: 20-30 mins**\r\n\r\n**Unit test coverage**\r\n\r\nClass | Class, % | Method, % | Line, %\r\n------- | ------------ | -------------- | ----------\r\nNettyResponseChannel | 100% (8/ 8) | 100% (37/ 37) | 96.3% (285/ 296)\r\n","created_at":"2016-05-20T05:58:32Z","updated_at":"2016-05-25T23:08:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df306e87ba5e8da9f686e9fa376c0e33f5dc6c2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/319/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/319/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/319/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/31c029966650113795bdb89cd546184be4704320","head":{"label":"vgkholla:RestResponseChannelGet","ref":"RestResponseChannelGet","sha":"31c029966650113795bdb89cd546184be4704320","user":{"login":"vgkholla","id":288834,"avatar_url":"https://avatars.githubusercontent.com/u/288834?v=3","gravatar_id":"","url":"https://api.github.com/users/vgkholla","html_url":"https://github.com/vgkholla","followers_url":"https://api.github.com/users/vgkholla/followers","following_url":"https://api.github.com/users/vgkholla/following{/other_user}","gists_url":"https://api.github.com/users/vgkholla/gists{/gist_id}","starred_url":"https://api.github.com/users/vgkholla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgkholla/subscriptions","organizations_url":"https://api.github.com/users/vgkholla/orgs","repos_url":"https://api.github.com/users/vgkholla/repos","events_url":"https://api.github.com/users/vgkholla/events{/privacy}","received_events_url":"https://api.github.com/users/vgkholla/received_events","type":"User","site_admin":false},"repo":{"id":33381520,"name":"ambry","full_name":"vgkholla/ambry","owner":{"login":"vgkholla","id":288834,"avatar_url":"https://avatars.githubusercontent.com/u/288834?v=3","gravatar_id":"","url":"https://api.github.com/users/vgkholla","html_url":"https://github.com/vgkholla","followers_url":"https://api.github.com/users/vgkholla/followers","following_url":"https://api.github.com/users/vgkholla/following{/other_user}","gists_url":"https://api.github.com/users/vgkholla/gists{/gist_id}","starred_url":"https://api.github.com/users/vgkholla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgkholla/subscriptions","organizations_url":"https://api.github.com/users/vgkholla/orgs","repos_url":"https://api.github.com/users/vgkholla/repos","events_url":"https://api.github.com/users/vgkholla/events{/privacy}","received_events_url":"https://api.github.com/users/vgkholla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vgkholla/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/vgkholla/ambry","forks_url":"https://api.github.com/repos/vgkholla/ambry/forks","keys_url":"https://api.github.com/repos/vgkholla/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vgkholla/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vgkholla/ambry/teams","hooks_url":"https://api.github.com/repos/vgkholla/ambry/hooks","issue_events_url":"https://api.github.com/repos/vgkholla/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/vgkholla/ambry/events","assignees_url":"https://api.github.com/repos/vgkholla/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/vgkholla/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/vgkholla/ambry/tags","blobs_url":"https://api.github.com/repos/vgkholla/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vgkholla/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vgkholla/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/vgkholla/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vgkholla/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/vgkholla/ambry/languages","stargazers_url":"https://api.github.com/repos/vgkholla/ambry/stargazers","contributors_url":"https://api.github.com/repos/vgkholla/ambry/contributors","subscribers_url":"https://api.github.com/repos/vgkholla/ambry/subscribers","subscription_url":"https://api.github.com/repos/vgkholla/ambry/subscription","commits_url":"https://api.github.com/repos/vgkholla/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/vgkholla/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/vgkholla/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/vgkholla/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/vgkholla/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/vgkholla/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vgkholla/ambry/merges","archive_url":"https://api.github.com/repos/vgkholla/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vgkholla/ambry/downloads","issues_url":"https://api.github.com/repos/vgkholla/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/vgkholla/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/vgkholla/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/vgkholla/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vgkholla/ambry/labels{/name}","releases_url":"https://api.github.com/repos/vgkholla/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/vgkholla/ambry/deployments","created_at":"2015-04-03T20:29:52Z","updated_at":"2016-05-04T00:02:55Z","pushed_at":"2016-05-24T18:39:15Z","git_url":"git://github.com/vgkholla/ambry.git","ssh_url":"git@github.com:vgkholla/ambry.git","clone_url":"https://github.com/vgkholla/ambry.git","svn_url":"https://github.com/vgkholla/ambry","homepage":null,"size":6710,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"89fb98dc36028ceb35528d6cb6501a713974239f","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2016-05-25T22:16:31Z","pushed_at":"2016-05-25T21:47:25Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":7130,"stargazers_count":370,"watchers_count":370,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":26,"forks":31,"open_issues":26,"watchers":370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/319"},"html":{"href":"https://github.com/linkedin/ambry/pull/319"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/319"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/31c029966650113795bdb89cd546184be4704320"}}}}
{"actor":{"display_login":"xiahome"}}