{"action":"created","issue":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/807","repository_url":"https://api.github.com/repos/ElektraInitiative/libelektra","labels_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/807/labels{/name}","comments_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/807/comments","events_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/807/events","html_url":"https://github.com/ElektraInitiative/libelektra/issues/807","id":161184890,"number":807,"title":"Shell recorder: shellcheck & checkbashisms","user":{"login":"KurtMi","id":11669591,"avatar_url":"https://avatars.githubusercontent.com/u/11669591?v=3","gravatar_id":"","url":"https://api.github.com/users/KurtMi","html_url":"https://github.com/KurtMi","followers_url":"https://api.github.com/users/KurtMi/followers","following_url":"https://api.github.com/users/KurtMi/following{/other_user}","gists_url":"https://api.github.com/users/KurtMi/gists{/gist_id}","starred_url":"https://api.github.com/users/KurtMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurtMi/subscriptions","organizations_url":"https://api.github.com/users/KurtMi/orgs","repos_url":"https://api.github.com/users/KurtMi/repos","events_url":"https://api.github.com/users/KurtMi/events{/privacy}","received_events_url":"https://api.github.com/users/KurtMi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tom-wa","id":13944659,"avatar_url":"https://avatars.githubusercontent.com/u/13944659?v=3","gravatar_id":"","url":"https://api.github.com/users/tom-wa","html_url":"https://github.com/tom-wa","followers_url":"https://api.github.com/users/tom-wa/followers","following_url":"https://api.github.com/users/tom-wa/following{/other_user}","gists_url":"https://api.github.com/users/tom-wa/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-wa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-wa/subscriptions","organizations_url":"https://api.github.com/users/tom-wa/orgs","repos_url":"https://api.github.com/users/tom-wa/repos","events_url":"https://api.github.com/users/tom-wa/events{/privacy}","received_events_url":"https://api.github.com/users/tom-wa/received_events","type":"User","site_admin":false},"assignees":[{"login":"tom-wa","id":13944659,"avatar_url":"https://avatars.githubusercontent.com/u/13944659?v=3","gravatar_id":"","url":"https://api.github.com/users/tom-wa","html_url":"https://github.com/tom-wa","followers_url":"https://api.github.com/users/tom-wa/followers","following_url":"https://api.github.com/users/tom-wa/following{/other_user}","gists_url":"https://api.github.com/users/tom-wa/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-wa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-wa/subscriptions","organizations_url":"https://api.github.com/users/tom-wa/orgs","repos_url":"https://api.github.com/users/tom-wa/repos","events_url":"https://api.github.com/users/tom-wa/events{/privacy}","received_events_url":"https://api.github.com/users/tom-wa/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-06-20T12:35:03Z","updated_at":"2016-07-19T23:10:54Z","closed_at":null,"body":"I let shellcheck and checkbashisms check the `shell_recorder.sh`. I fixed the most, but the following are to hardcore for me.\r\n\r\n```\r\n$ checkbashisms -f shell_recorder.sh\r\npossible bashism in shell_recorder.sh line 50 (${parm/?/pat[/str]}):\r\n    command=$(echo ${proto//'$Mountpoint'/$Mountpoint})\r\npossible bashism in shell_recorder.sh line 51 (${parm/?/pat[/str]}):\r\n    command=$(echo ${command//'$File'/$DBFile})\r\npossible bashism in shell_recorder.sh line 52 (${parm/?/pat[/str]}):\r\n    command=$(echo ${command//'$Storage'/$Storage})\r\npossible bashism in shell_recorder.sh line 53 (${parm/?/pat[/str]}):\r\n    command=$(echo ${command//'$MountArgs'/$MountArgs})\r\npossible bashism in shell_recorder.sh line 194 (<<< here string):\r\n        cmd=$(cut -d ' ' -f1 <<< $line)\r\npossible bashism in shell_recorder.sh line 197 (<<< here string):\r\n                Mountpoint=$(cut -d ' ' -f2 <<< $line)\r\npossible bashism in shell_recorder.sh line 200 (<<< here string):\r\n                DBFile=$(cut -d ' ' -f2 <<< $line)\r\npossible bashism in shell_recorder.sh line 203 (<<< here string):\r\n                Storage=$(cut -d ' ' -f2 <<< $line)\r\npossible bashism in shell_recorder.sh line 206 (<<< here string):\r\n                MountArgs=$(cut -d ' ' -f2- <<< $line)\r\npossible bashism in shell_recorder.sh line 209 (<<< here string):\r\n                echo \"$(cut -d ' ' -f2- <<< $line)\"\r\npossible bashism in shell_recorder.sh line 212 (<<< here string):\r\n                DiffType=$(cut -d ' ' -f2 <<< $line)\r\npossible bashism in shell_recorder.sh line 215 (<<< here string):\r\n                RETCMP=$(cut -d ' ' -f2- <<< $line)\r\npossible bashism in shell_recorder.sh line 218 (<<< here string):\r\n                ERRORSCMP=$(cut -d ' ' -f2- <<< $line)\r\npossible bashism in shell_recorder.sh line 221 (<<< here string):\r\n                WARNINGSCMP=$(cut -d ' ' -f2- <<< $line)\r\npossible bashism in shell_recorder.sh line 224 (<<< here string):\r\n                STDOUTCMP=$(cut -d ' ' -f2- <<< $line)\r\npossible bashism in shell_recorder.sh line 227 (<<< here string):\r\n                STDERRCMP=$(cut -d ' ' -f2- <<< $line)\r\npossible bashism in shell_recorder.sh line 230 (<<< here string):\r\n                DIFFCMP=$(cut -d ' ' -f2- <<< $line)\r\npossible bashism in shell_recorder.sh line 234 (<<< here string):\r\n                ARG=$(cut -d ' ' -f2- <<< $line)\r\n```\r\n\r\nand\r\n\r\n```\r\n$ shellcheck shell_recorder.sh\r\nIn shell_recorder.sh line 200:\r\n    while read line;\r\n          ^-- SC2162: read without -r will mangle backslashes.\r\n\r\n\r\nIn shell_recorder.sh line 35:\r\n    proto=\"$@\"\r\n          ^-- SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.\r\n```"},"comment":{"url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/comments/233793882","html_url":"https://github.com/ElektraInitiative/libelektra/issues/807#issuecomment-233793882","issue_url":"https://api.github.com/repos/ElektraInitiative/libelektra/issues/807","id":233793882,"user":{"login":"KurtMi","id":11669591,"avatar_url":"https://avatars.githubusercontent.com/u/11669591?v=3","gravatar_id":"","url":"https://api.github.com/users/KurtMi","html_url":"https://github.com/KurtMi","followers_url":"https://api.github.com/users/KurtMi/followers","following_url":"https://api.github.com/users/KurtMi/following{/other_user}","gists_url":"https://api.github.com/users/KurtMi/gists{/gist_id}","starred_url":"https://api.github.com/users/KurtMi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurtMi/subscriptions","organizations_url":"https://api.github.com/users/KurtMi/orgs","repos_url":"https://api.github.com/users/KurtMi/repos","events_url":"https://api.github.com/users/KurtMi/events{/privacy}","received_events_url":"https://api.github.com/users/KurtMi/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T23:10:54Z","updated_at":"2016-07-19T23:10:54Z","body":"I think `shellcheck` has some issues, but please wait till #806 is merged or work from my branch."}}
{"actor":{"display_login":"KurtMi"}}