{"action":"created","issue":{"url":"https://api.github.com/repos/softdevteam/krun/issues/293","repository_url":"https://api.github.com/repos/softdevteam/krun","labels_url":"https://api.github.com/repos/softdevteam/krun/issues/293/labels{/name}","comments_url":"https://api.github.com/repos/softdevteam/krun/issues/293/comments","events_url":"https://api.github.com/repos/softdevteam/krun/issues/293/events","html_url":"https://github.com/softdevteam/krun/pull/293","id":194983480,"number":293,"title":"Dump results earlier, so that the post-execution hooks see new results.","user":{"login":"vext01","id":604955,"avatar_url":"https://avatars.githubusercontent.com/u/604955?v=3","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"assignees":[{"login":"ltratt","id":20318,"avatar_url":"https://avatars.githubusercontent.com/u/20318?v=3","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},{"login":"snim2","id":97674,"avatar_url":"https://avatars.githubusercontent.com/u/97674?v=3","gravatar_id":"","url":"https://api.github.com/users/snim2","html_url":"https://github.com/snim2","followers_url":"https://api.github.com/users/snim2/followers","following_url":"https://api.github.com/users/snim2/following{/other_user}","gists_url":"https://api.github.com/users/snim2/gists{/gist_id}","starred_url":"https://api.github.com/users/snim2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snim2/subscriptions","organizations_url":"https://api.github.com/users/snim2/orgs","repos_url":"https://api.github.com/users/snim2/repos","events_url":"https://api.github.com/users/snim2/events{/privacy}","received_events_url":"https://api.github.com/users/snim2/received_events","type":"User","site_admin":false}],"milestone":null,"comments":23,"created_at":"2016-12-12T14:10:42Z","updated_at":"2016-12-12T16:10:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/softdevteam/krun/pulls/293","html_url":"https://github.com/softdevteam/krun/pull/293","diff_url":"https://github.com/softdevteam/krun/pull/293.diff","patch_url":"https://github.com/softdevteam/krun/pull/293.patch"},"body":"For discussion only at this point.\r\n\r\nThis is a minimal fix to ensure that the results file is up to date at the time of the post-execution commands running.\r\n\r\nThere was talk of the log being confusing since the last entry in an mid-run log file is not: \"reboot in preparation for next exec\". That would entail having the \"i'm rebooting\" message being logged before the post-execution commands have run, which I find a bit confusing, and would require some more involved changes which we would need to consider carefully.\r\n\r\nI think we would be wise to play it safe, and just be aware that the log file you see on bencher2 is at the time of the post-execution hook.\r\n\r\nIf anyone really feels strongly against, we can reconsider.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/softdevteam/krun/issues/comments/266471840","html_url":"https://github.com/softdevteam/krun/pull/293#issuecomment-266471840","issue_url":"https://api.github.com/repos/softdevteam/krun/issues/293","id":266471840,"user":{"login":"vext01","id":604955,"avatar_url":"https://avatars.githubusercontent.com/u/604955?v=3","gravatar_id":"","url":"https://api.github.com/users/vext01","html_url":"https://github.com/vext01","followers_url":"https://api.github.com/users/vext01/followers","following_url":"https://api.github.com/users/vext01/following{/other_user}","gists_url":"https://api.github.com/users/vext01/gists{/gist_id}","starred_url":"https://api.github.com/users/vext01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vext01/subscriptions","organizations_url":"https://api.github.com/users/vext01/orgs","repos_url":"https://api.github.com/users/vext01/repos","events_url":"https://api.github.com/users/vext01/events{/privacy}","received_events_url":"https://api.github.com/users/vext01/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T16:10:24Z","updated_at":"2016-12-12T16:10:24Z","body":"Take a look at this.\r\n\r\nWe now take the reboot count out of the manifest (instead of from the results file) and update it in the same way as the flags. This means have no business writing the results file twice any more.\r\n\r\nSo your typical manifest file looks like this now:\r\n```\r\neta_avail_idx=4                                                              \r\nnum_mails_sent=0000                                                                                      \r\nnum_reboots=00000000                                                                                     \r\nkeys                                                                                                     \r\nO dummy:Java:default-java\r\n...\r\n```\r\n\r\nAfter this, I have one more change to make to to make the manifest parser a little more robust. Separate PR though."}}
{"actor":{"display_login":"vext01"}}