{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/13","id":98796572,"html_url":"https://github.com/Bukashk0zzz/LiipImagineSerializationBundle/pull/13","diff_url":"https://github.com/Bukashk0zzz/LiipImagineSerializationBundle/pull/13.diff","patch_url":"https://github.com/Bukashk0zzz/LiipImagineSerializationBundle/pull/13.patch","issue_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/issues/13","number":13,"state":"open","locked":false,"title":"Fix include no host","user":{"login":"kimwue","id":1220600,"avatar_url":"https://avatars.githubusercontent.com/u/1220600?v=3","gravatar_id":"","url":"https://api.github.com/users/kimwue","html_url":"https://github.com/kimwue","followers_url":"https://api.github.com/users/kimwue/followers","following_url":"https://api.github.com/users/kimwue/following{/other_user}","gists_url":"https://api.github.com/users/kimwue/gists{/gist_id}","starred_url":"https://api.github.com/users/kimwue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimwue/subscriptions","organizations_url":"https://api.github.com/users/kimwue/orgs","repos_url":"https://api.github.com/users/kimwue/repos","events_url":"https://api.github.com/users/kimwue/events{/privacy}","received_events_url":"https://api.github.com/users/kimwue/received_events","type":"User","site_admin":false},"body":"**Issue**: includeHost=false not working for thumbnails generated from filters\r\n(https://github.com/Bukashk0zzz/LiipImagineSerializationBundle/issues/1)\r\n\r\nThe phpunit tests didn't catch this case, as they only checked for \"already stored\" images. I included cases to check for generated images/thumbs. Checks Annotation: for multiple filters specified as array and a single filter as string.\r\n\r\nI didn't find a way to get CacheManager->getBrowserPath to only return the relative path, it always returns the absolute path by default. So my change strips the host and protocol in case includeHost=false.","created_at":"2016-12-20T17:58:52Z","updated_at":"2016-12-20T17:58:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/13/commits","review_comments_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/13/comments","review_comment_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/issues/13/comments","statuses_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/statuses/c6764b226b997c59b3b59f97e5e17f2b6c051f54","head":{"label":"kimwue:fixIncludeNoHost","ref":"fixIncludeNoHost","sha":"c6764b226b997c59b3b59f97e5e17f2b6c051f54","user":{"login":"kimwue","id":1220600,"avatar_url":"https://avatars.githubusercontent.com/u/1220600?v=3","gravatar_id":"","url":"https://api.github.com/users/kimwue","html_url":"https://github.com/kimwue","followers_url":"https://api.github.com/users/kimwue/followers","following_url":"https://api.github.com/users/kimwue/following{/other_user}","gists_url":"https://api.github.com/users/kimwue/gists{/gist_id}","starred_url":"https://api.github.com/users/kimwue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimwue/subscriptions","organizations_url":"https://api.github.com/users/kimwue/orgs","repos_url":"https://api.github.com/users/kimwue/repos","events_url":"https://api.github.com/users/kimwue/events{/privacy}","received_events_url":"https://api.github.com/users/kimwue/received_events","type":"User","site_admin":false},"repo":{"id":76965244,"name":"LiipImagineSerializationBundle","full_name":"kimwue/LiipImagineSerializationBundle","owner":{"login":"kimwue","id":1220600,"avatar_url":"https://avatars.githubusercontent.com/u/1220600?v=3","gravatar_id":"","url":"https://api.github.com/users/kimwue","html_url":"https://github.com/kimwue","followers_url":"https://api.github.com/users/kimwue/followers","following_url":"https://api.github.com/users/kimwue/following{/other_user}","gists_url":"https://api.github.com/users/kimwue/gists{/gist_id}","starred_url":"https://api.github.com/users/kimwue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimwue/subscriptions","organizations_url":"https://api.github.com/users/kimwue/orgs","repos_url":"https://api.github.com/users/kimwue/repos","events_url":"https://api.github.com/users/kimwue/events{/privacy}","received_events_url":"https://api.github.com/users/kimwue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kimwue/LiipImagineSerializationBundle","description":"Provides integration between LiipImagineBundle and JMSSerializerBundle","fork":true,"url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle","forks_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/forks","keys_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/teams","hooks_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/hooks","issue_events_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/issues/events{/number}","events_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/events","assignees_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/assignees{/user}","branches_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/branches{/branch}","tags_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/tags","blobs_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/languages","stargazers_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/stargazers","contributors_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/contributors","subscribers_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/subscribers","subscription_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/subscription","commits_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/contents/{+path}","compare_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/merges","archive_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/downloads","issues_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/issues{/number}","pulls_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/labels{/name}","releases_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/releases{/id}","deployments_url":"https://api.github.com/repos/kimwue/LiipImagineSerializationBundle/deployments","created_at":"2016-12-20T14:53:02Z","updated_at":"2016-12-20T14:53:06Z","pushed_at":"2016-12-20T17:47:05Z","git_url":"git://github.com/kimwue/LiipImagineSerializationBundle.git","ssh_url":"git@github.com:kimwue/LiipImagineSerializationBundle.git","clone_url":"https://github.com/kimwue/LiipImagineSerializationBundle.git","svn_url":"https://github.com/kimwue/LiipImagineSerializationBundle","homepage":null,"size":39,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bukashk0zzz:master","ref":"master","sha":"b589a23968676a9b1180d95852cd2f7f1ff7ceaa","user":{"login":"Bukashk0zzz","id":1908342,"avatar_url":"https://avatars.githubusercontent.com/u/1908342?v=3","gravatar_id":"","url":"https://api.github.com/users/Bukashk0zzz","html_url":"https://github.com/Bukashk0zzz","followers_url":"https://api.github.com/users/Bukashk0zzz/followers","following_url":"https://api.github.com/users/Bukashk0zzz/following{/other_user}","gists_url":"https://api.github.com/users/Bukashk0zzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Bukashk0zzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bukashk0zzz/subscriptions","organizations_url":"https://api.github.com/users/Bukashk0zzz/orgs","repos_url":"https://api.github.com/users/Bukashk0zzz/repos","events_url":"https://api.github.com/users/Bukashk0zzz/events{/privacy}","received_events_url":"https://api.github.com/users/Bukashk0zzz/received_events","type":"User","site_admin":false},"repo":{"id":53334450,"name":"LiipImagineSerializationBundle","full_name":"Bukashk0zzz/LiipImagineSerializationBundle","owner":{"login":"Bukashk0zzz","id":1908342,"avatar_url":"https://avatars.githubusercontent.com/u/1908342?v=3","gravatar_id":"","url":"https://api.github.com/users/Bukashk0zzz","html_url":"https://github.com/Bukashk0zzz","followers_url":"https://api.github.com/users/Bukashk0zzz/followers","following_url":"https://api.github.com/users/Bukashk0zzz/following{/other_user}","gists_url":"https://api.github.com/users/Bukashk0zzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Bukashk0zzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bukashk0zzz/subscriptions","organizations_url":"https://api.github.com/users/Bukashk0zzz/orgs","repos_url":"https://api.github.com/users/Bukashk0zzz/repos","events_url":"https://api.github.com/users/Bukashk0zzz/events{/privacy}","received_events_url":"https://api.github.com/users/Bukashk0zzz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bukashk0zzz/LiipImagineSerializationBundle","description":"Provides integration between LiipImagineBundle and JMSSerializerBundle","fork":false,"url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle","forks_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/forks","keys_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/teams","hooks_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/hooks","issue_events_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/issues/events{/number}","events_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/events","assignees_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/assignees{/user}","branches_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/branches{/branch}","tags_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/tags","blobs_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/languages","stargazers_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/stargazers","contributors_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/contributors","subscribers_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/subscribers","subscription_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/subscription","commits_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/contents/{+path}","compare_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/merges","archive_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/downloads","issues_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/issues{/number}","pulls_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/labels{/name}","releases_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/releases{/id}","deployments_url":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/deployments","created_at":"2016-03-07T15:06:47Z","updated_at":"2016-11-04T16:34:48Z","pushed_at":"2016-11-04T13:48:29Z","git_url":"git://github.com/Bukashk0zzz/LiipImagineSerializationBundle.git","ssh_url":"git@github.com:Bukashk0zzz/LiipImagineSerializationBundle.git","clone_url":"https://github.com/Bukashk0zzz/LiipImagineSerializationBundle.git","svn_url":"https://github.com/Bukashk0zzz/LiipImagineSerializationBundle","homepage":null,"size":39,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/13"},"html":{"href":"https://github.com/Bukashk0zzz/LiipImagineSerializationBundle/pull/13"},"issue":{"href":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/issues/13"},"comments":{"href":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/Bukashk0zzz/LiipImagineSerializationBundle/statuses/c6764b226b997c59b3b59f97e5e17f2b6c051f54"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":102,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"kimwue"}}