{"push_id":956794399,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"ed6b7232e4c771c3136e2ade9339453a2969df5e","before":"aed54d71aad92c60a684f21e30e90bd2f4d9cc7f","commits":[{"sha":"ed6b7232e4c771c3136e2ade9339453a2969df5e","author":{"email":"c0f02d98506190746d1cdcb01be0f37b51e27077@chromium.org","name":"thakis"},"message":"Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (patchset #4 id:400001 of https://codereview.chromium.org/1534583002/ )\n\nReason for revert:\nDoesn't build on the 'all' builders:\n\n..\\..\\chrome\\tools\\service_discovery_sniffer\\service_discovery_sniffer.cc(60,26)\n:  error: invalid operands to binary expression ('const net::IPAddress' and\n'net::IPAddressNumber' (aka 'vector<unsigned char>'))\n  if (service.ip_address != net::IPAddressNumber()) {\n      ~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~\n..\\..\\chrome\\tools\\service_discovery_sniffer\\service_discovery_sniffer.cc(61,34)\n:  error: no matching function for call to 'IPAddressToString'\n    printf(\"\\tIP Address: %s\\n\", net::IPAddressToString(\n                                 ^~~~~~~~~~~~~~~~~~~~~~\n..\\..\\net/base/ip_address_number.h(51,24) :  note: candidate function not\nviable: no known conversion from 'const net::IPAddress' to 'const\nIPAddressNumber' (aka 'const vector<unsigned char>') for 1st argument\nNET_EXPORT std::string IPAddressToString(const IPAddressNumber& addr);\n                       ^\n..\\..\\net/base/ip_address_number.h(41,24) :  note: candidate function not\nviable: requires 2 arguments, but 1 was provided\nNET_EXPORT std::string IPAddressToString(const uint8_t* address,\n\nhttps://build.chromium.org/p/chromium/builders/Linux%20x64/builds/14840/steps/compile/logs/stdio\n\nOriginal issue's description:\n> This CL migrates Local Discovery from net::IPAddressNumber to net::IPAddress.\n>\n> This CL is part of the net::IPAddressNumber migration[1].\n>\n> BUG=496258\n>\n> [1] https://code.google.com/p/chromium/issues/detail?id=496258#c10\n>\n> Committed: https://crrev.com/aed54d71aad92c60a684f21e30e90bd2f4d9cc7f\n> Cr-Commit-Position: refs/heads/master@{#372550}\n\nTBR=dgozman@chromium.org,eroman@chromium.org,vitalybuka@chromium.org,martijn@martijnc.be\n# Skipping CQ checks because original CL landed less than 1 days ago.\nNOPRESUBMIT=true\nNOTREECHECKS=true\nNOTRY=true\nBUG=496258\n\nReview URL: https://codereview.chromium.org/1653573003\n\nCr-Commit-Position: refs/heads/master@{#372551}","distinct":true,"url":"https://api.github.com/repos/dstockwell/chromium/commits/ed6b7232e4c771c3136e2ade9339453a2969df5e"}]}