{"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/72160865","id":72160865,"diff_hunk":"@@ -402,14 +523,50 @@\n \t\t<ContactGeometrySet>\n \t\t\t<objects>\n \t\t\t\t<ContactHalfSpace name=\"floor\">\n-\t\t\t\t\t<!--Body name to connect the contact geometry to-->\n-\t\t\t\t\t<body_name>ground</body_name>\n-\t\t\t\t\t<!--Location of geometry center in the body frame-->\n+\t\t\t\t\t<!--List of connectors (structural dependencies) that this component has.-->\n+\t\t\t\t\t<connectors>\n+\t\t\t\t\t\t<Connector_PhysicalFrame_ name=\"frame\">\n+\t\t\t\t\t\t\t<!--Name of the component this Connector should be connected to.-->\n+\t\t\t\t\t\t\t<connectee_name>../ground</connectee_name>\n+\t\t\t\t\t\t</Connector_PhysicalFrame_>\n+\t\t\t\t\t</connectors>\n+\t\t\t\t\t<!--Location of geometry center in the PhysicalFrame.-->\n \t\t\t\t\t<location>0 0 0</location>\n-\t\t\t\t\t<!--Orientation of geometry in the body frame-->\n-\t\t\t\t\t<orientation>0 0 -1.5707963267949</orientation>\n+\t\t\t\t\t<!--Orientation of geometry in the PhysicalFrame (body-fixed XYZ Euler angles).-->\n+\t\t\t\t\t<orientation>0 0 -1.5707963267949001</orientation>\n \t\t\t\t</ContactHalfSpace>\n-\t\t\t</objects>\n+        <ContactMesh name=\"blockMesh\">\n+          <!--List of connectors (structural dependencies) that this component has.-->\n+          <connectors>\n+            <Connector_PhysicalFrame_ name=\"frame\">\n+              <!--Name of the component this Connector should be connected to.-->\n+              <connectee_name>block</connectee_name>\n+            </Connector_PhysicalFrame_>\n+          </connectors>\n+          <!--List of components that this component owns and serializes.-->\n+          <components />\n+          <!--Location of geometry center in the PhysicalFrame.-->\n+          <location>0 0 0</location>\n+          <!--Orientation of geometry in the PhysicalFrame (body-fixed XYZ Euler angles).-->\n+          <orientation>0 0 0</orientation>\n+          <!--Default appearance for this Geometry-->\n+          <Appearance>\n+            <!--Flag indicating whether the associated Geometry is visible or hidden.-->\n+            <visible>true</visible>\n+            <!--The opacity used to display the geometry between 0:transparent, 1:opaque.-->\n+            <opacity>1</opacity>\n+            <!--The color, (red, green, blue), [0, 1], used to display the geometry. -->\n+            <color>0 1 1</color>\n+            <!--Visuals applied to surfaces associated with this Appearance.-->\n+            <SurfaceProperties>\n+              <!--The representation (1:Points, 2:Wire, 3:Shaded) used to display the object.-->\n+              <representation>2</representation>\n+            </SurfaceProperties>\n+          </Appearance>","path":"OpenSim/Tools/Test/BuiltinGeometry.osim","position":640,"original_position":640,"commit_id":"a87b00cd8f4f0cad11c942ebac3427d248772cfc","original_commit_id":"a87b00cd8f4f0cad11c942ebac3427d248772cfc","user":{"login":"aseth1","id":6494122,"avatar_url":"https://avatars.githubusercontent.com/u/6494122?v=3","gravatar_id":"","url":"https://api.github.com/users/aseth1","html_url":"https://github.com/aseth1","followers_url":"https://api.github.com/users/aseth1/followers","following_url":"https://api.github.com/users/aseth1/following{/other_user}","gists_url":"https://api.github.com/users/aseth1/gists{/gist_id}","starred_url":"https://api.github.com/users/aseth1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aseth1/subscriptions","organizations_url":"https://api.github.com/users/aseth1/orgs","repos_url":"https://api.github.com/users/aseth1/repos","events_url":"https://api.github.com/users/aseth1/events{/privacy}","received_events_url":"https://api.github.com/users/aseth1/received_events","type":"User","site_admin":false},"body":"Is it that we only see Appearance for the first time here in the model file because it is the only changed appearance (others are all property value default so do not appear)? Or is it that only ContactGeometry Mesh has an Appearance? The test should verify the effect of Appearance on Geometry.","created_at":"2016-07-25T23:01:27Z","updated_at":"2016-07-25T23:01:27Z","html_url":"https://github.com/opensim-org/opensim-core/pull/1122#discussion_r72160865","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/72160865"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/1122#discussion_r72160865"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122","id":77513121,"html_url":"https://github.com/opensim-org/opensim-core/pull/1122","diff_url":"https://github.com/opensim-org/opensim-core/pull/1122.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/1122.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1122","number":1122,"state":"open","locked":false,"title":"Visualize wrap objects and contact geometry","user":{"login":"aymanhab","id":3972208,"avatar_url":"https://avatars.githubusercontent.com/u/3972208?v=3","gravatar_id":"","url":"https://api.github.com/users/aymanhab","html_url":"https://github.com/aymanhab","followers_url":"https://api.github.com/users/aymanhab/followers","following_url":"https://api.github.com/users/aymanhab/following{/other_user}","gists_url":"https://api.github.com/users/aymanhab/gists{/gist_id}","starred_url":"https://api.github.com/users/aymanhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymanhab/subscriptions","organizations_url":"https://api.github.com/users/aymanhab/orgs","repos_url":"https://api.github.com/users/aymanhab/repos","events_url":"https://api.github.com/users/aymanhab/events{/privacy}","received_events_url":"https://api.github.com/users/aymanhab/received_events","type":"User","site_admin":false},"body":"This PR allows WrapObjects and ContactMeshes to be visualized in API visualizer and GUI and also associate an Appearance Object to control the display instead of the old ad-hoc preference and color properties.","created_at":"2016-07-14T19:39:08Z","updated_at":"2016-07-25T23:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0626447f59ab636c30b7dd629ea5fa001cce1986","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/1122/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/a87b00cd8f4f0cad11c942ebac3427d248772cfc","head":{"label":"opensim-org:visualize_wrap_contact","ref":"visualize_wrap_contact","sha":"a87b00cd8f4f0cad11c942ebac3427d248772cfc","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-core/deployments","created_at":"2014-06-12T16:57:56Z","updated_at":"2016-07-13T09:12:50Z","pushed_at":"2016-07-25T19:28:24Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"https://opensim.stanford.edu","size":153614,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":333,"forks":42,"open_issues":333,"watchers":34,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"4399a7962e72215a74a93aa2eb7b206de86d5382","user":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"name":"opensim-core","full_name":"opensim-org/opensim-core","owner":{"login":"opensim-org","id":4370782,"avatar_url":"https://avatars.githubusercontent.com/u/4370782?v=3","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-core/deployments","created_at":"2014-06-12T16:57:56Z","updated_at":"2016-07-13T09:12:50Z","pushed_at":"2016-07-25T19:28:24Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"https://opensim.stanford.edu","size":153614,"stargazers_count":34,"watchers_count":34,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":333,"forks":42,"open_issues":333,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/1122"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/1122"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/1122/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/1122/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-core/statuses/a87b00cd8f4f0cad11c942ebac3427d248772cfc"}}}}
{"actor":{"display_login":"aseth1"}}