{"action":"created","issue":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3504","repository_url":"https://api.github.com/repos/Beep6581/RawTherapee","labels_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3504/labels{/name}","comments_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3504/comments","events_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3504/events","html_url":"https://github.com/Beep6581/RawTherapee/pull/3504","id":188081682,"number":3504,"title":"Fix some Clang warnings reported by @Partha1b","user":{"login":"Floessie","id":10133457,"avatar_url":"https://avatars.githubusercontent.com/u/10133457?v=3","gravatar_id":"","url":"https://api.github.com/users/Floessie","html_url":"https://github.com/Floessie","followers_url":"https://api.github.com/users/Floessie/followers","following_url":"https://api.github.com/users/Floessie/following{/other_user}","gists_url":"https://api.github.com/users/Floessie/gists{/gist_id}","starred_url":"https://api.github.com/users/Floessie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Floessie/subscriptions","organizations_url":"https://api.github.com/users/Floessie/orgs","repos_url":"https://api.github.com/users/Floessie/repos","events_url":"https://api.github.com/users/Floessie/events{/privacy}","received_events_url":"https://api.github.com/users/Floessie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-11-08T19:29:06Z","updated_at":"2016-11-09T13:09:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/pulls/3504","html_url":"https://github.com/Beep6581/RawTherapee/pull/3504","diff_url":"https://github.com/Beep6581/RawTherapee/pull/3504.diff","patch_url":"https://github.com/Beep6581/RawTherapee/pull/3504.patch"},"body":"This is a follow-up branch to #3501. @Partha1b provided us with some more warnings, two of which (the most imminent) are fixed here."},"comment":{"url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/comments/259410754","html_url":"https://github.com/Beep6581/RawTherapee/pull/3504#issuecomment-259410754","issue_url":"https://api.github.com/repos/Beep6581/RawTherapee/issues/3504","id":259410754,"user":{"login":"Floessie","id":10133457,"avatar_url":"https://avatars.githubusercontent.com/u/10133457?v=3","gravatar_id":"","url":"https://api.github.com/users/Floessie","html_url":"https://github.com/Floessie","followers_url":"https://api.github.com/users/Floessie/followers","following_url":"https://api.github.com/users/Floessie/following{/other_user}","gists_url":"https://api.github.com/users/Floessie/gists{/gist_id}","starred_url":"https://api.github.com/users/Floessie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Floessie/subscriptions","organizations_url":"https://api.github.com/users/Floessie/orgs","repos_url":"https://api.github.com/users/Floessie/repos","events_url":"https://api.github.com/users/Floessie/events{/privacy}","received_events_url":"https://api.github.com/users/Floessie/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T13:09:11Z","updated_at":"2016-11-09T13:09:11Z","body":"@heckflosse \r\n> In this case 1 has to be added to is_raw (because is_raw is the number of raw frames) which is what the above code does. Typical dcraw code ;)\r\n\r\n:frowning: Oh well... Must be the C way of writing `+= bool(get4())`. Thanks for your explanation. I thought it had one `&` too much.\r\n\r\n@Partha1b \r\n> Yes, I agree that most are uncritical. Hopefully in the future, we can take care of these warnings. :)\r\n\r\nI'll fix `procparams.h` tonight, but leave `dcraw.cc` and the missing `enum` value as is.\r\n\r\n> (As an aside, I'll comment on the main branch about launching of external programs if I may.)\r\n\r\nPlease do so (preferably in a new issue)."}}
{"actor":{"display_login":"Floessie"}}