{"action":"created","comment":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/72537545","id":72537545,"diff_hunk":"@@ -2645,6 +2645,9 @@ object Types {\n       if (ctx.period != validSuper) {\n         cachedSuper = tycon match {\n           case tp: TypeLambda => defn.AnyType\n+          case tp: TypeVar =>\n+            // supertype not stable, since underlying might change","path":"src/dotty/tools/dotc/core/Types.scala","position":null,"original_position":5,"commit_id":"04e6d5e5ad39d046a977de1bfd4563287e5b0f41","original_commit_id":"16a688fb24b2926aad47e2977444e0b9249db50b","user":{"login":"odersky","id":795990,"avatar_url":"https://avatars.githubusercontent.com/u/795990?v=3","gravatar_id":"","url":"https://api.github.com/users/odersky","html_url":"https://github.com/odersky","followers_url":"https://api.github.com/users/odersky/followers","following_url":"https://api.github.com/users/odersky/following{/other_user}","gists_url":"https://api.github.com/users/odersky/gists{/gist_id}","starred_url":"https://api.github.com/users/odersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odersky/subscriptions","organizations_url":"https://api.github.com/users/odersky/orgs","repos_url":"https://api.github.com/users/odersky/repos","events_url":"https://api.github.com/users/odersky/events{/privacy}","received_events_url":"https://api.github.com/users/odersky/received_events","type":"User","site_admin":false},"body":"Good point. Fixed in latest commit.\r\n","created_at":"2016-07-27T22:39:08Z","updated_at":"2016-07-27T22:39:08Z","html_url":"https://github.com/lampepfl/dotty/pull/1289#discussion_r72537545","pull_request_url":"https://api.github.com/repos/lampepfl/dotty/pulls/1289","_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments/72537545"},"html":{"href":"https://github.com/lampepfl/dotty/pull/1289#discussion_r72537545"},"pull_request":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1289"}}},"pull_request":{"url":"https://api.github.com/repos/lampepfl/dotty/pulls/1289","id":72109333,"html_url":"https://github.com/lampepfl/dotty/pull/1289","diff_url":"https://github.com/lampepfl/dotty/pull/1289.diff","patch_url":"https://github.com/lampepfl/dotty/pull/1289.patch","issue_url":"https://api.github.com/repos/lampepfl/dotty/issues/1289","number":1289,"state":"open","locked":false,"title":"partest: Enable separate compilation","user":{"login":"smarter","id":63430,"avatar_url":"https://avatars.githubusercontent.com/u/63430?v=3","gravatar_id":"","url":"https://api.github.com/users/smarter","html_url":"https://github.com/smarter","followers_url":"https://api.github.com/users/smarter/followers","following_url":"https://api.github.com/users/smarter/following{/other_user}","gists_url":"https://api.github.com/users/smarter/gists{/gist_id}","starred_url":"https://api.github.com/users/smarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarter/subscriptions","organizations_url":"https://api.github.com/users/smarter/orgs","repos_url":"https://api.github.com/users/smarter/repos","events_url":"https://api.github.com/users/smarter/events{/privacy}","received_events_url":"https://api.github.com/users/smarter/received_events","type":"User","site_admin":false},"body":"partest can separately compile files based on their suffix (_1, _2,\r\n...), it turns out that this feature was never enabled in the dotty\r\nversion of partest and no one noticed (it prints warnings in\r\n./tests/partest-generated/gen.log which no one reads).\r\n\r\nEnabling this revealed some latent separate compilation bugs that will need to\r\nbe fixed in the next few commits.\r\n\r\nThere are four (edit: actually more than that) test failures after this commit: https://gist.github.com/smarter/5cfff93170dae8864b9920e0d0398b63\r\n\r\nI don't know if I'll have time to look at all of them, so it would be nice if people could assign themselves (ping @DarkDimius, @felixmulder, @liufengyun, @odersky, @VladimirNik) to try to fix one of them and push it to this PR (you can edit this issue to assign yourself):\r\n- [x] `t1751` and `t294`\r\n  - Assignee: @smarter\r\n   - These are the same issue related to inference and Java annotations:\r\n    ```scala\r\nerror: none of the overloaded alternatives of constructor SuiteClasses in class SuiteClasses with types\r\n (value: Class[_]*)SuiteClasses\r\n (value: Array[Class[_]])SuiteClasses\r\nmatch arguments (Array[Nothing])\r\n@SuiteClasses(Array())\r\n^\r\n```\r\n- [X] `colltest5`\r\n  - Assignee: @smarter\r\n   - The value class `StringOps` has an overloaded method `++`, we replace overloading by numbers in the corresponding extension methods (`$extension0`, `$extension1`, ...) to avoid dealing with overloading after Typer (I'm no longer a fan of that scheme that we copied from scalac and considered replacing it by overloading). It seems to have gone wrong here (we emitted `$plus$plus$extension0(String, String)` when compiling the first file but when compiling the second file we looked for  `$plus$plus$extension1(String, String)`:\r\n   ```scala\r\njava.lang.NoSuchMethodError: strawman.collections.CollectionStrawMan5$StringOps$.$plus$plus$extension1(Ljava/lang/String;Ljava/lang/String;)Ljava/lang/String;\r\n```\r\n- [X] `t7859`\r\n  - Assignee: @VladimirNik \r\n  - The getter of `x` in the value class `A` should not be `private` because we need to access it from separate compilation units to unbox the value class:\r\n  ```scala\r\njava.lang.AssertionError: assertion failed: private getter x in class A in /home/smarter/opt/dotty/tests/partest-generated/run/t7859/A_1.scala accessed from value a in /home/smarter/opt/dotty/tests/partest-generated/run/t7859/B_2.scala\r\n        at scala.Predef$.assert(Predef.scala:165)\r\n        at dotty.tools.dotc.transform.ExpandPrivate.ensurePrivateAccessible(ExpandPrivate.scala:75)\r\n```\r\n- [X] `t1186, t1235, t1254, t1642`\r\n  - Assignee: @smarter\r\n  - The classpath used for javac is incorrect\r\n- [X] `volatile`\r\n  - Assignee: @smarter\r\n  - java filename should match public class name to make javac happy\r\n- `t1263, t1745`\r\n  - Assignee: ...\r\n  - Emitted classfiles do not contain type parameter information used by javac, see #1303, moved to pending for now\r\n- [x] `colltest4`\r\n  - Assignee: @felixmulder\r\n  - There is a bug in `CollectionStrawMan4`:\r\n  ```scala\r\n  object ListBuffer extends IterableFactory[ListBuffer] {\r\n    def fromIterable[B](coll: Iterable[B]): ListBuffer[B] = coll match {\r\n      case pd @ View.Partitioned(partition: View.Partition[B]) =>\r\n        partition.distribute(new ListBuffer[B]())\r\n        pd.forced.get.asInstanceOf[ListBuffer[B]]\r\n```\r\n  The cast is wrong, `pd.forced.get` returns a `List`, not a `ListBuffer`, this should be fixed both in `./tests/run/colltest4/CollectionStrawMan4_1.scala` and `./src/strawman/collections/CollectionStrawMan4.scala`, stacktrace: https://gist.github.com/smarter/5aab6857a20b0979b2909355171ab341\r\n- [x] `t0288`\r\n  - Assignee: @odersky \r\n  - This one seems tricky: it's a stale symbol error on the second run of dotty, the symbol is `test$Outer$Inner$$$outer` which is weird because Outer.Inner is a java inner class so it doesn't have an `$outer` field, someone familiar with how we deal with outer accessors should have a look.","created_at":"2016-06-01T01:09:35Z","updated_at":"2016-07-27T22:39:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e06ce3670581ebcd8c63bb7729eb9d5dc37f184e","assignee":{"login":"odersky","id":795990,"avatar_url":"https://avatars.githubusercontent.com/u/795990?v=3","gravatar_id":"","url":"https://api.github.com/users/odersky","html_url":"https://github.com/odersky","followers_url":"https://api.github.com/users/odersky/followers","following_url":"https://api.github.com/users/odersky/following{/other_user}","gists_url":"https://api.github.com/users/odersky/gists{/gist_id}","starred_url":"https://api.github.com/users/odersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odersky/subscriptions","organizations_url":"https://api.github.com/users/odersky/orgs","repos_url":"https://api.github.com/users/odersky/repos","events_url":"https://api.github.com/users/odersky/events{/privacy}","received_events_url":"https://api.github.com/users/odersky/received_events","type":"User","site_admin":false},"assignees":[{"login":"odersky","id":795990,"avatar_url":"https://avatars.githubusercontent.com/u/795990?v=3","gravatar_id":"","url":"https://api.github.com/users/odersky","html_url":"https://github.com/odersky","followers_url":"https://api.github.com/users/odersky/followers","following_url":"https://api.github.com/users/odersky/following{/other_user}","gists_url":"https://api.github.com/users/odersky/gists{/gist_id}","starred_url":"https://api.github.com/users/odersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odersky/subscriptions","organizations_url":"https://api.github.com/users/odersky/orgs","repos_url":"https://api.github.com/users/odersky/repos","events_url":"https://api.github.com/users/odersky/events{/privacy}","received_events_url":"https://api.github.com/users/odersky/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lampepfl/dotty/pulls/1289/commits","review_comments_url":"https://api.github.com/repos/lampepfl/dotty/pulls/1289/comments","review_comment_url":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lampepfl/dotty/issues/1289/comments","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/04e6d5e5ad39d046a977de1bfd4563287e5b0f41","head":{"label":"dotty-staging:fix/partest-separate","ref":"fix/partest-separate","sha":"04e6d5e5ad39d046a977de1bfd4563287e5b0f41","user":{"login":"dotty-staging","id":6998674,"avatar_url":"https://avatars.githubusercontent.com/u/6998674?v=3","gravatar_id":"","url":"https://api.github.com/users/dotty-staging","html_url":"https://github.com/dotty-staging","followers_url":"https://api.github.com/users/dotty-staging/followers","following_url":"https://api.github.com/users/dotty-staging/following{/other_user}","gists_url":"https://api.github.com/users/dotty-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/dotty-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotty-staging/subscriptions","organizations_url":"https://api.github.com/users/dotty-staging/orgs","repos_url":"https://api.github.com/users/dotty-staging/repos","events_url":"https://api.github.com/users/dotty-staging/events{/privacy}","received_events_url":"https://api.github.com/users/dotty-staging/received_events","type":"Organization","site_admin":false},"repo":{"id":17904384,"name":"dotty","full_name":"dotty-staging/dotty","owner":{"login":"dotty-staging","id":6998674,"avatar_url":"https://avatars.githubusercontent.com/u/6998674?v=3","gravatar_id":"","url":"https://api.github.com/users/dotty-staging","html_url":"https://github.com/dotty-staging","followers_url":"https://api.github.com/users/dotty-staging/followers","following_url":"https://api.github.com/users/dotty-staging/following{/other_user}","gists_url":"https://api.github.com/users/dotty-staging/gists{/gist_id}","starred_url":"https://api.github.com/users/dotty-staging/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotty-staging/subscriptions","organizations_url":"https://api.github.com/users/dotty-staging/orgs","repos_url":"https://api.github.com/users/dotty-staging/repos","events_url":"https://api.github.com/users/dotty-staging/events{/privacy}","received_events_url":"https://api.github.com/users/dotty-staging/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotty-staging/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":true,"url":"https://api.github.com/repos/dotty-staging/dotty","forks_url":"https://api.github.com/repos/dotty-staging/dotty/forks","keys_url":"https://api.github.com/repos/dotty-staging/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotty-staging/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotty-staging/dotty/teams","hooks_url":"https://api.github.com/repos/dotty-staging/dotty/hooks","issue_events_url":"https://api.github.com/repos/dotty-staging/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/dotty-staging/dotty/events","assignees_url":"https://api.github.com/repos/dotty-staging/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/dotty-staging/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/dotty-staging/dotty/tags","blobs_url":"https://api.github.com/repos/dotty-staging/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotty-staging/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotty-staging/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotty-staging/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotty-staging/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/dotty-staging/dotty/languages","stargazers_url":"https://api.github.com/repos/dotty-staging/dotty/stargazers","contributors_url":"https://api.github.com/repos/dotty-staging/dotty/contributors","subscribers_url":"https://api.github.com/repos/dotty-staging/dotty/subscribers","subscription_url":"https://api.github.com/repos/dotty-staging/dotty/subscription","commits_url":"https://api.github.com/repos/dotty-staging/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotty-staging/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotty-staging/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotty-staging/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotty-staging/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/dotty-staging/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotty-staging/dotty/merges","archive_url":"https://api.github.com/repos/dotty-staging/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotty-staging/dotty/downloads","issues_url":"https://api.github.com/repos/dotty-staging/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/dotty-staging/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/dotty-staging/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/dotty-staging/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotty-staging/dotty/labels{/name}","releases_url":"https://api.github.com/repos/dotty-staging/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/dotty-staging/dotty/deployments","created_at":"2014-03-19T13:06:15Z","updated_at":"2016-07-11T14:41:18Z","pushed_at":"2016-07-27T22:38:14Z","git_url":"git://github.com/dotty-staging/dotty.git","ssh_url":"git@github.com:dotty-staging/dotty.git","clone_url":"https://github.com/dotty-staging/dotty.git","svn_url":"https://github.com/dotty-staging/dotty","homepage":"","size":20059,"stargazers_count":4,"watchers_count":4,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"lampepfl:master","ref":"master","sha":"5ffce6e910f4cc1fced15824df86a9524be81681","user":{"login":"lampepfl","id":2684793,"avatar_url":"https://avatars.githubusercontent.com/u/2684793?v=3","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"repo":{"id":7035651,"name":"dotty","full_name":"lampepfl/dotty","owner":{"login":"lampepfl","id":2684793,"avatar_url":"https://avatars.githubusercontent.com/u/2684793?v=3","gravatar_id":"","url":"https://api.github.com/users/lampepfl","html_url":"https://github.com/lampepfl","followers_url":"https://api.github.com/users/lampepfl/followers","following_url":"https://api.github.com/users/lampepfl/following{/other_user}","gists_url":"https://api.github.com/users/lampepfl/gists{/gist_id}","starred_url":"https://api.github.com/users/lampepfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lampepfl/subscriptions","organizations_url":"https://api.github.com/users/lampepfl/orgs","repos_url":"https://api.github.com/users/lampepfl/repos","events_url":"https://api.github.com/users/lampepfl/events{/privacy}","received_events_url":"https://api.github.com/users/lampepfl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lampepfl/dotty","description":"Research platform for new language concepts and compiler technologies for Scala.","fork":false,"url":"https://api.github.com/repos/lampepfl/dotty","forks_url":"https://api.github.com/repos/lampepfl/dotty/forks","keys_url":"https://api.github.com/repos/lampepfl/dotty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lampepfl/dotty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lampepfl/dotty/teams","hooks_url":"https://api.github.com/repos/lampepfl/dotty/hooks","issue_events_url":"https://api.github.com/repos/lampepfl/dotty/issues/events{/number}","events_url":"https://api.github.com/repos/lampepfl/dotty/events","assignees_url":"https://api.github.com/repos/lampepfl/dotty/assignees{/user}","branches_url":"https://api.github.com/repos/lampepfl/dotty/branches{/branch}","tags_url":"https://api.github.com/repos/lampepfl/dotty/tags","blobs_url":"https://api.github.com/repos/lampepfl/dotty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lampepfl/dotty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lampepfl/dotty/git/refs{/sha}","trees_url":"https://api.github.com/repos/lampepfl/dotty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lampepfl/dotty/statuses/{sha}","languages_url":"https://api.github.com/repos/lampepfl/dotty/languages","stargazers_url":"https://api.github.com/repos/lampepfl/dotty/stargazers","contributors_url":"https://api.github.com/repos/lampepfl/dotty/contributors","subscribers_url":"https://api.github.com/repos/lampepfl/dotty/subscribers","subscription_url":"https://api.github.com/repos/lampepfl/dotty/subscription","commits_url":"https://api.github.com/repos/lampepfl/dotty/commits{/sha}","git_commits_url":"https://api.github.com/repos/lampepfl/dotty/git/commits{/sha}","comments_url":"https://api.github.com/repos/lampepfl/dotty/comments{/number}","issue_comment_url":"https://api.github.com/repos/lampepfl/dotty/issues/comments{/number}","contents_url":"https://api.github.com/repos/lampepfl/dotty/contents/{+path}","compare_url":"https://api.github.com/repos/lampepfl/dotty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lampepfl/dotty/merges","archive_url":"https://api.github.com/repos/lampepfl/dotty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lampepfl/dotty/downloads","issues_url":"https://api.github.com/repos/lampepfl/dotty/issues{/number}","pulls_url":"https://api.github.com/repos/lampepfl/dotty/pulls{/number}","milestones_url":"https://api.github.com/repos/lampepfl/dotty/milestones{/number}","notifications_url":"https://api.github.com/repos/lampepfl/dotty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lampepfl/dotty/labels{/name}","releases_url":"https://api.github.com/repos/lampepfl/dotty/releases{/id}","deployments_url":"https://api.github.com/repos/lampepfl/dotty/deployments","created_at":"2012-12-06T12:57:33Z","updated_at":"2016-07-27T19:38:16Z","pushed_at":"2016-07-27T22:38:14Z","git_url":"git://github.com/lampepfl/dotty.git","ssh_url":"git@github.com:lampepfl/dotty.git","clone_url":"https://github.com/lampepfl/dotty.git","svn_url":"https://github.com/lampepfl/dotty","homepage":"","size":26129,"stargazers_count":1146,"watchers_count":1146,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":174,"forks":148,"open_issues":174,"watchers":1146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1289"},"html":{"href":"https://github.com/lampepfl/dotty/pull/1289"},"issue":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/1289"},"comments":{"href":"https://api.github.com/repos/lampepfl/dotty/issues/1289/comments"},"review_comments":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1289/comments"},"review_comment":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lampepfl/dotty/pulls/1289/commits"},"statuses":{"href":"https://api.github.com/repos/lampepfl/dotty/statuses/04e6d5e5ad39d046a977de1bfd4563287e5b0f41"}}}}
{"actor":{"display_login":"odersky"}}