{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9543","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9543/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9543/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9543/events","html_url":"https://github.com/nodejs/node/pull/9543","id":188526205,"number":9543,"title":"url: more strict validation on ipv6 hostname","user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"labels":[{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false},{"id":155435992,"url":"https://api.github.com/repos/nodejs/node/labels/url","name":"url","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-10T14:45:00Z","updated_at":"2016-11-16T00:31:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9543","html_url":"https://github.com/nodejs/node/pull/9543","diff_url":"https://github.com/nodejs/node/pull/9543.diff","patch_url":"https://github.com/nodejs/node/pull/9543.patch"},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nurl\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\nJust improving the validation on ipv6 address :)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/260815706","html_url":"https://github.com/nodejs/node/pull/9543#issuecomment-260815706","issue_url":"https://api.github.com/repos/nodejs/node/issues/9543","id":260815706,"user":{"login":"yorkie","id":1935767,"avatar_url":"https://avatars.githubusercontent.com/u/1935767?v=3","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T00:31:09Z","updated_at":"2016-11-16T00:31:09Z","body":"> \"is an invalid\" or \"is not a valid\". The latter sounds better to my ears.\r\n\r\nFixed :)\r\n\r\n> http://[1:2:3:4%eth0]/\r\n\r\n@bnoordhuis does this got specified by any RFC? [3968](https://tools.ietf.org/html/rfc3986#section-3.2.2) seems to only define this to be:\r\n\r\n```\r\nIP-literal = \"[\" ( IPv6address / IPvFuture  ) \"]\"\r\n```\r\n\r\nWhich should not include the style of `http://[1:2:3:4%eth0]/`."}}
{"actor":{"display_login":"yorkie"}}