{"action":"opened","number":4425,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/4425","id":80597049,"html_url":"https://github.com/minetest/minetest/pull/4425","diff_url":"https://github.com/minetest/minetest/pull/4425.diff","patch_url":"https://github.com/minetest/minetest/pull/4425.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/4425","number":4425,"state":"open","locked":false,"title":"Assertion failure: sanitize some values obtained from mods (yaw, velocity, etc.)","user":{"login":"Rogier-5","id":6202053,"avatar_url":"https://avatars.githubusercontent.com/u/6202053?v=3","gravatar_id":"","url":"https://api.github.com/users/Rogier-5","html_url":"https://github.com/Rogier-5","followers_url":"https://api.github.com/users/Rogier-5/followers","following_url":"https://api.github.com/users/Rogier-5/following{/other_user}","gists_url":"https://api.github.com/users/Rogier-5/gists{/gist_id}","starred_url":"https://api.github.com/users/Rogier-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rogier-5/subscriptions","organizations_url":"https://api.github.com/users/Rogier-5/orgs","repos_url":"https://api.github.com/users/Rogier-5/repos","events_url":"https://api.github.com/users/Rogier-5/events{/privacy}","received_events_url":"https://api.github.com/users/Rogier-5/received_events","type":"User","site_admin":false},"body":"I got the following assertion failure:\r\n```\r\nminetest/src/util/serialize.h:278: void writeF1000(irr::u8*, irr::f32): Assertion `i >= ((float)(s32)((-0x7FFFFFFF - 1) / 1000.0f)) && i <= ((float)(s32)((0x7FFFFFFF) / 1000.0f))' failed.\r\n```\r\nBecause a mod (older version of mobs) was setting entity yaw and velocity to `-nan`.\r\n\r\nThis patch fixes this by sanitizing the float values a mod may set for objects.\r\n\r\nAlternatively, minetest could opt to return an error to the mod. However, as such mod bugs will be intermittent, possibly rare, and may be hard to reproduce and fix, I thought it would be better just to accept the invalid values, and sanitize them.\r\n\r\nOptionally, I could add code to print a warning message to the log ?","created_at":"2016-08-09T10:32:01Z","updated_at":"2016-08-09T10:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"806a9b2134fa926cd9332761b8ba7ca694840c30","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/4425/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/4425/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/4425/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/376924c1841dad87d395889f5a640e2a7bb50bdc","head":{"label":"Rogier-5:nan-crash","ref":"nan-crash","sha":"376924c1841dad87d395889f5a640e2a7bb50bdc","user":{"login":"Rogier-5","id":6202053,"avatar_url":"https://avatars.githubusercontent.com/u/6202053?v=3","gravatar_id":"","url":"https://api.github.com/users/Rogier-5","html_url":"https://github.com/Rogier-5","followers_url":"https://api.github.com/users/Rogier-5/followers","following_url":"https://api.github.com/users/Rogier-5/following{/other_user}","gists_url":"https://api.github.com/users/Rogier-5/gists{/gist_id}","starred_url":"https://api.github.com/users/Rogier-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rogier-5/subscriptions","organizations_url":"https://api.github.com/users/Rogier-5/orgs","repos_url":"https://api.github.com/users/Rogier-5/repos","events_url":"https://api.github.com/users/Rogier-5/events{/privacy}","received_events_url":"https://api.github.com/users/Rogier-5/received_events","type":"User","site_admin":false},"repo":{"id":45490264,"name":"minetest","full_name":"Rogier-5/minetest","owner":{"login":"Rogier-5","id":6202053,"avatar_url":"https://avatars.githubusercontent.com/u/6202053?v=3","gravatar_id":"","url":"https://api.github.com/users/Rogier-5","html_url":"https://github.com/Rogier-5","followers_url":"https://api.github.com/users/Rogier-5/followers","following_url":"https://api.github.com/users/Rogier-5/following{/other_user}","gists_url":"https://api.github.com/users/Rogier-5/gists{/gist_id}","starred_url":"https://api.github.com/users/Rogier-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rogier-5/subscriptions","organizations_url":"https://api.github.com/users/Rogier-5/orgs","repos_url":"https://api.github.com/users/Rogier-5/repos","events_url":"https://api.github.com/users/Rogier-5/events{/privacy}","received_events_url":"https://api.github.com/users/Rogier-5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rogier-5/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/Rogier-5/minetest","forks_url":"https://api.github.com/repos/Rogier-5/minetest/forks","keys_url":"https://api.github.com/repos/Rogier-5/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rogier-5/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rogier-5/minetest/teams","hooks_url":"https://api.github.com/repos/Rogier-5/minetest/hooks","issue_events_url":"https://api.github.com/repos/Rogier-5/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/Rogier-5/minetest/events","assignees_url":"https://api.github.com/repos/Rogier-5/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/Rogier-5/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/Rogier-5/minetest/tags","blobs_url":"https://api.github.com/repos/Rogier-5/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rogier-5/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rogier-5/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rogier-5/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rogier-5/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/Rogier-5/minetest/languages","stargazers_url":"https://api.github.com/repos/Rogier-5/minetest/stargazers","contributors_url":"https://api.github.com/repos/Rogier-5/minetest/contributors","subscribers_url":"https://api.github.com/repos/Rogier-5/minetest/subscribers","subscription_url":"https://api.github.com/repos/Rogier-5/minetest/subscription","commits_url":"https://api.github.com/repos/Rogier-5/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rogier-5/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rogier-5/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rogier-5/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rogier-5/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/Rogier-5/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rogier-5/minetest/merges","archive_url":"https://api.github.com/repos/Rogier-5/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rogier-5/minetest/downloads","issues_url":"https://api.github.com/repos/Rogier-5/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/Rogier-5/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/Rogier-5/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/Rogier-5/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rogier-5/minetest/labels{/name}","releases_url":"https://api.github.com/repos/Rogier-5/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/Rogier-5/minetest/deployments","created_at":"2015-11-03T19:27:52Z","updated_at":"2016-07-25T18:31:54Z","pushed_at":"2016-08-09T10:18:09Z","git_url":"git://github.com/Rogier-5/minetest.git","ssh_url":"git@github.com:Rogier-5/minetest.git","clone_url":"https://github.com/Rogier-5/minetest.git","svn_url":"https://github.com/Rogier-5/minetest","homepage":"http://minetest.net/","size":41461,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"b6d845adb4a0f39a58610c827817b1f881bfcebc","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2016-08-09T08:15:59Z","pushed_at":"2016-08-09T10:32:02Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":114530,"stargazers_count":2103,"watchers_count":2103,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":657,"mirror_url":null,"open_issues_count":847,"forks":657,"open_issues":847,"watchers":2103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4425"},"html":{"href":"https://github.com/minetest/minetest/pull/4425"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/4425"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/4425/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4425/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4425/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/376924c1841dad87d395889f5a640e2a7bb50bdc"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":23,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"Rogier-5"}}