{"action":"closed","issue":{"url":"https://api.github.com/repos/clinton-hall/nzbToMedia/issues/1088","repository_url":"https://api.github.com/repos/clinton-hall/nzbToMedia","labels_url":"https://api.github.com/repos/clinton-hall/nzbToMedia/issues/1088/labels{/name}","comments_url":"https://api.github.com/repos/clinton-hall/nzbToMedia/issues/1088/comments","events_url":"https://api.github.com/repos/clinton-hall/nzbToMedia/issues/1088/events","html_url":"https://github.com/clinton-hall/nzbToMedia/issues/1088","id":169621383,"number":1088,"title":"Transcoding: subtitle language not embedded correctly with ffmpeg","user":{"login":"ladude626","id":3040306,"avatar_url":"https://avatars.githubusercontent.com/u/3040306?v=3","gravatar_id":"","url":"https://api.github.com/users/ladude626","html_url":"https://github.com/ladude626","followers_url":"https://api.github.com/users/ladude626/followers","following_url":"https://api.github.com/users/ladude626/following{/other_user}","gists_url":"https://api.github.com/users/ladude626/gists{/gist_id}","starred_url":"https://api.github.com/users/ladude626/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladude626/subscriptions","organizations_url":"https://api.github.com/users/ladude626/orgs","repos_url":"https://api.github.com/users/ladude626/repos","events_url":"https://api.github.com/users/ladude626/events{/privacy}","received_events_url":"https://api.github.com/users/ladude626/received_events","type":"User","site_admin":false},"labels":[{"id":18947665,"url":"https://api.github.com/repos/clinton-hall/nzbToMedia/labels/BUG","name":"BUG","color":"fc2929","default":false},{"id":113982163,"url":"https://api.github.com/repos/clinton-hall/nzbToMedia/labels/FIXED","name":"FIXED","color":"009800","default":false},{"id":113790975,"url":"https://api.github.com/repos/clinton-hall/nzbToMedia/labels/in%20nightly","name":"in nightly","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-05T14:35:38Z","updated_at":"2016-10-29T19:51:44Z","closed_at":"2016-10-29T19:51:44Z","body":"I'm using the transcoding feature to automatically convert MKV -> MP4. I've turned on the subtitle grabbing feature and embedding into the MP4. However, I notice all foreign subtitles showing as english in Plex and in other applications. I believe the problem is when subtitles are downloaded, a 2 letter code for language (ISO 939-1) is used at the end of the file (ie movie.en.srt for english). This 2 letter code is then feed into ffmpeg. However, when I look at ffmpeg documentations, looks like 3 letter codes (ISO 939-2) should be used instead: https://ffmpeg.org/ffmpeg.html\r\n\r\nHere's an example of the how nzbToMedia is executing ffmpeg using 2 letter codes. In this case, I'm trying to integrate an English and Vietnamese subtitle.\r\n\r\n`nice -n19 ionice -c0 -n0 /ffmpeg/ffmpeg -loglevel warning -fflags +genpts -i /downloads/tv/True Detective S02E08 720p HDTV x264-0SEC/True Detective S02E08 720p HDTV x264-0SEC.mkv -i /downloads/tv/True Detective S02E08 720p HDTV x264-0SEC/True Detective S02E08 720p HDTV x264-0SEC.en.srt -i /downloads/tv/True Detective S02E08 720p HDTV x264-0SEC/True Detective S02E08 720p HDTV x264-0SEC.vi.srt -map 0:0 -map 0:1 -map 0:1 -map 0:2 -map 0:3 -map 1:0 -map 2:0 -c:v libx264 -c:a:0 aac -strict -2 -c:a:1 ac3 -c:s mov_text -metadata:s:s:2 language=en -metadata:s:s:3 language=vi /downloads/tv/True Detective S02E08 720p HDTV x264-0SEC/True Detective S02E08 720p HDTV x264-0SEC.mp4`\r\n\r\nWhen I run the above code manually and replacing \"en\" with \"eng\" and \"vi\" with \"vie\", it works correctly.\r\n\r\nPerhaps we need to convert 2 letter codes to 3 letter codes before feeding into ffmpeg. Here's some reference for ISO 639-1/2: https://www.loc.gov/standards/iso639-2/php/English_list.php"}}
{"actor":{"display_login":"clinton-hall"}}