{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/5","id":77041783,"html_url":"https://github.com/NYTimes/ingredient-phrase-tagger/pull/5","diff_url":"https://github.com/NYTimes/ingredient-phrase-tagger/pull/5.diff","patch_url":"https://github.com/NYTimes/ingredient-phrase-tagger/pull/5.patch","issue_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/issues/5","number":5,"state":"closed","locked":false,"title":"Honor $COUNT_TEST, don't test on training data.","user":{"login":"jsundram","id":150536,"avatar_url":"https://avatars.githubusercontent.com/u/150536?v=3","gravatar_id":"","url":"https://api.github.com/users/jsundram","html_url":"https://github.com/jsundram","followers_url":"https://api.github.com/users/jsundram/followers","following_url":"https://api.github.com/users/jsundram/following{/other_user}","gists_url":"https://api.github.com/users/jsundram/gists{/gist_id}","starred_url":"https://api.github.com/users/jsundram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsundram/subscriptions","organizations_url":"https://api.github.com/users/jsundram/orgs","repos_url":"https://api.github.com/users/jsundram/repos","events_url":"https://api.github.com/users/jsundram/events{/privacy}","received_events_url":"https://api.github.com/users/jsundram/received_events","type":"User","site_admin":false},"body":"I ran this script, and the generated stats from evaluate.py were unbelievably good:\r\n\r\n```\r\nSentence-Level Stats:\r\n\tcorrect:  91\r\n\ttotal:  100\r\n\t% correct:  91.0\r\n\r\nWord-Level Stats:\r\n\tcorrect: 572\r\n\ttotal: 588\r\n\t% correct: 97.2789115646\r\n```\r\n\r\nLooking closer, it seems like the model is being tested on a small amount of the data it was trained on. Providing the additional arguments on line 9:` --count=$COUNT_TEST --offset=$COUNT_TRAIN` fixes that and yields a more reasonable assessment of accuracy:\r\n\r\n```\r\nSentence-Level Stats:\r\n\tcorrect:  1489\r\n\ttotal:  1999\r\n\t% correct:  74.4872436218\r\n\r\nWord-Level Stats:\r\n\tcorrect: 10399\r\n\ttotal: 11450\r\n\t% correct: 90.8209606987\r\n```","created_at":"2016-07-11T23:51:02Z","updated_at":"2016-07-12T00:04:25Z","closed_at":"2016-07-12T00:04:25Z","merged_at":"2016-07-12T00:04:25Z","merge_commit_sha":"e414c2ca279f23c99c8338ceba00653d88d40dfe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/5/commits","review_comments_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/5/comments","review_comment_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/issues/5/comments","statuses_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/statuses/598a46b02167440e9c5e582ef595207a01330440","head":{"label":"jsundram:patch-1","ref":"patch-1","sha":"598a46b02167440e9c5e582ef595207a01330440","user":{"login":"jsundram","id":150536,"avatar_url":"https://avatars.githubusercontent.com/u/150536?v=3","gravatar_id":"","url":"https://api.github.com/users/jsundram","html_url":"https://github.com/jsundram","followers_url":"https://api.github.com/users/jsundram/followers","following_url":"https://api.github.com/users/jsundram/following{/other_user}","gists_url":"https://api.github.com/users/jsundram/gists{/gist_id}","starred_url":"https://api.github.com/users/jsundram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsundram/subscriptions","organizations_url":"https://api.github.com/users/jsundram/orgs","repos_url":"https://api.github.com/users/jsundram/repos","events_url":"https://api.github.com/users/jsundram/events{/privacy}","received_events_url":"https://api.github.com/users/jsundram/received_events","type":"User","site_admin":false},"repo":{"id":63110174,"name":"ingredient-phrase-tagger","full_name":"jsundram/ingredient-phrase-tagger","owner":{"login":"jsundram","id":150536,"avatar_url":"https://avatars.githubusercontent.com/u/150536?v=3","gravatar_id":"","url":"https://api.github.com/users/jsundram","html_url":"https://github.com/jsundram","followers_url":"https://api.github.com/users/jsundram/followers","following_url":"https://api.github.com/users/jsundram/following{/other_user}","gists_url":"https://api.github.com/users/jsundram/gists{/gist_id}","starred_url":"https://api.github.com/users/jsundram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsundram/subscriptions","organizations_url":"https://api.github.com/users/jsundram/orgs","repos_url":"https://api.github.com/users/jsundram/repos","events_url":"https://api.github.com/users/jsundram/events{/privacy}","received_events_url":"https://api.github.com/users/jsundram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsundram/ingredient-phrase-tagger","description":"Extract structured data from ingredient phrases using conditional random fields","fork":true,"url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger","forks_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/forks","keys_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/teams","hooks_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/hooks","issue_events_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/issues/events{/number}","events_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/events","assignees_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/assignees{/user}","branches_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/branches{/branch}","tags_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/tags","blobs_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/statuses/{sha}","languages_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/languages","stargazers_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/stargazers","contributors_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/contributors","subscribers_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/subscribers","subscription_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/subscription","commits_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/contents/{+path}","compare_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/merges","archive_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/downloads","issues_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/issues{/number}","pulls_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/pulls{/number}","milestones_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/milestones{/number}","notifications_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/labels{/name}","releases_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/releases{/id}","deployments_url":"https://api.github.com/repos/jsundram/ingredient-phrase-tagger/deployments","created_at":"2016-07-11T23:44:46Z","updated_at":"2016-07-11T23:44:47Z","pushed_at":"2016-07-11T23:48:10Z","git_url":"git://github.com/jsundram/ingredient-phrase-tagger.git","ssh_url":"git@github.com:jsundram/ingredient-phrase-tagger.git","clone_url":"https://github.com/jsundram/ingredient-phrase-tagger.git","svn_url":"https://github.com/jsundram/ingredient-phrase-tagger","homepage":"http://open.blogs.nytimes.com/2016/04/27/structured-ingredients-data-tagging/","size":3950,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NYTimes:master","ref":"master","sha":"8b565f2630424f9338e9a7751ca78a122890e5c8","user":{"login":"NYTimes","id":221409,"avatar_url":"https://avatars.githubusercontent.com/u/221409?v=3","gravatar_id":"","url":"https://api.github.com/users/NYTimes","html_url":"https://github.com/NYTimes","followers_url":"https://api.github.com/users/NYTimes/followers","following_url":"https://api.github.com/users/NYTimes/following{/other_user}","gists_url":"https://api.github.com/users/NYTimes/gists{/gist_id}","starred_url":"https://api.github.com/users/NYTimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYTimes/subscriptions","organizations_url":"https://api.github.com/users/NYTimes/orgs","repos_url":"https://api.github.com/users/NYTimes/repos","events_url":"https://api.github.com/users/NYTimes/events{/privacy}","received_events_url":"https://api.github.com/users/NYTimes/received_events","type":"Organization","site_admin":false},"repo":{"id":51404334,"name":"ingredient-phrase-tagger","full_name":"NYTimes/ingredient-phrase-tagger","owner":{"login":"NYTimes","id":221409,"avatar_url":"https://avatars.githubusercontent.com/u/221409?v=3","gravatar_id":"","url":"https://api.github.com/users/NYTimes","html_url":"https://github.com/NYTimes","followers_url":"https://api.github.com/users/NYTimes/followers","following_url":"https://api.github.com/users/NYTimes/following{/other_user}","gists_url":"https://api.github.com/users/NYTimes/gists{/gist_id}","starred_url":"https://api.github.com/users/NYTimes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYTimes/subscriptions","organizations_url":"https://api.github.com/users/NYTimes/orgs","repos_url":"https://api.github.com/users/NYTimes/repos","events_url":"https://api.github.com/users/NYTimes/events{/privacy}","received_events_url":"https://api.github.com/users/NYTimes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYTimes/ingredient-phrase-tagger","description":"Extract structured data from ingredient phrases using conditional random fields","fork":false,"url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger","forks_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/forks","keys_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/teams","hooks_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/hooks","issue_events_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/issues/events{/number}","events_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/events","assignees_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/assignees{/user}","branches_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/branches{/branch}","tags_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/tags","blobs_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/statuses/{sha}","languages_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/languages","stargazers_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/stargazers","contributors_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/contributors","subscribers_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/subscribers","subscription_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/subscription","commits_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/contents/{+path}","compare_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/merges","archive_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/downloads","issues_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/issues{/number}","pulls_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls{/number}","milestones_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/milestones{/number}","notifications_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/labels{/name}","releases_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/releases{/id}","deployments_url":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/deployments","created_at":"2016-02-09T22:15:39Z","updated_at":"2016-07-11T13:53:29Z","pushed_at":"2016-07-12T00:04:25Z","git_url":"git://github.com/NYTimes/ingredient-phrase-tagger.git","ssh_url":"git@github.com:NYTimes/ingredient-phrase-tagger.git","clone_url":"https://github.com/NYTimes/ingredient-phrase-tagger.git","svn_url":"https://github.com/NYTimes/ingredient-phrase-tagger","homepage":"http://open.blogs.nytimes.com/2016/04/27/structured-ingredients-data-tagging/","size":3950,"stargazers_count":260,"watchers_count":260,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":1,"forks":25,"open_issues":1,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/5"},"html":{"href":"https://github.com/NYTimes/ingredient-phrase-tagger/pull/5"},"issue":{"href":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/issues/5"},"comments":{"href":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/NYTimes/ingredient-phrase-tagger/statuses/598a46b02167440e9c5e582ef595207a01330440"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"adammck","id":19543,"avatar_url":"https://avatars.githubusercontent.com/u/19543?v=3","gravatar_id":"","url":"https://api.github.com/users/adammck","html_url":"https://github.com/adammck","followers_url":"https://api.github.com/users/adammck/followers","following_url":"https://api.github.com/users/adammck/following{/other_user}","gists_url":"https://api.github.com/users/adammck/gists{/gist_id}","starred_url":"https://api.github.com/users/adammck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammck/subscriptions","organizations_url":"https://api.github.com/users/adammck/orgs","repos_url":"https://api.github.com/users/adammck/repos","events_url":"https://api.github.com/users/adammck/events{/privacy}","received_events_url":"https://api.github.com/users/adammck/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"adammck"}}