{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/54241642","id":54241642,"diff_hunk":"@@ -127,13 +127,13 @@ export default class DeployFromSettingsController {\n      * (leading and trailing spaces are ignored by default)\n      * @export {!RegExp}\n      */\n-    this.namePattern = new RegExp('^[a-z0-9]([-a-z0-9]*[a-z0-9])?$');\n+    this.namePattern = new RegExp('^[a-z]([-a-z0-9]*[a-z0-9])?$');\n \n     /**\n      * Maximum length for Application name\n      * @export {string}\n      */\n-    this.nameMaxLength = '63';\n+    this.nameMaxLength = '24';","path":"src/app/frontend/deploy/deployfromsettings_controller.js","position":12,"original_position":12,"commit_id":"9560ea08522c87d1b199fc538896290de304520d","original_commit_id":"49aaf52a39c96cacbc8315a2ed1bed05ce3c549a","user":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"body":"@cheld PTAL","created_at":"2016-02-26T13:23:26Z","updated_at":"2016-02-26T13:23:26Z","html_url":"https://github.com/kubernetes/dashboard/pull/451#discussion_r54241642","pull_request_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/451","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments/54241642"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/451#discussion_r54241642"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/451","id":60803541,"html_url":"https://github.com/kubernetes/dashboard/pull/451","diff_url":"https://github.com/kubernetes/dashboard/pull/451.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/451.patch","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/451","number":451,"state":"open","locked":false,"title":"App name validation fix","user":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"body":"#411 \r\nApp name is restricted to 24 chars and regex pattern now also restricts first char to lowercase letter\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/kubernetes/dashboard/451)\n<!-- Reviewable:end -->\n","created_at":"2016-02-26T07:32:35Z","updated_at":"2016-02-26T13:23:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4da32f077ac62c10056a0704a10a15f4b2faccde","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/451/commits","review_comments_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/451/comments","review_comment_url":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/451/comments","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/9560ea08522c87d1b199fc538896290de304520d","head":{"label":"digitalfishpond:service-name-maxchars","ref":"service-name-maxchars","sha":"9560ea08522c87d1b199fc538896290de304520d","user":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"repo":{"id":49414437,"name":"dashboard","full_name":"digitalfishpond/dashboard","owner":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/digitalfishpond/dashboard","description":"","fork":true,"url":"https://api.github.com/repos/digitalfishpond/dashboard","forks_url":"https://api.github.com/repos/digitalfishpond/dashboard/forks","keys_url":"https://api.github.com/repos/digitalfishpond/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalfishpond/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalfishpond/dashboard/teams","hooks_url":"https://api.github.com/repos/digitalfishpond/dashboard/hooks","issue_events_url":"https://api.github.com/repos/digitalfishpond/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/digitalfishpond/dashboard/events","assignees_url":"https://api.github.com/repos/digitalfishpond/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/digitalfishpond/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/digitalfishpond/dashboard/tags","blobs_url":"https://api.github.com/repos/digitalfishpond/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalfishpond/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalfishpond/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalfishpond/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalfishpond/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalfishpond/dashboard/languages","stargazers_url":"https://api.github.com/repos/digitalfishpond/dashboard/stargazers","contributors_url":"https://api.github.com/repos/digitalfishpond/dashboard/contributors","subscribers_url":"https://api.github.com/repos/digitalfishpond/dashboard/subscribers","subscription_url":"https://api.github.com/repos/digitalfishpond/dashboard/subscription","commits_url":"https://api.github.com/repos/digitalfishpond/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalfishpond/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalfishpond/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalfishpond/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalfishpond/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/digitalfishpond/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalfishpond/dashboard/merges","archive_url":"https://api.github.com/repos/digitalfishpond/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalfishpond/dashboard/downloads","issues_url":"https://api.github.com/repos/digitalfishpond/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/digitalfishpond/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalfishpond/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalfishpond/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalfishpond/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/digitalfishpond/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/digitalfishpond/dashboard/deployments","created_at":"2016-01-11T09:07:33Z","updated_at":"2016-01-11T09:07:34Z","pushed_at":"2016-02-26T13:02:44Z","git_url":"git://github.com/digitalfishpond/dashboard.git","ssh_url":"git@github.com:digitalfishpond/dashboard.git","clone_url":"https://github.com/digitalfishpond/dashboard.git","svn_url":"https://github.com/digitalfishpond/dashboard","homepage":"","size":44175,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"cffd34a90ae4a2334db4f062202f3a00fdf73dc6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":44350607,"name":"dashboard","full_name":"kubernetes/dashboard","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/dashboard","description":"General-purpose web UI for Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/dashboard","forks_url":"https://api.github.com/repos/kubernetes/dashboard/forks","keys_url":"https://api.github.com/repos/kubernetes/dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/dashboard/teams","hooks_url":"https://api.github.com/repos/kubernetes/dashboard/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/dashboard/events","assignees_url":"https://api.github.com/repos/kubernetes/dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/dashboard/tags","blobs_url":"https://api.github.com/repos/kubernetes/dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/dashboard/languages","stargazers_url":"https://api.github.com/repos/kubernetes/dashboard/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/dashboard/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/dashboard/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/dashboard/subscription","commits_url":"https://api.github.com/repos/kubernetes/dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/dashboard/merges","archive_url":"https://api.github.com/repos/kubernetes/dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/dashboard/downloads","issues_url":"https://api.github.com/repos/kubernetes/dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/dashboard/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/dashboard/deployments","created_at":"2015-10-15T23:09:14Z","updated_at":"2016-02-25T19:36:56Z","pushed_at":"2016-02-26T13:02:48Z","git_url":"git://github.com/kubernetes/dashboard.git","ssh_url":"git@github.com:kubernetes/dashboard.git","clone_url":"https://github.com/kubernetes/dashboard.git","svn_url":"https://github.com/kubernetes/dashboard","homepage":"","size":44359,"stargazers_count":128,"watchers_count":128,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":83,"forks":39,"open_issues":83,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/451"},"html":{"href":"https://github.com/kubernetes/dashboard/pull/451"},"issue":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/451"},"comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/dashboard/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/dashboard/statuses/9560ea08522c87d1b199fc538896290de304520d"}}}}