{"action":"created","comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/49233585","id":49233585,"diff_hunk":"@@ -1,31 +1,63 @@\n-;;; packages.el --- %LAYERNAME% Layer packages File for Spacemacs\n+;;; packages.el --- %LAYER_NAME% layer packages file for Spacemacs.  -*- lexical-binding: t; -*-","path":"core/templates/packages.el.template","position":2,"original_position":2,"commit_id":"9d107fdafb47518f6530e77e262d2e8d63690498","original_commit_id":"1a0a2c1b0ae14069ac8690942094ebe86a56e9fb","user":{"login":"chrisbarrett","id":836504,"avatar_url":"https://avatars.githubusercontent.com/u/836504?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisbarrett","html_url":"https://github.com/chrisbarrett","followers_url":"https://api.github.com/users/chrisbarrett/followers","following_url":"https://api.github.com/users/chrisbarrett/following{/other_user}","gists_url":"https://api.github.com/users/chrisbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbarrett/subscriptions","organizations_url":"https://api.github.com/users/chrisbarrett/orgs","repos_url":"https://api.github.com/users/chrisbarrett/repos","events_url":"https://api.github.com/users/chrisbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbarrett/received_events","type":"User","site_admin":false},"body":"I'm happy to relent on this one if it's a blocker on the PR!\r\n\r\nFor your interest, as I understand it, lexical binding in elisp changes two things:\r\n1. changes `let` to to bind variables with lexical scope\r\n2. changes `lambda` to capture variables in the enclosing scope.\r\n\r\nThis is what every modern language with closures does, so I think it's a huge improvement. But I can imagine situations where contributors copy-pasta stuff off emacswiki that depends on dynamic scope and breaks. So I'm happy either way. :)","created_at":"2016-01-08T20:22:15Z","updated_at":"2016-01-08T20:22:15Z","html_url":"https://github.com/syl20bnr/spacemacs/pull/4491#discussion_r49233585","pull_request_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491","_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments/49233585"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/4491#discussion_r49233585"},"pull_request":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491"}}},"pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491","id":55443015,"html_url":"https://github.com/syl20bnr/spacemacs/pull/4491","diff_url":"https://github.com/syl20bnr/spacemacs/pull/4491.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/4491.patch","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4491","number":4491,"state":"open","locked":false,"title":"Update configuration layer templates","user":{"login":"chrisbarrett","id":836504,"avatar_url":"https://avatars.githubusercontent.com/u/836504?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisbarrett","html_url":"https://github.com/chrisbarrett","followers_url":"https://api.github.com/users/chrisbarrett/followers","following_url":"https://api.github.com/users/chrisbarrett/following{/other_user}","gists_url":"https://api.github.com/users/chrisbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbarrett/subscriptions","organizations_url":"https://api.github.com/users/chrisbarrett/orgs","repos_url":"https://api.github.com/users/chrisbarrett/repos","events_url":"https://api.github.com/users/chrisbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbarrett/received_events","type":"User","site_admin":false},"body":"Update the configuration layer template and make minor changes to the interactive command.\r\n\r\n- remove the now defunct `extensions.el` file from the template\r\n- query the user whether or not to create a layer readme\r\n- add template variables for the layer author and email address in the layer preamble.\r\n\r\nResolves #4488.","created_at":"2016-01-08T09:55:06Z","updated_at":"2016-01-08T20:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6c38ecef5b2a2477d0cdeb17b535a489b02d023","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491/commits","review_comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491/comments","review_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4491/comments","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/9d107fdafb47518f6530e77e262d2e8d63690498","head":{"label":"chrisbarrett:4488-update-configuration-layer-templates","ref":"4488-update-configuration-layer-templates","sha":"9d107fdafb47518f6530e77e262d2e8d63690498","user":{"login":"chrisbarrett","id":836504,"avatar_url":"https://avatars.githubusercontent.com/u/836504?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisbarrett","html_url":"https://github.com/chrisbarrett","followers_url":"https://api.github.com/users/chrisbarrett/followers","following_url":"https://api.github.com/users/chrisbarrett/following{/other_user}","gists_url":"https://api.github.com/users/chrisbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbarrett/subscriptions","organizations_url":"https://api.github.com/users/chrisbarrett/orgs","repos_url":"https://api.github.com/users/chrisbarrett/repos","events_url":"https://api.github.com/users/chrisbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbarrett/received_events","type":"User","site_admin":false},"repo":{"id":38873325,"name":"spacemacs","full_name":"chrisbarrett/spacemacs","owner":{"login":"chrisbarrett","id":836504,"avatar_url":"https://avatars.githubusercontent.com/u/836504?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisbarrett","html_url":"https://github.com/chrisbarrett","followers_url":"https://api.github.com/users/chrisbarrett/followers","following_url":"https://api.github.com/users/chrisbarrett/following{/other_user}","gists_url":"https://api.github.com/users/chrisbarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbarrett/subscriptions","organizations_url":"https://api.github.com/users/chrisbarrett/orgs","repos_url":"https://api.github.com/users/chrisbarrett/repos","events_url":"https://api.github.com/users/chrisbarrett/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbarrett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisbarrett/spacemacs","description":"NOTICE: My personal configuration has moved to https://github.com/chrisbarrett/spacemacs-layers","fork":true,"url":"https://api.github.com/repos/chrisbarrett/spacemacs","forks_url":"https://api.github.com/repos/chrisbarrett/spacemacs/forks","keys_url":"https://api.github.com/repos/chrisbarrett/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisbarrett/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisbarrett/spacemacs/teams","hooks_url":"https://api.github.com/repos/chrisbarrett/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/chrisbarrett/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/chrisbarrett/spacemacs/events","assignees_url":"https://api.github.com/repos/chrisbarrett/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/chrisbarrett/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/chrisbarrett/spacemacs/tags","blobs_url":"https://api.github.com/repos/chrisbarrett/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisbarrett/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisbarrett/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisbarrett/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisbarrett/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisbarrett/spacemacs/languages","stargazers_url":"https://api.github.com/repos/chrisbarrett/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/chrisbarrett/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/chrisbarrett/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/chrisbarrett/spacemacs/subscription","commits_url":"https://api.github.com/repos/chrisbarrett/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisbarrett/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisbarrett/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisbarrett/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisbarrett/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/chrisbarrett/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisbarrett/spacemacs/merges","archive_url":"https://api.github.com/repos/chrisbarrett/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisbarrett/spacemacs/downloads","issues_url":"https://api.github.com/repos/chrisbarrett/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/chrisbarrett/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisbarrett/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisbarrett/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisbarrett/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/chrisbarrett/spacemacs/releases{/id}","created_at":"2015-07-10T09:46:04Z","updated_at":"2015-07-10T10:00:39Z","pushed_at":"2016-01-08T10:34:57Z","git_url":"git://github.com/chrisbarrett/spacemacs.git","ssh_url":"git@github.com:chrisbarrett/spacemacs.git","clone_url":"https://github.com/chrisbarrett/spacemacs.git","svn_url":"https://github.com/chrisbarrett/spacemacs","homepage":"","size":21013,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syl20bnr:develop","ref":"develop","sha":"c34c9d0acca80cae3cdc10503f8b89e8990e1fed","user":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"repo":{"id":7212645,"name":"spacemacs","full_name":"syl20bnr/spacemacs","owner":{"login":"syl20bnr","id":1243537,"avatar_url":"https://avatars.githubusercontent.com/u/1243537?v=3","gravatar_id":"","url":"https://api.github.com/users/syl20bnr","html_url":"https://github.com/syl20bnr","followers_url":"https://api.github.com/users/syl20bnr/followers","following_url":"https://api.github.com/users/syl20bnr/following{/other_user}","gists_url":"https://api.github.com/users/syl20bnr/gists{/gist_id}","starred_url":"https://api.github.com/users/syl20bnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syl20bnr/subscriptions","organizations_url":"https://api.github.com/users/syl20bnr/orgs","repos_url":"https://api.github.com/users/syl20bnr/repos","events_url":"https://api.github.com/users/syl20bnr/events{/privacy}","received_events_url":"https://api.github.com/users/syl20bnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syl20bnr/spacemacs","description":"An Emacs distribution - The best editor is neither Emacs nor Vim,  it's Emacs *and* Vim!","fork":false,"url":"https://api.github.com/repos/syl20bnr/spacemacs","forks_url":"https://api.github.com/repos/syl20bnr/spacemacs/forks","keys_url":"https://api.github.com/repos/syl20bnr/spacemacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syl20bnr/spacemacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syl20bnr/spacemacs/teams","hooks_url":"https://api.github.com/repos/syl20bnr/spacemacs/hooks","issue_events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/events{/number}","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/events","assignees_url":"https://api.github.com/repos/syl20bnr/spacemacs/assignees{/user}","branches_url":"https://api.github.com/repos/syl20bnr/spacemacs/branches{/branch}","tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/tags","blobs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/{sha}","languages_url":"https://api.github.com/repos/syl20bnr/spacemacs/languages","stargazers_url":"https://api.github.com/repos/syl20bnr/spacemacs/stargazers","contributors_url":"https://api.github.com/repos/syl20bnr/spacemacs/contributors","subscribers_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscribers","subscription_url":"https://api.github.com/repos/syl20bnr/spacemacs/subscription","commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/syl20bnr/spacemacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/syl20bnr/spacemacs/contents/{+path}","compare_url":"https://api.github.com/repos/syl20bnr/spacemacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syl20bnr/spacemacs/merges","archive_url":"https://api.github.com/repos/syl20bnr/spacemacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syl20bnr/spacemacs/downloads","issues_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues{/number}","pulls_url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls{/number}","milestones_url":"https://api.github.com/repos/syl20bnr/spacemacs/milestones{/number}","notifications_url":"https://api.github.com/repos/syl20bnr/spacemacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/labels{/name}","releases_url":"https://api.github.com/repos/syl20bnr/spacemacs/releases{/id}","created_at":"2012-12-17T21:34:03Z","updated_at":"2016-01-08T19:34:06Z","pushed_at":"2016-01-08T20:21:01Z","git_url":"git://github.com/syl20bnr/spacemacs.git","ssh_url":"git@github.com:syl20bnr/spacemacs.git","clone_url":"https://github.com/syl20bnr/spacemacs.git","svn_url":"https://github.com/syl20bnr/spacemacs","homepage":"http://spacemacs.org","size":34629,"stargazers_count":5327,"watchers_count":5327,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1326,"mirror_url":null,"open_issues_count":564,"forks":1326,"open_issues":564,"watchers":5327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491"},"html":{"href":"https://github.com/syl20bnr/spacemacs/pull/4491"},"issue":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4491"},"comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4491/comments"},"review_comments":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491/comments"},"review_comment":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4491/commits"},"statuses":{"href":"https://api.github.com/repos/syl20bnr/spacemacs/statuses/9d107fdafb47518f6530e77e262d2e8d63690498"}}}}