{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/85803394","pull_request_review_id":6497554,"id":85803394,"diff_hunk":"@@ -598,6 +599,14 @@ void AudioMixer::handleNodeKilled(SharedNodePointer killedNode) {\n     });\n }\n \n+void AudioMixer::handleKillAvatarPacket(QSharedPointer<ReceivedMessage> packet, SharedNodePointer sendingNode) {\n+    auto clientData = dynamic_cast<AudioMixerClientData*>(sendingNode->getLinkedData());\n+    if (clientData) {\n+        clientData->removeAgentAvatarAudioStream();\n+    }","path":"assignment-client/src/audio/AudioMixer.cpp","position":16,"original_position":16,"commit_id":"80e38c395ecf100d6948dd5f59beaa2b1eb951e3","original_commit_id":"80e38c395ecf100d6948dd5f59beaa2b1eb951e3","user":{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"If the node is going to stay connected, you probably need to do the same thing we're doing in `nodeKilled` to clean up HRTF objects for other nodes.","created_at":"2016-10-31T18:31:50Z","updated_at":"2016-10-31T18:31:50Z","html_url":"https://github.com/highfidelity/hifi/pull/8966#discussion_r85803394","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8966","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/85803394"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8966#discussion_r85803394"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8966"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/8966","id":91654778,"html_url":"https://github.com/highfidelity/hifi/pull/8966","diff_url":"https://github.com/highfidelity/hifi/pull/8966.diff","patch_url":"https://github.com/highfidelity/hifi/pull/8966.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/8966","number":8966,"state":"open","locked":false,"title":"Send KillAvatar message to AudioMixer","user":{"login":"davidkelly","id":1072532,"avatar_url":"https://avatars.githubusercontent.com/u/1072532?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkelly","html_url":"https://github.com/davidkelly","followers_url":"https://api.github.com/users/davidkelly/followers","following_url":"https://api.github.com/users/davidkelly/following{/other_user}","gists_url":"https://api.github.com/users/davidkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkelly/subscriptions","organizations_url":"https://api.github.com/users/davidkelly/orgs","repos_url":"https://api.github.com/users/davidkelly/repos","events_url":"https://api.github.com/users/davidkelly/events{/privacy}","received_events_url":"https://api.github.com/users/davidkelly/received_events","type":"User","site_admin":false},"body":"Similar to sending it to the `AvatarMixer`.  In this case, it is so it can remove the listening agent avatar audio streams.  Otherwise they stick around forever, and eventually swamp the audio mixer.\r\n\r\nDNM until I test this a lot more thoroughly.","created_at":"2016-10-31T17:38:29Z","updated_at":"2016-10-31T18:31:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5a3dec12ef33d02b31f9498cbeb67e2b3632a71","assignee":{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"assignees":[{"login":"birarda","id":724069,"avatar_url":"https://avatars.githubusercontent.com/u/724069?v=3","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8966/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/8966/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/8966/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/80e38c395ecf100d6948dd5f59beaa2b1eb951e3","head":{"label":"davidkelly:dk/noMoAgentAudioStreams","ref":"dk/noMoAgentAudioStreams","sha":"80e38c395ecf100d6948dd5f59beaa2b1eb951e3","user":{"login":"davidkelly","id":1072532,"avatar_url":"https://avatars.githubusercontent.com/u/1072532?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkelly","html_url":"https://github.com/davidkelly","followers_url":"https://api.github.com/users/davidkelly/followers","following_url":"https://api.github.com/users/davidkelly/following{/other_user}","gists_url":"https://api.github.com/users/davidkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkelly/subscriptions","organizations_url":"https://api.github.com/users/davidkelly/orgs","repos_url":"https://api.github.com/users/davidkelly/repos","events_url":"https://api.github.com/users/davidkelly/events{/privacy}","received_events_url":"https://api.github.com/users/davidkelly/received_events","type":"User","site_admin":false},"repo":{"id":62350098,"name":"hifi","full_name":"davidkelly/hifi","owner":{"login":"davidkelly","id":1072532,"avatar_url":"https://avatars.githubusercontent.com/u/1072532?v=3","gravatar_id":"","url":"https://api.github.com/users/davidkelly","html_url":"https://github.com/davidkelly","followers_url":"https://api.github.com/users/davidkelly/followers","following_url":"https://api.github.com/users/davidkelly/following{/other_user}","gists_url":"https://api.github.com/users/davidkelly/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkelly/subscriptions","organizations_url":"https://api.github.com/users/davidkelly/orgs","repos_url":"https://api.github.com/users/davidkelly/repos","events_url":"https://api.github.com/users/davidkelly/events{/privacy}","received_events_url":"https://api.github.com/users/davidkelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidkelly/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/davidkelly/hifi","forks_url":"https://api.github.com/repos/davidkelly/hifi/forks","keys_url":"https://api.github.com/repos/davidkelly/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidkelly/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidkelly/hifi/teams","hooks_url":"https://api.github.com/repos/davidkelly/hifi/hooks","issue_events_url":"https://api.github.com/repos/davidkelly/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/davidkelly/hifi/events","assignees_url":"https://api.github.com/repos/davidkelly/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/davidkelly/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/davidkelly/hifi/tags","blobs_url":"https://api.github.com/repos/davidkelly/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidkelly/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidkelly/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidkelly/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidkelly/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/davidkelly/hifi/languages","stargazers_url":"https://api.github.com/repos/davidkelly/hifi/stargazers","contributors_url":"https://api.github.com/repos/davidkelly/hifi/contributors","subscribers_url":"https://api.github.com/repos/davidkelly/hifi/subscribers","subscription_url":"https://api.github.com/repos/davidkelly/hifi/subscription","commits_url":"https://api.github.com/repos/davidkelly/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidkelly/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidkelly/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidkelly/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidkelly/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/davidkelly/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidkelly/hifi/merges","archive_url":"https://api.github.com/repos/davidkelly/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidkelly/hifi/downloads","issues_url":"https://api.github.com/repos/davidkelly/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/davidkelly/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/davidkelly/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/davidkelly/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidkelly/hifi/labels{/name}","releases_url":"https://api.github.com/repos/davidkelly/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/davidkelly/hifi/deployments","created_at":"2016-07-01T00:16:16Z","updated_at":"2016-07-01T00:16:24Z","pushed_at":"2016-10-31T17:36:40Z","git_url":"git://github.com/davidkelly/hifi.git","ssh_url":"git@github.com:davidkelly/hifi.git","clone_url":"https://github.com/davidkelly/hifi.git","svn_url":"https://github.com/davidkelly/hifi","homepage":"","size":253243,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"dc8d0bf31c95a2c59a0f3fab6f17661c2f0b2910","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-10-31T15:25:57Z","pushed_at":"2016-10-31T18:13:24Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":302545,"stargazers_count":442,"watchers_count":442,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":52,"forks":257,"open_issues":52,"watchers":442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8966"},"html":{"href":"https://github.com/highfidelity/hifi/pull/8966"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8966"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/8966/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8966/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/8966/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/80e38c395ecf100d6948dd5f59beaa2b1eb951e3"}}}}
{"actor":{"display_login":"birarda"}}