{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments/64677674","id":64677674,"diff_hunk":"@@ -125,7 +125,7 @@ clean:\n \n # Remove all generated files and binaries\n clean-all: clean\n-\trm -rf src/atc_thrift src/api/bindata.go\n+\trm -rf src/atc_thrift src/assets/bindata.go","path":"Makefile","position":5,"original_position":5,"commit_id":"0b0feed2620cb167634ed011faaf85e35a880c9c","original_commit_id":"0b0feed2620cb167634ed011faaf85e35a880c9c","user":{"login":"zfjagann","id":794008,"avatar_url":"https://avatars.githubusercontent.com/u/794008?v=3","gravatar_id":"","url":"https://api.github.com/users/zfjagann","html_url":"https://github.com/zfjagann","followers_url":"https://api.github.com/users/zfjagann/followers","following_url":"https://api.github.com/users/zfjagann/following{/other_user}","gists_url":"https://api.github.com/users/zfjagann/gists{/gist_id}","starred_url":"https://api.github.com/users/zfjagann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfjagann/subscriptions","organizations_url":"https://api.github.com/users/zfjagann/orgs","repos_url":"https://api.github.com/users/zfjagann/repos","events_url":"https://api.github.com/users/zfjagann/events{/privacy}","received_events_url":"https://api.github.com/users/zfjagann/received_events","type":"User","site_admin":false},"body":"good catch!","created_at":"2016-05-26T00:57:33Z","updated_at":"2016-05-26T00:57:33Z","html_url":"https://github.com/facebook/augmented-traffic-control/pull/273#discussion_r64677674","pull_request_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments/64677674"},"html":{"href":"https://github.com/facebook/augmented-traffic-control/pull/273#discussion_r64677674"},"pull_request":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273","id":71485178,"html_url":"https://github.com/facebook/augmented-traffic-control/pull/273","diff_url":"https://github.com/facebook/augmented-traffic-control/pull/273.diff","patch_url":"https://github.com/facebook/augmented-traffic-control/pull/273.patch","issue_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/273","number":273,"state":"open","locked":false,"title":"Fixed make clean and rebuilt index.js and bindata.go","user":{"login":"smorad","id":1743889,"avatar_url":"https://avatars.githubusercontent.com/u/1743889?v=3","gravatar_id":"","url":"https://api.github.com/users/smorad","html_url":"https://github.com/smorad","followers_url":"https://api.github.com/users/smorad/followers","following_url":"https://api.github.com/users/smorad/following{/other_user}","gists_url":"https://api.github.com/users/smorad/gists{/gist_id}","starred_url":"https://api.github.com/users/smorad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smorad/subscriptions","organizations_url":"https://api.github.com/users/smorad/orgs","repos_url":"https://api.github.com/users/smorad/repos","events_url":"https://api.github.com/users/smorad/events{/privacy}","received_events_url":"https://api.github.com/users/smorad/received_events","type":"User","site_admin":false},"body":"Bindata.go was 4 months old, so I rebuilt it with the newest source, along with index.js. Additionally, make clean did not rm bindata.go.","created_at":"2016-05-26T00:45:51Z","updated_at":"2016-05-26T00:57:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bffd976ce9d5b659b68be70f76f3282a4740d60","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273/commits","review_comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273/comments","review_comment_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/273/comments","statuses_url":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/0b0feed2620cb167634ed011faaf85e35a880c9c","head":{"label":"facebook:rebuild-ui","ref":"rebuild-ui","sha":"0b0feed2620cb167634ed011faaf85e35a880c9c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":17996971,"name":"augmented-traffic-control","full_name":"facebook/augmented-traffic-control","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/augmented-traffic-control","description":"Augmented Traffic Control: A tool to simulate network conditions","fork":false,"url":"https://api.github.com/repos/facebook/augmented-traffic-control","forks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/forks","keys_url":"https://api.github.com/repos/facebook/augmented-traffic-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/augmented-traffic-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/augmented-traffic-control/teams","hooks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/hooks","issue_events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/events","assignees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/augmented-traffic-control/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/tags","blobs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/augmented-traffic-control/languages","stargazers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/stargazers","contributors_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contributors","subscribers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscribers","subscription_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscription","commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/augmented-traffic-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/augmented-traffic-control/merges","archive_url":"https://api.github.com/repos/facebook/augmented-traffic-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/augmented-traffic-control/downloads","issues_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/augmented-traffic-control/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/augmented-traffic-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/augmented-traffic-control/labels{/name}","releases_url":"https://api.github.com/repos/facebook/augmented-traffic-control/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/deployments","created_at":"2014-03-21T22:58:17Z","updated_at":"2016-05-24T17:09:35Z","pushed_at":"2016-05-26T00:45:52Z","git_url":"git://github.com/facebook/augmented-traffic-control.git","ssh_url":"git@github.com:facebook/augmented-traffic-control.git","clone_url":"https://github.com/facebook/augmented-traffic-control.git","svn_url":"https://github.com/facebook/augmented-traffic-control","homepage":"https://facebook.github.io/augmented-traffic-control","size":11951,"stargazers_count":2946,"watchers_count":2946,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":419,"mirror_url":null,"open_issues_count":14,"forks":419,"open_issues":14,"watchers":2946,"default_branch":"master"}},"base":{"label":"facebook:golang","ref":"golang","sha":"7ff5140d7b75de95d2a51e9f288cd0cb48a74f2e","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":17996971,"name":"augmented-traffic-control","full_name":"facebook/augmented-traffic-control","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/augmented-traffic-control","description":"Augmented Traffic Control: A tool to simulate network conditions","fork":false,"url":"https://api.github.com/repos/facebook/augmented-traffic-control","forks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/forks","keys_url":"https://api.github.com/repos/facebook/augmented-traffic-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/augmented-traffic-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/augmented-traffic-control/teams","hooks_url":"https://api.github.com/repos/facebook/augmented-traffic-control/hooks","issue_events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/augmented-traffic-control/events","assignees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/augmented-traffic-control/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/tags","blobs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/augmented-traffic-control/languages","stargazers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/stargazers","contributors_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contributors","subscribers_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscribers","subscription_url":"https://api.github.com/repos/facebook/augmented-traffic-control/subscription","commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/augmented-traffic-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/augmented-traffic-control/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/augmented-traffic-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/augmented-traffic-control/merges","archive_url":"https://api.github.com/repos/facebook/augmented-traffic-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/augmented-traffic-control/downloads","issues_url":"https://api.github.com/repos/facebook/augmented-traffic-control/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/augmented-traffic-control/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/augmented-traffic-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/augmented-traffic-control/labels{/name}","releases_url":"https://api.github.com/repos/facebook/augmented-traffic-control/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/augmented-traffic-control/deployments","created_at":"2014-03-21T22:58:17Z","updated_at":"2016-05-24T17:09:35Z","pushed_at":"2016-05-26T00:45:52Z","git_url":"git://github.com/facebook/augmented-traffic-control.git","ssh_url":"git@github.com:facebook/augmented-traffic-control.git","clone_url":"https://github.com/facebook/augmented-traffic-control.git","svn_url":"https://github.com/facebook/augmented-traffic-control","homepage":"https://facebook.github.io/augmented-traffic-control","size":11951,"stargazers_count":2946,"watchers_count":2946,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":419,"mirror_url":null,"open_issues_count":14,"forks":419,"open_issues":14,"watchers":2946,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273"},"html":{"href":"https://github.com/facebook/augmented-traffic-control/pull/273"},"issue":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/273"},"comments":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/augmented-traffic-control/statuses/0b0feed2620cb167634ed011faaf85e35a880c9c"}}}}
{"actor":{"display_login":"zfjagann"}}