{"action":"created","comment":{"url":"https://api.github.com/repos/IRATI/stack/pulls/comments/51574928","id":51574928,"diff_hunk":"@@ -357,7 +357,7 @@ void* ActiveWorker::run(void* param)\n \t\t\tLOG_DBG(\"Connection stablished between MAD and Manager (port id: %u)\", port_id);\n \n \t\t\t//I/O loop\n-\t\t\twhile(true) {\n+\t\t\twhile(keep_running) {","path":"rinad/src/ipcm/addons/ma/flowm.cc","position":5,"original_position":5,"commit_id":"526a986178df8478a0b223ec7c212e725b6adc65","original_commit_id":"526a986178df8478a0b223ec7c212e725b6adc65","user":{"login":"bernatgaston","id":6225187,"avatar_url":"https://avatars.githubusercontent.com/u/6225187?v=3","gravatar_id":"","url":"https://api.github.com/users/bernatgaston","html_url":"https://github.com/bernatgaston","followers_url":"https://api.github.com/users/bernatgaston/followers","following_url":"https://api.github.com/users/bernatgaston/following{/other_user}","gists_url":"https://api.github.com/users/bernatgaston/gists{/gist_id}","starred_url":"https://api.github.com/users/bernatgaston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernatgaston/subscriptions","organizations_url":"https://api.github.com/users/bernatgaston/orgs","repos_url":"https://api.github.com/users/bernatgaston/repos","events_url":"https://api.github.com/users/bernatgaston/events{/privacy}","received_events_url":"https://api.github.com/users/bernatgaston/received_events","type":"User","site_admin":false},"body":"This change was not the cause of the problem but I thought it was useful (the outer loop has this condition) but I didn't remember the exception... you are true. I am repushing","created_at":"2016-02-02T14:33:09Z","updated_at":"2016-02-02T14:33:09Z","html_url":"https://github.com/IRATI/stack/pull/853#discussion_r51574928","pull_request_url":"https://api.github.com/repos/IRATI/stack/pulls/853","_links":{"self":{"href":"https://api.github.com/repos/IRATI/stack/pulls/comments/51574928"},"html":{"href":"https://github.com/IRATI/stack/pull/853#discussion_r51574928"},"pull_request":{"href":"https://api.github.com/repos/IRATI/stack/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/IRATI/stack/pulls/853","id":57958994,"html_url":"https://github.com/IRATI/stack/pull/853","diff_url":"https://github.com/IRATI/stack/pull/853.diff","patch_url":"https://github.com/IRATI/stack/pull/853.patch","issue_url":"https://api.github.com/repos/IRATI/stack/issues/853","number":853,"state":"open","locked":false,"title":"MA stuck when closing flows","user":{"login":"bernatgaston","id":6225187,"avatar_url":"https://avatars.githubusercontent.com/u/6225187?v=3","gravatar_id":"","url":"https://api.github.com/users/bernatgaston","html_url":"https://github.com/bernatgaston","followers_url":"https://api.github.com/users/bernatgaston/followers","following_url":"https://api.github.com/users/bernatgaston/following{/other_user}","gists_url":"https://api.github.com/users/bernatgaston/gists{/gist_id}","starred_url":"https://api.github.com/users/bernatgaston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernatgaston/subscriptions","organizations_url":"https://api.github.com/users/bernatgaston/orgs","repos_url":"https://api.github.com/users/bernatgaston/repos","events_url":"https://api.github.com/users/bernatgaston/events{/privacy}","received_events_url":"https://api.github.com/users/bernatgaston/received_events","type":"User","site_admin":false},"body":"Fixes #851 . The order of destroying IPCP and addons has been changed.\r\nNow, IPCPs are destroyed before addons to avoid the MA being stuck on\r\nthe threads reading these IPCPs. Moreover, the loop of the MA reading\r\non the flows have been changed to allow exit from this loop.\r\n\r\nack @edugrasa ","created_at":"2016-02-02T09:16:39Z","updated_at":"2016-02-02T14:33:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5929fd472c55f25849e9db64cb44514b8918437","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IRATI/stack/pulls/853/commits","review_comments_url":"https://api.github.com/repos/IRATI/stack/pulls/853/comments","review_comment_url":"https://api.github.com/repos/IRATI/stack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IRATI/stack/issues/853/comments","statuses_url":"https://api.github.com/repos/IRATI/stack/statuses/526a986178df8478a0b223ec7c212e725b6adc65","head":{"label":"bernatgaston:pristine-1.4_MA_stuck","ref":"pristine-1.4_MA_stuck","sha":"526a986178df8478a0b223ec7c212e725b6adc65","user":{"login":"bernatgaston","id":6225187,"avatar_url":"https://avatars.githubusercontent.com/u/6225187?v=3","gravatar_id":"","url":"https://api.github.com/users/bernatgaston","html_url":"https://github.com/bernatgaston","followers_url":"https://api.github.com/users/bernatgaston/followers","following_url":"https://api.github.com/users/bernatgaston/following{/other_user}","gists_url":"https://api.github.com/users/bernatgaston/gists{/gist_id}","starred_url":"https://api.github.com/users/bernatgaston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernatgaston/subscriptions","organizations_url":"https://api.github.com/users/bernatgaston/orgs","repos_url":"https://api.github.com/users/bernatgaston/repos","events_url":"https://api.github.com/users/bernatgaston/events{/privacy}","received_events_url":"https://api.github.com/users/bernatgaston/received_events","type":"User","site_admin":false},"repo":{"id":30639520,"name":"stack","full_name":"bernatgaston/stack","owner":{"login":"bernatgaston","id":6225187,"avatar_url":"https://avatars.githubusercontent.com/u/6225187?v=3","gravatar_id":"","url":"https://api.github.com/users/bernatgaston","html_url":"https://github.com/bernatgaston","followers_url":"https://api.github.com/users/bernatgaston/followers","following_url":"https://api.github.com/users/bernatgaston/following{/other_user}","gists_url":"https://api.github.com/users/bernatgaston/gists{/gist_id}","starred_url":"https://api.github.com/users/bernatgaston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernatgaston/subscriptions","organizations_url":"https://api.github.com/users/bernatgaston/orgs","repos_url":"https://api.github.com/users/bernatgaston/repos","events_url":"https://api.github.com/users/bernatgaston/events{/privacy}","received_events_url":"https://api.github.com/users/bernatgaston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bernatgaston/stack","description":"RINA implementation for OS/Linux","fork":true,"url":"https://api.github.com/repos/bernatgaston/stack","forks_url":"https://api.github.com/repos/bernatgaston/stack/forks","keys_url":"https://api.github.com/repos/bernatgaston/stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bernatgaston/stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bernatgaston/stack/teams","hooks_url":"https://api.github.com/repos/bernatgaston/stack/hooks","issue_events_url":"https://api.github.com/repos/bernatgaston/stack/issues/events{/number}","events_url":"https://api.github.com/repos/bernatgaston/stack/events","assignees_url":"https://api.github.com/repos/bernatgaston/stack/assignees{/user}","branches_url":"https://api.github.com/repos/bernatgaston/stack/branches{/branch}","tags_url":"https://api.github.com/repos/bernatgaston/stack/tags","blobs_url":"https://api.github.com/repos/bernatgaston/stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bernatgaston/stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bernatgaston/stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/bernatgaston/stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bernatgaston/stack/statuses/{sha}","languages_url":"https://api.github.com/repos/bernatgaston/stack/languages","stargazers_url":"https://api.github.com/repos/bernatgaston/stack/stargazers","contributors_url":"https://api.github.com/repos/bernatgaston/stack/contributors","subscribers_url":"https://api.github.com/repos/bernatgaston/stack/subscribers","subscription_url":"https://api.github.com/repos/bernatgaston/stack/subscription","commits_url":"https://api.github.com/repos/bernatgaston/stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/bernatgaston/stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/bernatgaston/stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/bernatgaston/stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/bernatgaston/stack/contents/{+path}","compare_url":"https://api.github.com/repos/bernatgaston/stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bernatgaston/stack/merges","archive_url":"https://api.github.com/repos/bernatgaston/stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bernatgaston/stack/downloads","issues_url":"https://api.github.com/repos/bernatgaston/stack/issues{/number}","pulls_url":"https://api.github.com/repos/bernatgaston/stack/pulls{/number}","milestones_url":"https://api.github.com/repos/bernatgaston/stack/milestones{/number}","notifications_url":"https://api.github.com/repos/bernatgaston/stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bernatgaston/stack/labels{/name}","releases_url":"https://api.github.com/repos/bernatgaston/stack/releases{/id}","deployments_url":"https://api.github.com/repos/bernatgaston/stack/deployments","created_at":"2015-02-11T09:07:29Z","updated_at":"2015-02-11T09:11:15Z","pushed_at":"2016-02-02T14:23:59Z","git_url":"git://github.com/bernatgaston/stack.git","ssh_url":"git@github.com:bernatgaston/stack.git","clone_url":"https://github.com/bernatgaston/stack.git","svn_url":"https://github.com/bernatgaston/stack","homepage":"http://irati.github.io/stack","size":250169,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IRATI:pristine-1.4","ref":"pristine-1.4","sha":"dee5f39bf37189dd3493da7a614c21d0b9ce6165","user":{"login":"IRATI","id":9579648,"avatar_url":"https://avatars.githubusercontent.com/u/9579648?v=3","gravatar_id":"","url":"https://api.github.com/users/IRATI","html_url":"https://github.com/IRATI","followers_url":"https://api.github.com/users/IRATI/followers","following_url":"https://api.github.com/users/IRATI/following{/other_user}","gists_url":"https://api.github.com/users/IRATI/gists{/gist_id}","starred_url":"https://api.github.com/users/IRATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IRATI/subscriptions","organizations_url":"https://api.github.com/users/IRATI/orgs","repos_url":"https://api.github.com/users/IRATI/repos","events_url":"https://api.github.com/users/IRATI/events{/privacy}","received_events_url":"https://api.github.com/users/IRATI/received_events","type":"Organization","site_admin":false},"repo":{"id":26241846,"name":"stack","full_name":"IRATI/stack","owner":{"login":"IRATI","id":9579648,"avatar_url":"https://avatars.githubusercontent.com/u/9579648?v=3","gravatar_id":"","url":"https://api.github.com/users/IRATI","html_url":"https://github.com/IRATI","followers_url":"https://api.github.com/users/IRATI/followers","following_url":"https://api.github.com/users/IRATI/following{/other_user}","gists_url":"https://api.github.com/users/IRATI/gists{/gist_id}","starred_url":"https://api.github.com/users/IRATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IRATI/subscriptions","organizations_url":"https://api.github.com/users/IRATI/orgs","repos_url":"https://api.github.com/users/IRATI/repos","events_url":"https://api.github.com/users/IRATI/events{/privacy}","received_events_url":"https://api.github.com/users/IRATI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IRATI/stack","description":"RINA implementation for OS/Linux","fork":false,"url":"https://api.github.com/repos/IRATI/stack","forks_url":"https://api.github.com/repos/IRATI/stack/forks","keys_url":"https://api.github.com/repos/IRATI/stack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IRATI/stack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IRATI/stack/teams","hooks_url":"https://api.github.com/repos/IRATI/stack/hooks","issue_events_url":"https://api.github.com/repos/IRATI/stack/issues/events{/number}","events_url":"https://api.github.com/repos/IRATI/stack/events","assignees_url":"https://api.github.com/repos/IRATI/stack/assignees{/user}","branches_url":"https://api.github.com/repos/IRATI/stack/branches{/branch}","tags_url":"https://api.github.com/repos/IRATI/stack/tags","blobs_url":"https://api.github.com/repos/IRATI/stack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IRATI/stack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IRATI/stack/git/refs{/sha}","trees_url":"https://api.github.com/repos/IRATI/stack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IRATI/stack/statuses/{sha}","languages_url":"https://api.github.com/repos/IRATI/stack/languages","stargazers_url":"https://api.github.com/repos/IRATI/stack/stargazers","contributors_url":"https://api.github.com/repos/IRATI/stack/contributors","subscribers_url":"https://api.github.com/repos/IRATI/stack/subscribers","subscription_url":"https://api.github.com/repos/IRATI/stack/subscription","commits_url":"https://api.github.com/repos/IRATI/stack/commits{/sha}","git_commits_url":"https://api.github.com/repos/IRATI/stack/git/commits{/sha}","comments_url":"https://api.github.com/repos/IRATI/stack/comments{/number}","issue_comment_url":"https://api.github.com/repos/IRATI/stack/issues/comments{/number}","contents_url":"https://api.github.com/repos/IRATI/stack/contents/{+path}","compare_url":"https://api.github.com/repos/IRATI/stack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IRATI/stack/merges","archive_url":"https://api.github.com/repos/IRATI/stack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IRATI/stack/downloads","issues_url":"https://api.github.com/repos/IRATI/stack/issues{/number}","pulls_url":"https://api.github.com/repos/IRATI/stack/pulls{/number}","milestones_url":"https://api.github.com/repos/IRATI/stack/milestones{/number}","notifications_url":"https://api.github.com/repos/IRATI/stack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IRATI/stack/labels{/name}","releases_url":"https://api.github.com/repos/IRATI/stack/releases{/id}","deployments_url":"https://api.github.com/repos/IRATI/stack/deployments","created_at":"2014-11-05T22:04:17Z","updated_at":"2016-01-04T13:43:33Z","pushed_at":"2016-02-02T14:25:18Z","git_url":"git://github.com/IRATI/stack.git","ssh_url":"git@github.com:IRATI/stack.git","clone_url":"https://github.com/IRATI/stack.git","svn_url":"https://github.com/IRATI/stack","homepage":"http://irati.github.io/stack","size":250296,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":78,"forks":24,"open_issues":78,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IRATI/stack/pulls/853"},"html":{"href":"https://github.com/IRATI/stack/pull/853"},"issue":{"href":"https://api.github.com/repos/IRATI/stack/issues/853"},"comments":{"href":"https://api.github.com/repos/IRATI/stack/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/IRATI/stack/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/IRATI/stack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IRATI/stack/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/IRATI/stack/statuses/526a986178df8478a0b223ec7c212e725b6adc65"}}}}