{"action":"created","comment":{"url":"https://api.github.com/repos/NetSys/quilt/pulls/comments/81903967","pull_request_review_id":2849337,"id":81903967,"diff_hunk":"@@ -1055,13 +1107,31 @@ func updateNameservers(dk docker.Client, containers []db.Container) {\n \tmatches := nsRE.FindAllString(string(hostResolv), -1)\n \tnewNameservers := strings.Join(matches, \"\\n\")\n \n+\tcontainerChan := make(chan db.Container)\n+\tvar nsWG sync.WaitGroup\n+\tnsWG.Add(concurrencyLimit)\n+\tfor i := 0; i < concurrencyLimit; i++ {\n+\t\tgo func() {\n+\t\t\tupdateNS(dk, newNameservers, containerChan)\n+\t\t\tnsWG.Done()\n+\t\t}()\n+\t}\n+\n \tfor _, dbc := range containers {\n+\t\tcontainerChan <- dbc\n+\t}\n+\tclose(containerChan)\n+\tnsWG.Wait()\n+}","path":"minion/network/worker.go","position":199,"original_position":178,"commit_id":"1398175bcb00283079e7c944a58e7e1eab015842","original_commit_id":"8550d331bab86fcfcad92a02c7b1888c127b670f","user":{"login":"ejj","id":620438,"avatar_url":"https://avatars.githubusercontent.com/u/620438?v=3","gravatar_id":"","url":"https://api.github.com/users/ejj","html_url":"https://github.com/ejj","followers_url":"https://api.github.com/users/ejj/followers","following_url":"https://api.github.com/users/ejj/following{/other_user}","gists_url":"https://api.github.com/users/ejj/gists{/gist_id}","starred_url":"https://api.github.com/users/ejj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejj/subscriptions","organizations_url":"https://api.github.com/users/ejj/orgs","repos_url":"https://api.github.com/users/ejj/repos","events_url":"https://api.github.com/users/ejj/events{/privacy}","received_events_url":"https://api.github.com/users/ejj/received_events","type":"User","site_admin":false},"body":"Should be a newline after this closing bracket.","created_at":"2016-10-05T05:46:26Z","updated_at":"2016-10-05T05:50:39Z","html_url":"https://github.com/NetSys/quilt/pull/537#discussion_r81903967","pull_request_url":"https://api.github.com/repos/NetSys/quilt/pulls/537","_links":{"self":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/comments/81903967"},"html":{"href":"https://github.com/NetSys/quilt/pull/537#discussion_r81903967"},"pull_request":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/537"}}},"pull_request":{"url":"https://api.github.com/repos/NetSys/quilt/pulls/537","id":87255540,"html_url":"https://github.com/NetSys/quilt/pull/537","diff_url":"https://github.com/NetSys/quilt/pull/537.diff","patch_url":"https://github.com/NetSys/quilt/pull/537.patch","issue_url":"https://api.github.com/repos/NetSys/quilt/issues/537","number":537,"state":"open","locked":false,"title":"Scale fixes","user":{"login":"mmussomele","id":8631959,"avatar_url":"https://avatars.githubusercontent.com/u/8631959?v=3","gravatar_id":"","url":"https://api.github.com/users/mmussomele","html_url":"https://github.com/mmussomele","followers_url":"https://api.github.com/users/mmussomele/followers","following_url":"https://api.github.com/users/mmussomele/following{/other_user}","gists_url":"https://api.github.com/users/mmussomele/gists{/gist_id}","starred_url":"https://api.github.com/users/mmussomele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmussomele/subscriptions","organizations_url":"https://api.github.com/users/mmussomele/orgs","repos_url":"https://api.github.com/users/mmussomele/repos","events_url":"https://api.github.com/users/mmussomele/events{/privacy}","received_events_url":"https://api.github.com/users/mmussomele/received_events","type":"User","site_admin":false},"body":"Series of bug fixes, optimizations and convenience patches I made while performing scale testing. These are independent of the scale tester itself.","created_at":"2016-09-29T06:52:44Z","updated_at":"2016-10-05T05:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68e3d0c3282f2cbeb3e1e8034375d82ca798f72a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetSys/quilt/pulls/537/commits","review_comments_url":"https://api.github.com/repos/NetSys/quilt/pulls/537/comments","review_comment_url":"https://api.github.com/repos/NetSys/quilt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetSys/quilt/issues/537/comments","statuses_url":"https://api.github.com/repos/NetSys/quilt/statuses/1398175bcb00283079e7c944a58e7e1eab015842","head":{"label":"mmussomele:scale-fixes","ref":"scale-fixes","sha":"1398175bcb00283079e7c944a58e7e1eab015842","user":{"login":"mmussomele","id":8631959,"avatar_url":"https://avatars.githubusercontent.com/u/8631959?v=3","gravatar_id":"","url":"https://api.github.com/users/mmussomele","html_url":"https://github.com/mmussomele","followers_url":"https://api.github.com/users/mmussomele/followers","following_url":"https://api.github.com/users/mmussomele/following{/other_user}","gists_url":"https://api.github.com/users/mmussomele/gists{/gist_id}","starred_url":"https://api.github.com/users/mmussomele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmussomele/subscriptions","organizations_url":"https://api.github.com/users/mmussomele/orgs","repos_url":"https://api.github.com/users/mmussomele/repos","events_url":"https://api.github.com/users/mmussomele/events{/privacy}","received_events_url":"https://api.github.com/users/mmussomele/received_events","type":"User","site_admin":false},"repo":{"id":59638410,"name":"quilt","full_name":"mmussomele/quilt","owner":{"login":"mmussomele","id":8631959,"avatar_url":"https://avatars.githubusercontent.com/u/8631959?v=3","gravatar_id":"","url":"https://api.github.com/users/mmussomele","html_url":"https://github.com/mmussomele","followers_url":"https://api.github.com/users/mmussomele/followers","following_url":"https://api.github.com/users/mmussomele/following{/other_user}","gists_url":"https://api.github.com/users/mmussomele/gists{/gist_id}","starred_url":"https://api.github.com/users/mmussomele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmussomele/subscriptions","organizations_url":"https://api.github.com/users/mmussomele/orgs","repos_url":"https://api.github.com/users/mmussomele/repos","events_url":"https://api.github.com/users/mmussomele/events{/privacy}","received_events_url":"https://api.github.com/users/mmussomele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmussomele/quilt","description":"Quilt","fork":true,"url":"https://api.github.com/repos/mmussomele/quilt","forks_url":"https://api.github.com/repos/mmussomele/quilt/forks","keys_url":"https://api.github.com/repos/mmussomele/quilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmussomele/quilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmussomele/quilt/teams","hooks_url":"https://api.github.com/repos/mmussomele/quilt/hooks","issue_events_url":"https://api.github.com/repos/mmussomele/quilt/issues/events{/number}","events_url":"https://api.github.com/repos/mmussomele/quilt/events","assignees_url":"https://api.github.com/repos/mmussomele/quilt/assignees{/user}","branches_url":"https://api.github.com/repos/mmussomele/quilt/branches{/branch}","tags_url":"https://api.github.com/repos/mmussomele/quilt/tags","blobs_url":"https://api.github.com/repos/mmussomele/quilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmussomele/quilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmussomele/quilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmussomele/quilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmussomele/quilt/statuses/{sha}","languages_url":"https://api.github.com/repos/mmussomele/quilt/languages","stargazers_url":"https://api.github.com/repos/mmussomele/quilt/stargazers","contributors_url":"https://api.github.com/repos/mmussomele/quilt/contributors","subscribers_url":"https://api.github.com/repos/mmussomele/quilt/subscribers","subscription_url":"https://api.github.com/repos/mmussomele/quilt/subscription","commits_url":"https://api.github.com/repos/mmussomele/quilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmussomele/quilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmussomele/quilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmussomele/quilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmussomele/quilt/contents/{+path}","compare_url":"https://api.github.com/repos/mmussomele/quilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmussomele/quilt/merges","archive_url":"https://api.github.com/repos/mmussomele/quilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmussomele/quilt/downloads","issues_url":"https://api.github.com/repos/mmussomele/quilt/issues{/number}","pulls_url":"https://api.github.com/repos/mmussomele/quilt/pulls{/number}","milestones_url":"https://api.github.com/repos/mmussomele/quilt/milestones{/number}","notifications_url":"https://api.github.com/repos/mmussomele/quilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmussomele/quilt/labels{/name}","releases_url":"https://api.github.com/repos/mmussomele/quilt/releases{/id}","deployments_url":"https://api.github.com/repos/mmussomele/quilt/deployments","created_at":"2016-05-25T06:53:25Z","updated_at":"2016-05-25T17:31:40Z","pushed_at":"2016-10-05T05:18:47Z","git_url":"git://github.com/mmussomele/quilt.git","ssh_url":"git@github.com:mmussomele/quilt.git","clone_url":"https://github.com/mmussomele/quilt.git","svn_url":"https://github.com/mmussomele/quilt","homepage":"","size":15823,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NetSys:master","ref":"master","sha":"364fcd7005325ab183c0650cd87d925daf6a90d8","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":43390663,"name":"quilt","full_name":"NetSys/quilt","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/quilt","description":"Quilt","fork":false,"url":"https://api.github.com/repos/NetSys/quilt","forks_url":"https://api.github.com/repos/NetSys/quilt/forks","keys_url":"https://api.github.com/repos/NetSys/quilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/quilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/quilt/teams","hooks_url":"https://api.github.com/repos/NetSys/quilt/hooks","issue_events_url":"https://api.github.com/repos/NetSys/quilt/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/quilt/events","assignees_url":"https://api.github.com/repos/NetSys/quilt/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/quilt/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/quilt/tags","blobs_url":"https://api.github.com/repos/NetSys/quilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/quilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/quilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/quilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/quilt/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/quilt/languages","stargazers_url":"https://api.github.com/repos/NetSys/quilt/stargazers","contributors_url":"https://api.github.com/repos/NetSys/quilt/contributors","subscribers_url":"https://api.github.com/repos/NetSys/quilt/subscribers","subscription_url":"https://api.github.com/repos/NetSys/quilt/subscription","commits_url":"https://api.github.com/repos/NetSys/quilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/quilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/quilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/quilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/quilt/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/quilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/quilt/merges","archive_url":"https://api.github.com/repos/NetSys/quilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/quilt/downloads","issues_url":"https://api.github.com/repos/NetSys/quilt/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/quilt/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/quilt/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/quilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/quilt/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/quilt/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/quilt/deployments","created_at":"2015-09-29T19:52:32Z","updated_at":"2016-10-04T23:01:37Z","pushed_at":"2016-10-05T05:18:48Z","git_url":"git://github.com/NetSys/quilt.git","ssh_url":"git@github.com:NetSys/quilt.git","clone_url":"https://github.com/NetSys/quilt.git","svn_url":"https://github.com/NetSys/quilt","homepage":"","size":28439,"stargazers_count":29,"watchers_count":29,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/537"},"html":{"href":"https://github.com/NetSys/quilt/pull/537"},"issue":{"href":"https://api.github.com/repos/NetSys/quilt/issues/537"},"comments":{"href":"https://api.github.com/repos/NetSys/quilt/issues/537/comments"},"review_comments":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/537/comments"},"review_comment":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/537/commits"},"statuses":{"href":"https://api.github.com/repos/NetSys/quilt/statuses/1398175bcb00283079e7c944a58e7e1eab015842"}}}}
{"actor":{"display_login":"ejj"}}