{"action":"created","issue":{"url":"https://api.github.com/repos/snabbco/snabb/issues/1039","repository_url":"https://api.github.com/repos/snabbco/snabb","labels_url":"https://api.github.com/repos/snabbco/snabb/issues/1039/labels{/name}","comments_url":"https://api.github.com/repos/snabbco/snabb/issues/1039/comments","events_url":"https://api.github.com/repos/snabbco/snabb/issues/1039/events","html_url":"https://github.com/snabbco/snabb/pull/1039","id":183409985,"number":1039,"title":"Avoid NFV reconfigure when nothing has changed","user":{"login":"wingo","id":1745903,"avatar_url":"https://avatars.githubusercontent.com/u/1745903?v=3","gravatar_id":"","url":"https://api.github.com/users/wingo","html_url":"https://github.com/wingo","followers_url":"https://api.github.com/users/wingo/followers","following_url":"https://api.github.com/users/wingo/following{/other_user}","gists_url":"https://api.github.com/users/wingo/gists{/gist_id}","starred_url":"https://api.github.com/users/wingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingo/subscriptions","organizations_url":"https://api.github.com/users/wingo/orgs","repos_url":"https://api.github.com/users/wingo/repos","events_url":"https://api.github.com/users/wingo/events{/privacy}","received_events_url":"https://api.github.com/users/wingo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lukego","id":13791,"avatar_url":"https://avatars.githubusercontent.com/u/13791?v=3","gravatar_id":"","url":"https://api.github.com/users/lukego","html_url":"https://github.com/lukego","followers_url":"https://api.github.com/users/lukego/followers","following_url":"https://api.github.com/users/lukego/following{/other_user}","gists_url":"https://api.github.com/users/lukego/gists{/gist_id}","starred_url":"https://api.github.com/users/lukego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukego/subscriptions","organizations_url":"https://api.github.com/users/lukego/orgs","repos_url":"https://api.github.com/users/lukego/repos","events_url":"https://api.github.com/users/lukego/events{/privacy}","received_events_url":"https://api.github.com/users/lukego/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukego","id":13791,"avatar_url":"https://avatars.githubusercontent.com/u/13791?v=3","gravatar_id":"","url":"https://api.github.com/users/lukego","html_url":"https://github.com/lukego","followers_url":"https://api.github.com/users/lukego/followers","following_url":"https://api.github.com/users/lukego/following{/other_user}","gists_url":"https://api.github.com/users/lukego/gists{/gist_id}","starred_url":"https://api.github.com/users/lukego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukego/subscriptions","organizations_url":"https://api.github.com/users/lukego/orgs","repos_url":"https://api.github.com/users/lukego/repos","events_url":"https://api.github.com/users/lukego/events{/privacy}","received_events_url":"https://api.github.com/users/lukego/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2016-10-17T13:02:15Z","updated_at":"2016-10-19T13:14:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/snabbco/snabb/pulls/1039","html_url":"https://github.com/snabbco/snabb/pull/1039","diff_url":"https://github.com/snabbco/snabb/pull/1039.diff","patch_url":"https://github.com/snabbco/snabb/pull/1039.patch"},"body":"[Note: this PR originally contained two unrelated changes and was edited to contain just one.  What follows is the original PR note.  See https://github.com/snabbco/snabb/pull/1039#issuecomment-254790578 for the update.]\r\n\r\nTwo changes in this PR from downstream `lwaftr` branch: one to add the \"warning\" ingress drop monitor to the NFV.  This will simply detect drops and print out a warning to the console when many drops are detected.  The second avoids calling `reconfigure` when the configuration hasn't actually changed.  The former helps us track down which part of a system is slow, and the latter is a minor perf improvement. I'll push to my `optimize` branch to see what hydra thinks."},"comment":{"url":"https://api.github.com/repos/snabbco/snabb/issues/comments/254808552","html_url":"https://github.com/snabbco/snabb/pull/1039#issuecomment-254808552","issue_url":"https://api.github.com/repos/snabbco/snabb/issues/1039","id":254808552,"user":{"login":"wingo","id":1745903,"avatar_url":"https://avatars.githubusercontent.com/u/1745903?v=3","gravatar_id":"","url":"https://api.github.com/users/wingo","html_url":"https://github.com/wingo","followers_url":"https://api.github.com/users/wingo/followers","following_url":"https://api.github.com/users/wingo/following{/other_user}","gists_url":"https://api.github.com/users/wingo/gists{/gist_id}","starred_url":"https://api.github.com/users/wingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingo/subscriptions","organizations_url":"https://api.github.com/users/wingo/orgs","repos_url":"https://api.github.com/users/wingo/repos","events_url":"https://api.github.com/users/wingo/events{/privacy}","received_events_url":"https://api.github.com/users/wingo/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T13:14:26Z","updated_at":"2016-10-19T13:14:26Z","body":"Hydra results up.  The relevant comparison is between wingo-optimize and master, as wingo-optimize is just one commit beyond master."}}
{"actor":{"display_login":"wingo"}}