{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/californium/pulls/comments/74254840","id":74254840,"diff_hunk":"@@ -17,18 +17,27 @@\n  ******************************************************************************/\n package org.eclipse.californium.elements;\n \n+import java.util.Set;\n+\n /**\n- * A container for storing transport specific information about the context\n- * in which a message has been sent or received.\n+ * A container for storing transport specific information about the context in\n+ * which a message has been sent or received.\n  */\n public interface CorrelationContext {\n \n \t/**\n \t * Gets a value from this context.\n \t * \n \t * @param key the key to retrieve the value for.\n-\t * @return the value or <code>null</code> if this context does not contain\n-\t *         a value for the given key.\n+\t * @return the value or <code>null</code> if this context does not contain a\n+\t *         value for the given key.\n \t */\n \tString get(String key);\n+\n+\t/**\n+\t * Sends the list of keys available in the context.\n+\t *\n+\t * @return list of keys set in the context.","path":"element-connector/src/main/java/org/eclipse/californium/elements/CorrelationContext.java","position":28,"original_position":28,"commit_id":"c580784d8bed4f696d6d7a8bcc7c779d154fb2b2","original_commit_id":"c580784d8bed4f696d6d7a8bcc7c779d154fb2b2","user":{"login":"sophokles73","id":5682135,"avatar_url":"https://avatars.githubusercontent.com/u/5682135?v=3","gravatar_id":"","url":"https://api.github.com/users/sophokles73","html_url":"https://github.com/sophokles73","followers_url":"https://api.github.com/users/sophokles73/followers","following_url":"https://api.github.com/users/sophokles73/following{/other_user}","gists_url":"https://api.github.com/users/sophokles73/gists{/gist_id}","starred_url":"https://api.github.com/users/sophokles73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophokles73/subscriptions","organizations_url":"https://api.github.com/users/sophokles73/orgs","repos_url":"https://api.github.com/users/sophokles73/repos","events_url":"https://api.github.com/users/sophokles73/events{/privacy}","received_events_url":"https://api.github.com/users/sophokles73/received_events","type":"User","site_admin":false},"body":"Why are you returning a `Set` if the docs say *Gets a list of ...*?\r\nIs the returned set ordered?","created_at":"2016-08-10T14:28:34Z","updated_at":"2016-08-10T14:28:34Z","html_url":"https://github.com/eclipse/californium/pull/81#discussion_r74254840","pull_request_url":"https://api.github.com/repos/eclipse/californium/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments/74254840"},"html":{"href":"https://github.com/eclipse/californium/pull/81#discussion_r74254840"},"pull_request":{"href":"https://api.github.com/repos/eclipse/californium/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/californium/pulls/81","id":80619915,"html_url":"https://github.com/eclipse/californium/pull/81","diff_url":"https://github.com/eclipse/californium/pull/81.diff","patch_url":"https://github.com/eclipse/californium/pull/81.patch","issue_url":"https://api.github.com/repos/eclipse/californium/issues/81","number":81,"state":"open","locked":false,"title":"Fixes to persist observation","user":{"login":"ingoschaal","id":6795389,"avatar_url":"https://avatars.githubusercontent.com/u/6795389?v=3","gravatar_id":"","url":"https://api.github.com/users/ingoschaal","html_url":"https://github.com/ingoschaal","followers_url":"https://api.github.com/users/ingoschaal/followers","following_url":"https://api.github.com/users/ingoschaal/following{/other_user}","gists_url":"https://api.github.com/users/ingoschaal/gists{/gist_id}","starred_url":"https://api.github.com/users/ingoschaal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingoschaal/subscriptions","organizations_url":"https://api.github.com/users/ingoschaal/orgs","repos_url":"https://api.github.com/users/ingoschaal/repos","events_url":"https://api.github.com/users/ingoschaal/events{/privacy}","received_events_url":"https://api.github.com/users/ingoschaal/received_events","type":"User","site_admin":false},"body":"Added some fixes to persist Observation in ObservationStore to a permanent store like Redis or MongoDB.\r\n\r\n- In CorrelationContex added getKeys(), this allows to store the associated context.\r\n- In UdpMatcher replaced the instantOf check of DtlsCorrelationContext. Check if in the given exchange the correlationContext with key \"KEY_SESSION_ID\" is available.\r\nOtherwise we would have to persist something like the information about the instance of the correlationContext.\r\n- Removed the cast to the DtlsCorrelationContext, because all information can be retrieved over the CorrelationContext, which is used in the isResponseRelatedToDtlsRequest and isResponseStrictlyRelatedToDtlsRequest method.\r\nAll operation can be done through the Interface.","created_at":"2016-08-09T13:28:09Z","updated_at":"2016-08-10T14:28:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bf1a4ac7b34d10083ad3af7f8b6b3174b479cf9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/californium/pulls/81/commits","review_comments_url":"https://api.github.com/repos/eclipse/californium/pulls/81/comments","review_comment_url":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/californium/issues/81/comments","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/c580784d8bed4f696d6d7a8bcc7c779d154fb2b2","head":{"label":"bsinno:fixes_to_persist_observation","ref":"fixes_to_persist_observation","sha":"c580784d8bed4f696d6d7a8bcc7c779d154fb2b2","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":52429243,"name":"californium","full_name":"bsinno/californium","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars.githubusercontent.com/u/9215699?v=3","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/californium","description":"","fork":true,"url":"https://api.github.com/repos/bsinno/californium","forks_url":"https://api.github.com/repos/bsinno/californium/forks","keys_url":"https://api.github.com/repos/bsinno/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/californium/teams","hooks_url":"https://api.github.com/repos/bsinno/californium/hooks","issue_events_url":"https://api.github.com/repos/bsinno/californium/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/californium/events","assignees_url":"https://api.github.com/repos/bsinno/californium/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/californium/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/californium/tags","blobs_url":"https://api.github.com/repos/bsinno/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/californium/languages","stargazers_url":"https://api.github.com/repos/bsinno/californium/stargazers","contributors_url":"https://api.github.com/repos/bsinno/californium/contributors","subscribers_url":"https://api.github.com/repos/bsinno/californium/subscribers","subscription_url":"https://api.github.com/repos/bsinno/californium/subscription","commits_url":"https://api.github.com/repos/bsinno/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/californium/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/californium/merges","archive_url":"https://api.github.com/repos/bsinno/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/californium/downloads","issues_url":"https://api.github.com/repos/bsinno/californium/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/californium/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/californium/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/californium/deployments","created_at":"2016-02-24T09:13:26Z","updated_at":"2016-02-24T09:13:28Z","pushed_at":"2016-08-09T13:26:40Z","git_url":"git://github.com/bsinno/californium.git","ssh_url":"git@github.com:bsinno/californium.git","clone_url":"https://github.com/bsinno/californium.git","svn_url":"https://github.com/bsinno/californium","homepage":null,"size":3036,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:2.0.x","ref":"2.0.x","sha":"967582349bc233e8e3564047cc235563c7ec00c8","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":43075480,"name":"californium","full_name":"eclipse/californium","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/californium","description":"","fork":false,"url":"https://api.github.com/repos/eclipse/californium","forks_url":"https://api.github.com/repos/eclipse/californium/forks","keys_url":"https://api.github.com/repos/eclipse/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/californium/teams","hooks_url":"https://api.github.com/repos/eclipse/californium/hooks","issue_events_url":"https://api.github.com/repos/eclipse/californium/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/californium/events","assignees_url":"https://api.github.com/repos/eclipse/californium/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/californium/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/californium/tags","blobs_url":"https://api.github.com/repos/eclipse/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/californium/languages","stargazers_url":"https://api.github.com/repos/eclipse/californium/stargazers","contributors_url":"https://api.github.com/repos/eclipse/californium/contributors","subscribers_url":"https://api.github.com/repos/eclipse/californium/subscribers","subscription_url":"https://api.github.com/repos/eclipse/californium/subscription","commits_url":"https://api.github.com/repos/eclipse/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/californium/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/californium/merges","archive_url":"https://api.github.com/repos/eclipse/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/californium/downloads","issues_url":"https://api.github.com/repos/eclipse/californium/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/californium/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/californium/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/californium/deployments","created_at":"2015-09-24T15:27:15Z","updated_at":"2016-07-06T10:48:14Z","pushed_at":"2016-08-09T13:28:09Z","git_url":"git://github.com/eclipse/californium.git","ssh_url":"git@github.com:eclipse/californium.git","clone_url":"https://github.com/eclipse/californium.git","svn_url":"https://github.com/eclipse/californium","homepage":null,"size":3674,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":27,"forks":49,"open_issues":27,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/81"},"html":{"href":"https://github.com/eclipse/californium/pull/81"},"issue":{"href":"https://api.github.com/repos/eclipse/californium/issues/81"},"comments":{"href":"https://api.github.com/repos/eclipse/californium/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/californium/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/californium/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/californium/statuses/c580784d8bed4f696d6d7a8bcc7c779d154fb2b2"}}}}
{"actor":{"display_login":"sophokles73"}}