{"action":"created","comment":{"url":"https://api.github.com/repos/dropbox/djinni/pulls/comments/50307637","id":50307637,"diff_hunk":"@@ -178,7 +178,7 @@ class ObjcGenerator(spec: Spec) extends Generator(spec) {\n     val self = marshal.typename(objcName, r)\n \n     refs.header.add(\"#import <Foundation/Foundation.h>\")\n-    refs.body.add(\"!#import \" + q(spec.objcIncludePrefix + (if (r.ext.objc) \"../\" else \"\") + marshal.headerName(ident)))\n+    refs.body.add(\"!#import \" + q(spec.objcIncludePrefix + (if (r.ext.objc) spec.objcExtendedRecordIncludePrefix else \"\") + marshal.headerName(ident)))","path":"src/source/ObjcGenerator.scala","position":5,"original_position":5,"commit_id":"c8aa9fb492d1de4803a96732d07653f37d3e5edd","original_commit_id":"c8aa9fb492d1de4803a96732d07653f37d3e5edd","user":{"login":"mknejp","id":5156768,"avatar_url":"https://avatars.githubusercontent.com/u/5156768?v=3","gravatar_id":"","url":"https://api.github.com/users/mknejp","html_url":"https://github.com/mknejp","followers_url":"https://api.github.com/users/mknejp/followers","following_url":"https://api.github.com/users/mknejp/following{/other_user}","gists_url":"https://api.github.com/users/mknejp/gists{/gist_id}","starred_url":"https://api.github.com/users/mknejp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mknejp/subscriptions","organizations_url":"https://api.github.com/users/mknejp/orgs","repos_url":"https://api.github.com/users/mknejp/repos","events_url":"https://api.github.com/users/mknejp/events{/privacy}","received_events_url":"https://api.github.com/users/mknejp/received_events","type":"User","site_admin":false},"body":"Those are two different things. `--objc-include-prefix` specifies the include path Djinni has to generate in order for the compiler to find the Objective-C files *it is generating*. `--objc-extended-record-include-prefix` specifies what include path Djinni has to generate for the compiler to find *your own handwritten code*. Those paths don't have to be related at all.","created_at":"2016-01-20T19:45:30Z","updated_at":"2016-01-20T19:45:30Z","html_url":"https://github.com/dropbox/djinni/pull/191#discussion_r50307637","pull_request_url":"https://api.github.com/repos/dropbox/djinni/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/comments/50307637"},"html":{"href":"https://github.com/dropbox/djinni/pull/191#discussion_r50307637"},"pull_request":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/dropbox/djinni/pulls/191","id":56257860,"html_url":"https://github.com/dropbox/djinni/pull/191","diff_url":"https://github.com/dropbox/djinni/pull/191.diff","patch_url":"https://github.com/dropbox/djinni/pull/191.patch","issue_url":"https://api.github.com/repos/dropbox/djinni/issues/191","number":191,"state":"open","locked":false,"title":"*** POTENTIAL BREAKING CHANGE ***","user":{"login":"guycnicholas","id":5494702,"avatar_url":"https://avatars.githubusercontent.com/u/5494702?v=3","gravatar_id":"","url":"https://api.github.com/users/guycnicholas","html_url":"https://github.com/guycnicholas","followers_url":"https://api.github.com/users/guycnicholas/followers","following_url":"https://api.github.com/users/guycnicholas/following{/other_user}","gists_url":"https://api.github.com/users/guycnicholas/gists{/gist_id}","starred_url":"https://api.github.com/users/guycnicholas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guycnicholas/subscriptions","organizations_url":"https://api.github.com/users/guycnicholas/orgs","repos_url":"https://api.github.com/users/guycnicholas/repos","events_url":"https://api.github.com/users/guycnicholas/events{/privacy}","received_events_url":"https://api.github.com/users/guycnicholas/received_events","type":"User","site_admin":false},"body":"When extending a record using the +c or +o option the resultant Objective C code includes/imports the subclass assuming it is one level above the generated source.  i.e.\r\n\t#include \"../myExtendedRecord.h\"\r\nTo make the code positioning more flexible a pair of options were added to allow the developer to indicate the path prefix:\r\n\tcpp-extended-record-include-prefix\r\n\tobjc-extended-record-include-prefix\r\n\r\nTo use these options you would write something like this:\r\n\tdjinni/src/run \\\r\n\t\t--cpp-extended-record-include-prefix \"path_to_my_src/\"\r\n\r\ndoing this will result in an include of the form:\r\n\t#include \"path_to_my_src/myExtendedRecord.h\"\r\n\r\nThe breaking change part of this is that the default is now no path, so if you are now not compiling, you probably just need to add the following to your djinni run command\r\n\t--cpp-extended-record-include-prefix \"../\"","created_at":"2016-01-16T17:06:35Z","updated_at":"2016-01-20T19:45:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93754ffeb3105f029324908d45ba7d25f47759b2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/djinni/pulls/191/commits","review_comments_url":"https://api.github.com/repos/dropbox/djinni/pulls/191/comments","review_comment_url":"https://api.github.com/repos/dropbox/djinni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/djinni/issues/191/comments","statuses_url":"https://api.github.com/repos/dropbox/djinni/statuses/c8aa9fb492d1de4803a96732d07653f37d3e5edd","head":{"label":"guycnicholas:feature_184_take_2","ref":"feature_184_take_2","sha":"c8aa9fb492d1de4803a96732d07653f37d3e5edd","user":{"login":"guycnicholas","id":5494702,"avatar_url":"https://avatars.githubusercontent.com/u/5494702?v=3","gravatar_id":"","url":"https://api.github.com/users/guycnicholas","html_url":"https://github.com/guycnicholas","followers_url":"https://api.github.com/users/guycnicholas/followers","following_url":"https://api.github.com/users/guycnicholas/following{/other_user}","gists_url":"https://api.github.com/users/guycnicholas/gists{/gist_id}","starred_url":"https://api.github.com/users/guycnicholas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guycnicholas/subscriptions","organizations_url":"https://api.github.com/users/guycnicholas/orgs","repos_url":"https://api.github.com/users/guycnicholas/repos","events_url":"https://api.github.com/users/guycnicholas/events{/privacy}","received_events_url":"https://api.github.com/users/guycnicholas/received_events","type":"User","site_admin":false},"repo":{"id":49662515,"name":"djinni","full_name":"guycnicholas/djinni","owner":{"login":"guycnicholas","id":5494702,"avatar_url":"https://avatars.githubusercontent.com/u/5494702?v=3","gravatar_id":"","url":"https://api.github.com/users/guycnicholas","html_url":"https://github.com/guycnicholas","followers_url":"https://api.github.com/users/guycnicholas/followers","following_url":"https://api.github.com/users/guycnicholas/following{/other_user}","gists_url":"https://api.github.com/users/guycnicholas/gists{/gist_id}","starred_url":"https://api.github.com/users/guycnicholas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guycnicholas/subscriptions","organizations_url":"https://api.github.com/users/guycnicholas/orgs","repos_url":"https://api.github.com/users/guycnicholas/repos","events_url":"https://api.github.com/users/guycnicholas/events{/privacy}","received_events_url":"https://api.github.com/users/guycnicholas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guycnicholas/djinni","description":"A tool for generating cross-language type declarations and interface bindings.","fork":true,"url":"https://api.github.com/repos/guycnicholas/djinni","forks_url":"https://api.github.com/repos/guycnicholas/djinni/forks","keys_url":"https://api.github.com/repos/guycnicholas/djinni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guycnicholas/djinni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guycnicholas/djinni/teams","hooks_url":"https://api.github.com/repos/guycnicholas/djinni/hooks","issue_events_url":"https://api.github.com/repos/guycnicholas/djinni/issues/events{/number}","events_url":"https://api.github.com/repos/guycnicholas/djinni/events","assignees_url":"https://api.github.com/repos/guycnicholas/djinni/assignees{/user}","branches_url":"https://api.github.com/repos/guycnicholas/djinni/branches{/branch}","tags_url":"https://api.github.com/repos/guycnicholas/djinni/tags","blobs_url":"https://api.github.com/repos/guycnicholas/djinni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guycnicholas/djinni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guycnicholas/djinni/git/refs{/sha}","trees_url":"https://api.github.com/repos/guycnicholas/djinni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guycnicholas/djinni/statuses/{sha}","languages_url":"https://api.github.com/repos/guycnicholas/djinni/languages","stargazers_url":"https://api.github.com/repos/guycnicholas/djinni/stargazers","contributors_url":"https://api.github.com/repos/guycnicholas/djinni/contributors","subscribers_url":"https://api.github.com/repos/guycnicholas/djinni/subscribers","subscription_url":"https://api.github.com/repos/guycnicholas/djinni/subscription","commits_url":"https://api.github.com/repos/guycnicholas/djinni/commits{/sha}","git_commits_url":"https://api.github.com/repos/guycnicholas/djinni/git/commits{/sha}","comments_url":"https://api.github.com/repos/guycnicholas/djinni/comments{/number}","issue_comment_url":"https://api.github.com/repos/guycnicholas/djinni/issues/comments{/number}","contents_url":"https://api.github.com/repos/guycnicholas/djinni/contents/{+path}","compare_url":"https://api.github.com/repos/guycnicholas/djinni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guycnicholas/djinni/merges","archive_url":"https://api.github.com/repos/guycnicholas/djinni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guycnicholas/djinni/downloads","issues_url":"https://api.github.com/repos/guycnicholas/djinni/issues{/number}","pulls_url":"https://api.github.com/repos/guycnicholas/djinni/pulls{/number}","milestones_url":"https://api.github.com/repos/guycnicholas/djinni/milestones{/number}","notifications_url":"https://api.github.com/repos/guycnicholas/djinni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guycnicholas/djinni/labels{/name}","releases_url":"https://api.github.com/repos/guycnicholas/djinni/releases{/id}","created_at":"2016-01-14T17:16:49Z","updated_at":"2016-01-14T17:16:50Z","pushed_at":"2016-01-19T20:47:08Z","git_url":"git://github.com/guycnicholas/djinni.git","ssh_url":"git@github.com:guycnicholas/djinni.git","clone_url":"https://github.com/guycnicholas/djinni.git","svn_url":"https://github.com/guycnicholas/djinni","homepage":"","size":2859,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"f2e355725a30831e305738d0f568138f0e997644","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":23806326,"name":"djinni","full_name":"dropbox/djinni","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/djinni","description":"A tool for generating cross-language type declarations and interface bindings.","fork":false,"url":"https://api.github.com/repos/dropbox/djinni","forks_url":"https://api.github.com/repos/dropbox/djinni/forks","keys_url":"https://api.github.com/repos/dropbox/djinni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/djinni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/djinni/teams","hooks_url":"https://api.github.com/repos/dropbox/djinni/hooks","issue_events_url":"https://api.github.com/repos/dropbox/djinni/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/djinni/events","assignees_url":"https://api.github.com/repos/dropbox/djinni/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/djinni/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/djinni/tags","blobs_url":"https://api.github.com/repos/dropbox/djinni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/djinni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/djinni/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/djinni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/djinni/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/djinni/languages","stargazers_url":"https://api.github.com/repos/dropbox/djinni/stargazers","contributors_url":"https://api.github.com/repos/dropbox/djinni/contributors","subscribers_url":"https://api.github.com/repos/dropbox/djinni/subscribers","subscription_url":"https://api.github.com/repos/dropbox/djinni/subscription","commits_url":"https://api.github.com/repos/dropbox/djinni/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/djinni/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/djinni/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/djinni/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/djinni/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/djinni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/djinni/merges","archive_url":"https://api.github.com/repos/dropbox/djinni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/djinni/downloads","issues_url":"https://api.github.com/repos/dropbox/djinni/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/djinni/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/djinni/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/djinni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/djinni/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/djinni/releases{/id}","created_at":"2014-09-08T20:09:32Z","updated_at":"2016-01-20T06:12:38Z","pushed_at":"2016-01-19T20:47:09Z","git_url":"git://github.com/dropbox/djinni.git","ssh_url":"git@github.com:dropbox/djinni.git","clone_url":"https://github.com/dropbox/djinni.git","svn_url":"https://github.com/dropbox/djinni","homepage":"","size":3467,"stargazers_count":941,"watchers_count":941,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":47,"forks":133,"open_issues":47,"watchers":941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/191"},"html":{"href":"https://github.com/dropbox/djinni/pull/191"},"issue":{"href":"https://api.github.com/repos/dropbox/djinni/issues/191"},"comments":{"href":"https://api.github.com/repos/dropbox/djinni/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/djinni/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/djinni/statuses/c8aa9fb492d1de4803a96732d07653f37d3e5edd"}}}}