{"action":"created","issue":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager/issues/4","repository_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager","labels_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager/issues/4/comments","events_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager/issues/4/events","html_url":"https://github.com/segment-integrations/analytics.js-integration-google-tag-manager/pull/4","id":164170539,"number":4,"title":"push userId to data layer for track calls","user":{"login":"hankim813","id":5907121,"avatar_url":"https://avatars.githubusercontent.com/u/5907121?v=3","gravatar_id":"","url":"https://api.github.com/users/hankim813","html_url":"https://github.com/hankim813","followers_url":"https://api.github.com/users/hankim813/followers","following_url":"https://api.github.com/users/hankim813/following{/other_user}","gists_url":"https://api.github.com/users/hankim813/gists{/gist_id}","starred_url":"https://api.github.com/users/hankim813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hankim813/subscriptions","organizations_url":"https://api.github.com/users/hankim813/orgs","repos_url":"https://api.github.com/users/hankim813/repos","events_url":"https://api.github.com/users/hankim813/events{/privacy}","received_events_url":"https://api.github.com/users/hankim813/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-06T20:49:41Z","updated_at":"2016-07-12T22:19:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager/pulls/4","html_url":"https://github.com/segment-integrations/analytics.js-integration-google-tag-manager/pull/4","diff_url":"https://github.com/segment-integrations/analytics.js-integration-google-tag-manager/pull/4.diff","patch_url":"https://github.com/segment-integrations/analytics.js-integration-google-tag-manager/pull/4.patch"},"body":"fixes https://segment.atlassian.net/browse/INT-450 \r\n\r\n@sperand-io \r\n\r\nfyi -- i think we should modify the ajs-tester so that it updates the `analytics.user()` object when you call `analytics.identify()`. Right now it does not do that, meaning that in the `lib/index` I have to use the `analytics.user().id()` to grab the `userId` vs. being able to just use `track.userId()` since the only way to test it is to set the id of the user object directly by using `analytics.user().id(<ID>)`\r\n\r\nOr the facade `.userId()` function should fallback on checking the `analytics.user` object -- Right now it just looks up the `.field('userId')` \r\n\r\nDO NOT MERGE: waiting until rollout\r\n\r\nTODO:\r\n\r\n- [ ] deploy\r\n- [ ] update docs https://github.com/segmentio/site-docs/pull/1556\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager/issues/comments/232199558","html_url":"https://github.com/segment-integrations/analytics.js-integration-google-tag-manager/pull/4#issuecomment-232199558","issue_url":"https://api.github.com/repos/segment-integrations/analytics.js-integration-google-tag-manager/issues/4","id":232199558,"user":{"login":"jgershen","id":461246,"avatar_url":"https://avatars.githubusercontent.com/u/461246?v=3","gravatar_id":"","url":"https://api.github.com/users/jgershen","html_url":"https://github.com/jgershen","followers_url":"https://api.github.com/users/jgershen/followers","following_url":"https://api.github.com/users/jgershen/following{/other_user}","gists_url":"https://api.github.com/users/jgershen/gists{/gist_id}","starred_url":"https://api.github.com/users/jgershen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgershen/subscriptions","organizations_url":"https://api.github.com/users/jgershen/orgs","repos_url":"https://api.github.com/users/jgershen/repos","events_url":"https://api.github.com/users/jgershen/events{/privacy}","received_events_url":"https://api.github.com/users/jgershen/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T22:19:56Z","updated_at":"2016-07-12T22:19:56Z","body":"@hankim813 LGTM"}}
{"actor":{"display_login":"jgershen"}}