{"action":"created","comment":{"url":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/comments/85045034","pull_request_review_id":5783553,"id":85045034,"diff_hunk":"@@ -0,0 +1,34 @@\n+use core_foundation_sys::base::{OSStatus, CFTypeRef};\n+use libc::{c_char, c_void};\n+\n+use base::{SecKeychainItemRef, SecKeychainRef};\n+\n+extern \"C\" {\n+    #[cfg(target_os = \"macos\")]\n+    pub fn SecKeychainFindGenericPassword(keychainkeychainOrArray: CFTypeRef,","path":"security-framework-sys/src/passwords.rs","position":8,"original_position":8,"commit_id":"bf1c60b0a7ab3fd4891df7c63a5d844e36c4aa83","original_commit_id":"bf1c60b0a7ab3fd4891df7c63a5d844e36c4aa83","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"body":"These should be placed in the module corresponding to the header in which they are defined - `keychain` in this case I believe.","created_at":"2016-10-26T03:42:55Z","updated_at":"2016-10-26T03:42:55Z","html_url":"https://github.com/sfackler/rust-security-framework/pull/17#discussion_r85045034","pull_request_url":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/comments/85045034"},"html":{"href":"https://github.com/sfackler/rust-security-framework/pull/17#discussion_r85045034"},"pull_request":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17","id":89530648,"html_url":"https://github.com/sfackler/rust-security-framework/pull/17","diff_url":"https://github.com/sfackler/rust-security-framework/pull/17.diff","patch_url":"https://github.com/sfackler/rust-security-framework/pull/17.patch","issue_url":"https://api.github.com/repos/sfackler/rust-security-framework/issues/17","number":17,"state":"open","locked":false,"title":"Add support for generic password functions.","user":{"login":"neonquill","id":845294,"avatar_url":"https://avatars.githubusercontent.com/u/845294?v=3","gravatar_id":"","url":"https://api.github.com/users/neonquill","html_url":"https://github.com/neonquill","followers_url":"https://api.github.com/users/neonquill/followers","following_url":"https://api.github.com/users/neonquill/following{/other_user}","gists_url":"https://api.github.com/users/neonquill/gists{/gist_id}","starred_url":"https://api.github.com/users/neonquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neonquill/subscriptions","organizations_url":"https://api.github.com/users/neonquill/orgs","repos_url":"https://api.github.com/users/neonquill/repos","events_url":"https://api.github.com/users/neonquill/events{/privacy}","received_events_url":"https://api.github.com/users/neonquill/received_events","type":"User","site_admin":false},"body":"I'm not sure if this is the right place to make this change (vs. creating an entirely new library), so I am completely open to recommendations on how to make this more useful.\r\n\r\nAlso, I wasn't sure how to correctly call `CFRelease` on a `SecKeychainItemRef` variable. In the end, I removed the Opaque version in `security-framework-sys/src/base.rs`.  Better alternatives welcome.\r\n\r\n - Able to get, set, modify, and delete generic passwords in the\r\n   keychain.\r\n - Only works with the default keychain search list.\r\n - Currently no support for internet passwords.\r\n - All tests pass.","created_at":"2016-10-16T16:27:06Z","updated_at":"2016-10-26T03:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82cb99bec9ad999b6f6119fc7e51dd80ca966864","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17/commits","review_comments_url":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17/comments","review_comment_url":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sfackler/rust-security-framework/issues/17/comments","statuses_url":"https://api.github.com/repos/sfackler/rust-security-framework/statuses/bf1c60b0a7ab3fd4891df7c63a5d844e36c4aa83","head":{"label":"neonquill:add-password-support","ref":"add-password-support","sha":"bf1c60b0a7ab3fd4891df7c63a5d844e36c4aa83","user":{"login":"neonquill","id":845294,"avatar_url":"https://avatars.githubusercontent.com/u/845294?v=3","gravatar_id":"","url":"https://api.github.com/users/neonquill","html_url":"https://github.com/neonquill","followers_url":"https://api.github.com/users/neonquill/followers","following_url":"https://api.github.com/users/neonquill/following{/other_user}","gists_url":"https://api.github.com/users/neonquill/gists{/gist_id}","starred_url":"https://api.github.com/users/neonquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neonquill/subscriptions","organizations_url":"https://api.github.com/users/neonquill/orgs","repos_url":"https://api.github.com/users/neonquill/repos","events_url":"https://api.github.com/users/neonquill/events{/privacy}","received_events_url":"https://api.github.com/users/neonquill/received_events","type":"User","site_admin":false},"repo":{"id":71061953,"name":"rust-security-framework","full_name":"neonquill/rust-security-framework","owner":{"login":"neonquill","id":845294,"avatar_url":"https://avatars.githubusercontent.com/u/845294?v=3","gravatar_id":"","url":"https://api.github.com/users/neonquill","html_url":"https://github.com/neonquill","followers_url":"https://api.github.com/users/neonquill/followers","following_url":"https://api.github.com/users/neonquill/following{/other_user}","gists_url":"https://api.github.com/users/neonquill/gists{/gist_id}","starred_url":"https://api.github.com/users/neonquill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neonquill/subscriptions","organizations_url":"https://api.github.com/users/neonquill/orgs","repos_url":"https://api.github.com/users/neonquill/repos","events_url":"https://api.github.com/users/neonquill/events{/privacy}","received_events_url":"https://api.github.com/users/neonquill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neonquill/rust-security-framework","description":null,"fork":true,"url":"https://api.github.com/repos/neonquill/rust-security-framework","forks_url":"https://api.github.com/repos/neonquill/rust-security-framework/forks","keys_url":"https://api.github.com/repos/neonquill/rust-security-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neonquill/rust-security-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neonquill/rust-security-framework/teams","hooks_url":"https://api.github.com/repos/neonquill/rust-security-framework/hooks","issue_events_url":"https://api.github.com/repos/neonquill/rust-security-framework/issues/events{/number}","events_url":"https://api.github.com/repos/neonquill/rust-security-framework/events","assignees_url":"https://api.github.com/repos/neonquill/rust-security-framework/assignees{/user}","branches_url":"https://api.github.com/repos/neonquill/rust-security-framework/branches{/branch}","tags_url":"https://api.github.com/repos/neonquill/rust-security-framework/tags","blobs_url":"https://api.github.com/repos/neonquill/rust-security-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neonquill/rust-security-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neonquill/rust-security-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/neonquill/rust-security-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neonquill/rust-security-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/neonquill/rust-security-framework/languages","stargazers_url":"https://api.github.com/repos/neonquill/rust-security-framework/stargazers","contributors_url":"https://api.github.com/repos/neonquill/rust-security-framework/contributors","subscribers_url":"https://api.github.com/repos/neonquill/rust-security-framework/subscribers","subscription_url":"https://api.github.com/repos/neonquill/rust-security-framework/subscription","commits_url":"https://api.github.com/repos/neonquill/rust-security-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/neonquill/rust-security-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/neonquill/rust-security-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/neonquill/rust-security-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/neonquill/rust-security-framework/contents/{+path}","compare_url":"https://api.github.com/repos/neonquill/rust-security-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neonquill/rust-security-framework/merges","archive_url":"https://api.github.com/repos/neonquill/rust-security-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neonquill/rust-security-framework/downloads","issues_url":"https://api.github.com/repos/neonquill/rust-security-framework/issues{/number}","pulls_url":"https://api.github.com/repos/neonquill/rust-security-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/neonquill/rust-security-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/neonquill/rust-security-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neonquill/rust-security-framework/labels{/name}","releases_url":"https://api.github.com/repos/neonquill/rust-security-framework/releases{/id}","deployments_url":"https://api.github.com/repos/neonquill/rust-security-framework/deployments","created_at":"2016-10-16T16:16:21Z","updated_at":"2016-10-16T16:16:22Z","pushed_at":"2016-10-16T16:17:43Z","git_url":"git://github.com/neonquill/rust-security-framework.git","ssh_url":"git@github.com:neonquill/rust-security-framework.git","clone_url":"https://github.com/neonquill/rust-security-framework.git","svn_url":"https://github.com/neonquill/rust-security-framework","homepage":null,"size":1927,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sfackler:master","ref":"master","sha":"003e4d241e61a151164155ade00ee02a99b8ff3b","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"repo":{"id":41080105,"name":"rust-security-framework","full_name":"sfackler/rust-security-framework","owner":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfackler/rust-security-framework","description":null,"fork":false,"url":"https://api.github.com/repos/sfackler/rust-security-framework","forks_url":"https://api.github.com/repos/sfackler/rust-security-framework/forks","keys_url":"https://api.github.com/repos/sfackler/rust-security-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfackler/rust-security-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfackler/rust-security-framework/teams","hooks_url":"https://api.github.com/repos/sfackler/rust-security-framework/hooks","issue_events_url":"https://api.github.com/repos/sfackler/rust-security-framework/issues/events{/number}","events_url":"https://api.github.com/repos/sfackler/rust-security-framework/events","assignees_url":"https://api.github.com/repos/sfackler/rust-security-framework/assignees{/user}","branches_url":"https://api.github.com/repos/sfackler/rust-security-framework/branches{/branch}","tags_url":"https://api.github.com/repos/sfackler/rust-security-framework/tags","blobs_url":"https://api.github.com/repos/sfackler/rust-security-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfackler/rust-security-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfackler/rust-security-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfackler/rust-security-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfackler/rust-security-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/sfackler/rust-security-framework/languages","stargazers_url":"https://api.github.com/repos/sfackler/rust-security-framework/stargazers","contributors_url":"https://api.github.com/repos/sfackler/rust-security-framework/contributors","subscribers_url":"https://api.github.com/repos/sfackler/rust-security-framework/subscribers","subscription_url":"https://api.github.com/repos/sfackler/rust-security-framework/subscription","commits_url":"https://api.github.com/repos/sfackler/rust-security-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfackler/rust-security-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfackler/rust-security-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfackler/rust-security-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfackler/rust-security-framework/contents/{+path}","compare_url":"https://api.github.com/repos/sfackler/rust-security-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfackler/rust-security-framework/merges","archive_url":"https://api.github.com/repos/sfackler/rust-security-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfackler/rust-security-framework/downloads","issues_url":"https://api.github.com/repos/sfackler/rust-security-framework/issues{/number}","pulls_url":"https://api.github.com/repos/sfackler/rust-security-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/sfackler/rust-security-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/sfackler/rust-security-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfackler/rust-security-framework/labels{/name}","releases_url":"https://api.github.com/repos/sfackler/rust-security-framework/releases{/id}","deployments_url":"https://api.github.com/repos/sfackler/rust-security-framework/deployments","created_at":"2015-08-20T06:45:52Z","updated_at":"2016-10-23T17:44:08Z","pushed_at":"2016-10-23T17:44:07Z","git_url":"git://github.com/sfackler/rust-security-framework.git","ssh_url":"git@github.com:sfackler/rust-security-framework.git","clone_url":"https://github.com/sfackler/rust-security-framework.git","svn_url":"https://github.com/sfackler/rust-security-framework","homepage":null,"size":1942,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17"},"html":{"href":"https://github.com/sfackler/rust-security-framework/pull/17"},"issue":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/issues/17"},"comments":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/sfackler/rust-security-framework/statuses/bf1c60b0a7ab3fd4891df7c63a5d844e36c4aa83"}}}}
{"actor":{"display_login":"sfackler"}}