{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/1089","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/1089/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/1089/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/1089/events","html_url":"https://github.com/publiclab/plots2/pull/1089","id":194913411,"number":1089,"title":"[Staging] Changes to enable staging instance.","user":{"login":"icarito","id":199755,"avatar_url":"https://avatars.githubusercontent.com/u/199755?v=3","gravatar_id":"","url":"https://api.github.com/users/icarito","html_url":"https://github.com/icarito","followers_url":"https://api.github.com/users/icarito/followers","following_url":"https://api.github.com/users/icarito/following{/other_user}","gists_url":"https://api.github.com/users/icarito/gists{/gist_id}","starred_url":"https://api.github.com/users/icarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icarito/subscriptions","organizations_url":"https://api.github.com/users/icarito/orgs","repos_url":"https://api.github.com/users/icarito/repos","events_url":"https://api.github.com/users/icarito/events{/privacy}","received_events_url":"https://api.github.com/users/icarito/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-12-12T08:13:47Z","updated_at":"2016-12-13T04:04:18Z","closed_at":"2016-12-12T19:51:34Z","pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/1089","html_url":"https://github.com/publiclab/plots2/pull/1089","diff_url":"https://github.com/publiclab/plots2/pull/1089.diff","patch_url":"https://github.com/publiclab/plots2/pull/1089.patch"},"body":"Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!\r\n\r\n* [X] all tests pass -- `rake test:all`\r\n* [ ] code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)\r\n* [X] pull request is descriptively named with #number reference back to original issue\r\n* [X] if possible, multiple commits squashed if they're smaller changes\r\n* [ ] reviewed/confirmed/tested by another contributor or maintainer\r\n* [ ] `schema.rb.example` has been updated if any database migrations were added\r\n\r\nPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software\r\n\r\nWe have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.\r\n\r\nThanks!\r\n\r\nThis patch sets up Solr into its own independent container.\r\n\r\nA Travis server has been setup to build and deploy automatically upon commit to stable branch."},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/266635124","html_url":"https://github.com/publiclab/plots2/pull/1089#issuecomment-266635124","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/1089","id":266635124,"user":{"login":"icarito","id":199755,"avatar_url":"https://avatars.githubusercontent.com/u/199755?v=3","gravatar_id":"","url":"https://api.github.com/users/icarito","html_url":"https://github.com/icarito","followers_url":"https://api.github.com/users/icarito/followers","following_url":"https://api.github.com/users/icarito/following{/other_user}","gists_url":"https://api.github.com/users/icarito/gists{/gist_id}","starred_url":"https://api.github.com/users/icarito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icarito/subscriptions","organizations_url":"https://api.github.com/users/icarito/orgs","repos_url":"https://api.github.com/users/icarito/repos","events_url":"https://api.github.com/users/icarito/events{/privacy}","received_events_url":"https://api.github.com/users/icarito/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T04:04:18Z","updated_at":"2016-12-13T04:04:18Z","body":"Going deeper into this:\r\n_I honestly don't think the embedded Solr engine should be used for anything._\r\n\r\n> I'm fine with that as a policy - but we should update the README\r\n> accordingly. If this pr doesn't depend on this change in policy, perhaps we\r\n> can open an issue for it in the project repository so there's a \"paper\r\n> trail\"?\r\n\r\n> And itll be less of an issue as we shift towards using docker for the\r\n> developer install process itself, which is probably a good idea.\r\n\r\nI wasn't precise - I meant for anything user-facing. Developers should be free to use the embedded engine if it suits them best. I don't think we should require Docker for casual developers (or Java, unless they specifically want to work on Solr). Casual developers probably won't be running tests either, since Travis does this already - We need to get Travis to notice when tests fail though -> https://github.com/jywarren/web/issues/70\r\n\r\n> Gemfile.lock sounds fine -- does the install/deploy process change as a\r\n> result? This essentially locks gem versions, doesn't it?\r\n\r\nThe current practice can continue, some care should be taken to avoid committing this file accidentally (it's already in .gitignore, so to commit it you need to -f force it).\r\n\r\nEvery now and then it can be removed and created again by Bundler, when wanting to upgrade Gems."}}
{"actor":{"display_login":"icarito"}}