{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/67","id":24999196,"html_url":"https://github.com/nnhubbard/ZSSRichTextEditor/pull/67","diff_url":"https://github.com/nnhubbard/ZSSRichTextEditor/pull/67.diff","patch_url":"https://github.com/nnhubbard/ZSSRichTextEditor/pull/67.patch","issue_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/issues/67","number":67,"state":"closed","locked":false,"title":"Only show Toolbar if ZSSRichTextEditor is First Responder","user":{"login":"fabb","id":153960,"avatar_url":"https://avatars.githubusercontent.com/u/153960?v=3","gravatar_id":"","url":"https://api.github.com/users/fabb","html_url":"https://github.com/fabb","followers_url":"https://api.github.com/users/fabb/followers","following_url":"https://api.github.com/users/fabb/following{/other_user}","gists_url":"https://api.github.com/users/fabb/gists{/gist_id}","starred_url":"https://api.github.com/users/fabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabb/subscriptions","organizations_url":"https://api.github.com/users/fabb/orgs","repos_url":"https://api.github.com/users/fabb/repos","events_url":"https://api.github.com/users/fabb/events{/privacy}","received_events_url":"https://api.github.com/users/fabb/received_events","type":"User","site_admin":false},"body":"(!) not yet ready to merge\r\n\r\nThis fixes a part of #65.\r\n\r\n**Use Case**: A view with several `UITextField`s + `ZSSRichTextEditor` in a container view.\r\n\r\n**Fix Idea:** In `keyboardWillShowOrHide:` check if `ZSSRichTextEditor` really is the first responder. If not, do not show the toolbar.\r\n\r\n**What Works:** If the keyboard is not shown and a `UITextField` becomes active, the toolbar is not shown. When `ZSSRichTextEditor` becomes active the toolbar shows up.\r\n\r\n**Open Problems:** When `ZSSRichTextEditor` is active and the keyboard is visible, and the `UITextField` becomes active, the toolbar stays visible. This is due to the keyboard notifications not getting triggered when the `UITextField` becomes active, as the keyboard is already showing, and the `UITextField` does not have an `inputAccessoryView`.\r\n\r\nAny ideas how to fix this completely?","created_at":"2014-11-25T10:58:15Z","updated_at":"2016-09-04T21:46:31Z","closed_at":"2016-09-04T21:46:31Z","merged_at":null,"merge_commit_sha":"3c0af6b5bfdfafc77357fbe6b0308ed9b0090391","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/67/commits","review_comments_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/67/comments","review_comment_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/issues/67/comments","statuses_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/statuses/e7f064544e5558ed87d3b9890d29d24c3fe6388f","head":{"label":"fabb:fix_first_responder","ref":"fix_first_responder","sha":"e7f064544e5558ed87d3b9890d29d24c3fe6388f","user":{"login":"fabb","id":153960,"avatar_url":"https://avatars.githubusercontent.com/u/153960?v=3","gravatar_id":"","url":"https://api.github.com/users/fabb","html_url":"https://github.com/fabb","followers_url":"https://api.github.com/users/fabb/followers","following_url":"https://api.github.com/users/fabb/following{/other_user}","gists_url":"https://api.github.com/users/fabb/gists{/gist_id}","starred_url":"https://api.github.com/users/fabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabb/subscriptions","organizations_url":"https://api.github.com/users/fabb/orgs","repos_url":"https://api.github.com/users/fabb/repos","events_url":"https://api.github.com/users/fabb/events{/privacy}","received_events_url":"https://api.github.com/users/fabb/received_events","type":"User","site_admin":false},"repo":{"id":27077523,"name":"ZSSRichTextEditor","full_name":"fabb/ZSSRichTextEditor","owner":{"login":"fabb","id":153960,"avatar_url":"https://avatars.githubusercontent.com/u/153960?v=3","gravatar_id":"","url":"https://api.github.com/users/fabb","html_url":"https://github.com/fabb","followers_url":"https://api.github.com/users/fabb/followers","following_url":"https://api.github.com/users/fabb/following{/other_user}","gists_url":"https://api.github.com/users/fabb/gists{/gist_id}","starred_url":"https://api.github.com/users/fabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabb/subscriptions","organizations_url":"https://api.github.com/users/fabb/orgs","repos_url":"https://api.github.com/users/fabb/repos","events_url":"https://api.github.com/users/fabb/events{/privacy}","received_events_url":"https://api.github.com/users/fabb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabb/ZSSRichTextEditor","description":"A beautiful rich text WYSIWYG editor for iOS with a syntax highlighted source view","fork":true,"url":"https://api.github.com/repos/fabb/ZSSRichTextEditor","forks_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/forks","keys_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/teams","hooks_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/hooks","issue_events_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/issues/events{/number}","events_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/events","assignees_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/assignees{/user}","branches_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/branches{/branch}","tags_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/tags","blobs_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/statuses/{sha}","languages_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/languages","stargazers_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/stargazers","contributors_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/contributors","subscribers_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/subscribers","subscription_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/subscription","commits_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/contents/{+path}","compare_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/merges","archive_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/downloads","issues_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/issues{/number}","pulls_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/pulls{/number}","milestones_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/milestones{/number}","notifications_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/labels{/name}","releases_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/releases{/id}","deployments_url":"https://api.github.com/repos/fabb/ZSSRichTextEditor/deployments","created_at":"2014-11-24T13:46:40Z","updated_at":"2014-11-26T09:50:41Z","pushed_at":"2015-05-01T15:26:45Z","git_url":"git://github.com/fabb/ZSSRichTextEditor.git","ssh_url":"git@github.com:fabb/ZSSRichTextEditor.git","clone_url":"https://github.com/fabb/ZSSRichTextEditor.git","svn_url":"https://github.com/fabb/ZSSRichTextEditor","homepage":"","size":728,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nnhubbard:master","ref":"master","sha":"8235107b2b96b8e8de0235da91516fa1527a5e4d","user":{"login":"nnhubbard","id":30858,"avatar_url":"https://avatars.githubusercontent.com/u/30858?v=3","gravatar_id":"","url":"https://api.github.com/users/nnhubbard","html_url":"https://github.com/nnhubbard","followers_url":"https://api.github.com/users/nnhubbard/followers","following_url":"https://api.github.com/users/nnhubbard/following{/other_user}","gists_url":"https://api.github.com/users/nnhubbard/gists{/gist_id}","starred_url":"https://api.github.com/users/nnhubbard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnhubbard/subscriptions","organizations_url":"https://api.github.com/users/nnhubbard/orgs","repos_url":"https://api.github.com/users/nnhubbard/repos","events_url":"https://api.github.com/users/nnhubbard/events{/privacy}","received_events_url":"https://api.github.com/users/nnhubbard/received_events","type":"User","site_admin":false},"repo":{"id":16393248,"name":"ZSSRichTextEditor","full_name":"nnhubbard/ZSSRichTextEditor","owner":{"login":"nnhubbard","id":30858,"avatar_url":"https://avatars.githubusercontent.com/u/30858?v=3","gravatar_id":"","url":"https://api.github.com/users/nnhubbard","html_url":"https://github.com/nnhubbard","followers_url":"https://api.github.com/users/nnhubbard/followers","following_url":"https://api.github.com/users/nnhubbard/following{/other_user}","gists_url":"https://api.github.com/users/nnhubbard/gists{/gist_id}","starred_url":"https://api.github.com/users/nnhubbard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnhubbard/subscriptions","organizations_url":"https://api.github.com/users/nnhubbard/orgs","repos_url":"https://api.github.com/users/nnhubbard/repos","events_url":"https://api.github.com/users/nnhubbard/events{/privacy}","received_events_url":"https://api.github.com/users/nnhubbard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nnhubbard/ZSSRichTextEditor","description":"A beautiful rich text WYSIWYG editor for iOS with a syntax highlighted source view","fork":false,"url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor","forks_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/forks","keys_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/teams","hooks_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/hooks","issue_events_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/issues/events{/number}","events_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/events","assignees_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/assignees{/user}","branches_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/branches{/branch}","tags_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/tags","blobs_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/statuses/{sha}","languages_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/languages","stargazers_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/stargazers","contributors_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/contributors","subscribers_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/subscribers","subscription_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/subscription","commits_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/contents/{+path}","compare_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/merges","archive_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/downloads","issues_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/issues{/number}","pulls_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls{/number}","milestones_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/milestones{/number}","notifications_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/labels{/name}","releases_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/releases{/id}","deployments_url":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/deployments","created_at":"2014-01-30T22:39:12Z","updated_at":"2016-09-04T13:44:09Z","pushed_at":"2016-09-03T22:55:19Z","git_url":"git://github.com/nnhubbard/ZSSRichTextEditor.git","ssh_url":"git@github.com:nnhubbard/ZSSRichTextEditor.git","clone_url":"https://github.com/nnhubbard/ZSSRichTextEditor.git","svn_url":"https://github.com/nnhubbard/ZSSRichTextEditor","homepage":"","size":1086,"stargazers_count":1902,"watchers_count":1902,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":268,"mirror_url":null,"open_issues_count":25,"forks":268,"open_issues":25,"watchers":1902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/67"},"html":{"href":"https://github.com/nnhubbard/ZSSRichTextEditor/pull/67"},"issue":{"href":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/issues/67"},"comments":{"href":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/nnhubbard/ZSSRichTextEditor/statuses/e7f064544e5558ed87d3b9890d29d24c3fe6388f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":81,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"william205"}}