{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74682228","id":74682228,"diff_hunk":"@@ -1889,6 +1889,8 @@ type EndpointAddress struct {\n \t// Optional: Hostname of this endpoint\n \t// Meant to be used by DNS servers etc.\n \tHostname string `json:\"hostname,omitempty\"`\n+\t// Optional: Node hosting this endpoint\n+\tNodeName string `json:\"nodeName,omitempty\"`","path":"pkg/api/types.go","position":5,"original_position":5,"commit_id":"a8f06e1509b34a3790bfe121d44ad816fa7c76c6","original_commit_id":"a8f06e1509b34a3790bfe121d44ad816fa7c76c6","user":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"body":"yeah I didn't realize. I used to do it for fields that can be sensibly defaulted, like unset rc.replicas defaults to 1 because we detect a nil pointer vs a pointer to 0. ","created_at":"2016-08-13T05:38:33Z","updated_at":"2016-08-13T05:38:33Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30301#discussion_r74682228","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/74682228"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30301#discussion_r74682228"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301","id":80678277,"html_url":"https://github.com/kubernetes/kubernetes/pull/30301","diff_url":"https://github.com/kubernetes/kubernetes/pull/30301.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30301.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30301","number":30301,"state":"open","locked":false,"title":"Add NodeName to EndpointAddress object","user":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"body":"Adding a new string type `nodeName` to api.EndpointAddress.\r\nWe could also do  *ObjectReference to the api.Node object instead, which would be more precise for the future.\r\n\r\n```\r\ntype ObjectReference struct {\r\n    Kind            string    `json:\"kind,omitempty\"`\r\n    Namespace       string    `json:\"namespace,omitempty\"`\r\n    Name            string    `json:\"name,omitempty\"`\r\n    UID             types.UID `json:\"uid,omitempty\"`\r\n    APIVersion      string    `json:\"apiVersion,omitempty\"`\r\n    ResourceVersion string    `json:\"resourceVersion,omitempty\"`\r\n\r\n    // Optional. If referring to a piece of an object instead of an entire object, this string\r\n    // should contain information to identify the sub-object. For example, if the object\r\n    // reference is to a container within a pod, this would take on a value like:\r\n    // \"spec.containers{name}\" (where \"name\" refers to the name of the container that triggered\r\n    // the event) or if no container name is specified \"spec.containers[2]\" (container with\r\n    // index 2 in this pod). This syntax is chosen only to have some well-defined way of\r\n    // referencing a part of an object.\r\n    // TODO: this design is not final and this field is subject to change in the future.\r\n    FieldPath string `json:\"fieldPath,omitempty\"`\r\n}\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30301)\n<!-- Reviewable:end -->\n","created_at":"2016-08-09T19:18:04Z","updated_at":"2016-08-13T05:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e76a44e1707e88402982a343c565894d5c83b85a","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"assignees":[{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30301/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a8f06e1509b34a3790bfe121d44ad816fa7c76c6","head":{"label":"girishkalele:endpoint_hostnames","ref":"endpoint_hostnames","sha":"a8f06e1509b34a3790bfe121d44ad816fa7c76c6","user":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"repo":{"id":58407800,"name":"kubernetes","full_name":"girishkalele/kubernetes","owner":{"login":"girishkalele","id":18541549,"avatar_url":"https://avatars.githubusercontent.com/u/18541549?v=3","gravatar_id":"","url":"https://api.github.com/users/girishkalele","html_url":"https://github.com/girishkalele","followers_url":"https://api.github.com/users/girishkalele/followers","following_url":"https://api.github.com/users/girishkalele/following{/other_user}","gists_url":"https://api.github.com/users/girishkalele/gists{/gist_id}","starred_url":"https://api.github.com/users/girishkalele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girishkalele/subscriptions","organizations_url":"https://api.github.com/users/girishkalele/orgs","repos_url":"https://api.github.com/users/girishkalele/repos","events_url":"https://api.github.com/users/girishkalele/events{/privacy}","received_events_url":"https://api.github.com/users/girishkalele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/girishkalele/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/girishkalele/kubernetes","forks_url":"https://api.github.com/repos/girishkalele/kubernetes/forks","keys_url":"https://api.github.com/repos/girishkalele/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girishkalele/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girishkalele/kubernetes/teams","hooks_url":"https://api.github.com/repos/girishkalele/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/girishkalele/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/girishkalele/kubernetes/events","assignees_url":"https://api.github.com/repos/girishkalele/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/girishkalele/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/girishkalele/kubernetes/tags","blobs_url":"https://api.github.com/repos/girishkalele/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girishkalele/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girishkalele/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/girishkalele/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girishkalele/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/girishkalele/kubernetes/languages","stargazers_url":"https://api.github.com/repos/girishkalele/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/girishkalele/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/girishkalele/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/girishkalele/kubernetes/subscription","commits_url":"https://api.github.com/repos/girishkalele/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/girishkalele/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/girishkalele/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/girishkalele/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/girishkalele/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/girishkalele/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girishkalele/kubernetes/merges","archive_url":"https://api.github.com/repos/girishkalele/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girishkalele/kubernetes/downloads","issues_url":"https://api.github.com/repos/girishkalele/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/girishkalele/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/girishkalele/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/girishkalele/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girishkalele/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/girishkalele/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/girishkalele/kubernetes/deployments","created_at":"2016-05-09T20:59:15Z","updated_at":"2016-05-09T20:59:30Z","pushed_at":"2016-08-13T03:58:37Z","git_url":"git://github.com/girishkalele/kubernetes.git","ssh_url":"git@github.com:girishkalele/kubernetes.git","clone_url":"https://github.com/girishkalele/kubernetes.git","svn_url":"https://github.com/girishkalele/kubernetes","homepage":"http://kubernetes.io","size":307620,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8c81c8340f62c3ae5f2d85d700e5ff24154bf7d2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-13T05:01:42Z","pushed_at":"2016-08-13T05:08:36Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":523245,"stargazers_count":16107,"watchers_count":16107,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5120,"mirror_url":null,"open_issues_count":4158,"forks":5120,"open_issues":4158,"watchers":16107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30301"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30301"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30301/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30301/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a8f06e1509b34a3790bfe121d44ad816fa7c76c6"}}}}
{"actor":{"display_login":"bprashanth"}}