{"action":"created","comment":{"url":"https://api.github.com/repos/paypal/SeLion/pulls/comments/59399359","id":59399359,"diff_hunk":"@@ -44,14 +45,19 @@ public DesiredCapabilities getCapabilities(DesiredCapabilities capabilities) {\n         }\n         capabilities.setCapability(MOBILE_NODE_TYPE, mobileSession.getMobileNodeType().getAsString());\n         capabilities.setCapability(MobileCapabilityType.DEVICE_NAME, mobileSession.getDeviceType());\n+        if (mobileSession.getDeviceType() != null) {\n+            capabilities.setBrowserName(mobileSession.getDeviceType().toLowerCase());\n+        }\n         capabilities.setCapability(MobileCapabilityType.PLATFORM_VERSION, mobileSession.getPlatformVersion());\n         capabilities.setCapability(APPIUM_LOCALE_TYPE, mobileSession.getAppLocale());\n         capabilities.setCapability(APPIUM_LANGUAGE_TYPE, mobileSession.getAppLanguage());\n         if (mobileSession.getPlatform() == WebDriverPlatform.ANDROID) {\n             capabilities.setCapability(MobileCapabilityType.PLATFORM_NAME, APPIUM_ANDROID_PLATFORM_TYPE);\n+            capabilities.setPlatform(Platform.ANDROID);","path":"client/src/main/java/com/paypal/selion/internal/platform/grid/browsercapabilities/AppiumCapabilitiesBuilder.java","position":27,"original_position":27,"commit_id":"1b6a91ca2286abf65684ef899f484625550cde1a","original_commit_id":"1b6a91ca2286abf65684ef899f484625550cde1a","user":{"login":"mach6","id":3238999,"avatar_url":"https://avatars.githubusercontent.com/u/3238999?v=3","gravatar_id":"","url":"https://api.github.com/users/mach6","html_url":"https://github.com/mach6","followers_url":"https://api.github.com/users/mach6/followers","following_url":"https://api.github.com/users/mach6/following{/other_user}","gists_url":"https://api.github.com/users/mach6/gists{/gist_id}","starred_url":"https://api.github.com/users/mach6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mach6/subscriptions","organizations_url":"https://api.github.com/users/mach6/orgs","repos_url":"https://api.github.com/users/mach6/repos","events_url":"https://api.github.com/users/mach6/events{/privacy}","received_events_url":"https://api.github.com/users/mach6/received_events","type":"User","site_admin":false},"body":"Grids with appium nodes should have a custom capability matcher to address this. Refer to SeLion's MobileCapabilitiesMatcher in the 'server' component. Thus, I don't see the need to pass the platform desired capability.","created_at":"2016-04-12T15:41:55Z","updated_at":"2016-04-12T15:41:55Z","html_url":"https://github.com/paypal/SeLion/pull/265#discussion_r59399359","pull_request_url":"https://api.github.com/repos/paypal/SeLion/pulls/265","_links":{"self":{"href":"https://api.github.com/repos/paypal/SeLion/pulls/comments/59399359"},"html":{"href":"https://github.com/paypal/SeLion/pull/265#discussion_r59399359"},"pull_request":{"href":"https://api.github.com/repos/paypal/SeLion/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/paypal/SeLion/pulls/265","id":63856155,"html_url":"https://github.com/paypal/SeLion/pull/265","diff_url":"https://github.com/paypal/SeLion/pull/265.diff","patch_url":"https://github.com/paypal/SeLion/pull/265.patch","issue_url":"https://api.github.com/repos/paypal/SeLion/issues/265","number":265,"state":"open","locked":false,"title":"common interface for android and ios","user":{"login":"alizelzele","id":6006621,"avatar_url":"https://avatars.githubusercontent.com/u/6006621?v=3","gravatar_id":"","url":"https://api.github.com/users/alizelzele","html_url":"https://github.com/alizelzele","followers_url":"https://api.github.com/users/alizelzele/followers","following_url":"https://api.github.com/users/alizelzele/following{/other_user}","gists_url":"https://api.github.com/users/alizelzele/gists{/gist_id}","starred_url":"https://api.github.com/users/alizelzele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alizelzele/subscriptions","organizations_url":"https://api.github.com/users/alizelzele/orgs","repos_url":"https://api.github.com/users/alizelzele/repos","events_url":"https://api.github.com/users/alizelzele/events{/privacy}","received_events_url":"https://api.github.com/users/alizelzele/received_events","type":"User","site_admin":false},"body":"As discussed in #259 , this is a fork for having a common interface for both Android and Ios.\r\nthis PR contains the changes required to do the job. this Pr contains the following changes:\r\n  1- adding a new android project to sample-apps which is more like the IOS sample app version for testing.\r\n  2- changing code generator to support new system and generate files according to new requirement.\r\n  3- creating new common elements interfaces and implementing them for ios and android.\r\n  4- changing yaml reader to be able to read new style of yaml files.\r\n  5- adding some config properties for selecting platform and setting MobileElement annotation parameters from test suite.\r\n  6- changing config builder to support selenium grid with multiple appium instances with diferent platforms.\r\n  7- adding some test cases and a suite for testing if new system works properly.\r\n\r\nPlease let me know if any other change is required.","created_at":"2016-03-23T09:58:16Z","updated_at":"2016-04-12T15:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b7cb0f4f509c1f6b7b5d0bdc8f8ab69fe02f6a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/paypal/SeLion/pulls/265/commits","review_comments_url":"https://api.github.com/repos/paypal/SeLion/pulls/265/comments","review_comment_url":"https://api.github.com/repos/paypal/SeLion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/SeLion/issues/265/comments","statuses_url":"https://api.github.com/repos/paypal/SeLion/statuses/1b6a91ca2286abf65684ef899f484625550cde1a","head":{"label":"alizelzele:develop","ref":"develop","sha":"1b6a91ca2286abf65684ef899f484625550cde1a","user":{"login":"alizelzele","id":6006621,"avatar_url":"https://avatars.githubusercontent.com/u/6006621?v=3","gravatar_id":"","url":"https://api.github.com/users/alizelzele","html_url":"https://github.com/alizelzele","followers_url":"https://api.github.com/users/alizelzele/followers","following_url":"https://api.github.com/users/alizelzele/following{/other_user}","gists_url":"https://api.github.com/users/alizelzele/gists{/gist_id}","starred_url":"https://api.github.com/users/alizelzele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alizelzele/subscriptions","organizations_url":"https://api.github.com/users/alizelzele/orgs","repos_url":"https://api.github.com/users/alizelzele/repos","events_url":"https://api.github.com/users/alizelzele/events{/privacy}","received_events_url":"https://api.github.com/users/alizelzele/received_events","type":"User","site_admin":false},"repo":{"id":53311018,"name":"SeLion","full_name":"alizelzele/SeLion","owner":{"login":"alizelzele","id":6006621,"avatar_url":"https://avatars.githubusercontent.com/u/6006621?v=3","gravatar_id":"","url":"https://api.github.com/users/alizelzele","html_url":"https://github.com/alizelzele","followers_url":"https://api.github.com/users/alizelzele/followers","following_url":"https://api.github.com/users/alizelzele/following{/other_user}","gists_url":"https://api.github.com/users/alizelzele/gists{/gist_id}","starred_url":"https://api.github.com/users/alizelzele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alizelzele/subscriptions","organizations_url":"https://api.github.com/users/alizelzele/orgs","repos_url":"https://api.github.com/users/alizelzele/repos","events_url":"https://api.github.com/users/alizelzele/events{/privacy}","received_events_url":"https://api.github.com/users/alizelzele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alizelzele/SeLion","description":"Enabling Test Automation in Java","fork":true,"url":"https://api.github.com/repos/alizelzele/SeLion","forks_url":"https://api.github.com/repos/alizelzele/SeLion/forks","keys_url":"https://api.github.com/repos/alizelzele/SeLion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alizelzele/SeLion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alizelzele/SeLion/teams","hooks_url":"https://api.github.com/repos/alizelzele/SeLion/hooks","issue_events_url":"https://api.github.com/repos/alizelzele/SeLion/issues/events{/number}","events_url":"https://api.github.com/repos/alizelzele/SeLion/events","assignees_url":"https://api.github.com/repos/alizelzele/SeLion/assignees{/user}","branches_url":"https://api.github.com/repos/alizelzele/SeLion/branches{/branch}","tags_url":"https://api.github.com/repos/alizelzele/SeLion/tags","blobs_url":"https://api.github.com/repos/alizelzele/SeLion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alizelzele/SeLion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alizelzele/SeLion/git/refs{/sha}","trees_url":"https://api.github.com/repos/alizelzele/SeLion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alizelzele/SeLion/statuses/{sha}","languages_url":"https://api.github.com/repos/alizelzele/SeLion/languages","stargazers_url":"https://api.github.com/repos/alizelzele/SeLion/stargazers","contributors_url":"https://api.github.com/repos/alizelzele/SeLion/contributors","subscribers_url":"https://api.github.com/repos/alizelzele/SeLion/subscribers","subscription_url":"https://api.github.com/repos/alizelzele/SeLion/subscription","commits_url":"https://api.github.com/repos/alizelzele/SeLion/commits{/sha}","git_commits_url":"https://api.github.com/repos/alizelzele/SeLion/git/commits{/sha}","comments_url":"https://api.github.com/repos/alizelzele/SeLion/comments{/number}","issue_comment_url":"https://api.github.com/repos/alizelzele/SeLion/issues/comments{/number}","contents_url":"https://api.github.com/repos/alizelzele/SeLion/contents/{+path}","compare_url":"https://api.github.com/repos/alizelzele/SeLion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alizelzele/SeLion/merges","archive_url":"https://api.github.com/repos/alizelzele/SeLion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alizelzele/SeLion/downloads","issues_url":"https://api.github.com/repos/alizelzele/SeLion/issues{/number}","pulls_url":"https://api.github.com/repos/alizelzele/SeLion/pulls{/number}","milestones_url":"https://api.github.com/repos/alizelzele/SeLion/milestones{/number}","notifications_url":"https://api.github.com/repos/alizelzele/SeLion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alizelzele/SeLion/labels{/name}","releases_url":"https://api.github.com/repos/alizelzele/SeLion/releases{/id}","deployments_url":"https://api.github.com/repos/alizelzele/SeLion/deployments","created_at":"2016-03-07T09:02:07Z","updated_at":"2016-03-11T10:34:29Z","pushed_at":"2016-04-07T01:37:06Z","git_url":"git://github.com/alizelzele/SeLion.git","ssh_url":"git@github.com:alizelzele/SeLion.git","clone_url":"https://github.com/alizelzele/SeLion.git","svn_url":"https://github.com/alizelzele/SeLion","homepage":"http://selion.io","size":31241,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"paypal:develop","ref":"develop","sha":"e3ed9417d8894ec05eb4d0ab8ea17bfdc055ab3f","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars.githubusercontent.com/u/476675?v=3","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":22930887,"name":"SeLion","full_name":"paypal/SeLion","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars.githubusercontent.com/u/476675?v=3","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/SeLion","description":"Enabling Test Automation in Java","fork":false,"url":"https://api.github.com/repos/paypal/SeLion","forks_url":"https://api.github.com/repos/paypal/SeLion/forks","keys_url":"https://api.github.com/repos/paypal/SeLion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/SeLion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/SeLion/teams","hooks_url":"https://api.github.com/repos/paypal/SeLion/hooks","issue_events_url":"https://api.github.com/repos/paypal/SeLion/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/SeLion/events","assignees_url":"https://api.github.com/repos/paypal/SeLion/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/SeLion/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/SeLion/tags","blobs_url":"https://api.github.com/repos/paypal/SeLion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/SeLion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/SeLion/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/SeLion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/SeLion/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/SeLion/languages","stargazers_url":"https://api.github.com/repos/paypal/SeLion/stargazers","contributors_url":"https://api.github.com/repos/paypal/SeLion/contributors","subscribers_url":"https://api.github.com/repos/paypal/SeLion/subscribers","subscription_url":"https://api.github.com/repos/paypal/SeLion/subscription","commits_url":"https://api.github.com/repos/paypal/SeLion/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/SeLion/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/SeLion/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/SeLion/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/SeLion/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/SeLion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/SeLion/merges","archive_url":"https://api.github.com/repos/paypal/SeLion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/SeLion/downloads","issues_url":"https://api.github.com/repos/paypal/SeLion/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/SeLion/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/SeLion/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/SeLion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/SeLion/labels{/name}","releases_url":"https://api.github.com/repos/paypal/SeLion/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/SeLion/deployments","created_at":"2014-08-13T20:52:57Z","updated_at":"2016-04-06T06:03:45Z","pushed_at":"2016-04-12T06:19:32Z","git_url":"git://github.com/paypal/SeLion.git","ssh_url":"git@github.com:paypal/SeLion.git","clone_url":"https://github.com/paypal/SeLion.git","svn_url":"https://github.com/paypal/SeLion","homepage":"http://selion.io","size":33586,"stargazers_count":61,"watchers_count":61,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":12,"forks":97,"open_issues":12,"watchers":61,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/SeLion/pulls/265"},"html":{"href":"https://github.com/paypal/SeLion/pull/265"},"issue":{"href":"https://api.github.com/repos/paypal/SeLion/issues/265"},"comments":{"href":"https://api.github.com/repos/paypal/SeLion/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/SeLion/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/SeLion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/SeLion/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/SeLion/statuses/1b6a91ca2286abf65684ef899f484625550cde1a"}}}}