{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/79029025","id":79029025,"diff_hunk":"@@ -315,6 +323,45 @@ func (handler *ContainersHandlersImpl) GetContainerLogsHandler(params containers\n \treturn NewContainerOutputHandler(\"logs\").WithPayload(detachableOut, params.ID)\n }\n \n+func (handler *ContainersHandlersImpl) ContainerWaitHandler(params containers.ContainerWaitParams) middleware.Responder {\n+\tdefer trace.End(trace.Begin(fmt.Sprintf(\"%s:%d\", params.ID, params.Timeout)))\n+\n+\t// default context timeout in seconds\n+\tdefault_timeout := int64(180)","path":"lib/apiservers/portlayer/restapi/handlers/containers_handlers.go","position":57,"original_position":57,"commit_id":"558107a7dc7bb1daeb0026edd874e0b54bdfd1ae","original_commit_id":"558107a7dc7bb1daeb0026edd874e0b54bdfd1ae","user":{"login":"cgtexmex","id":726112,"avatar_url":"https://avatars.githubusercontent.com/u/726112?v=3","gravatar_id":"","url":"https://api.github.com/users/cgtexmex","html_url":"https://github.com/cgtexmex","followers_url":"https://api.github.com/users/cgtexmex/followers","following_url":"https://api.github.com/users/cgtexmex/following{/other_user}","gists_url":"https://api.github.com/users/cgtexmex/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtexmex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtexmex/subscriptions","organizations_url":"https://api.github.com/users/cgtexmex/orgs","repos_url":"https://api.github.com/users/cgtexmex/repos","events_url":"https://api.github.com/users/cgtexmex/events{/privacy}","received_events_url":"https://api.github.com/users/cgtexmex/received_events","type":"User","site_admin":false},"body":"apologies that's the ruby in me...","created_at":"2016-09-15T18:19:58Z","updated_at":"2016-09-15T18:19:58Z","html_url":"https://github.com/vmware/vic/pull/2304#discussion_r79029025","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2304","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/79029025"},"html":{"href":"https://github.com/vmware/vic/pull/2304#discussion_r79029025"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2304"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2304","id":84952831,"html_url":"https://github.com/vmware/vic/pull/2304","diff_url":"https://github.com/vmware/vic/pull/2304.diff","patch_url":"https://github.com/vmware/vic/pull/2304.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2304","number":2304,"state":"open","locked":false,"title":"ContainerWait","user":{"login":"cgtexmex","id":726112,"avatar_url":"https://avatars.githubusercontent.com/u/726112?v=3","gravatar_id":"","url":"https://api.github.com/users/cgtexmex","html_url":"https://github.com/cgtexmex","followers_url":"https://api.github.com/users/cgtexmex/followers","following_url":"https://api.github.com/users/cgtexmex/following{/other_user}","gists_url":"https://api.github.com/users/cgtexmex/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtexmex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtexmex/subscriptions","organizations_url":"https://api.github.com/users/cgtexmex/orgs","repos_url":"https://api.github.com/users/cgtexmex/repos","events_url":"https://api.github.com/users/cgtexmex/events{/privacy}","received_events_url":"https://api.github.com/users/cgtexmex/received_events","type":"User","site_admin":false},"body":"The primary change is to implement ContainerWait, but a few\r\nother changes were also implemented:\r\n\r\n* inspect now has the appropriate exit code\r\n* ps shows the exit code for stopped containers\r\n* fixed issue with state of containers shutdown out of band\r\n\r\nfixes #384, fixes #2310\r\n\r\n","created_at":"2016-09-12T22:01:05Z","updated_at":"2016-09-15T18:19:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abbeee12c1be8c52a4f108f5f14cbcb38e16c570","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2304/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2304/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2304/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/558107a7dc7bb1daeb0026edd874e0b54bdfd1ae","head":{"label":"cgtexmex:white-lion","ref":"white-lion","sha":"558107a7dc7bb1daeb0026edd874e0b54bdfd1ae","user":{"login":"cgtexmex","id":726112,"avatar_url":"https://avatars.githubusercontent.com/u/726112?v=3","gravatar_id":"","url":"https://api.github.com/users/cgtexmex","html_url":"https://github.com/cgtexmex","followers_url":"https://api.github.com/users/cgtexmex/followers","following_url":"https://api.github.com/users/cgtexmex/following{/other_user}","gists_url":"https://api.github.com/users/cgtexmex/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtexmex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtexmex/subscriptions","organizations_url":"https://api.github.com/users/cgtexmex/orgs","repos_url":"https://api.github.com/users/cgtexmex/repos","events_url":"https://api.github.com/users/cgtexmex/events{/privacy}","received_events_url":"https://api.github.com/users/cgtexmex/received_events","type":"User","site_admin":false},"repo":{"id":55994431,"name":"vic","full_name":"cgtexmex/vic","owner":{"login":"cgtexmex","id":726112,"avatar_url":"https://avatars.githubusercontent.com/u/726112?v=3","gravatar_id":"","url":"https://api.github.com/users/cgtexmex","html_url":"https://github.com/cgtexmex","followers_url":"https://api.github.com/users/cgtexmex/followers","following_url":"https://api.github.com/users/cgtexmex/following{/other_user}","gists_url":"https://api.github.com/users/cgtexmex/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtexmex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtexmex/subscriptions","organizations_url":"https://api.github.com/users/cgtexmex/orgs","repos_url":"https://api.github.com/users/cgtexmex/repos","events_url":"https://api.github.com/users/cgtexmex/events{/privacy}","received_events_url":"https://api.github.com/users/cgtexmex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgtexmex/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/cgtexmex/vic","forks_url":"https://api.github.com/repos/cgtexmex/vic/forks","keys_url":"https://api.github.com/repos/cgtexmex/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgtexmex/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgtexmex/vic/teams","hooks_url":"https://api.github.com/repos/cgtexmex/vic/hooks","issue_events_url":"https://api.github.com/repos/cgtexmex/vic/issues/events{/number}","events_url":"https://api.github.com/repos/cgtexmex/vic/events","assignees_url":"https://api.github.com/repos/cgtexmex/vic/assignees{/user}","branches_url":"https://api.github.com/repos/cgtexmex/vic/branches{/branch}","tags_url":"https://api.github.com/repos/cgtexmex/vic/tags","blobs_url":"https://api.github.com/repos/cgtexmex/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgtexmex/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgtexmex/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgtexmex/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgtexmex/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/cgtexmex/vic/languages","stargazers_url":"https://api.github.com/repos/cgtexmex/vic/stargazers","contributors_url":"https://api.github.com/repos/cgtexmex/vic/contributors","subscribers_url":"https://api.github.com/repos/cgtexmex/vic/subscribers","subscription_url":"https://api.github.com/repos/cgtexmex/vic/subscription","commits_url":"https://api.github.com/repos/cgtexmex/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgtexmex/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgtexmex/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgtexmex/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgtexmex/vic/contents/{+path}","compare_url":"https://api.github.com/repos/cgtexmex/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgtexmex/vic/merges","archive_url":"https://api.github.com/repos/cgtexmex/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgtexmex/vic/downloads","issues_url":"https://api.github.com/repos/cgtexmex/vic/issues{/number}","pulls_url":"https://api.github.com/repos/cgtexmex/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/cgtexmex/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/cgtexmex/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgtexmex/vic/labels{/name}","releases_url":"https://api.github.com/repos/cgtexmex/vic/releases{/id}","deployments_url":"https://api.github.com/repos/cgtexmex/vic/deployments","created_at":"2016-04-11T17:51:49Z","updated_at":"2016-04-11T17:51:50Z","pushed_at":"2016-09-15T18:08:11Z","git_url":"git://github.com/cgtexmex/vic.git","ssh_url":"git@github.com:cgtexmex/vic.git","clone_url":"https://github.com/cgtexmex/vic.git","svn_url":"https://github.com/cgtexmex/vic","homepage":null,"size":28973,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"ba9d81d5e9e3b28e6cd623769ee3edd6641b6737","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-09-13T11:55:50Z","pushed_at":"2016-09-15T18:10:23Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":79532,"stargazers_count":131,"watchers_count":131,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":498,"forks":47,"open_issues":498,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2304"},"html":{"href":"https://github.com/vmware/vic/pull/2304"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2304"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2304/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2304/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2304/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/558107a7dc7bb1daeb0026edd874e0b54bdfd1ae"}}}}
{"actor":{"display_login":"cgtexmex"}}