{"action":"closed","number":5043,"pull_request":{"url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/5043","id":17493507,"html_url":"https://github.com/caskroom/homebrew-cask/pull/5043","diff_url":"https://github.com/caskroom/homebrew-cask/pull/5043.diff","patch_url":"https://github.com/caskroom/homebrew-cask/pull/5043.patch","issue_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/5043","number":5043,"state":"closed","locked":false,"title":"WIP DSL: add `:glob` key to expand fileglobs","user":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"body":"This is a very rough/quick implementation, and is intended mostly for discussion,\r\nas this is the DSL proposal in #4688 which has no associated PR.\r\n\r\nProblems here include:\r\n 1. This was implemented alongside `:target` in `artifact/symlinked.rb`, which also\r\n     contains installation logic for artifacts.  A smarter implementation would improve\r\n     separation of concerns by moving the logic for interpreting both `:glob` and `:target`\r\n     keys into `dsl.rb` (or some class called from `dsl.rb`)\r\n 2. Only artifact sources such as `link` can be expanded.  Similar functionality would\r\n     also be useful (for example) in `uninstall :files`.\r\n 3. This interface seems clunky.  It might be cleaner to have an `expand` method in\r\n     the DSL for wrapping filenames:\r\n\r\n    ```ruby\r\n      link expand('*/VLC.app')\r\n    ```\r\n   \r\n    The `expand` method would actually call a constructor, because the action of expansion\r\n    must be deferred until install-time.  However, I think Expander.new('*') is needlessly\r\n    verbose for Cask authors, and not necessarily more self-documenting.\r\n    - The `expand` interface might also help address problem 2 above.\r\n\r\nReferences: https://github.com/caskroom/homebrew-versions/pull/293#issuecomment-46166969","created_at":"2014-06-23T19:20:41Z","updated_at":"2016-10-17T19:15:09Z","closed_at":"2016-10-17T19:15:08Z","merged_at":null,"merge_commit_sha":"c9c6630eac73c83c1caeb757328b68143d0d7cb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/5043/commits","review_comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/5043/comments","review_comment_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/5043/comments","statuses_url":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/87b645242dba54428174da1212e6a2e1f9ac47bc","head":{"label":"rolandwalker:add_glob_key","ref":"add_glob_key","sha":"87b645242dba54428174da1212e6a2e1f9ac47bc","user":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"repo":{"id":14505203,"name":"homebrew-cask","full_name":"rolandwalker/homebrew-cask","owner":{"login":"rolandwalker","id":727482,"avatar_url":"https://avatars.githubusercontent.com/u/727482?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandwalker","html_url":"https://github.com/rolandwalker","followers_url":"https://api.github.com/users/rolandwalker/followers","following_url":"https://api.github.com/users/rolandwalker/following{/other_user}","gists_url":"https://api.github.com/users/rolandwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandwalker/subscriptions","organizations_url":"https://api.github.com/users/rolandwalker/orgs","repos_url":"https://api.github.com/users/rolandwalker/repos","events_url":"https://api.github.com/users/rolandwalker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandwalker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolandwalker/homebrew-cask","description":"a friendly homebrew-style CLI workflow for the administration of Mac applications distributed as binaries","fork":true,"url":"https://api.github.com/repos/rolandwalker/homebrew-cask","forks_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/forks","keys_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/teams","hooks_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/hooks","issue_events_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/issues/events{/number}","events_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/events","assignees_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/assignees{/user}","branches_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/branches{/branch}","tags_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/tags","blobs_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/statuses/{sha}","languages_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/languages","stargazers_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/stargazers","contributors_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/contributors","subscribers_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/subscribers","subscription_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/subscription","commits_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/issues/comments{/number}","contents_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/contents/{+path}","compare_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/merges","archive_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/downloads","issues_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/issues{/number}","pulls_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/pulls{/number}","milestones_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/milestones{/number}","notifications_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/labels{/name}","releases_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/releases{/id}","deployments_url":"https://api.github.com/repos/rolandwalker/homebrew-cask/deployments","created_at":"2013-11-18T21:07:31Z","updated_at":"2015-02-11T13:04:21Z","pushed_at":"2015-02-23T20:44:21Z","git_url":"git://github.com/rolandwalker/homebrew-cask.git","ssh_url":"git@github.com:rolandwalker/homebrew-cask.git","clone_url":"https://github.com/rolandwalker/homebrew-cask.git","svn_url":"https://github.com/rolandwalker/homebrew-cask","homepage":"","size":39891,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"caskroom:master","ref":"master","sha":"82c08e74173b805039d9e2723167c946922b1529","user":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=3","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"repo":{"id":3623050,"name":"homebrew-cask","full_name":"caskroom/homebrew-cask","owner":{"login":"caskroom","id":5647711,"avatar_url":"https://avatars.githubusercontent.com/u/5647711?v=3","gravatar_id":"","url":"https://api.github.com/users/caskroom","html_url":"https://github.com/caskroom","followers_url":"https://api.github.com/users/caskroom/followers","following_url":"https://api.github.com/users/caskroom/following{/other_user}","gists_url":"https://api.github.com/users/caskroom/gists{/gist_id}","starred_url":"https://api.github.com/users/caskroom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskroom/subscriptions","organizations_url":"https://api.github.com/users/caskroom/orgs","repos_url":"https://api.github.com/users/caskroom/repos","events_url":"https://api.github.com/users/caskroom/events{/privacy}","received_events_url":"https://api.github.com/users/caskroom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskroom/homebrew-cask","description":"A CLI workflow for the administration of Mac applications distributed as binaries","fork":false,"url":"https://api.github.com/repos/caskroom/homebrew-cask","forks_url":"https://api.github.com/repos/caskroom/homebrew-cask/forks","keys_url":"https://api.github.com/repos/caskroom/homebrew-cask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskroom/homebrew-cask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskroom/homebrew-cask/teams","hooks_url":"https://api.github.com/repos/caskroom/homebrew-cask/hooks","issue_events_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/events{/number}","events_url":"https://api.github.com/repos/caskroom/homebrew-cask/events","assignees_url":"https://api.github.com/repos/caskroom/homebrew-cask/assignees{/user}","branches_url":"https://api.github.com/repos/caskroom/homebrew-cask/branches{/branch}","tags_url":"https://api.github.com/repos/caskroom/homebrew-cask/tags","blobs_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/{sha}","languages_url":"https://api.github.com/repos/caskroom/homebrew-cask/languages","stargazers_url":"https://api.github.com/repos/caskroom/homebrew-cask/stargazers","contributors_url":"https://api.github.com/repos/caskroom/homebrew-cask/contributors","subscribers_url":"https://api.github.com/repos/caskroom/homebrew-cask/subscribers","subscription_url":"https://api.github.com/repos/caskroom/homebrew-cask/subscription","commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskroom/homebrew-cask/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskroom/homebrew-cask/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskroom/homebrew-cask/contents/{+path}","compare_url":"https://api.github.com/repos/caskroom/homebrew-cask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskroom/homebrew-cask/merges","archive_url":"https://api.github.com/repos/caskroom/homebrew-cask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskroom/homebrew-cask/downloads","issues_url":"https://api.github.com/repos/caskroom/homebrew-cask/issues{/number}","pulls_url":"https://api.github.com/repos/caskroom/homebrew-cask/pulls{/number}","milestones_url":"https://api.github.com/repos/caskroom/homebrew-cask/milestones{/number}","notifications_url":"https://api.github.com/repos/caskroom/homebrew-cask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskroom/homebrew-cask/labels{/name}","releases_url":"https://api.github.com/repos/caskroom/homebrew-cask/releases{/id}","deployments_url":"https://api.github.com/repos/caskroom/homebrew-cask/deployments","created_at":"2012-03-05T02:05:17Z","updated_at":"2016-10-17T18:52:28Z","pushed_at":"2016-10-17T19:09:40Z","git_url":"git://github.com/caskroom/homebrew-cask.git","ssh_url":"git@github.com:caskroom/homebrew-cask.git","clone_url":"https://github.com/caskroom/homebrew-cask.git","svn_url":"https://github.com/caskroom/homebrew-cask","homepage":"http://caskroom.io","size":138327,"stargazers_count":9797,"watchers_count":9797,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4206,"mirror_url":null,"open_issues_count":88,"forks":4206,"open_issues":88,"watchers":9797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/5043"},"html":{"href":"https://github.com/caskroom/homebrew-cask/pull/5043"},"issue":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/issues/5043"},"comments":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/issues/5043/comments"},"review_comments":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/5043/comments"},"review_comment":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/pulls/5043/commits"},"statuses":{"href":"https://api.github.com/repos/caskroom/homebrew-cask/statuses/87b645242dba54428174da1212e6a2e1f9ac47bc"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":90,"deletions":7,"changed_files":5}}
{"actor":{"display_login":"jawshooah"}}