{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/13165","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/13165/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/13165/comments","events_url":"https://api.github.com/repos/apache/spark/issues/13165/events","html_url":"https://github.com/apache/spark/pull/13165","id":155440422,"number":13165,"title":"[SPARK-8603][SPARKR] Incorrect file separator passed to Java and Scripts from R in windows","user":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars.githubusercontent.com/u/6477701?v=3","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2016-05-18T08:09:13Z","updated_at":"2016-05-25T13:35:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/13165","html_url":"https://github.com/apache/spark/pull/13165","diff_url":"https://github.com/apache/spark/pull/13165.diff","patch_url":"https://github.com/apache/spark/pull/13165.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR corrects R file separator to accept Windows.\r\n\r\nAccording to the R API, [file](https://stat.ethz.ch/R-manual/R-devel/library/base/html/file.path.html), \r\n\r\n>```R\r\n>file.path(..., fsep = .Platform$file.sep)\r\n>```\r\n\r\n`file.path` API takes `.Platform$file.sep` but the default value for this is, `/` regardless of OS type.\r\n\r\nAlso, this is written as a note in the document as below:\r\n\r\n>The components are by default separated by / (not \\) on Windows.\r\n\r\n## How was this patch tested?\r\n\r\nJenkins tests and manually tested in a Window machine as below:\r\n\r\n```R\r\n> .Platform$OS.type\r\n[1] \"windows\"\r\n```\r\n\r\n```R\r\n> .Platform$file.sep\r\n[1] \"/\"\r\n```\r\n\r\nCloses #7025\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/221577653","html_url":"https://github.com/apache/spark/pull/13165#issuecomment-221577653","issue_url":"https://api.github.com/repos/apache/spark/issues/13165","id":221577653,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T13:35:10Z","updated_at":"2016-05-25T13:35:10Z","body":"**[Test build #59275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59275/consoleFull)** for PR 13165 at commit [`64141d2`](https://github.com/apache/spark/commit/64141d20049098c51ac7dd99c38b840b25ca073a).\n * This patch **fails R style tests**.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}