{"action":"created","comment":{"url":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/comments/91789087","pull_request_review_id":12301661,"id":91789087,"diff_hunk":"@@ -52,12 +52,11 @@ class App {\n \n   createPage() {\n     const page = new Page()\n-    page.setTheme(this.theme)\n+    page.setTheme((this.settings) ? this.settings.theme : 'default')","path":"app/js/App.js","position":19,"original_position":19,"commit_id":"b3cc846662e8f4cdbc2671e8d2a7aee30abdf18c","original_commit_id":"aef428311f73cb9a49a6f55f14faabddfb3ce1a9","user":{"login":"wellsjo","id":823446,"avatar_url":"https://avatars.githubusercontent.com/u/823446?v=3","gravatar_id":"","url":"https://api.github.com/users/wellsjo","html_url":"https://github.com/wellsjo","followers_url":"https://api.github.com/users/wellsjo/followers","following_url":"https://api.github.com/users/wellsjo/following{/other_user}","gists_url":"https://api.github.com/users/wellsjo/gists{/gist_id}","starred_url":"https://api.github.com/users/wellsjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellsjo/subscriptions","organizations_url":"https://api.github.com/users/wellsjo/orgs","repos_url":"https://api.github.com/users/wellsjo/repos","events_url":"https://api.github.com/users/wellsjo/events{/privacy}","received_events_url":"https://api.github.com/users/wellsjo/received_events","type":"User","site_admin":false},"body":"@vpillinger this still needs to be updated then we're 👍 ","created_at":"2016-12-09T20:25:01Z","updated_at":"2016-12-09T20:25:01Z","html_url":"https://github.com/wellsjo/JSON-Splora/pull/57#discussion_r91789087","pull_request_url":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/comments/91789087"},"html":{"href":"https://github.com/wellsjo/JSON-Splora/pull/57#discussion_r91789087"},"pull_request":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57","id":96998843,"html_url":"https://github.com/wellsjo/JSON-Splora/pull/57","diff_url":"https://github.com/wellsjo/JSON-Splora/pull/57.diff","patch_url":"https://github.com/wellsjo/JSON-Splora/pull/57.patch","issue_url":"https://api.github.com/repos/wellsjo/JSON-Splora/issues/57","number":57,"state":"open","locked":false,"title":"Add Testing Framework","user":{"login":"vpillinger","id":6379913,"avatar_url":"https://avatars.githubusercontent.com/u/6379913?v=3","gravatar_id":"","url":"https://api.github.com/users/vpillinger","html_url":"https://github.com/vpillinger","followers_url":"https://api.github.com/users/vpillinger/followers","following_url":"https://api.github.com/users/vpillinger/following{/other_user}","gists_url":"https://api.github.com/users/vpillinger/gists{/gist_id}","starred_url":"https://api.github.com/users/vpillinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpillinger/subscriptions","organizations_url":"https://api.github.com/users/vpillinger/orgs","repos_url":"https://api.github.com/users/vpillinger/repos","events_url":"https://api.github.com/users/vpillinger/events{/privacy}","received_events_url":"https://api.github.com/users/vpillinger/received_events","type":"User","site_admin":false},"body":"I have added Jasmine and Spectron to the project. Jasmine tests will be automatically ran as a pre-git commit hook. I am contemplating setting up a gulp watch() for continuous test and lint integration (although most ide will lint automatically already).\r\n\r\nEdit:\r\nAnother consideration, I left /spec/**_spec.js as the glob to find tests. However, it might be easier/more maintainable/ect. to put _spec.js files in a directory closer to the files being tested. For example, putting them in the same directory, or a sub directory. Any preferences/thoughts?\r\n\r\n#51 ","created_at":"2016-12-07T20:16:05Z","updated_at":"2016-12-09T20:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6253f421b695a2feaae84db95cbedf683b4caa15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57/commits","review_comments_url":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57/comments","review_comment_url":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wellsjo/JSON-Splora/issues/57/comments","statuses_url":"https://api.github.com/repos/wellsjo/JSON-Splora/statuses/b3cc846662e8f4cdbc2671e8d2a7aee30abdf18c","head":{"label":"vpillinger:master","ref":"master","sha":"b3cc846662e8f4cdbc2671e8d2a7aee30abdf18c","user":{"login":"vpillinger","id":6379913,"avatar_url":"https://avatars.githubusercontent.com/u/6379913?v=3","gravatar_id":"","url":"https://api.github.com/users/vpillinger","html_url":"https://github.com/vpillinger","followers_url":"https://api.github.com/users/vpillinger/followers","following_url":"https://api.github.com/users/vpillinger/following{/other_user}","gists_url":"https://api.github.com/users/vpillinger/gists{/gist_id}","starred_url":"https://api.github.com/users/vpillinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpillinger/subscriptions","organizations_url":"https://api.github.com/users/vpillinger/orgs","repos_url":"https://api.github.com/users/vpillinger/repos","events_url":"https://api.github.com/users/vpillinger/events{/privacy}","received_events_url":"https://api.github.com/users/vpillinger/received_events","type":"User","site_admin":false},"repo":{"id":75118845,"name":"JSON-Splora","full_name":"vpillinger/JSON-Splora","owner":{"login":"vpillinger","id":6379913,"avatar_url":"https://avatars.githubusercontent.com/u/6379913?v=3","gravatar_id":"","url":"https://api.github.com/users/vpillinger","html_url":"https://github.com/vpillinger","followers_url":"https://api.github.com/users/vpillinger/followers","following_url":"https://api.github.com/users/vpillinger/following{/other_user}","gists_url":"https://api.github.com/users/vpillinger/gists{/gist_id}","starred_url":"https://api.github.com/users/vpillinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpillinger/subscriptions","organizations_url":"https://api.github.com/users/vpillinger/orgs","repos_url":"https://api.github.com/users/vpillinger/repos","events_url":"https://api.github.com/users/vpillinger/events{/privacy}","received_events_url":"https://api.github.com/users/vpillinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vpillinger/JSON-Splora","description":"GUI for editing, visualizing, and manipulating JSON data","fork":true,"url":"https://api.github.com/repos/vpillinger/JSON-Splora","forks_url":"https://api.github.com/repos/vpillinger/JSON-Splora/forks","keys_url":"https://api.github.com/repos/vpillinger/JSON-Splora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vpillinger/JSON-Splora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vpillinger/JSON-Splora/teams","hooks_url":"https://api.github.com/repos/vpillinger/JSON-Splora/hooks","issue_events_url":"https://api.github.com/repos/vpillinger/JSON-Splora/issues/events{/number}","events_url":"https://api.github.com/repos/vpillinger/JSON-Splora/events","assignees_url":"https://api.github.com/repos/vpillinger/JSON-Splora/assignees{/user}","branches_url":"https://api.github.com/repos/vpillinger/JSON-Splora/branches{/branch}","tags_url":"https://api.github.com/repos/vpillinger/JSON-Splora/tags","blobs_url":"https://api.github.com/repos/vpillinger/JSON-Splora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vpillinger/JSON-Splora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vpillinger/JSON-Splora/git/refs{/sha}","trees_url":"https://api.github.com/repos/vpillinger/JSON-Splora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vpillinger/JSON-Splora/statuses/{sha}","languages_url":"https://api.github.com/repos/vpillinger/JSON-Splora/languages","stargazers_url":"https://api.github.com/repos/vpillinger/JSON-Splora/stargazers","contributors_url":"https://api.github.com/repos/vpillinger/JSON-Splora/contributors","subscribers_url":"https://api.github.com/repos/vpillinger/JSON-Splora/subscribers","subscription_url":"https://api.github.com/repos/vpillinger/JSON-Splora/subscription","commits_url":"https://api.github.com/repos/vpillinger/JSON-Splora/commits{/sha}","git_commits_url":"https://api.github.com/repos/vpillinger/JSON-Splora/git/commits{/sha}","comments_url":"https://api.github.com/repos/vpillinger/JSON-Splora/comments{/number}","issue_comment_url":"https://api.github.com/repos/vpillinger/JSON-Splora/issues/comments{/number}","contents_url":"https://api.github.com/repos/vpillinger/JSON-Splora/contents/{+path}","compare_url":"https://api.github.com/repos/vpillinger/JSON-Splora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vpillinger/JSON-Splora/merges","archive_url":"https://api.github.com/repos/vpillinger/JSON-Splora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vpillinger/JSON-Splora/downloads","issues_url":"https://api.github.com/repos/vpillinger/JSON-Splora/issues{/number}","pulls_url":"https://api.github.com/repos/vpillinger/JSON-Splora/pulls{/number}","milestones_url":"https://api.github.com/repos/vpillinger/JSON-Splora/milestones{/number}","notifications_url":"https://api.github.com/repos/vpillinger/JSON-Splora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vpillinger/JSON-Splora/labels{/name}","releases_url":"https://api.github.com/repos/vpillinger/JSON-Splora/releases{/id}","deployments_url":"https://api.github.com/repos/vpillinger/JSON-Splora/deployments","created_at":"2016-11-29T20:24:45Z","updated_at":"2016-11-29T20:24:47Z","pushed_at":"2016-12-09T19:40:47Z","git_url":"git://github.com/vpillinger/JSON-Splora.git","ssh_url":"git@github.com:vpillinger/JSON-Splora.git","clone_url":"https://github.com/vpillinger/JSON-Splora.git","svn_url":"https://github.com/vpillinger/JSON-Splora","homepage":"","size":2586,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wellsjo:master","ref":"master","sha":"d81e6e4815ca158d03c9162f7f0d55586b4b0b80","user":{"login":"wellsjo","id":823446,"avatar_url":"https://avatars.githubusercontent.com/u/823446?v=3","gravatar_id":"","url":"https://api.github.com/users/wellsjo","html_url":"https://github.com/wellsjo","followers_url":"https://api.github.com/users/wellsjo/followers","following_url":"https://api.github.com/users/wellsjo/following{/other_user}","gists_url":"https://api.github.com/users/wellsjo/gists{/gist_id}","starred_url":"https://api.github.com/users/wellsjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellsjo/subscriptions","organizations_url":"https://api.github.com/users/wellsjo/orgs","repos_url":"https://api.github.com/users/wellsjo/repos","events_url":"https://api.github.com/users/wellsjo/events{/privacy}","received_events_url":"https://api.github.com/users/wellsjo/received_events","type":"User","site_admin":false},"repo":{"id":71188401,"name":"JSON-Splora","full_name":"wellsjo/JSON-Splora","owner":{"login":"wellsjo","id":823446,"avatar_url":"https://avatars.githubusercontent.com/u/823446?v=3","gravatar_id":"","url":"https://api.github.com/users/wellsjo","html_url":"https://github.com/wellsjo","followers_url":"https://api.github.com/users/wellsjo/followers","following_url":"https://api.github.com/users/wellsjo/following{/other_user}","gists_url":"https://api.github.com/users/wellsjo/gists{/gist_id}","starred_url":"https://api.github.com/users/wellsjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellsjo/subscriptions","organizations_url":"https://api.github.com/users/wellsjo/orgs","repos_url":"https://api.github.com/users/wellsjo/repos","events_url":"https://api.github.com/users/wellsjo/events{/privacy}","received_events_url":"https://api.github.com/users/wellsjo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wellsjo/JSON-Splora","description":"GUI for editing, visualizing, and manipulating JSON data","fork":false,"url":"https://api.github.com/repos/wellsjo/JSON-Splora","forks_url":"https://api.github.com/repos/wellsjo/JSON-Splora/forks","keys_url":"https://api.github.com/repos/wellsjo/JSON-Splora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellsjo/JSON-Splora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellsjo/JSON-Splora/teams","hooks_url":"https://api.github.com/repos/wellsjo/JSON-Splora/hooks","issue_events_url":"https://api.github.com/repos/wellsjo/JSON-Splora/issues/events{/number}","events_url":"https://api.github.com/repos/wellsjo/JSON-Splora/events","assignees_url":"https://api.github.com/repos/wellsjo/JSON-Splora/assignees{/user}","branches_url":"https://api.github.com/repos/wellsjo/JSON-Splora/branches{/branch}","tags_url":"https://api.github.com/repos/wellsjo/JSON-Splora/tags","blobs_url":"https://api.github.com/repos/wellsjo/JSON-Splora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellsjo/JSON-Splora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellsjo/JSON-Splora/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellsjo/JSON-Splora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellsjo/JSON-Splora/statuses/{sha}","languages_url":"https://api.github.com/repos/wellsjo/JSON-Splora/languages","stargazers_url":"https://api.github.com/repos/wellsjo/JSON-Splora/stargazers","contributors_url":"https://api.github.com/repos/wellsjo/JSON-Splora/contributors","subscribers_url":"https://api.github.com/repos/wellsjo/JSON-Splora/subscribers","subscription_url":"https://api.github.com/repos/wellsjo/JSON-Splora/subscription","commits_url":"https://api.github.com/repos/wellsjo/JSON-Splora/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellsjo/JSON-Splora/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellsjo/JSON-Splora/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellsjo/JSON-Splora/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellsjo/JSON-Splora/contents/{+path}","compare_url":"https://api.github.com/repos/wellsjo/JSON-Splora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellsjo/JSON-Splora/merges","archive_url":"https://api.github.com/repos/wellsjo/JSON-Splora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellsjo/JSON-Splora/downloads","issues_url":"https://api.github.com/repos/wellsjo/JSON-Splora/issues{/number}","pulls_url":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls{/number}","milestones_url":"https://api.github.com/repos/wellsjo/JSON-Splora/milestones{/number}","notifications_url":"https://api.github.com/repos/wellsjo/JSON-Splora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellsjo/JSON-Splora/labels{/name}","releases_url":"https://api.github.com/repos/wellsjo/JSON-Splora/releases{/id}","deployments_url":"https://api.github.com/repos/wellsjo/JSON-Splora/deployments","created_at":"2016-10-17T23:01:45Z","updated_at":"2016-12-09T20:14:07Z","pushed_at":"2016-12-09T19:40:47Z","git_url":"git://github.com/wellsjo/JSON-Splora.git","ssh_url":"git@github.com:wellsjo/JSON-Splora.git","clone_url":"https://github.com/wellsjo/JSON-Splora.git","svn_url":"https://github.com/wellsjo/JSON-Splora","homepage":"","size":2607,"stargazers_count":1193,"watchers_count":1193,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":14,"forks":40,"open_issues":14,"watchers":1193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57"},"html":{"href":"https://github.com/wellsjo/JSON-Splora/pull/57"},"issue":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/issues/57"},"comments":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/wellsjo/JSON-Splora/statuses/b3cc846662e8f4cdbc2671e8d2a7aee30abdf18c"}}}}
{"actor":{"display_login":"wellsjo"}}