{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab/pulls/comments/89680377","pull_request_review_id":10222641,"id":89680377,"diff_hunk":"@@ -116,13 +117,23 @@ protected void internalReceiveCommand(String pvItemName, Command pvCommand) {\n \n         OneWireBindingConfig lvBindigConfig = getBindingConfig(pvItemName);\n \n-        if (lvBindigConfig instanceof AbstractOneWireDevicePropertyWritableBindingConfig) {\n+        if (lvBindigConfig instanceof OneWireDevicePropertyExecutableBindingConfig) {\n+            // This Binding implements a special behavior\n+            logger.debug(\"call execute for item \" + pvItemName);\n+\n+            ((OneWireDevicePropertyExecutableBindingConfig) lvBindigConfig).execute(pvCommand);\n+        } else if (lvBindigConfig instanceof AbstractOneWireDevicePropertyWritableBindingConfig) {\n+            logger.debug(\"write to item \" + pvItemName);","path":"bundles/binding/org.openhab.binding.onewire/src/main/java/org/openhab/binding/onewire/internal/OneWireBinding.java","position":30,"original_position":30,"commit_id":"12f02ea3a4296e98e1f1dadec4cd68e966d32b1b","original_commit_id":"12f02ea3a4296e98e1f1dadec4cd68e966d32b1b","user":{"login":"9037568","id":9916473,"avatar_url":"https://avatars.githubusercontent.com/u/9916473?v=3","gravatar_id":"","url":"https://api.github.com/users/9037568","html_url":"https://github.com/9037568","followers_url":"https://api.github.com/users/9037568/followers","following_url":"https://api.github.com/users/9037568/following{/other_user}","gists_url":"https://api.github.com/users/9037568/gists{/gist_id}","starred_url":"https://api.github.com/users/9037568/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9037568/subscriptions","organizations_url":"https://api.github.com/users/9037568/orgs","repos_url":"https://api.github.com/users/9037568/repos","events_url":"https://api.github.com/users/9037568/events{/privacy}","received_events_url":"https://api.github.com/users/9037568/received_events","type":"User","site_admin":false},"body":"Should use parameterized logging instead of string concatenation.","created_at":"2016-11-27T00:05:40Z","updated_at":"2016-11-27T00:08:29Z","html_url":"https://github.com/openhab/openhab/pull/4140#discussion_r89680377","pull_request_url":"https://api.github.com/repos/openhab/openhab/pulls/4140","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments/89680377"},"html":{"href":"https://github.com/openhab/openhab/pull/4140#discussion_r89680377"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4140"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab/pulls/4140","id":61848482,"html_url":"https://github.com/openhab/openhab/pull/4140","diff_url":"https://github.com/openhab/openhab/pull/4140.diff","patch_url":"https://github.com/openhab/openhab/pull/4140.patch","issue_url":"https://api.github.com/repos/openhab/openhab/issues/4140","number":4140,"state":"open","locked":false,"title":"OneWireBinding: New feature pushbutton","user":{"login":"Dennis650","id":10641318,"avatar_url":"https://avatars.githubusercontent.com/u/10641318?v=3","gravatar_id":"","url":"https://api.github.com/users/Dennis650","html_url":"https://github.com/Dennis650","followers_url":"https://api.github.com/users/Dennis650/followers","following_url":"https://api.github.com/users/Dennis650/following{/other_user}","gists_url":"https://api.github.com/users/Dennis650/gists{/gist_id}","starred_url":"https://api.github.com/users/Dennis650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dennis650/subscriptions","organizations_url":"https://api.github.com/users/Dennis650/orgs","repos_url":"https://api.github.com/users/Dennis650/repos","events_url":"https://api.github.com/users/Dennis650/events{/privacy}","received_events_url":"https://api.github.com/users/Dennis650/received_events","type":"User","site_admin":false},"body":"The new option makes it possible to use a relay like a pushbutton. It\nis possible to do that with a rule and timer, but then you have no\ncontrol of the real time a button is pushed on slow systems.\n\nExample:\nonewire=\"deviceId=29.66C30E000000;propertyName=sensed.0;refreshinterval=10\";pushbutton=500;invert\",autoupdate=\"false\"\n\nNew PullRequest for closed: #4063\n","created_at":"2016-03-06T17:21:50Z","updated_at":"2016-11-27T00:08:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e81682bc55d3a77d6a3c2cb98196c60232ea31ab","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openhab/openhab/milestones/12","html_url":"https://github.com/openhab/openhab/milestones/1.9.0","labels_url":"https://api.github.com/repos/openhab/openhab/milestones/12/labels","id":1479830,"number":12,"title":"1.9.0","description":"","creator":{"login":"teichsta","id":2108636,"avatar_url":"https://avatars.githubusercontent.com/u/2108636?v=3","gravatar_id":"","url":"https://api.github.com/users/teichsta","html_url":"https://github.com/teichsta","followers_url":"https://api.github.com/users/teichsta/followers","following_url":"https://api.github.com/users/teichsta/following{/other_user}","gists_url":"https://api.github.com/users/teichsta/gists{/gist_id}","starred_url":"https://api.github.com/users/teichsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teichsta/subscriptions","organizations_url":"https://api.github.com/users/teichsta/orgs","repos_url":"https://api.github.com/users/teichsta/repos","events_url":"https://api.github.com/users/teichsta/events{/privacy}","received_events_url":"https://api.github.com/users/teichsta/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":312,"state":"open","created_at":"2016-01-01T16:37:00Z","updated_at":"2016-11-26T17:28:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openhab/openhab/pulls/4140/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab/pulls/4140/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab/issues/4140/comments","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/12f02ea3a4296e98e1f1dadec4cd68e966d32b1b","head":{"label":"Dennis650:onewire-pushbutton","ref":"onewire-pushbutton","sha":"12f02ea3a4296e98e1f1dadec4cd68e966d32b1b","user":{"login":"Dennis650","id":10641318,"avatar_url":"https://avatars.githubusercontent.com/u/10641318?v=3","gravatar_id":"","url":"https://api.github.com/users/Dennis650","html_url":"https://github.com/Dennis650","followers_url":"https://api.github.com/users/Dennis650/followers","following_url":"https://api.github.com/users/Dennis650/following{/other_user}","gists_url":"https://api.github.com/users/Dennis650/gists{/gist_id}","starred_url":"https://api.github.com/users/Dennis650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dennis650/subscriptions","organizations_url":"https://api.github.com/users/Dennis650/orgs","repos_url":"https://api.github.com/users/Dennis650/repos","events_url":"https://api.github.com/users/Dennis650/events{/privacy}","received_events_url":"https://api.github.com/users/Dennis650/received_events","type":"User","site_admin":false},"repo":{"id":53258089,"name":"openhab","full_name":"Dennis650/openhab","owner":{"login":"Dennis650","id":10641318,"avatar_url":"https://avatars.githubusercontent.com/u/10641318?v=3","gravatar_id":"","url":"https://api.github.com/users/Dennis650","html_url":"https://github.com/Dennis650","followers_url":"https://api.github.com/users/Dennis650/followers","following_url":"https://api.github.com/users/Dennis650/following{/other_user}","gists_url":"https://api.github.com/users/Dennis650/gists{/gist_id}","starred_url":"https://api.github.com/users/Dennis650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dennis650/subscriptions","organizations_url":"https://api.github.com/users/Dennis650/orgs","repos_url":"https://api.github.com/users/Dennis650/repos","events_url":"https://api.github.com/users/Dennis650/events{/privacy}","received_events_url":"https://api.github.com/users/Dennis650/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dennis650/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/Dennis650/openhab","forks_url":"https://api.github.com/repos/Dennis650/openhab/forks","keys_url":"https://api.github.com/repos/Dennis650/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dennis650/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dennis650/openhab/teams","hooks_url":"https://api.github.com/repos/Dennis650/openhab/hooks","issue_events_url":"https://api.github.com/repos/Dennis650/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/Dennis650/openhab/events","assignees_url":"https://api.github.com/repos/Dennis650/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/Dennis650/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/Dennis650/openhab/tags","blobs_url":"https://api.github.com/repos/Dennis650/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dennis650/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dennis650/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dennis650/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dennis650/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/Dennis650/openhab/languages","stargazers_url":"https://api.github.com/repos/Dennis650/openhab/stargazers","contributors_url":"https://api.github.com/repos/Dennis650/openhab/contributors","subscribers_url":"https://api.github.com/repos/Dennis650/openhab/subscribers","subscription_url":"https://api.github.com/repos/Dennis650/openhab/subscription","commits_url":"https://api.github.com/repos/Dennis650/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dennis650/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dennis650/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dennis650/openhab/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dennis650/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/Dennis650/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dennis650/openhab/merges","archive_url":"https://api.github.com/repos/Dennis650/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dennis650/openhab/downloads","issues_url":"https://api.github.com/repos/Dennis650/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/Dennis650/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/Dennis650/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/Dennis650/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dennis650/openhab/labels{/name}","releases_url":"https://api.github.com/repos/Dennis650/openhab/releases{/id}","deployments_url":"https://api.github.com/repos/Dennis650/openhab/deployments","created_at":"2016-03-06T14:10:31Z","updated_at":"2016-03-06T14:10:45Z","pushed_at":"2016-03-06T20:16:58Z","git_url":"git://github.com/Dennis650/openhab.git","ssh_url":"git@github.com:Dennis650/openhab.git","clone_url":"https://github.com/Dennis650/openhab.git","svn_url":"https://github.com/Dennis650/openhab","homepage":null,"size":192048,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"1ffa5f38e6cd03a30fbcd86d06f75a68d7fbb961","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":12983151,"name":"openhab","full_name":"openhab/openhab","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab","description":"Source code of the open Home Automation Bus (openHAB)","fork":false,"url":"https://api.github.com/repos/openhab/openhab","forks_url":"https://api.github.com/repos/openhab/openhab/forks","keys_url":"https://api.github.com/repos/openhab/openhab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab/teams","hooks_url":"https://api.github.com/repos/openhab/openhab/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab/events","assignees_url":"https://api.github.com/repos/openhab/openhab/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab/tags","blobs_url":"https://api.github.com/repos/openhab/openhab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab/subscription","commits_url":"https://api.github.com/repos/openhab/openhab/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab/merges","archive_url":"https://api.github.com/repos/openhab/openhab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab/downloads","issues_url":"https://api.github.com/repos/openhab/openhab/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab/deployments","created_at":"2013-09-20T20:28:43Z","updated_at":"2016-11-26T22:45:15Z","pushed_at":"2016-11-26T22:27:00Z","git_url":"git://github.com/openhab/openhab.git","ssh_url":"git@github.com:openhab/openhab.git","clone_url":"https://github.com/openhab/openhab.git","svn_url":"https://github.com/openhab/openhab","homepage":null,"size":313094,"stargazers_count":3225,"watchers_count":3225,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1511,"mirror_url":null,"open_issues_count":351,"forks":1511,"open_issues":351,"watchers":3225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4140"},"html":{"href":"https://github.com/openhab/openhab/pull/4140"},"issue":{"href":"https://api.github.com/repos/openhab/openhab/issues/4140"},"comments":{"href":"https://api.github.com/repos/openhab/openhab/issues/4140/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4140/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab/pulls/4140/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab/statuses/12f02ea3a4296e98e1f1dadec4cd68e966d32b1b"}}}}
{"actor":{"display_login":"9037568"}}