{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/93615657","pull_request_review_id":14146876,"id":93615657,"diff_hunk":"@@ -354,3 +355,23 @@ def mark_vm_as_template(rest_api, provider, vm_name):\n         lambda: rest_api.collections.templates.find_by(name=vm_name).subcount != 0,\n         num_sec=700, delay=15)\n     return rest_api.collections.templates.get(name=vm_name)\n+\n+\n+def arbitration_settings(request, rest_api, num=2):","path":"cfme/rest/__init__.py","position":14,"original_position":14,"commit_id":"9a85a422067143c8841c3106a559e60f761b0d8e","original_commit_id":"9a85a422067143c8841c3106a559e60f761b0d8e","user":{"login":"psav","id":5639745,"avatar_url":"https://avatars.githubusercontent.com/u/5639745?v=3","gravatar_id":"","url":"https://api.github.com/users/psav","html_url":"https://github.com/psav","followers_url":"https://api.github.com/users/psav/followers","following_url":"https://api.github.com/users/psav/following{/other_user}","gists_url":"https://api.github.com/users/psav/gists{/gist_id}","starred_url":"https://api.github.com/users/psav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psav/subscriptions","organizations_url":"https://api.github.com/users/psav/orgs","repos_url":"https://api.github.com/users/psav/repos","events_url":"https://api.github.com/users/psav/events{/privacy}","received_events_url":"https://api.github.com/users/psav/received_events","type":"User","site_admin":false},"body":"I don't like the fact that the rest module is creating the random data. The test should create the random data and pass the ```body``` to the ```arbitration_settings()``` function which then just creates it with whatever the body is.","created_at":"2016-12-22T12:37:47Z","updated_at":"2016-12-22T12:40:18Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/3895#discussion_r93615657","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/93615657"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/3895#discussion_r93615657"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895","id":98981192,"html_url":"https://github.com/ManageIQ/integration_tests/pull/3895","diff_url":"https://github.com/ManageIQ/integration_tests/pull/3895.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/3895.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3895","number":3895,"state":"open","locked":false,"title":"[RFR] REST API tests for arbitration_settings","user":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars.githubusercontent.com/u/2352619?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"body":"__Adding tests__ for \"arbitration_settings\" collection.","created_at":"2016-12-21T18:22:22Z","updated_at":"2016-12-22T12:40:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ae86d807bc1e04cb4a37ccec3eae9efd42067dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3895/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/9a85a422067143c8841c3106a559e60f761b0d8e","head":{"label":"mkoura:arbitration_settings","ref":"arbitration_settings","sha":"9a85a422067143c8841c3106a559e60f761b0d8e","user":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars.githubusercontent.com/u/2352619?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"repo":{"id":58528439,"name":"cfme_tests","full_name":"mkoura/cfme_tests","owner":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars.githubusercontent.com/u/2352619?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkoura/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/mkoura/cfme_tests","forks_url":"https://api.github.com/repos/mkoura/cfme_tests/forks","keys_url":"https://api.github.com/repos/mkoura/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkoura/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkoura/cfme_tests/teams","hooks_url":"https://api.github.com/repos/mkoura/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/mkoura/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/mkoura/cfme_tests/events","assignees_url":"https://api.github.com/repos/mkoura/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/mkoura/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/mkoura/cfme_tests/tags","blobs_url":"https://api.github.com/repos/mkoura/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkoura/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkoura/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkoura/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkoura/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mkoura/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/mkoura/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/mkoura/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/mkoura/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/mkoura/cfme_tests/subscription","commits_url":"https://api.github.com/repos/mkoura/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkoura/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkoura/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkoura/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkoura/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/mkoura/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkoura/cfme_tests/merges","archive_url":"https://api.github.com/repos/mkoura/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkoura/cfme_tests/downloads","issues_url":"https://api.github.com/repos/mkoura/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/mkoura/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mkoura/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mkoura/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkoura/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/mkoura/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/mkoura/cfme_tests/deployments","created_at":"2016-05-11T08:44:27Z","updated_at":"2016-05-11T08:44:29Z","pushed_at":"2016-12-21T18:29:44Z","git_url":"git://github.com/mkoura/cfme_tests.git","ssh_url":"git@github.com:mkoura/cfme_tests.git","clone_url":"https://github.com/mkoura/cfme_tests.git","svn_url":"https://github.com/mkoura/cfme_tests","homepage":"","size":12646,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2d37e26e3c02985f08773812d7f62680571f09ce","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2016-10-25T08:25:21Z","pushed_at":"2016-12-22T12:25:18Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":12740,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":100,"forks":70,"open_issues":100,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/3895"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3895"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/3895/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/3895/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/9a85a422067143c8841c3106a559e60f761b0d8e"}}}}
{"actor":{"display_login":"psav"}}