{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/13576","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/13576/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/13576/comments","events_url":"https://api.github.com/repos/apache/spark/issues/13576/events","html_url":"https://github.com/apache/spark/pull/13576","id":159400302,"number":13576,"title":"[SPARK-15840][SQL] Add two missing options in documentation and some option related changes","user":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars.githubusercontent.com/u/6477701?v=3","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-06-09T12:52:42Z","updated_at":"2016-06-10T09:48:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/13576","html_url":"https://github.com/apache/spark/pull/13576","diff_url":"https://github.com/apache/spark/pull/13576.diff","patch_url":"https://github.com/apache/spark/pull/13576.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR\r\n\r\n1. Adds the documentations for some missing options, `inferSchema` and `mergeSchema` for Python and Scala.\r\n\r\n\r\n2. Fiixes `[[DataFrame]]` to ```:class:`DataFrame` ``` so that this can be shown \r\n\r\n  - from\r\n    ![2016-06-09 9 31 16](https://cloud.githubusercontent.com/assets/6477701/15929721/8b864734-2e89-11e6-83f6-207527de4ac9.png)\r\n\r\n  - to (with class link)\r\n    ![2016-06-09 9 31 00](https://cloud.githubusercontent.com/assets/6477701/15929717/8a03d728-2e89-11e6-8a3f-08294964db22.png)\r\n\r\n  (Please refer [the latest documentation](https://people.apache.org/~pwendell/spark-nightly/spark-master-docs/latest/api/python/pyspark.sql.html))\r\n\r\n3. Moves `mergeSchema` option to `ParquetOptions` with removing unused options, `metastoreSchema` and `metastoreTableName`.\r\n\r\n  They are not used anymore. They were removed in https://github.com/apache/spark/commit/e720dda42e806229ccfd970055c7b8a93eb447bf and there are no use cases as below:\r\n\r\n  ```bash\r\n  grep -r -e METASTORE_SCHEMA -e \\\"metastoreSchema\\\" -e \\\"metastoreTableName\\\" -e METASTORE_TABLE_NAME .\r\n  ```\r\n\r\n  ```\r\n  ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala:  private[sql] val METASTORE_SCHEMA = \"metastoreSchema\"\r\n  ./sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala:  private[sql] val METASTORE_TABLE_NAME = \"metastoreTableName\"\r\n  ./sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala:        ParquetFileFormat.METASTORE_TABLE_NAME -> TableIdentifier(\r\n```\r\n\r\n  It only sets `metastoreTableName` in the last case but does not use the table name.\r\n\r\n4. Sets the correct default values (in the documentation) for `compression` option for ORC(`snappy`, see [OrcOptions.scala#L33-L42](https://github.com/apache/spark/blob/3ded5bc4db2badc9ff49554e73421021d854306b/sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala#L33-L42)) and Parquet(`the value specified in SQLConf`, see [ParquetOptions.scala#L38-L47](https://github.com/apache/spark/blob/3ded5bc4db2badc9ff49554e73421021d854306b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetOptions.scala#L38-L47)) and `columnNameOfCorruptRecord` for JSON(`the value specified in SQLConf`, see [JsonFileFormat.scala#L53-L55](https://github.com/apache/spark/blob/4538443e276597530a27c6922e48503677b13956/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala#L53-L55) and [JsonFileFormat.scala#L105-L106](https://github.com/apache/spark/blob/4538443e276597530a27c6922e48503677b13956/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala#L105-L106)). \r\n\r\n## How was this patch tested?\r\n\r\nExisting tests should cover this."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/225140963","html_url":"https://github.com/apache/spark/pull/13576#issuecomment-225140963","issue_url":"https://api.github.com/repos/apache/spark/issues/13576","id":225140963,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T09:48:01Z","updated_at":"2016-06-10T09:48:01Z","body":"Test PASSed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60283/\nTest PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}