{"action":"created","issue":{"url":"https://api.github.com/repos/brianshumate/ansible-consul/issues/20","repository_url":"https://api.github.com/repos/brianshumate/ansible-consul","labels_url":"https://api.github.com/repos/brianshumate/ansible-consul/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/brianshumate/ansible-consul/issues/20/comments","events_url":"https://api.github.com/repos/brianshumate/ansible-consul/issues/20/events","html_url":"https://github.com/brianshumate/ansible-consul/pull/20","id":191751888,"number":20,"title":"Allowing re-running to add new nodes. More HA too.","user":{"login":"violuke","id":6420347,"avatar_url":"https://avatars.githubusercontent.com/u/6420347?v=3","gravatar_id":"","url":"https://api.github.com/users/violuke","html_url":"https://github.com/violuke","followers_url":"https://api.github.com/users/violuke/followers","following_url":"https://api.github.com/users/violuke/following{/other_user}","gists_url":"https://api.github.com/users/violuke/gists{/gist_id}","starred_url":"https://api.github.com/users/violuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/violuke/subscriptions","organizations_url":"https://api.github.com/users/violuke/orgs","repos_url":"https://api.github.com/users/violuke/repos","events_url":"https://api.github.com/users/violuke/events{/privacy}","received_events_url":"https://api.github.com/users/violuke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-25T18:32:58Z","updated_at":"2016-11-28T15:09:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brianshumate/ansible-consul/pulls/20","html_url":"https://github.com/brianshumate/ansible-consul/pull/20","diff_url":"https://github.com/brianshumate/ansible-consul/pull/20.diff","patch_url":"https://github.com/brianshumate/ansible-consul/pull/20.patch"},"body":"Firstly, great role, it's really helped me, but it wasn't perfect in just a couple of ways, so I've made some changes to try to give back to the community. This PR does two things:\r\n\r\n1. Previously if you re-ran the role with new nodes added, the new nodes would not be set up properly. They would not know the encryption key for a start, so could never connect.\r\n2. The var `consul_bootstrap_address` was a bit too much of an assumption (your first node might not be the bootstrap node, but this assumed it was). Additionally, you should really be including the entire array of `server` nodes in the `start_join` config value, not just the first one. What if that node went down and then you restarted consul on another node? I've changed it to include all `server` and `bootstrap` nodes (apart from itself). Remember, the `bootstrap` node will become a `server` node shortly.\r\n3. It does a similar with for the ACL token as it now does for encryption keys. Also the ACL replication token was never being set before, but now is.\r\n\r\nAgain, thanks for such a great role and I hope these changes help others too."},"comment":{"url":"https://api.github.com/repos/brianshumate/ansible-consul/issues/comments/263295093","html_url":"https://github.com/brianshumate/ansible-consul/pull/20#issuecomment-263295093","issue_url":"https://api.github.com/repos/brianshumate/ansible-consul/issues/20","id":263295093,"user":{"login":"brianshumate","id":77563,"avatar_url":"https://avatars.githubusercontent.com/u/77563?v=3","gravatar_id":"","url":"https://api.github.com/users/brianshumate","html_url":"https://github.com/brianshumate","followers_url":"https://api.github.com/users/brianshumate/followers","following_url":"https://api.github.com/users/brianshumate/following{/other_user}","gists_url":"https://api.github.com/users/brianshumate/gists{/gist_id}","starred_url":"https://api.github.com/users/brianshumate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianshumate/subscriptions","organizations_url":"https://api.github.com/users/brianshumate/orgs","repos_url":"https://api.github.com/users/brianshumate/repos","events_url":"https://api.github.com/users/brianshumate/events{/privacy}","received_events_url":"https://api.github.com/users/brianshumate/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T15:09:04Z","updated_at":"2016-11-28T15:09:04Z","body":"Hi Luke,\r\n\r\nThanks for the PR!\r\n\r\nI've been on a short holiday, but am back now and can review this and merge it soon.\r\n\r\nCheers,\r\n\r\nBrian"}}
{"actor":{"display_login":"brianshumate"}}