{"action":"created","comment":{"url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/comments/82510211","pull_request_review_id":3415065,"id":82510211,"diff_hunk":"@@ -273,16 +275,19 @@ gulp.task('test', cb => {\n   return runSequence('test:server', 'test:client', cb);\n });\n \n-gulp.task('test:server', ['mocha:unit', 'mocha:integration']);\n+gulp.task('test:server', cb => {\n+  return runSequence('mocha:unit', 'mocha:integration', cb);\n+});\n \n gulp.task('mocha:unit', ['env:test'], () => {\n   return gulp.src(paths.server.test.unit)\n-    .pipe(mocha(9001)());\n+    .pipe(mocha(9001, false)());\n });\n \n gulp.task('mocha:integration', ['env:test'], () => {\n-  return gulp.src([paths.server.test.integration, paths.server.test.finalizer], {base: serverTestPath})\n-    .pipe(mocha(9002)());\n+  return gulp.src([paths.server.test.integrationInitializer, paths.server.test.integration,\n+    paths.server.test.integrationFinisher], {base: serverTestPath})\n+    .pipe(mocha(9002, true)());","path":"gulpfile.js","position":56,"original_position":56,"commit_id":"77deaba11be797e988fe70c34ce204950e1d20e1","original_commit_id":"8bff47c687a86d4b86de0def157154a62f523df9","user":{"login":"BlueEyedHush","id":5757040,"avatar_url":"https://avatars.githubusercontent.com/u/5757040?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueEyedHush","html_url":"https://github.com/BlueEyedHush","followers_url":"https://api.github.com/users/BlueEyedHush/followers","following_url":"https://api.github.com/users/BlueEyedHush/following{/other_user}","gists_url":"https://api.github.com/users/BlueEyedHush/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueEyedHush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueEyedHush/subscriptions","organizations_url":"https://api.github.com/users/BlueEyedHush/orgs","repos_url":"https://api.github.com/users/BlueEyedHush/repos","events_url":"https://api.github.com/users/BlueEyedHush/events{/privacy}","received_events_url":"https://api.github.com/users/BlueEyedHush/received_events","type":"User","site_admin":false},"body":"I often throw some unrelated changes together in one branch or one commit because separating them requires inserting commits under some of the preexisting commits... generally too much effort and too little gain.\r\nIn this case however, the changes to test layout are related - native driver has asynchronous initialization, and it carries over to the initialization process of the whole application. And if the application is initalized asynchronously, it follows that integration tests also have to be - and that\r\ns what mocha's delayed mode is used for.","created_at":"2016-10-08T21:34:32Z","updated_at":"2016-10-08T21:34:32Z","html_url":"https://github.com/DancingMonkeyTeam/bitetracker/pull/7#discussion_r82510211","pull_request_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/comments/82510211"},"html":{"href":"https://github.com/DancingMonkeyTeam/bitetracker/pull/7#discussion_r82510211"},"pull_request":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7","id":86772369,"html_url":"https://github.com/DancingMonkeyTeam/bitetracker/pull/7","diff_url":"https://github.com/DancingMonkeyTeam/bitetracker/pull/7.diff","patch_url":"https://github.com/DancingMonkeyTeam/bitetracker/pull/7.patch","issue_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/7","number":7,"state":"open","locked":false,"title":"Grocery lists backend","user":{"login":"BlueEyedHush","id":5757040,"avatar_url":"https://avatars.githubusercontent.com/u/5757040?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueEyedHush","html_url":"https://github.com/BlueEyedHush","followers_url":"https://api.github.com/users/BlueEyedHush/followers","following_url":"https://api.github.com/users/BlueEyedHush/following{/other_user}","gists_url":"https://api.github.com/users/BlueEyedHush/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueEyedHush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueEyedHush/subscriptions","organizations_url":"https://api.github.com/users/BlueEyedHush/orgs","repos_url":"https://api.github.com/users/BlueEyedHush/repos","events_url":"https://api.github.com/users/BlueEyedHush/events{/privacy}","received_events_url":"https://api.github.com/users/BlueEyedHush/received_events","type":"User","site_admin":false},"body":"Still work in progress, but I think that the general shape is there - so you can look it through if you are really interested.","created_at":"2016-09-26T16:10:42Z","updated_at":"2016-10-08T21:34:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37301197258f0d2f5626eeb87b04c689249e9827","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7/commits","review_comments_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7/comments","review_comment_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/7/comments","statuses_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/statuses/77deaba11be797e988fe70c34ce204950e1d20e1","head":{"label":"DancingMonkeyTeam:feature-grocery_lists_backend","ref":"feature-grocery_lists_backend","sha":"77deaba11be797e988fe70c34ce204950e1d20e1","user":{"login":"DancingMonkeyTeam","id":18415404,"avatar_url":"https://avatars.githubusercontent.com/u/18415404?v=3","gravatar_id":"","url":"https://api.github.com/users/DancingMonkeyTeam","html_url":"https://github.com/DancingMonkeyTeam","followers_url":"https://api.github.com/users/DancingMonkeyTeam/followers","following_url":"https://api.github.com/users/DancingMonkeyTeam/following{/other_user}","gists_url":"https://api.github.com/users/DancingMonkeyTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/DancingMonkeyTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DancingMonkeyTeam/subscriptions","organizations_url":"https://api.github.com/users/DancingMonkeyTeam/orgs","repos_url":"https://api.github.com/users/DancingMonkeyTeam/repos","events_url":"https://api.github.com/users/DancingMonkeyTeam/events{/privacy}","received_events_url":"https://api.github.com/users/DancingMonkeyTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":56049664,"name":"bitetracker","full_name":"DancingMonkeyTeam/bitetracker","owner":{"login":"DancingMonkeyTeam","id":18415404,"avatar_url":"https://avatars.githubusercontent.com/u/18415404?v=3","gravatar_id":"","url":"https://api.github.com/users/DancingMonkeyTeam","html_url":"https://github.com/DancingMonkeyTeam","followers_url":"https://api.github.com/users/DancingMonkeyTeam/followers","following_url":"https://api.github.com/users/DancingMonkeyTeam/following{/other_user}","gists_url":"https://api.github.com/users/DancingMonkeyTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/DancingMonkeyTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DancingMonkeyTeam/subscriptions","organizations_url":"https://api.github.com/users/DancingMonkeyTeam/orgs","repos_url":"https://api.github.com/users/DancingMonkeyTeam/repos","events_url":"https://api.github.com/users/DancingMonkeyTeam/events{/privacy}","received_events_url":"https://api.github.com/users/DancingMonkeyTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DancingMonkeyTeam/bitetracker","description":"","fork":false,"url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker","forks_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/forks","keys_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/teams","hooks_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/hooks","issue_events_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/events{/number}","events_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/events","assignees_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/assignees{/user}","branches_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/branches{/branch}","tags_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/tags","blobs_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/statuses/{sha}","languages_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/languages","stargazers_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/stargazers","contributors_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/contributors","subscribers_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/subscribers","subscription_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/subscription","commits_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/contents/{+path}","compare_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/merges","archive_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/downloads","issues_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues{/number}","pulls_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls{/number}","milestones_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/milestones{/number}","notifications_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/labels{/name}","releases_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/releases{/id}","deployments_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/deployments","created_at":"2016-04-12T09:29:58Z","updated_at":"2016-04-12T09:30:34Z","pushed_at":"2016-10-08T12:03:12Z","git_url":"git://github.com/DancingMonkeyTeam/bitetracker.git","ssh_url":"git@github.com:DancingMonkeyTeam/bitetracker.git","clone_url":"https://github.com/DancingMonkeyTeam/bitetracker.git","svn_url":"https://github.com/DancingMonkeyTeam/bitetracker","homepage":null,"size":21629,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"DancingMonkeyTeam:master","ref":"master","sha":"5096cf92ee020cdc3d2812c20e38bd4f4c6bd8bb","user":{"login":"DancingMonkeyTeam","id":18415404,"avatar_url":"https://avatars.githubusercontent.com/u/18415404?v=3","gravatar_id":"","url":"https://api.github.com/users/DancingMonkeyTeam","html_url":"https://github.com/DancingMonkeyTeam","followers_url":"https://api.github.com/users/DancingMonkeyTeam/followers","following_url":"https://api.github.com/users/DancingMonkeyTeam/following{/other_user}","gists_url":"https://api.github.com/users/DancingMonkeyTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/DancingMonkeyTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DancingMonkeyTeam/subscriptions","organizations_url":"https://api.github.com/users/DancingMonkeyTeam/orgs","repos_url":"https://api.github.com/users/DancingMonkeyTeam/repos","events_url":"https://api.github.com/users/DancingMonkeyTeam/events{/privacy}","received_events_url":"https://api.github.com/users/DancingMonkeyTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":56049664,"name":"bitetracker","full_name":"DancingMonkeyTeam/bitetracker","owner":{"login":"DancingMonkeyTeam","id":18415404,"avatar_url":"https://avatars.githubusercontent.com/u/18415404?v=3","gravatar_id":"","url":"https://api.github.com/users/DancingMonkeyTeam","html_url":"https://github.com/DancingMonkeyTeam","followers_url":"https://api.github.com/users/DancingMonkeyTeam/followers","following_url":"https://api.github.com/users/DancingMonkeyTeam/following{/other_user}","gists_url":"https://api.github.com/users/DancingMonkeyTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/DancingMonkeyTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DancingMonkeyTeam/subscriptions","organizations_url":"https://api.github.com/users/DancingMonkeyTeam/orgs","repos_url":"https://api.github.com/users/DancingMonkeyTeam/repos","events_url":"https://api.github.com/users/DancingMonkeyTeam/events{/privacy}","received_events_url":"https://api.github.com/users/DancingMonkeyTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DancingMonkeyTeam/bitetracker","description":"","fork":false,"url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker","forks_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/forks","keys_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/teams","hooks_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/hooks","issue_events_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/events{/number}","events_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/events","assignees_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/assignees{/user}","branches_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/branches{/branch}","tags_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/tags","blobs_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/statuses/{sha}","languages_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/languages","stargazers_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/stargazers","contributors_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/contributors","subscribers_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/subscribers","subscription_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/subscription","commits_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/contents/{+path}","compare_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/merges","archive_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/downloads","issues_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues{/number}","pulls_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls{/number}","milestones_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/milestones{/number}","notifications_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/labels{/name}","releases_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/releases{/id}","deployments_url":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/deployments","created_at":"2016-04-12T09:29:58Z","updated_at":"2016-04-12T09:30:34Z","pushed_at":"2016-10-08T12:03:12Z","git_url":"git://github.com/DancingMonkeyTeam/bitetracker.git","ssh_url":"git@github.com:DancingMonkeyTeam/bitetracker.git","clone_url":"https://github.com/DancingMonkeyTeam/bitetracker.git","svn_url":"https://github.com/DancingMonkeyTeam/bitetracker","homepage":null,"size":21629,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7"},"html":{"href":"https://github.com/DancingMonkeyTeam/bitetracker/pull/7"},"issue":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/7"},"comments":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/DancingMonkeyTeam/bitetracker/statuses/77deaba11be797e988fe70c34ce204950e1d20e1"}}}}
{"actor":{"display_login":"BlueEyedHush"}}