{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/64079165","id":64079165,"diff_hunk":"@@ -22,4 +31,13 @@\n     <Ubuntu1604NativePath Condition=\"'$(Ubuntu1604NativePath)' == ''\">$(BuildNativePath)</Ubuntu1604NativePath>\n     <SkipPackageFileCheck>true</SkipPackageFileCheck>\n   </PropertyGroup>\n+\n+  <!-- Add path globs specific to native binaries to exclude unnecessary files in packages. -->\n+  <ItemGroup>\n+    <AdditionalLibPackageExcludes Include=\"%2A%2A\\%2A.dbg\" Condition=\"'$(OSGroupPath)'=='Linux'\" />","path":"src/Native/pkg/dir.props","position":29,"original_position":29,"commit_id":"f5c0bb4d8d87cd7ab69640dd3acc0918e8ae64d4","original_commit_id":"f5c0bb4d8d87cd7ab69640dd3acc0918e8ae64d4","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"body":"Good idea, and I think I'll do similar for the other globs. (I'll also move the condition to the `ItemGroup` to continue not adding these on Windows.)","created_at":"2016-05-20T17:40:06Z","updated_at":"2016-05-20T17:40:06Z","html_url":"https://github.com/dotnet/corefx/pull/7756#discussion_r64079165","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7756","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/64079165"},"html":{"href":"https://github.com/dotnet/corefx/pull/7756#discussion_r64079165"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7756"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7756","id":66543018,"html_url":"https://github.com/dotnet/corefx/pull/7756","diff_url":"https://github.com/dotnet/corefx/pull/7756.diff","patch_url":"https://github.com/dotnet/corefx/pull/7756.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7756","number":7756,"state":"open","locked":false,"title":"Create xplat and Windows native symbol packages","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"body":"On Windows, in Debug configuration, creates symbol packages with the `.pdb` from the native build.\r\n\r\nOn Linux/OSX, in Release configuration, creates symbol packages with symbols that have been stripped from the release library. On Linux the symbol files are `.so.dbg`, on OSX `.dylib.dwarf`.\r\n\r\nThe symbol stripping code is from https://github.com/dotnet/coreclr/blob/afdce3a592e/CMakeLists.txt#L279-L340 as well as some simplified platform detection logic from earlier in that file. I also looked at the PRs for stripping coreclr symbols (https://github.com/dotnet/coreclr/pull/3872) and creating coreclr symbol packages (https://github.com/dotnet/coreclr/pull/4218) a lot while making these changes.\r\n\r\nI've tested on Win10, OSX 10.11, and Ubuntu 14.04.4. I've uploaded the resulting native symbol packages to https://www.myget.org/gallery/dagood-test-native-symbols-corefx.\r\n\r\nI had to rig a few things to test this out (I'll be looking into them further):\r\n* On OSX, I had to force my `RuntimeOS` to `osx.10.10` in `build-packages.sh`. It's being used to filter which packages are created, and my `osx.10.11` resulted in no runtime packages being made.\r\n* On all platforms I passed `/p:ConfigurationGroup=Release` (or `Debug`) to `build-packages`. The command should probably have a switch built in.\r\n\r\n/cc @ericstj @weshaggard @brianrob","created_at":"2016-04-14T19:50:19Z","updated_at":"2016-05-20T17:40:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"633962347070b7e73785261863fb84953bce24ac","assignee":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7756/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7756/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7756/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/f5c0bb4d8d87cd7ab69640dd3acc0918e8ae64d4","head":{"label":"dagood:native-symbol-packages","ref":"native-symbol-packages","sha":"f5c0bb4d8d87cd7ab69640dd3acc0918e8ae64d4","user":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"repo":{"id":47152482,"name":"corefx","full_name":"dagood/corefx","owner":{"login":"dagood","id":12819531,"avatar_url":"https://avatars.githubusercontent.com/u/12819531?v=3","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dagood/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/dagood/corefx","forks_url":"https://api.github.com/repos/dagood/corefx/forks","keys_url":"https://api.github.com/repos/dagood/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagood/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagood/corefx/teams","hooks_url":"https://api.github.com/repos/dagood/corefx/hooks","issue_events_url":"https://api.github.com/repos/dagood/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dagood/corefx/events","assignees_url":"https://api.github.com/repos/dagood/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dagood/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dagood/corefx/tags","blobs_url":"https://api.github.com/repos/dagood/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagood/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagood/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagood/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagood/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dagood/corefx/languages","stargazers_url":"https://api.github.com/repos/dagood/corefx/stargazers","contributors_url":"https://api.github.com/repos/dagood/corefx/contributors","subscribers_url":"https://api.github.com/repos/dagood/corefx/subscribers","subscription_url":"https://api.github.com/repos/dagood/corefx/subscription","commits_url":"https://api.github.com/repos/dagood/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagood/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagood/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagood/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagood/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dagood/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagood/corefx/merges","archive_url":"https://api.github.com/repos/dagood/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagood/corefx/downloads","issues_url":"https://api.github.com/repos/dagood/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dagood/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dagood/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dagood/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagood/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dagood/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dagood/corefx/deployments","created_at":"2015-11-30T23:26:07Z","updated_at":"2016-03-08T16:06:33Z","pushed_at":"2016-05-19T16:49:15Z","git_url":"git://github.com/dagood/corefx.git","ssh_url":"git@github.com:dagood/corefx.git","clone_url":"https://github.com/dagood/corefx.git","svn_url":"https://github.com/dagood/corefx","homepage":"http://dotnet.github.io/","size":69653,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"dotnet:master","ref":"master","sha":"41b5489e7e54af65a18753b7dd6b9b09edcc3021","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-05-20T14:44:15Z","pushed_at":"2016-05-20T17:37:19Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":94583,"stargazers_count":9717,"watchers_count":9717,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2331,"mirror_url":null,"open_issues_count":989,"forks":2331,"open_issues":989,"watchers":9717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7756"},"html":{"href":"https://github.com/dotnet/corefx/pull/7756"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7756"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7756/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7756/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7756/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/f5c0bb4d8d87cd7ab69640dd3acc0918e8ae64d4"}}}}
{"actor":{"display_login":"dagood"}}