{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/tafia/quick-xml/pulls/2","id":60664783,"html_url":"https://github.com/tafia/quick-xml/pull/2","diff_url":"https://github.com/tafia/quick-xml/pull/2.diff","patch_url":"https://github.com/tafia/quick-xml/pull/2.patch","issue_url":"https://api.github.com/repos/tafia/quick-xml/issues/2","number":2,"state":"closed","locked":false,"title":"Added XmlWriter and Element::create API","user":{"login":"matt2xu","id":2864300,"avatar_url":"https://avatars.githubusercontent.com/u/2864300?v=3","gravatar_id":"","url":"https://api.github.com/users/matt2xu","html_url":"https://github.com/matt2xu","followers_url":"https://api.github.com/users/matt2xu/followers","following_url":"https://api.github.com/users/matt2xu/following{/other_user}","gists_url":"https://api.github.com/users/matt2xu/gists{/gist_id}","starred_url":"https://api.github.com/users/matt2xu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt2xu/subscriptions","organizations_url":"https://api.github.com/users/matt2xu/orgs","repos_url":"https://api.github.com/users/matt2xu/repos","events_url":"https://api.github.com/users/matt2xu/events{/privacy}","received_events_url":"https://api.github.com/users/matt2xu/received_events","type":"User","site_admin":false},"body":"This PR adds the possibility to transform (add/change elements) and write XML. Two changes:\r\n\r\n  1. add a XmlWriter structure, which just wraps a Write at the moment but could (should?) be extended in the future to support pretty-printing or automatic shortening of empty tags.\r\n  2. add a \"create\" method to Element, to create an element with a name/content, and possibly attributes (should only be used for start elements, but at the moment this is not enforced). For elements with no attributes, use the iter::empty() function.\r\n\r\nI added one test for the writer, and one test for the writer + element create. Also, note that I made the XmlWriter use a Write trait rather than BufWrite because it doesn't need its additional methods at the moment, but of course for best performance one should use a writer implementing BufWrite.","created_at":"2016-02-25T11:35:17Z","updated_at":"2016-02-26T01:08:12Z","closed_at":"2016-02-26T01:08:12Z","merged_at":"2016-02-26T01:08:12Z","merge_commit_sha":"5127f343eee8ed1ce086cffc81b87497061bf34c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tafia/quick-xml/pulls/2/commits","review_comments_url":"https://api.github.com/repos/tafia/quick-xml/pulls/2/comments","review_comment_url":"https://api.github.com/repos/tafia/quick-xml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tafia/quick-xml/issues/2/comments","statuses_url":"https://api.github.com/repos/tafia/quick-xml/statuses/a1d0d2040ef0c7422f0c481c43000048d5477f5d","head":{"label":"matt2xu:writer","ref":"writer","sha":"a1d0d2040ef0c7422f0c481c43000048d5477f5d","user":{"login":"matt2xu","id":2864300,"avatar_url":"https://avatars.githubusercontent.com/u/2864300?v=3","gravatar_id":"","url":"https://api.github.com/users/matt2xu","html_url":"https://github.com/matt2xu","followers_url":"https://api.github.com/users/matt2xu/followers","following_url":"https://api.github.com/users/matt2xu/following{/other_user}","gists_url":"https://api.github.com/users/matt2xu/gists{/gist_id}","starred_url":"https://api.github.com/users/matt2xu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt2xu/subscriptions","organizations_url":"https://api.github.com/users/matt2xu/orgs","repos_url":"https://api.github.com/users/matt2xu/repos","events_url":"https://api.github.com/users/matt2xu/events{/privacy}","received_events_url":"https://api.github.com/users/matt2xu/received_events","type":"User","site_admin":false},"repo":{"id":52507899,"name":"quick-xml","full_name":"matt2xu/quick-xml","owner":{"login":"matt2xu","id":2864300,"avatar_url":"https://avatars.githubusercontent.com/u/2864300?v=3","gravatar_id":"","url":"https://api.github.com/users/matt2xu","html_url":"https://github.com/matt2xu","followers_url":"https://api.github.com/users/matt2xu/followers","following_url":"https://api.github.com/users/matt2xu/following{/other_user}","gists_url":"https://api.github.com/users/matt2xu/gists{/gist_id}","starred_url":"https://api.github.com/users/matt2xu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt2xu/subscriptions","organizations_url":"https://api.github.com/users/matt2xu/orgs","repos_url":"https://api.github.com/users/matt2xu/repos","events_url":"https://api.github.com/users/matt2xu/events{/privacy}","received_events_url":"https://api.github.com/users/matt2xu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matt2xu/quick-xml","description":"Quick xml parser","fork":true,"url":"https://api.github.com/repos/matt2xu/quick-xml","forks_url":"https://api.github.com/repos/matt2xu/quick-xml/forks","keys_url":"https://api.github.com/repos/matt2xu/quick-xml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matt2xu/quick-xml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matt2xu/quick-xml/teams","hooks_url":"https://api.github.com/repos/matt2xu/quick-xml/hooks","issue_events_url":"https://api.github.com/repos/matt2xu/quick-xml/issues/events{/number}","events_url":"https://api.github.com/repos/matt2xu/quick-xml/events","assignees_url":"https://api.github.com/repos/matt2xu/quick-xml/assignees{/user}","branches_url":"https://api.github.com/repos/matt2xu/quick-xml/branches{/branch}","tags_url":"https://api.github.com/repos/matt2xu/quick-xml/tags","blobs_url":"https://api.github.com/repos/matt2xu/quick-xml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matt2xu/quick-xml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matt2xu/quick-xml/git/refs{/sha}","trees_url":"https://api.github.com/repos/matt2xu/quick-xml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matt2xu/quick-xml/statuses/{sha}","languages_url":"https://api.github.com/repos/matt2xu/quick-xml/languages","stargazers_url":"https://api.github.com/repos/matt2xu/quick-xml/stargazers","contributors_url":"https://api.github.com/repos/matt2xu/quick-xml/contributors","subscribers_url":"https://api.github.com/repos/matt2xu/quick-xml/subscribers","subscription_url":"https://api.github.com/repos/matt2xu/quick-xml/subscription","commits_url":"https://api.github.com/repos/matt2xu/quick-xml/commits{/sha}","git_commits_url":"https://api.github.com/repos/matt2xu/quick-xml/git/commits{/sha}","comments_url":"https://api.github.com/repos/matt2xu/quick-xml/comments{/number}","issue_comment_url":"https://api.github.com/repos/matt2xu/quick-xml/issues/comments{/number}","contents_url":"https://api.github.com/repos/matt2xu/quick-xml/contents/{+path}","compare_url":"https://api.github.com/repos/matt2xu/quick-xml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matt2xu/quick-xml/merges","archive_url":"https://api.github.com/repos/matt2xu/quick-xml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matt2xu/quick-xml/downloads","issues_url":"https://api.github.com/repos/matt2xu/quick-xml/issues{/number}","pulls_url":"https://api.github.com/repos/matt2xu/quick-xml/pulls{/number}","milestones_url":"https://api.github.com/repos/matt2xu/quick-xml/milestones{/number}","notifications_url":"https://api.github.com/repos/matt2xu/quick-xml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matt2xu/quick-xml/labels{/name}","releases_url":"https://api.github.com/repos/matt2xu/quick-xml/releases{/id}","deployments_url":"https://api.github.com/repos/matt2xu/quick-xml/deployments","created_at":"2016-02-25T08:11:04Z","updated_at":"2016-02-25T08:11:06Z","pushed_at":"2016-02-25T16:50:17Z","git_url":"git://github.com/matt2xu/quick-xml.git","ssh_url":"git@github.com:matt2xu/quick-xml.git","clone_url":"https://github.com/matt2xu/quick-xml.git","svn_url":"https://github.com/matt2xu/quick-xml","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tafia:master","ref":"master","sha":"2705fa6076684ce1c64799fa0e2b4fdcbfaf2338","user":{"login":"tafia","id":7351502,"avatar_url":"https://avatars.githubusercontent.com/u/7351502?v=3","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"repo":{"id":50503287,"name":"quick-xml","full_name":"tafia/quick-xml","owner":{"login":"tafia","id":7351502,"avatar_url":"https://avatars.githubusercontent.com/u/7351502?v=3","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tafia/quick-xml","description":"Quick xml parser","fork":false,"url":"https://api.github.com/repos/tafia/quick-xml","forks_url":"https://api.github.com/repos/tafia/quick-xml/forks","keys_url":"https://api.github.com/repos/tafia/quick-xml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tafia/quick-xml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tafia/quick-xml/teams","hooks_url":"https://api.github.com/repos/tafia/quick-xml/hooks","issue_events_url":"https://api.github.com/repos/tafia/quick-xml/issues/events{/number}","events_url":"https://api.github.com/repos/tafia/quick-xml/events","assignees_url":"https://api.github.com/repos/tafia/quick-xml/assignees{/user}","branches_url":"https://api.github.com/repos/tafia/quick-xml/branches{/branch}","tags_url":"https://api.github.com/repos/tafia/quick-xml/tags","blobs_url":"https://api.github.com/repos/tafia/quick-xml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tafia/quick-xml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tafia/quick-xml/git/refs{/sha}","trees_url":"https://api.github.com/repos/tafia/quick-xml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tafia/quick-xml/statuses/{sha}","languages_url":"https://api.github.com/repos/tafia/quick-xml/languages","stargazers_url":"https://api.github.com/repos/tafia/quick-xml/stargazers","contributors_url":"https://api.github.com/repos/tafia/quick-xml/contributors","subscribers_url":"https://api.github.com/repos/tafia/quick-xml/subscribers","subscription_url":"https://api.github.com/repos/tafia/quick-xml/subscription","commits_url":"https://api.github.com/repos/tafia/quick-xml/commits{/sha}","git_commits_url":"https://api.github.com/repos/tafia/quick-xml/git/commits{/sha}","comments_url":"https://api.github.com/repos/tafia/quick-xml/comments{/number}","issue_comment_url":"https://api.github.com/repos/tafia/quick-xml/issues/comments{/number}","contents_url":"https://api.github.com/repos/tafia/quick-xml/contents/{+path}","compare_url":"https://api.github.com/repos/tafia/quick-xml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tafia/quick-xml/merges","archive_url":"https://api.github.com/repos/tafia/quick-xml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tafia/quick-xml/downloads","issues_url":"https://api.github.com/repos/tafia/quick-xml/issues{/number}","pulls_url":"https://api.github.com/repos/tafia/quick-xml/pulls{/number}","milestones_url":"https://api.github.com/repos/tafia/quick-xml/milestones{/number}","notifications_url":"https://api.github.com/repos/tafia/quick-xml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tafia/quick-xml/labels{/name}","releases_url":"https://api.github.com/repos/tafia/quick-xml/releases{/id}","deployments_url":"https://api.github.com/repos/tafia/quick-xml/deployments","created_at":"2016-01-27T11:37:44Z","updated_at":"2016-02-25T12:47:42Z","pushed_at":"2016-02-26T01:08:12Z","git_url":"git://github.com/tafia/quick-xml.git","ssh_url":"git@github.com:tafia/quick-xml.git","clone_url":"https://github.com/tafia/quick-xml.git","svn_url":"https://github.com/tafia/quick-xml","homepage":null,"size":15,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tafia/quick-xml/pulls/2"},"html":{"href":"https://github.com/tafia/quick-xml/pull/2"},"issue":{"href":"https://api.github.com/repos/tafia/quick-xml/issues/2"},"comments":{"href":"https://api.github.com/repos/tafia/quick-xml/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/tafia/quick-xml/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/tafia/quick-xml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tafia/quick-xml/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/tafia/quick-xml/statuses/a1d0d2040ef0c7422f0c481c43000048d5477f5d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tafia","id":7351502,"avatar_url":"https://avatars.githubusercontent.com/u/7351502?v=3","gravatar_id":"","url":"https://api.github.com/users/tafia","html_url":"https://github.com/tafia","followers_url":"https://api.github.com/users/tafia/followers","following_url":"https://api.github.com/users/tafia/following{/other_user}","gists_url":"https://api.github.com/users/tafia/gists{/gist_id}","starred_url":"https://api.github.com/users/tafia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tafia/subscriptions","organizations_url":"https://api.github.com/users/tafia/orgs","repos_url":"https://api.github.com/users/tafia/repos","events_url":"https://api.github.com/users/tafia/events{/privacy}","received_events_url":"https://api.github.com/users/tafia/received_events","type":"User","site_admin":false},"comments":5,"review_comments":5,"commits":4,"additions":171,"deletions":21,"changed_files":2}}