{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/48684208","id":48684208,"diff_hunk":"@@ -547,17 +547,39 @@ std::string CURL::Get() const\n   std::string strURL;\n   strURL.reserve(sizeneed);\n \n-  strURL = GetWithoutFilename();\n-  strURL += m_strFileName;\n+  strURL = GetWithoutOptions();\n \n   if( !m_strOptions.empty() )\n     strURL += m_strOptions;\n+\n   if (!m_strProtocolOptions.empty())\n     strURL += \"|\"+m_strProtocolOptions;\n \n   return strURL;\n }\n \n+std::string CURL::GetWithoutOptions() const\n+{\n+  unsigned int sizeneed = m_strProtocol.length()\n+                        + m_strDomain.length()\n+                        + m_strUserName.length()\n+                        + m_strPassword.length()\n+                        + m_strHostName.length()\n+                        + m_strFileName.length()\n+                        + 10;\n+\n+  if (m_strProtocol.empty())\n+    return m_strFileName;\n+\n+  std::string strURL;\n+  strURL.reserve(sizeneed);\n+\n+  strURL = GetWithoutFilename();\n+  strURL += m_strFileName;\n+\n+  return strURL;\n+}\n+","path":"xbmc/URL.cpp","position":38,"original_position":38,"commit_id":"31e4fb015881e17737a8c4df8b4bd4a433e2541c","original_commit_id":"31e4fb015881e17737a8c4df8b4bd4a433e2541c","user":{"login":"ace20022","id":2150851,"avatar_url":"https://avatars.githubusercontent.com/u/2150851?v=3","gravatar_id":"","url":"https://api.github.com/users/ace20022","html_url":"https://github.com/ace20022","followers_url":"https://api.github.com/users/ace20022/followers","following_url":"https://api.github.com/users/ace20022/following{/other_user}","gists_url":"https://api.github.com/users/ace20022/gists{/gist_id}","starred_url":"https://api.github.com/users/ace20022/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ace20022/subscriptions","organizations_url":"https://api.github.com/users/ace20022/orgs","repos_url":"https://api.github.com/users/ace20022/repos","events_url":"https://api.github.com/users/ace20022/events{/privacy}","received_events_url":"https://api.github.com/users/ace20022/received_events","type":"User","site_admin":false},"body":"This seems to be equivalent to\r\n```c++\r\nstd::string CURL::GetWithoutOptions() const\r\n{\r\n  if (m_strProtocol.empty())\r\n    return m_strFileName;\r\n  \r\n  return GetWithoutFilename() + m_strFileName;\r\n}\r\n```\r\nOr have I missed something? ","created_at":"2016-01-02T11:52:28Z","updated_at":"2016-01-02T11:52:28Z","html_url":"https://github.com/xbmc/xbmc/pull/8724#discussion_r48684208","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8724","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/48684208"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8724#discussion_r48684208"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8724"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8724","id":54857345,"html_url":"https://github.com/xbmc/xbmc/pull/8724","diff_url":"https://github.com/xbmc/xbmc/pull/8724.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8724.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8724","number":8724,"state":"open","locked":false,"title":"fixed: Dir cache should ignore url (protocol) options (fixes #16469)","user":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"body":"Followup for https://github.com/xbmc/xbmc/pull/8717","created_at":"2015-12-31T10:19:46Z","updated_at":"2016-01-02T11:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a37f88577bdd8109000b766e7f97baf04189f09b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8724/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8724/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8724/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/31e4fb015881e17737a8c4df8b4bd4a433e2541c","head":{"label":"arnova:dircache_url_options_fix","ref":"dircache_url_options_fix","sha":"31e4fb015881e17737a8c4df8b4bd4a433e2541c","user":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"repo":{"id":1396979,"name":"xbmc","full_name":"arnova/xbmc","owner":{"login":"arnova","id":544531,"avatar_url":"https://avatars.githubusercontent.com/u/544531?v=3","gravatar_id":"","url":"https://api.github.com/users/arnova","html_url":"https://github.com/arnova","followers_url":"https://api.github.com/users/arnova/followers","following_url":"https://api.github.com/users/arnova/following{/other_user}","gists_url":"https://api.github.com/users/arnova/gists{/gist_id}","starred_url":"https://api.github.com/users/arnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnova/subscriptions","organizations_url":"https://api.github.com/users/arnova/orgs","repos_url":"https://api.github.com/users/arnova/repos","events_url":"https://api.github.com/users/arnova/events{/privacy}","received_events_url":"https://api.github.com/users/arnova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arnova/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/arnova/xbmc","forks_url":"https://api.github.com/repos/arnova/xbmc/forks","keys_url":"https://api.github.com/repos/arnova/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arnova/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arnova/xbmc/teams","hooks_url":"https://api.github.com/repos/arnova/xbmc/hooks","issue_events_url":"https://api.github.com/repos/arnova/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/arnova/xbmc/events","assignees_url":"https://api.github.com/repos/arnova/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/arnova/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/arnova/xbmc/tags","blobs_url":"https://api.github.com/repos/arnova/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arnova/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arnova/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/arnova/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arnova/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/arnova/xbmc/languages","stargazers_url":"https://api.github.com/repos/arnova/xbmc/stargazers","contributors_url":"https://api.github.com/repos/arnova/xbmc/contributors","subscribers_url":"https://api.github.com/repos/arnova/xbmc/subscribers","subscription_url":"https://api.github.com/repos/arnova/xbmc/subscription","commits_url":"https://api.github.com/repos/arnova/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/arnova/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/arnova/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/arnova/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/arnova/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/arnova/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arnova/xbmc/merges","archive_url":"https://api.github.com/repos/arnova/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arnova/xbmc/downloads","issues_url":"https://api.github.com/repos/arnova/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/arnova/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/arnova/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/arnova/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arnova/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/arnova/xbmc/releases{/id}","created_at":"2011-02-22T09:32:06Z","updated_at":"2015-05-05T17:10:09Z","pushed_at":"2015-12-31T09:18:19Z","git_url":"git://github.com/arnova/xbmc.git","ssh_url":"git@github.com:arnova/xbmc.git","clone_url":"https://github.com/arnova/xbmc.git","svn_url":"https://github.com/arnova/xbmc","homepage":"http://xbmc.org","size":533305,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"5ece5e0d4b9941e5a6825f44a55dae6b2a4dd372","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-01-02T10:58:52Z","pushed_at":"2016-01-02T11:43:50Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1727084,"stargazers_count":4377,"watchers_count":4377,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3230,"mirror_url":null,"open_issues_count":213,"forks":3230,"open_issues":213,"watchers":4377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8724"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8724"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8724"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8724/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8724/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8724/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/31e4fb015881e17737a8c4df8b4bd4a433e2541c"}}}}