{"action":"created","issue":{"url":"https://api.github.com/repos/babab/DisPass/issues/44","repository_url":"https://api.github.com/repos/babab/DisPass","labels_url":"https://api.github.com/repos/babab/DisPass/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/babab/DisPass/issues/44/comments","events_url":"https://api.github.com/repos/babab/DisPass/issues/44/events","html_url":"https://github.com/babab/DisPass/pull/44","id":140330444,"number":44,"title":"Add desktop file","user":{"login":"ryuslash","id":132613,"avatar_url":"https://avatars.githubusercontent.com/u/132613?v=3","gravatar_id":"","url":"https://api.github.com/users/ryuslash","html_url":"https://github.com/ryuslash","followers_url":"https://api.github.com/users/ryuslash/followers","following_url":"https://api.github.com/users/ryuslash/following{/other_user}","gists_url":"https://api.github.com/users/ryuslash/gists{/gist_id}","starred_url":"https://api.github.com/users/ryuslash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryuslash/subscriptions","organizations_url":"https://api.github.com/users/ryuslash/orgs","repos_url":"https://api.github.com/users/ryuslash/repos","events_url":"https://api.github.com/users/ryuslash/events{/privacy}","received_events_url":"https://api.github.com/users/ryuslash/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-12T01:18:36Z","updated_at":"2016-03-13T10:51:00Z","closed_at":"2016-03-13T02:13:14Z","pull_request":{"url":"https://api.github.com/repos/babab/DisPass/pulls/44","html_url":"https://github.com/babab/DisPass/pull/44","diff_url":"https://github.com/babab/DisPass/pull/44.diff","patch_url":"https://github.com/babab/DisPass/pull/44.patch"},"body":"This also adds the `$DESTDIR` variable to the Makefile and installs the appropriate logo files to the hicolor icon theme so they can be found by the desktop environment parsing the desktop file.\r\n\r\nI changed some `mv` and `cp` calls in the Makefile to `install` because my test (`make install DESTDIR=$(realpath dispass-test/)`) ran into errors of non-existent directories.\r\n\r\nI didn't know where to put the desktop file, so I added an `etc/` directory."},"comment":{"url":"https://api.github.com/repos/babab/DisPass/issues/comments/195933763","html_url":"https://github.com/babab/DisPass/pull/44#issuecomment-195933763","issue_url":"https://api.github.com/repos/babab/DisPass/issues/44","id":195933763,"user":{"login":"ryuslash","id":132613,"avatar_url":"https://avatars.githubusercontent.com/u/132613?v=3","gravatar_id":"","url":"https://api.github.com/users/ryuslash","html_url":"https://github.com/ryuslash","followers_url":"https://api.github.com/users/ryuslash/followers","following_url":"https://api.github.com/users/ryuslash/following{/other_user}","gists_url":"https://api.github.com/users/ryuslash/gists{/gist_id}","starred_url":"https://api.github.com/users/ryuslash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryuslash/subscriptions","organizations_url":"https://api.github.com/users/ryuslash/orgs","repos_url":"https://api.github.com/users/ryuslash/repos","events_url":"https://api.github.com/users/ryuslash/events{/privacy}","received_events_url":"https://api.github.com/users/ryuslash/received_events","type":"User","site_admin":false},"created_at":"2016-03-13T10:51:00Z","updated_at":"2016-03-13T10:51:00Z","body":"Yeah I'm not that familiar with the `--root` argument, I use(d) it in the wdocker pkgbuild because I saw that other packages were doing that too. That may have been with setup.py instead of pip, though. I also noticed that pip would refuse to install anything at all if there was no upgrade to perform.\r\n\r\nSo thanks for the changes! I'll try them out in the dispass-git pkgbuild."}}