{"action":"created","comment":{"url":"https://api.github.com/repos/CommBank/maestro/pulls/comments/67112920","id":67112920,"diff_hunk":"@@ -38,8 +38,9 @@ import au.com.cba.omnia.maestro.scalding.ExecutionOps._\n   * Base type for partitioned and unpartitioned Hive tables.\n   * ST - Type parameter of [[TypedSink]] and [[TypedPipe]]\n   * returned in `sink` and `write` methods respectively.\n+  * F - Can be any type given a way to extract `ST` from `F`\n   */\n-sealed trait HiveTable[T <: ThriftStruct, ST] {\n+sealed trait GenHiveTable[T <: ThriftStruct, ST, F] {","path":"maestro-scalding/src/main/scala/au/com/cba/omnia/maestro/hive/HiveTable.scala","position":7,"original_position":7,"commit_id":"3739a8f973994d9faa0ee64b00b8857d7441153e","original_commit_id":"3739a8f973994d9faa0ee64b00b8857d7441153e","user":{"login":"rowandavies","id":468519,"avatar_url":"https://avatars.githubusercontent.com/u/468519?v=3","gravatar_id":"","url":"https://api.github.com/users/rowandavies","html_url":"https://github.com/rowandavies","followers_url":"https://api.github.com/users/rowandavies/followers","following_url":"https://api.github.com/users/rowandavies/following{/other_user}","gists_url":"https://api.github.com/users/rowandavies/gists{/gist_id}","starred_url":"https://api.github.com/users/rowandavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowandavies/subscriptions","organizations_url":"https://api.github.com/users/rowandavies/orgs","repos_url":"https://api.github.com/users/rowandavies/repos","events_url":"https://api.github.com/users/rowandavies/events{/privacy}","received_events_url":"https://api.github.com/users/rowandavies/received_events","type":"User","site_admin":false},"body":"Right - it's following the scala api convention that has `GenSeq`, `GenTraversable`, ... for generalised versions of pre-existing things.   I'd agree it could be more specific about what was generalised.  Maybe `HiveTableWithExtractor`?\r\n","created_at":"2016-06-15T07:36:15Z","updated_at":"2016-06-15T07:36:15Z","html_url":"https://github.com/CommBank/maestro/pull/493#discussion_r67112920","pull_request_url":"https://api.github.com/repos/CommBank/maestro/pulls/493","_links":{"self":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/comments/67112920"},"html":{"href":"https://github.com/CommBank/maestro/pull/493#discussion_r67112920"},"pull_request":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/493"}}},"pull_request":{"url":"https://api.github.com/repos/CommBank/maestro/pulls/493","id":73664802,"html_url":"https://github.com/CommBank/maestro/pull/493","diff_url":"https://github.com/CommBank/maestro/pull/493.diff","patch_url":"https://github.com/CommBank/maestro/pull/493.patch","issue_url":"https://api.github.com/repos/CommBank/maestro/issues/493","number":493,"state":"open","locked":false,"title":"Make HiveTable generic to support partition information supplied externally","user":{"login":"vineethMM","id":11322952,"avatar_url":"https://avatars.githubusercontent.com/u/11322952?v=3","gravatar_id":"","url":"https://api.github.com/users/vineethMM","html_url":"https://github.com/vineethMM","followers_url":"https://api.github.com/users/vineethMM/followers","following_url":"https://api.github.com/users/vineethMM/following{/other_user}","gists_url":"https://api.github.com/users/vineethMM/gists{/gist_id}","starred_url":"https://api.github.com/users/vineethMM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vineethMM/subscriptions","organizations_url":"https://api.github.com/users/vineethMM/orgs","repos_url":"https://api.github.com/users/vineethMM/repos","events_url":"https://api.github.com/users/vineethMM/events{/privacy}","received_events_url":"https://api.github.com/users/vineethMM/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-14T00:40:32Z","updated_at":"2016-06-15T07:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42fc23995a2a707949865170bd12fe90a304d669","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CommBank/maestro/pulls/493/commits","review_comments_url":"https://api.github.com/repos/CommBank/maestro/pulls/493/comments","review_comment_url":"https://api.github.com/repos/CommBank/maestro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CommBank/maestro/issues/493/comments","statuses_url":"https://api.github.com/repos/CommBank/maestro/statuses/3739a8f973994d9faa0ee64b00b8857d7441153e","head":{"label":"CommBank:partitioned-hive-table-488","ref":"partitioned-hive-table-488","sha":"3739a8f973994d9faa0ee64b00b8857d7441153e","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":17347463,"name":"maestro","full_name":"CommBank/maestro","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/maestro","description":"Well-typed data pipeline framework for building robust ETL jobs","fork":false,"url":"https://api.github.com/repos/CommBank/maestro","forks_url":"https://api.github.com/repos/CommBank/maestro/forks","keys_url":"https://api.github.com/repos/CommBank/maestro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/maestro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/maestro/teams","hooks_url":"https://api.github.com/repos/CommBank/maestro/hooks","issue_events_url":"https://api.github.com/repos/CommBank/maestro/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/maestro/events","assignees_url":"https://api.github.com/repos/CommBank/maestro/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/maestro/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/maestro/tags","blobs_url":"https://api.github.com/repos/CommBank/maestro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/maestro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/maestro/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/maestro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/maestro/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/maestro/languages","stargazers_url":"https://api.github.com/repos/CommBank/maestro/stargazers","contributors_url":"https://api.github.com/repos/CommBank/maestro/contributors","subscribers_url":"https://api.github.com/repos/CommBank/maestro/subscribers","subscription_url":"https://api.github.com/repos/CommBank/maestro/subscription","commits_url":"https://api.github.com/repos/CommBank/maestro/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/maestro/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/maestro/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/maestro/issues/comments{/number}","contents_url":"https://api.github.com/repos/CommBank/maestro/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/maestro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/maestro/merges","archive_url":"https://api.github.com/repos/CommBank/maestro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/maestro/downloads","issues_url":"https://api.github.com/repos/CommBank/maestro/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/maestro/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/maestro/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/maestro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/maestro/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/maestro/releases{/id}","deployments_url":"https://api.github.com/repos/CommBank/maestro/deployments","created_at":"2014-03-02T21:34:53Z","updated_at":"2016-06-07T17:00:50Z","pushed_at":"2016-06-15T06:05:23Z","git_url":"git://github.com/CommBank/maestro.git","ssh_url":"git@github.com:CommBank/maestro.git","clone_url":"https://github.com/CommBank/maestro.git","svn_url":"https://github.com/CommBank/maestro","homepage":"https://commbank.github.io/maestro","size":57980,"stargazers_count":62,"watchers_count":62,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":63,"forks":30,"open_issues":63,"watchers":62,"default_branch":"master"}},"base":{"label":"CommBank:master","ref":"master","sha":"e06bc75d418e4e0693524f5290650e998cd6bf36","user":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"repo":{"id":17347463,"name":"maestro","full_name":"CommBank/maestro","owner":{"login":"CommBank","id":4240076,"avatar_url":"https://avatars.githubusercontent.com/u/4240076?v=3","gravatar_id":"","url":"https://api.github.com/users/CommBank","html_url":"https://github.com/CommBank","followers_url":"https://api.github.com/users/CommBank/followers","following_url":"https://api.github.com/users/CommBank/following{/other_user}","gists_url":"https://api.github.com/users/CommBank/gists{/gist_id}","starred_url":"https://api.github.com/users/CommBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CommBank/subscriptions","organizations_url":"https://api.github.com/users/CommBank/orgs","repos_url":"https://api.github.com/users/CommBank/repos","events_url":"https://api.github.com/users/CommBank/events{/privacy}","received_events_url":"https://api.github.com/users/CommBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CommBank/maestro","description":"Well-typed data pipeline framework for building robust ETL jobs","fork":false,"url":"https://api.github.com/repos/CommBank/maestro","forks_url":"https://api.github.com/repos/CommBank/maestro/forks","keys_url":"https://api.github.com/repos/CommBank/maestro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CommBank/maestro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CommBank/maestro/teams","hooks_url":"https://api.github.com/repos/CommBank/maestro/hooks","issue_events_url":"https://api.github.com/repos/CommBank/maestro/issues/events{/number}","events_url":"https://api.github.com/repos/CommBank/maestro/events","assignees_url":"https://api.github.com/repos/CommBank/maestro/assignees{/user}","branches_url":"https://api.github.com/repos/CommBank/maestro/branches{/branch}","tags_url":"https://api.github.com/repos/CommBank/maestro/tags","blobs_url":"https://api.github.com/repos/CommBank/maestro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CommBank/maestro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CommBank/maestro/git/refs{/sha}","trees_url":"https://api.github.com/repos/CommBank/maestro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CommBank/maestro/statuses/{sha}","languages_url":"https://api.github.com/repos/CommBank/maestro/languages","stargazers_url":"https://api.github.com/repos/CommBank/maestro/stargazers","contributors_url":"https://api.github.com/repos/CommBank/maestro/contributors","subscribers_url":"https://api.github.com/repos/CommBank/maestro/subscribers","subscription_url":"https://api.github.com/repos/CommBank/maestro/subscription","commits_url":"https://api.github.com/repos/CommBank/maestro/commits{/sha}","git_commits_url":"https://api.github.com/repos/CommBank/maestro/git/commits{/sha}","comments_url":"https://api.github.com/repos/CommBank/maestro/comments{/number}","issue_comment_url":"https://api.github.com/repos/CommBank/maestro/issues/comments{/number}","contents_url":"https://api.github.com/repos/CommBank/maestro/contents/{+path}","compare_url":"https://api.github.com/repos/CommBank/maestro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CommBank/maestro/merges","archive_url":"https://api.github.com/repos/CommBank/maestro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CommBank/maestro/downloads","issues_url":"https://api.github.com/repos/CommBank/maestro/issues{/number}","pulls_url":"https://api.github.com/repos/CommBank/maestro/pulls{/number}","milestones_url":"https://api.github.com/repos/CommBank/maestro/milestones{/number}","notifications_url":"https://api.github.com/repos/CommBank/maestro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CommBank/maestro/labels{/name}","releases_url":"https://api.github.com/repos/CommBank/maestro/releases{/id}","deployments_url":"https://api.github.com/repos/CommBank/maestro/deployments","created_at":"2014-03-02T21:34:53Z","updated_at":"2016-06-07T17:00:50Z","pushed_at":"2016-06-15T06:05:23Z","git_url":"git://github.com/CommBank/maestro.git","ssh_url":"git@github.com:CommBank/maestro.git","clone_url":"https://github.com/CommBank/maestro.git","svn_url":"https://github.com/CommBank/maestro","homepage":"https://commbank.github.io/maestro","size":57980,"stargazers_count":62,"watchers_count":62,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":63,"forks":30,"open_issues":63,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/493"},"html":{"href":"https://github.com/CommBank/maestro/pull/493"},"issue":{"href":"https://api.github.com/repos/CommBank/maestro/issues/493"},"comments":{"href":"https://api.github.com/repos/CommBank/maestro/issues/493/comments"},"review_comments":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/493/comments"},"review_comment":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CommBank/maestro/pulls/493/commits"},"statuses":{"href":"https://api.github.com/repos/CommBank/maestro/statuses/3739a8f973994d9faa0ee64b00b8857d7441153e"}}}}
{"actor":{"display_login":"rowandavies"}}