{"push_id":1179960195,"size":89,"distinct_size":80,"ref":"refs/heads/master","head":"5c31ba50984b5d9b6eb77cb1881bb94f156ae20e","before":"adcb9491bd6b45066f13637891ee5cbd94e311bc","commits":[{"sha":"6a828328e17c64a026b447357a619a00f0356425","author":{"name":"ColCh","email":"ebd87b6df573fddb63830eefe7a282114b633b62@gmail.com"},"message":"Add tabindex attribute to searchbar\n\nSummary:\nExplain the **motivation** for making this change. What existing problem does the pull request solve?\n\nThis is small improvement to docs webpage.\nI'm tired of clicking on searchbar with mouse/touchpad, so I've added a `tabindex` attribute to it, so it can be now focused with `Tab` key.\n\nI think this greatly improves user experience on documentation searching.\n\n**Test plan (required)**\n\n??? Just click on `Tab` and it will focus. Should I test it really?\n\n**Code formatting**\n\nAttributes are sorted alphabetically, I've inserted new attribute in this order, after `id` and before `type` attributes.\nCloses https://github.com/facebook/react-native/pull/8319\n\nDifferential Revision: D3470858\n\nfbshipit-source-id: 01240bdf1432d9873324ddee38be256dfab93df2","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/6a828328e17c64a026b447357a619a00f0356425"},{"sha":"f03bc9016e343285eb3f329384f3bbccf4ecc7a9","author":{"name":"Nathan Azaria","email":"34dffb0ea4248970c74e2fb0fbe92ccc35bcb1fb@fb.com"},"message":"Fixed flowtype of ListViewDataSource to accept optional params\n\nSummary:\nParamType of ListViewDataSource currently requires all the parameters to be supplied, although they are nullable.\nThis diff fixed it and allows the parameters to be not supplied.\n\nReviewed By: javache\n\nDifferential Revision: D3462796\n\nfbshipit-source-id: 68dee260ff0c4020b7fd2bb7031d14c980812694","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/f03bc9016e343285eb3f329384f3bbccf4ecc7a9"},{"sha":"c54f468ab25d0af9f812d745cae5f2a89463b222","author":{"name":"Greg Pstrucha","email":"abd9aa36d77d486276dc1ff5039f85ac4358e282@fb.com"},"message":"Enable -Wglobal-constructors\n\nReviewed By: kastiglione\n\nDifferential Revision: D3459099\n\nfbshipit-source-id: 2c847dcaf519508101ca6be09aa4d9236e1d7d51","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/c54f468ab25d0af9f812d745cae5f2a89463b222"},{"sha":"f4a8efa45256188435ad4cf1eae88362c36bd6f7","author":{"name":"Devin Abbott","email":"052a527646e49ccb3a0794ddd110c6b6adc693a5@gmail.com"},"message":"Add react-native-web-player to core components docs\n\nSummary:\nThis PR adds the interactive [React Native Web Player](http://dabbott.github.io/react-native-web-player/) to the docs. The web player is an embeddable iframe which runs React Native code using components from [react-native-web](https://github.com/necolas/react-native-web). For now, it's primarily for educational purposes, since only the basic components are implemented.\n\nSome details:\n- The iframe is loaded from MaxCDN using rawgit, locked down to a git tag.\n- Asset paths (i.e. images) are resolved relative to `//facebook.github.io/react-native/`\n- When viewed on mobile, it falls back to the syntax-highlighted code blocks.\n\nThe WebPlayer can be inserted into markdown by using the fences:\n\n```\n```ReactNativeWebPlayer\n\nimport ...\n\nAppRegistry.registerComponent ...\n\n`` `\n```\n\n![screen shot 2016-06-22 at 12 46 50 pm](https://cloud.githubusercontent.com/assets/1198882/16281068/7056804e-3877-11e6-82f7-ece245690548.png)\n\nI didn't actually add the WebPlayer to any docs pages in this PR. That we c\nCloses https://github.com/facebook/react-native/pull/8328\n\nDifferential Revision: D3471527\n\nPulled By: lacker\n\nfbshipit-source-id: 704da41cd77e08c7e2bc820557a74d36e88e8eb7","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/f4a8efa45256188435ad4cf1eae88362c36bd6f7"},{"sha":"072ef0a0d45579f56e87e0f963533028cc3fc23f","author":{"name":"Kevin Lacker","email":"eac9467eb0adeae68264a6970ac0a2cfceea0472@gmail.com"},"message":"More Resources doc, updating Support doc and quickstart too\n\nSummary:\nTLDR even more docs changes\n\nSo I created a More Resources doc that aggregates the high-quality-but-off-site stuff. Let's try to put more outlinks there. Also I removed the stuff on Support that was not support, and some misc changes to clean stuff up.\nCloses https://github.com/facebook/react-native/pull/8329\n\nDifferential Revision: D3471669\n\nPulled By: JoelMarcey\n\nfbshipit-source-id: 54edd543ced1b3a8f3d0baca5475ac96bae6e487","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/072ef0a0d45579f56e87e0f963533028cc3fc23f"},{"sha":"c95d3ef147325257097ebe81cfdd590e781f3202","author":{"name":"Ahmed El-Helw","email":"d2fef286a68d2b1b16b83145753fa5cc0ff46e38@fb.com"},"message":"Fix measure callback for TextInput on Nodes\n\nSummary: Add a MeasureUtil class\n\nReviewed By: emilsjolander\n\nDifferential Revision: D3467598\n\nfbshipit-source-id: 3ef0da1e4ef16c1f9756653d0aa2e8aa5a598eb1","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/c95d3ef147325257097ebe81cfdd590e781f3202"},{"sha":"d464f1d1c2770baa4b1bb95c4a57ba263c61f66c","author":{"name":"Joel Marcey","email":"274ca67ee81f654303535db421cd30f3dd362b67@fb.com"},"message":"Add React Native Web Player to most component basics\n\nSummary:\n> ListView is not supported by React Native Web as of yet, so it will not have it.\nCloses https://github.com/facebook/react-native/pull/8331\n\nDifferential Revision: D3472019\n\nPulled By: lacker\n\nfbshipit-source-id: e5fb430b6c8f4d437943c159beb00b9d9252c92d","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/d464f1d1c2770baa4b1bb95c4a57ba263c61f66c"},{"sha":"b4d15d3c5ac4542931e0f3d1b93b42109e523550","author":{"name":"Eric Vicenti","email":"60993fd2931bccf8b94630fa7735ef9356a373c3@fb.com"},"message":"Fix stale scene cleanup\n\nSummary: Previously we would not re-compute `this._transitionProps` after cleaning up stale scenes, so the render caused by setState still had the stale scenes in the props\n\nReviewed By: hedgerwang\n\nDifferential Revision: D3471011\n\nfbshipit-source-id: fd08ef7a21355a229e877c85f06d6584eb44f38e","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/b4d15d3c5ac4542931e0f3d1b93b42109e523550"},{"sha":"4ec53ee8fa2183fdeef52f0cb03c40bd6c56c451","author":{"name":"Christine Abernathy","email":"055f8462a9fc823eeeb6a0368935ab27dc9ad3a1@fb.com"},"message":"Update Navigator component doc\n\nSummary:\nRelated to #8203 to update the Navigator component reference doc.\n\n**Test plan (required)**\n\nStarted up the website and checked:\nhttp://localhost:8079/react-native/docs/navigator.html\n\n![component_navigator_2](https://cloud.githubusercontent.com/assets/691109/16280426/3f2cdc32-3874-11e6-810b-ca34d7bd4972.png)\n\n**Note**\n\nThe code is not Flow-ified so depended on jsdoc formatting to get the method parameter types. There's a current issue with handling optional types via react-docgen which parses components. There's an open PR to look into this: https://github.com/reactjs/react-docgen/pull/89. When that's resolved the `replaceAtIndex` method parameter type that's documented for `cb` needs to be updated to make it optional.\nCloses https://github.com/facebook/react-native/pull/8318\n\nDifferential Revision: D3471185\n\nPulled By: JoelMarcey\n\nfbshipit-source-id: 99f85ee2ab00dc200cf2812cce5b3ccec743d6a0","distinct":false,"url":"https://api.github.com/repos/erickreutz/react-native/commits/4ec53ee8fa2183fdeef52f0cb03c40bd6c56c451"},{"sha":"fdcb865cf3f3a5c4ef3cab62ba4dbe6a49f52e4b","author":{"name":"Chris Hopman","email":"b4caa24f9de55f461e4c51db2576ccfc3b9fb18e@fb.com"},"message":"Fix sending accessibility events to RN modals\n\nReviewed By: dmmiller\n\nDifferential Revision: D3472359\n\nfbshipit-source-id: c82d8e254cdd0531eb52805a6f00e63cf783fdc8","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/fdcb865cf3f3a5c4ef3cab62ba4dbe6a49f52e4b"},{"sha":"fff3d5dfb44b0fd326c65266d32a4ae7b1dc375d","author":{"name":"Kevin Lacker","email":"eac9467eb0adeae68264a6970ac0a2cfceea0472@gmail.com"},"message":"fix Firefox bug\n\nSummary:\nThe motivation is that the getting started page was not working in some cases in Firefox.\n\nThis line of code appears to be at best a no-op, at worst fails in Firefox, since \"event\" is undefined.\nCloses https://github.com/facebook/react-native/pull/8335\n\nDifferential Revision: D3473333\n\nPulled By: JoelMarcey\n\nfbshipit-source-id: 40581e83126675aa072c6ee25609cfb787015ce7","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/fff3d5dfb44b0fd326c65266d32a4ae7b1dc375d"},{"sha":"8feb1dc3b71ebf5c24acc6eeacf0b798c4141ff2","author":{"name":"Marc Horowitz","email":"5e85808dffeff32aa7915794d93d1e0510e0c781@fb.com"},"message":"If ExceptionsManager.handleException throws, throw the original error\n\nSummary:\nThis will let the JSC exception handling catch the error, and\ndisplay it in a red box.\n\nReviewed By: yungsters\n\nDifferential Revision: D3468336\n\nfbshipit-source-id: b89335dbcebf16a881bba783c68242e2b0cd509f","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/8feb1dc3b71ebf5c24acc6eeacf0b798c4141ff2"},{"sha":"590f90fe2eab0fc4a1d64e2409eaf4a617dcd9d1","author":{"name":"Artyom Trityak","email":"97f14341030a53db6635f457587376b722770c00@gmail.com"},"message":"Fix guides docs to es2015 classes and remove flowtype from Animation example\n\nSummary:\n1. Animation guide page is the only place where Flowtype is used, it would be better to remove it to prevent some confusion.\n\n2. ES2015 classes in guidelines docs pages and fixed some typos\n\n**Test plan (required)**\n\nShould i write any tests for this?\nCloses https://github.com/facebook/react-native/pull/8339\n\nDifferential Revision: D3474192\n\nPulled By: bestander\n\nfbshipit-source-id: 5531d1e399eaed0952732ac2e0bd1effc72d00a8","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/590f90fe2eab0fc4a1d64e2409eaf4a617dcd9d1"},{"sha":"6cd712713b1673f13510bc127ac970648f9b5eb3","author":{"name":"Mike Lambert","email":"0025b2ecb83717b3cbde54fec053fb1763cb5d2a@gmail.com"},"message":"Support selectable={true} property on Text fields on Android.\n\nSummary:\nExplain the **motivation** for making this change. What existing problem does the pull request solve?\n\nThis adds support for a text field that the user can click-and-drag to select text (which can then be copied using the native selected-text-hover-widget).\n\nI'd love to add this to iOS too, but iOS appears to draw glyphs directly to the screen for its <Text> widget (versus using UITextField), so it might be too difficult to support there. But at least I can support my Android users with this change.\n\nLet me know if/what kind of \"demonstrate the code is solid\" you would like for this. A screenshot of selected text with this property set?\nCloses https://github.com/facebook/react-native/pull/8028\n\nDifferential Revision: D3474196\n\nPulled By: bestander\n\nfbshipit-source-id: 8d3656681265a0e6229bfa13ff2ae021e894d3cd","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/6cd712713b1673f13510bc127ac970648f9b5eb3"},{"sha":"9b9df78e28342e484b8bfeec6207dbe0c7d4f869","author":{"name":"Joel Marcey","email":"274ca67ee81f654303535db421cd30f3dd362b67@fb.com"},"message":"Update Views API documentation\n\nSummary:\nEnsure all `props` have documentation. Add more details to current `props`.\nProvide more information to the API in general.\n\n> Would like to try to integrate the React Native Web Player for the initial\n> example, but not right now.\nCloses https://github.com/facebook/react-native/pull/8341\n\nDifferential Revision: D3475105\n\nPulled By: caabernathy\n\nfbshipit-source-id: 00ad30b2359831740715517278bec1d0231e089d","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/9b9df78e28342e484b8bfeec6207dbe0c7d4f869"},{"sha":"7fc51c8ceafa776ba94bca1f815ef700b4032b27","author":{"name":"Eric Kreutzer","email":"a16fbdd223a71781803acbd9bd107ba1353fc2f0@lugg.com"},"message":"use ColorPropType everywhere there is a color prop on TextInput\n\nSummary:\nIf using colors that are not strings react native would warn you of the problem. I made some changes so color props use `ColorPropType` instead of `PropTypes.string`.\nCloses https://github.com/facebook/react-native/pull/8325\n\nDifferential Revision: D3475516\n\nPulled By: javache\n\nfbshipit-source-id: b7e40a0de5e665fc5f41a975650bbba0ec210814","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/7fc51c8ceafa776ba94bca1f815ef700b4032b27"},{"sha":"57d85f1c3e2abcac9d647acd52b150650df596cc","author":{"name":"Leon","email":"c9b010b67bcc67d816dfbd5db6f849a5a02747bc@users.noreply.github.com"},"message":"Fixing Syntax Error \"errorMessage\" is read-only\n\nSummary:\nChanged const to let, to dodge the following issue:\n\n> \"errorMessage\" is read-only\n>   203 |         const errorMessage = `Callback with id ${cbID}: ${module}.${method}() not found`;\n>   204 |         if (method) {\n> > 205 |           errorMessage = `The callback ${method}() exists in module ${module}, `\n>       |           ^\n>   206 |           + `but only one callback may be registered to a function in a native module.`;\n>   207 |         }\nCloses https://github.com/facebook/react-native/pull/8347\n\nDifferential Revision: D3475525\n\nPulled By: javache\n\nfbshipit-source-id: e03b3b3411606e6798dc42c785f847c2eda03b0c","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/57d85f1c3e2abcac9d647acd52b150650df596cc"},{"sha":"cc959273da78ddee33d85036c7d409dd51347896","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Fix multi-character TextInput\n\nReviewed By: hnery\n\nDifferential Revision: D3457105\n\nfbshipit-source-id: dcb364123ed82842d4fb2dee9108f2805249a8f9","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/cc959273da78ddee33d85036c7d409dd51347896"},{"sha":"a2c1170da558d22cb10694d3a7830799a2928a06","author":{"name":"Martin Konicek","email":"f9c5ef9b5325ce81d68a8d733940290a1a837e54@fb.com"},"message":"Mention double tapping R to reload in the app template\n\nSummary:\nThis is a pretty useful trick to know, let's promote it :)\n\nThe formatting is consistent with iOS: https://github.com/facebook/react-native/blob/master/local-cli/generator/templates/index.ios.js\n\n<img width=\"443\" alt=\"screen shot 2016-06-23 at 4 04 47 pm\" src=\"https://cloud.githubusercontent.com/assets/346214/16304185/fc94f6d6-395c-11e6-9f2c-0167217d1514.png\">\nCloses https://github.com/facebook/react-native/pull/8354\n\nDifferential Revision: D3475790\n\nPulled By: mkonicek\n\nfbshipit-source-id: 06a43cf73b31d91faac72280d680f8eb95f50145","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/a2c1170da558d22cb10694d3a7830799a2928a06"},{"sha":"1cc7ef072ebe8bdd434137f0d3c953620e630969","author":{"name":"Alon Burg","email":"0efe1717ded76ff00a021dd924cfddcece9f655c@gmail.com"},"message":"Fixes 8309: Automatically run `adb reverse tcp:8081 tcp:8081` when st…\n\nSummary:\nin `runAndroid.js` I renamed the `buildAndRun()` into `run()` and added a call to `runAdbReverse`\nCloses https://github.com/facebook/react-native/pull/8345\n\nDifferential Revision: D3475782\n\nPulled By: mkonicek\n\nfbshipit-source-id: 6f2c5a3e6d61cbeec914175686d2a7909d22a957","distinct":true,"url":"https://api.github.com/repos/erickreutz/react-native/commits/1cc7ef072ebe8bdd434137f0d3c953620e630969"}]}
{"actor":{"display_login":"erickreutz"}}