{"action":"created","comment":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/71707619","id":71707619,"diff_hunk":"@@ -463,59 +466,450 @@ cc_run_hook(struct oci_cfg_hook* hook, const gchar* state,\n \treturn result;\n }\n \n+\n+/*!\n+ * Obtain the network configuration by querying the network namespace.\n+ *\n+ * \\param[in,out] config \\ref cc_oci_config.\n+ *\n+ * \\return \\c true on success, else \\c false.\n+ */\n+static gboolean\n+cc_oci_vm_netcfg_get (struct cc_oci_config *config)\n+{\n+\tif ((! config)) {\n+\t\treturn false;\n+\t}\n+\n+\t/* TODO: We need to support multiple networks */\n+\tif ( !cc_oci_network_discover (\"eth0\", config)) {","path":"src/process.c","position":77,"original_position":77,"commit_id":"f942e18cda6a532c4375b70790cc5d1ed79b3e26","original_commit_id":"f942e18cda6a532c4375b70790cc5d1ed79b3e26","user":{"login":"sameo","id":1043863,"avatar_url":"https://avatars.githubusercontent.com/u/1043863?v=3","gravatar_id":"","url":"https://api.github.com/users/sameo","html_url":"https://github.com/sameo","followers_url":"https://api.github.com/users/sameo/followers","following_url":"https://api.github.com/users/sameo/following{/other_user}","gists_url":"https://api.github.com/users/sameo/gists{/gist_id}","starred_url":"https://api.github.com/users/sameo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameo/subscriptions","organizations_url":"https://api.github.com/users/sameo/orgs","repos_url":"https://api.github.com/users/sameo/repos","events_url":"https://api.github.com/users/sameo/events{/privacy}","received_events_url":"https://api.github.com/users/sameo/received_events","type":"User","site_admin":false},"body":"@mcastelino Maybe you could comment on how this works with a hardcoded `eth0` string ?","created_at":"2016-07-21T13:48:04Z","updated_at":"2016-07-21T13:48:04Z","html_url":"https://github.com/01org/cc-oci-runtime/pull/44#discussion_r71707619","pull_request_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/71707619"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/44#discussion_r71707619"},"pull_request":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44","id":78243292,"html_url":"https://github.com/01org/cc-oci-runtime/pull/44","diff_url":"https://github.com/01org/cc-oci-runtime/pull/44.diff","patch_url":"https://github.com/01org/cc-oci-runtime/pull/44.patch","issue_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/44","number":44,"state":"open","locked":false,"title":"WIP: Adding Base Networking Support for CC","user":{"login":"mcastelino","id":7387737,"avatar_url":"https://avatars.githubusercontent.com/u/7387737?v=3","gravatar_id":"","url":"https://api.github.com/users/mcastelino","html_url":"https://github.com/mcastelino","followers_url":"https://api.github.com/users/mcastelino/followers","following_url":"https://api.github.com/users/mcastelino/following{/other_user}","gists_url":"https://api.github.com/users/mcastelino/gists{/gist_id}","starred_url":"https://api.github.com/users/mcastelino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcastelino/subscriptions","organizations_url":"https://api.github.com/users/mcastelino/orgs","repos_url":"https://api.github.com/users/mcastelino/repos","events_url":"https://api.github.com/users/mcastelino/events{/privacy}","received_events_url":"https://api.github.com/users/mcastelino/received_events","type":"User","site_admin":false},"body":"    Networking: Basic Networking Support\r\n\r\n    Support for a single network docker container\r\n    docker net=none and docker net=bridge\r\n\r\n    This commit includes support for\r\n\r\n    - Discovering the docker CNM created network interface\r\n        - its IPv4, IPv6 and MAC address\r\n    - Sending IP Configuration Parameters into the guest kernel\r\n    - Sending in the hostname to the guest kernel\r\n    - Creation of a single tap interface that can be used to\r\n      connect the VM to a single container network\r\n    - Configuration of the MAC address via QEMU\r\n    - Quick and dirty implementation that creates and integration\r\n      bridge and connects it to the container interface (veth)\r\n      and the tap interface (tap)\r\n    - Reprogramming of the veth MAC to one that does not conflict\r\n      with the MAC that is now assigned to the tap within the VM\r\n\r\n    Limitations:\r\n    IPv4+IPv6 containers are not supported due the kernel command\r\n    line limitations.\r\n\r\n    This implementation uses shell invocation vs netlink commands.\r\n    A future refined implementation will use netlink based interface\r\n    to configure networking.\r\n","created_at":"2016-07-21T00:58:17Z","updated_at":"2016-07-21T13:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4edb92cdc6413df32e77f90f275a365a2745041","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44/commits","review_comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44/comments","review_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/44/comments","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/f942e18cda6a532c4375b70790cc5d1ed79b3e26","head":{"label":"01org:networking","ref":"networking","sha":"f942e18cda6a532c4375b70790cc5d1ed79b3e26","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":62701840,"name":"cc-oci-runtime","full_name":"01org/cc-oci-runtime","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime","fork":false,"url":"https://api.github.com/repos/01org/cc-oci-runtime","forks_url":"https://api.github.com/repos/01org/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/01org/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/01org/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/01org/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/01org/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/01org/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/01org/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/01org/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/01org/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/01org/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/01org/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/01org/cc-oci-runtime/deployments","created_at":"2016-07-06T07:48:26Z","updated_at":"2016-07-20T19:55:31Z","pushed_at":"2016-07-21T00:58:17Z","git_url":"git://github.com/01org/cc-oci-runtime.git","ssh_url":"git@github.com:01org/cc-oci-runtime.git","clone_url":"https://github.com/01org/cc-oci-runtime.git","svn_url":"https://github.com/01org/cc-oci-runtime","homepage":"","size":718,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":3,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"d19fafabfe9ea756fb639d3b62f73e5e23236561","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":62701840,"name":"cc-oci-runtime","full_name":"01org/cc-oci-runtime","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime","fork":false,"url":"https://api.github.com/repos/01org/cc-oci-runtime","forks_url":"https://api.github.com/repos/01org/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/01org/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/01org/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/01org/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/01org/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/01org/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/01org/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/01org/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/01org/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/01org/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/01org/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/01org/cc-oci-runtime/deployments","created_at":"2016-07-06T07:48:26Z","updated_at":"2016-07-20T19:55:31Z","pushed_at":"2016-07-21T00:58:17Z","git_url":"git://github.com/01org/cc-oci-runtime.git","ssh_url":"git@github.com:01org/cc-oci-runtime.git","clone_url":"https://github.com/01org/cc-oci-runtime.git","svn_url":"https://github.com/01org/cc-oci-runtime","homepage":"","size":718,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":21,"forks":4,"open_issues":21,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/44"},"issue":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/44"},"comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/f942e18cda6a532c4375b70790cc5d1ed79b3e26"}}}}
{"actor":{"display_login":"sameo"}}