{"action":"created","comment":{"url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/comments/77985439","id":77985439,"diff_hunk":"@@ -128,12 +128,34 @@ public class PlayerConfig\n         public string Summoner2 { get { return (string)_playerData.SelectToken(\"summoner2\"); } }\n         public short Ribbon { get { return (short)_playerData.SelectToken(\"ribbon\"); } }\n         public int Icon { get { return (int)_playerData.SelectToken(\"icon\"); } }\n+        public Dictionary<string, List<int>> Runes { get { return _runeList; } }\n \n         private JToken _playerData;\n+        private Dictionary<string, List<int>> _runeList;\n \n         public PlayerConfig(JToken playerData)\n         {\n-            _playerData = playerData;\n+            _playerData = playerData;\r\n+            try\r\n+            {\r\n+                var runes = _playerData.SelectToken(\"runes\");\r\n+                _runeList = new Dictionary<string, List<int>>();\r\n+\r\n+                foreach (JProperty runeCategory in runes)\r","path":"GameServer/Logic/Config.cs","position":18,"original_position":18,"commit_id":"3740184bf705f3d9a7459053f500b135a836fc3d","original_commit_id":"3740184bf705f3d9a7459053f500b135a836fc3d","user":{"login":"MythicManiac","id":8225825,"avatar_url":"https://avatars.githubusercontent.com/u/8225825?v=3","gravatar_id":"","url":"https://api.github.com/users/MythicManiac","html_url":"https://github.com/MythicManiac","followers_url":"https://api.github.com/users/MythicManiac/followers","following_url":"https://api.github.com/users/MythicManiac/following{/other_user}","gists_url":"https://api.github.com/users/MythicManiac/gists{/gist_id}","starred_url":"https://api.github.com/users/MythicManiac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MythicManiac/subscriptions","organizations_url":"https://api.github.com/users/MythicManiac/orgs","repos_url":"https://api.github.com/users/MythicManiac/repos","events_url":"https://api.github.com/users/MythicManiac/events{/privacy}","received_events_url":"https://api.github.com/users/MythicManiac/received_events","type":"User","site_admin":false},"body":"Also if you do create the `RuneCollection` class, you should move the loading code probably there. You can actually do the whole loading with a single JSON.net function if your data structure and object structure match.","created_at":"2016-09-08T11:00:02Z","updated_at":"2016-09-08T11:00:02Z","html_url":"https://github.com/LeagueSandbox/GameServer/pull/201#discussion_r77985439","pull_request_url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/comments/77985439"},"html":{"href":"https://github.com/LeagueSandbox/GameServer/pull/201#discussion_r77985439"},"pull_request":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201","id":84364084,"html_url":"https://github.com/LeagueSandbox/GameServer/pull/201","diff_url":"https://github.com/LeagueSandbox/GameServer/pull/201.diff","patch_url":"https://github.com/LeagueSandbox/GameServer/pull/201.patch","issue_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/201","number":201,"state":"open","locked":false,"title":"Runes are working and apply their effect","user":{"login":"Maufeat","id":3602392,"avatar_url":"https://avatars.githubusercontent.com/u/3602392?v=3","gravatar_id":"","url":"https://api.github.com/users/Maufeat","html_url":"https://github.com/Maufeat","followers_url":"https://api.github.com/users/Maufeat/followers","following_url":"https://api.github.com/users/Maufeat/following{/other_user}","gists_url":"https://api.github.com/users/Maufeat/gists{/gist_id}","starred_url":"https://api.github.com/users/Maufeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maufeat/subscriptions","organizations_url":"https://api.github.com/users/Maufeat/orgs","repos_url":"https://api.github.com/users/Maufeat/repos","events_url":"https://api.github.com/users/Maufeat/events{/privacy}","received_events_url":"https://api.github.com/users/Maufeat/received_events","type":"User","site_admin":false},"body":"in the `GameInfo.json.template` you can set your runes. Look at http://ddragon.volibot.com/ the \"Runes\"-Tab for the IDs.","created_at":"2016-09-07T20:04:58Z","updated_at":"2016-09-08T11:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d835a753259cd6fb4a77c9cad939325ce32a06fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201/commits","review_comments_url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201/comments","review_comment_url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/201/comments","statuses_url":"https://api.github.com/repos/LeagueSandbox/GameServer/statuses/3740184bf705f3d9a7459053f500b135a836fc3d","head":{"label":"LeagueSandbox:runesAndMasteries","ref":"runesAndMasteries","sha":"3740184bf705f3d9a7459053f500b135a836fc3d","user":{"login":"LeagueSandbox","id":18346087,"avatar_url":"https://avatars.githubusercontent.com/u/18346087?v=3","gravatar_id":"","url":"https://api.github.com/users/LeagueSandbox","html_url":"https://github.com/LeagueSandbox","followers_url":"https://api.github.com/users/LeagueSandbox/followers","following_url":"https://api.github.com/users/LeagueSandbox/following{/other_user}","gists_url":"https://api.github.com/users/LeagueSandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/LeagueSandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeagueSandbox/subscriptions","organizations_url":"https://api.github.com/users/LeagueSandbox/orgs","repos_url":"https://api.github.com/users/LeagueSandbox/repos","events_url":"https://api.github.com/users/LeagueSandbox/events{/privacy}","received_events_url":"https://api.github.com/users/LeagueSandbox/received_events","type":"Organization","site_admin":false},"repo":{"id":54715255,"name":"GameServer","full_name":"LeagueSandbox/GameServer","owner":{"login":"LeagueSandbox","id":18346087,"avatar_url":"https://avatars.githubusercontent.com/u/18346087?v=3","gravatar_id":"","url":"https://api.github.com/users/LeagueSandbox","html_url":"https://github.com/LeagueSandbox","followers_url":"https://api.github.com/users/LeagueSandbox/followers","following_url":"https://api.github.com/users/LeagueSandbox/following{/other_user}","gists_url":"https://api.github.com/users/LeagueSandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/LeagueSandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeagueSandbox/subscriptions","organizations_url":"https://api.github.com/users/LeagueSandbox/orgs","repos_url":"https://api.github.com/users/LeagueSandbox/repos","events_url":"https://api.github.com/users/LeagueSandbox/events{/privacy}","received_events_url":"https://api.github.com/users/LeagueSandbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LeagueSandbox/GameServer","description":"League Sandbox's Game Server","fork":false,"url":"https://api.github.com/repos/LeagueSandbox/GameServer","forks_url":"https://api.github.com/repos/LeagueSandbox/GameServer/forks","keys_url":"https://api.github.com/repos/LeagueSandbox/GameServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeagueSandbox/GameServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeagueSandbox/GameServer/teams","hooks_url":"https://api.github.com/repos/LeagueSandbox/GameServer/hooks","issue_events_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/events{/number}","events_url":"https://api.github.com/repos/LeagueSandbox/GameServer/events","assignees_url":"https://api.github.com/repos/LeagueSandbox/GameServer/assignees{/user}","branches_url":"https://api.github.com/repos/LeagueSandbox/GameServer/branches{/branch}","tags_url":"https://api.github.com/repos/LeagueSandbox/GameServer/tags","blobs_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeagueSandbox/GameServer/statuses/{sha}","languages_url":"https://api.github.com/repos/LeagueSandbox/GameServer/languages","stargazers_url":"https://api.github.com/repos/LeagueSandbox/GameServer/stargazers","contributors_url":"https://api.github.com/repos/LeagueSandbox/GameServer/contributors","subscribers_url":"https://api.github.com/repos/LeagueSandbox/GameServer/subscribers","subscription_url":"https://api.github.com/repos/LeagueSandbox/GameServer/subscription","commits_url":"https://api.github.com/repos/LeagueSandbox/GameServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeagueSandbox/GameServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeagueSandbox/GameServer/contents/{+path}","compare_url":"https://api.github.com/repos/LeagueSandbox/GameServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeagueSandbox/GameServer/merges","archive_url":"https://api.github.com/repos/LeagueSandbox/GameServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeagueSandbox/GameServer/downloads","issues_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues{/number}","pulls_url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls{/number}","milestones_url":"https://api.github.com/repos/LeagueSandbox/GameServer/milestones{/number}","notifications_url":"https://api.github.com/repos/LeagueSandbox/GameServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeagueSandbox/GameServer/labels{/name}","releases_url":"https://api.github.com/repos/LeagueSandbox/GameServer/releases{/id}","deployments_url":"https://api.github.com/repos/LeagueSandbox/GameServer/deployments","created_at":"2016-03-25T11:39:45Z","updated_at":"2016-09-04T02:29:10Z","pushed_at":"2016-09-08T09:50:23Z","git_url":"git://github.com/LeagueSandbox/GameServer.git","ssh_url":"git@github.com:LeagueSandbox/GameServer.git","clone_url":"https://github.com/LeagueSandbox/GameServer.git","svn_url":"https://github.com/LeagueSandbox/GameServer","homepage":"","size":15616,"stargazers_count":35,"watchers_count":35,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":29,"forks":28,"open_issues":29,"watchers":35,"default_branch":"master"}},"base":{"label":"LeagueSandbox:master","ref":"master","sha":"3d593930f2cbed7c7a7bb5d67a9d278fc447fb94","user":{"login":"LeagueSandbox","id":18346087,"avatar_url":"https://avatars.githubusercontent.com/u/18346087?v=3","gravatar_id":"","url":"https://api.github.com/users/LeagueSandbox","html_url":"https://github.com/LeagueSandbox","followers_url":"https://api.github.com/users/LeagueSandbox/followers","following_url":"https://api.github.com/users/LeagueSandbox/following{/other_user}","gists_url":"https://api.github.com/users/LeagueSandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/LeagueSandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeagueSandbox/subscriptions","organizations_url":"https://api.github.com/users/LeagueSandbox/orgs","repos_url":"https://api.github.com/users/LeagueSandbox/repos","events_url":"https://api.github.com/users/LeagueSandbox/events{/privacy}","received_events_url":"https://api.github.com/users/LeagueSandbox/received_events","type":"Organization","site_admin":false},"repo":{"id":54715255,"name":"GameServer","full_name":"LeagueSandbox/GameServer","owner":{"login":"LeagueSandbox","id":18346087,"avatar_url":"https://avatars.githubusercontent.com/u/18346087?v=3","gravatar_id":"","url":"https://api.github.com/users/LeagueSandbox","html_url":"https://github.com/LeagueSandbox","followers_url":"https://api.github.com/users/LeagueSandbox/followers","following_url":"https://api.github.com/users/LeagueSandbox/following{/other_user}","gists_url":"https://api.github.com/users/LeagueSandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/LeagueSandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeagueSandbox/subscriptions","organizations_url":"https://api.github.com/users/LeagueSandbox/orgs","repos_url":"https://api.github.com/users/LeagueSandbox/repos","events_url":"https://api.github.com/users/LeagueSandbox/events{/privacy}","received_events_url":"https://api.github.com/users/LeagueSandbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LeagueSandbox/GameServer","description":"League Sandbox's Game Server","fork":false,"url":"https://api.github.com/repos/LeagueSandbox/GameServer","forks_url":"https://api.github.com/repos/LeagueSandbox/GameServer/forks","keys_url":"https://api.github.com/repos/LeagueSandbox/GameServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeagueSandbox/GameServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeagueSandbox/GameServer/teams","hooks_url":"https://api.github.com/repos/LeagueSandbox/GameServer/hooks","issue_events_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/events{/number}","events_url":"https://api.github.com/repos/LeagueSandbox/GameServer/events","assignees_url":"https://api.github.com/repos/LeagueSandbox/GameServer/assignees{/user}","branches_url":"https://api.github.com/repos/LeagueSandbox/GameServer/branches{/branch}","tags_url":"https://api.github.com/repos/LeagueSandbox/GameServer/tags","blobs_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeagueSandbox/GameServer/statuses/{sha}","languages_url":"https://api.github.com/repos/LeagueSandbox/GameServer/languages","stargazers_url":"https://api.github.com/repos/LeagueSandbox/GameServer/stargazers","contributors_url":"https://api.github.com/repos/LeagueSandbox/GameServer/contributors","subscribers_url":"https://api.github.com/repos/LeagueSandbox/GameServer/subscribers","subscription_url":"https://api.github.com/repos/LeagueSandbox/GameServer/subscription","commits_url":"https://api.github.com/repos/LeagueSandbox/GameServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeagueSandbox/GameServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeagueSandbox/GameServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeagueSandbox/GameServer/contents/{+path}","compare_url":"https://api.github.com/repos/LeagueSandbox/GameServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeagueSandbox/GameServer/merges","archive_url":"https://api.github.com/repos/LeagueSandbox/GameServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeagueSandbox/GameServer/downloads","issues_url":"https://api.github.com/repos/LeagueSandbox/GameServer/issues{/number}","pulls_url":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls{/number}","milestones_url":"https://api.github.com/repos/LeagueSandbox/GameServer/milestones{/number}","notifications_url":"https://api.github.com/repos/LeagueSandbox/GameServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeagueSandbox/GameServer/labels{/name}","releases_url":"https://api.github.com/repos/LeagueSandbox/GameServer/releases{/id}","deployments_url":"https://api.github.com/repos/LeagueSandbox/GameServer/deployments","created_at":"2016-03-25T11:39:45Z","updated_at":"2016-09-04T02:29:10Z","pushed_at":"2016-09-08T09:50:23Z","git_url":"git://github.com/LeagueSandbox/GameServer.git","ssh_url":"git@github.com:LeagueSandbox/GameServer.git","clone_url":"https://github.com/LeagueSandbox/GameServer.git","svn_url":"https://github.com/LeagueSandbox/GameServer","homepage":"","size":15616,"stargazers_count":35,"watchers_count":35,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":29,"forks":28,"open_issues":29,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201"},"html":{"href":"https://github.com/LeagueSandbox/GameServer/pull/201"},"issue":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/201"},"comments":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/LeagueSandbox/GameServer/statuses/3740184bf705f3d9a7459053f500b135a836fc3d"}}}}
{"actor":{"display_login":"MythicManiac"}}