{"action":"created","issue":{"url":"https://api.github.com/repos/mono/gtk-sharp/issues/148","repository_url":"https://api.github.com/repos/mono/gtk-sharp","labels_url":"https://api.github.com/repos/mono/gtk-sharp/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/mono/gtk-sharp/issues/148/comments","events_url":"https://api.github.com/repos/mono/gtk-sharp/issues/148/events","html_url":"https://github.com/mono/gtk-sharp/pull/148","id":166604705,"number":148,"title":"[Generator] Don't try to reconstruct the value on a struct parameter …","user":{"login":"Therzok","id":109974,"avatar_url":"https://avatars.githubusercontent.com/u/109974?v=3","gravatar_id":"","url":"https://api.github.com/users/Therzok","html_url":"https://github.com/Therzok","followers_url":"https://api.github.com/users/Therzok/followers","following_url":"https://api.github.com/users/Therzok/following{/other_user}","gists_url":"https://api.github.com/users/Therzok/gists{/gist_id}","starred_url":"https://api.github.com/users/Therzok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Therzok/subscriptions","organizations_url":"https://api.github.com/users/Therzok/orgs","repos_url":"https://api.github.com/users/Therzok/repos","events_url":"https://api.github.com/users/Therzok/events{/privacy}","received_events_url":"https://api.github.com/users/Therzok/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-20T15:05:45Z","updated_at":"2016-07-21T09:33:14Z","closed_at":"2016-07-21T09:30:50Z","pull_request":{"url":"https://api.github.com/repos/mono/gtk-sharp/pulls/148","html_url":"https://github.com/mono/gtk-sharp/pull/148","diff_url":"https://github.com/mono/gtk-sharp/pull/148.diff","patch_url":"https://github.com/mono/gtk-sharp/pull/148.patch"},"body":"…passed by value\r\n\r\nIn the case of TreeStore.GetValue, the generated code would try to assign\r\niter to the value that was marshalled back from native.\r\n\r\nThis behaviour is incorrect, as the struct was passed by value, and\r\ndiscarded, having no effect on the code-flow but useless overhead.\r\n```\r\npublic void GetValue(Gtk.TreeIter, int column, ref GLib.Value value) {\r\n\tIntPtr native_iter = GLib.Marshaller.StructureToPtrAlloc (iter);\r\n\tIntPtr native_value = GLib.Marshaller.StructureToPtrAlloc (value);\r\n\tgtk_tree_model_get_value(Handle, native_iter, column, native_value);\r\n\t// The line below is removed.\r\n\tnative_iter = TreeIter.New (native_iter);\r\n\tMarshal.FreeHGlobal (native_iter);\r\n\tvalue = (GLib.Value) Marshal.PtrToStructure (native_value, typeof (GLib.Value));\r\n\tMarshal.FreeHGlobal (native_value);\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/mono/gtk-sharp/issues/comments/234204247","html_url":"https://github.com/mono/gtk-sharp/pull/148#issuecomment-234204247","issue_url":"https://api.github.com/repos/mono/gtk-sharp/issues/148","id":234204247,"user":{"login":"knocte","id":331303,"avatar_url":"https://avatars.githubusercontent.com/u/331303?v=3","gravatar_id":"","url":"https://api.github.com/users/knocte","html_url":"https://github.com/knocte","followers_url":"https://api.github.com/users/knocte/followers","following_url":"https://api.github.com/users/knocte/following{/other_user}","gists_url":"https://api.github.com/users/knocte/gists{/gist_id}","starred_url":"https://api.github.com/users/knocte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knocte/subscriptions","organizations_url":"https://api.github.com/users/knocte/orgs","repos_url":"https://api.github.com/users/knocte/repos","events_url":"https://api.github.com/users/knocte/events{/privacy}","received_events_url":"https://api.github.com/users/knocte/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T09:33:14Z","updated_at":"2016-07-21T09:33:14Z","body":"Yeah definitely, can you guys port to master? :)\r\n"}}
{"actor":{"display_login":"knocte"}}