{"action":"reopened","issue":{"url":"https://api.github.com/repos/octokit/octokit.rb/issues/727","repository_url":"https://api.github.com/repos/octokit/octokit.rb","labels_url":"https://api.github.com/repos/octokit/octokit.rb/issues/727/labels{/name}","comments_url":"https://api.github.com/repos/octokit/octokit.rb/issues/727/comments","events_url":"https://api.github.com/repos/octokit/octokit.rb/issues/727/events","html_url":"https://github.com/octokit/octokit.rb/issues/727","id":139249350,"number":727,"title":"addressable v2.5.0 causing issue in octokit.rb v4.6.0","user":{"login":"pvdb","id":17322,"avatar_url":"https://avatars.githubusercontent.com/u/17322?v=3","gravatar_id":"","url":"https://api.github.com/users/pvdb","html_url":"https://github.com/pvdb","followers_url":"https://api.github.com/users/pvdb/followers","following_url":"https://api.github.com/users/pvdb/following{/other_user}","gists_url":"https://api.github.com/users/pvdb/gists{/gist_id}","starred_url":"https://api.github.com/users/pvdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvdb/subscriptions","organizations_url":"https://api.github.com/users/pvdb/orgs","repos_url":"https://api.github.com/users/pvdb/repos","events_url":"https://api.github.com/users/pvdb/events{/privacy}","received_events_url":"https://api.github.com/users/pvdb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-03-08T11:13:51Z","updated_at":"2016-11-09T14:48:33Z","closed_at":null,"body":"Hi peeps,\r\n\r\nAfter installing the latest release version of `octokit.rb` - i.e. `v4.3.0` - I noticed that the following query:\r\n\r\n``` ruby\r\nOctokit::Client.new.repository('octokit/octokit.rb').rels[:ssh].href\r\n```\r\n\r\n... which used to work in earlier releases, and returned:\r\n\r\n``` ruby\r\n\"git@github.com:octokit/octokit.rb.git\"\r\n```\r\n\r\n... now throws this exception instead:\r\n\r\n``` ruby\r\nAddressable::URI::InvalidURIError: Invalid scheme format: git@github.com\r\nfrom /usr/local/var/rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/addressable-2.4.0/lib/addressable/uri.rb:867:in `scheme='\r\n```\r\n\r\nThis is demonstrated in a bit more detail in the below `pry` sessions... I haven't had a chance yet to dig into the `sawyer` or `addressable` changes to determine whether this new behaviour is a bug or a feature, but I thought I'd raise it here already for awareness, as it is definitely a regression issue.\r\n\r\nThanks,\r\n\r\n@pvdb\r\n\r\n---\r\n\r\n**previous release: `octokit.rb v4.2.0` with `sawyer v0.6.0` and `addressable v2.3.8`**\r\n\r\n``` ruby\r\n[1] pry(main)> Octokit::VERSION\r\n=> \"4.2.0\"\r\n[2] pry(main)> Sawyer::VERSION\r\n=> \"0.6.0\"\r\n[3] pry(main)> Addressable::VERSION::STRING\r\n=> \"2.3.8\"\r\n[4] pry(main)> repo = Octokit::Client.new.repository('octokit/octokit.rb') ; nil\r\n=> nil\r\n[5] pry(main)> repo.rels[:git].href\r\n=> \"git://github.com/octokit/octokit.rb.git\"\r\n[6] pry(main)> repo.rels[:svn].href\r\n=> \"https://github.com/octokit/octokit.rb\"\r\n[7] pry(main)> repo.rels[:ssh].href\r\n=> \"git@github.com:octokit/octokit.rb.git\"\r\n[8] pry(main)> _\r\n```\r\n\r\n**current release: `octokit.rb v4.3.0` with `sawyer v0.7.0` and `addressable v2.4.0`**\r\n\r\n``` ruby\r\n[1] pry(main)> Octokit::VERSION\r\n=> \"4.3.0\"\r\n[2] pry(main)> Sawyer::VERSION\r\n=> \"0.7.0\"\r\n[3] pry(main)> Addressable::VERSION::STRING\r\n=> \"2.4.0\"\r\n[4] pry(main)> repo = Octokit::Client.new.repository('octokit/octokit.rb') ; nil\r\n=> nil\r\n[5] pry(main)> repo.rels[:git].href\r\n=> \"git://github.com/octokit/octokit.rb.git\"\r\n[6] pry(main)> repo.rels[:svn].href\r\n=> \"https://github.com/octokit/octokit.rb\"\r\n[7] pry(main)> repo.rels[:ssh].href\r\nAddressable::URI::InvalidURIError: Invalid scheme format: git@github.com\r\nfrom /usr/local/var/rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/addressable-2.4.0/lib/addressable/uri.rb:867:in `scheme='\r\n[8] pry(main)> _\r\n```\r\n"}}
{"actor":{"display_login":"pengwynn"}}