{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3904","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3904/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3904/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3904/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/3904","id":160755726,"number":3904,"title":"_DEFAULT_SOURCE flag added, and clang check version for IsTriviallyCopyable m…","user":{"login":"dhustkoder","id":11935784,"avatar_url":"https://avatars.githubusercontent.com/u/11935784?v=3","gravatar_id":"","url":"https://api.github.com/users/dhustkoder","html_url":"https://github.com/dhustkoder","followers_url":"https://api.github.com/users/dhustkoder/followers","following_url":"https://api.github.com/users/dhustkoder/following{/other_user}","gists_url":"https://api.github.com/users/dhustkoder/gists{/gist_id}","starred_url":"https://api.github.com/users/dhustkoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhustkoder/subscriptions","organizations_url":"https://api.github.com/users/dhustkoder/orgs","repos_url":"https://api.github.com/users/dhustkoder/repos","events_url":"https://api.github.com/users/dhustkoder/events{/privacy}","received_events_url":"https://api.github.com/users/dhustkoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-06-16T20:40:11Z","updated_at":"2016-06-17T16:46:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3904","html_url":"https://github.com/dolphin-emu/dolphin/pull/3904","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3904.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3904.patch"},"body":"…acro\r\n\r\nSo, I was getting some warnings when compiling dolphin on GNU/Linux with gcc 6.1 and clang 3.8\r\n\r\nFIRST ( when compiling with both gcc and clang ):\r\n'''\r\nIn file included from /usr/include/stdio.h:27:0,\r\n                 from /dolphin/Externals/miniupnpc/src/igd_desc_parse.c:10:\r\n/usr/include/features.h:148:3: warning: #warning \"_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE\" [-Wcpp]\r\n # warning \"_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE\"\r\n'''\r\nI solve this by adding a compiler flag _DEFAULT_SOURCE on the CMakeLists.txt \r\n\r\nSECOND (when compiling with clang):\r\nThe other warning is that the std::has_trivial_copy_constructor  was being used when I used clang 3.8 to compile, which has support to std::is_trivially_copyable. Adding a check for the clang's version solved that too.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/3904)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/226820594","html_url":"https://github.com/dolphin-emu/dolphin/pull/3904#issuecomment-226820594","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3904","id":226820594,"user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T16:46:18Z","updated_at":"2016-06-17T16:46:18Z","body":"@dolphin-emu-bot rebuild"}}
{"actor":{"display_login":"lioncash"}}