{"action":"created","comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/63100598","id":63100598,"diff_hunk":"@@ -70,13 +70,11 @@\n \n     <button\n       type=\"button\"\n-      class=\"btn btn-default\"\n+      class=\"pull-left btn btn-default\"\n       ng-click=\"CashTransferModalCtrl.cancel()\"\n       data-transfer-modal-cancel>\n       {{ \"FORM.BUTTONS.CANCEL\" | translate }}\n     </button>\n+    <div class=\"clearfix\"></div>","path":"client/src/partials/cash/modals/transfer.modal.html","position":35,"original_position":35,"commit_id":"83000c3d6a740b59e127a4ca7ace8e976119e715","original_commit_id":"83000c3d6a740b59e127a4ca7ace8e976119e715","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"body":"This \"clearfix\" class can go on the parent element. So, if you have this code:\r\n```html\r\n<div class=\"modal-footer\">\r\n  <button class=\"btn btn-default pull-right\"></button>\r\n</div>\r\n```\r\nAnd the button will not stay in the modal footer, this is a better way to fix it:\r\n```html\r\n<!-- put the clearfix on the parent -->\r\n<div class=\"modal-footer clearfix\">\r\n  <button class=\"btn btn-default pull-right\"></button>\r\n  <!-- <div class=\"clearfix\"></div> would also work, but is less clear, I think -->\r\n</div>\r\n```","created_at":"2016-05-12T21:27:56Z","updated_at":"2016-05-12T21:27:56Z","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/394#discussion_r63100598","pull_request_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/63100598"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/394#discussion_r63100598"},"pull_request":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394","id":69809329,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/394","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/394.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/394.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/394","number":394,"state":"open","locked":false,"title":"Use of modal select cashbox","user":{"login":"mbayopanda","id":5445251,"avatar_url":"https://avatars.githubusercontent.com/u/5445251?v=3","gravatar_id":"","url":"https://api.github.com/users/mbayopanda","html_url":"https://github.com/mbayopanda","followers_url":"https://api.github.com/users/mbayopanda/followers","following_url":"https://api.github.com/users/mbayopanda/following{/other_user}","gists_url":"https://api.github.com/users/mbayopanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbayopanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbayopanda/subscriptions","organizations_url":"https://api.github.com/users/mbayopanda/orgs","repos_url":"https://api.github.com/users/mbayopanda/repos","events_url":"https://api.github.com/users/mbayopanda/events{/privacy}","received_events_url":"https://api.github.com/users/mbayopanda/received_events","type":"User","site_admin":false},"body":"This PR : \r\n- Add a modal select cashbox \r\n- Move modal function into modal service \r\n- Fix receipt button for caution\r\n- Add e2e test for selecting cashbox in the modal window \r\n","created_at":"2016-05-12T09:59:45Z","updated_at":"2016-05-12T21:27:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cc7e6318e8954f25a03e1f79f15201543ce388d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/394/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/83000c3d6a740b59e127a4ca7ace8e976119e715","head":{"label":"mbayopanda:fix_cash_ui","ref":"fix_cash_ui","sha":"83000c3d6a740b59e127a4ca7ace8e976119e715","user":{"login":"mbayopanda","id":5445251,"avatar_url":"https://avatars.githubusercontent.com/u/5445251?v=3","gravatar_id":"","url":"https://api.github.com/users/mbayopanda","html_url":"https://github.com/mbayopanda","followers_url":"https://api.github.com/users/mbayopanda/followers","following_url":"https://api.github.com/users/mbayopanda/following{/other_user}","gists_url":"https://api.github.com/users/mbayopanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbayopanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbayopanda/subscriptions","organizations_url":"https://api.github.com/users/mbayopanda/orgs","repos_url":"https://api.github.com/users/mbayopanda/repos","events_url":"https://api.github.com/users/mbayopanda/events{/privacy}","received_events_url":"https://api.github.com/users/mbayopanda/received_events","type":"User","site_admin":false},"repo":{"id":49122869,"name":"bhima-2.X","full_name":"mbayopanda/bhima-2.X","owner":{"login":"mbayopanda","id":5445251,"avatar_url":"https://avatars.githubusercontent.com/u/5445251?v=3","gravatar_id":"","url":"https://api.github.com/users/mbayopanda","html_url":"https://github.com/mbayopanda","followers_url":"https://api.github.com/users/mbayopanda/followers","following_url":"https://api.github.com/users/mbayopanda/following{/other_user}","gists_url":"https://api.github.com/users/mbayopanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbayopanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbayopanda/subscriptions","organizations_url":"https://api.github.com/users/mbayopanda/orgs","repos_url":"https://api.github.com/users/mbayopanda/repos","events_url":"https://api.github.com/users/mbayopanda/events{/privacy}","received_events_url":"https://api.github.com/users/mbayopanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbayopanda/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":true,"url":"https://api.github.com/repos/mbayopanda/bhima-2.X","forks_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/forks","keys_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/events","assignees_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/merges","archive_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/deployments","created_at":"2016-01-06T08:26:46Z","updated_at":"2016-01-06T08:26:48Z","pushed_at":"2016-05-12T15:11:39Z","git_url":"git://github.com/mbayopanda/bhima-2.X.git","ssh_url":"git@github.com:mbayopanda/bhima-2.X.git","clone_url":"https://github.com/mbayopanda/bhima-2.X.git","svn_url":"https://github.com/mbayopanda/bhima-2.X","homepage":null,"size":3695,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:master","ref":"master","sha":"13d9c092c3a3dd55a9087fbb4dd7f02946914bd9","user":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":49052669,"name":"bhima-2.X","full_name":"IMA-WorldHealth/bhima-2.X","owner":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/deployments","created_at":"2016-01-05T08:30:30Z","updated_at":"2016-05-04T07:10:05Z","pushed_at":"2016-05-12T15:11:41Z","git_url":"git://github.com/IMA-WorldHealth/bhima-2.X.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima-2.X.git","clone_url":"https://github.com/IMA-WorldHealth/bhima-2.X.git","svn_url":"https://github.com/IMA-WorldHealth/bhima-2.X","homepage":null,"size":3880,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":91,"forks":6,"open_issues":91,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/394"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/394"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/83000c3d6a740b59e127a4ca7ace8e976119e715"}}}}