{"action":"created","comment":{"url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/comments/88226978","pull_request_review_id":8805474,"id":88226978,"diff_hunk":"@@ -0,0 +1,49 @@\n+{\n+    \"private\": false,\n+    \"nativescript\": {\n+        \"id\": \"org.nativescript.helloworldng\"\n+    },\n+    \"name\": \"tns-template-hello-world-ng\",\n+    \"main\": \"main.js\",\n+    \"version\": \"2.3.4\",\n+    \"author\": \"Telerik <support@telerik.com>\",\n+    \"description\": \"Nativescript Angular Hello World template\",\n+    \"license\": \"BSD\",\n+    \"keywords\": [\n+        \"telerik\",\n+        \"mobile\",\n+        \"angular\",\n+        \"nativescript\",\n+        \"{N}\",\n+        \"tns\",\n+        \"appbuilder\",\n+        \"template\"\n+    ],\n+    \"repository\": {\n+        \"type\": \"git\",\n+        \"url\": \"git://github.com/NativeScript/template-hello-world-ng\"\n+    },\n+    \"homepage\": \"https://github.com/NativeScript/template-hello-world-ng\",\n+    \"android\": {\n+        \"v8Flags\": \"--expose_gc\"\n+    },\n+    \"dependencies\": {","path":"examples/ExampleImgPickNG/app/package.json","position":30,"original_position":30,"commit_id":"b4e49c1fe816a8c0782515ac9e47dff312de8cfe","original_commit_id":"b4e49c1fe816a8c0782515ac9e47dff312de8cfe","user":{"login":"ignaciolarranaga","id":15932965,"avatar_url":"https://avatars.githubusercontent.com/u/15932965?v=3","gravatar_id":"","url":"https://api.github.com/users/ignaciolarranaga","html_url":"https://github.com/ignaciolarranaga","followers_url":"https://api.github.com/users/ignaciolarranaga/followers","following_url":"https://api.github.com/users/ignaciolarranaga/following{/other_user}","gists_url":"https://api.github.com/users/ignaciolarranaga/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciolarranaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciolarranaga/subscriptions","organizations_url":"https://api.github.com/users/ignaciolarranaga/orgs","repos_url":"https://api.github.com/users/ignaciolarranaga/repos","events_url":"https://api.github.com/users/ignaciolarranaga/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciolarranaga/received_events","type":"User","site_admin":false},"body":"@PanayotCankov Sorry, I didn't recall on this, it seems to be added to the template, because I just initialized the sample from tns create ... --ng","created_at":"2016-11-16T12:32:37Z","updated_at":"2016-11-16T12:32:37Z","html_url":"https://github.com/NativeScript/nativescript-imagepicker/pull/44#discussion_r88226978","pull_request_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/comments/88226978"},"html":{"href":"https://github.com/NativeScript/nativescript-imagepicker/pull/44#discussion_r88226978"},"pull_request":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44","id":93417422,"html_url":"https://github.com/NativeScript/nativescript-imagepicker/pull/44","diff_url":"https://github.com/NativeScript/nativescript-imagepicker/pull/44.diff","patch_url":"https://github.com/NativeScript/nativescript-imagepicker/pull/44.patch","issue_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/issues/44","number":44,"state":"closed","locked":false,"title":"Fixing for the plugin working in webpack for Angular projects (issue_43)","user":{"login":"ignaciolarranaga","id":15932965,"avatar_url":"https://avatars.githubusercontent.com/u/15932965?v=3","gravatar_id":"","url":"https://api.github.com/users/ignaciolarranaga","html_url":"https://github.com/ignaciolarranaga","followers_url":"https://api.github.com/users/ignaciolarranaga/followers","following_url":"https://api.github.com/users/ignaciolarranaga/following{/other_user}","gists_url":"https://api.github.com/users/ignaciolarranaga/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciolarranaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciolarranaga/subscriptions","organizations_url":"https://api.github.com/users/ignaciolarranaga/orgs","repos_url":"https://api.github.com/users/ignaciolarranaga/repos","events_url":"https://api.github.com/users/ignaciolarranaga/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciolarranaga/received_events","type":"User","site_admin":false},"body":"The plugin does not work with webpack / Angular, because it can not locate the JS/pages on navigation.\r\n\r\nI added a bundle-entry-points like in https://github.com/NativeScript/nativescript-dev-webpack/issues/6 but also had to move from the XML to JS navigation in order for it to work.\r\nI tried adding the xml's to the bundle of the client app, but it does not find them any way.\r\n\r\nI did leave them because I think it might be another solution in the future (or something I did not realize).\r\n\r\nI did also remove the helpers, because I have had problems on other plugins when running with webpack because of that.","created_at":"2016-11-12T00:03:57Z","updated_at":"2016-11-16T12:32:37Z","closed_at":"2016-11-16T10:49:20Z","merged_at":"2016-11-16T10:49:20Z","merge_commit_sha":"5a877f221ee2a87723b8194b4dbea90a43e85d7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44/commits","review_comments_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44/comments","review_comment_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/issues/44/comments","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/statuses/b4e49c1fe816a8c0782515ac9e47dff312de8cfe","head":{"label":"ignaciolarranaga:issue_43","ref":"issue_43","sha":"b4e49c1fe816a8c0782515ac9e47dff312de8cfe","user":{"login":"ignaciolarranaga","id":15932965,"avatar_url":"https://avatars.githubusercontent.com/u/15932965?v=3","gravatar_id":"","url":"https://api.github.com/users/ignaciolarranaga","html_url":"https://github.com/ignaciolarranaga","followers_url":"https://api.github.com/users/ignaciolarranaga/followers","following_url":"https://api.github.com/users/ignaciolarranaga/following{/other_user}","gists_url":"https://api.github.com/users/ignaciolarranaga/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciolarranaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciolarranaga/subscriptions","organizations_url":"https://api.github.com/users/ignaciolarranaga/orgs","repos_url":"https://api.github.com/users/ignaciolarranaga/repos","events_url":"https://api.github.com/users/ignaciolarranaga/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciolarranaga/received_events","type":"User","site_admin":false},"repo":{"id":73251357,"name":"nativescript-imagepicker","full_name":"ignaciolarranaga/nativescript-imagepicker","owner":{"login":"ignaciolarranaga","id":15932965,"avatar_url":"https://avatars.githubusercontent.com/u/15932965?v=3","gravatar_id":"","url":"https://api.github.com/users/ignaciolarranaga","html_url":"https://github.com/ignaciolarranaga","followers_url":"https://api.github.com/users/ignaciolarranaga/followers","following_url":"https://api.github.com/users/ignaciolarranaga/following{/other_user}","gists_url":"https://api.github.com/users/ignaciolarranaga/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciolarranaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciolarranaga/subscriptions","organizations_url":"https://api.github.com/users/ignaciolarranaga/orgs","repos_url":"https://api.github.com/users/ignaciolarranaga/repos","events_url":"https://api.github.com/users/ignaciolarranaga/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciolarranaga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ignaciolarranaga/nativescript-imagepicker","description":"Image picker plugin","fork":true,"url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker","forks_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/forks","keys_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/teams","hooks_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/hooks","issue_events_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/issues/events{/number}","events_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/events","assignees_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/assignees{/user}","branches_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/branches{/branch}","tags_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/tags","blobs_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/languages","stargazers_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/stargazers","contributors_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/contributors","subscribers_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/subscribers","subscription_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/subscription","commits_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/contents/{+path}","compare_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/merges","archive_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/downloads","issues_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/issues{/number}","pulls_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/labels{/name}","releases_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/releases{/id}","deployments_url":"https://api.github.com/repos/ignaciolarranaga/nativescript-imagepicker/deployments","created_at":"2016-11-09T04:03:42Z","updated_at":"2016-11-09T04:03:42Z","pushed_at":"2016-11-12T01:34:34Z","git_url":"git://github.com/ignaciolarranaga/nativescript-imagepicker.git","ssh_url":"git@github.com:ignaciolarranaga/nativescript-imagepicker.git","clone_url":"https://github.com/ignaciolarranaga/nativescript-imagepicker.git","svn_url":"https://github.com/ignaciolarranaga/nativescript-imagepicker","homepage":null,"size":5847,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"release"}},"base":{"label":"NativeScript:master","ref":"master","sha":"4bdffeed4231876284bd7f5657ac386a8c9bcdec","user":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars.githubusercontent.com/u/7392261?v=3","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":40597488,"name":"nativescript-imagepicker","full_name":"NativeScript/nativescript-imagepicker","owner":{"login":"NativeScript","id":7392261,"avatar_url":"https://avatars.githubusercontent.com/u/7392261?v=3","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NativeScript/nativescript-imagepicker","description":"Image picker plugin","fork":false,"url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker","forks_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/forks","keys_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/teams","hooks_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/events","assignees_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/tags","blobs_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/languages","stargazers_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/subscription","commits_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/merges","archive_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/downloads","issues_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/deployments","created_at":"2015-08-12T11:39:29Z","updated_at":"2016-10-19T15:47:39Z","pushed_at":"2016-11-16T10:49:20Z","git_url":"git://github.com/NativeScript/nativescript-imagepicker.git","ssh_url":"git@github.com:NativeScript/nativescript-imagepicker.git","clone_url":"https://github.com/NativeScript/nativescript-imagepicker.git","svn_url":"https://github.com/NativeScript/nativescript-imagepicker","homepage":null,"size":5850,"stargazers_count":13,"watchers_count":13,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":11,"forks":12,"open_issues":11,"watchers":13,"default_branch":"release"}},"_links":{"self":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44"},"html":{"href":"https://github.com/NativeScript/nativescript-imagepicker/pull/44"},"issue":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/issues/44"},"comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/NativeScript/nativescript-imagepicker/statuses/b4e49c1fe816a8c0782515ac9e47dff312de8cfe"}}}}
{"actor":{"display_login":"ignaciolarranaga"}}