{"push_id":972446937,"size":1,"distinct_size":1,"ref":"refs/heads/wmf/1.27.0-wmf.13","head":"a6c2cc1e56254066d140595965c04c7625a9e72f","before":"b55957e01a88e7afac9378f3c696a9c55a181e7c","commits":[{"sha":"a6c2cc1e56254066d140595965c04c7625a9e72f","author":{"email":"46f1a0bd5592a2f9244ca321b129902a06b53e03@samsmith.io","name":"Sam Smith"},"message":"Make SchemaEdit#log always return jQuery.Promise\n\nWhen Schema:Edit logging is enabled but the user isn't in the bucket,\nmobile edits will succeed but the editor overlay won't close. When the\nuser refreshes the page they'll see the \"Success! You're edit was\nsaved.\" toast.\n\nEditorOverlayBase#log is written assuming that SchemaEdit#log always\nreturns an instance of jQuery.Promise. If SchemaEdit is loaded - the\nWikimediaEvents extension is loaded - but the user isn't in the\nappropriate bucket, then null is returned.\n\nThis regression was introduced in 9b239fa.\n\nTo reproduce:\n* Install the WikimediaEvents extension\n* Add\n\n    $wgMFIgnoreEventLoggingBucketing = false;\n    $wgMFSchemaEditSampleRate = 0;\n\n  to LocalSettings.php\n* Edit a page with the mobile wikitext editor\n\nBug: T126497\nBug: T94156\nChange-Id: Ie5ef62cd06c2ee3f8b45728ebb89736cec5de44c","distinct":true,"url":"https://api.github.com/repos/wikimedia/mediawiki-extensions-MobileFrontend/commits/a6c2cc1e56254066d140595965c04c7625a9e72f"}]}