{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/comments/54345505","id":54345505,"diff_hunk":"@@ -154,45 +158,38 @@ def interleave=(should)\n   def flush\n     unless @property_hash.empty?\n       if @property_hash[:existing_resource] == :false\n-        debug ('Creating clone resource')\n-        updated = \"clone \"\n+        debug 'Creating clone resource'\n+        updated = 'clone '\n         updated << \"#{@property_hash[:name]} \"\n         updated << \"#{@property_hash[:primitive]} \"\n-        meta = \"\"\n+        meta = ''\n         meta << \"clone-max=#{@property_hash[:clone_max]} \" if @property_hash[:clone_max]\n         meta << \"clone-node-max=#{@property_hash[:clone_node_max]} \" if @property_hash[:clone_node_max]\n         meta << \"notify=#{@property_hash[:notify_clones]} \" if @property_hash[:notify_clones]\n         meta << \"globally-unique=#{@property_hash[:globally_unique]} \" if @property_hash[:globally_unique]\n         meta << \"ordered=#{@property_hash[:ordered]} \" if @property_hash[:ordered]\n         meta << \"interleave=#{@property_hash[:interleave]}\" if @property_hash[:interleave]\n-        updated << \"meta \" << meta if not meta.empty?\n-        Tempfile.open('puppet_crm_update') do |tmpfile|\n-          tmpfile.write(updated)\n-          tmpfile.flush\n-          ENV[\"CIB_shadow\"] = @resource[:cib]\n-          crm('configure', 'load', 'update', tmpfile.path.to_s)\n-        end\n+        updated << 'meta ' << meta unless meta.empty?\n       else\n-        debug ('Updating clone resource')\n-        updated = \"resource meta \"\n+        debug 'Updating clone resource'\n+        updated = 'resource meta '\n         updated << \"#{@property_hash[:name]} \"\n-        meta = \"set \"\n+        meta = 'set '\n         meta << \"clone-max=#{@property_hash[:clone_max]} \" if @property_hash[:clone_max]\n         meta << \"clone-node-max=#{@property_hash[:clone_node_max]} \" if @property_hash[:clone_node_max]\n         meta << \"notify=#{@property_hash[:notify_clones]} \" if @property_hash[:notify_clones]\n         meta << \"globally-unique=#{@property_hash[:globally_unique]} \" if @property_hash[:globally_unique]\n         meta << \"ordered=#{@property_hash[:ordered]} \" if @property_hash[:ordered]\n         meta << \"interleave=#{@property_hash[:interleave]}\" if @property_hash[:interleave]\n-        updated << meta if not meta.empty?\n-        debug(\"Loading update: #{updated}\")\n-        Tempfile.open('puppet_crm_update') do |tmpfile|\n-          tmpfile.write(updated)\n-          tmpfile.flush\n-          ENV[\"CIB_shadow\"] = @resource[:cib]\n-          crm('configure', 'load', 'update', tmpfile.path.to_s)\n-        end\n+        updated << meta unless meta.empty?\n+        debug \"Loading update: #{updated}\"\n+      end\n+      Tempfile.open('puppet_crm_update') do |tmpfile|","path":"lib/puppet/provider/cs_clone/crm.rb","position":108,"original_position":108,"commit_id":"4fe82c3d11f1e3083d8b0a676d9e197ba65fe1a8","original_commit_id":"4fe82c3d11f1e3083d8b0a676d9e197ba65fe1a8","user":{"login":"juniorsysadmin","id":6457128,"avatar_url":"https://avatars.githubusercontent.com/u/6457128?v=3","gravatar_id":"","url":"https://api.github.com/users/juniorsysadmin","html_url":"https://github.com/juniorsysadmin","followers_url":"https://api.github.com/users/juniorsysadmin/followers","following_url":"https://api.github.com/users/juniorsysadmin/following{/other_user}","gists_url":"https://api.github.com/users/juniorsysadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/juniorsysadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juniorsysadmin/subscriptions","organizations_url":"https://api.github.com/users/juniorsysadmin/orgs","repos_url":"https://api.github.com/users/juniorsysadmin/repos","events_url":"https://api.github.com/users/juniorsysadmin/events{/privacy}","received_events_url":"https://api.github.com/users/juniorsysadmin/received_events","type":"User","site_admin":false},"body":"This is a move of a code block outside the conditionals","created_at":"2016-02-28T07:47:47Z","updated_at":"2016-02-28T07:47:47Z","html_url":"https://github.com/voxpupuli/puppet-corosync/pull/195#discussion_r54345505","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/comments/54345505"},"html":{"href":"https://github.com/voxpupuli/puppet-corosync/pull/195#discussion_r54345505"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195","id":58123619,"html_url":"https://github.com/voxpupuli/puppet-corosync/pull/195","diff_url":"https://github.com/voxpupuli/puppet-corosync/pull/195.diff","patch_url":"https://github.com/voxpupuli/puppet-corosync/pull/195.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/issues/195","number":195,"state":"open","locked":false,"title":"Modulesync","user":{"login":"juniorsysadmin","id":6457128,"avatar_url":"https://avatars.githubusercontent.com/u/6457128?v=3","gravatar_id":"","url":"https://api.github.com/users/juniorsysadmin","html_url":"https://github.com/juniorsysadmin","followers_url":"https://api.github.com/users/juniorsysadmin/followers","following_url":"https://api.github.com/users/juniorsysadmin/following{/other_user}","gists_url":"https://api.github.com/users/juniorsysadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/juniorsysadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juniorsysadmin/subscriptions","organizations_url":"https://api.github.com/users/juniorsysadmin/orgs","repos_url":"https://api.github.com/users/juniorsysadmin/repos","events_url":"https://api.github.com/users/juniorsysadmin/events{/privacy}","received_events_url":"https://api.github.com/users/juniorsysadmin/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-03T11:23:18Z","updated_at":"2016-02-28T07:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"767c993f8173d818ed0fdb1f026364f529d0b30e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/issues/195/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/statuses/4fe82c3d11f1e3083d8b0a676d9e197ba65fe1a8","head":{"label":"juniorsysadmin:modulesync","ref":"modulesync","sha":"4fe82c3d11f1e3083d8b0a676d9e197ba65fe1a8","user":{"login":"juniorsysadmin","id":6457128,"avatar_url":"https://avatars.githubusercontent.com/u/6457128?v=3","gravatar_id":"","url":"https://api.github.com/users/juniorsysadmin","html_url":"https://github.com/juniorsysadmin","followers_url":"https://api.github.com/users/juniorsysadmin/followers","following_url":"https://api.github.com/users/juniorsysadmin/following{/other_user}","gists_url":"https://api.github.com/users/juniorsysadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/juniorsysadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juniorsysadmin/subscriptions","organizations_url":"https://api.github.com/users/juniorsysadmin/orgs","repos_url":"https://api.github.com/users/juniorsysadmin/repos","events_url":"https://api.github.com/users/juniorsysadmin/events{/privacy}","received_events_url":"https://api.github.com/users/juniorsysadmin/received_events","type":"User","site_admin":false},"repo":{"id":49325771,"name":"puppet-corosync","full_name":"juniorsysadmin/puppet-corosync","owner":{"login":"juniorsysadmin","id":6457128,"avatar_url":"https://avatars.githubusercontent.com/u/6457128?v=3","gravatar_id":"","url":"https://api.github.com/users/juniorsysadmin","html_url":"https://github.com/juniorsysadmin","followers_url":"https://api.github.com/users/juniorsysadmin/followers","following_url":"https://api.github.com/users/juniorsysadmin/following{/other_user}","gists_url":"https://api.github.com/users/juniorsysadmin/gists{/gist_id}","starred_url":"https://api.github.com/users/juniorsysadmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juniorsysadmin/subscriptions","organizations_url":"https://api.github.com/users/juniorsysadmin/orgs","repos_url":"https://api.github.com/users/juniorsysadmin/repos","events_url":"https://api.github.com/users/juniorsysadmin/events{/privacy}","received_events_url":"https://api.github.com/users/juniorsysadmin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juniorsysadmin/puppet-corosync","description":"Sets up and manages Corosync.","fork":true,"url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync","forks_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/forks","keys_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/teams","hooks_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/hooks","issue_events_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/issues/events{/number}","events_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/events","assignees_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/assignees{/user}","branches_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/branches{/branch}","tags_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/tags","blobs_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/git/refs{/sha}","trees_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/statuses/{sha}","languages_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/languages","stargazers_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/stargazers","contributors_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/contributors","subscribers_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/subscribers","subscription_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/subscription","commits_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/commits{/sha}","git_commits_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/git/commits{/sha}","comments_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/comments{/number}","issue_comment_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/issues/comments{/number}","contents_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/contents/{+path}","compare_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/merges","archive_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/downloads","issues_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/issues{/number}","pulls_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/pulls{/number}","milestones_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/milestones{/number}","notifications_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/labels{/name}","releases_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/releases{/id}","deployments_url":"https://api.github.com/repos/juniorsysadmin/puppet-corosync/deployments","created_at":"2016-01-09T13:44:37Z","updated_at":"2016-02-21T03:00:13Z","pushed_at":"2016-02-28T07:41:27Z","git_url":"git://github.com/juniorsysadmin/puppet-corosync.git","ssh_url":"git@github.com:juniorsysadmin/puppet-corosync.git","clone_url":"https://github.com/juniorsysadmin/puppet-corosync.git","svn_url":"https://github.com/juniorsysadmin/puppet-corosync","homepage":"http://forge.puppetlabs.com/puppet/corosync","size":438,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"1ca3028a6b9d6d76f1a5ca3b7fc4b1c5b899b377","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":3723449,"name":"puppet-corosync","full_name":"voxpupuli/puppet-corosync","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars.githubusercontent.com/u/8693967?v=3","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-corosync","description":"Sets up and manages Corosync.","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-corosync","forks_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-corosync/deployments","created_at":"2012-03-14T23:30:40Z","updated_at":"2016-02-17T11:53:17Z","pushed_at":"2016-02-28T07:41:27Z","git_url":"git://github.com/voxpupuli/puppet-corosync.git","ssh_url":"git@github.com:voxpupuli/puppet-corosync.git","clone_url":"https://github.com/voxpupuli/puppet-corosync.git","svn_url":"https://github.com/voxpupuli/puppet-corosync","homepage":"http://forge.puppetlabs.com/puppet/corosync","size":799,"stargazers_count":36,"watchers_count":36,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":29,"forks":116,"open_issues":29,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195"},"html":{"href":"https://github.com/voxpupuli/puppet-corosync/pull/195"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/issues/195"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-corosync/statuses/4fe82c3d11f1e3083d8b0a676d9e197ba65fe1a8"}}}}