{"action":"created","comment":{"url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments/94089122","pull_request_review_id":14619630,"id":94089122,"diff_hunk":"@@ -10,20 +10,30 @@ Flows supported: [code/implicit/hybrid flows](http://openid.net/specs/openid-con\n \n ## Configuration\n \n-Configuration can be set through Open Id menu in the admin dashboard and also through a recipe step.\n+Configuration can be set through OpenID Connect settings menu in the admin dashboard and also through a recipe step.\n \n Available settings are:\n + Testing Mode: Enabling Testing mode, removes the need of providing a certificate for signing tokens providing an ephemeral key. Also removes the requirement of using an HTTPS for issuing tokens.\n + Token Format: there are two options:\n   + JWT: This format uses signed JWT standard tokens (not encrypted). It requires the SSL certificate being used is accepted as a trusted certificate by the client.\n-  + Encrypted: This format uses non standard opaque tokens encrypted by the ASP.NET data protection block. \n+  + Encrypted: This format uses non standard opaque tokens encrypted by the ASP.NET data protection block. So, it doesn't require the client accept the SSL certificate as a trusted certificate.\n + Authority: Orchard url used by orchard to act as an identity server.\n + Audiences: Urls of the resource servers for which the identity server issues valid JWT tokens.\n + Certificate Store Location: CurrentUser/LocalMachine https://msdn.microsoft.com/en-us/library/system.security.cryptography.x509certificates.storelocation(v=vs.110).aspx\n + Certificate Store Name: AddressBook/AuthRootCertificateAuthority/Disallowed/My/Root/TrustedPeople/TrustedPublisher https://msdn.microsoft.com/en-us/library/system.security.cryptography.x509certificates.storename(v=vs.110).aspx\n + Certificate Thumbprint: The thumbprint of the certificate (It is recommended to not use same certificate it is been used for SSL).\n++ Enable Token Endpoint: Enables action /Orchard.OpenId/Access/Token.","path":"src/Orchard.Cms.Web/Modules/Orchard.OpenId/README.md","position":18,"original_position":18,"commit_id":"a020a002e1b95019322078d177885c4d986ad515","original_commit_id":"a020a002e1b95019322078d177885c4d986ad515","user":{"login":"sebastienros","id":1165805,"avatar_url":"https://avatars.githubusercontent.com/u/1165805?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienros","html_url":"https://github.com/sebastienros","followers_url":"https://api.github.com/users/sebastienros/followers","following_url":"https://api.github.com/users/sebastienros/following{/other_user}","gists_url":"https://api.github.com/users/sebastienros/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienros/subscriptions","organizations_url":"https://api.github.com/users/sebastienros/orgs","repos_url":"https://api.github.com/users/sebastienros/repos","events_url":"https://api.github.com/users/sebastienros/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienros/received_events","type":"User","site_admin":false},"body":"I don't think mentioning the actual urls is interesting in this context. I would only show them if they are actually necessary to know to configure external services, and in this case I would create a custom doc section. And if this url should be well-known, a more user friendly one would make more sense.","created_at":"2016-12-28T23:39:43Z","updated_at":"2016-12-28T23:40:30Z","html_url":"https://github.com/OrchardCMS/Orchard2/pull/484#discussion_r94089122","pull_request_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484","_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments/94089122"},"html":{"href":"https://github.com/OrchardCMS/Orchard2/pull/484#discussion_r94089122"},"pull_request":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484"}}},"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484","id":99599341,"html_url":"https://github.com/OrchardCMS/Orchard2/pull/484","diff_url":"https://github.com/OrchardCMS/Orchard2/pull/484.diff","patch_url":"https://github.com/OrchardCMS/Orchard2/pull/484.patch","issue_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/484","number":484,"state":"open","locked":false,"title":"Added Recipe Step for OpenId Apps and Readme.md updated","user":{"login":"jersiovic","id":4950766,"avatar_url":"https://avatars.githubusercontent.com/u/4950766?v=3","gravatar_id":"","url":"https://api.github.com/users/jersiovic","html_url":"https://github.com/jersiovic","followers_url":"https://api.github.com/users/jersiovic/followers","following_url":"https://api.github.com/users/jersiovic/following{/other_user}","gists_url":"https://api.github.com/users/jersiovic/gists{/gist_id}","starred_url":"https://api.github.com/users/jersiovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jersiovic/subscriptions","organizations_url":"https://api.github.com/users/jersiovic/orgs","repos_url":"https://api.github.com/users/jersiovic/repos","events_url":"https://api.github.com/users/jersiovic/events{/privacy}","received_events_url":"https://api.github.com/users/jersiovic/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-28T22:28:43Z","updated_at":"2016-12-28T23:40:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b65d9c0b142cec0539dc2ce572bfa535cef6d9d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484/commits","review_comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484/comments","review_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/484/comments","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/a020a002e1b95019322078d177885c4d986ad515","head":{"label":"OrchardCMS:RecipeStepForOpenIdApps","ref":"RecipeStepForOpenIdApps","sha":"a020a002e1b95019322078d177885c4d986ad515","user":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"name":"Orchard2","full_name":"OrchardCMS/Orchard2","owner":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrchardCMS/Orchard2","description":"Orchard vNext","fork":false,"url":"https://api.github.com/repos/OrchardCMS/Orchard2","forks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/forks","keys_url":"https://api.github.com/repos/OrchardCMS/Orchard2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/Orchard2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/Orchard2/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/events","assignees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/Orchard2/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/Orchard2/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/Orchard2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/Orchard2/merges","archive_url":"https://api.github.com/repos/OrchardCMS/Orchard2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/Orchard2/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/Orchard2/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/Orchard2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard2/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/Orchard2/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2016-12-28T05:21:27Z","pushed_at":"2016-12-28T23:35:29Z","git_url":"git://github.com/OrchardCMS/Orchard2.git","ssh_url":"git@github.com:OrchardCMS/Orchard2.git","clone_url":"https://github.com/OrchardCMS/Orchard2.git","svn_url":"https://github.com/OrchardCMS/Orchard2","homepage":null,"size":11110,"stargazers_count":623,"watchers_count":623,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"open_issues_count":119,"forks":234,"open_issues":119,"watchers":623,"default_branch":"master"}},"base":{"label":"OrchardCMS:oauth2","ref":"oauth2","sha":"1527f17e90915a111437af4255fb999484b7e244","user":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"name":"Orchard2","full_name":"OrchardCMS/Orchard2","owner":{"login":"OrchardCMS","id":1159247,"avatar_url":"https://avatars.githubusercontent.com/u/1159247?v=3","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OrchardCMS/Orchard2","description":"Orchard vNext","fork":false,"url":"https://api.github.com/repos/OrchardCMS/Orchard2","forks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/forks","keys_url":"https://api.github.com/repos/OrchardCMS/Orchard2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/Orchard2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/Orchard2/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/Orchard2/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/events","assignees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/Orchard2/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/Orchard2/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/Orchard2/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/Orchard2/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/Orchard2/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/Orchard2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/Orchard2/merges","archive_url":"https://api.github.com/repos/OrchardCMS/Orchard2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/Orchard2/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/Orchard2/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/Orchard2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard2/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/Orchard2/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2016-12-28T05:21:27Z","pushed_at":"2016-12-28T23:35:29Z","git_url":"git://github.com/OrchardCMS/Orchard2.git","ssh_url":"git@github.com:OrchardCMS/Orchard2.git","clone_url":"https://github.com/OrchardCMS/Orchard2.git","svn_url":"https://github.com/OrchardCMS/Orchard2","homepage":null,"size":11110,"stargazers_count":623,"watchers_count":623,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"open_issues_count":119,"forks":234,"open_issues":119,"watchers":623,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484"},"html":{"href":"https://github.com/OrchardCMS/Orchard2/pull/484"},"issue":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/484"},"comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/OrchardCMS/Orchard2/statuses/a020a002e1b95019322078d177885c4d986ad515"}}}}
{"actor":{"display_login":"sebastienros"}}