{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16271","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16271/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16271/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16271/events","html_url":"https://github.com/cms-sw/cmssw/pull/16271","id":184039499,"number":16271,"title":"Fixing code of tau embedding (TauAnalysis/MCEmbeddingTools) for run2 needs ","user":{"login":"swayand","id":6552830,"avatar_url":"https://avatars.githubusercontent.com/u/6552830?v=3","gravatar_id":"","url":"https://api.github.com/users/swayand","html_url":"https://github.com/swayand","followers_url":"https://api.github.com/users/swayand/followers","following_url":"https://api.github.com/users/swayand/following{/other_user}","gists_url":"https://api.github.com/users/swayand/gists{/gist_id}","starred_url":"https://api.github.com/users/swayand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swayand/subscriptions","organizations_url":"https://api.github.com/users/swayand/orgs","repos_url":"https://api.github.com/users/swayand/repos","events_url":"https://api.github.com/users/swayand/events{/privacy}","received_events_url":"https://api.github.com/users/swayand/received_events","type":"User","site_admin":false},"labels":[{"id":52881179,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881696,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/generators-pending","name":"generators-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":40,"closed_issues":1982,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-11-29T09:16:14Z","due_on":"2016-11-26T00:00:00Z","closed_at":null},"comments":48,"created_at":"2016-10-19T18:31:07Z","updated_at":"2016-11-29T13:56:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16271","html_url":"https://github.com/cms-sw/cmssw/pull/16271","diff_url":"https://github.com/cms-sw/cmssw/pull/16271.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16271.patch"},"body":"Most of the code has been rewritten to adapt Tau Embedding for run2 conditions. Details were presented here:\nhttps://indico.cern.ch/event/578066/contributions/2343771/attachments/1358062/2053774/stefan_wayand_Okt_19_reco_emb.pdf\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/263576176","html_url":"https://github.com/cms-sw/cmssw/pull/16271#issuecomment-263576176","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16271","id":263576176,"user":{"login":"swayand","id":6552830,"avatar_url":"https://avatars.githubusercontent.com/u/6552830?v=3","gravatar_id":"","url":"https://api.github.com/users/swayand","html_url":"https://github.com/swayand","followers_url":"https://api.github.com/users/swayand/followers","following_url":"https://api.github.com/users/swayand/following{/other_user}","gists_url":"https://api.github.com/users/swayand/gists{/gist_id}","starred_url":"https://api.github.com/users/swayand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swayand/subscriptions","organizations_url":"https://api.github.com/users/swayand/orgs","repos_url":"https://api.github.com/users/swayand/repos","events_url":"https://api.github.com/users/swayand/events{/privacy}","received_events_url":"https://api.github.com/users/swayand/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T13:56:47Z","updated_at":"2016-11-29T13:56:47Z","body":"At the moment we just run  HighLeve-RECO  and PAT (ake MINIAOD) over it, \ntherefore it is not in our hand to control all packages. So we decided \nto leave it in the code (like it was done before) and just produce the \nsame output like MuonIdProducer.cc do. Since PAT builds its own \nisolation maps and other stuff this extra information is rather \nunimportant at this stage, but if it needed in future then we also will \nmerge this collections.\n\n\n\n\nOn 11/28/2016 06:23 PM, Slava Krutelyov wrote:\n>\n> *@slava77* commented on this pull request.\n>\n> ------------------------------------------------------------------------\n>\n> In TauAnalysis/MCEmbeddingTools/plugins/TrackMergeremb.cc \n> <https://github.com/cms-sw/cmssw/pull/16271#pullrequestreview-10366266>:\n>\n> > +    edm::OrphanHandle<reco::MuonCollection> muonHandle = iEvent.put(std::move(outTracks));\n> +\n> +    auto fillMap = [](auto refH, auto& vec, edm::Event& ev, const std::string& cAl = \"\"){\n> +     typedef  edm::ValueMap<typename std::decay<decltype(vec)>::type::value_type> MapType;\n> +     std::unique_ptr<MapType > oMap(new MapType());\n> +     {\n> +       typename MapType::Filler filler(*oMap);\n> +       filler.insert(refH, vec.begin(), vec.end());\n> +       vec.clear();\n> +       filler.fill();\n> +     }\n> +     ev.put(std::move(oMap), cAl);\n> +    };\n> +\n> +   fillMap(muonHandle, combinedTimeColl, iEvent, \"combined\");\n> +   fillMap(muonHandle, dtTimeColl, iEvent, \"dt\");\n>\n> is it meaningful to create emtpy collections.\n> Wouldn't it be easier to instruct the code consuming these to do nothing?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/cms-sw/cmssw/pull/16271#pullrequestreview-10366266>, \n> or mute the thread \n> <https://github.com/notifications/unsubscribe-auth/AGP8_hQvKRNTdiydr9ZVXQcy_cCdMhyhks5rCw3_gaJpZM4KbTkf>.\n>\n\n"}}
{"actor":{"display_login":"swayand"}}