{"action":"created","issue":{"url":"https://api.github.com/repos/brkt/brkt-cli/issues/148","repository_url":"https://api.github.com/repos/brkt/brkt-cli","labels_url":"https://api.github.com/repos/brkt/brkt-cli/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/brkt/brkt-cli/issues/148/comments","events_url":"https://api.github.com/repos/brkt/brkt-cli/issues/148/events","html_url":"https://github.com/brkt/brkt-cli/pull/148","id":135606999,"number":148,"title":"Allow customers to configure use of their own NTP servers in metavisor.","user":{"login":"apoorva-jindal","id":16783793,"avatar_url":"https://avatars.githubusercontent.com/u/16783793?v=3","gravatar_id":"","url":"https://api.github.com/users/apoorva-jindal","html_url":"https://github.com/apoorva-jindal","followers_url":"https://api.github.com/users/apoorva-jindal/followers","following_url":"https://api.github.com/users/apoorva-jindal/following{/other_user}","gists_url":"https://api.github.com/users/apoorva-jindal/gists{/gist_id}","starred_url":"https://api.github.com/users/apoorva-jindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoorva-jindal/subscriptions","organizations_url":"https://api.github.com/users/apoorva-jindal/orgs","repos_url":"https://api.github.com/users/apoorva-jindal/repos","events_url":"https://api.github.com/users/apoorva-jindal/events{/privacy}","received_events_url":"https://api.github.com/users/apoorva-jindal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-23T02:11:35Z","updated_at":"2016-02-23T17:15:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brkt/brkt-cli/pulls/148","html_url":"https://github.com/brkt/brkt-cli/pull/148","diff_url":"https://github.com/brkt/brkt-cli/pull/148.diff","patch_url":"https://github.com/brkt/brkt-cli/pull/148.patch"},"body":"Adding ntp-server, a brkt-cli option to allow customers to override\r\nthe default NTP server in ntp configuration of metavisor.\r\nThis option is supported for both encryption and update process.\r\nntp-server is provided as user-data to the encryptor/updater instance.\r\nError out if ntp-server is not a valid host name or ipv4 address.\r\nFinally, handle errors reported by the Bracket Updater instance."},"comment":{"url":"https://api.github.com/repos/brkt/brkt-cli/issues/comments/187796614","html_url":"https://github.com/brkt/brkt-cli/pull/148#issuecomment-187796614","issue_url":"https://api.github.com/repos/brkt/brkt-cli/issues/148","id":187796614,"user":{"login":"jimvoll","id":16157340,"avatar_url":"https://avatars.githubusercontent.com/u/16157340?v=3","gravatar_id":"","url":"https://api.github.com/users/jimvoll","html_url":"https://github.com/jimvoll","followers_url":"https://api.github.com/users/jimvoll/followers","following_url":"https://api.github.com/users/jimvoll/following{/other_user}","gists_url":"https://api.github.com/users/jimvoll/gists{/gist_id}","starred_url":"https://api.github.com/users/jimvoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimvoll/subscriptions","organizations_url":"https://api.github.com/users/jimvoll/orgs","repos_url":"https://api.github.com/users/jimvoll/repos","events_url":"https://api.github.com/users/jimvoll/events{/privacy}","received_events_url":"https://api.github.com/users/jimvoll/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T17:15:01Z","updated_at":"2016-02-23T17:15:01Z","body":"I disagree with Boris on this one. I think we can, and should do some error checking here\r\nor the end result will be a failed launch on the resulting instance with little to go on.\r\n\r\nFor instance, I asked Approva to make sure the argument being passed wasn't IPv6\r\nfor instance. We should try to catch obvious typo's.\r\n\r\nUsing ntplib might not be a good answer here either. You might not be able to contact\r\nthe NTP servers specified as part of the encryption process for instance."}}