{"action":"created","comment":{"url":"https://api.github.com/repos/spockframework/spock/pulls/comments/75043369","id":75043369,"diff_hunk":"@@ -112,7 +112,10 @@ subprojects {\n   }\n \n   ext.\"signing.keyId\" = \"2EA0A67F\"\n-  ext.\"signing.password\" = System.getenv(\"SIGNING_PASSWORD\")\n+  if (System.getenv(\"SIGNING_PASSWORD\")) {\n+    // if the password property is set, even if its null null, the SigningExtension will try to load the key","path":"build.gradle","position":6,"original_position":6,"commit_id":"82b03ce01135a5e8cb60b8c31de3e1d6e2b0b21a","original_commit_id":"82b03ce01135a5e8cb60b8c31de3e1d6e2b0b21a","user":{"login":"leonard84","id":1151511,"avatar_url":"https://avatars.githubusercontent.com/u/1151511?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard84","html_url":"https://github.com/leonard84","followers_url":"https://api.github.com/users/leonard84/followers","following_url":"https://api.github.com/users/leonard84/following{/other_user}","gists_url":"https://api.github.com/users/leonard84/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard84/subscriptions","organizations_url":"https://api.github.com/users/leonard84/orgs","repos_url":"https://api.github.com/users/leonard84/repos","events_url":"https://api.github.com/users/leonard84/events{/privacy}","received_events_url":"https://api.github.com/users/leonard84/received_events","type":"User","site_admin":false},"body":"yeah typo","created_at":"2016-08-17T00:05:26Z","updated_at":"2016-08-17T00:05:26Z","html_url":"https://github.com/spockframework/spock/pull/634#discussion_r75043369","pull_request_url":"https://api.github.com/repos/spockframework/spock/pulls/634","_links":{"self":{"href":"https://api.github.com/repos/spockframework/spock/pulls/comments/75043369"},"html":{"href":"https://github.com/spockframework/spock/pull/634#discussion_r75043369"},"pull_request":{"href":"https://api.github.com/repos/spockframework/spock/pulls/634"}}},"pull_request":{"url":"https://api.github.com/repos/spockframework/spock/pulls/634","id":81547096,"html_url":"https://github.com/spockframework/spock/pull/634","diff_url":"https://github.com/spockframework/spock/pull/634.diff","patch_url":"https://github.com/spockframework/spock/pull/634.patch","issue_url":"https://api.github.com/repos/spockframework/spock/issues/634","number":634,"state":"open","locked":false,"title":"Fix NPE for install task if SIGNING_PASSWORD is null","user":{"login":"leonard84","id":1151511,"avatar_url":"https://avatars.githubusercontent.com/u/1151511?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard84","html_url":"https://github.com/leonard84","followers_url":"https://api.github.com/users/leonard84/followers","following_url":"https://api.github.com/users/leonard84/following{/other_user}","gists_url":"https://api.github.com/users/leonard84/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard84/subscriptions","organizations_url":"https://api.github.com/users/leonard84/orgs","repos_url":"https://api.github.com/users/leonard84/repos","events_url":"https://api.github.com/users/leonard84/events{/privacy}","received_events_url":"https://api.github.com/users/leonard84/received_events","type":"User","site_admin":false},"body":"The SingningExtension will try to load the key if the signing.password\r\nproperty is set, even if no actual signing is required. This happens\r\nas soon as the property is present regardless of its value.","created_at":"2016-08-16T21:22:02Z","updated_at":"2016-08-17T00:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2572a0026f52b6ce88ffb8ef9e0d11bd9f5c1cac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spockframework/spock/pulls/634/commits","review_comments_url":"https://api.github.com/repos/spockframework/spock/pulls/634/comments","review_comment_url":"https://api.github.com/repos/spockframework/spock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spockframework/spock/issues/634/comments","statuses_url":"https://api.github.com/repos/spockframework/spock/statuses/82b03ce01135a5e8cb60b8c31de3e1d6e2b0b21a","head":{"label":"leonard84:fix-signing-bug","ref":"fix-signing-bug","sha":"82b03ce01135a5e8cb60b8c31de3e1d6e2b0b21a","user":{"login":"leonard84","id":1151511,"avatar_url":"https://avatars.githubusercontent.com/u/1151511?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard84","html_url":"https://github.com/leonard84","followers_url":"https://api.github.com/users/leonard84/followers","following_url":"https://api.github.com/users/leonard84/following{/other_user}","gists_url":"https://api.github.com/users/leonard84/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard84/subscriptions","organizations_url":"https://api.github.com/users/leonard84/orgs","repos_url":"https://api.github.com/users/leonard84/repos","events_url":"https://api.github.com/users/leonard84/events{/privacy}","received_events_url":"https://api.github.com/users/leonard84/received_events","type":"User","site_admin":false},"repo":{"id":11291464,"name":"spock","full_name":"leonard84/spock","owner":{"login":"leonard84","id":1151511,"avatar_url":"https://avatars.githubusercontent.com/u/1151511?v=3","gravatar_id":"","url":"https://api.github.com/users/leonard84","html_url":"https://github.com/leonard84","followers_url":"https://api.github.com/users/leonard84/followers","following_url":"https://api.github.com/users/leonard84/following{/other_user}","gists_url":"https://api.github.com/users/leonard84/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard84/subscriptions","organizations_url":"https://api.github.com/users/leonard84/orgs","repos_url":"https://api.github.com/users/leonard84/repos","events_url":"https://api.github.com/users/leonard84/events{/privacy}","received_events_url":"https://api.github.com/users/leonard84/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leonard84/spock","description":"The Enterprise-ready testing and specification framework.","fork":true,"url":"https://api.github.com/repos/leonard84/spock","forks_url":"https://api.github.com/repos/leonard84/spock/forks","keys_url":"https://api.github.com/repos/leonard84/spock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leonard84/spock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leonard84/spock/teams","hooks_url":"https://api.github.com/repos/leonard84/spock/hooks","issue_events_url":"https://api.github.com/repos/leonard84/spock/issues/events{/number}","events_url":"https://api.github.com/repos/leonard84/spock/events","assignees_url":"https://api.github.com/repos/leonard84/spock/assignees{/user}","branches_url":"https://api.github.com/repos/leonard84/spock/branches{/branch}","tags_url":"https://api.github.com/repos/leonard84/spock/tags","blobs_url":"https://api.github.com/repos/leonard84/spock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leonard84/spock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leonard84/spock/git/refs{/sha}","trees_url":"https://api.github.com/repos/leonard84/spock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leonard84/spock/statuses/{sha}","languages_url":"https://api.github.com/repos/leonard84/spock/languages","stargazers_url":"https://api.github.com/repos/leonard84/spock/stargazers","contributors_url":"https://api.github.com/repos/leonard84/spock/contributors","subscribers_url":"https://api.github.com/repos/leonard84/spock/subscribers","subscription_url":"https://api.github.com/repos/leonard84/spock/subscription","commits_url":"https://api.github.com/repos/leonard84/spock/commits{/sha}","git_commits_url":"https://api.github.com/repos/leonard84/spock/git/commits{/sha}","comments_url":"https://api.github.com/repos/leonard84/spock/comments{/number}","issue_comment_url":"https://api.github.com/repos/leonard84/spock/issues/comments{/number}","contents_url":"https://api.github.com/repos/leonard84/spock/contents/{+path}","compare_url":"https://api.github.com/repos/leonard84/spock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leonard84/spock/merges","archive_url":"https://api.github.com/repos/leonard84/spock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leonard84/spock/downloads","issues_url":"https://api.github.com/repos/leonard84/spock/issues{/number}","pulls_url":"https://api.github.com/repos/leonard84/spock/pulls{/number}","milestones_url":"https://api.github.com/repos/leonard84/spock/milestones{/number}","notifications_url":"https://api.github.com/repos/leonard84/spock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leonard84/spock/labels{/name}","releases_url":"https://api.github.com/repos/leonard84/spock/releases{/id}","deployments_url":"https://api.github.com/repos/leonard84/spock/deployments","created_at":"2013-07-09T19:12:07Z","updated_at":"2014-10-05T14:52:24Z","pushed_at":"2016-08-16T21:33:50Z","git_url":"git://github.com/leonard84/spock.git","ssh_url":"git@github.com:leonard84/spock.git","clone_url":"https://github.com/leonard84/spock.git","svn_url":"https://github.com/leonard84/spock","homepage":"http://spockframework.org","size":8565,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spockframework:master","ref":"master","sha":"261107d83319f83349f5b1878d41d6116fa859ef","user":{"login":"spockframework","id":297723,"avatar_url":"https://avatars.githubusercontent.com/u/297723?v=3","gravatar_id":"","url":"https://api.github.com/users/spockframework","html_url":"https://github.com/spockframework","followers_url":"https://api.github.com/users/spockframework/followers","following_url":"https://api.github.com/users/spockframework/following{/other_user}","gists_url":"https://api.github.com/users/spockframework/gists{/gist_id}","starred_url":"https://api.github.com/users/spockframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spockframework/subscriptions","organizations_url":"https://api.github.com/users/spockframework/orgs","repos_url":"https://api.github.com/users/spockframework/repos","events_url":"https://api.github.com/users/spockframework/events{/privacy}","received_events_url":"https://api.github.com/users/spockframework/received_events","type":"Organization","site_admin":false},"repo":{"id":1161862,"name":"spock","full_name":"spockframework/spock","owner":{"login":"spockframework","id":297723,"avatar_url":"https://avatars.githubusercontent.com/u/297723?v=3","gravatar_id":"","url":"https://api.github.com/users/spockframework","html_url":"https://github.com/spockframework","followers_url":"https://api.github.com/users/spockframework/followers","following_url":"https://api.github.com/users/spockframework/following{/other_user}","gists_url":"https://api.github.com/users/spockframework/gists{/gist_id}","starred_url":"https://api.github.com/users/spockframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spockframework/subscriptions","organizations_url":"https://api.github.com/users/spockframework/orgs","repos_url":"https://api.github.com/users/spockframework/repos","events_url":"https://api.github.com/users/spockframework/events{/privacy}","received_events_url":"https://api.github.com/users/spockframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spockframework/spock","description":"The Enterprise-ready testing and specification framework.","fork":false,"url":"https://api.github.com/repos/spockframework/spock","forks_url":"https://api.github.com/repos/spockframework/spock/forks","keys_url":"https://api.github.com/repos/spockframework/spock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spockframework/spock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spockframework/spock/teams","hooks_url":"https://api.github.com/repos/spockframework/spock/hooks","issue_events_url":"https://api.github.com/repos/spockframework/spock/issues/events{/number}","events_url":"https://api.github.com/repos/spockframework/spock/events","assignees_url":"https://api.github.com/repos/spockframework/spock/assignees{/user}","branches_url":"https://api.github.com/repos/spockframework/spock/branches{/branch}","tags_url":"https://api.github.com/repos/spockframework/spock/tags","blobs_url":"https://api.github.com/repos/spockframework/spock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spockframework/spock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spockframework/spock/git/refs{/sha}","trees_url":"https://api.github.com/repos/spockframework/spock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spockframework/spock/statuses/{sha}","languages_url":"https://api.github.com/repos/spockframework/spock/languages","stargazers_url":"https://api.github.com/repos/spockframework/spock/stargazers","contributors_url":"https://api.github.com/repos/spockframework/spock/contributors","subscribers_url":"https://api.github.com/repos/spockframework/spock/subscribers","subscription_url":"https://api.github.com/repos/spockframework/spock/subscription","commits_url":"https://api.github.com/repos/spockframework/spock/commits{/sha}","git_commits_url":"https://api.github.com/repos/spockframework/spock/git/commits{/sha}","comments_url":"https://api.github.com/repos/spockframework/spock/comments{/number}","issue_comment_url":"https://api.github.com/repos/spockframework/spock/issues/comments{/number}","contents_url":"https://api.github.com/repos/spockframework/spock/contents/{+path}","compare_url":"https://api.github.com/repos/spockframework/spock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spockframework/spock/merges","archive_url":"https://api.github.com/repos/spockframework/spock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spockframework/spock/downloads","issues_url":"https://api.github.com/repos/spockframework/spock/issues{/number}","pulls_url":"https://api.github.com/repos/spockframework/spock/pulls{/number}","milestones_url":"https://api.github.com/repos/spockframework/spock/milestones{/number}","notifications_url":"https://api.github.com/repos/spockframework/spock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spockframework/spock/labels{/name}","releases_url":"https://api.github.com/repos/spockframework/spock/releases{/id}","deployments_url":"https://api.github.com/repos/spockframework/spock/deployments","created_at":"2010-12-12T19:02:34Z","updated_at":"2016-08-16T18:24:13Z","pushed_at":"2016-08-16T21:33:50Z","git_url":"git://github.com/spockframework/spock.git","ssh_url":"git@github.com:spockframework/spock.git","clone_url":"https://github.com/spockframework/spock.git","svn_url":"https://github.com/spockframework/spock","homepage":"http://spockframework.org","size":19125,"stargazers_count":1200,"watchers_count":1200,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":234,"mirror_url":null,"open_issues_count":204,"forks":234,"open_issues":204,"watchers":1200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spockframework/spock/pulls/634"},"html":{"href":"https://github.com/spockframework/spock/pull/634"},"issue":{"href":"https://api.github.com/repos/spockframework/spock/issues/634"},"comments":{"href":"https://api.github.com/repos/spockframework/spock/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/spockframework/spock/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/spockframework/spock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spockframework/spock/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/spockframework/spock/statuses/82b03ce01135a5e8cb60b8c31de3e1d6e2b0b21a"}}}}
{"actor":{"display_login":"leonard84"}}