{"push_id":1465915674,"size":7,"distinct_size":1,"ref":"refs/heads/master","head":"0dd5087994de7f99ebe0efccc218b73b8e8b456b","before":"32111d302fd66d5392d5cb565c37c2b4bb93ba0a","commits":[{"sha":"a10071cd97e67b5d1e33c92371744d9db7b301d6","author":{"name":"Leonid Mamchenkov","email":"95d6578748120f80de15911c0ede2d04ae20a3c9@mamchenkov.net"},"message":"Smarter way for field handlers to get value from data\n\nCurrently, we have multiple scenarios of passing the field\nvalue to the field handler (`renderValue()`, etc):\n\n* Using `$data` parameter\n* Using `$options['entity']` parameter\n\nOn top of that, both of these can be either one of the following:\n\n* An Entity instance\n* An array from $this->request->data()\n* An actual value of the field\n\nIn order to simplify the handling of these cases and make them\nmore consisten, we now do the following:\n\n1. Try to rely on `$data` parameter in all cases.\n2. Pass `$data` to `_getFieldValueFromData()` method, which checks\n   the type of the variable to be either an instance of Entity,\n   and instance of Request, or something else.\n3. If the `$data` is empty, then we try to get the value from the\n   `$options['entitiy']` if possible.\n\nThe last one should eventually be factored out and disappear.  It's\nonly there because we didn't do the clean data handling in the first\nplace.","distinct":false,"url":"https://api.github.com/repos/QoboLtd/cakephp-csv-migrations/commits/a10071cd97e67b5d1e33c92371744d9db7b301d6"},{"sha":"d0ee0a0697b4d1c3d59c0b08f70b6d2a1afcf5b1","author":{"name":"Leonid Mamchenkov","email":"95d6578748120f80de15911c0ede2d04ae20a3c9@mamchenkov.net"},"message":"Coding style fixes","distinct":false,"url":"https://api.github.com/repos/QoboLtd/cakephp-csv-migrations/commits/d0ee0a0697b4d1c3d59c0b08f70b6d2a1afcf5b1"},{"sha":"1b2e2c3ca435065d388d2764d89d63d40581cf7d","author":{"name":"Leonid Mamchenkov","email":"95d6578748120f80de15911c0ede2d04ae20a3c9@mamchenkov.net"},"message":"Send Request instance\n\nNow that field handlers know how to handle the `$data` variable\nproperly, we should just send the Request instance.","distinct":false,"url":"https://api.github.com/repos/QoboLtd/cakephp-csv-migrations/commits/1b2e2c3ca435065d388d2764d89d63d40581cf7d"},{"sha":"ca081db9a41bc9d11023f912eeda2550c13c7587","author":{"name":"Leonid Mamchenkov","email":"95d6578748120f80de15911c0ede2d04ae20a3c9@mamchenkov.net"},"message":"Fixed a typo","distinct":false,"url":"https://api.github.com/repos/QoboLtd/cakephp-csv-migrations/commits/ca081db9a41bc9d11023f912eeda2550c13c7587"},{"sha":"7cdd6fcc36d9c1021ab6f61e951a74936328d246","author":{"name":"Leonid Mamchenkov","email":"95d6578748120f80de15911c0ede2d04ae20a3c9@mamchenkov.net"},"message":"Fix handling field data in the loop\n\nHere, we differentiate between the `$data` that came in, and\n`$fieldData` which we are sending out to each field handler.","distinct":false,"url":"https://api.github.com/repos/QoboLtd/cakephp-csv-migrations/commits/7cdd6fcc36d9c1021ab6f61e951a74936328d246"},{"sha":"daf747fd60931ed665965184ba9354279e3cc2d3","author":{"name":"Leonid Mamchenkov","email":"95d6578748120f80de15911c0ede2d04ae20a3c9@mamchenkov.net"},"message":"Fix display field usage in related fields and API\n\nInstead of simply using a display field of the related module,\nwe need to pass the value through the Related Field Handler.  This\nfixes inconsistences in the display fields/values/styling, as well\nas improves the lookup of the value with recursion.","distinct":false,"url":"https://api.github.com/repos/QoboLtd/cakephp-csv-migrations/commits/daf747fd60931ed665965184ba9354279e3cc2d3"},{"sha":"0dd5087994de7f99ebe0efccc218b73b8e8b456b","author":{"name":"George Constantinou","email":"2dc662f0675359aceb99dc8253e07e7b0315e255@gmail.com"},"message":"Merge pull request #300 from QoboLtd/fh-data-fix\n\nField handler fixes","distinct":true,"url":"https://api.github.com/repos/QoboLtd/cakephp-csv-migrations/commits/0dd5087994de7f99ebe0efccc218b73b8e8b456b"}]}
{"actor":{"display_login":"georgeconstantinou"}}