{"action":"created","issue":{"url":"https://api.github.com/repos/brusselopole/Worldopole/issues/42","repository_url":"https://api.github.com/repos/brusselopole/Worldopole","labels_url":"https://api.github.com/repos/brusselopole/Worldopole/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/brusselopole/Worldopole/issues/42/comments","events_url":"https://api.github.com/repos/brusselopole/Worldopole/issues/42/events","html_url":"https://github.com/brusselopole/Worldopole/pull/42","id":174651714,"number":42,"title":"substract 15 minutes from timestamp to get real latest spawn","user":{"login":"ignaciogc","id":3594434,"avatar_url":"https://avatars.githubusercontent.com/u/3594434?v=3","gravatar_id":"","url":"https://api.github.com/users/ignaciogc","html_url":"https://github.com/ignaciogc","followers_url":"https://api.github.com/users/ignaciogc/followers","following_url":"https://api.github.com/users/ignaciogc/following{/other_user}","gists_url":"https://api.github.com/users/ignaciogc/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciogc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciogc/subscriptions","organizations_url":"https://api.github.com/users/ignaciogc/orgs","repos_url":"https://api.github.com/users/ignaciogc/repos","events_url":"https://api.github.com/users/ignaciogc/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciogc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-01T23:50:01Z","updated_at":"2016-09-02T00:51:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brusselopole/Worldopole/pulls/42","html_url":"https://github.com/brusselopole/Worldopole/pull/42","diff_url":"https://github.com/brusselopole/Worldopole/pull/42.diff","patch_url":"https://github.com/brusselopole/Worldopole/pull/42.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nPokemon details page was not showing the latest real spawn due to using disappear_time, instead of spawn time\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nUpdated query to remove the condition that would throw away any results that were newer than NOW()\r\nUpdated the time_ago function to remove 15 minutes (900 seconds) from the disappear_time to get the actual spawn time.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nIt fixes part of an open issue #30 and might help resolve some of the timestamp issues in the future.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nTested with actual results from my local version on rare pokemon (pokemonvb.com)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/brusselopole/Worldopole/issues/comments/244254891","html_url":"https://github.com/brusselopole/Worldopole/pull/42#issuecomment-244254891","issue_url":"https://api.github.com/repos/brusselopole/Worldopole/issues/42","id":244254891,"user":{"login":"ignaciogc","id":3594434,"avatar_url":"https://avatars.githubusercontent.com/u/3594434?v=3","gravatar_id":"","url":"https://api.github.com/users/ignaciogc","html_url":"https://github.com/ignaciogc","followers_url":"https://api.github.com/users/ignaciogc/followers","following_url":"https://api.github.com/users/ignaciogc/following{/other_user}","gists_url":"https://api.github.com/users/ignaciogc/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciogc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciogc/subscriptions","organizations_url":"https://api.github.com/users/ignaciogc/orgs","repos_url":"https://api.github.com/users/ignaciogc/repos","events_url":"https://api.github.com/users/ignaciogc/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciogc/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T00:51:07Z","updated_at":"2016-09-02T00:51:07Z","body":"I now that this is not an overall fix to the timezone issues, but it definitely fixes a small issue with the current code. \r\n\r\nAs I mentioned in a comment to #30 ; for RARE pokemon, the \"last seen\" information can be way off when they are listed on the \"recent spawns\". Since any spawns in the last 15 minutes are thrown away, for a rare pokemon, the system will throw away the only relevant spawn.\r\n\r\nIf there is a big change coming, this definitely doesn't need to be pulled, but otherwise it does help to show better data."}}
{"actor":{"display_login":"ignaciogc"}}