{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/1","id":67722440,"html_url":"https://github.com/tntdigital/eslint-config-tnt/pull/1","diff_url":"https://github.com/tntdigital/eslint-config-tnt/pull/1.diff","patch_url":"https://github.com/tntdigital/eslint-config-tnt/pull/1.patch","issue_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/1","number":1,"state":"open","locked":false,"title":"Relax the no-unused-vars rule","user":{"login":"fwielstra","id":394435,"avatar_url":"https://avatars.githubusercontent.com/u/394435?v=3","gravatar_id":"","url":"https://api.github.com/users/fwielstra","html_url":"https://github.com/fwielstra","followers_url":"https://api.github.com/users/fwielstra/followers","following_url":"https://api.github.com/users/fwielstra/following{/other_user}","gists_url":"https://api.github.com/users/fwielstra/gists{/gist_id}","starred_url":"https://api.github.com/users/fwielstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwielstra/subscriptions","organizations_url":"https://api.github.com/users/fwielstra/orgs","repos_url":"https://api.github.com/users/fwielstra/repos","events_url":"https://api.github.com/users/fwielstra/events{/privacy}","received_events_url":"https://api.github.com/users/fwielstra/received_events","type":"User","site_admin":false},"body":"This PR changes the `no-unused-vars` rule to no longer complain if certain function arguments are not used. I think that in some cases, these unused arguments are still valuable for documentation purposes or for completeness' sake.\r\nSecond, not declaring these arguments for e.g. anonymous callback functions seems a bit 'magic', like, where does the other argument go?\r\nThird, the rule is a bit confusing atm; it does not go off if the last argument in a function is used, e.g. any other arguments can be unused without warning. Another JS wtf thing.\r\n\r\nExample:\r\n\r\n```\r\nconst obj = { 'key1': 1, 'key2': 2, 'key3': 3 };\r\nconst keys = obj.map((v, k) => v); // violation: k is not used\r\nconst values = obj.map((v, k) => k); // with current setting: not a violation, last arg is used.\r\n```\r\n\r\nthis PR changes this so it never warns at unused function arguments.\r\n","created_at":"2016-04-25T13:48:24Z","updated_at":"2016-04-25T13:48:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/1/commits","review_comments_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/1/comments","review_comment_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/1/comments","statuses_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/statuses/4cbdd1b566de0ee4c95ffdae38b8180ae8d63906","head":{"label":"tntdigital:relax-no-unused-vars-rule","ref":"relax-no-unused-vars-rule","sha":"4cbdd1b566de0ee4c95ffdae38b8180ae8d63906","user":{"login":"tntdigital","id":16206367,"avatar_url":"https://avatars.githubusercontent.com/u/16206367?v=3","gravatar_id":"","url":"https://api.github.com/users/tntdigital","html_url":"https://github.com/tntdigital","followers_url":"https://api.github.com/users/tntdigital/followers","following_url":"https://api.github.com/users/tntdigital/following{/other_user}","gists_url":"https://api.github.com/users/tntdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/tntdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tntdigital/subscriptions","organizations_url":"https://api.github.com/users/tntdigital/orgs","repos_url":"https://api.github.com/users/tntdigital/repos","events_url":"https://api.github.com/users/tntdigital/events{/privacy}","received_events_url":"https://api.github.com/users/tntdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":56237922,"name":"eslint-config-tnt","full_name":"tntdigital/eslint-config-tnt","owner":{"login":"tntdigital","id":16206367,"avatar_url":"https://avatars.githubusercontent.com/u/16206367?v=3","gravatar_id":"","url":"https://api.github.com/users/tntdigital","html_url":"https://github.com/tntdigital","followers_url":"https://api.github.com/users/tntdigital/followers","following_url":"https://api.github.com/users/tntdigital/following{/other_user}","gists_url":"https://api.github.com/users/tntdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/tntdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tntdigital/subscriptions","organizations_url":"https://api.github.com/users/tntdigital/orgs","repos_url":"https://api.github.com/users/tntdigital/repos","events_url":"https://api.github.com/users/tntdigital/events{/privacy}","received_events_url":"https://api.github.com/users/tntdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tntdigital/eslint-config-tnt","description":"A set of shared ESLint configurations for all TNT Javascript projects","fork":false,"url":"https://api.github.com/repos/tntdigital/eslint-config-tnt","forks_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/forks","keys_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/teams","hooks_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/hooks","issue_events_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/events{/number}","events_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/events","assignees_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/assignees{/user}","branches_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/branches{/branch}","tags_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/tags","blobs_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/refs{/sha}","trees_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/statuses/{sha}","languages_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/languages","stargazers_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/stargazers","contributors_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/contributors","subscribers_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/subscribers","subscription_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/subscription","commits_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/commits{/sha}","git_commits_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/commits{/sha}","comments_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/comments{/number}","issue_comment_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/comments{/number}","contents_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/contents/{+path}","compare_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/merges","archive_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/downloads","issues_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues{/number}","pulls_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls{/number}","milestones_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/milestones{/number}","notifications_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/labels{/name}","releases_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/releases{/id}","deployments_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/deployments","created_at":"2016-04-14T13:04:29Z","updated_at":"2016-04-14T13:04:51Z","pushed_at":"2016-04-25T13:42:46Z","git_url":"git://github.com/tntdigital/eslint-config-tnt.git","ssh_url":"git@github.com:tntdigital/eslint-config-tnt.git","clone_url":"https://github.com/tntdigital/eslint-config-tnt.git","svn_url":"https://github.com/tntdigital/eslint-config-tnt","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tntdigital:master","ref":"master","sha":"7f78f6298ba0413dab0849dadafa4e3400dc566c","user":{"login":"tntdigital","id":16206367,"avatar_url":"https://avatars.githubusercontent.com/u/16206367?v=3","gravatar_id":"","url":"https://api.github.com/users/tntdigital","html_url":"https://github.com/tntdigital","followers_url":"https://api.github.com/users/tntdigital/followers","following_url":"https://api.github.com/users/tntdigital/following{/other_user}","gists_url":"https://api.github.com/users/tntdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/tntdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tntdigital/subscriptions","organizations_url":"https://api.github.com/users/tntdigital/orgs","repos_url":"https://api.github.com/users/tntdigital/repos","events_url":"https://api.github.com/users/tntdigital/events{/privacy}","received_events_url":"https://api.github.com/users/tntdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":56237922,"name":"eslint-config-tnt","full_name":"tntdigital/eslint-config-tnt","owner":{"login":"tntdigital","id":16206367,"avatar_url":"https://avatars.githubusercontent.com/u/16206367?v=3","gravatar_id":"","url":"https://api.github.com/users/tntdigital","html_url":"https://github.com/tntdigital","followers_url":"https://api.github.com/users/tntdigital/followers","following_url":"https://api.github.com/users/tntdigital/following{/other_user}","gists_url":"https://api.github.com/users/tntdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/tntdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tntdigital/subscriptions","organizations_url":"https://api.github.com/users/tntdigital/orgs","repos_url":"https://api.github.com/users/tntdigital/repos","events_url":"https://api.github.com/users/tntdigital/events{/privacy}","received_events_url":"https://api.github.com/users/tntdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tntdigital/eslint-config-tnt","description":"A set of shared ESLint configurations for all TNT Javascript projects","fork":false,"url":"https://api.github.com/repos/tntdigital/eslint-config-tnt","forks_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/forks","keys_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/teams","hooks_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/hooks","issue_events_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/events{/number}","events_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/events","assignees_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/assignees{/user}","branches_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/branches{/branch}","tags_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/tags","blobs_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/refs{/sha}","trees_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/statuses/{sha}","languages_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/languages","stargazers_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/stargazers","contributors_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/contributors","subscribers_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/subscribers","subscription_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/subscription","commits_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/commits{/sha}","git_commits_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/git/commits{/sha}","comments_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/comments{/number}","issue_comment_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/comments{/number}","contents_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/contents/{+path}","compare_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/merges","archive_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/downloads","issues_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues{/number}","pulls_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls{/number}","milestones_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/milestones{/number}","notifications_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/labels{/name}","releases_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/releases{/id}","deployments_url":"https://api.github.com/repos/tntdigital/eslint-config-tnt/deployments","created_at":"2016-04-14T13:04:29Z","updated_at":"2016-04-14T13:04:51Z","pushed_at":"2016-04-25T13:42:46Z","git_url":"git://github.com/tntdigital/eslint-config-tnt.git","ssh_url":"git@github.com:tntdigital/eslint-config-tnt.git","clone_url":"https://github.com/tntdigital/eslint-config-tnt.git","svn_url":"https://github.com/tntdigital/eslint-config-tnt","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/1"},"html":{"href":"https://github.com/tntdigital/eslint-config-tnt/pull/1"},"issue":{"href":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/1"},"comments":{"href":"https://api.github.com/repos/tntdigital/eslint-config-tnt/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tntdigital/eslint-config-tnt/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/tntdigital/eslint-config-tnt/statuses/4cbdd1b566de0ee4c95ffdae38b8180ae8d63906"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}