{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/16173","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/16173/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/16173/comments","events_url":"https://api.github.com/repos/apache/spark/issues/16173/events","html_url":"https://github.com/apache/spark/pull/16173","id":193815568,"number":16173,"title":"[SPARK-18742][CORE]readd spark.broadcast.factory conf to implement user-defined BroadcastFactory","user":{"login":"windpiger","id":12979185,"avatar_url":"https://avatars.githubusercontent.com/u/12979185?v=3","gravatar_id":"","url":"https://api.github.com/users/windpiger","html_url":"https://github.com/windpiger","followers_url":"https://api.github.com/users/windpiger/followers","following_url":"https://api.github.com/users/windpiger/following{/other_user}","gists_url":"https://api.github.com/users/windpiger/gists{/gist_id}","starred_url":"https://api.github.com/users/windpiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windpiger/subscriptions","organizations_url":"https://api.github.com/users/windpiger/orgs","repos_url":"https://api.github.com/users/windpiger/repos","events_url":"https://api.github.com/users/windpiger/events{/privacy}","received_events_url":"https://api.github.com/users/windpiger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2016-12-06T16:18:23Z","updated_at":"2016-12-16T01:17:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/16173","html_url":"https://github.com/apache/spark/pull/16173","diff_url":"https://github.com/apache/spark/pull/16173.diff","patch_url":"https://github.com/apache/spark/pull/16173.patch"},"body":"## What changes were proposed in this pull request?\r\nAfter SPARK-12588 Remove HTTPBroadcast [1], the one and only\r\nimplementation of BroadcastFactory is TorrentBroadcastFactory. No code\r\nin Spark 2 uses BroadcastFactory (but TorrentBroadcastFactory) however\r\nthe scaladoc says [2]:\r\n\r\n/**\r\n * An interface for all the broadcast implementations in Spark (to allow\r\n * multiple broadcast implementations). SparkContext uses a user-specified\r\n * BroadcastFactory implementation to instantiate a particular broadcast for the\r\n * entire Spark job.\r\n */\r\n\r\nwhich is not correct since there is no way to plug in a custom\r\nuser-specified BroadcastFactory.\r\n\r\nIt is better to readd spark.broadcast.factory for user-defined BroadcastFactory\r\n \r\n[1] https://issues.apache.org/jira/browse/SPARK-12588\r\n[2] https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala#L25-L30\r\n\r\n## How was this patch tested?\r\nunit test added"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/267492262","html_url":"https://github.com/apache/spark/pull/16173#issuecomment-267492262","issue_url":"https://api.github.com/repos/apache/spark/issues/16173","id":267492262,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T01:17:36Z","updated_at":"2016-12-16T01:17:36Z","body":"**[Test build #70227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70227/testReport)** for PR 16173 at commit [`49d799f`](https://github.com/apache/spark/commit/49d799fbbbf49b94af890820a050e395edf24c10)."}}
{"actor":{"display_login":"SparkQA"}}