{"action":"created","comment":{"url":"https://api.github.com/repos/mottosso/Qt.py/pulls/comments/77061203","id":77061203,"diff_hunk":"@@ -0,0 +1,52 @@\n+import os\n+import sys\n+import contextlib\n+import subprocess\n+\n+\n+@contextlib.contextmanager\n+def binding(binding):\n+    \"\"\"Prepare an environment for a specific binding\"\"\"\n+\n+    sys.stderr.write(\"\"\"\\\n+#\n+# Running tests with %s..\n+#\n+\"\"\" % binding)\n+\n+    os.environ[\"QT_PREFERRED_BINDING\"] = binding\n+\n+    try:\n+        yield\n+    except:\n+        pass\n+\n+    os.environ.pop(\"QT_PREFERRED_BINDING\")\n+\n+\n+if __name__ == \"__main__\":\n+    argv = [\n+        \"nosetests\",\n+        \"--verbose\",\n+        \"--with-process-isolation\",\n+        \"--exe\",\n+    ]\n+\n+    argv.extend(sys.argv[1:])\n+\n+    # Running each test independently via subprocess\n+    # enables tests to filter out from tests.py before\n+    # being split into individual processes via the\n+    # --with-process-isolation feature of nose.\n+    with binding(\"PyQt4\"):\n+        subprocess.call(argv)","path":"run_tests.py","position":42,"original_position":42,"commit_id":"4f76e245b5d58bf6d6f92120924616c3848256e9","original_commit_id":"76dc1cf6a966f6c582527cb639d4f8113e374936","user":{"login":"mottosso","id":2152766,"avatar_url":"https://avatars.githubusercontent.com/u/2152766?v=3","gravatar_id":"","url":"https://api.github.com/users/mottosso","html_url":"https://github.com/mottosso","followers_url":"https://api.github.com/users/mottosso/followers","following_url":"https://api.github.com/users/mottosso/following{/other_user}","gists_url":"https://api.github.com/users/mottosso/gists{/gist_id}","starred_url":"https://api.github.com/users/mottosso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mottosso/subscriptions","organizations_url":"https://api.github.com/users/mottosso/orgs","repos_url":"https://api.github.com/users/mottosso/repos","events_url":"https://api.github.com/users/mottosso/events{/privacy}","received_events_url":"https://api.github.com/users/mottosso/received_events","type":"User","site_admin":false},"body":"Sorry missed this comment.\r\n\r\nCons, not that I can tell. There are some organisational cons; as we are now doing in Python what we could have done in the docker ENTRYPOINT, and in the ENTRYPOINT we are doing things that could have been done here.\r\n\r\nI sense that at some point we'll either transition into doing it all there, or all in Python. But personally I feel it's too early to tell and would be happy to leave it as-is until we can point at concrete problems and manage them then. Unless you see any issues with it as-is?","created_at":"2016-08-31T19:56:44Z","updated_at":"2016-08-31T19:56:44Z","html_url":"https://github.com/mottosso/Qt.py/pull/123#discussion_r77061203","pull_request_url":"https://api.github.com/repos/mottosso/Qt.py/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/mottosso/Qt.py/pulls/comments/77061203"},"html":{"href":"https://github.com/mottosso/Qt.py/pull/123#discussion_r77061203"},"pull_request":{"href":"https://api.github.com/repos/mottosso/Qt.py/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/mottosso/Qt.py/pulls/123","id":83239992,"html_url":"https://github.com/mottosso/Qt.py/pull/123","diff_url":"https://github.com/mottosso/Qt.py/pull/123.diff","patch_url":"https://github.com/mottosso/Qt.py/pull/123.patch","issue_url":"https://api.github.com/repos/mottosso/Qt.py/issues/123","number":123,"state":"open","locked":false,"title":"Implement #122","user":{"login":"mottosso","id":2152766,"avatar_url":"https://avatars.githubusercontent.com/u/2152766?v=3","gravatar_id":"","url":"https://api.github.com/users/mottosso","html_url":"https://github.com/mottosso","followers_url":"https://api.github.com/users/mottosso/followers","following_url":"https://api.github.com/users/mottosso/following{/other_user}","gists_url":"https://api.github.com/users/mottosso/gists{/gist_id}","starred_url":"https://api.github.com/users/mottosso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mottosso/subscriptions","organizations_url":"https://api.github.com/users/mottosso/orgs","repos_url":"https://api.github.com/users/mottosso/repos","events_url":"https://api.github.com/users/mottosso/events{/privacy}","received_events_url":"https://api.github.com/users/mottosso/received_events","type":"User","site_admin":false},"body":"#122\r\n\r\nWithout access to Docker at the moment, will trust Travis to run tests for me.","created_at":"2016-08-30T09:48:24Z","updated_at":"2016-08-31T19:56:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb3dbbf8c9042ef9d80efc1dd6b3c0cf4ad21548","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mottosso/Qt.py/pulls/123/commits","review_comments_url":"https://api.github.com/repos/mottosso/Qt.py/pulls/123/comments","review_comment_url":"https://api.github.com/repos/mottosso/Qt.py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mottosso/Qt.py/issues/123/comments","statuses_url":"https://api.github.com/repos/mottosso/Qt.py/statuses/4f76e245b5d58bf6d6f92120924616c3848256e9","head":{"label":"abstractfactory:#122","ref":"#122","sha":"4f76e245b5d58bf6d6f92120924616c3848256e9","user":{"login":"abstractfactory","id":5812121,"avatar_url":"https://avatars.githubusercontent.com/u/5812121?v=3","gravatar_id":"","url":"https://api.github.com/users/abstractfactory","html_url":"https://github.com/abstractfactory","followers_url":"https://api.github.com/users/abstractfactory/followers","following_url":"https://api.github.com/users/abstractfactory/following{/other_user}","gists_url":"https://api.github.com/users/abstractfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/abstractfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstractfactory/subscriptions","organizations_url":"https://api.github.com/users/abstractfactory/orgs","repos_url":"https://api.github.com/users/abstractfactory/repos","events_url":"https://api.github.com/users/abstractfactory/events{/privacy}","received_events_url":"https://api.github.com/users/abstractfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":59884811,"name":"Qt.py","full_name":"abstractfactory/Qt.py","owner":{"login":"abstractfactory","id":5812121,"avatar_url":"https://avatars.githubusercontent.com/u/5812121?v=3","gravatar_id":"","url":"https://api.github.com/users/abstractfactory","html_url":"https://github.com/abstractfactory","followers_url":"https://api.github.com/users/abstractfactory/followers","following_url":"https://api.github.com/users/abstractfactory/following{/other_user}","gists_url":"https://api.github.com/users/abstractfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/abstractfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abstractfactory/subscriptions","organizations_url":"https://api.github.com/users/abstractfactory/orgs","repos_url":"https://api.github.com/users/abstractfactory/repos","events_url":"https://api.github.com/users/abstractfactory/events{/privacy}","received_events_url":"https://api.github.com/users/abstractfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/abstractfactory/Qt.py","description":"Python 2 & 3 compatibility wrapper around all Qt bindings - PySide, PySide2, PyQt4 and PyQt5.","fork":true,"url":"https://api.github.com/repos/abstractfactory/Qt.py","forks_url":"https://api.github.com/repos/abstractfactory/Qt.py/forks","keys_url":"https://api.github.com/repos/abstractfactory/Qt.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abstractfactory/Qt.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abstractfactory/Qt.py/teams","hooks_url":"https://api.github.com/repos/abstractfactory/Qt.py/hooks","issue_events_url":"https://api.github.com/repos/abstractfactory/Qt.py/issues/events{/number}","events_url":"https://api.github.com/repos/abstractfactory/Qt.py/events","assignees_url":"https://api.github.com/repos/abstractfactory/Qt.py/assignees{/user}","branches_url":"https://api.github.com/repos/abstractfactory/Qt.py/branches{/branch}","tags_url":"https://api.github.com/repos/abstractfactory/Qt.py/tags","blobs_url":"https://api.github.com/repos/abstractfactory/Qt.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abstractfactory/Qt.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abstractfactory/Qt.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/abstractfactory/Qt.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abstractfactory/Qt.py/statuses/{sha}","languages_url":"https://api.github.com/repos/abstractfactory/Qt.py/languages","stargazers_url":"https://api.github.com/repos/abstractfactory/Qt.py/stargazers","contributors_url":"https://api.github.com/repos/abstractfactory/Qt.py/contributors","subscribers_url":"https://api.github.com/repos/abstractfactory/Qt.py/subscribers","subscription_url":"https://api.github.com/repos/abstractfactory/Qt.py/subscription","commits_url":"https://api.github.com/repos/abstractfactory/Qt.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/abstractfactory/Qt.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/abstractfactory/Qt.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/abstractfactory/Qt.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/abstractfactory/Qt.py/contents/{+path}","compare_url":"https://api.github.com/repos/abstractfactory/Qt.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abstractfactory/Qt.py/merges","archive_url":"https://api.github.com/repos/abstractfactory/Qt.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abstractfactory/Qt.py/downloads","issues_url":"https://api.github.com/repos/abstractfactory/Qt.py/issues{/number}","pulls_url":"https://api.github.com/repos/abstractfactory/Qt.py/pulls{/number}","milestones_url":"https://api.github.com/repos/abstractfactory/Qt.py/milestones{/number}","notifications_url":"https://api.github.com/repos/abstractfactory/Qt.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abstractfactory/Qt.py/labels{/name}","releases_url":"https://api.github.com/repos/abstractfactory/Qt.py/releases{/id}","deployments_url":"https://api.github.com/repos/abstractfactory/Qt.py/deployments","created_at":"2016-05-28T08:27:13Z","updated_at":"2016-05-30T11:57:08Z","pushed_at":"2016-08-31T19:37:48Z","git_url":"git://github.com/abstractfactory/Qt.py.git","ssh_url":"git@github.com:abstractfactory/Qt.py.git","clone_url":"https://github.com/abstractfactory/Qt.py.git","svn_url":"https://github.com/abstractfactory/Qt.py","homepage":null,"size":174,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mottosso:master","ref":"master","sha":"34b4cfe9fcd380b0b42340f32e01d89532d3b882","user":{"login":"mottosso","id":2152766,"avatar_url":"https://avatars.githubusercontent.com/u/2152766?v=3","gravatar_id":"","url":"https://api.github.com/users/mottosso","html_url":"https://github.com/mottosso","followers_url":"https://api.github.com/users/mottosso/followers","following_url":"https://api.github.com/users/mottosso/following{/other_user}","gists_url":"https://api.github.com/users/mottosso/gists{/gist_id}","starred_url":"https://api.github.com/users/mottosso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mottosso/subscriptions","organizations_url":"https://api.github.com/users/mottosso/orgs","repos_url":"https://api.github.com/users/mottosso/repos","events_url":"https://api.github.com/users/mottosso/events{/privacy}","received_events_url":"https://api.github.com/users/mottosso/received_events","type":"User","site_admin":false},"repo":{"id":59824305,"name":"Qt.py","full_name":"mottosso/Qt.py","owner":{"login":"mottosso","id":2152766,"avatar_url":"https://avatars.githubusercontent.com/u/2152766?v=3","gravatar_id":"","url":"https://api.github.com/users/mottosso","html_url":"https://github.com/mottosso","followers_url":"https://api.github.com/users/mottosso/followers","following_url":"https://api.github.com/users/mottosso/following{/other_user}","gists_url":"https://api.github.com/users/mottosso/gists{/gist_id}","starred_url":"https://api.github.com/users/mottosso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mottosso/subscriptions","organizations_url":"https://api.github.com/users/mottosso/orgs","repos_url":"https://api.github.com/users/mottosso/repos","events_url":"https://api.github.com/users/mottosso/events{/privacy}","received_events_url":"https://api.github.com/users/mottosso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mottosso/Qt.py","description":"Minimal Python 2 & 3 shim around all Qt bindings - PySide, PySide2, PyQt4 and PyQt5.","fork":false,"url":"https://api.github.com/repos/mottosso/Qt.py","forks_url":"https://api.github.com/repos/mottosso/Qt.py/forks","keys_url":"https://api.github.com/repos/mottosso/Qt.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mottosso/Qt.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mottosso/Qt.py/teams","hooks_url":"https://api.github.com/repos/mottosso/Qt.py/hooks","issue_events_url":"https://api.github.com/repos/mottosso/Qt.py/issues/events{/number}","events_url":"https://api.github.com/repos/mottosso/Qt.py/events","assignees_url":"https://api.github.com/repos/mottosso/Qt.py/assignees{/user}","branches_url":"https://api.github.com/repos/mottosso/Qt.py/branches{/branch}","tags_url":"https://api.github.com/repos/mottosso/Qt.py/tags","blobs_url":"https://api.github.com/repos/mottosso/Qt.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mottosso/Qt.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mottosso/Qt.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/mottosso/Qt.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mottosso/Qt.py/statuses/{sha}","languages_url":"https://api.github.com/repos/mottosso/Qt.py/languages","stargazers_url":"https://api.github.com/repos/mottosso/Qt.py/stargazers","contributors_url":"https://api.github.com/repos/mottosso/Qt.py/contributors","subscribers_url":"https://api.github.com/repos/mottosso/Qt.py/subscribers","subscription_url":"https://api.github.com/repos/mottosso/Qt.py/subscription","commits_url":"https://api.github.com/repos/mottosso/Qt.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/mottosso/Qt.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/mottosso/Qt.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/mottosso/Qt.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/mottosso/Qt.py/contents/{+path}","compare_url":"https://api.github.com/repos/mottosso/Qt.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mottosso/Qt.py/merges","archive_url":"https://api.github.com/repos/mottosso/Qt.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mottosso/Qt.py/downloads","issues_url":"https://api.github.com/repos/mottosso/Qt.py/issues{/number}","pulls_url":"https://api.github.com/repos/mottosso/Qt.py/pulls{/number}","milestones_url":"https://api.github.com/repos/mottosso/Qt.py/milestones{/number}","notifications_url":"https://api.github.com/repos/mottosso/Qt.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mottosso/Qt.py/labels{/name}","releases_url":"https://api.github.com/repos/mottosso/Qt.py/releases{/id}","deployments_url":"https://api.github.com/repos/mottosso/Qt.py/deployments","created_at":"2016-05-27T09:52:11Z","updated_at":"2016-08-19T02:18:04Z","pushed_at":"2016-08-31T19:37:48Z","git_url":"git://github.com/mottosso/Qt.py.git","ssh_url":"git@github.com:mottosso/Qt.py.git","clone_url":"https://github.com/mottosso/Qt.py.git","svn_url":"https://github.com/mottosso/Qt.py","homepage":"","size":261,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":16,"forks":13,"open_issues":16,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mottosso/Qt.py/pulls/123"},"html":{"href":"https://github.com/mottosso/Qt.py/pull/123"},"issue":{"href":"https://api.github.com/repos/mottosso/Qt.py/issues/123"},"comments":{"href":"https://api.github.com/repos/mottosso/Qt.py/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/mottosso/Qt.py/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/mottosso/Qt.py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mottosso/Qt.py/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/mottosso/Qt.py/statuses/4f76e245b5d58bf6d6f92120924616c3848256e9"}}}}
{"actor":{"display_login":"mottosso"}}