{"action":"created","issue":{"url":"https://api.github.com/repos/splicemachine/spliceengine/issues/39","repository_url":"https://api.github.com/repos/splicemachine/spliceengine","labels_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/39/comments","events_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/39/events","html_url":"https://github.com/splicemachine/spliceengine/pull/39","id":167472175,"number":39,"title":"Fixed SPLICE 709 - Use Kryo pools in result streamer / stream listener","user":{"login":"jfilali","id":5000030,"avatar_url":"https://avatars.githubusercontent.com/u/5000030?v=3","gravatar_id":"","url":"https://api.github.com/users/jfilali","html_url":"https://github.com/jfilali","followers_url":"https://api.github.com/users/jfilali/followers","following_url":"https://api.github.com/users/jfilali/following{/other_user}","gists_url":"https://api.github.com/users/jfilali/gists{/gist_id}","starred_url":"https://api.github.com/users/jfilali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfilali/subscriptions","organizations_url":"https://api.github.com/users/jfilali/orgs","repos_url":"https://api.github.com/users/jfilali/repos","events_url":"https://api.github.com/users/jfilali/events{/privacy}","received_events_url":"https://api.github.com/users/jfilali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"scottfines","id":371216,"avatar_url":"https://avatars.githubusercontent.com/u/371216?v=3","gravatar_id":"","url":"https://api.github.com/users/scottfines","html_url":"https://github.com/scottfines","followers_url":"https://api.github.com/users/scottfines/followers","following_url":"https://api.github.com/users/scottfines/following{/other_user}","gists_url":"https://api.github.com/users/scottfines/gists{/gist_id}","starred_url":"https://api.github.com/users/scottfines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottfines/subscriptions","organizations_url":"https://api.github.com/users/scottfines/orgs","repos_url":"https://api.github.com/users/scottfines/repos","events_url":"https://api.github.com/users/scottfines/events{/privacy}","received_events_url":"https://api.github.com/users/scottfines/received_events","type":"User","site_admin":false},"assignees":[{"login":"scottfines","id":371216,"avatar_url":"https://avatars.githubusercontent.com/u/371216?v=3","gravatar_id":"","url":"https://api.github.com/users/scottfines","html_url":"https://github.com/scottfines","followers_url":"https://api.github.com/users/scottfines/followers","following_url":"https://api.github.com/users/scottfines/following{/other_user}","gists_url":"https://api.github.com/users/scottfines/gists{/gist_id}","starred_url":"https://api.github.com/users/scottfines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottfines/subscriptions","organizations_url":"https://api.github.com/users/scottfines/orgs","repos_url":"https://api.github.com/users/scottfines/repos","events_url":"https://api.github.com/users/scottfines/events{/privacy}","received_events_url":"https://api.github.com/users/scottfines/received_events","type":"User","site_admin":false},{"login":"dgomezferro","id":751899,"avatar_url":"https://avatars.githubusercontent.com/u/751899?v=3","gravatar_id":"","url":"https://api.github.com/users/dgomezferro","html_url":"https://github.com/dgomezferro","followers_url":"https://api.github.com/users/dgomezferro/followers","following_url":"https://api.github.com/users/dgomezferro/following{/other_user}","gists_url":"https://api.github.com/users/dgomezferro/gists{/gist_id}","starred_url":"https://api.github.com/users/dgomezferro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgomezferro/subscriptions","organizations_url":"https://api.github.com/users/dgomezferro/orgs","repos_url":"https://api.github.com/users/dgomezferro/repos","events_url":"https://api.github.com/users/dgomezferro/events{/privacy}","received_events_url":"https://api.github.com/users/dgomezferro/received_events","type":"User","site_admin":false},{"login":"genedavis","id":1200144,"avatar_url":"https://avatars.githubusercontent.com/u/1200144?v=3","gravatar_id":"","url":"https://api.github.com/users/genedavis","html_url":"https://github.com/genedavis","followers_url":"https://api.github.com/users/genedavis/followers","following_url":"https://api.github.com/users/genedavis/following{/other_user}","gists_url":"https://api.github.com/users/genedavis/gists{/gist_id}","starred_url":"https://api.github.com/users/genedavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genedavis/subscriptions","organizations_url":"https://api.github.com/users/genedavis/orgs","repos_url":"https://api.github.com/users/genedavis/repos","events_url":"https://api.github.com/users/genedavis/events{/privacy}","received_events_url":"https://api.github.com/users/genedavis/received_events","type":"User","site_admin":false},{"login":"jleach4","id":1850293,"avatar_url":"https://avatars.githubusercontent.com/u/1850293?v=3","gravatar_id":"","url":"https://api.github.com/users/jleach4","html_url":"https://github.com/jleach4","followers_url":"https://api.github.com/users/jleach4/followers","following_url":"https://api.github.com/users/jleach4/following{/other_user}","gists_url":"https://api.github.com/users/jleach4/gists{/gist_id}","starred_url":"https://api.github.com/users/jleach4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleach4/subscriptions","organizations_url":"https://api.github.com/users/jleach4/orgs","repos_url":"https://api.github.com/users/jleach4/repos","events_url":"https://api.github.com/users/jleach4/events{/privacy}","received_events_url":"https://api.github.com/users/jleach4/received_events","type":"User","site_admin":false},{"login":"jeffcunningham","id":4549951,"avatar_url":"https://avatars.githubusercontent.com/u/4549951?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffcunningham","html_url":"https://github.com/jeffcunningham","followers_url":"https://api.github.com/users/jeffcunningham/followers","following_url":"https://api.github.com/users/jeffcunningham/following{/other_user}","gists_url":"https://api.github.com/users/jeffcunningham/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffcunningham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffcunningham/subscriptions","organizations_url":"https://api.github.com/users/jeffcunningham/orgs","repos_url":"https://api.github.com/users/jeffcunningham/repos","events_url":"https://api.github.com/users/jeffcunningham/events{/privacy}","received_events_url":"https://api.github.com/users/jeffcunningham/received_events","type":"User","site_admin":false},{"login":"jfilali","id":5000030,"avatar_url":"https://avatars.githubusercontent.com/u/5000030?v=3","gravatar_id":"","url":"https://api.github.com/users/jfilali","html_url":"https://github.com/jfilali","followers_url":"https://api.github.com/users/jfilali/followers","following_url":"https://api.github.com/users/jfilali/following{/other_user}","gists_url":"https://api.github.com/users/jfilali/gists{/gist_id}","starred_url":"https://api.github.com/users/jfilali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfilali/subscriptions","organizations_url":"https://api.github.com/users/jfilali/orgs","repos_url":"https://api.github.com/users/jfilali/repos","events_url":"https://api.github.com/users/jfilali/events{/privacy}","received_events_url":"https://api.github.com/users/jfilali/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-07-25T21:38:21Z","updated_at":"2016-07-28T11:34:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/splicemachine/spliceengine/pulls/39","html_url":"https://github.com/splicemachine/spliceengine/pull/39","diff_url":"https://github.com/splicemachine/spliceengine/pull/39.diff","patch_url":"https://github.com/splicemachine/spliceengine/pull/39.patch"},"body":"I didn't change ResultStreamer because this code is executed in Spark for each request by deserializing the class. It doesn't make sense then to spin up a pool each time.\r\n\r\n Made SpliceSparkKryoRegistrator to implement KryoPool.KryoRegistry so we can reuse the Kryo Pool."},"comment":{"url":"https://api.github.com/repos/splicemachine/spliceengine/issues/comments/235870336","html_url":"https://github.com/splicemachine/spliceengine/pull/39#issuecomment-235870336","issue_url":"https://api.github.com/repos/splicemachine/spliceengine/issues/39","id":235870336,"user":{"login":"dgomezferro","id":751899,"avatar_url":"https://avatars.githubusercontent.com/u/751899?v=3","gravatar_id":"","url":"https://api.github.com/users/dgomezferro","html_url":"https://github.com/dgomezferro","followers_url":"https://api.github.com/users/dgomezferro/followers","following_url":"https://api.github.com/users/dgomezferro/following{/other_user}","gists_url":"https://api.github.com/users/dgomezferro/gists{/gist_id}","starred_url":"https://api.github.com/users/dgomezferro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgomezferro/subscriptions","organizations_url":"https://api.github.com/users/dgomezferro/orgs","repos_url":"https://api.github.com/users/dgomezferro/repos","events_url":"https://api.github.com/users/dgomezferro/events{/privacy}","received_events_url":"https://api.github.com/users/dgomezferro/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T11:34:39Z","updated_at":"2016-07-28T11:34:39Z","body":"I'm not sure why you think it's not possible, we can meet today if you'd like to discuss. The basic idea would be to replicate what you did on `StreamListenerServer` in `ResultStreamer`, that is, getting an `KryoPool` instance (which is shared, since it's stored in a static field in `SpliceSparkKryoRegistrator`) and then using that `KryoPool` to generate `Kryo` objects."}}
{"actor":{"display_login":"dgomezferro"}}