{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/68749330","id":68749330,"diff_hunk":"@@ -104,18 +114,14 @@ bool MCGRasterToCGImage(const MCGRaster &p_raster, MCGRectangle p_src_rect, CGCo\n \tt_width = p_src_rect.size.width;\n \tt_height = p_src_rect.size.height;\n \t\n-\t/* OVERHAUL - REVISIT: pixel formats */\n-\tconst uint8_t *t_src_ptr = (uint8_t*)p_raster.pixels;\n-\tt_src_ptr += t_y * p_raster.stride + t_x * sizeof(uint32_t);\n+\tconst uint8_t *t_src_ptr = (uint8_t*)MCGRasterGetPixelPtr(p_raster, t_x, t_y);","path":"engine/src/cgimageutil.cpp","position":27,"original_position":27,"commit_id":"3dfe253848530d64b1c0eaf08848a98bc381f0f9","original_commit_id":"3dfe253848530d64b1c0eaf08848a98bc381f0f9","user":{"login":"peter-b","id":47528,"avatar_url":"https://avatars.githubusercontent.com/u/47528?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-b","html_url":"https://github.com/peter-b","followers_url":"https://api.github.com/users/peter-b/followers","following_url":"https://api.github.com/users/peter-b/following{/other_user}","gists_url":"https://api.github.com/users/peter-b/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-b/subscriptions","organizations_url":"https://api.github.com/users/peter-b/orgs","repos_url":"https://api.github.com/users/peter-b/repos","events_url":"https://api.github.com/users/peter-b/events{/privacy}","received_events_url":"https://api.github.com/users/peter-b/received_events","type":"User","site_admin":false},"body":"As stylistic improvement, do you think it might be a good idea to change `MCGRasterGetPixelPtr()` to return `uint8_t *` or `byte_t *`? It would still be possible to store the result into a `void *` but maybe it would be a more informative prototype.","created_at":"2016-06-28T12:48:44Z","updated_at":"2016-06-28T12:48:44Z","html_url":"https://github.com/livecode/livecode/pull/4186#discussion_r68749330","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/4186","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/68749330"},"html":{"href":"https://github.com/livecode/livecode/pull/4186#discussion_r68749330"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4186"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/4186","id":74771568,"html_url":"https://github.com/livecode/livecode/pull/4186","diff_url":"https://github.com/livecode/livecode/pull/4186.diff","patch_url":"https://github.com/livecode/livecode/pull/4186.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/4186","number":4186,"state":"open","locked":false,"title":"[[ Bug 17615 ]] Fix CGImage using source MCGImageRef after release","user":{"login":"livecodeian","id":3985900,"avatar_url":"https://avatars.githubusercontent.com/u/3985900?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeian","html_url":"https://github.com/livecodeian","followers_url":"https://api.github.com/users/livecodeian/followers","following_url":"https://api.github.com/users/livecodeian/following{/other_user}","gists_url":"https://api.github.com/users/livecodeian/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeian/subscriptions","organizations_url":"https://api.github.com/users/livecodeian/orgs","repos_url":"https://api.github.com/users/livecodeian/repos","events_url":"https://api.github.com/users/livecodeian/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeian/received_events","type":"User","site_admin":false},"body":"The CGImage created while printing to preview can in some circumstances be retained and used after the MCGImageRef from which it was created has been destroyed.\r\n\r\nThis patch modifies the MCGImageToCGImage function to maintain a reference to the source MCGImageRef until the CGImage is freed","created_at":"2016-06-22T12:02:02Z","updated_at":"2016-06-28T12:48:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0df90b77471ac8b08743973a2715c508c599309b","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/livecode/livecode/milestones/111","html_url":"https://github.com/livecode/livecode/milestones/8.0.3-rc-1","labels_url":"https://api.github.com/repos/livecode/livecode/milestones/111/labels","id":1815345,"number":111,"title":"8.0.3-rc-1","description":null,"creator":{"login":"peter-b","id":47528,"avatar_url":"https://avatars.githubusercontent.com/u/47528?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-b","html_url":"https://github.com/peter-b","followers_url":"https://api.github.com/users/peter-b/followers","following_url":"https://api.github.com/users/peter-b/following{/other_user}","gists_url":"https://api.github.com/users/peter-b/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-b/subscriptions","organizations_url":"https://api.github.com/users/peter-b/orgs","repos_url":"https://api.github.com/users/peter-b/repos","events_url":"https://api.github.com/users/peter-b/events{/privacy}","received_events_url":"https://api.github.com/users/peter-b/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":18,"state":"open","created_at":"2016-06-08T10:24:06Z","updated_at":"2016-06-28T12:41:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/4186/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/4186/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/4186/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/3dfe253848530d64b1c0eaf08848a98bc381f0f9","head":{"label":"livecodeian:bugfix-17615","ref":"bugfix-17615","sha":"3dfe253848530d64b1c0eaf08848a98bc381f0f9","user":{"login":"livecodeian","id":3985900,"avatar_url":"https://avatars.githubusercontent.com/u/3985900?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeian","html_url":"https://github.com/livecodeian","followers_url":"https://api.github.com/users/livecodeian/followers","following_url":"https://api.github.com/users/livecodeian/following{/other_user}","gists_url":"https://api.github.com/users/livecodeian/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeian/subscriptions","organizations_url":"https://api.github.com/users/livecodeian/orgs","repos_url":"https://api.github.com/users/livecodeian/repos","events_url":"https://api.github.com/users/livecodeian/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeian/received_events","type":"User","site_admin":false},"repo":{"id":9372560,"name":"livecode","full_name":"livecodeian/livecode","owner":{"login":"livecodeian","id":3985900,"avatar_url":"https://avatars.githubusercontent.com/u/3985900?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeian","html_url":"https://github.com/livecodeian","followers_url":"https://api.github.com/users/livecodeian/followers","following_url":"https://api.github.com/users/livecodeian/following{/other_user}","gists_url":"https://api.github.com/users/livecodeian/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeian/subscriptions","organizations_url":"https://api.github.com/users/livecodeian/orgs","repos_url":"https://api.github.com/users/livecodeian/repos","events_url":"https://api.github.com/users/livecodeian/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/livecodeian/livecode","description":"","fork":true,"url":"https://api.github.com/repos/livecodeian/livecode","forks_url":"https://api.github.com/repos/livecodeian/livecode/forks","keys_url":"https://api.github.com/repos/livecodeian/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecodeian/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecodeian/livecode/teams","hooks_url":"https://api.github.com/repos/livecodeian/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecodeian/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecodeian/livecode/events","assignees_url":"https://api.github.com/repos/livecodeian/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecodeian/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecodeian/livecode/tags","blobs_url":"https://api.github.com/repos/livecodeian/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecodeian/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecodeian/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecodeian/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecodeian/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecodeian/livecode/languages","stargazers_url":"https://api.github.com/repos/livecodeian/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecodeian/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecodeian/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecodeian/livecode/subscription","commits_url":"https://api.github.com/repos/livecodeian/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecodeian/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecodeian/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecodeian/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecodeian/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecodeian/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecodeian/livecode/merges","archive_url":"https://api.github.com/repos/livecodeian/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecodeian/livecode/downloads","issues_url":"https://api.github.com/repos/livecodeian/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecodeian/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecodeian/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecodeian/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecodeian/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecodeian/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecodeian/livecode/deployments","created_at":"2013-04-11T14:42:23Z","updated_at":"2014-06-23T12:26:19Z","pushed_at":"2016-06-27T11:01:34Z","git_url":"git://github.com/livecodeian/livecode.git","ssh_url":"git@github.com:livecodeian/livecode.git","clone_url":"https://github.com/livecodeian/livecode.git","svn_url":"https://github.com/livecodeian/livecode","homepage":null,"size":115625,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"livecode:develop-8.0","ref":"develop-8.0","sha":"bd06ec3b011e71a1aed7fab3c7643809a0c21504","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"LiveCode cross-platform development environment (engine)","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecode/livecode/deployments","created_at":"2013-04-10T00:15:57Z","updated_at":"2016-06-21T09:02:12Z","pushed_at":"2016-06-28T12:41:51Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":"https://livecode.com/","size":176787,"stargazers_count":130,"watchers_count":130,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":48,"forks":103,"open_issues":48,"watchers":130,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4186"},"html":{"href":"https://github.com/livecode/livecode/pull/4186"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/4186"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/4186/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4186/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/4186/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/3dfe253848530d64b1c0eaf08848a98bc381f0f9"}}}}
{"actor":{"display_login":"peter-b"}}