{"action":"created","issue":{"url":"https://api.github.com/repos/dirkmoors/pyejabberd/issues/23","repository_url":"https://api.github.com/repos/dirkmoors/pyejabberd","labels_url":"https://api.github.com/repos/dirkmoors/pyejabberd/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/dirkmoors/pyejabberd/issues/23/comments","events_url":"https://api.github.com/repos/dirkmoors/pyejabberd/issues/23/events","html_url":"https://github.com/dirkmoors/pyejabberd/pull/23","id":128368828,"number":23,"title":"pyejabberd 0.3.0?","user":{"login":"encodeltd","id":4674902,"avatar_url":"https://avatars.githubusercontent.com/u/4674902?v=3","gravatar_id":"","url":"https://api.github.com/users/encodeltd","html_url":"https://github.com/encodeltd","followers_url":"https://api.github.com/users/encodeltd/followers","following_url":"https://api.github.com/users/encodeltd/following{/other_user}","gists_url":"https://api.github.com/users/encodeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/encodeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/encodeltd/subscriptions","organizations_url":"https://api.github.com/users/encodeltd/orgs","repos_url":"https://api.github.com/users/encodeltd/repos","events_url":"https://api.github.com/users/encodeltd/events{/privacy}","received_events_url":"https://api.github.com/users/encodeltd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-01-24T03:06:17Z","updated_at":"2016-03-22T21:20:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dirkmoors/pyejabberd/pulls/23","html_url":"https://github.com/dirkmoors/pyejabberd/pull/23","diff_url":"https://github.com/dirkmoors/pyejabberd/pull/23.diff","patch_url":"https://github.com/dirkmoors/pyejabberd/pull/23.patch"},"body":"`pyejabberd` up to version `0.2.10` is only compatible with `Ejabberd` up to version `15.07`.\r\n\r\n`Ejabberd 15.09` introduced OAuth 2.0 support which also changed a) arguments of some of the commands and b) access to admin commands.\r\n\r\nThis pull requests:\r\n\r\n- fixes auth call of `EjabberdAPIClient` by adding `'admin': True` to auth method since the admin calls must be explicitly marked as admin from 15.09 onwards. See https://github.com/processone/ejabberd/issues/845#issuecomment-165105417 (+ the rest of the thread of ticket #845).\r\n\r\n- adds new `check_account` API call.\r\n\r\n- fixes `get_roster` API call. From `Ejabberd 15.09` parameter `host` changed to `server`(!)\r\n\r\n- since the changes are backwards incompatible, testing was updated from versions 15.06, 15.07 to versions 15.09, 15.10, 15.11 and 16.01\r\n"},"comment":{"url":"https://api.github.com/repos/dirkmoors/pyejabberd/issues/comments/200035235","html_url":"https://github.com/dirkmoors/pyejabberd/pull/23#issuecomment-200035235","issue_url":"https://api.github.com/repos/dirkmoors/pyejabberd/issues/23","id":200035235,"user":{"login":"encodeltd","id":4674902,"avatar_url":"https://avatars.githubusercontent.com/u/4674902?v=3","gravatar_id":"","url":"https://api.github.com/users/encodeltd","html_url":"https://github.com/encodeltd","followers_url":"https://api.github.com/users/encodeltd/followers","following_url":"https://api.github.com/users/encodeltd/following{/other_user}","gists_url":"https://api.github.com/users/encodeltd/gists{/gist_id}","starred_url":"https://api.github.com/users/encodeltd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/encodeltd/subscriptions","organizations_url":"https://api.github.com/users/encodeltd/orgs","repos_url":"https://api.github.com/users/encodeltd/repos","events_url":"https://api.github.com/users/encodeltd/events{/privacy}","received_events_url":"https://api.github.com/users/encodeltd/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T21:20:49Z","updated_at":"2016-03-22T21:20:49Z","body":"hey Dirk,\r\n\r\nThat's correct, `get_room_options` is broken in `Ejabberd 16.01` and `16.02`. \r\n\r\nFor further details see https://github.com/processone/ejabberd/issues/982\r\n\r\nIt would be good to discuss what sort of strategy we should apply to all these issues that affect some of the previous releases.\r\n\r\nThe simplest way to tackle it is simply to test against the latest `Ejabberd` version. Ie. `get_room_options` fix for the ticket I reported to `Ejabberd` will be released in `Ejabberd 16.03`\r\n\r\nI was thinking to start a new documentation page \"known issues\" where all these cases would be noted so everyone would know what to expect.\r\n\r\nNot sure how we could handle these exceptions in the testing suite though. If there is a way to pass `Ejabberd` version to the testing suite we could adjust the tests so they would work as expected and we could also cover these exceptions in the tests.\r\n\r\nHope that makes sense.\r\n\r\nLet me know what do you think.\r\n\r\n--Marek"}}