{"action":"opened","number":5338,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5338","id":90036271,"html_url":"https://github.com/puppetlabs/puppet/pull/5338","diff_url":"https://github.com/puppetlabs/puppet/pull/5338.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5338.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5338","number":5338,"state":"open","locked":false,"title":"(PUP-1476) Include puppet and ruby versions in User-Agent","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"Previously, puppet did not specify an HTTP User-Agent string, so ruby\r\nwould send the default \"Ruby\". This made it difficult to debug and\r\ninterpret server-side logs when different versions of puppet agents\r\nconnect.\r\n\r\nThis commit adds a puppet setting `http_user_agent` which includes the\r\npuppet and ruby versions. The default value is of the form:\r\n\r\n    Puppet/4.7.0 Ruby/2.1.8-p440 (x86_64-darwin15.0)\r\n\r\nThe string is exposed as a setting for cases where puppet is being used\r\nas a library, and the enclosing application may need to override that.\r\n\r\nPuppet's HTTP connection code will send the User-Agent header with the\r\nabove value for all requests. The value is taken from the Puppet Module\r\nTool code. However, the strings are not exactly the same, because the\r\nPMT prefixes the string with additional information:\r\n\r\n    PMT/1.1.1 (v3; Net::HTTP) Puppet/4.7.0 Ruby/2.1.8-p440 (x86_64-darwin15.0)","created_at":"2016-10-19T15:42:24Z","updated_at":"2016-10-19T15:42:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97e099708b603f754b393312cc66a50f4094e1b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5338/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5338/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5338/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/92b6f21ec16a4d85d3bf50fdae26e15e40adf6ba","head":{"label":"joshcooper:ticket/master/PUP-1476-puppet-user-agent","ref":"ticket/master/PUP-1476-puppet-user-agent","sha":"92b6f21ec16a4d85d3bf50fdae26e15e40adf6ba","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"repo":{"id":1632836,"name":"puppet","full_name":"joshcooper/puppet","owner":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joshcooper/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/joshcooper/puppet","forks_url":"https://api.github.com/repos/joshcooper/puppet/forks","keys_url":"https://api.github.com/repos/joshcooper/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshcooper/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshcooper/puppet/teams","hooks_url":"https://api.github.com/repos/joshcooper/puppet/hooks","issue_events_url":"https://api.github.com/repos/joshcooper/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/joshcooper/puppet/events","assignees_url":"https://api.github.com/repos/joshcooper/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/joshcooper/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/joshcooper/puppet/tags","blobs_url":"https://api.github.com/repos/joshcooper/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshcooper/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshcooper/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshcooper/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshcooper/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/joshcooper/puppet/languages","stargazers_url":"https://api.github.com/repos/joshcooper/puppet/stargazers","contributors_url":"https://api.github.com/repos/joshcooper/puppet/contributors","subscribers_url":"https://api.github.com/repos/joshcooper/puppet/subscribers","subscription_url":"https://api.github.com/repos/joshcooper/puppet/subscription","commits_url":"https://api.github.com/repos/joshcooper/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshcooper/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshcooper/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshcooper/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshcooper/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/joshcooper/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshcooper/puppet/merges","archive_url":"https://api.github.com/repos/joshcooper/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshcooper/puppet/downloads","issues_url":"https://api.github.com/repos/joshcooper/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/joshcooper/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/joshcooper/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/joshcooper/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshcooper/puppet/labels{/name}","releases_url":"https://api.github.com/repos/joshcooper/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/joshcooper/puppet/deployments","created_at":"2011-04-18T21:50:21Z","updated_at":"2015-04-16T23:10:15Z","pushed_at":"2016-10-19T15:42:10Z","git_url":"git://github.com/joshcooper/puppet.git","ssh_url":"git@github.com:joshcooper/puppet.git","clone_url":"https://github.com/joshcooper/puppet.git","svn_url":"https://github.com/joshcooper/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":51604,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"5fb5e2deacb6043d2417e2d9acb4ebe78547f971","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2016-10-19T15:30:40Z","pushed_at":"2016-10-19T15:42:24Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":83227,"stargazers_count":4200,"watchers_count":4200,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1725,"mirror_url":null,"open_issues_count":61,"forks":1725,"open_issues":61,"watchers":4200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5338"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5338"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5338"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5338/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5338/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5338/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/92b6f21ec16a4d85d3bf50fdae26e15e40adf6ba"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"joshcooper"}}