{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/7486","repository_url":"https://api.github.com/repos/Microsoft/TypeScript","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/7486/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/7486/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/7486/events","html_url":"https://github.com/Microsoft/TypeScript/pull/7486","id":140321334,"number":7486,"title":"Add upper limit for the program size to prevent tsserver from crashing","user":{"login":"zhengbli","id":1171301,"avatar_url":"https://avatars.githubusercontent.com/u/1171301?v=3","gravatar_id":"","url":"https://api.github.com/users/zhengbli","html_url":"https://github.com/zhengbli","followers_url":"https://api.github.com/users/zhengbli/followers","following_url":"https://api.github.com/users/zhengbli/following{/other_user}","gists_url":"https://api.github.com/users/zhengbli/gists{/gist_id}","starred_url":"https://api.github.com/users/zhengbli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhengbli/subscriptions","organizations_url":"https://api.github.com/users/zhengbli/orgs","repos_url":"https://api.github.com/users/zhengbli/repos","events_url":"https://api.github.com/users/zhengbli/events{/privacy}","received_events_url":"https://api.github.com/users/zhengbli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/TypeScript/labels/cla-not-required","name":"cla-not-required","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-11T23:59:28Z","updated_at":"2016-03-18T17:38:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/7486","html_url":"https://github.com/Microsoft/TypeScript/pull/7486","diff_url":"https://github.com/Microsoft/TypeScript/pull/7486.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/7486.patch"},"body":"<!--\r\nThank you for submitting a pull request!\r\n\r\nHere's a checklist you might find useful.\r\n[ ] There is an associated issue that is labelled\r\n  'Bug' or 'Accepting PRs' or is in the Community milestone\r\n[ ] Code is up-to-date with the `master` branch\r\n[ ] You've successfully run `jake runtests` locally\r\n[ ] You've signed the CLA\r\n[ ] There are new or updated unit tests validating the change\r\n\r\nRefer to CONTRIBUTING.MD for more details.\r\n  https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n\r\n\r\nFixes #7444 \r\nFor experimental purpose, the upper limit was set to 35 Mb (as suggested in https://github.com/Microsoft/TypeScript/issues/7444#issuecomment-194735638), which might be changed to a better value after further tests. \r\n\r\nPer our discussion in #7444, the next step is to add a compiler switch (something like disableSizeLimit) to disable this check for a project. Though I will do that after the current size-checking logic was reviewed. \r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/198465577","html_url":"https://github.com/Microsoft/TypeScript/pull/7486#issuecomment-198465577","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/7486","id":198465577,"user":{"login":"billti","id":993909,"avatar_url":"https://avatars.githubusercontent.com/u/993909?v=3","gravatar_id":"","url":"https://api.github.com/users/billti","html_url":"https://github.com/billti","followers_url":"https://api.github.com/users/billti/followers","following_url":"https://api.github.com/users/billti/following{/other_user}","gists_url":"https://api.github.com/users/billti/gists{/gist_id}","starred_url":"https://api.github.com/users/billti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billti/subscriptions","organizations_url":"https://api.github.com/users/billti/orgs","repos_url":"https://api.github.com/users/billti/repos","events_url":"https://api.github.com/users/billti/events{/privacy}","received_events_url":"https://api.github.com/users/billti/received_events","type":"User","site_admin":false},"created_at":"2016-03-18T17:38:14Z","updated_at":"2016-03-18T17:38:14Z","body":"Looks good at first read. We should add the same logic on the VS host side also to improve Salsa experience there."}}