{"action":"created","comment":{"url":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/comments/54389731","id":54389731,"diff_hunk":"@@ -344,6 +344,76 @@\n \t\t\t);\n \t\t</cfscript>\n \t</cffunction>\n+\t<cffunction name=\"batchEditField\" access=\"public\" returntype=\"void\" output=\"false\">\n+\t\t<cfargument name=\"event\"             type=\"any\"     required=\"true\" />\n+\t\t<cfargument name=\"rc\"                type=\"struct\"  required=\"true\" />\n+\t\t<cfargument name=\"prc\"               type=\"struct\"  required=\"true\" />\n+\t\t<cfscript>\n+\t\t\tvar objectName   = rc.object;\n+\t\t\tvar field        = rc.pickField ?: \"\";\n+\t\t\tfieldAttributes  = presideObjectService.getObjectProperty( objectName, field);\n+\t\t\tfieldType        = presideObjectService.getDefaultFormControlForPropertyAttributes( argumentCollection = \t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\tfieldAttributes);\n+\t\t\tformControl.name          = field;\n+\t\t\tformControl.label         = field;\n+\t\t\tformControl.maxlength     = fieldAttributes.maxlength ?: \"\";\n+\t\t\tformControl.minlength     = fieldAttributes.minlength ?: \"\";\n+\t\t\tformControl.object        = fieldAttributes.relatedto;\n+\t\t\tformControl.sourceObject  = fieldAttributes.relatedto;\n+\t\t\tformControl.relatedto     = fieldAttributes.relatedto;\n+\t\t\tformControl.type          = fieldType;\n+\t\t\tformControl.maxValue      = fieldAttributes.maxvalue  ?: \"\";\n+\t\t\tformControl.minValue      = fieldAttributes.minvalue  ?: \"\";\n+\t\t\trc.renderObject           = renderFormControl( argumentCollection = formControl );\n+\t\t\tif(fieldType == \"manyToManySelect\") {\n+\t\t\t\trc.renderSwitch           = renderFormControl( type  = \"select\",\n+\t\t\t\t\t\t\t\t\t\t\t\t\t\t\tname     = \"overwrite\",\n+\t\t\t\t\t\t\t\t\t\t\t\t\t\t\tlabel    = \"Multi Edit Behaviour\",\n+\t\t\t\t\t\t\t\t\t\t\t\t\t\t\tvalues   = [ \"append\", \"overwrite\" ], \n+\t\t\t\t\t\t\t\t\t\t\t\t\t\t\tlabels   = [ translateResource( uri=\"cms:datamanager.multiDataAppend.title\" ),\t   translateResource( uri=\"cms:datamanager.multiDataOverwrite.title\" ) \n+\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t\t  ] );\n+\t\t\t}\n+\t\t\t_addObjectNameBreadCrumb( event, objectName );\n+\t\t\tevent.addAdminBreadCrumb(\n+\t\t\t\t  title = translateResource( uri=\"cms:datamanager.editrecord.breadcrumb.title\" )\n+\t\t\t\t, link  = \"\"\n+\t\t\t);\n+\t\t\tevent.setView( view=\"/admin/datamanager/batchEditField\");\n+\t\t</cfscript>\n+\t</cffunction>\n+\n+\t<cffunction name=\"batchEditAction\" access=\"public\" returntype=\"void\" output=\"false\">\n+\t\t<cfargument name=\"event\"             type=\"any\"     required=\"true\" />\n+\t\t<cfargument name=\"rc\"                type=\"struct\"  required=\"true\" />\n+\t\t<cfargument name=\"prc\"               type=\"struct\"  required=\"true\" />\n+\t\t<cfscript>\n+\t\t\trc.updateValue           = rc[rc.updateField];","path":"system/handlers/admin/DataManager.cfc","position":66,"original_position":66,"commit_id":"8877d33493c7e300f17ee02fb60f1d494873a7f0","original_commit_id":"8877d33493c7e300f17ee02fb60f1d494873a7f0","user":{"login":"DominicWatson","id":471162,"avatar_url":"https://avatars.githubusercontent.com/u/471162?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicWatson","html_url":"https://github.com/DominicWatson","followers_url":"https://api.github.com/users/DominicWatson/followers","following_url":"https://api.github.com/users/DominicWatson/following{/other_user}","gists_url":"https://api.github.com/users/DominicWatson/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicWatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicWatson/subscriptions","organizations_url":"https://api.github.com/users/DominicWatson/orgs","repos_url":"https://api.github.com/users/DominicWatson/repos","events_url":"https://api.github.com/users/DominicWatson/events{/privacy}","received_events_url":"https://api.github.com/users/DominicWatson/received_events","type":"User","site_admin":false},"body":"Feedback on code block below:\r\n\r\n* `var` scope local variables\r\n* Do not use `rc` for variables that are calculated by code. `rc` should be reserved for user input only. Use either local `var` scope, for variables that are only needed within the function, or `prc` for variables that need to be accessed later in views, etc.\r\n* Do not assume variables exist, e.g. `rc.updateField`. Instead:\r\n\r\n```\r\nvar updateField = rc.updateField ?: \"\";\r\n// etc.\r\n```","created_at":"2016-02-29T10:07:47Z","updated_at":"2016-02-29T10:07:47Z","html_url":"https://github.com/pixl8/Preside-CMS/pull/115#discussion_r54389731","pull_request_url":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/comments/54389731"},"html":{"href":"https://github.com/pixl8/Preside-CMS/pull/115#discussion_r54389731"},"pull_request":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115","id":60487514,"html_url":"https://github.com/pixl8/Preside-CMS/pull/115","diff_url":"https://github.com/pixl8/Preside-CMS/pull/115.diff","patch_url":"https://github.com/pixl8/Preside-CMS/pull/115.patch","issue_url":"https://api.github.com/repos/pixl8/Preside-CMS/issues/115","number":115,"state":"open","locked":false,"title":"Feature presidecms 258","user":{"login":"cfmitrah","id":532401,"avatar_url":"https://avatars.githubusercontent.com/u/532401?v=3","gravatar_id":"","url":"https://api.github.com/users/cfmitrah","html_url":"https://github.com/cfmitrah","followers_url":"https://api.github.com/users/cfmitrah/followers","following_url":"https://api.github.com/users/cfmitrah/following{/other_user}","gists_url":"https://api.github.com/users/cfmitrah/gists{/gist_id}","starred_url":"https://api.github.com/users/cfmitrah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfmitrah/subscriptions","organizations_url":"https://api.github.com/users/cfmitrah/orgs","repos_url":"https://api.github.com/users/cfmitrah/repos","events_url":"https://api.github.com/users/cfmitrah/events{/privacy}","received_events_url":"https://api.github.com/users/cfmitrah/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-24T10:33:35Z","updated_at":"2016-02-29T10:07:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"965948ee8406e81ec35db503a7ad235467a332f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115/commits","review_comments_url":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115/comments","review_comment_url":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixl8/Preside-CMS/issues/115/comments","statuses_url":"https://api.github.com/repos/pixl8/Preside-CMS/statuses/8877d33493c7e300f17ee02fb60f1d494873a7f0","head":{"label":"MitrahSoft:feature_PRESIDECMS-258","ref":"feature_PRESIDECMS-258","sha":"8877d33493c7e300f17ee02fb60f1d494873a7f0","user":{"login":"MitrahSoft","id":1324381,"avatar_url":"https://avatars.githubusercontent.com/u/1324381?v=3","gravatar_id":"","url":"https://api.github.com/users/MitrahSoft","html_url":"https://github.com/MitrahSoft","followers_url":"https://api.github.com/users/MitrahSoft/followers","following_url":"https://api.github.com/users/MitrahSoft/following{/other_user}","gists_url":"https://api.github.com/users/MitrahSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/MitrahSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitrahSoft/subscriptions","organizations_url":"https://api.github.com/users/MitrahSoft/orgs","repos_url":"https://api.github.com/users/MitrahSoft/repos","events_url":"https://api.github.com/users/MitrahSoft/events{/privacy}","received_events_url":"https://api.github.com/users/MitrahSoft/received_events","type":"Organization","site_admin":false},"repo":{"id":45022573,"name":"Preside-CMS","full_name":"MitrahSoft/Preside-CMS","owner":{"login":"MitrahSoft","id":1324381,"avatar_url":"https://avatars.githubusercontent.com/u/1324381?v=3","gravatar_id":"","url":"https://api.github.com/users/MitrahSoft","html_url":"https://github.com/MitrahSoft","followers_url":"https://api.github.com/users/MitrahSoft/followers","following_url":"https://api.github.com/users/MitrahSoft/following{/other_user}","gists_url":"https://api.github.com/users/MitrahSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/MitrahSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MitrahSoft/subscriptions","organizations_url":"https://api.github.com/users/MitrahSoft/orgs","repos_url":"https://api.github.com/users/MitrahSoft/repos","events_url":"https://api.github.com/users/MitrahSoft/events{/privacy}","received_events_url":"https://api.github.com/users/MitrahSoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MitrahSoft/Preside-CMS","description":"Preside CMS is an open source CMS for the Railo language","fork":true,"url":"https://api.github.com/repos/MitrahSoft/Preside-CMS","forks_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/forks","keys_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/teams","hooks_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/hooks","issue_events_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/events","assignees_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/tags","blobs_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/languages","stargazers_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/stargazers","contributors_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/contributors","subscribers_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/subscribers","subscription_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/subscription","commits_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/merges","archive_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/downloads","issues_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/labels{/name}","releases_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/releases{/id}","deployments_url":"https://api.github.com/repos/MitrahSoft/Preside-CMS/deployments","created_at":"2015-10-27T06:54:01Z","updated_at":"2016-01-29T14:48:48Z","pushed_at":"2016-02-29T08:52:47Z","git_url":"git://github.com/MitrahSoft/Preside-CMS.git","ssh_url":"git@github.com:MitrahSoft/Preside-CMS.git","clone_url":"https://github.com/MitrahSoft/Preside-CMS.git","svn_url":"https://github.com/MitrahSoft/Preside-CMS","homepage":null,"size":41746,"stargazers_count":0,"watchers_count":0,"language":"ColdFusion","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"pixl8:stable","ref":"stable","sha":"884cce608ad1b01b53a534a7e0862e37704647e6","user":{"login":"pixl8","id":7523823,"avatar_url":"https://avatars.githubusercontent.com/u/7523823?v=3","gravatar_id":"","url":"https://api.github.com/users/pixl8","html_url":"https://github.com/pixl8","followers_url":"https://api.github.com/users/pixl8/followers","following_url":"https://api.github.com/users/pixl8/following{/other_user}","gists_url":"https://api.github.com/users/pixl8/gists{/gist_id}","starred_url":"https://api.github.com/users/pixl8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixl8/subscriptions","organizations_url":"https://api.github.com/users/pixl8/orgs","repos_url":"https://api.github.com/users/pixl8/repos","events_url":"https://api.github.com/users/pixl8/events{/privacy}","received_events_url":"https://api.github.com/users/pixl8/received_events","type":"Organization","site_admin":false},"repo":{"id":19508826,"name":"Preside-CMS","full_name":"pixl8/Preside-CMS","owner":{"login":"pixl8","id":7523823,"avatar_url":"https://avatars.githubusercontent.com/u/7523823?v=3","gravatar_id":"","url":"https://api.github.com/users/pixl8","html_url":"https://github.com/pixl8","followers_url":"https://api.github.com/users/pixl8/followers","following_url":"https://api.github.com/users/pixl8/following{/other_user}","gists_url":"https://api.github.com/users/pixl8/gists{/gist_id}","starred_url":"https://api.github.com/users/pixl8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixl8/subscriptions","organizations_url":"https://api.github.com/users/pixl8/orgs","repos_url":"https://api.github.com/users/pixl8/repos","events_url":"https://api.github.com/users/pixl8/events{/privacy}","received_events_url":"https://api.github.com/users/pixl8/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pixl8/Preside-CMS","description":"PresideCMS is an open source CMS for the Lucee Server built on the ColdBox MVC Framework. It is developed and maintained by Pixl8 Interactive.","fork":false,"url":"https://api.github.com/repos/pixl8/Preside-CMS","forks_url":"https://api.github.com/repos/pixl8/Preside-CMS/forks","keys_url":"https://api.github.com/repos/pixl8/Preside-CMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixl8/Preside-CMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixl8/Preside-CMS/teams","hooks_url":"https://api.github.com/repos/pixl8/Preside-CMS/hooks","issue_events_url":"https://api.github.com/repos/pixl8/Preside-CMS/issues/events{/number}","events_url":"https://api.github.com/repos/pixl8/Preside-CMS/events","assignees_url":"https://api.github.com/repos/pixl8/Preside-CMS/assignees{/user}","branches_url":"https://api.github.com/repos/pixl8/Preside-CMS/branches{/branch}","tags_url":"https://api.github.com/repos/pixl8/Preside-CMS/tags","blobs_url":"https://api.github.com/repos/pixl8/Preside-CMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixl8/Preside-CMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixl8/Preside-CMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixl8/Preside-CMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixl8/Preside-CMS/statuses/{sha}","languages_url":"https://api.github.com/repos/pixl8/Preside-CMS/languages","stargazers_url":"https://api.github.com/repos/pixl8/Preside-CMS/stargazers","contributors_url":"https://api.github.com/repos/pixl8/Preside-CMS/contributors","subscribers_url":"https://api.github.com/repos/pixl8/Preside-CMS/subscribers","subscription_url":"https://api.github.com/repos/pixl8/Preside-CMS/subscription","commits_url":"https://api.github.com/repos/pixl8/Preside-CMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixl8/Preside-CMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixl8/Preside-CMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixl8/Preside-CMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixl8/Preside-CMS/contents/{+path}","compare_url":"https://api.github.com/repos/pixl8/Preside-CMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixl8/Preside-CMS/merges","archive_url":"https://api.github.com/repos/pixl8/Preside-CMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixl8/Preside-CMS/downloads","issues_url":"https://api.github.com/repos/pixl8/Preside-CMS/issues{/number}","pulls_url":"https://api.github.com/repos/pixl8/Preside-CMS/pulls{/number}","milestones_url":"https://api.github.com/repos/pixl8/Preside-CMS/milestones{/number}","notifications_url":"https://api.github.com/repos/pixl8/Preside-CMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixl8/Preside-CMS/labels{/name}","releases_url":"https://api.github.com/repos/pixl8/Preside-CMS/releases{/id}","deployments_url":"https://api.github.com/repos/pixl8/Preside-CMS/deployments","created_at":"2014-05-06T20:03:52Z","updated_at":"2016-01-28T19:20:51Z","pushed_at":"2016-02-29T08:52:47Z","git_url":"git://github.com/pixl8/Preside-CMS.git","ssh_url":"git@github.com:pixl8/Preside-CMS.git","clone_url":"https://github.com/pixl8/Preside-CMS.git","svn_url":"https://github.com/pixl8/Preside-CMS","homepage":"","size":41730,"stargazers_count":14,"watchers_count":14,"language":"ColdFusion","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":3,"forks":22,"open_issues":3,"watchers":14,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115"},"html":{"href":"https://github.com/pixl8/Preside-CMS/pull/115"},"issue":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/issues/115"},"comments":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/pixl8/Preside-CMS/statuses/8877d33493c7e300f17ee02fb60f1d494873a7f0"}}}}