{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/50002482","id":50002482,"diff_hunk":"@@ -0,0 +1,47 @@\n+<?php\n+\n+/*\n+ * This file is part of the Sylius package.\n+ *\n+ * (c) Paweł Jędrzejewski\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Sylius\\Bundle\\CoreBundle\\Distributor;\n+\n+/**\n+ * @author Mateusz Zalewski <mateusz.zalewski@lakion.com>\n+ */\n+class TaxesDistributor implements TaxesDistributorInterface\n+{\n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function distribute($taxItems, $taxAmount)\n+    {\n+        if (!is_int($taxItems) || 1 > $taxItems) {","path":"src/Sylius/Bundle/CoreBundle/Distributor/TaxesDistributor.php","position":24,"original_position":24,"commit_id":"4e7700b14ff7933d0f00e8a7e64911f7405afbc5","original_commit_id":"4e7700b14ff7933d0f00e8a7e64911f7405afbc5","user":{"login":"pamil","id":1897953,"avatar_url":"https://avatars.githubusercontent.com/u/1897953?v=3","gravatar_id":"","url":"https://api.github.com/users/pamil","html_url":"https://github.com/pamil","followers_url":"https://api.github.com/users/pamil/followers","following_url":"https://api.github.com/users/pamil/following{/other_user}","gists_url":"https://api.github.com/users/pamil/gists{/gist_id}","starred_url":"https://api.github.com/users/pamil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pamil/subscriptions","organizations_url":"https://api.github.com/users/pamil/orgs","repos_url":"https://api.github.com/users/pamil/repos","events_url":"https://api.github.com/users/pamil/events{/privacy}","received_events_url":"https://api.github.com/users/pamil/received_events","type":"User","site_admin":false},"body":"We might extract it to a private method","created_at":"2016-01-18T14:16:11Z","updated_at":"2016-01-18T14:16:11Z","html_url":"https://github.com/Sylius/Sylius/pull/3907#discussion_r50002482","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3907","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/50002482"},"html":{"href":"https://github.com/Sylius/Sylius/pull/3907#discussion_r50002482"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3907"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/3907","id":56334151,"html_url":"https://github.com/Sylius/Sylius/pull/3907","diff_url":"https://github.com/Sylius/Sylius/pull/3907.diff","patch_url":"https://github.com/Sylius/Sylius/pull/3907.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/3907","number":3907,"state":"open","locked":false,"title":"[Core] Shipment taxes","user":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed tickets |\r\n| License       | MIT\r\n| Doc PR        |\r\n\r\nThis PR is based on https://github.com/Sylius/Sylius/pull/3868.\r\n\r\nHere there comes some next improvements with taxes ;) ``ShippingMethod`` becomes *taxable* so no we can apply some new taxes based on shipping fee. For now, taxes are applied on ``Order`` level. There are also two new services ``OrderUnitsTaxesApplicator`` and ``OrderShipmentTaxesApplicator`` (I think naming should be discussed), which are injected to main ``OrderTaxesApplicator``, to split taxes-application logic.","created_at":"2016-01-18T12:01:13Z","updated_at":"2016-01-18T14:16:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"723490cca747f77e994b07f7caf27d9ce042460b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3907/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/3907/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/3907/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/4e7700b14ff7933d0f00e8a7e64911f7405afbc5","head":{"label":"Zales0123:shipment-taxes","ref":"shipment-taxes","sha":"4e7700b14ff7933d0f00e8a7e64911f7405afbc5","user":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"repo":{"id":28911466,"name":"Sylius","full_name":"Zales0123/Sylius","owner":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zales0123/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/Zales0123/Sylius","forks_url":"https://api.github.com/repos/Zales0123/Sylius/forks","keys_url":"https://api.github.com/repos/Zales0123/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zales0123/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zales0123/Sylius/teams","hooks_url":"https://api.github.com/repos/Zales0123/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Zales0123/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Zales0123/Sylius/events","assignees_url":"https://api.github.com/repos/Zales0123/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Zales0123/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Zales0123/Sylius/tags","blobs_url":"https://api.github.com/repos/Zales0123/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zales0123/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zales0123/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zales0123/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zales0123/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Zales0123/Sylius/languages","stargazers_url":"https://api.github.com/repos/Zales0123/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Zales0123/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Zales0123/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Zales0123/Sylius/subscription","commits_url":"https://api.github.com/repos/Zales0123/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zales0123/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zales0123/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zales0123/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zales0123/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Zales0123/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zales0123/Sylius/merges","archive_url":"https://api.github.com/repos/Zales0123/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zales0123/Sylius/downloads","issues_url":"https://api.github.com/repos/Zales0123/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Zales0123/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Zales0123/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Zales0123/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zales0123/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Zales0123/Sylius/releases{/id}","created_at":"2015-01-07T11:20:44Z","updated_at":"2016-01-14T10:09:00Z","pushed_at":"2016-01-18T13:42:09Z","git_url":"git://github.com/Zales0123/Sylius.git","ssh_url":"git@github.com:Zales0123/Sylius.git","clone_url":"https://github.com/Zales0123/Sylius.git","svn_url":"https://github.com/Zales0123/Sylius","homepage":"Sylius.org","size":22576,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"74059b4a7c601e1dab5300425300c6e21021b6fd","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"Component-based and format-agnostic (JSON/XML/HTML) eCommerce framework on top of Symfony.","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-01-17T13:12:46Z","pushed_at":"2016-01-18T14:13:53Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":53219,"stargazers_count":2127,"watchers_count":2127,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":771,"mirror_url":null,"open_issues_count":494,"forks":771,"open_issues":494,"watchers":2127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3907"},"html":{"href":"https://github.com/Sylius/Sylius/pull/3907"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/3907"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/3907/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3907/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/3907/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/4e7700b14ff7933d0f00e8a7e64911f7405afbc5"}}}}