{"action":"created","issue":{"url":"https://api.github.com/repos/redfin/react-server/issues/46","repository_url":"https://api.github.com/repos/redfin/react-server","labels_url":"https://api.github.com/repos/redfin/react-server/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/redfin/react-server/issues/46/comments","events_url":"https://api.github.com/repos/redfin/react-server/issues/46/events","html_url":"https://github.com/redfin/react-server/pull/46","id":138557465,"number":46,"title":"Partial fix for #34. npm v2 now works as long as hot mode is disabled.","user":{"login":"aickin","id":44199,"avatar_url":"https://avatars.githubusercontent.com/u/44199?v=3","gravatar_id":"","url":"https://api.github.com/users/aickin","html_url":"https://github.com/aickin","followers_url":"https://api.github.com/users/aickin/followers","following_url":"https://api.github.com/users/aickin/following{/other_user}","gists_url":"https://api.github.com/users/aickin/gists{/gist_id}","starred_url":"https://api.github.com/users/aickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aickin/subscriptions","organizations_url":"https://api.github.com/users/aickin/orgs","repos_url":"https://api.github.com/users/aickin/repos","events_url":"https://api.github.com/users/aickin/events{/privacy}","received_events_url":"https://api.github.com/users/aickin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-04T19:04:20Z","updated_at":"2016-03-05T03:37:40Z","closed_at":"2016-03-05T03:37:40Z","pull_request":{"url":"https://api.github.com/repos/redfin/react-server/pulls/46","html_url":"https://github.com/redfin/react-server/pull/46","diff_url":"https://github.com/redfin/react-server/pull/46.diff","patch_url":"https://github.com/redfin/react-server/pull/46.patch"},"body":"This is a simple partial fix for #34, adding two libraries as peer dependencies for `react-server-cli`. In both npm 2 and npm 3, I was able to do the following:\r\n\r\n1. clone `example-reactserver`\r\n1. `npm install`\r\n1. (for npm 3 only) `npm install` any uninstalled peer dependencies.\r\n1. `./node_modules/react-server-cli/bin/react-server-cli --hot=false`\r\n1. open `localhost:3000`\r\n\r\nAnd things worked. Huzzah.\r\n\r\nI still have dependency work to do to make hot reload mode work with npm v2, so #34 should stay open.\r\n\r\n~~(Also, note that in order to get `example-reactserver` to serve up its page correctly, [this bug fix PR](https://github.com/doug-wade/example-reactserver/pull/1) needs to be pulled.)~~ (PR was merged.)"},"comment":{"url":"https://api.github.com/repos/redfin/react-server/issues/comments/192562243","html_url":"https://github.com/redfin/react-server/pull/46#issuecomment-192562243","issue_url":"https://api.github.com/repos/redfin/react-server/issues/46","id":192562243,"user":{"login":"aickin","id":44199,"avatar_url":"https://avatars.githubusercontent.com/u/44199?v=3","gravatar_id":"","url":"https://api.github.com/users/aickin","html_url":"https://github.com/aickin","followers_url":"https://api.github.com/users/aickin/followers","following_url":"https://api.github.com/users/aickin/following{/other_user}","gists_url":"https://api.github.com/users/aickin/gists{/gist_id}","starred_url":"https://api.github.com/users/aickin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aickin/subscriptions","organizations_url":"https://api.github.com/users/aickin/orgs","repos_url":"https://api.github.com/users/aickin/repos","events_url":"https://api.github.com/users/aickin/events{/privacy}","received_events_url":"https://api.github.com/users/aickin/received_events","type":"User","site_admin":false},"created_at":"2016-03-05T03:37:40Z","updated_at":"2016-03-05T03:37:40Z","body":"I found a better way to do this that fixes both hot and non-hot mode, so I'm going to close this PR to make it clearer."}}