{"action":"closed","number":995,"pull_request":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/995","id":85610173,"html_url":"https://github.com/superdesk/superdesk-client-core/pull/995","diff_url":"https://github.com/superdesk/superdesk-client-core/pull/995.diff","patch_url":"https://github.com/superdesk/superdesk-client-core/pull/995.patch","issue_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/995","number":995,"state":"closed","locked":false,"title":"Auto-load external Angular modules using config","user":{"login":"gbbr","id":6686356,"avatar_url":"https://avatars.githubusercontent.com/u/6686356?v=3","gravatar_id":"","url":"https://api.github.com/users/gbbr","html_url":"https://github.com/gbbr","followers_url":"https://api.github.com/users/gbbr/followers","following_url":"https://api.github.com/users/gbbr/following{/other_user}","gists_url":"https://api.github.com/users/gbbr/gists{/gist_id}","starred_url":"https://api.github.com/users/gbbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbbr/subscriptions","organizations_url":"https://api.github.com/users/gbbr/orgs","repos_url":"https://api.github.com/users/gbbr/repos","events_url":"https://api.github.com/users/gbbr/events{/privacy}","received_events_url":"https://api.github.com/users/gbbr/received_events","type":"User","site_admin":false},"body":"Enables telling superdesk to load external resources via configuration. In `superdesk.config.js`, adding:\r\n```js\r\napps: ['superdesk-planning', 'my-app']\r\n```\r\nwill cause the client to include `node_modules/superdesk-planning` and `node_modules/my-app` into the compilation, as well as load all exported Angular modules into superdesk. \r\n\r\n--\r\nAll that external apps need to do is export an Angular module that is the entry point as default. ie:\r\n\r\n```js\r\nexport default angular.module('my.superdesk.app', []);\r\n```\r\n--\r\n### TODO\r\n\r\n- [x] Allow importing `npm` modules by config\r\n- [x] Write documentation","created_at":"2016-09-16T17:27:43Z","updated_at":"2016-10-07T08:43:43Z","closed_at":"2016-10-07T08:43:43Z","merged_at":"2016-10-07T08:43:43Z","merge_commit_sha":"e780d4f85219cfa14f66466c66dda69adb38fede","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones/5","html_url":"https://github.com/superdesk/superdesk-client-core/milestones/1.4","labels_url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones/5/labels","id":1998595,"number":5,"title":"1.4","description":"","creator":{"login":"petrjasek","id":179249,"avatar_url":"https://avatars.githubusercontent.com/u/179249?v=3","gravatar_id":"","url":"https://api.github.com/users/petrjasek","html_url":"https://github.com/petrjasek","followers_url":"https://api.github.com/users/petrjasek/followers","following_url":"https://api.github.com/users/petrjasek/following{/other_user}","gists_url":"https://api.github.com/users/petrjasek/gists{/gist_id}","starred_url":"https://api.github.com/users/petrjasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrjasek/subscriptions","organizations_url":"https://api.github.com/users/petrjasek/orgs","repos_url":"https://api.github.com/users/petrjasek/repos","events_url":"https://api.github.com/users/petrjasek/events{/privacy}","received_events_url":"https://api.github.com/users/petrjasek/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2016-09-12T14:54:29Z","updated_at":"2016-10-07T08:43:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/995/commits","review_comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/995/comments","review_comment_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/995/comments","statuses_url":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/8621d89460663ffa8f7231929cbd9b4b285b1667","head":{"label":"gbbr:plugin-npm2","ref":"plugin-npm2","sha":"8621d89460663ffa8f7231929cbd9b4b285b1667","user":{"login":"gbbr","id":6686356,"avatar_url":"https://avatars.githubusercontent.com/u/6686356?v=3","gravatar_id":"","url":"https://api.github.com/users/gbbr","html_url":"https://github.com/gbbr","followers_url":"https://api.github.com/users/gbbr/followers","following_url":"https://api.github.com/users/gbbr/following{/other_user}","gists_url":"https://api.github.com/users/gbbr/gists{/gist_id}","starred_url":"https://api.github.com/users/gbbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbbr/subscriptions","organizations_url":"https://api.github.com/users/gbbr/orgs","repos_url":"https://api.github.com/users/gbbr/repos","events_url":"https://api.github.com/users/gbbr/events{/privacy}","received_events_url":"https://api.github.com/users/gbbr/received_events","type":"User","site_admin":false},"repo":{"id":57036386,"name":"superdesk-client-core","full_name":"gbbr/superdesk-client-core","owner":{"login":"gbbr","id":6686356,"avatar_url":"https://avatars.githubusercontent.com/u/6686356?v=3","gravatar_id":"","url":"https://api.github.com/users/gbbr","html_url":"https://github.com/gbbr","followers_url":"https://api.github.com/users/gbbr/followers","following_url":"https://api.github.com/users/gbbr/following{/other_user}","gists_url":"https://api.github.com/users/gbbr/gists{/gist_id}","starred_url":"https://api.github.com/users/gbbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbbr/subscriptions","organizations_url":"https://api.github.com/users/gbbr/orgs","repos_url":"https://api.github.com/users/gbbr/repos","events_url":"https://api.github.com/users/gbbr/events{/privacy}","received_events_url":"https://api.github.com/users/gbbr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbbr/superdesk-client-core","description":"Common client modules for superdesk apps.","fork":true,"url":"https://api.github.com/repos/gbbr/superdesk-client-core","forks_url":"https://api.github.com/repos/gbbr/superdesk-client-core/forks","keys_url":"https://api.github.com/repos/gbbr/superdesk-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbbr/superdesk-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbbr/superdesk-client-core/teams","hooks_url":"https://api.github.com/repos/gbbr/superdesk-client-core/hooks","issue_events_url":"https://api.github.com/repos/gbbr/superdesk-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/gbbr/superdesk-client-core/events","assignees_url":"https://api.github.com/repos/gbbr/superdesk-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/gbbr/superdesk-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/gbbr/superdesk-client-core/tags","blobs_url":"https://api.github.com/repos/gbbr/superdesk-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbbr/superdesk-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbbr/superdesk-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbbr/superdesk-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbbr/superdesk-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/gbbr/superdesk-client-core/languages","stargazers_url":"https://api.github.com/repos/gbbr/superdesk-client-core/stargazers","contributors_url":"https://api.github.com/repos/gbbr/superdesk-client-core/contributors","subscribers_url":"https://api.github.com/repos/gbbr/superdesk-client-core/subscribers","subscription_url":"https://api.github.com/repos/gbbr/superdesk-client-core/subscription","commits_url":"https://api.github.com/repos/gbbr/superdesk-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbbr/superdesk-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbbr/superdesk-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbbr/superdesk-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbbr/superdesk-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/gbbr/superdesk-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbbr/superdesk-client-core/merges","archive_url":"https://api.github.com/repos/gbbr/superdesk-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbbr/superdesk-client-core/downloads","issues_url":"https://api.github.com/repos/gbbr/superdesk-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/gbbr/superdesk-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/gbbr/superdesk-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/gbbr/superdesk-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbbr/superdesk-client-core/labels{/name}","releases_url":"https://api.github.com/repos/gbbr/superdesk-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/gbbr/superdesk-client-core/deployments","created_at":"2016-04-25T11:28:25Z","updated_at":"2016-04-25T11:28:27Z","pushed_at":"2016-10-07T08:03:41Z","git_url":"git://github.com/gbbr/superdesk-client-core.git","ssh_url":"git@github.com:gbbr/superdesk-client-core.git","clone_url":"https://github.com/gbbr/superdesk-client-core.git","svn_url":"https://github.com/gbbr/superdesk-client-core","homepage":"","size":7293,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superdesk:master","ref":"master","sha":"9d07f6e5d449bfbaff8fce0a65587ee037a4fa16","user":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"repo":{"id":50631400,"name":"superdesk-client-core","full_name":"superdesk/superdesk-client-core","owner":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superdesk/superdesk-client-core","description":"Common client modules for superdesk apps.","fork":false,"url":"https://api.github.com/repos/superdesk/superdesk-client-core","forks_url":"https://api.github.com/repos/superdesk/superdesk-client-core/forks","keys_url":"https://api.github.com/repos/superdesk/superdesk-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdesk/superdesk-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdesk/superdesk-client-core/teams","hooks_url":"https://api.github.com/repos/superdesk/superdesk-client-core/hooks","issue_events_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/superdesk/superdesk-client-core/events","assignees_url":"https://api.github.com/repos/superdesk/superdesk-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/superdesk/superdesk-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/superdesk/superdesk-client-core/tags","blobs_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/superdesk/superdesk-client-core/languages","stargazers_url":"https://api.github.com/repos/superdesk/superdesk-client-core/stargazers","contributors_url":"https://api.github.com/repos/superdesk/superdesk-client-core/contributors","subscribers_url":"https://api.github.com/repos/superdesk/superdesk-client-core/subscribers","subscription_url":"https://api.github.com/repos/superdesk/superdesk-client-core/subscription","commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdesk/superdesk-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdesk/superdesk-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/superdesk/superdesk-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdesk/superdesk-client-core/merges","archive_url":"https://api.github.com/repos/superdesk/superdesk-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdesk/superdesk-client-core/downloads","issues_url":"https://api.github.com/repos/superdesk/superdesk-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/superdesk/superdesk-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/superdesk/superdesk-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdesk/superdesk-client-core/labels{/name}","releases_url":"https://api.github.com/repos/superdesk/superdesk-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/superdesk/superdesk-client-core/deployments","created_at":"2016-01-29T02:33:16Z","updated_at":"2016-10-05T13:04:21Z","pushed_at":"2016-10-07T08:43:43Z","git_url":"git://github.com/superdesk/superdesk-client-core.git","ssh_url":"git@github.com:superdesk/superdesk-client-core.git","clone_url":"https://github.com/superdesk/superdesk-client-core.git","svn_url":"https://github.com/superdesk/superdesk-client-core","homepage":"","size":7899,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":13,"forks":31,"open_issues":13,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/995"},"html":{"href":"https://github.com/superdesk/superdesk-client-core/pull/995"},"issue":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/995"},"comments":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/issues/995/comments"},"review_comments":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/995/comments"},"review_comment":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/pulls/995/commits"},"statuses":{"href":"https://api.github.com/repos/superdesk/superdesk-client-core/statuses/8621d89460663ffa8f7231929cbd9b4b285b1667"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gbbr","id":6686356,"avatar_url":"https://avatars.githubusercontent.com/u/6686356?v=3","gravatar_id":"","url":"https://api.github.com/users/gbbr","html_url":"https://github.com/gbbr","followers_url":"https://api.github.com/users/gbbr/followers","following_url":"https://api.github.com/users/gbbr/following{/other_user}","gists_url":"https://api.github.com/users/gbbr/gists{/gist_id}","starred_url":"https://api.github.com/users/gbbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbbr/subscriptions","organizations_url":"https://api.github.com/users/gbbr/orgs","repos_url":"https://api.github.com/users/gbbr/repos","events_url":"https://api.github.com/users/gbbr/events{/privacy}","received_events_url":"https://api.github.com/users/gbbr/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":46,"deletions":9,"changed_files":5}}
{"actor":{"display_login":"gbbr"}}