{"action":"created","comment":{"url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/comments/78772146","id":78772146,"diff_hunk":"@@ -201,7 +201,10 @@ bool TheThingsNetwork::enableFsbChannels(int fsb) {\n   return true;\n }\n \n-bool TheThingsNetwork::personalize(const byte devAddr[4], const byte nwkSKey[16], const byte appSKey[16]) {\n+bool TheThingsNetwork::personalize(const byte devAddr[4], const byte nwkSKey[16], const byte appSKey[16], bool reset) {\n+  \n+  if (reset == true)\n+    TheThingsNetwork::reset();","path":"src/TheThingsNetwork.cpp","position":8,"original_position":8,"commit_id":"7a042156f63aadb297d9d78a3c1d21c8f340db5e","original_commit_id":"7a042156f63aadb297d9d78a3c1d21c8f340db5e","user":{"login":"johanstokking","id":13334001,"avatar_url":"https://avatars.githubusercontent.com/u/13334001?v=3","gravatar_id":"","url":"https://api.github.com/users/johanstokking","html_url":"https://github.com/johanstokking","followers_url":"https://api.github.com/users/johanstokking/followers","following_url":"https://api.github.com/users/johanstokking/following{/other_user}","gists_url":"https://api.github.com/users/johanstokking/gists{/gist_id}","starred_url":"https://api.github.com/users/johanstokking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanstokking/subscriptions","organizations_url":"https://api.github.com/users/johanstokking/orgs","repos_url":"https://api.github.com/users/johanstokking/repos","events_url":"https://api.github.com/users/johanstokking/events{/privacy}","received_events_url":"https://api.github.com/users/johanstokking/received_events","type":"User","site_admin":false},"body":"```\r\nif reset() {\r\n  reset();\r\n}\r\n```","created_at":"2016-09-14T15:26:50Z","updated_at":"2016-09-14T15:26:50Z","html_url":"https://github.com/TheThingsNetwork/arduino-device-lib/pull/42#discussion_r78772146","pull_request_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/comments/78772146"},"html":{"href":"https://github.com/TheThingsNetwork/arduino-device-lib/pull/42#discussion_r78772146"},"pull_request":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42","id":85237908,"html_url":"https://github.com/TheThingsNetwork/arduino-device-lib/pull/42","diff_url":"https://github.com/TheThingsNetwork/arduino-device-lib/pull/42.diff","patch_url":"https://github.com/TheThingsNetwork/arduino-device-lib/pull/42.patch","issue_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/42","number":42,"state":"open","locked":false,"title":"called reset() in personalize()","user":{"login":"Nicolasdejean","id":20477842,"avatar_url":"https://avatars.githubusercontent.com/u/20477842?v=3","gravatar_id":"","url":"https://api.github.com/users/Nicolasdejean","html_url":"https://github.com/Nicolasdejean","followers_url":"https://api.github.com/users/Nicolasdejean/followers","following_url":"https://api.github.com/users/Nicolasdejean/following{/other_user}","gists_url":"https://api.github.com/users/Nicolasdejean/gists{/gist_id}","starred_url":"https://api.github.com/users/Nicolasdejean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nicolasdejean/subscriptions","organizations_url":"https://api.github.com/users/Nicolasdejean/orgs","repos_url":"https://api.github.com/users/Nicolasdejean/repos","events_url":"https://api.github.com/users/Nicolasdejean/events{/privacy}","received_events_url":"https://api.github.com/users/Nicolasdejean/received_events","type":"User","site_admin":false},"body":"Added a bool in parameter: true does a reset, false doesn't.#6","created_at":"2016-09-14T14:26:37Z","updated_at":"2016-09-14T15:26:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"969da817619260dd275b90c024c33bffe3f2f6cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42/commits","review_comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42/comments","review_comment_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/42/comments","statuses_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/statuses/7a042156f63aadb297d9d78a3c1d21c8f340db5e","head":{"label":"TheThingsNetwork:personalize","ref":"personalize","sha":"7a042156f63aadb297d9d78a3c1d21c8f340db5e","user":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":65997719,"name":"arduino-device-lib","full_name":"TheThingsNetwork/arduino-device-lib","owner":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheThingsNetwork/arduino-device-lib","description":"Arduino Library for TTN Devices","fork":false,"url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib","forks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/forks","keys_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/teams","hooks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/hooks","issue_events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/events{/number}","events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/events","assignees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/assignees{/user}","branches_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/branches{/branch}","tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/tags","blobs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/languages","stargazers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/stargazers","contributors_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/contributors","subscribers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/subscribers","subscription_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/subscription","commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/contents/{+path}","compare_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/merges","archive_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/downloads","issues_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues{/number}","pulls_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/labels{/name}","releases_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/releases{/id}","deployments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/deployments","created_at":"2016-08-18T13:04:36Z","updated_at":"2016-09-13T08:33:40Z","pushed_at":"2016-09-14T14:26:37Z","git_url":"git://github.com/TheThingsNetwork/arduino-device-lib.git","ssh_url":"git@github.com:TheThingsNetwork/arduino-device-lib.git","clone_url":"https://github.com/TheThingsNetwork/arduino-device-lib.git","svn_url":"https://github.com/TheThingsNetwork/arduino-device-lib","homepage":"","size":63,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":27,"forks":2,"open_issues":27,"watchers":2,"default_branch":"master"}},"base":{"label":"TheThingsNetwork:master","ref":"master","sha":"c70d4f8af01893c8565836528a1eb32fed7edcd3","user":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":65997719,"name":"arduino-device-lib","full_name":"TheThingsNetwork/arduino-device-lib","owner":{"login":"TheThingsNetwork","id":13333576,"avatar_url":"https://avatars.githubusercontent.com/u/13333576?v=3","gravatar_id":"","url":"https://api.github.com/users/TheThingsNetwork","html_url":"https://github.com/TheThingsNetwork","followers_url":"https://api.github.com/users/TheThingsNetwork/followers","following_url":"https://api.github.com/users/TheThingsNetwork/following{/other_user}","gists_url":"https://api.github.com/users/TheThingsNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/TheThingsNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheThingsNetwork/subscriptions","organizations_url":"https://api.github.com/users/TheThingsNetwork/orgs","repos_url":"https://api.github.com/users/TheThingsNetwork/repos","events_url":"https://api.github.com/users/TheThingsNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/TheThingsNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheThingsNetwork/arduino-device-lib","description":"Arduino Library for TTN Devices","fork":false,"url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib","forks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/forks","keys_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/teams","hooks_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/hooks","issue_events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/events{/number}","events_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/events","assignees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/assignees{/user}","branches_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/branches{/branch}","tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/tags","blobs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/languages","stargazers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/stargazers","contributors_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/contributors","subscribers_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/subscribers","subscription_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/subscription","commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/contents/{+path}","compare_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/merges","archive_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/downloads","issues_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues{/number}","pulls_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/labels{/name}","releases_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/releases{/id}","deployments_url":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/deployments","created_at":"2016-08-18T13:04:36Z","updated_at":"2016-09-13T08:33:40Z","pushed_at":"2016-09-14T14:26:37Z","git_url":"git://github.com/TheThingsNetwork/arduino-device-lib.git","ssh_url":"git@github.com:TheThingsNetwork/arduino-device-lib.git","clone_url":"https://github.com/TheThingsNetwork/arduino-device-lib.git","svn_url":"https://github.com/TheThingsNetwork/arduino-device-lib","homepage":"","size":63,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":27,"forks":2,"open_issues":27,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42"},"html":{"href":"https://github.com/TheThingsNetwork/arduino-device-lib/pull/42"},"issue":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/42"},"comments":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/TheThingsNetwork/arduino-device-lib/statuses/7a042156f63aadb297d9d78a3c1d21c8f340db5e"}}}}
{"actor":{"display_login":"johanstokking"}}