{"action":"created","comment":{"url":"https://api.github.com/repos/WASdev/tool.lars/pulls/comments/83179842","pull_request_review_id":4037591,"id":83179842,"diff_hunk":"@@ -1202,6 +1206,81 @@ public void test500Mapping() throws InvalidJsonAssetException, ParseException, I\n         mongoClient.close();\n     }\n \n+    @Test\n+    public void testRuntimeException() throws ClientProtocolException, IOException {","path":"server/src/fat/java/com/ibm/ws/lars/rest/ApiTest.java","position":23,"original_position":23,"commit_id":"51874011e93cf92ee5ee8b74328a579bca4cf06b","original_commit_id":"f1508599b39cc7769574e09947c6594cbcdb0148","user":{"login":"idlewis","id":10975900,"avatar_url":"https://avatars.githubusercontent.com/u/10975900?v=3","gravatar_id":"","url":"https://api.github.com/users/idlewis","html_url":"https://github.com/idlewis","followers_url":"https://api.github.com/users/idlewis/followers","following_url":"https://api.github.com/users/idlewis/following{/other_user}","gists_url":"https://api.github.com/users/idlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/idlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idlewis/subscriptions","organizations_url":"https://api.github.com/users/idlewis/orgs","repos_url":"https://api.github.com/users/idlewis/repos","events_url":"https://api.github.com/users/idlewis/events{/privacy}","received_events_url":"https://api.github.com/users/idlewis/received_events","type":"User","site_admin":false},"body":"Might be nice to have a comment in here to say where we are expecting the error to come from, i.e. this test is testing the error servlet, but the one below is testing the exception mapper in jax-rs..? I think ..??","created_at":"2016-10-13T09:48:03Z","updated_at":"2016-10-13T09:48:03Z","html_url":"https://github.com/WASdev/tool.lars/pull/141#discussion_r83179842","pull_request_url":"https://api.github.com/repos/WASdev/tool.lars/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/WASdev/tool.lars/pulls/comments/83179842"},"html":{"href":"https://github.com/WASdev/tool.lars/pull/141#discussion_r83179842"},"pull_request":{"href":"https://api.github.com/repos/WASdev/tool.lars/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/WASdev/tool.lars/pulls/141","id":89044803,"html_url":"https://github.com/WASdev/tool.lars/pull/141","diff_url":"https://github.com/WASdev/tool.lars/pull/141.diff","patch_url":"https://github.com/WASdev/tool.lars/pull/141.patch","issue_url":"https://api.github.com/repos/WASdev/tool.lars/issues/141","number":141,"state":"open","locked":false,"title":"Improve exception handling","user":{"login":"Azquelt","id":2011102,"avatar_url":"https://avatars.githubusercontent.com/u/2011102?v=3","gravatar_id":"","url":"https://api.github.com/users/Azquelt","html_url":"https://github.com/Azquelt","followers_url":"https://api.github.com/users/Azquelt/followers","following_url":"https://api.github.com/users/Azquelt/following{/other_user}","gists_url":"https://api.github.com/users/Azquelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Azquelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azquelt/subscriptions","organizations_url":"https://api.github.com/users/Azquelt/orgs","repos_url":"https://api.github.com/users/Azquelt/repos","events_url":"https://api.github.com/users/Azquelt/events{/privacy}","received_events_url":"https://api.github.com/users/Azquelt/received_events","type":"User","site_admin":false},"body":"Avoid leaking information when an exception is propegated up to the App server\r\n\r\nAlso use the correct Content-type when returning JSON error messages.","created_at":"2016-10-12T16:04:10Z","updated_at":"2016-10-13T09:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cc0ad3c8a61a9baeaaec61879567f1e90a69b94","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WASdev/tool.lars/pulls/141/commits","review_comments_url":"https://api.github.com/repos/WASdev/tool.lars/pulls/141/comments","review_comment_url":"https://api.github.com/repos/WASdev/tool.lars/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WASdev/tool.lars/issues/141/comments","statuses_url":"https://api.github.com/repos/WASdev/tool.lars/statuses/51874011e93cf92ee5ee8b74328a579bca4cf06b","head":{"label":"Azquelt:exception-handling","ref":"exception-handling","sha":"51874011e93cf92ee5ee8b74328a579bca4cf06b","user":{"login":"Azquelt","id":2011102,"avatar_url":"https://avatars.githubusercontent.com/u/2011102?v=3","gravatar_id":"","url":"https://api.github.com/users/Azquelt","html_url":"https://github.com/Azquelt","followers_url":"https://api.github.com/users/Azquelt/followers","following_url":"https://api.github.com/users/Azquelt/following{/other_user}","gists_url":"https://api.github.com/users/Azquelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Azquelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azquelt/subscriptions","organizations_url":"https://api.github.com/users/Azquelt/orgs","repos_url":"https://api.github.com/users/Azquelt/repos","events_url":"https://api.github.com/users/Azquelt/events{/privacy}","received_events_url":"https://api.github.com/users/Azquelt/received_events","type":"User","site_admin":false},"repo":{"id":30973172,"name":"tool.lars","full_name":"Azquelt/tool.lars","owner":{"login":"Azquelt","id":2011102,"avatar_url":"https://avatars.githubusercontent.com/u/2011102?v=3","gravatar_id":"","url":"https://api.github.com/users/Azquelt","html_url":"https://github.com/Azquelt","followers_url":"https://api.github.com/users/Azquelt/followers","following_url":"https://api.github.com/users/Azquelt/following{/other_user}","gists_url":"https://api.github.com/users/Azquelt/gists{/gist_id}","starred_url":"https://api.github.com/users/Azquelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azquelt/subscriptions","organizations_url":"https://api.github.com/users/Azquelt/orgs","repos_url":"https://api.github.com/users/Azquelt/repos","events_url":"https://api.github.com/users/Azquelt/events{/privacy}","received_events_url":"https://api.github.com/users/Azquelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Azquelt/tool.lars","description":"The Liberty Asset Repository Service implements a repository for Liberty features that you can deploy locally","fork":true,"url":"https://api.github.com/repos/Azquelt/tool.lars","forks_url":"https://api.github.com/repos/Azquelt/tool.lars/forks","keys_url":"https://api.github.com/repos/Azquelt/tool.lars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azquelt/tool.lars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azquelt/tool.lars/teams","hooks_url":"https://api.github.com/repos/Azquelt/tool.lars/hooks","issue_events_url":"https://api.github.com/repos/Azquelt/tool.lars/issues/events{/number}","events_url":"https://api.github.com/repos/Azquelt/tool.lars/events","assignees_url":"https://api.github.com/repos/Azquelt/tool.lars/assignees{/user}","branches_url":"https://api.github.com/repos/Azquelt/tool.lars/branches{/branch}","tags_url":"https://api.github.com/repos/Azquelt/tool.lars/tags","blobs_url":"https://api.github.com/repos/Azquelt/tool.lars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azquelt/tool.lars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azquelt/tool.lars/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azquelt/tool.lars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azquelt/tool.lars/statuses/{sha}","languages_url":"https://api.github.com/repos/Azquelt/tool.lars/languages","stargazers_url":"https://api.github.com/repos/Azquelt/tool.lars/stargazers","contributors_url":"https://api.github.com/repos/Azquelt/tool.lars/contributors","subscribers_url":"https://api.github.com/repos/Azquelt/tool.lars/subscribers","subscription_url":"https://api.github.com/repos/Azquelt/tool.lars/subscription","commits_url":"https://api.github.com/repos/Azquelt/tool.lars/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azquelt/tool.lars/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azquelt/tool.lars/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azquelt/tool.lars/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azquelt/tool.lars/contents/{+path}","compare_url":"https://api.github.com/repos/Azquelt/tool.lars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azquelt/tool.lars/merges","archive_url":"https://api.github.com/repos/Azquelt/tool.lars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azquelt/tool.lars/downloads","issues_url":"https://api.github.com/repos/Azquelt/tool.lars/issues{/number}","pulls_url":"https://api.github.com/repos/Azquelt/tool.lars/pulls{/number}","milestones_url":"https://api.github.com/repos/Azquelt/tool.lars/milestones{/number}","notifications_url":"https://api.github.com/repos/Azquelt/tool.lars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azquelt/tool.lars/labels{/name}","releases_url":"https://api.github.com/repos/Azquelt/tool.lars/releases{/id}","deployments_url":"https://api.github.com/repos/Azquelt/tool.lars/deployments","created_at":"2015-02-18T16:08:15Z","updated_at":"2016-01-14T16:20:32Z","pushed_at":"2016-10-13T09:30:38Z","git_url":"git://github.com/Azquelt/tool.lars.git","ssh_url":"git@github.com:Azquelt/tool.lars.git","clone_url":"https://github.com/Azquelt/tool.lars.git","svn_url":"https://github.com/Azquelt/tool.lars","homepage":"","size":1597,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WASdev:master","ref":"master","sha":"a4d51efb90ad92966497e544f345083f3dc08ccd","user":{"login":"WASdev","id":4928521,"avatar_url":"https://avatars.githubusercontent.com/u/4928521?v=3","gravatar_id":"","url":"https://api.github.com/users/WASdev","html_url":"https://github.com/WASdev","followers_url":"https://api.github.com/users/WASdev/followers","following_url":"https://api.github.com/users/WASdev/following{/other_user}","gists_url":"https://api.github.com/users/WASdev/gists{/gist_id}","starred_url":"https://api.github.com/users/WASdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WASdev/subscriptions","organizations_url":"https://api.github.com/users/WASdev/orgs","repos_url":"https://api.github.com/users/WASdev/repos","events_url":"https://api.github.com/users/WASdev/events{/privacy}","received_events_url":"https://api.github.com/users/WASdev/received_events","type":"Organization","site_admin":false},"repo":{"id":30705823,"name":"tool.lars","full_name":"WASdev/tool.lars","owner":{"login":"WASdev","id":4928521,"avatar_url":"https://avatars.githubusercontent.com/u/4928521?v=3","gravatar_id":"","url":"https://api.github.com/users/WASdev","html_url":"https://github.com/WASdev","followers_url":"https://api.github.com/users/WASdev/followers","following_url":"https://api.github.com/users/WASdev/following{/other_user}","gists_url":"https://api.github.com/users/WASdev/gists{/gist_id}","starred_url":"https://api.github.com/users/WASdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WASdev/subscriptions","organizations_url":"https://api.github.com/users/WASdev/orgs","repos_url":"https://api.github.com/users/WASdev/repos","events_url":"https://api.github.com/users/WASdev/events{/privacy}","received_events_url":"https://api.github.com/users/WASdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WASdev/tool.lars","description":"The Liberty Asset Repository Service implements a repository for Liberty features that you can deploy locally","fork":false,"url":"https://api.github.com/repos/WASdev/tool.lars","forks_url":"https://api.github.com/repos/WASdev/tool.lars/forks","keys_url":"https://api.github.com/repos/WASdev/tool.lars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WASdev/tool.lars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WASdev/tool.lars/teams","hooks_url":"https://api.github.com/repos/WASdev/tool.lars/hooks","issue_events_url":"https://api.github.com/repos/WASdev/tool.lars/issues/events{/number}","events_url":"https://api.github.com/repos/WASdev/tool.lars/events","assignees_url":"https://api.github.com/repos/WASdev/tool.lars/assignees{/user}","branches_url":"https://api.github.com/repos/WASdev/tool.lars/branches{/branch}","tags_url":"https://api.github.com/repos/WASdev/tool.lars/tags","blobs_url":"https://api.github.com/repos/WASdev/tool.lars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WASdev/tool.lars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WASdev/tool.lars/git/refs{/sha}","trees_url":"https://api.github.com/repos/WASdev/tool.lars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WASdev/tool.lars/statuses/{sha}","languages_url":"https://api.github.com/repos/WASdev/tool.lars/languages","stargazers_url":"https://api.github.com/repos/WASdev/tool.lars/stargazers","contributors_url":"https://api.github.com/repos/WASdev/tool.lars/contributors","subscribers_url":"https://api.github.com/repos/WASdev/tool.lars/subscribers","subscription_url":"https://api.github.com/repos/WASdev/tool.lars/subscription","commits_url":"https://api.github.com/repos/WASdev/tool.lars/commits{/sha}","git_commits_url":"https://api.github.com/repos/WASdev/tool.lars/git/commits{/sha}","comments_url":"https://api.github.com/repos/WASdev/tool.lars/comments{/number}","issue_comment_url":"https://api.github.com/repos/WASdev/tool.lars/issues/comments{/number}","contents_url":"https://api.github.com/repos/WASdev/tool.lars/contents/{+path}","compare_url":"https://api.github.com/repos/WASdev/tool.lars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WASdev/tool.lars/merges","archive_url":"https://api.github.com/repos/WASdev/tool.lars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WASdev/tool.lars/downloads","issues_url":"https://api.github.com/repos/WASdev/tool.lars/issues{/number}","pulls_url":"https://api.github.com/repos/WASdev/tool.lars/pulls{/number}","milestones_url":"https://api.github.com/repos/WASdev/tool.lars/milestones{/number}","notifications_url":"https://api.github.com/repos/WASdev/tool.lars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WASdev/tool.lars/labels{/name}","releases_url":"https://api.github.com/repos/WASdev/tool.lars/releases{/id}","deployments_url":"https://api.github.com/repos/WASdev/tool.lars/deployments","created_at":"2015-02-12T14:23:00Z","updated_at":"2016-01-12T03:05:29Z","pushed_at":"2016-10-13T09:30:38Z","git_url":"git://github.com/WASdev/tool.lars.git","ssh_url":"git@github.com:WASdev/tool.lars.git","clone_url":"https://github.com/WASdev/tool.lars.git","svn_url":"https://github.com/WASdev/tool.lars","homepage":"","size":1566,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":6,"forks":12,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WASdev/tool.lars/pulls/141"},"html":{"href":"https://github.com/WASdev/tool.lars/pull/141"},"issue":{"href":"https://api.github.com/repos/WASdev/tool.lars/issues/141"},"comments":{"href":"https://api.github.com/repos/WASdev/tool.lars/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/WASdev/tool.lars/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/WASdev/tool.lars/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WASdev/tool.lars/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/WASdev/tool.lars/statuses/51874011e93cf92ee5ee8b74328a579bca4cf06b"}}}}
{"actor":{"display_login":"idlewis"}}