{"action":"created","comment":{"url":"https://api.github.com/repos/yap/YAP/pulls/comments/83200640","pull_request_review_id":4057747,"id":83200640,"diff_hunk":"@@ -69,29 +58,23 @@ int main()\n \n     // generate integration data\n     std::mt19937 g(0);\n-    if (false) {\n-        m->integrationPointGenerator() = std::bind(yap::phsp<std::mt19937>, std::cref(*m->model()), D_mass, m->axes(), m2r, g, std::numeric_limits<unsigned>::max());\n-        // m->setNIntegrationPoints(4e4, 4e4);\n-        m->setNIntegrationPoints(20e3, 20e3, 6);\n-        LOG(INFO) << \"Generating integration points on the fly\";\n-    } else {\n-        // get FSP mass ranges\n-        auto m2r = yap::squared(mass_range(D_mass, m->axes(), m->model()->finalStateParticles()));\n-        \n-        // generate integration data\n-        std::generate_n(std::back_inserter(m->integralData()), 10000,\n-                        std::bind(yap::phsp<std::mt19937>, std::cref(*m->model()), D_mass, m->axes(), m2r, g, std::numeric_limits<unsigned>::max()));\n-        m->integralPartitions() = yap::DataPartitionBlock::create(m->integralData(), 6);\n-        LOG(INFO) << \"Created \" << m->integralData().size() << \" data points (\" << (m->integralData().bytes() * 1.e-6) << \" MB)\";\n \n-        yap::ImportanceSampler::calculate(m->modelIntegral(), m->integralPartitions());\n+    std::generate_n(std::back_inserter(m->integralData()), 100000,","path":"examples/bat_gen/runFitFractions.cxx","position":48,"original_position":48,"commit_id":"63f5e081155390e3d3302a4eacb10a07ed08fe1d","original_commit_id":"63f5e081155390e3d3302a4eacb10a07ed08fe1d","user":{"login":"greenwald","id":2571281,"avatar_url":"https://avatars.githubusercontent.com/u/2571281?v=3","gravatar_id":"","url":"https://api.github.com/users/greenwald","html_url":"https://github.com/greenwald","followers_url":"https://api.github.com/users/greenwald/followers","following_url":"https://api.github.com/users/greenwald/following{/other_user}","gists_url":"https://api.github.com/users/greenwald/gists{/gist_id}","starred_url":"https://api.github.com/users/greenwald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenwald/subscriptions","organizations_url":"https://api.github.com/users/greenwald/orgs","repos_url":"https://api.github.com/users/greenwald/repos","events_url":"https://api.github.com/users/greenwald/events{/privacy}","received_events_url":"https://api.github.com/users/greenwald/received_events","type":"User","site_admin":false},"body":"We should perhaps switch here from an integrating data set to the on-the-fly integration.","created_at":"2016-10-13T12:08:20Z","updated_at":"2016-10-13T12:10:10Z","html_url":"https://github.com/yap/YAP/pull/111#discussion_r83200640","pull_request_url":"https://api.github.com/repos/yap/YAP/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/yap/YAP/pulls/comments/83200640"},"html":{"href":"https://github.com/yap/YAP/pull/111#discussion_r83200640"},"pull_request":{"href":"https://api.github.com/repos/yap/YAP/pulls/111"}}},"pull_request":{"url":"https://api.github.com/repos/yap/YAP/pulls/111","id":89186831,"html_url":"https://github.com/yap/YAP/pull/111","diff_url":"https://github.com/yap/YAP/pull/111.diff","patch_url":"https://github.com/yap/YAP/pull/111.patch","issue_url":"https://api.github.com/repos/yap/YAP/issues/111","number":111,"state":"open","locked":false,"title":"clean up, rename, enhance and build runFitFractions","user":{"login":"Jojosito","id":12700726,"avatar_url":"https://avatars.githubusercontent.com/u/12700726?v=3","gravatar_id":"","url":"https://api.github.com/users/Jojosito","html_url":"https://github.com/Jojosito","followers_url":"https://api.github.com/users/Jojosito/followers","following_url":"https://api.github.com/users/Jojosito/following{/other_user}","gists_url":"https://api.github.com/users/Jojosito/gists{/gist_id}","starred_url":"https://api.github.com/users/Jojosito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jojosito/subscriptions","organizations_url":"https://api.github.com/users/Jojosito/orgs","repos_url":"https://api.github.com/users/Jojosito/repos","events_url":"https://api.github.com/users/Jojosito/events{/privacy}","received_events_url":"https://api.github.com/users/Jojosito/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-13T11:51:29Z","updated_at":"2016-10-13T12:10:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c16e70546302613b439b81ac79c72b1a0a30a327","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yap/YAP/pulls/111/commits","review_comments_url":"https://api.github.com/repos/yap/YAP/pulls/111/comments","review_comment_url":"https://api.github.com/repos/yap/YAP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yap/YAP/issues/111/comments","statuses_url":"https://api.github.com/repos/yap/YAP/statuses/63f5e081155390e3d3302a4eacb10a07ed08fe1d","head":{"label":"Jojosito:fitFractionsFix","ref":"fitFractionsFix","sha":"63f5e081155390e3d3302a4eacb10a07ed08fe1d","user":{"login":"Jojosito","id":12700726,"avatar_url":"https://avatars.githubusercontent.com/u/12700726?v=3","gravatar_id":"","url":"https://api.github.com/users/Jojosito","html_url":"https://github.com/Jojosito","followers_url":"https://api.github.com/users/Jojosito/followers","following_url":"https://api.github.com/users/Jojosito/following{/other_user}","gists_url":"https://api.github.com/users/Jojosito/gists{/gist_id}","starred_url":"https://api.github.com/users/Jojosito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jojosito/subscriptions","organizations_url":"https://api.github.com/users/Jojosito/orgs","repos_url":"https://api.github.com/users/Jojosito/repos","events_url":"https://api.github.com/users/Jojosito/events{/privacy}","received_events_url":"https://api.github.com/users/Jojosito/received_events","type":"User","site_admin":false},"repo":{"id":60611988,"name":"YAP","full_name":"Jojosito/YAP","owner":{"login":"Jojosito","id":12700726,"avatar_url":"https://avatars.githubusercontent.com/u/12700726?v=3","gravatar_id":"","url":"https://api.github.com/users/Jojosito","html_url":"https://github.com/Jojosito","followers_url":"https://api.github.com/users/Jojosito/followers","following_url":"https://api.github.com/users/Jojosito/following{/other_user}","gists_url":"https://api.github.com/users/Jojosito/gists{/gist_id}","starred_url":"https://api.github.com/users/Jojosito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jojosito/subscriptions","organizations_url":"https://api.github.com/users/Jojosito/orgs","repos_url":"https://api.github.com/users/Jojosito/repos","events_url":"https://api.github.com/users/Jojosito/events{/privacy}","received_events_url":"https://api.github.com/users/Jojosito/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jojosito/YAP","description":"Yet Another Partial Wave Analysis Toolkit","fork":true,"url":"https://api.github.com/repos/Jojosito/YAP","forks_url":"https://api.github.com/repos/Jojosito/YAP/forks","keys_url":"https://api.github.com/repos/Jojosito/YAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jojosito/YAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jojosito/YAP/teams","hooks_url":"https://api.github.com/repos/Jojosito/YAP/hooks","issue_events_url":"https://api.github.com/repos/Jojosito/YAP/issues/events{/number}","events_url":"https://api.github.com/repos/Jojosito/YAP/events","assignees_url":"https://api.github.com/repos/Jojosito/YAP/assignees{/user}","branches_url":"https://api.github.com/repos/Jojosito/YAP/branches{/branch}","tags_url":"https://api.github.com/repos/Jojosito/YAP/tags","blobs_url":"https://api.github.com/repos/Jojosito/YAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jojosito/YAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jojosito/YAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jojosito/YAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jojosito/YAP/statuses/{sha}","languages_url":"https://api.github.com/repos/Jojosito/YAP/languages","stargazers_url":"https://api.github.com/repos/Jojosito/YAP/stargazers","contributors_url":"https://api.github.com/repos/Jojosito/YAP/contributors","subscribers_url":"https://api.github.com/repos/Jojosito/YAP/subscribers","subscription_url":"https://api.github.com/repos/Jojosito/YAP/subscription","commits_url":"https://api.github.com/repos/Jojosito/YAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jojosito/YAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jojosito/YAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jojosito/YAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jojosito/YAP/contents/{+path}","compare_url":"https://api.github.com/repos/Jojosito/YAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jojosito/YAP/merges","archive_url":"https://api.github.com/repos/Jojosito/YAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jojosito/YAP/downloads","issues_url":"https://api.github.com/repos/Jojosito/YAP/issues{/number}","pulls_url":"https://api.github.com/repos/Jojosito/YAP/pulls{/number}","milestones_url":"https://api.github.com/repos/Jojosito/YAP/milestones{/number}","notifications_url":"https://api.github.com/repos/Jojosito/YAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jojosito/YAP/labels{/name}","releases_url":"https://api.github.com/repos/Jojosito/YAP/releases{/id}","deployments_url":"https://api.github.com/repos/Jojosito/YAP/deployments","created_at":"2016-06-07T12:38:51Z","updated_at":"2016-06-07T12:38:52Z","pushed_at":"2016-10-13T11:53:10Z","git_url":"git://github.com/Jojosito/YAP.git","ssh_url":"git@github.com:Jojosito/YAP.git","clone_url":"https://github.com/Jojosito/YAP.git","svn_url":"https://github.com/Jojosito/YAP","homepage":null,"size":5649,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yap:master","ref":"master","sha":"5d8379fa2c7b4989163afdcf0a707bfd11e6d641","user":{"login":"yap","id":14902736,"avatar_url":"https://avatars.githubusercontent.com/u/14902736?v=3","gravatar_id":"","url":"https://api.github.com/users/yap","html_url":"https://github.com/yap","followers_url":"https://api.github.com/users/yap/followers","following_url":"https://api.github.com/users/yap/following{/other_user}","gists_url":"https://api.github.com/users/yap/gists{/gist_id}","starred_url":"https://api.github.com/users/yap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yap/subscriptions","organizations_url":"https://api.github.com/users/yap/orgs","repos_url":"https://api.github.com/users/yap/repos","events_url":"https://api.github.com/users/yap/events{/privacy}","received_events_url":"https://api.github.com/users/yap/received_events","type":"Organization","site_admin":false},"repo":{"id":40311601,"name":"YAP","full_name":"yap/YAP","owner":{"login":"yap","id":14902736,"avatar_url":"https://avatars.githubusercontent.com/u/14902736?v=3","gravatar_id":"","url":"https://api.github.com/users/yap","html_url":"https://github.com/yap","followers_url":"https://api.github.com/users/yap/followers","following_url":"https://api.github.com/users/yap/following{/other_user}","gists_url":"https://api.github.com/users/yap/gists{/gist_id}","starred_url":"https://api.github.com/users/yap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yap/subscriptions","organizations_url":"https://api.github.com/users/yap/orgs","repos_url":"https://api.github.com/users/yap/repos","events_url":"https://api.github.com/users/yap/events{/privacy}","received_events_url":"https://api.github.com/users/yap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yap/YAP","description":"Yet Another Partial Wave Analysis Toolkit","fork":false,"url":"https://api.github.com/repos/yap/YAP","forks_url":"https://api.github.com/repos/yap/YAP/forks","keys_url":"https://api.github.com/repos/yap/YAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yap/YAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yap/YAP/teams","hooks_url":"https://api.github.com/repos/yap/YAP/hooks","issue_events_url":"https://api.github.com/repos/yap/YAP/issues/events{/number}","events_url":"https://api.github.com/repos/yap/YAP/events","assignees_url":"https://api.github.com/repos/yap/YAP/assignees{/user}","branches_url":"https://api.github.com/repos/yap/YAP/branches{/branch}","tags_url":"https://api.github.com/repos/yap/YAP/tags","blobs_url":"https://api.github.com/repos/yap/YAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yap/YAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yap/YAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/yap/YAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yap/YAP/statuses/{sha}","languages_url":"https://api.github.com/repos/yap/YAP/languages","stargazers_url":"https://api.github.com/repos/yap/YAP/stargazers","contributors_url":"https://api.github.com/repos/yap/YAP/contributors","subscribers_url":"https://api.github.com/repos/yap/YAP/subscribers","subscription_url":"https://api.github.com/repos/yap/YAP/subscription","commits_url":"https://api.github.com/repos/yap/YAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/yap/YAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/yap/YAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/yap/YAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/yap/YAP/contents/{+path}","compare_url":"https://api.github.com/repos/yap/YAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yap/YAP/merges","archive_url":"https://api.github.com/repos/yap/YAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yap/YAP/downloads","issues_url":"https://api.github.com/repos/yap/YAP/issues{/number}","pulls_url":"https://api.github.com/repos/yap/YAP/pulls{/number}","milestones_url":"https://api.github.com/repos/yap/YAP/milestones{/number}","notifications_url":"https://api.github.com/repos/yap/YAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yap/YAP/labels{/name}","releases_url":"https://api.github.com/repos/yap/YAP/releases{/id}","deployments_url":"https://api.github.com/repos/yap/YAP/deployments","created_at":"2015-08-06T15:13:07Z","updated_at":"2016-07-14T16:15:35Z","pushed_at":"2016-10-13T12:03:14Z","git_url":"git://github.com/yap/YAP.git","ssh_url":"git@github.com:yap/YAP.git","clone_url":"https://github.com/yap/YAP.git","svn_url":"https://github.com/yap/YAP","homepage":null,"size":6738,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":34,"forks":4,"open_issues":34,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yap/YAP/pulls/111"},"html":{"href":"https://github.com/yap/YAP/pull/111"},"issue":{"href":"https://api.github.com/repos/yap/YAP/issues/111"},"comments":{"href":"https://api.github.com/repos/yap/YAP/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/yap/YAP/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/yap/YAP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yap/YAP/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/yap/YAP/statuses/63f5e081155390e3d3302a4eacb10a07ed08fe1d"}}}}
{"actor":{"display_login":"greenwald"}}