{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/401","repository_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp","labels_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/401/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/401/comments","events_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/401/events","html_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/401","id":170497482,"number":401,"title":"Only load compat layers when we're rendering a feed","user":{"login":"philipjohn","id":136342,"avatar_url":"https://avatars.githubusercontent.com/u/136342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipjohn","html_url":"https://github.com/philipjohn","followers_url":"https://api.github.com/users/philipjohn/followers","following_url":"https://api.github.com/users/philipjohn/following{/other_user}","gists_url":"https://api.github.com/users/philipjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipjohn/subscriptions","organizations_url":"https://api.github.com/users/philipjohn/orgs","repos_url":"https://api.github.com/users/philipjohn/repos","events_url":"https://api.github.com/users/philipjohn/events{/privacy}","received_events_url":"https://api.github.com/users/philipjohn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/labels/compat","name":"compat","color":"1d76db"}],"state":"open","locked":false,"assignee":{"login":"philipjohn","id":136342,"avatar_url":"https://avatars.githubusercontent.com/u/136342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipjohn","html_url":"https://github.com/philipjohn","followers_url":"https://api.github.com/users/philipjohn/followers","following_url":"https://api.github.com/users/philipjohn/following{/other_user}","gists_url":"https://api.github.com/users/philipjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipjohn/subscriptions","organizations_url":"https://api.github.com/users/philipjohn/orgs","repos_url":"https://api.github.com/users/philipjohn/repos","events_url":"https://api.github.com/users/philipjohn/events{/privacy}","received_events_url":"https://api.github.com/users/philipjohn/received_events","type":"User","site_admin":false},"assignees":[{"login":"philipjohn","id":136342,"avatar_url":"https://avatars.githubusercontent.com/u/136342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipjohn","html_url":"https://github.com/philipjohn","followers_url":"https://api.github.com/users/philipjohn/followers","following_url":"https://api.github.com/users/philipjohn/following{/other_user}","gists_url":"https://api.github.com/users/philipjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipjohn/subscriptions","organizations_url":"https://api.github.com/users/philipjohn/orgs","repos_url":"https://api.github.com/users/philipjohn/repos","events_url":"https://api.github.com/users/philipjohn/events{/privacy}","received_events_url":"https://api.github.com/users/philipjohn/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/milestones/4","html_url":"https://github.com/Automattic/facebook-instant-articles-wp/milestones/3.1","labels_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/milestones/4/labels","id":1880590,"number":4,"title":"3.1","description":"Code freeze on August 13th for testing & bugfixes","creator":{"login":"philipjohn","id":136342,"avatar_url":"https://avatars.githubusercontent.com/u/136342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipjohn","html_url":"https://github.com/philipjohn","followers_url":"https://api.github.com/users/philipjohn/followers","following_url":"https://api.github.com/users/philipjohn/following{/other_user}","gists_url":"https://api.github.com/users/philipjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipjohn/subscriptions","organizations_url":"https://api.github.com/users/philipjohn/orgs","repos_url":"https://api.github.com/users/philipjohn/repos","events_url":"https://api.github.com/users/philipjohn/events{/privacy}","received_events_url":"https://api.github.com/users/philipjohn/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":17,"state":"open","created_at":"2016-07-13T10:37:11Z","updated_at":"2016-08-10T19:23:06Z","due_on":"2016-08-16T23:00:00Z","closed_at":null},"comments":3,"created_at":"2016-08-10T19:23:06Z","updated_at":"2016-08-13T12:17:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/pulls/401","html_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/401","diff_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/401.diff","patch_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/401.patch"},"body":"The plugin currently does not load compat layers conditionally.\r\n\r\nOne result is that embeds (e.g. for Facebook) are transformed into FBIA markup for normal front-end posts. This means embeds don't render because they are not recognisable HTML.\r\n\r\nThis PR moves the loading of compat layers to the feed initiation so that we only load the compatibility code when we are definitely rendering the feed."},"comment":{"url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/comments/239618017","html_url":"https://github.com/Automattic/facebook-instant-articles-wp/pull/401#issuecomment-239618017","issue_url":"https://api.github.com/repos/Automattic/facebook-instant-articles-wp/issues/401","id":239618017,"user":{"login":"philipjohn","id":136342,"avatar_url":"https://avatars.githubusercontent.com/u/136342?v=3","gravatar_id":"","url":"https://api.github.com/users/philipjohn","html_url":"https://github.com/philipjohn","followers_url":"https://api.github.com/users/philipjohn/followers","following_url":"https://api.github.com/users/philipjohn/following{/other_user}","gists_url":"https://api.github.com/users/philipjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/philipjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipjohn/subscriptions","organizations_url":"https://api.github.com/users/philipjohn/orgs","repos_url":"https://api.github.com/users/philipjohn/repos","events_url":"https://api.github.com/users/philipjohn/events{/privacy}","received_events_url":"https://api.github.com/users/philipjohn/received_events","type":"User","site_admin":false},"created_at":"2016-08-13T12:17:13Z","updated_at":"2016-08-13T12:17:13Z","body":"Damn, there was my hoping for a simple fix :)\r\n\r\nWe ought to help ourselves out with some sort of helper function. E.g. `is_fbia_response()` - or similar - would return true when we *should* be returning FBIA-compatible output.\r\n\r\nAny other time, such as normal front-end loads, it would return false. That way, we don't alter markup outside of responses that need FBIA markup.\r\n\r\nI feel like this is a pretty serious bug that we need to get into 3.1 :) I'll commit a helper function, and invoke it for feeds as an example but I'm unsure of the best place to do this for other responses - could you help with that please @diegoquinteiro ?"}}
{"actor":{"display_login":"philipjohn"}}