{"action":"opened","number":280,"pull_request":{"url":"https://api.github.com/repos/secdev/scapy/pulls/280","id":83172430,"html_url":"https://github.com/secdev/scapy/pull/280","diff_url":"https://github.com/secdev/scapy/pull/280.diff","patch_url":"https://github.com/secdev/scapy/pull/280.patch","issue_url":"https://api.github.com/repos/secdev/scapy/issues/280","number":280,"state":"open","locked":false,"title":"Choose correct source IP when there are interface aliases","user":{"login":"prxyg3n","id":21291402,"avatar_url":"https://avatars.githubusercontent.com/u/21291402?v=3","gravatar_id":"","url":"https://api.github.com/users/prxyg3n","html_url":"https://github.com/prxyg3n","followers_url":"https://api.github.com/users/prxyg3n/followers","following_url":"https://api.github.com/users/prxyg3n/following{/other_user}","gists_url":"https://api.github.com/users/prxyg3n/gists{/gist_id}","starred_url":"https://api.github.com/users/prxyg3n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prxyg3n/subscriptions","organizations_url":"https://api.github.com/users/prxyg3n/orgs","repos_url":"https://api.github.com/users/prxyg3n/repos","events_url":"https://api.github.com/users/prxyg3n/events{/privacy}","received_events_url":"https://api.github.com/users/prxyg3n/received_events","type":"User","site_admin":false},"body":"Resolves #278 \r\n\r\nRather than using ioctl to poll interfaces named by /proc/net/routes, we first enumerate interfaces using SIOCGIFCONF, and then retrieve addresses for all interfaces including aliases. Then when iterating over /proc/net/routes we pick source IPs based on link-local routes. This removes the need for the manual addition of the loopback route as this is scooped up by SIOCGIFCONF.\r\n\r\nTested on linux kernel 3.19.0 x86_64 only.","created_at":"2016-08-29T21:38:31Z","updated_at":"2016-08-29T21:38:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40b3a0a5746dfa2b4dad3f0c1befd05321abfe77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/secdev/scapy/pulls/280/commits","review_comments_url":"https://api.github.com/repos/secdev/scapy/pulls/280/comments","review_comment_url":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/280/comments","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/2340bfabf44bb2b5087b25664ca1e5db0feb347b","head":{"label":"prxyg3n:master","ref":"master","sha":"2340bfabf44bb2b5087b25664ca1e5db0feb347b","user":{"login":"prxyg3n","id":21291402,"avatar_url":"https://avatars.githubusercontent.com/u/21291402?v=3","gravatar_id":"","url":"https://api.github.com/users/prxyg3n","html_url":"https://github.com/prxyg3n","followers_url":"https://api.github.com/users/prxyg3n/followers","following_url":"https://api.github.com/users/prxyg3n/following{/other_user}","gists_url":"https://api.github.com/users/prxyg3n/gists{/gist_id}","starred_url":"https://api.github.com/users/prxyg3n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prxyg3n/subscriptions","organizations_url":"https://api.github.com/users/prxyg3n/orgs","repos_url":"https://api.github.com/users/prxyg3n/repos","events_url":"https://api.github.com/users/prxyg3n/events{/privacy}","received_events_url":"https://api.github.com/users/prxyg3n/received_events","type":"User","site_admin":false},"repo":{"id":66850662,"name":"scapy","full_name":"prxyg3n/scapy","owner":{"login":"prxyg3n","id":21291402,"avatar_url":"https://avatars.githubusercontent.com/u/21291402?v=3","gravatar_id":"","url":"https://api.github.com/users/prxyg3n","html_url":"https://github.com/prxyg3n","followers_url":"https://api.github.com/users/prxyg3n/followers","following_url":"https://api.github.com/users/prxyg3n/following{/other_user}","gists_url":"https://api.github.com/users/prxyg3n/gists{/gist_id}","starred_url":"https://api.github.com/users/prxyg3n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prxyg3n/subscriptions","organizations_url":"https://api.github.com/users/prxyg3n/orgs","repos_url":"https://api.github.com/users/prxyg3n/repos","events_url":"https://api.github.com/users/prxyg3n/events{/privacy}","received_events_url":"https://api.github.com/users/prxyg3n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prxyg3n/scapy","description":"Scapy: the python-based interactive packet manipulation program & library","fork":true,"url":"https://api.github.com/repos/prxyg3n/scapy","forks_url":"https://api.github.com/repos/prxyg3n/scapy/forks","keys_url":"https://api.github.com/repos/prxyg3n/scapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prxyg3n/scapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prxyg3n/scapy/teams","hooks_url":"https://api.github.com/repos/prxyg3n/scapy/hooks","issue_events_url":"https://api.github.com/repos/prxyg3n/scapy/issues/events{/number}","events_url":"https://api.github.com/repos/prxyg3n/scapy/events","assignees_url":"https://api.github.com/repos/prxyg3n/scapy/assignees{/user}","branches_url":"https://api.github.com/repos/prxyg3n/scapy/branches{/branch}","tags_url":"https://api.github.com/repos/prxyg3n/scapy/tags","blobs_url":"https://api.github.com/repos/prxyg3n/scapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prxyg3n/scapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prxyg3n/scapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/prxyg3n/scapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prxyg3n/scapy/statuses/{sha}","languages_url":"https://api.github.com/repos/prxyg3n/scapy/languages","stargazers_url":"https://api.github.com/repos/prxyg3n/scapy/stargazers","contributors_url":"https://api.github.com/repos/prxyg3n/scapy/contributors","subscribers_url":"https://api.github.com/repos/prxyg3n/scapy/subscribers","subscription_url":"https://api.github.com/repos/prxyg3n/scapy/subscription","commits_url":"https://api.github.com/repos/prxyg3n/scapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/prxyg3n/scapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/prxyg3n/scapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/prxyg3n/scapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/prxyg3n/scapy/contents/{+path}","compare_url":"https://api.github.com/repos/prxyg3n/scapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prxyg3n/scapy/merges","archive_url":"https://api.github.com/repos/prxyg3n/scapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prxyg3n/scapy/downloads","issues_url":"https://api.github.com/repos/prxyg3n/scapy/issues{/number}","pulls_url":"https://api.github.com/repos/prxyg3n/scapy/pulls{/number}","milestones_url":"https://api.github.com/repos/prxyg3n/scapy/milestones{/number}","notifications_url":"https://api.github.com/repos/prxyg3n/scapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prxyg3n/scapy/labels{/name}","releases_url":"https://api.github.com/repos/prxyg3n/scapy/releases{/id}","deployments_url":"https://api.github.com/repos/prxyg3n/scapy/deployments","created_at":"2016-08-29T14:23:59Z","updated_at":"2016-08-29T14:24:02Z","pushed_at":"2016-08-29T21:27:39Z","git_url":"git://github.com/prxyg3n/scapy.git","ssh_url":"git@github.com:prxyg3n/scapy.git","clone_url":"https://github.com/prxyg3n/scapy.git","svn_url":"https://github.com/prxyg3n/scapy","homepage":"http://www.secdev.org/projects/scapy/","size":63937,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"secdev:master","ref":"master","sha":"7365c9771029c0b99b43cd8cc346d266eaf4c7b4","user":{"login":"secdev","id":14927208,"avatar_url":"https://avatars.githubusercontent.com/u/14927208?v=3","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"repo":{"id":43509302,"name":"scapy","full_name":"secdev/scapy","owner":{"login":"secdev","id":14927208,"avatar_url":"https://avatars.githubusercontent.com/u/14927208?v=3","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/secdev/scapy","description":"Scapy: the python-based interactive packet manipulation program & library","fork":false,"url":"https://api.github.com/repos/secdev/scapy","forks_url":"https://api.github.com/repos/secdev/scapy/forks","keys_url":"https://api.github.com/repos/secdev/scapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/secdev/scapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/secdev/scapy/teams","hooks_url":"https://api.github.com/repos/secdev/scapy/hooks","issue_events_url":"https://api.github.com/repos/secdev/scapy/issues/events{/number}","events_url":"https://api.github.com/repos/secdev/scapy/events","assignees_url":"https://api.github.com/repos/secdev/scapy/assignees{/user}","branches_url":"https://api.github.com/repos/secdev/scapy/branches{/branch}","tags_url":"https://api.github.com/repos/secdev/scapy/tags","blobs_url":"https://api.github.com/repos/secdev/scapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/secdev/scapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/secdev/scapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/secdev/scapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/{sha}","languages_url":"https://api.github.com/repos/secdev/scapy/languages","stargazers_url":"https://api.github.com/repos/secdev/scapy/stargazers","contributors_url":"https://api.github.com/repos/secdev/scapy/contributors","subscribers_url":"https://api.github.com/repos/secdev/scapy/subscribers","subscription_url":"https://api.github.com/repos/secdev/scapy/subscription","commits_url":"https://api.github.com/repos/secdev/scapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/secdev/scapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/secdev/scapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/secdev/scapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/secdev/scapy/contents/{+path}","compare_url":"https://api.github.com/repos/secdev/scapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/secdev/scapy/merges","archive_url":"https://api.github.com/repos/secdev/scapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/secdev/scapy/downloads","issues_url":"https://api.github.com/repos/secdev/scapy/issues{/number}","pulls_url":"https://api.github.com/repos/secdev/scapy/pulls{/number}","milestones_url":"https://api.github.com/repos/secdev/scapy/milestones{/number}","notifications_url":"https://api.github.com/repos/secdev/scapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/secdev/scapy/labels{/name}","releases_url":"https://api.github.com/repos/secdev/scapy/releases{/id}","deployments_url":"https://api.github.com/repos/secdev/scapy/deployments","created_at":"2015-10-01T17:06:46Z","updated_at":"2016-08-29T12:41:20Z","pushed_at":"2016-08-29T21:38:31Z","git_url":"git://github.com/secdev/scapy.git","ssh_url":"git@github.com:secdev/scapy.git","clone_url":"https://github.com/secdev/scapy.git","svn_url":"https://github.com/secdev/scapy","homepage":"http://www.secdev.org/projects/scapy/","size":65778,"stargazers_count":592,"watchers_count":592,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":50,"forks":160,"open_issues":50,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/secdev/scapy/pulls/280"},"html":{"href":"https://github.com/secdev/scapy/pull/280"},"issue":{"href":"https://api.github.com/repos/secdev/scapy/issues/280"},"comments":{"href":"https://api.github.com/repos/secdev/scapy/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/secdev/scapy/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/secdev/scapy/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/secdev/scapy/statuses/2340bfabf44bb2b5087b25664ca1e5db0feb347b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":54,"deletions":30,"changed_files":1}}
{"actor":{"display_login":"prxyg3n"}}