{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/59779177","id":59779177,"diff_hunk":"@@ -16,8 +16,7 @@ class IntfsOrch : public Orch\n public:\n     IntfsOrch(DBConnector *db, string tableName, PortsOrch *portsOrch);\n private:\n-    void doTask();\n-\n+    virtual void doTask(_in_ Consumer& consumer_info);","path":"orchagent/intfsorch.h","position":6,"original_position":6,"commit_id":"08e35e171f37fe15830f52148e8cfd2cecd9680f","original_commit_id":"08e35e171f37fe15830f52148e8cfd2cecd9680f","user":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"body":"because base class is virtual. putting here virtual is to make it explicit and avoid any possible confusion.","created_at":"2016-04-14T19:47:53Z","updated_at":"2016-04-14T19:47:53Z","html_url":"https://github.com/Azure/sonic-swss/pull/13#discussion_r59779177","pull_request_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/59779177"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/13#discussion_r59779177"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/13","id":66077923,"html_url":"https://github.com/Azure/sonic-swss/pull/13","diff_url":"https://github.com/Azure/sonic-swss/pull/13.diff","patch_url":"https://github.com/Azure/sonic-swss/pull/13.patch","issue_url":"https://api.github.com/repos/Azure/sonic-swss/issues/13","number":13,"state":"open","locked":false,"title":"Swss.orchagent.multi.consumer","user":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-11T23:15:10Z","updated_at":"2016-04-14T19:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4ee151ade4b784b0913df93e2c61e0916a3af48","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/13/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/13/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/issues/13/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/08e35e171f37fe15830f52148e8cfd2cecd9680f","head":{"label":"hrachya-mellanox:swss.orchagent.multi.consumer","ref":"swss.orchagent.multi.consumer","sha":"08e35e171f37fe15830f52148e8cfd2cecd9680f","user":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"repo":{"id":54569590,"name":"sonic-swss","full_name":"hrachya-mellanox/sonic-swss","owner":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrachya-mellanox/sonic-swss","description":"Public version of swss repository","fork":true,"url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss","forks_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/forks","keys_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/teams","hooks_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/events","assignees_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/tags","blobs_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/subscription","commits_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/merges","archive_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/downloads","issues_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss/deployments","created_at":"2016-03-23T15:08:22Z","updated_at":"2016-03-23T15:08:24Z","pushed_at":"2016-04-13T19:55:14Z","git_url":"git://github.com/hrachya-mellanox/sonic-swss.git","ssh_url":"git@github.com:hrachya-mellanox/sonic-swss.git","clone_url":"https://github.com/hrachya-mellanox/sonic-swss.git","svn_url":"https://github.com/hrachya-mellanox/sonic-swss","homepage":null,"size":443,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"125f0ffceacc7faa01d189c3b010b98211a24133","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53515475,"name":"sonic-swss","full_name":"Azure/sonic-swss","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/sonic-swss","description":"Public version of swss repository","fork":false,"url":"https://api.github.com/repos/Azure/sonic-swss","forks_url":"https://api.github.com/repos/Azure/sonic-swss/forks","keys_url":"https://api.github.com/repos/Azure/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-swss/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-swss/events","assignees_url":"https://api.github.com/repos/Azure/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-swss/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-swss/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-swss/merges","archive_url":"https://api.github.com/repos/Azure/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-swss/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-swss/deployments","created_at":"2016-03-09T17:01:09Z","updated_at":"2016-03-29T22:27:08Z","pushed_at":"2016-04-14T18:28:35Z","git_url":"git://github.com/Azure/sonic-swss.git","ssh_url":"git@github.com:Azure/sonic-swss.git","clone_url":"https://github.com/Azure/sonic-swss.git","svn_url":"https://github.com/Azure/sonic-swss","homepage":null,"size":763,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/13"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/13"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/13"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-swss/statuses/08e35e171f37fe15830f52148e8cfd2cecd9680f"}}}}