{"action":"created","issue":{"url":"https://api.github.com/repos/STRML/react-grid-layout/issues/169","repository_url":"https://api.github.com/repos/STRML/react-grid-layout","labels_url":"https://api.github.com/repos/STRML/react-grid-layout/issues/169/labels{/name}","comments_url":"https://api.github.com/repos/STRML/react-grid-layout/issues/169/comments","events_url":"https://api.github.com/repos/STRML/react-grid-layout/issues/169/events","html_url":"https://github.com/STRML/react-grid-layout/issues/169","id":134835202,"number":169,"title":"onLayoutChange never called","user":{"login":"eMerzh","id":177003,"avatar_url":"https://avatars.githubusercontent.com/u/177003?v=3","gravatar_id":"","url":"https://api.github.com/users/eMerzh","html_url":"https://github.com/eMerzh","followers_url":"https://api.github.com/users/eMerzh/followers","following_url":"https://api.github.com/users/eMerzh/following{/other_user}","gists_url":"https://api.github.com/users/eMerzh/gists{/gist_id}","starred_url":"https://api.github.com/users/eMerzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eMerzh/subscriptions","organizations_url":"https://api.github.com/users/eMerzh/orgs","repos_url":"https://api.github.com/users/eMerzh/repos","events_url":"https://api.github.com/users/eMerzh/events{/privacy}","received_events_url":"https://api.github.com/users/eMerzh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-02-19T10:50:34Z","updated_at":"2016-02-23T23:43:31Z","closed_at":null,"body":"hi, \r\nin all of the example, \r\nwe use something like\r\n```jsx\r\n<ReactGridLayout onLayoutChange={this.onLayoutChange}\r\n          {...this.props}>\r\n</ReactGridLayout>\r\n```\r\nbut we expect i the component's onLayoutChange, that this.props.onLayoutChange is defined by the parent element.\r\nand so, we the callback override the component's callback that tries to do a setState and is never called.\r\nis it intended ?\r\n\r\nin the mean time, if i put the  order like this\r\n```jsx\r\n<ReactGridLayout {...this.props} onLayoutChange={this.onLayoutChange}>\r\n</ReactGridLayout>\r\n```\r\ni got an infinite loop...\r\n\r\nam i missing something?"},"comment":{"url":"https://api.github.com/repos/STRML/react-grid-layout/issues/comments/187969992","html_url":"https://github.com/STRML/react-grid-layout/issues/169#issuecomment-187969992","issue_url":"https://api.github.com/repos/STRML/react-grid-layout/issues/169","id":187969992,"user":{"login":"STRML","id":1197375,"avatar_url":"https://avatars.githubusercontent.com/u/1197375?v=3","gravatar_id":"","url":"https://api.github.com/users/STRML","html_url":"https://github.com/STRML","followers_url":"https://api.github.com/users/STRML/followers","following_url":"https://api.github.com/users/STRML/following{/other_user}","gists_url":"https://api.github.com/users/STRML/gists{/gist_id}","starred_url":"https://api.github.com/users/STRML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STRML/subscriptions","organizations_url":"https://api.github.com/users/STRML/orgs","repos_url":"https://api.github.com/users/STRML/repos","events_url":"https://api.github.com/users/STRML/events{/privacy}","received_events_url":"https://api.github.com/users/STRML/received_events","type":"User","site_admin":false},"created_at":"2016-02-23T23:43:31Z","updated_at":"2016-02-23T23:43:31Z","body":"I believe it may be an error - if you set a layout that is identical to\na previous one, another callback should not fire.\n\n> Puffton <mailto:notifications@github.com>\n> February 23, 2016 at 4:40 PM\n>\n> @STRML <https://github.com/STRML> Was this part of a previous workflow\n> which is now obsolete? It used to work before, and it seems @eMerzh\n> <https://github.com/eMerzh> used nearly identical pieces of code.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/STRML/react-grid-layout/issues/169#issuecomment-187946662>.\n>\n> eMerzh <mailto:notifications@github.com>\n> February 19, 2016 at 4:50 AM\n>\n> hi,\n> in all of the example,\n> we use something like\n>\n> <ReactGridLayout onLayoutChange={this.onLayoutChange}\n> {...this.props}>\n> </ReactGridLayout>\n>\n> but we expect i the component's onLayoutChange, that\n> this.props.onLayoutChange is defined by the parent element.\n> and so, we the callback override the component's callback that tries\n> to do a setState and is never called.\n> is it intended ?\n>\n> in the mean time, if i put the order like this\n>\n> <ReactGridLayout {...this.props} onLayoutChange={this.onLayoutChange}>\n> </ReactGridLayout>\n>\n> i got an infinite loop...\n>\n> am i missing something?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/STRML/react-grid-layout/issues/169>.\n>\n\n\n"}}