{"action":"created","comment":{"url":"https://api.github.com/repos/sulu/sulu/pulls/comments/68193902","id":68193902,"diff_hunk":"@@ -141,11 +141,13 @@ public function refreshUser(UserInterface $user)\n      */\n     public function supportsClass($class)\n     {\n-        return $class === 'Sulu\\Bundle\\CoreBundle\\Entity\\TestUser';\n+        return $class instanceof UserInterface;","path":"src/Sulu/Bundle/TestBundle/Testing/TestUserProvider.php","position":69,"original_position":34,"commit_id":"3a6d8abda0375cc0c3a7d1a80c5aeeb289ec047d","original_commit_id":"3a6d8abda0375cc0c3a7d1a80c5aeeb289ec047d","user":{"login":"wachterjohannes","id":1464615,"avatar_url":"https://avatars.githubusercontent.com/u/1464615?v=3","gravatar_id":"","url":"https://api.github.com/users/wachterjohannes","html_url":"https://github.com/wachterjohannes","followers_url":"https://api.github.com/users/wachterjohannes/followers","following_url":"https://api.github.com/users/wachterjohannes/following{/other_user}","gists_url":"https://api.github.com/users/wachterjohannes/gists{/gist_id}","starred_url":"https://api.github.com/users/wachterjohannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wachterjohannes/subscriptions","organizations_url":"https://api.github.com/users/wachterjohannes/orgs","repos_url":"https://api.github.com/users/wachterjohannes/repos","events_url":"https://api.github.com/users/wachterjohannes/events{/privacy}","received_events_url":"https://api.github.com/users/wachterjohannes/received_events","type":"User","site_admin":false},"body":"it seems to work in the tests so leave it!","created_at":"2016-06-23T08:22:49Z","updated_at":"2016-06-23T08:22:49Z","html_url":"https://github.com/sulu/sulu/pull/2498#discussion_r68193902","pull_request_url":"https://api.github.com/repos/sulu/sulu/pulls/2498","_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments/68193902"},"html":{"href":"https://github.com/sulu/sulu/pull/2498#discussion_r68193902"},"pull_request":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2498"}}},"pull_request":{"url":"https://api.github.com/repos/sulu/sulu/pulls/2498","id":74779849,"html_url":"https://github.com/sulu/sulu/pull/2498","diff_url":"https://github.com/sulu/sulu/pull/2498.diff","patch_url":"https://github.com/sulu/sulu/pull/2498.patch","issue_url":"https://api.github.com/repos/sulu/sulu/issues/2498","number":2498,"state":"open","locked":false,"title":"Fixed TestUserProvider for inheritance of contact. Created ContactRepositoryInterface","user":{"login":"turbo-ele","id":5152633,"avatar_url":"https://avatars.githubusercontent.com/u/5152633?v=3","gravatar_id":"","url":"https://api.github.com/users/turbo-ele","html_url":"https://github.com/turbo-ele","followers_url":"https://api.github.com/users/turbo-ele/followers","following_url":"https://api.github.com/users/turbo-ele/following{/other_user}","gists_url":"https://api.github.com/users/turbo-ele/gists{/gist_id}","starred_url":"https://api.github.com/users/turbo-ele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbo-ele/subscriptions","organizations_url":"https://api.github.com/users/turbo-ele/orgs","repos_url":"https://api.github.com/users/turbo-ele/repos","events_url":"https://api.github.com/users/turbo-ele/events{/privacy}","received_events_url":"https://api.github.com/users/turbo-ele/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| --- | ---\r\n| Bug fix? | yes\r\n| New feature? | no\r\n| BC breaks? | yes\r\n| Deprecations? | no\r\n| Fixed tickets | none\r\n| Related issues/PRs | none\r\n| License | MIT\r\n| Documentation PR | none\r\n\r\n#### What's in this PR?\r\n\r\nTestUserProvider was creating Contact and User by calling `new Contact()` and `new User()`. That way it was not possible to use the UserTestProvider in projects that were extending Contact and/or User.\r\nNow the UserRepositories and ContactRepositories `createNew()` Function is used for creating a User and Contact.\r\n\r\n#### BC Breaks/Deprecations\r\n\r\nA Interface for the ContactRepository has been created. Due to the refactoring\r\nthe function `appendJoins` has been changed from public to protected.\r\nTherefore this function cannot be called anymore.\r\n","created_at":"2016-06-22T13:03:18Z","updated_at":"2016-06-23T08:22:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f23190f52b2091b4e8e0775454d2f7a755b0d71","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sulu/sulu/pulls/2498/commits","review_comments_url":"https://api.github.com/repos/sulu/sulu/pulls/2498/comments","review_comment_url":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sulu/sulu/issues/2498/comments","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/3a6d8abda0375cc0c3a7d1a80c5aeeb289ec047d","head":{"label":"massiveart:bugfix/test-user-provider","ref":"bugfix/test-user-provider","sha":"3a6d8abda0375cc0c3a7d1a80c5aeeb289ec047d","user":{"login":"massiveart","id":854731,"avatar_url":"https://avatars.githubusercontent.com/u/854731?v=3","gravatar_id":"","url":"https://api.github.com/users/massiveart","html_url":"https://github.com/massiveart","followers_url":"https://api.github.com/users/massiveart/followers","following_url":"https://api.github.com/users/massiveart/following{/other_user}","gists_url":"https://api.github.com/users/massiveart/gists{/gist_id}","starred_url":"https://api.github.com/users/massiveart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massiveart/subscriptions","organizations_url":"https://api.github.com/users/massiveart/orgs","repos_url":"https://api.github.com/users/massiveart/repos","events_url":"https://api.github.com/users/massiveart/events{/privacy}","received_events_url":"https://api.github.com/users/massiveart/received_events","type":"Organization","site_admin":false},"repo":{"id":33129845,"name":"sulu","full_name":"massiveart/sulu","owner":{"login":"massiveart","id":854731,"avatar_url":"https://avatars.githubusercontent.com/u/854731?v=3","gravatar_id":"","url":"https://api.github.com/users/massiveart","html_url":"https://github.com/massiveart","followers_url":"https://api.github.com/users/massiveart/followers","following_url":"https://api.github.com/users/massiveart/following{/other_user}","gists_url":"https://api.github.com/users/massiveart/gists{/gist_id}","starred_url":"https://api.github.com/users/massiveart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massiveart/subscriptions","organizations_url":"https://api.github.com/users/massiveart/orgs","repos_url":"https://api.github.com/users/massiveart/repos","events_url":"https://api.github.com/users/massiveart/events{/privacy}","received_events_url":"https://api.github.com/users/massiveart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/massiveart/sulu","description":"Sulu 2.0 core bundle & components","fork":true,"url":"https://api.github.com/repos/massiveart/sulu","forks_url":"https://api.github.com/repos/massiveart/sulu/forks","keys_url":"https://api.github.com/repos/massiveart/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massiveart/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massiveart/sulu/teams","hooks_url":"https://api.github.com/repos/massiveart/sulu/hooks","issue_events_url":"https://api.github.com/repos/massiveart/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/massiveart/sulu/events","assignees_url":"https://api.github.com/repos/massiveart/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/massiveart/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/massiveart/sulu/tags","blobs_url":"https://api.github.com/repos/massiveart/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massiveart/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massiveart/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/massiveart/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massiveart/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/massiveart/sulu/languages","stargazers_url":"https://api.github.com/repos/massiveart/sulu/stargazers","contributors_url":"https://api.github.com/repos/massiveart/sulu/contributors","subscribers_url":"https://api.github.com/repos/massiveart/sulu/subscribers","subscription_url":"https://api.github.com/repos/massiveart/sulu/subscription","commits_url":"https://api.github.com/repos/massiveart/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/massiveart/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/massiveart/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/massiveart/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/massiveart/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/massiveart/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massiveart/sulu/merges","archive_url":"https://api.github.com/repos/massiveart/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massiveart/sulu/downloads","issues_url":"https://api.github.com/repos/massiveart/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/massiveart/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/massiveart/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/massiveart/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massiveart/sulu/labels{/name}","releases_url":"https://api.github.com/repos/massiveart/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/massiveart/sulu/deployments","created_at":"2015-03-30T15:00:41Z","updated_at":"2015-04-24T07:15:08Z","pushed_at":"2016-06-23T07:26:25Z","git_url":"git://github.com/massiveart/sulu.git","ssh_url":"git@github.com:massiveart/sulu.git","clone_url":"https://github.com/massiveart/sulu.git","svn_url":"https://github.com/massiveart/sulu","homepage":"www.sulu.io","size":68559,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sulu:master","ref":"master","sha":"5d523918bbe196842a35f538e91b2ebf967b2694","user":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu/sulu","owner":{"login":"sulu","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu","html_url":"https://github.com/sulu","followers_url":"https://api.github.com/users/sulu/followers","following_url":"https://api.github.com/users/sulu/following{/other_user}","gists_url":"https://api.github.com/users/sulu/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu/subscriptions","organizations_url":"https://api.github.com/users/sulu/orgs","repos_url":"https://api.github.com/users/sulu/repos","events_url":"https://api.github.com/users/sulu/events{/privacy}","received_events_url":"https://api.github.com/users/sulu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu/sulu","description":"Sulu core bundles & components","fork":false,"url":"https://api.github.com/repos/sulu/sulu","forks_url":"https://api.github.com/repos/sulu/sulu/forks","keys_url":"https://api.github.com/repos/sulu/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu/sulu/teams","hooks_url":"https://api.github.com/repos/sulu/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu/sulu/events","assignees_url":"https://api.github.com/repos/sulu/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu/sulu/tags","blobs_url":"https://api.github.com/repos/sulu/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu/sulu/subscription","commits_url":"https://api.github.com/repos/sulu/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu/sulu/issues/comments{/number}","contents_url":"https://api.github.com/repos/sulu/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu/sulu/merges","archive_url":"https://api.github.com/repos/sulu/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu/sulu/downloads","issues_url":"https://api.github.com/repos/sulu/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu/sulu/releases{/id}","deployments_url":"https://api.github.com/repos/sulu/sulu/deployments","created_at":"2013-10-18T12:57:02Z","updated_at":"2016-06-09T05:19:04Z","pushed_at":"2016-06-23T07:26:26Z","git_url":"git://github.com/sulu/sulu.git","ssh_url":"git@github.com:sulu/sulu.git","clone_url":"https://github.com/sulu/sulu.git","svn_url":"https://github.com/sulu/sulu","homepage":"sulu.io","size":80913,"stargazers_count":127,"watchers_count":127,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":399,"forks":42,"open_issues":399,"watchers":127,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2498"},"html":{"href":"https://github.com/sulu/sulu/pull/2498"},"issue":{"href":"https://api.github.com/repos/sulu/sulu/issues/2498"},"comments":{"href":"https://api.github.com/repos/sulu/sulu/issues/2498/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2498/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu/sulu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sulu/sulu/pulls/2498/commits"},"statuses":{"href":"https://api.github.com/repos/sulu/sulu/statuses/3a6d8abda0375cc0c3a7d1a80c5aeeb289ec047d"}}}}
{"actor":{"display_login":"wachterjohannes"}}