{"action":"created","comment":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/85286343","pull_request_review_id":6009908,"id":85286343,"diff_hunk":"@@ -100,6 +100,7 @@ private static bool IsJsonType(string contentType)\n             return contentMimeType.Equals(\"application/json\", StringComparison.OrdinalIgnoreCase) ||\r\n                 contentMimeType.StartsWith(\"application/json-\", StringComparison.OrdinalIgnoreCase) ||\r\n                 contentMimeType.Equals(\"text/json\", StringComparison.OrdinalIgnoreCase) ||\r\n+                contentMimeType.Equals(\"application/problem+json\", StringComparison.OrdinalIgnoreCase) ||\r\n                 (contentMimeType.StartsWith(\"application/vnd\", StringComparison.OrdinalIgnoreCase) &&\r","path":"src/Nancy/Responses/DefaultJsonSerializer.cs","position":5,"original_position":5,"commit_id":"d493b64ecad1c664ece07fbd80989a5e8373716b","original_commit_id":"d493b64ecad1c664ece07fbd80989a5e8373716b","user":{"login":"wilhen01","id":4677718,"avatar_url":"https://avatars.githubusercontent.com/u/4677718?v=3","gravatar_id":"","url":"https://api.github.com/users/wilhen01","html_url":"https://github.com/wilhen01","followers_url":"https://api.github.com/users/wilhen01/followers","following_url":"https://api.github.com/users/wilhen01/following{/other_user}","gists_url":"https://api.github.com/users/wilhen01/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhen01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhen01/subscriptions","organizations_url":"https://api.github.com/users/wilhen01/orgs","repos_url":"https://api.github.com/users/wilhen01/repos","events_url":"https://api.github.com/users/wilhen01/events{/privacy}","received_events_url":"https://api.github.com/users/wilhen01/received_events","type":"User","site_admin":false},"body":"I think it's technically correct In terms of the spec (or at least convention) on MIME types - custom types should always start with `application/vnd` to indicate a vendor-specific type. I guess in terms of what a serializer cares about it's just a question of whether it's a JSON type rather than wether it's a valid MIME type. I'll look at changing this and adding some tests. ","created_at":"2016-10-27T08:11:14Z","updated_at":"2016-10-27T08:11:14Z","html_url":"https://github.com/NancyFx/Nancy/pull/2601#discussion_r85286343","pull_request_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601","_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments/85286343"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2601#discussion_r85286343"},"pull_request":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601"}}},"pull_request":{"url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601","id":91022485,"html_url":"https://github.com/NancyFx/Nancy/pull/2601","diff_url":"https://github.com/NancyFx/Nancy/pull/2601.diff","patch_url":"https://github.com/NancyFx/Nancy/pull/2601.patch","issue_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2601","number":2601,"state":"open","locked":false,"title":"Added support for application/problem media types","user":{"login":"wilhen01","id":4677718,"avatar_url":"https://avatars.githubusercontent.com/u/4677718?v=3","gravatar_id":"","url":"https://api.github.com/users/wilhen01","html_url":"https://github.com/wilhen01","followers_url":"https://api.github.com/users/wilhen01/followers","following_url":"https://api.github.com/users/wilhen01/following{/other_user}","gists_url":"https://api.github.com/users/wilhen01/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhen01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhen01/subscriptions","organizations_url":"https://api.github.com/users/wilhen01/orgs","repos_url":"https://api.github.com/users/wilhen01/repos","events_url":"https://api.github.com/users/wilhen01/events{/privacy}","received_events_url":"https://api.github.com/users/wilhen01/received_events","type":"User","site_admin":false},"body":"### Prerequisites\r\n\r\n- [x] I have written a descriptive pull-request title\r\n- [x] I have verified that there are no overlapping [pull-requests](https://github.com/NancyFx/Nancy/pulls) open\r\n- [x] I have verified that I am following the Nancy [code style guidelines](https://github.com/NancyFx/Nancy/blob/45238076ad0b7f6ecabd6bae8469e30458d02efe/CONTRIBUTING.md#style-guidelines)\r\n- [ ] I have provided test coverage for my change (where applicable)\r\n\r\n### Description\r\nAdded support for the `application/problem+json` and `application/problem+xml` media types defined in [RFC7808](https://tools.ietf.org/html/rfc7807). While this RFC is still proposed rather than agreed, APIs are already using the type in question (e.g. Mailchimp). \r\n\r\nRe: test coverage, I was intending to write a unit tests to cover the changes but I couldn't work out the best place to put them (there doesn't appear to be a suite to cover the `IsJsonType` and `IsXmlType` methods changed). If someone can point me to where the tests should live I'll happily add some 😄 \r\n","created_at":"2016-10-26T14:59:30Z","updated_at":"2016-10-27T08:11:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32f5f83cb512570d009ff9b9802912a2a8d9ee0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601/commits","review_comments_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601/comments","review_comment_url":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/issues/2601/comments","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/d493b64ecad1c664ece07fbd80989a5e8373716b","head":{"label":"wilhen01:application-problem-mediatype","ref":"application-problem-mediatype","sha":"d493b64ecad1c664ece07fbd80989a5e8373716b","user":{"login":"wilhen01","id":4677718,"avatar_url":"https://avatars.githubusercontent.com/u/4677718?v=3","gravatar_id":"","url":"https://api.github.com/users/wilhen01","html_url":"https://github.com/wilhen01","followers_url":"https://api.github.com/users/wilhen01/followers","following_url":"https://api.github.com/users/wilhen01/following{/other_user}","gists_url":"https://api.github.com/users/wilhen01/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhen01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhen01/subscriptions","organizations_url":"https://api.github.com/users/wilhen01/orgs","repos_url":"https://api.github.com/users/wilhen01/repos","events_url":"https://api.github.com/users/wilhen01/events{/privacy}","received_events_url":"https://api.github.com/users/wilhen01/received_events","type":"User","site_admin":false},"repo":{"id":71907182,"name":"Nancy","full_name":"wilhen01/Nancy","owner":{"login":"wilhen01","id":4677718,"avatar_url":"https://avatars.githubusercontent.com/u/4677718?v=3","gravatar_id":"","url":"https://api.github.com/users/wilhen01","html_url":"https://github.com/wilhen01","followers_url":"https://api.github.com/users/wilhen01/followers","following_url":"https://api.github.com/users/wilhen01/following{/other_user}","gists_url":"https://api.github.com/users/wilhen01/gists{/gist_id}","starred_url":"https://api.github.com/users/wilhen01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilhen01/subscriptions","organizations_url":"https://api.github.com/users/wilhen01/orgs","repos_url":"https://api.github.com/users/wilhen01/repos","events_url":"https://api.github.com/users/wilhen01/events{/privacy}","received_events_url":"https://api.github.com/users/wilhen01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wilhen01/Nancy","description":"Lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":true,"url":"https://api.github.com/repos/wilhen01/Nancy","forks_url":"https://api.github.com/repos/wilhen01/Nancy/forks","keys_url":"https://api.github.com/repos/wilhen01/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wilhen01/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wilhen01/Nancy/teams","hooks_url":"https://api.github.com/repos/wilhen01/Nancy/hooks","issue_events_url":"https://api.github.com/repos/wilhen01/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/wilhen01/Nancy/events","assignees_url":"https://api.github.com/repos/wilhen01/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/wilhen01/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/wilhen01/Nancy/tags","blobs_url":"https://api.github.com/repos/wilhen01/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wilhen01/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wilhen01/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/wilhen01/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wilhen01/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/wilhen01/Nancy/languages","stargazers_url":"https://api.github.com/repos/wilhen01/Nancy/stargazers","contributors_url":"https://api.github.com/repos/wilhen01/Nancy/contributors","subscribers_url":"https://api.github.com/repos/wilhen01/Nancy/subscribers","subscription_url":"https://api.github.com/repos/wilhen01/Nancy/subscription","commits_url":"https://api.github.com/repos/wilhen01/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/wilhen01/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/wilhen01/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/wilhen01/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/wilhen01/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/wilhen01/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wilhen01/Nancy/merges","archive_url":"https://api.github.com/repos/wilhen01/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wilhen01/Nancy/downloads","issues_url":"https://api.github.com/repos/wilhen01/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/wilhen01/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/wilhen01/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/wilhen01/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wilhen01/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/wilhen01/Nancy/releases{/id}","deployments_url":"https://api.github.com/repos/wilhen01/Nancy/deployments","created_at":"2016-10-25T14:46:54Z","updated_at":"2016-10-25T14:46:58Z","pushed_at":"2016-10-26T14:54:01Z","git_url":"git://github.com/wilhen01/Nancy.git","ssh_url":"git@github.com:wilhen01/Nancy.git","clone_url":"https://github.com/wilhen01/Nancy.git","svn_url":"https://github.com/wilhen01/Nancy","homepage":"http://nancyfx.org","size":44674,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NancyFx:master","ref":"master","sha":"efe6461162991c5bb2f1621132649c089abc6966","user":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"repo":{"id":738250,"name":"Nancy","full_name":"NancyFx/Nancy","owner":{"login":"NancyFx","id":706659,"avatar_url":"https://avatars.githubusercontent.com/u/706659?v=3","gravatar_id":"","url":"https://api.github.com/users/NancyFx","html_url":"https://github.com/NancyFx","followers_url":"https://api.github.com/users/NancyFx/followers","following_url":"https://api.github.com/users/NancyFx/following{/other_user}","gists_url":"https://api.github.com/users/NancyFx/gists{/gist_id}","starred_url":"https://api.github.com/users/NancyFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NancyFx/subscriptions","organizations_url":"https://api.github.com/users/NancyFx/orgs","repos_url":"https://api.github.com/users/NancyFx/repos","events_url":"https://api.github.com/users/NancyFx/events{/privacy}","received_events_url":"https://api.github.com/users/NancyFx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NancyFx/Nancy","description":"Lightweight, low-ceremony, framework for building HTTP based services on .Net and Mono","fork":false,"url":"https://api.github.com/repos/NancyFx/Nancy","forks_url":"https://api.github.com/repos/NancyFx/Nancy/forks","keys_url":"https://api.github.com/repos/NancyFx/Nancy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NancyFx/Nancy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NancyFx/Nancy/teams","hooks_url":"https://api.github.com/repos/NancyFx/Nancy/hooks","issue_events_url":"https://api.github.com/repos/NancyFx/Nancy/issues/events{/number}","events_url":"https://api.github.com/repos/NancyFx/Nancy/events","assignees_url":"https://api.github.com/repos/NancyFx/Nancy/assignees{/user}","branches_url":"https://api.github.com/repos/NancyFx/Nancy/branches{/branch}","tags_url":"https://api.github.com/repos/NancyFx/Nancy/tags","blobs_url":"https://api.github.com/repos/NancyFx/Nancy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NancyFx/Nancy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NancyFx/Nancy/git/refs{/sha}","trees_url":"https://api.github.com/repos/NancyFx/Nancy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NancyFx/Nancy/statuses/{sha}","languages_url":"https://api.github.com/repos/NancyFx/Nancy/languages","stargazers_url":"https://api.github.com/repos/NancyFx/Nancy/stargazers","contributors_url":"https://api.github.com/repos/NancyFx/Nancy/contributors","subscribers_url":"https://api.github.com/repos/NancyFx/Nancy/subscribers","subscription_url":"https://api.github.com/repos/NancyFx/Nancy/subscription","commits_url":"https://api.github.com/repos/NancyFx/Nancy/commits{/sha}","git_commits_url":"https://api.github.com/repos/NancyFx/Nancy/git/commits{/sha}","comments_url":"https://api.github.com/repos/NancyFx/Nancy/comments{/number}","issue_comment_url":"https://api.github.com/repos/NancyFx/Nancy/issues/comments{/number}","contents_url":"https://api.github.com/repos/NancyFx/Nancy/contents/{+path}","compare_url":"https://api.github.com/repos/NancyFx/Nancy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NancyFx/Nancy/merges","archive_url":"https://api.github.com/repos/NancyFx/Nancy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NancyFx/Nancy/downloads","issues_url":"https://api.github.com/repos/NancyFx/Nancy/issues{/number}","pulls_url":"https://api.github.com/repos/NancyFx/Nancy/pulls{/number}","milestones_url":"https://api.github.com/repos/NancyFx/Nancy/milestones{/number}","notifications_url":"https://api.github.com/repos/NancyFx/Nancy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NancyFx/Nancy/labels{/name}","releases_url":"https://api.github.com/repos/NancyFx/Nancy/releases{/id}","deployments_url":"https://api.github.com/repos/NancyFx/Nancy/deployments","created_at":"2010-06-24T19:35:22Z","updated_at":"2016-10-27T01:15:54Z","pushed_at":"2016-10-26T14:59:30Z","git_url":"git://github.com/NancyFx/Nancy.git","ssh_url":"git@github.com:NancyFx/Nancy.git","clone_url":"https://github.com/NancyFx/Nancy.git","svn_url":"https://github.com/NancyFx/Nancy","homepage":"http://nancyfx.org","size":65322,"stargazers_count":4586,"watchers_count":4586,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1145,"mirror_url":null,"open_issues_count":169,"forks":1145,"open_issues":169,"watchers":4586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601"},"html":{"href":"https://github.com/NancyFx/Nancy/pull/2601"},"issue":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2601"},"comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/issues/2601/comments"},"review_comments":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601/comments"},"review_comment":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NancyFx/Nancy/pulls/2601/commits"},"statuses":{"href":"https://api.github.com/repos/NancyFx/Nancy/statuses/d493b64ecad1c664ece07fbd80989a5e8373716b"}}}}
{"actor":{"display_login":"wilhen01"}}