{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/67758710","id":67758710,"diff_hunk":"@@ -31,6 +31,13 @@ Resource Group Properties\n   group may use before new queries become queued. May be specified as\n   an absolute value (i.e. ``1GB``) or as a percentage (i.e. ``10%``) of the cluster's memory.\n \n+* ``softCpuLimit`` (optional): maximum amount of CPU time this\n+  group may use in a period (see ``cpuQuotaPeriod``) before a penalty will be applied to\n+  the maximum number of running queries.\n+\n+* ``hardCpuLimit`` (optional): maximum amount of CPU time this\n+  group may use in a period.","path":"presto-docs/src/main/sphinx/admin/resource-groups.rst","position":9,"original_position":9,"commit_id":"f8ac9612fda2d67b35e01da88fac0250dd8738f4","original_commit_id":"f8ac9612fda2d67b35e01da88fac0250dd8738f4","user":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"body":"document that soft limit without hard limit is mostly useless","created_at":"2016-06-20T20:18:54Z","updated_at":"2016-06-20T20:18:54Z","html_url":"https://github.com/prestodb/presto/pull/5468#discussion_r67758710","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/5468","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/67758710"},"html":{"href":"https://github.com/prestodb/presto/pull/5468#discussion_r67758710"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5468"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/5468","id":74307407,"html_url":"https://github.com/prestodb/presto/pull/5468","diff_url":"https://github.com/prestodb/presto/pull/5468.diff","patch_url":"https://github.com/prestodb/presto/pull/5468.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/5468","number":5468,"state":"open","locked":false,"title":"Add CPU limits to resource groups","user":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-17T21:25:15Z","updated_at":"2016-06-20T20:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9409d78b869080a50c55bb6c6d5676b78775e9d7","assignee":{"login":"dain","id":58298,"avatar_url":"https://avatars.githubusercontent.com/u/58298?v=3","gravatar_id":"","url":"https://api.github.com/users/dain","html_url":"https://github.com/dain","followers_url":"https://api.github.com/users/dain/followers","following_url":"https://api.github.com/users/dain/following{/other_user}","gists_url":"https://api.github.com/users/dain/gists{/gist_id}","starred_url":"https://api.github.com/users/dain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dain/subscriptions","organizations_url":"https://api.github.com/users/dain/orgs","repos_url":"https://api.github.com/users/dain/repos","events_url":"https://api.github.com/users/dain/events{/privacy}","received_events_url":"https://api.github.com/users/dain/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/5468/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/5468/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/5468/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/f8ac9612fda2d67b35e01da88fac0250dd8738f4","head":{"label":"cberner:quota","ref":"quota","sha":"f8ac9612fda2d67b35e01da88fac0250dd8738f4","user":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"repo":{"id":10272630,"name":"presto","full_name":"cberner/presto","owner":{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cberner/presto","description":"","fork":true,"url":"https://api.github.com/repos/cberner/presto","forks_url":"https://api.github.com/repos/cberner/presto/forks","keys_url":"https://api.github.com/repos/cberner/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cberner/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cberner/presto/teams","hooks_url":"https://api.github.com/repos/cberner/presto/hooks","issue_events_url":"https://api.github.com/repos/cberner/presto/issues/events{/number}","events_url":"https://api.github.com/repos/cberner/presto/events","assignees_url":"https://api.github.com/repos/cberner/presto/assignees{/user}","branches_url":"https://api.github.com/repos/cberner/presto/branches{/branch}","tags_url":"https://api.github.com/repos/cberner/presto/tags","blobs_url":"https://api.github.com/repos/cberner/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cberner/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cberner/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/cberner/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cberner/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/cberner/presto/languages","stargazers_url":"https://api.github.com/repos/cberner/presto/stargazers","contributors_url":"https://api.github.com/repos/cberner/presto/contributors","subscribers_url":"https://api.github.com/repos/cberner/presto/subscribers","subscription_url":"https://api.github.com/repos/cberner/presto/subscription","commits_url":"https://api.github.com/repos/cberner/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/cberner/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/cberner/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/cberner/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/cberner/presto/contents/{+path}","compare_url":"https://api.github.com/repos/cberner/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cberner/presto/merges","archive_url":"https://api.github.com/repos/cberner/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cberner/presto/downloads","issues_url":"https://api.github.com/repos/cberner/presto/issues{/number}","pulls_url":"https://api.github.com/repos/cberner/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/cberner/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/cberner/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cberner/presto/labels{/name}","releases_url":"https://api.github.com/repos/cberner/presto/releases{/id}","deployments_url":"https://api.github.com/repos/cberner/presto/deployments","created_at":"2013-05-24T18:37:52Z","updated_at":"2016-03-18T20:43:12Z","pushed_at":"2016-06-20T14:30:47Z","git_url":"git://github.com/cberner/presto.git","ssh_url":"git@github.com:cberner/presto.git","clone_url":"https://github.com/cberner/presto.git","svn_url":"https://github.com/cberner/presto","homepage":null,"size":54069,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"c39f69ab2a83eea4c8f9453e2a8ce77f6c8111ff","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2016-06-20T13:40:12Z","pushed_at":"2016-06-20T20:04:14Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":155230,"stargazers_count":4835,"watchers_count":4835,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1447,"mirror_url":null,"open_issues_count":556,"forks":1447,"open_issues":556,"watchers":4835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5468"},"html":{"href":"https://github.com/prestodb/presto/pull/5468"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/5468"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/5468/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5468/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/5468/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/f8ac9612fda2d67b35e01da88fac0250dd8738f4"}}}}
{"actor":{"display_login":"dain"}}