{"action":"created","comment":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/93199016","pull_request_review_id":13720256,"id":93199016,"diff_hunk":"@@ -337,6 +337,20 @@ Feature: Downloading things from a website.\n         And I open the download with a placeholder\n         Then \"Opening *download.bin* with [*python*]\" should be logged\n \n+    Scenario: Opening a download with default-open-dispatcher set\n+        When I set general -> default-open-dispatcher to python {} -c \"import sys; print(sys.argv[1])\"","path":"tests/end2end/features/downloads.feature","position":5,"original_position":5,"commit_id":"3d8dedc48bee1bf54c5ba11c82ca97e51a61ec3f","original_commit_id":"3d8dedc48bee1bf54c5ba11c82ca97e51a61ec3f","user":{"login":"swalladge","id":9714796,"avatar_url":"https://avatars.githubusercontent.com/u/9714796?v=3","gravatar_id":"","url":"https://api.github.com/users/swalladge","html_url":"https://github.com/swalladge","followers_url":"https://api.github.com/users/swalladge/followers","following_url":"https://api.github.com/users/swalladge/following{/other_user}","gists_url":"https://api.github.com/users/swalladge/gists{/gist_id}","starred_url":"https://api.github.com/users/swalladge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalladge/subscriptions","organizations_url":"https://api.github.com/users/swalladge/orgs","repos_url":"https://api.github.com/users/swalladge/repos","events_url":"https://api.github.com/users/swalladge/events{/privacy}","received_events_url":"https://api.github.com/users/swalladge/received_events","type":"User","site_admin":false},"body":"Is this just so it uses the correct version of python for testing? Because it practice you shouldn't have to enter the full path to executables.","created_at":"2016-12-20T09:31:30Z","updated_at":"2016-12-20T09:31:30Z","html_url":"https://github.com/The-Compiler/qutebrowser/pull/2175#discussion_r93199016","pull_request_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175","_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments/93199016"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/2175#discussion_r93199016"},"pull_request":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175"}}},"pull_request":{"url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175","id":98319963,"html_url":"https://github.com/The-Compiler/qutebrowser/pull/2175","diff_url":"https://github.com/The-Compiler/qutebrowser/pull/2175.diff","patch_url":"https://github.com/The-Compiler/qutebrowser/pull/2175.patch","issue_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2175","number":2175,"state":"open","locked":false,"title":"implement optional download-open handler setting","user":{"login":"swalladge","id":9714796,"avatar_url":"https://avatars.githubusercontent.com/u/9714796?v=3","gravatar_id":"","url":"https://api.github.com/users/swalladge","html_url":"https://github.com/swalladge","followers_url":"https://api.github.com/users/swalladge/followers","following_url":"https://api.github.com/users/swalladge/following{/other_user}","gists_url":"https://api.github.com/users/swalladge/gists{/gist_id}","starred_url":"https://api.github.com/users/swalladge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalladge/subscriptions","organizations_url":"https://api.github.com/users/swalladge/orgs","repos_url":"https://api.github.com/users/swalladge/repos","events_url":"https://api.github.com/users/swalladge/events{/privacy}","received_events_url":"https://api.github.com/users/swalladge/received_events","type":"User","site_admin":false},"body":"- adds new `general` -> `default-open-dispatcher` setting (string)\r\n- if set, will be used instead of QDesktopServices.openUrl - (xdg-open backend)\r\n- fixes the 'download handlers' part of issue #841\r\n- note that this is only relevent to the `:download-open` command and other\r\n  methods of opening downloaded files from qutebrowser","created_at":"2016-12-16T11:32:34Z","updated_at":"2016-12-20T09:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"253df5a93aa2dd7f6b3b5b7715b112c98e0c0d38","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175/commits","review_comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175/comments","review_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2175/comments","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/3d8dedc48bee1bf54c5ba11c82ca97e51a61ec3f","head":{"label":"swalladge:master","ref":"master","sha":"3d8dedc48bee1bf54c5ba11c82ca97e51a61ec3f","user":{"login":"swalladge","id":9714796,"avatar_url":"https://avatars.githubusercontent.com/u/9714796?v=3","gravatar_id":"","url":"https://api.github.com/users/swalladge","html_url":"https://github.com/swalladge","followers_url":"https://api.github.com/users/swalladge/followers","following_url":"https://api.github.com/users/swalladge/following{/other_user}","gists_url":"https://api.github.com/users/swalladge/gists{/gist_id}","starred_url":"https://api.github.com/users/swalladge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalladge/subscriptions","organizations_url":"https://api.github.com/users/swalladge/orgs","repos_url":"https://api.github.com/users/swalladge/repos","events_url":"https://api.github.com/users/swalladge/events{/privacy}","received_events_url":"https://api.github.com/users/swalladge/received_events","type":"User","site_admin":false},"repo":{"id":76627307,"name":"qutebrowser","full_name":"swalladge/qutebrowser","owner":{"login":"swalladge","id":9714796,"avatar_url":"https://avatars.githubusercontent.com/u/9714796?v=3","gravatar_id":"","url":"https://api.github.com/users/swalladge","html_url":"https://github.com/swalladge","followers_url":"https://api.github.com/users/swalladge/followers","following_url":"https://api.github.com/users/swalladge/following{/other_user}","gists_url":"https://api.github.com/users/swalladge/gists{/gist_id}","starred_url":"https://api.github.com/users/swalladge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalladge/subscriptions","organizations_url":"https://api.github.com/users/swalladge/orgs","repos_url":"https://api.github.com/users/swalladge/repos","events_url":"https://api.github.com/users/swalladge/events{/privacy}","received_events_url":"https://api.github.com/users/swalladge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swalladge/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":true,"url":"https://api.github.com/repos/swalladge/qutebrowser","forks_url":"https://api.github.com/repos/swalladge/qutebrowser/forks","keys_url":"https://api.github.com/repos/swalladge/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swalladge/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swalladge/qutebrowser/teams","hooks_url":"https://api.github.com/repos/swalladge/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/swalladge/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/swalladge/qutebrowser/events","assignees_url":"https://api.github.com/repos/swalladge/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/swalladge/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/swalladge/qutebrowser/tags","blobs_url":"https://api.github.com/repos/swalladge/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swalladge/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swalladge/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/swalladge/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swalladge/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/swalladge/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/swalladge/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/swalladge/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/swalladge/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/swalladge/qutebrowser/subscription","commits_url":"https://api.github.com/repos/swalladge/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/swalladge/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/swalladge/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/swalladge/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/swalladge/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/swalladge/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swalladge/qutebrowser/merges","archive_url":"https://api.github.com/repos/swalladge/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swalladge/qutebrowser/downloads","issues_url":"https://api.github.com/repos/swalladge/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/swalladge/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/swalladge/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/swalladge/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swalladge/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/swalladge/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/swalladge/qutebrowser/deployments","created_at":"2016-12-16T06:18:03Z","updated_at":"2016-12-16T06:18:06Z","pushed_at":"2016-12-20T01:42:18Z","git_url":"git://github.com/swalladge/qutebrowser.git","ssh_url":"git@github.com:swalladge/qutebrowser.git","clone_url":"https://github.com/swalladge/qutebrowser.git","svn_url":"https://github.com/swalladge/qutebrowser","homepage":"https://www.qutebrowser.org/","size":21362,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"The-Compiler:master","ref":"master","sha":"e1b5f6a64e3933ff880b300620fd0f9873811008","user":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"The-Compiler/qutebrowser","owner":{"login":"The-Compiler","id":625793,"avatar_url":"https://avatars.githubusercontent.com/u/625793?v=3","gravatar_id":"","url":"https://api.github.com/users/The-Compiler","html_url":"https://github.com/The-Compiler","followers_url":"https://api.github.com/users/The-Compiler/followers","following_url":"https://api.github.com/users/The-Compiler/following{/other_user}","gists_url":"https://api.github.com/users/The-Compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Compiler/subscriptions","organizations_url":"https://api.github.com/users/The-Compiler/orgs","repos_url":"https://api.github.com/users/The-Compiler/repos","events_url":"https://api.github.com/users/The-Compiler/events{/privacy}","received_events_url":"https://api.github.com/users/The-Compiler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Compiler/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":false,"url":"https://api.github.com/repos/The-Compiler/qutebrowser","forks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/forks","keys_url":"https://api.github.com/repos/The-Compiler/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Compiler/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Compiler/qutebrowser/teams","hooks_url":"https://api.github.com/repos/The-Compiler/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/The-Compiler/qutebrowser/events","assignees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/The-Compiler/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/tags","blobs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Compiler/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/The-Compiler/qutebrowser/subscription","commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Compiler/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Compiler/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/The-Compiler/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Compiler/qutebrowser/merges","archive_url":"https://api.github.com/repos/The-Compiler/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Compiler/qutebrowser/downloads","issues_url":"https://api.github.com/repos/The-Compiler/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Compiler/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Compiler/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Compiler/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/The-Compiler/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/The-Compiler/qutebrowser/deployments","created_at":"2014-06-26T14:59:34Z","updated_at":"2016-12-18T17:24:22Z","pushed_at":"2016-12-20T01:42:20Z","git_url":"git://github.com/The-Compiler/qutebrowser.git","ssh_url":"git@github.com:The-Compiler/qutebrowser.git","clone_url":"https://github.com/The-Compiler/qutebrowser.git","svn_url":"https://github.com/The-Compiler/qutebrowser","homepage":"https://www.qutebrowser.org/","size":21315,"stargazers_count":1641,"watchers_count":1641,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":240,"mirror_url":null,"open_issues_count":457,"forks":240,"open_issues":457,"watchers":1641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175"},"html":{"href":"https://github.com/The-Compiler/qutebrowser/pull/2175"},"issue":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2175"},"comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/issues/2175/comments"},"review_comments":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175/comments"},"review_comment":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/pulls/2175/commits"},"statuses":{"href":"https://api.github.com/repos/The-Compiler/qutebrowser/statuses/3d8dedc48bee1bf54c5ba11c82ca97e51a61ec3f"}}}}
{"actor":{"display_login":"swalladge"}}