{"action":"created","issue":{"url":"https://api.github.com/repos/qTox/qTox/issues/3755","repository_url":"https://api.github.com/repos/qTox/qTox","labels_url":"https://api.github.com/repos/qTox/qTox/issues/3755/labels{/name}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/3755/comments","events_url":"https://api.github.com/repos/qTox/qTox/issues/3755/events","html_url":"https://github.com/qTox/qTox/pull/3755","id":179672178,"number":3755,"title":"fix(settings): Play test sound when user enables test sound","user":{"login":"AliceGrey","id":8949059,"avatar_url":"https://avatars.githubusercontent.com/u/8949059?v=3","gravatar_id":"","url":"https://api.github.com/users/AliceGrey","html_url":"https://github.com/AliceGrey","followers_url":"https://api.github.com/users/AliceGrey/followers","following_url":"https://api.github.com/users/AliceGrey/following{/other_user}","gists_url":"https://api.github.com/users/AliceGrey/gists{/gist_id}","starred_url":"https://api.github.com/users/AliceGrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AliceGrey/subscriptions","organizations_url":"https://api.github.com/users/AliceGrey/orgs","repos_url":"https://api.github.com/users/AliceGrey/repos","events_url":"https://api.github.com/users/AliceGrey/events{/privacy}","received_events_url":"https://api.github.com/users/AliceGrey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-09-28T03:30:33Z","updated_at":"2016-10-06T18:20:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qTox/qTox/pulls/3755","html_url":"https://github.com/qTox/qTox/pull/3755","diff_url":"https://github.com/qTox/qTox/pull/3755.diff","patch_url":"https://github.com/qTox/qTox/pull/3755.patch"},"body":"Fixes #3735\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qtox/qtox/3755)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/qTox/qTox/issues/comments/252046183","html_url":"https://github.com/qTox/qTox/pull/3755#issuecomment-252046183","issue_url":"https://api.github.com/repos/qTox/qTox/issues/3755","id":252046183,"user":{"login":"sudden6","id":5585762,"avatar_url":"https://avatars.githubusercontent.com/u/5585762?v=3","gravatar_id":"","url":"https://api.github.com/users/sudden6","html_url":"https://github.com/sudden6","followers_url":"https://api.github.com/users/sudden6/followers","following_url":"https://api.github.com/users/sudden6/following{/other_user}","gists_url":"https://api.github.com/users/sudden6/gists{/gist_id}","starred_url":"https://api.github.com/users/sudden6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudden6/subscriptions","organizations_url":"https://api.github.com/users/sudden6/orgs","repos_url":"https://api.github.com/users/sudden6/repos","events_url":"https://api.github.com/users/sudden6/events{/privacy}","received_events_url":"https://api.github.com/users/sudden6/received_events","type":"User","site_admin":false},"created_at":"2016-10-06T18:20:02Z","updated_at":"2016-10-06T18:20:02Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[src/audio/audio.h, line 54 at r3](https://reviewable.io:443/reviews/qtox/qtox/3755#-KTQ23N59WYVg99z1eZv:-KTQD-VSICJkGZ5gRJ5-:b-jqtz9j) ([raw file](https://github.com/qtox/qtox/blob/29c18426444497b9dd1ba527f35401e2bb8dafd3/src/audio/audio.h#L54)):*\n<details><summary><i>Previously, Diadlo (Diadlo) wrote…</i></summary>\n> I not sure, that enum by [coding-style](https://github.com/qTox/qTox/blob/master/CONTRIBUTING.md#coding-style) should be in one line. @sudden6, @initramfs, what you think?\n> \n> Also, please, add [documentntation](https://github.com/qTox/qTox/blob/master/CONTRIBUTING.md#documentaion) to new enum class and method\n</details>\nIf the enum doesn't have explicit values set, I don't see a problem with it.\n\n---\n\n*[src/audio/audio.h, line 58 at r3](https://reviewable.io:443/reviews/qtox/qtox/3755#-KTQ327Z2FjjJjDEcHRn:-KTQD8UO8mA6m2ZFRD4P:b-kqjzyd) ([raw file](https://github.com/qtox/qtox/blob/29c18426444497b9dd1ba527f35401e2bb8dafd3/src/audio/audio.h#L58)):*\n<details><summary><i>Previously, Diadlo (Diadlo) wrote…</i></summary>\n> @sudden6, @initramfs What about new line here?\n> @initramfs, how are things progressing with the clang-format?\n</details>\nafter the `:` of  a case statement there should be a new line IMHO.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/qtox/qtox/3755)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"sudden6"}}