{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/87513604","pull_request_review_id":8125028,"id":87513604,"diff_hunk":"@@ -258,7 +258,9 @@ def _check_pub_data(self, pub_data):\n             )\n \n         # Failed to connect to the master and send the pub\n-        if 'jid' not in pub_data:\n+        if 'error' in pub_data:\n+            print(pub_data['error'])","path":"salt/client/__init__.py","position":15,"original_position":15,"commit_id":"84ab917b1de3935adefde4bfa0b175774af15998","original_commit_id":"84ab917b1de3935adefde4bfa0b175774af15998","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"I agree that would be better but it's a job for a different PR.","created_at":"2016-11-11T00:02:42Z","updated_at":"2016-11-11T00:02:42Z","html_url":"https://github.com/saltstack/salt/pull/37146#discussion_r87513604","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/37146","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/87513604"},"html":{"href":"https://github.com/saltstack/salt/pull/37146#discussion_r87513604"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/37146"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/37146","id":90369137,"html_url":"https://github.com/saltstack/salt/pull/37146","diff_url":"https://github.com/saltstack/salt/pull/37146.diff","patch_url":"https://github.com/saltstack/salt/pull/37146.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/37146","number":37146,"state":"open","locked":false,"title":"Master publish error reporting","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-21T11:41:39Z","updated_at":"2016-11-11T00:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e1b6a694c68f746b85664063e064202259db954","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/37146/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/37146/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/37146/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/84ab917b1de3935adefde4bfa0b175774af15998","head":{"label":"cachedout:master_pub_error_reporting","ref":"master_pub_error_reporting","sha":"84ab917b1de3935adefde4bfa0b175774af15998","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"repo":{"id":13233022,"name":"salt","full_name":"cachedout/salt","owner":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cachedout/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/cachedout/salt","forks_url":"https://api.github.com/repos/cachedout/salt/forks","keys_url":"https://api.github.com/repos/cachedout/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cachedout/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cachedout/salt/teams","hooks_url":"https://api.github.com/repos/cachedout/salt/hooks","issue_events_url":"https://api.github.com/repos/cachedout/salt/issues/events{/number}","events_url":"https://api.github.com/repos/cachedout/salt/events","assignees_url":"https://api.github.com/repos/cachedout/salt/assignees{/user}","branches_url":"https://api.github.com/repos/cachedout/salt/branches{/branch}","tags_url":"https://api.github.com/repos/cachedout/salt/tags","blobs_url":"https://api.github.com/repos/cachedout/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cachedout/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cachedout/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/cachedout/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cachedout/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/cachedout/salt/languages","stargazers_url":"https://api.github.com/repos/cachedout/salt/stargazers","contributors_url":"https://api.github.com/repos/cachedout/salt/contributors","subscribers_url":"https://api.github.com/repos/cachedout/salt/subscribers","subscription_url":"https://api.github.com/repos/cachedout/salt/subscription","commits_url":"https://api.github.com/repos/cachedout/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/cachedout/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/cachedout/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/cachedout/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/cachedout/salt/contents/{+path}","compare_url":"https://api.github.com/repos/cachedout/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cachedout/salt/merges","archive_url":"https://api.github.com/repos/cachedout/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cachedout/salt/downloads","issues_url":"https://api.github.com/repos/cachedout/salt/issues{/number}","pulls_url":"https://api.github.com/repos/cachedout/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/cachedout/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/cachedout/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cachedout/salt/labels{/name}","releases_url":"https://api.github.com/repos/cachedout/salt/releases{/id}","deployments_url":"https://api.github.com/repos/cachedout/salt/deployments","created_at":"2013-10-01T02:32:42Z","updated_at":"2015-01-07T05:47:18Z","pushed_at":"2016-11-10T23:33:13Z","git_url":"git://github.com/cachedout/salt.git","ssh_url":"git@github.com:cachedout/salt.git","clone_url":"https://github.com/cachedout/salt.git","svn_url":"https://github.com/cachedout/salt","homepage":"saltstack.org","size":153439,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:2016.11","ref":"2016.11","sha":"7036707fbf18a6277ce2151745c39d7604ab59e2","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2016-11-10T21:00:21Z","pushed_at":"2016-11-10T23:58:41Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":231126,"stargazers_count":7034,"watchers_count":7034,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3215,"mirror_url":null,"open_issues_count":3967,"forks":3215,"open_issues":3967,"watchers":7034,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/37146"},"html":{"href":"https://github.com/saltstack/salt/pull/37146"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/37146"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/37146/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/37146/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/37146/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/84ab917b1de3935adefde4bfa0b175774af15998"}}}}
{"actor":{"display_login":"cachedout"}}