{"action":"created","comment":{"url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/comments/52090546","id":52090546,"diff_hunk":"@@ -20,13 +20,13 @@ void AbstractTemplate::ApplyMutation(const Mutation& mut)\n {\n     // if the end of the mutation is before the end of our mapping,\n     //   update the mapping\n-    if (pinEnd_ || mut.Start() < end_) end_ += mut.LengthDiff();\n+    if (pinEnd_ || mut.Start() < end_ || mut.End() <= start_) end_ += mut.LengthDiff();","path":"src/Template.cpp","position":14,"original_position":14,"commit_id":"ecad10ff8d4d99d728645c230773b78bbe7425f6","original_commit_id":"ecad10ff8d4d99d728645c230773b78bbe7425f6","user":{"login":"evolvedmicrobe","id":1330626,"avatar_url":"https://avatars.githubusercontent.com/u/1330626?v=3","gravatar_id":"","url":"https://api.github.com/users/evolvedmicrobe","html_url":"https://github.com/evolvedmicrobe","followers_url":"https://api.github.com/users/evolvedmicrobe/followers","following_url":"https://api.github.com/users/evolvedmicrobe/following{/other_user}","gists_url":"https://api.github.com/users/evolvedmicrobe/gists{/gist_id}","starred_url":"https://api.github.com/users/evolvedmicrobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evolvedmicrobe/subscriptions","organizations_url":"https://api.github.com/users/evolvedmicrobe/orgs","repos_url":"https://api.github.com/users/evolvedmicrobe/repos","events_url":"https://api.github.com/users/evolvedmicrobe/events{/privacy}","received_events_url":"https://api.github.com/users/evolvedmicrobe/received_events","type":"User","site_admin":false},"body":"Is this what causes the tests to fail, or something else?\r\n","created_at":"2016-02-06T00:16:03Z","updated_at":"2016-02-06T00:16:03Z","html_url":"https://github.com/PacificBiosciences/ConsensusCore2/pull/22#discussion_r52090546","pull_request_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/comments/52090546"},"html":{"href":"https://github.com/PacificBiosciences/ConsensusCore2/pull/22#discussion_r52090546"},"pull_request":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22","id":58476393,"html_url":"https://github.com/PacificBiosciences/ConsensusCore2/pull/22","diff_url":"https://github.com/PacificBiosciences/ConsensusCore2/pull/22.diff","patch_url":"https://github.com/PacificBiosciences/ConsensusCore2/pull/22.patch","issue_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/22","number":22,"state":"open","locked":false,"title":"don't update mappings when mut doesn't apply, match prob and asserts","user":{"login":"nlhepler","id":38372,"avatar_url":"https://avatars.githubusercontent.com/u/38372?v=3","gravatar_id":"","url":"https://api.github.com/users/nlhepler","html_url":"https://github.com/nlhepler","followers_url":"https://api.github.com/users/nlhepler/followers","following_url":"https://api.github.com/users/nlhepler/following{/other_user}","gists_url":"https://api.github.com/users/nlhepler/gists{/gist_id}","starred_url":"https://api.github.com/users/nlhepler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlhepler/subscriptions","organizations_url":"https://api.github.com/users/nlhepler/orgs","repos_url":"https://api.github.com/users/nlhepler/repos","events_url":"https://api.github.com/users/nlhepler/events{/privacy}","received_events_url":"https://api.github.com/users/nlhepler/received_events","type":"User","site_admin":false},"body":"This fixes mutations at the end and the corresponding asserts, and a borked case where the mutation wasn't in InRange but we updated the mappings anyway (a pinStart corner-case)","created_at":"2016-02-05T19:56:14Z","updated_at":"2016-02-06T00:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3983a9c75b88d5cefcb01502e4f2d10cadae4c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22/commits","review_comments_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22/comments","review_comment_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/22/comments","statuses_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/statuses/ecad10ff8d4d99d728645c230773b78bbe7425f6","head":{"label":"PacificBiosciences:fixMisc","ref":"fixMisc","sha":"ecad10ff8d4d99d728645c230773b78bbe7425f6","user":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"repo":{"id":44767613,"name":"ConsensusCore2","full_name":"PacificBiosciences/ConsensusCore2","owner":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PacificBiosciences/ConsensusCore2","description":"PacBio consensus routines with SWIG bindings (Arrow model--successor to Quiver)","fork":false,"url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2","forks_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/forks","keys_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/teams","hooks_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/hooks","issue_events_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/events{/number}","events_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/events","assignees_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/assignees{/user}","branches_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/branches{/branch}","tags_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/tags","blobs_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/statuses/{sha}","languages_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/languages","stargazers_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/stargazers","contributors_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/contributors","subscribers_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/subscribers","subscription_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/subscription","commits_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/contents/{+path}","compare_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/merges","archive_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/downloads","issues_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues{/number}","pulls_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls{/number}","milestones_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/milestones{/number}","notifications_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/labels{/name}","releases_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/releases{/id}","deployments_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/deployments","created_at":"2015-10-22T19:14:48Z","updated_at":"2016-01-15T00:40:36Z","pushed_at":"2016-02-05T23:52:20Z","git_url":"git://github.com/PacificBiosciences/ConsensusCore2.git","ssh_url":"git@github.com:PacificBiosciences/ConsensusCore2.git","clone_url":"https://github.com/PacificBiosciences/ConsensusCore2.git","svn_url":"https://github.com/PacificBiosciences/ConsensusCore2","homepage":"","size":595,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"PacificBiosciences:master","ref":"master","sha":"038bb8a3da4a431d18cb927911c2f35e6e6dcb41","user":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"repo":{"id":44767613,"name":"ConsensusCore2","full_name":"PacificBiosciences/ConsensusCore2","owner":{"login":"PacificBiosciences","id":999745,"avatar_url":"https://avatars.githubusercontent.com/u/999745?v=3","gravatar_id":"","url":"https://api.github.com/users/PacificBiosciences","html_url":"https://github.com/PacificBiosciences","followers_url":"https://api.github.com/users/PacificBiosciences/followers","following_url":"https://api.github.com/users/PacificBiosciences/following{/other_user}","gists_url":"https://api.github.com/users/PacificBiosciences/gists{/gist_id}","starred_url":"https://api.github.com/users/PacificBiosciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PacificBiosciences/subscriptions","organizations_url":"https://api.github.com/users/PacificBiosciences/orgs","repos_url":"https://api.github.com/users/PacificBiosciences/repos","events_url":"https://api.github.com/users/PacificBiosciences/events{/privacy}","received_events_url":"https://api.github.com/users/PacificBiosciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PacificBiosciences/ConsensusCore2","description":"PacBio consensus routines with SWIG bindings (Arrow model--successor to Quiver)","fork":false,"url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2","forks_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/forks","keys_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/teams","hooks_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/hooks","issue_events_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/events{/number}","events_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/events","assignees_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/assignees{/user}","branches_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/branches{/branch}","tags_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/tags","blobs_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/statuses/{sha}","languages_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/languages","stargazers_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/stargazers","contributors_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/contributors","subscribers_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/subscribers","subscription_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/subscription","commits_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/contents/{+path}","compare_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/merges","archive_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/downloads","issues_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues{/number}","pulls_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls{/number}","milestones_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/milestones{/number}","notifications_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/labels{/name}","releases_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/releases{/id}","deployments_url":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/deployments","created_at":"2015-10-22T19:14:48Z","updated_at":"2016-01-15T00:40:36Z","pushed_at":"2016-02-05T23:52:20Z","git_url":"git://github.com/PacificBiosciences/ConsensusCore2.git","ssh_url":"git@github.com:PacificBiosciences/ConsensusCore2.git","clone_url":"https://github.com/PacificBiosciences/ConsensusCore2.git","svn_url":"https://github.com/PacificBiosciences/ConsensusCore2","homepage":"","size":595,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22"},"html":{"href":"https://github.com/PacificBiosciences/ConsensusCore2/pull/22"},"issue":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/22"},"comments":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/PacificBiosciences/ConsensusCore2/statuses/ecad10ff8d4d99d728645c230773b78bbe7425f6"}}}}