{"action":"created","comment":{"url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/comments/84252828","pull_request_review_id":5039418,"id":84252828,"diff_hunk":"@@ -342,26 +370,34 @@ protected void onDestroy() {\n      * Right after this method the view will be detached. {@link #getView()} will return\n      * <code>null</code> afterwards.\n      *\n-     * @see #sleep()\n+     * @see #detachView()\n      */\n+    protected void onDetachView() {\n+        if (mCalled) {\n+            throw new IllegalAccessError(\"don't call #onSleep() directly, call #detachView()\");","path":"thirtyinch/src/main/java/net/grandcentrix/thirtyinch/TiPresenter.java","position":271,"original_position":271,"commit_id":"5f79ddda55402132f47d10216310ae26ddc6515c","original_commit_id":"5f79ddda55402132f47d10216310ae26ddc6515c","user":{"login":"StefMa","id":10229883,"avatar_url":"https://avatars.githubusercontent.com/u/10229883?v=3","gravatar_id":"","url":"https://api.github.com/users/StefMa","html_url":"https://github.com/StefMa","followers_url":"https://api.github.com/users/StefMa/followers","following_url":"https://api.github.com/users/StefMa/following{/other_user}","gists_url":"https://api.github.com/users/StefMa/gists{/gist_id}","starred_url":"https://api.github.com/users/StefMa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefMa/subscriptions","organizations_url":"https://api.github.com/users/StefMa/orgs","repos_url":"https://api.github.com/users/StefMa/repos","events_url":"https://api.github.com/users/StefMa/events{/privacy}","received_events_url":"https://api.github.com/users/StefMa/received_events","type":"User","site_admin":false},"body":"> don`t call #onDetachView () directly... \r\n\r\nright?","created_at":"2016-10-20T10:18:37Z","updated_at":"2016-10-20T10:26:20Z","html_url":"https://github.com/grandcentrix/ThirtyInch/pull/26#discussion_r84252828","pull_request_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/comments/84252828"},"html":{"href":"https://github.com/grandcentrix/ThirtyInch/pull/26#discussion_r84252828"},"pull_request":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26","id":89379852,"html_url":"https://github.com/grandcentrix/ThirtyInch/pull/26","diff_url":"https://github.com/grandcentrix/ThirtyInch/pull/26.diff","patch_url":"https://github.com/grandcentrix/ThirtyInch/pull/26.patch","issue_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/26","number":26,"state":"open","locked":false,"title":"Change onWakeUp() to onAttachView(TiView) and onSleep() to onDetachView()","user":{"login":"passsy","id":1096485,"avatar_url":"https://avatars.githubusercontent.com/u/1096485?v=3","gravatar_id":"","url":"https://api.github.com/users/passsy","html_url":"https://github.com/passsy","followers_url":"https://api.github.com/users/passsy/followers","following_url":"https://api.github.com/users/passsy/following{/other_user}","gists_url":"https://api.github.com/users/passsy/gists{/gist_id}","starred_url":"https://api.github.com/users/passsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/passsy/subscriptions","organizations_url":"https://api.github.com/users/passsy/orgs","repos_url":"https://api.github.com/users/passsy/repos","events_url":"https://api.github.com/users/passsy/events{/privacy}","received_events_url":"https://api.github.com/users/passsy/received_events","type":"User","site_admin":false},"body":"The new naming is more convenient throughout most android MPV libraries. Switching to `Ti` should now be simpler. It reflects better that it's only about the view being absent. wakeup and sleep could imply the Presenter is kind of starting/stopping which is not the case.\r\n\r\n`onAttachView(TiView)` has the attached view as first parameter which is `@NonNull`. No calls to `getView()` are neccessary inside `onAttachView(TiView)`.\r\n`getView()` is now `@Nullable` (and always was null when not between `wakeup()` and `sleep()` state) and causes lint to hint a Nullable warning. This warning was missing and caused a lot of NPE for `Ti` beginners","created_at":"2016-10-14T12:58:45Z","updated_at":"2016-10-20T10:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d25730348d8823ebed1814febb58f6143b8f518a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26/commits","review_comments_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26/comments","review_comment_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/26/comments","statuses_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/statuses/5f79ddda55402132f47d10216310ae26ddc6515c","head":{"label":"grandcentrix:feature/refactor_presenter_view_methods","ref":"feature/refactor_presenter_view_methods","sha":"5f79ddda55402132f47d10216310ae26ddc6515c","user":{"login":"grandcentrix","id":239841,"avatar_url":"https://avatars.githubusercontent.com/u/239841?v=3","gravatar_id":"","url":"https://api.github.com/users/grandcentrix","html_url":"https://github.com/grandcentrix","followers_url":"https://api.github.com/users/grandcentrix/followers","following_url":"https://api.github.com/users/grandcentrix/following{/other_user}","gists_url":"https://api.github.com/users/grandcentrix/gists{/gist_id}","starred_url":"https://api.github.com/users/grandcentrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grandcentrix/subscriptions","organizations_url":"https://api.github.com/users/grandcentrix/orgs","repos_url":"https://api.github.com/users/grandcentrix/repos","events_url":"https://api.github.com/users/grandcentrix/events{/privacy}","received_events_url":"https://api.github.com/users/grandcentrix/received_events","type":"Organization","site_admin":false},"repo":{"id":66281816,"name":"ThirtyInch","full_name":"grandcentrix/ThirtyInch","owner":{"login":"grandcentrix","id":239841,"avatar_url":"https://avatars.githubusercontent.com/u/239841?v=3","gravatar_id":"","url":"https://api.github.com/users/grandcentrix","html_url":"https://github.com/grandcentrix","followers_url":"https://api.github.com/users/grandcentrix/followers","following_url":"https://api.github.com/users/grandcentrix/following{/other_user}","gists_url":"https://api.github.com/users/grandcentrix/gists{/gist_id}","starred_url":"https://api.github.com/users/grandcentrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grandcentrix/subscriptions","organizations_url":"https://api.github.com/users/grandcentrix/orgs","repos_url":"https://api.github.com/users/grandcentrix/repos","events_url":"https://api.github.com/users/grandcentrix/events{/privacy}","received_events_url":"https://api.github.com/users/grandcentrix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grandcentrix/ThirtyInch","description":"a MVP library for Android","fork":false,"url":"https://api.github.com/repos/grandcentrix/ThirtyInch","forks_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/forks","keys_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/teams","hooks_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/hooks","issue_events_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/events{/number}","events_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/events","assignees_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/assignees{/user}","branches_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/branches{/branch}","tags_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/tags","blobs_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/refs{/sha}","trees_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/statuses/{sha}","languages_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/languages","stargazers_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/stargazers","contributors_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/contributors","subscribers_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/subscribers","subscription_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/subscription","commits_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/commits{/sha}","git_commits_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/commits{/sha}","comments_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/comments{/number}","issue_comment_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/comments{/number}","contents_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/contents/{+path}","compare_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/merges","archive_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/downloads","issues_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues{/number}","pulls_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls{/number}","milestones_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/milestones{/number}","notifications_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/labels{/name}","releases_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/releases{/id}","deployments_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/deployments","created_at":"2016-08-22T14:55:09Z","updated_at":"2016-10-18T19:35:36Z","pushed_at":"2016-10-14T12:58:45Z","git_url":"git://github.com/grandcentrix/ThirtyInch.git","ssh_url":"git@github.com:grandcentrix/ThirtyInch.git","clone_url":"https://github.com/grandcentrix/ThirtyInch.git","svn_url":"https://github.com/grandcentrix/ThirtyInch","homepage":null,"size":355,"stargazers_count":532,"watchers_count":532,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":9,"forks":51,"open_issues":9,"watchers":532,"default_branch":"master"}},"base":{"label":"grandcentrix:master","ref":"master","sha":"07a37dab4c7c9f81ef9f0fdd1c1990ace860b4ef","user":{"login":"grandcentrix","id":239841,"avatar_url":"https://avatars.githubusercontent.com/u/239841?v=3","gravatar_id":"","url":"https://api.github.com/users/grandcentrix","html_url":"https://github.com/grandcentrix","followers_url":"https://api.github.com/users/grandcentrix/followers","following_url":"https://api.github.com/users/grandcentrix/following{/other_user}","gists_url":"https://api.github.com/users/grandcentrix/gists{/gist_id}","starred_url":"https://api.github.com/users/grandcentrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grandcentrix/subscriptions","organizations_url":"https://api.github.com/users/grandcentrix/orgs","repos_url":"https://api.github.com/users/grandcentrix/repos","events_url":"https://api.github.com/users/grandcentrix/events{/privacy}","received_events_url":"https://api.github.com/users/grandcentrix/received_events","type":"Organization","site_admin":false},"repo":{"id":66281816,"name":"ThirtyInch","full_name":"grandcentrix/ThirtyInch","owner":{"login":"grandcentrix","id":239841,"avatar_url":"https://avatars.githubusercontent.com/u/239841?v=3","gravatar_id":"","url":"https://api.github.com/users/grandcentrix","html_url":"https://github.com/grandcentrix","followers_url":"https://api.github.com/users/grandcentrix/followers","following_url":"https://api.github.com/users/grandcentrix/following{/other_user}","gists_url":"https://api.github.com/users/grandcentrix/gists{/gist_id}","starred_url":"https://api.github.com/users/grandcentrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grandcentrix/subscriptions","organizations_url":"https://api.github.com/users/grandcentrix/orgs","repos_url":"https://api.github.com/users/grandcentrix/repos","events_url":"https://api.github.com/users/grandcentrix/events{/privacy}","received_events_url":"https://api.github.com/users/grandcentrix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grandcentrix/ThirtyInch","description":"a MVP library for Android","fork":false,"url":"https://api.github.com/repos/grandcentrix/ThirtyInch","forks_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/forks","keys_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/teams","hooks_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/hooks","issue_events_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/events{/number}","events_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/events","assignees_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/assignees{/user}","branches_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/branches{/branch}","tags_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/tags","blobs_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/refs{/sha}","trees_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/statuses/{sha}","languages_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/languages","stargazers_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/stargazers","contributors_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/contributors","subscribers_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/subscribers","subscription_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/subscription","commits_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/commits{/sha}","git_commits_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/git/commits{/sha}","comments_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/comments{/number}","issue_comment_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/comments{/number}","contents_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/contents/{+path}","compare_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/merges","archive_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/downloads","issues_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues{/number}","pulls_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls{/number}","milestones_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/milestones{/number}","notifications_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/labels{/name}","releases_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/releases{/id}","deployments_url":"https://api.github.com/repos/grandcentrix/ThirtyInch/deployments","created_at":"2016-08-22T14:55:09Z","updated_at":"2016-10-18T19:35:36Z","pushed_at":"2016-10-14T12:58:45Z","git_url":"git://github.com/grandcentrix/ThirtyInch.git","ssh_url":"git@github.com:grandcentrix/ThirtyInch.git","clone_url":"https://github.com/grandcentrix/ThirtyInch.git","svn_url":"https://github.com/grandcentrix/ThirtyInch","homepage":null,"size":355,"stargazers_count":532,"watchers_count":532,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":9,"forks":51,"open_issues":9,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26"},"html":{"href":"https://github.com/grandcentrix/ThirtyInch/pull/26"},"issue":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/26"},"comments":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/grandcentrix/ThirtyInch/statuses/5f79ddda55402132f47d10216310ae26ddc6515c"}}}}
{"actor":{"display_login":"StefMa"}}