{"action":"created","issue":{"url":"https://api.github.com/repos/cmu-db/peloton/issues/446","repository_url":"https://api.github.com/repos/cmu-db/peloton","labels_url":"https://api.github.com/repos/cmu-db/peloton/issues/446/labels{/name}","comments_url":"https://api.github.com/repos/cmu-db/peloton/issues/446/comments","events_url":"https://api.github.com/repos/cmu-db/peloton/issues/446/events","html_url":"https://github.com/cmu-db/peloton/pull/446","id":198205278,"number":446,"title":"Remove Index::Compare Calls + MaskedTuple Enhancement","user":{"login":"apavlo","id":718045,"avatar_url":"https://avatars.githubusercontent.com/u/718045?v=3","gravatar_id":"","url":"https://api.github.com/users/apavlo","html_url":"https://github.com/apavlo","followers_url":"https://api.github.com/users/apavlo/followers","following_url":"https://api.github.com/users/apavlo/following{/other_user}","gists_url":"https://api.github.com/users/apavlo/gists{/gist_id}","starred_url":"https://api.github.com/users/apavlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apavlo/subscriptions","organizations_url":"https://api.github.com/users/apavlo/orgs","repos_url":"https://api.github.com/users/apavlo/repos","events_url":"https://api.github.com/users/apavlo/events{/privacy}","received_events_url":"https://api.github.com/users/apavlo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-12-30T23:25:04Z","updated_at":"2017-01-01T06:18:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/446","html_url":"https://github.com/cmu-db/peloton/pull/446","diff_url":"https://github.com/cmu-db/peloton/pull/446.diff","patch_url":"https://github.com/cmu-db/peloton/pull/446.patch"},"body":"Ok here's what we got in this one:\r\n\r\n1. Remove the call to `Index::Compare` inside of `BwTreeIndex::Scan`. This works because of @malin1993ml's fixes in #439 \r\n\r\n2. New `MaskedTuple` wrapper that takes in an `AbstractTuple` and a mask of column offsets and then converts any calls to `AbstractTuple::GetValue` to use the proper offset. This is a way to \"fake\" a tuple that has exactly the schema that is needed for a key look-up in an index. Using `MaskedTuple` completely removes the creation of `Value` objects inside of `IndexScanExecutor::ExecSecondaryIndexLookup`.\r\n\r\nI am going to check whether we can use `MaskedTuple` in the `GenericComparator` next.\r\n\r\nAs an aside, I am not sure whether `MaskedTuple` is the right name to call this. I was thinking maybe `MappedTuple` but that doesn't sound right either..."},"comment":{"url":"https://api.github.com/repos/cmu-db/peloton/issues/comments/269893434","html_url":"https://github.com/cmu-db/peloton/pull/446#issuecomment-269893434","issue_url":"https://api.github.com/repos/cmu-db/peloton/issues/446","id":269893434,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-01-01T06:18:07Z","updated_at":"2017-01-01T06:18:07Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9481769/badge)](https://coveralls.io/builds/9481769)\n\nCoverage decreased (-0.2%) to 63.471% when pulling **f16c1694f237b9b0082815c8c3f89cd44bd03f2d on apavlo:master** into **a609e753c87647af8fdf61765b24d99c7613bea0 on cmu-db:master**.\n"}}
{"actor":{"display_login":"coveralls"}}