{"action":"created","issue":{"url":"https://api.github.com/repos/ros-perception/image_pipeline/issues/240","repository_url":"https://api.github.com/repos/ros-perception/image_pipeline","labels_url":"https://api.github.com/repos/ros-perception/image_pipeline/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/ros-perception/image_pipeline/issues/240/comments","events_url":"https://api.github.com/repos/ros-perception/image_pipeline/issues/240/events","html_url":"https://github.com/ros-perception/image_pipeline/pull/240","id":195560560,"number":240,"title":"Apply value scaling to depth image with specified/default min/max range","user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-14T15:26:20Z","updated_at":"2016-12-15T08:30:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros-perception/image_pipeline/pulls/240","html_url":"https://github.com/ros-perception/image_pipeline/pull/240","diff_url":"https://github.com/ros-perception/image_pipeline/pull/240.diff","patch_url":"https://github.com/ros-perception/image_pipeline/pull/240.patch"},"body":"This is to visualize depth images without `_do_dynamic_scaling:=true` rosparam specification.\r\n\r\n- 32FC1: we assume meter metric, and 10[m] as the max range.\r\n- 16UC1: we assume milimeter metric, and 10 * 1000[mm] as the max range."},"comment":{"url":"https://api.github.com/repos/ros-perception/image_pipeline/issues/comments/267267865","html_url":"https://github.com/ros-perception/image_pipeline/pull/240#issuecomment-267267865","issue_url":"https://api.github.com/repos/ros-perception/image_pipeline/issues/240","id":267267865,"user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T08:30:06Z","updated_at":"2016-12-15T08:30:06Z","body":"## Update\r\n\r\nSometimes I'd like to visualize probability image whose image value range is from 0 to 1, and max_image_value should be `1` in that case.\r\n\r\nI hit another idea with specifying min/max image_value with rosparam to solve this problem.\r\nWe can assume the min/max values are not specified if they are equal, in that case we use 10[m] as the default value. And if either min or max image value specified we should use it.\r\n\r\n**not specified**\r\n![not_specified](https://cloud.githubusercontent.com/assets/4310419/21216752/ddf2f76e-c2eb-11e6-94d1-c1ccb30221f0.png)\r\n\r\n**max=3.0**\r\n![max_3](https://cloud.githubusercontent.com/assets/4310419/21216757/e8f7d260-c2eb-11e6-9164-76e4a77f26f9.png)\r\n\r\n**min=0.5,max=1.0**\r\n![min_0 5_max_1](https://cloud.githubusercontent.com/assets/4310419/21216789/19650300-c2ec-11e6-82af-5f230662ccdd.png)\r\n"}}
{"actor":{"display_login":"wkentaro"}}