{"action":"created","issue":{"url":"https://api.github.com/repos/mmistakes/minimal-mistakes/issues/519","repository_url":"https://api.github.com/repos/mmistakes/minimal-mistakes","labels_url":"https://api.github.com/repos/mmistakes/minimal-mistakes/issues/519/labels{/name}","comments_url":"https://api.github.com/repos/mmistakes/minimal-mistakes/issues/519/comments","events_url":"https://api.github.com/repos/mmistakes/minimal-mistakes/issues/519/events","html_url":"https://github.com/mmistakes/minimal-mistakes/issues/519","id":176274410,"number":519,"title":"Improve extensibility of theme styling and _variables.scss","user":{"login":"vwchu","id":4775142,"avatar_url":"https://avatars.githubusercontent.com/u/4775142?v=3","gravatar_id":"","url":"https://api.github.com/users/vwchu","html_url":"https://github.com/vwchu","followers_url":"https://api.github.com/users/vwchu/followers","following_url":"https://api.github.com/users/vwchu/following{/other_user}","gists_url":"https://api.github.com/users/vwchu/gists{/gist_id}","starred_url":"https://api.github.com/users/vwchu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vwchu/subscriptions","organizations_url":"https://api.github.com/users/vwchu/orgs","repos_url":"https://api.github.com/users/vwchu/repos","events_url":"https://api.github.com/users/vwchu/events{/privacy}","received_events_url":"https://api.github.com/users/vwchu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mmistakes/minimal-mistakes/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-12T00:26:54Z","updated_at":"2016-09-21T03:35:49Z","closed_at":null,"body":"- [ ] This is a question about using the theme.\r\n- [ ] I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.\r\n- [x] This is a feature request / enhancement / refactoring.\r\n- [ ] I have updated all gems with `bundle update`.\r\n- [ ] I have tested locally with `bundle exec jekyll build`.\r\n\r\n---\r\n\r\n## Environment informations\r\n\r\n- **Minimal Mistakes version:** 3.4.6\r\n\r\n---\r\n\r\n## Enhancement\r\n\r\nIn effort to improve maintainable, easier installation/upgrading and in preparation for the transition to Ruby gem-based theme #419, should the following refactoring be performed:\r\n\r\n1. Move `assets/css/main.scss` to `_sass/_main.scss`\r\n2. Add variable defaults `!default` to all variables in `_variables.scss` so that variables can be easily overridden without modifying `_variables.scss` directly. \r\n3. Replace assets/css/main.scss with a simple redirection to `_sass/_main.scss`\r\n\r\n    ```scss\r\n    @import \"main\";\r\n    ```\r\n"},"comment":{"url":"https://api.github.com/repos/mmistakes/minimal-mistakes/issues/comments/248502575","html_url":"https://github.com/mmistakes/minimal-mistakes/issues/519#issuecomment-248502575","issue_url":"https://api.github.com/repos/mmistakes/minimal-mistakes/issues/519","id":248502575,"user":{"login":"mmistakes","id":1376749,"avatar_url":"https://avatars.githubusercontent.com/u/1376749?v=3","gravatar_id":"","url":"https://api.github.com/users/mmistakes","html_url":"https://github.com/mmistakes","followers_url":"https://api.github.com/users/mmistakes/followers","following_url":"https://api.github.com/users/mmistakes/following{/other_user}","gists_url":"https://api.github.com/users/mmistakes/gists{/gist_id}","starred_url":"https://api.github.com/users/mmistakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmistakes/subscriptions","organizations_url":"https://api.github.com/users/mmistakes/orgs","repos_url":"https://api.github.com/users/mmistakes/repos","events_url":"https://api.github.com/users/mmistakes/events{/privacy}","received_events_url":"https://api.github.com/users/mmistakes/received_events","type":"User","site_admin":false},"created_at":"2016-09-21T03:35:49Z","updated_at":"2016-09-21T03:35:49Z","body":"That logic can apply to any changes to `.scss` files though. If breaking changes occur in any of the partials you won't know about that either unless you're carefully monitoring ever change made to the gem."}}
{"actor":{"display_login":"mmistakes"}}