{"action":"created","comment":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/comments/74338145","id":74338145,"diff_hunk":"@@ -3,7 +3,7 @@\n // FIXME: OOURA roundtrip FFT seems to be broken on windows for sizeFft = 4 (https://github.com/cinder/Cinder/issues/1263)\r\n #if ! defined( CINDER_MSW )\r\n \r\n-#include \"catch.hpp\"\r\n+#include \"../catch.hpp\"\r","path":"test/unit/src/audio/FftUnit.cpp","position":5,"original_position":5,"commit_id":"7b637f41063d1571177ff41229dd71de699e0319","original_commit_id":"7b637f41063d1571177ff41229dd71de699e0319","user":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars.githubusercontent.com/u/5132127?v=3","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"body":"I'd imagine adding `INCLUDES \"${UNIT_DIR}/src\"` when calling `ci_make_app()` would do it. I can't really think of a more reasonable place for catch.hpp to live other than `cinder/test/unit/src/catch.hpp` but of course open to other places.","created_at":"2016-08-10T21:53:14Z","updated_at":"2016-08-10T21:53:14Z","html_url":"https://github.com/cinder/Cinder/pull/1550#discussion_r74338145","pull_request_url":"https://api.github.com/repos/cinder/Cinder/pulls/1550","_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments/74338145"},"html":{"href":"https://github.com/cinder/Cinder/pull/1550#discussion_r74338145"},"pull_request":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1550"}}},"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/1550","id":80826325,"html_url":"https://github.com/cinder/Cinder/pull/1550","diff_url":"https://github.com/cinder/Cinder/pull/1550.diff","patch_url":"https://github.com/cinder/Cinder/pull/1550.patch","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/1550","number":1550,"state":"open","locked":false,"title":"cmake: enable building and running catch-style unit test suite. ","user":{"login":"dankegel","id":170976,"avatar_url":"https://avatars.githubusercontent.com/u/170976?v=3","gravatar_id":"","url":"https://api.github.com/users/dankegel","html_url":"https://github.com/dankegel","followers_url":"https://api.github.com/users/dankegel/followers","following_url":"https://api.github.com/users/dankegel/following{/other_user}","gists_url":"https://api.github.com/users/dankegel/gists{/gist_id}","starred_url":"https://api.github.com/users/dankegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankegel/subscriptions","organizations_url":"https://api.github.com/users/dankegel/orgs","repos_url":"https://api.github.com/users/dankegel/repos","events_url":"https://api.github.com/users/dankegel/events{/privacy}","received_events_url":"https://api.github.com/users/dankegel/received_events","type":"User","site_admin":false},"body":"After doing 'make', to run the tests, do 'make test' (shows little output) or 'ctest -v' (shows more output) or\r\nDebug/TestMain (bare metal, lets you use catch.hpp options).","created_at":"2016-08-10T16:34:38Z","updated_at":"2016-08-10T21:53:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f456039f3caf1e046209db0b8ce27a4eb625d50b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cinder/Cinder/pulls/1550/commits","review_comments_url":"https://api.github.com/repos/cinder/Cinder/pulls/1550/comments","review_comment_url":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/1550/comments","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/7b637f41063d1571177ff41229dd71de699e0319","head":{"label":"dankegel:bug1548_cmake_enable_tests","ref":"bug1548_cmake_enable_tests","sha":"7b637f41063d1571177ff41229dd71de699e0319","user":{"login":"dankegel","id":170976,"avatar_url":"https://avatars.githubusercontent.com/u/170976?v=3","gravatar_id":"","url":"https://api.github.com/users/dankegel","html_url":"https://github.com/dankegel","followers_url":"https://api.github.com/users/dankegel/followers","following_url":"https://api.github.com/users/dankegel/following{/other_user}","gists_url":"https://api.github.com/users/dankegel/gists{/gist_id}","starred_url":"https://api.github.com/users/dankegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankegel/subscriptions","organizations_url":"https://api.github.com/users/dankegel/orgs","repos_url":"https://api.github.com/users/dankegel/repos","events_url":"https://api.github.com/users/dankegel/events{/privacy}","received_events_url":"https://api.github.com/users/dankegel/received_events","type":"User","site_admin":false},"repo":{"id":65397030,"name":"Cinder","full_name":"dankegel/Cinder","owner":{"login":"dankegel","id":170976,"avatar_url":"https://avatars.githubusercontent.com/u/170976?v=3","gravatar_id":"","url":"https://api.github.com/users/dankegel","html_url":"https://github.com/dankegel","followers_url":"https://api.github.com/users/dankegel/followers","following_url":"https://api.github.com/users/dankegel/following{/other_user}","gists_url":"https://api.github.com/users/dankegel/gists{/gist_id}","starred_url":"https://api.github.com/users/dankegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dankegel/subscriptions","organizations_url":"https://api.github.com/users/dankegel/orgs","repos_url":"https://api.github.com/users/dankegel/repos","events_url":"https://api.github.com/users/dankegel/events{/privacy}","received_events_url":"https://api.github.com/users/dankegel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dankegel/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":true,"url":"https://api.github.com/repos/dankegel/Cinder","forks_url":"https://api.github.com/repos/dankegel/Cinder/forks","keys_url":"https://api.github.com/repos/dankegel/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dankegel/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dankegel/Cinder/teams","hooks_url":"https://api.github.com/repos/dankegel/Cinder/hooks","issue_events_url":"https://api.github.com/repos/dankegel/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/dankegel/Cinder/events","assignees_url":"https://api.github.com/repos/dankegel/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/dankegel/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/dankegel/Cinder/tags","blobs_url":"https://api.github.com/repos/dankegel/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dankegel/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dankegel/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/dankegel/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dankegel/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/dankegel/Cinder/languages","stargazers_url":"https://api.github.com/repos/dankegel/Cinder/stargazers","contributors_url":"https://api.github.com/repos/dankegel/Cinder/contributors","subscribers_url":"https://api.github.com/repos/dankegel/Cinder/subscribers","subscription_url":"https://api.github.com/repos/dankegel/Cinder/subscription","commits_url":"https://api.github.com/repos/dankegel/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/dankegel/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/dankegel/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/dankegel/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/dankegel/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/dankegel/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dankegel/Cinder/merges","archive_url":"https://api.github.com/repos/dankegel/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dankegel/Cinder/downloads","issues_url":"https://api.github.com/repos/dankegel/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/dankegel/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/dankegel/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/dankegel/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dankegel/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/dankegel/Cinder/releases{/id}","deployments_url":"https://api.github.com/repos/dankegel/Cinder/deployments","created_at":"2016-08-10T16:09:32Z","updated_at":"2016-08-10T16:09:54Z","pushed_at":"2016-08-10T20:52:00Z","git_url":"git://github.com/dankegel/Cinder.git","ssh_url":"git@github.com:dankegel/Cinder.git","clone_url":"https://github.com/dankegel/Cinder.git","svn_url":"https://github.com/dankegel/Cinder","homepage":"http://libcinder.org","size":407107,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cinder:android_linux","ref":"android_linux","sha":"0368933a39465044360ef29876f4da73ca633ceb","user":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"repo":{"id":622127,"name":"Cinder","full_name":"cinder/Cinder","owner":{"login":"cinder","id":154586,"avatar_url":"https://avatars.githubusercontent.com/u/154586?v=3","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cinder/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":false,"url":"https://api.github.com/repos/cinder/Cinder","forks_url":"https://api.github.com/repos/cinder/Cinder/forks","keys_url":"https://api.github.com/repos/cinder/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinder/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinder/Cinder/teams","hooks_url":"https://api.github.com/repos/cinder/Cinder/hooks","issue_events_url":"https://api.github.com/repos/cinder/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/cinder/Cinder/events","assignees_url":"https://api.github.com/repos/cinder/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/cinder/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/cinder/Cinder/tags","blobs_url":"https://api.github.com/repos/cinder/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinder/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinder/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinder/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/cinder/Cinder/languages","stargazers_url":"https://api.github.com/repos/cinder/Cinder/stargazers","contributors_url":"https://api.github.com/repos/cinder/Cinder/contributors","subscribers_url":"https://api.github.com/repos/cinder/Cinder/subscribers","subscription_url":"https://api.github.com/repos/cinder/Cinder/subscription","commits_url":"https://api.github.com/repos/cinder/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinder/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinder/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinder/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/cinder/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/cinder/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinder/Cinder/merges","archive_url":"https://api.github.com/repos/cinder/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinder/Cinder/downloads","issues_url":"https://api.github.com/repos/cinder/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/cinder/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/cinder/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/cinder/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinder/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/cinder/Cinder/releases{/id}","deployments_url":"https://api.github.com/repos/cinder/Cinder/deployments","created_at":"2010-04-21T19:03:10Z","updated_at":"2016-08-10T17:43:04Z","pushed_at":"2016-08-10T20:52:01Z","git_url":"git://github.com/cinder/Cinder.git","ssh_url":"git@github.com:cinder/Cinder.git","clone_url":"https://github.com/cinder/Cinder.git","svn_url":"https://github.com/cinder/Cinder","homepage":"http://libcinder.org","size":515552,"stargazers_count":2668,"watchers_count":2668,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":646,"mirror_url":null,"open_issues_count":199,"forks":646,"open_issues":199,"watchers":2668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1550"},"html":{"href":"https://github.com/cinder/Cinder/pull/1550"},"issue":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1550"},"comments":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1550/comments"},"review_comments":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1550/comments"},"review_comment":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1550/commits"},"statuses":{"href":"https://api.github.com/repos/cinder/Cinder/statuses/7b637f41063d1571177ff41229dd71de699e0319"}}}}
{"actor":{"display_login":"richardeakin"}}