{"action":"created","issue":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1112","repository_url":"https://api.github.com/repos/smartdevicelink/sdl_core","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1112/labels{/name}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1112/comments","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1112/events","html_url":"https://github.com/smartdevicelink/sdl_core/pull/1112","id":195764333,"number":1112,"title":"Fix TransportManagerDefault unit test issues","user":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-15T10:06:56Z","updated_at":"2016-12-21T11:29:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1112","html_url":"https://github.com/smartdevicelink/sdl_core/pull/1112","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/1112.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/1112.patch"},"body":"Created mock for LastState class, to let UT use LastState without rewriting it in app_info_storage file.\r\nReplaced LastState onto mock equivalent object in TransportManagerDefault unit test.\r\nMade changes to fix SegFault issue of TransportManagerDefault unit test:\r\n - Moved \"thread->join()\" logic to destuctor of ThreadedSocket child classes;\r\n - Added connection shutdown and close in Disconnect command to stop socket that is pending for connection;\r\n - Moved the ConnectionCreated notification right after we create new threaded socket connection to ensure that in Stop() method all connections will be valid;\r\n - Added additional check to prevent creation of new socket for already terminated connection.\r\n\r\nRelated tasks : [APPLINK-30284](https://adc.luxoft.com/jira/browse/APPLINK-30284),  [APPLINK-30431](https://adc.luxoft.com/jira/browse/APPLINK-30431)"},"comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments/268500654","html_url":"https://github.com/smartdevicelink/sdl_core/pull/1112#issuecomment-268500654","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1112","id":268500654,"user":{"login":"dcherniev","id":22448027,"avatar_url":"https://avatars.githubusercontent.com/u/22448027?v=3","gravatar_id":"","url":"https://api.github.com/users/dcherniev","html_url":"https://github.com/dcherniev","followers_url":"https://api.github.com/users/dcherniev/followers","following_url":"https://api.github.com/users/dcherniev/following{/other_user}","gists_url":"https://api.github.com/users/dcherniev/gists{/gist_id}","starred_url":"https://api.github.com/users/dcherniev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcherniev/subscriptions","organizations_url":"https://api.github.com/users/dcherniev/orgs","repos_url":"https://api.github.com/users/dcherniev/repos","events_url":"https://api.github.com/users/dcherniev/events{/privacy}","received_events_url":"https://api.github.com/users/dcherniev/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T11:29:39Z","updated_at":"2016-12-21T11:29:39Z","body":"Rebuild required"}}
{"actor":{"display_login":"dcherniev"}}