{"action":"created","comment":{"url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/comments/87111766","pull_request_review_id":7736092,"id":87111766,"diff_hunk":"@@ -249,14 +263,8 @@ func deleteDNSRecord(serviceName string, dockerId string) error {\n \t\t\t\t\tResourceRecordSet: &route53.ResourceRecordSet{\n \t\t\t\t\t\tName: aws.String(serviceName + \".\" + DNSName),\n \t\t\t\t\t\tType: aws.String(route53.RRTypeA),\n-\t\t\t\t\t\tResourceRecords: []*route53.ResourceRecord{\n-\t\t\t\t\t\t\t{\n-\t\t\t\t\t\t\t\tValue: aws.String(aValue),\n-\t\t\t\t\t\t\t},\n-\t\t\t\t\t\t},\n-\t\t\t\t\t\tSetIdentifier: aws.String(dockerId),\n-\t\t\t\t\t\tTTL:           aws.Int64(defaultTTL),\n-\t\t\t\t\t\tWeight:        aws.Int64(defaultWeight),\n+\t\t\t\t\t\tResourceRecords: aValues,\n+\t\t\t\t\t\tTTL: aws.Int64(defaultTTL),","path":"ecssd_agent.go","position":152,"original_position":152,"commit_id":"3445d7f26b4086ad4858d9e66423d6b76c858956","original_commit_id":"3445d7f26b4086ad4858d9e66423d6b76c858956","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"body":"Oh, TTL is required. Strange.\r\n\r\n> DELETE: Deletes a existing resource record set that has the specified values for Name, Type, SetIdentifier (for latency, weighted, geolocation, and failover resource record sets), and TTL (except alias resource record sets, for which the TTL is determined by the AWS resource that you're routing DNS queries to).","created_at":"2016-11-09T00:01:16Z","updated_at":"2016-11-09T00:12:01Z","html_url":"https://github.com/ifwe/service-discovery-ecs-dns/pull/1#discussion_r87111766","pull_request_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/comments/87111766"},"html":{"href":"https://github.com/ifwe/service-discovery-ecs-dns/pull/1#discussion_r87111766"},"pull_request":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1","id":92882449,"html_url":"https://github.com/ifwe/service-discovery-ecs-dns/pull/1","diff_url":"https://github.com/ifwe/service-discovery-ecs-dns/pull/1.diff","patch_url":"https://github.com/ifwe/service-discovery-ecs-dns/pull/1.patch","issue_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/1","number":1,"state":"open","locked":false,"title":"LIVE-1331: Manage A records instead of creating new ones","user":{"login":"mishan","id":788577,"avatar_url":"https://avatars.githubusercontent.com/u/788577?v=3","gravatar_id":"","url":"https://api.github.com/users/mishan","html_url":"https://github.com/mishan","followers_url":"https://api.github.com/users/mishan/followers","following_url":"https://api.github.com/users/mishan/following{/other_user}","gists_url":"https://api.github.com/users/mishan/gists{/gist_id}","starred_url":"https://api.github.com/users/mishan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishan/subscriptions","organizations_url":"https://api.github.com/users/mishan/orgs","repos_url":"https://api.github.com/users/mishan/repos","events_url":"https://api.github.com/users/mishan/events{/privacy}","received_events_url":"https://api.github.com/users/mishan/received_events","type":"User","site_admin":false},"body":"- No more Docker IDs attached to them unfortunately. We can live without that.\r\n\r\n@TysonAndre ","created_at":"2016-11-08T23:45:05Z","updated_at":"2016-11-09T00:17:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2ace98ca23a3ee1f25327a963e6c20123959ad8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/1/comments","statuses_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/statuses/3445d7f26b4086ad4858d9e66423d6b76c858956","head":{"label":"ifwe:manage-a-records","ref":"manage-a-records","sha":"3445d7f26b4086ad4858d9e66423d6b76c858956","user":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"repo":{"id":72676439,"name":"service-discovery-ecs-dns","full_name":"ifwe/service-discovery-ecs-dns","owner":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ifwe/service-discovery-ecs-dns","description":"Service Discovery via DNS with ECS.","fork":true,"url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns","forks_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/forks","keys_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/teams","hooks_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/hooks","issue_events_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/events{/number}","events_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/events","assignees_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/assignees{/user}","branches_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/branches{/branch}","tags_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/tags","blobs_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/languages","stargazers_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/stargazers","contributors_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/contributors","subscribers_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/subscribers","subscription_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/subscription","commits_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/contents/{+path}","compare_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/merges","archive_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/downloads","issues_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues{/number}","pulls_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/labels{/name}","releases_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/releases{/id}","deployments_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/deployments","created_at":"2016-11-02T20:00:18Z","updated_at":"2016-11-02T20:00:19Z","pushed_at":"2016-11-08T23:45:05Z","git_url":"git://github.com/ifwe/service-discovery-ecs-dns.git","ssh_url":"git@github.com:ifwe/service-discovery-ecs-dns.git","clone_url":"https://github.com/ifwe/service-discovery-ecs-dns.git","svn_url":"https://github.com/ifwe/service-discovery-ecs-dns","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ifwe:master","ref":"master","sha":"b7b21ab4f7362e37fdefc9e24f42a911ec4148d2","user":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"repo":{"id":72676439,"name":"service-discovery-ecs-dns","full_name":"ifwe/service-discovery-ecs-dns","owner":{"login":"ifwe","id":8762479,"avatar_url":"https://avatars.githubusercontent.com/u/8762479?v=3","gravatar_id":"","url":"https://api.github.com/users/ifwe","html_url":"https://github.com/ifwe","followers_url":"https://api.github.com/users/ifwe/followers","following_url":"https://api.github.com/users/ifwe/following{/other_user}","gists_url":"https://api.github.com/users/ifwe/gists{/gist_id}","starred_url":"https://api.github.com/users/ifwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifwe/subscriptions","organizations_url":"https://api.github.com/users/ifwe/orgs","repos_url":"https://api.github.com/users/ifwe/repos","events_url":"https://api.github.com/users/ifwe/events{/privacy}","received_events_url":"https://api.github.com/users/ifwe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ifwe/service-discovery-ecs-dns","description":"Service Discovery via DNS with ECS.","fork":true,"url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns","forks_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/forks","keys_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/teams","hooks_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/hooks","issue_events_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/events{/number}","events_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/events","assignees_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/assignees{/user}","branches_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/branches{/branch}","tags_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/tags","blobs_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/languages","stargazers_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/stargazers","contributors_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/contributors","subscribers_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/subscribers","subscription_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/subscription","commits_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/contents/{+path}","compare_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/merges","archive_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/downloads","issues_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues{/number}","pulls_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/labels{/name}","releases_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/releases{/id}","deployments_url":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/deployments","created_at":"2016-11-02T20:00:18Z","updated_at":"2016-11-02T20:00:19Z","pushed_at":"2016-11-08T23:45:05Z","git_url":"git://github.com/ifwe/service-discovery-ecs-dns.git","ssh_url":"git@github.com:ifwe/service-discovery-ecs-dns.git","clone_url":"https://github.com/ifwe/service-discovery-ecs-dns.git","svn_url":"https://github.com/ifwe/service-discovery-ecs-dns","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1"},"html":{"href":"https://github.com/ifwe/service-discovery-ecs-dns/pull/1"},"issue":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/1"},"comments":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ifwe/service-discovery-ecs-dns/statuses/3445d7f26b4086ad4858d9e66423d6b76c858956"}}}}
{"actor":{"display_login":"TysonAndre"}}