{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/68385199","id":68385199,"diff_hunk":"@@ -848,6 +856,11 @@ def authorize(self, volume_path, auth_id, readonly=False, tenant_id=None):\n                 # have mon auth caps that prevent it from accessing those keys\n                 # (e.g. limit it to only access keys with a manila.* prefix)\n             else:\n+                if auth_meta['tenant_id'] != tenant_id.__str__():","path":"src/pybind/ceph_volume_client.py","position":null,"original_position":19,"commit_id":"bbe4835583a213750afe8c6e7b69671bde266d4c","original_commit_id":"bbe4835583a213750afe8c6e7b69671bde266d4c","user":{"login":"ajarr","id":4090301,"avatar_url":"https://avatars.githubusercontent.com/u/4090301?v=3","gravatar_id":"","url":"https://api.github.com/users/ajarr","html_url":"https://github.com/ajarr","followers_url":"https://api.github.com/users/ajarr/followers","following_url":"https://api.github.com/users/ajarr/following{/other_user}","gists_url":"https://api.github.com/users/ajarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajarr/subscriptions","organizations_url":"https://api.github.com/users/ajarr/orgs","repos_url":"https://api.github.com/users/ajarr/repos","events_url":"https://api.github.com/users/ajarr/events{/privacy}","received_events_url":"https://api.github.com/users/ajarr/received_events","type":"User","site_admin":false},"body":"check only if tenant_id is None, i.e., the caller is not multi-tenant aware.","created_at":"2016-06-24T11:22:26Z","updated_at":"2016-06-24T11:22:26Z","html_url":"https://github.com/ceph/ceph/pull/9864#discussion_r68385199","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/9864","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/68385199"},"html":{"href":"https://github.com/ceph/ceph/pull/9864#discussion_r68385199"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9864"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/9864","id":74778816,"html_url":"https://github.com/ceph/ceph/pull/9864","diff_url":"https://github.com/ceph/ceph/pull/9864.diff","patch_url":"https://github.com/ceph/ceph/pull/9864.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/9864","number":9864,"state":"open","locked":false,"title":"[DNM] ceph_volume_client: authentication metadata","user":{"login":"ajarr","id":4090301,"avatar_url":"https://avatars.githubusercontent.com/u/4090301?v=3","gravatar_id":"","url":"https://api.github.com/users/ajarr","html_url":"https://github.com/ajarr","followers_url":"https://api.github.com/users/ajarr/followers","following_url":"https://api.github.com/users/ajarr/following{/other_user}","gists_url":"https://api.github.com/users/ajarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajarr/subscriptions","organizations_url":"https://api.github.com/users/ajarr/orgs","repos_url":"https://api.github.com/users/ajarr/repos","events_url":"https://api.github.com/users/ajarr/events{/privacy}","received_events_url":"https://api.github.com/users/ajarr/received_events","type":"User","site_admin":false},"body":"ceph_volume_client: authentication metadata\r\nStore a two-way mapping between auth IDs and volumes.\r\n\r\nEnables us to record some metadata on auth ids (which\r\nopenstack tenant created it) so that we can avoid exposing\r\nkeys to other tenants who try to use the same ceph\r\nauth id.\r\n\r\nEnables us to expose the list of which auth ids have access\r\nto a volume, so that Manila's update_access() can be\r\nimplemented efficiently.\r\n\r\nPending TODOs and testing.\r\n\r\n* TODO: Implement fstat python bindings for libcephfs\r\n* TODO: version the on-disk structures\r\n\r\nFixes: http://tracker.ceph.com/issues/15615\r\n\r\n","created_at":"2016-06-22T12:56:23Z","updated_at":"2016-06-24T11:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25b669560e19d2f20f3d11917ae46a0c2c9a9e21","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/9864/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/9864/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/9864/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/bbe4835583a213750afe8c6e7b69671bde266d4c","head":{"label":"ajarr:wip-15615","ref":"wip-15615","sha":"bbe4835583a213750afe8c6e7b69671bde266d4c","user":{"login":"ajarr","id":4090301,"avatar_url":"https://avatars.githubusercontent.com/u/4090301?v=3","gravatar_id":"","url":"https://api.github.com/users/ajarr","html_url":"https://github.com/ajarr","followers_url":"https://api.github.com/users/ajarr/followers","following_url":"https://api.github.com/users/ajarr/following{/other_user}","gists_url":"https://api.github.com/users/ajarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajarr/subscriptions","organizations_url":"https://api.github.com/users/ajarr/orgs","repos_url":"https://api.github.com/users/ajarr/repos","events_url":"https://api.github.com/users/ajarr/events{/privacy}","received_events_url":"https://api.github.com/users/ajarr/received_events","type":"User","site_admin":false},"repo":{"id":55061431,"name":"ceph","full_name":"ajarr/ceph","owner":{"login":"ajarr","id":4090301,"avatar_url":"https://avatars.githubusercontent.com/u/4090301?v=3","gravatar_id":"","url":"https://api.github.com/users/ajarr","html_url":"https://github.com/ajarr","followers_url":"https://api.github.com/users/ajarr/followers","following_url":"https://api.github.com/users/ajarr/following{/other_user}","gists_url":"https://api.github.com/users/ajarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajarr/subscriptions","organizations_url":"https://api.github.com/users/ajarr/orgs","repos_url":"https://api.github.com/users/ajarr/repos","events_url":"https://api.github.com/users/ajarr/events{/privacy}","received_events_url":"https://api.github.com/users/ajarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajarr/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/ajarr/ceph","forks_url":"https://api.github.com/repos/ajarr/ceph/forks","keys_url":"https://api.github.com/repos/ajarr/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajarr/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajarr/ceph/teams","hooks_url":"https://api.github.com/repos/ajarr/ceph/hooks","issue_events_url":"https://api.github.com/repos/ajarr/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ajarr/ceph/events","assignees_url":"https://api.github.com/repos/ajarr/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ajarr/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ajarr/ceph/tags","blobs_url":"https://api.github.com/repos/ajarr/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajarr/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajarr/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajarr/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajarr/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ajarr/ceph/languages","stargazers_url":"https://api.github.com/repos/ajarr/ceph/stargazers","contributors_url":"https://api.github.com/repos/ajarr/ceph/contributors","subscribers_url":"https://api.github.com/repos/ajarr/ceph/subscribers","subscription_url":"https://api.github.com/repos/ajarr/ceph/subscription","commits_url":"https://api.github.com/repos/ajarr/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajarr/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajarr/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajarr/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajarr/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ajarr/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajarr/ceph/merges","archive_url":"https://api.github.com/repos/ajarr/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajarr/ceph/downloads","issues_url":"https://api.github.com/repos/ajarr/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ajarr/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ajarr/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ajarr/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajarr/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ajarr/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ajarr/ceph/deployments","created_at":"2016-03-30T12:34:01Z","updated_at":"2016-03-30T12:34:20Z","pushed_at":"2016-06-23T18:01:42Z","git_url":"git://github.com/ajarr/ceph.git","ssh_url":"git@github.com:ajarr/ceph.git","clone_url":"https://github.com/ajarr/ceph.git","svn_url":"https://github.com/ajarr/ceph","homepage":"http://ceph.com","size":167805,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"51826cc0b93d0b37b1bbebb18889373ee042cdaa","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2016-06-23T23:31:37Z","pushed_at":"2016-06-24T11:08:01Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":222942,"stargazers_count":2253,"watchers_count":2253,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1345,"mirror_url":null,"open_issues_count":420,"forks":1345,"open_issues":420,"watchers":2253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9864"},"html":{"href":"https://github.com/ceph/ceph/pull/9864"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/9864"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/9864/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9864/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/9864/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/bbe4835583a213750afe8c6e7b69671bde266d4c"}}}}
{"actor":{"display_login":"ajarr"}}