{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8976","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8976/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8976/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8976/events","html_url":"https://github.com/bitcoin/bitcoin/pull/8976","id":184146338,"number":8976,"title":"libconsensus: Add input validation of flags","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Utils%20and%20libraries","name":"Utils and libraries","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-20T06:35:43Z","updated_at":"2016-10-20T06:39:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/8976","html_url":"https://github.com/bitcoin/bitcoin/pull/8976","diff_url":"https://github.com/bitcoin/bitcoin/pull/8976.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/8976.patch"},"body":"Makes it an error to use flags that have not been defined on the libconsensus API.\r\n\r\nThere has been some confusion as to what pass to libconsensus, and (combined with mention in the release notes) this should clear it up.\r\n\r\nUsing undocumented flags is a risk because their meaning, and what combinations are allowed, changes from release to release. E.g. it is no longer possible to pass `(CLEANSTACK | P2SH)` without running into an assertion after the segwit changes.\r\n\r\nHowever: this currently fails the tests because our own tests rely on this undocumented behavior(!). I am not entirely sure what would be the best way to solve this.\r\n"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/255021808","html_url":"https://github.com/bitcoin/bitcoin/pull/8976#issuecomment-255021808","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/8976","id":255021808,"user":{"login":"NicolasDorier","id":3020646,"avatar_url":"https://avatars.githubusercontent.com/u/3020646?v=3","gravatar_id":"","url":"https://api.github.com/users/NicolasDorier","html_url":"https://github.com/NicolasDorier","followers_url":"https://api.github.com/users/NicolasDorier/followers","following_url":"https://api.github.com/users/NicolasDorier/following{/other_user}","gists_url":"https://api.github.com/users/NicolasDorier/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasDorier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasDorier/subscriptions","organizations_url":"https://api.github.com/users/NicolasDorier/orgs","repos_url":"https://api.github.com/users/NicolasDorier/repos","events_url":"https://api.github.com/users/NicolasDorier/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasDorier/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T06:39:58Z","updated_at":"2016-10-20T06:39:58Z","body":"utACK 4522cb4 I claim guilty!"}}
{"actor":{"display_login":"NicolasDorier"}}