{"action":"created","comment":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments/69554193","id":69554193,"diff_hunk":"@@ -189,24 +189,28 @@ qx.Bootstrap.define(\"qx.lang.String\",\n     /**\n      * Check whether the string starts with the given substring\n      *\n+     * @deprecated {6.0} Please use String instance startsWith method instead\n+     *\n      * @param fullstr {String} the string to search in\n      * @param substr {String} the substring to look for\n      * @return {Boolean} whether the string starts with the given substring\n      */\n     startsWith : function(fullstr, substr) {\n-      return fullstr.indexOf(substr) === 0;\n+      return fullstr.startsWith(substr);\n     },\n \n \n     /**\n      * Check whether the string ends with the given substring\n      *\n+     * @deprecated {6.0} Please use String instance endsWith method instead\n+     *\n      * @param fullstr {String} the string to search in\n      * @param substr {String} the substring to look for\n      * @return {Boolean} whether the string ends with the given substring\n      */\n     endsWith : function(fullstr, substr) {\n-      return fullstr.substring(fullstr.length - substr.length, fullstr.length) === substr;\n+      return fullstr.endsWith(fullstr);","path":"framework/source/class/qx/lang/String.js","position":27,"original_position":27,"commit_id":"bba9455254e974c520e4c356e64379a3ab7b687e","original_commit_id":"bba9455254e974c520e4c356e64379a3ab7b687e","user":{"login":"level420","id":210674,"avatar_url":"https://avatars.githubusercontent.com/u/210674?v=3","gravatar_id":"","url":"https://api.github.com/users/level420","html_url":"https://github.com/level420","followers_url":"https://api.github.com/users/level420/followers","following_url":"https://api.github.com/users/level420/following{/other_user}","gists_url":"https://api.github.com/users/level420/gists{/gist_id}","starred_url":"https://api.github.com/users/level420/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/level420/subscriptions","organizations_url":"https://api.github.com/users/level420/orgs","repos_url":"https://api.github.com/users/level420/repos","events_url":"https://api.github.com/users/level420/events{/privacy}","received_events_url":"https://api.github.com/users/level420/received_events","type":"User","site_admin":false},"body":"@schnepe2 this should be: ```fullstr.endsWith(substr);```","created_at":"2016-07-05T12:32:19Z","updated_at":"2016-07-05T12:32:19Z","html_url":"https://github.com/qooxdoo/qooxdoo/pull/9076#discussion_r69554193","pull_request_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076","_links":{"self":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments/69554193"},"html":{"href":"https://github.com/qooxdoo/qooxdoo/pull/9076#discussion_r69554193"},"pull_request":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076"}}},"pull_request":{"url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076","id":76036329,"html_url":"https://github.com/qooxdoo/qooxdoo/pull/9076","diff_url":"https://github.com/qooxdoo/qooxdoo/pull/9076.diff","patch_url":"https://github.com/qooxdoo/qooxdoo/pull/9076.patch","issue_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076","number":9076,"state":"open","locked":false,"title":"String \"startsWith()\" and \"endsWith()\" polyfills ...ECMAScript 2015 (6th Edition, ECMA-262)","user":{"login":"schnepe2","id":18400313,"avatar_url":"https://avatars.githubusercontent.com/u/18400313?v=3","gravatar_id":"","url":"https://api.github.com/users/schnepe2","html_url":"https://github.com/schnepe2","followers_url":"https://api.github.com/users/schnepe2/followers","following_url":"https://api.github.com/users/schnepe2/following{/other_user}","gists_url":"https://api.github.com/users/schnepe2/gists{/gist_id}","starred_url":"https://api.github.com/users/schnepe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnepe2/subscriptions","organizations_url":"https://api.github.com/users/schnepe2/orgs","repos_url":"https://api.github.com/users/schnepe2/repos","events_url":"https://api.github.com/users/schnepe2/events{/privacy}","received_events_url":"https://api.github.com/users/schnepe2/received_events","type":"User","site_admin":false},"body":"Hi there,\r\n\r\nhere's my PR for the polyfills for the String prototype methods `startsWith` and `endsWith`.\r\n\r\nI always found it irritating that there are still some clients (IE) missing this and I had to use\r\n`qx.lang.String.startsWith(str, \"foo\")` instead of the easy to read `str.startsWith(\"foo\")` :smile: \r\n\r\nIncluding tests & environment checks\r\n\r\nReferences:\r\nhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith\r\nhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith","created_at":"2016-07-01T21:03:12Z","updated_at":"2016-07-05T12:32:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5543ef2322a61f9caf35fd0392245af8e971f68","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076/commits","review_comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076/comments","review_comment_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076/comments","statuses_url":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/bba9455254e974c520e4c356e64379a3ab7b687e","head":{"label":"schnepe2:master","ref":"master","sha":"bba9455254e974c520e4c356e64379a3ab7b687e","user":{"login":"schnepe2","id":18400313,"avatar_url":"https://avatars.githubusercontent.com/u/18400313?v=3","gravatar_id":"","url":"https://api.github.com/users/schnepe2","html_url":"https://github.com/schnepe2","followers_url":"https://api.github.com/users/schnepe2/followers","following_url":"https://api.github.com/users/schnepe2/following{/other_user}","gists_url":"https://api.github.com/users/schnepe2/gists{/gist_id}","starred_url":"https://api.github.com/users/schnepe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnepe2/subscriptions","organizations_url":"https://api.github.com/users/schnepe2/orgs","repos_url":"https://api.github.com/users/schnepe2/repos","events_url":"https://api.github.com/users/schnepe2/events{/privacy}","received_events_url":"https://api.github.com/users/schnepe2/received_events","type":"User","site_admin":false},"repo":{"id":60773153,"name":"qooxdoo","full_name":"schnepe2/qooxdoo","owner":{"login":"schnepe2","id":18400313,"avatar_url":"https://avatars.githubusercontent.com/u/18400313?v=3","gravatar_id":"","url":"https://api.github.com/users/schnepe2","html_url":"https://github.com/schnepe2","followers_url":"https://api.github.com/users/schnepe2/followers","following_url":"https://api.github.com/users/schnepe2/following{/other_user}","gists_url":"https://api.github.com/users/schnepe2/gists{/gist_id}","starred_url":"https://api.github.com/users/schnepe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnepe2/subscriptions","organizations_url":"https://api.github.com/users/schnepe2/orgs","repos_url":"https://api.github.com/users/schnepe2/repos","events_url":"https://api.github.com/users/schnepe2/events{/privacy}","received_events_url":"https://api.github.com/users/schnepe2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schnepe2/qooxdoo","description":"qooxdoo - Universal JavaScript Framework","fork":true,"url":"https://api.github.com/repos/schnepe2/qooxdoo","forks_url":"https://api.github.com/repos/schnepe2/qooxdoo/forks","keys_url":"https://api.github.com/repos/schnepe2/qooxdoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schnepe2/qooxdoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schnepe2/qooxdoo/teams","hooks_url":"https://api.github.com/repos/schnepe2/qooxdoo/hooks","issue_events_url":"https://api.github.com/repos/schnepe2/qooxdoo/issues/events{/number}","events_url":"https://api.github.com/repos/schnepe2/qooxdoo/events","assignees_url":"https://api.github.com/repos/schnepe2/qooxdoo/assignees{/user}","branches_url":"https://api.github.com/repos/schnepe2/qooxdoo/branches{/branch}","tags_url":"https://api.github.com/repos/schnepe2/qooxdoo/tags","blobs_url":"https://api.github.com/repos/schnepe2/qooxdoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schnepe2/qooxdoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schnepe2/qooxdoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/schnepe2/qooxdoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schnepe2/qooxdoo/statuses/{sha}","languages_url":"https://api.github.com/repos/schnepe2/qooxdoo/languages","stargazers_url":"https://api.github.com/repos/schnepe2/qooxdoo/stargazers","contributors_url":"https://api.github.com/repos/schnepe2/qooxdoo/contributors","subscribers_url":"https://api.github.com/repos/schnepe2/qooxdoo/subscribers","subscription_url":"https://api.github.com/repos/schnepe2/qooxdoo/subscription","commits_url":"https://api.github.com/repos/schnepe2/qooxdoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/schnepe2/qooxdoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/schnepe2/qooxdoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/schnepe2/qooxdoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/schnepe2/qooxdoo/contents/{+path}","compare_url":"https://api.github.com/repos/schnepe2/qooxdoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schnepe2/qooxdoo/merges","archive_url":"https://api.github.com/repos/schnepe2/qooxdoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schnepe2/qooxdoo/downloads","issues_url":"https://api.github.com/repos/schnepe2/qooxdoo/issues{/number}","pulls_url":"https://api.github.com/repos/schnepe2/qooxdoo/pulls{/number}","milestones_url":"https://api.github.com/repos/schnepe2/qooxdoo/milestones{/number}","notifications_url":"https://api.github.com/repos/schnepe2/qooxdoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schnepe2/qooxdoo/labels{/name}","releases_url":"https://api.github.com/repos/schnepe2/qooxdoo/releases{/id}","deployments_url":"https://api.github.com/repos/schnepe2/qooxdoo/deployments","created_at":"2016-06-09T12:30:14Z","updated_at":"2016-06-09T12:30:28Z","pushed_at":"2016-07-05T12:15:55Z","git_url":"git://github.com/schnepe2/qooxdoo.git","ssh_url":"git@github.com:schnepe2/qooxdoo.git","clone_url":"https://github.com/schnepe2/qooxdoo.git","svn_url":"https://github.com/schnepe2/qooxdoo","homepage":"http://qooxdoo.org","size":244702,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qooxdoo:master","ref":"master","sha":"3bc6ebe608bbe4270a467d8fc1d1f8c13ee3b6b4","user":{"login":"qooxdoo","id":105118,"avatar_url":"https://avatars.githubusercontent.com/u/105118?v=3","gravatar_id":"","url":"https://api.github.com/users/qooxdoo","html_url":"https://github.com/qooxdoo","followers_url":"https://api.github.com/users/qooxdoo/followers","following_url":"https://api.github.com/users/qooxdoo/following{/other_user}","gists_url":"https://api.github.com/users/qooxdoo/gists{/gist_id}","starred_url":"https://api.github.com/users/qooxdoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qooxdoo/subscriptions","organizations_url":"https://api.github.com/users/qooxdoo/orgs","repos_url":"https://api.github.com/users/qooxdoo/repos","events_url":"https://api.github.com/users/qooxdoo/events{/privacy}","received_events_url":"https://api.github.com/users/qooxdoo/received_events","type":"Organization","site_admin":false},"repo":{"id":548213,"name":"qooxdoo","full_name":"qooxdoo/qooxdoo","owner":{"login":"qooxdoo","id":105118,"avatar_url":"https://avatars.githubusercontent.com/u/105118?v=3","gravatar_id":"","url":"https://api.github.com/users/qooxdoo","html_url":"https://github.com/qooxdoo","followers_url":"https://api.github.com/users/qooxdoo/followers","following_url":"https://api.github.com/users/qooxdoo/following{/other_user}","gists_url":"https://api.github.com/users/qooxdoo/gists{/gist_id}","starred_url":"https://api.github.com/users/qooxdoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qooxdoo/subscriptions","organizations_url":"https://api.github.com/users/qooxdoo/orgs","repos_url":"https://api.github.com/users/qooxdoo/repos","events_url":"https://api.github.com/users/qooxdoo/events{/privacy}","received_events_url":"https://api.github.com/users/qooxdoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qooxdoo/qooxdoo","description":"qooxdoo - Universal JavaScript Framework","fork":false,"url":"https://api.github.com/repos/qooxdoo/qooxdoo","forks_url":"https://api.github.com/repos/qooxdoo/qooxdoo/forks","keys_url":"https://api.github.com/repos/qooxdoo/qooxdoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qooxdoo/qooxdoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qooxdoo/qooxdoo/teams","hooks_url":"https://api.github.com/repos/qooxdoo/qooxdoo/hooks","issue_events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/events{/number}","events_url":"https://api.github.com/repos/qooxdoo/qooxdoo/events","assignees_url":"https://api.github.com/repos/qooxdoo/qooxdoo/assignees{/user}","branches_url":"https://api.github.com/repos/qooxdoo/qooxdoo/branches{/branch}","tags_url":"https://api.github.com/repos/qooxdoo/qooxdoo/tags","blobs_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/{sha}","languages_url":"https://api.github.com/repos/qooxdoo/qooxdoo/languages","stargazers_url":"https://api.github.com/repos/qooxdoo/qooxdoo/stargazers","contributors_url":"https://api.github.com/repos/qooxdoo/qooxdoo/contributors","subscribers_url":"https://api.github.com/repos/qooxdoo/qooxdoo/subscribers","subscription_url":"https://api.github.com/repos/qooxdoo/qooxdoo/subscription","commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/qooxdoo/qooxdoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/qooxdoo/qooxdoo/contents/{+path}","compare_url":"https://api.github.com/repos/qooxdoo/qooxdoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qooxdoo/qooxdoo/merges","archive_url":"https://api.github.com/repos/qooxdoo/qooxdoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qooxdoo/qooxdoo/downloads","issues_url":"https://api.github.com/repos/qooxdoo/qooxdoo/issues{/number}","pulls_url":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls{/number}","milestones_url":"https://api.github.com/repos/qooxdoo/qooxdoo/milestones{/number}","notifications_url":"https://api.github.com/repos/qooxdoo/qooxdoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qooxdoo/qooxdoo/labels{/name}","releases_url":"https://api.github.com/repos/qooxdoo/qooxdoo/releases{/id}","deployments_url":"https://api.github.com/repos/qooxdoo/qooxdoo/deployments","created_at":"2010-03-05T10:01:27Z","updated_at":"2016-07-03T20:31:36Z","pushed_at":"2016-07-05T12:15:56Z","git_url":"git://github.com/qooxdoo/qooxdoo.git","ssh_url":"git@github.com:qooxdoo/qooxdoo.git","clone_url":"https://github.com/qooxdoo/qooxdoo.git","svn_url":"https://github.com/qooxdoo/qooxdoo","homepage":"http://qooxdoo.org","size":265301,"stargazers_count":510,"watchers_count":510,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":32,"forks":186,"open_issues":32,"watchers":510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076"},"html":{"href":"https://github.com/qooxdoo/qooxdoo/pull/9076"},"issue":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076"},"comments":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/issues/9076/comments"},"review_comments":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076/comments"},"review_comment":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/pulls/9076/commits"},"statuses":{"href":"https://api.github.com/repos/qooxdoo/qooxdoo/statuses/bba9455254e974c520e4c356e64379a3ab7b687e"}}}}
{"actor":{"display_login":"level420"}}