{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/comments/93838690","pull_request_review_id":14372650,"id":93838690,"diff_hunk":"@@ -322,6 +322,34 @@ rule \"ocaml C stubs: (o|obj) -> clib\"\n         object file only.\"\n   (C_tools.make_single_library \"%(path)%(libname)\" \"%(path)lib%(libname).clib\");;\n \n+(** Static libraries (.cmxa) and (.cmxs):\n+\n+    Historically ocamlbuild had a bit too many .cmxs-related for its","path":"src/ocaml_specific.ml","position":6,"original_position":6,"commit_id":"f1da41d749177a8d027fab7e0ea4bca3c67abf4d","original_commit_id":"f1da41d749177a8d027fab7e0ea4bca3c67abf4d","user":{"login":"Armael","id":315125,"avatar_url":"https://avatars.githubusercontent.com/u/315125?v=3","gravatar_id":"","url":"https://api.github.com/users/Armael","html_url":"https://github.com/Armael","followers_url":"https://api.github.com/users/Armael/followers","following_url":"https://api.github.com/users/Armael/following{/other_user}","gists_url":"https://api.github.com/users/Armael/gists{/gist_id}","starred_url":"https://api.github.com/users/Armael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armael/subscriptions","organizations_url":"https://api.github.com/users/Armael/orgs","repos_url":"https://api.github.com/users/Armael/repos","events_url":"https://api.github.com/users/Armael/events{/privacy}","received_events_url":"https://api.github.com/users/Armael/received_events","type":"User","site_admin":false},"body":"\".cmxs-related rules\"?","created_at":"2016-12-26T02:43:47Z","updated_at":"2016-12-26T02:43:47Z","html_url":"https://github.com/ocaml/ocamlbuild/pull/135#discussion_r93838690","pull_request_url":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/comments/93838690"},"html":{"href":"https://github.com/ocaml/ocamlbuild/pull/135#discussion_r93838690"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135","id":99335026,"html_url":"https://github.com/ocaml/ocamlbuild/pull/135","diff_url":"https://github.com/ocaml/ocamlbuild/pull/135.diff","patch_url":"https://github.com/ocaml/ocamlbuild/pull/135.patch","issue_url":"https://api.github.com/repos/ocaml/ocamlbuild/issues/135","number":135,"state":"open","locked":false,"title":"Understand cmxs rules","user":{"login":"gasche","id":426238,"avatar_url":"https://avatars.githubusercontent.com/u/426238?v=3","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"body":"Contains the changes discussed in the re-discussion of #131. @Armael, would you by chance have the time to give it a second pair of eyes?","created_at":"2016-12-26T02:37:12Z","updated_at":"2016-12-26T02:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0dd7668e668cc2d25aa1338c49b23df2cbb7ab7c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocamlbuild/issues/135/comments","statuses_url":"https://api.github.com/repos/ocaml/ocamlbuild/statuses/f1da41d749177a8d027fab7e0ea4bca3c67abf4d","head":{"label":"gasche:understand-cmxs-rules","ref":"understand-cmxs-rules","sha":"f1da41d749177a8d027fab7e0ea4bca3c67abf4d","user":{"login":"gasche","id":426238,"avatar_url":"https://avatars.githubusercontent.com/u/426238?v=3","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"repo":{"id":48485337,"name":"ocamlbuild","full_name":"gasche/ocamlbuild","owner":{"login":"gasche","id":426238,"avatar_url":"https://avatars.githubusercontent.com/u/426238?v=3","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gasche/ocamlbuild","description":"OCamlbuild","fork":true,"url":"https://api.github.com/repos/gasche/ocamlbuild","forks_url":"https://api.github.com/repos/gasche/ocamlbuild/forks","keys_url":"https://api.github.com/repos/gasche/ocamlbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gasche/ocamlbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gasche/ocamlbuild/teams","hooks_url":"https://api.github.com/repos/gasche/ocamlbuild/hooks","issue_events_url":"https://api.github.com/repos/gasche/ocamlbuild/issues/events{/number}","events_url":"https://api.github.com/repos/gasche/ocamlbuild/events","assignees_url":"https://api.github.com/repos/gasche/ocamlbuild/assignees{/user}","branches_url":"https://api.github.com/repos/gasche/ocamlbuild/branches{/branch}","tags_url":"https://api.github.com/repos/gasche/ocamlbuild/tags","blobs_url":"https://api.github.com/repos/gasche/ocamlbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gasche/ocamlbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gasche/ocamlbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/gasche/ocamlbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gasche/ocamlbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/gasche/ocamlbuild/languages","stargazers_url":"https://api.github.com/repos/gasche/ocamlbuild/stargazers","contributors_url":"https://api.github.com/repos/gasche/ocamlbuild/contributors","subscribers_url":"https://api.github.com/repos/gasche/ocamlbuild/subscribers","subscription_url":"https://api.github.com/repos/gasche/ocamlbuild/subscription","commits_url":"https://api.github.com/repos/gasche/ocamlbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/gasche/ocamlbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/gasche/ocamlbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/gasche/ocamlbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/gasche/ocamlbuild/contents/{+path}","compare_url":"https://api.github.com/repos/gasche/ocamlbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gasche/ocamlbuild/merges","archive_url":"https://api.github.com/repos/gasche/ocamlbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gasche/ocamlbuild/downloads","issues_url":"https://api.github.com/repos/gasche/ocamlbuild/issues{/number}","pulls_url":"https://api.github.com/repos/gasche/ocamlbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/gasche/ocamlbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/gasche/ocamlbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gasche/ocamlbuild/labels{/name}","releases_url":"https://api.github.com/repos/gasche/ocamlbuild/releases{/id}","deployments_url":"https://api.github.com/repos/gasche/ocamlbuild/deployments","created_at":"2015-12-23T10:44:18Z","updated_at":"2016-01-19T21:36:30Z","pushed_at":"2016-12-26T02:36:22Z","git_url":"git://github.com/gasche/ocamlbuild.git","ssh_url":"git@github.com:gasche/ocamlbuild.git","clone_url":"https://github.com/gasche/ocamlbuild.git","svn_url":"https://github.com/gasche/ocamlbuild","homepage":null,"size":1100,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ocaml:master","ref":"master","sha":"5a3fe71b738f0327579f7b27420a5c9469123f79","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":47338127,"name":"ocamlbuild","full_name":"ocaml/ocamlbuild","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocamlbuild","description":"OCamlbuild","fork":false,"url":"https://api.github.com/repos/ocaml/ocamlbuild","forks_url":"https://api.github.com/repos/ocaml/ocamlbuild/forks","keys_url":"https://api.github.com/repos/ocaml/ocamlbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocamlbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocamlbuild/teams","hooks_url":"https://api.github.com/repos/ocaml/ocamlbuild/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocamlbuild/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocamlbuild/events","assignees_url":"https://api.github.com/repos/ocaml/ocamlbuild/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocamlbuild/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocamlbuild/tags","blobs_url":"https://api.github.com/repos/ocaml/ocamlbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocamlbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocamlbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocamlbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocamlbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocamlbuild/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocamlbuild/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocamlbuild/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocamlbuild/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocamlbuild/subscription","commits_url":"https://api.github.com/repos/ocaml/ocamlbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocamlbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocamlbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocamlbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocamlbuild/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocamlbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocamlbuild/merges","archive_url":"https://api.github.com/repos/ocaml/ocamlbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocamlbuild/downloads","issues_url":"https://api.github.com/repos/ocaml/ocamlbuild/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocamlbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocamlbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocamlbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocamlbuild/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocamlbuild/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocamlbuild/deployments","created_at":"2015-12-03T14:43:57Z","updated_at":"2016-12-19T14:47:47Z","pushed_at":"2016-12-26T02:37:13Z","git_url":"git://github.com/ocaml/ocamlbuild.git","ssh_url":"git@github.com:ocaml/ocamlbuild.git","clone_url":"https://github.com/ocaml/ocamlbuild.git","svn_url":"https://github.com/ocaml/ocamlbuild","homepage":null,"size":1096,"stargazers_count":40,"watchers_count":40,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":57,"forks":30,"open_issues":57,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135"},"html":{"href":"https://github.com/ocaml/ocamlbuild/pull/135"},"issue":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/issues/135"},"comments":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocamlbuild/statuses/f1da41d749177a8d027fab7e0ea4bca3c67abf4d"}}}}
{"actor":{"display_login":"Armael"}}