{"action":"created","comment":{"url":"https://api.github.com/repos/bignerdranch/Deferred/pulls/comments/59067897","id":59067897,"diff_hunk":"@@ -0,0 +1,52 @@\n+//\n+//  FutureComposition.swift\n+//  Deferred\n+//\n+//  Created by Zachary Waldowski on 4/2/16.\n+//  Copyright © 2014-2016 Big Nerd Ranch. Licensed under MIT.\n+//\n+\n+extension FutureType {\n+    /// Composes this future with another.","path":"Sources/FutureComposition.swift","position":10,"original_position":10,"commit_id":"8f757d2d18468b049af0a470e98c0d9c79ee7a8e","original_commit_id":"8f757d2d18468b049af0a470e98c0d9c79ee7a8e","user":{"login":"zwaldowski","id":170812,"avatar_url":"https://avatars.githubusercontent.com/u/170812?v=3","gravatar_id":"","url":"https://api.github.com/users/zwaldowski","html_url":"https://github.com/zwaldowski","followers_url":"https://api.github.com/users/zwaldowski/followers","following_url":"https://api.github.com/users/zwaldowski/following{/other_user}","gists_url":"https://api.github.com/users/zwaldowski/gists{/gist_id}","starred_url":"https://api.github.com/users/zwaldowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwaldowski/subscriptions","organizations_url":"https://api.github.com/users/zwaldowski/orgs","repos_url":"https://api.github.com/users/zwaldowski/repos","events_url":"https://api.github.com/users/zwaldowski/events{/privacy}","received_events_url":"https://api.github.com/users/zwaldowski/received_events","type":"User","site_admin":false},"body":"Yeah, I think these can do away with the doc tags (except for `seealso`) and just be \"Creates a future that becomes…\"\r\n\r\n[See also](https://swift.org/documentation/api-design-guidelines/):\r\n\r\n> Describe what a function or method does and what it returns, omitting null effects and Void returns:\r\n> \r\n> ```swift\r\n> /// Inserts `newHead` at the beginning of `self`.\r\n> mutating func prepend(newHead: Int)\r\n> \r\n> /// Returns a `List` containing `head` followed by the elements\r\n> /// of `self`.\r\n> func prepending(head: Element) -> List\r\n> \r\n> /// Removes and returns the first element of `self` if non-empty;\r\n> /// returns `nil` otherwise.\r\n> mutating func popFirst() -> Element?\r\n> ```\r\n","created_at":"2016-04-08T18:19:32Z","updated_at":"2016-04-08T18:19:32Z","html_url":"https://github.com/bignerdranch/Deferred/pull/89#discussion_r59067897","pull_request_url":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89","_links":{"self":{"href":"https://api.github.com/repos/bignerdranch/Deferred/pulls/comments/59067897"},"html":{"href":"https://github.com/bignerdranch/Deferred/pull/89#discussion_r59067897"},"pull_request":{"href":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89","id":65648180,"html_url":"https://github.com/bignerdranch/Deferred/pull/89","diff_url":"https://github.com/bignerdranch/Deferred/pull/89.diff","patch_url":"https://github.com/bignerdranch/Deferred/pull/89.patch","issue_url":"https://api.github.com/repos/bignerdranch/Deferred/issues/89","number":89,"state":"open","locked":false,"title":"Decouple from dispatch_queue_t with ExecutorType","user":{"login":"zwaldowski","id":170812,"avatar_url":"https://avatars.githubusercontent.com/u/170812?v=3","gravatar_id":"","url":"https://api.github.com/users/zwaldowski","html_url":"https://github.com/zwaldowski","followers_url":"https://api.github.com/users/zwaldowski/followers","following_url":"https://api.github.com/users/zwaldowski/following{/other_user}","gists_url":"https://api.github.com/users/zwaldowski/gists{/gist_id}","starred_url":"https://api.github.com/users/zwaldowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwaldowski/subscriptions","organizations_url":"https://api.github.com/users/zwaldowski/orgs","repos_url":"https://api.github.com/users/zwaldowski/repos","events_url":"https://api.github.com/users/zwaldowski/events{/privacy}","received_events_url":"https://api.github.com/users/zwaldowski/received_events","type":"User","site_admin":false},"body":"#### What's in this pull request?\r\n\r\nAddresses #88 through the introduction of an `ExecutorType` protocol. The concept itself still requires GCD, though, so no progress towards #54 yet. (All that can mostly be guarded out with `#if os` at this point, but that step has not been taken yet.)\r\n\r\n#### Testing\r\n\r\nThe tests continue to use the queue-based versions of `upon`. Extra tests should be written to handle the minor new code path in `Deferred` itself.\r\n\r\n#### API Changes\r\n\r\nThis is a source-compatible API change.","created_at":"2016-04-07T15:18:35Z","updated_at":"2016-04-08T18:19:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad4661ad6a5ac5b50c9fa412cb28b83cf35268a3","assignee":null,"milestone":{"url":"https://api.github.com/repos/bignerdranch/Deferred/milestones/3","html_url":"https://github.com/bignerdranch/Deferred/milestones/2.0","labels_url":"https://api.github.com/repos/bignerdranch/Deferred/milestones/3/labels","id":1284200,"number":3,"title":"2.0","description":"","creator":{"login":"zwaldowski","id":170812,"avatar_url":"https://avatars.githubusercontent.com/u/170812?v=3","gravatar_id":"","url":"https://api.github.com/users/zwaldowski","html_url":"https://github.com/zwaldowski","followers_url":"https://api.github.com/users/zwaldowski/followers","following_url":"https://api.github.com/users/zwaldowski/following{/other_user}","gists_url":"https://api.github.com/users/zwaldowski/gists{/gist_id}","starred_url":"https://api.github.com/users/zwaldowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwaldowski/subscriptions","organizations_url":"https://api.github.com/users/zwaldowski/orgs","repos_url":"https://api.github.com/users/zwaldowski/repos","events_url":"https://api.github.com/users/zwaldowski/events{/privacy}","received_events_url":"https://api.github.com/users/zwaldowski/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":26,"state":"open","created_at":"2015-09-01T14:30:22Z","updated_at":"2016-04-08T15:37:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89/commits","review_comments_url":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89/comments","review_comment_url":"https://api.github.com/repos/bignerdranch/Deferred/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bignerdranch/Deferred/issues/89/comments","statuses_url":"https://api.github.com/repos/bignerdranch/Deferred/statuses/8f757d2d18468b049af0a470e98c0d9c79ee7a8e","head":{"label":"bignerdranch:zwaldowski/executor","ref":"zwaldowski/executor","sha":"8f757d2d18468b049af0a470e98c0d9c79ee7a8e","user":{"login":"bignerdranch","id":230455,"avatar_url":"https://avatars.githubusercontent.com/u/230455?v=3","gravatar_id":"","url":"https://api.github.com/users/bignerdranch","html_url":"https://github.com/bignerdranch","followers_url":"https://api.github.com/users/bignerdranch/followers","following_url":"https://api.github.com/users/bignerdranch/following{/other_user}","gists_url":"https://api.github.com/users/bignerdranch/gists{/gist_id}","starred_url":"https://api.github.com/users/bignerdranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignerdranch/subscriptions","organizations_url":"https://api.github.com/users/bignerdranch/orgs","repos_url":"https://api.github.com/users/bignerdranch/repos","events_url":"https://api.github.com/users/bignerdranch/events{/privacy}","received_events_url":"https://api.github.com/users/bignerdranch/received_events","type":"Organization","site_admin":false},"repo":{"id":22843893,"name":"Deferred","full_name":"bignerdranch/Deferred","owner":{"login":"bignerdranch","id":230455,"avatar_url":"https://avatars.githubusercontent.com/u/230455?v=3","gravatar_id":"","url":"https://api.github.com/users/bignerdranch","html_url":"https://github.com/bignerdranch","followers_url":"https://api.github.com/users/bignerdranch/followers","following_url":"https://api.github.com/users/bignerdranch/following{/other_user}","gists_url":"https://api.github.com/users/bignerdranch/gists{/gist_id}","starred_url":"https://api.github.com/users/bignerdranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignerdranch/subscriptions","organizations_url":"https://api.github.com/users/bignerdranch/orgs","repos_url":"https://api.github.com/users/bignerdranch/repos","events_url":"https://api.github.com/users/bignerdranch/events{/privacy}","received_events_url":"https://api.github.com/users/bignerdranch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bignerdranch/Deferred","description":"An implementation of OCaml's Deferred for Swift.","fork":false,"url":"https://api.github.com/repos/bignerdranch/Deferred","forks_url":"https://api.github.com/repos/bignerdranch/Deferred/forks","keys_url":"https://api.github.com/repos/bignerdranch/Deferred/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bignerdranch/Deferred/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bignerdranch/Deferred/teams","hooks_url":"https://api.github.com/repos/bignerdranch/Deferred/hooks","issue_events_url":"https://api.github.com/repos/bignerdranch/Deferred/issues/events{/number}","events_url":"https://api.github.com/repos/bignerdranch/Deferred/events","assignees_url":"https://api.github.com/repos/bignerdranch/Deferred/assignees{/user}","branches_url":"https://api.github.com/repos/bignerdranch/Deferred/branches{/branch}","tags_url":"https://api.github.com/repos/bignerdranch/Deferred/tags","blobs_url":"https://api.github.com/repos/bignerdranch/Deferred/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bignerdranch/Deferred/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bignerdranch/Deferred/git/refs{/sha}","trees_url":"https://api.github.com/repos/bignerdranch/Deferred/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bignerdranch/Deferred/statuses/{sha}","languages_url":"https://api.github.com/repos/bignerdranch/Deferred/languages","stargazers_url":"https://api.github.com/repos/bignerdranch/Deferred/stargazers","contributors_url":"https://api.github.com/repos/bignerdranch/Deferred/contributors","subscribers_url":"https://api.github.com/repos/bignerdranch/Deferred/subscribers","subscription_url":"https://api.github.com/repos/bignerdranch/Deferred/subscription","commits_url":"https://api.github.com/repos/bignerdranch/Deferred/commits{/sha}","git_commits_url":"https://api.github.com/repos/bignerdranch/Deferred/git/commits{/sha}","comments_url":"https://api.github.com/repos/bignerdranch/Deferred/comments{/number}","issue_comment_url":"https://api.github.com/repos/bignerdranch/Deferred/issues/comments{/number}","contents_url":"https://api.github.com/repos/bignerdranch/Deferred/contents/{+path}","compare_url":"https://api.github.com/repos/bignerdranch/Deferred/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bignerdranch/Deferred/merges","archive_url":"https://api.github.com/repos/bignerdranch/Deferred/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bignerdranch/Deferred/downloads","issues_url":"https://api.github.com/repos/bignerdranch/Deferred/issues{/number}","pulls_url":"https://api.github.com/repos/bignerdranch/Deferred/pulls{/number}","milestones_url":"https://api.github.com/repos/bignerdranch/Deferred/milestones{/number}","notifications_url":"https://api.github.com/repos/bignerdranch/Deferred/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bignerdranch/Deferred/labels{/name}","releases_url":"https://api.github.com/repos/bignerdranch/Deferred/releases{/id}","deployments_url":"https://api.github.com/repos/bignerdranch/Deferred/deployments","created_at":"2014-08-11T15:24:22Z","updated_at":"2016-04-04T19:30:12Z","pushed_at":"2016-04-07T15:18:36Z","git_url":"git://github.com/bignerdranch/Deferred.git","ssh_url":"git@github.com:bignerdranch/Deferred.git","clone_url":"https://github.com/bignerdranch/Deferred.git","svn_url":"https://github.com/bignerdranch/Deferred","homepage":"","size":454,"stargazers_count":205,"watchers_count":205,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":205,"default_branch":"master"}},"base":{"label":"bignerdranch:master","ref":"master","sha":"464b2c420f455cdc9f9b0bd6e47a7a2d95fef51c","user":{"login":"bignerdranch","id":230455,"avatar_url":"https://avatars.githubusercontent.com/u/230455?v=3","gravatar_id":"","url":"https://api.github.com/users/bignerdranch","html_url":"https://github.com/bignerdranch","followers_url":"https://api.github.com/users/bignerdranch/followers","following_url":"https://api.github.com/users/bignerdranch/following{/other_user}","gists_url":"https://api.github.com/users/bignerdranch/gists{/gist_id}","starred_url":"https://api.github.com/users/bignerdranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignerdranch/subscriptions","organizations_url":"https://api.github.com/users/bignerdranch/orgs","repos_url":"https://api.github.com/users/bignerdranch/repos","events_url":"https://api.github.com/users/bignerdranch/events{/privacy}","received_events_url":"https://api.github.com/users/bignerdranch/received_events","type":"Organization","site_admin":false},"repo":{"id":22843893,"name":"Deferred","full_name":"bignerdranch/Deferred","owner":{"login":"bignerdranch","id":230455,"avatar_url":"https://avatars.githubusercontent.com/u/230455?v=3","gravatar_id":"","url":"https://api.github.com/users/bignerdranch","html_url":"https://github.com/bignerdranch","followers_url":"https://api.github.com/users/bignerdranch/followers","following_url":"https://api.github.com/users/bignerdranch/following{/other_user}","gists_url":"https://api.github.com/users/bignerdranch/gists{/gist_id}","starred_url":"https://api.github.com/users/bignerdranch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bignerdranch/subscriptions","organizations_url":"https://api.github.com/users/bignerdranch/orgs","repos_url":"https://api.github.com/users/bignerdranch/repos","events_url":"https://api.github.com/users/bignerdranch/events{/privacy}","received_events_url":"https://api.github.com/users/bignerdranch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bignerdranch/Deferred","description":"An implementation of OCaml's Deferred for Swift.","fork":false,"url":"https://api.github.com/repos/bignerdranch/Deferred","forks_url":"https://api.github.com/repos/bignerdranch/Deferred/forks","keys_url":"https://api.github.com/repos/bignerdranch/Deferred/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bignerdranch/Deferred/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bignerdranch/Deferred/teams","hooks_url":"https://api.github.com/repos/bignerdranch/Deferred/hooks","issue_events_url":"https://api.github.com/repos/bignerdranch/Deferred/issues/events{/number}","events_url":"https://api.github.com/repos/bignerdranch/Deferred/events","assignees_url":"https://api.github.com/repos/bignerdranch/Deferred/assignees{/user}","branches_url":"https://api.github.com/repos/bignerdranch/Deferred/branches{/branch}","tags_url":"https://api.github.com/repos/bignerdranch/Deferred/tags","blobs_url":"https://api.github.com/repos/bignerdranch/Deferred/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bignerdranch/Deferred/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bignerdranch/Deferred/git/refs{/sha}","trees_url":"https://api.github.com/repos/bignerdranch/Deferred/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bignerdranch/Deferred/statuses/{sha}","languages_url":"https://api.github.com/repos/bignerdranch/Deferred/languages","stargazers_url":"https://api.github.com/repos/bignerdranch/Deferred/stargazers","contributors_url":"https://api.github.com/repos/bignerdranch/Deferred/contributors","subscribers_url":"https://api.github.com/repos/bignerdranch/Deferred/subscribers","subscription_url":"https://api.github.com/repos/bignerdranch/Deferred/subscription","commits_url":"https://api.github.com/repos/bignerdranch/Deferred/commits{/sha}","git_commits_url":"https://api.github.com/repos/bignerdranch/Deferred/git/commits{/sha}","comments_url":"https://api.github.com/repos/bignerdranch/Deferred/comments{/number}","issue_comment_url":"https://api.github.com/repos/bignerdranch/Deferred/issues/comments{/number}","contents_url":"https://api.github.com/repos/bignerdranch/Deferred/contents/{+path}","compare_url":"https://api.github.com/repos/bignerdranch/Deferred/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bignerdranch/Deferred/merges","archive_url":"https://api.github.com/repos/bignerdranch/Deferred/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bignerdranch/Deferred/downloads","issues_url":"https://api.github.com/repos/bignerdranch/Deferred/issues{/number}","pulls_url":"https://api.github.com/repos/bignerdranch/Deferred/pulls{/number}","milestones_url":"https://api.github.com/repos/bignerdranch/Deferred/milestones{/number}","notifications_url":"https://api.github.com/repos/bignerdranch/Deferred/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bignerdranch/Deferred/labels{/name}","releases_url":"https://api.github.com/repos/bignerdranch/Deferred/releases{/id}","deployments_url":"https://api.github.com/repos/bignerdranch/Deferred/deployments","created_at":"2014-08-11T15:24:22Z","updated_at":"2016-04-04T19:30:12Z","pushed_at":"2016-04-07T15:18:36Z","git_url":"git://github.com/bignerdranch/Deferred.git","ssh_url":"git@github.com:bignerdranch/Deferred.git","clone_url":"https://github.com/bignerdranch/Deferred.git","svn_url":"https://github.com/bignerdranch/Deferred","homepage":"","size":454,"stargazers_count":205,"watchers_count":205,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89"},"html":{"href":"https://github.com/bignerdranch/Deferred/pull/89"},"issue":{"href":"https://api.github.com/repos/bignerdranch/Deferred/issues/89"},"comments":{"href":"https://api.github.com/repos/bignerdranch/Deferred/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/bignerdranch/Deferred/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bignerdranch/Deferred/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/bignerdranch/Deferred/statuses/8f757d2d18468b049af0a470e98c0d9c79ee7a8e"}}}}