{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/802","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/802/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/802/events","html_url":"https://github.com/ocaml/ocaml/pull/802","id":176191660,"number":802,"title":"MPR#7351: ocamldoc html, use tags rather than <br>","user":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars.githubusercontent.com/u/7689388?v=3","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-09-10T17:34:47Z","updated_at":"2016-09-10T20:57:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/802","html_url":"https://github.com/ocaml/ocaml/pull/802","diff_url":"https://github.com/ocaml/ocaml/pull/802.diff","patch_url":"https://github.com/ocaml/ocaml/pull/802.patch"},"body":"This PR proposes to replace all uses of the `<br>` tag outside of `<code>` in the ocamldoc html backend by more meaningful tags, in order to improve the themability of the generated html. See [MPR:7351](http://caml.inria.fr/mantis/view.php?id=7351).\r\n\r\nIn particular, ocamldoc sometimes used `<br>` tags to separate elements of a list, they are now `<li>` elements with a specific class for the corresponding `<ul>`; or to separate different blocks, these block are now given their own `<div>` tag. \r\n\r\nThe manual and default ocamldoc css styles have been altered to keep the rendered html globally similar but could be tweaked further: for instance, the vertical margin for title elements could be increased to get back to the previous spacing.\r\n\r\n@dbuenzli : if you have comments, criticisms or examples of documentation where the `<br>` were particularly problematic, they would be very welcome."},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/246139872","html_url":"https://github.com/ocaml/ocaml/pull/802#issuecomment-246139872","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/802","id":246139872,"user":{"login":"Octachron","id":7689388,"avatar_url":"https://avatars.githubusercontent.com/u/7689388?v=3","gravatar_id":"","url":"https://api.github.com/users/Octachron","html_url":"https://github.com/Octachron","followers_url":"https://api.github.com/users/Octachron/followers","following_url":"https://api.github.com/users/Octachron/following{/other_user}","gists_url":"https://api.github.com/users/Octachron/gists{/gist_id}","starred_url":"https://api.github.com/users/Octachron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Octachron/subscriptions","organizations_url":"https://api.github.com/users/Octachron/orgs","repos_url":"https://api.github.com/users/Octachron/repos","events_url":"https://api.github.com/users/Octachron/events{/privacy}","received_events_url":"https://api.github.com/users/Octachron/received_events","type":"User","site_admin":false},"created_at":"2016-09-10T20:57:50Z","updated_at":"2016-09-10T20:57:50Z","body":"> It's really not a good structure for enabling simple stylesheets.\r\n\r\nI would argue than even more than that, it did not reflect any meaningful intent from  the documentation.\r\n\r\n> Why more than previously ? \r\n\r\nI was unprecise: as much as in trunk currently, a little more than in the previous version of this PR."}}
{"actor":{"display_login":"Octachron"}}