{"action":"created","issue":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/358","repository_url":"https://api.github.com/repos/openresty/lua-nginx-module","labels_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/358/comments","events_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/358/events","html_url":"https://github.com/openresty/lua-nginx-module/pull/358","id":30912647,"number":358,"title":"ngx.shared.DICT.incr optional expire argument","user":{"login":"splitice","id":468579,"avatar_url":"https://avatars.githubusercontent.com/u/468579?v=3","gravatar_id":"","url":"https://api.github.com/users/splitice","html_url":"https://github.com/splitice","followers_url":"https://api.github.com/users/splitice/followers","following_url":"https://api.github.com/users/splitice/following{/other_user}","gists_url":"https://api.github.com/users/splitice/gists{/gist_id}","starred_url":"https://api.github.com/users/splitice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitice/subscriptions","organizations_url":"https://api.github.com/users/splitice/orgs","repos_url":"https://api.github.com/users/splitice/repos","events_url":"https://api.github.com/users/splitice/events{/privacy}","received_events_url":"https://api.github.com/users/splitice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2014-04-05T10:17:05Z","updated_at":"2016-12-18T09:10:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/358","html_url":"https://github.com/openresty/lua-nginx-module/pull/358","diff_url":"https://github.com/openresty/lua-nginx-module/pull/358.diff","patch_url":"https://github.com/openresty/lua-nginx-module/pull/358.patch"},"body":"As mentioned in https://groups.google.com/forum/#!topic/openresty-en/-avsa-jaSYg\n"},"comment":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/comments/267810871","html_url":"https://github.com/openresty/lua-nginx-module/pull/358#issuecomment-267810871","issue_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/358","id":267810871,"user":{"login":"splitice","id":468579,"avatar_url":"https://avatars.githubusercontent.com/u/468579?v=3","gravatar_id":"","url":"https://api.github.com/users/splitice","html_url":"https://github.com/splitice","followers_url":"https://api.github.com/users/splitice/followers","following_url":"https://api.github.com/users/splitice/following{/other_user}","gists_url":"https://api.github.com/users/splitice/gists{/gist_id}","starred_url":"https://api.github.com/users/splitice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splitice/subscriptions","organizations_url":"https://api.github.com/users/splitice/orgs","repos_url":"https://api.github.com/users/splitice/repos","events_url":"https://api.github.com/users/splitice/events{/privacy}","received_events_url":"https://api.github.com/users/splitice/received_events","type":"User","site_admin":false},"created_at":"2016-12-18T09:10:24Z","updated_at":"2016-12-18T09:10:24Z","body":"Sorry, i'm not sure I really see your point regarding existing keys.\r\n\r\nAt-least in our usages of incr over multiple subsystems I can count on one hand the number of times we have used ```incr``` without an expire argument. Large amounts of the time its used as a key'ed counter for certain events, or in reverse to limit certain events.\r\n\r\nIn order to do this with two methods expire would have to return false if the key was not found, and then incr called with init, then if created call expire again. Three method calls for something we currently do with one parameter.\r\n\r\nI have no objections for an exipre method as well. its definitely a plus. Theres a few places we do ```set``` varaibles just to touch the expire time."}}
{"actor":{"display_login":"splitice"}}