{"action":"closed","issue":{"url":"https://api.github.com/repos/scitran/apps/issues/12","repository_url":"https://api.github.com/repos/scitran/apps","labels_url":"https://api.github.com/repos/scitran/apps/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/scitran/apps/issues/12/comments","events_url":"https://api.github.com/repos/scitran/apps/issues/12/events","html_url":"https://github.com/scitran/apps/issues/12","id":145744942,"number":12,"title":"Filenames not quoted in bash","user":{"login":"kofalt","id":265071,"avatar_url":"https://avatars.githubusercontent.com/u/265071?v=3","gravatar_id":"","url":"https://api.github.com/users/kofalt","html_url":"https://github.com/kofalt","followers_url":"https://api.github.com/users/kofalt/followers","following_url":"https://api.github.com/users/kofalt/following{/other_user}","gists_url":"https://api.github.com/users/kofalt/gists{/gist_id}","starred_url":"https://api.github.com/users/kofalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kofalt/subscriptions","organizations_url":"https://api.github.com/users/kofalt/orgs","repos_url":"https://api.github.com/users/kofalt/repos","events_url":"https://api.github.com/users/kofalt/events{/privacy}","received_events_url":"https://api.github.com/users/kofalt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/scitran/apps/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"lmperry","id":2119651,"avatar_url":"https://avatars.githubusercontent.com/u/2119651?v=3","gravatar_id":"","url":"https://api.github.com/users/lmperry","html_url":"https://github.com/lmperry","followers_url":"https://api.github.com/users/lmperry/followers","following_url":"https://api.github.com/users/lmperry/following{/other_user}","gists_url":"https://api.github.com/users/lmperry/gists{/gist_id}","starred_url":"https://api.github.com/users/lmperry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmperry/subscriptions","organizations_url":"https://api.github.com/users/lmperry/orgs","repos_url":"https://api.github.com/users/lmperry/repos","events_url":"https://api.github.com/users/lmperry/events{/privacy}","received_events_url":"https://api.github.com/users/lmperry/received_events","type":"User","site_admin":false},"milestone":null,"comments":0,"created_at":"2016-04-04T17:06:56Z","updated_at":"2016-04-04T17:58:01Z","closed_at":"2016-04-04T17:58:01Z","body":"Discovered by @ryansanford - the use of basename [here](https://github.com/scitran/apps/blob/b59bbb775644b9d7566c6b17533c8e05ab8c8f7f/classifier/dicom-mr-classifier/run#L29) does not quote the file name, and thus will not work with filenames that have spaces.\r\n\r\n```\r\nbasename: extra operand 'SSFSE.zip'\r\nTry 'basename --help' for more information.\r\nusage: dicom-mr-classifier.py [-h] [--log_level LOG_LEVEL] dcmtgz [outbase]\r\ndicom-mr-classifier.py: error: unrecognized arguments: SSFSE.zip /flywheel/v0/output/\r\nNo results found in output directory... Exiting\r\nExit was 1\r\n```\r\n\r\nIt may be that other parts of the same script, and / or the other wrappers, also need quotes added."}}