{"action":"created","comment":{"url":"https://api.github.com/repos/rustbridge/helix/pulls/comments/67728475","id":67728475,"diff_hunk":"@@ -25,3 +26,11 @@ impl ToRust<String> for CheckedValue<String> {\n         unsafe { std::str::from_utf8_unchecked(slice) }.to_string()\n     }\n }\n+\n+impl ToRuby for String {\n+    fn to_ruby(self) -> VALUE {\n+        let len = self.len();\n+        let cstr = CString::new(self).unwrap();","path":"src/coercions/string.rs","position":20,"original_position":20,"commit_id":"51611e1d560aa6495d92be9d9e08a552403e588b","original_commit_id":"51611e1d560aa6495d92be9d9e08a552403e588b","user":{"login":"aergonaut","id":284007,"avatar_url":"https://avatars.githubusercontent.com/u/284007?v=3","gravatar_id":"","url":"https://api.github.com/users/aergonaut","html_url":"https://github.com/aergonaut","followers_url":"https://api.github.com/users/aergonaut/followers","following_url":"https://api.github.com/users/aergonaut/following{/other_user}","gists_url":"https://api.github.com/users/aergonaut/gists{/gist_id}","starred_url":"https://api.github.com/users/aergonaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aergonaut/subscriptions","organizations_url":"https://api.github.com/users/aergonaut/orgs","repos_url":"https://api.github.com/users/aergonaut/repos","events_url":"https://api.github.com/users/aergonaut/events{/privacy}","received_events_url":"https://api.github.com/users/aergonaut/received_events","type":"User","site_admin":false},"body":"Ah gotcha. Sorry misunderstood your comment","created_at":"2016-06-20T17:16:32Z","updated_at":"2016-06-20T17:16:33Z","html_url":"https://github.com/rustbridge/helix/pull/10#discussion_r67728475","pull_request_url":"https://api.github.com/repos/rustbridge/helix/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/rustbridge/helix/pulls/comments/67728475"},"html":{"href":"https://github.com/rustbridge/helix/pull/10#discussion_r67728475"},"pull_request":{"href":"https://api.github.com/repos/rustbridge/helix/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/rustbridge/helix/pulls/10","id":71312693,"html_url":"https://github.com/rustbridge/helix/pull/10","diff_url":"https://github.com/rustbridge/helix/pull/10.diff","patch_url":"https://github.com/rustbridge/helix/pull/10.patch","issue_url":"https://api.github.com/repos/rustbridge/helix/issues/10","number":10,"state":"open","locked":false,"title":"Implement ToRuby for String","user":{"login":"aergonaut","id":284007,"avatar_url":"https://avatars.githubusercontent.com/u/284007?v=3","gravatar_id":"","url":"https://api.github.com/users/aergonaut","html_url":"https://github.com/aergonaut","followers_url":"https://api.github.com/users/aergonaut/followers","following_url":"https://api.github.com/users/aergonaut/following{/other_user}","gists_url":"https://api.github.com/users/aergonaut/gists{/gist_id}","starred_url":"https://api.github.com/users/aergonaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aergonaut/subscriptions","organizations_url":"https://api.github.com/users/aergonaut/orgs","repos_url":"https://api.github.com/users/aergonaut/repos","events_url":"https://api.github.com/users/aergonaut/events{/privacy}","received_events_url":"https://api.github.com/users/aergonaut/received_events","type":"User","site_admin":false},"body":"Hi @wycats, @chancancode!\r\n\r\nI've been really excited about this project since last year when it was still called TurboRuby. I was really happy to see it come back as Helix at RailsConf this year!\r\n\r\nI was playing around with the library and noticed that the only types that have `ToRuby` implementations so far are `()` and `bool`. Implementing the trait for `String` seemed straightforward, so I took a try at it.\r\n\r\nI am definitely not an expert at Rust or MRI, so I'm not sure if this is the correct way to handle this. Please let me know!","created_at":"2016-05-25T00:08:16Z","updated_at":"2016-06-20T17:16:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c14c7087f524b39e45dfac426668e48122dced3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rustbridge/helix/pulls/10/commits","review_comments_url":"https://api.github.com/repos/rustbridge/helix/pulls/10/comments","review_comment_url":"https://api.github.com/repos/rustbridge/helix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rustbridge/helix/issues/10/comments","statuses_url":"https://api.github.com/repos/rustbridge/helix/statuses/51611e1d560aa6495d92be9d9e08a552403e588b","head":{"label":"aergonaut:string-to-ruby","ref":"string-to-ruby","sha":"51611e1d560aa6495d92be9d9e08a552403e588b","user":{"login":"aergonaut","id":284007,"avatar_url":"https://avatars.githubusercontent.com/u/284007?v=3","gravatar_id":"","url":"https://api.github.com/users/aergonaut","html_url":"https://github.com/aergonaut","followers_url":"https://api.github.com/users/aergonaut/followers","following_url":"https://api.github.com/users/aergonaut/following{/other_user}","gists_url":"https://api.github.com/users/aergonaut/gists{/gist_id}","starred_url":"https://api.github.com/users/aergonaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aergonaut/subscriptions","organizations_url":"https://api.github.com/users/aergonaut/orgs","repos_url":"https://api.github.com/users/aergonaut/repos","events_url":"https://api.github.com/users/aergonaut/events{/privacy}","received_events_url":"https://api.github.com/users/aergonaut/received_events","type":"User","site_admin":false},"repo":{"id":58946726,"name":"helix","full_name":"aergonaut/helix","owner":{"login":"aergonaut","id":284007,"avatar_url":"https://avatars.githubusercontent.com/u/284007?v=3","gravatar_id":"","url":"https://api.github.com/users/aergonaut","html_url":"https://github.com/aergonaut","followers_url":"https://api.github.com/users/aergonaut/followers","following_url":"https://api.github.com/users/aergonaut/following{/other_user}","gists_url":"https://api.github.com/users/aergonaut/gists{/gist_id}","starred_url":"https://api.github.com/users/aergonaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aergonaut/subscriptions","organizations_url":"https://api.github.com/users/aergonaut/orgs","repos_url":"https://api.github.com/users/aergonaut/repos","events_url":"https://api.github.com/users/aergonaut/events{/privacy}","received_events_url":"https://api.github.com/users/aergonaut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aergonaut/helix","description":"Ruby and Rust, sitting in a tree","fork":true,"url":"https://api.github.com/repos/aergonaut/helix","forks_url":"https://api.github.com/repos/aergonaut/helix/forks","keys_url":"https://api.github.com/repos/aergonaut/helix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aergonaut/helix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aergonaut/helix/teams","hooks_url":"https://api.github.com/repos/aergonaut/helix/hooks","issue_events_url":"https://api.github.com/repos/aergonaut/helix/issues/events{/number}","events_url":"https://api.github.com/repos/aergonaut/helix/events","assignees_url":"https://api.github.com/repos/aergonaut/helix/assignees{/user}","branches_url":"https://api.github.com/repos/aergonaut/helix/branches{/branch}","tags_url":"https://api.github.com/repos/aergonaut/helix/tags","blobs_url":"https://api.github.com/repos/aergonaut/helix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aergonaut/helix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aergonaut/helix/git/refs{/sha}","trees_url":"https://api.github.com/repos/aergonaut/helix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aergonaut/helix/statuses/{sha}","languages_url":"https://api.github.com/repos/aergonaut/helix/languages","stargazers_url":"https://api.github.com/repos/aergonaut/helix/stargazers","contributors_url":"https://api.github.com/repos/aergonaut/helix/contributors","subscribers_url":"https://api.github.com/repos/aergonaut/helix/subscribers","subscription_url":"https://api.github.com/repos/aergonaut/helix/subscription","commits_url":"https://api.github.com/repos/aergonaut/helix/commits{/sha}","git_commits_url":"https://api.github.com/repos/aergonaut/helix/git/commits{/sha}","comments_url":"https://api.github.com/repos/aergonaut/helix/comments{/number}","issue_comment_url":"https://api.github.com/repos/aergonaut/helix/issues/comments{/number}","contents_url":"https://api.github.com/repos/aergonaut/helix/contents/{+path}","compare_url":"https://api.github.com/repos/aergonaut/helix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aergonaut/helix/merges","archive_url":"https://api.github.com/repos/aergonaut/helix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aergonaut/helix/downloads","issues_url":"https://api.github.com/repos/aergonaut/helix/issues{/number}","pulls_url":"https://api.github.com/repos/aergonaut/helix/pulls{/number}","milestones_url":"https://api.github.com/repos/aergonaut/helix/milestones{/number}","notifications_url":"https://api.github.com/repos/aergonaut/helix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aergonaut/helix/labels{/name}","releases_url":"https://api.github.com/repos/aergonaut/helix/releases{/id}","deployments_url":"https://api.github.com/repos/aergonaut/helix/deployments","created_at":"2016-05-16T16:06:16Z","updated_at":"2016-05-16T16:06:17Z","pushed_at":"2016-06-19T05:45:56Z","git_url":"git://github.com/aergonaut/helix.git","ssh_url":"git@github.com:aergonaut/helix.git","clone_url":"https://github.com/aergonaut/helix.git","svn_url":"https://github.com/aergonaut/helix","homepage":null,"size":77,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rustbridge:master","ref":"master","sha":"569557866e27f3b48e8605ec4d7b26f8956d8199","user":{"login":"rustbridge","id":16467739,"avatar_url":"https://avatars.githubusercontent.com/u/16467739?v=3","gravatar_id":"","url":"https://api.github.com/users/rustbridge","html_url":"https://github.com/rustbridge","followers_url":"https://api.github.com/users/rustbridge/followers","following_url":"https://api.github.com/users/rustbridge/following{/other_user}","gists_url":"https://api.github.com/users/rustbridge/gists{/gist_id}","starred_url":"https://api.github.com/users/rustbridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustbridge/subscriptions","organizations_url":"https://api.github.com/users/rustbridge/orgs","repos_url":"https://api.github.com/users/rustbridge/repos","events_url":"https://api.github.com/users/rustbridge/events{/privacy}","received_events_url":"https://api.github.com/users/rustbridge/received_events","type":"Organization","site_admin":false},"repo":{"id":45665561,"name":"helix","full_name":"rustbridge/helix","owner":{"login":"rustbridge","id":16467739,"avatar_url":"https://avatars.githubusercontent.com/u/16467739?v=3","gravatar_id":"","url":"https://api.github.com/users/rustbridge","html_url":"https://github.com/rustbridge","followers_url":"https://api.github.com/users/rustbridge/followers","following_url":"https://api.github.com/users/rustbridge/following{/other_user}","gists_url":"https://api.github.com/users/rustbridge/gists{/gist_id}","starred_url":"https://api.github.com/users/rustbridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustbridge/subscriptions","organizations_url":"https://api.github.com/users/rustbridge/orgs","repos_url":"https://api.github.com/users/rustbridge/repos","events_url":"https://api.github.com/users/rustbridge/events{/privacy}","received_events_url":"https://api.github.com/users/rustbridge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rustbridge/helix","description":"Ruby and Rust, sitting in a tree","fork":false,"url":"https://api.github.com/repos/rustbridge/helix","forks_url":"https://api.github.com/repos/rustbridge/helix/forks","keys_url":"https://api.github.com/repos/rustbridge/helix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustbridge/helix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustbridge/helix/teams","hooks_url":"https://api.github.com/repos/rustbridge/helix/hooks","issue_events_url":"https://api.github.com/repos/rustbridge/helix/issues/events{/number}","events_url":"https://api.github.com/repos/rustbridge/helix/events","assignees_url":"https://api.github.com/repos/rustbridge/helix/assignees{/user}","branches_url":"https://api.github.com/repos/rustbridge/helix/branches{/branch}","tags_url":"https://api.github.com/repos/rustbridge/helix/tags","blobs_url":"https://api.github.com/repos/rustbridge/helix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustbridge/helix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustbridge/helix/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustbridge/helix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustbridge/helix/statuses/{sha}","languages_url":"https://api.github.com/repos/rustbridge/helix/languages","stargazers_url":"https://api.github.com/repos/rustbridge/helix/stargazers","contributors_url":"https://api.github.com/repos/rustbridge/helix/contributors","subscribers_url":"https://api.github.com/repos/rustbridge/helix/subscribers","subscription_url":"https://api.github.com/repos/rustbridge/helix/subscription","commits_url":"https://api.github.com/repos/rustbridge/helix/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustbridge/helix/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustbridge/helix/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustbridge/helix/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustbridge/helix/contents/{+path}","compare_url":"https://api.github.com/repos/rustbridge/helix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustbridge/helix/merges","archive_url":"https://api.github.com/repos/rustbridge/helix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustbridge/helix/downloads","issues_url":"https://api.github.com/repos/rustbridge/helix/issues{/number}","pulls_url":"https://api.github.com/repos/rustbridge/helix/pulls{/number}","milestones_url":"https://api.github.com/repos/rustbridge/helix/milestones{/number}","notifications_url":"https://api.github.com/repos/rustbridge/helix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustbridge/helix/labels{/name}","releases_url":"https://api.github.com/repos/rustbridge/helix/releases{/id}","deployments_url":"https://api.github.com/repos/rustbridge/helix/deployments","created_at":"2015-11-06T07:06:36Z","updated_at":"2016-06-20T14:44:46Z","pushed_at":"2016-06-19T17:33:17Z","git_url":"git://github.com/rustbridge/helix.git","ssh_url":"git@github.com:rustbridge/helix.git","clone_url":"https://github.com/rustbridge/helix.git","svn_url":"https://github.com/rustbridge/helix","homepage":null,"size":74,"stargazers_count":755,"watchers_count":755,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":8,"forks":16,"open_issues":8,"watchers":755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rustbridge/helix/pulls/10"},"html":{"href":"https://github.com/rustbridge/helix/pull/10"},"issue":{"href":"https://api.github.com/repos/rustbridge/helix/issues/10"},"comments":{"href":"https://api.github.com/repos/rustbridge/helix/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/rustbridge/helix/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/rustbridge/helix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rustbridge/helix/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/rustbridge/helix/statuses/51611e1d560aa6495d92be9d9e08a552403e588b"}}}}
{"actor":{"display_login":"aergonaut"}}