{"action":"created","comment":{"url":"https://api.github.com/repos/iarna/tacks/pulls/comments/82308651","pull_request_review_id":3226634,"id":82308651,"diff_hunk":"@@ -28,7 +28,7 @@ function loadFromDir (dir, top) {\n     if (fileinfo.isSymbolicLink()) {\n       var dest = fs.readlinkSync(filepath)\n       if (/^(?:[a-z]\\:)?[\\\\/]/i.test(dest)) {\n-        dest = '/' + path.relative(top, dest)\n+        dest = path.sep + path.relative(top, dest)","path":"load-from-dir.js","position":null,"original_position":5,"commit_id":"d124b4f5e4ece2655498dd163572bab9447a50bd","original_commit_id":"56c28b34c840e8536080a18a77633755ec3d63f8","user":{"login":"watilde","id":1716463,"avatar_url":"https://avatars.githubusercontent.com/u/1716463?v=3","gravatar_id":"","url":"https://api.github.com/users/watilde","html_url":"https://github.com/watilde","followers_url":"https://api.github.com/users/watilde/followers","following_url":"https://api.github.com/users/watilde/following{/other_user}","gists_url":"https://api.github.com/users/watilde/gists{/gist_id}","starred_url":"https://api.github.com/users/watilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watilde/subscriptions","organizations_url":"https://api.github.com/users/watilde/orgs","repos_url":"https://api.github.com/users/watilde/repos","events_url":"https://api.github.com/users/watilde/events{/privacy}","received_events_url":"https://api.github.com/users/watilde/received_events","type":"User","site_admin":false},"body":"I've wrapped it with `path.join`","created_at":"2016-10-06T23:50:36Z","updated_at":"2016-10-06T23:50:36Z","html_url":"https://github.com/iarna/tacks/pull/4#discussion_r82308651","pull_request_url":"https://api.github.com/repos/iarna/tacks/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/iarna/tacks/pulls/comments/82308651"},"html":{"href":"https://github.com/iarna/tacks/pull/4#discussion_r82308651"},"pull_request":{"href":"https://api.github.com/repos/iarna/tacks/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/iarna/tacks/pulls/4","id":86660280,"html_url":"https://github.com/iarna/tacks/pull/4","diff_url":"https://github.com/iarna/tacks/pull/4.diff","patch_url":"https://github.com/iarna/tacks/pull/4.patch","issue_url":"https://api.github.com/repos/iarna/tacks/issues/4","number":4,"state":"open","locked":false,"title":"Replace hard corded path sep with path.sep to support Windows","user":{"login":"watilde","id":1716463,"avatar_url":"https://avatars.githubusercontent.com/u/1716463?v=3","gravatar_id":"","url":"https://api.github.com/users/watilde","html_url":"https://github.com/watilde","followers_url":"https://api.github.com/users/watilde/followers","following_url":"https://api.github.com/users/watilde/following{/other_user}","gists_url":"https://api.github.com/users/watilde/gists{/gist_id}","starred_url":"https://api.github.com/users/watilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watilde/subscriptions","organizations_url":"https://api.github.com/users/watilde/orgs","repos_url":"https://api.github.com/users/watilde/repos","events_url":"https://api.github.com/users/watilde/events{/privacy}","received_events_url":"https://api.github.com/users/watilde/received_events","type":"User","site_admin":false},"body":"Since the ci still have errors, let me fix the part of the causes -\r\nhttps://github.com/npm/npm/pull/14045","created_at":"2016-09-25T19:42:44Z","updated_at":"2016-10-06T23:50:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4103af981576d8118d6e7fda115f323d67230bb4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/iarna/tacks/pulls/4/commits","review_comments_url":"https://api.github.com/repos/iarna/tacks/pulls/4/comments","review_comment_url":"https://api.github.com/repos/iarna/tacks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iarna/tacks/issues/4/comments","statuses_url":"https://api.github.com/repos/iarna/tacks/statuses/d124b4f5e4ece2655498dd163572bab9447a50bd","head":{"label":"watilde:patch/windows","ref":"patch/windows","sha":"d124b4f5e4ece2655498dd163572bab9447a50bd","user":{"login":"watilde","id":1716463,"avatar_url":"https://avatars.githubusercontent.com/u/1716463?v=3","gravatar_id":"","url":"https://api.github.com/users/watilde","html_url":"https://github.com/watilde","followers_url":"https://api.github.com/users/watilde/followers","following_url":"https://api.github.com/users/watilde/following{/other_user}","gists_url":"https://api.github.com/users/watilde/gists{/gist_id}","starred_url":"https://api.github.com/users/watilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watilde/subscriptions","organizations_url":"https://api.github.com/users/watilde/orgs","repos_url":"https://api.github.com/users/watilde/repos","events_url":"https://api.github.com/users/watilde/events{/privacy}","received_events_url":"https://api.github.com/users/watilde/received_events","type":"User","site_admin":false},"repo":{"id":56846695,"name":"tacks","full_name":"watilde/tacks","owner":{"login":"watilde","id":1716463,"avatar_url":"https://avatars.githubusercontent.com/u/1716463?v=3","gravatar_id":"","url":"https://api.github.com/users/watilde","html_url":"https://github.com/watilde","followers_url":"https://api.github.com/users/watilde/followers","following_url":"https://api.github.com/users/watilde/following{/other_user}","gists_url":"https://api.github.com/users/watilde/gists{/gist_id}","starred_url":"https://api.github.com/users/watilde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watilde/subscriptions","organizations_url":"https://api.github.com/users/watilde/orgs","repos_url":"https://api.github.com/users/watilde/repos","events_url":"https://api.github.com/users/watilde/events{/privacy}","received_events_url":"https://api.github.com/users/watilde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/watilde/tacks","description":"Generate fixture modules from folders","fork":true,"url":"https://api.github.com/repos/watilde/tacks","forks_url":"https://api.github.com/repos/watilde/tacks/forks","keys_url":"https://api.github.com/repos/watilde/tacks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watilde/tacks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watilde/tacks/teams","hooks_url":"https://api.github.com/repos/watilde/tacks/hooks","issue_events_url":"https://api.github.com/repos/watilde/tacks/issues/events{/number}","events_url":"https://api.github.com/repos/watilde/tacks/events","assignees_url":"https://api.github.com/repos/watilde/tacks/assignees{/user}","branches_url":"https://api.github.com/repos/watilde/tacks/branches{/branch}","tags_url":"https://api.github.com/repos/watilde/tacks/tags","blobs_url":"https://api.github.com/repos/watilde/tacks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watilde/tacks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watilde/tacks/git/refs{/sha}","trees_url":"https://api.github.com/repos/watilde/tacks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watilde/tacks/statuses/{sha}","languages_url":"https://api.github.com/repos/watilde/tacks/languages","stargazers_url":"https://api.github.com/repos/watilde/tacks/stargazers","contributors_url":"https://api.github.com/repos/watilde/tacks/contributors","subscribers_url":"https://api.github.com/repos/watilde/tacks/subscribers","subscription_url":"https://api.github.com/repos/watilde/tacks/subscription","commits_url":"https://api.github.com/repos/watilde/tacks/commits{/sha}","git_commits_url":"https://api.github.com/repos/watilde/tacks/git/commits{/sha}","comments_url":"https://api.github.com/repos/watilde/tacks/comments{/number}","issue_comment_url":"https://api.github.com/repos/watilde/tacks/issues/comments{/number}","contents_url":"https://api.github.com/repos/watilde/tacks/contents/{+path}","compare_url":"https://api.github.com/repos/watilde/tacks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watilde/tacks/merges","archive_url":"https://api.github.com/repos/watilde/tacks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watilde/tacks/downloads","issues_url":"https://api.github.com/repos/watilde/tacks/issues{/number}","pulls_url":"https://api.github.com/repos/watilde/tacks/pulls{/number}","milestones_url":"https://api.github.com/repos/watilde/tacks/milestones{/number}","notifications_url":"https://api.github.com/repos/watilde/tacks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watilde/tacks/labels{/name}","releases_url":"https://api.github.com/repos/watilde/tacks/releases{/id}","deployments_url":"https://api.github.com/repos/watilde/tacks/deployments","created_at":"2016-04-22T10:12:12Z","updated_at":"2016-04-22T10:12:13Z","pushed_at":"2016-10-06T23:46:37Z","git_url":"git://github.com/watilde/tacks.git","ssh_url":"git@github.com:watilde/tacks.git","clone_url":"https://github.com/watilde/tacks.git","svn_url":"https://github.com/watilde/tacks","homepage":null,"size":45,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iarna:master","ref":"master","sha":"64f996a5aeb3b1f9ebb63c84ac31a78a1c9bf234","user":{"login":"iarna","id":983798,"avatar_url":"https://avatars.githubusercontent.com/u/983798?v=3","gravatar_id":"","url":"https://api.github.com/users/iarna","html_url":"https://github.com/iarna","followers_url":"https://api.github.com/users/iarna/followers","following_url":"https://api.github.com/users/iarna/following{/other_user}","gists_url":"https://api.github.com/users/iarna/gists{/gist_id}","starred_url":"https://api.github.com/users/iarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iarna/subscriptions","organizations_url":"https://api.github.com/users/iarna/orgs","repos_url":"https://api.github.com/users/iarna/repos","events_url":"https://api.github.com/users/iarna/events{/privacy}","received_events_url":"https://api.github.com/users/iarna/received_events","type":"User","site_admin":false},"repo":{"id":50453159,"name":"tacks","full_name":"iarna/tacks","owner":{"login":"iarna","id":983798,"avatar_url":"https://avatars.githubusercontent.com/u/983798?v=3","gravatar_id":"","url":"https://api.github.com/users/iarna","html_url":"https://github.com/iarna","followers_url":"https://api.github.com/users/iarna/followers","following_url":"https://api.github.com/users/iarna/following{/other_user}","gists_url":"https://api.github.com/users/iarna/gists{/gist_id}","starred_url":"https://api.github.com/users/iarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iarna/subscriptions","organizations_url":"https://api.github.com/users/iarna/orgs","repos_url":"https://api.github.com/users/iarna/repos","events_url":"https://api.github.com/users/iarna/events{/privacy}","received_events_url":"https://api.github.com/users/iarna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iarna/tacks","description":"Generate fixture modules from folders","fork":false,"url":"https://api.github.com/repos/iarna/tacks","forks_url":"https://api.github.com/repos/iarna/tacks/forks","keys_url":"https://api.github.com/repos/iarna/tacks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iarna/tacks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iarna/tacks/teams","hooks_url":"https://api.github.com/repos/iarna/tacks/hooks","issue_events_url":"https://api.github.com/repos/iarna/tacks/issues/events{/number}","events_url":"https://api.github.com/repos/iarna/tacks/events","assignees_url":"https://api.github.com/repos/iarna/tacks/assignees{/user}","branches_url":"https://api.github.com/repos/iarna/tacks/branches{/branch}","tags_url":"https://api.github.com/repos/iarna/tacks/tags","blobs_url":"https://api.github.com/repos/iarna/tacks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iarna/tacks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iarna/tacks/git/refs{/sha}","trees_url":"https://api.github.com/repos/iarna/tacks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iarna/tacks/statuses/{sha}","languages_url":"https://api.github.com/repos/iarna/tacks/languages","stargazers_url":"https://api.github.com/repos/iarna/tacks/stargazers","contributors_url":"https://api.github.com/repos/iarna/tacks/contributors","subscribers_url":"https://api.github.com/repos/iarna/tacks/subscribers","subscription_url":"https://api.github.com/repos/iarna/tacks/subscription","commits_url":"https://api.github.com/repos/iarna/tacks/commits{/sha}","git_commits_url":"https://api.github.com/repos/iarna/tacks/git/commits{/sha}","comments_url":"https://api.github.com/repos/iarna/tacks/comments{/number}","issue_comment_url":"https://api.github.com/repos/iarna/tacks/issues/comments{/number}","contents_url":"https://api.github.com/repos/iarna/tacks/contents/{+path}","compare_url":"https://api.github.com/repos/iarna/tacks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iarna/tacks/merges","archive_url":"https://api.github.com/repos/iarna/tacks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iarna/tacks/downloads","issues_url":"https://api.github.com/repos/iarna/tacks/issues{/number}","pulls_url":"https://api.github.com/repos/iarna/tacks/pulls{/number}","milestones_url":"https://api.github.com/repos/iarna/tacks/milestones{/number}","notifications_url":"https://api.github.com/repos/iarna/tacks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iarna/tacks/labels{/name}","releases_url":"https://api.github.com/repos/iarna/tacks/releases{/id}","deployments_url":"https://api.github.com/repos/iarna/tacks/deployments","created_at":"2016-01-26T19:25:34Z","updated_at":"2016-05-25T11:53:13Z","pushed_at":"2016-10-06T23:46:37Z","git_url":"git://github.com/iarna/tacks.git","ssh_url":"git@github.com:iarna/tacks.git","clone_url":"https://github.com/iarna/tacks.git","svn_url":"https://github.com/iarna/tacks","homepage":null,"size":44,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iarna/tacks/pulls/4"},"html":{"href":"https://github.com/iarna/tacks/pull/4"},"issue":{"href":"https://api.github.com/repos/iarna/tacks/issues/4"},"comments":{"href":"https://api.github.com/repos/iarna/tacks/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/iarna/tacks/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/iarna/tacks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iarna/tacks/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/iarna/tacks/statuses/d124b4f5e4ece2655498dd163572bab9447a50bd"}}}}
{"actor":{"display_login":"watilde"}}