{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/jmxfetch/issues/111","repository_url":"https://api.github.com/repos/DataDog/jmxfetch","labels_url":"https://api.github.com/repos/DataDog/jmxfetch/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/jmxfetch/issues/111/comments","events_url":"https://api.github.com/repos/DataDog/jmxfetch/issues/111/events","html_url":"https://github.com/DataDog/jmxfetch/pull/111","id":184308135,"number":111,"title":"Added JMX TabularData support","user":{"login":"brothhaar","id":5386567,"avatar_url":"https://avatars.githubusercontent.com/u/5386567?v=3","gravatar_id":"","url":"https://api.github.com/users/brothhaar","html_url":"https://github.com/brothhaar","followers_url":"https://api.github.com/users/brothhaar/followers","following_url":"https://api.github.com/users/brothhaar/following{/other_user}","gists_url":"https://api.github.com/users/brothhaar/gists{/gist_id}","starred_url":"https://api.github.com/users/brothhaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brothhaar/subscriptions","organizations_url":"https://api.github.com/users/brothhaar/orgs","repos_url":"https://api.github.com/users/brothhaar/repos","events_url":"https://api.github.com/users/brothhaar/events{/privacy}","received_events_url":"https://api.github.com/users/brothhaar/received_events","type":"User","site_admin":false},"labels":[{"id":49207627,"url":"https://api.github.com/repos/DataDog/jmxfetch/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"assignees":[{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/jmxfetch/milestones/11","html_url":"https://github.com/DataDog/jmxfetch/milestone/11","labels_url":"https://api.github.com/repos/DataDog/jmxfetch/milestones/11/labels","id":1493377,"number":11,"title":"Triage","description":"","creator":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":2,"state":"open","created_at":"2016-01-08T19:42:54Z","updated_at":"2016-10-26T21:53:11Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-10-20T18:40:19Z","updated_at":"2016-12-27T18:02:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/jmxfetch/pulls/111","html_url":"https://github.com/DataDog/jmxfetch/pull/111","diff_url":"https://github.com/DataDog/jmxfetch/pull/111.diff","patch_url":"https://github.com/DataDog/jmxfetch/pull/111.patch"},"body":"Copied from #104, since I screwed up that branch. \n\nAdded JMX TabularData support\nWhen a TabularData type is encountered, multiple metrics are generated with the same alias, but a unique tag per entry\nThe tag is generated by concatenating each of the (possibly multiple) key values for each CompositeData entry in the TabularData JMX value\nAlso included limit and sort capability to allow sorting and limiting the number of metrics returned for a single configuration entry (since a TabularData value could have many records).\nYAML config format:\n\n```\n      - include:\n          domain: <domain>\n          bean:\n            - <bean name>\n          attribute:\n            <TabularData attribute name>:\n              metric_type: <type>\n              alias: <alias>\n              tags:\n                <tag name>: $key\n              limit: 20\n              sort: desc\n```\n"},"comment":{"url":"https://api.github.com/repos/DataDog/jmxfetch/issues/comments/269360571","html_url":"https://github.com/DataDog/jmxfetch/pull/111#issuecomment-269360571","issue_url":"https://api.github.com/repos/DataDog/jmxfetch/issues/111","id":269360571,"user":{"login":"brothhaar","id":5386567,"avatar_url":"https://avatars.githubusercontent.com/u/5386567?v=3","gravatar_id":"","url":"https://api.github.com/users/brothhaar","html_url":"https://github.com/brothhaar","followers_url":"https://api.github.com/users/brothhaar/followers","following_url":"https://api.github.com/users/brothhaar/following{/other_user}","gists_url":"https://api.github.com/users/brothhaar/gists{/gist_id}","starred_url":"https://api.github.com/users/brothhaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brothhaar/subscriptions","organizations_url":"https://api.github.com/users/brothhaar/orgs","repos_url":"https://api.github.com/users/brothhaar/repos","events_url":"https://api.github.com/users/brothhaar/events{/privacy}","received_events_url":"https://api.github.com/users/brothhaar/received_events","type":"User","site_admin":false},"created_at":"2016-12-27T18:02:20Z","updated_at":"2016-12-27T18:02:20Z","body":"OK @yannmh, the transient test failure I was seeing was related to counter metric rate calculation after a bean refresh (which I added to the test). The timing changed and I was seeing rates of `0.96 - 1.0` rather than the `0.98 - 1` that the `TestApp` was expecting. It's not a new bug, IMO, just odd timing in the test. I updated the metric's expected range.\r\n\r\nSorry about the delay on this, I'm just now cleaning up my TODO list from the past few months."}}
{"actor":{"display_login":"brothhaar"}}