{"action":"created","issue":{"url":"https://api.github.com/repos/cloudant/python-cloudant/issues/144","repository_url":"https://api.github.com/repos/cloudant/python-cloudant","labels_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/144/comments","events_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/144/events","html_url":"https://github.com/cloudant/python-cloudant/pull/144","id":146976805,"number":144,"title":"Remove make_result from Query and View","user":{"login":"emlaver","id":10552966,"avatar_url":"https://avatars.githubusercontent.com/u/10552966?v=3","gravatar_id":"","url":"https://api.github.com/users/emlaver","html_url":"https://github.com/emlaver","followers_url":"https://api.github.com/users/emlaver/followers","following_url":"https://api.github.com/users/emlaver/following{/other_user}","gists_url":"https://api.github.com/users/emlaver/gists{/gist_id}","starred_url":"https://api.github.com/users/emlaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlaver/subscriptions","organizations_url":"https://api.github.com/users/emlaver/orgs","repos_url":"https://api.github.com/users/emlaver/repos","events_url":"https://api.github.com/users/emlaver/events{/privacy}","received_events_url":"https://api.github.com/users/emlaver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-08T16:34:13Z","updated_at":"2016-04-12T14:19:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cloudant/python-cloudant/pulls/144","html_url":"https://github.com/cloudant/python-cloudant/pull/144","diff_url":"https://github.com/cloudant/python-cloudant/pull/144.diff","patch_url":"https://github.com/cloudant/python-cloudant/pull/144.patch"},"body":"## What\r\n\r\nThe make_result method in Query and View classes is redundant and confusing. It should be removed. A Result/QueryResult object can be stood up that essentially would perform the same functionality. Likewise the database convenience methods of get_view_results and get_query_results also perform the same functionality.\r\n\r\n## How\r\n\r\nIn database.py module:\r\n- change get_view_results to standup a new Result object passing it **kwargs.\r\n- change get_query_results to standup a new QueryResult object passing it **kwargs.\r\n\r\nIn result.py module:\r\n- Move parameter docs from make_result methods to Result/QueryResult class docstring.\r\n- Remove references to make_result in comments.\r\n\r\nIn view.py module:\r\n- Remove make_result.\r\n- Refactor custom_result to use a new Result object passing it **kwargs.\r\n- Add QueryIndexView.custom_result to override and disable the base method View.custom_result\r\n\r\nIn query.py module:\r\n- Remove make_result.\r\n- Refactor custom_result to use a new QueryResult object passing it **kwargs.\r\n\r\n## Testing\r\n\r\nNo additional tests.\r\nRemoved make_result tests.\r\n\r\n## Reviewers\r\n\r\nreviewer @alfinkel \r\nreviewer @ricellis\r\n\r\n## Issues\r\n\r\n#46 "},"comment":{"url":"https://api.github.com/repos/cloudant/python-cloudant/issues/comments/208929393","html_url":"https://github.com/cloudant/python-cloudant/pull/144#issuecomment-208929393","issue_url":"https://api.github.com/repos/cloudant/python-cloudant/issues/144","id":208929393,"user":{"login":"ricellis","id":10698320,"avatar_url":"https://avatars.githubusercontent.com/u/10698320?v=3","gravatar_id":"","url":"https://api.github.com/users/ricellis","html_url":"https://github.com/ricellis","followers_url":"https://api.github.com/users/ricellis/followers","following_url":"https://api.github.com/users/ricellis/following{/other_user}","gists_url":"https://api.github.com/users/ricellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ricellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricellis/subscriptions","organizations_url":"https://api.github.com/users/ricellis/orgs","repos_url":"https://api.github.com/users/ricellis/repos","events_url":"https://api.github.com/users/ricellis/events{/privacy}","received_events_url":"https://api.github.com/users/ricellis/received_events","type":"User","site_admin":false},"created_at":"2016-04-12T14:19:00Z","updated_at":"2016-04-12T14:19:00Z","body":"+1 after small addition to CHANGES.md"}}