{"action":"created","issue":{"url":"https://api.github.com/repos/formly-js/angular-formly/issues/670","repository_url":"https://api.github.com/repos/formly-js/angular-formly","labels_url":"https://api.github.com/repos/formly-js/angular-formly/issues/670/labels{/name}","comments_url":"https://api.github.com/repos/formly-js/angular-formly/issues/670/comments","events_url":"https://api.github.com/repos/formly-js/angular-formly/issues/670/events","html_url":"https://github.com/formly-js/angular-formly/pull/670","id":143350198,"number":670,"title":"feat(FormlyFormController): Exposes FormlyFormController so it can be used outside of formly-form","user":{"login":"pcardune","id":124827,"avatar_url":"https://avatars.githubusercontent.com/u/124827?v=3","gravatar_id":"","url":"https://api.github.com/users/pcardune","html_url":"https://github.com/pcardune","followers_url":"https://api.github.com/users/pcardune/followers","following_url":"https://api.github.com/users/pcardune/following{/other_user}","gists_url":"https://api.github.com/users/pcardune/gists{/gist_id}","starred_url":"https://api.github.com/users/pcardune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcardune/subscriptions","organizations_url":"https://api.github.com/users/pcardune/orgs","repos_url":"https://api.github.com/users/pcardune/repos","events_url":"https://api.github.com/users/pcardune/events{/privacy}","received_events_url":"https://api.github.com/users/pcardune/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-03-24T20:23:34Z","updated_at":"2016-03-24T20:58:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/formly-js/angular-formly/pulls/670","html_url":"https://github.com/formly-js/angular-formly/pull/670","diff_url":"https://github.com/formly-js/angular-formly/pull/670.diff","patch_url":"https://github.com/formly-js/angular-formly/pull/670.patch"},"body":"## What\r\n\r\nThis change simply moves FormlyFormController into a separate file and registers it with the $controller service. There is no change in functionality.\r\n\r\n## Why\r\n\r\nFor the formly plugin I am writing, I want to reuse the logic in the FormlyFormController with a\r\ndifferent directive. This change makes the controller available to third party code via the\r\n`$controller` service. See an example of the usage here: https://github.com/Shoobx/plato-form/commit/aa609b49532af036274351acc014060ca8ee5d8c#diff-61cd5ccb0f47d71f982481c6bb4a2fa6R40\r\n\r\n## How\r\n\r\nThe diff is fairly self explanatory.\r\n\r\nFor issue #663 \r\n\r\nChecklist:\r\n\r\n* [x] Follows the commit message [conventions](https://github.com/stevemao/conventional-changelog-angular/blob/master/convention.md)\r\n* [x] Is [rebased with master](https://egghead.io/lessons/javascript-how-to-rebase-a-git-pull-request-branch?series=how-to-contribute-to-an-open-source-project-on-github)\r\n* [x] Is [only one (maybe two) commits](https://egghead.io/lessons/javascript-how-to-squash-multiple-git-commits)"},"comment":{"url":"https://api.github.com/repos/formly-js/angular-formly/issues/comments/201018201","html_url":"https://github.com/formly-js/angular-formly/pull/670#issuecomment-201018201","issue_url":"https://api.github.com/repos/formly-js/angular-formly/issues/670","id":201018201,"user":{"login":"BarryThePenguin","id":1351912,"avatar_url":"https://avatars.githubusercontent.com/u/1351912?v=3","gravatar_id":"","url":"https://api.github.com/users/BarryThePenguin","html_url":"https://github.com/BarryThePenguin","followers_url":"https://api.github.com/users/BarryThePenguin/followers","following_url":"https://api.github.com/users/BarryThePenguin/following{/other_user}","gists_url":"https://api.github.com/users/BarryThePenguin/gists{/gist_id}","starred_url":"https://api.github.com/users/BarryThePenguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarryThePenguin/subscriptions","organizations_url":"https://api.github.com/users/BarryThePenguin/orgs","repos_url":"https://api.github.com/users/BarryThePenguin/repos","events_url":"https://api.github.com/users/BarryThePenguin/events{/privacy}","received_events_url":"https://api.github.com/users/BarryThePenguin/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T20:58:56Z","updated_at":"2016-03-24T20:58:56Z","body":"Awesome! I've been thinking of doing the same thing for a while now... If there's any tests in `formly-form.test.js` that don't have a `compileAndDigest` in them, would be good to seperate them into a different file too"}}