{"action":"created","issue":{"url":"https://api.github.com/repos/ua-eas/kfs/issues/113","repository_url":"https://api.github.com/repos/ua-eas/kfs","labels_url":"https://api.github.com/repos/ua-eas/kfs/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/ua-eas/kfs/issues/113/comments","events_url":"https://api.github.com/repos/ua-eas/kfs/issues/113/events","html_url":"https://github.com/ua-eas/kfs/pull/113","id":154776389,"number":113,"title":"UAF-429 UAF-2562 Added the code to allow disapprove on SubFund Routing for REQ Documents.","user":{"login":"leahasullivan","id":5092112,"avatar_url":"https://avatars.githubusercontent.com/u/5092112?v=3","gravatar_id":"","url":"https://api.github.com/users/leahasullivan","html_url":"https://github.com/leahasullivan","followers_url":"https://api.github.com/users/leahasullivan/followers","following_url":"https://api.github.com/users/leahasullivan/following{/other_user}","gists_url":"https://api.github.com/users/leahasullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/leahasullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leahasullivan/subscriptions","organizations_url":"https://api.github.com/users/leahasullivan/orgs","repos_url":"https://api.github.com/users/leahasullivan/repos","events_url":"https://api.github.com/users/leahasullivan/events{/privacy}","received_events_url":"https://api.github.com/users/leahasullivan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-13T18:45:18Z","updated_at":"2016-05-16T22:41:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ua-eas/kfs/pulls/113","html_url":"https://github.com/ua-eas/kfs/pull/113","diff_url":"https://github.com/ua-eas/kfs/pull/113.diff","patch_url":"https://github.com/ua-eas/kfs/pull/113.patch"},"body":"Added the constants for the disapproval for subfund node. KFS3 had some additional code in the PurapWorkflowConstants.java file, but it looks as if those are no longer used in KFS6 after looking at the other code in that file.\r\n\r\nWhen placing this class in the edu.arizona PurapConstants.java, it required an update to the imports in the RequisitionDocument.java file to point to the override. If the imports were not updated, the disapproval was still broken. I tried putting the methods needed in baseline RequisitionDocument.java into the override (edu.arizona version) RequisitionDocument.java and referencing the override for PurapConstants.java, but it would not work. (I moved 5 methods that called the class RequisitionStatuses in PurapConstants.) I was concerned that I would have to move most if not all of this file into the override to get it to work correctly.\r\n\r\nMy options to fix were:\r\n1. put the changes to PurapConstants.java in baseline\r\n2. put the changes to PurapConstants.java in edu.arizona override and update the imports for the baseline file RequisitionDocument.java.\r\n\r\nI placed the changes in baseline because there are 12 other files that reference the baseline class RequisitionStatuses. I was concerned that moving the changes to edu.arizona may (or may not) require import updates to the other files in the future that may need to use any updates to the class RequisitionStatuses. (which there are 12 files with this import)\r\n"},"comment":{"url":"https://api.github.com/repos/ua-eas/kfs/issues/comments/219570071","html_url":"https://github.com/ua-eas/kfs/pull/113#issuecomment-219570071","issue_url":"https://api.github.com/repos/ua-eas/kfs/issues/113","id":219570071,"user":{"login":"Perrinek","id":2000491,"avatar_url":"https://avatars.githubusercontent.com/u/2000491?v=3","gravatar_id":"","url":"https://api.github.com/users/Perrinek","html_url":"https://github.com/Perrinek","followers_url":"https://api.github.com/users/Perrinek/followers","following_url":"https://api.github.com/users/Perrinek/following{/other_user}","gists_url":"https://api.github.com/users/Perrinek/gists{/gist_id}","starred_url":"https://api.github.com/users/Perrinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Perrinek/subscriptions","organizations_url":"https://api.github.com/users/Perrinek/orgs","repos_url":"https://api.github.com/users/Perrinek/repos","events_url":"https://api.github.com/users/Perrinek/events{/privacy}","received_events_url":"https://api.github.com/users/Perrinek/received_events","type":"User","site_admin":false},"created_at":"2016-05-16T22:41:04Z","updated_at":"2016-05-16T22:41:04Z","body":"Looks good!"}}