{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/90111635","pull_request_review_id":10636160,"id":90111635,"diff_hunk":"@@ -313,7 +320,7 @@ func (w *Watcher) flush() {\n // handle deals with requests delivered by the public API\n // onto the background watcher goroutine.\n func (w *Watcher) handle(req interface{}) {\n-\tlogger.Tracef(\"got request: %#v\", req)\n+\tlogger.Tracef(\"[%s] got request: %#v for model\", w.modelUUID[:6], req)","path":"state/presence/presence.go","position":35,"original_position":35,"commit_id":"aad5943b4fc67354c9bb2148d4e6b383939f6ab6","original_commit_id":"aad5943b4fc67354c9bb2148d4e6b383939f6ab6","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"body":"Perhaps not just now given that we want to delete all this code.","created_at":"2016-11-29T20:56:01Z","updated_at":"2016-11-29T20:56:01Z","html_url":"https://github.com/juju/juju/pull/6629#discussion_r90111635","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/6629","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/90111635"},"html":{"href":"https://github.com/juju/juju/pull/6629#discussion_r90111635"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/6629"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/6629","id":95761018,"html_url":"https://github.com/juju/juju/pull/6629","diff_url":"https://github.com/juju/juju/pull/6629.diff","patch_url":"https://github.com/juju/juju/pull/6629.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/6629","number":6629,"state":"open","locked":false,"title":"[presence] Always sync before responding to requests.","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"body":"When initiating a migration, sometimes the precheck would report an agent as down when status would show it as up. The cause of this was a timing issue in the state workers. It was possible for a request for agent alive to be processed by the presence worker before it had synced its state with the database, which would cause it to report the agent as down.\r\n\r\nThis change moves the initial call to sync with the database outside of the infinite for loop in the loop function. It appears that the intention was always to start with an initial sync as the next sync time was time.After(0). However since it was in a select, sometimes if a request came in very quickly, the request would be handled first.\r\n\r\nA drive-by fix for a state leak in the migration pre-check code. The state returned for checking the controller machines was never closed.","created_at":"2016-11-29T19:41:24Z","updated_at":"2016-11-29T20:56:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaee77ade157ca6a5c747f14fe5d8388b2ec9518","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/6629/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/6629/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/6629/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/aad5943b4fc67354c9bb2148d4e6b383939f6ab6","head":{"label":"howbazaar:migration-machine-down","ref":"migration-machine-down","sha":"aad5943b4fc67354c9bb2148d4e6b383939f6ab6","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"repo":{"id":20467403,"name":"juju","full_name":"howbazaar/juju","owner":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/howbazaar/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/howbazaar/juju","forks_url":"https://api.github.com/repos/howbazaar/juju/forks","keys_url":"https://api.github.com/repos/howbazaar/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/howbazaar/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/howbazaar/juju/teams","hooks_url":"https://api.github.com/repos/howbazaar/juju/hooks","issue_events_url":"https://api.github.com/repos/howbazaar/juju/issues/events{/number}","events_url":"https://api.github.com/repos/howbazaar/juju/events","assignees_url":"https://api.github.com/repos/howbazaar/juju/assignees{/user}","branches_url":"https://api.github.com/repos/howbazaar/juju/branches{/branch}","tags_url":"https://api.github.com/repos/howbazaar/juju/tags","blobs_url":"https://api.github.com/repos/howbazaar/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/howbazaar/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/howbazaar/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/howbazaar/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/howbazaar/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/howbazaar/juju/languages","stargazers_url":"https://api.github.com/repos/howbazaar/juju/stargazers","contributors_url":"https://api.github.com/repos/howbazaar/juju/contributors","subscribers_url":"https://api.github.com/repos/howbazaar/juju/subscribers","subscription_url":"https://api.github.com/repos/howbazaar/juju/subscription","commits_url":"https://api.github.com/repos/howbazaar/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/howbazaar/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/howbazaar/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/howbazaar/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/howbazaar/juju/contents/{+path}","compare_url":"https://api.github.com/repos/howbazaar/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/howbazaar/juju/merges","archive_url":"https://api.github.com/repos/howbazaar/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/howbazaar/juju/downloads","issues_url":"https://api.github.com/repos/howbazaar/juju/issues{/number}","pulls_url":"https://api.github.com/repos/howbazaar/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/howbazaar/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/howbazaar/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/howbazaar/juju/labels{/name}","releases_url":"https://api.github.com/repos/howbazaar/juju/releases{/id}","deployments_url":"https://api.github.com/repos/howbazaar/juju/deployments","created_at":"2014-06-04T02:27:18Z","updated_at":"2016-01-15T01:18:35Z","pushed_at":"2016-11-29T20:32:38Z","git_url":"git://github.com/howbazaar/juju.git","ssh_url":"git@github.com:howbazaar/juju.git","clone_url":"https://github.com/howbazaar/juju.git","svn_url":"https://github.com/howbazaar/juju","homepage":null,"size":93948,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:develop","ref":"develop","sha":"aa221fa70e2c46f402c219d21b3bd30001cc134c","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-11-29T17:33:19Z","pushed_at":"2016-11-29T20:31:54Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":128924,"stargazers_count":538,"watchers_count":538,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":21,"forks":167,"open_issues":21,"watchers":538,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/6629"},"html":{"href":"https://github.com/juju/juju/pull/6629"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/6629"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/6629/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/6629/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/6629/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/aad5943b4fc67354c9bb2148d4e6b383939f6ab6"}}}}
{"actor":{"display_login":"howbazaar"}}