{"action":"created","comment":{"url":"https://api.github.com/repos/cesium-ml/cesium/pulls/comments/82303902","pull_request_review_id":3222270,"id":82303902,"diff_hunk":"@@ -83,3 +59,29 @@ def test_fit_optimize():\n     assert hasattr(model, \"predict_proba\")\n     assert isinstance(model, GridSearchCV)\n     assert isinstance(model.best_estimator_, RandomForestClassifier)\n+\n+\n+def test_fit_multichannel():\n+    \"\"\"Test model building helper function for multi-channel feature data.\"\"\"\n+    fset = sample_featureset(10, 3, ['amplitude', 'maximum', 'minimum', 'median'],\n+                             ['class1', 'class2'])\n+    model = build_model.MODELS_TYPE_DICT['RandomForestClassifier']()\n+    model = build_model.build_model_from_featureset(fset, model)\n+    assert isinstance(model, RandomForestClassifier)\n+\n+\n+def test_invalid_feature_values():\n+    \"\"\"Test proper exception handling for invalid feature values\"\"\"\n+    fset = sample_featureset(10, 1, ['x_valid', 'x_inf', 'x_nan'], ['class1', 'class2'])\n+    fset.x_inf.values[0, 0] = np.inf\n+    fset.x_nan.values[0, 0] = np.nan\n+    model = build_model.MODELS_TYPE_DICT['RandomForestClassifier']()\n+    try:\n+        model = build_model.build_model_from_featureset(fset, model)\n+    except ValueError as e:\n+        assert 'x_valid' not in str(e)\n+        assert 'x_inf' in str(e)\n+        assert 'x_nan' in str(e)\n+","path":"cesium/tests/test_build_model.py","position":95,"original_position":95,"commit_id":"f031c4ade13fdd3f0ecffb085b85acc0eac036c3","original_commit_id":"f031c4ade13fdd3f0ecffb085b85acc0eac036c3","user":{"login":"stefanv","id":45071,"avatar_url":"https://avatars.githubusercontent.com/u/45071?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanv","html_url":"https://github.com/stefanv","followers_url":"https://api.github.com/users/stefanv/followers","following_url":"https://api.github.com/users/stefanv/following{/other_user}","gists_url":"https://api.github.com/users/stefanv/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanv/subscriptions","organizations_url":"https://api.github.com/users/stefanv/orgs","repos_url":"https://api.github.com/users/stefanv/repos","events_url":"https://api.github.com/users/stefanv/events{/privacy}","received_events_url":"https://api.github.com/users/stefanv/received_events","type":"User","site_admin":false},"body":"Else? ","created_at":"2016-10-06T23:07:54Z","updated_at":"2016-10-06T23:08:03Z","html_url":"https://github.com/cesium-ml/cesium/pull/195#discussion_r82303902","pull_request_url":"https://api.github.com/repos/cesium-ml/cesium/pulls/195","_links":{"self":{"href":"https://api.github.com/repos/cesium-ml/cesium/pulls/comments/82303902"},"html":{"href":"https://github.com/cesium-ml/cesium/pull/195#discussion_r82303902"},"pull_request":{"href":"https://api.github.com/repos/cesium-ml/cesium/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/cesium-ml/cesium/pulls/195","id":88354540,"html_url":"https://github.com/cesium-ml/cesium/pull/195","diff_url":"https://github.com/cesium-ml/cesium/pull/195.diff","patch_url":"https://github.com/cesium-ml/cesium/pull/195.patch","issue_url":"https://api.github.com/repos/cesium-ml/cesium/issues/195","number":195,"state":"open","locked":false,"title":"Raise more detailed exception when encountering invalid feature values","user":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"body":"Fixes #92. Combined with cesium-ml/cesium_web#109 this should also make debugging failures on the frontend easier.","created_at":"2016-10-06T22:43:54Z","updated_at":"2016-10-06T23:08:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a951d2acf735fe7c9b2f6b6117b5eed0d633c760","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cesium-ml/cesium/pulls/195/commits","review_comments_url":"https://api.github.com/repos/cesium-ml/cesium/pulls/195/comments","review_comment_url":"https://api.github.com/repos/cesium-ml/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cesium-ml/cesium/issues/195/comments","statuses_url":"https://api.github.com/repos/cesium-ml/cesium/statuses/f031c4ade13fdd3f0ecffb085b85acc0eac036c3","head":{"label":"bnaul:nan_handling","ref":"nan_handling","sha":"f031c4ade13fdd3f0ecffb085b85acc0eac036c3","user":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"repo":{"id":41396103,"name":"cesium","full_name":"bnaul/cesium","owner":{"login":"bnaul","id":903655,"avatar_url":"https://avatars.githubusercontent.com/u/903655?v=3","gravatar_id":"","url":"https://api.github.com/users/bnaul","html_url":"https://github.com/bnaul","followers_url":"https://api.github.com/users/bnaul/followers","following_url":"https://api.github.com/users/bnaul/following{/other_user}","gists_url":"https://api.github.com/users/bnaul/gists{/gist_id}","starred_url":"https://api.github.com/users/bnaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnaul/subscriptions","organizations_url":"https://api.github.com/users/bnaul/orgs","repos_url":"https://api.github.com/users/bnaul/repos","events_url":"https://api.github.com/users/bnaul/events{/privacy}","received_events_url":"https://api.github.com/users/bnaul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bnaul/cesium","description":"Machine Learning Time-Series Platform","fork":true,"url":"https://api.github.com/repos/bnaul/cesium","forks_url":"https://api.github.com/repos/bnaul/cesium/forks","keys_url":"https://api.github.com/repos/bnaul/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnaul/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnaul/cesium/teams","hooks_url":"https://api.github.com/repos/bnaul/cesium/hooks","issue_events_url":"https://api.github.com/repos/bnaul/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/bnaul/cesium/events","assignees_url":"https://api.github.com/repos/bnaul/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/bnaul/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/bnaul/cesium/tags","blobs_url":"https://api.github.com/repos/bnaul/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnaul/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnaul/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnaul/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnaul/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/bnaul/cesium/languages","stargazers_url":"https://api.github.com/repos/bnaul/cesium/stargazers","contributors_url":"https://api.github.com/repos/bnaul/cesium/contributors","subscribers_url":"https://api.github.com/repos/bnaul/cesium/subscribers","subscription_url":"https://api.github.com/repos/bnaul/cesium/subscription","commits_url":"https://api.github.com/repos/bnaul/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnaul/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnaul/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnaul/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnaul/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/bnaul/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnaul/cesium/merges","archive_url":"https://api.github.com/repos/bnaul/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnaul/cesium/downloads","issues_url":"https://api.github.com/repos/bnaul/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/bnaul/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/bnaul/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/bnaul/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnaul/cesium/labels{/name}","releases_url":"https://api.github.com/repos/bnaul/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/bnaul/cesium/deployments","created_at":"2015-08-26T00:59:56Z","updated_at":"2016-09-03T14:52:40Z","pushed_at":"2016-10-06T22:40:59Z","git_url":"git://github.com/bnaul/cesium.git","ssh_url":"git@github.com:bnaul/cesium.git","clone_url":"https://github.com/bnaul/cesium.git","svn_url":"https://github.com/bnaul/cesium","homepage":null,"size":22202,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cesium-ml:master","ref":"master","sha":"463e8418414aaf2af2ae80282828d9c45f174003","user":{"login":"cesium-ml","id":17838960,"avatar_url":"https://avatars.githubusercontent.com/u/17838960?v=3","gravatar_id":"","url":"https://api.github.com/users/cesium-ml","html_url":"https://github.com/cesium-ml","followers_url":"https://api.github.com/users/cesium-ml/followers","following_url":"https://api.github.com/users/cesium-ml/following{/other_user}","gists_url":"https://api.github.com/users/cesium-ml/gists{/gist_id}","starred_url":"https://api.github.com/users/cesium-ml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesium-ml/subscriptions","organizations_url":"https://api.github.com/users/cesium-ml/orgs","repos_url":"https://api.github.com/users/cesium-ml/repos","events_url":"https://api.github.com/users/cesium-ml/events{/privacy}","received_events_url":"https://api.github.com/users/cesium-ml/received_events","type":"Organization","site_admin":false},"repo":{"id":25928850,"name":"cesium","full_name":"cesium-ml/cesium","owner":{"login":"cesium-ml","id":17838960,"avatar_url":"https://avatars.githubusercontent.com/u/17838960?v=3","gravatar_id":"","url":"https://api.github.com/users/cesium-ml","html_url":"https://github.com/cesium-ml","followers_url":"https://api.github.com/users/cesium-ml/followers","following_url":"https://api.github.com/users/cesium-ml/following{/other_user}","gists_url":"https://api.github.com/users/cesium-ml/gists{/gist_id}","starred_url":"https://api.github.com/users/cesium-ml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesium-ml/subscriptions","organizations_url":"https://api.github.com/users/cesium-ml/orgs","repos_url":"https://api.github.com/users/cesium-ml/repos","events_url":"https://api.github.com/users/cesium-ml/events{/privacy}","received_events_url":"https://api.github.com/users/cesium-ml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cesium-ml/cesium","description":"Machine Learning Time-Series Platform","fork":false,"url":"https://api.github.com/repos/cesium-ml/cesium","forks_url":"https://api.github.com/repos/cesium-ml/cesium/forks","keys_url":"https://api.github.com/repos/cesium-ml/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesium-ml/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesium-ml/cesium/teams","hooks_url":"https://api.github.com/repos/cesium-ml/cesium/hooks","issue_events_url":"https://api.github.com/repos/cesium-ml/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/cesium-ml/cesium/events","assignees_url":"https://api.github.com/repos/cesium-ml/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/cesium-ml/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/cesium-ml/cesium/tags","blobs_url":"https://api.github.com/repos/cesium-ml/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesium-ml/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesium-ml/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesium-ml/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesium-ml/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/cesium-ml/cesium/languages","stargazers_url":"https://api.github.com/repos/cesium-ml/cesium/stargazers","contributors_url":"https://api.github.com/repos/cesium-ml/cesium/contributors","subscribers_url":"https://api.github.com/repos/cesium-ml/cesium/subscribers","subscription_url":"https://api.github.com/repos/cesium-ml/cesium/subscription","commits_url":"https://api.github.com/repos/cesium-ml/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesium-ml/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesium-ml/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesium-ml/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cesium-ml/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/cesium-ml/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesium-ml/cesium/merges","archive_url":"https://api.github.com/repos/cesium-ml/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesium-ml/cesium/downloads","issues_url":"https://api.github.com/repos/cesium-ml/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/cesium-ml/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/cesium-ml/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/cesium-ml/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesium-ml/cesium/labels{/name}","releases_url":"https://api.github.com/repos/cesium-ml/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/cesium-ml/cesium/deployments","created_at":"2014-10-29T16:00:02Z","updated_at":"2016-10-05T01:02:24Z","pushed_at":"2016-10-06T22:43:54Z","git_url":"git://github.com/cesium-ml/cesium.git","ssh_url":"git@github.com:cesium-ml/cesium.git","clone_url":"https://github.com/cesium-ml/cesium.git","svn_url":"https://github.com/cesium-ml/cesium","homepage":null,"size":22324,"stargazers_count":90,"watchers_count":90,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":18,"forks":19,"open_issues":18,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cesium-ml/cesium/pulls/195"},"html":{"href":"https://github.com/cesium-ml/cesium/pull/195"},"issue":{"href":"https://api.github.com/repos/cesium-ml/cesium/issues/195"},"comments":{"href":"https://api.github.com/repos/cesium-ml/cesium/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/cesium-ml/cesium/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/cesium-ml/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cesium-ml/cesium/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/cesium-ml/cesium/statuses/f031c4ade13fdd3f0ecffb085b85acc0eac036c3"}}}}
{"actor":{"display_login":"stefanv"}}