{"action":"created","issue":{"url":"https://api.github.com/repos/ruma/ruma/issues/89","repository_url":"https://api.github.com/repos/ruma/ruma","labels_url":"https://api.github.com/repos/ruma/ruma/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/ruma/ruma/issues/89/comments","events_url":"https://api.github.com/repos/ruma/ruma/issues/89/events","html_url":"https://github.com/ruma/ruma/pull/89","id":177548225,"number":89,"title":"Add basic implementation for the /account/deactivate endpoint.","user":{"login":"mujx","id":6430350,"avatar_url":"https://avatars.githubusercontent.com/u/6430350?v=3","gravatar_id":"","url":"https://api.github.com/users/mujx","html_url":"https://github.com/mujx","followers_url":"https://api.github.com/users/mujx/followers","following_url":"https://api.github.com/users/mujx/following{/other_user}","gists_url":"https://api.github.com/users/mujx/gists{/gist_id}","starred_url":"https://api.github.com/users/mujx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mujx/subscriptions","organizations_url":"https://api.github.com/users/mujx/orgs","repos_url":"https://api.github.com/users/mujx/repos","events_url":"https://api.github.com/users/mujx/events{/privacy}","received_events_url":"https://api.github.com/users/mujx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-17T01:22:48Z","updated_at":"2016-09-17T18:43:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ruma/ruma/pulls/89","html_url":"https://github.com/ruma/ruma/pull/89","diff_url":"https://github.com/ruma/ruma/pull/89.diff","patch_url":"https://github.com/ruma/ruma/pull/89.patch"},"body":"I wrote a basic implementation for the deactivate endpoint, but I am not sure if deleting the user\r\nfrom the database is the best approach.\r\n\r\nMaybe we can use a flag?"},"comment":{"url":"https://api.github.com/repos/ruma/ruma/issues/comments/247796759","html_url":"https://github.com/ruma/ruma/pull/89#issuecomment-247796759","issue_url":"https://api.github.com/repos/ruma/ruma/issues/89","id":247796759,"user":{"login":"jimmycuadra","id":122457,"avatar_url":"https://avatars.githubusercontent.com/u/122457?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmycuadra","html_url":"https://github.com/jimmycuadra","followers_url":"https://api.github.com/users/jimmycuadra/followers","following_url":"https://api.github.com/users/jimmycuadra/following{/other_user}","gists_url":"https://api.github.com/users/jimmycuadra/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmycuadra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmycuadra/subscriptions","organizations_url":"https://api.github.com/users/jimmycuadra/orgs","repos_url":"https://api.github.com/users/jimmycuadra/repos","events_url":"https://api.github.com/users/jimmycuadra/events{/privacy}","received_events_url":"https://api.github.com/users/jimmycuadra/received_events","type":"User","site_admin":false},"created_at":"2016-09-17T18:43:20Z","updated_at":"2016-09-17T18:43:20Z","body":"Thanks for the PR! The spec doesn't say anything about what deactivating means other than \"removing all ability for the user to login again.\" If the user record were to be deleted from the database, that might be a problem since there will still be events in the graph for any rooms they joined that reference them. Given the limited scope of being able to log in that the spec describes, I think you're right that we should just have an \"active\" field for users that is true initially and stays true until the deactivate. Then we'd need to check the value of this field before issuing any new access tokens for the user."}}
{"actor":{"display_login":"jimmycuadra"}}