{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/66318938","id":66318938,"diff_hunk":"@@ -414,10 +398,10 @@ test('`click` triggers appropriate events in order', function() {\n     events = [];\n     return click('.index-view input[type=checkbox]');\n   }).then(function() {\n-    // i.e. mousedown, mouseup, change:true, click, click:true\n+    // i.e. mousedown, mouseup, click\n     // Firefox differs so we can't assert the exact ordering here.\n     // See https://bugzilla.mozilla.org/show_bug.cgi?id=843554.\n-    equal(events.length, 5, 'fires click and change on checkboxes');\n+    equal(events.length, 3, 'fires click and change on checkboxes');","path":"packages/ember-testing/tests/helpers_test.js","position":70,"original_position":70,"commit_id":"7eb7869be3fe61e00e73315230598976a55f4156","original_commit_id":"7eb7869be3fe61e00e73315230598976a55f4156","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"body":"Not sure if `change:true` `click:true` were view events or not.","created_at":"2016-06-08T19:04:30Z","updated_at":"2016-06-08T19:04:30Z","html_url":"https://github.com/emberjs/ember.js/pull/13617#discussion_r66318938","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13617","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/66318938"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13617#discussion_r66318938"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13617"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13617","id":72905526,"html_url":"https://github.com/emberjs/ember.js/pull/13617","diff_url":"https://github.com/emberjs/ember.js/pull/13617.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13617.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13617","number":13617,"state":"open","locked":false,"title":"[GLIMMER] Cleanup Glimmer View Support Mixin","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"body":"In glimmer we have a better strategy around setting layout and thus\r\nprivate APIS such as `templateNameFor` are no longer needed. This also\r\nremoves the following from the view support mixin.\r\n\r\n- CP for `template` (does nothing today)\r\n- CP for `layout` (cannot change post init, slotted in component class)\r\n- Slotted `layoutName` (in Component class)\r\n- Slotted `templateName` (doesn't work in components and was deprecated)\r\n- Slotted `isView` (not used in glimmer)\r\n\r\nThis also consolidates the component lookup between both engines and removes the `{{view}}` keyword from HTMLBars.\r\n\r\n/cc @krisselden","created_at":"2016-06-07T16:19:02Z","updated_at":"2016-06-08T19:04:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a526fe88f184dddc2b31c5d574cdf5f65977c36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13617/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13617/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13617/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/7eb7869be3fe61e00e73315230598976a55f4156","head":{"label":"chadhietala:glimmer-view-support","ref":"glimmer-view-support","sha":"7eb7869be3fe61e00e73315230598976a55f4156","user":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"repo":{"id":22746792,"name":"ember.js","full_name":"chadhietala/ember.js","owner":{"login":"chadhietala","id":183799,"avatar_url":"https://avatars.githubusercontent.com/u/183799?v=3","gravatar_id":"","url":"https://api.github.com/users/chadhietala","html_url":"https://github.com/chadhietala","followers_url":"https://api.github.com/users/chadhietala/followers","following_url":"https://api.github.com/users/chadhietala/following{/other_user}","gists_url":"https://api.github.com/users/chadhietala/gists{/gist_id}","starred_url":"https://api.github.com/users/chadhietala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadhietala/subscriptions","organizations_url":"https://api.github.com/users/chadhietala/orgs","repos_url":"https://api.github.com/users/chadhietala/repos","events_url":"https://api.github.com/users/chadhietala/events{/privacy}","received_events_url":"https://api.github.com/users/chadhietala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadhietala/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/chadhietala/ember.js","forks_url":"https://api.github.com/repos/chadhietala/ember.js/forks","keys_url":"https://api.github.com/repos/chadhietala/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadhietala/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadhietala/ember.js/teams","hooks_url":"https://api.github.com/repos/chadhietala/ember.js/hooks","issue_events_url":"https://api.github.com/repos/chadhietala/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/chadhietala/ember.js/events","assignees_url":"https://api.github.com/repos/chadhietala/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/chadhietala/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/chadhietala/ember.js/tags","blobs_url":"https://api.github.com/repos/chadhietala/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadhietala/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadhietala/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadhietala/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadhietala/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chadhietala/ember.js/languages","stargazers_url":"https://api.github.com/repos/chadhietala/ember.js/stargazers","contributors_url":"https://api.github.com/repos/chadhietala/ember.js/contributors","subscribers_url":"https://api.github.com/repos/chadhietala/ember.js/subscribers","subscription_url":"https://api.github.com/repos/chadhietala/ember.js/subscription","commits_url":"https://api.github.com/repos/chadhietala/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadhietala/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadhietala/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadhietala/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadhietala/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/chadhietala/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadhietala/ember.js/merges","archive_url":"https://api.github.com/repos/chadhietala/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadhietala/ember.js/downloads","issues_url":"https://api.github.com/repos/chadhietala/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/chadhietala/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chadhietala/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chadhietala/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadhietala/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/chadhietala/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/chadhietala/ember.js/deployments","created_at":"2014-08-08T05:15:30Z","updated_at":"2014-12-11T18:19:26Z","pushed_at":"2016-06-08T19:02:53Z","git_url":"git://github.com/chadhietala/ember.js.git","ssh_url":"git@github.com:chadhietala/ember.js.git","clone_url":"https://github.com/chadhietala/ember.js.git","svn_url":"https://github.com/chadhietala/ember.js","homepage":"http://www.emberjs.com","size":32332,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"49730043e687a1d789d90246e375b0712199a8fe","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-06-08T17:43:38Z","pushed_at":"2016-06-08T19:02:53Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":68910,"stargazers_count":16321,"watchers_count":16321,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3488,"mirror_url":null,"open_issues_count":263,"forks":3488,"open_issues":263,"watchers":16321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13617"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13617"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13617"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13617/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13617/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13617/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/7eb7869be3fe61e00e73315230598976a55f4156"}}}}
{"actor":{"display_login":"chadhietala"}}