{"action":"closed","number":245,"pull_request":{"url":"https://api.github.com/repos/getdnsapi/getdns/pulls/245","id":97984199,"html_url":"https://github.com/getdnsapi/getdns/pull/245","diff_url":"https://github.com/getdnsapi/getdns/pull/245.diff","patch_url":"https://github.com/getdnsapi/getdns/pull/245.patch","issue_url":"https://api.github.com/repos/getdnsapi/getdns/issues/245","number":245,"state":"closed","locked":false,"title":"Fixed eventloop","user":{"login":"neilcook","id":15052760,"avatar_url":"https://avatars.githubusercontent.com/u/15052760?v=3","gravatar_id":"","url":"https://api.github.com/users/neilcook","html_url":"https://github.com/neilcook","followers_url":"https://api.github.com/users/neilcook/followers","following_url":"https://api.github.com/users/neilcook/following{/other_user}","gists_url":"https://api.github.com/users/neilcook/gists{/gist_id}","starred_url":"https://api.github.com/users/neilcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilcook/subscriptions","organizations_url":"https://api.github.com/users/neilcook/orgs","repos_url":"https://api.github.com/users/neilcook/repos","events_url":"https://api.github.com/users/neilcook/events{/privacy}","received_events_url":"https://api.github.com/users/neilcook/received_events","type":"User","site_admin":false},"body":"This is a \"proper\" fix for the original problems with hardcoded max_fds, and also the issue with the use of a sparse array for handling timeouts and fds, which becomes horrendously inefficient when the maximum number of fds is set very high.\r\nThis patch uses the BSD-licensed uthash.h to store fd and timeout data in hash tables. This means that only the fd and timeout events that are currently active are stored and processed. Hash entries are dynamically allocated and freed as required.\r\nThis implementation should be faster than the original implementation, even when max fds is very high, as it only processes the timeouts and fds that are scheduled.","created_at":"2016-12-14T16:16:17Z","updated_at":"2016-12-14T18:05:52Z","closed_at":"2016-12-14T18:05:52Z","merged_at":null,"merge_commit_sha":"67452d4e02cc04cacd69ac0c6697726470b421ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/getdnsapi/getdns/pulls/245/commits","review_comments_url":"https://api.github.com/repos/getdnsapi/getdns/pulls/245/comments","review_comment_url":"https://api.github.com/repos/getdnsapi/getdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getdnsapi/getdns/issues/245/comments","statuses_url":"https://api.github.com/repos/getdnsapi/getdns/statuses/0d395639781ff7adbcbc65daeafdc7db23ce1410","head":{"label":"neilcook:fixed_eventloop","ref":"fixed_eventloop","sha":"0d395639781ff7adbcbc65daeafdc7db23ce1410","user":{"login":"neilcook","id":15052760,"avatar_url":"https://avatars.githubusercontent.com/u/15052760?v=3","gravatar_id":"","url":"https://api.github.com/users/neilcook","html_url":"https://github.com/neilcook","followers_url":"https://api.github.com/users/neilcook/followers","following_url":"https://api.github.com/users/neilcook/following{/other_user}","gists_url":"https://api.github.com/users/neilcook/gists{/gist_id}","starred_url":"https://api.github.com/users/neilcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilcook/subscriptions","organizations_url":"https://api.github.com/users/neilcook/orgs","repos_url":"https://api.github.com/users/neilcook/repos","events_url":"https://api.github.com/users/neilcook/events{/privacy}","received_events_url":"https://api.github.com/users/neilcook/received_events","type":"User","site_admin":false},"repo":{"id":47277910,"name":"getdns","full_name":"neilcook/getdns","owner":{"login":"neilcook","id":15052760,"avatar_url":"https://avatars.githubusercontent.com/u/15052760?v=3","gravatar_id":"","url":"https://api.github.com/users/neilcook","html_url":"https://github.com/neilcook","followers_url":"https://api.github.com/users/neilcook/followers","following_url":"https://api.github.com/users/neilcook/following{/other_user}","gists_url":"https://api.github.com/users/neilcook/gists{/gist_id}","starred_url":"https://api.github.com/users/neilcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilcook/subscriptions","organizations_url":"https://api.github.com/users/neilcook/orgs","repos_url":"https://api.github.com/users/neilcook/repos","events_url":"https://api.github.com/users/neilcook/events{/privacy}","received_events_url":"https://api.github.com/users/neilcook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neilcook/getdns","description":"A modern asynchronous DNS API  http://getdnsapi.net/","fork":true,"url":"https://api.github.com/repos/neilcook/getdns","forks_url":"https://api.github.com/repos/neilcook/getdns/forks","keys_url":"https://api.github.com/repos/neilcook/getdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neilcook/getdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neilcook/getdns/teams","hooks_url":"https://api.github.com/repos/neilcook/getdns/hooks","issue_events_url":"https://api.github.com/repos/neilcook/getdns/issues/events{/number}","events_url":"https://api.github.com/repos/neilcook/getdns/events","assignees_url":"https://api.github.com/repos/neilcook/getdns/assignees{/user}","branches_url":"https://api.github.com/repos/neilcook/getdns/branches{/branch}","tags_url":"https://api.github.com/repos/neilcook/getdns/tags","blobs_url":"https://api.github.com/repos/neilcook/getdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neilcook/getdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neilcook/getdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/neilcook/getdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neilcook/getdns/statuses/{sha}","languages_url":"https://api.github.com/repos/neilcook/getdns/languages","stargazers_url":"https://api.github.com/repos/neilcook/getdns/stargazers","contributors_url":"https://api.github.com/repos/neilcook/getdns/contributors","subscribers_url":"https://api.github.com/repos/neilcook/getdns/subscribers","subscription_url":"https://api.github.com/repos/neilcook/getdns/subscription","commits_url":"https://api.github.com/repos/neilcook/getdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/neilcook/getdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/neilcook/getdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/neilcook/getdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/neilcook/getdns/contents/{+path}","compare_url":"https://api.github.com/repos/neilcook/getdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neilcook/getdns/merges","archive_url":"https://api.github.com/repos/neilcook/getdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neilcook/getdns/downloads","issues_url":"https://api.github.com/repos/neilcook/getdns/issues{/number}","pulls_url":"https://api.github.com/repos/neilcook/getdns/pulls{/number}","milestones_url":"https://api.github.com/repos/neilcook/getdns/milestones{/number}","notifications_url":"https://api.github.com/repos/neilcook/getdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neilcook/getdns/labels{/name}","releases_url":"https://api.github.com/repos/neilcook/getdns/releases{/id}","deployments_url":"https://api.github.com/repos/neilcook/getdns/deployments","created_at":"2015-12-02T17:47:04Z","updated_at":"2016-10-26T12:23:15Z","pushed_at":"2016-12-14T17:50:49Z","git_url":"git://github.com/neilcook/getdns.git","ssh_url":"git@github.com:neilcook/getdns.git","clone_url":"https://github.com/neilcook/getdns.git","svn_url":"https://github.com/neilcook/getdns","homepage":"","size":8154,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"getdnsapi:develop","ref":"develop","sha":"4518a3d672aefa8740e288f7283a61fb8b0157a7","user":{"login":"getdnsapi","id":6717229,"avatar_url":"https://avatars.githubusercontent.com/u/6717229?v=3","gravatar_id":"","url":"https://api.github.com/users/getdnsapi","html_url":"https://github.com/getdnsapi","followers_url":"https://api.github.com/users/getdnsapi/followers","following_url":"https://api.github.com/users/getdnsapi/following{/other_user}","gists_url":"https://api.github.com/users/getdnsapi/gists{/gist_id}","starred_url":"https://api.github.com/users/getdnsapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getdnsapi/subscriptions","organizations_url":"https://api.github.com/users/getdnsapi/orgs","repos_url":"https://api.github.com/users/getdnsapi/repos","events_url":"https://api.github.com/users/getdnsapi/events{/privacy}","received_events_url":"https://api.github.com/users/getdnsapi/received_events","type":"Organization","site_admin":false},"repo":{"id":17215361,"name":"getdns","full_name":"getdnsapi/getdns","owner":{"login":"getdnsapi","id":6717229,"avatar_url":"https://avatars.githubusercontent.com/u/6717229?v=3","gravatar_id":"","url":"https://api.github.com/users/getdnsapi","html_url":"https://github.com/getdnsapi","followers_url":"https://api.github.com/users/getdnsapi/followers","following_url":"https://api.github.com/users/getdnsapi/following{/other_user}","gists_url":"https://api.github.com/users/getdnsapi/gists{/gist_id}","starred_url":"https://api.github.com/users/getdnsapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getdnsapi/subscriptions","organizations_url":"https://api.github.com/users/getdnsapi/orgs","repos_url":"https://api.github.com/users/getdnsapi/repos","events_url":"https://api.github.com/users/getdnsapi/events{/privacy}","received_events_url":"https://api.github.com/users/getdnsapi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getdnsapi/getdns","description":"A modern asynchronous DNS API  http://getdnsapi.net/","fork":false,"url":"https://api.github.com/repos/getdnsapi/getdns","forks_url":"https://api.github.com/repos/getdnsapi/getdns/forks","keys_url":"https://api.github.com/repos/getdnsapi/getdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getdnsapi/getdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getdnsapi/getdns/teams","hooks_url":"https://api.github.com/repos/getdnsapi/getdns/hooks","issue_events_url":"https://api.github.com/repos/getdnsapi/getdns/issues/events{/number}","events_url":"https://api.github.com/repos/getdnsapi/getdns/events","assignees_url":"https://api.github.com/repos/getdnsapi/getdns/assignees{/user}","branches_url":"https://api.github.com/repos/getdnsapi/getdns/branches{/branch}","tags_url":"https://api.github.com/repos/getdnsapi/getdns/tags","blobs_url":"https://api.github.com/repos/getdnsapi/getdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getdnsapi/getdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getdnsapi/getdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/getdnsapi/getdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getdnsapi/getdns/statuses/{sha}","languages_url":"https://api.github.com/repos/getdnsapi/getdns/languages","stargazers_url":"https://api.github.com/repos/getdnsapi/getdns/stargazers","contributors_url":"https://api.github.com/repos/getdnsapi/getdns/contributors","subscribers_url":"https://api.github.com/repos/getdnsapi/getdns/subscribers","subscription_url":"https://api.github.com/repos/getdnsapi/getdns/subscription","commits_url":"https://api.github.com/repos/getdnsapi/getdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/getdnsapi/getdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/getdnsapi/getdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/getdnsapi/getdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/getdnsapi/getdns/contents/{+path}","compare_url":"https://api.github.com/repos/getdnsapi/getdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getdnsapi/getdns/merges","archive_url":"https://api.github.com/repos/getdnsapi/getdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getdnsapi/getdns/downloads","issues_url":"https://api.github.com/repos/getdnsapi/getdns/issues{/number}","pulls_url":"https://api.github.com/repos/getdnsapi/getdns/pulls{/number}","milestones_url":"https://api.github.com/repos/getdnsapi/getdns/milestones{/number}","notifications_url":"https://api.github.com/repos/getdnsapi/getdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getdnsapi/getdns/labels{/name}","releases_url":"https://api.github.com/repos/getdnsapi/getdns/releases{/id}","deployments_url":"https://api.github.com/repos/getdnsapi/getdns/deployments","created_at":"2014-02-26T15:38:24Z","updated_at":"2016-12-08T08:29:35Z","pushed_at":"2016-12-14T17:50:50Z","git_url":"git://github.com/getdnsapi/getdns.git","ssh_url":"git@github.com:getdnsapi/getdns.git","clone_url":"https://github.com/getdnsapi/getdns.git","svn_url":"https://github.com/getdnsapi/getdns","homepage":"","size":14393,"stargazers_count":134,"watchers_count":134,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":34,"forks":47,"open_issues":34,"watchers":134,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/getdnsapi/getdns/pulls/245"},"html":{"href":"https://github.com/getdnsapi/getdns/pull/245"},"issue":{"href":"https://api.github.com/repos/getdnsapi/getdns/issues/245"},"comments":{"href":"https://api.github.com/repos/getdnsapi/getdns/issues/245/comments"},"review_comments":{"href":"https://api.github.com/repos/getdnsapi/getdns/pulls/245/comments"},"review_comment":{"href":"https://api.github.com/repos/getdnsapi/getdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getdnsapi/getdns/pulls/245/commits"},"statuses":{"href":"https://api.github.com/repos/getdnsapi/getdns/statuses/0d395639781ff7adbcbc65daeafdc7db23ce1410"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":8,"additions":1248,"deletions":102,"changed_files":3}}
{"actor":{"display_login":"neilcook"}}