{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/73780097","id":73780097,"diff_hunk":"@@ -2636,6 +2636,47 @@ public Object Clone()\n         [System.Security.SecuritySafeCritical]  // auto-generated\n         [MethodImplAttribute(MethodImplOptions.InternalCall)]\n         public extern void Initialize();\n+\n+\n+        private static void ThrowArrayNullException()\n+        {\n+            throw new ArgumentNullException(\"array\");\n+        }\n+\n+        private static void ThrowElementTypeNullException()\n+        {\n+            throw new ArgumentNullException(\"elementType\");\n+        }\n+\n+        private static void ThrowArgumentCountOutOfRange()\n+        {\n+            throw new ArgumentOutOfRangeException(\"count\", Environment.GetResourceString(\"ArgumentOutOfRange_Count\"));\n+        }\n+\n+        private static void ThrowArgumentStartIndexOutOfRange()\n+        {\n+            throw new ArgumentOutOfRangeException(\"startIndex\", Environment.GetResourceString(\"ArgumentOutOfRange_Index\"));\n+        }\n+\n+        private static void ThrowArgumentElementTypeMustBeType()\n+        {\n+            throw new ArgumentException(Environment.GetResourceString(\"Arg_MustBeType\"), \"elementType\");\n+        }\n+\n+        private static void ThrowArgumentOutOfRangeNeedNonNegNum(string parmName)","path":"src/mscorlib/src/System/Array.cs","position":null,"original_position":904,"commit_id":"4570a40203d2c09f447726667db4c6056daf8685","original_commit_id":"37caf55180b1e050ea50b7c0d4a2da91f93a3c82","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2016-08-06T03:30:50Z","updated_at":"2016-08-06T03:30:50Z","html_url":"https://github.com/dotnet/coreclr/pull/6634#discussion_r73780097","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6634","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/73780097"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6634#discussion_r73780097"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6634"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/6634","id":80316091,"html_url":"https://github.com/dotnet/coreclr/pull/6634","diff_url":"https://github.com/dotnet/coreclr/pull/6634.diff","patch_url":"https://github.com/dotnet/coreclr/pull/6634.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/6634","number":6634,"state":"open","locked":false,"title":"Reduced Array exception code repetition","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"With the introduction of https://github.com/dotnet/coreclr/pull/6103\r\n\r\nThese changes result in a 67kB reduction int the size of System.Private.CoreLib native (Windows_NT.x64.Release).\r\n```\r\nPre  System.Private.CoreLib.ni.dll 10,913,280 bytes\r\nPost System.Private.CoreLib.ni.dll 10,844,672 bytes\r\n```\r\n68,608 byte reduction\r\n\r\n/cc @AndyAyersMS @mikedn  \r\n","created_at":"2016-08-05T22:32:05Z","updated_at":"2016-08-06T03:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1f39c2abecce72a974f2572135578e7256b4ecb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6634/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/6634/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/6634/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/4570a40203d2c09f447726667db4c6056daf8685","head":{"label":"benaadams:array-exceptions","ref":"array-exceptions","sha":"4570a40203d2c09f447726667db4c6056daf8685","user":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"repo":{"id":30264189,"name":"coreclr","full_name":"benaadams/coreclr","owner":{"login":"benaadams","id":1142958,"avatar_url":"https://avatars.githubusercontent.com/u/1142958?v=3","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benaadams/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/benaadams/coreclr","forks_url":"https://api.github.com/repos/benaadams/coreclr/forks","keys_url":"https://api.github.com/repos/benaadams/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benaadams/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benaadams/coreclr/teams","hooks_url":"https://api.github.com/repos/benaadams/coreclr/hooks","issue_events_url":"https://api.github.com/repos/benaadams/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/benaadams/coreclr/events","assignees_url":"https://api.github.com/repos/benaadams/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/benaadams/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/benaadams/coreclr/tags","blobs_url":"https://api.github.com/repos/benaadams/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benaadams/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benaadams/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/benaadams/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benaadams/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/benaadams/coreclr/languages","stargazers_url":"https://api.github.com/repos/benaadams/coreclr/stargazers","contributors_url":"https://api.github.com/repos/benaadams/coreclr/contributors","subscribers_url":"https://api.github.com/repos/benaadams/coreclr/subscribers","subscription_url":"https://api.github.com/repos/benaadams/coreclr/subscription","commits_url":"https://api.github.com/repos/benaadams/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/benaadams/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/benaadams/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/benaadams/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/benaadams/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/benaadams/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benaadams/coreclr/merges","archive_url":"https://api.github.com/repos/benaadams/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benaadams/coreclr/downloads","issues_url":"https://api.github.com/repos/benaadams/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/benaadams/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/benaadams/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/benaadams/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benaadams/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/benaadams/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/benaadams/coreclr/deployments","created_at":"2015-02-03T20:56:42Z","updated_at":"2015-06-11T05:46:49Z","pushed_at":"2016-08-06T03:30:28Z","git_url":"git://github.com/benaadams/coreclr.git","ssh_url":"git@github.com:benaadams/coreclr.git","clone_url":"https://github.com/benaadams/coreclr.git","svn_url":"https://github.com/benaadams/coreclr","homepage":"","size":94005,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"patch-1"}},"base":{"label":"dotnet:master","ref":"master","sha":"8596efa80c68bdc90f577aa80252406dec6bedb0","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-08-05T18:30:18Z","pushed_at":"2016-08-06T03:30:29Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":105353,"stargazers_count":6761,"watchers_count":6761,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1591,"mirror_url":null,"open_issues_count":911,"forks":1591,"open_issues":911,"watchers":6761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6634"},"html":{"href":"https://github.com/dotnet/coreclr/pull/6634"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6634"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/6634/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6634/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/6634/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/4570a40203d2c09f447726667db4c6056daf8685"}}}}
{"actor":{"display_login":"benaadams"}}