{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-R/repgen/pulls/comments/92892764","pull_request_review_id":13411765,"id":92892764,"diff_hunk":"@@ -103,6 +105,21 @@ parseRefData <- function(data, series) {\n   return(plotData)\n }\n \n+parseEstimatedEdges <- function(data, allVars){\n+  datasets <- unlist(allVars, recursive = FALSE)[which(grepl(\"stat\\\\d\", names(unlist(allVars, recursive = FALSE))))]\n+  times <- datasets[which(grepl(\"time\", names(datasets)))]\n+  values <- datasets[which(grepl(\"value\", names(datasets)))]\n+  estData <- data.frame(time=unname(unlist(times[which(grepl(\"est\", names(times)))])), value=unname(unlist(values[which(grepl(\"est\", names(values)))])), set=\"est\")\n+  statData <- data.frame(time=unname(unlist(times[which(!grepl(\"est\", names(times)))])), value=unname(unlist(values[which(!grepl(\"est\", names(values)))])), set=\"stat\")","path":"R/dvhydrograph-data.R","position":18,"original_position":18,"commit_id":"a3302613f52fd0e20da0233777b7ff5f6d196111","original_commit_id":"a3302613f52fd0e20da0233777b7ff5f6d196111","user":{"login":"lindsaycarr","id":13220910,"avatar_url":"https://avatars.githubusercontent.com/u/13220910?v=3","gravatar_id":"","url":"https://api.github.com/users/lindsaycarr","html_url":"https://github.com/lindsaycarr","followers_url":"https://api.github.com/users/lindsaycarr/followers","following_url":"https://api.github.com/users/lindsaycarr/following{/other_user}","gists_url":"https://api.github.com/users/lindsaycarr/gists{/gist_id}","starred_url":"https://api.github.com/users/lindsaycarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindsaycarr/subscriptions","organizations_url":"https://api.github.com/users/lindsaycarr/orgs","repos_url":"https://api.github.com/users/lindsaycarr/repos","events_url":"https://api.github.com/users/lindsaycarr/events{/privacy}","received_events_url":"https://api.github.com/users/lindsaycarr/received_events","type":"User","site_admin":false},"body":"not a huge fan of what's happening here at the beginning - you go through and grab all of the times and values into single lists and then separate back out into est and stat dataframes. I think the more logical way would be to pull the est and stat data from allVars separately:\r\n\r\n```r\r\nest_df_list <- lapply(allVars[grepl('est_stat\\\\d', names(allVars))], as.data.frame, stringsAsFactors=F)\r\nestData <- bind_rows(est_df_list) %>% select(-legend.name) %>% mutate(set=rep('est', nrow(.)))\r\n\r\nstat_df_list <- lapply(allVars[grepl('^stat\\\\d', names(allVars))], as.data.frame, stringsAsFactors=F)\r\nstatData <- bind_rows(stat_df_list) %>% select(-legend.name) %>% mutate(set=rep('stat', nrow(.)))\r\n```\r\n\r\nthen you can continue on to the code below.","created_at":"2016-12-16T21:53:29Z","updated_at":"2016-12-16T21:55:41Z","html_url":"https://github.com/USGS-R/repgen/pull/482#discussion_r92892764","pull_request_url":"https://api.github.com/repos/USGS-R/repgen/pulls/482","_links":{"self":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/comments/92892764"},"html":{"href":"https://github.com/USGS-R/repgen/pull/482#discussion_r92892764"},"pull_request":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/482"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-R/repgen/pulls/482","id":98364516,"html_url":"https://github.com/USGS-R/repgen/pull/482","diff_url":"https://github.com/USGS-R/repgen/pull/482.diff","patch_url":"https://github.com/USGS-R/repgen/pull/482.patch","issue_url":"https://api.github.com/repos/USGS-R/repgen/issues/482","number":482,"state":"open","locked":false,"title":"AQCU-928: DV Hydro- Step plots are not connected going from estimated to not estimated, and not estimated to estimated","user":{"login":"zmoore-usgs","id":20842403,"avatar_url":"https://avatars.githubusercontent.com/u/20842403?v=3","gravatar_id":"","url":"https://api.github.com/users/zmoore-usgs","html_url":"https://github.com/zmoore-usgs","followers_url":"https://api.github.com/users/zmoore-usgs/followers","following_url":"https://api.github.com/users/zmoore-usgs/following{/other_user}","gists_url":"https://api.github.com/users/zmoore-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/zmoore-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmoore-usgs/subscriptions","organizations_url":"https://api.github.com/users/zmoore-usgs/orgs","repos_url":"https://api.github.com/users/zmoore-usgs/repos","events_url":"https://api.github.com/users/zmoore-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/zmoore-usgs/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-16T16:35:43Z","updated_at":"2016-12-16T21:55:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2effeb7387f879acb41a1e5ea520119507ab9825","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-R/repgen/pulls/482/commits","review_comments_url":"https://api.github.com/repos/USGS-R/repgen/pulls/482/comments","review_comment_url":"https://api.github.com/repos/USGS-R/repgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-R/repgen/issues/482/comments","statuses_url":"https://api.github.com/repos/USGS-R/repgen/statuses/a3302613f52fd0e20da0233777b7ff5f6d196111","head":{"label":"zmoore-usgs:feature/estimated-dv-connections","ref":"feature/estimated-dv-connections","sha":"a3302613f52fd0e20da0233777b7ff5f6d196111","user":{"login":"zmoore-usgs","id":20842403,"avatar_url":"https://avatars.githubusercontent.com/u/20842403?v=3","gravatar_id":"","url":"https://api.github.com/users/zmoore-usgs","html_url":"https://github.com/zmoore-usgs","followers_url":"https://api.github.com/users/zmoore-usgs/followers","following_url":"https://api.github.com/users/zmoore-usgs/following{/other_user}","gists_url":"https://api.github.com/users/zmoore-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/zmoore-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmoore-usgs/subscriptions","organizations_url":"https://api.github.com/users/zmoore-usgs/orgs","repos_url":"https://api.github.com/users/zmoore-usgs/repos","events_url":"https://api.github.com/users/zmoore-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/zmoore-usgs/received_events","type":"User","site_admin":false},"repo":{"id":65741799,"name":"repgen","full_name":"zmoore-usgs/repgen","owner":{"login":"zmoore-usgs","id":20842403,"avatar_url":"https://avatars.githubusercontent.com/u/20842403?v=3","gravatar_id":"","url":"https://api.github.com/users/zmoore-usgs","html_url":"https://github.com/zmoore-usgs","followers_url":"https://api.github.com/users/zmoore-usgs/followers","following_url":"https://api.github.com/users/zmoore-usgs/following{/other_user}","gists_url":"https://api.github.com/users/zmoore-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/zmoore-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmoore-usgs/subscriptions","organizations_url":"https://api.github.com/users/zmoore-usgs/orgs","repos_url":"https://api.github.com/users/zmoore-usgs/repos","events_url":"https://api.github.com/users/zmoore-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/zmoore-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmoore-usgs/repgen","description":"report generation in R","fork":true,"url":"https://api.github.com/repos/zmoore-usgs/repgen","forks_url":"https://api.github.com/repos/zmoore-usgs/repgen/forks","keys_url":"https://api.github.com/repos/zmoore-usgs/repgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmoore-usgs/repgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmoore-usgs/repgen/teams","hooks_url":"https://api.github.com/repos/zmoore-usgs/repgen/hooks","issue_events_url":"https://api.github.com/repos/zmoore-usgs/repgen/issues/events{/number}","events_url":"https://api.github.com/repos/zmoore-usgs/repgen/events","assignees_url":"https://api.github.com/repos/zmoore-usgs/repgen/assignees{/user}","branches_url":"https://api.github.com/repos/zmoore-usgs/repgen/branches{/branch}","tags_url":"https://api.github.com/repos/zmoore-usgs/repgen/tags","blobs_url":"https://api.github.com/repos/zmoore-usgs/repgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmoore-usgs/repgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmoore-usgs/repgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmoore-usgs/repgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmoore-usgs/repgen/statuses/{sha}","languages_url":"https://api.github.com/repos/zmoore-usgs/repgen/languages","stargazers_url":"https://api.github.com/repos/zmoore-usgs/repgen/stargazers","contributors_url":"https://api.github.com/repos/zmoore-usgs/repgen/contributors","subscribers_url":"https://api.github.com/repos/zmoore-usgs/repgen/subscribers","subscription_url":"https://api.github.com/repos/zmoore-usgs/repgen/subscription","commits_url":"https://api.github.com/repos/zmoore-usgs/repgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmoore-usgs/repgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmoore-usgs/repgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmoore-usgs/repgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmoore-usgs/repgen/contents/{+path}","compare_url":"https://api.github.com/repos/zmoore-usgs/repgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmoore-usgs/repgen/merges","archive_url":"https://api.github.com/repos/zmoore-usgs/repgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmoore-usgs/repgen/downloads","issues_url":"https://api.github.com/repos/zmoore-usgs/repgen/issues{/number}","pulls_url":"https://api.github.com/repos/zmoore-usgs/repgen/pulls{/number}","milestones_url":"https://api.github.com/repos/zmoore-usgs/repgen/milestones{/number}","notifications_url":"https://api.github.com/repos/zmoore-usgs/repgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmoore-usgs/repgen/labels{/name}","releases_url":"https://api.github.com/repos/zmoore-usgs/repgen/releases{/id}","deployments_url":"https://api.github.com/repos/zmoore-usgs/repgen/deployments","created_at":"2016-08-15T15:12:50Z","updated_at":"2016-08-15T15:12:51Z","pushed_at":"2016-12-16T21:05:44Z","git_url":"git://github.com/zmoore-usgs/repgen.git","ssh_url":"git@github.com:zmoore-usgs/repgen.git","clone_url":"https://github.com/zmoore-usgs/repgen.git","svn_url":"https://github.com/zmoore-usgs/repgen","homepage":null,"size":12301,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-R:master","ref":"master","sha":"b5a47b6c252200bcf0c7807979f352e067251cab","user":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"repo":{"id":31678130,"name":"repgen","full_name":"USGS-R/repgen","owner":{"login":"USGS-R","id":3188813,"avatar_url":"https://avatars.githubusercontent.com/u/3188813?v=3","gravatar_id":"","url":"https://api.github.com/users/USGS-R","html_url":"https://github.com/USGS-R","followers_url":"https://api.github.com/users/USGS-R/followers","following_url":"https://api.github.com/users/USGS-R/following{/other_user}","gists_url":"https://api.github.com/users/USGS-R/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-R/subscriptions","organizations_url":"https://api.github.com/users/USGS-R/orgs","repos_url":"https://api.github.com/users/USGS-R/repos","events_url":"https://api.github.com/users/USGS-R/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-R/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-R/repgen","description":"report generation in R","fork":false,"url":"https://api.github.com/repos/USGS-R/repgen","forks_url":"https://api.github.com/repos/USGS-R/repgen/forks","keys_url":"https://api.github.com/repos/USGS-R/repgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-R/repgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-R/repgen/teams","hooks_url":"https://api.github.com/repos/USGS-R/repgen/hooks","issue_events_url":"https://api.github.com/repos/USGS-R/repgen/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-R/repgen/events","assignees_url":"https://api.github.com/repos/USGS-R/repgen/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-R/repgen/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-R/repgen/tags","blobs_url":"https://api.github.com/repos/USGS-R/repgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-R/repgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-R/repgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-R/repgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-R/repgen/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-R/repgen/languages","stargazers_url":"https://api.github.com/repos/USGS-R/repgen/stargazers","contributors_url":"https://api.github.com/repos/USGS-R/repgen/contributors","subscribers_url":"https://api.github.com/repos/USGS-R/repgen/subscribers","subscription_url":"https://api.github.com/repos/USGS-R/repgen/subscription","commits_url":"https://api.github.com/repos/USGS-R/repgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-R/repgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-R/repgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-R/repgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-R/repgen/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-R/repgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-R/repgen/merges","archive_url":"https://api.github.com/repos/USGS-R/repgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-R/repgen/downloads","issues_url":"https://api.github.com/repos/USGS-R/repgen/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-R/repgen/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-R/repgen/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-R/repgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-R/repgen/labels{/name}","releases_url":"https://api.github.com/repos/USGS-R/repgen/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-R/repgen/deployments","created_at":"2015-03-04T20:24:02Z","updated_at":"2016-10-24T17:01:53Z","pushed_at":"2016-12-16T21:05:44Z","git_url":"git://github.com/USGS-R/repgen.git","ssh_url":"git@github.com:USGS-R/repgen.git","clone_url":"https://github.com/USGS-R/repgen.git","svn_url":"https://github.com/USGS-R/repgen","homepage":null,"size":12266,"stargazers_count":7,"watchers_count":7,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":8,"forks":12,"open_issues":8,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/482"},"html":{"href":"https://github.com/USGS-R/repgen/pull/482"},"issue":{"href":"https://api.github.com/repos/USGS-R/repgen/issues/482"},"comments":{"href":"https://api.github.com/repos/USGS-R/repgen/issues/482/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/482/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-R/repgen/pulls/482/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-R/repgen/statuses/a3302613f52fd0e20da0233777b7ff5f6d196111"}}}}
{"actor":{"display_login":"lindsaycarr"}}