{"action":"created","comment":{"url":"https://api.github.com/repos/nus-mtp/worldscope/pulls/comments/53921085","id":53921085,"diff_hunk":"@@ -24,8 +24,14 @@ lab.experiment('Utility#getModuleName Tests', function () {\n });\n \n lab.experiment('Utility#randomValueBase64 tests', function () {\n-  lab.test('Should return some strings', function (done) {\n+  lab.test('Should return a string with correct length', function (done) {\n     Code.expect(Utility.randomValueBase64(20).length).to.equal(20);\n     done();\n   });\n+  lab.test('Should return different string in each call', function (done) {","path":"app_server/test/util/Utility.js","position":9,"original_position":9,"commit_id":"7a243f4251708e3219c59d8fb7436ec2dcaad858","original_commit_id":"7a243f4251708e3219c59d8fb7436ec2dcaad858","user":{"login":"ndt93","id":5065989,"avatar_url":"https://avatars.githubusercontent.com/u/5065989?v=3","gravatar_id":"","url":"https://api.github.com/users/ndt93","html_url":"https://github.com/ndt93","followers_url":"https://api.github.com/users/ndt93/followers","following_url":"https://api.github.com/users/ndt93/following{/other_user}","gists_url":"https://api.github.com/users/ndt93/gists{/gist_id}","starred_url":"https://api.github.com/users/ndt93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndt93/subscriptions","organizations_url":"https://api.github.com/users/ndt93/orgs","repos_url":"https://api.github.com/users/ndt93/repos","events_url":"https://api.github.com/users/ndt93/events{/privacy}","received_events_url":"https://api.github.com/users/ndt93/received_events","type":"User","site_admin":false},"body":":scream: ","created_at":"2016-02-24T10:43:57Z","updated_at":"2016-02-24T10:43:57Z","html_url":"https://github.com/nus-mtp/worldscope/pull/53#discussion_r53921085","pull_request_url":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/nus-mtp/worldscope/pulls/comments/53921085"},"html":{"href":"https://github.com/nus-mtp/worldscope/pull/53#discussion_r53921085"},"pull_request":{"href":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53","id":60236463,"html_url":"https://github.com/nus-mtp/worldscope/pull/53","diff_url":"https://github.com/nus-mtp/worldscope/pull/53.diff","patch_url":"https://github.com/nus-mtp/worldscope/pull/53.patch","issue_url":"https://api.github.com/repos/nus-mtp/worldscope/issues/53","number":53,"state":"open","locked":false,"title":"Socket disconnect","user":{"login":"ndt93","id":5065989,"avatar_url":"https://avatars.githubusercontent.com/u/5065989?v=3","gravatar_id":"","url":"https://api.github.com/users/ndt93","html_url":"https://github.com/ndt93","followers_url":"https://api.github.com/users/ndt93/followers","following_url":"https://api.github.com/users/ndt93/following{/other_user}","gists_url":"https://api.github.com/users/ndt93/gists{/gist_id}","starred_url":"https://api.github.com/users/ndt93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndt93/subscriptions","organizations_url":"https://api.github.com/users/ndt93/orgs","repos_url":"https://api.github.com/users/ndt93/repos","events_url":"https://api.github.com/users/ndt93/events{/privacy}","received_events_url":"https://api.github.com/users/ndt93/received_events","type":"User","site_admin":false},"body":"* Remove clients and update rooms when clients are disconnected\r\n* Purge clients from room and remove room when a user ends a stream or when a stream is stopped\r\n\r\n`Client` corresponds to a websocket connection, not just a user. A user can have multiple sockets, corresponding to that user viewing or publishing different streams.","created_at":"2016-02-22T20:37:01Z","updated_at":"2016-02-24T10:43:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"845032163be1cb2bc9a26a3110a4fb3556a67d8b","assignee":{"login":"sharminelow","id":7575618,"avatar_url":"https://avatars.githubusercontent.com/u/7575618?v=3","gravatar_id":"","url":"https://api.github.com/users/sharminelow","html_url":"https://github.com/sharminelow","followers_url":"https://api.github.com/users/sharminelow/followers","following_url":"https://api.github.com/users/sharminelow/following{/other_user}","gists_url":"https://api.github.com/users/sharminelow/gists{/gist_id}","starred_url":"https://api.github.com/users/sharminelow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharminelow/subscriptions","organizations_url":"https://api.github.com/users/sharminelow/orgs","repos_url":"https://api.github.com/users/sharminelow/repos","events_url":"https://api.github.com/users/sharminelow/events{/privacy}","received_events_url":"https://api.github.com/users/sharminelow/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53/commits","review_comments_url":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53/comments","review_comment_url":"https://api.github.com/repos/nus-mtp/worldscope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-mtp/worldscope/issues/53/comments","statuses_url":"https://api.github.com/repos/nus-mtp/worldscope/statuses/7a243f4251708e3219c59d8fb7436ec2dcaad858","head":{"label":"nus-mtp:socket-disconnect","ref":"socket-disconnect","sha":"7a243f4251708e3219c59d8fb7436ec2dcaad858","user":{"login":"nus-mtp","id":12422648,"avatar_url":"https://avatars.githubusercontent.com/u/12422648?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-mtp","html_url":"https://github.com/nus-mtp","followers_url":"https://api.github.com/users/nus-mtp/followers","following_url":"https://api.github.com/users/nus-mtp/following{/other_user}","gists_url":"https://api.github.com/users/nus-mtp/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-mtp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-mtp/subscriptions","organizations_url":"https://api.github.com/users/nus-mtp/orgs","repos_url":"https://api.github.com/users/nus-mtp/repos","events_url":"https://api.github.com/users/nus-mtp/events{/privacy}","received_events_url":"https://api.github.com/users/nus-mtp/received_events","type":"Organization","site_admin":false},"repo":{"id":41545905,"name":"worldscope","full_name":"nus-mtp/worldscope","owner":{"login":"nus-mtp","id":12422648,"avatar_url":"https://avatars.githubusercontent.com/u/12422648?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-mtp","html_url":"https://github.com/nus-mtp","followers_url":"https://api.github.com/users/nus-mtp/followers","following_url":"https://api.github.com/users/nus-mtp/following{/other_user}","gists_url":"https://api.github.com/users/nus-mtp/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-mtp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-mtp/subscriptions","organizations_url":"https://api.github.com/users/nus-mtp/orgs","repos_url":"https://api.github.com/users/nus-mtp/repos","events_url":"https://api.github.com/users/nus-mtp/events{/privacy}","received_events_url":"https://api.github.com/users/nus-mtp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-mtp/worldscope","description":"An open source live mobile broadcast platform.  Worldscope's client runs on Android.  The backend runs on Wowza and Node.js (using Hapi framework).","fork":false,"url":"https://api.github.com/repos/nus-mtp/worldscope","forks_url":"https://api.github.com/repos/nus-mtp/worldscope/forks","keys_url":"https://api.github.com/repos/nus-mtp/worldscope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-mtp/worldscope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-mtp/worldscope/teams","hooks_url":"https://api.github.com/repos/nus-mtp/worldscope/hooks","issue_events_url":"https://api.github.com/repos/nus-mtp/worldscope/issues/events{/number}","events_url":"https://api.github.com/repos/nus-mtp/worldscope/events","assignees_url":"https://api.github.com/repos/nus-mtp/worldscope/assignees{/user}","branches_url":"https://api.github.com/repos/nus-mtp/worldscope/branches{/branch}","tags_url":"https://api.github.com/repos/nus-mtp/worldscope/tags","blobs_url":"https://api.github.com/repos/nus-mtp/worldscope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-mtp/worldscope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-mtp/worldscope/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-mtp/worldscope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-mtp/worldscope/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-mtp/worldscope/languages","stargazers_url":"https://api.github.com/repos/nus-mtp/worldscope/stargazers","contributors_url":"https://api.github.com/repos/nus-mtp/worldscope/contributors","subscribers_url":"https://api.github.com/repos/nus-mtp/worldscope/subscribers","subscription_url":"https://api.github.com/repos/nus-mtp/worldscope/subscription","commits_url":"https://api.github.com/repos/nus-mtp/worldscope/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-mtp/worldscope/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-mtp/worldscope/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-mtp/worldscope/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-mtp/worldscope/contents/{+path}","compare_url":"https://api.github.com/repos/nus-mtp/worldscope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-mtp/worldscope/merges","archive_url":"https://api.github.com/repos/nus-mtp/worldscope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-mtp/worldscope/downloads","issues_url":"https://api.github.com/repos/nus-mtp/worldscope/issues{/number}","pulls_url":"https://api.github.com/repos/nus-mtp/worldscope/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-mtp/worldscope/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-mtp/worldscope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-mtp/worldscope/labels{/name}","releases_url":"https://api.github.com/repos/nus-mtp/worldscope/releases{/id}","deployments_url":"https://api.github.com/repos/nus-mtp/worldscope/deployments","created_at":"2015-08-28T12:20:34Z","updated_at":"2016-02-02T10:26:32Z","pushed_at":"2016-02-24T10:26:42Z","git_url":"git://github.com/nus-mtp/worldscope.git","ssh_url":"git@github.com:nus-mtp/worldscope.git","clone_url":"https://github.com/nus-mtp/worldscope.git","svn_url":"https://github.com/nus-mtp/worldscope","homepage":"","size":3833,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"nus-mtp:master","ref":"master","sha":"661877eefec097823c16748ad0f5ad9a43f2d707","user":{"login":"nus-mtp","id":12422648,"avatar_url":"https://avatars.githubusercontent.com/u/12422648?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-mtp","html_url":"https://github.com/nus-mtp","followers_url":"https://api.github.com/users/nus-mtp/followers","following_url":"https://api.github.com/users/nus-mtp/following{/other_user}","gists_url":"https://api.github.com/users/nus-mtp/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-mtp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-mtp/subscriptions","organizations_url":"https://api.github.com/users/nus-mtp/orgs","repos_url":"https://api.github.com/users/nus-mtp/repos","events_url":"https://api.github.com/users/nus-mtp/events{/privacy}","received_events_url":"https://api.github.com/users/nus-mtp/received_events","type":"Organization","site_admin":false},"repo":{"id":41545905,"name":"worldscope","full_name":"nus-mtp/worldscope","owner":{"login":"nus-mtp","id":12422648,"avatar_url":"https://avatars.githubusercontent.com/u/12422648?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-mtp","html_url":"https://github.com/nus-mtp","followers_url":"https://api.github.com/users/nus-mtp/followers","following_url":"https://api.github.com/users/nus-mtp/following{/other_user}","gists_url":"https://api.github.com/users/nus-mtp/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-mtp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-mtp/subscriptions","organizations_url":"https://api.github.com/users/nus-mtp/orgs","repos_url":"https://api.github.com/users/nus-mtp/repos","events_url":"https://api.github.com/users/nus-mtp/events{/privacy}","received_events_url":"https://api.github.com/users/nus-mtp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-mtp/worldscope","description":"An open source live mobile broadcast platform.  Worldscope's client runs on Android.  The backend runs on Wowza and Node.js (using Hapi framework).","fork":false,"url":"https://api.github.com/repos/nus-mtp/worldscope","forks_url":"https://api.github.com/repos/nus-mtp/worldscope/forks","keys_url":"https://api.github.com/repos/nus-mtp/worldscope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-mtp/worldscope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-mtp/worldscope/teams","hooks_url":"https://api.github.com/repos/nus-mtp/worldscope/hooks","issue_events_url":"https://api.github.com/repos/nus-mtp/worldscope/issues/events{/number}","events_url":"https://api.github.com/repos/nus-mtp/worldscope/events","assignees_url":"https://api.github.com/repos/nus-mtp/worldscope/assignees{/user}","branches_url":"https://api.github.com/repos/nus-mtp/worldscope/branches{/branch}","tags_url":"https://api.github.com/repos/nus-mtp/worldscope/tags","blobs_url":"https://api.github.com/repos/nus-mtp/worldscope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-mtp/worldscope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-mtp/worldscope/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-mtp/worldscope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-mtp/worldscope/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-mtp/worldscope/languages","stargazers_url":"https://api.github.com/repos/nus-mtp/worldscope/stargazers","contributors_url":"https://api.github.com/repos/nus-mtp/worldscope/contributors","subscribers_url":"https://api.github.com/repos/nus-mtp/worldscope/subscribers","subscription_url":"https://api.github.com/repos/nus-mtp/worldscope/subscription","commits_url":"https://api.github.com/repos/nus-mtp/worldscope/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-mtp/worldscope/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-mtp/worldscope/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-mtp/worldscope/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-mtp/worldscope/contents/{+path}","compare_url":"https://api.github.com/repos/nus-mtp/worldscope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-mtp/worldscope/merges","archive_url":"https://api.github.com/repos/nus-mtp/worldscope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-mtp/worldscope/downloads","issues_url":"https://api.github.com/repos/nus-mtp/worldscope/issues{/number}","pulls_url":"https://api.github.com/repos/nus-mtp/worldscope/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-mtp/worldscope/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-mtp/worldscope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-mtp/worldscope/labels{/name}","releases_url":"https://api.github.com/repos/nus-mtp/worldscope/releases{/id}","deployments_url":"https://api.github.com/repos/nus-mtp/worldscope/deployments","created_at":"2015-08-28T12:20:34Z","updated_at":"2016-02-02T10:26:32Z","pushed_at":"2016-02-24T10:26:42Z","git_url":"git://github.com/nus-mtp/worldscope.git","ssh_url":"git@github.com:nus-mtp/worldscope.git","clone_url":"https://github.com/nus-mtp/worldscope.git","svn_url":"https://github.com/nus-mtp/worldscope","homepage":"","size":3833,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53"},"html":{"href":"https://github.com/nus-mtp/worldscope/pull/53"},"issue":{"href":"https://api.github.com/repos/nus-mtp/worldscope/issues/53"},"comments":{"href":"https://api.github.com/repos/nus-mtp/worldscope/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-mtp/worldscope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-mtp/worldscope/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/nus-mtp/worldscope/statuses/7a243f4251708e3219c59d8fb7436ec2dcaad858"}}}}