{"action":"created","comment":{"url":"https://api.github.com/repos/atom/bracket-matcher/pulls/comments/58019617","id":58019617,"diff_hunk":"@@ -24,6 +24,7 @@ class BracketMatcher\n     \"‹\": \"›\"\n \n   toggleQuotes: (includeSmartQuotes) ->\n+    return if @pairedCharacters? and includeSmartQuotes is (@pairedCharacters isnt @defaultPairs)","path":"lib/bracket-matcher.coffee","position":4,"original_position":4,"commit_id":"26d598d607bdfb899932b45f4b867820a53ba552","original_commit_id":"26d598d607bdfb899932b45f4b867820a53ba552","user":{"login":"deprint","id":7817714,"avatar_url":"https://avatars.githubusercontent.com/u/7817714?v=3","gravatar_id":"","url":"https://api.github.com/users/deprint","html_url":"https://github.com/deprint","followers_url":"https://api.github.com/users/deprint/followers","following_url":"https://api.github.com/users/deprint/following{/other_user}","gists_url":"https://api.github.com/users/deprint/gists{/gist_id}","starred_url":"https://api.github.com/users/deprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deprint/subscriptions","organizations_url":"https://api.github.com/users/deprint/orgs","repos_url":"https://api.github.com/users/deprint/repos","events_url":"https://api.github.com/users/deprint/events{/privacy}","received_events_url":"https://api.github.com/users/deprint/received_events","type":"User","site_admin":false},"body":"For full scope support, this line ensures that we don't update `pairedCharacters` in every `toggleQuotes` call (only when the config value and/or scope changes).","created_at":"2016-03-31T08:52:38Z","updated_at":"2016-03-31T08:52:38Z","html_url":"https://github.com/atom/bracket-matcher/pull/223#discussion_r58019617","pull_request_url":"https://api.github.com/repos/atom/bracket-matcher/pulls/223","_links":{"self":{"href":"https://api.github.com/repos/atom/bracket-matcher/pulls/comments/58019617"},"html":{"href":"https://github.com/atom/bracket-matcher/pull/223#discussion_r58019617"},"pull_request":{"href":"https://api.github.com/repos/atom/bracket-matcher/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/atom/bracket-matcher/pulls/223","id":64157171,"html_url":"https://github.com/atom/bracket-matcher/pull/223","diff_url":"https://github.com/atom/bracket-matcher/pull/223.diff","patch_url":"https://github.com/atom/bracket-matcher/pull/223.patch","issue_url":"https://api.github.com/repos/atom/bracket-matcher/issues/223","number":223,"state":"open","locked":false,"title":"Allow scoped settings","user":{"login":"deprint","id":7817714,"avatar_url":"https://avatars.githubusercontent.com/u/7817714?v=3","gravatar_id":"","url":"https://api.github.com/users/deprint","html_url":"https://github.com/deprint","followers_url":"https://api.github.com/users/deprint/followers","following_url":"https://api.github.com/users/deprint/following{/other_user}","gists_url":"https://api.github.com/users/deprint/gists{/gist_id}","starred_url":"https://api.github.com/users/deprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deprint/subscriptions","organizations_url":"https://api.github.com/users/deprint/orgs","repos_url":"https://api.github.com/users/deprint/repos","events_url":"https://api.github.com/users/deprint/events{/privacy}","received_events_url":"https://api.github.com/users/deprint/received_events","type":"User","site_admin":false},"body":"With scoped settings users are able to change bracket-matcher depending on the currently used scope:\r\n\r\n```coffee\r\n\".lisp.source\":\r\n  \"bracket-matcher\":\r\n    autocompleteBrackets: false\r\n  editor:\r\n    autoIndent: false\r\n```\r\n\r\nThis is useful for languages like Lisp, that don't use `` ` `` and other characters for quotes.\r\n\r\nIt also fixes an (as far as I know) unreported bug where a scoped `editor.autoIndent` setting would be ignored.\r\n\r\nConsider this a first step towards #182.","created_at":"2016-03-25T12:15:27Z","updated_at":"2016-03-31T08:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc27eb015423e0de4c5ff0a96fe92431c3cc34ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/bracket-matcher/pulls/223/commits","review_comments_url":"https://api.github.com/repos/atom/bracket-matcher/pulls/223/comments","review_comment_url":"https://api.github.com/repos/atom/bracket-matcher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/bracket-matcher/issues/223/comments","statuses_url":"https://api.github.com/repos/atom/bracket-matcher/statuses/26d598d607bdfb899932b45f4b867820a53ba552","head":{"label":"deprint:scoped-settings","ref":"scoped-settings","sha":"26d598d607bdfb899932b45f4b867820a53ba552","user":{"login":"deprint","id":7817714,"avatar_url":"https://avatars.githubusercontent.com/u/7817714?v=3","gravatar_id":"","url":"https://api.github.com/users/deprint","html_url":"https://github.com/deprint","followers_url":"https://api.github.com/users/deprint/followers","following_url":"https://api.github.com/users/deprint/following{/other_user}","gists_url":"https://api.github.com/users/deprint/gists{/gist_id}","starred_url":"https://api.github.com/users/deprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deprint/subscriptions","organizations_url":"https://api.github.com/users/deprint/orgs","repos_url":"https://api.github.com/users/deprint/repos","events_url":"https://api.github.com/users/deprint/events{/privacy}","received_events_url":"https://api.github.com/users/deprint/received_events","type":"User","site_admin":false},"repo":{"id":54637077,"name":"bracket-matcher","full_name":"deprint/bracket-matcher","owner":{"login":"deprint","id":7817714,"avatar_url":"https://avatars.githubusercontent.com/u/7817714?v=3","gravatar_id":"","url":"https://api.github.com/users/deprint","html_url":"https://github.com/deprint","followers_url":"https://api.github.com/users/deprint/followers","following_url":"https://api.github.com/users/deprint/following{/other_user}","gists_url":"https://api.github.com/users/deprint/gists{/gist_id}","starred_url":"https://api.github.com/users/deprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deprint/subscriptions","organizations_url":"https://api.github.com/users/deprint/orgs","repos_url":"https://api.github.com/users/deprint/repos","events_url":"https://api.github.com/users/deprint/events{/privacy}","received_events_url":"https://api.github.com/users/deprint/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deprint/bracket-matcher","description":"Jump to brackets","fork":true,"url":"https://api.github.com/repos/deprint/bracket-matcher","forks_url":"https://api.github.com/repos/deprint/bracket-matcher/forks","keys_url":"https://api.github.com/repos/deprint/bracket-matcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deprint/bracket-matcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deprint/bracket-matcher/teams","hooks_url":"https://api.github.com/repos/deprint/bracket-matcher/hooks","issue_events_url":"https://api.github.com/repos/deprint/bracket-matcher/issues/events{/number}","events_url":"https://api.github.com/repos/deprint/bracket-matcher/events","assignees_url":"https://api.github.com/repos/deprint/bracket-matcher/assignees{/user}","branches_url":"https://api.github.com/repos/deprint/bracket-matcher/branches{/branch}","tags_url":"https://api.github.com/repos/deprint/bracket-matcher/tags","blobs_url":"https://api.github.com/repos/deprint/bracket-matcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deprint/bracket-matcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deprint/bracket-matcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/deprint/bracket-matcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deprint/bracket-matcher/statuses/{sha}","languages_url":"https://api.github.com/repos/deprint/bracket-matcher/languages","stargazers_url":"https://api.github.com/repos/deprint/bracket-matcher/stargazers","contributors_url":"https://api.github.com/repos/deprint/bracket-matcher/contributors","subscribers_url":"https://api.github.com/repos/deprint/bracket-matcher/subscribers","subscription_url":"https://api.github.com/repos/deprint/bracket-matcher/subscription","commits_url":"https://api.github.com/repos/deprint/bracket-matcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/deprint/bracket-matcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/deprint/bracket-matcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/deprint/bracket-matcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/deprint/bracket-matcher/contents/{+path}","compare_url":"https://api.github.com/repos/deprint/bracket-matcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deprint/bracket-matcher/merges","archive_url":"https://api.github.com/repos/deprint/bracket-matcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deprint/bracket-matcher/downloads","issues_url":"https://api.github.com/repos/deprint/bracket-matcher/issues{/number}","pulls_url":"https://api.github.com/repos/deprint/bracket-matcher/pulls{/number}","milestones_url":"https://api.github.com/repos/deprint/bracket-matcher/milestones{/number}","notifications_url":"https://api.github.com/repos/deprint/bracket-matcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deprint/bracket-matcher/labels{/name}","releases_url":"https://api.github.com/repos/deprint/bracket-matcher/releases{/id}","deployments_url":"https://api.github.com/repos/deprint/bracket-matcher/deployments","created_at":"2016-03-24T11:31:07Z","updated_at":"2016-03-24T11:31:08Z","pushed_at":"2016-03-25T11:43:43Z","git_url":"git://github.com/deprint/bracket-matcher.git","ssh_url":"git@github.com:deprint/bracket-matcher.git","clone_url":"https://github.com/deprint/bracket-matcher.git","svn_url":"https://github.com/deprint/bracket-matcher","homepage":null,"size":301,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"f55f6606dd915686b66db4948f13f080ac65dc31","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":12088141,"name":"bracket-matcher","full_name":"atom/bracket-matcher","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/bracket-matcher","description":"Jump to brackets","fork":false,"url":"https://api.github.com/repos/atom/bracket-matcher","forks_url":"https://api.github.com/repos/atom/bracket-matcher/forks","keys_url":"https://api.github.com/repos/atom/bracket-matcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/bracket-matcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/bracket-matcher/teams","hooks_url":"https://api.github.com/repos/atom/bracket-matcher/hooks","issue_events_url":"https://api.github.com/repos/atom/bracket-matcher/issues/events{/number}","events_url":"https://api.github.com/repos/atom/bracket-matcher/events","assignees_url":"https://api.github.com/repos/atom/bracket-matcher/assignees{/user}","branches_url":"https://api.github.com/repos/atom/bracket-matcher/branches{/branch}","tags_url":"https://api.github.com/repos/atom/bracket-matcher/tags","blobs_url":"https://api.github.com/repos/atom/bracket-matcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/bracket-matcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/bracket-matcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/bracket-matcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/bracket-matcher/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/bracket-matcher/languages","stargazers_url":"https://api.github.com/repos/atom/bracket-matcher/stargazers","contributors_url":"https://api.github.com/repos/atom/bracket-matcher/contributors","subscribers_url":"https://api.github.com/repos/atom/bracket-matcher/subscribers","subscription_url":"https://api.github.com/repos/atom/bracket-matcher/subscription","commits_url":"https://api.github.com/repos/atom/bracket-matcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/bracket-matcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/bracket-matcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/bracket-matcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/bracket-matcher/contents/{+path}","compare_url":"https://api.github.com/repos/atom/bracket-matcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/bracket-matcher/merges","archive_url":"https://api.github.com/repos/atom/bracket-matcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/bracket-matcher/downloads","issues_url":"https://api.github.com/repos/atom/bracket-matcher/issues{/number}","pulls_url":"https://api.github.com/repos/atom/bracket-matcher/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/bracket-matcher/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/bracket-matcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/bracket-matcher/labels{/name}","releases_url":"https://api.github.com/repos/atom/bracket-matcher/releases{/id}","deployments_url":"https://api.github.com/repos/atom/bracket-matcher/deployments","created_at":"2013-08-13T17:34:31Z","updated_at":"2016-03-13T21:36:52Z","pushed_at":"2016-03-25T12:15:27Z","git_url":"git://github.com/atom/bracket-matcher.git","ssh_url":"git@github.com:atom/bracket-matcher.git","clone_url":"https://github.com/atom/bracket-matcher.git","svn_url":"https://github.com/atom/bracket-matcher","homepage":null,"size":525,"stargazers_count":65,"watchers_count":65,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":97,"forks":68,"open_issues":97,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/bracket-matcher/pulls/223"},"html":{"href":"https://github.com/atom/bracket-matcher/pull/223"},"issue":{"href":"https://api.github.com/repos/atom/bracket-matcher/issues/223"},"comments":{"href":"https://api.github.com/repos/atom/bracket-matcher/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/bracket-matcher/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/bracket-matcher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/bracket-matcher/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/atom/bracket-matcher/statuses/26d598d607bdfb899932b45f4b867820a53ba552"}}}}