{"action":"created","comment":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/comments/89943427","pull_request_review_id":10470838,"id":89943427,"diff_hunk":"@@ -200,28 +239,28 @@ ADIOI_BG_persInfo_init(ADIOI_BG_ConfInfo_t *conf,\n                   pers.Network_Config.cnBridge_E << 2;\n    ADIOI_Assert((bridgeCoords >= 0)); /* A dim is < 6 bits or sorting won't work */\n \n-   if((hw.Coords[0] == pers.Network_Config.cnBridge_A) && \n-      (hw.Coords[1] == pers.Network_Config.cnBridge_B) && \n-      (hw.Coords[2] == pers.Network_Config.cnBridge_C) && \n-      (hw.Coords[3] == pers.Network_Config.cnBridge_D) && \n-      (hw.Coords[4] == pers.Network_Config.cnBridge_E)) {\n+   if(( net->Acoord == pers.Network_Config.cnBridge_A) && ","path":"src/mpi/romio/adio/ad_gpfs/bg/ad_bg_pset.c","position":null,"original_position":160,"commit_id":"74b6dad4a7a36fb5e900abf1d1559db3186f5835","original_commit_id":"d93e7fab495f72c85726b97d27de97840517f592","user":{"login":"pkcoff","id":10079996,"avatar_url":"https://avatars.githubusercontent.com/u/10079996?v=3","gravatar_id":"","url":"https://api.github.com/users/pkcoff","html_url":"https://github.com/pkcoff","followers_url":"https://api.github.com/users/pkcoff/followers","following_url":"https://api.github.com/users/pkcoff/following{/other_user}","gists_url":"https://api.github.com/users/pkcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/pkcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkcoff/subscriptions","organizations_url":"https://api.github.com/users/pkcoff/orgs","repos_url":"https://api.github.com/users/pkcoff/repos","events_url":"https://api.github.com/users/pkcoff/events{/privacy}","received_events_url":"https://api.github.com/users/pkcoff/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2016-11-29T05:28:59Z","updated_at":"2016-11-29T05:28:59Z","html_url":"https://github.com/pmodels/mpich/pull/2440#discussion_r89943427","pull_request_url":"https://api.github.com/repos/pmodels/mpich/pulls/2440","_links":{"self":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/comments/89943427"},"html":{"href":"https://github.com/pmodels/mpich/pull/2440#discussion_r89943427"},"pull_request":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/2440"}}},"pull_request":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/2440","id":94751549,"html_url":"https://github.com/pmodels/mpich/pull/2440","diff_url":"https://github.com/pmodels/mpich/pull/2440.diff","patch_url":"https://github.com/pmodels/mpich/pull/2440.patch","issue_url":"https://api.github.com/repos/pmodels/mpich/issues/2440","number":2440,"state":"open","locked":false,"title":"Bgq romio ch4 enablement","user":{"login":"pkcoff","id":10079996,"avatar_url":"https://avatars.githubusercontent.com/u/10079996?v=3","gravatar_id":"","url":"https://api.github.com/users/pkcoff","html_url":"https://github.com/pkcoff","followers_url":"https://api.github.com/users/pkcoff/followers","following_url":"https://api.github.com/users/pkcoff/following{/other_user}","gists_url":"https://api.github.com/users/pkcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/pkcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkcoff/subscriptions","organizations_url":"https://api.github.com/users/pkcoff/orgs","repos_url":"https://api.github.com/users/pkcoff/repos","events_url":"https://api.github.com/users/pkcoff/events{/privacy}","received_events_url":"https://api.github.com/users/pkcoff/received_events","type":"User","site_admin":false},"body":"There was pamid-specific (MPIX) code in the BGQ ROMIO files that needed to be replaced with SPI calls.  There were also some bugs in BGQ ROMIO exposed by running CH4 that needed to be fixed.\r\n","created_at":"2016-11-22T05:38:18Z","updated_at":"2016-11-29T05:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2f9481995d51152f7f5a44b22ea628669c0e086","assignee":{"login":"roblatham00","id":2278417,"avatar_url":"https://avatars.githubusercontent.com/u/2278417?v=3","gravatar_id":"","url":"https://api.github.com/users/roblatham00","html_url":"https://github.com/roblatham00","followers_url":"https://api.github.com/users/roblatham00/followers","following_url":"https://api.github.com/users/roblatham00/following{/other_user}","gists_url":"https://api.github.com/users/roblatham00/gists{/gist_id}","starred_url":"https://api.github.com/users/roblatham00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblatham00/subscriptions","organizations_url":"https://api.github.com/users/roblatham00/orgs","repos_url":"https://api.github.com/users/roblatham00/repos","events_url":"https://api.github.com/users/roblatham00/events{/privacy}","received_events_url":"https://api.github.com/users/roblatham00/received_events","type":"User","site_admin":false},"assignees":[{"login":"roblatham00","id":2278417,"avatar_url":"https://avatars.githubusercontent.com/u/2278417?v=3","gravatar_id":"","url":"https://api.github.com/users/roblatham00","html_url":"https://github.com/roblatham00","followers_url":"https://api.github.com/users/roblatham00/followers","following_url":"https://api.github.com/users/roblatham00/following{/other_user}","gists_url":"https://api.github.com/users/roblatham00/gists{/gist_id}","starred_url":"https://api.github.com/users/roblatham00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblatham00/subscriptions","organizations_url":"https://api.github.com/users/roblatham00/orgs","repos_url":"https://api.github.com/users/roblatham00/repos","events_url":"https://api.github.com/users/roblatham00/events{/privacy}","received_events_url":"https://api.github.com/users/roblatham00/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pmodels/mpich/pulls/2440/commits","review_comments_url":"https://api.github.com/repos/pmodels/mpich/pulls/2440/comments","review_comment_url":"https://api.github.com/repos/pmodels/mpich/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmodels/mpich/issues/2440/comments","statuses_url":"https://api.github.com/repos/pmodels/mpich/statuses/74b6dad4a7a36fb5e900abf1d1559db3186f5835","head":{"label":"pkcoff:bgq-romio-ch4-enablement","ref":"bgq-romio-ch4-enablement","sha":"74b6dad4a7a36fb5e900abf1d1559db3186f5835","user":{"login":"pkcoff","id":10079996,"avatar_url":"https://avatars.githubusercontent.com/u/10079996?v=3","gravatar_id":"","url":"https://api.github.com/users/pkcoff","html_url":"https://github.com/pkcoff","followers_url":"https://api.github.com/users/pkcoff/followers","following_url":"https://api.github.com/users/pkcoff/following{/other_user}","gists_url":"https://api.github.com/users/pkcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/pkcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkcoff/subscriptions","organizations_url":"https://api.github.com/users/pkcoff/orgs","repos_url":"https://api.github.com/users/pkcoff/repos","events_url":"https://api.github.com/users/pkcoff/events{/privacy}","received_events_url":"https://api.github.com/users/pkcoff/received_events","type":"User","site_admin":false},"repo":{"id":72472908,"name":"mpich","full_name":"pkcoff/mpich","owner":{"login":"pkcoff","id":10079996,"avatar_url":"https://avatars.githubusercontent.com/u/10079996?v=3","gravatar_id":"","url":"https://api.github.com/users/pkcoff","html_url":"https://github.com/pkcoff","followers_url":"https://api.github.com/users/pkcoff/followers","following_url":"https://api.github.com/users/pkcoff/following{/other_user}","gists_url":"https://api.github.com/users/pkcoff/gists{/gist_id}","starred_url":"https://api.github.com/users/pkcoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkcoff/subscriptions","organizations_url":"https://api.github.com/users/pkcoff/orgs","repos_url":"https://api.github.com/users/pkcoff/repos","events_url":"https://api.github.com/users/pkcoff/events{/privacy}","received_events_url":"https://api.github.com/users/pkcoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkcoff/mpich","description":"Official MPICH Repository","fork":true,"url":"https://api.github.com/repos/pkcoff/mpich","forks_url":"https://api.github.com/repos/pkcoff/mpich/forks","keys_url":"https://api.github.com/repos/pkcoff/mpich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkcoff/mpich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkcoff/mpich/teams","hooks_url":"https://api.github.com/repos/pkcoff/mpich/hooks","issue_events_url":"https://api.github.com/repos/pkcoff/mpich/issues/events{/number}","events_url":"https://api.github.com/repos/pkcoff/mpich/events","assignees_url":"https://api.github.com/repos/pkcoff/mpich/assignees{/user}","branches_url":"https://api.github.com/repos/pkcoff/mpich/branches{/branch}","tags_url":"https://api.github.com/repos/pkcoff/mpich/tags","blobs_url":"https://api.github.com/repos/pkcoff/mpich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkcoff/mpich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkcoff/mpich/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkcoff/mpich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkcoff/mpich/statuses/{sha}","languages_url":"https://api.github.com/repos/pkcoff/mpich/languages","stargazers_url":"https://api.github.com/repos/pkcoff/mpich/stargazers","contributors_url":"https://api.github.com/repos/pkcoff/mpich/contributors","subscribers_url":"https://api.github.com/repos/pkcoff/mpich/subscribers","subscription_url":"https://api.github.com/repos/pkcoff/mpich/subscription","commits_url":"https://api.github.com/repos/pkcoff/mpich/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkcoff/mpich/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkcoff/mpich/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkcoff/mpich/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkcoff/mpich/contents/{+path}","compare_url":"https://api.github.com/repos/pkcoff/mpich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkcoff/mpich/merges","archive_url":"https://api.github.com/repos/pkcoff/mpich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkcoff/mpich/downloads","issues_url":"https://api.github.com/repos/pkcoff/mpich/issues{/number}","pulls_url":"https://api.github.com/repos/pkcoff/mpich/pulls{/number}","milestones_url":"https://api.github.com/repos/pkcoff/mpich/milestones{/number}","notifications_url":"https://api.github.com/repos/pkcoff/mpich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkcoff/mpich/labels{/name}","releases_url":"https://api.github.com/repos/pkcoff/mpich/releases{/id}","deployments_url":"https://api.github.com/repos/pkcoff/mpich/deployments","created_at":"2016-10-31T19:57:38Z","updated_at":"2016-10-31T19:57:58Z","pushed_at":"2016-11-29T05:28:24Z","git_url":"git://github.com/pkcoff/mpich.git","ssh_url":"git@github.com:pkcoff/mpich.git","clone_url":"https://github.com/pkcoff/mpich.git","svn_url":"https://github.com/pkcoff/mpich","homepage":"http://www.mpich.org","size":49394,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmodels:master","ref":"master","sha":"ccd12b60ba3f90a660e99cf6c76b36bb83408a42","user":{"login":"pmodels","id":15700567,"avatar_url":"https://avatars.githubusercontent.com/u/15700567?v=3","gravatar_id":"","url":"https://api.github.com/users/pmodels","html_url":"https://github.com/pmodels","followers_url":"https://api.github.com/users/pmodels/followers","following_url":"https://api.github.com/users/pmodels/following{/other_user}","gists_url":"https://api.github.com/users/pmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/pmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmodels/subscriptions","organizations_url":"https://api.github.com/users/pmodels/orgs","repos_url":"https://api.github.com/users/pmodels/repos","events_url":"https://api.github.com/users/pmodels/events{/privacy}","received_events_url":"https://api.github.com/users/pmodels/received_events","type":"Organization","site_admin":false},"repo":{"id":70918679,"name":"mpich","full_name":"pmodels/mpich","owner":{"login":"pmodels","id":15700567,"avatar_url":"https://avatars.githubusercontent.com/u/15700567?v=3","gravatar_id":"","url":"https://api.github.com/users/pmodels","html_url":"https://github.com/pmodels","followers_url":"https://api.github.com/users/pmodels/followers","following_url":"https://api.github.com/users/pmodels/following{/other_user}","gists_url":"https://api.github.com/users/pmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/pmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmodels/subscriptions","organizations_url":"https://api.github.com/users/pmodels/orgs","repos_url":"https://api.github.com/users/pmodels/repos","events_url":"https://api.github.com/users/pmodels/events{/privacy}","received_events_url":"https://api.github.com/users/pmodels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmodels/mpich","description":"Official MPICH Repository","fork":false,"url":"https://api.github.com/repos/pmodels/mpich","forks_url":"https://api.github.com/repos/pmodels/mpich/forks","keys_url":"https://api.github.com/repos/pmodels/mpich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmodels/mpich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmodels/mpich/teams","hooks_url":"https://api.github.com/repos/pmodels/mpich/hooks","issue_events_url":"https://api.github.com/repos/pmodels/mpich/issues/events{/number}","events_url":"https://api.github.com/repos/pmodels/mpich/events","assignees_url":"https://api.github.com/repos/pmodels/mpich/assignees{/user}","branches_url":"https://api.github.com/repos/pmodels/mpich/branches{/branch}","tags_url":"https://api.github.com/repos/pmodels/mpich/tags","blobs_url":"https://api.github.com/repos/pmodels/mpich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmodels/mpich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmodels/mpich/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmodels/mpich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmodels/mpich/statuses/{sha}","languages_url":"https://api.github.com/repos/pmodels/mpich/languages","stargazers_url":"https://api.github.com/repos/pmodels/mpich/stargazers","contributors_url":"https://api.github.com/repos/pmodels/mpich/contributors","subscribers_url":"https://api.github.com/repos/pmodels/mpich/subscribers","subscription_url":"https://api.github.com/repos/pmodels/mpich/subscription","commits_url":"https://api.github.com/repos/pmodels/mpich/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmodels/mpich/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmodels/mpich/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmodels/mpich/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmodels/mpich/contents/{+path}","compare_url":"https://api.github.com/repos/pmodels/mpich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmodels/mpich/merges","archive_url":"https://api.github.com/repos/pmodels/mpich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmodels/mpich/downloads","issues_url":"https://api.github.com/repos/pmodels/mpich/issues{/number}","pulls_url":"https://api.github.com/repos/pmodels/mpich/pulls{/number}","milestones_url":"https://api.github.com/repos/pmodels/mpich/milestones{/number}","notifications_url":"https://api.github.com/repos/pmodels/mpich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmodels/mpich/labels{/name}","releases_url":"https://api.github.com/repos/pmodels/mpich/releases{/id}","deployments_url":"https://api.github.com/repos/pmodels/mpich/deployments","created_at":"2016-10-14T14:39:42Z","updated_at":"2016-11-22T14:44:09Z","pushed_at":"2016-11-29T05:28:25Z","git_url":"git://github.com/pmodels/mpich.git","ssh_url":"git@github.com:pmodels/mpich.git","clone_url":"https://github.com/pmodels/mpich.git","svn_url":"https://github.com/pmodels/mpich","homepage":"http://www.mpich.org","size":50442,"stargazers_count":26,"watchers_count":26,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":334,"forks":18,"open_issues":334,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/2440"},"html":{"href":"https://github.com/pmodels/mpich/pull/2440"},"issue":{"href":"https://api.github.com/repos/pmodels/mpich/issues/2440"},"comments":{"href":"https://api.github.com/repos/pmodels/mpich/issues/2440/comments"},"review_comments":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/2440/comments"},"review_comment":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/2440/commits"},"statuses":{"href":"https://api.github.com/repos/pmodels/mpich/statuses/74b6dad4a7a36fb5e900abf1d1559db3186f5835"}}}}
{"actor":{"display_login":"pkcoff"}}