{"action":"created","issue":{"url":"https://api.github.com/repos/xapi-project/sm/issues/299","repository_url":"https://api.github.com/repos/xapi-project/sm","labels_url":"https://api.github.com/repos/xapi-project/sm/issues/299/labels{/name}","comments_url":"https://api.github.com/repos/xapi-project/sm/issues/299/comments","events_url":"https://api.github.com/repos/xapi-project/sm/issues/299/events","html_url":"https://github.com/xapi-project/sm/pull/299","id":131400354,"number":299,"title":"CP-6096: Extract out raw iscsi SR","user":{"login":"BobBall","id":1170329,"avatar_url":"https://avatars.githubusercontent.com/u/1170329?v=3","gravatar_id":"","url":"https://api.github.com/users/BobBall","html_url":"https://github.com/BobBall","followers_url":"https://api.github.com/users/BobBall/followers","following_url":"https://api.github.com/users/BobBall/following{/other_user}","gists_url":"https://api.github.com/users/BobBall/gists{/gist_id}","starred_url":"https://api.github.com/users/BobBall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BobBall/subscriptions","organizations_url":"https://api.github.com/users/BobBall/orgs","repos_url":"https://api.github.com/users/BobBall/repos","events_url":"https://api.github.com/users/BobBall/events{/privacy}","received_events_url":"https://api.github.com/users/BobBall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-04T16:27:29Z","updated_at":"2016-04-07T10:55:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xapi-project/sm/pulls/299","html_url":"https://github.com/xapi-project/sm/pull/299","diff_url":"https://github.com/xapi-project/sm/pull/299.diff","patch_url":"https://github.com/xapi-project/sm/pull/299.patch"},"body":"The existing 'iscsi' SR type functionally works very well, however ISCSISR a base class for LVHDoISCSI and OCFSoISCSI SRs, therefore it would be risky to claim support for raw ISCSI connections in OpenStack, since some issues may not be fixable without causing complications for the existing supported SR types.\r\n\r\nThis patch series creates a new leaf SR type for 'iscsi' by moving the existing SR type to a new base class"},"comment":{"url":"https://api.github.com/repos/xapi-project/sm/issues/comments/206810556","html_url":"https://github.com/xapi-project/sm/pull/299#issuecomment-206810556","issue_url":"https://api.github.com/repos/xapi-project/sm/issues/299","id":206810556,"user":{"login":"germanop","id":3437428,"avatar_url":"https://avatars.githubusercontent.com/u/3437428?v=3","gravatar_id":"","url":"https://api.github.com/users/germanop","html_url":"https://github.com/germanop","followers_url":"https://api.github.com/users/germanop/followers","following_url":"https://api.github.com/users/germanop/following{/other_user}","gists_url":"https://api.github.com/users/germanop/gists{/gist_id}","starred_url":"https://api.github.com/users/germanop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanop/subscriptions","organizations_url":"https://api.github.com/users/germanop/orgs","repos_url":"https://api.github.com/users/germanop/repos","events_url":"https://api.github.com/users/germanop/events{/privacy}","received_events_url":"https://api.github.com/users/germanop/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T10:55:15Z","updated_at":"2016-04-07T10:55:15Z","body":"In your second commit you did rename ISCSISR.py to ISCSI_base.py but, in the same commit, you immediately created a new, almost empty, ISCSISR.py\r\n\r\nThat does not work well when git tries to understand renames.."}}