{"action":"created","issue":{"url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/402","repository_url":"https://api.github.com/repos/OrchardCMS/Orchard2","labels_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/402/labels{/name}","comments_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/402/comments","events_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/402/events","html_url":"https://github.com/OrchardCMS/Orchard2/pull/402","id":194778748,"number":402,"title":"Fixes #398 - hooking up two expanders","user":{"login":"Jetski5822","id":619530,"avatar_url":"https://avatars.githubusercontent.com/u/619530?v=3","gravatar_id":"","url":"https://api.github.com/users/Jetski5822","html_url":"https://github.com/Jetski5822","followers_url":"https://api.github.com/users/Jetski5822/followers","following_url":"https://api.github.com/users/Jetski5822/following{/other_user}","gists_url":"https://api.github.com/users/Jetski5822/gists{/gist_id}","starred_url":"https://api.github.com/users/Jetski5822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jetski5822/subscriptions","organizations_url":"https://api.github.com/users/Jetski5822/orgs","repos_url":"https://api.github.com/users/Jetski5822/repos","events_url":"https://api.github.com/users/Jetski5822/events{/privacy}","received_events_url":"https://api.github.com/users/Jetski5822/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2016-12-10T16:51:29Z","updated_at":"2016-12-15T00:39:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/Orchard2/pulls/402","html_url":"https://github.com/OrchardCMS/Orchard2/pull/402","diff_url":"https://github.com/OrchardCMS/Orchard2/pull/402.diff","patch_url":"https://github.com/OrchardCMS/Orchard2/pull/402.patch"},"body":"@jtkech what do you think?"},"comment":{"url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/comments/267201801","html_url":"https://github.com/OrchardCMS/Orchard2/pull/402#issuecomment-267201801","issue_url":"https://api.github.com/repos/OrchardCMS/Orchard2/issues/402","id":267201801,"user":{"login":"jtkech","id":8586360,"avatar_url":"https://avatars.githubusercontent.com/u/8586360?v=3","gravatar_id":"","url":"https://api.github.com/users/jtkech","html_url":"https://github.com/jtkech","followers_url":"https://api.github.com/users/jtkech/followers","following_url":"https://api.github.com/users/jtkech/following{/other_user}","gists_url":"https://api.github.com/users/jtkech/gists{/gist_id}","starred_url":"https://api.github.com/users/jtkech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtkech/subscriptions","organizations_url":"https://api.github.com/users/jtkech/orgs","repos_url":"https://api.github.com/users/jtkech/repos","events_url":"https://api.github.com/users/jtkech/events{/privacy}","received_events_url":"https://api.github.com/users/jtkech/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T00:39:02Z","updated_at":"2016-12-15T00:39:02Z","body":"\r\nNot so easy to return back to this after other works.\r\n\r\nSo, as said in my previous comment, because now we can create a new admin theme we can select, not sure it' worth to use an admin view expander to allow a non admin theme to override admin views.\r\n\r\nThat's said i just tried to override an admin controller view (could be a component view) without having to create a new admin theme (based or not on TheAdmin), just by using the following view in TheTheme.\r\n\r\n    /Orchard2/src/Orchard.Cms.Web/Themes/TheTheme/Views/Orchard.Admin/Admin/Index.cshtml\r\n\r\nThen, by using the admin view locations expander i got the following (see below). What's your feeling?\r\n\r\n- **So, do you think it's worth to keep the admin view expander?**\r\n- If so, i would like to know if we really need to use a \"Shell\" context value (not only the \"Theme\" one). We need it if enabled themes could be different per tenant.\r\n\r\nI ask this because it seems that right now themes are installed / enabled through the setup recipe, then we can't enable / disable them, we can just select them. But maybe there is a missing ThemeService, or it is intended to use the ModuleService to enable / disable themes as modules, i don't know.\r\n\r\n![admin expander](https://cloud.githubusercontent.com/assets/8586360/21206378/dd8b9d1a-c261-11e6-9900-359c3cf16865.png)\r\n\r\nBest."}}
{"actor":{"display_login":"jtkech"}}