{"action":"created","issue":{"url":"https://api.github.com/repos/cakephp/app/issues/383","repository_url":"https://api.github.com/repos/cakephp/app","labels_url":"https://api.github.com/repos/cakephp/app/issues/383/labels{/name}","comments_url":"https://api.github.com/repos/cakephp/app/issues/383/comments","events_url":"https://api.github.com/repos/cakephp/app/issues/383/events","html_url":"https://github.com/cakephp/app/issues/383","id":153566891,"number":383,"title":"Session table to use char(40) instead of varchar(40)","user":{"login":"thinkingmedia","id":551022,"avatar_url":"https://avatars.githubusercontent.com/u/551022?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkingmedia","html_url":"https://github.com/thinkingmedia","followers_url":"https://api.github.com/users/thinkingmedia/followers","following_url":"https://api.github.com/users/thinkingmedia/following{/other_user}","gists_url":"https://api.github.com/users/thinkingmedia/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkingmedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkingmedia/subscriptions","organizations_url":"https://api.github.com/users/thinkingmedia/orgs","repos_url":"https://api.github.com/users/thinkingmedia/repos","events_url":"https://api.github.com/users/thinkingmedia/events{/privacy}","received_events_url":"https://api.github.com/users/thinkingmedia/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cakephp/app/labels/Enhancement","name":"Enhancement","color":"bfe5bf"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cakephp/app/milestones/12","html_url":"https://github.com/cakephp/app/milestones/3.2.7","labels_url":"https://api.github.com/repos/cakephp/app/milestones/12/labels","id":1739538,"number":12,"title":"3.2.7","description":"Bugfixes and minor improvements.","creator":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":3,"state":"open","created_at":"2016-04-30T02:41:51Z","updated_at":"2016-05-07T04:24:53Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-05-07T01:59:50Z","updated_at":"2016-05-07T04:24:53Z","closed_at":"2016-05-07T04:24:53Z","body":"I think the `sessions.sql` file has been around for several years now, but today I noticed that it was using `varchar(40)` as the primary key.\r\n\r\nMySQL (not sure about other DBs) will allow you to use `varchar` as a primary key column, but there are a number of references that say performance can be poor. This of course is relative to the number of rows in the table.\r\n\r\nStill, I think this should be changed to just `char(40)` since this column holds the hash key for the session ID and it's length doesn't vary.\r\n\r\nCan anyone think of a reason why this would break anything by changing it?"},"comment":{"url":"https://api.github.com/repos/cakephp/app/issues/comments/217605790","html_url":"https://github.com/cakephp/app/issues/383#issuecomment-217605790","issue_url":"https://api.github.com/repos/cakephp/app/issues/383","id":217605790,"user":{"login":"markstory","id":24086,"avatar_url":"https://avatars.githubusercontent.com/u/24086?v=3","gravatar_id":"","url":"https://api.github.com/users/markstory","html_url":"https://github.com/markstory","followers_url":"https://api.github.com/users/markstory/followers","following_url":"https://api.github.com/users/markstory/following{/other_user}","gists_url":"https://api.github.com/users/markstory/gists{/gist_id}","starred_url":"https://api.github.com/users/markstory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstory/subscriptions","organizations_url":"https://api.github.com/users/markstory/orgs","repos_url":"https://api.github.com/users/markstory/repos","events_url":"https://api.github.com/users/markstory/events{/privacy}","received_events_url":"https://api.github.com/users/markstory/received_events","type":"User","site_admin":false},"created_at":"2016-05-07T04:24:53Z","updated_at":"2016-05-07T04:24:53Z","body":"Closing as a pull request is open now."}}