{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/78425666","id":78425666,"diff_hunk":"@@ -29,13 +29,34 @@ const YT_PLAYER_STATE_PLAYING = 1;\n \n class AmpYoutube extends AMP.BaseElement {\n \n-  /** @override */\n-  preconnectCallback(onLayout) {\n-    this.preconnect.url('https://www.youtube.com', onLayout);\n+  constructor() {","path":"extensions/amp-youtube/0.1/amp-youtube.js","position":16,"original_position":16,"commit_id":"132b9449ef8b29634332a571aee112bfdb84c05f","original_commit_id":"132b9449ef8b29634332a571aee112bfdb84c05f","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"and pass through to super","created_at":"2016-09-12T18:17:09Z","updated_at":"2016-09-12T18:17:09Z","html_url":"https://github.com/ampproject/amphtml/pull/4931#discussion_r78425666","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4931","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/78425666"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4931#discussion_r78425666"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4931"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/4931","id":84916657,"html_url":"https://github.com/ampproject/amphtml/pull/4931","diff_url":"https://github.com/ampproject/amphtml/pull/4931.diff","patch_url":"https://github.com/ampproject/amphtml/pull/4931.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/4931","number":4931,"state":"open","locked":false,"title":"Type check first extension (amp-youtube)","user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"body":"- Compiles together with main binary. While this may overlook some problems, it avoid unknown type warnings.\r\n- Adds a dedicated extern for `AMP.BaseElement`. This is needed to get the inheritance hierarchy correct and not get unknown type warnings for other compilation units.","created_at":"2016-09-12T18:04:38Z","updated_at":"2016-09-12T18:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6f37916c9888ab688a9d902bcccc6d8c74a978a","assignee":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"assignees":[{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars.githubusercontent.com/u/2099009?v=3","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4931/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/4931/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/4931/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/132b9449ef8b29634332a571aee112bfdb84c05f","head":{"label":"cramforce:types10","ref":"types10","sha":"132b9449ef8b29634332a571aee112bfdb84c05f","user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"repo":{"id":43817601,"name":"amphtml","full_name":"cramforce/amphtml","owner":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cramforce/amphtml","description":"","fork":true,"url":"https://api.github.com/repos/cramforce/amphtml","forks_url":"https://api.github.com/repos/cramforce/amphtml/forks","keys_url":"https://api.github.com/repos/cramforce/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cramforce/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cramforce/amphtml/teams","hooks_url":"https://api.github.com/repos/cramforce/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cramforce/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cramforce/amphtml/events","assignees_url":"https://api.github.com/repos/cramforce/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cramforce/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cramforce/amphtml/tags","blobs_url":"https://api.github.com/repos/cramforce/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cramforce/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cramforce/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cramforce/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cramforce/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cramforce/amphtml/languages","stargazers_url":"https://api.github.com/repos/cramforce/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cramforce/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cramforce/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cramforce/amphtml/subscription","commits_url":"https://api.github.com/repos/cramforce/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cramforce/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cramforce/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cramforce/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cramforce/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cramforce/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cramforce/amphtml/merges","archive_url":"https://api.github.com/repos/cramforce/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cramforce/amphtml/downloads","issues_url":"https://api.github.com/repos/cramforce/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cramforce/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cramforce/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cramforce/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cramforce/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cramforce/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cramforce/amphtml/deployments","created_at":"2015-10-07T13:28:45Z","updated_at":"2015-10-07T13:28:46Z","pushed_at":"2016-09-12T18:05:30Z","git_url":"git://github.com/cramforce/amphtml.git","ssh_url":"git@github.com:cramforce/amphtml.git","clone_url":"https://github.com/cramforce/amphtml.git","svn_url":"https://github.com/cramforce/amphtml","homepage":"","size":155484,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"656d83d852e2396d1e5462b6716d0b7a20dbd9f0","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-09-12T16:49:15Z","pushed_at":"2016-09-12T18:13:46Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":194448,"stargazers_count":8438,"watchers_count":8438,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1243,"mirror_url":null,"open_issues_count":730,"forks":1243,"open_issues":730,"watchers":8438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4931"},"html":{"href":"https://github.com/ampproject/amphtml/pull/4931"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4931"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/4931/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4931/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/4931/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/132b9449ef8b29634332a571aee112bfdb84c05f"}}}}
{"actor":{"display_login":"erwinmombay"}}