{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20513","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20513/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20513/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20513/events","html_url":"https://github.com/NixOS/nixpkgs/pull/20513","id":190231891,"number":20513,"title":"[wip] nodejs: Flag to disable building with openSSL","user":{"login":"spacekitteh","id":1940652,"avatar_url":"https://avatars.githubusercontent.com/u/1940652?v=3","gravatar_id":"","url":"https://api.github.com/users/spacekitteh","html_url":"https://github.com/spacekitteh","followers_url":"https://api.github.com/users/spacekitteh/followers","following_url":"https://api.github.com/users/spacekitteh/following{/other_user}","gists_url":"https://api.github.com/users/spacekitteh/gists{/gist_id}","starred_url":"https://api.github.com/users/spacekitteh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacekitteh/subscriptions","organizations_url":"https://api.github.com/users/spacekitteh/orgs","repos_url":"https://api.github.com/users/spacekitteh/repos","events_url":"https://api.github.com/users/spacekitteh/events{/privacy}","received_events_url":"https://api.github.com/users/spacekitteh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-18T04:08:31Z","updated_at":"2016-11-19T07:41:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/20513","html_url":"https://github.com/NixOS/nixpkgs/pull/20513","diff_url":"https://github.com/NixOS/nixpkgs/pull/20513.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/20513.patch"},"body":"###### Motivation for this change\r\nSome uses for nodejs are not web servers, such as being a build system (looking at you, cjdns). Thus it makes no sense to pull in OpenSSL in these cases. This creates a flag to build without SSL.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/261699465","html_url":"https://github.com/NixOS/nixpkgs/pull/20513#issuecomment-261699465","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/20513","id":261699465,"user":{"login":"gilligan","id":27668,"avatar_url":"https://avatars.githubusercontent.com/u/27668?v=3","gravatar_id":"","url":"https://api.github.com/users/gilligan","html_url":"https://github.com/gilligan","followers_url":"https://api.github.com/users/gilligan/followers","following_url":"https://api.github.com/users/gilligan/following{/other_user}","gists_url":"https://api.github.com/users/gilligan/gists{/gist_id}","starred_url":"https://api.github.com/users/gilligan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilligan/subscriptions","organizations_url":"https://api.github.com/users/gilligan/orgs","repos_url":"https://api.github.com/users/gilligan/repos","events_url":"https://api.github.com/users/gilligan/events{/privacy}","received_events_url":"https://api.github.com/users/gilligan/received_events","type":"User","site_admin":false},"created_at":"2016-11-19T07:41:56Z","updated_at":"2016-11-19T07:41:56Z","body":"Disabling npm has a huge benefit for whenever you are creating runtime production environments which will mostly just invoke some service via node directly. It reduces the closure size considerably.\r\n\r\nI do not see the same benefits with the ssl flag. I also do not think that anything that *can* be configured *should* also be configured."}}
{"actor":{"display_login":"gilligan"}}