{"action":"created","comment":{"url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/comments/65938683","id":65938683,"diff_hunk":"@@ -71,12 +96,57 @@ public function canAccessMultipleIdentifiers() {\n    */\n   public function getActiveFeatures() {\n \n-    $this->assertEquals( [ self::TEST_FEATURE ],                         $this->_gatekeeper->getActiveFeatures() );\n-    $this->assertEquals( [ self::TEST_FEATURE ],                         $this->_gatekeeper->getActiveFeatures( 4567 ) );\n-    $this->assertEquals( [ self::TEST_FEATURE, self::PER_USER_FEATURE ], $this->_gatekeeper->getActiveFeatures( 123 ) );\n-    $this->assertEquals( [ self::TEST_FEATURE, self::PER_USER_FEATURE ], $this->_gatekeeper->getActiveFeatures( [ 123 ] ) );\n-    $this->assertEquals( [ self::TEST_FEATURE, self::PER_USER_FEATURE ], $this->_gatekeeper->getActiveFeatures( [ 111, 456 ] ) );\n+    $this->assertEquals( [ self::TEST_FEATURE ],                                                   $this->_gatekeeper->getActiveFeatures() );\n+    $this->assertEquals( [ self::TEST_FEATURE ],                                                   $this->_gatekeeper->getActiveFeatures( 4567 ) );\n+    $this->assertEquals( [ self::TEST_FEATURE, self::PER_USER_FEATURE ],                           $this->_gatekeeper->getActiveFeatures( 123 ) );\n+    $this->assertEquals( [ self::TEST_FEATURE, self::PER_USER_FEATURE ],                           $this->_gatekeeper->getActiveFeatures( [ 123 ] ) );\n+    $this->assertEquals(\n+        [ self::TEST_FEATURE, self::PER_USER_FEATURE, self::PERCENTAGE_FEATURE, self::COMPLEX_PERCENTAGE_FEATURE ],\n+        $this->_gatekeeper->getActiveFeatures( [ 111, 456 ] )\n+    );\n \n   } // getActiveFeatures\n \n+  /**\n+   * @test\n+   */\n+  public function getPercentageFeaturesByActiveState() {\n+\n+    $this->assertEquals(\n+        [ self::PERCENTAGE_FEATURE => false, self::COMPLEX_PERCENTAGE_FEATURE => false ],\n+        $this->_gatekeeper->getPercentageFeaturesByActiveState()\n+    );\n+\n+    $this->assertEquals(\n+        [ self::PERCENTAGE_FEATURE => true, self::COMPLEX_PERCENTAGE_FEATURE => true ],\n+        $this->_gatekeeper->getPercentageFeaturesByActiveState( 111 )\n+    );\n+\n+    $this->assertEquals(\n+        [ self::PERCENTAGE_FEATURE => true, self::COMPLEX_PERCENTAGE_FEATURE => true ],\n+        $this->_gatekeeper->getPercentageFeaturesByActiveState( [ 111 ] )\n+    );\n+\n+    $this->assertEquals(\n+        [ self::PERCENTAGE_FEATURE => false, self::COMPLEX_PERCENTAGE_FEATURE => false ],\n+        $this->_gatekeeper->getPercentageFeaturesByActiveState( 222 )\n+    );\n+\n+    $this->assertEquals(\n+        [ self::PERCENTAGE_FEATURE => true, self::COMPLEX_PERCENTAGE_FEATURE => true ],\n+        $this->_gatekeeper->getPercentageFeaturesByActiveState( 555 )\n+    );\n+\n+    $this->assertEquals(\n+        [ self::PERCENTAGE_FEATURE => false, self::COMPLEX_PERCENTAGE_FEATURE => true ],\n+        $this->_gatekeeper->getPercentageFeaturesByActiveState( 321 )\n+    );\n+\n+    $this->assertEquals(\n+        [ self::PERCENTAGE_FEATURE => false, self::COMPLEX_PERCENTAGE_FEATURE => true ],\n+        $this->_gatekeeper->getPercentageFeaturesByActiveState( [ 333, 321 ] )\n+    );\n+\n+  } // getPercentageFeaturesByActiveState\n+","path":"tests/unit/GatekeeperTest.php","position":111,"original_position":111,"commit_id":"cee18dc1f43a46fd911c97d64d98551555d3e934","original_commit_id":"cee18dc1f43a46fd911c97d64d98551555d3e934","user":{"login":"DFoxinator","id":1854657,"avatar_url":"https://avatars.githubusercontent.com/u/1854657?v=3","gravatar_id":"","url":"https://api.github.com/users/DFoxinator","html_url":"https://github.com/DFoxinator","followers_url":"https://api.github.com/users/DFoxinator/followers","following_url":"https://api.github.com/users/DFoxinator/following{/other_user}","gists_url":"https://api.github.com/users/DFoxinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DFoxinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFoxinator/subscriptions","organizations_url":"https://api.github.com/users/DFoxinator/orgs","repos_url":"https://api.github.com/users/DFoxinator/repos","events_url":"https://api.github.com/users/DFoxinator/events{/privacy}","received_events_url":"https://api.github.com/users/DFoxinator/received_events","type":"User","site_admin":false},"body":"I'm still confused. What would the actual separation be, meaning what are the two method names for the separation? Test x and test what, what I'm saying is I don't understand because this test is testing getPercentageFeaturesByActiveState. Do you mean use a data provider?","created_at":"2016-06-06T18:06:31Z","updated_at":"2016-06-06T18:06:31Z","html_url":"https://github.com/behance/nbd.php-gatekeeper/pull/14#discussion_r65938683","pull_request_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/comments/65938683"},"html":{"href":"https://github.com/behance/nbd.php-gatekeeper/pull/14#discussion_r65938683"},"pull_request":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14","id":72746638,"html_url":"https://github.com/behance/nbd.php-gatekeeper/pull/14","diff_url":"https://github.com/behance/nbd.php-gatekeeper/pull/14.diff","patch_url":"https://github.com/behance/nbd.php-gatekeeper/pull/14.patch","issue_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/14","number":14,"state":"open","locked":false,"title":"Method: ability to get feature status by rule type","user":{"login":"DFoxinator","id":1854657,"avatar_url":"https://avatars.githubusercontent.com/u/1854657?v=3","gravatar_id":"","url":"https://api.github.com/users/DFoxinator","html_url":"https://github.com/DFoxinator","followers_url":"https://api.github.com/users/DFoxinator/followers","following_url":"https://api.github.com/users/DFoxinator/following{/other_user}","gists_url":"https://api.github.com/users/DFoxinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DFoxinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFoxinator/subscriptions","organizations_url":"https://api.github.com/users/DFoxinator/orgs","repos_url":"https://api.github.com/users/DFoxinator/repos","events_url":"https://api.github.com/users/DFoxinator/events{/privacy}","received_events_url":"https://api.github.com/users/DFoxinator/received_events","type":"User","site_admin":false},"body":"@be-dmitry \r\n@ingluisjimenez \r\n@amy ","created_at":"2016-06-06T17:27:15Z","updated_at":"2016-06-06T18:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a481baa657cf1aa20ad3479147b8f884d3eeb875","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14/commits","review_comments_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14/comments","review_comment_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/14/comments","statuses_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/statuses/cee18dc1f43a46fd911c97d64d98551555d3e934","head":{"label":"DFoxinator:get_percent_features","ref":"get_percent_features","sha":"cee18dc1f43a46fd911c97d64d98551555d3e934","user":{"login":"DFoxinator","id":1854657,"avatar_url":"https://avatars.githubusercontent.com/u/1854657?v=3","gravatar_id":"","url":"https://api.github.com/users/DFoxinator","html_url":"https://github.com/DFoxinator","followers_url":"https://api.github.com/users/DFoxinator/followers","following_url":"https://api.github.com/users/DFoxinator/following{/other_user}","gists_url":"https://api.github.com/users/DFoxinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DFoxinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFoxinator/subscriptions","organizations_url":"https://api.github.com/users/DFoxinator/orgs","repos_url":"https://api.github.com/users/DFoxinator/repos","events_url":"https://api.github.com/users/DFoxinator/events{/privacy}","received_events_url":"https://api.github.com/users/DFoxinator/received_events","type":"User","site_admin":false},"repo":{"id":59862528,"name":"nbd.php-gatekeeper","full_name":"DFoxinator/nbd.php-gatekeeper","owner":{"login":"DFoxinator","id":1854657,"avatar_url":"https://avatars.githubusercontent.com/u/1854657?v=3","gravatar_id":"","url":"https://api.github.com/users/DFoxinator","html_url":"https://github.com/DFoxinator","followers_url":"https://api.github.com/users/DFoxinator/followers","following_url":"https://api.github.com/users/DFoxinator/following{/other_user}","gists_url":"https://api.github.com/users/DFoxinator/gists{/gist_id}","starred_url":"https://api.github.com/users/DFoxinator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFoxinator/subscriptions","organizations_url":"https://api.github.com/users/DFoxinator/orgs","repos_url":"https://api.github.com/users/DFoxinator/repos","events_url":"https://api.github.com/users/DFoxinator/events{/privacy}","received_events_url":"https://api.github.com/users/DFoxinator/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DFoxinator/nbd.php-gatekeeper","description":"","fork":true,"url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper","forks_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/forks","keys_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/teams","hooks_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/hooks","issue_events_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/issues/events{/number}","events_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/events","assignees_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/assignees{/user}","branches_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/branches{/branch}","tags_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/tags","blobs_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/languages","stargazers_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/stargazers","contributors_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/contributors","subscribers_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/subscribers","subscription_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/subscription","commits_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/contents/{+path}","compare_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/merges","archive_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/downloads","issues_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/issues{/number}","pulls_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/labels{/name}","releases_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/releases{/id}","deployments_url":"https://api.github.com/repos/DFoxinator/nbd.php-gatekeeper/deployments","created_at":"2016-05-27T20:49:00Z","updated_at":"2016-05-27T20:49:02Z","pushed_at":"2016-06-06T17:38:27Z","git_url":"git://github.com/DFoxinator/nbd.php-gatekeeper.git","ssh_url":"git@github.com:DFoxinator/nbd.php-gatekeeper.git","clone_url":"https://github.com/DFoxinator/nbd.php-gatekeeper.git","svn_url":"https://github.com/DFoxinator/nbd.php-gatekeeper","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"behance:master","ref":"master","sha":"a8516bd5ef50c3d81eaebab59668df9cd8cb0472","user":{"login":"behance","id":1197743,"avatar_url":"https://avatars.githubusercontent.com/u/1197743?v=3","gravatar_id":"","url":"https://api.github.com/users/behance","html_url":"https://github.com/behance","followers_url":"https://api.github.com/users/behance/followers","following_url":"https://api.github.com/users/behance/following{/other_user}","gists_url":"https://api.github.com/users/behance/gists{/gist_id}","starred_url":"https://api.github.com/users/behance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behance/subscriptions","organizations_url":"https://api.github.com/users/behance/orgs","repos_url":"https://api.github.com/users/behance/repos","events_url":"https://api.github.com/users/behance/events{/privacy}","received_events_url":"https://api.github.com/users/behance/received_events","type":"Organization","site_admin":false},"repo":{"id":59605662,"name":"nbd.php-gatekeeper","full_name":"behance/nbd.php-gatekeeper","owner":{"login":"behance","id":1197743,"avatar_url":"https://avatars.githubusercontent.com/u/1197743?v=3","gravatar_id":"","url":"https://api.github.com/users/behance","html_url":"https://github.com/behance","followers_url":"https://api.github.com/users/behance/followers","following_url":"https://api.github.com/users/behance/following{/other_user}","gists_url":"https://api.github.com/users/behance/gists{/gist_id}","starred_url":"https://api.github.com/users/behance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behance/subscriptions","organizations_url":"https://api.github.com/users/behance/orgs","repos_url":"https://api.github.com/users/behance/repos","events_url":"https://api.github.com/users/behance/events{/privacy}","received_events_url":"https://api.github.com/users/behance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/behance/nbd.php-gatekeeper","description":"Provides functionality for controlling access to features with a variety of rules","fork":false,"url":"https://api.github.com/repos/behance/nbd.php-gatekeeper","forks_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/forks","keys_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/teams","hooks_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/hooks","issue_events_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/events{/number}","events_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/events","assignees_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/assignees{/user}","branches_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/branches{/branch}","tags_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/tags","blobs_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/languages","stargazers_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/stargazers","contributors_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/contributors","subscribers_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/subscribers","subscription_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/subscription","commits_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/contents/{+path}","compare_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/merges","archive_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/downloads","issues_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues{/number}","pulls_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/labels{/name}","releases_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/releases{/id}","deployments_url":"https://api.github.com/repos/behance/nbd.php-gatekeeper/deployments","created_at":"2016-05-24T20:18:05Z","updated_at":"2016-06-02T22:08:08Z","pushed_at":"2016-06-06T17:38:28Z","git_url":"git://github.com/behance/nbd.php-gatekeeper.git","ssh_url":"git@github.com:behance/nbd.php-gatekeeper.git","clone_url":"https://github.com/behance/nbd.php-gatekeeper.git","svn_url":"https://github.com/behance/nbd.php-gatekeeper","homepage":"","size":39,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14"},"html":{"href":"https://github.com/behance/nbd.php-gatekeeper/pull/14"},"issue":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/14"},"comments":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/behance/nbd.php-gatekeeper/statuses/cee18dc1f43a46fd911c97d64d98551555d3e934"}}}}
{"actor":{"display_login":"DFoxinator"}}