{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/19","id":84041064,"html_url":"https://github.com/PHPOffice/PhpSpreadsheet/pull/19","diff_url":"https://github.com/PHPOffice/PhpSpreadsheet/pull/19.diff","patch_url":"https://github.com/PHPOffice/PhpSpreadsheet/pull/19.patch","issue_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/issues/19","number":19,"state":"closed","locked":false,"title":"Don't truncate to 64k in mb_str_replace","user":{"login":"Synchro","id":81561,"avatar_url":"https://avatars.githubusercontent.com/u/81561?v=3","gravatar_id":"","url":"https://api.github.com/users/Synchro","html_url":"https://github.com/Synchro","followers_url":"https://api.github.com/users/Synchro/followers","following_url":"https://api.github.com/users/Synchro/following{/other_user}","gists_url":"https://api.github.com/users/Synchro/gists{/gist_id}","starred_url":"https://api.github.com/users/Synchro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Synchro/subscriptions","organizations_url":"https://api.github.com/users/Synchro/orgs","repos_url":"https://api.github.com/users/Synchro/repos","events_url":"https://api.github.com/users/Synchro/events{/privacy}","received_events_url":"https://api.github.com/users/Synchro/received_events","type":"User","site_admin":false},"body":"I ran into this is a non-PhpSpreadsheet context, but using this code. The idea behind this function is that it's a multibyte-aware version of `str_replace`, but unlike that function, it imposes a 64k limit on strings, and it will unexpectedly truncate when handling strings longer than that. All that's required to fix it is remove the length limit by setting it to `null` instead, which is all this PR does. In case this limit was imposed for memory reasons, it could perhaps instead be raised to a larger value, but that would still break technical compatibility with str_replace.","created_at":"2016-09-05T21:46:26Z","updated_at":"2016-09-07T15:30:11Z","closed_at":"2016-09-07T15:30:10Z","merged_at":"2016-09-07T15:30:10Z","merge_commit_sha":"cbeae09c210d76f1d23053b9e848d43fc2570405","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/19/commits","review_comments_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/19/comments","review_comment_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/issues/19/comments","statuses_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/statuses/39ea4eea98972466025472e2a9e414c5e04e47da","head":{"label":"Synchro:develop","ref":"develop","sha":"39ea4eea98972466025472e2a9e414c5e04e47da","user":{"login":"Synchro","id":81561,"avatar_url":"https://avatars.githubusercontent.com/u/81561?v=3","gravatar_id":"","url":"https://api.github.com/users/Synchro","html_url":"https://github.com/Synchro","followers_url":"https://api.github.com/users/Synchro/followers","following_url":"https://api.github.com/users/Synchro/following{/other_user}","gists_url":"https://api.github.com/users/Synchro/gists{/gist_id}","starred_url":"https://api.github.com/users/Synchro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Synchro/subscriptions","organizations_url":"https://api.github.com/users/Synchro/orgs","repos_url":"https://api.github.com/users/Synchro/repos","events_url":"https://api.github.com/users/Synchro/events{/privacy}","received_events_url":"https://api.github.com/users/Synchro/received_events","type":"User","site_admin":false},"repo":{"id":67451546,"name":"PhpSpreadsheet","full_name":"Synchro/PhpSpreadsheet","owner":{"login":"Synchro","id":81561,"avatar_url":"https://avatars.githubusercontent.com/u/81561?v=3","gravatar_id":"","url":"https://api.github.com/users/Synchro","html_url":"https://github.com/Synchro","followers_url":"https://api.github.com/users/Synchro/followers","following_url":"https://api.github.com/users/Synchro/following{/other_user}","gists_url":"https://api.github.com/users/Synchro/gists{/gist_id}","starred_url":"https://api.github.com/users/Synchro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Synchro/subscriptions","organizations_url":"https://api.github.com/users/Synchro/orgs","repos_url":"https://api.github.com/users/Synchro/repos","events_url":"https://api.github.com/users/Synchro/events{/privacy}","received_events_url":"https://api.github.com/users/Synchro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Synchro/PhpSpreadsheet","description":"A pure PHP library for reading and writing spreadsheet files","fork":true,"url":"https://api.github.com/repos/Synchro/PhpSpreadsheet","forks_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/forks","keys_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/teams","hooks_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/hooks","issue_events_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/issues/events{/number}","events_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/events","assignees_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/assignees{/user}","branches_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/branches{/branch}","tags_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/tags","blobs_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/statuses/{sha}","languages_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/languages","stargazers_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/stargazers","contributors_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/contributors","subscribers_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/subscribers","subscription_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/subscription","commits_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/contents/{+path}","compare_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/merges","archive_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/downloads","issues_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/issues{/number}","pulls_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/pulls{/number}","milestones_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/milestones{/number}","notifications_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/labels{/name}","releases_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/releases{/id}","deployments_url":"https://api.github.com/repos/Synchro/PhpSpreadsheet/deployments","created_at":"2016-09-05T21:19:13Z","updated_at":"2016-09-05T21:19:16Z","pushed_at":"2016-09-05T21:27:09Z","git_url":"git://github.com/Synchro/PhpSpreadsheet.git","ssh_url":"git@github.com:Synchro/PhpSpreadsheet.git","clone_url":"https://github.com/Synchro/PhpSpreadsheet.git","svn_url":"https://github.com/Synchro/PhpSpreadsheet","homepage":null,"size":22295,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PHPOffice:develop","ref":"develop","sha":"67918419c4afa7a683d43e05f860fa6c7ad02277","user":{"login":"PHPOffice","id":1836015,"avatar_url":"https://avatars.githubusercontent.com/u/1836015?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPOffice","html_url":"https://github.com/PHPOffice","followers_url":"https://api.github.com/users/PHPOffice/followers","following_url":"https://api.github.com/users/PHPOffice/following{/other_user}","gists_url":"https://api.github.com/users/PHPOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPOffice/subscriptions","organizations_url":"https://api.github.com/users/PHPOffice/orgs","repos_url":"https://api.github.com/users/PHPOffice/repos","events_url":"https://api.github.com/users/PHPOffice/events{/privacy}","received_events_url":"https://api.github.com/users/PHPOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":61490598,"name":"PhpSpreadsheet","full_name":"PHPOffice/PhpSpreadsheet","owner":{"login":"PHPOffice","id":1836015,"avatar_url":"https://avatars.githubusercontent.com/u/1836015?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPOffice","html_url":"https://github.com/PHPOffice","followers_url":"https://api.github.com/users/PHPOffice/followers","following_url":"https://api.github.com/users/PHPOffice/following{/other_user}","gists_url":"https://api.github.com/users/PHPOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPOffice/subscriptions","organizations_url":"https://api.github.com/users/PHPOffice/orgs","repos_url":"https://api.github.com/users/PHPOffice/repos","events_url":"https://api.github.com/users/PHPOffice/events{/privacy}","received_events_url":"https://api.github.com/users/PHPOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PHPOffice/PhpSpreadsheet","description":"A pure PHP library for reading and writing spreadsheet files","fork":false,"url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet","forks_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/forks","keys_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/teams","hooks_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/hooks","issue_events_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/issues/events{/number}","events_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/events","assignees_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/assignees{/user}","branches_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/branches{/branch}","tags_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/tags","blobs_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/statuses/{sha}","languages_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/languages","stargazers_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/stargazers","contributors_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/contributors","subscribers_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/subscribers","subscription_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/subscription","commits_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/contents/{+path}","compare_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/merges","archive_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/downloads","issues_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/issues{/number}","pulls_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls{/number}","milestones_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/milestones{/number}","notifications_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/labels{/name}","releases_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/releases{/id}","deployments_url":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/deployments","created_at":"2016-06-19T16:58:48Z","updated_at":"2016-08-25T05:01:36Z","pushed_at":"2016-09-07T15:30:11Z","git_url":"git://github.com/PHPOffice/PhpSpreadsheet.git","ssh_url":"git@github.com:PHPOffice/PhpSpreadsheet.git","clone_url":"https://github.com/PHPOffice/PhpSpreadsheet.git","svn_url":"https://github.com/PHPOffice/PhpSpreadsheet","homepage":null,"size":22296,"stargazers_count":14,"watchers_count":14,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":9,"forks":6,"open_issues":9,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/19"},"html":{"href":"https://github.com/PHPOffice/PhpSpreadsheet/pull/19"},"issue":{"href":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/issues/19"},"comments":{"href":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/PHPOffice/PhpSpreadsheet/statuses/39ea4eea98972466025472e2a9e414c5e04e47da"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"PowerKiKi","id":72603,"avatar_url":"https://avatars.githubusercontent.com/u/72603?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerKiKi","html_url":"https://github.com/PowerKiKi","followers_url":"https://api.github.com/users/PowerKiKi/followers","following_url":"https://api.github.com/users/PowerKiKi/following{/other_user}","gists_url":"https://api.github.com/users/PowerKiKi/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerKiKi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerKiKi/subscriptions","organizations_url":"https://api.github.com/users/PowerKiKi/orgs","repos_url":"https://api.github.com/users/PowerKiKi/repos","events_url":"https://api.github.com/users/PowerKiKi/events{/privacy}","received_events_url":"https://api.github.com/users/PowerKiKi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"PowerKiKi"}}