{"action":"created","issue":{"url":"https://api.github.com/repos/koreader/koreader/issues/2145","repository_url":"https://api.github.com/repos/koreader/koreader","labels_url":"https://api.github.com/repos/koreader/koreader/issues/2145/labels{/name}","comments_url":"https://api.github.com/repos/koreader/koreader/issues/2145/comments","events_url":"https://api.github.com/repos/koreader/koreader/issues/2145/events","html_url":"https://github.com/koreader/koreader/issues/2145","id":164654052,"number":2145,"title":"Screen fully refreshed after staying on a page for a minute","user":{"login":"Hzj-jie","id":1188462,"avatar_url":"https://avatars.githubusercontent.com/u/1188462?v=3","gravatar_id":"","url":"https://api.github.com/users/Hzj-jie","html_url":"https://github.com/Hzj-jie","followers_url":"https://api.github.com/users/Hzj-jie/followers","following_url":"https://api.github.com/users/Hzj-jie/following{/other_user}","gists_url":"https://api.github.com/users/Hzj-jie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hzj-jie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hzj-jie/subscriptions","organizations_url":"https://api.github.com/users/Hzj-jie/orgs","repos_url":"https://api.github.com/users/Hzj-jie/repos","events_url":"https://api.github.com/users/Hzj-jie/events{/privacy}","received_events_url":"https://api.github.com/users/Hzj-jie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/koreader/koreader/milestones/4","html_url":"https://github.com/koreader/koreader/milestones/next%20stable%20release","labels_url":"https://api.github.com/repos/koreader/koreader/milestones/4/labels","id":1628292,"number":4,"title":"next stable release","description":"","creator":{"login":"houqp","id":670302,"avatar_url":"https://avatars.githubusercontent.com/u/670302?v=3","gravatar_id":"","url":"https://api.github.com/users/houqp","html_url":"https://github.com/houqp","followers_url":"https://api.github.com/users/houqp/followers","following_url":"https://api.github.com/users/houqp/following{/other_user}","gists_url":"https://api.github.com/users/houqp/gists{/gist_id}","starred_url":"https://api.github.com/users/houqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houqp/subscriptions","organizations_url":"https://api.github.com/users/houqp/orgs","repos_url":"https://api.github.com/users/houqp/repos","events_url":"https://api.github.com/users/houqp/events{/privacy}","received_events_url":"https://api.github.com/users/houqp/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":46,"state":"open","created_at":"2016-03-08T08:43:07Z","updated_at":"2016-07-09T21:30:22Z","due_on":"2016-07-05T07:00:00Z","closed_at":null},"comments":7,"created_at":"2016-07-09T07:02:19Z","updated_at":"2016-07-11T20:22:27Z","closed_at":null,"body":"* KOReader version: 513 nightly build\r\n* Device: Kobo Aura HD\r\n\r\n#### Issue\r\n\r\nWhen auto refresh time feature has been enabled, and after staying on a page for around one minute, the screen automatically fully refreshed.\r\n\r\n#### Steps to reproduce\r\n\r\nI believe this issue relates to my recent change to set dirty region in TextWidge:setText. And the size of status bar is entire screen (no idea whether this is expected). Currently a work around is to set the page full refresh time as 99 page to reduce the possibility of this kind of full refresh. But is it expected that the status bar covers the entire screen?"},"comment":{"url":"https://api.github.com/repos/koreader/koreader/issues/comments/231852785","html_url":"https://github.com/koreader/koreader/issues/2145#issuecomment-231852785","issue_url":"https://api.github.com/repos/koreader/koreader/issues/2145","id":231852785,"user":{"login":"Hzj-jie","id":1188462,"avatar_url":"https://avatars.githubusercontent.com/u/1188462?v=3","gravatar_id":"","url":"https://api.github.com/users/Hzj-jie","html_url":"https://github.com/Hzj-jie","followers_url":"https://api.github.com/users/Hzj-jie/followers","following_url":"https://api.github.com/users/Hzj-jie/following{/other_user}","gists_url":"https://api.github.com/users/Hzj-jie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hzj-jie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hzj-jie/subscriptions","organizations_url":"https://api.github.com/users/Hzj-jie/orgs","repos_url":"https://api.github.com/users/Hzj-jie/repos","events_url":"https://api.github.com/users/Hzj-jie/events{/privacy}","received_events_url":"https://api.github.com/users/Hzj-jie/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T20:22:27Z","updated_at":"2016-07-11T20:22:27Z","body":"Oh, seems I have misunderstood your comment in my PR.\r\nNow I quite understand your meaning, but I still have concern about it. Is there any reason we should not setDirty in TextWidget? I know the implementation detail of UIManager restricts it, but logically we should setDirty each time TextWidget:setText called. Otherwise some text change may not reflect to the screen."}}
{"actor":{"display_login":"Hzj-jie"}}