{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/78223568","id":78223568,"diff_hunk":"@@ -29,7 +29,13 @@ void Java_org_gearvrf_OvrViewManager_cull(JNIEnv * jni, jclass clazz,\n     Scene* scene = reinterpret_cast<Scene*>(jscene);\n     Camera* camera = reinterpret_cast<Camera*>(jcamera);\n     ShaderManager* shader_manager = reinterpret_cast<ShaderManager*>(jshader_manager);\n-    Renderer::cull(scene, camera, shader_manager);\n+    renderer = Renderer::getInstance();","path":"GVRf/Framework/backend_oculus/src/main/jni/ovr_view_manager.cpp","position":5,"original_position":5,"commit_id":"7adb23e1858f1cc1d5fb8a36d1c8d836628ddd23","original_commit_id":"7adb23e1858f1cc1d5fb8a36d1c8d836628ddd23","user":{"login":"liaxim","id":11889541,"avatar_url":"https://avatars.githubusercontent.com/u/11889541?v=3","gravatar_id":"","url":"https://api.github.com/users/liaxim","html_url":"https://github.com/liaxim","followers_url":"https://api.github.com/users/liaxim/followers","following_url":"https://api.github.com/users/liaxim/following{/other_user}","gists_url":"https://api.github.com/users/liaxim/gists{/gist_id}","starred_url":"https://api.github.com/users/liaxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liaxim/subscriptions","organizations_url":"https://api.github.com/users/liaxim/orgs","repos_url":"https://api.github.com/users/liaxim/repos","events_url":"https://api.github.com/users/liaxim/events{/privacy}","received_events_url":"https://api.github.com/users/liaxim/received_events","type":"User","site_admin":false},"body":"Can Renderer::getInstance() really return nullptr? I think new should throw; in that case the checks and the logs are unnecessary.","created_at":"2016-09-09T18:05:50Z","updated_at":"2016-09-09T18:05:50Z","html_url":"https://github.com/Samsung/GearVRf/pull/839#discussion_r78223568","pull_request_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/839","_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/78223568"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/839#discussion_r78223568"},"pull_request":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/839"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/839","id":83550054,"html_url":"https://github.com/Samsung/GearVRf/pull/839","diff_url":"https://github.com/Samsung/GearVRf/pull/839.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/839.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/839","number":839,"state":"open","locked":false,"title":"Refactor renderer, adding vulkan renderer","user":{"login":"roshanch","id":15111024,"avatar_url":"https://avatars.githubusercontent.com/u/15111024?v=3","gravatar_id":"","url":"https://api.github.com/users/roshanch","html_url":"https://github.com/roshanch","followers_url":"https://api.github.com/users/roshanch/followers","following_url":"https://api.github.com/users/roshanch/following{/other_user}","gists_url":"https://api.github.com/users/roshanch/gists{/gist_id}","starred_url":"https://api.github.com/users/roshanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshanch/subscriptions","organizations_url":"https://api.github.com/users/roshanch/orgs","repos_url":"https://api.github.com/users/roshanch/repos","events_url":"https://api.github.com/users/roshanch/events{/privacy}","received_events_url":"https://api.github.com/users/roshanch/received_events","type":"User","site_admin":false},"body":"Making GL and Vulkan Renderer seperate.\r\nTested with jassimp and modelview sample.\r\n\r\nGearVRf-DCO-1.0-Signed-off-by: Roshan Chaudhari roshan.c@samsung.com","created_at":"2016-08-31T23:59:22Z","updated_at":"2016-09-09T18:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1e8d6bb8d5b14b8538f8a58ade314c3637ff6c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/839/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/839/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/839/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/7adb23e1858f1cc1d5fb8a36d1c8d836628ddd23","head":{"label":"roshanch:renderer_restructure","ref":"renderer_restructure","sha":"7adb23e1858f1cc1d5fb8a36d1c8d836628ddd23","user":{"login":"roshanch","id":15111024,"avatar_url":"https://avatars.githubusercontent.com/u/15111024?v=3","gravatar_id":"","url":"https://api.github.com/users/roshanch","html_url":"https://github.com/roshanch","followers_url":"https://api.github.com/users/roshanch/followers","following_url":"https://api.github.com/users/roshanch/following{/other_user}","gists_url":"https://api.github.com/users/roshanch/gists{/gist_id}","starred_url":"https://api.github.com/users/roshanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshanch/subscriptions","organizations_url":"https://api.github.com/users/roshanch/orgs","repos_url":"https://api.github.com/users/roshanch/repos","events_url":"https://api.github.com/users/roshanch/events{/privacy}","received_events_url":"https://api.github.com/users/roshanch/received_events","type":"User","site_admin":false},"repo":{"id":61405701,"name":"GearVRf","full_name":"roshanch/GearVRf","owner":{"login":"roshanch","id":15111024,"avatar_url":"https://avatars.githubusercontent.com/u/15111024?v=3","gravatar_id":"","url":"https://api.github.com/users/roshanch","html_url":"https://github.com/roshanch","followers_url":"https://api.github.com/users/roshanch/followers","following_url":"https://api.github.com/users/roshanch/following{/other_user}","gists_url":"https://api.github.com/users/roshanch/gists{/gist_id}","starred_url":"https://api.github.com/users/roshanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roshanch/subscriptions","organizations_url":"https://api.github.com/users/roshanch/orgs","repos_url":"https://api.github.com/users/roshanch/repos","events_url":"https://api.github.com/users/roshanch/events{/privacy}","received_events_url":"https://api.github.com/users/roshanch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roshanch/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/roshanch/GearVRf","forks_url":"https://api.github.com/repos/roshanch/GearVRf/forks","keys_url":"https://api.github.com/repos/roshanch/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roshanch/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roshanch/GearVRf/teams","hooks_url":"https://api.github.com/repos/roshanch/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/roshanch/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/roshanch/GearVRf/events","assignees_url":"https://api.github.com/repos/roshanch/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/roshanch/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/roshanch/GearVRf/tags","blobs_url":"https://api.github.com/repos/roshanch/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roshanch/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roshanch/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/roshanch/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roshanch/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/roshanch/GearVRf/languages","stargazers_url":"https://api.github.com/repos/roshanch/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/roshanch/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/roshanch/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/roshanch/GearVRf/subscription","commits_url":"https://api.github.com/repos/roshanch/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/roshanch/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/roshanch/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/roshanch/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/roshanch/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/roshanch/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roshanch/GearVRf/merges","archive_url":"https://api.github.com/repos/roshanch/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roshanch/GearVRf/downloads","issues_url":"https://api.github.com/repos/roshanch/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/roshanch/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/roshanch/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/roshanch/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roshanch/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/roshanch/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/roshanch/GearVRf/deployments","created_at":"2016-06-17T22:25:56Z","updated_at":"2016-06-17T22:26:00Z","pushed_at":"2016-09-09T17:46:12Z","git_url":"git://github.com/roshanch/GearVRf.git","ssh_url":"git@github.com:roshanch/GearVRf.git","clone_url":"https://github.com/roshanch/GearVRf.git","svn_url":"https://github.com/roshanch/GearVRf","homepage":"http://www.gearvrf.org","size":667796,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"a0dc60cf79c00981f5f923b3f3199a8819ac78a0","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/GearVRf/deployments","created_at":"2015-03-25T02:02:18Z","updated_at":"2016-09-09T18:02:21Z","pushed_at":"2016-09-09T17:46:12Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":757452,"stargazers_count":210,"watchers_count":210,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"open_issues_count":75,"forks":155,"open_issues":75,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/839"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/839"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/839"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/839/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/839/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/839/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/7adb23e1858f1cc1d5fb8a36d1c8d836628ddd23"}}}}
{"actor":{"display_login":"liaxim"}}