{"action":"created","comment":{"url":"https://api.github.com/repos/google/syzkaller/pulls/comments/83179775","pull_request_review_id":4032833,"id":83179775,"diff_hunk":"@@ -52,6 +52,13 @@ func (t TypeCommon) Default() uintptr {\n \treturn 0\n }\n \n+type Endianness int\n+\n+const (\n+\tLittleEndian Endianness = iota","path":"sys/decl.go","position":7,"original_position":7,"commit_id":"7a53296a51216665c6acb70334d7ce8e5543ffa6","original_commit_id":"7a9235f819dfdcd2477b34e8ca88920526bdd494","user":{"login":"dvyukov","id":1095328,"avatar_url":"https://avatars.githubusercontent.com/u/1095328?v=3","gravatar_id":"","url":"https://api.github.com/users/dvyukov","html_url":"https://github.com/dvyukov","followers_url":"https://api.github.com/users/dvyukov/followers","following_url":"https://api.github.com/users/dvyukov/following{/other_user}","gists_url":"https://api.github.com/users/dvyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/dvyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvyukov/subscriptions","organizations_url":"https://api.github.com/users/dvyukov/orgs","repos_url":"https://api.github.com/users/dvyukov/repos","events_url":"https://api.github.com/users/dvyukov/events{/privacy}","received_events_url":"https://api.github.com/users/dvyukov/received_events","type":"User","site_admin":false},"body":"Please let's do just 'BigEndian bool'.\r\nThis `Endianness Endianness` causes too much clutter for no apparent benefit. There are only 2 options, which is naturally represented by a bool. There are multiple copies \r\n\r\n```\r\n\tEndianness: LittleEndian,\r\n\r\n\tEndianness == LittleEndian\r\n\r\n\tendianness := \"LittleEndian\"\r\n\tif !littleEndian {\r\n\t\tendianness = \"BigEndian\"\r\n\t}\r\n```\r\n\r\nIf we do the bool, we can drop:\r\n```\r\n\tendianness := \"LittleEndian\"\r\n\tif !littleEndian {\r\n\t\tendianness = \"BigEndian\"\r\n\t}\r\n```\r\nentirely, as a bool is correctly printed with %v.\r\n\r\nWe can also drop `Endianness: LittleEndian,` initialization, as default value for bool represents our semantic default of having little endian (unless said otherwise).\r\n","created_at":"2016-10-13T09:47:37Z","updated_at":"2016-10-13T09:47:51Z","html_url":"https://github.com/google/syzkaller/pull/83#discussion_r83179775","pull_request_url":"https://api.github.com/repos/google/syzkaller/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments/83179775"},"html":{"href":"https://github.com/google/syzkaller/pull/83#discussion_r83179775"},"pull_request":{"href":"https://api.github.com/repos/google/syzkaller/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/google/syzkaller/pulls/83","id":88890926,"html_url":"https://github.com/google/syzkaller/pull/83","diff_url":"https://github.com/google/syzkaller/pull/83.diff","patch_url":"https://github.com/google/syzkaller/pull/83.patch","issue_url":"https://api.github.com/repos/google/syzkaller/issues/83","number":83,"state":"open","locked":false,"title":"Add big-endian ints","user":{"login":"xairy","id":4965052,"avatar_url":"https://avatars.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-11T19:01:54Z","updated_at":"2016-10-13T09:47:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"717ef45301ac9d84cd4b19f041e200dee5a15654","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/syzkaller/pulls/83/commits","review_comments_url":"https://api.github.com/repos/google/syzkaller/pulls/83/comments","review_comment_url":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/syzkaller/issues/83/comments","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/7a53296a51216665c6acb70334d7ce8e5543ffa6","head":{"label":"xairy:big-endian","ref":"big-endian","sha":"7a53296a51216665c6acb70334d7ce8e5543ffa6","user":{"login":"xairy","id":4965052,"avatar_url":"https://avatars.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"repo":{"id":68212846,"name":"syzkaller","full_name":"xairy/syzkaller","owner":{"login":"xairy","id":4965052,"avatar_url":"https://avatars.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xairy/syzkaller","description":"syzkaller is a distributed, unsupervised, coverage-guided Linux syscall fuzzer","fork":true,"url":"https://api.github.com/repos/xairy/syzkaller","forks_url":"https://api.github.com/repos/xairy/syzkaller/forks","keys_url":"https://api.github.com/repos/xairy/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xairy/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xairy/syzkaller/teams","hooks_url":"https://api.github.com/repos/xairy/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/xairy/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/xairy/syzkaller/events","assignees_url":"https://api.github.com/repos/xairy/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/xairy/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/xairy/syzkaller/tags","blobs_url":"https://api.github.com/repos/xairy/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xairy/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xairy/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/xairy/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xairy/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/xairy/syzkaller/languages","stargazers_url":"https://api.github.com/repos/xairy/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/xairy/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/xairy/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/xairy/syzkaller/subscription","commits_url":"https://api.github.com/repos/xairy/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/xairy/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/xairy/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/xairy/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/xairy/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/xairy/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xairy/syzkaller/merges","archive_url":"https://api.github.com/repos/xairy/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xairy/syzkaller/downloads","issues_url":"https://api.github.com/repos/xairy/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/xairy/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/xairy/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/xairy/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xairy/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/xairy/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/xairy/syzkaller/deployments","created_at":"2016-09-14T14:22:30Z","updated_at":"2016-09-14T14:22:32Z","pushed_at":"2016-10-12T11:29:49Z","git_url":"git://github.com/xairy/syzkaller.git","ssh_url":"git@github.com:xairy/syzkaller.git","clone_url":"https://github.com/xairy/syzkaller.git","svn_url":"https://github.com/xairy/syzkaller","homepage":"","size":2067,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"cb8fcaf84c7386b129ef54d9ee5fd36b6c56bf0d","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":44087204,"name":"syzkaller","full_name":"google/syzkaller","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/syzkaller","description":"syzkaller is a distributed, unsupervised, coverage-guided Linux syscall fuzzer","fork":false,"url":"https://api.github.com/repos/google/syzkaller","forks_url":"https://api.github.com/repos/google/syzkaller/forks","keys_url":"https://api.github.com/repos/google/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/syzkaller/teams","hooks_url":"https://api.github.com/repos/google/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/google/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/google/syzkaller/events","assignees_url":"https://api.github.com/repos/google/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/google/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/google/syzkaller/tags","blobs_url":"https://api.github.com/repos/google/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/google/syzkaller/languages","stargazers_url":"https://api.github.com/repos/google/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/google/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/google/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/google/syzkaller/subscription","commits_url":"https://api.github.com/repos/google/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/google/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/syzkaller/merges","archive_url":"https://api.github.com/repos/google/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/syzkaller/downloads","issues_url":"https://api.github.com/repos/google/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/google/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/google/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/google/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/google/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/google/syzkaller/deployments","created_at":"2015-10-12T06:05:05Z","updated_at":"2016-10-13T05:54:09Z","pushed_at":"2016-10-12T11:29:47Z","git_url":"git://github.com/google/syzkaller.git","ssh_url":"git@github.com:google/syzkaller.git","clone_url":"https://github.com/google/syzkaller.git","svn_url":"https://github.com/google/syzkaller","homepage":"","size":2131,"stargazers_count":375,"watchers_count":375,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":13,"forks":69,"open_issues":13,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/83"},"html":{"href":"https://github.com/google/syzkaller/pull/83"},"issue":{"href":"https://api.github.com/repos/google/syzkaller/issues/83"},"comments":{"href":"https://api.github.com/repos/google/syzkaller/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/google/syzkaller/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/syzkaller/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/google/syzkaller/statuses/7a53296a51216665c6acb70334d7ce8e5543ffa6"}}}}
{"actor":{"display_login":"dvyukov"}}