{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/74697668","id":74697668,"diff_hunk":"@@ -231,7 +235,10 @@ def target_temperature(self):\n     @property\n     def operation(self: ThermostatDevice) -> str:\n         \"\"\"Return current operation ie. heat, cool, idle.\"\"\"\n-        return self._device.system_mode\n+        if hasattr(self._device, 'system_mode'):\n+            return self._device.system_mode\n+        else:\n+            return 'undefined'","path":"homeassistant/components/thermostat/honeywell.py","position":30,"original_position":30,"commit_id":"e47f7988282917a011850e9b76197a48db1429f3","original_commit_id":"e47f7988282917a011850e9b76197a48db1429f3","user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"Same","created_at":"2016-08-14T08:11:58Z","updated_at":"2016-08-14T08:11:58Z","html_url":"https://github.com/home-assistant/home-assistant/pull/2815#discussion_r74697668","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/74697668"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2815#discussion_r74697668"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815","id":81236891,"html_url":"https://github.com/home-assistant/home-assistant/pull/2815","diff_url":"https://github.com/home-assistant/home-assistant/pull/2815.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/2815.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2815","number":2815,"state":"open","locked":false,"title":"Check for existence of system mode on Honeywell thermostats","user":{"login":"mKeRix","id":770596,"avatar_url":"https://avatars.githubusercontent.com/u/770596?v=3","gravatar_id":"","url":"https://api.github.com/users/mKeRix","html_url":"https://github.com/mKeRix","followers_url":"https://api.github.com/users/mKeRix/followers","following_url":"https://api.github.com/users/mKeRix/following{/other_user}","gists_url":"https://api.github.com/users/mKeRix/gists{/gist_id}","starred_url":"https://api.github.com/users/mKeRix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mKeRix/subscriptions","organizations_url":"https://api.github.com/users/mKeRix/orgs","repos_url":"https://api.github.com/users/mKeRix/repos","events_url":"https://api.github.com/users/mKeRix/events{/privacy}","received_events_url":"https://api.github.com/users/mKeRix/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nNot all Honeywell thermostats have an HVAC mode (e.g. the ones commonly sold in Germany for district heating). In 0.26 the Honeywell component would fail setting up in that case, this check whether the `system_mode` parameter exists before it does anything with it\r\n\r\n**Related issue (if applicable):** extends #2757 \r\n\r\n**Checklist:**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf code communicates with devices, web services, or a:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51\r\n\r\n","created_at":"2016-08-14T08:07:08Z","updated_at":"2016-08-14T08:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9d5116c60e95c697763bddddf645a2420e6727f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/2815/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e47f7988282917a011850e9b76197a48db1429f3","head":{"label":"mKeRix:honeywell-hvac-eu-fix","ref":"honeywell-hvac-eu-fix","sha":"e47f7988282917a011850e9b76197a48db1429f3","user":{"login":"mKeRix","id":770596,"avatar_url":"https://avatars.githubusercontent.com/u/770596?v=3","gravatar_id":"","url":"https://api.github.com/users/mKeRix","html_url":"https://github.com/mKeRix","followers_url":"https://api.github.com/users/mKeRix/followers","following_url":"https://api.github.com/users/mKeRix/following{/other_user}","gists_url":"https://api.github.com/users/mKeRix/gists{/gist_id}","starred_url":"https://api.github.com/users/mKeRix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mKeRix/subscriptions","organizations_url":"https://api.github.com/users/mKeRix/orgs","repos_url":"https://api.github.com/users/mKeRix/repos","events_url":"https://api.github.com/users/mKeRix/events{/privacy}","received_events_url":"https://api.github.com/users/mKeRix/received_events","type":"User","site_admin":false},"repo":{"id":42828839,"name":"home-assistant","full_name":"mKeRix/home-assistant","owner":{"login":"mKeRix","id":770596,"avatar_url":"https://avatars.githubusercontent.com/u/770596?v=3","gravatar_id":"","url":"https://api.github.com/users/mKeRix","html_url":"https://github.com/mKeRix","followers_url":"https://api.github.com/users/mKeRix/followers","following_url":"https://api.github.com/users/mKeRix/following{/other_user}","gists_url":"https://api.github.com/users/mKeRix/gists{/gist_id}","starred_url":"https://api.github.com/users/mKeRix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mKeRix/subscriptions","organizations_url":"https://api.github.com/users/mKeRix/orgs","repos_url":"https://api.github.com/users/mKeRix/repos","events_url":"https://api.github.com/users/mKeRix/events{/privacy}","received_events_url":"https://api.github.com/users/mKeRix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mKeRix/home-assistant","description":"Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/mKeRix/home-assistant","forks_url":"https://api.github.com/repos/mKeRix/home-assistant/forks","keys_url":"https://api.github.com/repos/mKeRix/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mKeRix/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mKeRix/home-assistant/teams","hooks_url":"https://api.github.com/repos/mKeRix/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/mKeRix/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/mKeRix/home-assistant/events","assignees_url":"https://api.github.com/repos/mKeRix/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/mKeRix/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/mKeRix/home-assistant/tags","blobs_url":"https://api.github.com/repos/mKeRix/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mKeRix/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mKeRix/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/mKeRix/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mKeRix/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/mKeRix/home-assistant/languages","stargazers_url":"https://api.github.com/repos/mKeRix/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/mKeRix/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/mKeRix/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/mKeRix/home-assistant/subscription","commits_url":"https://api.github.com/repos/mKeRix/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/mKeRix/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/mKeRix/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/mKeRix/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/mKeRix/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/mKeRix/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mKeRix/home-assistant/merges","archive_url":"https://api.github.com/repos/mKeRix/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mKeRix/home-assistant/downloads","issues_url":"https://api.github.com/repos/mKeRix/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/mKeRix/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/mKeRix/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/mKeRix/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mKeRix/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/mKeRix/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/mKeRix/home-assistant/deployments","created_at":"2015-09-20T20:41:24Z","updated_at":"2016-04-13T04:14:07Z","pushed_at":"2016-08-14T08:03:13Z","git_url":"git://github.com/mKeRix/home-assistant.git","ssh_url":"git@github.com:mKeRix/home-assistant.git","clone_url":"https://github.com/mKeRix/home-assistant.git","svn_url":"https://github.com/mKeRix/home-assistant","homepage":"https://home-assistant.io","size":23854,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"c6f67a52038c73d689f888ae72203dc0f6f595d5","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2016-08-14T07:08:18Z","pushed_at":"2016-08-14T08:10:09Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":104101,"stargazers_count":3859,"watchers_count":3859,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":886,"mirror_url":null,"open_issues_count":177,"forks":886,"open_issues":177,"watchers":3859,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/2815"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2815"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/2815/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/2815/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e47f7988282917a011850e9b76197a48db1429f3"}}}}
{"actor":{"display_login":"balloob"}}