{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30935","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30935/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30935/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30935/events","html_url":"https://github.com/kubernetes/kubernetes/pull/30935","id":172010677,"number":30935,"title":"Make a vSphere cluster the failure_zone","user":{"login":"vipulsabhaya","id":1105391,"avatar_url":"https://avatars.githubusercontent.com/u/1105391?v=3","gravatar_id":"","url":"https://api.github.com/users/vipulsabhaya","html_url":"https://github.com/vipulsabhaya","followers_url":"https://api.github.com/users/vipulsabhaya/followers","following_url":"https://api.github.com/users/vipulsabhaya/following{/other_user}","gists_url":"https://api.github.com/users/vipulsabhaya/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulsabhaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulsabhaya/subscriptions","organizations_url":"https://api.github.com/users/vipulsabhaya/orgs","repos_url":"https://api.github.com/users/vipulsabhaya/repos","events_url":"https://api.github.com/users/vipulsabhaya/events{/privacy}","received_events_url":"https://api.github.com/users/vipulsabhaya/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge","name":"do-not-merge","color":"e11d21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/ok-to-merge","name":"ok-to-merge","color":"fbca04"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"https://github.com/kubernetes/features/blob/master/release-1.4/Release-1.4.md","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":199,"closed_issues":606,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-09-01T20:47:52Z","due_on":"2016-09-15T00:00:00Z","closed_at":null},"comments":26,"created_at":"2016-08-18T21:56:16Z","updated_at":"2016-09-01T20:55:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30935","html_url":"https://github.com/kubernetes/kubernetes/pull/30935","diff_url":"https://github.com/kubernetes/kubernetes/pull/30935.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30935.patch"},"body":"vSphere cloud provider returns the FailureZone as Cluster, if the VM belongs to a ResourcePool under a Cluster. \r\n\r\nfixes: #30933\r\n\r\n* Currently the vSphere cloud provider treats Datacenter as the failure\r\n  Zone.  This doesn't necessarily work since in the current implemention\r\n  Kubernetes nodes cannot span Datacenters.\r\n* This change introduces Clusters as the failure zone, while treating\r\n  Datacenters as Regions\r\n* Also updated tests for Zones\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30935)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/244209522","html_url":"https://github.com/kubernetes/kubernetes/pull/30935#issuecomment-244209522","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30935","id":244209522,"user":{"login":"vipulsabhaya","id":1105391,"avatar_url":"https://avatars.githubusercontent.com/u/1105391?v=3","gravatar_id":"","url":"https://api.github.com/users/vipulsabhaya","html_url":"https://github.com/vipulsabhaya","followers_url":"https://api.github.com/users/vipulsabhaya/followers","following_url":"https://api.github.com/users/vipulsabhaya/following{/other_user}","gists_url":"https://api.github.com/users/vipulsabhaya/gists{/gist_id}","starred_url":"https://api.github.com/users/vipulsabhaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vipulsabhaya/subscriptions","organizations_url":"https://api.github.com/users/vipulsabhaya/orgs","repos_url":"https://api.github.com/users/vipulsabhaya/repos","events_url":"https://api.github.com/users/vipulsabhaya/events{/privacy}","received_events_url":"https://api.github.com/users/vipulsabhaya/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T20:55:34Z","updated_at":"2016-09-01T20:55:34Z","body":"> How risky is it to merge this change?\r\nIt's low risk.  In the event the Node does not belong to a vsphere cluster, this change becomes a no-op and return nil for failure_zone like it does today.\r\n> How easy is it to roll this change back?\r\nThe changeset is small, backporting and roll back is going to be trivial.\r\n> What's the cost if it doesn't make the 1.4 release?\r\nwith the vSphere provider, we are not accurately labeling nodes appropriately.  This becomes an issue for production deployments that want to span multiple Failure Zones or AZs.  At this point, the vSphere provider behaves differently with respect to zones than other providers."}}
{"actor":{"display_login":"vipulsabhaya"}}