{"action":"opened","number":11,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/11","id":80732162,"html_url":"https://github.com/serilog/serilog-sinks-async/pull/11","diff_url":"https://github.com/serilog/serilog-sinks-async/pull/11.diff","patch_url":"https://github.com/serilog/serilog-sinks-async/pull/11.patch","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-async/issues/11","number":11,"state":"open","locked":false,"title":"Added File() baseline and AsyncFile sanity check to the latency benchmark","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"body":"Getting the following results:\r\n\r\n```ini\r\n\r\nBenchmarkDotNet=v0.9.7.0\r\nOS=Microsoft Windows NT 6.2.9200.0\r\nProcessor=Intel(R) Core(TM) i7-3720QM CPU 2.60GHz, ProcessorCount=8\r\nFrequency=2533308 ticks, Resolution=394.7408 ns, Timer=TSC\r\nHostCLR=MS.NET 4.0.30319.42000, Arch=64-bit RELEASE [RyuJIT]\r\nJitModules=clrjit-v4.6.1080.0\r\n\r\nType=LatencyBenchmark  Mode=Throughput  \r\n\r\n```\r\n    Method |         Median |      StdDev | Scaled |\r\n---------- |--------------- |------------ |------- |\r\n      Sync |     50.2585 ns |   0.7480 ns |   1.00 |\r\n     Async |    440.9520 ns |  20.1586 ns |   8.77 |\r\n      File | 10,527.3446 ns | 171.1528 ns | 209.46 |\r\n AsyncFile |    209.3905 ns |   5.7984 ns |   4.17 |\r\n\r\n\r\nThis required some messing about as the original benchmarks were overflowing the buffer, and thus were benchmarking fail-plus-SelfLog latency rather than the enqueueing latency.\r\n\r\nI think the difference between Async and AsyncFile can be put down to contention: the worker thread that's writing the events to the log file won't be interacting with the `BlockingCollection` as much.\r\n\r\n50x lower-latency file logging (on SSD) is pretty cool; I'm sure we can improve but it's a decent result :-)\r\n\r\n","created_at":"2016-08-10T04:16:50Z","updated_at":"2016-08-10T04:16:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/11/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/11/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-async/issues/11/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-async/statuses/66ea896614ce9cc18c50e2518ebc8e6ae220c642","head":{"label":"nblumhardt:dev","ref":"dev","sha":"66ea896614ce9cc18c50e2518ebc8e6ae220c642","user":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"repo":{"id":65076800,"name":"serilog-sinks-async","full_name":"nblumhardt/serilog-sinks-async","owner":{"login":"nblumhardt","id":342712,"avatar_url":"https://avatars.githubusercontent.com/u/342712?v=3","gravatar_id":"","url":"https://api.github.com/users/nblumhardt","html_url":"https://github.com/nblumhardt","followers_url":"https://api.github.com/users/nblumhardt/followers","following_url":"https://api.github.com/users/nblumhardt/following{/other_user}","gists_url":"https://api.github.com/users/nblumhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/nblumhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nblumhardt/subscriptions","organizations_url":"https://api.github.com/users/nblumhardt/orgs","repos_url":"https://api.github.com/users/nblumhardt/repos","events_url":"https://api.github.com/users/nblumhardt/events{/privacy}","received_events_url":"https://api.github.com/users/nblumhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nblumhardt/serilog-sinks-async","description":"An Async Serilog sink","fork":true,"url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async","forks_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/forks","keys_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/teams","hooks_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/hooks","issue_events_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/issues/events{/number}","events_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/events","assignees_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/assignees{/user}","branches_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/branches{/branch}","tags_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/tags","blobs_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/git/refs{/sha}","trees_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/statuses/{sha}","languages_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/languages","stargazers_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/stargazers","contributors_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/contributors","subscribers_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/subscribers","subscription_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/subscription","commits_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/commits{/sha}","git_commits_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/git/commits{/sha}","comments_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/comments{/number}","issue_comment_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/issues/comments{/number}","contents_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/contents/{+path}","compare_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/merges","archive_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/downloads","issues_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/issues{/number}","pulls_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/pulls{/number}","milestones_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/milestones{/number}","notifications_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/labels{/name}","releases_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/releases{/id}","deployments_url":"https://api.github.com/repos/nblumhardt/serilog-sinks-async/deployments","created_at":"2016-08-06T10:08:14Z","updated_at":"2016-08-06T10:08:15Z","pushed_at":"2016-08-10T04:11:09Z","git_url":"git://github.com/nblumhardt/serilog-sinks-async.git","ssh_url":"git@github.com:nblumhardt/serilog-sinks-async.git","clone_url":"https://github.com/nblumhardt/serilog-sinks-async.git","svn_url":"https://github.com/nblumhardt/serilog-sinks-async","homepage":null,"size":1227,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"serilog:dev","ref":"dev","sha":"7bd3fcff2f6b34bb19675ba8c3afce9986de32ae","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":63378465,"name":"serilog-sinks-async","full_name":"serilog/serilog-sinks-async","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-sinks-async","description":"An Async Serilog sink","fork":false,"url":"https://api.github.com/repos/serilog/serilog-sinks-async","forks_url":"https://api.github.com/repos/serilog/serilog-sinks-async/forks","keys_url":"https://api.github.com/repos/serilog/serilog-sinks-async/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-sinks-async/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-sinks-async/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-sinks-async/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-sinks-async/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-sinks-async/events","assignees_url":"https://api.github.com/repos/serilog/serilog-sinks-async/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-sinks-async/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-sinks-async/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-sinks-async/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-sinks-async/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-sinks-async/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-sinks-async/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-async/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-sinks-async/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-sinks-async/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-sinks-async/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-sinks-async/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-sinks-async/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-sinks-async/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-sinks-async/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-async/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-async/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-sinks-async/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-sinks-async/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-sinks-async/merges","archive_url":"https://api.github.com/repos/serilog/serilog-sinks-async/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-sinks-async/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-sinks-async/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-sinks-async/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-sinks-async/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-async/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-sinks-async/releases{/id}","deployments_url":"https://api.github.com/repos/serilog/serilog-sinks-async/deployments","created_at":"2016-07-15T00:20:04Z","updated_at":"2016-08-07T09:40:40Z","pushed_at":"2016-08-10T04:16:50Z","git_url":"git://github.com/serilog/serilog-sinks-async.git","ssh_url":"git@github.com:serilog/serilog-sinks-async.git","clone_url":"https://github.com/serilog/serilog-sinks-async.git","svn_url":"https://github.com/serilog/serilog-sinks-async","homepage":null,"size":1243,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/11"},"html":{"href":"https://github.com/serilog/serilog-sinks-async/pull/11"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-sinks-async/issues/11"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-async/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-sinks-async/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-sinks-async/statuses/66ea896614ce9cc18c50e2518ebc8e6ae220c642"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":81,"deletions":18,"changed_files":6}}
{"actor":{"display_login":"nblumhardt"}}