{"action":"created","comment":{"url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments/61667839","id":61667839,"diff_hunk":"@@ -0,0 +1,234 @@\n+#!/usr/bin/python2\n+# -*- encoding: utf8 -*-\n+# :pylint: disable=too-few-public-methods,C\n+#\n+# The Qubes OS Project, http://www.qubes-os.org\n+#\n+# Copyright (C) 2016 Bahtiar `kalkin-` Gadimov <bahtiar@gadimov.de>\n+#\n+# This program is free software; you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation; either version 2 of the License, or\n+# (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License along\n+# with this program; if not, write to the Free Software Foundation, Inc.,\n+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.\n+#\n+\n+from __future__ import print_function\n+\n+import sys\n+from argparse import SUPPRESS, Action\n+from subprocess import PIPE, Popen\n+\n+from qubes import Qubes, get_entry_point_one\n+from qubes.exc import QubesException\n+from qubes.storage import STORAGE_ENTRY_POINT, pool_drivers\n+from qubes.tools import QubesArgumentParser","path":"qubes/tools/qvm_pool.py","position":33,"original_position":33,"commit_id":"bc96b4374dcd0224b3172365e95d1a0493c20034","original_commit_id":"bc96b4374dcd0224b3172365e95d1a0493c20034","user":{"login":"marmarek","id":726704,"avatar_url":"https://avatars.githubusercontent.com/u/726704?v=3","gravatar_id":"","url":"https://api.github.com/users/marmarek","html_url":"https://github.com/marmarek","followers_url":"https://api.github.com/users/marmarek/followers","following_url":"https://api.github.com/users/marmarek/following{/other_user}","gists_url":"https://api.github.com/users/marmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/marmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marmarek/subscriptions","organizations_url":"https://api.github.com/users/marmarek/orgs","repos_url":"https://api.github.com/users/marmarek/repos","events_url":"https://api.github.com/users/marmarek/events{/privacy}","received_events_url":"https://api.github.com/users/marmarek/received_events","type":"User","site_admin":false},"body":"@woju recommends to avoid this type of imports and use just `import qubes.tools` (and full names later) - for readability. For example it would be much clearer what `Action` or `driver_parameters` is (two cases that tool me a few seconds to find out).","created_at":"2016-04-30T10:17:20Z","updated_at":"2016-04-30T10:17:20Z","html_url":"https://github.com/woju/qubes-core-admin/pull/9#discussion_r61667839","pull_request_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments/61667839"},"html":{"href":"https://github.com/woju/qubes-core-admin/pull/9#discussion_r61667839"},"pull_request":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9","id":68400555,"html_url":"https://github.com/woju/qubes-core-admin/pull/9","diff_url":"https://github.com/woju/qubes-core-admin/pull/9.diff","patch_url":"https://github.com/woju/qubes-core-admin/pull/9.patch","issue_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/9","number":9,"state":"open","locked":false,"title":"Add qvm-pool and manpage for it","user":{"login":"kalkin","id":145191,"avatar_url":"https://avatars.githubusercontent.com/u/145191?v=3","gravatar_id":"","url":"https://api.github.com/users/kalkin","html_url":"https://github.com/kalkin","followers_url":"https://api.github.com/users/kalkin/followers","following_url":"https://api.github.com/users/kalkin/following{/other_user}","gists_url":"https://api.github.com/users/kalkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalkin/subscriptions","organizations_url":"https://api.github.com/users/kalkin/orgs","repos_url":"https://api.github.com/users/kalkin/repos","events_url":"https://api.github.com/users/kalkin/events{/privacy}","received_events_url":"https://api.github.com/users/kalkin/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-04-29T16:46:41Z","updated_at":"2016-04-30T10:17:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e9bc354258f567802f6a78e4d7e1c9bb262d6ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9/commits","review_comments_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9/comments","review_comment_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/9/comments","statuses_url":"https://api.github.com/repos/woju/qubes-core-admin/statuses/bc96b4374dcd0224b3172365e95d1a0493c20034","head":{"label":"kalkin:qvm-pool","ref":"qvm-pool","sha":"bc96b4374dcd0224b3172365e95d1a0493c20034","user":{"login":"kalkin","id":145191,"avatar_url":"https://avatars.githubusercontent.com/u/145191?v=3","gravatar_id":"","url":"https://api.github.com/users/kalkin","html_url":"https://github.com/kalkin","followers_url":"https://api.github.com/users/kalkin/followers","following_url":"https://api.github.com/users/kalkin/following{/other_user}","gists_url":"https://api.github.com/users/kalkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalkin/subscriptions","organizations_url":"https://api.github.com/users/kalkin/orgs","repos_url":"https://api.github.com/users/kalkin/repos","events_url":"https://api.github.com/users/kalkin/events{/privacy}","received_events_url":"https://api.github.com/users/kalkin/received_events","type":"User","site_admin":false},"repo":{"id":30782377,"name":"qubes-core-admin","full_name":"kalkin/qubes-core-admin","owner":{"login":"kalkin","id":145191,"avatar_url":"https://avatars.githubusercontent.com/u/145191?v=3","gravatar_id":"","url":"https://api.github.com/users/kalkin","html_url":"https://github.com/kalkin","followers_url":"https://api.github.com/users/kalkin/followers","following_url":"https://api.github.com/users/kalkin/following{/other_user}","gists_url":"https://api.github.com/users/kalkin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalkin/subscriptions","organizations_url":"https://api.github.com/users/kalkin/orgs","repos_url":"https://api.github.com/users/kalkin/repos","events_url":"https://api.github.com/users/kalkin/events{/privacy}","received_events_url":"https://api.github.com/users/kalkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalkin/qubes-core-admin","description":"Qubes component: core-admin","fork":true,"url":"https://api.github.com/repos/kalkin/qubes-core-admin","forks_url":"https://api.github.com/repos/kalkin/qubes-core-admin/forks","keys_url":"https://api.github.com/repos/kalkin/qubes-core-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalkin/qubes-core-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalkin/qubes-core-admin/teams","hooks_url":"https://api.github.com/repos/kalkin/qubes-core-admin/hooks","issue_events_url":"https://api.github.com/repos/kalkin/qubes-core-admin/issues/events{/number}","events_url":"https://api.github.com/repos/kalkin/qubes-core-admin/events","assignees_url":"https://api.github.com/repos/kalkin/qubes-core-admin/assignees{/user}","branches_url":"https://api.github.com/repos/kalkin/qubes-core-admin/branches{/branch}","tags_url":"https://api.github.com/repos/kalkin/qubes-core-admin/tags","blobs_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalkin/qubes-core-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/kalkin/qubes-core-admin/languages","stargazers_url":"https://api.github.com/repos/kalkin/qubes-core-admin/stargazers","contributors_url":"https://api.github.com/repos/kalkin/qubes-core-admin/contributors","subscribers_url":"https://api.github.com/repos/kalkin/qubes-core-admin/subscribers","subscription_url":"https://api.github.com/repos/kalkin/qubes-core-admin/subscription","commits_url":"https://api.github.com/repos/kalkin/qubes-core-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalkin/qubes-core-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalkin/qubes-core-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalkin/qubes-core-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalkin/qubes-core-admin/contents/{+path}","compare_url":"https://api.github.com/repos/kalkin/qubes-core-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalkin/qubes-core-admin/merges","archive_url":"https://api.github.com/repos/kalkin/qubes-core-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalkin/qubes-core-admin/downloads","issues_url":"https://api.github.com/repos/kalkin/qubes-core-admin/issues{/number}","pulls_url":"https://api.github.com/repos/kalkin/qubes-core-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/kalkin/qubes-core-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/kalkin/qubes-core-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalkin/qubes-core-admin/labels{/name}","releases_url":"https://api.github.com/repos/kalkin/qubes-core-admin/releases{/id}","deployments_url":"https://api.github.com/repos/kalkin/qubes-core-admin/deployments","created_at":"2015-02-14T00:36:10Z","updated_at":"2016-04-25T12:11:17Z","pushed_at":"2016-04-29T16:52:02Z","git_url":"git://github.com/kalkin/qubes-core-admin.git","ssh_url":"git@github.com:kalkin/qubes-core-admin.git","clone_url":"https://github.com/kalkin/qubes-core-admin.git","svn_url":"https://github.com/kalkin/qubes-core-admin","homepage":null,"size":10026,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"woju:core3-devel","ref":"core3-devel","sha":"044aefe25a5b4aa4ad3fe35093141c3ff4f2d463","user":{"login":"woju","id":1550337,"avatar_url":"https://avatars.githubusercontent.com/u/1550337?v=3","gravatar_id":"","url":"https://api.github.com/users/woju","html_url":"https://github.com/woju","followers_url":"https://api.github.com/users/woju/followers","following_url":"https://api.github.com/users/woju/following{/other_user}","gists_url":"https://api.github.com/users/woju/gists{/gist_id}","starred_url":"https://api.github.com/users/woju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woju/subscriptions","organizations_url":"https://api.github.com/users/woju/orgs","repos_url":"https://api.github.com/users/woju/repos","events_url":"https://api.github.com/users/woju/events{/privacy}","received_events_url":"https://api.github.com/users/woju/received_events","type":"User","site_admin":false},"repo":{"id":31896140,"name":"qubes-core-admin","full_name":"woju/qubes-core-admin","owner":{"login":"woju","id":1550337,"avatar_url":"https://avatars.githubusercontent.com/u/1550337?v=3","gravatar_id":"","url":"https://api.github.com/users/woju","html_url":"https://github.com/woju","followers_url":"https://api.github.com/users/woju/followers","following_url":"https://api.github.com/users/woju/following{/other_user}","gists_url":"https://api.github.com/users/woju/gists{/gist_id}","starred_url":"https://api.github.com/users/woju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woju/subscriptions","organizations_url":"https://api.github.com/users/woju/orgs","repos_url":"https://api.github.com/users/woju/repos","events_url":"https://api.github.com/users/woju/events{/privacy}","received_events_url":"https://api.github.com/users/woju/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woju/qubes-core-admin","description":"Qubes component: core-admin","fork":true,"url":"https://api.github.com/repos/woju/qubes-core-admin","forks_url":"https://api.github.com/repos/woju/qubes-core-admin/forks","keys_url":"https://api.github.com/repos/woju/qubes-core-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woju/qubes-core-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woju/qubes-core-admin/teams","hooks_url":"https://api.github.com/repos/woju/qubes-core-admin/hooks","issue_events_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/events{/number}","events_url":"https://api.github.com/repos/woju/qubes-core-admin/events","assignees_url":"https://api.github.com/repos/woju/qubes-core-admin/assignees{/user}","branches_url":"https://api.github.com/repos/woju/qubes-core-admin/branches{/branch}","tags_url":"https://api.github.com/repos/woju/qubes-core-admin/tags","blobs_url":"https://api.github.com/repos/woju/qubes-core-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woju/qubes-core-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woju/qubes-core-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/woju/qubes-core-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woju/qubes-core-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/woju/qubes-core-admin/languages","stargazers_url":"https://api.github.com/repos/woju/qubes-core-admin/stargazers","contributors_url":"https://api.github.com/repos/woju/qubes-core-admin/contributors","subscribers_url":"https://api.github.com/repos/woju/qubes-core-admin/subscribers","subscription_url":"https://api.github.com/repos/woju/qubes-core-admin/subscription","commits_url":"https://api.github.com/repos/woju/qubes-core-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/woju/qubes-core-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/woju/qubes-core-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/woju/qubes-core-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/woju/qubes-core-admin/contents/{+path}","compare_url":"https://api.github.com/repos/woju/qubes-core-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woju/qubes-core-admin/merges","archive_url":"https://api.github.com/repos/woju/qubes-core-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woju/qubes-core-admin/downloads","issues_url":"https://api.github.com/repos/woju/qubes-core-admin/issues{/number}","pulls_url":"https://api.github.com/repos/woju/qubes-core-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/woju/qubes-core-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/woju/qubes-core-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woju/qubes-core-admin/labels{/name}","releases_url":"https://api.github.com/repos/woju/qubes-core-admin/releases{/id}","deployments_url":"https://api.github.com/repos/woju/qubes-core-admin/deployments","created_at":"2015-03-09T12:04:24Z","updated_at":"2016-01-29T16:57:09Z","pushed_at":"2016-04-29T16:57:09Z","git_url":"git://github.com/woju/qubes-core-admin.git","ssh_url":"git@github.com:woju/qubes-core-admin.git","clone_url":"https://github.com/woju/qubes-core-admin.git","svn_url":"https://github.com/woju/qubes-core-admin","homepage":null,"size":11865,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"core3-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9"},"html":{"href":"https://github.com/woju/qubes-core-admin/pull/9"},"issue":{"href":"https://api.github.com/repos/woju/qubes-core-admin/issues/9"},"comments":{"href":"https://api.github.com/repos/woju/qubes-core-admin/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woju/qubes-core-admin/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/woju/qubes-core-admin/statuses/bc96b4374dcd0224b3172365e95d1a0493c20034"}}}}