{"action":"created","issue":{"url":"https://api.github.com/repos/javaslang/javaslang/issues/1576","repository_url":"https://api.github.com/repos/javaslang/javaslang","labels_url":"https://api.github.com/repos/javaslang/javaslang/issues/1576/labels{/name}","comments_url":"https://api.github.com/repos/javaslang/javaslang/issues/1576/comments","events_url":"https://api.github.com/repos/javaslang/javaslang/issues/1576/events","html_url":"https://github.com/javaslang/javaslang/pull/1576","id":177671750,"number":1576,"title":"Applied PR #1571 review comments of @paplorinc","user":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/javaslang/javaslang/labels/design/refactoring/improvement","name":"design/refactoring/improvement","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/javaslang/javaslang/milestones/22","html_url":"https://github.com/javaslang/javaslang/milestones/2.0.4","labels_url":"https://api.github.com/repos/javaslang/javaslang/milestones/22/labels","id":1787074,"number":22,"title":"2.0.4","description":"Bugfix Release 2.0.4","creator":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":22,"state":"open","created_at":"2016-05-25T10:19:59Z","updated_at":"2016-09-18T19:42:04Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-09-18T19:42:04Z","updated_at":"2016-09-19T15:30:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/1576","html_url":"https://github.com/javaslang/javaslang/pull/1576","diff_url":"https://github.com/javaslang/javaslang/pull/1576.diff","patch_url":"https://github.com/javaslang/javaslang/pull/1576.patch"},"body":"Follow-up PR of #1571"},"comment":{"url":"https://api.github.com/repos/javaslang/javaslang/issues/comments/248027165","html_url":"https://github.com/javaslang/javaslang/pull/1576#issuecomment-248027165","issue_url":"https://api.github.com/repos/javaslang/javaslang/issues/1576","id":248027165,"user":{"login":"paplorinc","id":1841944,"avatar_url":"https://avatars.githubusercontent.com/u/1841944?v=3","gravatar_id":"","url":"https://api.github.com/users/paplorinc","html_url":"https://github.com/paplorinc","followers_url":"https://api.github.com/users/paplorinc/followers","following_url":"https://api.github.com/users/paplorinc/following{/other_user}","gists_url":"https://api.github.com/users/paplorinc/gists{/gist_id}","starred_url":"https://api.github.com/users/paplorinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paplorinc/subscriptions","organizations_url":"https://api.github.com/users/paplorinc/orgs","repos_url":"https://api.github.com/users/paplorinc/repos","events_url":"https://api.github.com/users/paplorinc/events{/privacy}","received_events_url":"https://api.github.com/users/paplorinc/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T15:30:31Z","updated_at":"2016-09-19T15:30:31Z","body":"Memoization (mutation / multi threading in general) performance is difficult measure properly.\r\nI tried to come up with a good benchmarks, but I modified more things than I should quote here, so I created a separate PR for it (since it includes an alternative optimization also).\r\nI hope you don't mind me hijacking your PR :)\r\n\r\nThe benchmark compares simple eager access (`java_eager`) to `Lazy`'s first access (`slang_lazy`) and subsequent, initialized access (`slang_inited_lazy`):\r\n\r\nThese are the measurements:\r\n```java\r\nBefore:\r\n    java_eager/slang_inited_lazy  1.17×\r\n    java_eager/slang_lazy         6.89×\r\n\r\nCurrent PR:\r\n    java_eager/slang_inited_lazy  1.07×\r\n    java_eager/slang_lazy         6.56×\r\n\r\nAlternative:\r\n    java_eager/slang_inited_lazy  1.02×\r\n    java_eager/slang_lazy         6.73×\r\n```\r\n\r\ni.e. before is the worst, your solution is faster for first access, the alternative is faster after the first access.\r\n\r\nSee: #1577"}}
{"actor":{"display_login":"paplorinc"}}