{"action":"created","issue":{"url":"https://api.github.com/repos/micjamking/devtools-author/issues/19","repository_url":"https://api.github.com/repos/micjamking/devtools-author","labels_url":"https://api.github.com/repos/micjamking/devtools-author/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/micjamking/devtools-author/issues/19/comments","events_url":"https://api.github.com/repos/micjamking/devtools-author/issues/19/events","html_url":"https://github.com/micjamking/devtools-author/issues/19","id":106215871,"number":19,"title":"[1.0] Add unit tests","user":{"login":"micjamking","id":651702,"avatar_url":"https://avatars.githubusercontent.com/u/651702?v=3","gravatar_id":"","url":"https://api.github.com/users/micjamking","html_url":"https://github.com/micjamking","followers_url":"https://api.github.com/users/micjamking/followers","following_url":"https://api.github.com/users/micjamking/following{/other_user}","gists_url":"https://api.github.com/users/micjamking/gists{/gist_id}","starred_url":"https://api.github.com/users/micjamking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micjamking/subscriptions","organizations_url":"https://api.github.com/users/micjamking/orgs","repos_url":"https://api.github.com/users/micjamking/repos","events_url":"https://api.github.com/users/micjamking/events{/privacy}","received_events_url":"https://api.github.com/users/micjamking/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/micjamking/devtools-author/labels/development","name":"development","color":"eb6420"},{"url":"https://api.github.com/repos/micjamking/devtools-author/labels/enhancement","name":"enhancement","color":"bfd4f2"},{"url":"https://api.github.com/repos/micjamking/devtools-author/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/micjamking/devtools-author/labels/low","name":"low","color":"f7c6c7"}],"state":"open","locked":false,"assignee":{"login":"micjamking","id":651702,"avatar_url":"https://avatars.githubusercontent.com/u/651702?v=3","gravatar_id":"","url":"https://api.github.com/users/micjamking","html_url":"https://github.com/micjamking","followers_url":"https://api.github.com/users/micjamking/followers","following_url":"https://api.github.com/users/micjamking/following{/other_user}","gists_url":"https://api.github.com/users/micjamking/gists{/gist_id}","starred_url":"https://api.github.com/users/micjamking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micjamking/subscriptions","organizations_url":"https://api.github.com/users/micjamking/orgs","repos_url":"https://api.github.com/users/micjamking/repos","events_url":"https://api.github.com/users/micjamking/events{/privacy}","received_events_url":"https://api.github.com/users/micjamking/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/micjamking/devtools-author/milestones/1","html_url":"https://github.com/micjamking/devtools-author/milestones/1.0%20-%20Stable%20Release","labels_url":"https://api.github.com/repos/micjamking/devtools-author/milestones/1/labels","id":1294854,"number":1,"title":"1.0 - Stable Release","description":"","creator":{"login":"micjamking","id":651702,"avatar_url":"https://avatars.githubusercontent.com/u/651702?v=3","gravatar_id":"","url":"https://api.github.com/users/micjamking","html_url":"https://github.com/micjamking","followers_url":"https://api.github.com/users/micjamking/followers","following_url":"https://api.github.com/users/micjamking/following{/other_user}","gists_url":"https://api.github.com/users/micjamking/gists{/gist_id}","starred_url":"https://api.github.com/users/micjamking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micjamking/subscriptions","organizations_url":"https://api.github.com/users/micjamking/orgs","repos_url":"https://api.github.com/users/micjamking/repos","events_url":"https://api.github.com/users/micjamking/events{/privacy}","received_events_url":"https://api.github.com/users/micjamking/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":18,"state":"open","created_at":"2015-09-08T07:54:37Z","updated_at":"2016-02-14T04:26:39Z","due_on":"2016-05-03T10:00:00Z","closed_at":null},"comments":11,"created_at":"2015-09-13T12:59:23Z","updated_at":"2016-02-15T23:03:34Z","closed_at":null,"body":"Create unit tests for setting up the extension dependencies and communication with `chrome.storage`. A majority of the functionality is reliant on the successful return of several XHR's and the unit tests should reflect this behavior. Third-party functionality (ie. `chrome.storage` and `chrome.devtools.panels`) should be stubbed out appropriately.\r\n\r\n## Unit testing scope\r\n\r\n**DevTools Extension: [app/scripts/devtools.js](https://github.com/micjamking/devtools-author/blob/master/app/scripts/devtools.js)**\r\n- **app.loadTheme:** gets stylesheet name from `chrome.storage` via XHR and fires callback function if returns success 200\r\n- **app.init:** creates 'Author Settings' panel via `chrome.devtools.panels` and loads panel html page\r\n\r\n**Author Settings panel: [app/scripts/panel.js](https://github.com/micjamking/devtools-author/blob/master/app/scripts/panel.js)**\r\n- **init:** gets `theme.json` via XHR and fires callback function if returns success 200\r\n- **getTheme:** gets `devtools-theme` from `chrome.storage` and returns it for display in UI\r\n- **getFontFamily:** gets `devtools-fontFamily` from `chrome.storage` and returns it for display in UI\r\n- **getFontSize:** gets `devtools-fontSize` from `chrome.storage` and returns it for display in UI\r\n\r\n**References:**\r\n- http://stackoverflow.com/questions/2869827/how-to-test-chrome-extensions\r\n- http://stackoverflow.com/questions/14798528/testing-browser-extensions/17370531#17370531\r\n- https://github.com/vitalets/sinon-chrome"},"comment":{"url":"https://api.github.com/repos/micjamking/devtools-author/issues/comments/184434376","html_url":"https://github.com/micjamking/devtools-author/issues/19#issuecomment-184434376","issue_url":"https://api.github.com/repos/micjamking/devtools-author/issues/19","id":184434376,"user":{"login":"benniemosher","id":337539,"avatar_url":"https://avatars.githubusercontent.com/u/337539?v=3","gravatar_id":"","url":"https://api.github.com/users/benniemosher","html_url":"https://github.com/benniemosher","followers_url":"https://api.github.com/users/benniemosher/followers","following_url":"https://api.github.com/users/benniemosher/following{/other_user}","gists_url":"https://api.github.com/users/benniemosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benniemosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benniemosher/subscriptions","organizations_url":"https://api.github.com/users/benniemosher/orgs","repos_url":"https://api.github.com/users/benniemosher/repos","events_url":"https://api.github.com/users/benniemosher/events{/privacy}","received_events_url":"https://api.github.com/users/benniemosher/received_events","type":"User","site_admin":false},"created_at":"2016-02-15T23:03:33Z","updated_at":"2016-02-15T23:03:33Z","body":"My vote is that we do that in an isolated branch until it gets updated in\ntheir master. It will at least allow us to get testing.\n\n\n\n--\n\nThanks,\n\nBennie Mosher\nhttps://benniemosher.com\n+1 (970) 590-2040\n\nOn Mon, Feb 15, 2016 at 3:51 PM, Tony Gaskell <notifications@github.com>\nwrote:\n\n> I have a forked version of karma-sinon-chrome and opened a PR (\n> 9joneg/karma-sinon-chrome#2\n> <https://github.com/9joneg/karma-sinon-chrome/pull/2>) in hopes of\n> getting that to be updated.\n>\n> In the mean time, do you want to just link to the forked repo?\n> https://github.com/thgaskell/karma-sinon-chrome\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/micjamking/devtools-author/issues/19#issuecomment-184428645>\n> .\n>\n"}}