{"action":"closed","number":117,"pull_request":{"url":"https://api.github.com/repos/RackHD/on-tasks/pulls/117","id":58119693,"html_url":"https://github.com/RackHD/on-tasks/pull/117","diff_url":"https://github.com/RackHD/on-tasks/pull/117.diff","patch_url":"https://github.com/RackHD/on-tasks/pull/117.patch","issue_url":"https://api.github.com/repos/RackHD/on-tasks/issues/117","number":117,"state":"closed","locked":false,"title":"Add valid ip to lookups when discovery regardless of its source","user":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"body":"Currently there are two cases in RackHD that the BMC MAC-IP relations will be put into lookups:\r\n1.\tBMC IP is DHCP and in the subnet of eth1\r\n2.\tBMC IP is static\r\n\r\nThere is also the case where BMC is DHCP in subnet of ORA eth0 with a valid IP address (the IP address is assigned by external DHCP server in eth0).\r\n\r\nThis PR covers the above case, removing check of \"DHCP\" source in bmc catalogs when adding lookup entry. It will not cause duplicate in lookups, since lookup.js in on-core has covered this situation.","created_at":"2016-02-03T10:46:51Z","updated_at":"2016-02-04T08:00:27Z","closed_at":"2016-02-04T08:00:27Z","merged_at":"2016-02-04T08:00:27Z","merge_commit_sha":"8d1af188a1dc89a99108bada8c45c5aee9d24e3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/117/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/117/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/issues/117/comments","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/0fd5bfd0f497a1b8422b4fcbd6a8cb293abc1dee","head":{"label":"iceiilin:bmc_dhcp","ref":"bmc_dhcp","sha":"0fd5bfd0f497a1b8422b4fcbd6a8cb293abc1dee","user":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"repo":{"id":45585883,"name":"on-tasks","full_name":"iceiilin/on-tasks","owner":{"login":"iceiilin","id":10793130,"avatar_url":"https://avatars.githubusercontent.com/u/10793130?v=3","gravatar_id":"","url":"https://api.github.com/users/iceiilin","html_url":"https://github.com/iceiilin","followers_url":"https://api.github.com/users/iceiilin/followers","following_url":"https://api.github.com/users/iceiilin/following{/other_user}","gists_url":"https://api.github.com/users/iceiilin/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiilin/subscriptions","organizations_url":"https://api.github.com/users/iceiilin/orgs","repos_url":"https://api.github.com/users/iceiilin/repos","events_url":"https://api.github.com/users/iceiilin/events{/privacy}","received_events_url":"https://api.github.com/users/iceiilin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iceiilin/on-tasks","description":"","fork":true,"url":"https://api.github.com/repos/iceiilin/on-tasks","forks_url":"https://api.github.com/repos/iceiilin/on-tasks/forks","keys_url":"https://api.github.com/repos/iceiilin/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iceiilin/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iceiilin/on-tasks/teams","hooks_url":"https://api.github.com/repos/iceiilin/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/iceiilin/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/iceiilin/on-tasks/events","assignees_url":"https://api.github.com/repos/iceiilin/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/iceiilin/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/iceiilin/on-tasks/tags","blobs_url":"https://api.github.com/repos/iceiilin/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iceiilin/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iceiilin/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/iceiilin/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iceiilin/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/iceiilin/on-tasks/languages","stargazers_url":"https://api.github.com/repos/iceiilin/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/iceiilin/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/iceiilin/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/iceiilin/on-tasks/subscription","commits_url":"https://api.github.com/repos/iceiilin/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/iceiilin/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/iceiilin/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/iceiilin/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/iceiilin/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/iceiilin/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iceiilin/on-tasks/merges","archive_url":"https://api.github.com/repos/iceiilin/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iceiilin/on-tasks/downloads","issues_url":"https://api.github.com/repos/iceiilin/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/iceiilin/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/iceiilin/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/iceiilin/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iceiilin/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/iceiilin/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/iceiilin/on-tasks/deployments","created_at":"2015-11-05T03:47:11Z","updated_at":"2015-11-05T03:47:13Z","pushed_at":"2016-02-04T07:01:49Z","git_url":"git://github.com/iceiilin/on-tasks.git","ssh_url":"git@github.com:iceiilin/on-tasks.git","clone_url":"https://github.com/iceiilin/on-tasks.git","svn_url":"https://github.com/iceiilin/on-tasks","homepage":null,"size":996,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"75339959c79021a4a03177706ad3aceb5e1b699d","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690099,"name":"on-tasks","full_name":"RackHD/on-tasks","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-tasks","description":"","fork":false,"url":"https://api.github.com/repos/RackHD/on-tasks","forks_url":"https://api.github.com/repos/RackHD/on-tasks/forks","keys_url":"https://api.github.com/repos/RackHD/on-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-tasks/teams","hooks_url":"https://api.github.com/repos/RackHD/on-tasks/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-tasks/events","assignees_url":"https://api.github.com/repos/RackHD/on-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-tasks/tags","blobs_url":"https://api.github.com/repos/RackHD/on-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-tasks/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-tasks/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-tasks/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-tasks/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-tasks/subscription","commits_url":"https://api.github.com/repos/RackHD/on-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-tasks/merges","archive_url":"https://api.github.com/repos/RackHD/on-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-tasks/downloads","issues_url":"https://api.github.com/repos/RackHD/on-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-tasks/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-tasks/deployments","created_at":"2015-08-31T17:29:32Z","updated_at":"2016-01-31T09:07:09Z","pushed_at":"2016-02-04T08:00:27Z","git_url":"git://github.com/RackHD/on-tasks.git","ssh_url":"git@github.com:RackHD/on-tasks.git","clone_url":"https://github.com/RackHD/on-tasks.git","svn_url":"https://github.com/RackHD/on-tasks","homepage":null,"size":1048,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":5,"forks":27,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/117"},"html":{"href":"https://github.com/RackHD/on-tasks/pull/117"},"issue":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/117"},"comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-tasks/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-tasks/statuses/0fd5bfd0f497a1b8422b4fcbd6a8cb293abc1dee"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"benbp","id":1020379,"avatar_url":"https://avatars.githubusercontent.com/u/1020379?v=3","gravatar_id":"","url":"https://api.github.com/users/benbp","html_url":"https://github.com/benbp","followers_url":"https://api.github.com/users/benbp/followers","following_url":"https://api.github.com/users/benbp/following{/other_user}","gists_url":"https://api.github.com/users/benbp/gists{/gist_id}","starred_url":"https://api.github.com/users/benbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benbp/subscriptions","organizations_url":"https://api.github.com/users/benbp/orgs","repos_url":"https://api.github.com/users/benbp/repos","events_url":"https://api.github.com/users/benbp/events{/privacy}","received_events_url":"https://api.github.com/users/benbp/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":35,"deletions":34,"changed_files":3}}