{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/hmda-platform/issues/471","repository_url":"https://api.github.com/repos/cfpb/hmda-platform","labels_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/471/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/471/comments","events_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/471/events","html_url":"https://github.com/cfpb/hmda-platform/issues/471","id":168747555,"number":471,"title":"How should we handle optional edits?","user":{"login":"hkeeler","id":4269085,"avatar_url":"https://avatars.githubusercontent.com/u/4269085?v=3","gravatar_id":"","url":"https://api.github.com/users/hkeeler","html_url":"https://github.com/hkeeler","followers_url":"https://api.github.com/users/hkeeler/followers","following_url":"https://api.github.com/users/hkeeler/following{/other_user}","gists_url":"https://api.github.com/users/hkeeler/gists{/gist_id}","starred_url":"https://api.github.com/users/hkeeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkeeler/subscriptions","organizations_url":"https://api.github.com/users/hkeeler/orgs","repos_url":"https://api.github.com/users/hkeeler/repos","events_url":"https://api.github.com/users/hkeeler/events{/privacy}","received_events_url":"https://api.github.com/users/hkeeler/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cfpb/hmda-platform/labels/Data%20Validation","name":"Data Validation","color":"5319e7"},{"url":"https://api.github.com/repos/cfpb/hmda-platform/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-01T21:33:33Z","updated_at":"2016-09-12T14:37:56Z","closed_at":null,"body":"As mentioned on #452, certain edits cannot be applied under certain circumstances.  For example, we want to allow anonymous LAR validations, and thus, all edits that compare LAR data to the institution data of the filer, cannot be applied.\r\n\r\nOur first attempt on #452 was to filter out these edits in validation engines when the optional data (`Institution`) was not present.  However, we moved that logic to within the edit itself, always returning `Success()` when the optional data is not present.  This made testing much easier, but does give the false sense that a given edit _passed_ when it was really _ignored_.  It also means we'd be duplicating this logic within each edit that follows this pattern.\r\n\r\nI'm curious to get other's thoughts on this.  There are currently only 5 edits with this optional institution .  I'm not sure if there are other types edits that need to be made optionalized.  That may drive whether or not this should be institution-specific, or something more general."},"comment":{"url":"https://api.github.com/repos/cfpb/hmda-platform/issues/comments/246368322","html_url":"https://github.com/cfpb/hmda-platform/issues/471#issuecomment-246368322","issue_url":"https://api.github.com/repos/cfpb/hmda-platform/issues/471","id":246368322,"user":{"login":"jmarin","id":438146,"avatar_url":"https://avatars.githubusercontent.com/u/438146?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarin","html_url":"https://github.com/jmarin","followers_url":"https://api.github.com/users/jmarin/followers","following_url":"https://api.github.com/users/jmarin/following{/other_user}","gists_url":"https://api.github.com/users/jmarin/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarin/subscriptions","organizations_url":"https://api.github.com/users/jmarin/orgs","repos_url":"https://api.github.com/users/jmarin/repos","events_url":"https://api.github.com/users/jmarin/events{/privacy}","received_events_url":"https://api.github.com/users/jmarin/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T14:37:56Z","updated_at":"2016-09-12T14:37:56Z","body":"@hkeeler @lgdean can this be closed?"}}
{"actor":{"display_login":"jmarin"}}