{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/81652246","pull_request_review_id":2617115,"id":81652246,"diff_hunk":"@@ -151,9 +171,34 @@ public void describeTo(Description description) {\n \n   @Override\n   public void describeMismatchSafely(PipelineResult pResult, Description description) {\n-    description\n-        .appendText(\"was (\")\n-        .appendText(actualChecksum)\n-        .appendText(\")\");\n+    String info;\n+    if (response == null) {\n+      info = \"BigQuery response is null\";\n+    } else if (response.getRows() == null) {\n+      info = \"rows that is from BigQuery response is null\";\n+    } else if (response.getRows().isEmpty()) {\n+      info = \"rows that is from BigQuery response is empty\";\n+    } else {\n+      info = String.format(\"was (%s).%n\"\n+          + \"\\tTotal number of rows are: %d.%n\"\n+          + \"\\tQueried data details:%s\",\n+          actualChecksum, response.getTotalRows(), printRows(4));","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/testing/BigqueryMatcher.java","position":185,"original_position":176,"commit_id":"2b05b04b95449e9278b1c83514b336f5607c92fc","original_commit_id":"2b05b04b95449e9278b1c83514b336f5607c92fc","user":{"login":"jasonkuster","id":2396054,"avatar_url":"https://avatars.githubusercontent.com/u/2396054?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonkuster","html_url":"https://github.com/jasonkuster","followers_url":"https://api.github.com/users/jasonkuster/followers","following_url":"https://api.github.com/users/jasonkuster/following{/other_user}","gists_url":"https://api.github.com/users/jasonkuster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonkuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonkuster/subscriptions","organizations_url":"https://api.github.com/users/jasonkuster/orgs","repos_url":"https://api.github.com/users/jasonkuster/repos","events_url":"https://api.github.com/users/jasonkuster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonkuster/received_events","type":"User","site_admin":false},"body":"Pull the 4 out into a constant, also we discussed in person today making this more like 20.","created_at":"2016-10-03T22:19:21Z","updated_at":"2016-10-03T22:40:41Z","html_url":"https://github.com/apache/incubator-beam/pull/990#discussion_r81652246","pull_request_url":"https://api.github.com/repos/apache/incubator-beam/pulls/990","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments/81652246"},"html":{"href":"https://github.com/apache/incubator-beam/pull/990#discussion_r81652246"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/990"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-beam/pulls/990","id":86419025,"html_url":"https://github.com/apache/incubator-beam/pull/990","diff_url":"https://github.com/apache/incubator-beam/pull/990.diff","patch_url":"https://github.com/apache/incubator-beam/pull/990.patch","issue_url":"https://api.github.com/repos/apache/incubator-beam/issues/990","number":990,"state":"open","locked":false,"title":"[BEAM-605] Create Bigquery Verifier","user":{"login":"markflyhigh","id":4008895,"avatar_url":"https://avatars.githubusercontent.com/u/4008895?v=3","gravatar_id":"","url":"https://api.github.com/users/markflyhigh","html_url":"https://github.com/markflyhigh","followers_url":"https://api.github.com/users/markflyhigh/followers","following_url":"https://api.github.com/users/markflyhigh/following{/other_user}","gists_url":"https://api.github.com/users/markflyhigh/gists{/gist_id}","starred_url":"https://api.github.com/users/markflyhigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markflyhigh/subscriptions","organizations_url":"https://api.github.com/users/markflyhigh/orgs","repos_url":"https://api.github.com/users/markflyhigh/repos","events_url":"https://api.github.com/users/markflyhigh/events{/privacy}","received_events_url":"https://api.github.com/users/markflyhigh/received_events","type":"User","site_admin":false},"body":"Be sure to do all of the following to help us incorporate your contribution\r\nquickly and easily:\r\n\r\n - [x] Make sure the PR title is formatted like:\r\n   `[BEAM-<Jira issue #>] Description of pull request`\r\n - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable\r\n       Travis-CI on your fork and ensure the whole test matrix passes).\r\n - [x] Replace `<Jira issue #>` in the title with the actual Jira issue\r\n       number, if there is one.\r\n - [ ] If this contribution is large, please file an Apache\r\n       [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).\r\n\r\n---\r\n\r\n - Create BigqueryMatcher that is used to verify Bigquery data in integration test.\r\n - Add BigqueryMatcher to BigQueryTornadoesIT for output verification. \r\n\r\nExample command is used to running BigQueryTornadoesIT:\r\n```\r\nmvn clean verify -pl examples/java -am -DskipITs=false -Dit.test=BigQueryTornadoesIT -DintegrationTestPipelineOptions='[ \"--tempRoot=gs://clouddfe-testing-temp-storage\", \"--runner=org.apache.beam.runners.dataflow.testing.TestDataflowRunner\" ]'\r\n```","created_at":"2016-09-22T21:36:01Z","updated_at":"2016-10-03T22:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acec16b059d5cf9c3cf6f13aed0d00e3ceb9fb80","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-beam/pulls/990/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-beam/pulls/990/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-beam/issues/990/comments","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/2b05b04b95449e9278b1c83514b336f5607c92fc","head":{"label":"markflyhigh:bigquery-data-IT-verifier","ref":"bigquery-data-IT-verifier","sha":"2b05b04b95449e9278b1c83514b336f5607c92fc","user":{"login":"markflyhigh","id":4008895,"avatar_url":"https://avatars.githubusercontent.com/u/4008895?v=3","gravatar_id":"","url":"https://api.github.com/users/markflyhigh","html_url":"https://github.com/markflyhigh","followers_url":"https://api.github.com/users/markflyhigh/followers","following_url":"https://api.github.com/users/markflyhigh/following{/other_user}","gists_url":"https://api.github.com/users/markflyhigh/gists{/gist_id}","starred_url":"https://api.github.com/users/markflyhigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markflyhigh/subscriptions","organizations_url":"https://api.github.com/users/markflyhigh/orgs","repos_url":"https://api.github.com/users/markflyhigh/repos","events_url":"https://api.github.com/users/markflyhigh/events{/privacy}","received_events_url":"https://api.github.com/users/markflyhigh/received_events","type":"User","site_admin":false},"repo":{"id":61327747,"name":"incubator-beam","full_name":"markflyhigh/incubator-beam","owner":{"login":"markflyhigh","id":4008895,"avatar_url":"https://avatars.githubusercontent.com/u/4008895?v=3","gravatar_id":"","url":"https://api.github.com/users/markflyhigh","html_url":"https://github.com/markflyhigh","followers_url":"https://api.github.com/users/markflyhigh/followers","following_url":"https://api.github.com/users/markflyhigh/following{/other_user}","gists_url":"https://api.github.com/users/markflyhigh/gists{/gist_id}","starred_url":"https://api.github.com/users/markflyhigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markflyhigh/subscriptions","organizations_url":"https://api.github.com/users/markflyhigh/orgs","repos_url":"https://api.github.com/users/markflyhigh/repos","events_url":"https://api.github.com/users/markflyhigh/events{/privacy}","received_events_url":"https://api.github.com/users/markflyhigh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markflyhigh/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/markflyhigh/incubator-beam","forks_url":"https://api.github.com/repos/markflyhigh/incubator-beam/forks","keys_url":"https://api.github.com/repos/markflyhigh/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markflyhigh/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markflyhigh/incubator-beam/teams","hooks_url":"https://api.github.com/repos/markflyhigh/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/markflyhigh/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/markflyhigh/incubator-beam/events","assignees_url":"https://api.github.com/repos/markflyhigh/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/markflyhigh/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/markflyhigh/incubator-beam/tags","blobs_url":"https://api.github.com/repos/markflyhigh/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markflyhigh/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markflyhigh/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/markflyhigh/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markflyhigh/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/markflyhigh/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/markflyhigh/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/markflyhigh/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/markflyhigh/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/markflyhigh/incubator-beam/subscription","commits_url":"https://api.github.com/repos/markflyhigh/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/markflyhigh/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/markflyhigh/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/markflyhigh/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/markflyhigh/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/markflyhigh/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markflyhigh/incubator-beam/merges","archive_url":"https://api.github.com/repos/markflyhigh/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markflyhigh/incubator-beam/downloads","issues_url":"https://api.github.com/repos/markflyhigh/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/markflyhigh/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/markflyhigh/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/markflyhigh/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markflyhigh/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/markflyhigh/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/markflyhigh/incubator-beam/deployments","created_at":"2016-06-16T21:43:00Z","updated_at":"2016-06-16T21:43:04Z","pushed_at":"2016-09-30T22:55:58Z","git_url":"git://github.com/markflyhigh/incubator-beam.git","ssh_url":"git@github.com:markflyhigh/incubator-beam.git","clone_url":"https://github.com/markflyhigh/incubator-beam.git","svn_url":"https://github.com/markflyhigh/incubator-beam","homepage":null,"size":18898,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2b8b20ded545bbb4fcbf3f196c6b965aa5e158ae","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"name":"incubator-beam","full_name":"apache/incubator-beam","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-beam","forks_url":"https://api.github.com/repos/apache/incubator-beam/forks","keys_url":"https://api.github.com/repos/apache/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-beam/teams","hooks_url":"https://api.github.com/repos/apache/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-beam/events","assignees_url":"https://api.github.com/repos/apache/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-beam/tags","blobs_url":"https://api.github.com/repos/apache/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-beam/subscription","commits_url":"https://api.github.com/repos/apache/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-beam/merges","archive_url":"https://api.github.com/repos/apache/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-beam/downloads","issues_url":"https://api.github.com/repos/apache/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2016-10-02T20:26:55Z","pushed_at":"2016-10-03T22:14:22Z","git_url":"git://github.com/apache/incubator-beam.git","ssh_url":"git@github.com:apache/incubator-beam.git","clone_url":"https://github.com/apache/incubator-beam.git","svn_url":"https://github.com/apache/incubator-beam","homepage":null,"size":29050,"stargazers_count":375,"watchers_count":375,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":237,"mirror_url":"git://git.apache.org/incubator-beam.git","open_issues_count":49,"forks":237,"open_issues":49,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/990"},"html":{"href":"https://github.com/apache/incubator-beam/pull/990"},"issue":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/990"},"comments":{"href":"https://api.github.com/repos/apache/incubator-beam/issues/990/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/990/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-beam/pulls/990/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-beam/statuses/2b05b04b95449e9278b1c83514b336f5607c92fc"}}}}
{"actor":{"display_login":"jasonkuster"}}