{"action":"opened","number":4888,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/4888","id":89766863,"html_url":"https://github.com/brave/browser-laptop/pull/4888","diff_url":"https://github.com/brave/browser-laptop/pull/4888.diff","patch_url":"https://github.com/brave/browser-laptop/pull/4888.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/4888","number":4888,"state":"open","locked":false,"title":"\"New bookmark folder\" and \"New bookmark\" buttons added to about:bookmarks","user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"body":"- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n\r\nTest Plan:\r\n\r\n\"New bookmark folder\" and \"New bookmark\" buttons added to about:bookmarks\r\n\r\n- sortableTable now allows you to provide a control instead of a string for the header\r\n- about:bookmarks now properly sets tableID (not used yet)\r\n- Adding a new bookmark now requires either a title or location (URL). Required because clicking new bookmark creates an empty object (versus existing buttons which always supply the current page).\r\n- Fixed style issue with about:bookmarks (moved border-right on folderView to organizeView\r\n\r\nFixes https://github.com/brave/browser-laptop/issues/4684\r\nFixes https://github.com/brave/browser-laptop/issues/4866\r\n\r\nAuditors: @jkup, @bbondy\r\n\r\nTest Plan:\r\n1. Launch Brave and visit about:bookmarks\r\n2. Pick any folder on the left hand side and click it to select it\r\n3. Click the +folder icon, above the folder view\r\n4. Confirm that the new bookmark folder UI comes up and that it sets the parent folder properly\r\n5. Click add and ensure folder gets added\r\n6. Pick any folder and click it to select\r\n7. In the \"title\" column, hit the star+ icon to add a new bookmark\r\n8. Confirm you can't add an empty bookmark. Type and see the button enable itself. Delete chars and it disables itself again.\r\n9. Confirm the parent folder is correct and type in a title/url. When done, hit save.\r\n10. Confirm bookmark was added.","created_at":"2016-10-18T08:19:49Z","updated_at":"2016-10-18T08:19:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"jkup","id":490294,"avatar_url":"https://avatars.githubusercontent.com/u/490294?v=3","gravatar_id":"","url":"https://api.github.com/users/jkup","html_url":"https://github.com/jkup","followers_url":"https://api.github.com/users/jkup/followers","following_url":"https://api.github.com/users/jkup/following{/other_user}","gists_url":"https://api.github.com/users/jkup/gists{/gist_id}","starred_url":"https://api.github.com/users/jkup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkup/subscriptions","organizations_url":"https://api.github.com/users/jkup/orgs","repos_url":"https://api.github.com/users/jkup/repos","events_url":"https://api.github.com/users/jkup/events{/privacy}","received_events_url":"https://api.github.com/users/jkup/received_events","type":"User","site_admin":false},"assignees":[{"login":"jkup","id":490294,"avatar_url":"https://avatars.githubusercontent.com/u/490294?v=3","gravatar_id":"","url":"https://api.github.com/users/jkup","html_url":"https://github.com/jkup","followers_url":"https://api.github.com/users/jkup/followers","following_url":"https://api.github.com/users/jkup/following{/other_user}","gists_url":"https://api.github.com/users/jkup/gists{/gist_id}","starred_url":"https://api.github.com/users/jkup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkup/subscriptions","organizations_url":"https://api.github.com/users/jkup/orgs","repos_url":"https://api.github.com/users/jkup/repos","events_url":"https://api.github.com/users/jkup/events{/privacy}","received_events_url":"https://api.github.com/users/jkup/received_events","type":"User","site_admin":false},{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/39","html_url":"https://github.com/brave/browser-laptop/milestones/0.12.6dev","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/39/labels","id":2059135,"number":39,"title":"0.12.6dev","description":"Freeze Oct 17","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":23,"state":"open","created_at":"2016-10-10T12:46:34Z","updated_at":"2016-10-18T08:19:49Z","due_on":"2016-10-19T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/4888/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/4888/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/4888/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/e24f4fe1aa6ddfc8409d11de99ae0816d860bf45","head":{"label":"bsclifton:bm-manager-add-folder","ref":"bm-manager-add-folder","sha":"e24f4fe1aa6ddfc8409d11de99ae0816d860bf45","user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"repo":{"id":56203023,"name":"browser-laptop","full_name":"bsclifton/browser-laptop","owner":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsclifton/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/bsclifton/browser-laptop","forks_url":"https://api.github.com/repos/bsclifton/browser-laptop/forks","keys_url":"https://api.github.com/repos/bsclifton/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsclifton/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsclifton/browser-laptop/teams","hooks_url":"https://api.github.com/repos/bsclifton/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/bsclifton/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/bsclifton/browser-laptop/events","assignees_url":"https://api.github.com/repos/bsclifton/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/bsclifton/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/bsclifton/browser-laptop/tags","blobs_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsclifton/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/bsclifton/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/bsclifton/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/bsclifton/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/bsclifton/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/bsclifton/browser-laptop/subscription","commits_url":"https://api.github.com/repos/bsclifton/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsclifton/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsclifton/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsclifton/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsclifton/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/bsclifton/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsclifton/browser-laptop/merges","archive_url":"https://api.github.com/repos/bsclifton/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsclifton/browser-laptop/downloads","issues_url":"https://api.github.com/repos/bsclifton/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/bsclifton/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/bsclifton/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/bsclifton/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsclifton/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/bsclifton/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/bsclifton/browser-laptop/deployments","created_at":"2016-04-14T03:03:23Z","updated_at":"2016-04-25T01:11:35Z","pushed_at":"2016-10-18T08:18:08Z","git_url":"git://github.com/bsclifton/browser-laptop.git","ssh_url":"git@github.com:bsclifton/browser-laptop.git","clone_url":"https://github.com/bsclifton/browser-laptop.git","svn_url":"https://github.com/bsclifton/browser-laptop","homepage":"https://www.brave.com","size":26898,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"878f7c587d4f851ab861ba50ca177b0b03933007","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2016-10-18T06:47:51Z","pushed_at":"2016-10-18T06:30:34Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":41521,"stargazers_count":3585,"watchers_count":3585,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":409,"mirror_url":null,"open_issues_count":1389,"forks":409,"open_issues":1389,"watchers":3585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4888"},"html":{"href":"https://github.com/brave/browser-laptop/pull/4888"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/4888"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/4888/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4888/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/4888/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/e24f4fe1aa6ddfc8409d11de99ae0816d860bf45"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":70,"deletions":14,"changed_files":6}}
{"actor":{"display_login":"bsclifton"}}