{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/89461851","pull_request_review_id":10006548,"id":89461851,"diff_hunk":"@@ -50,6 +55,10 @@ def process_strategy_local_db_cache_all\n       end\n     end\n \n+    def complete?\n+      complete","path":"app/models/manager_refresh/dto_collection.rb","position":32,"original_position":32,"commit_id":"46b753f5dc0c1aec21ca3029cdfbb769bb54b30c","original_commit_id":"46b753f5dc0c1aec21ca3029cdfbb769bb54b30c","user":{"login":"durandom","id":161888,"avatar_url":"https://avatars.githubusercontent.com/u/161888?v=3","gravatar_id":"","url":"https://api.github.com/users/durandom","html_url":"https://github.com/durandom","followers_url":"https://api.github.com/users/durandom/followers","following_url":"https://api.github.com/users/durandom/following{/other_user}","gists_url":"https://api.github.com/users/durandom/gists{/gist_id}","starred_url":"https://api.github.com/users/durandom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/durandom/subscriptions","organizations_url":"https://api.github.com/users/durandom/orgs","repos_url":"https://api.github.com/users/durandom/repos","events_url":"https://api.github.com/users/durandom/events{/privacy}","received_events_url":"https://api.github.com/users/durandom/received_events","type":"User","site_admin":false},"body":"should return a boolean `!!complete`","created_at":"2016-11-24T09:37:09Z","updated_at":"2016-11-24T09:37:09Z","html_url":"https://github.com/ManageIQ/manageiq/pull/12791#discussion_r89461851","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/89461851"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/12791#discussion_r89461851"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791","id":94827367,"html_url":"https://github.com/ManageIQ/manageiq/pull/12791","diff_url":"https://github.com/ManageIQ/manageiq/pull/12791.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/12791.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12791","number":12791,"state":"open","locked":false,"title":"Dto collection changes needed for skeletal refresh","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"body":"Needed changes for skeletal refresh\r\n\r\n1. being able to mark completeness of the DtoCollection, so we can forbid deletion of missing records\r\n2. being able to blacklist and whitelist attributes, so we can share parsing code, while saving only partial information\r\n","created_at":"2016-11-22T14:45:02Z","updated_at":"2016-11-24T09:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3595941fc68c9ee31f508939bcb4f7f87b0f96ca","assignee":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"assignees":[{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12791/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/46b753f5dc0c1aec21ca3029cdfbb769bb54b30c","head":{"label":"Ladas:dto_collection_changes_needed_for_skeletal_refresh","ref":"dto_collection_changes_needed_for_skeletal_refresh","sha":"46b753f5dc0c1aec21ca3029cdfbb769bb54b30c","user":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"repo":{"id":27175121,"name":"manageiq","full_name":"Ladas/manageiq","owner":{"login":"Ladas","id":1737058,"avatar_url":"https://avatars.githubusercontent.com/u/1737058?v=3","gravatar_id":"","url":"https://api.github.com/users/Ladas","html_url":"https://github.com/Ladas","followers_url":"https://api.github.com/users/Ladas/followers","following_url":"https://api.github.com/users/Ladas/following{/other_user}","gists_url":"https://api.github.com/users/Ladas/gists{/gist_id}","starred_url":"https://api.github.com/users/Ladas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ladas/subscriptions","organizations_url":"https://api.github.com/users/Ladas/orgs","repos_url":"https://api.github.com/users/Ladas/repos","events_url":"https://api.github.com/users/Ladas/events{/privacy}","received_events_url":"https://api.github.com/users/Ladas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ladas/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/Ladas/manageiq","forks_url":"https://api.github.com/repos/Ladas/manageiq/forks","keys_url":"https://api.github.com/repos/Ladas/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ladas/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ladas/manageiq/teams","hooks_url":"https://api.github.com/repos/Ladas/manageiq/hooks","issue_events_url":"https://api.github.com/repos/Ladas/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/Ladas/manageiq/events","assignees_url":"https://api.github.com/repos/Ladas/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/Ladas/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/Ladas/manageiq/tags","blobs_url":"https://api.github.com/repos/Ladas/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ladas/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ladas/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ladas/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ladas/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/Ladas/manageiq/languages","stargazers_url":"https://api.github.com/repos/Ladas/manageiq/stargazers","contributors_url":"https://api.github.com/repos/Ladas/manageiq/contributors","subscribers_url":"https://api.github.com/repos/Ladas/manageiq/subscribers","subscription_url":"https://api.github.com/repos/Ladas/manageiq/subscription","commits_url":"https://api.github.com/repos/Ladas/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ladas/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ladas/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ladas/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ladas/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/Ladas/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ladas/manageiq/merges","archive_url":"https://api.github.com/repos/Ladas/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ladas/manageiq/downloads","issues_url":"https://api.github.com/repos/Ladas/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/Ladas/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/Ladas/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/Ladas/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ladas/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/Ladas/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/Ladas/manageiq/deployments","created_at":"2014-11-26T12:09:24Z","updated_at":"2016-02-04T14:54:45Z","pushed_at":"2016-11-23T18:14:38Z","git_url":"git://github.com/Ladas/manageiq.git","ssh_url":"git@github.com:Ladas/manageiq.git","clone_url":"https://github.com/Ladas/manageiq.git","svn_url":"https://github.com/Ladas/manageiq","homepage":"manageiq.org","size":174015,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"538b938dd4b81c5aff0347b9787da55622f97d3e","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-11-24T09:08:22Z","pushed_at":"2016-11-24T08:34:40Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":224948,"stargazers_count":356,"watchers_count":356,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":385,"mirror_url":null,"open_issues_count":918,"forks":385,"open_issues":918,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/12791"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/12791"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/12791/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12791/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/46b753f5dc0c1aec21ca3029cdfbb769bb54b30c"}}}}
{"actor":{"display_login":"durandom"}}