{"action":"created","issue":{"url":"https://api.github.com/repos/kevin-brown/github-support-tickets/issues/1","repository_url":"https://api.github.com/repos/kevin-brown/github-support-tickets","labels_url":"https://api.github.com/repos/kevin-brown/github-support-tickets/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/kevin-brown/github-support-tickets/issues/1/comments","events_url":"https://api.github.com/repos/kevin-brown/github-support-tickets/issues/1/events","html_url":"https://github.com/kevin-brown/github-support-tickets/issues/1","id":124814913,"number":1,"title":"Wrong \"ready to merge status\" on pull requests","user":{"login":"kevin-brown","id":1991850,"avatar_url":"https://avatars.githubusercontent.com/u/1991850?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-brown","html_url":"https://github.com/kevin-brown","followers_url":"https://api.github.com/users/kevin-brown/followers","following_url":"https://api.github.com/users/kevin-brown/following{/other_user}","gists_url":"https://api.github.com/users/kevin-brown/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-brown/subscriptions","organizations_url":"https://api.github.com/users/kevin-brown/orgs","repos_url":"https://api.github.com/users/kevin-brown/repos","events_url":"https://api.github.com/users/kevin-brown/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-brown/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kevin-brown/github-support-tickets/labels/submitted","name":"submitted","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-01-04T18:47:15Z","updated_at":"2016-02-26T01:50:53Z","closed_at":null,"body":"We use [protected branches and required status checks](https://github.com/blog/2051-protected-branches-and-required-status-checks) for a few things, and they've been working out great... for those of us who are administrators. We have checks enabled, so non-admins cannot merge pull requests if they are failing builds, and nobody can force-push to the master branch (yay!).\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1991850/12097206/5017da90-b2e8-11e5-8dd4-21f65a777525.png)\r\n\r\nFor those of us who are administrators, everything looks fine when there is a pull request with failing status checks.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1991850/12097101/c84a19fc-b2e7-11e5-9cc0-038a40f11f24.png)\r\n\r\nBut for those who aren't administrators? Well, they are just told that their branch is not up to date. We can reproduce this issue by setting \"Include administrators\" in the protected branch settings.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1991850/12097121/e0f9dec4-b2e7-11e5-9730-5aaf6e019a2d.png)\r\n\r\n----\r\n\r\nThis issue also extends to branches with passing status checks. For administrators, they just see a pull request that is up to date, all status checks are passing, and is ready to merge.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1991850/12097166/1849f0d0-b2e8-11e5-9b90-b64a32fdb2c0.png)\r\n\r\nBut non-administrators? They just see a pull request which is out of date with the latest master.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1991850/12097135/f43a0b9e-b2e7-11e5-8d17-9f1a709a51a3.png)\r\n\r\nNow, this one is tricky. The pull request actually isn't up to date with the base branch, but GitHub isn't warning us if we are an administrator and can override the protection. Both of these images are from the same pull request, the only difference is the \"Include administrators\" setting has been checked for the last one."},"comment":{"url":"https://api.github.com/repos/kevin-brown/github-support-tickets/issues/comments/189075046","html_url":"https://github.com/kevin-brown/github-support-tickets/issues/1#issuecomment-189075046","issue_url":"https://api.github.com/repos/kevin-brown/github-support-tickets/issues/1","id":189075046,"user":{"login":"ryangribble","id":5425163,"avatar_url":"https://avatars.githubusercontent.com/u/5425163?v=3","gravatar_id":"","url":"https://api.github.com/users/ryangribble","html_url":"https://github.com/ryangribble","followers_url":"https://api.github.com/users/ryangribble/followers","following_url":"https://api.github.com/users/ryangribble/following{/other_user}","gists_url":"https://api.github.com/users/ryangribble/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangribble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangribble/subscriptions","organizations_url":"https://api.github.com/users/ryangribble/orgs","repos_url":"https://api.github.com/users/ryangribble/repos","events_url":"https://api.github.com/users/ryangribble/events{/privacy}","received_events_url":"https://api.github.com/users/ryangribble/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T01:50:53Z","updated_at":"2016-02-26T01:50:53Z","body":"any updates on this?  We've just encountered the same situation... We are on GitHub Enterprise 2.5 and I see that 2.5.1 has just been released... need to see whether that contains a fix or not"}}