{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3748","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3748/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3748/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3748/events","html_url":"https://github.com/RobotLocomotion/drake/pull/3748","id":182099086,"number":3748,"title":"Use GTest::GTest and Threads::Threads imported targets from upstream CMake","user":{"login":"jamiesnape","id":3630149,"avatar_url":"https://avatars.githubusercontent.com/u/3630149?v=3","gravatar_id":"","url":"https://api.github.com/users/jamiesnape","html_url":"https://github.com/jamiesnape","followers_url":"https://api.github.com/users/jamiesnape/followers","following_url":"https://api.github.com/users/jamiesnape/following{/other_user}","gists_url":"https://api.github.com/users/jamiesnape/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiesnape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiesnape/subscriptions","organizations_url":"https://api.github.com/users/jamiesnape/orgs","repos_url":"https://api.github.com/users/jamiesnape/repos","events_url":"https://api.github.com/users/jamiesnape/events{/privacy}","received_events_url":"https://api.github.com/users/jamiesnape/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false},"assignees":[{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-10-10T19:45:53Z","updated_at":"2016-10-11T14:08:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/3748","html_url":"https://github.com/RobotLocomotion/drake/pull/3748","diff_url":"https://github.com/RobotLocomotion/drake/pull/3748.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/3748.patch"},"body":"CMake already sets up an imported target for Threads, so we do not need to create our own. Using `GTest::GTest` automatically adds `Threads::Threads` to those targets (as well as the appropriate include directory for GTest).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/3748)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/252927326","html_url":"https://github.com/RobotLocomotion/drake/pull/3748#issuecomment-252927326","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/3748","id":252927326,"user":{"login":"david-german-tri","id":17437069,"avatar_url":"https://avatars.githubusercontent.com/u/17437069?v=3","gravatar_id":"","url":"https://api.github.com/users/david-german-tri","html_url":"https://github.com/david-german-tri","followers_url":"https://api.github.com/users/david-german-tri/followers","following_url":"https://api.github.com/users/david-german-tri/following{/other_user}","gists_url":"https://api.github.com/users/david-german-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/david-german-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-german-tri/subscriptions","organizations_url":"https://api.github.com/users/david-german-tri/orgs","repos_url":"https://api.github.com/users/david-german-tri/repos","events_url":"https://api.github.com/users/david-german-tri/events{/privacy}","received_events_url":"https://api.github.com/users/david-german-tri/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T14:08:29Z","updated_at":"2016-10-11T14:08:29Z","body":"\n\n\n\nReview status: 0 of 16 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[drake/common/test/CMakeLists.txt, line 42 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/3748#-KTo3cvvoUayZEqEJmn6:-KTo3cvvoUayZEqEJmn7:b-1r3vcx) ([raw file](https://github.com/robotlocomotion/drake/blob/1130b546a3cbfcb5418848ca5c080e1daf7820ee/drake/common/test/CMakeLists.txt#L42)):*\n> ```CMake\n>   target_compile_options(drake_assert_test_disabled PRIVATE -UDRAKE_ENABLE_ASSERTS)\n> endif()\n> target_link_libraries(drake_assert_test_disabled drakeCommon ${GTEST_BOTH_LIBRARIES})\n> ```\n\nWhat's the rationale for all these substitutions?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/3748)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"david-german-tri"}}