{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/74454437","id":74454437,"diff_hunk":"@@ -80,6 +81,8 @@ func init() {\n \tcmd.Flags().StringVar(&createCluster.DNSZone, \"dns-zone\", \"\", \"DNS hosted zone to use (defaults to last two components of cluster name)\")\n \tcmd.Flags().StringVar(&createCluster.OutDir, \"out\", \"\", \"Path to write any local output\")\n \tcmd.Flags().StringVar(&createCluster.AdminAccess, \"admin-access\", \"\", \"Restrict access to admin endpoints (SSH, HTTPS) to this CIDR.  If not set, access will not be restricted by IP.\")\n+\n+\tcmd.Flags().BoolVar(&createCluster.NoAssociatePublicIP, \"no-associate-public-ip\", false, \"Specify --no-associate-public-ip to disable association of public IP for master ASG and nodes.\")","path":"cmd/kops/create_cluster.go","position":49,"original_position":49,"commit_id":"fad3d3a4f4b2ca3ca68f722a73365222e906b38c","original_commit_id":"fad3d3a4f4b2ca3ca68f722a73365222e906b38c","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars.githubusercontent.com/u/100893?v=3","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"Actually, a better idea... what about adding a default value to `func (r *InstanceGroupRegistry) Find(name string) (*InstanceGroup, error) {` in registry.go.\r\n\r\nThe cleanest way might be to create a method on InstanceGroup called `SetDefaults` or similar, and then call it from Find in registry.go, and also in populate_instancegroup_spec.go.\r\n\r\nWe essentially want a field with a default value of true, but I don't know of an easier way.  And we do something similar in k8s.","created_at":"2016-08-11T16:19:56Z","updated_at":"2016-08-11T16:19:56Z","html_url":"https://github.com/kubernetes/kops/pull/273#discussion_r74454437","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/273","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/74454437"},"html":{"href":"https://github.com/kubernetes/kops/pull/273#discussion_r74454437"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/273"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/273","id":80255719,"html_url":"https://github.com/kubernetes/kops/pull/273","diff_url":"https://github.com/kubernetes/kops/pull/273.diff","patch_url":"https://github.com/kubernetes/kops/pull/273.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/273","number":273,"state":"open","locked":false,"title":"Add no-public-ip option to instance groups ","user":{"login":"moleksyuk","id":793472,"avatar_url":"https://avatars.githubusercontent.com/u/793472?v=3","gravatar_id":"","url":"https://api.github.com/users/moleksyuk","html_url":"https://github.com/moleksyuk","followers_url":"https://api.github.com/users/moleksyuk/followers","following_url":"https://api.github.com/users/moleksyuk/following{/other_user}","gists_url":"https://api.github.com/users/moleksyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/moleksyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moleksyuk/subscriptions","organizations_url":"https://api.github.com/users/moleksyuk/orgs","repos_url":"https://api.github.com/users/moleksyuk/repos","events_url":"https://api.github.com/users/moleksyuk/events{/privacy}","received_events_url":"https://api.github.com/users/moleksyuk/received_events","type":"User","site_admin":false},"body":"This pull request contains changes related to issue #266 ","created_at":"2016-08-05T14:50:08Z","updated_at":"2016-08-11T16:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a806642f536de28dd742ec8ee8eeeae062749c9d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/273/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/273/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/273/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/fad3d3a4f4b2ca3ca68f722a73365222e906b38c","head":{"label":"moleksyuk:master","ref":"master","sha":"fad3d3a4f4b2ca3ca68f722a73365222e906b38c","user":{"login":"moleksyuk","id":793472,"avatar_url":"https://avatars.githubusercontent.com/u/793472?v=3","gravatar_id":"","url":"https://api.github.com/users/moleksyuk","html_url":"https://github.com/moleksyuk","followers_url":"https://api.github.com/users/moleksyuk/followers","following_url":"https://api.github.com/users/moleksyuk/following{/other_user}","gists_url":"https://api.github.com/users/moleksyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/moleksyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moleksyuk/subscriptions","organizations_url":"https://api.github.com/users/moleksyuk/orgs","repos_url":"https://api.github.com/users/moleksyuk/repos","events_url":"https://api.github.com/users/moleksyuk/events{/privacy}","received_events_url":"https://api.github.com/users/moleksyuk/received_events","type":"User","site_admin":false},"repo":{"id":64914900,"name":"kops","full_name":"moleksyuk/kops","owner":{"login":"moleksyuk","id":793472,"avatar_url":"https://avatars.githubusercontent.com/u/793472?v=3","gravatar_id":"","url":"https://api.github.com/users/moleksyuk","html_url":"https://github.com/moleksyuk","followers_url":"https://api.github.com/users/moleksyuk/followers","following_url":"https://api.github.com/users/moleksyuk/following{/other_user}","gists_url":"https://api.github.com/users/moleksyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/moleksyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moleksyuk/subscriptions","organizations_url":"https://api.github.com/users/moleksyuk/orgs","repos_url":"https://api.github.com/users/moleksyuk/repos","events_url":"https://api.github.com/users/moleksyuk/events{/privacy}","received_events_url":"https://api.github.com/users/moleksyuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moleksyuk/kops","description":"kops deployment","fork":true,"url":"https://api.github.com/repos/moleksyuk/kops","forks_url":"https://api.github.com/repos/moleksyuk/kops/forks","keys_url":"https://api.github.com/repos/moleksyuk/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moleksyuk/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moleksyuk/kops/teams","hooks_url":"https://api.github.com/repos/moleksyuk/kops/hooks","issue_events_url":"https://api.github.com/repos/moleksyuk/kops/issues/events{/number}","events_url":"https://api.github.com/repos/moleksyuk/kops/events","assignees_url":"https://api.github.com/repos/moleksyuk/kops/assignees{/user}","branches_url":"https://api.github.com/repos/moleksyuk/kops/branches{/branch}","tags_url":"https://api.github.com/repos/moleksyuk/kops/tags","blobs_url":"https://api.github.com/repos/moleksyuk/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moleksyuk/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moleksyuk/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/moleksyuk/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moleksyuk/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/moleksyuk/kops/languages","stargazers_url":"https://api.github.com/repos/moleksyuk/kops/stargazers","contributors_url":"https://api.github.com/repos/moleksyuk/kops/contributors","subscribers_url":"https://api.github.com/repos/moleksyuk/kops/subscribers","subscription_url":"https://api.github.com/repos/moleksyuk/kops/subscription","commits_url":"https://api.github.com/repos/moleksyuk/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/moleksyuk/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/moleksyuk/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/moleksyuk/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/moleksyuk/kops/contents/{+path}","compare_url":"https://api.github.com/repos/moleksyuk/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moleksyuk/kops/merges","archive_url":"https://api.github.com/repos/moleksyuk/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moleksyuk/kops/downloads","issues_url":"https://api.github.com/repos/moleksyuk/kops/issues{/number}","pulls_url":"https://api.github.com/repos/moleksyuk/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/moleksyuk/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/moleksyuk/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moleksyuk/kops/labels{/name}","releases_url":"https://api.github.com/repos/moleksyuk/kops/releases{/id}","deployments_url":"https://api.github.com/repos/moleksyuk/kops/deployments","created_at":"2016-08-04T07:56:36Z","updated_at":"2016-08-04T07:56:39Z","pushed_at":"2016-08-06T11:46:52Z","git_url":"git://github.com/moleksyuk/kops.git","ssh_url":"git@github.com:moleksyuk/kops.git","clone_url":"https://github.com/moleksyuk/kops.git","svn_url":"https://github.com/moleksyuk/kops","homepage":"","size":82931,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5d437d3c2d80e12479dadccc92abb0f40a321ac9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"kops deployment","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2016-08-11T12:26:27Z","pushed_at":"2016-08-11T16:10:36Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":82949,"stargazers_count":110,"watchers_count":110,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":97,"forks":18,"open_issues":97,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/273"},"html":{"href":"https://github.com/kubernetes/kops/pull/273"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/273"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/fad3d3a4f4b2ca3ca68f722a73365222e906b38c"}}}}
{"actor":{"display_login":"justinsb"}}