{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/58526108","id":58526108,"diff_hunk":"@@ -366,8 +366,13 @@ class GridIn\n \n   /**\n    * Read grid data from an ucd file. Numerical data is ignored.\n+   * It is not possible to use a ucd file to set both boundary_id and\n+   * manifold_id for the same cell. Yet it is possible to use\n+   * the flag apply_all_indicators_to_manifolds to decide if\n+   * the indicators in the file refer to manifolds (flag set to true)\n+   * or boundaries (flag set to false).\n    */\n-  void read_ucd (std::istream &in);\n+  void read_ucd (std::istream &in, const bool apply_all_indicators_to_manifolds=false);","path":"include/deal.II/grid/grid_in.h","position":11,"original_position":11,"commit_id":"2c8b6fec80bd38237df5c0e332dbef3cce2cdc44","original_commit_id":"2c8b6fec80bd38237df5c0e332dbef3cce2cdc44","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"body":"can you break the line so that every argument is on its own line, as we typically do?","created_at":"2016-04-05T12:07:37Z","updated_at":"2016-04-05T12:07:37Z","html_url":"https://github.com/dealii/dealii/pull/2459#discussion_r58526108","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/2459","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/58526108"},"html":{"href":"https://github.com/dealii/dealii/pull/2459#discussion_r58526108"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2459"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/2459","id":65265883,"html_url":"https://github.com/dealii/dealii/pull/2459","diff_url":"https://github.com/dealii/dealii/pull/2459.diff","patch_url":"https://github.com/dealii/dealii/pull/2459.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/2459","number":2459,"state":"open","locked":false,"title":"added new option to read boundary indicators in a ucd file as manifold ids","user":{"login":"andreamola","id":8832692,"avatar_url":"https://avatars.githubusercontent.com/u/8832692?v=3","gravatar_id":"","url":"https://api.github.com/users/andreamola","html_url":"https://github.com/andreamola","followers_url":"https://api.github.com/users/andreamola/followers","following_url":"https://api.github.com/users/andreamola/following{/other_user}","gists_url":"https://api.github.com/users/andreamola/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamola/subscriptions","organizations_url":"https://api.github.com/users/andreamola/orgs","repos_url":"https://api.github.com/users/andreamola/repos","events_url":"https://api.github.com/users/andreamola/events{/privacy}","received_events_url":"https://api.github.com/users/andreamola/received_events","type":"User","site_admin":false},"body":"In a ucd file one can specify only one indicator per cell. In a grid of dimension dim, all the dim-1 entities are normally interpreted as boundary ids. This gives problems whenever one wants to specify a flag to internal faces in the grid. With this option one can tell to the read_ucd function to read all the flags for the dim-1 cells as manifold indicators. Flags on internal faces can now be specified.  ","created_at":"2016-04-05T08:04:56Z","updated_at":"2016-04-05T12:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63ee2a77a5a0e68940de9550c73d279785f8287a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/2459/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/2459/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/2459/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/2c8b6fec80bd38237df5c0e332dbef3cce2cdc44","head":{"label":"andreamola:read_ucd_for_manifold_ids","ref":"read_ucd_for_manifold_ids","sha":"2c8b6fec80bd38237df5c0e332dbef3cce2cdc44","user":{"login":"andreamola","id":8832692,"avatar_url":"https://avatars.githubusercontent.com/u/8832692?v=3","gravatar_id":"","url":"https://api.github.com/users/andreamola","html_url":"https://github.com/andreamola","followers_url":"https://api.github.com/users/andreamola/followers","following_url":"https://api.github.com/users/andreamola/following{/other_user}","gists_url":"https://api.github.com/users/andreamola/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamola/subscriptions","organizations_url":"https://api.github.com/users/andreamola/orgs","repos_url":"https://api.github.com/users/andreamola/repos","events_url":"https://api.github.com/users/andreamola/events{/privacy}","received_events_url":"https://api.github.com/users/andreamola/received_events","type":"User","site_admin":false},"repo":{"id":24333302,"name":"dealii","full_name":"andreamola/dealii","owner":{"login":"andreamola","id":8832692,"avatar_url":"https://avatars.githubusercontent.com/u/8832692?v=3","gravatar_id":"","url":"https://api.github.com/users/andreamola","html_url":"https://github.com/andreamola","followers_url":"https://api.github.com/users/andreamola/followers","following_url":"https://api.github.com/users/andreamola/following{/other_user}","gists_url":"https://api.github.com/users/andreamola/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamola/subscriptions","organizations_url":"https://api.github.com/users/andreamola/orgs","repos_url":"https://api.github.com/users/andreamola/repos","events_url":"https://api.github.com/users/andreamola/events{/privacy}","received_events_url":"https://api.github.com/users/andreamola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreamola/dealii","description":"","fork":true,"url":"https://api.github.com/repos/andreamola/dealii","forks_url":"https://api.github.com/repos/andreamola/dealii/forks","keys_url":"https://api.github.com/repos/andreamola/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreamola/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreamola/dealii/teams","hooks_url":"https://api.github.com/repos/andreamola/dealii/hooks","issue_events_url":"https://api.github.com/repos/andreamola/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/andreamola/dealii/events","assignees_url":"https://api.github.com/repos/andreamola/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/andreamola/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/andreamola/dealii/tags","blobs_url":"https://api.github.com/repos/andreamola/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreamola/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreamola/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreamola/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreamola/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/andreamola/dealii/languages","stargazers_url":"https://api.github.com/repos/andreamola/dealii/stargazers","contributors_url":"https://api.github.com/repos/andreamola/dealii/contributors","subscribers_url":"https://api.github.com/repos/andreamola/dealii/subscribers","subscription_url":"https://api.github.com/repos/andreamola/dealii/subscription","commits_url":"https://api.github.com/repos/andreamola/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreamola/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreamola/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreamola/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreamola/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/andreamola/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreamola/dealii/merges","archive_url":"https://api.github.com/repos/andreamola/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreamola/dealii/downloads","issues_url":"https://api.github.com/repos/andreamola/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/andreamola/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/andreamola/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/andreamola/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreamola/dealii/labels{/name}","releases_url":"https://api.github.com/repos/andreamola/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/andreamola/dealii/deployments","created_at":"2014-09-22T15:05:29Z","updated_at":"2016-04-05T07:58:07Z","pushed_at":"2016-04-05T11:24:59Z","git_url":"git://github.com/andreamola/dealii.git","ssh_url":"git@github.com:andreamola/dealii.git","clone_url":"https://github.com/andreamola/dealii.git","svn_url":"https://github.com/andreamola/dealii","homepage":null,"size":136292,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"fba6e1fb11ce927f705ac77cfde476b0edf81482","user":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"name":"dealii","full_name":"dealii/dealii","owner":{"login":"dealii","id":7506070,"avatar_url":"https://avatars.githubusercontent.com/u/7506070?v=3","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2016-04-01T22:20:06Z","pushed_at":"2016-04-05T12:02:38Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"git@github.com:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"http://www.dealii.org/","size":156741,"stargazers_count":135,"watchers_count":135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":177,"forks":159,"open_issues":177,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2459"},"html":{"href":"https://github.com/dealii/dealii/pull/2459"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/2459"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/2459/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2459/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/2459/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/2c8b6fec80bd38237df5c0e332dbef3cce2cdc44"}}}}