{"action":"created","comment":{"url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/comments/74998276","id":74998276,"diff_hunk":"@@ -797,6 +872,49 @@ private void sendUpdate(JSONObject obj, boolean keepCallback, PluginResult.Statu\n         public InAppBrowserClient(CordovaWebView webView, EditText mEditText) {\n             this.webView = webView;\n             this.edittext = mEditText;\n+            this.currentUrl = null;\n+            this.whiteList = new ArrayList<String>();\n+        }\n+\n+        /**\n+         * Ignore SSL Certificate errors when the certificate is good with HttpsUrlConnection\n+         */\n+        @Override\n+        public void onReceivedSslError(WebView view, SslErrorHandler handler, SslError error) {\n+            Log.d(LOG_TAG, \"We have received an SSL error on this URL: \" + error.getUrl());\n+            int endIndex = error.getUrl().indexOf(\"/\", 8);","path":"src/android/InAppBrowser.java","position":136,"original_position":136,"commit_id":"a2f961f23cc3144bcb1170aa46dc58c052ec5beb","original_commit_id":"a2f961f23cc3144bcb1170aa46dc58c052ec5beb","user":{"login":"grokcode","id":61232,"avatar_url":"https://avatars.githubusercontent.com/u/61232?v=3","gravatar_id":"","url":"https://api.github.com/users/grokcode","html_url":"https://github.com/grokcode","followers_url":"https://api.github.com/users/grokcode/followers","following_url":"https://api.github.com/users/grokcode/following{/other_user}","gists_url":"https://api.github.com/users/grokcode/gists{/gist_id}","starred_url":"https://api.github.com/users/grokcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grokcode/subscriptions","organizations_url":"https://api.github.com/users/grokcode/orgs","repos_url":"https://api.github.com/users/grokcode/repos","events_url":"https://api.github.com/users/grokcode/events{/privacy}","received_events_url":"https://api.github.com/users/grokcode/received_events","type":"User","site_admin":false},"body":"@brad Sure, sounds fine to me.","created_at":"2016-08-16T18:57:06Z","updated_at":"2016-08-16T18:57:06Z","html_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser/pull/1#discussion_r74998276","pull_request_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/comments/74998276"},"html":{"href":"https://github.com/orcasgit/cordova-plugin-inappbrowser/pull/1#discussion_r74998276"},"pull_request":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1","id":81498658,"html_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser/pull/1","diff_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser/pull/1.diff","patch_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser/pull/1.patch","issue_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/1","number":1,"state":"open","locked":false,"title":"Trust ca android ios","user":{"login":"brad","id":1614,"avatar_url":"https://avatars.githubusercontent.com/u/1614?v=3","gravatar_id":"","url":"https://api.github.com/users/brad","html_url":"https://github.com/brad","followers_url":"https://api.github.com/users/brad/followers","following_url":"https://api.github.com/users/brad/following{/other_user}","gists_url":"https://api.github.com/users/brad/gists{/gist_id}","starred_url":"https://api.github.com/users/brad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brad/subscriptions","organizations_url":"https://api.github.com/users/brad/orgs","repos_url":"https://api.github.com/users/brad/repos","events_url":"https://api.github.com/users/brad/events{/privacy}","received_events_url":"https://api.github.com/users/brad/received_events","type":"User","site_admin":false},"body":"@orcasgit/orcas-developers Please review. This leans heavily on the [CustomHTTPProtocol example](https://developer.apple.com/library/ios/samplecode/CustomHTTPProtocol/Introduction/Intro.html) by Apple, though I was able to simplify a few things by getting the certificate from a file instead of a URL as in their example. This is what Apple themselves [recommend we do](https://developer.apple.com/library/mac/technotes/tn2232/_index.html#//apple_ref/doc/uid/DTS40012884-CH1-SECUIWEBVIEW) in order to get `UIWebView` to trust other certificates.\r\n\r\nThe android stuff is here too (unchanged) because I thought it made sense to merge to the master branch of this repo, and I'll redo my PR against upstream to include both Android and iOS support.","created_at":"2016-08-16T16:04:15Z","updated_at":"2016-08-16T18:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"544cc579a7428b381acd4603fdc7a25123d8609f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1/commits","review_comments_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1/comments","review_comment_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/1/comments","statuses_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/statuses/a2f961f23cc3144bcb1170aa46dc58c052ec5beb","head":{"label":"orcasgit:trust-ca-android-ios","ref":"trust-ca-android-ios","sha":"a2f961f23cc3144bcb1170aa46dc58c052ec5beb","user":{"login":"orcasgit","id":9833,"avatar_url":"https://avatars.githubusercontent.com/u/9833?v=3","gravatar_id":"","url":"https://api.github.com/users/orcasgit","html_url":"https://github.com/orcasgit","followers_url":"https://api.github.com/users/orcasgit/followers","following_url":"https://api.github.com/users/orcasgit/following{/other_user}","gists_url":"https://api.github.com/users/orcasgit/gists{/gist_id}","starred_url":"https://api.github.com/users/orcasgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orcasgit/subscriptions","organizations_url":"https://api.github.com/users/orcasgit/orgs","repos_url":"https://api.github.com/users/orcasgit/repos","events_url":"https://api.github.com/users/orcasgit/events{/privacy}","received_events_url":"https://api.github.com/users/orcasgit/received_events","type":"Organization","site_admin":false},"repo":{"id":38904623,"name":"cordova-plugin-inappbrowser","full_name":"orcasgit/cordova-plugin-inappbrowser","owner":{"login":"orcasgit","id":9833,"avatar_url":"https://avatars.githubusercontent.com/u/9833?v=3","gravatar_id":"","url":"https://api.github.com/users/orcasgit","html_url":"https://github.com/orcasgit","followers_url":"https://api.github.com/users/orcasgit/followers","following_url":"https://api.github.com/users/orcasgit/following{/other_user}","gists_url":"https://api.github.com/users/orcasgit/gists{/gist_id}","starred_url":"https://api.github.com/users/orcasgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orcasgit/subscriptions","organizations_url":"https://api.github.com/users/orcasgit/orgs","repos_url":"https://api.github.com/users/orcasgit/repos","events_url":"https://api.github.com/users/orcasgit/events{/privacy}","received_events_url":"https://api.github.com/users/orcasgit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser","description":"Mirror of Apache Cordova Plugin inappbrowser","fork":true,"url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser","forks_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/forks","keys_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/teams","hooks_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/hooks","issue_events_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/events{/number}","events_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/events","assignees_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/assignees{/user}","branches_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/branches{/branch}","tags_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/tags","blobs_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/languages","stargazers_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/stargazers","contributors_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/contributors","subscribers_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/subscribers","subscription_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/subscription","commits_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/contents/{+path}","compare_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/merges","archive_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/downloads","issues_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues{/number}","pulls_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/labels{/name}","releases_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/releases{/id}","deployments_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/deployments","created_at":"2015-07-10T22:20:57Z","updated_at":"2016-03-07T23:58:48Z","pushed_at":"2016-08-16T16:04:15Z","git_url":"git://github.com/orcasgit/cordova-plugin-inappbrowser.git","ssh_url":"git@github.com:orcasgit/cordova-plugin-inappbrowser.git","clone_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser.git","svn_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser","homepage":null,"size":842,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"orcasgit:master","ref":"master","sha":"3f63aaee583f85a8ed603fc15cc83127919f8320","user":{"login":"orcasgit","id":9833,"avatar_url":"https://avatars.githubusercontent.com/u/9833?v=3","gravatar_id":"","url":"https://api.github.com/users/orcasgit","html_url":"https://github.com/orcasgit","followers_url":"https://api.github.com/users/orcasgit/followers","following_url":"https://api.github.com/users/orcasgit/following{/other_user}","gists_url":"https://api.github.com/users/orcasgit/gists{/gist_id}","starred_url":"https://api.github.com/users/orcasgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orcasgit/subscriptions","organizations_url":"https://api.github.com/users/orcasgit/orgs","repos_url":"https://api.github.com/users/orcasgit/repos","events_url":"https://api.github.com/users/orcasgit/events{/privacy}","received_events_url":"https://api.github.com/users/orcasgit/received_events","type":"Organization","site_admin":false},"repo":{"id":38904623,"name":"cordova-plugin-inappbrowser","full_name":"orcasgit/cordova-plugin-inappbrowser","owner":{"login":"orcasgit","id":9833,"avatar_url":"https://avatars.githubusercontent.com/u/9833?v=3","gravatar_id":"","url":"https://api.github.com/users/orcasgit","html_url":"https://github.com/orcasgit","followers_url":"https://api.github.com/users/orcasgit/followers","following_url":"https://api.github.com/users/orcasgit/following{/other_user}","gists_url":"https://api.github.com/users/orcasgit/gists{/gist_id}","starred_url":"https://api.github.com/users/orcasgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orcasgit/subscriptions","organizations_url":"https://api.github.com/users/orcasgit/orgs","repos_url":"https://api.github.com/users/orcasgit/repos","events_url":"https://api.github.com/users/orcasgit/events{/privacy}","received_events_url":"https://api.github.com/users/orcasgit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser","description":"Mirror of Apache Cordova Plugin inappbrowser","fork":true,"url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser","forks_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/forks","keys_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/teams","hooks_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/hooks","issue_events_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/events{/number}","events_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/events","assignees_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/assignees{/user}","branches_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/branches{/branch}","tags_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/tags","blobs_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/languages","stargazers_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/stargazers","contributors_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/contributors","subscribers_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/subscribers","subscription_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/subscription","commits_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/contents/{+path}","compare_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/merges","archive_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/downloads","issues_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues{/number}","pulls_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/labels{/name}","releases_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/releases{/id}","deployments_url":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/deployments","created_at":"2015-07-10T22:20:57Z","updated_at":"2016-03-07T23:58:48Z","pushed_at":"2016-08-16T16:04:15Z","git_url":"git://github.com/orcasgit/cordova-plugin-inappbrowser.git","ssh_url":"git@github.com:orcasgit/cordova-plugin-inappbrowser.git","clone_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser.git","svn_url":"https://github.com/orcasgit/cordova-plugin-inappbrowser","homepage":null,"size":842,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1"},"html":{"href":"https://github.com/orcasgit/cordova-plugin-inappbrowser/pull/1"},"issue":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/1"},"comments":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/orcasgit/cordova-plugin-inappbrowser/statuses/a2f961f23cc3144bcb1170aa46dc58c052ec5beb"}}}}
{"actor":{"display_login":"grokcode"}}