{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/87214216","pull_request_review_id":7834548,"id":87214216,"diff_hunk":"@@ -0,0 +1,44 @@\n+##############################################################################\n+# Copyright (c) 2013-2016, Lawrence Livermore National Security, LLC.\n+# Produced at the Lawrence Livermore National Laboratory.\n+#\n+# This file is part of Spack.\n+# Created by Todd Gamblin, tgamblin@llnl.gov, All rights reserved.\n+# LLNL-CODE-647188\n+#\n+# For details, see https://github.com/llnl/spack\n+# Please also see the LICENSE file for our notice and the LGPL.\n+#\n+# This program is free software; you can redistribute it and/or modify\n+# it under the terms of the GNU Lesser General Public License (as\n+# published by the Free Software Foundation) version 2.1, February 1999.\n+#\n+# This program is distributed in the hope that it will be useful, but\n+# WITHOUT ANY WARRANTY; without even the IMPLIED WARRANTY OF\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the terms and\n+# conditions of the GNU Lesser General Public License for more details.\n+#\n+# You should have received a copy of the GNU Lesser General Public\n+# License along with this program; if not, write to the Free Software\n+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA\n+##############################################################################\n+from spack import *\n+\n+\n+class Jansson(CMakePackage):\n+    \"\"\"Jansson is a C library for encoding, decoding and manipulating JSON data.\"\"\"\n+\n+    homepage = \"http://www.digip.org/jansson/\"\n+    url      = \"https://github.com/akheron/jansson/archive/v2.9.tar.gz\"\n+\n+    version('2.9', 'd2db25c437b359fc5a065ed938962237')\n+\n+    depends_on('cmake', type='build')\n+\n+    def install(self, spec, prefix):\n+        with working_dir('spack-build', create=True):\n+            cmake('-DCMAKE_INSTALL_PREFIX=%s' % prefix,\n+                  '..', *std_cmake_args)\n+\n+            make()\n+            make('install')","path":"var/spack/repos/builtin/packages/jansson/package.py","position":44,"original_position":44,"commit_id":"a21b20532cdbc0c9e73c98ce8e0583314cfedeeb","original_commit_id":"a21b20532cdbc0c9e73c98ce8e0583314cfedeeb","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"Since you're extending CMakePackage, you can get rid of this whole install method. It's the default anyway.","created_at":"2016-11-09T15:31:58Z","updated_at":"2016-11-09T15:31:58Z","html_url":"https://github.com/LLNL/spack/pull/2287#discussion_r87214216","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/2287","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/87214216"},"html":{"href":"https://github.com/LLNL/spack/pull/2287#discussion_r87214216"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2287"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/2287","id":92929770,"html_url":"https://github.com/LLNL/spack/pull/2287","diff_url":"https://github.com/LLNL/spack/pull/2287.diff","patch_url":"https://github.com/LLNL/spack/pull/2287.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/2287","number":2287,"state":"open","locked":false,"title":"Packages: Add Jansson","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"This adds the built recipe for [Jansson](http://www.digip.org/jansson/), *a C library for encoding, decoding and manipulating JSON data.*\r\n\r\n### GitHub Repo\r\n\r\nhttps://github.com/akheron/jansson\r\n\r\n### Downstream Usage\r\n\r\nIn [ISAAC](https://github.com/ComputationalRadiationPhysics/isaac) which is an *in situ visualization library* based on [alpaka](https://github.com/ComputationalRadiationPhysics/alpaka) and/or CUDA which is used in [PIConGPU](https://github.com/ComputationalRadiationPhysics/picongpu).","created_at":"2016-11-09T09:34:39Z","updated_at":"2016-11-09T15:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39eeb8c43bf2355947e0d27ec1c4fb619219ef64","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/2287/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/2287/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/2287/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/a21b20532cdbc0c9e73c98ce8e0583314cfedeeb","head":{"label":"ax3l:topic-jansson","ref":"topic-jansson","sha":"a21b20532cdbc0c9e73c98ce8e0583314cfedeeb","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"repo":{"id":66849594,"name":"spack","full_name":"ax3l/spack","owner":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ax3l/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/ax3l/spack","forks_url":"https://api.github.com/repos/ax3l/spack/forks","keys_url":"https://api.github.com/repos/ax3l/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ax3l/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ax3l/spack/teams","hooks_url":"https://api.github.com/repos/ax3l/spack/hooks","issue_events_url":"https://api.github.com/repos/ax3l/spack/issues/events{/number}","events_url":"https://api.github.com/repos/ax3l/spack/events","assignees_url":"https://api.github.com/repos/ax3l/spack/assignees{/user}","branches_url":"https://api.github.com/repos/ax3l/spack/branches{/branch}","tags_url":"https://api.github.com/repos/ax3l/spack/tags","blobs_url":"https://api.github.com/repos/ax3l/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ax3l/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ax3l/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ax3l/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ax3l/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/ax3l/spack/languages","stargazers_url":"https://api.github.com/repos/ax3l/spack/stargazers","contributors_url":"https://api.github.com/repos/ax3l/spack/contributors","subscribers_url":"https://api.github.com/repos/ax3l/spack/subscribers","subscription_url":"https://api.github.com/repos/ax3l/spack/subscription","commits_url":"https://api.github.com/repos/ax3l/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ax3l/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ax3l/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ax3l/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ax3l/spack/contents/{+path}","compare_url":"https://api.github.com/repos/ax3l/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ax3l/spack/merges","archive_url":"https://api.github.com/repos/ax3l/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ax3l/spack/downloads","issues_url":"https://api.github.com/repos/ax3l/spack/issues{/number}","pulls_url":"https://api.github.com/repos/ax3l/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/ax3l/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/ax3l/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ax3l/spack/labels{/name}","releases_url":"https://api.github.com/repos/ax3l/spack/releases{/id}","deployments_url":"https://api.github.com/repos/ax3l/spack/deployments","created_at":"2016-08-29T14:12:01Z","updated_at":"2016-08-29T14:12:05Z","pushed_at":"2016-11-09T09:48:35Z","git_url":"git://github.com/ax3l/spack.git","ssh_url":"git@github.com:ax3l/spack.git","clone_url":"https://github.com/ax3l/spack.git","svn_url":"https://github.com/ax3l/spack","homepage":"http://software.llnl.gov/spack","size":12538,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"4457c6a2ad436f666dfc1ef8135b8a355e81ceef","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-11-03T17:40:46Z","pushed_at":"2016-11-09T14:44:04Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":21425,"stargazers_count":170,"watchers_count":170,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":155,"mirror_url":null,"open_issues_count":392,"forks":155,"open_issues":392,"watchers":170,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2287"},"html":{"href":"https://github.com/LLNL/spack/pull/2287"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/2287"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/2287/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2287/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2287/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/a21b20532cdbc0c9e73c98ce8e0583314cfedeeb"}}}}
{"actor":{"display_login":"adamjstewart"}}