{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/84600250","pull_request_review_id":5368613,"id":84600250,"diff_hunk":"@@ -255,7 +255,6 @@ export class StaticReflector implements ReflectorReader {\n       }\n \n       function resolveReferenceValue(staticSymbol: StaticSymbol): any {\n-        let result: any = staticSymbol;","path":"modules/@angular/compiler-cli/src/static_reflector.ts","position":4,"original_position":4,"commit_id":"6b56be8447be99ab301aa3fa37323c1e5f089dd3","original_commit_id":"6b56be8447be99ab301aa3fa37323c1e5f089dd3","user":{"login":"alfaproject","id":60164,"avatar_url":"https://avatars.githubusercontent.com/u/60164?v=3","gravatar_id":"","url":"https://api.github.com/users/alfaproject","html_url":"https://github.com/alfaproject","followers_url":"https://api.github.com/users/alfaproject/followers","following_url":"https://api.github.com/users/alfaproject/following{/other_user}","gists_url":"https://api.github.com/users/alfaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/alfaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfaproject/subscriptions","organizations_url":"https://api.github.com/users/alfaproject/orgs","repos_url":"https://api.github.com/users/alfaproject/repos","events_url":"https://api.github.com/users/alfaproject/events{/privacy}","received_events_url":"https://api.github.com/users/alfaproject/received_events","type":"User","site_admin":false},"body":"No worries, I can rebase. Had to make the change to pass linting tests anyway.","created_at":"2016-10-23T17:39:29Z","updated_at":"2016-10-23T17:39:29Z","html_url":"https://github.com/angular/angular/pull/12464#discussion_r84600250","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/12464","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/84600250"},"html":{"href":"https://github.com/angular/angular/pull/12464#discussion_r84600250"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/12464"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/12464","id":90494433,"html_url":"https://github.com/angular/angular/pull/12464","diff_url":"https://github.com/angular/angular/pull/12464.diff","patch_url":"https://github.com/angular/angular/pull/12464.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/12464","number":12464,"state":"open","locked":false,"title":"refactor(typescript): remove unused locals and lint more modules","user":{"login":"alfaproject","id":60164,"avatar_url":"https://avatars.githubusercontent.com/u/60164?v=3","gravatar_id":"","url":"https://api.github.com/users/alfaproject","html_url":"https://github.com/alfaproject","followers_url":"https://api.github.com/users/alfaproject/followers","following_url":"https://api.github.com/users/alfaproject/following{/other_user}","gists_url":"https://api.github.com/users/alfaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/alfaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfaproject/subscriptions","organizations_url":"https://api.github.com/users/alfaproject/orgs","repos_url":"https://api.github.com/users/alfaproject/repos","events_url":"https://api.github.com/users/alfaproject/events{/privacy}","received_events_url":"https://api.github.com/users/alfaproject/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[ ] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[x] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[x] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nNo CI checks exist for unused locals or variables.\r\n\r\n\r\n**What is the new behavior?**\r\nTypeScript compiler will check for unused locals in some projects.\r\nTSLint is now configured to flag unused variables, and is extended to more projects.\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n\r\n**Other information**:\r\nIdeally, the Typescript compiler should be used to check for unused locals in all projects, but some of the current projects include generated code, and this PR is already big enough.\r\n\r\nP.S.: I might have found a bug with the XTB loading.","created_at":"2016-10-22T20:29:02Z","updated_at":"2016-10-23T17:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b2001ecf6ae271294d35398f585fb1880394410","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/12464/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/12464/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/12464/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/6b56be8447be99ab301aa3fa37323c1e5f089dd3","head":{"label":"xcaliber-tech:ts-variables-cleanup","ref":"ts-variables-cleanup","sha":"6b56be8447be99ab301aa3fa37323c1e5f089dd3","user":{"login":"xcaliber-tech","id":5228170,"avatar_url":"https://avatars.githubusercontent.com/u/5228170?v=3","gravatar_id":"","url":"https://api.github.com/users/xcaliber-tech","html_url":"https://github.com/xcaliber-tech","followers_url":"https://api.github.com/users/xcaliber-tech/followers","following_url":"https://api.github.com/users/xcaliber-tech/following{/other_user}","gists_url":"https://api.github.com/users/xcaliber-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/xcaliber-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcaliber-tech/subscriptions","organizations_url":"https://api.github.com/users/xcaliber-tech/orgs","repos_url":"https://api.github.com/users/xcaliber-tech/repos","events_url":"https://api.github.com/users/xcaliber-tech/events{/privacy}","received_events_url":"https://api.github.com/users/xcaliber-tech/received_events","type":"Organization","site_admin":false},"repo":{"id":70900972,"name":"angular","full_name":"xcaliber-tech/angular","owner":{"login":"xcaliber-tech","id":5228170,"avatar_url":"https://avatars.githubusercontent.com/u/5228170?v=3","gravatar_id":"","url":"https://api.github.com/users/xcaliber-tech","html_url":"https://github.com/xcaliber-tech","followers_url":"https://api.github.com/users/xcaliber-tech/followers","following_url":"https://api.github.com/users/xcaliber-tech/following{/other_user}","gists_url":"https://api.github.com/users/xcaliber-tech/gists{/gist_id}","starred_url":"https://api.github.com/users/xcaliber-tech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcaliber-tech/subscriptions","organizations_url":"https://api.github.com/users/xcaliber-tech/orgs","repos_url":"https://api.github.com/users/xcaliber-tech/repos","events_url":"https://api.github.com/users/xcaliber-tech/events{/privacy}","received_events_url":"https://api.github.com/users/xcaliber-tech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcaliber-tech/angular","description":null,"fork":true,"url":"https://api.github.com/repos/xcaliber-tech/angular","forks_url":"https://api.github.com/repos/xcaliber-tech/angular/forks","keys_url":"https://api.github.com/repos/xcaliber-tech/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcaliber-tech/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcaliber-tech/angular/teams","hooks_url":"https://api.github.com/repos/xcaliber-tech/angular/hooks","issue_events_url":"https://api.github.com/repos/xcaliber-tech/angular/issues/events{/number}","events_url":"https://api.github.com/repos/xcaliber-tech/angular/events","assignees_url":"https://api.github.com/repos/xcaliber-tech/angular/assignees{/user}","branches_url":"https://api.github.com/repos/xcaliber-tech/angular/branches{/branch}","tags_url":"https://api.github.com/repos/xcaliber-tech/angular/tags","blobs_url":"https://api.github.com/repos/xcaliber-tech/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcaliber-tech/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcaliber-tech/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcaliber-tech/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcaliber-tech/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/xcaliber-tech/angular/languages","stargazers_url":"https://api.github.com/repos/xcaliber-tech/angular/stargazers","contributors_url":"https://api.github.com/repos/xcaliber-tech/angular/contributors","subscribers_url":"https://api.github.com/repos/xcaliber-tech/angular/subscribers","subscription_url":"https://api.github.com/repos/xcaliber-tech/angular/subscription","commits_url":"https://api.github.com/repos/xcaliber-tech/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcaliber-tech/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcaliber-tech/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcaliber-tech/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcaliber-tech/angular/contents/{+path}","compare_url":"https://api.github.com/repos/xcaliber-tech/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcaliber-tech/angular/merges","archive_url":"https://api.github.com/repos/xcaliber-tech/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcaliber-tech/angular/downloads","issues_url":"https://api.github.com/repos/xcaliber-tech/angular/issues{/number}","pulls_url":"https://api.github.com/repos/xcaliber-tech/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/xcaliber-tech/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/xcaliber-tech/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcaliber-tech/angular/labels{/name}","releases_url":"https://api.github.com/repos/xcaliber-tech/angular/releases{/id}","deployments_url":"https://api.github.com/repos/xcaliber-tech/angular/deployments","created_at":"2016-10-14T10:42:23Z","updated_at":"2016-10-23T14:57:59Z","pushed_at":"2016-10-23T14:58:25Z","git_url":"git://github.com/xcaliber-tech/angular.git","ssh_url":"git@github.com:xcaliber-tech/angular.git","clone_url":"https://github.com/xcaliber-tech/angular.git","svn_url":"https://github.com/xcaliber-tech/angular","homepage":"https://angular.io","size":31591,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"bfc97ff2cd05548f77863fcf69f9f17c26e2b5f1","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":null,"fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-10-23T16:24:41Z","pushed_at":"2016-10-23T14:58:26Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":648959,"stargazers_count":17547,"watchers_count":17547,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4457,"mirror_url":null,"open_issues_count":889,"forks":4457,"open_issues":889,"watchers":17547,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/12464"},"html":{"href":"https://github.com/angular/angular/pull/12464"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/12464"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/12464/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/12464/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/12464/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/6b56be8447be99ab301aa3fa37323c1e5f089dd3"}}}}
{"actor":{"display_login":"alfaproject"}}