{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/57607636","id":57607636,"diff_hunk":"@@ -24,3 +28,85 @@ moduleFor('Syntax test: {{#if}} and {{#unless}} without inverse', class extends\n   }\n \n });\n+\n+moduleFor('Syntax test: {{#if}}', class extends RenderingTest {\n+\n+  ['@test child conditional should not render children if parent conditional becomes false'](assert) {","path":"packages/ember-glimmer/tests/integration/syntax/if-unless-test.js","position":17,"original_position":17,"commit_id":"1148f4e649bd8aae0af741f1b17ee650a160aeb1","original_commit_id":"1148f4e649bd8aae0af741f1b17ee650a160aeb1","user":{"login":"chancancode","id":55829,"avatar_url":"https://avatars.githubusercontent.com/u/55829?v=3","gravatar_id":"","url":"https://api.github.com/users/chancancode","html_url":"https://github.com/chancancode","followers_url":"https://api.github.com/users/chancancode/followers","following_url":"https://api.github.com/users/chancancode/following{/other_user}","gists_url":"https://api.github.com/users/chancancode/gists{/gist_id}","starred_url":"https://api.github.com/users/chancancode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancancode/subscriptions","organizations_url":"https://api.github.com/users/chancancode/orgs","repos_url":"https://api.github.com/users/chancancode/repos","events_url":"https://api.github.com/users/chancancode/events{/privacy}","received_events_url":"https://api.github.com/users/chancancode/received_events","type":"User","site_admin":false},"body":"I suspect this could be hoisted up to the `TogglingSyntaxConditionalsTest` level (maybe even the `TogglingConditionalsTest` if we make `foo-bar` a helper instead). Maybe something like this would work:\r\n\r\n```javascript\r\nlet innerTemplate = this.templateFor({ cond: 'cond2', truthy: '{{foo-bar}}', falsy: '' }); // {{#if cond2}}{{foo-bar}}{{else}}{{/if}}\r\nlet outerTemplate = this.templateFor({ cond: 'cond1', truthy: innerTemplate, falsy: '' }); // {{#if cond1}}{{#if cond2}}{{foo-bar}}{{else}}{{/if}}{{else}}{{/if}}\r\nlet wrappedTemplate = this.wrapperFor([outerTemplate]);\r\n\r\nthis.render(wrappedTemplate, { cond1: true, cond2: false });\r\n\r\n...\r\n\r\nthis.runTask(() => {\r\n  set(this.context, 'cond2', true);\r\n  set(this.context, 'cond1', false);\r\n});\r\n\r\n...\r\n```","created_at":"2016-03-28T18:11:06Z","updated_at":"2016-03-28T18:11:06Z","html_url":"https://github.com/emberjs/ember.js/pull/13159#discussion_r57607636","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13159","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/57607636"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13159#discussion_r57607636"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13159"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13159","id":63652748,"html_url":"https://github.com/emberjs/ember.js/pull/13159","diff_url":"https://github.com/emberjs/ember.js/pull/13159.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13159.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13159","number":13159,"state":"open","locked":false,"title":"[Glimmer2] port remaining if-unless tests","user":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"body":"Part of https://github.com/emberjs/ember.js/issues/13127\r\n\r\nTODO:\r\n\r\n * [x] port, consolidate or delete remaining tests\r\n * [x] annotate/deleted moved tests","created_at":"2016-03-22T00:11:56Z","updated_at":"2016-03-28T18:11:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69bcc8ba4063c715b733aa6c1490b40c862aa30f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13159/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13159/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13159/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/1148f4e649bd8aae0af741f1b17ee650a160aeb1","head":{"label":"GavinJoyce:gj/if-unless-tests","ref":"gj/if-unless-tests","sha":"1148f4e649bd8aae0af741f1b17ee650a160aeb1","user":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"repo":{"id":50780854,"name":"ember.js","full_name":"GavinJoyce/ember.js","owner":{"login":"GavinJoyce","id":2526,"avatar_url":"https://avatars.githubusercontent.com/u/2526?v=3","gravatar_id":"","url":"https://api.github.com/users/GavinJoyce","html_url":"https://github.com/GavinJoyce","followers_url":"https://api.github.com/users/GavinJoyce/followers","following_url":"https://api.github.com/users/GavinJoyce/following{/other_user}","gists_url":"https://api.github.com/users/GavinJoyce/gists{/gist_id}","starred_url":"https://api.github.com/users/GavinJoyce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GavinJoyce/subscriptions","organizations_url":"https://api.github.com/users/GavinJoyce/orgs","repos_url":"https://api.github.com/users/GavinJoyce/repos","events_url":"https://api.github.com/users/GavinJoyce/events{/privacy}","received_events_url":"https://api.github.com/users/GavinJoyce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GavinJoyce/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/GavinJoyce/ember.js","forks_url":"https://api.github.com/repos/GavinJoyce/ember.js/forks","keys_url":"https://api.github.com/repos/GavinJoyce/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GavinJoyce/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GavinJoyce/ember.js/teams","hooks_url":"https://api.github.com/repos/GavinJoyce/ember.js/hooks","issue_events_url":"https://api.github.com/repos/GavinJoyce/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/GavinJoyce/ember.js/events","assignees_url":"https://api.github.com/repos/GavinJoyce/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/GavinJoyce/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/GavinJoyce/ember.js/tags","blobs_url":"https://api.github.com/repos/GavinJoyce/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GavinJoyce/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GavinJoyce/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/GavinJoyce/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GavinJoyce/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/GavinJoyce/ember.js/languages","stargazers_url":"https://api.github.com/repos/GavinJoyce/ember.js/stargazers","contributors_url":"https://api.github.com/repos/GavinJoyce/ember.js/contributors","subscribers_url":"https://api.github.com/repos/GavinJoyce/ember.js/subscribers","subscription_url":"https://api.github.com/repos/GavinJoyce/ember.js/subscription","commits_url":"https://api.github.com/repos/GavinJoyce/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/GavinJoyce/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/GavinJoyce/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/GavinJoyce/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/GavinJoyce/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/GavinJoyce/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GavinJoyce/ember.js/merges","archive_url":"https://api.github.com/repos/GavinJoyce/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GavinJoyce/ember.js/downloads","issues_url":"https://api.github.com/repos/GavinJoyce/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/GavinJoyce/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/GavinJoyce/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/GavinJoyce/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GavinJoyce/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/GavinJoyce/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/GavinJoyce/ember.js/deployments","created_at":"2016-01-31T15:27:27Z","updated_at":"2016-01-31T15:27:31Z","pushed_at":"2016-03-28T16:42:28Z","git_url":"git://github.com/GavinJoyce/ember.js.git","ssh_url":"git@github.com:GavinJoyce/ember.js.git","clone_url":"https://github.com/GavinJoyce/ember.js.git","svn_url":"https://github.com/GavinJoyce/ember.js","homepage":"http://www.emberjs.com","size":32048,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"3bf8c0f3865c6dd887c045ab2fe441fabc3ff32f","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-03-28T16:25:13Z","pushed_at":"2016-03-28T16:42:28Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":66498,"stargazers_count":15960,"watchers_count":15960,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3423,"mirror_url":null,"open_issues_count":433,"forks":3423,"open_issues":433,"watchers":15960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13159"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13159"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13159"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13159/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13159/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13159/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/1148f4e649bd8aae0af741f1b17ee650a160aeb1"}}}}