{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/6328","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/6328/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6328/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/6328/events","html_url":"https://github.com/nodejs/node/pull/6328","id":150033081,"number":6328,"title":"repl: Don’t complete expressions when eval() failed","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/repl","name":"repl","color":"5319e7"},{"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/13","html_url":"https://github.com/nodejs/node/milestones/6.0.0","labels_url":"https://api.github.com/repos/nodejs/node/milestones/13/labels","id":1269366,"number":13,"title":"6.0.0","description":"","creator":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":25,"state":"open","created_at":"2015-08-24T13:31:52Z","updated_at":"2016-04-21T18:16:30Z","due_on":"2016-04-30T04:00:00Z","closed_at":null},"comments":3,"created_at":"2016-04-21T10:34:02Z","updated_at":"2016-04-22T05:02:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6328","html_url":"https://github.com/nodejs/node/pull/6328","diff_url":"https://github.com/nodejs/node/pull/6328.diff","patch_url":"https://github.com/nodejs/node/pull/6328.patch"},"body":"##### Checklist\r\n\r\n- [x] tests and code linting passes\r\n- [x] a test and/or benchmark is included\r\n- [x] the commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\nrepl\r\n\r\n##### Description of change\r\n\r\nInstead of changing the way “simple” expressions are detected, switch to ignoring errors when completing. This approach is more generic than the previous one from 0b66b8f, but also changes the way errors are thrown when completing.\r\n\r\nFixes: #6325\r\n\r\nThis includes a revert of the regular expression change in #6192.\r\nThis is also a completely inappropriate solution if it is *intended* that trying to complete expressions like `a = b.c.d` with `b` not defined throw a `ReferenceError`; the test file seems to be laid out to expect that behaviour. I can’t imagine how that might be even remotely desirable, though."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/213257165","html_url":"https://github.com/nodejs/node/pull/6328#issuecomment-213257165","issue_url":"https://api.github.com/repos/nodejs/node/issues/6328","id":213257165,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T05:02:33Z","updated_at":"2016-04-22T05:02:33Z","body":"This LGTM but would like to get more review from @nodejs/ctc "}}