{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/28462","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/28462/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/28462/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/28462/events","html_url":"https://github.com/saltstack/salt/issues/28462","id":114358191,"number":28462,"title":"Bad load from minion - Minions don't refresh keys on master restart until a command is sent over the bus","user":{"login":"JaseFace","id":6116767,"avatar_url":"https://avatars.githubusercontent.com/u/6116767?v=3","gravatar_id":"","url":"https://api.github.com/users/JaseFace","html_url":"https://github.com/JaseFace","followers_url":"https://api.github.com/users/JaseFace/followers","following_url":"https://api.github.com/users/JaseFace/following{/other_user}","gists_url":"https://api.github.com/users/JaseFace/gists{/gist_id}","starred_url":"https://api.github.com/users/JaseFace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaseFace/subscriptions","organizations_url":"https://api.github.com/users/JaseFace/orgs","repos_url":"https://api.github.com/users/JaseFace/repos","events_url":"https://api.github.com/users/JaseFace/events{/privacy}","received_events_url":"https://api.github.com/users/JaseFace/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Core","name":"Core","color":"fef2c0"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Medium%20Severity","name":"Medium Severity","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestones/Approved","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":3059,"closed_issues":3596,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2016-05-05T21:02:22Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2015-10-30T21:20:33Z","updated_at":"2016-05-06T18:36:18Z","closed_at":null,"body":"It appears the minions don't refresh the AES key when the master is restarted until a job is sent to them over the bus.  This is easily reproducible for us on 2015.8.1 (minions and masters).  I've tested with ping_on_rotate true and false with no change.\r\n\r\nAfter a restart we see massive spam in the master logs:\r\n```\r\n[salt.transport.zeromq][ERROR   ][5113] Bad load from minion\r\n```\r\n\r\nI went ahead and added the payload to the log line to get a quick capture of what it was, and it appears to be a valid payload, I'm guessing it's just using the old key:\r\n```\r\n[salt.transport.zeromq][ERROR   ][29352] Bad load from minion {'load': '7y\\xaa\\[..snip..]\\xd2D', 'enc': 'aes'}\r\n```\r\n\r\nIf we run a salt '*' test.ping, the Bad load errors immediately cease.  I haven't dug in past this, as I wanted to see if anyone else had run into similar or there were known bugs.  It appears the ping_on_rotate process isn't applying here as it's actually a full master restart, and we don't see the errors during the daily or key removal rotation, so I believe that process is fine.  Along with fixing the bug that's not triggering the AES rotation as the minions talk to the master after a restart, does a ping_on_start option make sense to compliment?"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/217524346","html_url":"https://github.com/saltstack/salt/issues/28462#issuecomment-217524346","issue_url":"https://api.github.com/repos/saltstack/salt/issues/28462","id":217524346,"user":{"login":"herisanu","id":9824408,"avatar_url":"https://avatars.githubusercontent.com/u/9824408?v=3","gravatar_id":"","url":"https://api.github.com/users/herisanu","html_url":"https://github.com/herisanu","followers_url":"https://api.github.com/users/herisanu/followers","following_url":"https://api.github.com/users/herisanu/following{/other_user}","gists_url":"https://api.github.com/users/herisanu/gists{/gist_id}","starred_url":"https://api.github.com/users/herisanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herisanu/subscriptions","organizations_url":"https://api.github.com/users/herisanu/orgs","repos_url":"https://api.github.com/users/herisanu/repos","events_url":"https://api.github.com/users/herisanu/events{/privacy}","received_events_url":"https://api.github.com/users/herisanu/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T18:36:18Z","updated_at":"2016-05-06T18:36:18Z","body":"Any updates on this issue?"}}