{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/bourbon/pulls/comments/85646878","pull_request_review_id":6352919,"id":85646878,"diff_hunk":"@@ -0,0 +1,31 @@\n+@charset \"UTF-8\";\n+\n+/// Programatically determines the contrast between two colors.\n+///\n+/// Note that the alpha channel is ignored.\n+///\n+/// @link https://goo.gl/54htLV\n+///\n+/// @argument {color (hex)} $color-1\n+///\n+/// @argument {color (hex)} $color-2\n+///\n+/// @return {number (1-21)}\n+///\n+/// @example scss\n+///   contrast(black, white)","path":"core/bourbon/helpers/_contrast-ratio.scss","position":16,"original_position":16,"commit_id":"427c2dad7e18aa7594e82b968e90ac4388d1ec37","original_commit_id":"427c2dad7e18aa7594e82b968e90ac4388d1ec37","user":{"login":"tysongach","id":903327,"avatar_url":"https://avatars.githubusercontent.com/u/903327?v=3","gravatar_id":"","url":"https://api.github.com/users/tysongach","html_url":"https://github.com/tysongach","followers_url":"https://api.github.com/users/tysongach/followers","following_url":"https://api.github.com/users/tysongach/following{/other_user}","gists_url":"https://api.github.com/users/tysongach/gists{/gist_id}","starred_url":"https://api.github.com/users/tysongach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysongach/subscriptions","organizations_url":"https://api.github.com/users/tysongach/orgs","repos_url":"https://api.github.com/users/tysongach/repos","events_url":"https://api.github.com/users/tysongach/events{/privacy}","received_events_url":"https://api.github.com/users/tysongach/received_events","type":"User","site_admin":false},"body":"Needs updating to new name: \r\n\r\n```diff\r\n- ///   contrast(black, white)\r\n+ ///   _contrast-ratio(black, white)\r\n```","created_at":"2016-10-29T19:47:38Z","updated_at":"2016-10-29T19:56:03Z","html_url":"https://github.com/thoughtbot/bourbon/pull/935#discussion_r85646878","pull_request_url":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/bourbon/pulls/comments/85646878"},"html":{"href":"https://github.com/thoughtbot/bourbon/pull/935#discussion_r85646878"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935","id":84009138,"html_url":"https://github.com/thoughtbot/bourbon/pull/935","diff_url":"https://github.com/thoughtbot/bourbon/pull/935.diff","patch_url":"https://github.com/thoughtbot/bourbon/pull/935.patch","issue_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/935","number":935,"state":"open","locked":false,"title":"improve contrast-switch","user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"body":"I tried to improve the contrast-switch function:\r\n\r\n- `$light-color` and `$dark-color` are taken into account when determining whether `$base-color` is light.\r\n- The algorithm for calculating the contrast conforms with [WCAG](https://www.w3.org/TR/WCAG20/#contrast-ratiodef) (though it is not exact because Sass does not have a `pow()` function)\r\n\r\nSee also less/less.js#2754 for a similar change in less.\r\n\r\nI did not yet include any new tests because I do not have a working ruby setup right now. Please let me know what you think of this. If you like it I will manage to add some tests somehow.\r\n","created_at":"2016-09-05T14:19:47Z","updated_at":"2016-10-29T19:56:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f70626d41d5050bc95bb9e8b71cd8541b945cd4b","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/thoughtbot/bourbon/milestones/9","html_url":"https://github.com/thoughtbot/bourbon/milestones/5.0.0","labels_url":"https://api.github.com/repos/thoughtbot/bourbon/milestones/9/labels","id":1022160,"number":9,"title":"5.0.0","description":"- No more vendor prefix mixins\r\n- Lots of maintenance and consistency refinements\r\n- Improved and versioned documentation\r\n- A re-structured directory tree to not pollute the load path","creator":{"login":"tysongach","id":903327,"avatar_url":"https://avatars.githubusercontent.com/u/903327?v=3","gravatar_id":"","url":"https://api.github.com/users/tysongach","html_url":"https://github.com/tysongach","followers_url":"https://api.github.com/users/tysongach/followers","following_url":"https://api.github.com/users/tysongach/following{/other_user}","gists_url":"https://api.github.com/users/tysongach/gists{/gist_id}","starred_url":"https://api.github.com/users/tysongach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tysongach/subscriptions","organizations_url":"https://api.github.com/users/tysongach/orgs","repos_url":"https://api.github.com/users/tysongach/repos","events_url":"https://api.github.com/users/tysongach/events{/privacy}","received_events_url":"https://api.github.com/users/tysongach/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":28,"state":"open","created_at":"2015-03-15T16:31:54Z","updated_at":"2016-10-29T14:57:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/bourbon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/935/comments","statuses_url":"https://api.github.com/repos/thoughtbot/bourbon/statuses/427c2dad7e18aa7594e82b968e90ac4388d1ec37","head":{"label":"xi:feature-improve-contrast","ref":"feature-improve-contrast","sha":"427c2dad7e18aa7594e82b968e90ac4388d1ec37","user":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"repo":{"id":67417602,"name":"bourbon","full_name":"xi/bourbon","owner":{"login":"xi","id":202576,"avatar_url":"https://avatars.githubusercontent.com/u/202576?v=3","gravatar_id":"","url":"https://api.github.com/users/xi","html_url":"https://github.com/xi","followers_url":"https://api.github.com/users/xi/followers","following_url":"https://api.github.com/users/xi/following{/other_user}","gists_url":"https://api.github.com/users/xi/gists{/gist_id}","starred_url":"https://api.github.com/users/xi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xi/subscriptions","organizations_url":"https://api.github.com/users/xi/orgs","repos_url":"https://api.github.com/users/xi/repos","events_url":"https://api.github.com/users/xi/events{/privacy}","received_events_url":"https://api.github.com/users/xi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xi/bourbon","description":"A Lightweight Sass Tool Set:","fork":true,"url":"https://api.github.com/repos/xi/bourbon","forks_url":"https://api.github.com/repos/xi/bourbon/forks","keys_url":"https://api.github.com/repos/xi/bourbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xi/bourbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xi/bourbon/teams","hooks_url":"https://api.github.com/repos/xi/bourbon/hooks","issue_events_url":"https://api.github.com/repos/xi/bourbon/issues/events{/number}","events_url":"https://api.github.com/repos/xi/bourbon/events","assignees_url":"https://api.github.com/repos/xi/bourbon/assignees{/user}","branches_url":"https://api.github.com/repos/xi/bourbon/branches{/branch}","tags_url":"https://api.github.com/repos/xi/bourbon/tags","blobs_url":"https://api.github.com/repos/xi/bourbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xi/bourbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xi/bourbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/xi/bourbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xi/bourbon/statuses/{sha}","languages_url":"https://api.github.com/repos/xi/bourbon/languages","stargazers_url":"https://api.github.com/repos/xi/bourbon/stargazers","contributors_url":"https://api.github.com/repos/xi/bourbon/contributors","subscribers_url":"https://api.github.com/repos/xi/bourbon/subscribers","subscription_url":"https://api.github.com/repos/xi/bourbon/subscription","commits_url":"https://api.github.com/repos/xi/bourbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/xi/bourbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/xi/bourbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/xi/bourbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/xi/bourbon/contents/{+path}","compare_url":"https://api.github.com/repos/xi/bourbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xi/bourbon/merges","archive_url":"https://api.github.com/repos/xi/bourbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xi/bourbon/downloads","issues_url":"https://api.github.com/repos/xi/bourbon/issues{/number}","pulls_url":"https://api.github.com/repos/xi/bourbon/pulls{/number}","milestones_url":"https://api.github.com/repos/xi/bourbon/milestones{/number}","notifications_url":"https://api.github.com/repos/xi/bourbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xi/bourbon/labels{/name}","releases_url":"https://api.github.com/repos/xi/bourbon/releases{/id}","deployments_url":"https://api.github.com/repos/xi/bourbon/deployments","created_at":"2016-09-05T12:07:57Z","updated_at":"2016-09-05T12:07:58Z","pushed_at":"2016-10-29T19:37:14Z","git_url":"git://github.com/xi/bourbon.git","ssh_url":"git@github.com:xi/bourbon.git","clone_url":"https://github.com/xi/bourbon.git","svn_url":"https://github.com/xi/bourbon","homepage":"http://bourbon.io","size":2876,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"7148769f14fb27028d1f42da9f0e696fffd2070b","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":1653882,"name":"bourbon","full_name":"thoughtbot/bourbon","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/bourbon","description":"A Lightweight Sass Tool Set:","fork":false,"url":"https://api.github.com/repos/thoughtbot/bourbon","forks_url":"https://api.github.com/repos/thoughtbot/bourbon/forks","keys_url":"https://api.github.com/repos/thoughtbot/bourbon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/bourbon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/bourbon/teams","hooks_url":"https://api.github.com/repos/thoughtbot/bourbon/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/bourbon/events","assignees_url":"https://api.github.com/repos/thoughtbot/bourbon/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/bourbon/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/bourbon/tags","blobs_url":"https://api.github.com/repos/thoughtbot/bourbon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/bourbon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/bourbon/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/bourbon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/bourbon/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/bourbon/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/bourbon/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/bourbon/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/bourbon/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/bourbon/subscription","commits_url":"https://api.github.com/repos/thoughtbot/bourbon/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/bourbon/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/bourbon/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/bourbon/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/bourbon/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/bourbon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/bourbon/merges","archive_url":"https://api.github.com/repos/thoughtbot/bourbon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/bourbon/downloads","issues_url":"https://api.github.com/repos/thoughtbot/bourbon/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/bourbon/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/bourbon/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/bourbon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/bourbon/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/bourbon/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/bourbon/deployments","created_at":"2011-04-23T15:41:20Z","updated_at":"2016-10-29T13:16:13Z","pushed_at":"2016-10-29T19:37:14Z","git_url":"git://github.com/thoughtbot/bourbon.git","ssh_url":"git@github.com:thoughtbot/bourbon.git","clone_url":"https://github.com/thoughtbot/bourbon.git","svn_url":"https://github.com/thoughtbot/bourbon","homepage":"http://bourbon.io","size":5775,"stargazers_count":7678,"watchers_count":7678,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":863,"mirror_url":null,"open_issues_count":14,"forks":863,"open_issues":14,"watchers":7678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935"},"html":{"href":"https://github.com/thoughtbot/bourbon/pull/935"},"issue":{"href":"https://api.github.com/repos/thoughtbot/bourbon/issues/935"},"comments":{"href":"https://api.github.com/repos/thoughtbot/bourbon/issues/935/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/bourbon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/bourbon/pulls/935/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/bourbon/statuses/427c2dad7e18aa7594e82b968e90ac4388d1ec37"}}}}
{"actor":{"display_login":"tysongach"}}