{"action":"created","issue":{"url":"https://api.github.com/repos/reagent-project/reagent-template/issues/119","repository_url":"https://api.github.com/repos/reagent-project/reagent-template","labels_url":"https://api.github.com/repos/reagent-project/reagent-template/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/reagent-project/reagent-template/issues/119/comments","events_url":"https://api.github.com/repos/reagent-project/reagent-template/issues/119/events","html_url":"https://github.com/reagent-project/reagent-template/issues/119","id":157672935,"number":119,"title":"Stop using profile merging for :cljsbuild key. Just use different builds.","user":{"login":"bhauman","id":2624,"avatar_url":"https://avatars.githubusercontent.com/u/2624?v=3","gravatar_id":"","url":"https://api.github.com/users/bhauman","html_url":"https://github.com/bhauman","followers_url":"https://api.github.com/users/bhauman/followers","following_url":"https://api.github.com/users/bhauman/following{/other_user}","gists_url":"https://api.github.com/users/bhauman/gists{/gist_id}","starred_url":"https://api.github.com/users/bhauman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhauman/subscriptions","organizations_url":"https://api.github.com/users/bhauman/orgs","repos_url":"https://api.github.com/users/bhauman/repos","events_url":"https://api.github.com/users/bhauman/events{/privacy}","received_events_url":"https://api.github.com/users/bhauman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-31T13:34:44Z","updated_at":"2016-05-31T15:40:18Z","closed_at":null,"body":"There are several reasons for this.\r\n\r\nOne reason is `:output-dir` contamination.  Having both compiles go to the same output directory can lead to confusing compilation states when moving from dev to prod.\r\n\r\nMy main reason is that this is where people look for an example of how to set up a ClojureScript project and `(start-figwheel!)` can't do profile merging and it ends up confusing a lot of people.  There is are several reasons for figwheel not to do profile merging, but the biggest one is so that we aren't pulling all of Leiningen into the process that is running the compiler and possibly the dev server. Leiningen is a big dependency that changes slowly and this can lead to all sorts of dependency tree conflicts.\r\n\r\nAnother reason is that profile merging is just not needed.\r\n\r\nThe configuration for `:figwheel` and `:cljsbuild` are \"just data\".  They do not change the runtime environment the way that something like `:dependencies` or something else that modifies the classpath.\r\n\r\nAnd since :cljsbuild lets you have as many builds as you need, there is no need to use profile merging to get the behavior you want.\r\n\r\nSo it would be extremely helpful if we could change this to use multiple builds in cljsbuild.\r\n"},"comment":{"url":"https://api.github.com/repos/reagent-project/reagent-template/issues/comments/222728865","html_url":"https://github.com/reagent-project/reagent-template/issues/119#issuecomment-222728865","issue_url":"https://api.github.com/repos/reagent-project/reagent-template/issues/119","id":222728865,"user":{"login":"yogthos","id":121208,"avatar_url":"https://avatars.githubusercontent.com/u/121208?v=3","gravatar_id":"","url":"https://api.github.com/users/yogthos","html_url":"https://github.com/yogthos","followers_url":"https://api.github.com/users/yogthos/followers","following_url":"https://api.github.com/users/yogthos/following{/other_user}","gists_url":"https://api.github.com/users/yogthos/gists{/gist_id}","starred_url":"https://api.github.com/users/yogthos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yogthos/subscriptions","organizations_url":"https://api.github.com/users/yogthos/orgs","repos_url":"https://api.github.com/users/yogthos/repos","events_url":"https://api.github.com/users/yogthos/events{/privacy}","received_events_url":"https://api.github.com/users/yogthos/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T15:40:17Z","updated_at":"2016-05-31T15:40:17Z","body":"That sounds reasonable to me, @bhauman would you be up for making a pr with the fix? :)"}}
{"actor":{"display_login":"yogthos"}}