{"action":"created","issue":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5708","repository_url":"https://api.github.com/repos/CenterForOpenScience/osf.io","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5708/labels{/name}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5708/comments","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5708/events","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5708","id":156029510,"number":5708,"title":"Feature/osf 4304 [OSF-4304]","user":{"login":"mluke93","id":13735498,"avatar_url":"https://avatars.githubusercontent.com/u/13735498?v=3","gravatar_id":"","url":"https://api.github.com/users/mluke93","html_url":"https://github.com/mluke93","followers_url":"https://api.github.com/users/mluke93/followers","following_url":"https://api.github.com/users/mluke93/following{/other_user}","gists_url":"https://api.github.com/users/mluke93/gists{/gist_id}","starred_url":"https://api.github.com/users/mluke93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mluke93/subscriptions","organizations_url":"https://api.github.com/users/mluke93/orgs","repos_url":"https://api.github.com/users/mluke93/repos","events_url":"https://api.github.com/users/mluke93/events{/privacy}","received_events_url":"https://api.github.com/users/mluke93/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-05-20T19:00:07Z","updated_at":"2016-05-24T13:05:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/5708","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5708","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/5708.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/5708.patch"},"body":"<!-- Before submit your Pull Request, make sure you picked\r\n     the right branch:\r\n\r\n     - For hotfixes, select \"master\" as the target branch\r\n     - For new features, select \"develop\" as the target branch\r\n     - For release feature fixes, select the relevant release branch (release/X.Y.Z) as the target branch -->\r\n\r\n## Purpose\r\n\r\nWhen attempting to embargo a Registration, if the user attempts to pick a date 3 days away (as is required to Embargo) after 8pm, the system informs them that they must pick a date at least 3 days away, and won't let them pick that date (ie. On August 31st 8:36pm, the calendar does not recognize September 3rd as a valid date). The problem lied in the timezone difference between local time and UTC time. There is a four hour difference (hence why it had a problem starting at 8pm). So the valid date calculation needed to account for the time zone difference.\r\n\r\n## Changes\r\n\r\n- Added the Timezone Offset when calculating the chosen end date in milliseconds\r\n- Fixed some of formatting.\r\n\r\n## Side effects\r\n\r\n- The max length (4 years) might have a similar issue to this.\r\n\r\n## Ticket\r\n\r\nhttps://openscience.atlassian.net/browse/OSF-4304"},"comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments/221262017","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/5708#issuecomment-221262017","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/5708","id":221262017,"user":{"login":"brianjgeiger","id":6599111,"avatar_url":"https://avatars.githubusercontent.com/u/6599111?v=3","gravatar_id":"","url":"https://api.github.com/users/brianjgeiger","html_url":"https://github.com/brianjgeiger","followers_url":"https://api.github.com/users/brianjgeiger/followers","following_url":"https://api.github.com/users/brianjgeiger/following{/other_user}","gists_url":"https://api.github.com/users/brianjgeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/brianjgeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianjgeiger/subscriptions","organizations_url":"https://api.github.com/users/brianjgeiger/orgs","repos_url":"https://api.github.com/users/brianjgeiger/repos","events_url":"https://api.github.com/users/brianjgeiger/events{/privacy}","received_events_url":"https://api.github.com/users/brianjgeiger/received_events","type":"User","site_admin":false},"created_at":"2016-05-24T13:05:00Z","updated_at":"2016-05-24T13:05:00Z","body":"Pass done. 🐧 "}}
{"actor":{"display_login":"brianjgeiger"}}