{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/740","repository_url":"https://api.github.com/repos/vufind-org/vufind","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/740/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/740/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/740/events","html_url":"https://github.com/vufind-org/vufind/pull/740","id":162132908,"number":740,"title":"Cancel buttons for holds","user":{"login":"olli-gold","id":1461291,"avatar_url":"https://avatars.githubusercontent.com/u/1461291?v=3","gravatar_id":"","url":"https://api.github.com/users/olli-gold","html_url":"https://github.com/olli-gold","followers_url":"https://api.github.com/users/olli-gold/followers","following_url":"https://api.github.com/users/olli-gold/following{/other_user}","gists_url":"https://api.github.com/users/olli-gold/gists{/gist_id}","starred_url":"https://api.github.com/users/olli-gold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olli-gold/subscriptions","organizations_url":"https://api.github.com/users/olli-gold/orgs","repos_url":"https://api.github.com/users/olli-gold/repos","events_url":"https://api.github.com/users/olli-gold/events{/privacy}","received_events_url":"https://api.github.com/users/olli-gold/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-06-24T12:03:03Z","updated_at":"2016-06-27T07:13:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/740","html_url":"https://github.com/vufind-org/vufind/pull/740","diff_url":"https://github.com/vufind-org/vufind/pull/740.diff","patch_url":"https://github.com/vufind-org/vufind/pull/740.patch"},"body":"This PR fixes a minor problem in the MyResearchController. Normally the buttons to cancel a Hold should get hidden if no Hold can be cancelled. This did not work (at least not in my VuFind instance), and I hope, this little PR fixes that."},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/228669947","html_url":"https://github.com/vufind-org/vufind/pull/740#issuecomment-228669947","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/740","id":228669947,"user":{"login":"olli-gold","id":1461291,"avatar_url":"https://avatars.githubusercontent.com/u/1461291?v=3","gravatar_id":"","url":"https://api.github.com/users/olli-gold","html_url":"https://github.com/olli-gold","followers_url":"https://api.github.com/users/olli-gold/followers","following_url":"https://api.github.com/users/olli-gold/following{/other_user}","gists_url":"https://api.github.com/users/olli-gold/gists{/gist_id}","starred_url":"https://api.github.com/users/olli-gold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olli-gold/subscriptions","organizations_url":"https://api.github.com/users/olli-gold/orgs","repos_url":"https://api.github.com/users/olli-gold/repos","events_url":"https://api.github.com/users/olli-gold/events{/privacy}","received_events_url":"https://api.github.com/users/olli-gold/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T07:13:40Z","updated_at":"2016-06-27T07:13:40Z","body":"Well, this is what I get as $current in the foreach loop in MyResearchController (https://github.com/vufind-org/vufind/blob/master/module/VuFind/src/VuFind/Controller/MyResearchController.php#L916):\r\n```\r\narray (size=11)\r\n  'item_id' => string 'http://uri.gbv.de/document/opac-de-830:bar:830$34096983' (length=55)\r\n  'cancel_details' => string '' (length=0)\r\n  'id' => string '40445623' (length=8)\r\n  'type' => string 'provided' (length=8)\r\n  'location' => string 'Test-Theke' (length=10)\r\n  'position' => null\r\n  'available' => boolean true\r\n  'title' => string 'Praktikum über Entwurf und Manipulation von Datenbanken : SQL/DS (IBM), UDS (Siemens) und MEMODAX / Vossen, Gottfried (1986)' (length=125)\r\n  'callnumber' => string '34:3409-6983' (length=12)\r\n  'create' => string '17.06.2016' (length=10)\r\n  'expire' => string '' (length=0)\r\n```\r\n\r\nAs you see, cancel_details is an empty string as expected.\r\nThis if-clause in https://github.com/vufind-org/vufind/blob/master/module/VuFind/src/VuFind/Controller/MyResearchController.php#L922 is returning true.\r\n\r\nHowever changing the if-clause in https://github.com/vufind-org/vufind/blob/master/module/VuFind/src/VuFind/Controller/MyResearchController.php#L922 like that:\r\n`                && !empty($current['cancel_details'])`\r\nis returning false. \r\n\r\nThus your revision of the PR is working fine for me while the original version is not working fine. I don't see the driver returning anything wrong here, do you?"}}
{"actor":{"display_login":"olli-gold"}}