{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/76487279","id":76487279,"diff_hunk":"@@ -35,29 +35,31 @@ clean:\n \t@rm -fR build dist rpm-build MANIFEST htmlcov .coverage cover ooinstall.egg-info oo-install\n \t@rm -fR $(NAME)env\n \n+viewcover:\n+\txdg-open cover/index.html\n+\n virtualenv:\n \t@echo \"#############################################\"\n \t@echo \"# Creating a virtualenv\"\n \t@echo \"#############################################\"\n \tvirtualenv $(NAME)env\n+\t. $(NAME)env/bin/activate && pip install setuptools==17.1.1","path":"utils/Makefile","position":12,"original_position":12,"commit_id":"635dbc0040b691ac3f2d8cec3296ddf58cfd3072","original_commit_id":"635dbc0040b691ac3f2d8cec3296ddf58cfd3072","user":{"login":"abutcher","id":47003,"avatar_url":"https://avatars.githubusercontent.com/u/47003?v=3","gravatar_id":"","url":"https://api.github.com/users/abutcher","html_url":"https://github.com/abutcher","followers_url":"https://api.github.com/users/abutcher/followers","following_url":"https://api.github.com/users/abutcher/following{/other_user}","gists_url":"https://api.github.com/users/abutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/abutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abutcher/subscriptions","organizations_url":"https://api.github.com/users/abutcher/orgs","repos_url":"https://api.github.com/users/abutcher/repos","events_url":"https://api.github.com/users/abutcher/events{/privacy}","received_events_url":"https://api.github.com/users/abutcher/received_events","type":"User","site_admin":false},"body":"This is the current version on RHEL 7.2, I believe.","created_at":"2016-08-26T21:00:00Z","updated_at":"2016-08-26T21:00:00Z","html_url":"https://github.com/openshift/openshift-ansible/pull/2367#discussion_r76487279","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/76487279"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2367#discussion_r76487279"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367","id":82913625,"html_url":"https://github.com/openshift/openshift-ansible/pull/2367","diff_url":"https://github.com/openshift/openshift-ansible/pull/2367.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/2367.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2367","number":2367,"state":"open","locked":false,"title":"Fix PyLint errors discovered when upgrading to newer version","user":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"body":"    Fix PyLint errors discovered when upgrading to newer version\r\n    \r\n    * Fixes PyLint to run in the virtualenv used for all tests\r\n    \r\n    * Replaced 'LooseVersion' with 'parse_version' from setuptools\r\n    - This is a work around for the issue in\r\n      https://github.com/PyCQA/pylint/issues/73 in which pylint can not\r\n      import disutils.version correctly in a virtualenv.\r\n    \r\n    * Removed the unused function 'delete_hosts' which was causing a\r\n      pylint error as well\r\n    \r\n    * Removed a deprecated pylint pragma option, 'bad-builtin'\r\n    \r\n    * Fixed some import ordering issues it was picky about\r\n    \r\n    * Added another disable for a case where the PyLint suggestion would\r\n      have us altering the container we would be iterating over\r\n    \r\n    * Add code-coverage reports to the unittests with the MINIMUM coverage\r\n      percentage for success set to 70%\r\n    - Current test coverage is at 76%","created_at":"2016-08-26T16:08:05Z","updated_at":"2016-08-26T21:00:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e91270e2a36b4a7e04952fd8374e4b372dc727a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/2367/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/635dbc0040b691ac3f2d8cec3296ddf58cfd3072","head":{"label":"tbielawa:FixNewerPyLintErrors","ref":"FixNewerPyLintErrors","sha":"635dbc0040b691ac3f2d8cec3296ddf58cfd3072","user":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"repo":{"id":61655058,"name":"openshift-ansible","full_name":"tbielawa/openshift-ansible","owner":{"login":"tbielawa","id":33121,"avatar_url":"https://avatars.githubusercontent.com/u/33121?v=3","gravatar_id":"","url":"https://api.github.com/users/tbielawa","html_url":"https://github.com/tbielawa","followers_url":"https://api.github.com/users/tbielawa/followers","following_url":"https://api.github.com/users/tbielawa/following{/other_user}","gists_url":"https://api.github.com/users/tbielawa/gists{/gist_id}","starred_url":"https://api.github.com/users/tbielawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbielawa/subscriptions","organizations_url":"https://api.github.com/users/tbielawa/orgs","repos_url":"https://api.github.com/users/tbielawa/repos","events_url":"https://api.github.com/users/tbielawa/events{/privacy}","received_events_url":"https://api.github.com/users/tbielawa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbielawa/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/tbielawa/openshift-ansible","forks_url":"https://api.github.com/repos/tbielawa/openshift-ansible/forks","keys_url":"https://api.github.com/repos/tbielawa/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbielawa/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbielawa/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/tbielawa/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/tbielawa/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/tbielawa/openshift-ansible/events","assignees_url":"https://api.github.com/repos/tbielawa/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/tbielawa/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/tbielawa/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbielawa/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/tbielawa/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/tbielawa/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/tbielawa/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/tbielawa/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/tbielawa/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/tbielawa/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbielawa/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbielawa/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbielawa/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbielawa/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/tbielawa/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbielawa/openshift-ansible/merges","archive_url":"https://api.github.com/repos/tbielawa/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbielawa/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/tbielawa/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/tbielawa/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/tbielawa/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/tbielawa/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbielawa/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/tbielawa/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/tbielawa/openshift-ansible/deployments","created_at":"2016-06-21T17:54:56Z","updated_at":"2016-06-21T17:55:00Z","pushed_at":"2016-08-26T19:27:45Z","git_url":"git://github.com/tbielawa/openshift-ansible.git","ssh_url":"git@github.com:tbielawa/openshift-ansible.git","clone_url":"https://github.com/tbielawa/openshift-ansible.git","svn_url":"https://github.com/tbielawa/openshift-ansible","homepage":"install.openshift.com","size":5986,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"739648d2131a2723a21eafa4217203025438e729","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Ansible Code","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2016-08-25T21:38:15Z","pushed_at":"2016-08-26T20:56:51Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"install.openshift.com","size":7879,"stargazers_count":229,"watchers_count":229,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":371,"mirror_url":null,"open_issues_count":336,"forks":371,"open_issues":336,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/2367"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2367"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/2367/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/2367/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/635dbc0040b691ac3f2d8cec3296ddf58cfd3072"}}}}
{"actor":{"display_login":"abutcher"}}