{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/61198802","id":61198802,"diff_hunk":"@@ -204,11 +204,12 @@ in\n         serviceConfig =\n           { ExecStartPre = \"${pkgs.coreutils}/bin/rm -f %t/ssh-agent\";\n             ExecStart =\n-                \"${cfg.package}/bin/ssh-agent \" +\n+                \"${cfg.package}/bin/ssh-agent -D \" +\n                 optionalString (cfg.agentTimeout != null) (\"-t ${cfg.agentTimeout} \") +\n                 \"-a %t/ssh-agent\";\n+            ExecStartPost = \"/bin/sh -c 'set -eu ; while [ ! -S $SSH_AUCK_SOCK ]; do sleep 1; done'\";","path":"nixos/modules/programs/ssh.nix","position":8,"original_position":8,"commit_id":"140f426efa757e0d63319ab2a871240a1e9a1371","original_commit_id":"140f426efa757e0d63319ab2a871240a1e9a1371","user":{"login":"joachifm","id":41977,"avatar_url":"https://avatars.githubusercontent.com/u/41977?v=3","gravatar_id":"","url":"https://api.github.com/users/joachifm","html_url":"https://github.com/joachifm","followers_url":"https://api.github.com/users/joachifm/followers","following_url":"https://api.github.com/users/joachifm/following{/other_user}","gists_url":"https://api.github.com/users/joachifm/gists{/gist_id}","starred_url":"https://api.github.com/users/joachifm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachifm/subscriptions","organizations_url":"https://api.github.com/users/joachifm/orgs","repos_url":"https://api.github.com/users/joachifm/repos","events_url":"https://api.github.com/users/joachifm/events{/privacy}","received_events_url":"https://api.github.com/users/joachifm/received_events","type":"User","site_admin":false},"body":"I wonder, isn't sleeping for a whole second between tests a bit excessive? `sleep` accepts fractional arguments.","created_at":"2016-04-27T03:18:21Z","updated_at":"2016-04-27T03:18:21Z","html_url":"https://github.com/NixOS/nixpkgs/pull/14994#discussion_r61198802","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/61198802"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/14994#discussion_r61198802"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994","id":67844593,"html_url":"https://github.com/NixOS/nixpkgs/pull/14994","diff_url":"https://github.com/NixOS/nixpkgs/pull/14994.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/14994.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14994","number":14994,"state":"open","locked":false,"title":"ssh-agent module: run in foreground as upstream recommends","user":{"login":"peterhoeg","id":722550,"avatar_url":"https://avatars.githubusercontent.com/u/722550?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhoeg","html_url":"https://github.com/peterhoeg","followers_url":"https://api.github.com/users/peterhoeg/followers","following_url":"https://api.github.com/users/peterhoeg/following{/other_user}","gists_url":"https://api.github.com/users/peterhoeg/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhoeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhoeg/subscriptions","organizations_url":"https://api.github.com/users/peterhoeg/orgs","repos_url":"https://api.github.com/users/peterhoeg/repos","events_url":"https://api.github.com/users/peterhoeg/events{/privacy}","received_events_url":"https://api.github.com/users/peterhoeg/received_events","type":"User","site_admin":false},"body":"I'm using it here and it works perfectly fine.\r\n\r\nSystemd's official recommendation is that everything should run in the foreground.\r\n\r\n###### Things done\r\n\r\n- [X] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [X] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n","created_at":"2016-04-26T08:23:34Z","updated_at":"2016-04-27T03:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d09438af02bc08486fd2639763e43feeaefd1f09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14994/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/140f426efa757e0d63319ab2a871240a1e9a1371","head":{"label":"peterhoeg:ssh-agent","ref":"ssh-agent","sha":"140f426efa757e0d63319ab2a871240a1e9a1371","user":{"login":"peterhoeg","id":722550,"avatar_url":"https://avatars.githubusercontent.com/u/722550?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhoeg","html_url":"https://github.com/peterhoeg","followers_url":"https://api.github.com/users/peterhoeg/followers","following_url":"https://api.github.com/users/peterhoeg/following{/other_user}","gists_url":"https://api.github.com/users/peterhoeg/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhoeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhoeg/subscriptions","organizations_url":"https://api.github.com/users/peterhoeg/orgs","repos_url":"https://api.github.com/users/peterhoeg/repos","events_url":"https://api.github.com/users/peterhoeg/events{/privacy}","received_events_url":"https://api.github.com/users/peterhoeg/received_events","type":"User","site_admin":false},"repo":{"id":53913648,"name":"nixpkgs","full_name":"peterhoeg/nixpkgs","owner":{"login":"peterhoeg","id":722550,"avatar_url":"https://avatars.githubusercontent.com/u/722550?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhoeg","html_url":"https://github.com/peterhoeg","followers_url":"https://api.github.com/users/peterhoeg/followers","following_url":"https://api.github.com/users/peterhoeg/following{/other_user}","gists_url":"https://api.github.com/users/peterhoeg/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhoeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhoeg/subscriptions","organizations_url":"https://api.github.com/users/peterhoeg/orgs","repos_url":"https://api.github.com/users/peterhoeg/repos","events_url":"https://api.github.com/users/peterhoeg/events{/privacy}","received_events_url":"https://api.github.com/users/peterhoeg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterhoeg/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/peterhoeg/nixpkgs","forks_url":"https://api.github.com/repos/peterhoeg/nixpkgs/forks","keys_url":"https://api.github.com/repos/peterhoeg/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterhoeg/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterhoeg/nixpkgs/teams","hooks_url":"https://api.github.com/repos/peterhoeg/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/peterhoeg/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/peterhoeg/nixpkgs/events","assignees_url":"https://api.github.com/repos/peterhoeg/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/peterhoeg/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/peterhoeg/nixpkgs/tags","blobs_url":"https://api.github.com/repos/peterhoeg/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterhoeg/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterhoeg/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterhoeg/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterhoeg/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/peterhoeg/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/peterhoeg/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/peterhoeg/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/peterhoeg/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/peterhoeg/nixpkgs/subscription","commits_url":"https://api.github.com/repos/peterhoeg/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterhoeg/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterhoeg/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterhoeg/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterhoeg/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/peterhoeg/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterhoeg/nixpkgs/merges","archive_url":"https://api.github.com/repos/peterhoeg/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterhoeg/nixpkgs/downloads","issues_url":"https://api.github.com/repos/peterhoeg/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/peterhoeg/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/peterhoeg/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/peterhoeg/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterhoeg/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/peterhoeg/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/peterhoeg/nixpkgs/deployments","created_at":"2016-03-15T04:07:05Z","updated_at":"2016-03-15T04:07:27Z","pushed_at":"2016-04-27T02:30:30Z","git_url":"git://github.com/peterhoeg/nixpkgs.git","ssh_url":"git@github.com:peterhoeg/nixpkgs.git","clone_url":"https://github.com/peterhoeg/nixpkgs.git","svn_url":"https://github.com/peterhoeg/nixpkgs","homepage":null,"size":327345,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"4c10d404e7f3d68fb818b6dddc98b162b0d00832","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-04-27T03:04:53Z","pushed_at":"2016-04-27T02:07:09Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":518272,"stargazers_count":1059,"watchers_count":1059,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1365,"mirror_url":null,"open_issues_count":1307,"forks":1365,"open_issues":1307,"watchers":1059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/14994"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14994"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/14994/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14994/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/140f426efa757e0d63319ab2a871240a1e9a1371"}}}}