{"push_id":1071986552,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"76955364934b1778324076737b390cf3a4def56b","before":"7816ad4127e141e5f815ac24020e104a64d2d7ef","commits":[{"sha":"76955364934b1778324076737b390cf3a4def56b","author":{"email":"b5829ab323f3e33c2eddc22f59219bf7aeb2b325@eldorado.org.br","name":"Igor Nunes"},"message":"Improve strcoll test portability\n\nSummary:Accordingly to the man page [1] and php documentarion [2], the\nstrcoll function does not specify the return value for strcoll\nwhen the operands are not equal. It just specifies if the return\nvalue must be greater, or lower than zero in case the operands are\ndifferent.\n\nFor ppc64, when running the following chunk of code in a cpp\nprogram (i.e. using string.h's strcoll function, like hhvm does),\nI get \"1\" as result:\n\n  setlocale(LC_COLLATE,\"C\");\n  printf(\"%d\\n\", strcoll(\"a\",\"A\"));\n\nHowever on x86 I get \"32\".\n\nThe results are different, but according to [1] and [2] they are\nnot wrong. The zend test [3] is done in a portable way.\n\n[1] http://linux.die.net/man/3/strcoll\n[2] http://php.net/manual/en/function.strcoll.php\n[3] hphp/test/zend/good/ext/standard/tests/strings/strcoll.php\nCloses https://github.com/facebook/hhvm/pull/6981\n\nReviewed By: Orvid\n\nDifferential Revision: D3169829\n\nfb-gh-sync-id: 9d5fb792176d6a50c7ad3ab90035f1fda2493826\nfbshipit-source-id: 9d5fb792176d6a50c7ad3ab90035f1fda2493826","distinct":true,"url":"https://api.github.com/repos/facebook/hhvm/commits/76955364934b1778324076737b390cf3a4def56b"}]}