{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/59086764","id":59086764,"diff_hunk":"@@ -1,24 +1,40 @@\n package cluster\n \n import (\n+\t\"errors\"\n \t\"testing\"\n \n \t\"github.com/aws/aws-sdk-go/aws\"\n+\t\"github.com/aws/aws-sdk-go/aws/awserr\"\n \t\"github.com/aws/aws-sdk-go/service/ec2\"\n \t\"github.com/coreos/coreos-kubernetes/multi-node/aws/pkg/config\"\n )\n \n-type dummyEC2Service map[string]struct {\n+const minimalConfigYaml = `\n+externalDNSName: test-external-dns-name\n+keyName: test-key-name\n+region: us-west-1\n+availabilityZone: us-west-1c\n+clusterName: test-cluster-name\n+kmsKeyArn: \"arn:aws:kms:us-west-1:xxxxxxxxx:key/xxxxxxxxxxxxxxxxxxx\"\n+`\n+\n+type VPC struct {\n \tcidr        string\n \tsubnetCidrs []string\n }\n \n+type dummyEC2Service struct {\n+\tVPCs     map[string]VPC\n+\tKeyPairs map[string]bool\n+}\n+\n func (svc dummyEC2Service) DescribeVpcs(input *ec2.DescribeVpcsInput) (*ec2.DescribeVpcsOutput, error) {\n \toutput := ec2.DescribeVpcsOutput{}\n-\tfor _, vpcId := range input.VpcIds {\n-\t\tif vpc, ok := svc[*vpcId]; ok {\n+\tfor _, vpcID := range input.VpcIds {","path":"multi-node/aws/pkg/cluster/cluster_test.go","position":37,"original_position":37,"commit_id":"1e7a92de493fffccc7e71291b5dc3b1aad5d4d33","original_commit_id":"1e7a92de493fffccc7e71291b5dc3b1aad5d4d33","user":{"login":"cgag","id":696309,"avatar_url":"https://avatars.githubusercontent.com/u/696309?v=3","gravatar_id":"","url":"https://api.github.com/users/cgag","html_url":"https://github.com/cgag","followers_url":"https://api.github.com/users/cgag/followers","following_url":"https://api.github.com/users/cgag/following{/other_user}","gists_url":"https://api.github.com/users/cgag/gists{/gist_id}","starred_url":"https://api.github.com/users/cgag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgag/subscriptions","organizations_url":"https://api.github.com/users/cgag/orgs","repos_url":"https://api.github.com/users/cgag/repos","events_url":"https://api.github.com/users/cgag/events{/privacy}","received_events_url":"https://api.github.com/users/cgag/received_events","type":"User","site_admin":false},"body":"This capitalization makes golint happy, but it's inconsistent with the amazon's naming.  I'd prefer to not propagate their deviancy, but I can change this back if we'd rather be consistent.","created_at":"2016-04-08T20:45:23Z","updated_at":"2016-04-08T20:45:23Z","html_url":"https://github.com/coreos/coreos-kubernetes/pull/362#discussion_r59086764","pull_request_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/59086764"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/362#discussion_r59086764"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362","id":64400822,"html_url":"https://github.com/coreos/coreos-kubernetes/pull/362","diff_url":"https://github.com/coreos/coreos-kubernetes/pull/362.diff","patch_url":"https://github.com/coreos/coreos-kubernetes/pull/362.patch","issue_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/362","number":362,"state":"open","locked":false,"title":"kube-aws: validate that the key pair exists","user":{"login":"cgag","id":696309,"avatar_url":"https://avatars.githubusercontent.com/u/696309?v=3","gravatar_id":"","url":"https://api.github.com/users/cgag","html_url":"https://github.com/cgag","followers_url":"https://api.github.com/users/cgag/followers","following_url":"https://api.github.com/users/cgag/following{/other_user}","gists_url":"https://api.github.com/users/cgag/gists{/gist_id}","starred_url":"https://api.github.com/users/cgag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgag/subscriptions","organizations_url":"https://api.github.com/users/cgag/orgs","repos_url":"https://api.github.com/users/cgag/repos","events_url":"https://api.github.com/users/cgag/events{/privacy}","received_events_url":"https://api.github.com/users/cgag/received_events","type":"User","site_admin":false},"body":"fixes #331","created_at":"2016-03-29T01:19:19Z","updated_at":"2016-04-08T20:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97cd5803bf8a8357e126264a0d0d2aa9f4857016","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/milestones/2","html_url":"https://github.com/coreos/coreos-kubernetes/milestones/v.0.5.2","labels_url":"https://api.github.com/repos/coreos/coreos-kubernetes/milestones/2/labels","id":1669681,"number":2,"title":"v.0.5.2","description":"","creator":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":6,"state":"closed","created_at":"2016-03-28T17:54:54Z","updated_at":"2016-04-08T01:41:39Z","due_on":"2016-03-31T07:00:00Z","closed_at":"2016-04-08T01:41:39Z"},"commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/362/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/1e7a92de493fffccc7e71291b5dc3b1aad5d4d33","head":{"label":"cgag:validate-key-pair","ref":"validate-key-pair","sha":"1e7a92de493fffccc7e71291b5dc3b1aad5d4d33","user":{"login":"cgag","id":696309,"avatar_url":"https://avatars.githubusercontent.com/u/696309?v=3","gravatar_id":"","url":"https://api.github.com/users/cgag","html_url":"https://github.com/cgag","followers_url":"https://api.github.com/users/cgag/followers","following_url":"https://api.github.com/users/cgag/following{/other_user}","gists_url":"https://api.github.com/users/cgag/gists{/gist_id}","starred_url":"https://api.github.com/users/cgag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgag/subscriptions","organizations_url":"https://api.github.com/users/cgag/orgs","repos_url":"https://api.github.com/users/cgag/repos","events_url":"https://api.github.com/users/cgag/events{/privacy}","received_events_url":"https://api.github.com/users/cgag/received_events","type":"User","site_admin":false},"repo":{"id":54413236,"name":"coreos-kubernetes","full_name":"cgag/coreos-kubernetes","owner":{"login":"cgag","id":696309,"avatar_url":"https://avatars.githubusercontent.com/u/696309?v=3","gravatar_id":"","url":"https://api.github.com/users/cgag","html_url":"https://github.com/cgag","followers_url":"https://api.github.com/users/cgag/followers","following_url":"https://api.github.com/users/cgag/following{/other_user}","gists_url":"https://api.github.com/users/cgag/gists{/gist_id}","starred_url":"https://api.github.com/users/cgag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgag/subscriptions","organizations_url":"https://api.github.com/users/cgag/orgs","repos_url":"https://api.github.com/users/cgag/repos","events_url":"https://api.github.com/users/cgag/events{/privacy}","received_events_url":"https://api.github.com/users/cgag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgag/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":true,"url":"https://api.github.com/repos/cgag/coreos-kubernetes","forks_url":"https://api.github.com/repos/cgag/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/cgag/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgag/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgag/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/cgag/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/cgag/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/cgag/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/cgag/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/cgag/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/cgag/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/cgag/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgag/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgag/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgag/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgag/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/cgag/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/cgag/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/cgag/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/cgag/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/cgag/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/cgag/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgag/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgag/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgag/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgag/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/cgag/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgag/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/cgag/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgag/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/cgag/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/cgag/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/cgag/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/cgag/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgag/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/cgag/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/cgag/coreos-kubernetes/deployments","created_at":"2016-03-21T18:32:36Z","updated_at":"2016-04-05T23:05:40Z","pushed_at":"2016-04-08T20:38:22Z","git_url":"git://github.com/cgag/coreos-kubernetes.git","ssh_url":"git@github.com:cgag/coreos-kubernetes.git","clone_url":"https://github.com/cgag/coreos-kubernetes.git","svn_url":"https://github.com/cgag/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":15786,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"b71dc7122438e45b82ac00ff2d04b35dde590fd0","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":41458519,"name":"coreos-kubernetes","full_name":"coreos/coreos-kubernetes","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":false,"url":"https://api.github.com/repos/coreos/coreos-kubernetes","forks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/coreos/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/coreos/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/deployments","created_at":"2015-08-27T01:25:24Z","updated_at":"2016-04-07T13:40:51Z","pushed_at":"2016-04-08T20:38:23Z","git_url":"git://github.com/coreos/coreos-kubernetes.git","ssh_url":"git@github.com:coreos/coreos-kubernetes.git","clone_url":"https://github.com/coreos/coreos-kubernetes.git","svn_url":"https://github.com/coreos/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":40902,"stargazers_count":283,"watchers_count":283,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":66,"forks":158,"open_issues":66,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/362"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/362"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/1e7a92de493fffccc7e71291b5dc3b1aad5d4d33"}}}}