{"action":"created","comment":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/55823050","id":55823050,"diff_hunk":"@@ -86,7 +86,8 @@ int git_config__cvar(int *out, git_config *config, git_cvar_cached cvar)\n \tstruct map_data *data = &_cvar_maps[(int)cvar];\n \tgit_config_entry *entry;\n \n-\tgit_config__lookup_entry(&entry, config, data->cvar_name, false);\n+\tif ((error = git_config__lookup_entry(&entry, config, data->cvar_name, false)) < 0)\n+\t\treturn error;","path":"src/config_cache.c","position":6,"original_position":6,"commit_id":"64036ba14f69443afca0779718f4901a94ecc895","original_commit_id":"64036ba14f69443afca0779718f4901a94ecc895","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"body":"In fact it does not, see the commit message. `git_config__lookup_entry` with `no_errors == false` calls `get_entry` with `GET_NO_MISSING`. So we shouldn't get an error for missing entries.","created_at":"2016-03-11T12:20:57Z","updated_at":"2016-03-11T12:20:57Z","html_url":"https://github.com/libgit2/libgit2/pull/3677#discussion_r55823050","pull_request_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3677","_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments/55823050"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3677#discussion_r55823050"},"pull_request":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3677"}}},"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/3677","id":62521083,"html_url":"https://github.com/libgit2/libgit2/pull/3677","diff_url":"https://github.com/libgit2/libgit2/pull/3677.diff","patch_url":"https://github.com/libgit2/libgit2/pull/3677.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/3677","number":3677,"state":"open","locked":false,"title":"Coverity fixes round 7","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"body":"Mostly fixes involving ignored return codes. Down to a defect density of 0.25 and 29 defects outstanding in my fork.\r\n\r\nWhile we're at it: I've got a custom user model that fixes how Coverity models vectors (see [user_model.c](https://github.com/pks-t/libgit2/blob/f943300f1001e146445802df3ee3cbefd6bf352e/script/user_model.c)). It fixes some issues but requires us to manually upload the file into Coverity. Do we want this added?","created_at":"2016-03-11T10:03:50Z","updated_at":"2016-03-11T12:20:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b08270cd69c446a4b087ecd43dbab939d6f29ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3677/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/3677/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/3677/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/64036ba14f69443afca0779718f4901a94ecc895","head":{"label":"pks-t:pks/coverity-fixes-round7","ref":"pks/coverity-fixes-round7","sha":"64036ba14f69443afca0779718f4901a94ecc895","user":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"repo":{"id":29849449,"name":"libgit2","full_name":"pks-t/libgit2","owner":{"login":"pks-t","id":4056630,"avatar_url":"https://avatars.githubusercontent.com/u/4056630?v=3","gravatar_id":"","url":"https://api.github.com/users/pks-t","html_url":"https://github.com/pks-t","followers_url":"https://api.github.com/users/pks-t/followers","following_url":"https://api.github.com/users/pks-t/following{/other_user}","gists_url":"https://api.github.com/users/pks-t/gists{/gist_id}","starred_url":"https://api.github.com/users/pks-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pks-t/subscriptions","organizations_url":"https://api.github.com/users/pks-t/orgs","repos_url":"https://api.github.com/users/pks-t/repos","events_url":"https://api.github.com/users/pks-t/events{/privacy}","received_events_url":"https://api.github.com/users/pks-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pks-t/libgit2","description":"The Library","fork":true,"url":"https://api.github.com/repos/pks-t/libgit2","forks_url":"https://api.github.com/repos/pks-t/libgit2/forks","keys_url":"https://api.github.com/repos/pks-t/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pks-t/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pks-t/libgit2/teams","hooks_url":"https://api.github.com/repos/pks-t/libgit2/hooks","issue_events_url":"https://api.github.com/repos/pks-t/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/pks-t/libgit2/events","assignees_url":"https://api.github.com/repos/pks-t/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/pks-t/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/pks-t/libgit2/tags","blobs_url":"https://api.github.com/repos/pks-t/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pks-t/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pks-t/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pks-t/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pks-t/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/pks-t/libgit2/languages","stargazers_url":"https://api.github.com/repos/pks-t/libgit2/stargazers","contributors_url":"https://api.github.com/repos/pks-t/libgit2/contributors","subscribers_url":"https://api.github.com/repos/pks-t/libgit2/subscribers","subscription_url":"https://api.github.com/repos/pks-t/libgit2/subscription","commits_url":"https://api.github.com/repos/pks-t/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pks-t/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pks-t/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pks-t/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pks-t/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/pks-t/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pks-t/libgit2/merges","archive_url":"https://api.github.com/repos/pks-t/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pks-t/libgit2/downloads","issues_url":"https://api.github.com/repos/pks-t/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/pks-t/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/pks-t/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/pks-t/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pks-t/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/pks-t/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/pks-t/libgit2/deployments","created_at":"2015-01-26T07:12:59Z","updated_at":"2016-02-09T16:51:49Z","pushed_at":"2016-03-11T11:29:07Z","git_url":"git://github.com/pks-t/libgit2.git","ssh_url":"git@github.com:pks-t/libgit2.git","clone_url":"https://github.com/pks-t/libgit2.git","svn_url":"https://github.com/pks-t/libgit2","homepage":"http://libgit2.github.com","size":19927,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"2ba9a0ddacd315dafb54990ff2bfa204e6924016","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"name":"libgit2","full_name":"libgit2/libgit2","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2","description":"The Library","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2016-03-11T10:20:24Z","pushed_at":"2016-03-11T11:29:08Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"http://libgit2.github.com","size":35097,"stargazers_count":5519,"watchers_count":5519,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1326,"mirror_url":null,"open_issues_count":148,"forks":1326,"open_issues":148,"watchers":5519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3677"},"html":{"href":"https://github.com/libgit2/libgit2/pull/3677"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3677"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/3677/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3677/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/3677/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/64036ba14f69443afca0779718f4901a94ecc895"}}}}