{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1042","repository_url":"https://api.github.com/repos/kaldi-asr/kaldi","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1042/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1042/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1042/events","html_url":"https://github.com/kaldi-asr/kaldi/pull/1042","id":178075367,"number":1042,"title":"Avoid segfault in wav-reverberate","user":{"login":"jfainberg","id":2356937,"avatar_url":"https://avatars.githubusercontent.com/u/2356937?v=3","gravatar_id":"","url":"https://api.github.com/users/jfainberg","html_url":"https://github.com/jfainberg","followers_url":"https://api.github.com/users/jfainberg/followers","following_url":"https://api.github.com/users/jfainberg/following{/other_user}","gists_url":"https://api.github.com/users/jfainberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jfainberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfainberg/subscriptions","organizations_url":"https://api.github.com/users/jfainberg/orgs","repos_url":"https://api.github.com/users/jfainberg/repos","events_url":"https://api.github.com/users/jfainberg/events{/privacy}","received_events_url":"https://api.github.com/users/jfainberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-20T14:25:37Z","updated_at":"2016-09-20T15:14:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1042","html_url":"https://github.com/kaldi-asr/kaldi/pull/1042","diff_url":"https://github.com/kaldi-asr/kaldi/pull/1042.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/1042.patch"},"body":"Using --additive-signals without also setting --snrs and --start-times\r\nproduces a segmentation fault when calling AddNoise (snr_vector and\r\nstart_time_vector empty). Will check that these arguments are set and\r\nthat their length matches the number of added signals. Not sure \r\nwhether the check for empty arguments is superfluous when we have \r\nthe assertions later on.\r\n\r\nAlternatively, could set more sensible default values for snrs and\r\nstart_times, e.g. 0 for all additive signals in both snrs and\r\nstart_times?"},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/248332455","html_url":"https://github.com/kaldi-asr/kaldi/pull/1042#issuecomment-248332455","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1042","id":248332455,"user":{"login":"jfainberg","id":2356937,"avatar_url":"https://avatars.githubusercontent.com/u/2356937?v=3","gravatar_id":"","url":"https://api.github.com/users/jfainberg","html_url":"https://github.com/jfainberg","followers_url":"https://api.github.com/users/jfainberg/followers","following_url":"https://api.github.com/users/jfainberg/following{/other_user}","gists_url":"https://api.github.com/users/jfainberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jfainberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfainberg/subscriptions","organizations_url":"https://api.github.com/users/jfainberg/orgs","repos_url":"https://api.github.com/users/jfainberg/repos","events_url":"https://api.github.com/users/jfainberg/events{/privacy}","received_events_url":"https://api.github.com/users/jfainberg/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T15:14:10Z","updated_at":"2016-09-20T15:14:10Z","body":"Thanks! Unfortunately it failed at the same place... Bit confusing why it would fail, but I'll try to debug..."}}
{"actor":{"display_login":"jfainberg"}}