{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14770","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14770/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14770/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14770/events","html_url":"https://github.com/NixOS/nixpkgs/pull/14770","id":148904453,"number":14770,"title":"Qmake build hooks","user":{"login":"abbradar","id":1174810,"avatar_url":"https://avatars.githubusercontent.com/u/1174810?v=3","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/0.kind:%20enhancement","name":"0.kind: enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/9.needs:%20feedback","name":"9.needs: feedback","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-04-17T00:17:24Z","updated_at":"2016-07-17T15:01:36Z","closed_at":"2016-04-20T16:19:40Z","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/14770","html_url":"https://github.com/NixOS/nixpkgs/pull/14770","diff_url":"https://github.com/NixOS/nixpkgs/pull/14770.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/14770.patch"},"body":"###### Things done\r\n\r\n- [ ] Tested using sandboxing (`nix-build --option build-use-chroot true` or [nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nThis adds two hooks in spirit of `autoreconfHook`: `qmake4Hook` and `qt5{4,5}.qmakeHook`. Both are meant to automatically execute `qmake` on configure stage with necessary preparations and `PREFIX` argument. I've went through all packages that use Qt and half-automatically moved them to using those hooks. Also I did a little change in Qt 5 hook, moving final qmake setup to `postHook` from `preConfigureHook` -- this allows one to override `configurePhase` is he really wants to without additional headache.\r\n\r\ncc @vcunat @ttuegel @aszlig (I've reverted your commits that add `preConfigure` in packages -- should perhaps have announced my to-be work earlier to avoid this).\r\n\r\nWIP because this needs testing, although it builds several Qt 4/5 packages successfully. The problem is that I cannot test all of them right now -- several are broken, and `nox-review` doesn't work because of that."},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/233186176","html_url":"https://github.com/NixOS/nixpkgs/pull/14770#issuecomment-233186176","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/14770","id":233186176,"user":{"login":"womfoo","id":1595132,"avatar_url":"https://avatars.githubusercontent.com/u/1595132?v=3","gravatar_id":"","url":"https://api.github.com/users/womfoo","html_url":"https://github.com/womfoo","followers_url":"https://api.github.com/users/womfoo/followers","following_url":"https://api.github.com/users/womfoo/following{/other_user}","gists_url":"https://api.github.com/users/womfoo/gists{/gist_id}","starred_url":"https://api.github.com/users/womfoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/womfoo/subscriptions","organizations_url":"https://api.github.com/users/womfoo/orgs","repos_url":"https://api.github.com/users/womfoo/repos","events_url":"https://api.github.com/users/womfoo/events{/privacy}","received_events_url":"https://api.github.com/users/womfoo/received_events","type":"User","site_admin":false},"created_at":"2016-07-17T15:01:36Z","updated_at":"2016-07-17T15:01:36Z","body":"Hey @tokudan I've just prepared a fix for fritzing in #17043"}}
{"actor":{"display_login":"womfoo"}}