{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/exhibits/pulls/comments/70363789","id":70363789,"diff_hunk":"@@ -18,7 +18,7 @@\n # directory. Alternatively, in the individual `*_spec.rb` files, manually\n # require only the support files necessary.\n #\n-# Dir[Rails.root.join(\"spec/support/**/*.rb\")].each { |f| require f }\n+Dir[Rails.root.join(\"spec/support/**/*.rb\")].each { |f| require f }","path":"spec/rails_helper.rb","position":5,"original_position":5,"commit_id":"56e319eca7c13b69e31198c7244f0620dba3cb82","original_commit_id":"56e319eca7c13b69e31198c7244f0620dba3cb82","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2016-07-12T01:06:25Z","updated_at":"2016-07-12T01:06:25Z","html_url":"https://github.com/sul-dlss/exhibits/pull/239#discussion_r70363789","pull_request_url":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/exhibits/pulls/comments/70363789"},"html":{"href":"https://github.com/sul-dlss/exhibits/pull/239#discussion_r70363789"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239","id":77047176,"html_url":"https://github.com/sul-dlss/exhibits/pull/239","diff_url":"https://github.com/sul-dlss/exhibits/pull/239.diff","patch_url":"https://github.com/sul-dlss/exhibits/pull/239.patch","issue_url":"https://api.github.com/repos/sul-dlss/exhibits/issues/239","number":239,"state":"open","locked":false,"title":"[WIP] First stab at hiding exhibit creation from non-admins. Refs #212","user":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars.githubusercontent.com/u/131982?v=3","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"body":"The problem I'm running into, however, is in testing my changes. Apparently every FactoryGirl user winds up being able to create exhibits, because every user returns an admin role when I call `#roles` on the user instance, and `#superadmin` returns `true`.","created_at":"2016-07-12T01:06:23Z","updated_at":"2016-07-12T01:06:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"086e2586ffb7f066ca6f2083e0db508d9ccfb01f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/exhibits/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/exhibits/issues/239/comments","statuses_url":"https://api.github.com/repos/sul-dlss/exhibits/statuses/56e319eca7c13b69e31198c7244f0620dba3cb82","head":{"label":"sul-dlss:hide_request_new_exhibit_block_for_non_admin_users","ref":"hide_request_new_exhibit_block_for_non_admin_users","sha":"56e319eca7c13b69e31198c7244f0620dba3cb82","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":18410674,"name":"exhibits","full_name":"sul-dlss/exhibits","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/exhibits","description":"Stanford University Libraries online exhibits showcase","fork":false,"url":"https://api.github.com/repos/sul-dlss/exhibits","forks_url":"https://api.github.com/repos/sul-dlss/exhibits/forks","keys_url":"https://api.github.com/repos/sul-dlss/exhibits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/exhibits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/exhibits/teams","hooks_url":"https://api.github.com/repos/sul-dlss/exhibits/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/exhibits/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/exhibits/events","assignees_url":"https://api.github.com/repos/sul-dlss/exhibits/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/exhibits/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/exhibits/tags","blobs_url":"https://api.github.com/repos/sul-dlss/exhibits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/exhibits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/exhibits/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/exhibits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/exhibits/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/exhibits/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/exhibits/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/exhibits/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/exhibits/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/exhibits/subscription","commits_url":"https://api.github.com/repos/sul-dlss/exhibits/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/exhibits/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/exhibits/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/exhibits/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/exhibits/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/exhibits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/exhibits/merges","archive_url":"https://api.github.com/repos/sul-dlss/exhibits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/exhibits/downloads","issues_url":"https://api.github.com/repos/sul-dlss/exhibits/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/exhibits/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/exhibits/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/exhibits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/exhibits/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/exhibits/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/exhibits/deployments","created_at":"2014-04-03T16:48:30Z","updated_at":"2016-01-13T19:47:12Z","pushed_at":"2016-07-12T01:06:23Z","git_url":"git://github.com/sul-dlss/exhibits.git","ssh_url":"git@github.com:sul-dlss/exhibits.git","clone_url":"https://github.com/sul-dlss/exhibits.git","svn_url":"https://github.com/sul-dlss/exhibits","homepage":"https://exhibits.stanford.edu","size":552,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":33,"forks":2,"open_issues":33,"watchers":0,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"3c8d459482028154a7ad60473747b34c5b2eea18","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":18410674,"name":"exhibits","full_name":"sul-dlss/exhibits","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/exhibits","description":"Stanford University Libraries online exhibits showcase","fork":false,"url":"https://api.github.com/repos/sul-dlss/exhibits","forks_url":"https://api.github.com/repos/sul-dlss/exhibits/forks","keys_url":"https://api.github.com/repos/sul-dlss/exhibits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/exhibits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/exhibits/teams","hooks_url":"https://api.github.com/repos/sul-dlss/exhibits/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/exhibits/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/exhibits/events","assignees_url":"https://api.github.com/repos/sul-dlss/exhibits/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/exhibits/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/exhibits/tags","blobs_url":"https://api.github.com/repos/sul-dlss/exhibits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/exhibits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/exhibits/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/exhibits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/exhibits/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/exhibits/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/exhibits/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/exhibits/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/exhibits/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/exhibits/subscription","commits_url":"https://api.github.com/repos/sul-dlss/exhibits/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/exhibits/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/exhibits/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/exhibits/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/exhibits/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/exhibits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/exhibits/merges","archive_url":"https://api.github.com/repos/sul-dlss/exhibits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/exhibits/downloads","issues_url":"https://api.github.com/repos/sul-dlss/exhibits/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/exhibits/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/exhibits/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/exhibits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/exhibits/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/exhibits/releases{/id}","deployments_url":"https://api.github.com/repos/sul-dlss/exhibits/deployments","created_at":"2014-04-03T16:48:30Z","updated_at":"2016-01-13T19:47:12Z","pushed_at":"2016-07-12T01:06:23Z","git_url":"git://github.com/sul-dlss/exhibits.git","ssh_url":"git@github.com:sul-dlss/exhibits.git","clone_url":"https://github.com/sul-dlss/exhibits.git","svn_url":"https://github.com/sul-dlss/exhibits","homepage":"https://exhibits.stanford.edu","size":552,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":33,"forks":2,"open_issues":33,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239"},"html":{"href":"https://github.com/sul-dlss/exhibits/pull/239"},"issue":{"href":"https://api.github.com/repos/sul-dlss/exhibits/issues/239"},"comments":{"href":"https://api.github.com/repos/sul-dlss/exhibits/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/exhibits/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/exhibits/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/exhibits/statuses/56e319eca7c13b69e31198c7244f0620dba3cb82"}}}}
{"actor":{"display_login":"houndci-bot"}}