{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/57848510","id":57848510,"diff_hunk":"@@ -367,14 +353,14 @@ var FontFaceObject = (function FontFaceObjectClosure() {\n         return null;\n       }\n \n-      if (PDFJS.disableFontFace) {\n+      if (this.options.disableFontFace) {\n         this.disableFontFace = true;\n         return null;\n       }\n \n       var nativeFontFace = new FontFace(this.loadedName, this.data, {});\n \n-      if (PDFJS.pdfBug && 'FontInspector' in globalScope &&\n+      if (getDefaultSetting('pdfBug') && 'FontInspector' in globalScope &&","path":"src/display/font_loader.js","position":111,"original_position":111,"commit_id":"fbafbc0b7d4c78cc0f2edc7c65b62114fbd5a52e","original_commit_id":"fbafbc0b7d4c78cc0f2edc7c65b62114fbd5a52e","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"body":"Since you're passing in both `isEvalSupported` and `disableFontFace` as options, are there any reason not do that with `pdfBug` as well?","created_at":"2016-03-30T07:50:57Z","updated_at":"2016-03-30T07:50:57Z","html_url":"https://github.com/mozilla/pdf.js/pull/7126#discussion_r57848510","pull_request_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126","_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments/57848510"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/7126#discussion_r57848510"},"pull_request":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126","id":64384740,"html_url":"https://github.com/mozilla/pdf.js/pull/7126","diff_url":"https://github.com/mozilla/pdf.js/pull/7126.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/7126.patch","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7126","number":7126,"state":"open","locked":false,"title":"Move all PDFJS display/ usages into global.js file.","user":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"body":"The dom_utils.js may use global PDFJS to pull values (if the object exists), see getDefaultSetting.\r\n\r\nAlso, exposed more functions/classes for generic viewer and examples. Also changed PDFJS object access from these.\r\n\r\n","created_at":"2016-03-28T22:14:08Z","updated_at":"2016-03-30T07:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b714d80411101462cea1736266adaf88660dad1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126/commits","review_comments_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126/comments","review_comment_url":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7126/comments","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/fbafbc0b7d4c78cc0f2edc7c65b62114fbd5a52e","head":{"label":"yurydelendik:rm-pdfjs-display","ref":"rm-pdfjs-display","sha":"fbafbc0b7d4c78cc0f2edc7c65b62114fbd5a52e","user":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"repo":{"id":3910637,"name":"pdf.js","full_name":"yurydelendik/pdf.js","owner":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yurydelendik/pdf.js","description":"PDF Reader in JavaScript","fork":true,"url":"https://api.github.com/repos/yurydelendik/pdf.js","forks_url":"https://api.github.com/repos/yurydelendik/pdf.js/forks","keys_url":"https://api.github.com/repos/yurydelendik/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yurydelendik/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yurydelendik/pdf.js/teams","hooks_url":"https://api.github.com/repos/yurydelendik/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/yurydelendik/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/yurydelendik/pdf.js/events","assignees_url":"https://api.github.com/repos/yurydelendik/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/yurydelendik/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/yurydelendik/pdf.js/tags","blobs_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yurydelendik/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/yurydelendik/pdf.js/languages","stargazers_url":"https://api.github.com/repos/yurydelendik/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/yurydelendik/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/yurydelendik/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/yurydelendik/pdf.js/subscription","commits_url":"https://api.github.com/repos/yurydelendik/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/yurydelendik/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/yurydelendik/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/yurydelendik/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/yurydelendik/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/yurydelendik/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yurydelendik/pdf.js/merges","archive_url":"https://api.github.com/repos/yurydelendik/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yurydelendik/pdf.js/downloads","issues_url":"https://api.github.com/repos/yurydelendik/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/yurydelendik/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/yurydelendik/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/yurydelendik/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yurydelendik/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/yurydelendik/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/yurydelendik/pdf.js/deployments","created_at":"2012-04-02T19:26:16Z","updated_at":"2015-07-02T19:39:39Z","pushed_at":"2016-03-29T21:58:56Z","git_url":"git://github.com/yurydelendik/pdf.js.git","ssh_url":"git@github.com:yurydelendik/pdf.js.git","clone_url":"https://github.com/yurydelendik/pdf.js.git","svn_url":"https://github.com/yurydelendik/pdf.js","homepage":"","size":58214,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"6d2b195857092ade9ad97a61dfd5b347384c76b8","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1663468,"name":"pdf.js","full_name":"mozilla/pdf.js","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/pdf.js","description":"PDF Reader in JavaScript","fork":false,"url":"https://api.github.com/repos/mozilla/pdf.js","forks_url":"https://api.github.com/repos/mozilla/pdf.js/forks","keys_url":"https://api.github.com/repos/mozilla/pdf.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/pdf.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/pdf.js/teams","hooks_url":"https://api.github.com/repos/mozilla/pdf.js/hooks","issue_events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/pdf.js/events","assignees_url":"https://api.github.com/repos/mozilla/pdf.js/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/pdf.js/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/pdf.js/tags","blobs_url":"https://api.github.com/repos/mozilla/pdf.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/pdf.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/pdf.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/pdf.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/pdf.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/pdf.js/languages","stargazers_url":"https://api.github.com/repos/mozilla/pdf.js/stargazers","contributors_url":"https://api.github.com/repos/mozilla/pdf.js/contributors","subscribers_url":"https://api.github.com/repos/mozilla/pdf.js/subscribers","subscription_url":"https://api.github.com/repos/mozilla/pdf.js/subscription","commits_url":"https://api.github.com/repos/mozilla/pdf.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/pdf.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/pdf.js/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/pdf.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/pdf.js/merges","archive_url":"https://api.github.com/repos/mozilla/pdf.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/pdf.js/downloads","issues_url":"https://api.github.com/repos/mozilla/pdf.js/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/pdf.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/pdf.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/pdf.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/pdf.js/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/pdf.js/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/pdf.js/deployments","created_at":"2011-04-26T06:32:03Z","updated_at":"2016-03-30T07:37:41Z","pushed_at":"2016-03-29T22:26:07Z","git_url":"git://github.com/mozilla/pdf.js.git","ssh_url":"git@github.com:mozilla/pdf.js.git","clone_url":"https://github.com/mozilla/pdf.js.git","svn_url":"https://github.com/mozilla/pdf.js","homepage":"","size":111119,"stargazers_count":13995,"watchers_count":13995,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3301,"mirror_url":null,"open_issues_count":585,"forks":3301,"open_issues":585,"watchers":13995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126"},"html":{"href":"https://github.com/mozilla/pdf.js/pull/7126"},"issue":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/7126"},"comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/issues/7126/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/pdf.js/pulls/7126/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/pdf.js/statuses/fbafbc0b7d4c78cc0f2edc7c65b62114fbd5a52e"}}}}