{"action":"created","issue":{"url":"https://api.github.com/repos/reactjs/react-tutorial/issues/139","repository_url":"https://api.github.com/repos/reactjs/react-tutorial","labels_url":"https://api.github.com/repos/reactjs/react-tutorial/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/reactjs/react-tutorial/issues/139/comments","events_url":"https://api.github.com/repos/reactjs/react-tutorial/issues/139/events","html_url":"https://github.com/reactjs/react-tutorial/issues/139","id":158452872,"number":139,"title":"Stored XSS in Mark Down","user":{"login":"matt-","id":453602,"avatar_url":"https://avatars.githubusercontent.com/u/453602?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-","html_url":"https://github.com/matt-","followers_url":"https://api.github.com/users/matt-/followers","following_url":"https://api.github.com/users/matt-/following{/other_user}","gists_url":"https://api.github.com/users/matt-/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-/subscriptions","organizations_url":"https://api.github.com/users/matt-/orgs","repos_url":"https://api.github.com/users/matt-/repos","events_url":"https://api.github.com/users/matt-/events{/privacy}","received_events_url":"https://api.github.com/users/matt-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-06-03T20:55:17Z","updated_at":"2016-06-03T21:12:42Z","closed_at":null,"body":"The markdown library (marked) used in this demo does not properly handle HTML entities (even with the sanitize option set to true). This leads to a stored XSS in this demo. \r\n\r\nThe marked project also appears to be abandoned. I suggest using something else in the demo. I know this is not intended to be production code, but people will follow this as an example. You can also see this in action on the main https://facebook.github.io/react/ page under \"A Component Using External Plugins\" as a \"self xss\"\r\n\r\n### POC: \r\nRun the project and submit a comment with the following markdown:  \r\n```\r\n[XSS](javascript&#58document;alert&#40;1&#41;)\r\n```\r\n\r\n### References: \r\nThe pull request I opened to them (a long time ago):\r\nhttps://github.com/chjj/marked/pull/592\r\n\r\nA full writeup on the actual issue: \r\nhttps://snyk.io/blog/marked-xss-vulnerability/\r\n\r\nThe Node Security Advisory:\r\nhttps://nodesecurity.io/advisories/101\r\n\r\nAs well as RetireJS: \r\nhttp://retirejs.github.io/retire.js/"},"comment":{"url":"https://api.github.com/repos/reactjs/react-tutorial/issues/comments/223695842","html_url":"https://github.com/reactjs/react-tutorial/issues/139#issuecomment-223695842","issue_url":"https://api.github.com/repos/reactjs/react-tutorial/issues/139","id":223695842,"user":{"login":"matt-","id":453602,"avatar_url":"https://avatars.githubusercontent.com/u/453602?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-","html_url":"https://github.com/matt-","followers_url":"https://api.github.com/users/matt-/followers","following_url":"https://api.github.com/users/matt-/following{/other_user}","gists_url":"https://api.github.com/users/matt-/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-/subscriptions","organizations_url":"https://api.github.com/users/matt-/orgs","repos_url":"https://api.github.com/users/matt-/repos","events_url":"https://api.github.com/users/matt-/events{/privacy}","received_events_url":"https://api.github.com/users/matt-/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T21:12:42Z","updated_at":"2016-06-03T21:12:42Z","body":"Do you think I should also add a ticket for the https://github.com/facebook/react gh-page branch? "}}
{"actor":{"display_login":"matt-"}}