{"action":"opened","issue":{"url":"https://api.github.com/repos/nextcloud/server/issues/2197","repository_url":"https://api.github.com/repos/nextcloud/server","labels_url":"https://api.github.com/repos/nextcloud/server/issues/2197/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/2197/comments","events_url":"https://api.github.com/repos/nextcloud/server/issues/2197/events","html_url":"https://github.com/nextcloud/server/issues/2197","id":190287490,"number":2197,"title":"Comments within a federated share should be made visible to all federated parties","user":{"login":"didierm","id":989004,"avatar_url":"https://avatars.githubusercontent.com/u/989004?v=3","gravatar_id":"","url":"https://api.github.com/users/didierm","html_url":"https://github.com/didierm","followers_url":"https://api.github.com/users/didierm/followers","following_url":"https://api.github.com/users/didierm/following{/other_user}","gists_url":"https://api.github.com/users/didierm/gists{/gist_id}","starred_url":"https://api.github.com/users/didierm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didierm/subscriptions","organizations_url":"https://api.github.com/users/didierm/orgs","repos_url":"https://api.github.com/users/didierm/repos","events_url":"https://api.github.com/users/didierm/events{/privacy}","received_events_url":"https://api.github.com/users/didierm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-18T10:38:48Z","updated_at":"2016-11-18T10:38:48Z","closed_at":null,"body":"In the context of a (federated) share, we consider comments as a valuable means of communication and hence an essential part of the collaboration effort.\r\n\r\nWhile we appreciate use cases where tags are being contained to the server where they are initially created and stored, we deem it appropriate to make comments within a federated share available to all parties having access that share.\r\n\r\n### Steps to reproduce\r\n1. For collaboration purposes, UserA federates a share (shareX) on serverA to UserB on ServerB ;\r\n2. UserA creates comments in the shareX realm ;\r\n3. UserB creates comments in the shareX realm. \r\n### Expected behaviour\r\nParties with access to shareX (i.e. both UserA and UserB) should see all comments in this share's realm.\r\n\r\n### Actual behaviour\r\nUserA only sees his/her own shareX comments (stored on ServerA), UserB only sees his/her own shareX comments (stored on ServerB).\r\n\r\n### Server configuration\r\n**Nextcloud version: 10.0.1**\r\n\r\n\r\n### Workflow proposal : \r\n\r\n- Add a **'public/private'** boolean field to table oc_comments (defaulting to _private_) ;\r\n- When a share is federated, disclose a **[public]** checkbox next to the **[Post]** button in the UI, allowing (new) comments to be made public ;\r\n\r\n- For performance and privacy reasons, comments which are tagged _public_ are stored in or transferred to table oc_comments on the server hosting the share, _private_ comments are stored on or transferred to the user's server;\r\n\r\n- Reversal from _public_ to _private_ status and vice versa can only be executed by the comment owner [oc_comments.actor_id].\r\n\r\n"}}
{"actor":{"display_login":"didierm"}}