{"action":"created","comment":{"url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments/59030400","id":59030400,"diff_hunk":"@@ -303,51 +316,116 @@ an analysis run. The value of `invocationInfo` would have to be combined with in\n source to allow the run to be repeated.\n ~\n \n-### `analysisTargets` property { #runInfo-analysisTargets }\n+### `fileInfo` property { #runInfo-fileInfo }\n \n-A `runInfo` object may contain a property named `analysisTargets` whose value is an array,\n-each of whose elements is a `fileReference` object (&sect;[#fileReference])\n-representing the location of a single analysis target scanned during the run.\n-This array shall contain one entry for each analysis target that was scanned,\n-even if the analysis targets were not individually specified on the command line.\n+A `runInfo` object should contain a property named `fileInfo` whose value is a JSON object,\n+each of whose properties represents a file that was scanned in the course of the run.\n \n-~ IsoNumberedNote { @IsoNumberedNote=1 }\n-The command line with which the tool was invoked might specify its input files\n-by means of a wild card such as *.cc, or it might specify them implicitly,\n-for example, by scanning the files in the current directory.\n+The `fileInfo` object should contain properties representing at least those files in which results were detected,\n+but it may contain properties representing all scanned files (whether or not results were detected in those files),\n+or for any subset of those files.\n+\n+~ IsoNumberedNote { @IsoNumberedNote=1}\n+`fileReference` objects contain information that is useful for viewers.\n+Viewers will be able to provide the most information to users if the `fileInfo`\n+property is present and contains information for every file in which results were detected.\n ~\n \n-The `analysisTargets` array shall be empty if no analysis targets were scanned in the course of the run.\n+Each property name in the `fileInfo` object shall be the URI of a scanned file.\n+No two of these property names shall be equivalent as defined in &sect;[#uriProperties].\n \n-~ IsoNumberedNote\n-This could happen if the command line specified a wildcard such as *.cc for the input files,\n-and no files matched the wildcard.\n-~\n+Each property value in the `fileInfo` object shall be an array of `fileReference` objects (&sect;[#fileReference])\n+which contain information about the file identified by the URI in the property name.\n \n-~ IsoExample\n+If the scanned file is not nested within another file, then the array shall consist of a single\n+element, and the property name shall be the absolute URI of the scanned file.\n+\n+~ IsoNumberedExample { @IsoNumberedExample=1}\n \n ```\n-[\n-    {\n-        \"uri\": \"file:///C:/Code/a.cc\",\n-        \"hashes\": [\n+runInfo: {\n+    fileInfo: {\n+        \"file:///C:/Code/main.cc\": [\n             {\n-                \"value\": \"b13ce2678a8807ba0765ab94a0ecd394f869bc81\",\n-                \"algorithm\": \"SHA-256\"\n+                \"uri\": \"file:///C:/Code/main.cc\"","path":"document/CoreFormat.mdk","position":null,"original_position":93,"commit_id":"a93cd5aa8f79e2f4812f369d59953245a84e66b7","original_commit_id":"b6b169586b58b7c5dd01a8aba1a90a5c2f0d1fc0","user":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2016-04-08T14:13:13Z","updated_at":"2016-04-08T14:13:13Z","html_url":"https://github.com/sarif-standard/sarif-spec/pull/139#discussion_r59030400","pull_request_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments/59030400"},"html":{"href":"https://github.com/sarif-standard/sarif-spec/pull/139#discussion_r59030400"},"pull_request":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139","id":65699570,"html_url":"https://github.com/sarif-standard/sarif-spec/pull/139","diff_url":"https://github.com/sarif-standard/sarif-spec/pull/139.diff","patch_url":"https://github.com/sarif-standard/sarif-spec/pull/139.patch","issue_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/139","number":139,"state":"open","locked":false,"title":"Fix #107: Deduplicate the nesting in physical locations","user":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"body":"@michaelcfanning ","created_at":"2016-04-07T21:04:42Z","updated_at":"2016-04-08T14:13:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f91dbbc4def5d7acdbd96a90c89ed16c967c7f7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139/commits","review_comments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139/comments","review_comment_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/139/comments","statuses_url":"https://api.github.com/repos/sarif-standard/sarif-spec/statuses/a93cd5aa8f79e2f4812f369d59953245a84e66b7","head":{"label":"lgolding:issue-107","ref":"issue-107","sha":"a93cd5aa8f79e2f4812f369d59953245a84e66b7","user":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"repo":{"id":52565043,"name":"sarif-spec","full_name":"lgolding/sarif-spec","owner":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lgolding/sarif-spec","description":"The specification document for the Static Analysis Results Interchange Format (SARIF)","fork":true,"url":"https://api.github.com/repos/lgolding/sarif-spec","forks_url":"https://api.github.com/repos/lgolding/sarif-spec/forks","keys_url":"https://api.github.com/repos/lgolding/sarif-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lgolding/sarif-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lgolding/sarif-spec/teams","hooks_url":"https://api.github.com/repos/lgolding/sarif-spec/hooks","issue_events_url":"https://api.github.com/repos/lgolding/sarif-spec/issues/events{/number}","events_url":"https://api.github.com/repos/lgolding/sarif-spec/events","assignees_url":"https://api.github.com/repos/lgolding/sarif-spec/assignees{/user}","branches_url":"https://api.github.com/repos/lgolding/sarif-spec/branches{/branch}","tags_url":"https://api.github.com/repos/lgolding/sarif-spec/tags","blobs_url":"https://api.github.com/repos/lgolding/sarif-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lgolding/sarif-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lgolding/sarif-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/lgolding/sarif-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lgolding/sarif-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/lgolding/sarif-spec/languages","stargazers_url":"https://api.github.com/repos/lgolding/sarif-spec/stargazers","contributors_url":"https://api.github.com/repos/lgolding/sarif-spec/contributors","subscribers_url":"https://api.github.com/repos/lgolding/sarif-spec/subscribers","subscription_url":"https://api.github.com/repos/lgolding/sarif-spec/subscription","commits_url":"https://api.github.com/repos/lgolding/sarif-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/lgolding/sarif-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/lgolding/sarif-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/lgolding/sarif-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/lgolding/sarif-spec/contents/{+path}","compare_url":"https://api.github.com/repos/lgolding/sarif-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lgolding/sarif-spec/merges","archive_url":"https://api.github.com/repos/lgolding/sarif-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lgolding/sarif-spec/downloads","issues_url":"https://api.github.com/repos/lgolding/sarif-spec/issues{/number}","pulls_url":"https://api.github.com/repos/lgolding/sarif-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/lgolding/sarif-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/lgolding/sarif-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lgolding/sarif-spec/labels{/name}","releases_url":"https://api.github.com/repos/lgolding/sarif-spec/releases{/id}","deployments_url":"https://api.github.com/repos/lgolding/sarif-spec/deployments","created_at":"2016-02-25T23:44:18Z","updated_at":"2016-02-25T23:44:19Z","pushed_at":"2016-04-08T14:12:48Z","git_url":"git://github.com/lgolding/sarif-spec.git","ssh_url":"git@github.com:lgolding/sarif-spec.git","clone_url":"https://github.com/lgolding/sarif-spec.git","svn_url":"https://github.com/lgolding/sarif-spec","homepage":null,"size":1049,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sarif-standard:master","ref":"master","sha":"e95b256b9ed668f5f6d7a47347c681534355c37a","user":{"login":"sarif-standard","id":13755421,"avatar_url":"https://avatars.githubusercontent.com/u/13755421?v=3","gravatar_id":"","url":"https://api.github.com/users/sarif-standard","html_url":"https://github.com/sarif-standard","followers_url":"https://api.github.com/users/sarif-standard/followers","following_url":"https://api.github.com/users/sarif-standard/following{/other_user}","gists_url":"https://api.github.com/users/sarif-standard/gists{/gist_id}","starred_url":"https://api.github.com/users/sarif-standard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarif-standard/subscriptions","organizations_url":"https://api.github.com/users/sarif-standard/orgs","repos_url":"https://api.github.com/users/sarif-standard/repos","events_url":"https://api.github.com/users/sarif-standard/events{/privacy}","received_events_url":"https://api.github.com/users/sarif-standard/received_events","type":"Organization","site_admin":false},"repo":{"id":40567795,"name":"sarif-spec","full_name":"sarif-standard/sarif-spec","owner":{"login":"sarif-standard","id":13755421,"avatar_url":"https://avatars.githubusercontent.com/u/13755421?v=3","gravatar_id":"","url":"https://api.github.com/users/sarif-standard","html_url":"https://github.com/sarif-standard","followers_url":"https://api.github.com/users/sarif-standard/followers","following_url":"https://api.github.com/users/sarif-standard/following{/other_user}","gists_url":"https://api.github.com/users/sarif-standard/gists{/gist_id}","starred_url":"https://api.github.com/users/sarif-standard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarif-standard/subscriptions","organizations_url":"https://api.github.com/users/sarif-standard/orgs","repos_url":"https://api.github.com/users/sarif-standard/repos","events_url":"https://api.github.com/users/sarif-standard/events{/privacy}","received_events_url":"https://api.github.com/users/sarif-standard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sarif-standard/sarif-spec","description":"The specification document for the Static Analysis Results Interchange Format (SARIF)","fork":false,"url":"https://api.github.com/repos/sarif-standard/sarif-spec","forks_url":"https://api.github.com/repos/sarif-standard/sarif-spec/forks","keys_url":"https://api.github.com/repos/sarif-standard/sarif-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarif-standard/sarif-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarif-standard/sarif-spec/teams","hooks_url":"https://api.github.com/repos/sarif-standard/sarif-spec/hooks","issue_events_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/events{/number}","events_url":"https://api.github.com/repos/sarif-standard/sarif-spec/events","assignees_url":"https://api.github.com/repos/sarif-standard/sarif-spec/assignees{/user}","branches_url":"https://api.github.com/repos/sarif-standard/sarif-spec/branches{/branch}","tags_url":"https://api.github.com/repos/sarif-standard/sarif-spec/tags","blobs_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarif-standard/sarif-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/sarif-standard/sarif-spec/languages","stargazers_url":"https://api.github.com/repos/sarif-standard/sarif-spec/stargazers","contributors_url":"https://api.github.com/repos/sarif-standard/sarif-spec/contributors","subscribers_url":"https://api.github.com/repos/sarif-standard/sarif-spec/subscribers","subscription_url":"https://api.github.com/repos/sarif-standard/sarif-spec/subscription","commits_url":"https://api.github.com/repos/sarif-standard/sarif-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarif-standard/sarif-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarif-standard/sarif-spec/contents/{+path}","compare_url":"https://api.github.com/repos/sarif-standard/sarif-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarif-standard/sarif-spec/merges","archive_url":"https://api.github.com/repos/sarif-standard/sarif-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarif-standard/sarif-spec/downloads","issues_url":"https://api.github.com/repos/sarif-standard/sarif-spec/issues{/number}","pulls_url":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/sarif-standard/sarif-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/sarif-standard/sarif-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarif-standard/sarif-spec/labels{/name}","releases_url":"https://api.github.com/repos/sarif-standard/sarif-spec/releases{/id}","deployments_url":"https://api.github.com/repos/sarif-standard/sarif-spec/deployments","created_at":"2015-08-11T22:14:51Z","updated_at":"2016-04-05T13:55:46Z","pushed_at":"2016-04-08T14:12:49Z","git_url":"git://github.com/sarif-standard/sarif-spec.git","ssh_url":"git@github.com:sarif-standard/sarif-spec.git","clone_url":"https://github.com/sarif-standard/sarif-spec.git","svn_url":"https://github.com/sarif-standard/sarif-spec","homepage":null,"size":1335,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":36,"forks":2,"open_issues":36,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139"},"html":{"href":"https://github.com/sarif-standard/sarif-spec/pull/139"},"issue":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/139"},"comments":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/sarif-standard/sarif-spec/statuses/a93cd5aa8f79e2f4812f369d59953245a84e66b7"}}}}