{"action":"created","issue":{"url":"https://api.github.com/repos/steemit/steemit.com/issues/233","repository_url":"https://api.github.com/repos/steemit/steemit.com","labels_url":"https://api.github.com/repos/steemit/steemit.com/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/steemit/steemit.com/issues/233/comments","events_url":"https://api.github.com/repos/steemit/steemit.com/issues/233/events","html_url":"https://github.com/steemit/steemit.com/issues/233","id":176221676,"number":233,"title":"Add i18n support","user":{"login":"f3rnando","id":290850,"avatar_url":"https://avatars.githubusercontent.com/u/290850?v=3","gravatar_id":"","url":"https://api.github.com/users/f3rnando","html_url":"https://github.com/f3rnando","followers_url":"https://api.github.com/users/f3rnando/followers","following_url":"https://api.github.com/users/f3rnando/following{/other_user}","gists_url":"https://api.github.com/users/f3rnando/gists{/gist_id}","starred_url":"https://api.github.com/users/f3rnando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f3rnando/subscriptions","organizations_url":"https://api.github.com/users/f3rnando/orgs","repos_url":"https://api.github.com/users/f3rnando/repos","events_url":"https://api.github.com/users/f3rnando/events{/privacy}","received_events_url":"https://api.github.com/users/f3rnando/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-11T05:25:55Z","updated_at":"2016-09-22T23:51:08Z","closed_at":null,"body":"I'm creating this issue in order to begin discussions on i18n support for steemit.com given that Im working into a clean, updated fork of this repo to include this feature.\r\n\r\nCore points, questions and insights:\r\n\r\n1. Adding i18n support is quite easy, the biggest efforts reside on translation and on keeping translation files updated.\r\n2. I will PR as soon as spanish translations are done, in order to make merging relevant and useful right away.\r\n3. The modules/plugins that I chose are: [react-intl](https://github.com/yahoo/react-intl) and [babel-plugin-react-intl](https://github.com/yahoo/babel-plugin-react-intl). Are these fine? if any other should be considered, please propose it ASAP.\r\n4. The current i18n branch can be found here: [f3rnando/steemit.com/tree/i18n](https://github.com/f3rnando/steemit.com/tree/i18n) \r\n5. The current status compare of steemit.com:master > f3rnando:i18n [here](https://github.com/steemit/steemit.com/compare/master...f3rnando:i18n?expand=1)\r\n6. Language selection should be automatic based on user locale\r\n7. A chinese speaking user might access from a browser asking en-US, and he might want to override that language selection. I will not develop this UI feature, I believe it is subjective and the steemit team will take over this task.\r\n8. I may give access to this repo to whoever wishes to collaborate and/or audit it.\r\n\r\nPlease reply referring to the list number, if any.\r\n\r\nUpdates coming soon."},"comment":{"url":"https://api.github.com/repos/steemit/steemit.com/issues/comments/249060923","html_url":"https://github.com/steemit/steemit.com/issues/233#issuecomment-249060923","issue_url":"https://api.github.com/repos/steemit/steemit.com/issues/233","id":249060923,"user":{"login":"f3rnando","id":290850,"avatar_url":"https://avatars.githubusercontent.com/u/290850?v=3","gravatar_id":"","url":"https://api.github.com/users/f3rnando","html_url":"https://github.com/f3rnando","followers_url":"https://api.github.com/users/f3rnando/followers","following_url":"https://api.github.com/users/f3rnando/following{/other_user}","gists_url":"https://api.github.com/users/f3rnando/gists{/gist_id}","starred_url":"https://api.github.com/users/f3rnando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f3rnando/subscriptions","organizations_url":"https://api.github.com/users/f3rnando/orgs","repos_url":"https://api.github.com/users/f3rnando/repos","events_url":"https://api.github.com/users/f3rnando/events{/privacy}","received_events_url":"https://api.github.com/users/f3rnando/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T23:51:08Z","updated_at":"2016-09-22T23:51:08Z","body":"@valzav @jcalfee @roadscape @mynameiskeo @skzap  we were discussing in steemit.chat (steemit-i18n-dev channel) a few points to get this done:\r\n\r\n9. Should we wrap strings before PR or would it be better to PR just the i18n support files? If we take the task to wrap all strings, it could get to be a merge nightmare for you (steemit devs)\r\n10. What naming should be choosen? I personally like __(), others prefer translate(), none or a few t().\r\n11. given #2 what about html and plurals translate? (eg: __p() __HTML, translateHTML(), etc)\r\n@Undeadlol1 is already using translate(), I believe that this might be the logic way to go.\r\n12. Should I rebase previous to PR? or merge? or pull --rebase? Please indicate the best approach.\r\n\r\n3. Update: Finally, **babel-plugin-react-intl** wasnt used.\r\n\r\nThanks in advance.\r\n\r\n\r\n"}}
{"actor":{"display_login":"f3rnando"}}