{"action":"opened","number":311,"pull_request":{"url":"https://api.github.com/repos/astropy/ccdproc/pulls/311","id":59806704,"html_url":"https://github.com/astropy/ccdproc/pull/311","diff_url":"https://github.com/astropy/ccdproc/pull/311.diff","patch_url":"https://github.com/astropy/ccdproc/pull/311.patch","issue_url":"https://api.github.com/repos/astropy/ccdproc/issues/311","number":311,"state":"open","locked":false,"title":"Scale uncertainty with the number of combined pixel during combination.","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"body":"Fixes #309 \r\n\r\nPlease review this carefully.\r\n\r\nSome still open issues:\r\n- Since you did not pass ``ddof`` to ``np.ma.std`` I didn't correct for finite populations either and just divided by ``np.sqrt(valid_pixel)``. This might not be exactly correct but I'm not too sure about statistics. The downside with such an finite population correction is also that the number of valid pixel could be 0 and then subtracting 1 and taking the square root ... not good.\r\n- both combiners ignore scaling and weighting for the uncertainty computation.\r\n- median combine ignores the masked values (probably because ``median_absolute_deviation`` cannot handle these. Therefore I corrected just with the whole number of pixel because these are used for uncertainty computation. It's inconsistent but I don't have time right now to validate what needs to be done to make that take masked arrays.","created_at":"2016-02-18T14:34:30Z","updated_at":"2016-02-18T14:34:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/astropy/ccdproc/pulls/311/commits","review_comments_url":"https://api.github.com/repos/astropy/ccdproc/pulls/311/comments","review_comment_url":"https://api.github.com/repos/astropy/ccdproc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/ccdproc/issues/311/comments","statuses_url":"https://api.github.com/repos/astropy/ccdproc/statuses/796218ecb41437ad5420f226870e4e374677a324","head":{"label":"MSeifert04:combiner_uncertainty_scaling","ref":"combiner_uncertainty_scaling","sha":"796218ecb41437ad5420f226870e4e374677a324","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"repo":{"id":44630463,"name":"ccdproc","full_name":"MSeifert04/ccdproc","owner":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars.githubusercontent.com/u/14200878?v=3","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MSeifert04/ccdproc","description":"Astropy affiliated package for reducing optical/IR CCD data","fork":true,"url":"https://api.github.com/repos/MSeifert04/ccdproc","forks_url":"https://api.github.com/repos/MSeifert04/ccdproc/forks","keys_url":"https://api.github.com/repos/MSeifert04/ccdproc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSeifert04/ccdproc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSeifert04/ccdproc/teams","hooks_url":"https://api.github.com/repos/MSeifert04/ccdproc/hooks","issue_events_url":"https://api.github.com/repos/MSeifert04/ccdproc/issues/events{/number}","events_url":"https://api.github.com/repos/MSeifert04/ccdproc/events","assignees_url":"https://api.github.com/repos/MSeifert04/ccdproc/assignees{/user}","branches_url":"https://api.github.com/repos/MSeifert04/ccdproc/branches{/branch}","tags_url":"https://api.github.com/repos/MSeifert04/ccdproc/tags","blobs_url":"https://api.github.com/repos/MSeifert04/ccdproc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSeifert04/ccdproc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSeifert04/ccdproc/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSeifert04/ccdproc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSeifert04/ccdproc/statuses/{sha}","languages_url":"https://api.github.com/repos/MSeifert04/ccdproc/languages","stargazers_url":"https://api.github.com/repos/MSeifert04/ccdproc/stargazers","contributors_url":"https://api.github.com/repos/MSeifert04/ccdproc/contributors","subscribers_url":"https://api.github.com/repos/MSeifert04/ccdproc/subscribers","subscription_url":"https://api.github.com/repos/MSeifert04/ccdproc/subscription","commits_url":"https://api.github.com/repos/MSeifert04/ccdproc/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSeifert04/ccdproc/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSeifert04/ccdproc/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSeifert04/ccdproc/issues/comments{/number}","contents_url":"https://api.github.com/repos/MSeifert04/ccdproc/contents/{+path}","compare_url":"https://api.github.com/repos/MSeifert04/ccdproc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSeifert04/ccdproc/merges","archive_url":"https://api.github.com/repos/MSeifert04/ccdproc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSeifert04/ccdproc/downloads","issues_url":"https://api.github.com/repos/MSeifert04/ccdproc/issues{/number}","pulls_url":"https://api.github.com/repos/MSeifert04/ccdproc/pulls{/number}","milestones_url":"https://api.github.com/repos/MSeifert04/ccdproc/milestones{/number}","notifications_url":"https://api.github.com/repos/MSeifert04/ccdproc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSeifert04/ccdproc/labels{/name}","releases_url":"https://api.github.com/repos/MSeifert04/ccdproc/releases{/id}","deployments_url":"https://api.github.com/repos/MSeifert04/ccdproc/deployments","created_at":"2015-10-20T19:37:44Z","updated_at":"2015-10-20T19:37:45Z","pushed_at":"2016-02-18T14:27:30Z","git_url":"git://github.com/MSeifert04/ccdproc.git","ssh_url":"git@github.com:MSeifert04/ccdproc.git","clone_url":"https://github.com/MSeifert04/ccdproc.git","svn_url":"https://github.com/MSeifert04/ccdproc","homepage":"ccdproc.readthedocs.org","size":966,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"f70ff928e07166346c76c99d2495727048af2d52","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":13384007,"name":"ccdproc","full_name":"astropy/ccdproc","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/ccdproc","description":"Astropy affiliated package for reducing optical/IR CCD data","fork":false,"url":"https://api.github.com/repos/astropy/ccdproc","forks_url":"https://api.github.com/repos/astropy/ccdproc/forks","keys_url":"https://api.github.com/repos/astropy/ccdproc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/ccdproc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/ccdproc/teams","hooks_url":"https://api.github.com/repos/astropy/ccdproc/hooks","issue_events_url":"https://api.github.com/repos/astropy/ccdproc/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/ccdproc/events","assignees_url":"https://api.github.com/repos/astropy/ccdproc/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/ccdproc/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/ccdproc/tags","blobs_url":"https://api.github.com/repos/astropy/ccdproc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/ccdproc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/ccdproc/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/ccdproc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/ccdproc/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/ccdproc/languages","stargazers_url":"https://api.github.com/repos/astropy/ccdproc/stargazers","contributors_url":"https://api.github.com/repos/astropy/ccdproc/contributors","subscribers_url":"https://api.github.com/repos/astropy/ccdproc/subscribers","subscription_url":"https://api.github.com/repos/astropy/ccdproc/subscription","commits_url":"https://api.github.com/repos/astropy/ccdproc/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/ccdproc/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/ccdproc/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/ccdproc/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/ccdproc/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/ccdproc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/ccdproc/merges","archive_url":"https://api.github.com/repos/astropy/ccdproc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/ccdproc/downloads","issues_url":"https://api.github.com/repos/astropy/ccdproc/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/ccdproc/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/ccdproc/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/ccdproc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/ccdproc/labels{/name}","releases_url":"https://api.github.com/repos/astropy/ccdproc/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/ccdproc/deployments","created_at":"2013-10-07T13:05:51Z","updated_at":"2016-02-17T11:51:56Z","pushed_at":"2016-02-17T17:13:16Z","git_url":"git://github.com/astropy/ccdproc.git","ssh_url":"git@github.com:astropy/ccdproc.git","clone_url":"https://github.com/astropy/ccdproc.git","svn_url":"https://github.com/astropy/ccdproc","homepage":"ccdproc.readthedocs.org","size":1013,"stargazers_count":23,"watchers_count":23,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":45,"forks":31,"open_issues":45,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/ccdproc/pulls/311"},"html":{"href":"https://github.com/astropy/ccdproc/pull/311"},"issue":{"href":"https://api.github.com/repos/astropy/ccdproc/issues/311"},"comments":{"href":"https://api.github.com/repos/astropy/ccdproc/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/ccdproc/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/ccdproc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/ccdproc/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/ccdproc/statuses/796218ecb41437ad5420f226870e4e374677a324"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":50,"deletions":7,"changed_files":3}}