{"action":"created","issue":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/294","repository_url":"https://api.github.com/repos/learningequality/kolibri","labels_url":"https://api.github.com/repos/learningequality/kolibri/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/294/comments","events_url":"https://api.github.com/repos/learningequality/kolibri/issues/294/events","html_url":"https://github.com/learningequality/kolibri/pull/294","id":166466978,"number":294,"title":"html attribute double-quotes","user":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars.githubusercontent.com/u/2367265?v=3","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-20T00:09:58Z","updated_at":"2016-07-20T01:05:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/294","html_url":"https://github.com/learningequality/kolibri/pull/294","diff_url":"https://github.com/learningequality/kolibri/pull/294.diff","patch_url":"https://github.com/learningequality/kolibri/pull/294.patch"},"body":"Almost all developers (myself being the main exception) have tended to use double-quotes for HTML attributes.\r\n\r\nThis PR migrates all single-quotes to double-quotes, and adds a linting rule to enforce that convention.\r\n\r\nThis also addresses @66eli77's concern about embedded javascript strings, allowing us to use the conventional single quotes for inline js strings, e.g.:\r\n\r\n```html\r\n   <a :href=\"'http://' + domain\">link</a>\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/comments/233811103","html_url":"https://github.com/learningequality/kolibri/pull/294#issuecomment-233811103","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/294","id":233811103,"user":{"login":"indirectlylit","id":2367265,"avatar_url":"https://avatars.githubusercontent.com/u/2367265?v=3","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T01:05:25Z","updated_at":"2016-07-20T01:05:25Z","body":"Merging this into mmvp makes me a little uncomfortable just because it touches so many files. I'd prefer holding off with this PR for a week or two until mmvp has truly stabilized?"}}
{"actor":{"display_login":"indirectlylit"}}