{"action":"created","issue":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1088","repository_url":"https://api.github.com/repos/cBioPortal/cbioportal","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1088/labels{/name}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1088/comments","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1088/events","html_url":"https://github.com/cBioPortal/cbioportal/issues/1088","id":150045010,"number":1088,"title":"DB settings confusing","user":{"login":"pieterlukasse","id":2900303,"avatar_url":"https://avatars.githubusercontent.com/u/2900303?v=3","gravatar_id":"","url":"https://api.github.com/users/pieterlukasse","html_url":"https://github.com/pieterlukasse","followers_url":"https://api.github.com/users/pieterlukasse/followers","following_url":"https://api.github.com/users/pieterlukasse/following{/other_user}","gists_url":"https://api.github.com/users/pieterlukasse/gists{/gist_id}","starred_url":"https://api.github.com/users/pieterlukasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieterlukasse/subscriptions","organizations_url":"https://api.github.com/users/pieterlukasse/orgs","repos_url":"https://api.github.com/users/pieterlukasse/repos","events_url":"https://api.github.com/users/pieterlukasse/events{/privacy}","received_events_url":"https://api.github.com/users/pieterlukasse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cBioPortal/cbioportal/labels/discussion","name":"discussion","color":"0052cc"},{"url":"https://api.github.com/repos/cBioPortal/cbioportal/labels/documentation","name":"documentation","color":"0052cc"},{"url":"https://api.github.com/repos/cBioPortal/cbioportal/labels/help%20wanted","name":"help wanted","color":"00bb00"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-21T11:24:23Z","updated_at":"2016-04-28T21:23:29Z","closed_at":null,"body":"The documentation in https://github.com/cBioPortal/cbioportal/wiki/portal.properties-Reference#database-settings is a bit confusing as it seems that some db properties are only used by the data loading scripts and not by the portal code (which takes config from spring?). "},"comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments/215566827","html_url":"https://github.com/cBioPortal/cbioportal/issues/1088#issuecomment-215566827","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1088","id":215566827,"user":{"login":"inodb","id":1334004,"avatar_url":"https://avatars.githubusercontent.com/u/1334004?v=3","gravatar_id":"","url":"https://api.github.com/users/inodb","html_url":"https://github.com/inodb","followers_url":"https://api.github.com/users/inodb/followers","following_url":"https://api.github.com/users/inodb/following{/other_user}","gists_url":"https://api.github.com/users/inodb/gists{/gist_id}","starred_url":"https://api.github.com/users/inodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inodb/subscriptions","organizations_url":"https://api.github.com/users/inodb/orgs","repos_url":"https://api.github.com/users/inodb/repos","events_url":"https://api.github.com/users/inodb/events{/privacy}","received_events_url":"https://api.github.com/users/inodb/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T21:23:29Z","updated_at":"2016-04-28T21:23:29Z","body":"@holtgrewe thanks for the 12 factor app principles link, that's super useful!\r\n\r\nI think it would be great to use an environment variable for the db. I checked with @ersinciftci and it seems that there's no current effort ongoing to change this.\r\n\r\nFor heroku I added a spring config variable to switch between jndi and dbcp at run time, see: https://github.com/cBioPortal/cbioportal/pull/605. I would assume something similar is possible for the database. The [heroku devcenter](https://devcenter.heroku.com/articles/connecting-to-relational-databases-on-heroku-with-java#using-the-database_url-in-spring-with-xml-configuration) solutions @holtgrewe pointed out look decent to me."}}