{"action":"created","issue":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1012","repository_url":"https://api.github.com/repos/Smoothieware/Smoothieware","labels_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1012/labels{/name}","comments_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1012/comments","events_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1012/events","html_url":"https://github.com/Smoothieware/Smoothieware/pull/1012","id":173810296,"number":1012,"title":"Fix preset position","user":{"login":"Zaaphod","id":3008560,"avatar_url":"https://avatars.githubusercontent.com/u/3008560?v=3","gravatar_id":"","url":"https://api.github.com/users/Zaaphod","html_url":"https://github.com/Zaaphod","followers_url":"https://api.github.com/users/Zaaphod/followers","following_url":"https://api.github.com/users/Zaaphod/following{/other_user}","gists_url":"https://api.github.com/users/Zaaphod/gists{/gist_id}","starred_url":"https://api.github.com/users/Zaaphod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zaaphod/subscriptions","organizations_url":"https://api.github.com/users/Zaaphod/orgs","repos_url":"https://api.github.com/users/Zaaphod/repos","events_url":"https://api.github.com/users/Zaaphod/events{/privacy}","received_events_url":"https://api.github.com/users/Zaaphod/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-29T16:05:50Z","updated_at":"2016-08-29T18:42:39Z","closed_at":"2016-08-29T18:42:39Z","pull_request":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/pulls/1012","html_url":"https://github.com/Smoothieware/Smoothieware/pull/1012","diff_url":"https://github.com/Smoothieware/Smoothieware/pull/1012.diff","patch_url":"https://github.com/Smoothieware/Smoothieware/pull/1012.patch"},"body":"This is to fix a bug when moving to preset position with G28.2 in normal mode or G28 in grbl mode.  The problem was that if you were in G20 (inch mode) and set a predefined position with G28.1, it saved it in mm, which in itself was no problem, however when moving to the predefined position with G28.2/G28 it was not forcing G21, so it was moving the saved distance in inches instead of mm, so it was going 25.4 times too far.  To make sure the same position is achieved whether in G20 or G21, the predefined position is still saved in mm as it was, however now it forces it out of inch mode if it was active so the move correctly positions. the G20/G21 mode is then restored to what it was before the command was issued.\r\n\r\nI also implemented two options, both of which I need on my cnc machines, so I thought I would share them.   \r\n\r\nFirst is move_to_park_after_home which is the same as move_to_origin_after_home but it moves to the predefined position instead of 0,0.   This is very useful for any machine homing off either a Xmax or Ymax switch because it is unlikely anyone homing off a positive limit switch would want to move all the way to 0,0 where the machine is now in the way of loading, while it would be very useful to automatically go to the park position.  \r\n\r\nThe second option is back_off_first.  This simply allows control over whether to do the backoff before or after move_to_origin_after_home or move_to_park_after_home.    This is only in effect if the machine is not delta and it defaults to false, so leaving it out makes it exactly the same as it was."},"comment":{"url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/comments/243215668","html_url":"https://github.com/Smoothieware/Smoothieware/pull/1012#issuecomment-243215668","issue_url":"https://api.github.com/repos/Smoothieware/Smoothieware/issues/1012","id":243215668,"user":{"login":"wolfmanjm","id":22263,"avatar_url":"https://avatars.githubusercontent.com/u/22263?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfmanjm","html_url":"https://github.com/wolfmanjm","followers_url":"https://api.github.com/users/wolfmanjm/followers","following_url":"https://api.github.com/users/wolfmanjm/following{/other_user}","gists_url":"https://api.github.com/users/wolfmanjm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfmanjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfmanjm/subscriptions","organizations_url":"https://api.github.com/users/wolfmanjm/orgs","repos_url":"https://api.github.com/users/wolfmanjm/repos","events_url":"https://api.github.com/users/wolfmanjm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfmanjm/received_events","type":"User","site_admin":false},"created_at":"2016-08-29T18:42:39Z","updated_at":"2016-08-29T18:42:39Z","body":"I am rejecting this as it violates the submission rules.\r\nonly one feature per pull request, this has at lest two.\r\nYou need to separate these in two PR. As I may not accept the homing one for instance."}}
{"actor":{"display_login":"wolfmanjm"}}