{"action":"closed","number":314,"pull_request":{"url":"https://api.github.com/repos/NumScale/boost.simd/pulls/314","id":92749454,"html_url":"https://github.com/NumScale/boost.simd/pull/314","diff_url":"https://github.com/NumScale/boost.simd/pull/314.diff","patch_url":"https://github.com/NumScale/boost.simd/pull/314.patch","issue_url":"https://api.github.com/repos/NumScale/boost.simd/issues/314","number":314,"state":"closed","locked":false,"title":"Fixed comments and documentation","user":{"login":"Fytch","id":10600373,"avatar_url":"https://avatars.githubusercontent.com/u/10600373?v=3","gravatar_id":"","url":"https://api.github.com/users/Fytch","html_url":"https://github.com/Fytch","followers_url":"https://api.github.com/users/Fytch/followers","following_url":"https://api.github.com/users/Fytch/following{/other_user}","gists_url":"https://api.github.com/users/Fytch/gists{/gist_id}","starred_url":"https://api.github.com/users/Fytch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fytch/subscriptions","organizations_url":"https://api.github.com/users/Fytch/orgs","repos_url":"https://api.github.com/users/Fytch/repos","events_url":"https://api.github.com/users/Fytch/events{/privacy}","received_events_url":"https://api.github.com/users/Fytch/received_events","type":"User","site_admin":false},"body":"My changes concern the files _detail/predef/hardware/simd/x86/versions.h_ and _function/if*.hpp_.\r\n\r\nThere was a mismatch between the comment and the code in _version.h_.\r\n\r\nChanges to the _function/if*.hpp_ files:\r\nOften times the documentation was referring to a parameter called `cond` which doesn't exist. The conditional parameter is labeled `c` throughout the concerned parts of the documentations, including the function signatures.\r\nFurthermore, the documentation seemed to be very inconsistent regarding `@c` and `@ref` tags; so I've made use of them wherever possible.\r\nThere also were some incorrect code samles with missing `<T>()` e.g. after `Allbits`.\r\nAlso fixed formatting and incorrect phrasing.\r\n\r\nImportant: The function signature as seen previously in _if_else.hpp_ was incorrect. Although I've fixed it, I'm uncertain whether or not this change entails further need for fixes along the library.\r\n","created_at":"2016-11-08T10:16:19Z","updated_at":"2016-11-08T13:29:19Z","closed_at":"2016-11-08T13:29:19Z","merged_at":"2016-11-08T13:29:19Z","merge_commit_sha":"2217f1d0102193799469b533e3a7118bf4a77dde","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NumScale/boost.simd/pulls/314/commits","review_comments_url":"https://api.github.com/repos/NumScale/boost.simd/pulls/314/comments","review_comment_url":"https://api.github.com/repos/NumScale/boost.simd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NumScale/boost.simd/issues/314/comments","statuses_url":"https://api.github.com/repos/NumScale/boost.simd/statuses/287eff9f20712c1ad2625ff4b1c6ace274cb3e1c","head":{"label":"Fytch:typos_fixed","ref":"typos_fixed","sha":"287eff9f20712c1ad2625ff4b1c6ace274cb3e1c","user":{"login":"Fytch","id":10600373,"avatar_url":"https://avatars.githubusercontent.com/u/10600373?v=3","gravatar_id":"","url":"https://api.github.com/users/Fytch","html_url":"https://github.com/Fytch","followers_url":"https://api.github.com/users/Fytch/followers","following_url":"https://api.github.com/users/Fytch/following{/other_user}","gists_url":"https://api.github.com/users/Fytch/gists{/gist_id}","starred_url":"https://api.github.com/users/Fytch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fytch/subscriptions","organizations_url":"https://api.github.com/users/Fytch/orgs","repos_url":"https://api.github.com/users/Fytch/repos","events_url":"https://api.github.com/users/Fytch/events{/privacy}","received_events_url":"https://api.github.com/users/Fytch/received_events","type":"User","site_admin":false},"repo":{"id":73167251,"name":"boost.simd","full_name":"Fytch/boost.simd","owner":{"login":"Fytch","id":10600373,"avatar_url":"https://avatars.githubusercontent.com/u/10600373?v=3","gravatar_id":"","url":"https://api.github.com/users/Fytch","html_url":"https://github.com/Fytch","followers_url":"https://api.github.com/users/Fytch/followers","following_url":"https://api.github.com/users/Fytch/following{/other_user}","gists_url":"https://api.github.com/users/Fytch/gists{/gist_id}","starred_url":"https://api.github.com/users/Fytch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fytch/subscriptions","organizations_url":"https://api.github.com/users/Fytch/orgs","repos_url":"https://api.github.com/users/Fytch/repos","events_url":"https://api.github.com/users/Fytch/events{/privacy}","received_events_url":"https://api.github.com/users/Fytch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fytch/boost.simd","description":"Portable SIMD computation library - To be proposed as a Boost library","fork":true,"url":"https://api.github.com/repos/Fytch/boost.simd","forks_url":"https://api.github.com/repos/Fytch/boost.simd/forks","keys_url":"https://api.github.com/repos/Fytch/boost.simd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fytch/boost.simd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fytch/boost.simd/teams","hooks_url":"https://api.github.com/repos/Fytch/boost.simd/hooks","issue_events_url":"https://api.github.com/repos/Fytch/boost.simd/issues/events{/number}","events_url":"https://api.github.com/repos/Fytch/boost.simd/events","assignees_url":"https://api.github.com/repos/Fytch/boost.simd/assignees{/user}","branches_url":"https://api.github.com/repos/Fytch/boost.simd/branches{/branch}","tags_url":"https://api.github.com/repos/Fytch/boost.simd/tags","blobs_url":"https://api.github.com/repos/Fytch/boost.simd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fytch/boost.simd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fytch/boost.simd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fytch/boost.simd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fytch/boost.simd/statuses/{sha}","languages_url":"https://api.github.com/repos/Fytch/boost.simd/languages","stargazers_url":"https://api.github.com/repos/Fytch/boost.simd/stargazers","contributors_url":"https://api.github.com/repos/Fytch/boost.simd/contributors","subscribers_url":"https://api.github.com/repos/Fytch/boost.simd/subscribers","subscription_url":"https://api.github.com/repos/Fytch/boost.simd/subscription","commits_url":"https://api.github.com/repos/Fytch/boost.simd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fytch/boost.simd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fytch/boost.simd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fytch/boost.simd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fytch/boost.simd/contents/{+path}","compare_url":"https://api.github.com/repos/Fytch/boost.simd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fytch/boost.simd/merges","archive_url":"https://api.github.com/repos/Fytch/boost.simd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fytch/boost.simd/downloads","issues_url":"https://api.github.com/repos/Fytch/boost.simd/issues{/number}","pulls_url":"https://api.github.com/repos/Fytch/boost.simd/pulls{/number}","milestones_url":"https://api.github.com/repos/Fytch/boost.simd/milestones{/number}","notifications_url":"https://api.github.com/repos/Fytch/boost.simd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fytch/boost.simd/labels{/name}","releases_url":"https://api.github.com/repos/Fytch/boost.simd/releases{/id}","deployments_url":"https://api.github.com/repos/Fytch/boost.simd/deployments","created_at":"2016-11-08T08:55:05Z","updated_at":"2016-11-08T08:55:12Z","pushed_at":"2016-11-08T10:13:03Z","git_url":"git://github.com/Fytch/boost.simd.git","ssh_url":"git@github.com:Fytch/boost.simd.git","clone_url":"https://github.com/Fytch/boost.simd.git","svn_url":"https://github.com/Fytch/boost.simd","homepage":"","size":17987,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"NumScale:develop","ref":"develop","sha":"a54f6f67a433e8fa33800b82f02411a0bcaa29d4","user":{"login":"NumScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?v=3","gravatar_id":"","url":"https://api.github.com/users/NumScale","html_url":"https://github.com/NumScale","followers_url":"https://api.github.com/users/NumScale/followers","following_url":"https://api.github.com/users/NumScale/following{/other_user}","gists_url":"https://api.github.com/users/NumScale/gists{/gist_id}","starred_url":"https://api.github.com/users/NumScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NumScale/subscriptions","organizations_url":"https://api.github.com/users/NumScale/orgs","repos_url":"https://api.github.com/users/NumScale/repos","events_url":"https://api.github.com/users/NumScale/events{/privacy}","received_events_url":"https://api.github.com/users/NumScale/received_events","type":"Organization","site_admin":false},"repo":{"id":31229726,"name":"boost.simd","full_name":"NumScale/boost.simd","owner":{"login":"NumScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?v=3","gravatar_id":"","url":"https://api.github.com/users/NumScale","html_url":"https://github.com/NumScale","followers_url":"https://api.github.com/users/NumScale/followers","following_url":"https://api.github.com/users/NumScale/following{/other_user}","gists_url":"https://api.github.com/users/NumScale/gists{/gist_id}","starred_url":"https://api.github.com/users/NumScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NumScale/subscriptions","organizations_url":"https://api.github.com/users/NumScale/orgs","repos_url":"https://api.github.com/users/NumScale/repos","events_url":"https://api.github.com/users/NumScale/events{/privacy}","received_events_url":"https://api.github.com/users/NumScale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NumScale/boost.simd","description":"Portable SIMD computation library - To be proposed as a Boost library","fork":false,"url":"https://api.github.com/repos/NumScale/boost.simd","forks_url":"https://api.github.com/repos/NumScale/boost.simd/forks","keys_url":"https://api.github.com/repos/NumScale/boost.simd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NumScale/boost.simd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NumScale/boost.simd/teams","hooks_url":"https://api.github.com/repos/NumScale/boost.simd/hooks","issue_events_url":"https://api.github.com/repos/NumScale/boost.simd/issues/events{/number}","events_url":"https://api.github.com/repos/NumScale/boost.simd/events","assignees_url":"https://api.github.com/repos/NumScale/boost.simd/assignees{/user}","branches_url":"https://api.github.com/repos/NumScale/boost.simd/branches{/branch}","tags_url":"https://api.github.com/repos/NumScale/boost.simd/tags","blobs_url":"https://api.github.com/repos/NumScale/boost.simd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NumScale/boost.simd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NumScale/boost.simd/git/refs{/sha}","trees_url":"https://api.github.com/repos/NumScale/boost.simd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NumScale/boost.simd/statuses/{sha}","languages_url":"https://api.github.com/repos/NumScale/boost.simd/languages","stargazers_url":"https://api.github.com/repos/NumScale/boost.simd/stargazers","contributors_url":"https://api.github.com/repos/NumScale/boost.simd/contributors","subscribers_url":"https://api.github.com/repos/NumScale/boost.simd/subscribers","subscription_url":"https://api.github.com/repos/NumScale/boost.simd/subscription","commits_url":"https://api.github.com/repos/NumScale/boost.simd/commits{/sha}","git_commits_url":"https://api.github.com/repos/NumScale/boost.simd/git/commits{/sha}","comments_url":"https://api.github.com/repos/NumScale/boost.simd/comments{/number}","issue_comment_url":"https://api.github.com/repos/NumScale/boost.simd/issues/comments{/number}","contents_url":"https://api.github.com/repos/NumScale/boost.simd/contents/{+path}","compare_url":"https://api.github.com/repos/NumScale/boost.simd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NumScale/boost.simd/merges","archive_url":"https://api.github.com/repos/NumScale/boost.simd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NumScale/boost.simd/downloads","issues_url":"https://api.github.com/repos/NumScale/boost.simd/issues{/number}","pulls_url":"https://api.github.com/repos/NumScale/boost.simd/pulls{/number}","milestones_url":"https://api.github.com/repos/NumScale/boost.simd/milestones{/number}","notifications_url":"https://api.github.com/repos/NumScale/boost.simd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NumScale/boost.simd/labels{/name}","releases_url":"https://api.github.com/repos/NumScale/boost.simd/releases{/id}","deployments_url":"https://api.github.com/repos/NumScale/boost.simd/deployments","created_at":"2015-02-23T21:04:49Z","updated_at":"2016-11-08T10:35:56Z","pushed_at":"2016-11-08T13:29:19Z","git_url":"git://github.com/NumScale/boost.simd.git","ssh_url":"git@github.com:NumScale/boost.simd.git","clone_url":"https://github.com/NumScale/boost.simd.git","svn_url":"https://github.com/NumScale/boost.simd","homepage":"","size":20796,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":70,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/314"},"html":{"href":"https://github.com/NumScale/boost.simd/pull/314"},"issue":{"href":"https://api.github.com/repos/NumScale/boost.simd/issues/314"},"comments":{"href":"https://api.github.com/repos/NumScale/boost.simd/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/NumScale/boost.simd/statuses/287eff9f20712c1ad2625ff4b1c6ace274cb3e1c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ccharly","id":569258,"avatar_url":"https://avatars.githubusercontent.com/u/569258?v=3","gravatar_id":"","url":"https://api.github.com/users/ccharly","html_url":"https://github.com/ccharly","followers_url":"https://api.github.com/users/ccharly/followers","following_url":"https://api.github.com/users/ccharly/following{/other_user}","gists_url":"https://api.github.com/users/ccharly/gists{/gist_id}","starred_url":"https://api.github.com/users/ccharly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccharly/subscriptions","organizations_url":"https://api.github.com/users/ccharly/orgs","repos_url":"https://api.github.com/users/ccharly/repos","events_url":"https://api.github.com/users/ccharly/events{/privacy}","received_events_url":"https://api.github.com/users/ccharly/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":57,"deletions":57,"changed_files":15}}
{"actor":{"display_login":"ccharly"}}