{"action":"created","issue":{"url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1042","repository_url":"https://api.github.com/repos/CorsixTH/CorsixTH","labels_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1042/labels{/name}","comments_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1042/comments","events_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1042/events","html_url":"https://github.com/CorsixTH/CorsixTH/issues/1042","id":149096602,"number":1042,"title":"doesn't build with ffmpeg 3.0","user":{"login":"a-detiste","id":7994192,"avatar_url":"https://avatars.githubusercontent.com/u/7994192?v=3","gravatar_id":"","url":"https://api.github.com/users/a-detiste","html_url":"https://github.com/a-detiste","followers_url":"https://api.github.com/users/a-detiste/followers","following_url":"https://api.github.com/users/a-detiste/following{/other_user}","gists_url":"https://api.github.com/users/a-detiste/gists{/gist_id}","starred_url":"https://api.github.com/users/a-detiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-detiste/subscriptions","organizations_url":"https://api.github.com/users/a-detiste/orgs","repos_url":"https://api.github.com/users/a-detiste/repos","events_url":"https://api.github.com/users/a-detiste/events{/privacy}","received_events_url":"https://api.github.com/users/a-detiste/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/CorsixTH/CorsixTH/milestones/5","html_url":"https://github.com/CorsixTH/CorsixTH/milestones/0.60","labels_url":"https://api.github.com/repos/CorsixTH/CorsixTH/milestones/5/labels","id":1605955,"number":5,"title":"0.60","description":"0.60 release","creator":{"login":"TheCycoONE","id":823433,"avatar_url":"https://avatars.githubusercontent.com/u/823433?v=3","gravatar_id":"","url":"https://api.github.com/users/TheCycoONE","html_url":"https://github.com/TheCycoONE","followers_url":"https://api.github.com/users/TheCycoONE/followers","following_url":"https://api.github.com/users/TheCycoONE/following{/other_user}","gists_url":"https://api.github.com/users/TheCycoONE/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCycoONE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCycoONE/subscriptions","organizations_url":"https://api.github.com/users/TheCycoONE/orgs","repos_url":"https://api.github.com/users/TheCycoONE/repos","events_url":"https://api.github.com/users/TheCycoONE/events{/privacy}","received_events_url":"https://api.github.com/users/TheCycoONE/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":5,"state":"open","created_at":"2016-02-25T19:36:38Z","updated_at":"2016-04-18T11:48:54Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-04-18T09:31:04Z","updated_at":"2016-04-18T12:37:39Z","closed_at":null,"body":"Hi,\r\n\r\nThe debian build daemons tried to automatically rebuild Corsix-TH with FFMpeg 3.0.\r\nThat failed. Fix seems obvious ( `s/av_free_packet/av_packet_unref/g`),\r\ncan you please review it (I have a 6hours commute for now, sorry)\r\nand include it in 0.60 release ?\r\n\r\nThis commit at MPV project says this api had been deprecated for a while\r\nand /av_packet_unref is already present in FFmpeg for a while,\r\nand that is dated Oct 2015.\r\n\r\nhttps://github.com/mpv-player/mpv/commit/3c081dfd938181dcd0c7dfedbbc3db460d757e38\r\n\r\n```\r\nReplace deprecated av_free_packet() calls \r\n\r\nav_free_packet() got finally deprecated. Use av_packet_unref() instead,\r\nwhich has almost the same semantics, has existed for a while, and is\r\navailable in all FFmpeg and Libav versions we support.\r\n```\r\n\r\n-----\r\n\r\n@emorrp1 \r\n\r\nhttps://buildd.debian.org/status/package.php?p=corsix-th#problem-3\r\n\r\nhttps://github.com/xbmc/xbmc/commit/37743813f5f6beaf36c06b56ddbea07d74b72936\r\n\r\nhttps://github.com/andrewrk/libgroove/commit/aed5104a92089e9b56ac5a47935980f9f07f72b5"},"comment":{"url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/comments/211360495","html_url":"https://github.com/CorsixTH/CorsixTH/issues/1042#issuecomment-211360495","issue_url":"https://api.github.com/repos/CorsixTH/CorsixTH/issues/1042","id":211360495,"user":{"login":"emorrp1","id":71895,"avatar_url":"https://avatars.githubusercontent.com/u/71895?v=3","gravatar_id":"","url":"https://api.github.com/users/emorrp1","html_url":"https://github.com/emorrp1","followers_url":"https://api.github.com/users/emorrp1/followers","following_url":"https://api.github.com/users/emorrp1/following{/other_user}","gists_url":"https://api.github.com/users/emorrp1/gists{/gist_id}","starred_url":"https://api.github.com/users/emorrp1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emorrp1/subscriptions","organizations_url":"https://api.github.com/users/emorrp1/orgs","repos_url":"https://api.github.com/users/emorrp1/repos","events_url":"https://api.github.com/users/emorrp1/events{/privacy}","received_events_url":"https://api.github.com/users/emorrp1/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T12:37:39Z","updated_at":"2016-04-18T12:37:39Z","body":"I've looked into the [build log](https://buildd.debian.org/status/fetch.php?pkg=corsix-th&arch=arm64&ver=0.50-1%2Bb1&stamp=1460970775) (search \"Building CXX object\") and while there are deprecation warnings (see below), that's not the actual build error.\r\n\r\n> [CorsixTH/Src/th_movie.h:69](https://github.com/CorsixTH/CorsixTH/blob/v0.50/CorsixTH/Src/th_movie.h#L69):5: error: 'PixelFormat' does not name a type\r\n\r\nWhich looks like it was fixed cleanly in v0.60-beta1 (9260930bd1e4721736859bee9c86aa70ecd3ddba) so apologies for bothering you and we should just be able to cherry-pick the patch for compatibility (or wait for the v0.60 release). I think this issue can be closed.\r\n\r\n>  Use AVPixelFormat and related\r\n> \r\n> Non AV prefixed PixelFormat and PIX_FMT_* enums have been deprecated for years.\r\n> They have been removed in git for both libav and ffmpeg. This patch uses the newer replacements while retaining compatibility for old ffmpeg and libav versions.\r\n\r\nFull list of deprecations from build log (which would be nice to fix anyway):\r\n* `avpicture_get_size`\r\n* `avpicture_fill`\r\n* `av_dup_packet`\r\n* `av_free_packet`\r\n\r\n@a-detiste FYI, I've begun preliminary changes for v0.60 in the \"debian/experimental\" git branch"}}