{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/commercial-templates/issues/92","repository_url":"https://api.github.com/repos/guardian/commercial-templates","labels_url":"https://api.github.com/repos/guardian/commercial-templates/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/guardian/commercial-templates/issues/92/comments","events_url":"https://api.github.com/repos/guardian/commercial-templates/issues/92/events","html_url":"https://github.com/guardian/commercial-templates/pull/92","id":188724805,"number":92,"title":"Making place for AMP creatives","user":{"login":"regiskuckaertz","id":629976,"avatar_url":"https://avatars.githubusercontent.com/u/629976?v=3","gravatar_id":"","url":"https://api.github.com/users/regiskuckaertz","html_url":"https://github.com/regiskuckaertz","followers_url":"https://api.github.com/users/regiskuckaertz/followers","following_url":"https://api.github.com/users/regiskuckaertz/following{/other_user}","gists_url":"https://api.github.com/users/regiskuckaertz/gists{/gist_id}","starred_url":"https://api.github.com/users/regiskuckaertz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regiskuckaertz/subscriptions","organizations_url":"https://api.github.com/users/regiskuckaertz/orgs","repos_url":"https://api.github.com/users/regiskuckaertz/repos","events_url":"https://api.github.com/users/regiskuckaertz/events{/privacy}","received_events_url":"https://api.github.com/users/regiskuckaertz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-11T10:00:11Z","updated_at":"2016-11-14T11:18:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/guardian/commercial-templates/pulls/92","html_url":"https://github.com/guardian/commercial-templates/pull/92","diff_url":"https://github.com/guardian/commercial-templates/pull/92.diff","patch_url":"https://github.com/guardian/commercial-templates/pull/92.patch"},"body":"So, AMP is very specific in that:\r\n\r\n- we can't use JavaScript: this severely limits the scope of each template to be essentially empty HTML fragments with DFP placeholders\r\n- we can't use `style` attributes: that means moving all the style-related variables into the CSS\r\n- AMP is for mobile only so all the desktop stuff can go away\r\n- Finally, the `!important` keyword is forbidden in AMP... I don't know why\r\n\r\nAs a result I had to change the build process, which is the point of this PR. It also adds a Fabric for AMP for testing purposes.\r\n\r\n(As a corollary, a much better build process will be written at some point in the future. It is good enough now. For example, we could use UNCSS to remove all the unnecessary styles for a specific template.)\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/commercial-templates/issues/comments/260310396","html_url":"https://github.com/guardian/commercial-templates/pull/92#issuecomment-260310396","issue_url":"https://api.github.com/repos/guardian/commercial-templates/issues/92","id":260310396,"user":{"login":"janua","id":445472,"avatar_url":"https://avatars.githubusercontent.com/u/445472?v=3","gravatar_id":"","url":"https://api.github.com/users/janua","html_url":"https://github.com/janua","followers_url":"https://api.github.com/users/janua/followers","following_url":"https://api.github.com/users/janua/following{/other_user}","gists_url":"https://api.github.com/users/janua/gists{/gist_id}","starred_url":"https://api.github.com/users/janua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janua/subscriptions","organizations_url":"https://api.github.com/users/janua/orgs","repos_url":"https://api.github.com/users/janua/repos","events_url":"https://api.github.com/users/janua/events{/privacy}","received_events_url":"https://api.github.com/users/janua/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T11:18:20Z","updated_at":"2016-11-14T11:18:20Z","body":"LGTM :+1: "}}
{"actor":{"display_login":"janua"}}