{"action":"closed","number":34,"pull_request":{"url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/34","id":59534635,"html_url":"https://github.com/LibraryOfCongress/bagit-java/pull/34","diff_url":"https://github.com/LibraryOfCongress/bagit-java/pull/34.diff","patch_url":"https://github.com/LibraryOfCongress/bagit-java/pull/34.patch","issue_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/34","number":34,"state":"closed","locked":false,"title":"Bagit-java issue 31 : Hidden files should be ignored.","user":{"login":"danshim","id":1028699,"avatar_url":"https://avatars.githubusercontent.com/u/1028699?v=3","gravatar_id":"","url":"https://api.github.com/users/danshim","html_url":"https://github.com/danshim","followers_url":"https://api.github.com/users/danshim/followers","following_url":"https://api.github.com/users/danshim/following{/other_user}","gists_url":"https://api.github.com/users/danshim/gists{/gist_id}","starred_url":"https://api.github.com/users/danshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danshim/subscriptions","organizations_url":"https://api.github.com/users/danshim/orgs","repos_url":"https://api.github.com/users/danshim/repos","events_url":"https://api.github.com/users/danshim/events{/privacy}","received_events_url":"https://api.github.com/users/danshim/received_events","type":"User","site_admin":false},"body":"In the vast majority of cases, system hidden files are not intended to be viewed or exploited by users and are generated as facilitators to the operating system. They are therefore hidden from the curator who creates or verifies a bag, and are included, unknowingly, in the bagging and validation processes, causing false negatives.\r\n\r\nThey should therefore be ignored by Bagit, unless, in some rare cases, the creator specifically intends to include those hidden files in the bag.\r\n\r\nThis change filters out hidden files by default, while adding an option to include them, in both bag creation and validation, in the process.\r\n\r\nThe actual code change consists of creating a new node filter that ignores hidden files, and adding a default filter property to both the BagFactory and FileSystem class/interfaces. The default constructor of the BagFactory class instantiates a NotHiddenFileSystemNodeFilter as its default filter. A null filter is allowed, not filtering nodes by default.\r\n\r\nSetting a default filter on a BagFactory can be used with any FileSystemNodeFilter, including combination of several filters using the And, Not and Or filters.\r\n\r\n ","created_at":"2016-02-16T18:42:30Z","updated_at":"2016-02-22T19:22:34Z","closed_at":"2016-02-22T19:22:34Z","merged_at":null,"merge_commit_sha":"0a98225bf2ed60750976e428a57420eba77d5596","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/34/commits","review_comments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/34/comments","review_comment_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/34/comments","statuses_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/statuses/25d138fad103e58f6b899ab44e4a79fee0931866","head":{"label":"danshim:master","ref":"master","sha":"25d138fad103e58f6b899ab44e4a79fee0931866","user":{"login":"danshim","id":1028699,"avatar_url":"https://avatars.githubusercontent.com/u/1028699?v=3","gravatar_id":"","url":"https://api.github.com/users/danshim","html_url":"https://github.com/danshim","followers_url":"https://api.github.com/users/danshim/followers","following_url":"https://api.github.com/users/danshim/following{/other_user}","gists_url":"https://api.github.com/users/danshim/gists{/gist_id}","starred_url":"https://api.github.com/users/danshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danshim/subscriptions","organizations_url":"https://api.github.com/users/danshim/orgs","repos_url":"https://api.github.com/users/danshim/repos","events_url":"https://api.github.com/users/danshim/events{/privacy}","received_events_url":"https://api.github.com/users/danshim/received_events","type":"User","site_admin":false},"repo":{"id":51475780,"name":"bagit-java","full_name":"danshim/bagit-java","owner":{"login":"danshim","id":1028699,"avatar_url":"https://avatars.githubusercontent.com/u/1028699?v=3","gravatar_id":"","url":"https://api.github.com/users/danshim","html_url":"https://github.com/danshim","followers_url":"https://api.github.com/users/danshim/followers","following_url":"https://api.github.com/users/danshim/following{/other_user}","gists_url":"https://api.github.com/users/danshim/gists{/gist_id}","starred_url":"https://api.github.com/users/danshim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danshim/subscriptions","organizations_url":"https://api.github.com/users/danshim/orgs","repos_url":"https://api.github.com/users/danshim/repos","events_url":"https://api.github.com/users/danshim/events{/privacy}","received_events_url":"https://api.github.com/users/danshim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danshim/bagit-java","description":"Java library and command line to support BagIt. A fork of a project of the Library of Congress which addresses the issue of hidden system files such as .DS_Store and thumbnail files causing false negatives.","fork":true,"url":"https://api.github.com/repos/danshim/bagit-java","forks_url":"https://api.github.com/repos/danshim/bagit-java/forks","keys_url":"https://api.github.com/repos/danshim/bagit-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danshim/bagit-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danshim/bagit-java/teams","hooks_url":"https://api.github.com/repos/danshim/bagit-java/hooks","issue_events_url":"https://api.github.com/repos/danshim/bagit-java/issues/events{/number}","events_url":"https://api.github.com/repos/danshim/bagit-java/events","assignees_url":"https://api.github.com/repos/danshim/bagit-java/assignees{/user}","branches_url":"https://api.github.com/repos/danshim/bagit-java/branches{/branch}","tags_url":"https://api.github.com/repos/danshim/bagit-java/tags","blobs_url":"https://api.github.com/repos/danshim/bagit-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danshim/bagit-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danshim/bagit-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/danshim/bagit-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danshim/bagit-java/statuses/{sha}","languages_url":"https://api.github.com/repos/danshim/bagit-java/languages","stargazers_url":"https://api.github.com/repos/danshim/bagit-java/stargazers","contributors_url":"https://api.github.com/repos/danshim/bagit-java/contributors","subscribers_url":"https://api.github.com/repos/danshim/bagit-java/subscribers","subscription_url":"https://api.github.com/repos/danshim/bagit-java/subscription","commits_url":"https://api.github.com/repos/danshim/bagit-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/danshim/bagit-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/danshim/bagit-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/danshim/bagit-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/danshim/bagit-java/contents/{+path}","compare_url":"https://api.github.com/repos/danshim/bagit-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danshim/bagit-java/merges","archive_url":"https://api.github.com/repos/danshim/bagit-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danshim/bagit-java/downloads","issues_url":"https://api.github.com/repos/danshim/bagit-java/issues{/number}","pulls_url":"https://api.github.com/repos/danshim/bagit-java/pulls{/number}","milestones_url":"https://api.github.com/repos/danshim/bagit-java/milestones{/number}","notifications_url":"https://api.github.com/repos/danshim/bagit-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danshim/bagit-java/labels{/name}","releases_url":"https://api.github.com/repos/danshim/bagit-java/releases{/id}","deployments_url":"https://api.github.com/repos/danshim/bagit-java/deployments","created_at":"2016-02-10T22:02:40Z","updated_at":"2016-02-14T06:14:46Z","pushed_at":"2016-02-22T06:37:45Z","git_url":"git://github.com/danshim/bagit-java.git","ssh_url":"git@github.com:danshim/bagit-java.git","clone_url":"https://github.com/danshim/bagit-java.git","svn_url":"https://github.com/danshim/bagit-java","homepage":"","size":148350,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LibraryOfCongress:master","ref":"master","sha":"ea8c16e66df8e52dd3e006badde37466751d000e","user":{"login":"LibraryOfCongress","id":2070730,"avatar_url":"https://avatars.githubusercontent.com/u/2070730?v=3","gravatar_id":"","url":"https://api.github.com/users/LibraryOfCongress","html_url":"https://github.com/LibraryOfCongress","followers_url":"https://api.github.com/users/LibraryOfCongress/followers","following_url":"https://api.github.com/users/LibraryOfCongress/following{/other_user}","gists_url":"https://api.github.com/users/LibraryOfCongress/gists{/gist_id}","starred_url":"https://api.github.com/users/LibraryOfCongress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibraryOfCongress/subscriptions","organizations_url":"https://api.github.com/users/LibraryOfCongress/orgs","repos_url":"https://api.github.com/users/LibraryOfCongress/repos","events_url":"https://api.github.com/users/LibraryOfCongress/events{/privacy}","received_events_url":"https://api.github.com/users/LibraryOfCongress/received_events","type":"Organization","site_admin":false},"repo":{"id":10645334,"name":"bagit-java","full_name":"LibraryOfCongress/bagit-java","owner":{"login":"LibraryOfCongress","id":2070730,"avatar_url":"https://avatars.githubusercontent.com/u/2070730?v=3","gravatar_id":"","url":"https://api.github.com/users/LibraryOfCongress","html_url":"https://github.com/LibraryOfCongress","followers_url":"https://api.github.com/users/LibraryOfCongress/followers","following_url":"https://api.github.com/users/LibraryOfCongress/following{/other_user}","gists_url":"https://api.github.com/users/LibraryOfCongress/gists{/gist_id}","starred_url":"https://api.github.com/users/LibraryOfCongress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibraryOfCongress/subscriptions","organizations_url":"https://api.github.com/users/LibraryOfCongress/orgs","repos_url":"https://api.github.com/users/LibraryOfCongress/repos","events_url":"https://api.github.com/users/LibraryOfCongress/events{/privacy}","received_events_url":"https://api.github.com/users/LibraryOfCongress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LibraryOfCongress/bagit-java","description":"Java library and command line to support BagIt. A project of the Library of Congress. Note: project members may work on both official Library of Congress projects and non-LC projects.","fork":false,"url":"https://api.github.com/repos/LibraryOfCongress/bagit-java","forks_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/forks","keys_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/teams","hooks_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/hooks","issue_events_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/events{/number}","events_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/events","assignees_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/assignees{/user}","branches_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/branches{/branch}","tags_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/tags","blobs_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/statuses/{sha}","languages_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/languages","stargazers_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/stargazers","contributors_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/contributors","subscribers_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/subscribers","subscription_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/subscription","commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/contents/{+path}","compare_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/merges","archive_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/downloads","issues_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues{/number}","pulls_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls{/number}","milestones_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/milestones{/number}","notifications_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/labels{/name}","releases_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/releases{/id}","deployments_url":"https://api.github.com/repos/LibraryOfCongress/bagit-java/deployments","created_at":"2013-06-12T15:02:44Z","updated_at":"2016-02-03T15:38:03Z","pushed_at":"2016-02-22T06:37:45Z","git_url":"git://github.com/LibraryOfCongress/bagit-java.git","ssh_url":"git@github.com:LibraryOfCongress/bagit-java.git","clone_url":"https://github.com/LibraryOfCongress/bagit-java.git","svn_url":"https://github.com/LibraryOfCongress/bagit-java","homepage":"","size":150129,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":6,"forks":18,"open_issues":6,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/34"},"html":{"href":"https://github.com/LibraryOfCongress/bagit-java/pull/34"},"issue":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/34"},"comments":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/LibraryOfCongress/bagit-java/statuses/25d138fad103e58f6b899ab44e4a79fee0931866"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":177,"deletions":64,"changed_files":17}}