{"action":"created","issue":{"url":"https://api.github.com/repos/IIIF/mirador/issues/947","repository_url":"https://api.github.com/repos/IIIF/mirador","labels_url":"https://api.github.com/repos/IIIF/mirador/issues/947/labels{/name}","comments_url":"https://api.github.com/repos/IIIF/mirador/issues/947/comments","events_url":"https://api.github.com/repos/IIIF/mirador/issues/947/events","html_url":"https://github.com/IIIF/mirador/pull/947","id":158410316,"number":947,"title":"TOC Ranges Fix for Release 2.1","user":{"login":"thehabes","id":3287006,"avatar_url":"https://avatars.githubusercontent.com/u/3287006?v=3","gravatar_id":"","url":"https://api.github.com/users/thehabes","html_url":"https://github.com/thehabes","followers_url":"https://api.github.com/users/thehabes/followers","following_url":"https://api.github.com/users/thehabes/following{/other_user}","gists_url":"https://api.github.com/users/thehabes/gists{/gist_id}","starred_url":"https://api.github.com/users/thehabes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehabes/subscriptions","organizations_url":"https://api.github.com/users/thehabes/orgs","repos_url":"https://api.github.com/users/thehabes/repos","events_url":"https://api.github.com/users/thehabes/events{/privacy}","received_events_url":"https://api.github.com/users/thehabes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-03T16:57:38Z","updated_at":"2016-06-03T17:20:11Z","closed_at":"2016-06-03T17:17:37Z","pull_request":{"url":"https://api.github.com/repos/IIIF/mirador/pulls/947","html_url":"https://github.com/IIIF/mirador/pull/947","diff_url":"https://github.com/IIIF/mirador/pull/947.diff","patch_url":"https://github.com/IIIF/mirador/pull/947.patch"},"body":"**The main fix for this pull request:**\r\nThis fix is all in toc.js with some select mirador.css changes, see the function extractV21RangeTrees and the toc-caret click event handler.\r\n\r\nThis fixes #939, #680 and #527 and an issue not yet brought up:  what happens when a range is within more than one range?  Right now, the within property in mirador doesn't support that.  The ranges[] property does.  The V2 algorithm would just ignore it, the V21 algorithm will support it and place it correctly.\r\n\r\n**Extras included with this pull request:**\r\nThis code also has the fix for #375.  For a demo on how I have placed the image manipulation tools in with the other hud controls, visit [this page](http://165.134.241.141/brokenBooks/getManifest.html)\r\n***anything with the word bbAnno in it can be stricken from the pull request, it is specific to making it work for my application.  \r\n\r\nThis code also supports Non-IIIF images (that is, images not fed via a tiling service or from a IIIF server).  For this code, see the .fail() function in imageView.js (line 954)\r\n\r\nThis code supports default images for \"Image Not Found\" and \"Image Not Resolved\" situations.  See manifest.js, iiif.js, utils.js.  The images used for these are hard linked, feel free to replace them or ignore this code entirely.  "},"comment":{"url":"https://api.github.com/repos/IIIF/mirador/issues/comments/223639369","html_url":"https://github.com/IIIF/mirador/pull/947#issuecomment-223639369","issue_url":"https://api.github.com/repos/IIIF/mirador/issues/947","id":223639369,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T17:20:11Z","updated_at":"2016-06-03T17:20:11Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6455184/badge)](https://coveralls.io/builds/6455184)\n\nCoverage decreased (-5.4%) to 35.367% when pulling **b397d5e4a55373eb8abe89dfa2a153e5dbb24cea on thehabes:master** into **76a35e7c179f31fdc4aad822c9a61b3f20348e3c on IIIF:release2.1**.\n"}}
{"actor":{"display_login":"coveralls"}}