{"action":"created","comment":{"url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/comments/70677496","id":70677496,"diff_hunk":"@@ -0,0 +1,780 @@\n+{","path":"test/configuration/displayname.spec.conf/displayname_schema.json","position":1,"original_position":1,"commit_id":"c62508c3a60587317c1942206077d66e60dbe07f","original_commit_id":"c62508c3a60587317c1942206077d66e60dbe07f","user":{"login":"robes","id":4202842,"avatar_url":"https://avatars.githubusercontent.com/u/4202842?v=3","gravatar_id":"","url":"https://api.github.com/users/robes","html_url":"https://github.com/robes","followers_url":"https://api.github.com/users/robes/followers","following_url":"https://api.github.com/users/robes/following{/other_user}","gists_url":"https://api.github.com/users/robes/gists{/gist_id}","starred_url":"https://api.github.com/users/robes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robes/subscriptions","organizations_url":"https://api.github.com/users/robes/orgs","repos_url":"https://api.github.com/users/robes/repos","events_url":"https://api.github.com/users/robes/events{/privacy}","received_events_url":"https://api.github.com/users/robes/received_events","type":"User","site_admin":false},"body":"general comment here. this seems like a huge schema just to test display name. i think these should be much smaller scoped and focused so that it just covers the schema needed for the test case at hand. i would expect a couple tables at most so that you can test the display name annotation in the primary entity and in nested entities.","created_at":"2016-07-13T18:05:25Z","updated_at":"2016-07-13T18:05:25Z","html_url":"https://github.com/informatics-isi-edu/ermrestjs/pull/82#discussion_r70677496","pull_request_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/comments/70677496"},"html":{"href":"https://github.com/informatics-isi-edu/ermrestjs/pull/82#discussion_r70677496"},"pull_request":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82","id":77213399,"html_url":"https://github.com/informatics-isi-edu/ermrestjs/pull/82","diff_url":"https://github.com/informatics-isi-edu/ermrestjs/pull/82.diff","patch_url":"https://github.com/informatics-isi-edu/ermrestjs/pull/82.patch","issue_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/82","number":82,"state":"open","locked":false,"title":"Displayname Unit Tests","user":{"login":"RFSH","id":2129750,"avatar_url":"https://avatars.githubusercontent.com/u/2129750?v=3","gravatar_id":"","url":"https://api.github.com/users/RFSH","html_url":"https://github.com/RFSH","followers_url":"https://api.github.com/users/RFSH/followers","following_url":"https://api.github.com/users/RFSH/following{/other_user}","gists_url":"https://api.github.com/users/RFSH/gists{/gist_id}","starred_url":"https://api.github.com/users/RFSH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RFSH/subscriptions","organizations_url":"https://api.github.com/users/RFSH/orgs","repos_url":"https://api.github.com/users/RFSH/repos","events_url":"https://api.github.com/users/RFSH/events{/privacy}","received_events_url":"https://api.github.com/users/RFSH/received_events","type":"User","site_admin":false},"body":"This PR,\r\n- Removes old test files.\r\n- Updates the test files to include test cases for displayname.\r\n- Updates the \"How to test the package\" section in readme.\r\n- Updates the .travis.yml file.\r\n\r\n@robes @chiragsanghvi  Can you please review this?","created_at":"2016-07-13T00:28:47Z","updated_at":"2016-07-13T18:05:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45347433f96197ab31392563890fbced5578b71a","assignee":{"login":"chiragsanghvi","id":1658152,"avatar_url":"https://avatars.githubusercontent.com/u/1658152?v=3","gravatar_id":"","url":"https://api.github.com/users/chiragsanghvi","html_url":"https://github.com/chiragsanghvi","followers_url":"https://api.github.com/users/chiragsanghvi/followers","following_url":"https://api.github.com/users/chiragsanghvi/following{/other_user}","gists_url":"https://api.github.com/users/chiragsanghvi/gists{/gist_id}","starred_url":"https://api.github.com/users/chiragsanghvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chiragsanghvi/subscriptions","organizations_url":"https://api.github.com/users/chiragsanghvi/orgs","repos_url":"https://api.github.com/users/chiragsanghvi/repos","events_url":"https://api.github.com/users/chiragsanghvi/events{/privacy}","received_events_url":"https://api.github.com/users/chiragsanghvi/received_events","type":"User","site_admin":false},"assignees":[{"login":"chiragsanghvi","id":1658152,"avatar_url":"https://avatars.githubusercontent.com/u/1658152?v=3","gravatar_id":"","url":"https://api.github.com/users/chiragsanghvi","html_url":"https://github.com/chiragsanghvi","followers_url":"https://api.github.com/users/chiragsanghvi/followers","following_url":"https://api.github.com/users/chiragsanghvi/following{/other_user}","gists_url":"https://api.github.com/users/chiragsanghvi/gists{/gist_id}","starred_url":"https://api.github.com/users/chiragsanghvi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chiragsanghvi/subscriptions","organizations_url":"https://api.github.com/users/chiragsanghvi/orgs","repos_url":"https://api.github.com/users/chiragsanghvi/repos","events_url":"https://api.github.com/users/chiragsanghvi/events{/privacy}","received_events_url":"https://api.github.com/users/chiragsanghvi/received_events","type":"User","site_admin":false},{"login":"robes","id":4202842,"avatar_url":"https://avatars.githubusercontent.com/u/4202842?v=3","gravatar_id":"","url":"https://api.github.com/users/robes","html_url":"https://github.com/robes","followers_url":"https://api.github.com/users/robes/followers","following_url":"https://api.github.com/users/robes/following{/other_user}","gists_url":"https://api.github.com/users/robes/gists{/gist_id}","starred_url":"https://api.github.com/users/robes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robes/subscriptions","organizations_url":"https://api.github.com/users/robes/orgs","repos_url":"https://api.github.com/users/robes/repos","events_url":"https://api.github.com/users/robes/events{/privacy}","received_events_url":"https://api.github.com/users/robes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82/commits","review_comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82/comments","review_comment_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/82/comments","statuses_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/c62508c3a60587317c1942206077d66e60dbe07f","head":{"label":"informatics-isi-edu:displayname","ref":"displayname","sha":"c62508c3a60587317c1942206077d66e60dbe07f","user":{"login":"informatics-isi-edu","id":9324294,"avatar_url":"https://avatars.githubusercontent.com/u/9324294?v=3","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":39903075,"name":"ermrestjs","full_name":"informatics-isi-edu/ermrestjs","owner":{"login":"informatics-isi-edu","id":9324294,"avatar_url":"https://avatars.githubusercontent.com/u/9324294?v=3","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/informatics-isi-edu/ermrestjs","description":"ERMrest client library in JavaScript","fork":false,"url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs","forks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/forks","keys_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/teams","hooks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/hooks","issue_events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/events{/number}","events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/events","assignees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/assignees{/user}","branches_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/branches{/branch}","tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/tags","blobs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/{sha}","languages_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/languages","stargazers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/stargazers","contributors_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contributors","subscribers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscribers","subscription_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscription","commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contents/{+path}","compare_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/merges","archive_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/downloads","issues_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues{/number}","pulls_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls{/number}","milestones_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/milestones{/number}","notifications_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/labels{/name}","releases_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/releases{/id}","deployments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/deployments","created_at":"2015-07-29T16:06:49Z","updated_at":"2016-01-12T23:51:44Z","pushed_at":"2016-07-13T00:50:50Z","git_url":"git://github.com/informatics-isi-edu/ermrestjs.git","ssh_url":"git@github.com:informatics-isi-edu/ermrestjs.git","clone_url":"https://github.com/informatics-isi-edu/ermrestjs.git","svn_url":"https://github.com/informatics-isi-edu/ermrestjs","homepage":null,"size":388,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":29,"forks":2,"open_issues":29,"watchers":0,"default_branch":"master"}},"base":{"label":"informatics-isi-edu:master","ref":"master","sha":"a3a10511495b38587678e0e7671dea7c0e17ebdd","user":{"login":"informatics-isi-edu","id":9324294,"avatar_url":"https://avatars.githubusercontent.com/u/9324294?v=3","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":39903075,"name":"ermrestjs","full_name":"informatics-isi-edu/ermrestjs","owner":{"login":"informatics-isi-edu","id":9324294,"avatar_url":"https://avatars.githubusercontent.com/u/9324294?v=3","gravatar_id":"","url":"https://api.github.com/users/informatics-isi-edu","html_url":"https://github.com/informatics-isi-edu","followers_url":"https://api.github.com/users/informatics-isi-edu/followers","following_url":"https://api.github.com/users/informatics-isi-edu/following{/other_user}","gists_url":"https://api.github.com/users/informatics-isi-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/informatics-isi-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/informatics-isi-edu/subscriptions","organizations_url":"https://api.github.com/users/informatics-isi-edu/orgs","repos_url":"https://api.github.com/users/informatics-isi-edu/repos","events_url":"https://api.github.com/users/informatics-isi-edu/events{/privacy}","received_events_url":"https://api.github.com/users/informatics-isi-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/informatics-isi-edu/ermrestjs","description":"ERMrest client library in JavaScript","fork":false,"url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs","forks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/forks","keys_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/teams","hooks_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/hooks","issue_events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/events{/number}","events_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/events","assignees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/assignees{/user}","branches_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/branches{/branch}","tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/tags","blobs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/{sha}","languages_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/languages","stargazers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/stargazers","contributors_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contributors","subscribers_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscribers","subscription_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/subscription","commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/contents/{+path}","compare_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/merges","archive_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/downloads","issues_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues{/number}","pulls_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls{/number}","milestones_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/milestones{/number}","notifications_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/labels{/name}","releases_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/releases{/id}","deployments_url":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/deployments","created_at":"2015-07-29T16:06:49Z","updated_at":"2016-01-12T23:51:44Z","pushed_at":"2016-07-13T00:50:50Z","git_url":"git://github.com/informatics-isi-edu/ermrestjs.git","ssh_url":"git@github.com:informatics-isi-edu/ermrestjs.git","clone_url":"https://github.com/informatics-isi-edu/ermrestjs.git","svn_url":"https://github.com/informatics-isi-edu/ermrestjs","homepage":null,"size":388,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":29,"forks":2,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82"},"html":{"href":"https://github.com/informatics-isi-edu/ermrestjs/pull/82"},"issue":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/82"},"comments":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/informatics-isi-edu/ermrestjs/statuses/c62508c3a60587317c1942206077d66e60dbe07f"}}}}
{"actor":{"display_login":"robes"}}