{"action":"created","issue":{"url":"https://api.github.com/repos/PX4/Firmware/issues/2534","repository_url":"https://api.github.com/repos/PX4/Firmware","labels_url":"https://api.github.com/repos/PX4/Firmware/issues/2534/labels{/name}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/2534/comments","events_url":"https://api.github.com/repos/PX4/Firmware/issues/2534/events","html_url":"https://github.com/PX4/Firmware/issues/2534","id":93120227,"number":2534,"title":"Implement MAV_CMD_SET_MESSAGE_INTERVAL and MESSAGE_INTERVAL","user":{"login":"AndreasAntener","id":5750020,"avatar_url":"https://avatars.githubusercontent.com/u/5750020?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasAntener","html_url":"https://github.com/AndreasAntener","followers_url":"https://api.github.com/users/AndreasAntener/followers","following_url":"https://api.github.com/users/AndreasAntener/following{/other_user}","gists_url":"https://api.github.com/users/AndreasAntener/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasAntener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasAntener/subscriptions","organizations_url":"https://api.github.com/users/AndreasAntener/orgs","repos_url":"https://api.github.com/users/AndreasAntener/repos","events_url":"https://api.github.com/users/AndreasAntener/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasAntener/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/PX4/Firmware/milestones/12","html_url":"https://github.com/PX4/Firmware/milestones/Release%20v1.4.0","labels_url":"https://api.github.com/repos/PX4/Firmware/milestones/12/labels","id":1483533,"number":12,"title":"Release v1.4.0","description":"","creator":{"login":"LorenzMeier","id":1208119,"avatar_url":"https://avatars.githubusercontent.com/u/1208119?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":36,"state":"open","created_at":"2016-01-04T21:23:10Z","updated_at":"2016-05-25T08:10:38Z","due_on":"2016-05-11T22:00:00Z","closed_at":null},"comments":9,"created_at":"2015-07-05T15:26:00Z","updated_at":"2016-05-25T08:10:38Z","closed_at":null,"body":"@LorenzMeier \r\nIn `handle_message_request_data_stream` we convert the received rate (I believe it's meant to be a rate, see below) into an interval (https://github.com/PX4/Firmware/blob/bc5cf50f1a2e3c6113204c48258835d9098b5b0b/src/modules/mavlink/mavlink_receiver.cpp#L1166). But the later invoked method to configure the stream in `mavlink_main` does it again which leads to huge rates. This might be bug in `handle_message_request_data_stream`, which I can fix as soon as I know what the message really meant to specify.\r\n\r\nIn `REQUEST_DATA_STREAM`, the comment says it specifies an interval, but the parameter name suggests it's a rate.\r\nhttps://github.com/mavlink/mavlink/blob/378cd337301b3a6b944fedc46b4fcd89e16da42c/message_definitions/v1.0/common.xml#L2095\r\n\r\nWhat is it? Rates seem to make more sense to me, so I assume the comment lies (what a surprise that would be ;)). Or is it rates * 1000 so we can specify slower than 1Hz?"},"comment":{"url":"https://api.github.com/repos/PX4/Firmware/issues/comments/221503051","html_url":"https://github.com/PX4/Firmware/issues/2534#issuecomment-221503051","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/2534","id":221503051,"user":{"login":"AndreasAntener","id":5750020,"avatar_url":"https://avatars.githubusercontent.com/u/5750020?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreasAntener","html_url":"https://github.com/AndreasAntener","followers_url":"https://api.github.com/users/AndreasAntener/followers","following_url":"https://api.github.com/users/AndreasAntener/following{/other_user}","gists_url":"https://api.github.com/users/AndreasAntener/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasAntener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasAntener/subscriptions","organizations_url":"https://api.github.com/users/AndreasAntener/orgs","repos_url":"https://api.github.com/users/AndreasAntener/repos","events_url":"https://api.github.com/users/AndreasAntener/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasAntener/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T08:10:38Z","updated_at":"2016-05-25T08:10:38Z","body":"I don't think this is implemented"}}
{"actor":{"display_login":"AndreasAntener"}}