{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/72905284","id":72905284,"diff_hunk":"@@ -2645,7 +2647,18 @@\n       <properties>\n         <scala.version>2.11.8</scala.version>\n         <scala.binary.version>2.11</scala.binary.version>\n+        <jline.version>2.12.1</jline.version>\n+        <jline.groupid>jline</jline.groupid>","path":"pom.xml","position":25,"original_position":25,"commit_id":"e4bf237ed43461897beb00211de2d10321fe40b1","original_commit_id":"e4bf237ed43461897beb00211de2d10321fe40b1","user":{"login":"stsc-pentasys","id":6389280,"avatar_url":"https://avatars.githubusercontent.com/u/6389280?v=3","gravatar_id":"","url":"https://api.github.com/users/stsc-pentasys","html_url":"https://github.com/stsc-pentasys","followers_url":"https://api.github.com/users/stsc-pentasys/followers","following_url":"https://api.github.com/users/stsc-pentasys/following{/other_user}","gists_url":"https://api.github.com/users/stsc-pentasys/gists{/gist_id}","starred_url":"https://api.github.com/users/stsc-pentasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsc-pentasys/subscriptions","organizations_url":"https://api.github.com/users/stsc-pentasys/orgs","repos_url":"https://api.github.com/users/stsc-pentasys/repos","events_url":"https://api.github.com/users/stsc-pentasys/events{/privacy}","received_events_url":"https://api.github.com/users/stsc-pentasys/received_events","type":"User","site_admin":false},"body":"See above - provides the correct properties for Scala 2.11.8.","created_at":"2016-07-31T14:41:06Z","updated_at":"2016-07-31T14:41:06Z","html_url":"https://github.com/apache/spark/pull/14429#discussion_r72905284","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/14429","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/72905284"},"html":{"href":"https://github.com/apache/spark/pull/14429#discussion_r72905284"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/14429"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14429","id":79484918,"html_url":"https://github.com/apache/spark/pull/14429","diff_url":"https://github.com/apache/spark/pull/14429.diff","patch_url":"https://github.com/apache/spark/pull/14429.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/14429","number":14429,"state":"open","locked":false,"title":"[SPARK-16770][BUILD] Fix JLine dependency management and version (Sca…","user":{"login":"stsc-pentasys","id":6389280,"avatar_url":"https://avatars.githubusercontent.com/u/6389280?v=3","gravatar_id":"","url":"https://api.github.com/users/stsc-pentasys","html_url":"https://github.com/stsc-pentasys","followers_url":"https://api.github.com/users/stsc-pentasys/followers","following_url":"https://api.github.com/users/stsc-pentasys/following{/other_user}","gists_url":"https://api.github.com/users/stsc-pentasys/gists{/gist_id}","starred_url":"https://api.github.com/users/stsc-pentasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsc-pentasys/subscriptions","organizations_url":"https://api.github.com/users/stsc-pentasys/orgs","repos_url":"https://api.github.com/users/stsc-pentasys/repos","events_url":"https://api.github.com/users/stsc-pentasys/events{/privacy}","received_events_url":"https://api.github.com/users/stsc-pentasys/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nAs of Scala 2.11.x there is no longer a org.scala-lang:jline version aligned to the scala version itself. Scala console now uses the plain jline:jline module. Spark's  dependency management did not reflect this change properly, causing Maven to pull in Jline via transitive dependency. Unfortunately Jline 2.12 contained a minor but very annoying bug rendering the shell almost useless for developers with german keyboard layout. This request contains the following chages:\r\n- Exclude transitive dependency 'jline:jline' from hive-exec module\r\n- Remove global properties 'jline.version' and 'jline.groupId'\r\n- Add both properties and dependency to 'scala-2.11' profile\r\n- Add explicit dependency on 'jline:jline' to  module 'spark-repl'\r\n\r\n## How was this patch tested?\r\n- Running mvn dependency:tree and checking for correct Jline version 2.12.1\r\n- Running full builds with assembly and checking for jline-2.12.1.jar in 'lib' folder of generated tarball\r\n","created_at":"2016-07-31T13:26:58Z","updated_at":"2016-07-31T14:41:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1725521e03c5c0edffef4a704088126799e5f2b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/14429/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/14429/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/14429/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/e4bf237ed43461897beb00211de2d10321fe40b1","head":{"label":"stsc-pentasys:SPARK-16770","ref":"SPARK-16770","sha":"e4bf237ed43461897beb00211de2d10321fe40b1","user":{"login":"stsc-pentasys","id":6389280,"avatar_url":"https://avatars.githubusercontent.com/u/6389280?v=3","gravatar_id":"","url":"https://api.github.com/users/stsc-pentasys","html_url":"https://github.com/stsc-pentasys","followers_url":"https://api.github.com/users/stsc-pentasys/followers","following_url":"https://api.github.com/users/stsc-pentasys/following{/other_user}","gists_url":"https://api.github.com/users/stsc-pentasys/gists{/gist_id}","starred_url":"https://api.github.com/users/stsc-pentasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsc-pentasys/subscriptions","organizations_url":"https://api.github.com/users/stsc-pentasys/orgs","repos_url":"https://api.github.com/users/stsc-pentasys/repos","events_url":"https://api.github.com/users/stsc-pentasys/events{/privacy}","received_events_url":"https://api.github.com/users/stsc-pentasys/received_events","type":"User","site_admin":false},"repo":{"id":64546741,"name":"spark","full_name":"stsc-pentasys/spark","owner":{"login":"stsc-pentasys","id":6389280,"avatar_url":"https://avatars.githubusercontent.com/u/6389280?v=3","gravatar_id":"","url":"https://api.github.com/users/stsc-pentasys","html_url":"https://github.com/stsc-pentasys","followers_url":"https://api.github.com/users/stsc-pentasys/followers","following_url":"https://api.github.com/users/stsc-pentasys/following{/other_user}","gists_url":"https://api.github.com/users/stsc-pentasys/gists{/gist_id}","starred_url":"https://api.github.com/users/stsc-pentasys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsc-pentasys/subscriptions","organizations_url":"https://api.github.com/users/stsc-pentasys/orgs","repos_url":"https://api.github.com/users/stsc-pentasys/repos","events_url":"https://api.github.com/users/stsc-pentasys/events{/privacy}","received_events_url":"https://api.github.com/users/stsc-pentasys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stsc-pentasys/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/stsc-pentasys/spark","forks_url":"https://api.github.com/repos/stsc-pentasys/spark/forks","keys_url":"https://api.github.com/repos/stsc-pentasys/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stsc-pentasys/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stsc-pentasys/spark/teams","hooks_url":"https://api.github.com/repos/stsc-pentasys/spark/hooks","issue_events_url":"https://api.github.com/repos/stsc-pentasys/spark/issues/events{/number}","events_url":"https://api.github.com/repos/stsc-pentasys/spark/events","assignees_url":"https://api.github.com/repos/stsc-pentasys/spark/assignees{/user}","branches_url":"https://api.github.com/repos/stsc-pentasys/spark/branches{/branch}","tags_url":"https://api.github.com/repos/stsc-pentasys/spark/tags","blobs_url":"https://api.github.com/repos/stsc-pentasys/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stsc-pentasys/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stsc-pentasys/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/stsc-pentasys/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stsc-pentasys/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/stsc-pentasys/spark/languages","stargazers_url":"https://api.github.com/repos/stsc-pentasys/spark/stargazers","contributors_url":"https://api.github.com/repos/stsc-pentasys/spark/contributors","subscribers_url":"https://api.github.com/repos/stsc-pentasys/spark/subscribers","subscription_url":"https://api.github.com/repos/stsc-pentasys/spark/subscription","commits_url":"https://api.github.com/repos/stsc-pentasys/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/stsc-pentasys/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/stsc-pentasys/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/stsc-pentasys/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/stsc-pentasys/spark/contents/{+path}","compare_url":"https://api.github.com/repos/stsc-pentasys/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stsc-pentasys/spark/merges","archive_url":"https://api.github.com/repos/stsc-pentasys/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stsc-pentasys/spark/downloads","issues_url":"https://api.github.com/repos/stsc-pentasys/spark/issues{/number}","pulls_url":"https://api.github.com/repos/stsc-pentasys/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/stsc-pentasys/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/stsc-pentasys/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stsc-pentasys/spark/labels{/name}","releases_url":"https://api.github.com/repos/stsc-pentasys/spark/releases{/id}","deployments_url":"https://api.github.com/repos/stsc-pentasys/spark/deployments","created_at":"2016-07-30T13:59:58Z","updated_at":"2016-07-30T14:00:21Z","pushed_at":"2016-07-31T13:00:49Z","git_url":"git://github.com/stsc-pentasys/spark.git","ssh_url":"git@github.com:stsc-pentasys/spark.git","clone_url":"https://github.com/stsc-pentasys/spark.git","svn_url":"https://github.com/stsc-pentasys/spark","homepage":null,"size":176783,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"064d91ff7342002414d3274694a8e2e37f154986","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-07-31T13:57:34Z","pushed_at":"2016-07-31T14:15:08Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":505639,"stargazers_count":9487,"watchers_count":9487,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8798,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":458,"forks":8798,"open_issues":458,"watchers":9487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/14429"},"html":{"href":"https://github.com/apache/spark/pull/14429"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/14429"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/14429/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/14429/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/14429/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/e4bf237ed43461897beb00211de2d10321fe40b1"}}}}
{"actor":{"display_login":"stsc-pentasys"}}