{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/1849","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/1849/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/1849/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/1849/events","html_url":"https://github.com/zulip/zulip/pull/1849","id":179016928,"number":1849,"title":"Handle unknown search operators","user":{"login":"mohsenSy","id":11737155,"avatar_url":"https://avatars.githubusercontent.com/u/11737155?v=3","gravatar_id":"","url":"https://api.github.com/users/mohsenSy","html_url":"https://github.com/mohsenSy","followers_url":"https://api.github.com/users/mohsenSy/followers","following_url":"https://api.github.com/users/mohsenSy/following{/other_user}","gists_url":"https://api.github.com/users/mohsenSy/gists{/gist_id}","starred_url":"https://api.github.com/users/mohsenSy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohsenSy/subscriptions","organizations_url":"https://api.github.com/users/mohsenSy/orgs","repos_url":"https://api.github.com/users/mohsenSy/repos","events_url":"https://api.github.com/users/mohsenSy/events{/privacy}","received_events_url":"https://api.github.com/users/mohsenSy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2016-09-24T07:33:55Z","updated_at":"2016-10-13T10:47:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/1849","html_url":"https://github.com/zulip/zulip/pull/1849","diff_url":"https://github.com/zulip/zulip/pull/1849.diff","patch_url":"https://github.com/zulip/zulip/pull/1849.patch"},"body":"I had to check for the operators, if the operator is not known I changed it to \"search\".\r\nMore details in commit 9e16a0d4c87b76bacdf55c758e6cbedf9d6e37da"},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/253479691","html_url":"https://github.com/zulip/zulip/pull/1849#issuecomment-253479691","issue_url":"https://api.github.com/repos/zulip/zulip/issues/1849","id":253479691,"user":{"login":"mohsenSy","id":11737155,"avatar_url":"https://avatars.githubusercontent.com/u/11737155?v=3","gravatar_id":"","url":"https://api.github.com/users/mohsenSy","html_url":"https://github.com/mohsenSy","followers_url":"https://api.github.com/users/mohsenSy/followers","following_url":"https://api.github.com/users/mohsenSy/following{/other_user}","gists_url":"https://api.github.com/users/mohsenSy/gists{/gist_id}","starred_url":"https://api.github.com/users/mohsenSy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohsenSy/subscriptions","organizations_url":"https://api.github.com/users/mohsenSy/orgs","repos_url":"https://api.github.com/users/mohsenSy/repos","events_url":"https://api.github.com/users/mohsenSy/events{/privacy}","received_events_url":"https://api.github.com/users/mohsenSy/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T10:47:27Z","updated_at":"2016-10-13T10:47:27Z","body":"@timabbott I finally got this to work, is it okay?\r\nThe failed test was using `stream:Verona subject:frontend+test` as a search query, the first part is okay but the second one according to my logic will be considered as unknown operator because `subject` operator is not handled in `Filter.operator_to_prefix`, but `topic` operator is handled there so I just changed the operator from `subject` to `topic` and it worked.\r\n\r\nPlease review the code tell me what you think about it, so I can start working on writing tests.\r\nI should write frontend tests as documented here http://zulip.readthedocs.io/en/latest/testing-with-casper.html right?"}}
{"actor":{"display_login":"mohsenSy"}}