{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/partner-contact/pulls/comments/50171105","id":50171105,"diff_hunk":"@@ -1,26 +1,11 @@\n # -*- coding: utf-8 -*-","path":"partner_firstname/models/partner.py","position":1,"original_position":1,"commit_id":"3c43fdc78fe5436b554b6f82caaa724b73c69d71","original_commit_id":"57afa38a83a2864f141b94720d0fd80ffccb7e24","user":{"login":"bealdav","id":1853434,"avatar_url":"https://avatars.githubusercontent.com/u/1853434?v=3","gravatar_id":"","url":"https://api.github.com/users/bealdav","html_url":"https://github.com/bealdav","followers_url":"https://api.github.com/users/bealdav/followers","following_url":"https://api.github.com/users/bealdav/following{/other_user}","gists_url":"https://api.github.com/users/bealdav/gists{/gist_id}","starred_url":"https://api.github.com/users/bealdav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bealdav/subscriptions","organizations_url":"https://api.github.com/users/bealdav/orgs","repos_url":"https://api.github.com/users/bealdav/repos","events_url":"https://api.github.com/users/bealdav/events{/privacy}","received_events_url":"https://api.github.com/users/bealdav/received_events","type":"User","site_admin":false},"body":"IMHO, it's easier to define filename from a functional point of view, i.e.: product, partner. Easy to read and allow to gather several models in the same file if there is not a lot features. Keep It Simple please to have a progressive learning curve.\r\nThe technical point of view is in the file :-)","created_at":"2016-01-19T20:34:03Z","updated_at":"2016-01-19T20:34:03Z","html_url":"https://github.com/OCA/partner-contact/pull/238#discussion_r50171105","pull_request_url":"https://api.github.com/repos/OCA/partner-contact/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/comments/50171105"},"html":{"href":"https://github.com/OCA/partner-contact/pull/238#discussion_r50171105"},"pull_request":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/partner-contact/pulls/238","id":55889689,"html_url":"https://github.com/OCA/partner-contact/pull/238","diff_url":"https://github.com/OCA/partner-contact/pull/238.diff","patch_url":"https://github.com/OCA/partner-contact/pull/238.patch","issue_url":"https://api.github.com/repos/OCA/partner-contact/issues/238","number":238,"state":"open","locked":false,"title":"[9.0] [PORT] partner_firstname","user":{"login":"yvaucher","id":4158438,"avatar_url":"https://avatars.githubusercontent.com/u/4158438?v=3","gravatar_id":"","url":"https://api.github.com/users/yvaucher","html_url":"https://github.com/yvaucher","followers_url":"https://api.github.com/users/yvaucher/followers","following_url":"https://api.github.com/users/yvaucher/following{/other_user}","gists_url":"https://api.github.com/users/yvaucher/gists{/gist_id}","starred_url":"https://api.github.com/users/yvaucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvaucher/subscriptions","organizations_url":"https://api.github.com/users/yvaucher/orgs","repos_url":"https://api.github.com/users/yvaucher/repos","events_url":"https://api.github.com/users/yvaucher/events{/privacy}","received_events_url":"https://api.github.com/users/yvaucher/received_events","type":"User","site_admin":false},"body":"- Take history of module partner_firstname from 8.0\r\n- add missing authors\r\n- use reduced license header\r\n- move models in models directory\r\n- adapt views\r\n- show firstname, lastname only in edit mode\r\n- use company_type in views instead of is_company\r\n- adapt constraint on contacts\r\n- remove hack to make user editable\r\n- adapt check to accept invoicing or shipping address without name","created_at":"2016-01-13T12:14:34Z","updated_at":"2016-01-19T20:34:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"293ade3cdd02246e4a62022cc5f53bd75d9e39b7","assignee":null,"milestone":{"url":"https://api.github.com/repos/OCA/partner-contact/milestones/4","html_url":"https://github.com/OCA/partner-contact/milestones/9.0","labels_url":"https://api.github.com/repos/OCA/partner-contact/milestones/4/labels","id":1354371,"number":4,"title":"9.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":4,"state":"open","created_at":"2015-10-14T00:32:28Z","updated_at":"2016-01-19T18:14:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/partner-contact/pulls/238/commits","review_comments_url":"https://api.github.com/repos/OCA/partner-contact/pulls/238/comments","review_comment_url":"https://api.github.com/repos/OCA/partner-contact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/partner-contact/issues/238/comments","statuses_url":"https://api.github.com/repos/OCA/partner-contact/statuses/3c43fdc78fe5436b554b6f82caaa724b73c69d71","head":{"label":"yvaucher:9.0-port-partner-firstname","ref":"9.0-port-partner-firstname","sha":"3c43fdc78fe5436b554b6f82caaa724b73c69d71","user":{"login":"yvaucher","id":4158438,"avatar_url":"https://avatars.githubusercontent.com/u/4158438?v=3","gravatar_id":"","url":"https://api.github.com/users/yvaucher","html_url":"https://github.com/yvaucher","followers_url":"https://api.github.com/users/yvaucher/followers","following_url":"https://api.github.com/users/yvaucher/following{/other_user}","gists_url":"https://api.github.com/users/yvaucher/gists{/gist_id}","starred_url":"https://api.github.com/users/yvaucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvaucher/subscriptions","organizations_url":"https://api.github.com/users/yvaucher/orgs","repos_url":"https://api.github.com/users/yvaucher/repos","events_url":"https://api.github.com/users/yvaucher/events{/privacy}","received_events_url":"https://api.github.com/users/yvaucher/received_events","type":"User","site_admin":false},"repo":{"id":28082974,"name":"partner-contact","full_name":"yvaucher/partner-contact","owner":{"login":"yvaucher","id":4158438,"avatar_url":"https://avatars.githubusercontent.com/u/4158438?v=3","gravatar_id":"","url":"https://api.github.com/users/yvaucher","html_url":"https://github.com/yvaucher","followers_url":"https://api.github.com/users/yvaucher/followers","following_url":"https://api.github.com/users/yvaucher/following{/other_user}","gists_url":"https://api.github.com/users/yvaucher/gists{/gist_id}","starred_url":"https://api.github.com/users/yvaucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvaucher/subscriptions","organizations_url":"https://api.github.com/users/yvaucher/orgs","repos_url":"https://api.github.com/users/yvaucher/repos","events_url":"https://api.github.com/users/yvaucher/events{/privacy}","received_events_url":"https://api.github.com/users/yvaucher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yvaucher/partner-contact","description":"","fork":true,"url":"https://api.github.com/repos/yvaucher/partner-contact","forks_url":"https://api.github.com/repos/yvaucher/partner-contact/forks","keys_url":"https://api.github.com/repos/yvaucher/partner-contact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yvaucher/partner-contact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yvaucher/partner-contact/teams","hooks_url":"https://api.github.com/repos/yvaucher/partner-contact/hooks","issue_events_url":"https://api.github.com/repos/yvaucher/partner-contact/issues/events{/number}","events_url":"https://api.github.com/repos/yvaucher/partner-contact/events","assignees_url":"https://api.github.com/repos/yvaucher/partner-contact/assignees{/user}","branches_url":"https://api.github.com/repos/yvaucher/partner-contact/branches{/branch}","tags_url":"https://api.github.com/repos/yvaucher/partner-contact/tags","blobs_url":"https://api.github.com/repos/yvaucher/partner-contact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yvaucher/partner-contact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yvaucher/partner-contact/git/refs{/sha}","trees_url":"https://api.github.com/repos/yvaucher/partner-contact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yvaucher/partner-contact/statuses/{sha}","languages_url":"https://api.github.com/repos/yvaucher/partner-contact/languages","stargazers_url":"https://api.github.com/repos/yvaucher/partner-contact/stargazers","contributors_url":"https://api.github.com/repos/yvaucher/partner-contact/contributors","subscribers_url":"https://api.github.com/repos/yvaucher/partner-contact/subscribers","subscription_url":"https://api.github.com/repos/yvaucher/partner-contact/subscription","commits_url":"https://api.github.com/repos/yvaucher/partner-contact/commits{/sha}","git_commits_url":"https://api.github.com/repos/yvaucher/partner-contact/git/commits{/sha}","comments_url":"https://api.github.com/repos/yvaucher/partner-contact/comments{/number}","issue_comment_url":"https://api.github.com/repos/yvaucher/partner-contact/issues/comments{/number}","contents_url":"https://api.github.com/repos/yvaucher/partner-contact/contents/{+path}","compare_url":"https://api.github.com/repos/yvaucher/partner-contact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yvaucher/partner-contact/merges","archive_url":"https://api.github.com/repos/yvaucher/partner-contact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yvaucher/partner-contact/downloads","issues_url":"https://api.github.com/repos/yvaucher/partner-contact/issues{/number}","pulls_url":"https://api.github.com/repos/yvaucher/partner-contact/pulls{/number}","milestones_url":"https://api.github.com/repos/yvaucher/partner-contact/milestones{/number}","notifications_url":"https://api.github.com/repos/yvaucher/partner-contact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yvaucher/partner-contact/labels{/name}","releases_url":"https://api.github.com/repos/yvaucher/partner-contact/releases{/id}","created_at":"2014-12-16T10:55:45Z","updated_at":"2015-02-06T14:52:27Z","pushed_at":"2016-01-19T18:01:09Z","git_url":"git://github.com/yvaucher/partner-contact.git","ssh_url":"git@github.com:yvaucher/partner-contact.git","clone_url":"https://github.com/yvaucher/partner-contact.git","svn_url":"https://github.com/yvaucher/partner-contact","homepage":null,"size":1272,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.0"}},"base":{"label":"OCA:9.0","ref":"9.0","sha":"3398e80890c1e14aa3131baad1a5bf6f9ed6a96b","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20922147,"name":"partner-contact","full_name":"OCA/partner-contact","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/partner-contact","description":"Odoo Partner and Contact related addons","fork":false,"url":"https://api.github.com/repos/OCA/partner-contact","forks_url":"https://api.github.com/repos/OCA/partner-contact/forks","keys_url":"https://api.github.com/repos/OCA/partner-contact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/partner-contact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/partner-contact/teams","hooks_url":"https://api.github.com/repos/OCA/partner-contact/hooks","issue_events_url":"https://api.github.com/repos/OCA/partner-contact/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/partner-contact/events","assignees_url":"https://api.github.com/repos/OCA/partner-contact/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/partner-contact/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/partner-contact/tags","blobs_url":"https://api.github.com/repos/OCA/partner-contact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/partner-contact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/partner-contact/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/partner-contact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/partner-contact/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/partner-contact/languages","stargazers_url":"https://api.github.com/repos/OCA/partner-contact/stargazers","contributors_url":"https://api.github.com/repos/OCA/partner-contact/contributors","subscribers_url":"https://api.github.com/repos/OCA/partner-contact/subscribers","subscription_url":"https://api.github.com/repos/OCA/partner-contact/subscription","commits_url":"https://api.github.com/repos/OCA/partner-contact/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/partner-contact/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/partner-contact/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/partner-contact/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/partner-contact/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/partner-contact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/partner-contact/merges","archive_url":"https://api.github.com/repos/OCA/partner-contact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/partner-contact/downloads","issues_url":"https://api.github.com/repos/OCA/partner-contact/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/partner-contact/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/partner-contact/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/partner-contact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/partner-contact/labels{/name}","releases_url":"https://api.github.com/repos/OCA/partner-contact/releases{/id}","created_at":"2014-06-17T12:19:26Z","updated_at":"2016-01-14T11:06:06Z","pushed_at":"2016-01-19T18:01:09Z","git_url":"git://github.com/OCA/partner-contact.git","ssh_url":"git@github.com:OCA/partner-contact.git","clone_url":"https://github.com/OCA/partner-contact.git","svn_url":"https://github.com/OCA/partner-contact","homepage":"","size":3591,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":43,"forks":132,"open_issues":43,"watchers":34,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/238"},"html":{"href":"https://github.com/OCA/partner-contact/pull/238"},"issue":{"href":"https://api.github.com/repos/OCA/partner-contact/issues/238"},"comments":{"href":"https://api.github.com/repos/OCA/partner-contact/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/partner-contact/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/partner-contact/statuses/3c43fdc78fe5436b554b6f82caaa724b73c69d71"}}}}