{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/bake/pulls/comments/54608191","id":54608191,"diff_hunk":"@@ -446,6 +446,25 @@ public function testBakeIndex()\n     }\n \n     /**\n+     * test bake template with index limit overwrite\n+     *\n+     * @return void\n+     */\n+    public function testBakeIndexWithIndexLimit()\n+    {\n+        $this->Task->controllerName = 'TemplateTaskComments';\n+        $this->Task->modelName = 'TemplateTaskComments';\n+        $this->Task->controllerClass = __NAMESPACE__ . '\\TemplateTaskCommentsController';\n+        $this->Task->params['indexColumns'] = 3;","path":"tests/TestCase/Shell/Task/TemplateTaskTest.php","position":13,"original_position":13,"commit_id":"91ab859da18adad97c1ca330c68bca8ae350245a","original_commit_id":"91ab859da18adad97c1ca330c68bca8ae350245a","user":{"login":"HavokInspiration","id":5243386,"avatar_url":"https://avatars.githubusercontent.com/u/5243386?v=3","gravatar_id":"","url":"https://api.github.com/users/HavokInspiration","html_url":"https://github.com/HavokInspiration","followers_url":"https://api.github.com/users/HavokInspiration/followers","following_url":"https://api.github.com/users/HavokInspiration/following{/other_user}","gists_url":"https://api.github.com/users/HavokInspiration/gists{/gist_id}","starred_url":"https://api.github.com/users/HavokInspiration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HavokInspiration/subscriptions","organizations_url":"https://api.github.com/users/HavokInspiration/orgs","repos_url":"https://api.github.com/users/HavokInspiration/repos","events_url":"https://api.github.com/users/HavokInspiration/events{/privacy}","received_events_url":"https://api.github.com/users/HavokInspiration/received_events","type":"User","site_admin":false},"body":"Yes I completely agree with you.\r\nI believe it's a just a mistake that was not caught because the tests pass since it's written the same both in the test and in the code. \r\nIt should be ``index-columns`` and it will work as expected.","created_at":"2016-03-01T18:08:48Z","updated_at":"2016-03-01T18:08:48Z","html_url":"https://github.com/cakephp/bake/pull/172#discussion_r54608191","pull_request_url":"https://api.github.com/repos/cakephp/bake/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/cakephp/bake/pulls/comments/54608191"},"html":{"href":"https://github.com/cakephp/bake/pull/172#discussion_r54608191"},"pull_request":{"href":"https://api.github.com/repos/cakephp/bake/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/cakephp/bake/pulls/172","id":49351395,"html_url":"https://github.com/cakephp/bake/pull/172","diff_url":"https://github.com/cakephp/bake/pull/172.diff","patch_url":"https://github.com/cakephp/bake/pull/172.patch","issue_url":"https://api.github.com/repos/cakephp/bake/issues/172","number":172,"state":"open","locked":false,"title":"Implementation of Index Column Limitation (Closes #65)","user":{"login":"DSchalla","id":5972329,"avatar_url":"https://avatars.githubusercontent.com/u/5972329?v=3","gravatar_id":"","url":"https://api.github.com/users/DSchalla","html_url":"https://github.com/DSchalla","followers_url":"https://api.github.com/users/DSchalla/followers","following_url":"https://api.github.com/users/DSchalla/following{/other_user}","gists_url":"https://api.github.com/users/DSchalla/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchalla/subscriptions","organizations_url":"https://api.github.com/users/DSchalla/orgs","repos_url":"https://api.github.com/users/DSchalla/repos","events_url":"https://api.github.com/users/DSchalla/events{/privacy}","received_events_url":"https://api.github.com/users/DSchalla/received_events","type":"User","site_admin":false},"body":"As discussed in #65, this PR implements a flag to set the index number limitation to any value while keeping the default value of 7. \r\n\r\nI would welcome any feedback regarding the implementation + tests, I am uncertain whether its the \"best practice\".","created_at":"2015-10-31T15:14:50Z","updated_at":"2016-03-01T18:08:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6cdbb19282b08399571fee56cc025e9837cae9e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/bake/pulls/172/commits","review_comments_url":"https://api.github.com/repos/cakephp/bake/pulls/172/comments","review_comment_url":"https://api.github.com/repos/cakephp/bake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/bake/issues/172/comments","statuses_url":"https://api.github.com/repos/cakephp/bake/statuses/91ab859da18adad97c1ca330c68bca8ae350245a","head":{"label":"DSchalla:index-columns","ref":"index-columns","sha":"91ab859da18adad97c1ca330c68bca8ae350245a","user":{"login":"DSchalla","id":5972329,"avatar_url":"https://avatars.githubusercontent.com/u/5972329?v=3","gravatar_id":"","url":"https://api.github.com/users/DSchalla","html_url":"https://github.com/DSchalla","followers_url":"https://api.github.com/users/DSchalla/followers","following_url":"https://api.github.com/users/DSchalla/following{/other_user}","gists_url":"https://api.github.com/users/DSchalla/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchalla/subscriptions","organizations_url":"https://api.github.com/users/DSchalla/orgs","repos_url":"https://api.github.com/users/DSchalla/repos","events_url":"https://api.github.com/users/DSchalla/events{/privacy}","received_events_url":"https://api.github.com/users/DSchalla/received_events","type":"User","site_admin":false},"repo":{"id":28574234,"name":"bake","full_name":"DSchalla/bake","owner":{"login":"DSchalla","id":5972329,"avatar_url":"https://avatars.githubusercontent.com/u/5972329?v=3","gravatar_id":"","url":"https://api.github.com/users/DSchalla","html_url":"https://github.com/DSchalla","followers_url":"https://api.github.com/users/DSchalla/followers","following_url":"https://api.github.com/users/DSchalla/following{/other_user}","gists_url":"https://api.github.com/users/DSchalla/gists{/gist_id}","starred_url":"https://api.github.com/users/DSchalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DSchalla/subscriptions","organizations_url":"https://api.github.com/users/DSchalla/orgs","repos_url":"https://api.github.com/users/DSchalla/repos","events_url":"https://api.github.com/users/DSchalla/events{/privacy}","received_events_url":"https://api.github.com/users/DSchalla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DSchalla/bake","description":"The Bake Command Plugin","fork":true,"url":"https://api.github.com/repos/DSchalla/bake","forks_url":"https://api.github.com/repos/DSchalla/bake/forks","keys_url":"https://api.github.com/repos/DSchalla/bake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DSchalla/bake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DSchalla/bake/teams","hooks_url":"https://api.github.com/repos/DSchalla/bake/hooks","issue_events_url":"https://api.github.com/repos/DSchalla/bake/issues/events{/number}","events_url":"https://api.github.com/repos/DSchalla/bake/events","assignees_url":"https://api.github.com/repos/DSchalla/bake/assignees{/user}","branches_url":"https://api.github.com/repos/DSchalla/bake/branches{/branch}","tags_url":"https://api.github.com/repos/DSchalla/bake/tags","blobs_url":"https://api.github.com/repos/DSchalla/bake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DSchalla/bake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DSchalla/bake/git/refs{/sha}","trees_url":"https://api.github.com/repos/DSchalla/bake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DSchalla/bake/statuses/{sha}","languages_url":"https://api.github.com/repos/DSchalla/bake/languages","stargazers_url":"https://api.github.com/repos/DSchalla/bake/stargazers","contributors_url":"https://api.github.com/repos/DSchalla/bake/contributors","subscribers_url":"https://api.github.com/repos/DSchalla/bake/subscribers","subscription_url":"https://api.github.com/repos/DSchalla/bake/subscription","commits_url":"https://api.github.com/repos/DSchalla/bake/commits{/sha}","git_commits_url":"https://api.github.com/repos/DSchalla/bake/git/commits{/sha}","comments_url":"https://api.github.com/repos/DSchalla/bake/comments{/number}","issue_comment_url":"https://api.github.com/repos/DSchalla/bake/issues/comments{/number}","contents_url":"https://api.github.com/repos/DSchalla/bake/contents/{+path}","compare_url":"https://api.github.com/repos/DSchalla/bake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DSchalla/bake/merges","archive_url":"https://api.github.com/repos/DSchalla/bake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DSchalla/bake/downloads","issues_url":"https://api.github.com/repos/DSchalla/bake/issues{/number}","pulls_url":"https://api.github.com/repos/DSchalla/bake/pulls{/number}","milestones_url":"https://api.github.com/repos/DSchalla/bake/milestones{/number}","notifications_url":"https://api.github.com/repos/DSchalla/bake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DSchalla/bake/labels{/name}","releases_url":"https://api.github.com/repos/DSchalla/bake/releases{/id}","deployments_url":"https://api.github.com/repos/DSchalla/bake/deployments","created_at":"2014-12-28T23:37:28Z","updated_at":"2015-01-15T22:16:38Z","pushed_at":"2016-02-29T19:55:31Z","git_url":"git://github.com/DSchalla/bake.git","ssh_url":"git@github.com:DSchalla/bake.git","clone_url":"https://github.com/DSchalla/bake.git","svn_url":"https://github.com/DSchalla/bake","homepage":null,"size":4060,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"702c5720599d6cd4f48d4168ad7fe595777aac3a","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":27730883,"name":"bake","full_name":"cakephp/bake","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/bake","description":"The Bake Command Plugin","fork":false,"url":"https://api.github.com/repos/cakephp/bake","forks_url":"https://api.github.com/repos/cakephp/bake/forks","keys_url":"https://api.github.com/repos/cakephp/bake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/bake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/bake/teams","hooks_url":"https://api.github.com/repos/cakephp/bake/hooks","issue_events_url":"https://api.github.com/repos/cakephp/bake/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/bake/events","assignees_url":"https://api.github.com/repos/cakephp/bake/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/bake/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/bake/tags","blobs_url":"https://api.github.com/repos/cakephp/bake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/bake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/bake/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/bake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/bake/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/bake/languages","stargazers_url":"https://api.github.com/repos/cakephp/bake/stargazers","contributors_url":"https://api.github.com/repos/cakephp/bake/contributors","subscribers_url":"https://api.github.com/repos/cakephp/bake/subscribers","subscription_url":"https://api.github.com/repos/cakephp/bake/subscription","commits_url":"https://api.github.com/repos/cakephp/bake/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/bake/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/bake/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/bake/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/bake/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/bake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/bake/merges","archive_url":"https://api.github.com/repos/cakephp/bake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/bake/downloads","issues_url":"https://api.github.com/repos/cakephp/bake/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/bake/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/bake/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/bake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/bake/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/bake/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/bake/deployments","created_at":"2014-12-08T19:22:54Z","updated_at":"2016-02-12T16:40:42Z","pushed_at":"2016-03-01T16:24:04Z","git_url":"git://github.com/cakephp/bake.git","ssh_url":"git@github.com:cakephp/bake.git","clone_url":"https://github.com/cakephp/bake.git","svn_url":"https://github.com/cakephp/bake","homepage":null,"size":4137,"stargazers_count":36,"watchers_count":36,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":20,"forks":37,"open_issues":20,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/bake/pulls/172"},"html":{"href":"https://github.com/cakephp/bake/pull/172"},"issue":{"href":"https://api.github.com/repos/cakephp/bake/issues/172"},"comments":{"href":"https://api.github.com/repos/cakephp/bake/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/bake/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/bake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/bake/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/bake/statuses/91ab859da18adad97c1ca330c68bca8ae350245a"}}}}