{"action":"opened","number":94,"pull_request":{"url":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/94","id":67571286,"html_url":"https://github.com/legacysurvey/legacypipe/pull/94","diff_url":"https://github.com/legacysurvey/legacypipe/pull/94.diff","patch_url":"https://github.com/legacysurvey/legacypipe/pull/94.patch","issue_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues/94","number":94,"state":"open","locked":false,"title":"allows processing of Bok images, tested by looking at resulting model images, looks reasonable for decam,mosaic, and bok ","user":{"login":"kaylanb","id":5062170,"avatar_url":"https://avatars.githubusercontent.com/u/5062170?v=3","gravatar_id":"","url":"https://api.github.com/users/kaylanb","html_url":"https://github.com/kaylanb","followers_url":"https://api.github.com/users/kaylanb/followers","following_url":"https://api.github.com/users/kaylanb/following{/other_user}","gists_url":"https://api.github.com/users/kaylanb/gists{/gist_id}","starred_url":"https://api.github.com/users/kaylanb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaylanb/subscriptions","organizations_url":"https://api.github.com/users/kaylanb/orgs","repos_url":"https://api.github.com/users/kaylanb/repos","events_url":"https://api.github.com/users/kaylanb/events{/privacy}","received_events_url":"https://api.github.com/users/kaylanb/received_events","type":"User","site_admin":false},"body":"I merged master into my Bok branch, fixed conflicts, tested still works, pushed to github, and made this pull request. I was able to run on any combination of decam, mosaic, bok, ptf images with this version. There are four main updates, listed in priority order.\r\n\r\n1) zeropoints: Bok and Mosaic do NOT need exptime correction in legacypipe code, but Decam does. I think zpt+= 2.5log10(exptime) should be handled by the ccds.fits file since zeropoints, etc. are already calculated separately with Decstat, Mosstat, Bokstat etc.\r\n2) photometic cuts currently NOT done for 90prime because \"abs(zpt -\r\n ccd zpt) > 0.1\" would reject all 90prime images\r\n3) get_ccds() function now ensures no whitespaces lead or trail ccds.camera names. This makes Tractor MUCH more robust since many if/else statements involve camera = 'decam','mosaic','90prime', etc. \r\n4) telescope naming convention: \"90prime\" for bok, \"decam\" for decam, \"mosaic\" for mosaic, and \"ptf\" for ptf","created_at":"2016-04-22T20:51:56Z","updated_at":"2016-04-22T20:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5d2e8e6b43cb2d80070d4a322b45d160f00d603","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/94/commits","review_comments_url":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/94/comments","review_comment_url":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues/94/comments","statuses_url":"https://api.github.com/repos/legacysurvey/legacypipe/statuses/5c8fcfb101354351d346f93a2f62d547fc203305","head":{"label":"legacysurvey:bok","ref":"bok","sha":"5c8fcfb101354351d346f93a2f62d547fc203305","user":{"login":"legacysurvey","id":13069388,"avatar_url":"https://avatars.githubusercontent.com/u/13069388?v=3","gravatar_id":"","url":"https://api.github.com/users/legacysurvey","html_url":"https://github.com/legacysurvey","followers_url":"https://api.github.com/users/legacysurvey/followers","following_url":"https://api.github.com/users/legacysurvey/following{/other_user}","gists_url":"https://api.github.com/users/legacysurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/legacysurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legacysurvey/subscriptions","organizations_url":"https://api.github.com/users/legacysurvey/orgs","repos_url":"https://api.github.com/users/legacysurvey/repos","events_url":"https://api.github.com/users/legacysurvey/events{/privacy}","received_events_url":"https://api.github.com/users/legacysurvey/received_events","type":"Organization","site_admin":false},"repo":{"id":38130179,"name":"legacypipe","full_name":"legacysurvey/legacypipe","owner":{"login":"legacysurvey","id":13069388,"avatar_url":"https://avatars.githubusercontent.com/u/13069388?v=3","gravatar_id":"","url":"https://api.github.com/users/legacysurvey","html_url":"https://github.com/legacysurvey","followers_url":"https://api.github.com/users/legacysurvey/followers","following_url":"https://api.github.com/users/legacysurvey/following{/other_user}","gists_url":"https://api.github.com/users/legacysurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/legacysurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legacysurvey/subscriptions","organizations_url":"https://api.github.com/users/legacysurvey/orgs","repos_url":"https://api.github.com/users/legacysurvey/repos","events_url":"https://api.github.com/users/legacysurvey/events{/privacy}","received_events_url":"https://api.github.com/users/legacysurvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/legacysurvey/legacypipe","description":"Our image reduction pipeline, using the Tractor framework","fork":false,"url":"https://api.github.com/repos/legacysurvey/legacypipe","forks_url":"https://api.github.com/repos/legacysurvey/legacypipe/forks","keys_url":"https://api.github.com/repos/legacysurvey/legacypipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legacysurvey/legacypipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legacysurvey/legacypipe/teams","hooks_url":"https://api.github.com/repos/legacysurvey/legacypipe/hooks","issue_events_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues/events{/number}","events_url":"https://api.github.com/repos/legacysurvey/legacypipe/events","assignees_url":"https://api.github.com/repos/legacysurvey/legacypipe/assignees{/user}","branches_url":"https://api.github.com/repos/legacysurvey/legacypipe/branches{/branch}","tags_url":"https://api.github.com/repos/legacysurvey/legacypipe/tags","blobs_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legacysurvey/legacypipe/statuses/{sha}","languages_url":"https://api.github.com/repos/legacysurvey/legacypipe/languages","stargazers_url":"https://api.github.com/repos/legacysurvey/legacypipe/stargazers","contributors_url":"https://api.github.com/repos/legacysurvey/legacypipe/contributors","subscribers_url":"https://api.github.com/repos/legacysurvey/legacypipe/subscribers","subscription_url":"https://api.github.com/repos/legacysurvey/legacypipe/subscription","commits_url":"https://api.github.com/repos/legacysurvey/legacypipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/legacysurvey/legacypipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/legacysurvey/legacypipe/contents/{+path}","compare_url":"https://api.github.com/repos/legacysurvey/legacypipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legacysurvey/legacypipe/merges","archive_url":"https://api.github.com/repos/legacysurvey/legacypipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legacysurvey/legacypipe/downloads","issues_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues{/number}","pulls_url":"https://api.github.com/repos/legacysurvey/legacypipe/pulls{/number}","milestones_url":"https://api.github.com/repos/legacysurvey/legacypipe/milestones{/number}","notifications_url":"https://api.github.com/repos/legacysurvey/legacypipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legacysurvey/legacypipe/labels{/name}","releases_url":"https://api.github.com/repos/legacysurvey/legacypipe/releases{/id}","deployments_url":"https://api.github.com/repos/legacysurvey/legacypipe/deployments","created_at":"2015-06-26T19:40:29Z","updated_at":"2016-02-02T00:25:35Z","pushed_at":"2016-04-22T20:51:57Z","git_url":"git://github.com/legacysurvey/legacypipe.git","ssh_url":"git@github.com:legacysurvey/legacypipe.git","clone_url":"https://github.com/legacysurvey/legacypipe.git","svn_url":"https://github.com/legacysurvey/legacypipe","homepage":null,"size":34845,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":39,"forks":5,"open_issues":39,"watchers":5,"default_branch":"master"}},"base":{"label":"legacysurvey:master","ref":"master","sha":"8d9fce50bf0041cbce96ad66553a8b9482af55bb","user":{"login":"legacysurvey","id":13069388,"avatar_url":"https://avatars.githubusercontent.com/u/13069388?v=3","gravatar_id":"","url":"https://api.github.com/users/legacysurvey","html_url":"https://github.com/legacysurvey","followers_url":"https://api.github.com/users/legacysurvey/followers","following_url":"https://api.github.com/users/legacysurvey/following{/other_user}","gists_url":"https://api.github.com/users/legacysurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/legacysurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legacysurvey/subscriptions","organizations_url":"https://api.github.com/users/legacysurvey/orgs","repos_url":"https://api.github.com/users/legacysurvey/repos","events_url":"https://api.github.com/users/legacysurvey/events{/privacy}","received_events_url":"https://api.github.com/users/legacysurvey/received_events","type":"Organization","site_admin":false},"repo":{"id":38130179,"name":"legacypipe","full_name":"legacysurvey/legacypipe","owner":{"login":"legacysurvey","id":13069388,"avatar_url":"https://avatars.githubusercontent.com/u/13069388?v=3","gravatar_id":"","url":"https://api.github.com/users/legacysurvey","html_url":"https://github.com/legacysurvey","followers_url":"https://api.github.com/users/legacysurvey/followers","following_url":"https://api.github.com/users/legacysurvey/following{/other_user}","gists_url":"https://api.github.com/users/legacysurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/legacysurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legacysurvey/subscriptions","organizations_url":"https://api.github.com/users/legacysurvey/orgs","repos_url":"https://api.github.com/users/legacysurvey/repos","events_url":"https://api.github.com/users/legacysurvey/events{/privacy}","received_events_url":"https://api.github.com/users/legacysurvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/legacysurvey/legacypipe","description":"Our image reduction pipeline, using the Tractor framework","fork":false,"url":"https://api.github.com/repos/legacysurvey/legacypipe","forks_url":"https://api.github.com/repos/legacysurvey/legacypipe/forks","keys_url":"https://api.github.com/repos/legacysurvey/legacypipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legacysurvey/legacypipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legacysurvey/legacypipe/teams","hooks_url":"https://api.github.com/repos/legacysurvey/legacypipe/hooks","issue_events_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues/events{/number}","events_url":"https://api.github.com/repos/legacysurvey/legacypipe/events","assignees_url":"https://api.github.com/repos/legacysurvey/legacypipe/assignees{/user}","branches_url":"https://api.github.com/repos/legacysurvey/legacypipe/branches{/branch}","tags_url":"https://api.github.com/repos/legacysurvey/legacypipe/tags","blobs_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legacysurvey/legacypipe/statuses/{sha}","languages_url":"https://api.github.com/repos/legacysurvey/legacypipe/languages","stargazers_url":"https://api.github.com/repos/legacysurvey/legacypipe/stargazers","contributors_url":"https://api.github.com/repos/legacysurvey/legacypipe/contributors","subscribers_url":"https://api.github.com/repos/legacysurvey/legacypipe/subscribers","subscription_url":"https://api.github.com/repos/legacysurvey/legacypipe/subscription","commits_url":"https://api.github.com/repos/legacysurvey/legacypipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/legacysurvey/legacypipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/legacysurvey/legacypipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/legacysurvey/legacypipe/contents/{+path}","compare_url":"https://api.github.com/repos/legacysurvey/legacypipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legacysurvey/legacypipe/merges","archive_url":"https://api.github.com/repos/legacysurvey/legacypipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legacysurvey/legacypipe/downloads","issues_url":"https://api.github.com/repos/legacysurvey/legacypipe/issues{/number}","pulls_url":"https://api.github.com/repos/legacysurvey/legacypipe/pulls{/number}","milestones_url":"https://api.github.com/repos/legacysurvey/legacypipe/milestones{/number}","notifications_url":"https://api.github.com/repos/legacysurvey/legacypipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legacysurvey/legacypipe/labels{/name}","releases_url":"https://api.github.com/repos/legacysurvey/legacypipe/releases{/id}","deployments_url":"https://api.github.com/repos/legacysurvey/legacypipe/deployments","created_at":"2015-06-26T19:40:29Z","updated_at":"2016-02-02T00:25:35Z","pushed_at":"2016-04-22T20:51:57Z","git_url":"git://github.com/legacysurvey/legacypipe.git","ssh_url":"git@github.com:legacysurvey/legacypipe.git","clone_url":"https://github.com/legacysurvey/legacypipe.git","svn_url":"https://github.com/legacysurvey/legacypipe","homepage":null,"size":34845,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":39,"forks":5,"open_issues":39,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/94"},"html":{"href":"https://github.com/legacysurvey/legacypipe/pull/94"},"issue":{"href":"https://api.github.com/repos/legacysurvey/legacypipe/issues/94"},"comments":{"href":"https://api.github.com/repos/legacysurvey/legacypipe/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/legacysurvey/legacypipe/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/legacysurvey/legacypipe/statuses/5c8fcfb101354351d346f93a2f62d547fc203305"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":10,"additions":576,"deletions":113,"changed_files":6}}