{"action":"opened","number":94,"pull_request":{"url":"https://api.github.com/repos/poteto/ember-crumbly/pulls/94","id":85829305,"html_url":"https://github.com/poteto/ember-crumbly/pull/94","diff_url":"https://github.com/poteto/ember-crumbly/pull/94.diff","patch_url":"https://github.com/poteto/ember-crumbly/pull/94.patch","issue_url":"https://api.github.com/repos/poteto/ember-crumbly/issues/94","number":94,"state":"open","locked":false,"title":"Crumply disables links when you redirect to another route","user":{"login":"samdemaeyer","id":7160913,"avatar_url":"https://avatars.githubusercontent.com/u/7160913?v=3","gravatar_id":"","url":"https://api.github.com/users/samdemaeyer","html_url":"https://github.com/samdemaeyer","followers_url":"https://api.github.com/users/samdemaeyer/followers","following_url":"https://api.github.com/users/samdemaeyer/following{/other_user}","gists_url":"https://api.github.com/users/samdemaeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/samdemaeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdemaeyer/subscriptions","organizations_url":"https://api.github.com/users/samdemaeyer/orgs","repos_url":"https://api.github.com/users/samdemaeyer/repos","events_url":"https://api.github.com/users/samdemaeyer/events{/privacy}","received_events_url":"https://api.github.com/users/samdemaeyer/received_events","type":"User","site_admin":false},"body":"### ⚠️ Bug in bread-crumbs ⚠️ \r\n\r\n#### I have added a failing test to illustrate the problem. It was working with version 1.0.2 fine.\r\n\r\nI think the problem is in here: https://github.com/poteto/ember-crumbly/blob/master/addon/components/bread-crumbs.js#L96-L99\r\n\r\n### Explanation\r\nWhen we enter a route, the last segment is not linkable. If then we transition to a child route, since a moment ago on the route the `linkable` property was set to `false`, than both the last segment and the parent one are not linkable.\r\n\r\n### Example:\r\n`/home/level1/level2`\r\n - `home` => link\r\n - `level1` => link\r\n - `level2` => no link\r\n\r\nWhen I click on a link that redirects to the `level3` route, the following happens:  \r\n\r\n`/home/level1/level2/level3`\r\n - `home` => link\r\n - `level1` => link\r\n - `level2` => no link\r\n - `level3` => no link\r\n\r\n`level2` was set before to not be a link and it stays this way. It should be a link though.","created_at":"2016-09-19T16:49:03Z","updated_at":"2016-09-19T16:49:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/poteto/ember-crumbly/pulls/94/commits","review_comments_url":"https://api.github.com/repos/poteto/ember-crumbly/pulls/94/comments","review_comment_url":"https://api.github.com/repos/poteto/ember-crumbly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poteto/ember-crumbly/issues/94/comments","statuses_url":"https://api.github.com/repos/poteto/ember-crumbly/statuses/ac6d106efd5f468725ebb72da99e4c6ff09f2716","head":{"label":"samdemaeyer:create-failing-test","ref":"create-failing-test","sha":"ac6d106efd5f468725ebb72da99e4c6ff09f2716","user":{"login":"samdemaeyer","id":7160913,"avatar_url":"https://avatars.githubusercontent.com/u/7160913?v=3","gravatar_id":"","url":"https://api.github.com/users/samdemaeyer","html_url":"https://github.com/samdemaeyer","followers_url":"https://api.github.com/users/samdemaeyer/followers","following_url":"https://api.github.com/users/samdemaeyer/following{/other_user}","gists_url":"https://api.github.com/users/samdemaeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/samdemaeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdemaeyer/subscriptions","organizations_url":"https://api.github.com/users/samdemaeyer/orgs","repos_url":"https://api.github.com/users/samdemaeyer/repos","events_url":"https://api.github.com/users/samdemaeyer/events{/privacy}","received_events_url":"https://api.github.com/users/samdemaeyer/received_events","type":"User","site_admin":false},"repo":{"id":68620549,"name":"ember-crumbly","full_name":"samdemaeyer/ember-crumbly","owner":{"login":"samdemaeyer","id":7160913,"avatar_url":"https://avatars.githubusercontent.com/u/7160913?v=3","gravatar_id":"","url":"https://api.github.com/users/samdemaeyer","html_url":"https://github.com/samdemaeyer","followers_url":"https://api.github.com/users/samdemaeyer/followers","following_url":"https://api.github.com/users/samdemaeyer/following{/other_user}","gists_url":"https://api.github.com/users/samdemaeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/samdemaeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samdemaeyer/subscriptions","organizations_url":"https://api.github.com/users/samdemaeyer/orgs","repos_url":"https://api.github.com/users/samdemaeyer/repos","events_url":"https://api.github.com/users/samdemaeyer/events{/privacy}","received_events_url":"https://api.github.com/users/samdemaeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samdemaeyer/ember-crumbly","description":"Declarative breadcrumb navigation for Ember apps","fork":true,"url":"https://api.github.com/repos/samdemaeyer/ember-crumbly","forks_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/forks","keys_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/teams","hooks_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/hooks","issue_events_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/issues/events{/number}","events_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/events","assignees_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/assignees{/user}","branches_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/branches{/branch}","tags_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/tags","blobs_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/git/refs{/sha}","trees_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/statuses/{sha}","languages_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/languages","stargazers_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/stargazers","contributors_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/contributors","subscribers_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/subscribers","subscription_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/subscription","commits_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/commits{/sha}","git_commits_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/git/commits{/sha}","comments_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/comments{/number}","issue_comment_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/issues/comments{/number}","contents_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/contents/{+path}","compare_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/merges","archive_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/downloads","issues_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/issues{/number}","pulls_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/pulls{/number}","milestones_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/milestones{/number}","notifications_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/labels{/name}","releases_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/releases{/id}","deployments_url":"https://api.github.com/repos/samdemaeyer/ember-crumbly/deployments","created_at":"2016-09-19T15:45:32Z","updated_at":"2016-09-19T15:45:33Z","pushed_at":"2016-09-19T16:35:27Z","git_url":"git://github.com/samdemaeyer/ember-crumbly.git","ssh_url":"git@github.com:samdemaeyer/ember-crumbly.git","clone_url":"https://github.com/samdemaeyer/ember-crumbly.git","svn_url":"https://github.com/samdemaeyer/ember-crumbly","homepage":"","size":152,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"poteto:master","ref":"master","sha":"842a53e2f07a5acf393a900c921fc0c4c6d15e67","user":{"login":"poteto","id":1390709,"avatar_url":"https://avatars.githubusercontent.com/u/1390709?v=3","gravatar_id":"","url":"https://api.github.com/users/poteto","html_url":"https://github.com/poteto","followers_url":"https://api.github.com/users/poteto/followers","following_url":"https://api.github.com/users/poteto/following{/other_user}","gists_url":"https://api.github.com/users/poteto/gists{/gist_id}","starred_url":"https://api.github.com/users/poteto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poteto/subscriptions","organizations_url":"https://api.github.com/users/poteto/orgs","repos_url":"https://api.github.com/users/poteto/repos","events_url":"https://api.github.com/users/poteto/events{/privacy}","received_events_url":"https://api.github.com/users/poteto/received_events","type":"User","site_admin":false},"repo":{"id":36042369,"name":"ember-crumbly","full_name":"poteto/ember-crumbly","owner":{"login":"poteto","id":1390709,"avatar_url":"https://avatars.githubusercontent.com/u/1390709?v=3","gravatar_id":"","url":"https://api.github.com/users/poteto","html_url":"https://github.com/poteto","followers_url":"https://api.github.com/users/poteto/followers","following_url":"https://api.github.com/users/poteto/following{/other_user}","gists_url":"https://api.github.com/users/poteto/gists{/gist_id}","starred_url":"https://api.github.com/users/poteto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poteto/subscriptions","organizations_url":"https://api.github.com/users/poteto/orgs","repos_url":"https://api.github.com/users/poteto/repos","events_url":"https://api.github.com/users/poteto/events{/privacy}","received_events_url":"https://api.github.com/users/poteto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poteto/ember-crumbly","description":"Declarative breadcrumb navigation for Ember apps","fork":false,"url":"https://api.github.com/repos/poteto/ember-crumbly","forks_url":"https://api.github.com/repos/poteto/ember-crumbly/forks","keys_url":"https://api.github.com/repos/poteto/ember-crumbly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poteto/ember-crumbly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poteto/ember-crumbly/teams","hooks_url":"https://api.github.com/repos/poteto/ember-crumbly/hooks","issue_events_url":"https://api.github.com/repos/poteto/ember-crumbly/issues/events{/number}","events_url":"https://api.github.com/repos/poteto/ember-crumbly/events","assignees_url":"https://api.github.com/repos/poteto/ember-crumbly/assignees{/user}","branches_url":"https://api.github.com/repos/poteto/ember-crumbly/branches{/branch}","tags_url":"https://api.github.com/repos/poteto/ember-crumbly/tags","blobs_url":"https://api.github.com/repos/poteto/ember-crumbly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poteto/ember-crumbly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poteto/ember-crumbly/git/refs{/sha}","trees_url":"https://api.github.com/repos/poteto/ember-crumbly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poteto/ember-crumbly/statuses/{sha}","languages_url":"https://api.github.com/repos/poteto/ember-crumbly/languages","stargazers_url":"https://api.github.com/repos/poteto/ember-crumbly/stargazers","contributors_url":"https://api.github.com/repos/poteto/ember-crumbly/contributors","subscribers_url":"https://api.github.com/repos/poteto/ember-crumbly/subscribers","subscription_url":"https://api.github.com/repos/poteto/ember-crumbly/subscription","commits_url":"https://api.github.com/repos/poteto/ember-crumbly/commits{/sha}","git_commits_url":"https://api.github.com/repos/poteto/ember-crumbly/git/commits{/sha}","comments_url":"https://api.github.com/repos/poteto/ember-crumbly/comments{/number}","issue_comment_url":"https://api.github.com/repos/poteto/ember-crumbly/issues/comments{/number}","contents_url":"https://api.github.com/repos/poteto/ember-crumbly/contents/{+path}","compare_url":"https://api.github.com/repos/poteto/ember-crumbly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poteto/ember-crumbly/merges","archive_url":"https://api.github.com/repos/poteto/ember-crumbly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poteto/ember-crumbly/downloads","issues_url":"https://api.github.com/repos/poteto/ember-crumbly/issues{/number}","pulls_url":"https://api.github.com/repos/poteto/ember-crumbly/pulls{/number}","milestones_url":"https://api.github.com/repos/poteto/ember-crumbly/milestones{/number}","notifications_url":"https://api.github.com/repos/poteto/ember-crumbly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poteto/ember-crumbly/labels{/name}","releases_url":"https://api.github.com/repos/poteto/ember-crumbly/releases{/id}","deployments_url":"https://api.github.com/repos/poteto/ember-crumbly/deployments","created_at":"2015-05-21T23:33:41Z","updated_at":"2016-09-19T06:49:30Z","pushed_at":"2016-09-19T16:49:03Z","git_url":"git://github.com/poteto/ember-crumbly.git","ssh_url":"git@github.com:poteto/ember-crumbly.git","clone_url":"https://github.com/poteto/ember-crumbly.git","svn_url":"https://github.com/poteto/ember-crumbly","homepage":"","size":152,"stargazers_count":118,"watchers_count":118,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":27,"forks":33,"open_issues":27,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poteto/ember-crumbly/pulls/94"},"html":{"href":"https://github.com/poteto/ember-crumbly/pull/94"},"issue":{"href":"https://api.github.com/repos/poteto/ember-crumbly/issues/94"},"comments":{"href":"https://api.github.com/repos/poteto/ember-crumbly/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/poteto/ember-crumbly/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/poteto/ember-crumbly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poteto/ember-crumbly/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/poteto/ember-crumbly/statuses/ac6d106efd5f468725ebb72da99e4c6ff09f2716"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":21,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"samdemaeyer"}}