{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments/80816922","pull_request_review_id":1845153,"id":80816922,"diff_hunk":"@@ -0,0 +1,160 @@\n+/**\n+ * A bundle is a grouping of files which serve the need of one or more\n+ * entrypoint files.\n+ */\n+export interface IBundle {\n+  entrypoints: Set<URL>;\n+  files: Set<URL>;\n+}\n+\n+/**\n+ * A bundle strategy function is used to transform an array of bundles.\n+ */\n+export type IBundleStrategy = (bundles: IBundle[]) => IBundle[];\n+\n+/**\n+ * A mapping of URLs to their full set of transitive dependencies, such that\n+ * `a->b, b->c, b->d, e->f` would be represented `{a:[b,c,d], e:[f]}`\n+ */\n+export type IFileTransDepsIndex = Map<URL, Set<URL>>;\n+\n+/**\n+ * Defining this URL type to make it clear which strings represent URLs.","path":"src/bundle-manifest.ts","position":22,"original_position":22,"commit_id":"316b90ee3769f67c5875549bacc92550718b48f5","original_commit_id":"316b90ee3769f67c5875549bacc92550718b48f5","user":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2016-09-27T23:22:58Z","updated_at":"2016-09-27T23:22:58Z","html_url":"https://github.com/Polymer/vulcanize/pull/379#discussion_r80816922","pull_request_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/379","_links":{"self":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments/80816922"},"html":{"href":"https://github.com/Polymer/vulcanize/pull/379#discussion_r80816922"},"pull_request":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/379"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/vulcanize/pulls/379","id":87021890,"html_url":"https://github.com/Polymer/vulcanize/pull/379","diff_url":"https://github.com/Polymer/vulcanize/pull/379.diff","patch_url":"https://github.com/Polymer/vulcanize/pull/379.patch","issue_url":"https://api.github.com/repos/Polymer/vulcanize/issues/379","number":379,"state":"open","locked":false,"title":"Foundational work in the sharding logic for bundles.","user":{"login":"usergenic","id":578,"avatar_url":"https://avatars.githubusercontent.com/u/578?v=3","gravatar_id":"","url":"https://api.github.com/users/usergenic","html_url":"https://github.com/usergenic","followers_url":"https://api.github.com/users/usergenic/followers","following_url":"https://api.github.com/users/usergenic/following{/other_user}","gists_url":"https://api.github.com/users/usergenic/gists{/gist_id}","starred_url":"https://api.github.com/users/usergenic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usergenic/subscriptions","organizations_url":"https://api.github.com/users/usergenic/orgs","repos_url":"https://api.github.com/users/usergenic/repos","events_url":"https://api.github.com/users/usergenic/events{/privacy}","received_events_url":"https://api.github.com/users/usergenic/received_events","type":"User","site_admin":false},"body":"Note: this filename is `bundle-manifest` because these types/functions are working towards producing a BundleManifest object that will drive the Bundler's operations.  However, BundleManifest, is not yet implemented.\r\n\r\nI specifically excluded the BundleManifest implementation from the branch to ensure this layer of abstraction works on its own and makes sense on its own.  Notably missing here are URL-generation for bundles and the BundleManifest interface to lookup a Bundle by a constituent file.","created_at":"2016-09-27T22:09:50Z","updated_at":"2016-09-27T23:48:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec20ef56ae3267866943b624221a848fffe606b4","assignee":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},{"login":"garlicnation","id":1105965,"avatar_url":"https://avatars.githubusercontent.com/u/1105965?v=3","gravatar_id":"","url":"https://api.github.com/users/garlicnation","html_url":"https://github.com/garlicnation","followers_url":"https://api.github.com/users/garlicnation/followers","following_url":"https://api.github.com/users/garlicnation/following{/other_user}","gists_url":"https://api.github.com/users/garlicnation/gists{/gist_id}","starred_url":"https://api.github.com/users/garlicnation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garlicnation/subscriptions","organizations_url":"https://api.github.com/users/garlicnation/orgs","repos_url":"https://api.github.com/users/garlicnation/repos","events_url":"https://api.github.com/users/garlicnation/events{/privacy}","received_events_url":"https://api.github.com/users/garlicnation/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/379/commits","review_comments_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/379/comments","review_comment_url":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/vulcanize/issues/379/comments","statuses_url":"https://api.github.com/repos/Polymer/vulcanize/statuses/316b90ee3769f67c5875549bacc92550718b48f5","head":{"label":"Polymer:bundle-manifest","ref":"bundle-manifest","sha":"316b90ee3769f67c5875549bacc92550718b48f5","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":13599100,"name":"vulcanize","full_name":"Polymer/vulcanize","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/vulcanize","description":"Build tool for HTMLImports and Web Components","fork":false,"url":"https://api.github.com/repos/Polymer/vulcanize","forks_url":"https://api.github.com/repos/Polymer/vulcanize/forks","keys_url":"https://api.github.com/repos/Polymer/vulcanize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/vulcanize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/vulcanize/teams","hooks_url":"https://api.github.com/repos/Polymer/vulcanize/hooks","issue_events_url":"https://api.github.com/repos/Polymer/vulcanize/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/vulcanize/events","assignees_url":"https://api.github.com/repos/Polymer/vulcanize/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/vulcanize/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/vulcanize/tags","blobs_url":"https://api.github.com/repos/Polymer/vulcanize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/vulcanize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/vulcanize/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/vulcanize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/vulcanize/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/vulcanize/languages","stargazers_url":"https://api.github.com/repos/Polymer/vulcanize/stargazers","contributors_url":"https://api.github.com/repos/Polymer/vulcanize/contributors","subscribers_url":"https://api.github.com/repos/Polymer/vulcanize/subscribers","subscription_url":"https://api.github.com/repos/Polymer/vulcanize/subscription","commits_url":"https://api.github.com/repos/Polymer/vulcanize/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/vulcanize/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/vulcanize/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/vulcanize/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/vulcanize/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/vulcanize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/vulcanize/merges","archive_url":"https://api.github.com/repos/Polymer/vulcanize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/vulcanize/downloads","issues_url":"https://api.github.com/repos/Polymer/vulcanize/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/vulcanize/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/vulcanize/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/vulcanize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/vulcanize/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/vulcanize/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/vulcanize/deployments","created_at":"2013-10-15T18:56:20Z","updated_at":"2016-09-26T07:35:18Z","pushed_at":"2016-09-27T22:09:50Z","git_url":"git://github.com/Polymer/vulcanize.git","ssh_url":"git@github.com:Polymer/vulcanize.git","clone_url":"https://github.com/Polymer/vulcanize.git","svn_url":"https://github.com/Polymer/vulcanize","homepage":"","size":1150,"stargazers_count":1113,"watchers_count":1113,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":84,"forks":115,"open_issues":84,"watchers":1113,"default_branch":"master"}},"base":{"label":"Polymer:v3","ref":"v3","sha":"4b8428d5a3ac7a6e6986a0f58016225daadfa58c","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":13599100,"name":"vulcanize","full_name":"Polymer/vulcanize","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/vulcanize","description":"Build tool for HTMLImports and Web Components","fork":false,"url":"https://api.github.com/repos/Polymer/vulcanize","forks_url":"https://api.github.com/repos/Polymer/vulcanize/forks","keys_url":"https://api.github.com/repos/Polymer/vulcanize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/vulcanize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/vulcanize/teams","hooks_url":"https://api.github.com/repos/Polymer/vulcanize/hooks","issue_events_url":"https://api.github.com/repos/Polymer/vulcanize/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/vulcanize/events","assignees_url":"https://api.github.com/repos/Polymer/vulcanize/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/vulcanize/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/vulcanize/tags","blobs_url":"https://api.github.com/repos/Polymer/vulcanize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/vulcanize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/vulcanize/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/vulcanize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/vulcanize/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/vulcanize/languages","stargazers_url":"https://api.github.com/repos/Polymer/vulcanize/stargazers","contributors_url":"https://api.github.com/repos/Polymer/vulcanize/contributors","subscribers_url":"https://api.github.com/repos/Polymer/vulcanize/subscribers","subscription_url":"https://api.github.com/repos/Polymer/vulcanize/subscription","commits_url":"https://api.github.com/repos/Polymer/vulcanize/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/vulcanize/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/vulcanize/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/vulcanize/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/vulcanize/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/vulcanize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/vulcanize/merges","archive_url":"https://api.github.com/repos/Polymer/vulcanize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/vulcanize/downloads","issues_url":"https://api.github.com/repos/Polymer/vulcanize/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/vulcanize/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/vulcanize/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/vulcanize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/vulcanize/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/vulcanize/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/vulcanize/deployments","created_at":"2013-10-15T18:56:20Z","updated_at":"2016-09-26T07:35:18Z","pushed_at":"2016-09-27T22:09:50Z","git_url":"git://github.com/Polymer/vulcanize.git","ssh_url":"git@github.com:Polymer/vulcanize.git","clone_url":"https://github.com/Polymer/vulcanize.git","svn_url":"https://github.com/Polymer/vulcanize","homepage":"","size":1150,"stargazers_count":1113,"watchers_count":1113,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":84,"forks":115,"open_issues":84,"watchers":1113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/379"},"html":{"href":"https://github.com/Polymer/vulcanize/pull/379"},"issue":{"href":"https://api.github.com/repos/Polymer/vulcanize/issues/379"},"comments":{"href":"https://api.github.com/repos/Polymer/vulcanize/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/vulcanize/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/vulcanize/statuses/316b90ee3769f67c5875549bacc92550718b48f5"}}}}
{"actor":{"display_login":"justinfagnani"}}