{"action":"created","issue":{"url":"https://api.github.com/repos/NerdWallet/nw-react-slider/issues/5","repository_url":"https://api.github.com/repos/NerdWallet/nw-react-slider","labels_url":"https://api.github.com/repos/NerdWallet/nw-react-slider/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/NerdWallet/nw-react-slider/issues/5/comments","events_url":"https://api.github.com/repos/NerdWallet/nw-react-slider/issues/5/events","html_url":"https://github.com/NerdWallet/nw-react-slider/pull/5","id":173892036,"number":5,"title":"Only calling onChange when I expected it to be called","user":{"login":"thataustin","id":609078,"avatar_url":"https://avatars.githubusercontent.com/u/609078?v=3","gravatar_id":"","url":"https://api.github.com/users/thataustin","html_url":"https://github.com/thataustin","followers_url":"https://api.github.com/users/thataustin/followers","following_url":"https://api.github.com/users/thataustin/following{/other_user}","gists_url":"https://api.github.com/users/thataustin/gists{/gist_id}","starred_url":"https://api.github.com/users/thataustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thataustin/subscriptions","organizations_url":"https://api.github.com/users/thataustin/orgs","repos_url":"https://api.github.com/users/thataustin/repos","events_url":"https://api.github.com/users/thataustin/events{/privacy}","received_events_url":"https://api.github.com/users/thataustin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-29T22:55:06Z","updated_at":"2016-09-07T22:04:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NerdWallet/nw-react-slider/pulls/5","html_url":"https://github.com/NerdWallet/nw-react-slider/pull/5","diff_url":"https://github.com/NerdWallet/nw-react-slider/pull/5.diff","patch_url":"https://github.com/NerdWallet/nw-react-slider/pull/5.patch"},"body":"Here's what I changed:\r\n- `updateValueFromPosition` now returns the new value, and not the slider position\r\n    - This return value wasn't being used anywhere as far as I can tell, so it should be a safe change.\r\n- `updateValueFromPosition` no longer calls `this.props.onChange` (which was getting called way to often from my perspective as a consumer of this component)\r\n- `handleUp` and `clickOnTrack` do now call `this.props.onChange`, which seems like a reasonable time to call that method"},"comment":{"url":"https://api.github.com/repos/NerdWallet/nw-react-slider/issues/comments/245434220","html_url":"https://github.com/NerdWallet/nw-react-slider/pull/5#issuecomment-245434220","issue_url":"https://api.github.com/repos/NerdWallet/nw-react-slider/issues/5","id":245434220,"user":{"login":"akshat1","id":1529776,"avatar_url":"https://avatars.githubusercontent.com/u/1529776?v=3","gravatar_id":"","url":"https://api.github.com/users/akshat1","html_url":"https://github.com/akshat1","followers_url":"https://api.github.com/users/akshat1/followers","following_url":"https://api.github.com/users/akshat1/following{/other_user}","gists_url":"https://api.github.com/users/akshat1/gists{/gist_id}","starred_url":"https://api.github.com/users/akshat1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshat1/subscriptions","organizations_url":"https://api.github.com/users/akshat1/orgs","repos_url":"https://api.github.com/users/akshat1/repos","events_url":"https://api.github.com/users/akshat1/events{/privacy}","received_events_url":"https://api.github.com/users/akshat1/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T22:04:31Z","updated_at":"2016-09-07T22:04:31Z","body":"@thataustin I'm sorry it took a while for us to respond to your pull-request. We are looking at it currently and we will get back to you soon. Thanks for contributing!"}}
{"actor":{"display_login":"akshat1"}}