{"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine/pulls/comments/55935072","id":55935072,"diff_hunk":"@@ -8,61 +8,84 @@\n \n #include <list>\n #include <symengine/polynomial.h>\n+#include <symengine/rational.h>\n+#include <symengine/series.h>\n \n namespace SymEngine {\n //! UnivariateSeries Class\n-class UnivariateSeries : public Basic {\n-public:\n-    //! `var_` : Variable of the UnivariateSeries\n-    //! `poly_` : holds the UnivariateIntPolynomial of the series\n-    //! `prec_` : precision of the UnivariateSeries, i.e. self = poly + O(var^prec)\n+class UnivariateSeries : public SeriesBase<UnivariateExprPolynomial, Expression, UnivariateSeries> {\n     // UnivariateSeries 1 + 2*x + x**2 + O(x**5) has dict_ = {{0, 1}, {1, 2}, {2, 1}} with var_ = \"x\" and prec_ = 5\n-    RCP<const Symbol> var_;\n-    RCP<const UnivariateIntPolynomial> poly_;\n-    unsigned int prec_;\n public:\n+    unsigned int prec_;\n     IMPLEMENT_TYPEID(UNIVARIATESERIES)\n-    //! Constructor of UnivariateSeries class\n-    UnivariateSeries(const RCP<const Symbol> &var, const unsigned int &precision, const RCP<const UnivariateIntPolynomial> &poly);\n-    UnivariateSeries(const RCP<const Symbol> &var, const unsigned int& precision, const unsigned int& max_exp, map_uint_mpz&& dict);\n+    UnivariateSeries(const UnivariateExprPolynomial &sp, const std::string varname, const unsigned degree) : SeriesBase(std::move(sp), varname, degree) {}\n+    UnivariateSeries(const RCP<const Symbol> &var, const unsigned int &precision, const UnivariateExprPolynomial &poly);\n+    UnivariateSeries(const RCP<const Symbol> &var, const unsigned int &precision, const unsigned int &max_exp, map_int_Expr &&dict);\n     UnivariateSeries(const RCP<const Symbol> &var, const unsigned int &precision, const map_uint_mpz &dict);","path":"symengine/series_generic.h","position":28,"original_position":28,"commit_id":"537a8dc92ea1138e2146dacdd94791a44cd84f0d","original_commit_id":"537a8dc92ea1138e2146dacdd94791a44cd84f0d","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"This is unnecessary","created_at":"2016-03-13T10:32:09Z","updated_at":"2016-03-13T10:32:09Z","html_url":"https://github.com/symengine/symengine/pull/868#discussion_r55935072","pull_request_url":"https://api.github.com/repos/symengine/symengine/pulls/868","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments/55935072"},"html":{"href":"https://github.com/symengine/symengine/pull/868#discussion_r55935072"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine/pulls/868"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/868","id":62667084,"html_url":"https://github.com/symengine/symengine/pull/868","diff_url":"https://github.com/symengine/symengine/pull/868.diff","patch_url":"https://github.com/symengine/symengine/pull/868.patch","issue_url":"https://api.github.com/repos/symengine/symengine/issues/868","number":868,"state":"open","locked":false,"title":"[WIP] UnivariateSeries","user":{"login":"chenchfort","id":8339862,"avatar_url":"https://avatars.githubusercontent.com/u/8339862?v=3","gravatar_id":"","url":"https://api.github.com/users/chenchfort","html_url":"https://github.com/chenchfort","followers_url":"https://api.github.com/users/chenchfort/followers","following_url":"https://api.github.com/users/chenchfort/following{/other_user}","gists_url":"https://api.github.com/users/chenchfort/gists{/gist_id}","starred_url":"https://api.github.com/users/chenchfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenchfort/subscriptions","organizations_url":"https://api.github.com/users/chenchfort/orgs","repos_url":"https://api.github.com/users/chenchfort/repos","events_url":"https://api.github.com/users/chenchfort/events{/privacy}","received_events_url":"https://api.github.com/users/chenchfort/received_events","type":"User","site_admin":false},"body":"Resuming the work from #810. A new UnivariateSeries that uses SeriesBase as its base. Without external dependencies, UnivariateSeries uses the existing generic interface implementation to match those of Piranha and Flint.\r\n\r\n@shivamvats @certik @isuruf @Sumith1896","created_at":"2016-03-13T10:03:35Z","updated_at":"2016-03-13T10:32:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd16d6d0cfcad7109fafd5fb163bc914e73be194","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symengine/symengine/pulls/868/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine/pulls/868/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/868/comments","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/537a8dc92ea1138e2146dacdd94791a44cd84f0d","head":{"label":"chenchfort:univariateseries","ref":"univariateseries","sha":"537a8dc92ea1138e2146dacdd94791a44cd84f0d","user":{"login":"chenchfort","id":8339862,"avatar_url":"https://avatars.githubusercontent.com/u/8339862?v=3","gravatar_id":"","url":"https://api.github.com/users/chenchfort","html_url":"https://github.com/chenchfort","followers_url":"https://api.github.com/users/chenchfort/followers","following_url":"https://api.github.com/users/chenchfort/following{/other_user}","gists_url":"https://api.github.com/users/chenchfort/gists{/gist_id}","starred_url":"https://api.github.com/users/chenchfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenchfort/subscriptions","organizations_url":"https://api.github.com/users/chenchfort/orgs","repos_url":"https://api.github.com/users/chenchfort/repos","events_url":"https://api.github.com/users/chenchfort/events{/privacy}","received_events_url":"https://api.github.com/users/chenchfort/received_events","type":"User","site_admin":false},"repo":{"id":49797249,"name":"symengine","full_name":"chenchfort/symengine","owner":{"login":"chenchfort","id":8339862,"avatar_url":"https://avatars.githubusercontent.com/u/8339862?v=3","gravatar_id":"","url":"https://api.github.com/users/chenchfort","html_url":"https://github.com/chenchfort","followers_url":"https://api.github.com/users/chenchfort/followers","following_url":"https://api.github.com/users/chenchfort/following{/other_user}","gists_url":"https://api.github.com/users/chenchfort/gists{/gist_id}","starred_url":"https://api.github.com/users/chenchfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenchfort/subscriptions","organizations_url":"https://api.github.com/users/chenchfort/orgs","repos_url":"https://api.github.com/users/chenchfort/repos","events_url":"https://api.github.com/users/chenchfort/events{/privacy}","received_events_url":"https://api.github.com/users/chenchfort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chenchfort/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/chenchfort/symengine","forks_url":"https://api.github.com/repos/chenchfort/symengine/forks","keys_url":"https://api.github.com/repos/chenchfort/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chenchfort/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chenchfort/symengine/teams","hooks_url":"https://api.github.com/repos/chenchfort/symengine/hooks","issue_events_url":"https://api.github.com/repos/chenchfort/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/chenchfort/symengine/events","assignees_url":"https://api.github.com/repos/chenchfort/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/chenchfort/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/chenchfort/symengine/tags","blobs_url":"https://api.github.com/repos/chenchfort/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chenchfort/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chenchfort/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/chenchfort/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chenchfort/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/chenchfort/symengine/languages","stargazers_url":"https://api.github.com/repos/chenchfort/symengine/stargazers","contributors_url":"https://api.github.com/repos/chenchfort/symengine/contributors","subscribers_url":"https://api.github.com/repos/chenchfort/symengine/subscribers","subscription_url":"https://api.github.com/repos/chenchfort/symengine/subscription","commits_url":"https://api.github.com/repos/chenchfort/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/chenchfort/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/chenchfort/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/chenchfort/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/chenchfort/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/chenchfort/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chenchfort/symengine/merges","archive_url":"https://api.github.com/repos/chenchfort/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chenchfort/symengine/downloads","issues_url":"https://api.github.com/repos/chenchfort/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/chenchfort/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/chenchfort/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/chenchfort/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chenchfort/symengine/labels{/name}","releases_url":"https://api.github.com/repos/chenchfort/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/chenchfort/symengine/deployments","created_at":"2016-01-17T00:46:40Z","updated_at":"2016-01-17T00:46:42Z","pushed_at":"2016-03-13T09:29:27Z","git_url":"git://github.com/chenchfort/symengine.git","ssh_url":"git@github.com:chenchfort/symengine.git","clone_url":"https://github.com/chenchfort/symengine.git","svn_url":"https://github.com/chenchfort/symengine","homepage":"http://sympy.org","size":4600,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"35ec543c9c6c0c324868d045b46252b6400b4e86","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"symengine/symengine","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/symengine/symengine","forks_url":"https://api.github.com/repos/symengine/symengine/forks","keys_url":"https://api.github.com/repos/symengine/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine/teams","hooks_url":"https://api.github.com/repos/symengine/symengine/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine/events","assignees_url":"https://api.github.com/repos/symengine/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine/tags","blobs_url":"https://api.github.com/repos/symengine/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine/subscription","commits_url":"https://api.github.com/repos/symengine/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine/merges","archive_url":"https://api.github.com/repos/symengine/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine/downloads","issues_url":"https://api.github.com/repos/symengine/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine/deployments","created_at":"2008-08-13T18:40:14Z","updated_at":"2016-03-09T23:50:38Z","pushed_at":"2016-03-13T10:03:35Z","git_url":"git://github.com/symengine/symengine.git","ssh_url":"git@github.com:symengine/symengine.git","clone_url":"https://github.com/symengine/symengine.git","svn_url":"https://github.com/symengine/symengine","homepage":"http://sympy.org","size":33991,"stargazers_count":124,"watchers_count":124,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":102,"forks":98,"open_issues":102,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/868"},"html":{"href":"https://github.com/symengine/symengine/pull/868"},"issue":{"href":"https://api.github.com/repos/symengine/symengine/issues/868"},"comments":{"href":"https://api.github.com/repos/symengine/symengine/issues/868/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine/pulls/868/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine/pulls/868/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine/statuses/537a8dc92ea1138e2146dacdd94791a44cd84f0d"}}}}