{"action":"created","comment":{"url":"https://api.github.com/repos/spree/spree/pulls/comments/71546882","id":71546882,"diff_hunk":"@@ -44,7 +44,7 @@ def taxon_ids_string=(s)\n \n         # All taxons in an order\n         def order_taxons(order)\n-          Spree::Taxon.joins(products: {variants_including_master: :line_items}).where(spree_line_items: {order_id: order.id}).uniq\n+          Spree::Taxon.joins(products: {variants_including_master: :line_items}).where(spree_line_items: {order_id: order.id}).distinct","path":"core/app/models/spree/promotion/rules/taxon.rb","position":5,"original_position":5,"commit_id":"7466f3ca974fc51fc61925fb93556bf149e9b64b","original_commit_id":"7466f3ca974fc51fc61925fb93556bf149e9b64b","user":{"login":"damianlegawiec","id":55154,"avatar_url":"https://avatars.githubusercontent.com/u/55154?v=3","gravatar_id":"","url":"https://api.github.com/users/damianlegawiec","html_url":"https://github.com/damianlegawiec","followers_url":"https://api.github.com/users/damianlegawiec/followers","following_url":"https://api.github.com/users/damianlegawiec/following{/other_user}","gists_url":"https://api.github.com/users/damianlegawiec/gists{/gist_id}","starred_url":"https://api.github.com/users/damianlegawiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianlegawiec/subscriptions","organizations_url":"https://api.github.com/users/damianlegawiec/orgs","repos_url":"https://api.github.com/users/damianlegawiec/repos","events_url":"https://api.github.com/users/damianlegawiec/events{/privacy}","received_events_url":"https://api.github.com/users/damianlegawiec/received_events","type":"User","site_admin":false},"body":"@mauazua could we also fix this hound issue in this PR? Thanks!","created_at":"2016-07-20T15:23:53Z","updated_at":"2016-07-20T15:23:53Z","html_url":"https://github.com/spree/spree/pull/7492#discussion_r71546882","pull_request_url":"https://api.github.com/repos/spree/spree/pulls/7492","_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/comments/71546882"},"html":{"href":"https://github.com/spree/spree/pull/7492#discussion_r71546882"},"pull_request":{"href":"https://api.github.com/repos/spree/spree/pulls/7492"}}},"pull_request":{"url":"https://api.github.com/repos/spree/spree/pulls/7492","id":78161699,"html_url":"https://github.com/spree/spree/pull/7492","diff_url":"https://github.com/spree/spree/pull/7492.diff","patch_url":"https://github.com/spree/spree/pull/7492.patch","issue_url":"https://api.github.com/repos/spree/spree/issues/7492","number":7492,"state":"open","locked":false,"title":"[Rails 5] replace deprecated uniq with distinct on relation","user":{"login":"mauazua","id":2800299,"avatar_url":"https://avatars.githubusercontent.com/u/2800299?v=3","gravatar_id":"","url":"https://api.github.com/users/mauazua","html_url":"https://github.com/mauazua","followers_url":"https://api.github.com/users/mauazua/followers","following_url":"https://api.github.com/users/mauazua/following{/other_user}","gists_url":"https://api.github.com/users/mauazua/gists{/gist_id}","starred_url":"https://api.github.com/users/mauazua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauazua/subscriptions","organizations_url":"https://api.github.com/users/mauazua/orgs","repos_url":"https://api.github.com/users/mauazua/repos","events_url":"https://api.github.com/users/mauazua/events{/privacy}","received_events_url":"https://api.github.com/users/mauazua/received_events","type":"User","site_admin":false},"body":"In Rails 5 `uniq` method for relations is deprecated. This PR switches `uniq` to preferred `distinct`.","created_at":"2016-07-20T14:54:21Z","updated_at":"2016-07-20T15:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40c8639366396f1f02b3ef5f7c12b0484f23ca8d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spree/spree/pulls/7492/commits","review_comments_url":"https://api.github.com/repos/spree/spree/pulls/7492/comments","review_comment_url":"https://api.github.com/repos/spree/spree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spree/spree/issues/7492/comments","statuses_url":"https://api.github.com/repos/spree/spree/statuses/7466f3ca974fc51fc61925fb93556bf149e9b64b","head":{"label":"spark-solutions:distinct_instead_of_uniq","ref":"distinct_instead_of_uniq","sha":"7466f3ca974fc51fc61925fb93556bf149e9b64b","user":{"login":"spark-solutions","id":10135622,"avatar_url":"https://avatars.githubusercontent.com/u/10135622?v=3","gravatar_id":"","url":"https://api.github.com/users/spark-solutions","html_url":"https://github.com/spark-solutions","followers_url":"https://api.github.com/users/spark-solutions/followers","following_url":"https://api.github.com/users/spark-solutions/following{/other_user}","gists_url":"https://api.github.com/users/spark-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/spark-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark-solutions/subscriptions","organizations_url":"https://api.github.com/users/spark-solutions/orgs","repos_url":"https://api.github.com/users/spark-solutions/repos","events_url":"https://api.github.com/users/spark-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/spark-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":49967412,"name":"spree","full_name":"spark-solutions/spree","owner":{"login":"spark-solutions","id":10135622,"avatar_url":"https://avatars.githubusercontent.com/u/10135622?v=3","gravatar_id":"","url":"https://api.github.com/users/spark-solutions","html_url":"https://github.com/spark-solutions","followers_url":"https://api.github.com/users/spark-solutions/followers","following_url":"https://api.github.com/users/spark-solutions/following{/other_user}","gists_url":"https://api.github.com/users/spark-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/spark-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spark-solutions/subscriptions","organizations_url":"https://api.github.com/users/spark-solutions/orgs","repos_url":"https://api.github.com/users/spark-solutions/repos","events_url":"https://api.github.com/users/spark-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/spark-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spark-solutions/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":true,"url":"https://api.github.com/repos/spark-solutions/spree","forks_url":"https://api.github.com/repos/spark-solutions/spree/forks","keys_url":"https://api.github.com/repos/spark-solutions/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spark-solutions/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spark-solutions/spree/teams","hooks_url":"https://api.github.com/repos/spark-solutions/spree/hooks","issue_events_url":"https://api.github.com/repos/spark-solutions/spree/issues/events{/number}","events_url":"https://api.github.com/repos/spark-solutions/spree/events","assignees_url":"https://api.github.com/repos/spark-solutions/spree/assignees{/user}","branches_url":"https://api.github.com/repos/spark-solutions/spree/branches{/branch}","tags_url":"https://api.github.com/repos/spark-solutions/spree/tags","blobs_url":"https://api.github.com/repos/spark-solutions/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spark-solutions/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spark-solutions/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spark-solutions/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spark-solutions/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/spark-solutions/spree/languages","stargazers_url":"https://api.github.com/repos/spark-solutions/spree/stargazers","contributors_url":"https://api.github.com/repos/spark-solutions/spree/contributors","subscribers_url":"https://api.github.com/repos/spark-solutions/spree/subscribers","subscription_url":"https://api.github.com/repos/spark-solutions/spree/subscription","commits_url":"https://api.github.com/repos/spark-solutions/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spark-solutions/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spark-solutions/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spark-solutions/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/spark-solutions/spree/contents/{+path}","compare_url":"https://api.github.com/repos/spark-solutions/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spark-solutions/spree/merges","archive_url":"https://api.github.com/repos/spark-solutions/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spark-solutions/spree/downloads","issues_url":"https://api.github.com/repos/spark-solutions/spree/issues{/number}","pulls_url":"https://api.github.com/repos/spark-solutions/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/spark-solutions/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/spark-solutions/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spark-solutions/spree/labels{/name}","releases_url":"https://api.github.com/repos/spark-solutions/spree/releases{/id}","deployments_url":"https://api.github.com/repos/spark-solutions/spree/deployments","created_at":"2016-01-19T16:47:28Z","updated_at":"2016-03-06T22:56:21Z","pushed_at":"2016-07-20T14:41:35Z","git_url":"git://github.com/spark-solutions/spree.git","ssh_url":"git@github.com:spark-solutions/spree.git","clone_url":"https://github.com/spark-solutions/spree.git","svn_url":"https://github.com/spark-solutions/spree","homepage":"http://spreecommerce.com","size":78556,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"spree:master","ref":"master","sha":"4e90aaf92e3ed05482127285b5d6c1387ab97b69","user":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"repo":{"id":3314,"name":"spree","full_name":"spree/spree","owner":{"login":"spree","id":56702,"avatar_url":"https://avatars.githubusercontent.com/u/56702?v=3","gravatar_id":"","url":"https://api.github.com/users/spree","html_url":"https://github.com/spree","followers_url":"https://api.github.com/users/spree/followers","following_url":"https://api.github.com/users/spree/following{/other_user}","gists_url":"https://api.github.com/users/spree/gists{/gist_id}","starred_url":"https://api.github.com/users/spree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spree/subscriptions","organizations_url":"https://api.github.com/users/spree/orgs","repos_url":"https://api.github.com/users/spree/repos","events_url":"https://api.github.com/users/spree/events{/privacy}","received_events_url":"https://api.github.com/users/spree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spree/spree","description":"Spree is a complete open source e-commerce solution for Ruby on Rails.","fork":false,"url":"https://api.github.com/repos/spree/spree","forks_url":"https://api.github.com/repos/spree/spree/forks","keys_url":"https://api.github.com/repos/spree/spree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spree/spree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spree/spree/teams","hooks_url":"https://api.github.com/repos/spree/spree/hooks","issue_events_url":"https://api.github.com/repos/spree/spree/issues/events{/number}","events_url":"https://api.github.com/repos/spree/spree/events","assignees_url":"https://api.github.com/repos/spree/spree/assignees{/user}","branches_url":"https://api.github.com/repos/spree/spree/branches{/branch}","tags_url":"https://api.github.com/repos/spree/spree/tags","blobs_url":"https://api.github.com/repos/spree/spree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spree/spree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spree/spree/git/refs{/sha}","trees_url":"https://api.github.com/repos/spree/spree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spree/spree/statuses/{sha}","languages_url":"https://api.github.com/repos/spree/spree/languages","stargazers_url":"https://api.github.com/repos/spree/spree/stargazers","contributors_url":"https://api.github.com/repos/spree/spree/contributors","subscribers_url":"https://api.github.com/repos/spree/spree/subscribers","subscription_url":"https://api.github.com/repos/spree/spree/subscription","commits_url":"https://api.github.com/repos/spree/spree/commits{/sha}","git_commits_url":"https://api.github.com/repos/spree/spree/git/commits{/sha}","comments_url":"https://api.github.com/repos/spree/spree/comments{/number}","issue_comment_url":"https://api.github.com/repos/spree/spree/issues/comments{/number}","contents_url":"https://api.github.com/repos/spree/spree/contents/{+path}","compare_url":"https://api.github.com/repos/spree/spree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spree/spree/merges","archive_url":"https://api.github.com/repos/spree/spree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spree/spree/downloads","issues_url":"https://api.github.com/repos/spree/spree/issues{/number}","pulls_url":"https://api.github.com/repos/spree/spree/pulls{/number}","milestones_url":"https://api.github.com/repos/spree/spree/milestones{/number}","notifications_url":"https://api.github.com/repos/spree/spree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spree/spree/labels{/name}","releases_url":"https://api.github.com/repos/spree/spree/releases{/id}","deployments_url":"https://api.github.com/repos/spree/spree/deployments","created_at":"2008-03-10T14:45:35Z","updated_at":"2016-07-20T14:04:04Z","pushed_at":"2016-07-20T15:23:01Z","git_url":"git://github.com/spree/spree.git","ssh_url":"git@github.com:spree/spree.git","clone_url":"https://github.com/spree/spree.git","svn_url":"https://github.com/spree/spree","homepage":"http://spreecommerce.com","size":106784,"stargazers_count":7645,"watchers_count":7645,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3600,"mirror_url":null,"open_issues_count":175,"forks":3600,"open_issues":175,"watchers":7645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spree/spree/pulls/7492"},"html":{"href":"https://github.com/spree/spree/pull/7492"},"issue":{"href":"https://api.github.com/repos/spree/spree/issues/7492"},"comments":{"href":"https://api.github.com/repos/spree/spree/issues/7492/comments"},"review_comments":{"href":"https://api.github.com/repos/spree/spree/pulls/7492/comments"},"review_comment":{"href":"https://api.github.com/repos/spree/spree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spree/spree/pulls/7492/commits"},"statuses":{"href":"https://api.github.com/repos/spree/spree/statuses/7466f3ca974fc51fc61925fb93556bf149e9b64b"}}}}
{"actor":{"display_login":"damianlegawiec"}}