{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/5797","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/5797/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/5797/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/5797/events","html_url":"https://github.com/playframework/playframework/pull/5797","id":138552012,"number":5797,"title":"[master] Use scalatest for templates","user":{"login":"wsargent","id":71236,"avatar_url":"https://avatars.githubusercontent.com/u/71236?v=3","gravatar_id":"","url":"https://api.github.com/users/wsargent","html_url":"https://github.com/wsargent","followers_url":"https://api.github.com/users/wsargent/followers","following_url":"https://api.github.com/users/wsargent/following{/other_user}","gists_url":"https://api.github.com/users/wsargent/gists{/gist_id}","starred_url":"https://api.github.com/users/wsargent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsargent/subscriptions","organizations_url":"https://api.github.com/users/wsargent/orgs","repos_url":"https://api.github.com/users/wsargent/repos","events_url":"https://api.github.com/users/wsargent/events{/privacy}","received_events_url":"https://api.github.com/users/wsargent/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-03-04T18:43:16Z","updated_at":"2016-05-25T07:16:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/5797","html_url":"https://github.com/playframework/playframework/pull/5797","diff_url":"https://github.com/playframework/playframework/pull/5797.diff","patch_url":"https://github.com/playframework/playframework/pull/5797.patch"},"body":"# Pull Request Checklist\r\n\r\n* [x] Have you read through the [contributor guidelines](https://www.playframework.com/contributing)?\r\n* [x] Have you signed the [Typesafe CLA](https://www.typesafe.com/contribute/cla)?\r\n* [x] Have you [squashed your commits](https://www.playframework.com/documentation/2.4.x/WorkingWithGit#Squashing-commits)?\r\n* [x] Have you added copyright headers to new files?\r\n* [x] Have you checked that both Scala and Java APIs are updated?\r\n* [x] Have you updated the documentation for both Scala and Java sections?\r\n* [x] Have you added tests for any changed functionality?\r\n\r\n## Fixes\r\n\r\nScalatest needed updating, and the integration tests for play-scala-intro were failing because HtmlUnit didn't support jQuery 2.2.0.\r\n\r\n## Purpose\r\n\r\nUpdates scalatest, changes tests for play-scala-intro, uses customized integration tests.\r\n\r\n## References\r\n\r\nSame as https://github.com/playframework/playframework/pull/5796 but more expansive"},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/221492506","html_url":"https://github.com/playframework/playframework/pull/5797#issuecomment-221492506","issue_url":"https://api.github.com/repos/playframework/playframework/issues/5797","id":221492506,"user":{"login":"richdougherty","id":14750,"avatar_url":"https://avatars.githubusercontent.com/u/14750?v=3","gravatar_id":"","url":"https://api.github.com/users/richdougherty","html_url":"https://github.com/richdougherty","followers_url":"https://api.github.com/users/richdougherty/followers","following_url":"https://api.github.com/users/richdougherty/following{/other_user}","gists_url":"https://api.github.com/users/richdougherty/gists{/gist_id}","starred_url":"https://api.github.com/users/richdougherty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richdougherty/subscriptions","organizations_url":"https://api.github.com/users/richdougherty/orgs","repos_url":"https://api.github.com/users/richdougherty/repos","events_url":"https://api.github.com/users/richdougherty/events{/privacy}","received_events_url":"https://api.github.com/users/richdougherty/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T07:16:52Z","updated_at":"2016-05-25T07:16:52Z","body":"LGTM.\r\n\r\nJust one question: is all the `synchronized` stuff around `Application` tests something that end users will need to do when they make these kinds of tests in their own projects? It seems like it's a bit of boilerplate they shouldn't need to worry about."}}
{"actor":{"display_login":"richdougherty"}}