{"action":"opened","number":123,"pull_request":{"url":"https://api.github.com/repos/Solo5/solo5/pulls/123","id":94380793,"html_url":"https://github.com/Solo5/solo5/pull/123","diff_url":"https://github.com/Solo5/solo5/pull/123.diff","patch_url":"https://github.com/Solo5/solo5/pull/123.patch","issue_url":"https://api.github.com/repos/Solo5/solo5/issues/123","number":123,"state":"open","locked":false,"title":"remove LD hacks","user":{"login":"hannesm","id":228456,"avatar_url":"https://avatars.githubusercontent.com/u/228456?v=3","gravatar_id":"","url":"https://api.github.com/users/hannesm","html_url":"https://github.com/hannesm","followers_url":"https://api.github.com/users/hannesm/followers","following_url":"https://api.github.com/users/hannesm/following{/other_user}","gists_url":"https://api.github.com/users/hannesm/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesm/subscriptions","organizations_url":"https://api.github.com/users/hannesm/orgs","repos_url":"https://api.github.com/users/hannesm/repos","events_url":"https://api.github.com/users/hannesm/events{/privacy}","received_events_url":"https://api.github.com/users/hannesm/received_events","type":"User","site_admin":false},"body":"Makefile.common included first Makeconf, and set AS, CC, LD unconditionally\r\nafterwards.  This lead to the LD in Makeconf never having any effect.\r\n\r\nIt turns out (I didn't yet dig which commit) that FreeBSD's ld (version 2.17.50)\r\nworks fine with Solo5 now.  I tested this with a) solo5 examples,\r\nb) mirage-skeleton examples up to stackv4 and static_website_tls.\r\n\r\nThis commit a) removes the LD detection (executed on FreeBSD only), b) moves the .include in Makefile.common to a later point so that we can actually override these variables in Makeconf.  It worked before #106, but not after (before `?=` was used, after `=`).\r\n\r\n@mato a review would be appreciated.  Once this is in, I'm happy to remove the corresponding code from mirage/mirage.\r\n\r\nHere is `readelf -S mir-stackv4.virtio` compiled with ld 2.17.50:\r\n```\r\n  [Nr] Name              Type             Address           Offset\r\n       Size              EntSize          Flags  Link  Info  Align\r\n  [ 0] (null)            NULL             0000000000000000  00000000\r\n       0000000000000000  0000000000000000           0     0     0\r\n  [ 1] .bootstrap        PROGBITS         0000000000100000  00001000\r\n       0000000000000020  0000000000000000  AX       0     0     4\r\n  [ 2] .text             PROGBITS         0000000000101000  00002000\r\n       00000000001116cf  0000000000000000  AX       0     0     4096\r\n  [ 3] .rodata           PROGBITS         0000000000213000  00114000\r\n       00000000000076a8  0000000000000000   A       0     0     16\r\n  [ 4] .eh_frame         X86_64_UNWIND    000000000021a6a8  0011b6a8\r\n       00000000000336b0  0000000000000000   A       0     0     8\r\n  [ 5] .got              PROGBITS         000000000024e000  0014f000\r\n       000000000000e718  0000000000000008  WA       0     0     8\r\n  [ 6] .data             PROGBITS         000000000025c740  0015d740\r\n       00000000000ba440  0000000000000000  WA       0     0     64\r\n  [ 7] .bss              NOBITS           0000000000317000  00217b80\r\n       0000000000019694  0000000000000000  WA       0     0     16\r\n  [ 8] .comment          PROGBITS         0000000000000000  00217b80\r\n       0000000000000052  0000000000000001  MS       0     0     1\r\n  [ 9] .debug_aranges    PROGBITS         0000000000000000  00217be0\r\n       0000000000001890  0000000000000000           0     0     16\r\n  [10] .debug_pubnames   PROGBITS         0000000000000000  00219470\r\n       0000000000007501  0000000000000000           0     0     1\r\n  [11] .debug_info       PROGBITS         0000000000000000  00220971\r\n       000000000002a8b3  0000000000000000           0     0     1\r\n  [12] .debug_abbrev     PROGBITS         0000000000000000  0024b224\r\n       0000000000007479  0000000000000000           0     0     1\r\n  [13] .debug_line       PROGBITS         0000000000000000  0025269d\r\n       000000000002ce28  0000000000000000           0     0     1\r\n  [14] .debug_str        PROGBITS         0000000000000000  0027f4c5\r\n       0000000000007bf0  0000000000000001  MS       0     0     1\r\n  [15] .debug_loc        PROGBITS         0000000000000000  002870b5\r\n       0000000000026a04  0000000000000000           0     0     1\r\n  [16] .debug_macinfo    PROGBITS         0000000000000000  002adab9\r\n       0000000000000041  0000000000000000           0     0     1\r\n  [17] .debug_pubtypes   PROGBITS         0000000000000000  002adafa\r\n       0000000000003a90  0000000000000000           0     0     1\r\n  [18] .debug_ranges     PROGBITS         0000000000000000  002b158a\r\n       00000000000070b0  0000000000000000           0     0     1\r\n  [19] .shstrtab         STRTAB           0000000000000000  002b863a\r\n       00000000000000df  0000000000000000           0     0     1\r\n  [20] .symtab           SYMTAB           0000000000000000  002b8ca0\r\n       00000000000671e8  0000000000000018          21   9900     8\r\n  [21] .strtab           STRTAB           0000000000000000  0031fe88\r\n       000000000005d1b4  0000000000000000           0     0     1\r\n```\r\n\r\nAnd here with 2.27:\r\n```\r\n  [Nr] Name              Type             Address           Offset\r\n       Size              EntSize          Flags  Link  Info  Align\r\n  [ 0] (null)            NULL             0000000000000000  00000000\r\n       0000000000000000  0000000000000000           0     0     0\r\n  [ 1] .bootstrap        PROGBITS         0000000000100000  00001000\r\n       0000000000000020  0000000000000000  AX       0     0     4\r\n  [ 2] .text             PROGBITS         0000000000101000  00002000\r\n       00000000001116cf  0000000000000000  AX       0     0     4096\r\n  [ 3] .rodata           PROGBITS         0000000000213000  00114000\r\n       00000000000076a8  0000000000000000   A       0     0     16\r\n  [ 4] .eh_frame         X86_64_UNWIND    000000000021a6a8  0011b6a8\r\n       00000000000336b0  0000000000000000   A       0     0     8\r\n  [ 5] .got              PROGBITS         000000000024e000  0014f000\r\n       0000000000000018  0000000000000008  WA       0     0     8\r\n  [ 6] .data             PROGBITS         000000000024e040  0014f040\r\n       00000000000ba440  0000000000000000  WA       0     0     64\r\n  [ 7] .bss              NOBITS           0000000000309000  00209480\r\n       0000000000019694  0000000000000000  WA       0     0     16\r\n  [ 8] .comment          PROGBITS         0000000000000000  00209480\r\n       0000000000000052  0000000000000001  MS       0     0     1\r\n  [ 9] .debug_aranges    PROGBITS         0000000000000000  002094e0\r\n       0000000000001890  0000000000000000           0     0     16\r\n  [10] .debug_pubnames   PROGBITS         0000000000000000  0020ad70\r\n       0000000000007501  0000000000000000           0     0     1\r\n  [11] .debug_info       PROGBITS         0000000000000000  00212271\r\n       000000000002a8b3  0000000000000000           0     0     1\r\n  [12] .debug_abbrev     PROGBITS         0000000000000000  0023cb24\r\n       0000000000007479  0000000000000000           0     0     1\r\n  [13] .debug_line       PROGBITS         0000000000000000  00243f9d\r\n       000000000002ce28  0000000000000000           0     0     1\r\n  [14] .debug_str        PROGBITS         0000000000000000  00270dc5\r\n       0000000000007bf0  0000000000000001  MS       0     0     1\r\n  [15] .debug_loc        PROGBITS         0000000000000000  002789b5\r\n       0000000000026a04  0000000000000000           0     0     1\r\n  [16] .debug_macinfo    PROGBITS         0000000000000000  0029f3b9\r\n       0000000000000041  0000000000000000           0     0     1\r\n  [17] .debug_pubtypes   PROGBITS         0000000000000000  0029f3fa\r\n       0000000000003a90  0000000000000000           0     0     1\r\n  [18] .debug_ranges     PROGBITS         0000000000000000  002a2e8a\r\n       00000000000070b0  0000000000000000           0     0     1\r\n  [19] .shstrtab         STRTAB           0000000000000000  0036e1ae\r\n       00000000000000df  0000000000000000           0     0     1\r\n  [20] .symtab           SYMTAB           0000000000000000  002a9f40\r\n       0000000000067218  0000000000000018          21   9902     8\r\n  [21] .strtab           STRTAB           0000000000000000  00311158\r\n       000000000005d056  0000000000000000           0     0     1\r\n```","created_at":"2016-11-18T15:24:18Z","updated_at":"2016-11-18T15:24:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Solo5/solo5/pulls/123/commits","review_comments_url":"https://api.github.com/repos/Solo5/solo5/pulls/123/comments","review_comment_url":"https://api.github.com/repos/Solo5/solo5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Solo5/solo5/issues/123/comments","statuses_url":"https://api.github.com/repos/Solo5/solo5/statuses/f3b5895e94a3851ed79675e8a95d4242eff82866","head":{"label":"hannesm:no-ld","ref":"no-ld","sha":"f3b5895e94a3851ed79675e8a95d4242eff82866","user":{"login":"hannesm","id":228456,"avatar_url":"https://avatars.githubusercontent.com/u/228456?v=3","gravatar_id":"","url":"https://api.github.com/users/hannesm","html_url":"https://github.com/hannesm","followers_url":"https://api.github.com/users/hannesm/followers","following_url":"https://api.github.com/users/hannesm/following{/other_user}","gists_url":"https://api.github.com/users/hannesm/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesm/subscriptions","organizations_url":"https://api.github.com/users/hannesm/orgs","repos_url":"https://api.github.com/users/hannesm/repos","events_url":"https://api.github.com/users/hannesm/events{/privacy}","received_events_url":"https://api.github.com/users/hannesm/received_events","type":"User","site_admin":false},"repo":{"id":62319188,"name":"solo5","full_name":"hannesm/solo5","owner":{"login":"hannesm","id":228456,"avatar_url":"https://avatars.githubusercontent.com/u/228456?v=3","gravatar_id":"","url":"https://api.github.com/users/hannesm","html_url":"https://github.com/hannesm","followers_url":"https://api.github.com/users/hannesm/followers","following_url":"https://api.github.com/users/hannesm/following{/other_user}","gists_url":"https://api.github.com/users/hannesm/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesm/subscriptions","organizations_url":"https://api.github.com/users/hannesm/orgs","repos_url":"https://api.github.com/users/hannesm/repos","events_url":"https://api.github.com/users/hannesm/events{/privacy}","received_events_url":"https://api.github.com/users/hannesm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hannesm/solo5","description":"The Solo5 unikernel","fork":true,"url":"https://api.github.com/repos/hannesm/solo5","forks_url":"https://api.github.com/repos/hannesm/solo5/forks","keys_url":"https://api.github.com/repos/hannesm/solo5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hannesm/solo5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hannesm/solo5/teams","hooks_url":"https://api.github.com/repos/hannesm/solo5/hooks","issue_events_url":"https://api.github.com/repos/hannesm/solo5/issues/events{/number}","events_url":"https://api.github.com/repos/hannesm/solo5/events","assignees_url":"https://api.github.com/repos/hannesm/solo5/assignees{/user}","branches_url":"https://api.github.com/repos/hannesm/solo5/branches{/branch}","tags_url":"https://api.github.com/repos/hannesm/solo5/tags","blobs_url":"https://api.github.com/repos/hannesm/solo5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hannesm/solo5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hannesm/solo5/git/refs{/sha}","trees_url":"https://api.github.com/repos/hannesm/solo5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hannesm/solo5/statuses/{sha}","languages_url":"https://api.github.com/repos/hannesm/solo5/languages","stargazers_url":"https://api.github.com/repos/hannesm/solo5/stargazers","contributors_url":"https://api.github.com/repos/hannesm/solo5/contributors","subscribers_url":"https://api.github.com/repos/hannesm/solo5/subscribers","subscription_url":"https://api.github.com/repos/hannesm/solo5/subscription","commits_url":"https://api.github.com/repos/hannesm/solo5/commits{/sha}","git_commits_url":"https://api.github.com/repos/hannesm/solo5/git/commits{/sha}","comments_url":"https://api.github.com/repos/hannesm/solo5/comments{/number}","issue_comment_url":"https://api.github.com/repos/hannesm/solo5/issues/comments{/number}","contents_url":"https://api.github.com/repos/hannesm/solo5/contents/{+path}","compare_url":"https://api.github.com/repos/hannesm/solo5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hannesm/solo5/merges","archive_url":"https://api.github.com/repos/hannesm/solo5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hannesm/solo5/downloads","issues_url":"https://api.github.com/repos/hannesm/solo5/issues{/number}","pulls_url":"https://api.github.com/repos/hannesm/solo5/pulls{/number}","milestones_url":"https://api.github.com/repos/hannesm/solo5/milestones{/number}","notifications_url":"https://api.github.com/repos/hannesm/solo5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hannesm/solo5/labels{/name}","releases_url":"https://api.github.com/repos/hannesm/solo5/releases{/id}","deployments_url":"https://api.github.com/repos/hannesm/solo5/deployments","created_at":"2016-06-30T14:54:16Z","updated_at":"2016-06-30T14:54:17Z","pushed_at":"2016-11-18T15:18:43Z","git_url":"git://github.com/hannesm/solo5.git","ssh_url":"git@github.com:hannesm/solo5.git","clone_url":"https://github.com/hannesm/solo5.git","svn_url":"https://github.com/hannesm/solo5","homepage":"","size":545,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Solo5:master","ref":"master","sha":"84763e1dd3e7050148288b7cbefb8e120ffba798","user":{"login":"Solo5","id":20474498,"avatar_url":"https://avatars.githubusercontent.com/u/20474498?v=3","gravatar_id":"","url":"https://api.github.com/users/Solo5","html_url":"https://github.com/Solo5","followers_url":"https://api.github.com/users/Solo5/followers","following_url":"https://api.github.com/users/Solo5/following{/other_user}","gists_url":"https://api.github.com/users/Solo5/gists{/gist_id}","starred_url":"https://api.github.com/users/Solo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solo5/subscriptions","organizations_url":"https://api.github.com/users/Solo5/orgs","repos_url":"https://api.github.com/users/Solo5/repos","events_url":"https://api.github.com/users/Solo5/events{/privacy}","received_events_url":"https://api.github.com/users/Solo5/received_events","type":"Organization","site_admin":false},"repo":{"id":47781176,"name":"solo5","full_name":"Solo5/solo5","owner":{"login":"Solo5","id":20474498,"avatar_url":"https://avatars.githubusercontent.com/u/20474498?v=3","gravatar_id":"","url":"https://api.github.com/users/Solo5","html_url":"https://github.com/Solo5","followers_url":"https://api.github.com/users/Solo5/followers","following_url":"https://api.github.com/users/Solo5/following{/other_user}","gists_url":"https://api.github.com/users/Solo5/gists{/gist_id}","starred_url":"https://api.github.com/users/Solo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solo5/subscriptions","organizations_url":"https://api.github.com/users/Solo5/orgs","repos_url":"https://api.github.com/users/Solo5/repos","events_url":"https://api.github.com/users/Solo5/events{/privacy}","received_events_url":"https://api.github.com/users/Solo5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Solo5/solo5","description":"The Solo5 unikernel","fork":false,"url":"https://api.github.com/repos/Solo5/solo5","forks_url":"https://api.github.com/repos/Solo5/solo5/forks","keys_url":"https://api.github.com/repos/Solo5/solo5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Solo5/solo5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Solo5/solo5/teams","hooks_url":"https://api.github.com/repos/Solo5/solo5/hooks","issue_events_url":"https://api.github.com/repos/Solo5/solo5/issues/events{/number}","events_url":"https://api.github.com/repos/Solo5/solo5/events","assignees_url":"https://api.github.com/repos/Solo5/solo5/assignees{/user}","branches_url":"https://api.github.com/repos/Solo5/solo5/branches{/branch}","tags_url":"https://api.github.com/repos/Solo5/solo5/tags","blobs_url":"https://api.github.com/repos/Solo5/solo5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Solo5/solo5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Solo5/solo5/git/refs{/sha}","trees_url":"https://api.github.com/repos/Solo5/solo5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Solo5/solo5/statuses/{sha}","languages_url":"https://api.github.com/repos/Solo5/solo5/languages","stargazers_url":"https://api.github.com/repos/Solo5/solo5/stargazers","contributors_url":"https://api.github.com/repos/Solo5/solo5/contributors","subscribers_url":"https://api.github.com/repos/Solo5/solo5/subscribers","subscription_url":"https://api.github.com/repos/Solo5/solo5/subscription","commits_url":"https://api.github.com/repos/Solo5/solo5/commits{/sha}","git_commits_url":"https://api.github.com/repos/Solo5/solo5/git/commits{/sha}","comments_url":"https://api.github.com/repos/Solo5/solo5/comments{/number}","issue_comment_url":"https://api.github.com/repos/Solo5/solo5/issues/comments{/number}","contents_url":"https://api.github.com/repos/Solo5/solo5/contents/{+path}","compare_url":"https://api.github.com/repos/Solo5/solo5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Solo5/solo5/merges","archive_url":"https://api.github.com/repos/Solo5/solo5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Solo5/solo5/downloads","issues_url":"https://api.github.com/repos/Solo5/solo5/issues{/number}","pulls_url":"https://api.github.com/repos/Solo5/solo5/pulls{/number}","milestones_url":"https://api.github.com/repos/Solo5/solo5/milestones{/number}","notifications_url":"https://api.github.com/repos/Solo5/solo5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Solo5/solo5/labels{/name}","releases_url":"https://api.github.com/repos/Solo5/solo5/releases{/id}","deployments_url":"https://api.github.com/repos/Solo5/solo5/deployments","created_at":"2015-12-10T18:54:36Z","updated_at":"2016-11-18T12:04:45Z","pushed_at":"2016-11-13T17:36:43Z","git_url":"git://github.com/Solo5/solo5.git","ssh_url":"git@github.com:Solo5/solo5.git","clone_url":"https://github.com/Solo5/solo5.git","svn_url":"https://github.com/Solo5/solo5","homepage":"","size":718,"stargazers_count":177,"watchers_count":177,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":10,"forks":24,"open_issues":10,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Solo5/solo5/pulls/123"},"html":{"href":"https://github.com/Solo5/solo5/pull/123"},"issue":{"href":"https://api.github.com/repos/Solo5/solo5/issues/123"},"comments":{"href":"https://api.github.com/repos/Solo5/solo5/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/Solo5/solo5/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/Solo5/solo5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Solo5/solo5/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/Solo5/solo5/statuses/f3b5895e94a3851ed79675e8a95d4242eff82866"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":6,"deletions":15,"changed_files":5}}
{"actor":{"display_login":"hannesm"}}