{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/70566570","id":70566570,"diff_hunk":"@@ -334,15 +342,18 @@ port::Status CudnnSupport::Init() {\n     // Check whether loaded version of CuDNN matches what the source\n     // was built with.\n     size_t loaded_version = dynload::cudnnGetVersion();\n-    bool library_loaded_matches_source = (loaded_version == CUDNN_VERSION);\n+    size_t loaded_major_version = cudnnMajorVersion(loaded_version);\n+    bool library_loaded_matches_source =\n+        (loaded_major_version == cudnnMajorVersion(CUDNN_VERSION));","path":"tensorflow/stream_executor/cuda/cuda_dnn.cc","position":22,"original_position":22,"commit_id":"1416889464a7e2ea1ddfb773c07fc5f9f0c7cac8","original_commit_id":"1416889464a7e2ea1ddfb773c07fc5f9f0c7cac8","user":{"login":"zheng-xq","id":15736910,"avatar_url":"https://avatars.githubusercontent.com/u/15736910?v=3","gravatar_id":"","url":"https://api.github.com/users/zheng-xq","html_url":"https://github.com/zheng-xq","followers_url":"https://api.github.com/users/zheng-xq/followers","following_url":"https://api.github.com/users/zheng-xq/following{/other_user}","gists_url":"https://api.github.com/users/zheng-xq/gists{/gist_id}","starred_url":"https://api.github.com/users/zheng-xq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheng-xq/subscriptions","organizations_url":"https://api.github.com/users/zheng-xq/orgs","repos_url":"https://api.github.com/users/zheng-xq/repos","events_url":"https://api.github.com/users/zheng-xq/events{/privacy}","received_events_url":"https://api.github.com/users/zheng-xq/received_events","type":"User","site_admin":false},"body":"I am not entirely sure it is safe to check only the major version. cudnn versions have three parts: major, minor and patch level. Only the last part can be safely ignored for ABI compatibility. ","created_at":"2016-07-13T05:38:34Z","updated_at":"2016-07-13T05:38:34Z","html_url":"https://github.com/tensorflow/tensorflow/pull/3249#discussion_r70566570","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/70566570"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/3249#discussion_r70566570"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249","id":76859374,"html_url":"https://github.com/tensorflow/tensorflow/pull/3249","diff_url":"https://github.com/tensorflow/tensorflow/pull/3249.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/3249.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/3249","number":3249,"state":"open","locked":false,"title":"Change cudnn version checking to check Major version.","user":{"login":"vrv","id":463737,"avatar_url":"https://avatars.githubusercontent.com/u/463737?v=3","gravatar_id":"","url":"https://api.github.com/users/vrv","html_url":"https://github.com/vrv","followers_url":"https://api.github.com/users/vrv/followers","following_url":"https://api.github.com/users/vrv/following{/other_user}","gists_url":"https://api.github.com/users/vrv/gists{/gist_id}","starred_url":"https://api.github.com/users/vrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrv/subscriptions","organizations_url":"https://api.github.com/users/vrv/orgs","repos_url":"https://api.github.com/users/vrv/repos","events_url":"https://api.github.com/users/vrv/events{/privacy}","received_events_url":"https://api.github.com/users/vrv/received_events","type":"User","site_admin":false},"body":"CuDNN versions with the same major version should be ABI\r\ncompatible, which means that if we release a binary\r\nwith cudnn version 5.1, it should be compatible with\r\na system whose runtime loads version 5.0.  This check\r\nwould trigger if the cudnn version loaded at runtime is\r\n5 but the compile-time version used was 4.\r\n\r\nThis change is based off of recommendations from\r\nhttps://github.com/tensorflow/tensorflow/issues/2525#issuecomment-223523008.\r\n\r\nFixes #3225.","created_at":"2016-07-09T23:03:20Z","updated_at":"2016-07-13T05:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dc186a04f70b5534ba610c74de73c517120d364","assignee":{"login":"zheng-xq","id":15736910,"avatar_url":"https://avatars.githubusercontent.com/u/15736910?v=3","gravatar_id":"","url":"https://api.github.com/users/zheng-xq","html_url":"https://github.com/zheng-xq","followers_url":"https://api.github.com/users/zheng-xq/followers","following_url":"https://api.github.com/users/zheng-xq/following{/other_user}","gists_url":"https://api.github.com/users/zheng-xq/gists{/gist_id}","starred_url":"https://api.github.com/users/zheng-xq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheng-xq/subscriptions","organizations_url":"https://api.github.com/users/zheng-xq/orgs","repos_url":"https://api.github.com/users/zheng-xq/repos","events_url":"https://api.github.com/users/zheng-xq/events{/privacy}","received_events_url":"https://api.github.com/users/zheng-xq/received_events","type":"User","site_admin":false},"assignees":[{"login":"zheng-xq","id":15736910,"avatar_url":"https://avatars.githubusercontent.com/u/15736910?v=3","gravatar_id":"","url":"https://api.github.com/users/zheng-xq","html_url":"https://github.com/zheng-xq","followers_url":"https://api.github.com/users/zheng-xq/followers","following_url":"https://api.github.com/users/zheng-xq/following{/other_user}","gists_url":"https://api.github.com/users/zheng-xq/gists{/gist_id}","starred_url":"https://api.github.com/users/zheng-xq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zheng-xq/subscriptions","organizations_url":"https://api.github.com/users/zheng-xq/orgs","repos_url":"https://api.github.com/users/zheng-xq/repos","events_url":"https://api.github.com/users/zheng-xq/events{/privacy}","received_events_url":"https://api.github.com/users/zheng-xq/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/3249/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/1416889464a7e2ea1ddfb773c07fc5f9f0c7cac8","head":{"label":"vrv:cudnn_version","ref":"cudnn_version","sha":"1416889464a7e2ea1ddfb773c07fc5f9f0c7cac8","user":{"login":"vrv","id":463737,"avatar_url":"https://avatars.githubusercontent.com/u/463737?v=3","gravatar_id":"","url":"https://api.github.com/users/vrv","html_url":"https://github.com/vrv","followers_url":"https://api.github.com/users/vrv/followers","following_url":"https://api.github.com/users/vrv/following{/other_user}","gists_url":"https://api.github.com/users/vrv/gists{/gist_id}","starred_url":"https://api.github.com/users/vrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrv/subscriptions","organizations_url":"https://api.github.com/users/vrv/orgs","repos_url":"https://api.github.com/users/vrv/repos","events_url":"https://api.github.com/users/vrv/events{/privacy}","received_events_url":"https://api.github.com/users/vrv/received_events","type":"User","site_admin":false},"repo":{"id":51214789,"name":"tensorflow","full_name":"vrv/tensorflow","owner":{"login":"vrv","id":463737,"avatar_url":"https://avatars.githubusercontent.com/u/463737?v=3","gravatar_id":"","url":"https://api.github.com/users/vrv","html_url":"https://github.com/vrv","followers_url":"https://api.github.com/users/vrv/followers","following_url":"https://api.github.com/users/vrv/following{/other_user}","gists_url":"https://api.github.com/users/vrv/gists{/gist_id}","starred_url":"https://api.github.com/users/vrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrv/subscriptions","organizations_url":"https://api.github.com/users/vrv/orgs","repos_url":"https://api.github.com/users/vrv/repos","events_url":"https://api.github.com/users/vrv/events{/privacy}","received_events_url":"https://api.github.com/users/vrv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vrv/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/vrv/tensorflow","forks_url":"https://api.github.com/repos/vrv/tensorflow/forks","keys_url":"https://api.github.com/repos/vrv/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrv/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrv/tensorflow/teams","hooks_url":"https://api.github.com/repos/vrv/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/vrv/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/vrv/tensorflow/events","assignees_url":"https://api.github.com/repos/vrv/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/vrv/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/vrv/tensorflow/tags","blobs_url":"https://api.github.com/repos/vrv/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrv/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrv/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrv/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrv/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/vrv/tensorflow/languages","stargazers_url":"https://api.github.com/repos/vrv/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/vrv/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/vrv/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/vrv/tensorflow/subscription","commits_url":"https://api.github.com/repos/vrv/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrv/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrv/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrv/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrv/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/vrv/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrv/tensorflow/merges","archive_url":"https://api.github.com/repos/vrv/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrv/tensorflow/downloads","issues_url":"https://api.github.com/repos/vrv/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/vrv/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/vrv/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/vrv/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrv/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/vrv/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/vrv/tensorflow/deployments","created_at":"2016-02-06T18:16:58Z","updated_at":"2016-02-06T18:17:03Z","pushed_at":"2016-07-12T23:08:58Z","git_url":"git://github.com/vrv/tensorflow.git","ssh_url":"git@github.com:vrv/tensorflow.git","clone_url":"https://github.com/vrv/tensorflow.git","svn_url":"https://github.com/vrv/tensorflow","homepage":"http://tensorflow.org","size":51886,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"5db7366cf6d7d011e5a3b4bc00c21612acc0940a","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2016-07-13T05:15:41Z","pushed_at":"2016-07-13T05:22:00Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"http://tensorflow.org","size":214278,"stargazers_count":27912,"watchers_count":27912,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11332,"mirror_url":null,"open_issues_count":409,"forks":11332,"open_issues":409,"watchers":27912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/3249"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/3249"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/3249/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/3249/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/1416889464a7e2ea1ddfb773c07fc5f9f0c7cac8"}}}}
{"actor":{"display_login":"zheng-xq"}}