{"action":"created","comment":{"url":"https://api.github.com/repos/kinetiknz/cubeb/pulls/comments/86286046","pull_request_review_id":6950594,"id":86286046,"diff_hunk":"@@ -1529,13 +1560,13 @@ audiounit_stream_init(cubeb * context,\n   if (input_stream_params) {\n     stm->input_stream_params = *input_stream_params;\n     stm->input_device = input_device;\n+    stm->is_default_input = input_device == nullptr ||\n+                            (audiounit_get_default_device_id(CUBEB_DEVICE_TYPE_INPUT) ==\n+                                                  reinterpret_cast<intptr_t>(input_device));","path":"src/cubeb_audiounit.cpp","position":334,"original_position":187,"commit_id":"d57397b5e58aeeff0861c1c4f2616fcf28b2e560","original_commit_id":"d57397b5e58aeeff0861c1c4f2616fcf28b2e560","user":{"login":"kinetiknz","id":67343,"avatar_url":"https://avatars.githubusercontent.com/u/67343?v=3","gravatar_id":"","url":"https://api.github.com/users/kinetiknz","html_url":"https://github.com/kinetiknz","followers_url":"https://api.github.com/users/kinetiknz/followers","following_url":"https://api.github.com/users/kinetiknz/following{/other_user}","gists_url":"https://api.github.com/users/kinetiknz/gists{/gist_id}","starred_url":"https://api.github.com/users/kinetiknz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinetiknz/subscriptions","organizations_url":"https://api.github.com/users/kinetiknz/orgs","repos_url":"https://api.github.com/users/kinetiknz/repos","events_url":"https://api.github.com/users/kinetiknz/events{/privacy}","received_events_url":"https://api.github.com/users/kinetiknz/received_events","type":"User","site_admin":false},"body":"You can rebase on top of https://github.com/kinetiknz/cubeb/tree/cubeb_devid_cleanup and the intptr_t cast won't be necessary any longer.","created_at":"2016-11-03T04:50:01Z","updated_at":"2016-11-03T04:50:01Z","html_url":"https://github.com/kinetiknz/cubeb/pull/179#discussion_r86286046","pull_request_url":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/kinetiknz/cubeb/pulls/comments/86286046"},"html":{"href":"https://github.com/kinetiknz/cubeb/pull/179#discussion_r86286046"},"pull_request":{"href":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179","id":91658617,"html_url":"https://github.com/kinetiknz/cubeb/pull/179","diff_url":"https://github.com/kinetiknz/cubeb/pull/179.diff","patch_url":"https://github.com/kinetiknz/cubeb/pull/179.patch","issue_url":"https://api.github.com/repos/kinetiknz/cubeb/issues/179","number":179,"state":"open","locked":false,"title":"audiounit: Crash and device switch fixes","user":{"login":"achronop","id":1420722,"avatar_url":"https://avatars.githubusercontent.com/u/1420722?v=3","gravatar_id":"","url":"https://api.github.com/users/achronop","html_url":"https://github.com/achronop","followers_url":"https://api.github.com/users/achronop/followers","following_url":"https://api.github.com/users/achronop/following{/other_user}","gists_url":"https://api.github.com/users/achronop/gists{/gist_id}","starred_url":"https://api.github.com/users/achronop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achronop/subscriptions","organizations_url":"https://api.github.com/users/achronop/orgs","repos_url":"https://api.github.com/users/achronop/repos","events_url":"https://api.github.com/users/achronop/events{/privacy}","received_events_url":"https://api.github.com/users/achronop/received_events","type":"User","site_admin":false},"body":"The branch contains an number of fixes found using the Logitech c920 and c930 webcam.\r\n\r\n- Bug1306247: Do not crash when camera is unplugged.\r\n- Bug1272386: Do not assert on debug when c930 starts.\r\n- Bug1311911: Build up latency with c920.\r\n- Switch to default device when camera is unplugged or when a different default device is chosen from audio settings.\r\n- Add some useful debug logs.\r\n- Correct small errors.\r\n\r\nAbout device switching behavior a discussion is on going on #167. The device switching behavior implemented here is not the final but a good compromise till we reach to a conclusion.","created_at":"2016-10-31T17:59:42Z","updated_at":"2016-11-03T04:50:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbb1f6019fed123f4805372103a1ec8615b9c5cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179/commits","review_comments_url":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179/comments","review_comment_url":"https://api.github.com/repos/kinetiknz/cubeb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kinetiknz/cubeb/issues/179/comments","statuses_url":"https://api.github.com/repos/kinetiknz/cubeb/statuses/d57397b5e58aeeff0861c1c4f2616fcf28b2e560","head":{"label":"achronop:osx-fixes-logitech-webcam","ref":"osx-fixes-logitech-webcam","sha":"d57397b5e58aeeff0861c1c4f2616fcf28b2e560","user":{"login":"achronop","id":1420722,"avatar_url":"https://avatars.githubusercontent.com/u/1420722?v=3","gravatar_id":"","url":"https://api.github.com/users/achronop","html_url":"https://github.com/achronop","followers_url":"https://api.github.com/users/achronop/followers","following_url":"https://api.github.com/users/achronop/following{/other_user}","gists_url":"https://api.github.com/users/achronop/gists{/gist_id}","starred_url":"https://api.github.com/users/achronop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achronop/subscriptions","organizations_url":"https://api.github.com/users/achronop/orgs","repos_url":"https://api.github.com/users/achronop/repos","events_url":"https://api.github.com/users/achronop/events{/privacy}","received_events_url":"https://api.github.com/users/achronop/received_events","type":"User","site_admin":false},"repo":{"id":47107597,"name":"cubeb","full_name":"achronop/cubeb","owner":{"login":"achronop","id":1420722,"avatar_url":"https://avatars.githubusercontent.com/u/1420722?v=3","gravatar_id":"","url":"https://api.github.com/users/achronop","html_url":"https://github.com/achronop","followers_url":"https://api.github.com/users/achronop/followers","following_url":"https://api.github.com/users/achronop/following{/other_user}","gists_url":"https://api.github.com/users/achronop/gists{/gist_id}","starred_url":"https://api.github.com/users/achronop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achronop/subscriptions","organizations_url":"https://api.github.com/users/achronop/orgs","repos_url":"https://api.github.com/users/achronop/repos","events_url":"https://api.github.com/users/achronop/events{/privacy}","received_events_url":"https://api.github.com/users/achronop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achronop/cubeb","description":"Cross platform audio library","fork":true,"url":"https://api.github.com/repos/achronop/cubeb","forks_url":"https://api.github.com/repos/achronop/cubeb/forks","keys_url":"https://api.github.com/repos/achronop/cubeb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achronop/cubeb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achronop/cubeb/teams","hooks_url":"https://api.github.com/repos/achronop/cubeb/hooks","issue_events_url":"https://api.github.com/repos/achronop/cubeb/issues/events{/number}","events_url":"https://api.github.com/repos/achronop/cubeb/events","assignees_url":"https://api.github.com/repos/achronop/cubeb/assignees{/user}","branches_url":"https://api.github.com/repos/achronop/cubeb/branches{/branch}","tags_url":"https://api.github.com/repos/achronop/cubeb/tags","blobs_url":"https://api.github.com/repos/achronop/cubeb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achronop/cubeb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achronop/cubeb/git/refs{/sha}","trees_url":"https://api.github.com/repos/achronop/cubeb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achronop/cubeb/statuses/{sha}","languages_url":"https://api.github.com/repos/achronop/cubeb/languages","stargazers_url":"https://api.github.com/repos/achronop/cubeb/stargazers","contributors_url":"https://api.github.com/repos/achronop/cubeb/contributors","subscribers_url":"https://api.github.com/repos/achronop/cubeb/subscribers","subscription_url":"https://api.github.com/repos/achronop/cubeb/subscription","commits_url":"https://api.github.com/repos/achronop/cubeb/commits{/sha}","git_commits_url":"https://api.github.com/repos/achronop/cubeb/git/commits{/sha}","comments_url":"https://api.github.com/repos/achronop/cubeb/comments{/number}","issue_comment_url":"https://api.github.com/repos/achronop/cubeb/issues/comments{/number}","contents_url":"https://api.github.com/repos/achronop/cubeb/contents/{+path}","compare_url":"https://api.github.com/repos/achronop/cubeb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achronop/cubeb/merges","archive_url":"https://api.github.com/repos/achronop/cubeb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achronop/cubeb/downloads","issues_url":"https://api.github.com/repos/achronop/cubeb/issues{/number}","pulls_url":"https://api.github.com/repos/achronop/cubeb/pulls{/number}","milestones_url":"https://api.github.com/repos/achronop/cubeb/milestones{/number}","notifications_url":"https://api.github.com/repos/achronop/cubeb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achronop/cubeb/labels{/name}","releases_url":"https://api.github.com/repos/achronop/cubeb/releases{/id}","deployments_url":"https://api.github.com/repos/achronop/cubeb/deployments","created_at":"2015-11-30T09:16:03Z","updated_at":"2016-07-08T08:35:45Z","pushed_at":"2016-11-01T17:53:29Z","git_url":"git://github.com/achronop/cubeb.git","ssh_url":"git@github.com:achronop/cubeb.git","clone_url":"https://github.com/achronop/cubeb.git","svn_url":"https://github.com/achronop/cubeb","homepage":"","size":1874,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kinetiknz:master","ref":"master","sha":"3d2a2e9c1d89ea658a2af18d46956010290da2e2","user":{"login":"kinetiknz","id":67343,"avatar_url":"https://avatars.githubusercontent.com/u/67343?v=3","gravatar_id":"","url":"https://api.github.com/users/kinetiknz","html_url":"https://github.com/kinetiknz","followers_url":"https://api.github.com/users/kinetiknz/followers","following_url":"https://api.github.com/users/kinetiknz/following{/other_user}","gists_url":"https://api.github.com/users/kinetiknz/gists{/gist_id}","starred_url":"https://api.github.com/users/kinetiknz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinetiknz/subscriptions","organizations_url":"https://api.github.com/users/kinetiknz/orgs","repos_url":"https://api.github.com/users/kinetiknz/repos","events_url":"https://api.github.com/users/kinetiknz/events{/privacy}","received_events_url":"https://api.github.com/users/kinetiknz/received_events","type":"User","site_admin":false},"repo":{"id":2016094,"name":"cubeb","full_name":"kinetiknz/cubeb","owner":{"login":"kinetiknz","id":67343,"avatar_url":"https://avatars.githubusercontent.com/u/67343?v=3","gravatar_id":"","url":"https://api.github.com/users/kinetiknz","html_url":"https://github.com/kinetiknz","followers_url":"https://api.github.com/users/kinetiknz/followers","following_url":"https://api.github.com/users/kinetiknz/following{/other_user}","gists_url":"https://api.github.com/users/kinetiknz/gists{/gist_id}","starred_url":"https://api.github.com/users/kinetiknz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinetiknz/subscriptions","organizations_url":"https://api.github.com/users/kinetiknz/orgs","repos_url":"https://api.github.com/users/kinetiknz/repos","events_url":"https://api.github.com/users/kinetiknz/events{/privacy}","received_events_url":"https://api.github.com/users/kinetiknz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinetiknz/cubeb","description":"Cross platform audio library","fork":false,"url":"https://api.github.com/repos/kinetiknz/cubeb","forks_url":"https://api.github.com/repos/kinetiknz/cubeb/forks","keys_url":"https://api.github.com/repos/kinetiknz/cubeb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinetiknz/cubeb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinetiknz/cubeb/teams","hooks_url":"https://api.github.com/repos/kinetiknz/cubeb/hooks","issue_events_url":"https://api.github.com/repos/kinetiknz/cubeb/issues/events{/number}","events_url":"https://api.github.com/repos/kinetiknz/cubeb/events","assignees_url":"https://api.github.com/repos/kinetiknz/cubeb/assignees{/user}","branches_url":"https://api.github.com/repos/kinetiknz/cubeb/branches{/branch}","tags_url":"https://api.github.com/repos/kinetiknz/cubeb/tags","blobs_url":"https://api.github.com/repos/kinetiknz/cubeb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinetiknz/cubeb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinetiknz/cubeb/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinetiknz/cubeb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinetiknz/cubeb/statuses/{sha}","languages_url":"https://api.github.com/repos/kinetiknz/cubeb/languages","stargazers_url":"https://api.github.com/repos/kinetiknz/cubeb/stargazers","contributors_url":"https://api.github.com/repos/kinetiknz/cubeb/contributors","subscribers_url":"https://api.github.com/repos/kinetiknz/cubeb/subscribers","subscription_url":"https://api.github.com/repos/kinetiknz/cubeb/subscription","commits_url":"https://api.github.com/repos/kinetiknz/cubeb/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinetiknz/cubeb/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinetiknz/cubeb/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinetiknz/cubeb/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinetiknz/cubeb/contents/{+path}","compare_url":"https://api.github.com/repos/kinetiknz/cubeb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinetiknz/cubeb/merges","archive_url":"https://api.github.com/repos/kinetiknz/cubeb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinetiknz/cubeb/downloads","issues_url":"https://api.github.com/repos/kinetiknz/cubeb/issues{/number}","pulls_url":"https://api.github.com/repos/kinetiknz/cubeb/pulls{/number}","milestones_url":"https://api.github.com/repos/kinetiknz/cubeb/milestones{/number}","notifications_url":"https://api.github.com/repos/kinetiknz/cubeb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinetiknz/cubeb/labels{/name}","releases_url":"https://api.github.com/repos/kinetiknz/cubeb/releases{/id}","deployments_url":"https://api.github.com/repos/kinetiknz/cubeb/deployments","created_at":"2011-07-08T04:20:48Z","updated_at":"2016-10-24T19:13:14Z","pushed_at":"2016-11-03T04:49:03Z","git_url":"git://github.com/kinetiknz/cubeb.git","ssh_url":"git@github.com:kinetiknz/cubeb.git","clone_url":"https://github.com/kinetiknz/cubeb.git","svn_url":"https://github.com/kinetiknz/cubeb","homepage":"","size":2097,"stargazers_count":50,"watchers_count":50,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":16,"forks":31,"open_issues":16,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179"},"html":{"href":"https://github.com/kinetiknz/cubeb/pull/179"},"issue":{"href":"https://api.github.com/repos/kinetiknz/cubeb/issues/179"},"comments":{"href":"https://api.github.com/repos/kinetiknz/cubeb/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/kinetiknz/cubeb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kinetiknz/cubeb/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/kinetiknz/cubeb/statuses/d57397b5e58aeeff0861c1c4f2616fcf28b2e560"}}}}
{"actor":{"display_login":"kinetiknz"}}