{"action":"created","comment":{"url":"https://api.github.com/repos/heroku/identity/pulls/comments/53720438","id":53720438,"diff_hunk":"@@ -546,6 +546,57 @@ def app\n       assert_match /Vorboten/, last_response.body\n     end\n \n+    describe \"exising sessions\" do\n+      let(:session_id) { \"1234\" }\n+      let(:rack_env) do\n+        {\n+          \"rack.session\" => {\n+            \"oauth_session_id\" => session_id, \"access_token\" => \"5678\"\n+          }\n+        }\n+      end\n+\n+      it \"clears an existing session\" do\n+        post \"/login\",\n+          {email: \"kerry@heroku.com\", password: \"abcdefgh\"}, rack_env\n+\n+        assert_match /^heroku_user_session=(.+)$/, response_cookie,\n+              \"it should contain a new session\"","path":"test/auth_test.rb","position":19,"original_position":19,"commit_id":"a80fc542b11d363f14311e56eaba3589c2db8dbf","original_commit_id":"a80fc542b11d363f14311e56eaba3589c2db8dbf","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Align the parameters of a method call if they span more than one line.","created_at":"2016-02-23T00:48:43Z","updated_at":"2016-02-23T00:48:43Z","html_url":"https://github.com/heroku/identity/pull/214#discussion_r53720438","pull_request_url":"https://api.github.com/repos/heroku/identity/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/heroku/identity/pulls/comments/53720438"},"html":{"href":"https://github.com/heroku/identity/pull/214#discussion_r53720438"},"pull_request":{"href":"https://api.github.com/repos/heroku/identity/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/heroku/identity/pulls/214","id":60268730,"html_url":"https://github.com/heroku/identity/pull/214","diff_url":"https://github.com/heroku/identity/pull/214.diff","patch_url":"https://github.com/heroku/identity/pull/214.patch","issue_url":"https://api.github.com/repos/heroku/identity/issues/214","number":214,"state":"open","locked":false,"title":"Flush previous session on login","user":{"login":"dmcinnes","id":16557,"avatar_url":"https://avatars.githubusercontent.com/u/16557?v=3","gravatar_id":"","url":"https://api.github.com/users/dmcinnes","html_url":"https://github.com/dmcinnes","followers_url":"https://api.github.com/users/dmcinnes/followers","following_url":"https://api.github.com/users/dmcinnes/following{/other_user}","gists_url":"https://api.github.com/users/dmcinnes/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcinnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcinnes/subscriptions","organizations_url":"https://api.github.com/users/dmcinnes/orgs","repos_url":"https://api.github.com/users/dmcinnes/repos","events_url":"https://api.github.com/users/dmcinnes/events{/privacy}","received_events_url":"https://api.github.com/users/dmcinnes/received_events","type":"User","site_admin":false},"body":"This updates the login endpoint to force any previous sessions attached to the browser to explicitly log out before the new user logs in.","created_at":"2016-02-23T00:48:36Z","updated_at":"2016-02-23T00:48:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc8c5f008b544661a598bd161b1206ce1f98c652","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/heroku/identity/pulls/214/commits","review_comments_url":"https://api.github.com/repos/heroku/identity/pulls/214/comments","review_comment_url":"https://api.github.com/repos/heroku/identity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heroku/identity/issues/214/comments","statuses_url":"https://api.github.com/repos/heroku/identity/statuses/a80fc542b11d363f14311e56eaba3589c2db8dbf","head":{"label":"heroku:doug/flush-previous-session-on-login","ref":"doug/flush-previous-session-on-login","sha":"a80fc542b11d363f14311e56eaba3589c2db8dbf","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":7472185,"name":"identity","full_name":"heroku/identity","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/identity","description":"Login and OAuth management service for Heroku","fork":false,"url":"https://api.github.com/repos/heroku/identity","forks_url":"https://api.github.com/repos/heroku/identity/forks","keys_url":"https://api.github.com/repos/heroku/identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/identity/teams","hooks_url":"https://api.github.com/repos/heroku/identity/hooks","issue_events_url":"https://api.github.com/repos/heroku/identity/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/identity/events","assignees_url":"https://api.github.com/repos/heroku/identity/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/identity/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/identity/tags","blobs_url":"https://api.github.com/repos/heroku/identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/identity/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/identity/languages","stargazers_url":"https://api.github.com/repos/heroku/identity/stargazers","contributors_url":"https://api.github.com/repos/heroku/identity/contributors","subscribers_url":"https://api.github.com/repos/heroku/identity/subscribers","subscription_url":"https://api.github.com/repos/heroku/identity/subscription","commits_url":"https://api.github.com/repos/heroku/identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/identity/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/identity/merges","archive_url":"https://api.github.com/repos/heroku/identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/identity/downloads","issues_url":"https://api.github.com/repos/heroku/identity/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/identity/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/identity/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/identity/labels{/name}","releases_url":"https://api.github.com/repos/heroku/identity/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/identity/deployments","created_at":"2013-01-06T20:17:00Z","updated_at":"2016-02-20T01:05:32Z","pushed_at":"2016-02-23T00:48:37Z","git_url":"git://github.com/heroku/identity.git","ssh_url":"git@github.com:heroku/identity.git","clone_url":"https://github.com/heroku/identity.git","svn_url":"https://github.com/heroku/identity","homepage":"https://id.heroku.com/","size":2317,"stargazers_count":244,"watchers_count":244,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":18,"forks":15,"open_issues":18,"watchers":244,"default_branch":"master"}},"base":{"label":"heroku:master","ref":"master","sha":"3e6f30387d31f7e40821d0bd18596d57ff198e84","user":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"repo":{"id":7472185,"name":"identity","full_name":"heroku/identity","owner":{"login":"heroku","id":23211,"avatar_url":"https://avatars.githubusercontent.com/u/23211?v=3","gravatar_id":"","url":"https://api.github.com/users/heroku","html_url":"https://github.com/heroku","followers_url":"https://api.github.com/users/heroku/followers","following_url":"https://api.github.com/users/heroku/following{/other_user}","gists_url":"https://api.github.com/users/heroku/gists{/gist_id}","starred_url":"https://api.github.com/users/heroku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heroku/subscriptions","organizations_url":"https://api.github.com/users/heroku/orgs","repos_url":"https://api.github.com/users/heroku/repos","events_url":"https://api.github.com/users/heroku/events{/privacy}","received_events_url":"https://api.github.com/users/heroku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heroku/identity","description":"Login and OAuth management service for Heroku","fork":false,"url":"https://api.github.com/repos/heroku/identity","forks_url":"https://api.github.com/repos/heroku/identity/forks","keys_url":"https://api.github.com/repos/heroku/identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heroku/identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heroku/identity/teams","hooks_url":"https://api.github.com/repos/heroku/identity/hooks","issue_events_url":"https://api.github.com/repos/heroku/identity/issues/events{/number}","events_url":"https://api.github.com/repos/heroku/identity/events","assignees_url":"https://api.github.com/repos/heroku/identity/assignees{/user}","branches_url":"https://api.github.com/repos/heroku/identity/branches{/branch}","tags_url":"https://api.github.com/repos/heroku/identity/tags","blobs_url":"https://api.github.com/repos/heroku/identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heroku/identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heroku/identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/heroku/identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heroku/identity/statuses/{sha}","languages_url":"https://api.github.com/repos/heroku/identity/languages","stargazers_url":"https://api.github.com/repos/heroku/identity/stargazers","contributors_url":"https://api.github.com/repos/heroku/identity/contributors","subscribers_url":"https://api.github.com/repos/heroku/identity/subscribers","subscription_url":"https://api.github.com/repos/heroku/identity/subscription","commits_url":"https://api.github.com/repos/heroku/identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/heroku/identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/heroku/identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/heroku/identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/heroku/identity/contents/{+path}","compare_url":"https://api.github.com/repos/heroku/identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heroku/identity/merges","archive_url":"https://api.github.com/repos/heroku/identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heroku/identity/downloads","issues_url":"https://api.github.com/repos/heroku/identity/issues{/number}","pulls_url":"https://api.github.com/repos/heroku/identity/pulls{/number}","milestones_url":"https://api.github.com/repos/heroku/identity/milestones{/number}","notifications_url":"https://api.github.com/repos/heroku/identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heroku/identity/labels{/name}","releases_url":"https://api.github.com/repos/heroku/identity/releases{/id}","deployments_url":"https://api.github.com/repos/heroku/identity/deployments","created_at":"2013-01-06T20:17:00Z","updated_at":"2016-02-20T01:05:32Z","pushed_at":"2016-02-23T00:48:37Z","git_url":"git://github.com/heroku/identity.git","ssh_url":"git@github.com:heroku/identity.git","clone_url":"https://github.com/heroku/identity.git","svn_url":"https://github.com/heroku/identity","homepage":"https://id.heroku.com/","size":2317,"stargazers_count":244,"watchers_count":244,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":18,"forks":15,"open_issues":18,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heroku/identity/pulls/214"},"html":{"href":"https://github.com/heroku/identity/pull/214"},"issue":{"href":"https://api.github.com/repos/heroku/identity/issues/214"},"comments":{"href":"https://api.github.com/repos/heroku/identity/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/heroku/identity/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/heroku/identity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heroku/identity/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/heroku/identity/statuses/a80fc542b11d363f14311e56eaba3589c2db8dbf"}}}}