{"action":"created","issue":{"url":"https://api.github.com/repos/davidker/unisys/issues/14","repository_url":"https://api.github.com/repos/davidker/unisys","labels_url":"https://api.github.com/repos/davidker/unisys/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/davidker/unisys/issues/14/comments","events_url":"https://api.github.com/repos/davidker/unisys/issues/14/events","html_url":"https://github.com/davidker/unisys/issues/14","id":140543961,"number":14,"title":"Get rid of unused code.","user":{"login":"davidker","id":11467670,"avatar_url":"https://avatars.githubusercontent.com/u/11467670?v=3","gravatar_id":"","url":"https://api.github.com/users/davidker","html_url":"https://github.com/davidker","followers_url":"https://api.github.com/users/davidker/followers","following_url":"https://api.github.com/users/davidker/following{/other_user}","gists_url":"https://api.github.com/users/davidker/gists{/gist_id}","starred_url":"https://api.github.com/users/davidker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidker/subscriptions","organizations_url":"https://api.github.com/users/davidker/orgs","repos_url":"https://api.github.com/users/davidker/repos","events_url":"https://api.github.com/users/davidker/events{/privacy}","received_events_url":"https://api.github.com/users/davidker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-13T23:42:55Z","updated_at":"2016-03-14T13:03:01Z","closed_at":null,"body":"`static ssize_t chipsetready_store(struct device *dev,\r\n                                  struct device_attribute *attr,\r\n                                  const char *buf, size_t count)\r\n{\r\n        char msgtype[64];\r\n\r\n        if (sscanf(buf, \"%63s\", msgtype) != 1)\r\n                return -EINVAL;\r\n\r\n        if (!strcmp(msgtype, \"CALLHOMEDISK_MOUNTED\")) {\r\n                chipset_events[0] = 1;\r\n                return count;\r\n        } else if (!strcmp(msgtype, \"MODULES_LOADED\")) {\r\n                chipset_events[1] = 1;\r\n                return count;\r\n        }\r\n        return -EINVAL;\r\n}\r\n`\r\n\r\nDo we really need this in a guest?  Isn't CALLHOMEDISK_MOUNTED just a Service Partition call?  Modules_LOADED is that still needed when it gets loaded on demand? "},"comment":{"url":"https://api.github.com/repos/davidker/unisys/issues/comments/196300493","html_url":"https://github.com/davidker/unisys/issues/14#issuecomment-196300493","issue_url":"https://api.github.com/repos/davidker/unisys/issues/14","id":196300493,"user":{"login":"selltc","id":12817577,"avatar_url":"https://avatars.githubusercontent.com/u/12817577?v=3","gravatar_id":"","url":"https://api.github.com/users/selltc","html_url":"https://github.com/selltc","followers_url":"https://api.github.com/users/selltc/followers","following_url":"https://api.github.com/users/selltc/following{/other_user}","gists_url":"https://api.github.com/users/selltc/gists{/gist_id}","starred_url":"https://api.github.com/users/selltc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selltc/subscriptions","organizations_url":"https://api.github.com/users/selltc/orgs","repos_url":"https://api.github.com/users/selltc/repos","events_url":"https://api.github.com/users/selltc/events{/privacy}","received_events_url":"https://api.github.com/users/selltc/received_events","type":"User","site_admin":false},"created_at":"2016-03-14T13:03:01Z","updated_at":"2016-03-14T13:03:01Z","body":"It seems it might be appropriate to just narrow the scope of this issue to handle the cleaning up of the sysfs attribute stuff, including removing unused code.  So I will rename this issue accordingly.  Feel free to name it otherwise if you disagree.  I figure that we can add other issues to remove other instances of unused code when/if we find them."}}