{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/65820708","id":65820708,"diff_hunk":"@@ -243,8 +246,20 @@ private static void checkSequence(long sequence) {\n         try {\n             final Future future = new ClientInvocation(getClient(), clientMessage, partitionId).invoke();\n             return (T) future.get();\n+        } catch (ExecutionException e) {\n+            if (e.getCause() instanceof StaleSequenceException) {\n+                StaleSequenceException se = (StaleSequenceException) e.getCause();\n+                long l = headSequence();\n+                throw new StaleSequenceException(se.getMessage(), l);","path":"hazelcast-client/src/main/java/com/hazelcast/client/proxy/ClientRingbufferProxy.java","position":31,"original_position":31,"commit_id":"62badb9cd1cca47fb0ee15054d06e5c09c86f0f6","original_commit_id":"62badb9cd1cca47fb0ee15054d06e5c09c86f0f6","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"body":"this is ugly as stacktraces are lost. the other option is to set the `headSeq` via reflection....","created_at":"2016-06-05T17:10:42Z","updated_at":"2016-06-05T17:10:42Z","html_url":"https://github.com/hazelcast/hazelcast/pull/8323#discussion_r65820708","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/65820708"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/8323#discussion_r65820708"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323","id":72634673,"html_url":"https://github.com/hazelcast/hazelcast/pull/8323","diff_url":"https://github.com/hazelcast/hazelcast/pull/8323.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/8323.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/8323","number":8323,"state":"open","locked":false,"title":"Include headSeq in StaleSequenceException on a client-side","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"body":"It's a similar issue to #7317 - I'm applying the same workaround.\r\n\r\nAlso I added `toString()` to client proxy implementation\r\nand re-used RingbufferAbstractTest on a client side.","created_at":"2016-06-05T17:10:02Z","updated_at":"2016-06-05T17:10:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56cd5ae8d9e375bf38a73e097236beb97d1f9900","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/70","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.7","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/70/labels","id":1346433,"number":70,"title":"3.7","description":"","creator":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"open_issues":173,"closed_issues":630,"state":"open","created_at":"2015-10-09T12:16:13Z","updated_at":"2016-06-05T17:10:02Z","due_on":"2016-06-19T21:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/8323/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/62badb9cd1cca47fb0ee15054d06e5c09c86f0f6","head":{"label":"jerrinot:fixes/ringbuffer-client/master","ref":"fixes/ringbuffer-client/master","sha":"62badb9cd1cca47fb0ee15054d06e5c09c86f0f6","user":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"repo":{"id":14844579,"name":"hazelcast","full_name":"jerrinot/hazelcast","owner":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars.githubusercontent.com/u/158619?v=3","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerrinot/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/jerrinot/hazelcast","forks_url":"https://api.github.com/repos/jerrinot/hazelcast/forks","keys_url":"https://api.github.com/repos/jerrinot/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerrinot/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerrinot/hazelcast/teams","hooks_url":"https://api.github.com/repos/jerrinot/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/jerrinot/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/jerrinot/hazelcast/events","assignees_url":"https://api.github.com/repos/jerrinot/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/jerrinot/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/jerrinot/hazelcast/tags","blobs_url":"https://api.github.com/repos/jerrinot/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerrinot/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerrinot/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerrinot/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerrinot/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/jerrinot/hazelcast/languages","stargazers_url":"https://api.github.com/repos/jerrinot/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/jerrinot/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/jerrinot/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/jerrinot/hazelcast/subscription","commits_url":"https://api.github.com/repos/jerrinot/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerrinot/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerrinot/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerrinot/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerrinot/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/jerrinot/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerrinot/hazelcast/merges","archive_url":"https://api.github.com/repos/jerrinot/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerrinot/hazelcast/downloads","issues_url":"https://api.github.com/repos/jerrinot/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/jerrinot/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/jerrinot/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/jerrinot/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerrinot/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/jerrinot/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/jerrinot/hazelcast/deployments","created_at":"2013-12-01T19:18:56Z","updated_at":"2015-04-27T20:28:12Z","pushed_at":"2016-06-05T17:09:47Z","git_url":"git://github.com/jerrinot/hazelcast.git","ssh_url":"git@github.com:jerrinot/hazelcast.git","clone_url":"https://github.com/jerrinot/hazelcast.git","svn_url":"https://github.com/jerrinot/hazelcast","homepage":"www.hazelcast.com","size":94919,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"e4ed42188bd7ebeb79a2e27a912ba50f6b43ed9b","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-06-04T11:01:19Z","pushed_at":"2016-06-05T17:10:03Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":127487,"stargazers_count":1591,"watchers_count":1591,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":751,"mirror_url":null,"open_issues_count":602,"forks":751,"open_issues":602,"watchers":1591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/8323"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/8323"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/8323/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/8323/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/62badb9cd1cca47fb0ee15054d06e5c09c86f0f6"}}}}
{"actor":{"display_login":"jerrinot"}}