{"action":"created","issue":{"url":"https://api.github.com/repos/henrytao-me/smooth-app-bar-layout/issues/74","repository_url":"https://api.github.com/repos/henrytao-me/smooth-app-bar-layout","labels_url":"https://api.github.com/repos/henrytao-me/smooth-app-bar-layout/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/henrytao-me/smooth-app-bar-layout/issues/74/comments","events_url":"https://api.github.com/repos/henrytao-me/smooth-app-bar-layout/issues/74/events","html_url":"https://github.com/henrytao-me/smooth-app-bar-layout/issues/74","id":133824855,"number":74,"title":"Dynamic AppBar Height","user":{"login":"lishiyo","id":7489058,"avatar_url":"https://avatars.githubusercontent.com/u/7489058?v=3","gravatar_id":"","url":"https://api.github.com/users/lishiyo","html_url":"https://github.com/lishiyo","followers_url":"https://api.github.com/users/lishiyo/followers","following_url":"https://api.github.com/users/lishiyo/following{/other_user}","gists_url":"https://api.github.com/users/lishiyo/gists{/gist_id}","starred_url":"https://api.github.com/users/lishiyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lishiyo/subscriptions","organizations_url":"https://api.github.com/users/lishiyo/orgs","repos_url":"https://api.github.com/users/lishiyo/repos","events_url":"https://api.github.com/users/lishiyo/events{/privacy}","received_events_url":"https://api.github.com/users/lishiyo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-15T21:47:42Z","updated_at":"2016-02-16T21:54:53Z","closed_at":null,"body":"Hi there! Thanks so much for making this. I was wondering, is there a way to support variable/dynamic appbarlayout heights, where my appbar wraps a placeholder fragment that when swapped can end up any height? \r\n\r\n```\r\n<me.henrytao.smoothappbarlayout.SmoothAppBarLayout\r\n\t\tandroid:id=\"@+id/appbar\"\r\n\t\tandroid:layout_width=\"match_parent\"\r\n\t\tandroid:layout_height=\"wrap_content\"\r\n\t\tandroid:minHeight=\"50dp\">\r\n\t\t\t<!-- Header placeholder -->\r\n\t\t\t<FrameLayout\r\n\t\t\t\tandroid:id=\"@+id/header_fragment_placeholder\"\r\n\t\t\t\tapp:layout_scrollFlags=\"scroll\"\r\n\t\t\t\tandroid:layout_width=\"match_parent\"\r\n\t\t\t\tandroid:layout_height=\"wrap_content\" />\r\n</me.henrytao.smoothappbarlayout.SmoothAppBarLayout>\r\n// ...\r\n<ViewPager />\r\n```\r\n\r\n^^My xml. In your examples it seems that `SmoothAppBarLayout` is a fixed height, rather than `wrap_content`. I set a minimum height as I'm using a viewpager, but the recyclerviews in the viewpager are being cropped at the top - it's clear the `SmoothAppBarLayout` height doesn't include the instantiated header fragment height. Is it possible to do so? "},"comment":{"url":"https://api.github.com/repos/henrytao-me/smooth-app-bar-layout/issues/comments/184890618","html_url":"https://github.com/henrytao-me/smooth-app-bar-layout/issues/74#issuecomment-184890618","issue_url":"https://api.github.com/repos/henrytao-me/smooth-app-bar-layout/issues/74","id":184890618,"user":{"login":"henrytao-me","id":5274722,"avatar_url":"https://avatars.githubusercontent.com/u/5274722?v=3","gravatar_id":"","url":"https://api.github.com/users/henrytao-me","html_url":"https://github.com/henrytao-me","followers_url":"https://api.github.com/users/henrytao-me/followers","following_url":"https://api.github.com/users/henrytao-me/following{/other_user}","gists_url":"https://api.github.com/users/henrytao-me/gists{/gist_id}","starred_url":"https://api.github.com/users/henrytao-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrytao-me/subscriptions","organizations_url":"https://api.github.com/users/henrytao-me/orgs","repos_url":"https://api.github.com/users/henrytao-me/repos","events_url":"https://api.github.com/users/henrytao-me/events{/privacy}","received_events_url":"https://api.github.com/users/henrytao-me/received_events","type":"User","site_admin":false},"created_at":"2016-02-16T21:54:53Z","updated_at":"2016-02-16T21:54:53Z","body":"Hi @lishiyo \r\n\r\nI don't think delay adding header fragment causes any problem. \r\n\r\nI modified the code like below. After 3s, it still worked correctly. \r\n\r\n```java\r\n    new Handler().postDelayed(new Runnable() {\r\n      @Override\r\n      public void run() {\r\n        getSupportFragmentManager()\r\n            .beginTransaction()\r\n            .replace(R.id.header_holder_fragment, mHeaderHolderFragment)\r\n            .commit();\r\n      }\r\n    }, 3000);\r\n```\r\n\r\nWould you mind to record a video to show the issue? "}}