{"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/68140199","id":68140199,"diff_hunk":"@@ -85,6 +85,7 @@ def get_enrollments(ccns, term_yr, term_cd)\n             attrs[:email] = attrs.delete :email_address\n             attrs[:majors] = section_enrollments_by_uid[attrs[:ldap_uid]].collect { |e| e['major'] }\n             if (enrollment_row = section_enrollments_by_uid[attrs[:ldap_uid]].first)\n+              attrs[:student_id] = enrollment_row['student_id']","path":"app/models/rosters/common.rb","position":4,"original_position":4,"commit_id":"330fa1015daa14528a0f1c77d3ef00b2b61cb446","original_commit_id":"330fa1015daa14528a0f1c77d3ef00b2b61cb446","user":{"login":"redconfetti","id":746759,"avatar_url":"https://avatars.githubusercontent.com/u/746759?v=3","gravatar_id":"","url":"https://api.github.com/users/redconfetti","html_url":"https://github.com/redconfetti","followers_url":"https://api.github.com/users/redconfetti/followers","following_url":"https://api.github.com/users/redconfetti/following{/other_user}","gists_url":"https://api.github.com/users/redconfetti/gists{/gist_id}","starred_url":"https://api.github.com/users/redconfetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redconfetti/subscriptions","organizations_url":"https://api.github.com/users/redconfetti/orgs","repos_url":"https://api.github.com/users/redconfetti/repos","events_url":"https://api.github.com/users/redconfetti/events{/privacy}","received_events_url":"https://api.github.com/users/redconfetti/received_events","type":"User","site_admin":false},"body":"@paulkerschen. I assume that your next commit will change some logic to ensure that the student ID isn't overwritten when not present?","created_at":"2016-06-22T21:37:56Z","updated_at":"2016-06-22T21:37:56Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5553#discussion_r68140199","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/68140199"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/5553#discussion_r68140199"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553","id":74848072,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5553","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5553.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5553.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5553","number":5553,"state":"open","locked":false,"title":"SISRP-21615 Use EDO DB, not LDAP, as student id source in rosters","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"body":"https://jira.berkeley.edu/browse/SISRP-21615","created_at":"2016-06-22T20:06:39Z","updated_at":"2016-06-22T21:37:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"789f6919a2f8ac63553efd6c2b473bead3226d16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5553/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/330fa1015daa14528a0f1c77d3ef00b2b61cb446","head":{"label":"paulkerschen:sisrp-21615","ref":"sisrp-21615","sha":"330fa1015daa14528a0f1c77d3ef00b2b61cb446","user":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"repo":{"id":26028641,"name":"calcentral","full_name":"paulkerschen/calcentral","owner":{"login":"paulkerschen","id":2413467,"avatar_url":"https://avatars.githubusercontent.com/u/2413467?v=3","gravatar_id":"","url":"https://api.github.com/users/paulkerschen","html_url":"https://github.com/paulkerschen","followers_url":"https://api.github.com/users/paulkerschen/followers","following_url":"https://api.github.com/users/paulkerschen/following{/other_user}","gists_url":"https://api.github.com/users/paulkerschen/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkerschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkerschen/subscriptions","organizations_url":"https://api.github.com/users/paulkerschen/orgs","repos_url":"https://api.github.com/users/paulkerschen/repos","events_url":"https://api.github.com/users/paulkerschen/events{/privacy}","received_events_url":"https://api.github.com/users/paulkerschen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulkerschen/calcentral","description":"","fork":true,"url":"https://api.github.com/repos/paulkerschen/calcentral","forks_url":"https://api.github.com/repos/paulkerschen/calcentral/forks","keys_url":"https://api.github.com/repos/paulkerschen/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulkerschen/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulkerschen/calcentral/teams","hooks_url":"https://api.github.com/repos/paulkerschen/calcentral/hooks","issue_events_url":"https://api.github.com/repos/paulkerschen/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/paulkerschen/calcentral/events","assignees_url":"https://api.github.com/repos/paulkerschen/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/paulkerschen/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/paulkerschen/calcentral/tags","blobs_url":"https://api.github.com/repos/paulkerschen/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulkerschen/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulkerschen/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulkerschen/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulkerschen/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/paulkerschen/calcentral/languages","stargazers_url":"https://api.github.com/repos/paulkerschen/calcentral/stargazers","contributors_url":"https://api.github.com/repos/paulkerschen/calcentral/contributors","subscribers_url":"https://api.github.com/repos/paulkerschen/calcentral/subscribers","subscription_url":"https://api.github.com/repos/paulkerschen/calcentral/subscription","commits_url":"https://api.github.com/repos/paulkerschen/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulkerschen/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulkerschen/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulkerschen/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulkerschen/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/paulkerschen/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulkerschen/calcentral/merges","archive_url":"https://api.github.com/repos/paulkerschen/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulkerschen/calcentral/downloads","issues_url":"https://api.github.com/repos/paulkerschen/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/paulkerschen/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/paulkerschen/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/paulkerschen/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulkerschen/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/paulkerschen/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/paulkerschen/calcentral/deployments","created_at":"2014-10-31T18:41:02Z","updated_at":"2016-01-14T04:21:14Z","pushed_at":"2016-06-22T20:05:40Z","git_url":"git://github.com/paulkerschen/calcentral.git","ssh_url":"git@github.com:paulkerschen/calcentral.git","clone_url":"https://github.com/paulkerschen/calcentral.git","svn_url":"https://github.com/paulkerschen/calcentral","homepage":"https://calcentral.berkeley.edu","size":22446,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"mirror"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"a4cd9737ddec474773623827ebf098a8197a780f","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":"","fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2016-06-10T18:11:04Z","pushed_at":"2016-06-22T20:56:21Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":28972,"stargazers_count":60,"watchers_count":60,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":1,"forks":60,"open_issues":1,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/5553"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5553"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5553/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5553/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/330fa1015daa14528a0f1c77d3ef00b2b61cb446"}}}}
{"actor":{"display_login":"redconfetti"}}