{"action":"closed","number":6267,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/6267","id":85560214,"html_url":"https://github.com/juju/juju/pull/6267","diff_url":"https://github.com/juju/juju/pull/6267.diff","patch_url":"https://github.com/juju/juju/pull/6267.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/6267","number":6267,"state":"closed","locked":false,"title":"Update LXD network templates for Juju","user":{"login":"macgreagoir","id":5586350,"avatar_url":"https://avatars.githubusercontent.com/u/5586350?v=3","gravatar_id":"","url":"https://api.github.com/users/macgreagoir","html_url":"https://github.com/macgreagoir","followers_url":"https://api.github.com/users/macgreagoir/followers","following_url":"https://api.github.com/users/macgreagoir/following{/other_user}","gists_url":"https://api.github.com/users/macgreagoir/gists{/gist_id}","starred_url":"https://api.github.com/users/macgreagoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macgreagoir/subscriptions","organizations_url":"https://api.github.com/users/macgreagoir/orgs","repos_url":"https://api.github.com/users/macgreagoir/repos","events_url":"https://api.github.com/users/macgreagoir/events{/privacy}","received_events_url":"https://api.github.com/users/macgreagoir/received_events","type":"User","site_admin":false},"body":"Adds the ability to write out LXD templates before a container is\r\nstarted, and uses this to update the networking templates with what Juju\r\nrequires for the container's ENI.\r\n\r\nThis prevents the default LXD behaviour, which is to expect DHCP on\r\neth0, breaking container provisioning when DHCP is not available on eth0.\r\n\r\nFixes lp:1611981\r\n\r\nQA steps:\r\n  * Test in a MAAS environment with two NICs per node, where the NIC with the higher sorting name  is on the PXE/DHCP space, and ensuring the other space does not serve DHCP\r\n    - NICs can be renamed in MAAS on a node's page\r\n    - For example, if ens3 and ens4 are named by default, and ens3 is the PXE/DHCP interface, rename ens3 as 'nicZ' and ens4 as 'nicA'\r\n    - You may also like to assign a static IP addr to the second ('nicA' in this example) interface\r\n  * `juju add-machine lxd:<host>` for a xenial container\r\n    - The container should start\r\n    - In the container, `/etc/network/interfaces` should source `/etc/network/interfaces.d/*.cfg`\r\n    - In the container, `/etc/network/interfaces.d/` should have a `.cfg` file configuring its interfaces and nameservers correct for the environment (eth0 with an address in nicA's space, in this example, and eth1 in nicZ's)\r\n  * Repeat with a trusty container, `juju add-machine --series trusty lxd:<host>`\r\n\r\n(RB link: http://reviews.vapour.ws/r/5706/)","created_at":"2016-09-16T11:51:01Z","updated_at":"2016-09-28T13:39:55Z","closed_at":"2016-09-28T13:39:55Z","merged_at":null,"merge_commit_sha":"c52abdef3ce9653a8155769395d704666376c67b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/6267/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/6267/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/6267/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/cd3dda0ab1d0acadfbaace5f940778e054298ccb","head":{"label":"macgreagoir:lxd-network-templates","ref":"lxd-network-templates","sha":"cd3dda0ab1d0acadfbaace5f940778e054298ccb","user":{"login":"macgreagoir","id":5586350,"avatar_url":"https://avatars.githubusercontent.com/u/5586350?v=3","gravatar_id":"","url":"https://api.github.com/users/macgreagoir","html_url":"https://github.com/macgreagoir","followers_url":"https://api.github.com/users/macgreagoir/followers","following_url":"https://api.github.com/users/macgreagoir/following{/other_user}","gists_url":"https://api.github.com/users/macgreagoir/gists{/gist_id}","starred_url":"https://api.github.com/users/macgreagoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macgreagoir/subscriptions","organizations_url":"https://api.github.com/users/macgreagoir/orgs","repos_url":"https://api.github.com/users/macgreagoir/repos","events_url":"https://api.github.com/users/macgreagoir/events{/privacy}","received_events_url":"https://api.github.com/users/macgreagoir/received_events","type":"User","site_admin":false},"repo":{"id":59470253,"name":"juju","full_name":"macgreagoir/juju","owner":{"login":"macgreagoir","id":5586350,"avatar_url":"https://avatars.githubusercontent.com/u/5586350?v=3","gravatar_id":"","url":"https://api.github.com/users/macgreagoir","html_url":"https://github.com/macgreagoir","followers_url":"https://api.github.com/users/macgreagoir/followers","following_url":"https://api.github.com/users/macgreagoir/following{/other_user}","gists_url":"https://api.github.com/users/macgreagoir/gists{/gist_id}","starred_url":"https://api.github.com/users/macgreagoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macgreagoir/subscriptions","organizations_url":"https://api.github.com/users/macgreagoir/orgs","repos_url":"https://api.github.com/users/macgreagoir/repos","events_url":"https://api.github.com/users/macgreagoir/events{/privacy}","received_events_url":"https://api.github.com/users/macgreagoir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/macgreagoir/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/macgreagoir/juju","forks_url":"https://api.github.com/repos/macgreagoir/juju/forks","keys_url":"https://api.github.com/repos/macgreagoir/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macgreagoir/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macgreagoir/juju/teams","hooks_url":"https://api.github.com/repos/macgreagoir/juju/hooks","issue_events_url":"https://api.github.com/repos/macgreagoir/juju/issues/events{/number}","events_url":"https://api.github.com/repos/macgreagoir/juju/events","assignees_url":"https://api.github.com/repos/macgreagoir/juju/assignees{/user}","branches_url":"https://api.github.com/repos/macgreagoir/juju/branches{/branch}","tags_url":"https://api.github.com/repos/macgreagoir/juju/tags","blobs_url":"https://api.github.com/repos/macgreagoir/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macgreagoir/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macgreagoir/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/macgreagoir/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macgreagoir/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/macgreagoir/juju/languages","stargazers_url":"https://api.github.com/repos/macgreagoir/juju/stargazers","contributors_url":"https://api.github.com/repos/macgreagoir/juju/contributors","subscribers_url":"https://api.github.com/repos/macgreagoir/juju/subscribers","subscription_url":"https://api.github.com/repos/macgreagoir/juju/subscription","commits_url":"https://api.github.com/repos/macgreagoir/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/macgreagoir/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/macgreagoir/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/macgreagoir/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/macgreagoir/juju/contents/{+path}","compare_url":"https://api.github.com/repos/macgreagoir/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macgreagoir/juju/merges","archive_url":"https://api.github.com/repos/macgreagoir/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macgreagoir/juju/downloads","issues_url":"https://api.github.com/repos/macgreagoir/juju/issues{/number}","pulls_url":"https://api.github.com/repos/macgreagoir/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/macgreagoir/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/macgreagoir/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macgreagoir/juju/labels{/name}","releases_url":"https://api.github.com/repos/macgreagoir/juju/releases{/id}","deployments_url":"https://api.github.com/repos/macgreagoir/juju/deployments","created_at":"2016-05-23T09:35:20Z","updated_at":"2016-05-23T09:35:30Z","pushed_at":"2016-09-27T16:41:45Z","git_url":"git://github.com/macgreagoir/juju.git","ssh_url":"git@github.com:macgreagoir/juju.git","clone_url":"https://github.com/macgreagoir/juju.git","svn_url":"https://github.com/macgreagoir/juju","homepage":"juju.ubuntu.com","size":95664,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"34284ed594d6424fa7c778914c5c5f8d99bf0e68","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2016-09-28T03:53:39Z","pushed_at":"2016-09-28T13:39:31Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":125972,"stargazers_count":508,"watchers_count":508,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":20,"forks":158,"open_issues":20,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/6267"},"html":{"href":"https://github.com/juju/juju/pull/6267"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/6267"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/6267/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/6267/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/6267/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/cd3dda0ab1d0acadfbaace5f940778e054298ccb"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":273,"deletions":21,"changed_files":5}}
{"actor":{"display_login":"macgreagoir"}}