{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15143","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15143/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15143/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15143/events","html_url":"https://github.com/mantidproject/mantid/pull/15143","id":130630161,"number":15143,"title":"Fix Lambda min and Lambda max in old Reflectometry GUI","user":{"login":"MattKing06","id":13132124,"avatar_url":"https://avatars.githubusercontent.com/u/13132124?v=3","gravatar_id":"","url":"https://api.github.com/users/MattKing06","html_url":"https://github.com/MattKing06","followers_url":"https://api.github.com/users/MattKing06/followers","following_url":"https://api.github.com/users/MattKing06/following{/other_user}","gists_url":"https://api.github.com/users/MattKing06/gists{/gist_id}","starred_url":"https://api.github.com/users/MattKing06/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattKing06/subscriptions","organizations_url":"https://api.github.com/users/MattKing06/orgs","repos_url":"https://api.github.com/users/MattKing06/repos","events_url":"https://api.github.com/users/MattKing06/events{/privacy}","received_events_url":"https://api.github.com/users/MattKing06/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Reflectometry","name":"Component: Reflectometry","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bugfix","name":"Misc: Bugfix","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":554,"closed_issues":136,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-02-18T23:21:14Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":1,"created_at":"2016-02-02T09:49:11Z","updated_at":"2016-02-19T08:25:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15143","html_url":"https://github.com/mantidproject/mantid/pull/15143","diff_url":"https://github.com/mantidproject/mantid/pull/15143.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15143.patch"},"body":"**Code Review**\r\n- Make sure that there is no more addition to the Wavelength min and max that are retrieved from the IDFs of the reflectometry instruments.\r\n- Make sure the comments that mentioned the addition of constants are now removed\r\n- Make sure all other code changes make sense and are clean.\r\n\r\n**Tester** \r\n- Make sure that your managed data directory is able to use the data archive\r\n- Open the reflectometry interface `Interfaces > Reflectometry > ISIS Reflectometry`\r\n- Change the processing instrument to `SURF`\r\n- Insert this information into the processing table:\r\n- `Run(s):` 114150, `trans1:`114147\r\n- Click `Process`\r\n- Ensure that the `qmin_1` entry is populated with a value close to 0.048\r\n- Ensure that the `qmax_1` entry is populated with a value close to 0.7\r\n- Ensure that the `angle 1` entry is populated with a value of 1.5\r\n\r\n**Release Notes** //todo\r\n\r\n\r\nFixes #15131"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/186115237","html_url":"https://github.com/mantidproject/mantid/pull/15143#issuecomment-186115237","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15143","id":186115237,"user":{"login":"raquelalvarezbanos","id":8956985,"avatar_url":"https://avatars.githubusercontent.com/u/8956985?v=3","gravatar_id":"","url":"https://api.github.com/users/raquelalvarezbanos","html_url":"https://github.com/raquelalvarezbanos","followers_url":"https://api.github.com/users/raquelalvarezbanos/followers","following_url":"https://api.github.com/users/raquelalvarezbanos/following{/other_user}","gists_url":"https://api.github.com/users/raquelalvarezbanos/gists{/gist_id}","starred_url":"https://api.github.com/users/raquelalvarezbanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raquelalvarezbanos/subscriptions","organizations_url":"https://api.github.com/users/raquelalvarezbanos/orgs","repos_url":"https://api.github.com/users/raquelalvarezbanos/repos","events_url":"https://api.github.com/users/raquelalvarezbanos/events{/privacy}","received_events_url":"https://api.github.com/users/raquelalvarezbanos/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T08:25:22Z","updated_at":"2016-02-19T08:25:22Z","body":"Works as described: `qmin1` and `qmax1` are populated according to `Q = 4 * pi / lambda * sin(theta)`, and `lambda` values used are those read from the parameter file (addition constants were removed). Please @MattKing06 don't forget to update the release notes."}}