{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4326","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4326/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4326/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4326/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/4326","id":181838029,"number":4326,"title":"Framedump: Merge screenshot code with framedumping.","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-08T17:24:21Z","updated_at":"2016-10-09T02:46:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4326","html_url":"https://github.com/dolphin-emu/dolphin/pull/4326","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4326.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4326.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4326)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/252460821","html_url":"https://github.com/dolphin-emu/dolphin/pull/4326#issuecomment-252460821","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4326","id":252460821,"user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars.githubusercontent.com/u/11288319?v=3","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"created_at":"2016-10-09T02:46:07Z","updated_at":"2016-10-09T02:46:07Z","body":"\n\n\n\nReviewed 15 of 15 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[Source/Core/VideoCommon/RenderBase.cpp, line 567 at r1](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4326#-KTbJNwoWgYt3h8eeJeD:-KTbJNwoWgYt3h8eeJeE:b-thnekj) ([raw file](https://github.com/dolphin-emu/dolphin/blob/64927a2f81fe64503060c949ead525995fd63a2a/Source/Core/VideoCommon/RenderBase.cpp#L567)):*\n> ```cpp\n> \n>   // TODO: Refactor this. Right now it's needed for the implace flipping of the image.\n>   m_frame_data.assign(data, data + stride * h);\n> ```\n\nCould this allocation/copy be skipped if the image doesn't need to be flipped?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dolphin-emu/dolphin/4326)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"stenzek"}}