{"action":"created","comment":{"url":"https://api.github.com/repos/latchset/custodia/pulls/comments/60072806","id":60072806,"diff_hunk":"@@ -414,4 +423,7 @@ def get_socket(self):\n         return (self.httpd.socket, self.httpd.socket_file)\n \n     def serve(self):\n+        if sd_notify is not None and systemd_booted():\n+            logger.debug('sd_notify(\"READY=1\")')","path":"custodia/httpd/server.py","position":28,"original_position":28,"commit_id":"75c37c6906c4597a53c5abea8c5e1c1eb2be124e","original_commit_id":"75c37c6906c4597a53c5abea8c5e1c1eb2be124e","user":{"login":"simo5","id":8332609,"avatar_url":"https://avatars.githubusercontent.com/u/8332609?v=3","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false},"body":"What's the point of this log statement ?\r\nI do not think we really care to log a functional detail of the startup process, systemd is already loggin that for us.","created_at":"2016-04-18T14:53:44Z","updated_at":"2016-04-18T14:53:44Z","html_url":"https://github.com/latchset/custodia/pull/15#discussion_r60072806","pull_request_url":"https://api.github.com/repos/latchset/custodia/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/latchset/custodia/pulls/comments/60072806"},"html":{"href":"https://github.com/latchset/custodia/pull/15#discussion_r60072806"},"pull_request":{"href":"https://api.github.com/repos/latchset/custodia/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/latchset/custodia/pulls/15","id":66866250,"html_url":"https://github.com/latchset/custodia/pull/15","diff_url":"https://github.com/latchset/custodia/pull/15.diff","patch_url":"https://github.com/latchset/custodia/pull/15.patch","issue_url":"https://api.github.com/repos/latchset/custodia/issues/15","number":15,"state":"open","locked":false,"title":"Add sd_notify() call to custodia server","user":{"login":"tiran","id":444071,"avatar_url":"https://avatars.githubusercontent.com/u/444071?v=3","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"body":"The Custodia server is now able to notify systemd that it is ready to\r\nhandle requests. systemd.daemon.notify(\"READY=1\") is called after the\r\nlistening socket has been created and before the HTTP server starts its\r\nserver loop.\r\n\r\nCustodia depends on python-systemd or python3-systemd for notification.\r\nIf no systemd bindings are available or systemd isn't running,\r\nsd_notify() is not called.\r\n\r\nSigned-off-by: Christian Heimes <cheimes@redhat.com>","created_at":"2016-04-18T14:49:20Z","updated_at":"2016-04-18T14:53:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"978ac3c560c23659b57f0f15d3c31f010c0c5d13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/latchset/custodia/pulls/15/commits","review_comments_url":"https://api.github.com/repos/latchset/custodia/pulls/15/comments","review_comment_url":"https://api.github.com/repos/latchset/custodia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/latchset/custodia/issues/15/comments","statuses_url":"https://api.github.com/repos/latchset/custodia/statuses/75c37c6906c4597a53c5abea8c5e1c1eb2be124e","head":{"label":"tiran:sd_notify","ref":"sd_notify","sha":"75c37c6906c4597a53c5abea8c5e1c1eb2be124e","user":{"login":"tiran","id":444071,"avatar_url":"https://avatars.githubusercontent.com/u/444071?v=3","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"repo":{"id":38678584,"name":"custodia","full_name":"tiran/custodia","owner":{"login":"tiran","id":444071,"avatar_url":"https://avatars.githubusercontent.com/u/444071?v=3","gravatar_id":"","url":"https://api.github.com/users/tiran","html_url":"https://github.com/tiran","followers_url":"https://api.github.com/users/tiran/followers","following_url":"https://api.github.com/users/tiran/following{/other_user}","gists_url":"https://api.github.com/users/tiran/gists{/gist_id}","starred_url":"https://api.github.com/users/tiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiran/subscriptions","organizations_url":"https://api.github.com/users/tiran/orgs","repos_url":"https://api.github.com/users/tiran/repos","events_url":"https://api.github.com/users/tiran/events{/privacy}","received_events_url":"https://api.github.com/users/tiran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiran/custodia","description":"A service to manage, retrieve and store secrets","fork":true,"url":"https://api.github.com/repos/tiran/custodia","forks_url":"https://api.github.com/repos/tiran/custodia/forks","keys_url":"https://api.github.com/repos/tiran/custodia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiran/custodia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiran/custodia/teams","hooks_url":"https://api.github.com/repos/tiran/custodia/hooks","issue_events_url":"https://api.github.com/repos/tiran/custodia/issues/events{/number}","events_url":"https://api.github.com/repos/tiran/custodia/events","assignees_url":"https://api.github.com/repos/tiran/custodia/assignees{/user}","branches_url":"https://api.github.com/repos/tiran/custodia/branches{/branch}","tags_url":"https://api.github.com/repos/tiran/custodia/tags","blobs_url":"https://api.github.com/repos/tiran/custodia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiran/custodia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiran/custodia/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiran/custodia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiran/custodia/statuses/{sha}","languages_url":"https://api.github.com/repos/tiran/custodia/languages","stargazers_url":"https://api.github.com/repos/tiran/custodia/stargazers","contributors_url":"https://api.github.com/repos/tiran/custodia/contributors","subscribers_url":"https://api.github.com/repos/tiran/custodia/subscribers","subscription_url":"https://api.github.com/repos/tiran/custodia/subscription","commits_url":"https://api.github.com/repos/tiran/custodia/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiran/custodia/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiran/custodia/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiran/custodia/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiran/custodia/contents/{+path}","compare_url":"https://api.github.com/repos/tiran/custodia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiran/custodia/merges","archive_url":"https://api.github.com/repos/tiran/custodia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiran/custodia/downloads","issues_url":"https://api.github.com/repos/tiran/custodia/issues{/number}","pulls_url":"https://api.github.com/repos/tiran/custodia/pulls{/number}","milestones_url":"https://api.github.com/repos/tiran/custodia/milestones{/number}","notifications_url":"https://api.github.com/repos/tiran/custodia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiran/custodia/labels{/name}","releases_url":"https://api.github.com/repos/tiran/custodia/releases{/id}","deployments_url":"https://api.github.com/repos/tiran/custodia/deployments","created_at":"2015-07-07T09:45:01Z","updated_at":"2016-01-19T15:43:23Z","pushed_at":"2016-04-18T14:49:03Z","git_url":"git://github.com/tiran/custodia.git","ssh_url":"git@github.com:tiran/custodia.git","clone_url":"https://github.com/tiran/custodia.git","svn_url":"https://github.com/tiran/custodia","homepage":"","size":198,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"latchset:master","ref":"master","sha":"ed7205227316246d99a288d321dd63e9dc5be9f9","user":{"login":"latchset","id":17146082,"avatar_url":"https://avatars.githubusercontent.com/u/17146082?v=3","gravatar_id":"","url":"https://api.github.com/users/latchset","html_url":"https://github.com/latchset","followers_url":"https://api.github.com/users/latchset/followers","following_url":"https://api.github.com/users/latchset/following{/other_user}","gists_url":"https://api.github.com/users/latchset/gists{/gist_id}","starred_url":"https://api.github.com/users/latchset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latchset/subscriptions","organizations_url":"https://api.github.com/users/latchset/orgs","repos_url":"https://api.github.com/users/latchset/repos","events_url":"https://api.github.com/users/latchset/events{/privacy}","received_events_url":"https://api.github.com/users/latchset/received_events","type":"Organization","site_admin":false},"repo":{"id":31661898,"name":"custodia","full_name":"latchset/custodia","owner":{"login":"latchset","id":17146082,"avatar_url":"https://avatars.githubusercontent.com/u/17146082?v=3","gravatar_id":"","url":"https://api.github.com/users/latchset","html_url":"https://github.com/latchset","followers_url":"https://api.github.com/users/latchset/followers","following_url":"https://api.github.com/users/latchset/following{/other_user}","gists_url":"https://api.github.com/users/latchset/gists{/gist_id}","starred_url":"https://api.github.com/users/latchset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latchset/subscriptions","organizations_url":"https://api.github.com/users/latchset/orgs","repos_url":"https://api.github.com/users/latchset/repos","events_url":"https://api.github.com/users/latchset/events{/privacy}","received_events_url":"https://api.github.com/users/latchset/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/latchset/custodia","description":"A service to manage, retrieve and store secrets","fork":false,"url":"https://api.github.com/repos/latchset/custodia","forks_url":"https://api.github.com/repos/latchset/custodia/forks","keys_url":"https://api.github.com/repos/latchset/custodia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/latchset/custodia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/latchset/custodia/teams","hooks_url":"https://api.github.com/repos/latchset/custodia/hooks","issue_events_url":"https://api.github.com/repos/latchset/custodia/issues/events{/number}","events_url":"https://api.github.com/repos/latchset/custodia/events","assignees_url":"https://api.github.com/repos/latchset/custodia/assignees{/user}","branches_url":"https://api.github.com/repos/latchset/custodia/branches{/branch}","tags_url":"https://api.github.com/repos/latchset/custodia/tags","blobs_url":"https://api.github.com/repos/latchset/custodia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/latchset/custodia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/latchset/custodia/git/refs{/sha}","trees_url":"https://api.github.com/repos/latchset/custodia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/latchset/custodia/statuses/{sha}","languages_url":"https://api.github.com/repos/latchset/custodia/languages","stargazers_url":"https://api.github.com/repos/latchset/custodia/stargazers","contributors_url":"https://api.github.com/repos/latchset/custodia/contributors","subscribers_url":"https://api.github.com/repos/latchset/custodia/subscribers","subscription_url":"https://api.github.com/repos/latchset/custodia/subscription","commits_url":"https://api.github.com/repos/latchset/custodia/commits{/sha}","git_commits_url":"https://api.github.com/repos/latchset/custodia/git/commits{/sha}","comments_url":"https://api.github.com/repos/latchset/custodia/comments{/number}","issue_comment_url":"https://api.github.com/repos/latchset/custodia/issues/comments{/number}","contents_url":"https://api.github.com/repos/latchset/custodia/contents/{+path}","compare_url":"https://api.github.com/repos/latchset/custodia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/latchset/custodia/merges","archive_url":"https://api.github.com/repos/latchset/custodia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/latchset/custodia/downloads","issues_url":"https://api.github.com/repos/latchset/custodia/issues{/number}","pulls_url":"https://api.github.com/repos/latchset/custodia/pulls{/number}","milestones_url":"https://api.github.com/repos/latchset/custodia/milestones{/number}","notifications_url":"https://api.github.com/repos/latchset/custodia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/latchset/custodia/labels{/name}","releases_url":"https://api.github.com/repos/latchset/custodia/releases{/id}","deployments_url":"https://api.github.com/repos/latchset/custodia/deployments","created_at":"2015-03-04T14:45:03Z","updated_at":"2016-04-07T14:54:09Z","pushed_at":"2016-04-18T14:49:21Z","git_url":"git://github.com/latchset/custodia.git","ssh_url":"git@github.com:latchset/custodia.git","clone_url":"https://github.com/latchset/custodia.git","svn_url":"https://github.com/latchset/custodia","homepage":"","size":182,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/latchset/custodia/pulls/15"},"html":{"href":"https://github.com/latchset/custodia/pull/15"},"issue":{"href":"https://api.github.com/repos/latchset/custodia/issues/15"},"comments":{"href":"https://api.github.com/repos/latchset/custodia/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/latchset/custodia/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/latchset/custodia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/latchset/custodia/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/latchset/custodia/statuses/75c37c6906c4597a53c5abea8c5e1c1eb2be124e"}}}}