{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments/56124172","id":56124172,"diff_hunk":"@@ -99,18 +95,23 @@ public DefaultTokenCacheStore(Context context) {\n             throw new IllegalArgumentException(\"Context is null\");","path":"src/src/com/microsoft/aad/adal/DefaultTokenCacheStore.java","position":12,"original_position":12,"commit_id":"67877829dacf056a1cd4cb7176cfd968f4f56c3d","original_commit_id":"67877829dacf056a1cd4cb7176cfd968f4f56c3d","user":{"login":"agamemnum","id":9207562,"avatar_url":"https://avatars.githubusercontent.com/u/9207562?v=3","gravatar_id":"","url":"https://api.github.com/users/agamemnum","html_url":"https://github.com/agamemnum","followers_url":"https://api.github.com/users/agamemnum/followers","following_url":"https://api.github.com/users/agamemnum/following{/other_user}","gists_url":"https://api.github.com/users/agamemnum/gists{/gist_id}","starred_url":"https://api.github.com/users/agamemnum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agamemnum/subscriptions","organizations_url":"https://api.github.com/users/agamemnum/orgs","repos_url":"https://api.github.com/users/agamemnum/repos","events_url":"https://api.github.com/users/agamemnum/events{/privacy}","received_events_url":"https://api.github.com/users/agamemnum/received_events","type":"User","site_admin":false},"body":"nit: move it to the first line if null throw right away. Just simpler to read code","created_at":"2016-03-15T07:33:24Z","updated_at":"2016-03-15T07:33:24Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/539#discussion_r56124172","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments/56124172"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/539#discussion_r56124172"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539","id":62718925,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/539","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/539.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/539.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/539","number":539,"state":"open","locked":false,"title":"StorageHelper is singleton","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"body":"If SecretKey is null or failed to generate throw IlligalStateException\r\n(we should not allow null secret keys)\r\nRewrote all tests around encryption to use real methods instead of reflective ones","created_at":"2016-03-14T09:25:58Z","updated_at":"2016-03-15T07:33:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a85ebbad3561f52cd01095787a7a8aeacfa3e457","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/539/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/67877829dacf056a1cd4cb7176cfd968f4f56c3d","head":{"label":"imakhalova:cleanup3","ref":"cleanup3","sha":"67877829dacf056a1cd4cb7176cfd968f4f56c3d","user":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"repo":{"id":51237079,"name":"azure-activedirectory-library-for-android","full_name":"imakhalova/azure-activedirectory-library-for-android","owner":{"login":"imakhalova","id":15003397,"avatar_url":"https://avatars.githubusercontent.com/u/15003397?v=3","gravatar_id":"","url":"https://api.github.com/users/imakhalova","html_url":"https://github.com/imakhalova","followers_url":"https://api.github.com/users/imakhalova/followers","following_url":"https://api.github.com/users/imakhalova/following{/other_user}","gists_url":"https://api.github.com/users/imakhalova/gists{/gist_id}","starred_url":"https://api.github.com/users/imakhalova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imakhalova/subscriptions","organizations_url":"https://api.github.com/users/imakhalova/orgs","repos_url":"https://api.github.com/users/imakhalova/repos","events_url":"https://api.github.com/users/imakhalova/events{/privacy}","received_events_url":"https://api.github.com/users/imakhalova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android","description":"The ADAL SDK for Android gives you the ability to add support for Work Accounts to your application with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":true,"url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android","forks_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/forks","keys_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/teams","hooks_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/hooks","issue_events_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/events","assignees_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/tags","blobs_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/languages","stargazers_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/stargazers","contributors_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/contributors","subscribers_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/subscribers","subscription_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/subscription","commits_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/merges","archive_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/downloads","issues_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/labels{/name}","releases_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/imakhalova/azure-activedirectory-library-for-android/deployments","created_at":"2016-02-07T05:42:06Z","updated_at":"2016-02-07T05:42:07Z","pushed_at":"2016-03-14T23:19:17Z","git_url":"git://github.com/imakhalova/azure-activedirectory-library-for-android.git","ssh_url":"git@github.com:imakhalova/azure-activedirectory-library-for-android.git","clone_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android.git","svn_url":"https://github.com/imakhalova/azure-activedirectory-library-for-android","homepage":"http://www.windowsazure.com/en-us/services/active-directory/","size":9605,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"ad14383680fafc12ac0b51dd9824b3b1a11a1d43","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":14703238,"name":"azure-activedirectory-library-for-android","full_name":"AzureAD/azure-activedirectory-library-for-android","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android","description":"The ADAL SDK for Android gives you the ability to add support for Work Accounts to your application with just a few lines of additional code. This SDK gives your application the full functionality of Microsoft Azure AD, including industry standard protocol support for OAuth2, Web API integration with user level consent, and two factor authentication support.","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/releases{/id}","deployments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/deployments","created_at":"2013-11-26T00:59:05Z","updated_at":"2016-03-14T15:02:00Z","pushed_at":"2016-03-15T00:53:50Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-android.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-android.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-android","homepage":"http://www.windowsazure.com/en-us/services/active-directory/","size":23545,"stargazers_count":58,"watchers_count":58,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":57,"forks":49,"open_issues":57,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-android/pull/539"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/539"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-android/statuses/67877829dacf056a1cd4cb7176cfd968f4f56c3d"}}}}