{"action":"opened","issue":{"url":"https://api.github.com/repos/FundingCircle/shipment_tracker/issues/91","repository_url":"https://api.github.com/repos/FundingCircle/shipment_tracker","labels_url":"https://api.github.com/repos/FundingCircle/shipment_tracker/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/FundingCircle/shipment_tracker/issues/91/comments","events_url":"https://api.github.com/repos/FundingCircle/shipment_tracker/issues/91/events","html_url":"https://github.com/FundingCircle/shipment_tracker/issues/91","id":131109714,"number":91,"title":"Does not generate correct SHA or show correct status on merge commits","user":{"login":"eqdw","id":46030,"avatar_url":"https://avatars.githubusercontent.com/u/46030?v=3","gravatar_id":"","url":"https://api.github.com/users/eqdw","html_url":"https://github.com/eqdw","followers_url":"https://api.github.com/users/eqdw/followers","following_url":"https://api.github.com/users/eqdw/following{/other_user}","gists_url":"https://api.github.com/users/eqdw/gists{/gist_id}","starred_url":"https://api.github.com/users/eqdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqdw/subscriptions","organizations_url":"https://api.github.com/users/eqdw/orgs","repos_url":"https://api.github.com/users/eqdw/repos","events_url":"https://api.github.com/users/eqdw/events{/privacy}","received_events_url":"https://api.github.com/users/eqdw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-03T18:15:02Z","updated_at":"2016-02-03T18:15:02Z","closed_at":null,"body":"Working example: https://github.com/FundingCircle/us-direct-borrower/pull/628\r\n\r\nI've made two commits to this PR. On each commit, I opened up the status checks window, clicked 'details' next to the shipment tracker check to create a feature review, and everything worked as expected\r\n\r\n<img width=\"564\" alt=\"screen shot 2016-02-03 at 9 47 23 am\" src=\"https://cloud.githubusercontent.com/assets/46030/12791964/61fc2260-ca5e-11e5-91fa-0aeeda8965e2.png\">\r\n\r\n<img width=\"577\" alt=\"screen shot 2016-02-03 at 9 47 31 am\" src=\"https://cloud.githubusercontent.com/assets/46030/12791969/6987700c-ca5e-11e5-95b2-ec7dc8421d3c.png\">\r\n\r\n\r\nHowever, since the thing we're most interested in tracking is the unit of work, this is best represented by the merge commit. When we view the details on a merge commit, we can see the shipment tracker status check\r\n\r\n<img width=\"822\" alt=\"screen shot 2016-02-03 at 10 11 38 am\" src=\"https://cloud.githubusercontent.com/assets/46030/12791997/8cb4577a-ca5e-11e5-997c-35e2def46d58.png\">\r\n\r\nTwo issues occur:\r\n\r\n* *the 'details' link takes me to a feature review for the latest commit in this PR, and not the merge commit itself*\r\n* *the status check erroneously says 'no feature review found' when the details link points to an existing FR*\r\n\r\n----\r\n\r\nWe believe that the correct behaviour is that the details link for the merge commit should point to an FR with the SHA of the merge commit, and that the status check should accurately represent the presence or absence of that FR. \r\n\r\nIn the mean time, a workaround for the first issue is to manually create the FR from the merge commit SHA, either through the UI or through manual URL manipulation. \r\n\r\n"}}