{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/7814","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/7814/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7814/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/7814/events","html_url":"https://github.com/openshift/origin/pull/7814","id":138651957,"number":7814,"title":"Make conversions public for performance","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-03-05T06:09:41Z","updated_at":"2016-03-07T21:10:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7814","html_url":"https://github.com/openshift/origin/pull/7814","diff_url":"https://github.com/openshift/origin/pull/7814.diff","patch_url":"https://github.com/openshift/origin/pull/7814.patch"},"body":"Generates faster conversion code, removes allocations and reflection, and gets rid of warnings in tooling.\r\n\r\nFixes #7084\r\n\r\n[test]"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/193450554","html_url":"https://github.com/openshift/origin/pull/7814#issuecomment-193450554","issue_url":"https://api.github.com/repos/openshift/origin/issues/7814","id":193450554,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2016-03-07T21:10:55Z","updated_at":"2016-03-07T21:10:55Z","body":"The change is that we do that during generation.  If you declare a public\nconversion func, we don't add the defaulting.  I'm fine with adding to\nevery conversion.\n\nOn Mon, Mar 7, 2016 at 12:45 PM, David Eads <notifications@github.com>\nwrote:\n\n> I thought that the Converter applied the the defaultingFuncs before the\n> conversionFunc was looked up.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/openshift/origin/pull/7814#issuecomment-193389382>.\n>\n"}}