{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/60581983","id":60581983,"diff_hunk":"@@ -3519,8 +3529,8 @@ def test0(self):\n         if isinstance(mode_opt, compile.DebugMode):\n             self.assertRaises(ValueError, f)\n \n-        # Check stacktrace was copied over correctly after opt was applied\n-        self.assertTrue(check_stack_trace(f, ops_to_check='all'))\n+        # No need to check_stack_trace","path":"theano/tensor/tests/test_opt.py","position":null,"original_position":158,"commit_id":"895493523f52c5c8fde1d5391d34f4e7b56010ba","original_commit_id":"d89e1c4883cbe36b3f0651e327bbfeefbc4c87e3","user":{"login":"lamblin","id":178249,"avatar_url":"https://avatars.githubusercontent.com/u/178249?v=3","gravatar_id":"","url":"https://api.github.com/users/lamblin","html_url":"https://github.com/lamblin","followers_url":"https://api.github.com/users/lamblin/followers","following_url":"https://api.github.com/users/lamblin/following{/other_user}","gists_url":"https://api.github.com/users/lamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/lamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamblin/subscriptions","organizations_url":"https://api.github.com/users/lamblin/orgs","repos_url":"https://api.github.com/users/lamblin/repos","events_url":"https://api.github.com/users/lamblin/events{/privacy}","received_events_url":"https://api.github.com/users/lamblin/received_events","type":"User","site_admin":false},"body":"Please add a comment explaining _why_ there is no need.","created_at":"2016-04-21T13:45:42Z","updated_at":"2016-04-21T13:45:42Z","html_url":"https://github.com/Theano/Theano/pull/4383#discussion_r60581983","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/4383","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/60581983"},"html":{"href":"https://github.com/Theano/Theano/pull/4383#discussion_r60581983"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4383"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/4383","id":66731482,"html_url":"https://github.com/Theano/Theano/pull/4383","diff_url":"https://github.com/Theano/Theano/pull/4383.diff","patch_url":"https://github.com/Theano/Theano/pull/4383.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/4383","number":4383,"state":"open","locked":false,"title":"Make stack trace tests in `tensor/tests/test_opt.py` use `check_stack_trace`.","user":{"login":"saebrahimi","id":4037904,"avatar_url":"https://avatars.githubusercontent.com/u/4037904?v=3","gravatar_id":"","url":"https://api.github.com/users/saebrahimi","html_url":"https://github.com/saebrahimi","followers_url":"https://api.github.com/users/saebrahimi/followers","following_url":"https://api.github.com/users/saebrahimi/following{/other_user}","gists_url":"https://api.github.com/users/saebrahimi/gists{/gist_id}","starred_url":"https://api.github.com/users/saebrahimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saebrahimi/subscriptions","organizations_url":"https://api.github.com/users/saebrahimi/orgs","repos_url":"https://api.github.com/users/saebrahimi/repos","events_url":"https://api.github.com/users/saebrahimi/events{/privacy}","received_events_url":"https://api.github.com/users/saebrahimi/received_events","type":"User","site_admin":false},"body":"Modified test_opt.py to use check_stack_trace and modified check_stack_trace to loop over outputs for ops_to_check=last and some refactoring\r\n\r\nfix #4379 ","created_at":"2016-04-16T08:05:25Z","updated_at":"2016-04-21T13:45:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c8153d5ceffbf07d589efad74fe5731cbaa344a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/4383/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/4383/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/4383/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/895493523f52c5c8fde1d5391d34f4e7b56010ba","head":{"label":"saebrahimi:keep_stack_trace_tensor_tests/test_opt","ref":"keep_stack_trace_tensor_tests/test_opt","sha":"895493523f52c5c8fde1d5391d34f4e7b56010ba","user":{"login":"saebrahimi","id":4037904,"avatar_url":"https://avatars.githubusercontent.com/u/4037904?v=3","gravatar_id":"","url":"https://api.github.com/users/saebrahimi","html_url":"https://github.com/saebrahimi","followers_url":"https://api.github.com/users/saebrahimi/followers","following_url":"https://api.github.com/users/saebrahimi/following{/other_user}","gists_url":"https://api.github.com/users/saebrahimi/gists{/gist_id}","starred_url":"https://api.github.com/users/saebrahimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saebrahimi/subscriptions","organizations_url":"https://api.github.com/users/saebrahimi/orgs","repos_url":"https://api.github.com/users/saebrahimi/repos","events_url":"https://api.github.com/users/saebrahimi/events{/privacy}","received_events_url":"https://api.github.com/users/saebrahimi/received_events","type":"User","site_admin":false},"repo":{"id":56347002,"name":"Theano","full_name":"saebrahimi/Theano","owner":{"login":"saebrahimi","id":4037904,"avatar_url":"https://avatars.githubusercontent.com/u/4037904?v=3","gravatar_id":"","url":"https://api.github.com/users/saebrahimi","html_url":"https://github.com/saebrahimi","followers_url":"https://api.github.com/users/saebrahimi/followers","following_url":"https://api.github.com/users/saebrahimi/following{/other_user}","gists_url":"https://api.github.com/users/saebrahimi/gists{/gist_id}","starred_url":"https://api.github.com/users/saebrahimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saebrahimi/subscriptions","organizations_url":"https://api.github.com/users/saebrahimi/orgs","repos_url":"https://api.github.com/users/saebrahimi/repos","events_url":"https://api.github.com/users/saebrahimi/events{/privacy}","received_events_url":"https://api.github.com/users/saebrahimi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saebrahimi/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":true,"url":"https://api.github.com/repos/saebrahimi/Theano","forks_url":"https://api.github.com/repos/saebrahimi/Theano/forks","keys_url":"https://api.github.com/repos/saebrahimi/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saebrahimi/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saebrahimi/Theano/teams","hooks_url":"https://api.github.com/repos/saebrahimi/Theano/hooks","issue_events_url":"https://api.github.com/repos/saebrahimi/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/saebrahimi/Theano/events","assignees_url":"https://api.github.com/repos/saebrahimi/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/saebrahimi/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/saebrahimi/Theano/tags","blobs_url":"https://api.github.com/repos/saebrahimi/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saebrahimi/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saebrahimi/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/saebrahimi/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saebrahimi/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/saebrahimi/Theano/languages","stargazers_url":"https://api.github.com/repos/saebrahimi/Theano/stargazers","contributors_url":"https://api.github.com/repos/saebrahimi/Theano/contributors","subscribers_url":"https://api.github.com/repos/saebrahimi/Theano/subscribers","subscription_url":"https://api.github.com/repos/saebrahimi/Theano/subscription","commits_url":"https://api.github.com/repos/saebrahimi/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/saebrahimi/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/saebrahimi/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/saebrahimi/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/saebrahimi/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/saebrahimi/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saebrahimi/Theano/merges","archive_url":"https://api.github.com/repos/saebrahimi/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saebrahimi/Theano/downloads","issues_url":"https://api.github.com/repos/saebrahimi/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/saebrahimi/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/saebrahimi/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/saebrahimi/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saebrahimi/Theano/labels{/name}","releases_url":"https://api.github.com/repos/saebrahimi/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/saebrahimi/Theano/deployments","created_at":"2016-04-15T20:11:34Z","updated_at":"2016-04-15T20:11:37Z","pushed_at":"2016-04-21T12:41:06Z","git_url":"git://github.com/saebrahimi/Theano.git","ssh_url":"git@github.com:saebrahimi/Theano.git","clone_url":"https://github.com/saebrahimi/Theano.git","svn_url":"https://github.com/saebrahimi/Theano","homepage":"http://www.deeplearning.net/software/theano","size":51916,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"7e04466d9ff3a3b9446d2f814da87b305b9057ab","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2016-04-21T13:32:13Z","pushed_at":"2016-04-21T13:20:31Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":72060,"stargazers_count":3556,"watchers_count":3556,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1290,"mirror_url":null,"open_issues_count":638,"forks":1290,"open_issues":638,"watchers":3556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4383"},"html":{"href":"https://github.com/Theano/Theano/pull/4383"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/4383"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/4383/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4383/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/4383/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/895493523f52c5c8fde1d5391d34f4e7b56010ba"}}}}