{"action":"opened","number":35926,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35926","id":91685301,"html_url":"https://github.com/kubernetes/kubernetes/pull/35926","diff_url":"https://github.com/kubernetes/kubernetes/pull/35926.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/35926.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35926","number":35926,"state":"open","locked":false,"title":"Return proper error from openstack provider ExternalID","user":{"login":"ritchida","id":17182040,"avatar_url":"https://avatars.githubusercontent.com/u/17182040?v=3","gravatar_id":"","url":"https://api.github.com/users/ritchida","html_url":"https://github.com/ritchida","followers_url":"https://api.github.com/users/ritchida/followers","following_url":"https://api.github.com/users/ritchida/following{/other_user}","gists_url":"https://api.github.com/users/ritchida/gists{/gist_id}","starred_url":"https://api.github.com/users/ritchida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritchida/subscriptions","organizations_url":"https://api.github.com/users/ritchida/orgs","repos_url":"https://api.github.com/users/ritchida/repos","events_url":"https://api.github.com/users/ritchida/events{/privacy}","received_events_url":"https://api.github.com/users/ritchida/received_events","type":"User","site_admin":false},"body":"The node controller iterates over each node to determine whether it still exists.  It calls the provider's ExternalID function to determine this, looking for a specific error:  cloudprovider.InstanceNotFound.  If ExternalID does not return that specific error, the node controller will not evict the node even if it doesn't exist.  The openstack provider ExternalID function was not returning the proper error.","created_at":"2016-10-31T20:34:57Z","updated_at":"2016-10-31T20:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35926/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35926/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/35926/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/02c5ba186d4c014275717828d60abd52b527030b","head":{"label":"hpcloud:dr-remove-node-openstack","ref":"dr-remove-node-openstack","sha":"02c5ba186d4c014275717828d60abd52b527030b","user":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":46591836,"name":"kubernetes","full_name":"hpcloud/kubernetes","owner":{"login":"hpcloud","id":366390,"avatar_url":"https://avatars.githubusercontent.com/u/366390?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcloud","html_url":"https://github.com/hpcloud","followers_url":"https://api.github.com/users/hpcloud/followers","following_url":"https://api.github.com/users/hpcloud/following{/other_user}","gists_url":"https://api.github.com/users/hpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcloud/subscriptions","organizations_url":"https://api.github.com/users/hpcloud/orgs","repos_url":"https://api.github.com/users/hpcloud/repos","events_url":"https://api.github.com/users/hpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/hpcloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcloud/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/hpcloud/kubernetes","forks_url":"https://api.github.com/repos/hpcloud/kubernetes/forks","keys_url":"https://api.github.com/repos/hpcloud/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcloud/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcloud/kubernetes/teams","hooks_url":"https://api.github.com/repos/hpcloud/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hpcloud/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hpcloud/kubernetes/events","assignees_url":"https://api.github.com/repos/hpcloud/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hpcloud/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hpcloud/kubernetes/tags","blobs_url":"https://api.github.com/repos/hpcloud/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcloud/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcloud/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcloud/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcloud/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcloud/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hpcloud/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hpcloud/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hpcloud/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hpcloud/kubernetes/subscription","commits_url":"https://api.github.com/repos/hpcloud/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcloud/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcloud/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcloud/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcloud/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hpcloud/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcloud/kubernetes/merges","archive_url":"https://api.github.com/repos/hpcloud/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcloud/kubernetes/downloads","issues_url":"https://api.github.com/repos/hpcloud/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hpcloud/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcloud/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcloud/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcloud/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hpcloud/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hpcloud/kubernetes/deployments","created_at":"2015-11-20T23:11:23Z","updated_at":"2016-10-31T17:57:31Z","pushed_at":"2016-10-31T19:17:45Z","git_url":"git://github.com/hpcloud/kubernetes.git","ssh_url":"git@github.com:hpcloud/kubernetes.git","clone_url":"https://github.com/hpcloud/kubernetes.git","svn_url":"https://github.com/hpcloud/kubernetes","homepage":"http://kubernetes.io","size":345130,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e6b2517feba1152d50b1cab05a75c7e37fbc9943","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-10-31T18:09:15Z","pushed_at":"2016-10-31T20:34:57Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":609770,"stargazers_count":18044,"watchers_count":18044,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5894,"mirror_url":null,"open_issues_count":5174,"forks":5894,"open_issues":5174,"watchers":18044,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35926"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/35926"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/35926"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/35926/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35926/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/35926/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/02c5ba186d4c014275717828d60abd52b527030b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"ritchida"}}