{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/68149701","id":68149701,"diff_hunk":"@@ -0,0 +1,74 @@\n+/*\n+ * The Alluxio Open Foundation licenses this work under the Apache License, version 2.0\n+ * (the \"License\"). You may not use this work except in compliance with the License, which is\n+ * available at www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * This software is distributed on an \"AS IS\" basis, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,\n+ * either express or implied, as more fully set forth in the License.\n+ *\n+ * See the NOTICE file distributed with this work for information regarding copyright ownership.\n+ */\n+\n+package alluxio.collections;\n+\n+import java.util.Set;\n+\n+/**\n+ * An interface representing an index for this {@link IndexedSet}, each index for this set must\n+ * implement the interface to define how to get the value of the field chosen as the index. Users\n+ * must use the same instance of the implementation of this interface as the parameter in all\n+ * methods of {@link IndexedSet} to represent the same index.\n+ *\n+ * @param <T> type of objects in this {@link IndexedSet}\n+ */\n+interface FieldIndex<T> {\n+  /**\n+   * Gets the value of the field that serves as index.\n+   *\n+   * @param o the instance to get the field value from\n+   * @return the field value, which is just an Object\n+   */\n+  Object getFieldValue(T o);","path":"core/common/src/main/java/alluxio/collections/FieldIndex.java","position":31,"original_position":31,"commit_id":"5bc9df64c784ff7d31f3887f423342e62f7aaeee","original_commit_id":"5bc9df64c784ff7d31f3887f423342e62f7aaeee","user":{"login":"xhad1234","id":4424966,"avatar_url":"https://avatars.githubusercontent.com/u/4424966?v=3","gravatar_id":"","url":"https://api.github.com/users/xhad1234","html_url":"https://github.com/xhad1234","followers_url":"https://api.github.com/users/xhad1234/followers","following_url":"https://api.github.com/users/xhad1234/following{/other_user}","gists_url":"https://api.github.com/users/xhad1234/gists{/gist_id}","starred_url":"https://api.github.com/users/xhad1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhad1234/subscriptions","organizations_url":"https://api.github.com/users/xhad1234/orgs","repos_url":"https://api.github.com/users/xhad1234/repos","events_url":"https://api.github.com/users/xhad1234/events{/privacy}","received_events_url":"https://api.github.com/users/xhad1234/received_events","type":"User","site_admin":false},"body":"@aaudiber If we get rid of this method, user will have no way to get the FieldValue. Is that okay?","created_at":"2016-06-22T22:51:30Z","updated_at":"2016-06-22T22:51:30Z","html_url":"https://github.com/Alluxio/alluxio/pull/3555#discussion_r68149701","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/68149701"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/3555#discussion_r68149701"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555","id":74150480,"html_url":"https://github.com/Alluxio/alluxio/pull/3555","diff_url":"https://github.com/Alluxio/alluxio/pull/3555.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/3555.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3555","number":3555,"state":"open","locked":false,"title":"Memory optimization for IndexedSet","user":{"login":"xhad1234","id":4424966,"avatar_url":"https://avatars.githubusercontent.com/u/4424966?v=3","gravatar_id":"","url":"https://api.github.com/users/xhad1234","html_url":"https://github.com/xhad1234","followers_url":"https://api.github.com/users/xhad1234/followers","following_url":"https://api.github.com/users/xhad1234/following{/other_user}","gists_url":"https://api.github.com/users/xhad1234/gists{/gist_id}","starred_url":"https://api.github.com/users/xhad1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhad1234/subscriptions","organizations_url":"https://api.github.com/users/xhad1234/orgs","repos_url":"https://api.github.com/users/xhad1234/repos","events_url":"https://api.github.com/users/xhad1234/events{/privacy}","received_events_url":"https://api.github.com/users/xhad1234/received_events","type":"User","site_admin":false},"body":"- For unrepeatable indexedSet, remove the inner HashSet in each entry. While maintaining the inner HashSet for repeatable indexedSet.\r\n\r\n- A simple LoadGenerator creating empty files in flat hierarchy.","created_at":"2016-06-16T20:54:25Z","updated_at":"2016-06-22T22:51:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cba2bb785853f4abb3fb2dd363967f7558dfa762","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/3555/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/5bc9df64c784ff7d31f3887f423342e62f7aaeee","head":{"label":"xhad1234:memory_profiling","ref":"memory_profiling","sha":"5bc9df64c784ff7d31f3887f423342e62f7aaeee","user":{"login":"xhad1234","id":4424966,"avatar_url":"https://avatars.githubusercontent.com/u/4424966?v=3","gravatar_id":"","url":"https://api.github.com/users/xhad1234","html_url":"https://github.com/xhad1234","followers_url":"https://api.github.com/users/xhad1234/followers","following_url":"https://api.github.com/users/xhad1234/following{/other_user}","gists_url":"https://api.github.com/users/xhad1234/gists{/gist_id}","starred_url":"https://api.github.com/users/xhad1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhad1234/subscriptions","organizations_url":"https://api.github.com/users/xhad1234/orgs","repos_url":"https://api.github.com/users/xhad1234/repos","events_url":"https://api.github.com/users/xhad1234/events{/privacy}","received_events_url":"https://api.github.com/users/xhad1234/received_events","type":"User","site_admin":false},"repo":{"id":58971312,"name":"alluxio","full_name":"xhad1234/alluxio","owner":{"login":"xhad1234","id":4424966,"avatar_url":"https://avatars.githubusercontent.com/u/4424966?v=3","gravatar_id":"","url":"https://api.github.com/users/xhad1234","html_url":"https://github.com/xhad1234","followers_url":"https://api.github.com/users/xhad1234/followers","following_url":"https://api.github.com/users/xhad1234/following{/other_user}","gists_url":"https://api.github.com/users/xhad1234/gists{/gist_id}","starred_url":"https://api.github.com/users/xhad1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhad1234/subscriptions","organizations_url":"https://api.github.com/users/xhad1234/orgs","repos_url":"https://api.github.com/users/xhad1234/repos","events_url":"https://api.github.com/users/xhad1234/events{/privacy}","received_events_url":"https://api.github.com/users/xhad1234/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xhad1234/alluxio","description":"Alluxio, formerly Tachyon, Memory Speed Virtual Distributed Storage System","fork":true,"url":"https://api.github.com/repos/xhad1234/alluxio","forks_url":"https://api.github.com/repos/xhad1234/alluxio/forks","keys_url":"https://api.github.com/repos/xhad1234/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xhad1234/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xhad1234/alluxio/teams","hooks_url":"https://api.github.com/repos/xhad1234/alluxio/hooks","issue_events_url":"https://api.github.com/repos/xhad1234/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/xhad1234/alluxio/events","assignees_url":"https://api.github.com/repos/xhad1234/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/xhad1234/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/xhad1234/alluxio/tags","blobs_url":"https://api.github.com/repos/xhad1234/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xhad1234/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xhad1234/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/xhad1234/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xhad1234/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/xhad1234/alluxio/languages","stargazers_url":"https://api.github.com/repos/xhad1234/alluxio/stargazers","contributors_url":"https://api.github.com/repos/xhad1234/alluxio/contributors","subscribers_url":"https://api.github.com/repos/xhad1234/alluxio/subscribers","subscription_url":"https://api.github.com/repos/xhad1234/alluxio/subscription","commits_url":"https://api.github.com/repos/xhad1234/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/xhad1234/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/xhad1234/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/xhad1234/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/xhad1234/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/xhad1234/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xhad1234/alluxio/merges","archive_url":"https://api.github.com/repos/xhad1234/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xhad1234/alluxio/downloads","issues_url":"https://api.github.com/repos/xhad1234/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/xhad1234/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/xhad1234/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/xhad1234/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xhad1234/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/xhad1234/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/xhad1234/alluxio/deployments","created_at":"2016-05-16T22:10:01Z","updated_at":"2016-05-16T22:10:06Z","pushed_at":"2016-06-22T19:14:20Z","git_url":"git://github.com/xhad1234/alluxio.git","ssh_url":"git@github.com:xhad1234/alluxio.git","clone_url":"https://github.com/xhad1234/alluxio.git","svn_url":"https://github.com/xhad1234/alluxio","homepage":"http://www.alluxio.org/","size":54832,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"3f1ecba460cc38c0db0a68d48a8e2b638aa7a66f","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Memory Speed Virtual Distributed Storage System","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2016-06-22T21:47:05Z","pushed_at":"2016-06-22T22:48:16Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":87337,"stargazers_count":2414,"watchers_count":2414,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1001,"mirror_url":null,"open_issues_count":27,"forks":1001,"open_issues":27,"watchers":2414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/3555"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3555"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/3555/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/3555/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/5bc9df64c784ff7d31f3887f423342e62f7aaeee"}}}}
{"actor":{"display_login":"xhad1234"}}