{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/54733869","id":54733869,"diff_hunk":"@@ -11943,7 +11945,16 @@ void HqlCppTranslator::buildFunctionDefinition(IHqlExpression * funcdef)\n         if (languageAttr)\n             buildScriptFunctionDefinition(funcctx, funcdef, proto);\n         else\n-            buildCppFunctionDefinition(funcctx, bodyCode, proto);\n+        {\n+            bool isInline = bodyCode->hasAttribute(inlineAtom);\n+            if (isInline)","path":"ecl/hqlcpp/hqlcpp.cpp","position":16,"original_position":16,"commit_id":"48eff44873afe92588e139efd93cbb88b2dae67b","original_commit_id":"48eff44873afe92588e139efd93cbb88b2dae67b","user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"body":"This also needs to be conditional on \r\n(translator.queryOptions().spanMultipleCpp - otherwise if you are generating into a single c++ file the function never appears.\r\n","created_at":"2016-03-02T15:00:23Z","updated_at":"2016-03-02T15:00:23Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8285#discussion_r54733869","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/54733869"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8285#discussion_r54733869"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285","id":61223735,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8285","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8285.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8285.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8285","number":8285,"state":"open","locked":false,"title":"HPCC-2819 Would be nice to be able to add inline qualifier to embedc++","user":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"body":"Add support for inline C++.\r\n\r\nUsage\r\n    Resulttype funcname ( parameterlist ) := EMBED( C++ : INLINE )\r\n\r\nNote: feature added to EMBED(C++) rather than EMBEDC++ so that 'INLINE' may be specified in the attribute list","created_at":"2016-03-01T10:46:32Z","updated_at":"2016-03-02T15:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd23238581dffed8705872d044e32059b1cc7f3c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8285/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/48eff44873afe92588e139efd93cbb88b2dae67b","head":{"label":"shamser:issue2819_inline","ref":"issue2819_inline","sha":"48eff44873afe92588e139efd93cbb88b2dae67b","user":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"repo":{"id":32939247,"name":"HPCC-Platform","full_name":"shamser/HPCC-Platform","owner":{"login":"shamser","id":11410590,"avatar_url":"https://avatars.githubusercontent.com/u/11410590?v=3","gravatar_id":"","url":"https://api.github.com/users/shamser","html_url":"https://github.com/shamser","followers_url":"https://api.github.com/users/shamser/followers","following_url":"https://api.github.com/users/shamser/following{/other_user}","gists_url":"https://api.github.com/users/shamser/gists{/gist_id}","starred_url":"https://api.github.com/users/shamser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamser/subscriptions","organizations_url":"https://api.github.com/users/shamser/orgs","repos_url":"https://api.github.com/users/shamser/repos","events_url":"https://api.github.com/users/shamser/events{/privacy}","received_events_url":"https://api.github.com/users/shamser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shamser/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/shamser/HPCC-Platform","forks_url":"https://api.github.com/repos/shamser/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/shamser/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shamser/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shamser/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/shamser/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/shamser/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/shamser/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/shamser/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/shamser/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shamser/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/shamser/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/shamser/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/shamser/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/shamser/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/shamser/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/shamser/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/shamser/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/shamser/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/shamser/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/shamser/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shamser/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/shamser/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shamser/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/shamser/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/shamser/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/shamser/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/shamser/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shamser/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/shamser/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/shamser/HPCC-Platform/deployments","created_at":"2015-03-26T16:34:05Z","updated_at":"2016-01-18T14:01:23Z","pushed_at":"2016-03-01T17:22:47Z","git_url":"git://github.com/shamser/HPCC-Platform.git","ssh_url":"git@github.com:shamser/HPCC-Platform.git","clone_url":"https://github.com/shamser/HPCC-Platform.git","svn_url":"https://github.com/shamser/HPCC-Platform","homepage":"track.hpccsystems.com","size":171460,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-6.0.0","ref":"candidate-6.0.0","sha":"c165e6324b3dcecea8ce892d13f62c258e7e1c7c","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2016-03-02T01:49:31Z","pushed_at":"2016-03-02T14:18:06Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":193888,"stargazers_count":268,"watchers_count":268,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":426,"forks":134,"open_issues":426,"watchers":268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/8285"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8285"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8285/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8285/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/48eff44873afe92588e139efd93cbb88b2dae67b"}}}}