{"action":"created","issue":{"url":"https://api.github.com/repos/PopulateTools/gobierto/issues/194","repository_url":"https://api.github.com/repos/PopulateTools/gobierto","labels_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/194/comments","events_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/194/events","html_url":"https://github.com/PopulateTools/gobierto/pull/194","id":197367104,"number":194,"title":"Gobierto People module (first iteration)","user":{"login":"danguita","id":126392,"avatar_url":"https://avatars.githubusercontent.com/u/126392?v=3","gravatar_id":"","url":"https://api.github.com/users/danguita","html_url":"https://github.com/danguita","followers_url":"https://api.github.com/users/danguita/followers","following_url":"https://api.github.com/users/danguita/following{/other_user}","gists_url":"https://api.github.com/users/danguita/gists{/gist_id}","starred_url":"https://api.github.com/users/danguita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danguita/subscriptions","organizations_url":"https://api.github.com/users/danguita/orgs","repos_url":"https://api.github.com/users/danguita/repos","events_url":"https://api.github.com/users/danguita/events{/privacy}","received_events_url":"https://api.github.com/users/danguita/received_events","type":"User","site_admin":false},"labels":[{"id":484033113,"url":"https://api.github.com/repos/PopulateTools/gobierto/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-23T13:11:02Z","updated_at":"2016-12-30T09:35:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PopulateTools/gobierto/pulls/194","html_url":"https://github.com/PopulateTools/gobierto/pull/194","diff_url":"https://github.com/PopulateTools/gobierto/pull/194.diff","patch_url":"https://github.com/PopulateTools/gobierto/pull/194.patch"},"body":"Connects to #190.\r\n\r\n### Review notes\r\n\r\nI'm not deploying this code to Staging since we're taking advantage of the PostgreSQL JSONB data type to store and query unstructured data, so we would need to upgrade our PostgreSQL instances to 9.4+ to release these changes.\r\n\r\nPlease note that we were using PostgreSQL 9.6.1 in development env (the latest release available at that time) until we decide the version to go in production. Let's take it into account to keep exactly the same version in every environment. i.e. production, staging, development and test.\r\n\r\n---\r\n\r\n### What does this PR do?\r\n\r\nThis PR introduces the new `gobierto-people` module and implements a first iteration in the Admin (`gobierto-admin`) namespace, mainly focused in back-end and architecture. It also implements a new component called `DynamicContent`, that The DynamicContent which allows managing schema free content blocks via a collection of helpers that significantly ease the integration process.\r\n\r\nThis component is key and will be extensively used in this new module, for now. Many other details on the implementation can be found in the doc that comes with this PR: https://github.com/PopulateTools/gobierto/blob/3556c523e1e65d50f5fd9e15762d1ed5a262afcb/docs/dynamic-content-component.md\r\n\r\nAny new strings are being localised into the three languages available now. I tried to do my best with the Catalan translations, but once again I'd need some help from my beloved @ferblape. Most of the strings are already localised, but there're some in which I had doubts 😛 \r\n\r\n---\r\n\r\n### How should this be manually tested?\r\n\r\nFirst, run migrations and re-seed the database to make sure the new `GobiertoPeople` module is reachable via the `madrid.gobierto.dev` Site in the left sidebar.\r\n\r\nHaving http://gobierto.dev/admin/people/people as the main entry point for this feature, let's check that:\r\n\r\n- [x] A Person can be created.\r\n- [x] A Person can be updated.\r\n- [x] New (dynamic content) fields can be added in this context.\r\n- [x] A new Content block can be created.\r\n- [x] A Content block can be updated, by changing its title and any of its fields' properties.\r\n- [x] New fields can be added or deleted in a Content block context.\r\n- [x] A Content block can be deleted as well.\r\n- [x] Everything is localised.\r\n- [x] There's a good test coverage for every new part!\r\n\r\n---\r\n\r\n#### ✏️ Missing stuff\r\n\r\n- Integrate the latest front-end from https://github.com/PopulateTools/gobierto/pull/188.\r\n- Extend the `GobiertoPeople::Person` resource by adding new fields present in the latest specification.\r\n- Limit the Content block management options to privileged Admin users (Manager).\r\n- Continue developing the rest of resources at `Person` level such as Events, Statements and Posts.\r\n"},"comment":{"url":"https://api.github.com/repos/PopulateTools/gobierto/issues/comments/269750987","html_url":"https://github.com/PopulateTools/gobierto/pull/194#issuecomment-269750987","issue_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/194","id":269750987,"user":{"login":"ferblape","id":17616,"avatar_url":"https://avatars.githubusercontent.com/u/17616?v=3","gravatar_id":"","url":"https://api.github.com/users/ferblape","html_url":"https://github.com/ferblape","followers_url":"https://api.github.com/users/ferblape/followers","following_url":"https://api.github.com/users/ferblape/following{/other_user}","gists_url":"https://api.github.com/users/ferblape/gists{/gist_id}","starred_url":"https://api.github.com/users/ferblape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferblape/subscriptions","organizations_url":"https://api.github.com/users/ferblape/orgs","repos_url":"https://api.github.com/users/ferblape/repos","events_url":"https://api.github.com/users/ferblape/events{/privacy}","received_events_url":"https://api.github.com/users/ferblape/received_events","type":"User","site_admin":false},"created_at":"2016-12-30T09:35:09Z","updated_at":"2016-12-30T09:35:09Z","body":"- All checks completed successfully\r\n- Code review 👌 \r\n\r\nAs we discussed, we'll wait until we have a newer Postgres version in production to merge it.\r\n\r\nThanks!"}}
{"actor":{"display_login":"ferblape"}}