{"action":"created","issue":{"url":"https://api.github.com/repos/warseph/soap-as-promised/issues/9","repository_url":"https://api.github.com/repos/warseph/soap-as-promised","labels_url":"https://api.github.com/repos/warseph/soap-as-promised/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/warseph/soap-as-promised/issues/9/comments","events_url":"https://api.github.com/repos/warseph/soap-as-promised/issues/9/events","html_url":"https://github.com/warseph/soap-as-promised/pull/9","id":191115298,"number":9,"title":"Added object check before adding raw response property","user":{"login":"davegriff","id":12398198,"avatar_url":"https://avatars.githubusercontent.com/u/12398198?v=3","gravatar_id":"","url":"https://api.github.com/users/davegriff","html_url":"https://github.com/davegriff","followers_url":"https://api.github.com/users/davegriff/followers","following_url":"https://api.github.com/users/davegriff/following{/other_user}","gists_url":"https://api.github.com/users/davegriff/gists{/gist_id}","starred_url":"https://api.github.com/users/davegriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegriff/subscriptions","organizations_url":"https://api.github.com/users/davegriff/orgs","repos_url":"https://api.github.com/users/davegriff/repos","events_url":"https://api.github.com/users/davegriff/events{/privacy}","received_events_url":"https://api.github.com/users/davegriff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-22T20:25:25Z","updated_at":"2016-11-22T20:52:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/warseph/soap-as-promised/pulls/9","html_url":"https://github.com/warseph/soap-as-promised/pull/9","diff_url":"https://github.com/warseph/soap-as-promised/pull/9.diff","patch_url":"https://github.com/warseph/soap-as-promised/pull/9.patch"},"body":"If soap method does not return an object the existing implementation fails because trying to add a prototype/field to a value type (i.e. string).   So that an existing soap user can wrap with soap-as-promised ok, I've kept the return value as-is rather than creating a wrapper object (like with null values)."},"comment":{"url":"https://api.github.com/repos/warseph/soap-as-promised/issues/comments/262362132","html_url":"https://github.com/warseph/soap-as-promised/pull/9#issuecomment-262362132","issue_url":"https://api.github.com/repos/warseph/soap-as-promised/issues/9","id":262362132,"user":{"login":"davegriff","id":12398198,"avatar_url":"https://avatars.githubusercontent.com/u/12398198?v=3","gravatar_id":"","url":"https://api.github.com/users/davegriff","html_url":"https://github.com/davegriff","followers_url":"https://api.github.com/users/davegriff/followers","following_url":"https://api.github.com/users/davegriff/following{/other_user}","gists_url":"https://api.github.com/users/davegriff/gists{/gist_id}","starred_url":"https://api.github.com/users/davegriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegriff/subscriptions","organizations_url":"https://api.github.com/users/davegriff/orgs","repos_url":"https://api.github.com/users/davegriff/repos","events_url":"https://api.github.com/users/davegriff/events{/privacy}","received_events_url":"https://api.github.com/users/davegriff/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T20:52:24Z","updated_at":"2016-11-22T20:52:24Z","body":"Sorry, it's not in the case of an empty or null response, but for simple return types (i.e. string).  If a soap function only returns a simple response (i.e. it's not a complex type/object), then node-soap only returns the value of that property, not an object.  Although, the documentation says that it will return an object, but it doesn't.  \r\n\r\nI will add a test for the case.  \r\n"}}
{"actor":{"display_login":"davegriff"}}