He stayed with the Ibrox club for 21 years until retiring in 1915, was part of Rangers' treble-winning (Scottish Football League title, Glasgow Cup and Glasgow Merchants Charity Cup) teams of 1896–97, 1899–1900 and 1910–11, and played in 69 of the club's 74 matches during their run of four consecutive championships from 1898 to 1902.
He remained affiliated with the Ibrox club for 21 years until his retirement in 1915, was a member of Rangers' triumphant teams that won the Scottish Football League title, Glasgow Cup, and Glasgow Merchants Charity Cup from 1896 to 1902, and participated in 69 of the club's 74 matches during their four consecutive championship runs from 1898 to 1902.