From 1962 to 1993 he was Professor of Scottish History and Literature at the University of Glasgow.
He served as a Professor of Scottish History and Literature at the University of Glasgow from 1962 to 1993.