After spells at Dennistoun and Alexandra Athletic, the latter for whom he also served as general secretary, he joined Rangers in 1882. During his time at Rangers, he won his only cap for Scotland, and scored twice in 5–0 win over Ireland on 26 January 1884.
He started his professional career with temporary assignments at Dennistoun and Alexandra Athletic, where he also handled administrative duties. He then joined Rangers in 1882, achieving his sole international appearance for Scotland and scoring twice in a convincing 5–0 win over Ireland on January 26, 1884.