After spells at Dennistoun and Alexandra Athletic, the latter for whom he also served as general secretary, he joined Rangers in 1882. During his time at Rangers, he won his only cap for Scotland, and scored twice in 5–0 win over Ireland on 26 January 1884.
He began his career with brief periods at Dennistoun and Alexandra Athletic, where he also served as the club's administrator. He then moved to Rangers in 1882, where he achieved his sole international appearance for Scotland and scored twice in a decisive 5–0 win over Ireland on January 26, 1884.