[03:43] <Xubuntu_dasads> hello
[03:50] <pleia2> knome: 698 followers! ;)
[05:23] <pleia2> 699!
[05:24] <Unit193> I'm not one of them.
[07:28] <olbi> hello
[07:28] <olbi> I have installed xfce 4.10 pre2 from repo on launchpad and in session-menu I have hibernate, close etc as gray and can't click it
[07:29] <Unit193> This isn't a support channel, hibernate was disabled in P, and 4.10Xfce isn't supported either.
[07:30] <olbi> grrr with hibernate :P it sometimes was helpful :)
[07:32] <Unit193> You can reenable it, it's in the relnotes.
[07:35] <micahg> we should be getting 4.10 for quantal
[07:52] <olbi> I know it, but 12.04 is LTS :)
[07:54] <micahg> olbi: and 4.10 released 3 months late :)
[07:55] <micahg> LTS means bug/security support, not new versions
[08:01] <olbi> micahg: I know it, this is not good for the general reception but we should thx for so many good changes :)
[08:09] <ochosi> hi everyone
[08:29] <olbi> hello ochosi :)
[08:30] <olbi> I have 30 degrees in Lodz, Poland. How is yours? :)
[08:40] <knome> micahg, for the supportability of the lts, i was thinking if it made sense to SRU xfce 4.10 :P
[08:49] <Unit193> With or without him killing you? And I already said it wasn't, you know you don't want to make me wrong.
[08:51] <knome> ;)
[08:53] <ochosi> olbi: 30 as wellhere
[08:53] <micahg> knome: not a chance :)
[08:54] <knome> micahg, really? why not ;)
[08:54] <micahg> I don't even think I'd approve a backport (or would at least have to think about it long and hard)
[08:57] <knome> start thinking :]
[08:59] <micahg> let's get the stack working in quantal first
[09:00] <knome> sure, but if you need a long think... better to start that now ;)
[09:10] <olbi> good that bluebird works good now :D
[09:57] <mr_pouit> o hai
[09:57] <knome> hey mr_pouit
[09:57] <mr_pouit> micahg: yeah, 4.10 in quantal
[09:57] <mr_pouit> and +1, not a chance for the big sru
[09:57] <knome> :|
[09:57] <knome> even if that helped the support burden?
[09:58] <mr_pouit> you need to update all xfce packages, that's a no-no
[09:58] <knome> k
[09:59] <knome> when is the final release of 4.10 in a PPA then :P
[09:59] <knome> people are asking for that *a lot*
[10:03] <mr_pouit> maybe today or tomorrow
[10:03] <mr_pouit> there's no new feature between pre2 and final...
[10:04] <mr_pouit> so people won't see anything new when they already have pre2
[10:04] <mr_pouit> and there's still an upgrade issue I haven't cleared yet (in my ppa, apt will decide to hold back xfce4-session, xfce4-appfinder and xubuntu-desktop, no good)
[10:17] <knome> mr_pouit, yeah. but those who have not installed any ppa yet
[10:18] <knome> mr_pouit, stupid to point them to rc2 now and tell them it's going to change later :/
[10:18] <mr_pouit> or they could wait and profit of 12.04 :}
[10:18] <Unit193> ^
[10:19] <knome> yeah, well...
[10:20] <knome> more people "voiding the warranty", less people to support...
[10:20] <knome> ;)
[10:20] <reon> Hi peoples
[10:23] <reon> Any idea when the 4.10 PPA will be populated? https://launchpad.net/~xubuntu-dev/+archive/xfce-4.10
[10:24] <knome> mr_pouit, as i said... stupid.
[10:24] <knome> reon, soon
[10:26] <reon> knome, :) I got itchy fingers and really keen to try it out. I'm considering building it from the tarballs but I would much rather just use a PPA.
[10:27] <mr_pouit> knome: I can already copy the pre2 packages to the xubuntu-dev ppa, eh
[10:27] <knome> mr_pouit, your choice - if you are sure that doesn't create any regressions, fine
[10:30] <mr_pouit> if I were be sure it didn't create any regression, it would have been in 12.04 :}
[10:30] <knome> heh, yeah...
[10:30] <mr_pouit> of course it will create regressions...
[10:30] <knome> heh :)
[10:30] <knome> in that case, don't
[10:31] <baizon> mr_pouit: why arent you upgrading your ppa from pre2 to final? :P
[10:35] <baizon> mr_pouit: ?
[10:36] <ochosi> oh dear, ubiquity just decided to hang after i pressed the "skip" button (it was downloading stupid language-packs for _ages_ ...)
[10:36]  * ochosi wonders what'll happen if i reboot now
[10:37] <knome> baizon, because he has other things to work on?
[10:37] <baizon> ok :)
[10:39] <mr_pouit> i'm updating the debian packaging now for 4.10 final, then I'll restart my session to test, and then I'll backport that in my ppa
[10:39] <mr_pouit> (insert random bits of real life things between each step)
[10:40]  * knome inserts "step into a dog poo"
[10:40] <baizon> mr_pouit: thanks for the info :)
[10:40] <reon> mr_pouit, which is your PPA?
[10:40] <baizon> reon: https://launchpad.net/~mrpouit/+archive/ppa
[10:41] <reon> Thx, will bookmark it and check it every hour :D
[10:41] <mr_pouit> knome: thanks :>
[10:41] <knome> mr_pouit, np! ;) (you said random...)
[10:50] <ochosi> grmpf, seems like (at least) my menu is borked
[10:52] <knome> ;)
[10:52] <ochosi> wondering whether i should just do another clean install
[10:53] <knome> heh
[10:53] <ochosi> i'm not really looking forward to fixing more random breakage
[10:53] <knome> ochosi, another clean install which you bork by pressing "skip" ?
[10:53] <ochosi> nope, one where i set up better/faster mirrors before installing...
[10:54] <knome> ;)
[22:13] <knome> what's wrong with the person on #xubuntu ?
[22:13] <knome> is he totally drunk?
[22:16] <pleia2> I was hoping for non-native speaker, but they're using a US ISP
[22:16] <pleia2> so... ohio
[22:16] <knome> :|
[22:16] <ochosi> well who knows, there might be non-native speakers living in ohio as well...
[22:16] <knome> can somebody try another approach?
[22:19] <ochosi> knome: sry, you seem to have more energy for that then me (at least today)
[22:19] <knome> meh :)
[22:19] <knome> hi ochosi
[22:20] <ochosi> about albatross, i think it needs to be fixed "from scratch" (as in: like bluebird)
[22:20] <knome> yeah, but if there is a workaround for now, let's use that until we fix it
[22:20] <ochosi> and it was unfinished business anyway, so i'm not a big fan of applying a patch to something that i'll rewrite
[22:20] <ochosi> have you tested the patch?
[22:20] <knome> no, but can do later
[22:21] <ochosi> mkay
[22:21] <ochosi> i honestly haven't looked at it
[22:21] <ochosi> can probably do that later this week
[22:21] <ochosi> still have to set up a wiki-page for sean_d to work on the shortcuts-overlay
[22:22] <knome> yeah
[22:22] <ochosi> and i really don't like using the ubuntu-wiki for that, it's soo slow...
[22:22] <ochosi> (still)
[22:23] <ochosi> not sure i mentioned that already, but i think we should fork unity-greeter for 12.10
[22:23] <knome> it's getting a bit better...
[22:24] <knome> discuss with madnick, i'm ok with it if it looks good
[23:21]  * pleia2 needs to set up a filter for xubuntu wiki alerts
[23:22] <knome> mr_pouit, micahg: note that you are both assignees for including 4.10; https://wiki.ubuntu.com/Xubuntu/Roadmap/Goals/Quantal
[23:22] <knome> pleia2, sorry! ;)
[23:22] <pleia2> :)
[23:22] <knome> mr_pouit, micahg: if you think this is wrong... fight with each other or find other assignees ;))
[23:44] <knome> pleia2, you still there?
[23:46] <pleia2> at work, so "sort of"
[23:47] <knome> heh, ok, a few quick Q's
[23:47] <knome> what do you think of listing only the supported releases at the wiki front, and pointing to wiki/Releases for the rest?
[23:48] <knome> also, do you think we can remove the "Get Involved!" -p from the wiki front, since it's mostly the same as in xubuntu.org? (everything except "you can join xubuntu-users on launchpad")
[23:48] <pleia2> sounds good
[23:48] <pleia2> maybe keep it and link to the website
[23:49] <knome> we do that already, but it's duplicating
[23:49] <pleia2> ah, we do link it, just delete the rest
[23:49] <knome> maybe condense it a bit, then it'd be good ;)
[23:49] <knome> hehe, sure
[23:49] <pleia2> yeah
[23:49] <pleia2> For information on how to contribute, see the Get Involved page of our website.
[23:49] <knome> yeah.
[23:50] <knome> see the "banner" at the top pointing to community help wiki?
[23:50] <knome> what about adding another.
[23:50] <knome> for the link, i mean
[23:50] <pleia2> oh sure
[23:50] <pleia2> that sounds good
[23:50] <pleia2> did you see pretty new help.ubuntu.com/community/ ? :)
[23:50] <pleia2> they haz new theme
[23:51] <knome> ooh
[23:51] <knome> nice
[23:51] <knome> at least that's a bit better ;)
[23:51] <knome> did you see the updated http://xubuntu.org/help/ ?
[23:51] <pleia2> they applied it about a week ago to help.ubuntu proper, I think it was just today that they put it on /community
[23:52] <knome> yeah, i think i've been hitting that site in a week and haven't seen that theme yet
[23:52] <pleia2> I don't remember specifics of /help before (except there was an xchat menu screenshot)
[23:52] <knome> yeah, i condensed it quite a lot
[23:52] <pleia2> good
[23:52] <knome> there was a huge paragraph on technical specifics of mailing lists...
[23:52] <knome> about (un)subscription and all


[08:29] <ridcully1st_> Hello everyone. I have a some problems setting up scim to write chinese on lbuntu 12.04
[08:29] <ridcully1st_> I istalled scim and scim-pinyin and I get the scim steup  window and the icon in taskbar  but when I want to trigger (cntrl+ space)  nothing happens
[08:29] <ridcully1st_> has someone a tip what todo
[11:27] <ridcully1st_> Hello, could someone help me with scim
[12:13] <peazipHelp> hi all, I am trying to use Peazip with lubuntu 12.04. It installs fine, but when i run it, it complains it does not have libgdk_pixbuf-2.0.so.0
[12:13] <peazipHelp> i did a locate and i found it at: /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0. is there a way i can find out where it is looked?
[12:13] <peazipHelp> looking?
[12:13] <peazipHelp> that way i can setup a symlink?
[19:22] <psilo23> so, i finally upgraded to lubuntu 12.04 but whats the difference with 11.10, i dont see any ifference except the software center hehehe
[19:23] <bioterror> LXDM replaced with LightDM and Lubuntu finally supports multiple users
[19:23] <bioterror> like using same computer at the same time
[19:23] <Unit193> http://www.ubuntu.com/getubuntu/releasenotes/1204
[19:23] <Unit193> Awwwh, crap, wrong one.
[19:24] <psilo23> okay i dont use that but alright
[19:24] <bioterror> unit :D
[19:24] <Unit193> https://wiki.ubuntu.com/PrecisePangolin/ReleaseNotes/Lubuntu  (Hay, it redirects there, I was very close)
[19:24] <bioterror> you can now quiet yourself for that mistake
[19:26] <psilo23> well i learned one thing from that site u gave me, lubuntu is not lts, didnt know that one
[19:42] <semitones> hey you guys
[20:28] <SAKKED> bioterror: i thought this 12.04 is still LxDM
[20:28] <Unit193> Nope, Lightdm.
[20:31] <SAKKED> ok
[20:33] <bioterror> change was succesful if people thinks that ;)
[20:34] <Unit193> If you upgraded, you may still have LXDM if that's the one you selected.
[20:34] <Shogoot> hi guys. any of you dare to help me get a green icon on the firewall thingy in AZURE? im working from a lubuntu OS :)
[20:35] <bioterror> fix your router
[20:35] <Unit193> !crosspost | Shogoot
[20:36] <SAKKED> how can i disable workspaces?
[20:36] <Shogoot> -1 to bioterror for not helping at all :P
[20:36] <bioterror> SAKKED, for example from ~/.config/openbox/lubuntu-rc.xml
[20:36] <bioterror> you change workspaces to 1
[20:37] <bioterror> or was it Openbox with the capital O
[20:37] <bioterror> ;)
[20:37] <Shogoot> SAKKED, right click one of the desktops in the taskbar and look in the "desktoppager " option
[20:37] <bioterror> Shogoot, I have quite low intentions to help people to warez stuff
[20:37] <SAKKED> aaaa
[20:37] <SAKKED> ok
[20:38] <bioterror> but make port forward
[20:38] <SAKKED> i just clicked and changed it
[20:38] <SAKKED> pretty easy
[20:38] <SAKKED> im using LXDM
[20:38] <SAKKED> atm
[20:38] <SAKKED> looks pretty nice
[20:38] <SAKKED> i like this moore than the original
[20:39] <Shogoot> whatever sakked you just do your no-helpfull thing
[20:40] <Shogoot> sorry menat bioterror xD
[20:41] <Shogoot> meant*
[20:52] <Shogoot> Think i got it right now :)
[20:53] <Shogoot> Another question. Is it possible to share folders from lubuntu with a win7 machine on the same network?
[20:54] <Unit193> Yep.
[20:54] <Shogoot> Is taht using samba, ans straight forward?
[20:55] <Unit193> Well you can rsync, scp, sshfs, and samba (think SSHFS would work, but may well not)
[20:55] <Unit193> !samba
[20:56] <Shogoot> so samba has the msot support from microsoft?
[20:57] <Unit193> Yep.
[20:58] <hal14450> i wouldn't exactly say it's supported
[20:58] <Unit193> Works the best with rather.
[21:01] <Shogoot> was it not possible to right click a folder and "share it?"
[21:01] <Shogoot> or is that ubuntu only?
[21:01] <hal14450> Unit193, agreed it's probably the best option
[21:01] <Shogoot> rather? what is that?
[21:01] <Unit193> Shogoot: Not that I know of.
[21:02] <Unit193> hal14450: Yeah, that's how I read the question, thanks.
[21:03] <hal14450> Unit193, sorry if that came off as confrontational it just reminded me of a talk i attended at a linux conference
[21:03] <Unit193> Na, it's great.
[21:06] <hal14450> Jeremy Allison gave the talk I saw and he did mention how difficult it was at the time to keep samba working but you're right they do a good job of it
[21:09] <hal14450> sshfs works best for my needs but that's mainly due to being lazy about running anything else when ssh can do what i want
[21:11] <Unit193> scp is great for a couple files, and rsync is great for backup along with larger amounts.
[21:12] <bioterror> and samba is great for the ease of doing HTPC shares, I find it even easier than NFS ;)
[21:12] <hal14450> rsync is my tool of choice for anything larger than a few files otherwise i generally use mc
[21:12] <bioterror> and there's not huge difference in speed between samba and nfs than what it's like between samba and scp
[21:13] <Unit193> bioterror: Yep, only time I ever used NFS was on XP. :P  (Not with a linux box either)
[21:13] <hal14450> i gave up on NFS as it isn't as kind when the wifi connection drops as sshfs is
[21:14] <hal14450> as far as htpc goes mine recently overheated :(
[21:14] <Shogoot> So help me a bit here. I managed to get access to my lubuntumachine that has a folde ri shared... its visible from win7
[21:15] <hal14450> it was ~11yrs old so it's doubtful i'll want to fix it
[21:15] <Shogoot> what i cant get to work is the ctrl-x to move a file from the folder to win7
[21:15] <Shogoot> even i have given write/read in the samba
[21:15] <Shogoot> must i chmod the folder?
[21:23] <Unit193> Well it is in fact another user trying to edit files.
[21:54] <Dice-Man> hi
[21:54] <Dice-Man> i've installed ssh
[21:54] <Dice-Man> but it doesn't run at system startup
[21:54] <Dice-Man> i'm forced to pass by command line shell
[21:54] <hal14450> lsof -i |grep ssh says?
[21:55] <Dice-Man> at present moment i've make a sudo service ssh start
[21:55] <Dice-Man> so the service is up and running
[21:55] <Dice-Man> it says nothing
[21:58] <Dice-Man> are there any way to edit the init script ?
[21:58] <Dice-Man> and therefore launch ssh early ?
[21:59] <hal14450> it should run at boot time if you've set it properly
[22:00] <hal14450> you won't get anything from that command unless you run it as sudo sorry
[22:02] <Dice-Man> there are no clues to start ssh at startup ??
[22:02] <hal14450> i'm actually having a bit of a brain fart as to what file to edit to make sure it runs at startup
[22:02] <Dice-Man> it was automatically configurated before
[22:03] <hal14450> /etc/default/<something> was my first guess
[22:03] <hal14450> this is what i get for not using it and thus losing it knowledge wise
[22:04] <Unit193> What package exactly did you install?
[22:05] <hal14450> perhaps it's just in /etc/ssh/sshd_config
[22:29] <Dice-Man> Unit193: openssh-server
[22:29] <Dice-Man> with apt-get
[22:30] <VanKush> hello folks, please how can I configure which x session will be assumed by default?
[22:31] <VanKush> after I installed lubunu-desktop meta package in Precise, my KDM got flooded with 10+ openbox related entries, and Gnome-session (stressing that I have no gnome installed) was set default
[22:31] <VanKush> so if I do not select kde or lxde session manually, I hit an error anytime I log on
[22:33] <Unit193> That's not normal at all, and Lubuntu is the normal session.
[22:36] <VanKush> I would suppose so as well
[22:36] <VanKush> yet my priority is to select KDE Plasma session as default again
[23:35] <Dice-Man> Unit193: ping ?
[23:36] <Dice-Man> update-rc.d doesn't run :(
[23:38] <bkm> I mouse-dragged a terminal window so that the bar was behind lxpanel. would there have been a way to get to it without killing lxpanel (which is what i did)?
[23:39] <Unit193> Alt+tab to it and then alt+space m  for move
[23:39] <Unit193> Dice-Man: "Doesn't run"?
[23:40] <Dice-Man> doesn't work
[23:40] <Dice-Man> :)
[23:40] <Dice-Man> sorry my english
[23:40] <Unit193> !dontwork
[23:40] <Unit193> sudo update-rc.d ssh enable   or something like that.
[23:40] <Dice-Man> okay i see
[23:41] <Dice-Man> update-rc.d ssh defaults
[23:41] <Dice-Man> then reboot
[23:41] <Dice-Man> ssh doesn't start automatically
[23:41] <Dice-Man> always forced to start it with sudo service ssh start
[23:41] <Unit193> Did you ever try    sudo dpkg-reconfigure openssh-server    ?
[23:42] <Dice-Man> well no
[23:43] <Dice-Man> i'm trying sudo apt-get install ssh
[23:43] <Dice-Man> it contains the server and the client
[23:43] <Dice-Man> maybe the installation do the right scripts for auto start ?
[23:45] <Unit193> openssh-server did it for me.
[23:50] <Dice-Man> i'm trying dpk reconfigure...
[23:55] <Dice-Man> doesn't work :(


[01:53] <duanedesign> d'oh, I just realized Bruno Maag was at UDS-N and I didnt get to meet him :\
[01:53] <duanedesign> as a graphic designer i must say that would of been awesome
[12:09] <ivanka> thorwil: hi
[12:10] <thorwil> hi ivanka
[12:11] <ivanka> thorwil: I was going to ask you where to file a bug but I found it! Please ignore my interruption :-)
[12:12] <thorwil> ivanka: no worries. still curious what project
[12:34] <ivanka> thorwil: https://bugs.launchpad.net/buttons/+bug/673488
[12:34] <ubot2> Launchpad bug 673488 in buttons "screenshots.ubuntu.com needs styling (affects: 1) (heat: 8)" [Medium,New]
[12:39] <thorwil> interesting
[12:40] <thorwil> ivanka: why co-branding, if the entire point of that site are ubuntu-specific screenshots?
[12:40] <ivanka> thorwil: well, there seemed to be some debian packages too which weren't ubuntu specific
[12:41] <ivanka> thorwil: can I take it from your question that this is an acceptable way to put out a piece of work?
[12:41] <ivanka> :-)
[12:42] <thorwil> ivanka: well, it needs to hit the mailing list or at least team subscribers
[12:43] <ivanka> thorwil: I was going to send it to the artwork list and then we can agree how to subscribe people?
[12:44] <thorwil> ivanka: manual mail to the list and asking people to subscribe to the report if interested might be a good policy
[12:45] <ivanka> thorwil: cool. One more question - if you go to that project, can you see the other bug I put in there?
[12:47] <thorwil> ivanka: do you mean https://bugs.launchpad.net/buttons/+bug/673494 ?
[12:47] <ubot2> Launchpad bug 673494 in buttons "Screenshots campaign (affects: 1) (heat: 8)" [Undecided,New]
[12:47] <ivanka> thorwil: yes - perfect


[08:59] <al-maisan> intellectronica and henninge: when you open up shop please note that the branch in the queue fixes a release-critical bug.
[09:29] <al-maisan> henninge: when you open up shop please note that the branch in the queue fixes a release-critical bug
[09:47] <henninge> al-maisan: oh right, I am OCR today! ;)
[09:47] <al-maisan> henninge: :)
[09:48] <henninge> Shop's open. Please feel free to stroll around and look at the offerings, I'll be with you soon.
[09:57] <henninge> noodles775: I just requested an r-c review from you. Please feel free to ask me about it when you get to it.
[09:58] <noodles775> henninge: will do.
[10:17] <henninge> al-maisan:  The branch looks really good but I am wondering about test coverage.
[10:17] <al-maisan> henninge: aha
[10:17] <al-maisan> henninge: do you think it needs more/different testing?
[10:19] <henninge> al-maisan: I am just wondering if it would be possible to extend the test to test the case where the user has permission to upload to a series other than currentseries.
[10:19] <al-maisan> henninge: I can do that, no problem at all.
[10:19] <henninge> al-maisan: currently it only tests "allowed for currentseries, denied for others"
[10:19] <henninge> al-maisan: cool, I'd feel much better about that.
[10:20] <al-maisan> henninge: I'll ping you with the incremental diff in a few minutes.
[10:20] <henninge> al-maisan: did you already run the test suite on this? I am surprised that no other tests need to be adapted.
[10:21] <al-maisan> henninge: package sets are a pretty narrow niche .. but I will run the package upload tests as well .. thanks for pointing this out!
[10:24] <henninge> al-maisan: np
[10:25] <henninge> al-maisan: one last issue. I am not familiar with _schema_circular_imports.py but I think I see what it does.
[10:26] <al-maisan> henninge: it's the avoidance of circular imports..
[10:28] <henninge> al-maisan: yes, so I gathered. I am just trying to figure out how it works.
[10:28] <henninge> al-maisan: I trust, though, that this is correct the way you did it, so no real issue for the review.
[10:28] <henninge> ;-)
[10:29] <al-maisan> the LP API metadata is manipulated afterwards out of the interface declaration scope
[10:29] <al-maisan> henninge: thanks
[10:33] <henninge> al-maisan: np, r=me
[10:33] <henninge> (what I meant)
[10:33] <al-maisan> henninge: thank you very much indeed.
[11:50] <stub> henninge: https://code.edge.launchpad.net/~stub/launchpad/replication/+merge/14155 is an rc canditate
[11:52] <al-maisan> hello henninge, I needed to tidy up a few things to get the requested tests to work: http://pastebin.ubuntu.com/307456/
[11:52] <al-maisan> henninge: just want to make sure you approve of these changes as well
[11:53] <henninge> al-maisan: I understand
[11:53] <al-maisan> thanks
[11:53] <henninge> stub: I am onto yours next.
[11:53] <al-maisan> henninge: I also ran all package upload and archive related tests to make sure nothing breaks.
[11:54] <henninge> cool
[12:00] <henninge> al-maisan: so you had to make these changes just to be able to extend the test in this way?
[12:01] <al-maisan> henninge: yes, in order to manipulate archive permissions based on package sets, I needed to change the API to pass the package sets as opposed to their names.
[12:01] <al-maisan> that was the main change really.
[12:03] <henninge> al-maisan: btw, you seem to be using the API exclusively to test this. Is there a reason for that?
[12:04] <al-maisan> henninge: yes, this functionality is presently only exposed via the LP API.
[12:04] <henninge> al-maisan: ah
[12:04] <al-maisan> the UI is still to come
[12:05] <henninge> al-maisan: and now a packageset can only be passed in as an object, not represented by its name, as used to be the case, right?
[12:05] <al-maisan> henninge: yes, the reason being that package names are *not* globally unique any more
[12:06] <al-maisan> now, the combination of a package set name and a distro series is unique
[12:06] <al-maisan> s/package names/package set names/
[12:07] <henninge> al-maisan: ah, I understand.
[12:07] <al-maisan> I could have added a 'distroseries' parameter but I thought it was more straight-forward to just pass in the package set *object*
[12:08] <henninge> al-maisan: but shouldn't there be some obsolete code now, that did the lookup from name to object?
[12:09] <al-maisan> henninge: let me check quickly
[12:11] <al-maisan> henninge: good catch, the ArchivePermission._nameToPackageset() method is now superfluous.
[12:13] <al-maisan> henninge: http://pastebin.ubuntu.com/307472/
[12:18] <al-maisan> henninge: actually .. on a second thought .. scratch that .. the methods involved are internal (as in not exposed via the LP API) and it may still be OK to pass in package sets or package set names in this case.
[12:18] <al-maisan> the methods involved = the IArchivePermission methods in the most recent diff
[12:21] <al-maisan> henninge: hrm .. this is a bit complicated .. I guess one important aspect is that IArchivePermission methods are exposed *indirectly* via the IArchive LP API and that's where some of the confusion arose
[12:21] <henninge> al-maisan: sorry, team call atm. Won't be long.
[12:21] <al-maisan> henninge: cool.
[12:47] <henninge> al-maisan: so, your patch remains as it was, right?
[12:48] <al-maisan> henninge: yep
[12:49] <al-maisan> henninge: this change is still required: http://pastebin.ubuntu.com/307456/
[12:50] <henninge> al-maisan: yeah, I believe you ... ;-)
[12:50] <henninge> al-maisan: and the new test looks very good! Thanks for adding that!
[12:50] <henninge> al-maisan: still r=me
[12:50] <al-maisan> henninge: thank you for prodding me :)
[12:50] <henninge> ;)
[12:50] <al-maisan> .. and thanks for the review
[12:50] <henninge> np
[12:53]  * henninge lunches
[13:44] <al-maisan> hello henninge-lunch, I have another release critical branch that needs a review: https://code.edge.launchpad.net/~al-maisan/launchpad/sync-470411/+merge/14301
[13:44] <al-maisan> henninge-lunch: believe it or not but it's a 1-liner :)
[14:14] <henninge> al-maisan: done, r=me
[14:15] <al-maisan> henninge: thanks a million :)
[14:15] <henninge> al-maisan: nee, war doch nur *eine* Zeile! ;-)
[14:15] <al-maisan> aha :)
[14:15] <henninge> al-maisan: eine Million Zeilen hätte ich abgelehnt ...
[14:16] <al-maisan> henninge: ich hätte es Dir nicht 'mal übelgenommen :)
[15:41] <wgrant> jml: Can you please review https://code.edge.launchpad.net/~wgrant/launchpad/distroseries-source-format-selection-db/+merge/14304?
[15:58] <danilos> henninge, abentley: mine are not RC-candidates, so do give precedence to what is :)
[16:24] <henninge> danilos: I don't see why strip_last_newline is needed?
[16:25] <danilos> henninge, because gazillion of tests would have to be changed if it was something like rstrip("\r\n")
[16:25] <henninge> danilos: ;-)
[16:25] <danilos> henninge, well, not gazillion, but something like 4 very obscure tests, and if it was just .strip(), then something around 14 :)
[16:26] <henninge> danilos: ok, but my hunch was correct, that rstrip would be enough to do what you need!
[16:26] <danilos> henninge, also, .rstrip() strips all final newlines, and with some comments, whitespace should stay there
[16:27] <danilos> henninge, almost, I started with that, but tests correctly brought header comments to my attention, and they usually have a few newlines before the initial message, and I feel they belong there :)
[16:30] <danilos> henninge, I would have changed the few tests if it were not for these cases where we should keep extra newlines
[16:34] <henninge> danilos: sorry, phone call
[16:34] <danilos> henninge, was it for me?
[16:35] <henninge> danilos: ;-)
[16:35] <henninge> danilos: no, it was my dad
[16:36] <henninge> danilos: the other thing: strip_last_newline is testing for all versions of line breaks, but you only do split("\n") eventually.
[16:36] <danilos> henninge, oh, ok then :)
[16:37] <henninge> danilos: is there a magic in there that I forget that does line break type detection?
[16:37] <danilos> henninge, well, I don't have to fix all problems with that code? also, .split("\n") would work correctly with DOS-style line endings as well
[16:38] <danilos> henninge, and no, there isn't anything special that you are missing
[16:38] <henninge> >>> "Henning\r\nEggers".split("\n")
[16:38] <henninge> ['Henning\r', 'Eggers']
[16:38] <danilos> henninge, see :)
[16:38] <henninge> danilos: if you are fine with that behaviour ...
[16:38] <danilos> henninge, now, you can insert "#" in front of 'Henning\r' and 'Eggers' and it'll be fine
[16:39] <danilos> henninge, we've got another set of bugs for dealing with \r's, but I am not touching those right now :)
[16:40] <henninge> danilos: ok, ok. r=me
[16:42] <danilos> henninge, thanks
[18:03] <sinzui> abentley: I have an rc-candidate to fix a problem with the product-release-finder: https://code.edge.launchpad.net/~sinzui/launchpad/prf-files/+merge/14311
[18:04] <sinzui> oh, that is a bad diff
[18:04]  * sinzui deletes and tries again
[18:29] <sinzui> abentley: RC candidate: https://code.edge.launchpad.net/~sinzui/launchpad/prf-files/+merge/14312
[19:38] <abentley> sinzui: r=me.
[19:38] <sinzui> thanks
[19:38] <abentley> sinzui: You should make two separate review requests, one for RC one for code.
[19:38] <sinzui> yes, you are right
[19:39] <sinzui> I added RC so that you would see it should hop in front of non-rc branches
[19:40] <abentley> sinzui: If you requested an RC review from flacoste, I would see that also.
[19:40] <sinzui> I see that I was not thinking
[19:40] <abentley> sinzui: Since I can't provide an "rc code" review, the Canonical Launchpad Engineering review request will never be satisfied.
[19:41] <flacoste> sinzui: do you have a r-c review request for me?
[19:42] <abentley> flacoste: We were discussing https://code.edge.launchpad.net/~sinzui/launchpad/prf-files/+merge/14312