test/property_test.c:243: error: BUFFER_OVERRUN_L3
  Offset: [2, +oo] Size: [1, 11] by call to `ossl_method_store_add`.
Showing all 25 steps of the trace


test/property_test.c:229:9: Array declaration
227.           char *impl;
228.       } impls[] = {
229.           { 6, "position=1", "a" },
               ^
230.           { 6, "position=2", "b" },
231.           { 6, "position=3", "c" },

test/property_test.c:243:14: Call
241.   
242.       for (i = 0; i < OSSL_NELEM(impls); i++)
243.           if (!TEST_true(ossl_method_store_add(store, impls[i].nid, impls[i].prop,
                    ^
244.                                                impls[i].impl, NULL))) {
245.               TEST_note("iteration %zd", i + 1);

crypto/property/property.c:176:1: Parameter `*properties`
  174.   }
  175.   
  176. > int ossl_method_store_add(OSSL_METHOD_STORE *store,
  177.                             int nid, const char *properties,
  178.                             void *method, void (*method_destruct)(void *))

crypto/property/property.c:205:28: Call
  203.       ossl_method_cache_flush(store, nid);
  204.       if ((impl->properties = ossl_prop_defn_get(store->ctx, properties)) == NULL) {
  205.           impl->properties = ossl_parse_property(store->ctx, properties);
                                    ^
  206.           if (impl->properties == NULL)
  207.               goto err;

crypto/property/property_parse.c:329:1: Parameter `*defn`
    327.   }
    328.   
    329. > OSSL_PROPERTY_LIST *ossl_parse_property(OPENSSL_CTX *ctx, const char *defn)
    330.   {
    331.       PROPERTY_DEFINITION *prop = NULL;

crypto/property/property_parse.c:334:5: Assignment
    332.       OSSL_PROPERTY_LIST *res = NULL;
    333.       STACK_OF(PROPERTY_DEFINITION) *sk;
    334.       const char *s = defn;
               ^
    335.       int done;
    336.   

crypto/property/property_parse.c:340:9: Call
    338.           return NULL;
    339.   
    340.       s = skip_space(s);
                   ^
    341.       done = *s == '\0';
    342.       while (!done) {

crypto/property/property_parse.c:52:1: Parameter `*s`
      50.   DEFINE_STACK_OF(PROPERTY_DEFINITION)
      51.   
      52. > static const char *skip_space(const char *s)
      53.   {
      54.       while (ossl_isspace(*s))

crypto/property/property_parse.c:56:5: Assignment
      54.       while (ossl_isspace(*s))
      55.           s++;
      56.       return s;
                ^
      57.   }
      58.   

crypto/property/property_parse.c:340:5: Assignment
    338.           return NULL;
    339.   
    340.       s = skip_space(s);
               ^
    341.       done = *s == '\0';
    342.       while (!done) {

crypto/property/property_parse.c:350:14: Call
    348.           memset(&prop->v, 0, sizeof(prop->v));
    349.           prop->optional = 0;
    350.           if (!parse_name(ctx, &s, 1, &prop->name_idx))
                        ^
    351.               goto err;
    352.           prop->oper = PROPERTY_OPER_EQ;

crypto/property/property_parse.c:83:1: Parameter `**t`
      81.   }
      82.   
      83. > static int parse_name(OPENSSL_CTX *ctx, const char *t[], int create,
      84.                         OSSL_PROPERTY_IDX *idx)
      85.   {

crypto/property/property_parse.c:358:13: Call
    356.               goto err;
    357.           }
    358.           if (match_ch(&s, '=')) {
                       ^
    359.               if (!parse_value(ctx, &s, prop, 1)) {
    360.                   ERR_raise_data(ERR_LIB_PROP, PROP_R_NO_VALUE,

crypto/property/property_parse.c:59:1: Parameter `**t`
      57.   }
      58.   
      59. > static int match_ch(const char *t[], char m)
      60.   {
      61.       const char *s = *t;

crypto/property/property_parse.c:359:18: Call
    357.           }
    358.           if (match_ch(&s, '=')) {
    359.               if (!parse_value(ctx, &s, prop, 1)) {
                            ^
    360.                   ERR_raise_data(ERR_LIB_PROP, PROP_R_NO_VALUE,
    361.                                  "HERE-->%s", start);

crypto/property/property_parse.c:254:1: Parameter `**t`
      252.   }
      253.   
      254. > static int parse_value(OPENSSL_CTX *ctx, const char *t[],
      255.                          PROPERTY_DEFINITION *res, int create)
      256.   {

crypto/property/property_parse.c:257:5: Assignment
      255.                          PROPERTY_DEFINITION *res, int create)
      256.   {
      257.       const char *s = *t;
                 ^
      258.       int r = 0;
      259.   

crypto/property/property_parse.c:261:9: Assignment
      259.   
      260.       if (*s == '"' || *s == '\'') {
      261.           s++;
                     ^
      262.           r = parse_string(ctx, &s, s[-1], res, create);
      263.       } else if (*s == '+') {

crypto/property/property_parse.c:262:13: Call
      260.       if (*s == '"' || *s == '\'') {
      261.           s++;
      262.           r = parse_string(ctx, &s, s[-1], res, create);
                         ^
      263.       } else if (*s == '+') {
      264.           s++;

crypto/property/property_parse.c:190:1: Parameter `**t`
        188.   }
        189.   
        190. > static int parse_string(OPENSSL_CTX *ctx, const char *t[], char delim,
        191.                           PROPERTY_DEFINITION *res, const int create)
        192.   {

crypto/property/property_parse.c:194:5: Assignment
        192.   {
        193.       char v[1000];
        194.       const char *s = *t;
                   ^
        195.       size_t i = 0;
        196.       int err = 0;

crypto/property/property_parse.c:216:10: Call
        214.           res->v.str_val = ossl_property_value(ctx, v, create);
        215.       }
        216.       *t = skip_space(s + 1);
                        ^
        217.       res->type = PROPERTY_TYPE_STRING;
        218.       return !err;

crypto/property/property_parse.c:52:1: <Length trace>
50.   DEFINE_STACK_OF(PROPERTY_DEFINITION)
51.   
52. > static const char *skip_space(const char *s)
53.   {
54.       while (ossl_isspace(*s))

crypto/property/property_parse.c:52:1: Parameter `*s`
          50.   DEFINE_STACK_OF(PROPERTY_DEFINITION)
          51.   
          52. > static const char *skip_space(const char *s)
          53.   {
          54.       while (ossl_isspace(*s))

crypto/property/property_parse.c:54:12: Array access: Offset: [2, +oo] Size: [1, 11] by call to `ossl_method_store_add` 
          52.   static const char *skip_space(const char *s)
          53.   {
          54.       while (ossl_isspace(*s))
                           ^
          55.           s++;
          56.       return s;

static const char *skip_space(const char *s)
{
    while (ossl_isspace(*s))
        s++;
    return s;
}
['static int test_register_deregister(void)\n{\n    static const struct {\n        int nid;\n        const char *prop;\n        char *impl;\n    } impls[] = {\n        { 6, "position=1", "a" },\n        { 6, "position=2", "b" },\n        { 6, "position=3", "c" },\n        { 6, "position=4", "d" },\n    };\n    size_t i;\n    int ret = 0;\n    OSSL_METHOD_STORE *store;\n    if (!TEST_ptr(store = ossl_method_store_new(NULL))\n        || !add_property_names("position", NULL))\n        goto err;\n    for (i = 0; i < OSSL_NELEM(impls); i++)\n        if (!TEST_true(ossl_method_store_add(store, impls[i].nid, impls[i].prop,\n                                             impls[i].impl, NULL))) {\n            TEST_note("iteration %zd", i + 1);\n            goto err;\n        }\n    for (i = 0; i < OSSL_NELEM(impls); i++) {\n        const size_t j = (1 + i * 3) % OSSL_NELEM(impls);\n        int nid = impls[j].nid;\n        void *impl = impls[j].impl;\n        if (!TEST_true(ossl_method_store_remove(store, nid, impl))\n            || !TEST_false(ossl_method_store_remove(store, nid, impl))) {\n            TEST_note("iteration %zd, position %zd", i + 1, j + 1);\n            goto err;\n        }\n    }\n    if (TEST_false(ossl_method_store_remove(store, impls[0].nid, impls[0].impl)))\n        ret = 1;\nerr:\n    ossl_method_store_free(store);\n    return ret;\n}', 'int ossl_method_store_add(OSSL_METHOD_STORE *store,\n                          int nid, const char *properties,\n                          void *method, void (*method_destruct)(void *))\n{\n    ALGORITHM *alg = NULL;\n    IMPLEMENTATION *impl;\n    int ret = 0;\n    if (nid <= 0 || method == NULL || store == NULL)\n        return 0;\n    if (properties == NULL)\n        properties = "";\n    impl = OPENSSL_malloc(sizeof(*impl));\n    if (impl == NULL)\n        return 0;\n    impl->method = method;\n    impl->method_destruct = method_destruct;\n    ossl_property_write_lock(store);\n    ossl_method_cache_flush(store, nid);\n    if ((impl->properties = ossl_prop_defn_get(store->ctx, properties)) == NULL) {\n        impl->properties = ossl_parse_property(store->ctx, properties);\n        if (impl->properties == NULL)\n            goto err;\n        ossl_prop_defn_set(store->ctx, properties, impl->properties);\n    }\n    alg = ossl_method_store_retrieve(store, nid);\n    if (alg == NULL) {\n        if ((alg = OPENSSL_zalloc(sizeof(*alg))) == NULL\n                || (alg->impls = sk_IMPLEMENTATION_new_null()) == NULL\n                || (alg->cache = lh_QUERY_new(&query_hash, &query_cmp)) == NULL)\n            goto err;\n        alg->nid = nid;\n        if (!ossl_method_store_insert(store, alg))\n            goto err;\n    }\n    if (sk_IMPLEMENTATION_push(alg->impls, impl))\n        ret = 1;\n    ossl_property_unlock(store);\n    if (ret == 0)\n        impl_free(impl);\n    return ret;\nerr:\n    ossl_property_unlock(store);\n    alg_cleanup(0, alg);\n    impl_free(impl);\n    return 0;\n}', 'OSSL_PROPERTY_LIST *ossl_parse_property(OPENSSL_CTX *ctx, const char *defn)\n{\n    PROPERTY_DEFINITION *prop = NULL;\n    OSSL_PROPERTY_LIST *res = NULL;\n    STACK_OF(PROPERTY_DEFINITION) *sk;\n    const char *s = defn;\n    int done;\n    if (s == NULL || (sk = sk_PROPERTY_DEFINITION_new(&pd_compare)) == NULL)\n        return NULL;\n    s = skip_space(s);\n    done = *s == \'\\0\';\n    while (!done) {\n        const char *start = s;\n        prop = OPENSSL_malloc(sizeof(*prop));\n        if (prop == NULL)\n            goto err;\n        memset(&prop->v, 0, sizeof(prop->v));\n        prop->optional = 0;\n        if (!parse_name(ctx, &s, 1, &prop->name_idx))\n            goto err;\n        prop->oper = PROPERTY_OPER_EQ;\n        if (prop->name_idx == 0) {\n            ERR_raise_data(ERR_LIB_PROP, PROP_R_PARSE_FAILED,\n                           "Unknown name HERE-->%s", start);\n            goto err;\n        }\n        if (match_ch(&s, \'=\')) {\n            if (!parse_value(ctx, &s, prop, 1)) {\n                ERR_raise_data(ERR_LIB_PROP, PROP_R_NO_VALUE,\n                               "HERE-->%s", start);\n                goto err;\n            }\n        } else {\n            prop->type = PROPERTY_TYPE_STRING;\n            prop->v.str_val = ossl_property_true;\n        }\n        if (!sk_PROPERTY_DEFINITION_push(sk, prop))\n            goto err;\n        prop = NULL;\n        done = !match_ch(&s, \',\');\n    }\n    if (*s != \'\\0\') {\n        ERR_raise_data(ERR_LIB_PROP, PROP_R_TRAILING_CHARACTERS,\n                       "HERE-->%s", s);\n        goto err;\n    }\n    res = stack_to_property_list(sk);\nerr:\n    OPENSSL_free(prop);\n    sk_PROPERTY_DEFINITION_pop_free(sk, &pd_free);\n    return res;\n}', 'static const char *skip_space(const char *s)\n{\n    while (ossl_isspace(*s))\n        s++;\n    return s;\n}', 'static int parse_name(OPENSSL_CTX *ctx, const char *t[], int create,\n                      OSSL_PROPERTY_IDX *idx)\n{\n    char name[100];\n    int err = 0;\n    size_t i = 0;\n    const char *s = *t;\n    int user_name = 0;\n    for (;;) {\n        if (!ossl_isalpha(*s)) {\n            ERR_raise_data(ERR_LIB_PROP, PROP_R_NOT_AN_IDENTIFIER,\n                           "HERE-->%s", *t);\n            return 0;\n        }\n        do {\n            if (i < sizeof(name) - 1)\n                name[i++] = ossl_tolower(*s);\n            else\n                err = 1;\n        } while (*++s == \'_\' || ossl_isalnum(*s));\n        if (*s != \'.\')\n            break;\n        user_name = 1;\n        if (i < sizeof(name) - 1)\n            name[i++] = *s;\n        else\n            err = 1;\n        s++;\n    }\n    name[i] = \'\\0\';\n    if (err) {\n        ERR_raise_data(ERR_LIB_PROP, PROP_R_NAME_TOO_LONG, "HERE-->%s", *t);\n        return 0;\n    }\n    *t = skip_space(s);\n    *idx = ossl_property_name(ctx, name, user_name && create);\n    return 1;\n}', 'static int match_ch(const char *t[], char m)\n{\n    const char *s = *t;\n    if (*s == m) {\n        *t = skip_space(s + 1);\n        return 1;\n    }\n    return 0;\n}', 'static int parse_value(OPENSSL_CTX *ctx, const char *t[],\n                       PROPERTY_DEFINITION *res, int create)\n{\n    const char *s = *t;\n    int r = 0;\n    if (*s == \'"\' || *s == \'\\\'\') {\n        s++;\n        r = parse_string(ctx, &s, s[-1], res, create);\n    } else if (*s == \'+\') {\n        s++;\n        r = parse_number(&s, res);\n    } else if (*s == \'-\') {\n        s++;\n        r = parse_number(&s, res);\n        res->v.int_val = -res->v.int_val;\n    } else if (*s == \'0\' && s[1] == \'x\') {\n        s += 2;\n        r = parse_hex(&s, res);\n    } else if (*s == \'0\' && ossl_isdigit(s[1])) {\n        s++;\n        r = parse_oct(&s, res);\n    } else if (ossl_isdigit(*s)) {\n        return parse_number(t, res);\n    } else if (ossl_isalpha(*s))\n        return parse_unquoted(ctx, t, res, create);\n    if (r)\n        *t = s;\n    return r;\n}', 'static int parse_string(OPENSSL_CTX *ctx, const char *t[], char delim,\n                        PROPERTY_DEFINITION *res, const int create)\n{\n    char v[1000];\n    const char *s = *t;\n    size_t i = 0;\n    int err = 0;\n    while (*s != \'\\0\' && *s != delim) {\n        if (i < sizeof(v) - 1)\n            v[i++] = *s;\n        else\n            err = 1;\n        s++;\n    }\n    if (*s == \'\\0\') {\n        ERR_raise_data(ERR_LIB_PROP, PROP_R_NO_MATCHING_STRING_DELIMETER,\n                       "HERE-->%c%s", delim, *t);\n        return 0;\n    }\n    v[i] = \'\\0\';\n    if (err) {\n        ERR_raise_data(ERR_LIB_PROP, PROP_R_STRING_TOO_LONG, "HERE-->%s", *t);\n    } else {\n        res->v.str_val = ossl_property_value(ctx, v, create);\n    }\n    *t = skip_space(s + 1);\n    res->type = PROPERTY_TYPE_STRING;\n    return !err;\n}']