test/bntest.c:1995: error: BUFFER_OVERRUN_L3
  Offset added: [8, +oo] Size: [0, 67108856] by call to `BN_rand_range`.
Showing all 26 steps of the trace


test/bntest.c:1992:13: Call
1990.           || !TEST_ptr(rng = BN_new())
1991.           || !TEST_ptr(val = BN_new())
1992.           || !TEST_true(BN_set_word(rng, range)))
                    ^
1993.           goto err;
1994.       for (i = 0; i < iterations; i++) {

crypto/bn/bn_lib.c:368:15: Assignment
  366.       a->neg = 0;
  367.       a->d[0] = w;
  368.       a->top = (w ? 1 : 0);
                       ^
  369.       a->flags &= ~BN_FLG_FIXED_TOP;
  370.       bn_check_top(a);

crypto/bn/bn_lib.c:368:5: Assignment
  366.       a->neg = 0;
  367.       a->d[0] = w;
  368.       a->top = (w ? 1 : 0);
             ^
  369.       a->flags &= ~BN_FLG_FIXED_TOP;
  370.       bn_check_top(a);

test/bntest.c:1995:14: Call
1993.           goto err;
1994.       for (i = 0; i < iterations; i++) {
1995.           if (!TEST_true(BN_rand_range(val, rng))
                     ^
1996.               || !TEST_uint_lt(v = (unsigned int)BN_get_word(val), range))
1997.               goto err;

crypto/bn/bn_rand.c:177:1: Parameter `r->top`
  175.   }
  176.   
  177. > int BN_rand_range(BIGNUM *r, const BIGNUM *range)
  178.   {
  179.       return bnrand_range(NORMAL, r, range);

crypto/bn/bn_rand.c:179:12: Call
  177.   int BN_rand_range(BIGNUM *r, const BIGNUM *range)
  178.   {
  179.       return bnrand_range(NORMAL, r, range);
                    ^
  180.   }
  181.   

crypto/bn/bn_rand.c:113:1: Parameter `r->top`
    111.   
    112.   /* random number r:  0 <= r < range */
    113. > static int bnrand_range(BNRAND_FLAG flag, BIGNUM *r, const BIGNUM *range)
    114.   {
    115.       int n;

crypto/bn/bn_rand.c:128:9: Call
    126.   
    127.       if (n == 1)
    128.           BN_zero(r);
                   ^
    129.       else if (!BN_is_bit_set(range, n - 2) && !BN_is_bit_set(range, n - 3)) {
    130.           /*

crypto/bn/bn_lib.c:361:1: Parameter `a->top`
      359.   }
      360.   
      361. > int BN_set_word(BIGNUM *a, BN_ULONG w)
      362.   {
      363.       bn_check_top(a);

crypto/bn/bn_lib.c:364:9: Call
      362.   {
      363.       bn_check_top(a);
      364.       if (bn_expand(a, (int)sizeof(BN_ULONG) * 8) == NULL)
                     ^
      365.           return 0;
      366.       a->neg = 0;

crypto/bn/bn_lcl.h:660:1: Parameter `a->top`
        658.                            const BIGNUM *add, const BIGNUM *rem, BN_CTX *ctx);
        659.   
        660. > static ossl_inline BIGNUM *bn_expand(BIGNUM *a, int bits)
        661.   {
        662.       if (bits > (INT_MAX - BN_BITS2 + 1))

crypto/bn/bn_lcl.h:668:12: Call
        666.           return a;
        667.   
        668.       return bn_expand2((a),(bits+BN_BITS2-1)/BN_BITS2);
                          ^
        669.   }
        670.   

crypto/bn/bn_lib.c:245:1: Parameter `b->top`
          243.    */
          244.   
          245. > BIGNUM *bn_expand2(BIGNUM *b, int words)
          246.   {
          247.       if (words > b->dmax) {

crypto/bn/bn_lib.c:248:23: Call
          246.   {
          247.       if (words > b->dmax) {
          248.           BN_ULONG *a = bn_expand_internal(b, words);
                                       ^
          249.           if (!a)
          250.               return NULL;

crypto/bn/bn_lib.c:209:1: <Offset trace>
207.   /* This is used by bn_expand2() */
208.   /* The caller MUST check that words > b->dmax before calling this */
209. > static BN_ULONG *bn_expand_internal(const BIGNUM *b, int words)
210.   {
211.       BN_ULONG *a = NULL;

crypto/bn/bn_lib.c:209:1: Parameter `b->top`
            207.   /* This is used by bn_expand2() */
            208.   /* The caller MUST check that words > b->dmax before calling this */
            209. > static BN_ULONG *bn_expand_internal(const BIGNUM *b, int words)
            210.   {
            211.       BN_ULONG *a = NULL;

crypto/bn/bn_lib.c:209:1: <Length trace>
207.   /* This is used by bn_expand2() */
208.   /* The caller MUST check that words > b->dmax before calling this */
209. > static BN_ULONG *bn_expand_internal(const BIGNUM *b, int words)
210.   {
211.       BN_ULONG *a = NULL;

crypto/bn/bn_lib.c:209:1: Parameter `words`
            207.   /* This is used by bn_expand2() */
            208.   /* The caller MUST check that words > b->dmax before calling this */
            209. > static BN_ULONG *bn_expand_internal(const BIGNUM *b, int words)
            210.   {
            211.       BN_ULONG *a = NULL;

crypto/bn/bn_lib.c:224:13: Call
            222.           a = OPENSSL_secure_zalloc(words * sizeof(*a));
            223.       else
            224.           a = OPENSSL_zalloc(words * sizeof(*a));
                               ^
            225.       if (a == NULL) {
            226.           BNerr(BN_F_BN_EXPAND_INTERNAL, ERR_R_MALLOC_FAILURE);

crypto/mem.c:228:1: Parameter `num`
              226.   }
              227.   
              228. > void *CRYPTO_zalloc(size_t num, const char *file, int line)
              229.   {
              230.       void *ret = CRYPTO_malloc(num, file, line);

crypto/mem.c:230:17: Call
              228.   void *CRYPTO_zalloc(size_t num, const char *file, int line)
              229.   {
              230.       void *ret = CRYPTO_malloc(num, file, line);
                                     ^
              231.   
              232.       FAILTEST();

crypto/mem.c:201:9: Assignment
                199.   
                200.       if (num == 0)
                201.           return NULL;
                               ^
                202.   
                203.       FAILTEST();

crypto/mem.c:230:5: Assignment
              228.   void *CRYPTO_zalloc(size_t num, const char *file, int line)
              229.   {
              230.       void *ret = CRYPTO_malloc(num, file, line);
                         ^
              231.   
              232.       FAILTEST();

crypto/mem.c:235:5: Assignment
              233.       if (ret != NULL)
              234.           memset(ret, 0, num);
              235.       return ret;
                         ^
              236.   }
              237.   

crypto/bn/bn_lib.c:224:9: Assignment
            222.           a = OPENSSL_secure_zalloc(words * sizeof(*a));
            223.       else
            224.           a = OPENSSL_zalloc(words * sizeof(*a));
                           ^
            225.       if (a == NULL) {
            226.           BNerr(BN_F_BN_EXPAND_INTERNAL, ERR_R_MALLOC_FAILURE);

crypto/bn/bn_lib.c:232:9: Array access: Offset added: [8, +oo] Size: [0, 67108856] by call to `BN_rand_range` 
            230.       assert(b->top <= words);
            231.       if (b->top > 0)
            232.           memcpy(a, b->d, sizeof(*a) * b->top);
                           ^
            233.   
            234.       return a;

static BN_ULONG *bn_expand_internal(const BIGNUM *b, int words)
{
    BN_ULONG *a = NULL;
    if (words > (INT_MAX / (4 * BN_BITS2))) {
        BNerr(BN_F_BN_EXPAND_INTERNAL, BN_R_BIGNUM_TOO_LONG);
        return NULL;
    }
    if (BN_get_flags(b, BN_FLG_STATIC_DATA)) {
        BNerr(BN_F_BN_EXPAND_INTERNAL, BN_R_EXPAND_ON_STATIC_BIGNUM_DATA);
        return NULL;
    }
    if (BN_get_flags(b, BN_FLG_SECURE))
        a = OPENSSL_secure_zalloc(words * sizeof(*a));
    else
        a = OPENSSL_zalloc(words * sizeof(*a));
    if (a == NULL) {
        BNerr(BN_F_BN_EXPAND_INTERNAL, ERR_R_MALLOC_FAILURE);
        return NULL;
    }
    assert(b->top <= words);
    if (b->top > 0)
        memcpy(a, b->d, sizeof(*a) * b->top);
    return a;
}
['static int test_rand_range(int n)\n{\n    const unsigned int range = rand_range_cases[n].range;\n    const unsigned int iterations = rand_range_cases[n].iterations;\n    const double critical = rand_range_cases[n].critical;\n    const double expected = iterations / (double)range;\n    double sum = 0;\n    BIGNUM *rng = NULL, *val = NULL;\n    size_t *counts;\n    unsigned int i, v;\n    int res = 0;\n    if (!TEST_ptr(counts = OPENSSL_zalloc(sizeof(*counts) * range))\n        || !TEST_ptr(rng = BN_new())\n        || !TEST_ptr(val = BN_new())\n        || !TEST_true(BN_set_word(rng, range)))\n        goto err;\n    for (i = 0; i < iterations; i++) {\n        if (!TEST_true(BN_rand_range(val, rng))\n            || !TEST_uint_lt(v = (unsigned int)BN_get_word(val), range))\n            goto err;\n        counts[v]++;\n    }\n    TEST_note("range %u  iterations %u  critical %.4f", range, iterations,\n              critical);\n    if (range < 20) {\n        TEST_note("frequencies (expected %.2f)", expected);\n        for (i = 0; i < range; i++)\n            TEST_note("    %2u  %6zu", i, counts[i]);\n    }\n    for (i = 0; i < range; i++) {\n        const double delta = counts[i] - expected;\n        sum += delta * delta;\n    }\n    sum /= expected;\n    TEST_note("test statistic %.4f", sum);\n    if (TEST_double_lt(sum, critical))\n        res = 1;\nerr:\n    BN_free(rng);\n    BN_free(val);\n    OPENSSL_free(counts);\n    return res;\n}', 'int BN_set_word(BIGNUM *a, BN_ULONG w)\n{\n    bn_check_top(a);\n    if (bn_expand(a, (int)sizeof(BN_ULONG) * 8) == NULL)\n        return 0;\n    a->neg = 0;\n    a->d[0] = w;\n    a->top = (w ? 1 : 0);\n    a->flags &= ~BN_FLG_FIXED_TOP;\n    bn_check_top(a);\n    return 1;\n}', 'int BN_rand_range(BIGNUM *r, const BIGNUM *range)\n{\n    return bnrand_range(NORMAL, r, range);\n}', 'static int bnrand_range(BNRAND_FLAG flag, BIGNUM *r, const BIGNUM *range)\n{\n    int n;\n    int count = 100;\n    if (range->neg || BN_is_zero(range)) {\n        BNerr(BN_F_BNRAND_RANGE, BN_R_INVALID_RANGE);\n        return 0;\n    }\n    n = BN_num_bits(range);\n    if (n == 1)\n        BN_zero(r);\n    else if (!BN_is_bit_set(range, n - 2) && !BN_is_bit_set(range, n - 3)) {\n        do {\n            if (!bnrand(flag, r, n + 1, BN_RAND_TOP_ANY, BN_RAND_BOTTOM_ANY))\n                return 0;\n            if (BN_cmp(r, range) >= 0) {\n                if (!BN_sub(r, r, range))\n                    return 0;\n                if (BN_cmp(r, range) >= 0)\n                    if (!BN_sub(r, r, range))\n                        return 0;\n            }\n            if (!--count) {\n                BNerr(BN_F_BNRAND_RANGE, BN_R_TOO_MANY_ITERATIONS);\n                return 0;\n            }\n        }\n        while (BN_cmp(r, range) >= 0);\n    } else {\n        do {\n            if (!bnrand(flag, r, n, BN_RAND_TOP_ANY, BN_RAND_BOTTOM_ANY))\n                return 0;\n            if (!--count) {\n                BNerr(BN_F_BNRAND_RANGE, BN_R_TOO_MANY_ITERATIONS);\n                return 0;\n            }\n        }\n        while (BN_cmp(r, range) >= 0);\n    }\n    bn_check_top(r);\n    return 1;\n}', 'static ossl_inline BIGNUM *bn_expand(BIGNUM *a, int bits)\n{\n    if (bits > (INT_MAX - BN_BITS2 + 1))\n        return NULL;\n    if (((bits+BN_BITS2-1)/BN_BITS2) <= (a)->dmax)\n        return a;\n    return bn_expand2((a),(bits+BN_BITS2-1)/BN_BITS2);\n}', 'BIGNUM *bn_expand2(BIGNUM *b, int words)\n{\n    if (words > b->dmax) {\n        BN_ULONG *a = bn_expand_internal(b, words);\n        if (!a)\n            return NULL;\n        if (b->d) {\n            OPENSSL_cleanse(b->d, b->dmax * sizeof(b->d[0]));\n            bn_free_d(b);\n        }\n        b->d = a;\n        b->dmax = words;\n    }\n    return b;\n}', 'static BN_ULONG *bn_expand_internal(const BIGNUM *b, int words)\n{\n    BN_ULONG *a = NULL;\n    if (words > (INT_MAX / (4 * BN_BITS2))) {\n        BNerr(BN_F_BN_EXPAND_INTERNAL, BN_R_BIGNUM_TOO_LONG);\n        return NULL;\n    }\n    if (BN_get_flags(b, BN_FLG_STATIC_DATA)) {\n        BNerr(BN_F_BN_EXPAND_INTERNAL, BN_R_EXPAND_ON_STATIC_BIGNUM_DATA);\n        return NULL;\n    }\n    if (BN_get_flags(b, BN_FLG_SECURE))\n        a = OPENSSL_secure_zalloc(words * sizeof(*a));\n    else\n        a = OPENSSL_zalloc(words * sizeof(*a));\n    if (a == NULL) {\n        BNerr(BN_F_BN_EXPAND_INTERNAL, ERR_R_MALLOC_FAILURE);\n        return NULL;\n    }\n    assert(b->top <= words);\n    if (b->top > 0)\n        memcpy(a, b->d, sizeof(*a) * b->top);\n    return a;\n}', 'void *CRYPTO_zalloc(size_t num, const char *file, int line)\n{\n    void *ret = CRYPTO_malloc(num, file, line);\n    FAILTEST();\n    if (ret != NULL)\n        memset(ret, 0, num);\n    return ret;\n}', 'void *CRYPTO_malloc(size_t num, const char *file, int line)\n{\n    void *ret = NULL;\n    INCREMENT(malloc_count);\n    if (malloc_impl != NULL && malloc_impl != CRYPTO_malloc)\n        return malloc_impl(num, file, line);\n    if (num == 0)\n        return NULL;\n    FAILTEST();\n    if (allow_customize) {\n        allow_customize = 0;\n    }\n#if !defined(OPENSSL_NO_CRYPTO_MDEBUG) && !defined(FIPS_MODE)\n    if (call_malloc_debug) {\n        CRYPTO_mem_debug_malloc(NULL, num, 0, file, line);\n        ret = malloc(num);\n        CRYPTO_mem_debug_malloc(ret, num, 1, file, line);\n    } else {\n        ret = malloc(num);\n    }\n#else\n    (void)(file); (void)(line);\n    ret = malloc(num);\n#endif\n    return ret;\n}']