
Keep It Simple, Stupid

Comment on


Your inconsistent indention makes it very hard to read, but it seems that's still not the entire script. At least there are unclosed curly braces.

You don't seem to keep references to Spreadsheet::ParseExcel objects, so unless your version of that module is very old, no memory should leak from here.

One thing I do notice is that $materialmapping_table_xml will continually grow, and there's not much you can do about it, except moving to a solution that writes each $materialmapping_item to a file, and then stops keeping it in memory.

In reply to Re^5: Delete parse data spreadsheet::parseexcel by moritz
in thread Delete parse data spreadsheet::parseexcel by cibien

and:  <code> code here </code>

  • Please read these before you post! —
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Log In?

    What's my password?
    Create A New User
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others avoiding work at the Monastery: (3)
    As of 2013-12-21 02:05 GMT
    Find Nodes?
      Voting Booth?

      How do you parse XML?

      Results (434 votes), past polls