path: root/security/smack/smack.h
diff options
authorCasey Schaufler <casey@schaufler-ca.com>2012-05-23 17:46:58 -0700
committerCasey Schaufler <casey@schaufler-ca.com>2012-07-13 15:49:23 -0700
commiteb982cb4cf6405b97ea1f9e1d10864981f269d46 (patch)
tree8d89448e0ef96d587ea8052021a721e632b4b318 /security/smack/smack.h
parent417c6c8ee2eb6975f357d8975af94ba5fbeaf82d (diff)
Smack: fix smack_new_inode bogosities
In January of 2012 Al Viro pointed out three bits of code that he titled "new_inode_smack bogosities". This patch repairs these errors. 1. smack_sb_kern_mount() included a NULL check that is impossible. The check and NULL case are removed. 2. smack_kb_kern_mount() included pointless locking. The locking is removed. Since this is the only place that lock was used the lock is removed from the superblock_smack structure. 3. smk_fill_super() incorrectly and unnecessarily set the Smack label for the smackfs root inode. The assignment has been removed. Targeted for git://gitorious.org/smack-next/kernel.git Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Diffstat (limited to 'security/smack/smack.h')
1 files changed, 0 insertions, 1 deletions
index cc361b8f3d13..76feb31eb823 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -43,7 +43,6 @@ struct superblock_smack {
char *smk_hat;
char *smk_default;
int smk_initialized;
- spinlock_t smk_sblock; /* for initialization */
struct socket_smack {