Opened 14 years ago

Closed 14 years ago

#2915 closed defect (fixed)

Connection sound plays multiple times

Reported by: lanky Owned by: nobody
Milestone: Adium X 1.0 Component: Adium Core
Version: Severity: normal
Keywords: Cc:
Patch Status:


When I connect usually my AIM and ICQ accounts connect before my MSN account, and as a result the sound that plays when I connect plays twice. Any way to fix this so that the sound only plays once when I tell all three accounts to connect at the same time?

Change History (11)

comment:1 Changed 14 years ago by Peter Hosey

you want it to play after the third account connects?

comment:2 Changed 14 years ago by Evan Schoenberg

Resolution: worksforme
Status: newclosed

If they connect in rapid succession, you get one sound. If there is time between the connections, you get multiple sounds.

comment:3 Changed 14 years ago by lanky

Well they're supposed to connect in multiple succession, but there is a one or two second gap between my AIM/ICQ accounts connecting and my MSN account connecting, even if all of them are set to connect at once, so the sound plays twice. Its especially annoying with mine since I'm playing a soundbyte a couple seconds long and the dialogue cuts out halfway through and restarts.

comment:4 Changed 14 years ago by Evan Schoenberg

Unfortunately, we're looking at a tradeoff; Adium has no way of knowing, when your first account connects, that any of the other ones will succeed. To perfectly only send 1 alert / play 1 sound, Adium would have to wait a potentially infinite amount of time. To perfectly alert you of an account connecting, Adium would have to send the notification immediately.

Right now we group all account connection events within a 2 second period. Could you provide some timing data, over a number of connect cycles, as to how far removed these two are for you?

comment:5 Changed 14 years ago by lanky

I ran some tests and it looks like it's taking between 3 and 4 seconds on average for my MSN to connect after my ICQ connects. Every once in awhile (maybe one in five times) the sound plays once, but in general, it's playing twice. A simple fix might be to extend the connection event period to 4 or 5 seconds. I can't really see a downside to extending it a couple seconds.

comment:6 Changed 14 years ago by David Munch

On a slower machine this happens a lot. Especially with lots of people on your IM lists. Boosting it to 5 seconds would be great.

comment:7 Changed 14 years ago by Evan Schoenberg

5 seconds is long, I think; if you connect just one account, it seems weird to wait 5 seconds after it connects to receive any notification. Let's try 4.

comment:8 Changed 14 years ago by Evan Schoenberg

Milestone: Adium X 1.0

comment:9 Changed 14 years ago by anonymous

What if the script was written in such a way that the sound plays immediately upon the first connection, and then doesn't play again if another account connects within the five seconds?

comment:10 Changed 14 years ago by Evan Schoenberg

Resolution: worksforme
Status: closedreopened

That's what it does, anonymous.

comment:11 Changed 14 years ago by Evan Schoenberg

Resolution: fixed
Status: reopenedclosed

In ([15103]): Upped the account event grouping interval to 4 seconds. Fixes #2915

Note: See TracTickets for help on using tickets.