[00:00:16] Thanx for the link. Anyway, this is all new to me..Just created the account.. Bout an hour ago actually. The thing is.. It says that my account is active on 5 project sites and I have no idea how to change that.. [00:00:31] of course, it may be different for SVGs (what I'm looking at currently) [00:01:39] frksand89: you might want to try asking on wikimedia-tech or wikipedia-en [02:46:32] TimStarling: there are scripts for everything you need to do in ldap [02:46:43] TimStarling: it's *very* rare to need to make an ldif [02:46:50] modify-ldap-group will work [02:47:09] if there's a command to do it locally on the system, there should be a script to do it too [06:20:36] New review: Tim Starling; "void append_char(char* s, char c) {" [analytics/udp-filters] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/3222 [08:12:44] * RoanKattouw grabs a drink and sets out to do the largest rebase in his life [08:13:56] RL2 and master have diverged by 219 and 118 commits respectively [08:22:09] wii [08:46:57] Krinkle-away: You here yet? [09:57:28] Krinkle-away: ping? [10:41:26] New review: Hashar; "Marking do not submit for now till I have time to review and actually configure it on Jenkins." [integration/jenkins] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/2289 [10:59:08] RoanKattouw: I have seen your mail about direct push to non master branches [10:59:15] I guess if people want it them so be it [10:59:30] but we probably do not want that on mediawiki/core.git [10:59:45] will review the access rights this afternoon [10:59:45] Why not? [10:59:48] OK [11:00:15] we still have to polish up the workflow with branches [11:00:21] I think Rob has been working on it [11:00:22] and Chad [11:00:27] OK [11:00:32] I'll add RobLa to CC then [11:00:38] might be a good idea [11:00:45] and sumanah :-) [11:00:51] since she is the project manager somehow [11:01:16] meh too late [11:01:18] ahah [11:01:27] it is ok [11:01:39] she is just going to complain about the platform engineering Cabal [11:01:46] ;-D [11:01:51] I was mostly just wondering if there was a technical reason not to do this [11:01:59] none I know of [11:02:05] From a social perspective I don't think it's a problem [11:02:25] merely a question of process. I think we want any submissions to be associated to a change in gerrit [11:02:34] Well still [11:02:44] In order to submit it to master, there has to be a Gerrit change somewhere [11:03:10] yup [11:03:52] So people could submit a merge commit (this is not ideal because Gerrit doesn't display diffs for those, so you can't do inline commenting), or they could squash-merge their branch [11:04:15] I think operations/puppet is configured like you did; Aka you can not push directly to production branch but you can to the test branch. [11:04:38] yeah we disallow merge commit [11:04:57] Are you sure? [11:05:03] https://gerrit.wikimedia.org/r/3854 [11:05:04] overall, we have no idea how to handle working with multiple branches [11:05:16] ohhhhh [11:05:32] To be fair, I am a project owner [11:05:38] So maybe I have special powers in that regard [11:05:59] (FYI, RL2 is a gated working branch for now) [11:06:49] hmm [11:06:53] that is indeed a merge commit [11:07:11] which looks clean to me [11:07:36] couldn't you just rebase RL2 on top of master? [11:07:40] (just wondering) [11:08:40] anyway that is a perfect example to build on [11:09:00] I guess that would help us define a process (or polish the process if it is being written) [11:10:16] lunch time anyway I am starving [11:11:37] I've done that too [11:11:40] Was very tedious [11:11:58] But then I'd have to submit it as a new branch, because we disable force push (with good reason) [12:12:15] RoanKattouw: Hi there [12:12:29] Ohai [12:12:32] I slept in a bit, still have to get used to nl timezone (how ironic) [12:12:36] hehe [12:12:43] And I was up at 7:45 today [12:12:51] wow [12:13:01] I've been up early all week, it's a remnant of my jetlag [12:13:09] And I'm not too eager to get rid of it either, it's useful :) [12:13:16] (otoh I fall over at 9:30pm) [12:13:47] yeah, I would've gone to bed earlier but I didn't fully realized how early 10am was. [12:15:21] checking the task management page now [12:15:31] <^demon> RoanKattouw: Can we upgrade gerrit-dev? [12:15:43] +* (RK) Per-module config in core, apparently Andrew needs it [12:15:46] hm.. [12:16:09] interesting, per-module config for non-gadgets as well I suppose. Configurable from LocalSettings? [12:16:58] ^demon: Feel free [12:17:08] <^demon> 2.3rc0 :D [12:17:23] ^demon: Are you on the project already? If not, tell me and I'll add you [12:17:31] <^demon> Yeah I am. [12:17:48] ^demon: There is a good chance that upgrading gerrit even to the slightest newer version will render the stylesheet useless. I suspect the classnames in gerrit are completely rendered automatically based on whatever is the most common color on the page etc. (not kidding) [12:17:49] <^demon> Now, where is Antoine... [12:18:05] but just on labs [12:18:06] that should be fine [12:18:58] <^demon> Yeah, I really really wanna start playing with 2.3 though :) [12:19:12] <^demon> It's got some must-have features and I plan to upgrade production as soon as we're confident. [12:21:57] k [12:22:46] <^demon> https://gerrit-review.googlesource.com/#/c/33220/9/ReleaseNotes/ReleaseNotes-2.3.txt - planned release notes, worth reading. [12:24:56] issue 203 Create project through web interface [12:26:03] <^demon> There's that :) [12:26:16] <^demon> There's also "Allow superprojects to subscribe to submodules updates" [12:26:18] <^demon> My pet issue [12:26:33] Krinkle: OK, so, RL@ [12:26:34] *RL2 [12:26:43] Yes [12:26:54] I was reading Erik's mail yesterday [12:27:05] Did you see... yes that [12:27:08] And https://gerrit.wikimedia.org/r/3854 [12:27:17] Perhaps we should go for an earlier release that doesn't change much for the user [12:27:26] get the repo and RL-only stuff out first in a stable fashion [12:27:31] (and Special:Gadgets) [12:27:53] A lot of changes are user-facing though [12:27:59] Like the Gadget definition: namespace, Special:Gadgets, etc [12:28:04] Yes [12:28:07] I meant more like no procedural changes [12:28:10] just where what is what [12:28:14] Or well I guess they're administrator-changes [12:28:29] Oh you mean the things that Erik is suggesting? [12:28:31] Or ... what? [12:28:41] Could you give an example of a change that should be excluded? [12:28:56] no not like that [12:29:16] I meant something we might be going to implement, that we should perhaps move to a Gadgets 2.5 plan [12:29:19] like module prefs [12:29:54] which is a fairly major change that is going to add a new feature for gadget writes and also change the interface for users [12:30:25] and I am not fully sure we can get that into a state that we are willing to support into "infinity" [12:30:33] within reasonable time [12:31:10] * Krinkle checks gerrit link [12:31:41] Oh, OK [12:31:43] Yeah that's fair [12:31:44] what ? "splitting of Gadget modules in a scripts module and a style module" [12:31:53] I know you didn't merge it but… that was reverted in trunk, not? [12:31:58] No, it's still in master [12:32:02] Wait [12:32:06] No, I reverted that in master [12:32:15] 9009f36e81b3189ecb0cf77de63924eab25d66a7 (Revert r106007 (Split Gadget modules into two, one for scripts and one for styles): I like the concept of having multiple modules, and I'll probably implement this in the RL2 branch, but this specific implementation has issues (subclassing OutputPage, building its own head items) that were pointed out on CR but never fixed.) [12:32:28] Right, I remember us being fairly clear on that it wasn't done "right" [12:32:37] Yes, but I would like us to do it [12:32:48] Similar thing for skin-specific gadgets [12:33:02] That was implemented right, but the underlying code has been rewritten so much that we'll have to redo it [12:33:10] Yeah [12:33:30] that should be fairly simple to support in the front-end, it's only an addition to Special:Gadgets editor [12:34:02] RoanKattouw: [12:34:02] 294abd1e32b365e1d84e4f7448a8694a1a989b6e (Move styles in gadgets to the top of pages to avoid flash of unstyled content.) [12:34:20] did that end up in 1.19wmf1? I read a bug the other day that seemed like that happened [12:34:29] I don't think so [12:35:01] <^demon> gerrit-dev now running 2.3rc0 [12:35:02] <^demon> :) [12:35:07] !b 35471 | RoanKattouw [12:35:07] RoanKattouw: https://bugzilla.wikimedia.org/show_bug.cgi?id=35471 [12:35:35] <^demon> Sweet! You can disable/hide projects :D [12:35:39] RoanKattouw: the @import bug with concatenating