<< Back to previous view

[CLJS-452] clojure.browser.net: enable WebSockets? Created: 31/Dec/12  Updated: 21/Feb/15  Resolved: 21/Feb/15

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: Linus Ericsson Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: enhancement

clojurescript in browsers, wrapper for Google Closures WebSocket.

Attachments: Text File 0001-enabled-websockets.patch    
Patch: Code


In https://github.com/clojure/clojurescript/blob/master/src/cljs/clojure/browser/net.cljs there's a nicely prepared support for WebSockets with the note

;; WebSocket is not supported in the 3/23/11 release of Google
;; Closure, but will be included in the next release.

is there anything preventing us from enable the support for WebSockets with the next release of ClojureScript?

patch 0001-enable-websockets.patch do just enable the functionality. No test-cases included.

Comment by David Nolen [ 20/Jan/13 12:51 AM ]

Have you verified that this doesn't break browser REPL? Thanks!

Comment by David Nolen [ 21/Feb/15 7:39 AM ]

fixed https://github.com/clojure/clojurescript/commit/ab3c8a5cbb9fb1ccdf7fb9355b8853ebbfc79661

Generated at Sat Aug 27 12:10:03 CDT 2016 using JIRA 4.4#649-r158309.