 During the First World War he served in the Royal Garrison Artillery as a gunner and later as a photographer in the Royal Flying Corps.His older brother was killed during the war.He was official artist to the Botanical Society of Edinburgh and secretary of its offshoot, the Scottish Alpine Botanical Society which combined botany with mountain climbing.